From MAILER-DAEMON Sun Feb 01 12:13:19 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnL8v-0001ao-7d
	for mharc-classpath@gnu.org; Sun, 01 Feb 2004 12:12:21 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnL8d-0001IZ-Cn
	for classpath@gnu.org; Sun, 01 Feb 2004 12:12:03 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AnL7y-0008UN-PP
	for classpath@gnu.org; Sun, 01 Feb 2004 12:11:55 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AnL7n-00087A-HE
	for classpath@gnu.org; Sun, 01 Feb 2004 12:11:11 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AnL7I-0006d2-00; Sun, 01 Feb 2004 18:10:40 +0100
From: Mark Wielaard <mark@klomp.org>
To: Robert Lougher <robert_lougher@hotmail.com>
In-Reply-To: <BAY10-F50bdVJWrGW6E0001b006@hotmail.com>
References: <BAY10-F50bdVJWrGW6E0001b006@hotmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-ZzMpUTW1dmMXFuooId9s"
Message-Id: <1075655468.2102.65.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 01 Feb 2004 18:11:08 +0100
Cc: classpath@gnu.org
Subject: Re: JamVM 1.1.1 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Feb 2004 17:12:14 -0000


--=-ZzMpUTW1dmMXFuooId9s
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 2004-01-27 at 14:09, Robert Lougher wrote:
> I believe a couple of people on this list have at least given JamVM a tes=
t. =20
> In case you're interested, JamVM 1.1.1 is finally out (see=20
> http://jamvm.sourceforge.net).  It's been updated to use Classpath 0.07, =
as=20
> well as using a Java 2 style system class loader as discussed last Decemb=
er=20
> (a new job delayed the release).
> [...]
> Mark mentioned he gave JamVM 1.1.0 a go with the AWT peers.  I haven't ha=
d=20
> any time to do testing with 1.1.1.  However, I'd like to - Is there any t=
est=20
> programs about which gives good coverage?

Very nice! Just tried it out on the Wonka Visual Test Engine (see
http://sources.redhat.com/mauve/ CVS or an older tar ball at
http://www.klomp.org/mark/open-wonka-visualtest.tar.gz). I needed one
small patch for Classpath CVS (see the commit-classpath mailing list)
that might also be needed for 0.07 (I didn't check). Without that patch
you will get the following error when starting up a program that uses
AWT: jamvm: relocation error:
/usr/local/classpath/lib/classpath//libgtkpeer.so: undefined symbol:
g_thread_init

It works nicely. Even the Japanese Business card example looks good (to
the untrained eye that doesn't actually know how a Japanese business
card is supposed to look that is). All in all I am impressed with both
JamVM and the progress that the gtk-peers have made recently!

Cheers,

Mark

--=-ZzMpUTW1dmMXFuooId9s
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAHTMrxVhZCJWr9QwRAlv0AJ4jkUuqBVwfDciORkw/tlHRr+ojiwCcD6CK
BhYJ32SIjIeZo735P5cYcPM=
=8L5y
-----END PGP SIGNATURE-----

--=-ZzMpUTW1dmMXFuooId9s--




From MAILER-DAEMON Sun Feb 01 12:22:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnLIC-0000XE-Dd
	for mharc-classpath@gnu.org; Sun, 01 Feb 2004 12:21:56 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnLHo-0008FL-HR
	for classpath@gnu.org; Sun, 01 Feb 2004 12:21:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AnLGs-0006Yt-Dq
	for classpath@gnu.org; Sun, 01 Feb 2004 12:21:08 -0500
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AnLGl-0006X7-BN
	for classpath@gnu.org; Sun, 01 Feb 2004 12:20:27 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-95-192.ewetel.net
	[80.228.95.192])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i11HKM1h000277;
	Sun, 1 Feb 2004 18:20:23 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1AnLGf-0000mK-00; Sun, 01 Feb 2004 18:20:21 +0100
Date: Sun, 1 Feb 2004 18:20:21 +0100
From: Michael Koch <konqueror@gmx.de>
To: Mark Wielaard <mark@klomp.org>
Message-ID: <20040201172021.GC2334@mail.konqueror.de>
References: <BAY10-F50bdVJWrGW6E0001b006@hotmail.com>
	<1075655468.2102.65.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1075655468.2102.65.camel@elsschot.wildebeest.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: classpath@gnu.org
Subject: Re: JamVM 1.1.1 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Feb 2004 17:21:48 -0000

On Sun, Feb 01, 2004 at 06:11:08PM +0100, Mark Wielaard wrote:
> Hi,
> 
> On Tue, 2004-01-27 at 14:09, Robert Lougher wrote:
> > I believe a couple of people on this list have at least given JamVM a test.  
> > In case you're interested, JamVM 1.1.1 is finally out (see 
> > http://jamvm.sourceforge.net).  It's been updated to use Classpath 0.07, as 
> > well as using a Java 2 style system class loader as discussed last December 
> > (a new job delayed the release).
> > [...]
> > Mark mentioned he gave JamVM 1.1.0 a go with the AWT peers.  I haven't had 
> > any time to do testing with 1.1.1.  However, I'd like to - Is there any test 
> > programs about which gives good coverage?
> 
> Very nice! Just tried it out on the Wonka Visual Test Engine (see
> http://sources.redhat.com/mauve/ CVS or an older tar ball at
> http://www.klomp.org/mark/open-wonka-visualtest.tar.gz). I needed one
> small patch for Classpath CVS (see the commit-classpath mailing list)
> that might also be needed for 0.07 (I didn't check). Without that patch
> you will get the following error when starting up a program that uses
> AWT: jamvm: relocation error:
> /usr/local/classpath/lib/classpath//libgtkpeer.so: undefined symbol:
> g_thread_init

This bug was introduced POST-0.07, so classpath 0.07 is not infected.


Michael



From MAILER-DAEMON Mon Feb 02 02:11:43 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnYFC-00069D-GD
	for mharc-classpath@gnu.org; Mon, 02 Feb 2004 02:11:42 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnYF9-00068l-OF
	for classpath@gnu.org; Mon, 02 Feb 2004 02:11:39 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AnYEd-00061j-Uc
	for classpath@gnu.org; Mon, 02 Feb 2004 02:11:38 -0500
Received: from [62.108.28.95] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AnYEd-000616-1N
	for classpath@gnu.org; Mon, 02 Feb 2004 02:11:07 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AnYE6-0001Ie-00
	for <classpath@gnu.org>; Mon, 02 Feb 2004 08:10:34 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-zi3tj5UOp2+fwK6UkLEu"
Message-Id: <1075705862.2102.94.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 02 Feb 2004 08:11:02 +0100
Subject: Jikes 1.19 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2004 07:11:40 -0000


--=-zi3tj5UOp2+fwK6UkLEu
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi all,

The Jikes compiler hackers made a new release.
Some interesting new improvements:

        Command line options have been improved.
       =20
        Some pedantic warnings are controlled by name, so that you can
        select which warnings you get (for example, not everyone wants
        to know that 1L is preferred over 1l when writing a long
        literal).
       =20
        More switches have long names.
       =20
        Default state of switches now printed with --help.
       =20
        New switch -Xswitchcheck: Warn about fallthrough in switch
        statements (compatible with javac).
       =20
        New switch +Pnaming-convention: Warn about naming choices that
        violate Java's naming conventions. This switch is currently ON
        by default, +Pno-naming-convention will disable it for sites
        that use a different naming convention.
       =20
        New switch --noassert: Omits assertions from .class files (not
        recommended for normal development, but provided to allow you to
        do -source 1.4 -target 1.3).
       =20
        Now supports -target 1.4.2 (compatible with javac, no changes
        from -target 1.4 in emitted code).
       =20
        Error text has been improved for method calls, to list the
        parameter types the compiler is trying to match. Error text on
        duplicate declarations tries harder to list the original
        declaration.
       =20
        Static checks have been added for a variety of common Java
        mistakes, including empty catch and finally blocks, accidental
        overloading of the equals method, classes implementing equals
        but not hashCode (or the other way around), interfaces used as
        enums, missing private constructors to prevent instantiation of
        utility classes, overly-general throws clauses, public static
        final array fields, returning null instead of a zero-length
        array, and deviations from standard Java naming conventions.

See/Get it here:
http://www-124.ibm.com/developerworks/downloads/detail.php?group_id=3D10&wh=
at=3Drele&id=3D686

If you have time, please try it out on GNU Classpath and see if these
new warnings point out anything interesting. You want to add
+Pno-naming-convention since the new jikes otherwise generates lots and
lots of warnings.

Cheers,

Mark

--=-zi3tj5UOp2+fwK6UkLEu
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAHfgFxVhZCJWr9QwRAmmIAJ0UfwVK42nV/FZ3SV+bMxadvIZpQgCgiQwI
Qt6yjnbMGeclbOir3owY80M=
=BxEA
-----END PGP SIGNATURE-----

--=-zi3tj5UOp2+fwK6UkLEu--




From MAILER-DAEMON Mon Feb 02 10:12:38 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnfE2-0001gc-Bk
	for mharc-classpath@gnu.org; Mon, 02 Feb 2004 09:38:58 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnfDw-0001eL-8z
	for classpath@gnu.org; Mon, 02 Feb 2004 09:38:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1Anf6F-0008MH-1L
	for classpath@gnu.org; Mon, 02 Feb 2004 09:31:26 -0500
Received: from [204.127.202.55] (helo=sccrmhc11.comcast.net)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AneyL-0006TU-Mq
	for classpath@gnu.org; Mon, 02 Feb 2004 09:22:45 -0500
Received: from byu.net (c-24-10-254-137.client.comcast.net[24.10.254.137])
	by comcast.net (sccrmhc11) with SMTP id <200402021422360110005j6fe>
	(Authid: ericblake); Mon, 2 Feb 2004 14:22:36 +0000
Message-ID: <401E5D31.8030001@byu.net>
Date: Mon, 02 Feb 2004 07:22:41 -0700
From: Eric Blake <ebb9@byu.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <1075705862.2102.94.camel@elsschot.wildebeest.org>
In-Reply-To: <1075705862.2102.94.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: Jikes 1.19 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2004 14:38:55 -0000

I'm glad you forwarded this announcement on to the Classpath list, Mark (yes, 
I'm one of the main jikes hackers).  The jikes project would appreciate 
feedback on which new warnings are too pedantic to be on by default (for 
example, naming-conventions); we enabled them this release because it is 
easier to turn something off after feedback than to leave it off and people 
never learn that it exists.  Comments are welcome to jikes AT www-124.ibm.com.

I also recommend upgrading to jikes 1.19 when compiling classpath, because it 
has fixed bugs that are present in previous releases, which may affect the 
validity of Classpath code.

Mark Wielaard wrote:

> Hi all,
> 
> The Jikes compiler hackers made a new release.
> Some interesting new improvements:
> 
>         Command line options have been improved.
>         
>         Some pedantic warnings are controlled by name, so that you can
>         select which warnings you get (for example, not everyone wants
>         to know that 1L is preferred over 1l when writing a long
>         literal).
>         
>         More switches have long names.
>         
>         Default state of switches now printed with --help.
>         
>         New switch -Xswitchcheck: Warn about fallthrough in switch
>         statements (compatible with javac).
>         
>         New switch +Pnaming-convention: Warn about naming choices that
>         violate Java's naming conventions. This switch is currently ON
>         by default, +Pno-naming-convention will disable it for sites
>         that use a different naming convention.
>         
>         New switch --noassert: Omits assertions from .class files (not
>         recommended for normal development, but provided to allow you to
>         do -source 1.4 -target 1.3).
>         
>         Now supports -target 1.4.2 (compatible with javac, no changes
>         from -target 1.4 in emitted code).
>         
>         Error text has been improved for method calls, to list the
>         parameter types the compiler is trying to match. Error text on
>         duplicate declarations tries harder to list the original
>         declaration.
>         
>         Static checks have been added for a variety of common Java
>         mistakes, including empty catch and finally blocks, accidental
>         overloading of the equals method, classes implementing equals
>         but not hashCode (or the other way around), interfaces used as
>         enums, missing private constructors to prevent instantiation of
>         utility classes, overly-general throws clauses, public static
>         final array fields, returning null instead of a zero-length
>         array, and deviations from standard Java naming conventions.
> 
> See/Get it here:
> http://www-124.ibm.com/developerworks/downloads/detail.php?group_id=10&what=rele&id=686
> 
> If you have time, please try it out on GNU Classpath and see if these
> new warnings point out anything interesting. You want to add
> +Pno-naming-convention since the new jikes otherwise generates lots and
> lots of warnings.
> 
> Cheers,
> 
> Mark

-- 
Someday, I might put a cute statement here.

Eric Blake             ebb9@byu.net




From MAILER-DAEMON Mon Feb 02 14:11:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnjPt-0001TT-3U
	for mharc-classpath@gnu.org; Mon, 02 Feb 2004 14:07:29 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnjPg-0001Pm-3G
	for classpath@gnu.org; Mon, 02 Feb 2004 14:07:16 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AnjP6-0001BI-51
	for classpath@gnu.org; Mon, 02 Feb 2004 14:07:11 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AnjP3-00016K-A6
	for classpath@gnu.org; Mon, 02 Feb 2004 14:06:37 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i12J6Sb15284;
	Mon, 2 Feb 2004 14:06:28 -0500
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i12J6Pa22457; 
	Mon, 2 Feb 2004 14:06:26 -0500
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i12J6OXd015115; Mon, 2 Feb 2004 14:06:24 -0500
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: libgcj patches <java-patches@gcc.gnu.org>
Content-Type: multipart/mixed; boundary="=-0c0P5AmxUYxnapg5GNNC"
Message-Id: <1075748783.2449.66.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Mon, 02 Feb 2004 14:06:24 -0500
Cc: classpath patches <classpath@gnu.org>
Subject: Patch: fix handling of AWT alias methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2004 19:07:17 -0000


--=-0c0P5AmxUYxnapg5GNNC
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hello,

This patch fixes the way we handle "alias" methods in the AWT, where a
public or protected method has been deprecated in favour of a new one
that has the same function but a different name.  Sun does this a fair
amount to fix cases where the original method's name did not follow
their naming conventions.

Unfortunately, this practise complicates class library code that calls
these aliased methods.  Library code must still call the deprecated
method so that old client code that overrides it continues to work.  But
library code must also call the new version, because new code is
expected to override the new method.

The correct way to handle this (and the way Sun does it) may seem
counterintuitive because it means that new code is less efficient than
old code: the new method must call the deprecated method, and throughout
the library code calls to the old method must be replaced with calls to
the new one.

Take the example of a newly-written container laying out a component and
wanting to know its preferred size.  The Component class has a
deprecated preferredSize method and a new method, getPreferredSize. 
Assume that the container is laying out an old component that overrides
preferredSize and a new component that overrides getPreferredSize.  If
the container calls getPreferredSize and the default implementation of
getPreferredSize calls preferredSize, then the old component will have
its preferredSize method called and new code will have its
getPreferredSize method called.

Even using this calling scheme, an old component may still be laid out
improperly if it implements a method, getPreferredSize, that has the
same signature as the new Component.getPreferredSize.  But that is a
general problem -- adding new public or protected methods to a
widely-used class that calls those methods internally is risky, because
existing client code may have already declared methods with the same
signature.

The solution may still seem counterintuitive -- why not have the
deprecated method call the new method, then have the library always call
the old method.  One problem with that, using the preferred size example
again, is that new containers, which will use the non-deprecated
getPreferredSize, will not get the preferred size of old components.

Jeroen Frijters provides a good explanation of the problem in his IKVM
web log [1].

Comments?

Tom

[1] GridBagLayout and more AWT, http://weblog.ikvm.net/commentview.aspx?guid=8B14C003-E16A-4E99-A52E-AD776CBB8CBF

2004-02-02  Thomas Fitzsimmons  <fitzsim@redhat.com>

	* gnu/java/awt/peer/gtk/GtkListPeer.java,
	java/awt/BorderLayout.java, java/awt/CardLayout.java,
	java/awt/CheckboxGroup.java, java/awt/Choice.java,
	java/awt/Component.java, java/awt/Container.java,
	java/awt/FontMetrics.java, java/awt/GridBagLayout.java,
	java/awt/LayoutManager2.java, java/awt/List.java,
	java/awt/Menu.java, java/awt/MenuBar.java,
	java/awt/MenuItem.java, java/awt/Polygon.java,
	java/awt/Rectangle.java, java/awt/ScrollPane.java,
	java/awt/Scrollbar.java, java/awt/TextArea.java,
	java/awt/TextField.java,
	java/awt/image/renderable/RenderContext.java,
	javax/swing/JApplet.java: Fix handling of alias methods, where a
	method has been deprecated in favour of a new one with the same
	funtion but a different name.  Put the method implementation in
	the deprecated method and have the new method call the
	deprecated one.  Make all other code call the new method.


--=-0c0P5AmxUYxnapg5GNNC
Content-Disposition: attachment; filename=fix-aliases.patch
Content-Type: text/x-patch; name=fix-aliases.patch; charset=UTF-8
Content-Transfer-Encoding: 7bit

Index: gnu/java/awt/peer/gtk/GtkListPeer.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/peer/gtk/GtkListPeer.java,v
retrieving revision 1.6
diff -u -r1.6 GtkListPeer.java
--- gnu/java/awt/peer/gtk/GtkListPeer.java	17 Dec 2003 18:02:56 -0000	1.6
+++ gnu/java/awt/peer/gtk/GtkListPeer.java	2 Feb 2004 17:41:48 -0000
@@ -85,18 +85,12 @@
   
   public Dimension getMinimumSize (int rows)
   {
-    int dims[] = new int[2];
-
-    getSize (rows, dims);
-    return (new Dimension (dims[0], dims[1]));
+    return minimumSize (rows);
   }
 
   public Dimension getPreferredSize (int rows)
   {
-    int dims[] = new int[2];
-
-    getSize (rows, dims);
-    return (new Dimension (dims[0], dims[1]));
+    return preferredSize (rows);
   }
   
   public native int[] getSelectedIndexes ();
@@ -104,12 +98,18 @@
 
   public Dimension minimumSize (int rows)
   {
-    return (getMinimumSize (rows));
+    int dims[] = new int[2];
+
+    getSize (rows, dims);
+    return new Dimension (dims[0], dims[1]);
   }
 
   public Dimension preferredSize (int rows)
   {
-    return (getPreferredSize (rows));
+    int dims[] = new int[2];
+
+    getSize (rows, dims);
+    return new Dimension (dims[0], dims[1]);
   }
 
   public void removeAll ()
Index: java/awt/BorderLayout.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/BorderLayout.java,v
retrieving revision 1.10
diff -u -r1.10 BorderLayout.java
--- java/awt/BorderLayout.java	10 Nov 2002 23:11:21 -0000	1.10
+++ java/awt/BorderLayout.java	2 Feb 2004 17:41:48 -0000
@@ -349,7 +349,28 @@
   if (constraints != null && ! (constraints instanceof String))
     throw new IllegalArgumentException("Constraint must be a string");
 
-  String str = (String)constraints;
+  addLayoutComponent((String) constraints, component);
+}
+
+/*************************************************************************/
+
+/**
+  * Adds a component to the layout in the specified constraint position, 
+  * which must be one of the string constants defined in this class.
+  *
+  * @param constraints The constraint string.
+  * @param component The component to add.
+  *
+  * @exception IllegalArgumentException If the constraint object is not
+  * one of the specified constants in this class.
+  *
+  * @deprecated This method is deprecated in favor of
+  * <code>addLayoutComponent(Component, Object)</code>.
+  */
+public void
+addLayoutComponent(String constraints, Component component)
+{
+  String str = constraints;
 
   if (str == null || str.equals(CENTER))
     center = component;
@@ -371,27 +392,6 @@
     lastItem = component;
   else
     throw new IllegalArgumentException("Constraint value not valid: " + str);
-}
-
-/*************************************************************************/
-
-/**
-  * Adds a component to the layout in the specified constraint position, 
-  * which must be one of the string constants defined in this class.
-  *
-  * @param constraints The constraint string.
-  * @param component The component to add.
-  *
-  * @exception IllegalArgumentException If the constraint object is not
-  * one of the specified constants in this class.
-  *
-  * @deprecated This method is deprecated in favor of
-  * <code>addLayoutComponent(Component, Object)</code>.
-  */
-public void
-addLayoutComponent(String constraints, Component component)
-{
-  addLayoutComponent(component, constraints);
 }
 
 /*************************************************************************/
Index: java/awt/CardLayout.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/CardLayout.java,v
retrieving revision 1.8
diff -u -r1.8 CardLayout.java
--- java/awt/CardLayout.java	15 Jan 2003 22:47:04 -0000	1.8
+++ java/awt/CardLayout.java	2 Feb 2004 17:41:48 -0000
@@ -90,7 +90,7 @@
     if (! (constraints instanceof String))
       throw new IllegalArgumentException ("Object " + constraints
 					  + " is not a string");
-    tab.put (constraints, comp);
+    addLayoutComponent ((String) constraints, comp);
   }
 
   /** Add a new component to the layout.  The name can be used later
@@ -102,7 +102,7 @@
    */
   public void addLayoutComponent (String name, Component comp)
   {
-    addLayoutComponent (comp, name);
+    tab.put (name, comp);
   }
 
   /** Cause the first component in the container to be displayed.
Index: java/awt/CheckboxGroup.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/CheckboxGroup.java,v
retrieving revision 1.4
diff -u -r1.4 CheckboxGroup.java
--- java/awt/CheckboxGroup.java	22 Jan 2002 22:40:04 -0000	1.4
+++ java/awt/CheckboxGroup.java	2 Feb 2004 17:41:48 -0000
@@ -95,8 +95,8 @@
 public Checkbox
 getSelectedCheckbox()
 {
-  return(selectedCheckbox);
-} 
+  return getCurrent ();
+}
 
 /*************************************************************************/
 
@@ -126,17 +126,7 @@
 public void
 setSelectedCheckbox(Checkbox selectedCheckbox)
 {
-  if (this.selectedCheckbox != null)
-    {
-      if (this.selectedCheckbox.getCheckboxGroup() != this)
-        return;
-
-      this.selectedCheckbox.setState(false);
-    }
-
-  this.selectedCheckbox = selectedCheckbox;
-  if (selectedCheckbox != null)
-    selectedCheckbox.setState(true);
+  setCurrent (selectedCheckbox);
 }
 
 /*************************************************************************/
@@ -153,7 +143,17 @@
 public void
 setCurrent(Checkbox selectedCheckbox)
 {
-  setSelectedCheckbox(selectedCheckbox);
+  if (this.selectedCheckbox != null)
+    {
+      if (this.selectedCheckbox.getCheckboxGroup() != this)
+        return;
+
+      this.selectedCheckbox.setState(false);
+    }
+
+  this.selectedCheckbox = selectedCheckbox;
+  if (selectedCheckbox != null)
+    selectedCheckbox.setState(true);
 }
 
 /*************************************************************************/
Index: java/awt/Choice.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Choice.java,v
retrieving revision 1.13
diff -u -r1.13 Choice.java
--- java/awt/Choice.java	5 Jan 2004 21:18:06 -0000	1.13
+++ java/awt/Choice.java	2 Feb 2004 17:41:48 -0000
@@ -111,7 +111,7 @@
 public int
 getItemCount()
 {
-  return(pItems.size());
+  return countItems ();
 }
 
 /*************************************************************************/
Index: java/awt/Component.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Component.java,v
retrieving revision 1.34
diff -u -r1.34 Component.java
--- java/awt/Component.java	26 Jan 2004 21:55:41 -0000	1.34
+++ java/awt/Component.java	2 Feb 2004 17:41:48 -0000
@@ -779,9 +779,7 @@
    */
   public void setEnabled(boolean b)
   {
-    this.enabled = b;
-    if (peer != null)
-      peer.setEnabled(b);
+    enable (b);
   }
 
   /**
@@ -791,7 +789,9 @@
    */
   public void enable()
   {
-    setEnabled(true);
+    this.enabled = true;
+    if (peer != null)
+      peer.setEnabled (true);
   }
 
   /**
@@ -802,7 +802,10 @@
    */
   public void enable(boolean b)
   {
-    setEnabled(b);
+    if (b)
+      enable ();
+    else
+      disable ();
   }
 
   /**
@@ -812,7 +815,9 @@
    */
   public void disable()
   {
-    setEnabled(false);
+    this.enabled = false;
+    if (peer != null)
+      peer.setEnabled (false);
   }
 
   /**
@@ -856,10 +861,7 @@
     // Inspection by subclassing shows that Sun's implementation calls
     // show(boolean) which then calls show() or hide(). It is the show()
     // method that is overriden in subclasses like Window.
-    if (b)
-      show();
-    else
-      hide();
+    show (b);
   }
 
   /**
@@ -887,7 +889,10 @@
    */
   public void show(boolean b)
   {
-    setVisible(b);
+    if (b)
+      show ();
+    else
+      hide ();
   }
 
   /**
@@ -1083,7 +1088,7 @@
    */
   public Point getLocation()
   {
-    return new Point(x, y);
+    return location ();
   }
 
   /**
@@ -1110,7 +1115,7 @@
    */
   public Point location()
   {
-    return getLocation();
+    return new Point (x, y);
   }
 
   /**
@@ -1125,13 +1130,7 @@
    */
   public void setLocation(int x, int y)
   {
-    if (this.x == x && this.y == y)
-      return;
-    invalidate();
-    this.x = x;
-    this.y = y;
-    if (peer != null)
-      peer.setBounds(x, y, width, height);
+    move (x, y);
   }
 
   /**
@@ -1145,7 +1144,13 @@
    */
   public void move(int x, int y)
   {
-    setLocation(x, y);
+    if (this.x == x && this.y == y)
+      return;
+    invalidate ();
+    this.x = x;
+    this.y = y;
+    if (peer != null)
+      peer.setBounds (x, y, width, height);
   }
 
   /**
@@ -1173,7 +1178,7 @@
    */
   public Dimension getSize()
   {
-    return new Dimension(width, height);
+    return size ();
   }
 
   /**
@@ -1184,7 +1189,7 @@
    */
   public Dimension size()
   {
-    return getSize();
+    return new Dimension (width, height);
   }
 
   /**
@@ -1197,13 +1202,7 @@
    */
   public void setSize(int width, int height)
   {
-    if (this.width == width && this.height == height)
-      return;
-    invalidate();
-    this.width = width;
-    this.height = height;
-    if (peer != null)
-      peer.setBounds(x, y, width, height);
+    resize (width, height);
   }
 
   /**
@@ -1215,7 +1214,13 @@
    */
   public void resize(int width, int height)
   {
-    setSize(width, height);
+    if (this.width == width && this.height == height)
+      return;
+    invalidate ();
+    this.width = width;
+    this.height = height;
+    if (peer != null)
+      peer.setBounds (x, y, width, height);
   }
 
   /**
@@ -1229,7 +1234,7 @@
    */
   public void setSize(Dimension d)
   {
-    setSize(d.width, d.height);
+    resize (d);
   }
 
   /**
@@ -1241,7 +1246,7 @@
    */
   public void resize(Dimension d)
   {
-    setSize(d.width, d.height);
+    resize (d.width, d.height);
   }
 
   /**
@@ -1256,7 +1261,7 @@
    */
   public Rectangle getBounds()
   {
-    return new Rectangle(x, y, width, height);
+    return bounds ();
   }
 
   /**
@@ -1269,7 +1274,7 @@
    */
   public Rectangle bounds()
   {
-    return getBounds();
+    return new Rectangle (x, y, width, height);
   }
 
   /**
@@ -1289,15 +1294,7 @@
    */
   public void setBounds(int x, int y, int w, int h)
   {
-    if (this.x == x && this.y == y && width == w && height == h)
-      return;
-    invalidate();
-    this.x = x;
-    this.y = y;
-    width = w;
-    height = h;
-    if (peer != null)
-      peer.setBounds(x, y, w, h);
+    reshape (x, y, w, h);
   }
 
   /**
@@ -1306,13 +1303,22 @@
    *
    * @param x the X coordinate of the upper left corner of the rectangle
    * @param y the Y coordinate of the upper left corner of the rectangle
-   * @param w the width of the rectangle
-   * @param h the height of the rectangle
+   * @param width the width of the rectangle
+   * @param height the height of the rectangle
    * @deprecated use {@link #setBounds(int, int, int, int)} instead
    */
   public void reshape(int x, int y, int width, int height)
   {
-    setBounds(x, y, width, height);
+    if (this.x == x && this.y == y
+        && this.width == width && this.height == height)
+      return;
+    invalidate ();
+    this.x = x;
+    this.y = y;
+    this.width = width;
+    this.height = height;
+    if (peer != null)
+      peer.setBounds (x, y, width, height);
   }
 
   /**
@@ -1329,7 +1335,7 @@
    */
   public void setBounds(Rectangle r)
   {
-    setBounds(r.x, r.y, r.width, r.height);
+    setBounds (r.x, r.y, r.width, r.height);
   }
 
   /**
@@ -1560,7 +1566,7 @@
    */
   public void doLayout()
   {
-    // nothing to do unless we're a container
+    layout ();
   }
 
   /**
@@ -1571,7 +1577,7 @@
    */
   public void layout()
   {
-    doLayout();
+    // Nothing to do unless we're a container.
   }
 
   /**
@@ -2076,7 +2082,7 @@
    */
   public boolean contains(int x, int y)
   {
-    return x >= 0 && y >= 0 && x < width && y < height;
+    return inside (x, y);
   }
 
   /**
@@ -2090,7 +2096,7 @@
    */
   public boolean inside(int x, int y)
   {
-    return contains(x, y);
+    return x >= 0 && y >= 0 && x < width && y < height;
   }
 
   /**
@@ -2105,7 +2111,7 @@
    */
   public boolean contains(Point p)
   {
-    return contains(p.x, p.y);
+    return contains (p.x, p.y);
   }
 
   /**
@@ -2120,7 +2126,7 @@
    */
   public Component getComponentAt(int x, int y)
   {
-    return contains(x, y) ? this : null;
+    return locate (x, y);
   }
 
   /**
@@ -2135,7 +2141,7 @@
    */
   public Component locate(int x, int y)
   {
-    return getComponentAt(x, y);
+    return contains (x, y) ? this : null;
   }
 
   /**
@@ -2151,7 +2157,7 @@
    */
   public Component getComponentAt(Point p)
   {
-    return getComponentAt(p.x, p.y);
+    return getComponentAt (p.x, p.y);
   }
 
   /**
Index: java/awt/Container.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Container.java,v
retrieving revision 1.32
diff -u -r1.32 Container.java
--- java/awt/Container.java	26 Jan 2004 21:55:41 -0000	1.32
+++ java/awt/Container.java	2 Feb 2004 17:41:48 -0000
@@ -106,7 +106,7 @@
    */
   public int getComponentCount()
   {
-    return ncomponents;
+    return countComponents ();
   }
 
   /**
@@ -118,7 +118,7 @@
    */
   public int countComponents()
   {
-    return getComponentCount();
+    return ncomponents;
   }
 
   /**
@@ -186,10 +186,7 @@
    */
   public Insets getInsets()
   {
-    if (peer == null)
-      return new Insets(0, 0, 0, 0);
-    
-    return ((ContainerPeer) peer).getInsets();
+    return insets ();
   }
 
   /**
@@ -201,7 +198,10 @@
    */
   public Insets insets()
   {
-    return getInsets();
+    if (peer == null)
+      return new Insets (0, 0, 0, 0);
+
+    return ((ContainerPeer) peer).getInsets ();
   }
 
   /**
@@ -463,8 +463,7 @@
    */
   public void doLayout()
   {
-    if (layoutMgr != null)
-      layoutMgr.layoutContainer(this);
+    layout ();
   }
 
   /**
@@ -474,7 +473,8 @@
    */
   public void layout()
   {
-    doLayout();
+    if (layoutMgr != null)
+      layoutMgr.layoutContainer (this);
   }
 
   /**
@@ -555,7 +555,7 @@
    */
   public Dimension getPreferredSize()
   {
-      return preferredSize();
+    return preferredSize ();
   }
 
   /**
@@ -567,10 +567,10 @@
    */
   public Dimension preferredSize()
   {
-      if (layoutMgr != null)
-	  return layoutMgr.preferredLayoutSize(this);
-      else
-	  return super.preferredSize();
+    if (layoutMgr != null)
+      return layoutMgr.preferredLayoutSize (this);
+    else
+      return super.preferredSize ();
   }
 
   /**
@@ -580,7 +580,7 @@
    */
   public Dimension getMinimumSize()
   {
-      return minimumSize();
+    return minimumSize ();
   }
 
   /**
@@ -592,10 +592,10 @@
    */
   public Dimension minimumSize()
   {
-      if (layoutMgr != null)
-	  return layoutMgr.minimumLayoutSize(this);
-      else
-	  return super.minimumSize();
+    if (layoutMgr != null)
+      return layoutMgr.minimumLayoutSize (this);
+    else
+      return super.minimumSize ();
   }
 
   /**
@@ -833,23 +833,7 @@
    */
   public Component getComponentAt(int x, int y)
   {
-    synchronized (getTreeLock ())
-      {
-        if (! contains(x, y))
-          return null;
-        for (int i = 0; i < ncomponents; ++i)
-          {
-            // Ignore invisible children...
-            if (!component[i].isVisible())
-              continue;
-
-            int x2 = x - component[i].x;
-            int y2 = y - component[i].y;
-            if (component[i].contains(x2, y2))
-              return component[i];
-          }
-        return this;
-      }
+    return locate (x, y);
   }
 
   /**
@@ -869,7 +853,23 @@
    */
   public Component locate(int x, int y)
   {
-    return getComponentAt(x, y);
+    synchronized (getTreeLock ())
+      {
+        if (!contains (x, y))
+          return null;
+        for (int i = 0; i < ncomponents; ++i)
+          {
+            // Ignore invisible children...
+            if (!component[i].isVisible ())
+              continue;
+
+            int x2 = x - component[i].x;
+            int y2 = y - component[i].y;
+            if (component[i].contains (x2, y2))
+              return component[i];
+          }
+        return this;
+      }
   }
 
   /**
@@ -886,7 +886,7 @@
    */
   public Component getComponentAt(Point p)
   {
-    return getComponentAt(p.x, p.y);
+    return getComponentAt (p.x, p.y);
   }
 
   public Component findComponentAt(int x, int y)
Index: java/awt/FontMetrics.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/FontMetrics.java,v
retrieving revision 1.4
diff -u -r1.4 FontMetrics.java
--- java/awt/FontMetrics.java	22 Jan 2002 22:58:08 -0000	1.4
+++ java/awt/FontMetrics.java	2 Feb 2004 17:41:48 -0000
@@ -195,7 +195,7 @@
 public int
 getMaxDescent()
 {
-  return(getDescent());
+  return getMaxDecent ();
 }
 
 /*************************************************************************/
@@ -212,7 +212,7 @@
 public int
 getMaxDecent()
 {
-  return(getMaxDescent());
+  return getDescent ();
 }
 
 /*************************************************************************/
Index: java/awt/GridBagLayout.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/GridBagLayout.java,v
retrieving revision 1.6
diff -u -r1.6 GridBagLayout.java
--- java/awt/GridBagLayout.java	14 Nov 2003 22:44:29 -0000	1.6
+++ java/awt/GridBagLayout.java	2 Feb 2004 17:41:48 -0000
@@ -149,7 +149,7 @@
 
     public void layoutContainer (Container parent)
     {
-	arrangeGrid (parent);
+      arrangeGrid (parent);
     }
 
     public float getLayoutAlignmentX (Container target)
@@ -302,7 +302,8 @@
      */
     protected void AdjustForGravity (GridBagConstraints gbc, Rectangle rect)
     {
-	adjustForGravity (gbc, rect);
+      // FIXME
+      throw new Error ("Not implemented");
     }
 
     /**
@@ -310,7 +311,115 @@
      */
     protected void ArrangeGrid (Container parent)
     {
-	arrangeGrid (parent);
+      Component[] components = parent.getComponents();
+
+      if (components.length == 0)
+        return;
+
+      GridBagLayoutInfo info = getLayoutInfo (parent, PREFERREDSIZE);
+      if (info.cols == 0 && info.rows == 0)
+        return;
+      layoutInfo = info;
+
+      // DEBUG
+      //dumpLayoutInfo (layoutInfo);
+    
+      for(int i = 0; i < components.length; i++)
+	{
+          Component component = components [i];
+		
+          // If component is not visible we dont have to care about it.
+          if (!component.isVisible())
+            continue;
+		
+          GridBagConstraints constraints = lookupConstraints (component);
+
+          int cellx = sumIntArray(layoutInfo.colWidths, constraints.gridx);
+          int celly = sumIntArray(layoutInfo.rowHeights, constraints.gridy);
+          int cellw = sumIntArray(layoutInfo.colWidths,
+                                  constraints.gridx + constraints.gridwidth) - cellx;
+          int cellh = sumIntArray(layoutInfo.rowHeights,
+                                  constraints.gridy + constraints.gridheight) - celly;
+
+          Insets insets = constraints.insets;
+          if (insets != null)
+	    {
+              cellx += insets.left;
+              celly += insets.top;
+              cellw -= insets.left + insets.right;
+              cellh -= insets.top + insets.bottom;
+	    }
+
+          Dimension dim = component.getPreferredSize();
+
+          // Note: Documentation says that padding is added on both sides, but
+          // visual inspection shows that the Sun implementation only adds it
+          // once, so we do the same.
+          dim.width += constraints.ipadx;
+          dim.height += constraints.ipady;
+
+          switch(constraints.fill)
+	    {
+            case GridBagConstraints.HORIZONTAL:
+              dim.width = cellw;
+              break;
+            case GridBagConstraints.VERTICAL:
+              dim.height = cellh;
+              break;
+            case GridBagConstraints.BOTH:
+              dim.width = cellw;
+              dim.height = cellh;
+              break;
+	    }
+
+          int x;
+          int y;
+
+          switch(constraints.anchor)
+	    {
+            case GridBagConstraints.NORTH:
+              x = cellx + (cellw - dim.width) / 2;
+              y = celly;
+              break;
+            case GridBagConstraints.SOUTH:
+              x = cellx + (cellw - dim.width) / 2;
+              y = celly + cellh - dim.height;
+              break;
+            case GridBagConstraints.WEST:
+              x = cellx;
+              y = celly + (cellh - dim.height) / 2;
+              break;
+            case GridBagConstraints.EAST:
+              x = cellx + cellw - dim.width;
+              y = celly + (cellh - dim.height) / 2;
+              break;
+            case GridBagConstraints.NORTHEAST:
+              x = cellx + cellw - dim.width;
+              y = celly;
+              break;
+            case GridBagConstraints.NORTHWEST:
+              x = cellx;
+              y = celly;
+              break;
+            case GridBagConstraints.SOUTHEAST:
+              x = cellx + cellw - dim.width;
+              y = celly + cellh - dim.height;
+              break;
+            case GridBagConstraints.SOUTHWEST:
+              x = cellx;
+              y = celly + cellh - dim.height;
+              break;
+            default:
+              x = cellx + (cellw - dim.width) / 2;
+              y = celly + (cellh - dim.height) / 2;
+              break;
+	    }
+
+          component.setBounds(layoutInfo.pos_x + x, layoutInfo.pos_y + y, dim.width, dim.height);
+	}
+
+      // DEBUG
+      //dumpLayoutInfo (layoutInfo);
     }
 
     /**
@@ -318,7 +427,160 @@
      */
     protected GridBagLayoutInfo GetLayoutInfo (Container parent, int sizeflag)
     {
-	return getLayoutInfo (parent, sizeflag);
+      if (sizeflag != MINSIZE && sizeflag != PREFERREDSIZE)
+        throw new IllegalArgumentException();
+
+      Dimension parentDim = parent.getSize ();
+      Insets parentInsets = parent.getInsets ();
+      parentDim.width -= parentInsets.left + parentInsets.right;
+      parentDim.height -= parentInsets.top + parentInsets.bottom;
+   
+      int x = 0;
+      int y = 0;
+      int max_x = 0;
+      int max_y = 0;
+
+      // first we figure out how many rows/columns
+      Component[] components = parent.getComponents();
+      for (int i = 0; i < components.length; i++)
+	{
+          Component component = components [i];
+		
+          // If component is not visible we dont have to care about it.
+          if (!component.isVisible())
+            continue;
+		
+          GridBagConstraints constraints = lookupConstraints (component);
+		
+          if(constraints.gridx == GridBagConstraints.RELATIVE)
+            constraints.gridx = x;
+
+          if(constraints.gridy == GridBagConstraints.RELATIVE)
+            constraints.gridy = y;
+		
+          max_x = Math.max(max_x, 
+                           constraints.gridx + Math.max(1, constraints.gridwidth));
+          max_y = Math.max(max_y,
+                           constraints.gridy + Math.max(1, constraints.gridheight));
+
+          if(constraints.gridwidth == GridBagConstraints.REMAINDER)
+	    {
+              x = 0;
+              y++;
+	    }
+          else
+	    {
+              x = constraints.gridx + Math.max(1, constraints.gridwidth);
+              y = constraints.gridy;
+	    }
+	}
+	
+      GridBagLayoutInfo info = new GridBagLayoutInfo(max_x, max_y);
+
+      for (x = 0; x <= max_x; x++)
+	{
+          if(columnWidths != null && columnWidths.length > x)
+	    {
+              info.colWidths[x] = columnWidths[x];
+	    }
+          if(columnWeights != null && columnWeights.length > x)
+	    {
+              info.colWeights[x] = columnWeights[x];
+	    }
+          for (int i = 0; i < components.length; i++)
+	    {
+              Component component = components [i];
+			
+              // If component is not visible we dont have to care about it.
+              if (!component.isVisible())
+                continue;
+			
+              GridBagConstraints constraints = lookupConstraints (component);
+
+              // first we fix up any REMAINDER cells
+              if(constraints.gridwidth == GridBagConstraints.REMAINDER)
+		{
+                  constraints.gridwidth = max_x - constraints.gridx;
+		}
+              if(constraints.gridheight == GridBagConstraints.REMAINDER)
+		{
+                  constraints.gridheight = max_y - constraints.gridy;
+		}
+
+              if(constraints.gridx + constraints.gridwidth - 1 == x)
+		{
+                  int width = (sizeflag == PREFERREDSIZE) ?
+                    component.getPreferredSize().width :
+                    component.getMinimumSize().width;
+                  if(constraints.insets != null)
+		    {
+                      width += constraints.insets.left + constraints.insets.right;
+		    }
+                  width += constraints.ipadx;
+                  for(int w = 1; w < constraints.gridwidth; w++)
+		    {
+                      width -= info.colWidths[x - w];
+		    }
+                  info.colWidths[x] = Math.max(info.colWidths[x], width);
+                  info.colWeights[x] =
+                    Math.max(info.colWeights[x], constraints.weightx);
+		}
+	    }
+	}
+
+      for (y = 0; y <= max_y; y++)
+	{
+          if(rowHeights != null && rowHeights.length > y)
+	    {
+              info.rowHeights[y] = rowHeights[y];
+	    }
+          if(rowWeights != null && rowWeights.length > y)
+	    {
+              info.rowWeights[y] = rowWeights[y];
+	    }
+          for (int i = 0; i < components.length; i++)
+	    {
+              Component component = components [i];
+			
+              // If component is not visible we dont have to care about it.
+              if (!component.isVisible())
+                continue;
+			
+              GridBagConstraints constraints = lookupConstraints (component);
+
+              if(constraints.gridy + constraints.gridheight - 1 == y)
+		{
+                  int height = (sizeflag == PREFERREDSIZE) ?
+                    component.getPreferredSize().height :
+                    component.getMinimumSize().height;
+                  if(constraints.insets != null)
+		    {
+                      height += constraints.insets.top + constraints.insets.bottom;
+		    } 
+                  height += constraints.ipady;
+                  for(int h = 1; h < constraints.gridheight; h++)
+		    {
+                      height -= info.rowHeights[y - h];
+		    }
+                  info.rowHeights[y] = Math.max(info.rowHeights[y], height);
+                  info.rowWeights[y] =
+                    Math.max(info.rowWeights[y], constraints.weighty);
+		}
+	    }
+	}
+
+      calcCellSizes (info.colWidths, info.colWeights, parentDim.width);
+      calcCellSizes (info.rowHeights, info.rowWeights, parentDim.height);
+
+      int totalWidth = sumIntArray(info.colWidths);
+      int totalHeight = sumIntArray(info.rowHeights);
+      info.pos_x = parentInsets.left + (parentDim.width - totalWidth) / 2;
+      info.pos_y = parentInsets.top + (parentDim.height - totalHeight) / 2;
+
+      // DEBUG
+      //dumpLayoutInfo (info);
+
+      return info;
     }
 
     /**
@@ -326,7 +588,13 @@
      */
     protected Dimension GetMinSize (Container parent, GridBagLayoutInfo info)
     {
-	return getMinSize (parent, info);
+      if (parent == null || info == null)
+        return new Dimension (0, 0);
+
+      Insets insets = parent.getInsets();
+      int width = sumIntArray (info.colWidths) + insets.left + insets.right;
+      int height = sumIntArray (info.rowHeights) + insets.top + insets.bottom;
+      return new Dimension (width, height);
     }
 
     /**
@@ -334,13 +602,7 @@
      */
     protected Dimension getMinSize (Container parent, GridBagLayoutInfo info)
     {
-	if (parent == null || info == null)
-	    return new Dimension (0, 0);
-
-	Insets insets = parent.getInsets();
-	int width = sumIntArray (info.colWidths) + insets.left + insets.right;
-	int height = sumIntArray (info.rowHeights) + insets.top + insets.bottom;
-	return new Dimension (width, height);
+      return GetMinSize (parent, info);
     }
 
     private void calcCellSizes (int[] sizes, double[] weights, int range)
@@ -404,116 +666,7 @@
      */
     protected void arrangeGrid (Container parent)
     {
-	Component[] components = parent.getComponents();
-
-	if (components.length == 0)
-	    return;
-
-	GridBagLayoutInfo info = getLayoutInfo (parent, PREFERREDSIZE);
-	if (info.cols == 0 && info.rows == 0)
-	    return;
-	layoutInfo = info;
-
-	// DEBUG
-	//dumpLayoutInfo (layoutInfo);
-    
-	for(int i = 0; i < components.length; i++)
-	{
-	    Component component = components [i];
-		
-	    // If component is not visible we dont have to care about it.
-	    if (!component.isVisible())
-		continue;
-		
-	    GridBagConstraints constraints = lookupConstraints (component);
-
-	    int cellx = sumIntArray(layoutInfo.colWidths, constraints.gridx);
-	    int celly = sumIntArray(layoutInfo.rowHeights, constraints.gridy);
-	    int cellw = sumIntArray(layoutInfo.colWidths,
-		constraints.gridx + constraints.gridwidth) - cellx;
-	    int cellh = sumIntArray(layoutInfo.rowHeights,
-		constraints.gridy + constraints.gridheight) - celly;
-
-	    Insets insets = constraints.insets;
-	    if (insets != null)
-	    {
-		cellx += insets.left;
-		celly += insets.top;
-		cellw -= insets.left + insets.right;
-		cellh -= insets.top + insets.bottom;
-	    }
-
-	    Dimension dim = component.preferredSize();
-
-	    // Note: Documentation says that padding is added on both sides, but
-	    // visual inspection shows that the Sun implementation only adds it
-	    // once, so we do the same.
-	    dim.width += constraints.ipadx;
-	    dim.height += constraints.ipady;
-
-	    switch(constraints.fill)
-	    {
-		case GridBagConstraints.HORIZONTAL:
-		    dim.width = cellw;
-		    break;
-		case GridBagConstraints.VERTICAL:
-		    dim.height = cellh;
-		    break;
-		case GridBagConstraints.BOTH:
-		    dim.width = cellw;
-		    dim.height = cellh;
-		    break;
-	    }
-
-	    int x;
-	    int y;
-
-	    switch(constraints.anchor)
-	    {
-		case GridBagConstraints.NORTH:
-		    x = cellx + (cellw - dim.width) / 2;
-		    y = celly;
-		    break;
-		case GridBagConstraints.SOUTH:
-		    x = cellx + (cellw - dim.width) / 2;
-		    y = celly + cellh - dim.height;
-		    break;
-		case GridBagConstraints.WEST:
-		    x = cellx;
-		    y = celly + (cellh - dim.height) / 2;
-		    break;
-		case GridBagConstraints.EAST:
-		    x = cellx + cellw - dim.width;
-		    y = celly + (cellh - dim.height) / 2;
-		    break;
-		case GridBagConstraints.NORTHEAST:
-		    x = cellx + cellw - dim.width;
-		    y = celly;
-		    break;
-		case GridBagConstraints.NORTHWEST:
-		    x = cellx;
-		    y = celly;
-		    break;
-		case GridBagConstraints.SOUTHEAST:
-		    x = cellx + cellw - dim.width;
-		    y = celly + cellh - dim.height;
-		    break;
-		case GridBagConstraints.SOUTHWEST:
-		    x = cellx;
-		    y = celly + cellh - dim.height;
-		    break;
-		default:
-		    x = cellx + (cellw - dim.width) / 2;
-		    y = celly + (cellh - dim.height) / 2;
-		    break;
-	    }
-
-	    component.setBounds(layoutInfo.pos_x + x, layoutInfo.pos_y + y, dim.width, dim.height);
-	}
-    
-	// DEBUG
-	//dumpLayoutInfo (layoutInfo);
-
+      ArrangeGrid (parent);
     }
 
     /**
@@ -521,160 +674,7 @@
      */
     protected GridBagLayoutInfo getLayoutInfo (Container parent, int sizeflag)
     {
-	if (sizeflag != MINSIZE && sizeflag != PREFERREDSIZE)
-	    throw new IllegalArgumentException();
-
-	Dimension parentDim = parent.size();
-	Insets parentInsets = parent.insets();
-	parentDim.width -= parentInsets.left + parentInsets.right;
-	parentDim.height -= parentInsets.top + parentInsets.bottom;
-   
-	int x = 0;
-	int y = 0;
-	int max_x = 0;
-	int max_y = 0;
-
-	// first we figure out how many rows/columns
-	Component[] components = parent.getComponents();
-	for (int i = 0; i < components.length; i++)
-	{
-	    Component component = components [i];
-		
-	    // If component is not visible we dont have to care about it.
-	    if (!component.isVisible())
-		continue;
-		
-	    GridBagConstraints constraints = lookupConstraints (component);
-		
-	    if(constraints.gridx == GridBagConstraints.RELATIVE)
-		constraints.gridx = x;
-
-	    if(constraints.gridy == GridBagConstraints.RELATIVE)
-		constraints.gridy = y;
-		
-	    max_x = Math.max(max_x, 
-		constraints.gridx + Math.max(1, constraints.gridwidth));
-	    max_y = Math.max(max_y,
-		constraints.gridy + Math.max(1, constraints.gridheight));
-
-	    if(constraints.gridwidth == GridBagConstraints.REMAINDER)
-	    {
-		x = 0;
-		y++;
-	    }
-	    else
-	    {
-		x = constraints.gridx + Math.max(1, constraints.gridwidth);
-		y = constraints.gridy;
-	    }
-	}
-	
-	GridBagLayoutInfo info = new GridBagLayoutInfo(max_x, max_y);
-
-	for (x = 0; x <= max_x; x++)
-	{
-	    if(columnWidths != null && columnWidths.length > x)
-	    {
-		info.colWidths[x] = columnWidths[x];
-	    }
-	    if(columnWeights != null && columnWeights.length > x)
-	    {
-		info.colWeights[x] = columnWeights[x];
-	    }
-	    for (int i = 0; i < components.length; i++)
-	    {
-		Component component = components [i];
-			
-		// If component is not visible we dont have to care about it.
-		if (!component.isVisible())
-		    continue;
-			
-		GridBagConstraints constraints = lookupConstraints (component);
-
-		// first we fix up any REMAINDER cells
-		if(constraints.gridwidth == GridBagConstraints.REMAINDER)
-		{
-		    constraints.gridwidth = max_x - constraints.gridx;
-		}
-		if(constraints.gridheight == GridBagConstraints.REMAINDER)
-		{
-		    constraints.gridheight = max_y - constraints.gridy;
-		}
-
-		if(constraints.gridx + constraints.gridwidth - 1 == x)
-		{
-		    int width = (sizeflag == PREFERREDSIZE) ?
-			component.preferredSize().width :
-			component.minimumSize().width;
-		    if(constraints.insets != null)
-		    {
-			width += constraints.insets.left + constraints.insets.right;
-		    }
-		    width += constraints.ipadx;
-		    for(int w = 1; w < constraints.gridwidth; w++)
-		    {
-			width -= info.colWidths[x - w];
-		    }
-		    info.colWidths[x] = Math.max(info.colWidths[x], width);
-		    info.colWeights[x] =
-			Math.max(info.colWeights[x], constraints.weightx);
-		}
-	    }
-	}
-
-	for (y = 0; y <= max_y; y++)
-	{
-	    if(rowHeights != null && rowHeights.length > y)
-	    {
-		info.rowHeights[y] = rowHeights[y];
-	    }
-	    if(rowWeights != null && rowWeights.length > y)
-	    {
-		info.rowWeights[y] = rowWeights[y];
-	    }
-	    for (int i = 0; i < components.length; i++)
-	    {
-		Component component = components [i];
-			
-		// If component is not visible we dont have to care about it.
-		if (!component.isVisible())
-		    continue;
-			
-		GridBagConstraints constraints = lookupConstraints (component);
-
-		if(constraints.gridy + constraints.gridheight - 1 == y)
-		{
-		    int height = (sizeflag == PREFERREDSIZE) ?
-			component.preferredSize().height :
-			component.minimumSize().height;
-		    if(constraints.insets != null)
-		    {
-			height += constraints.insets.top + constraints.insets.bottom;
-		    } 
-		    height += constraints.ipady;
-		    for(int h = 1; h < constraints.gridheight; h++)
-		    {
-			height -= info.rowHeights[y - h];
-		    }
-		    info.rowHeights[y] = Math.max(info.rowHeights[y], height);
-		    info.rowWeights[y] =
-			Math.max(info.rowWeights[y], constraints.weighty);
-		}
-	    }
-	}
-
-	calcCellSizes (info.colWidths, info.colWeights, parentDim.width);
-	calcCellSizes (info.rowHeights, info.rowWeights, parentDim.height);
-
-	int totalWidth = sumIntArray(info.colWidths);
-	int totalHeight = sumIntArray(info.rowHeights);
-	info.pos_x = parentInsets.left + (parentDim.width - totalWidth) / 2;
-	info.pos_y = parentInsets.top + (parentDim.height - totalHeight) / 2;
-
-	// DEBUG
-	//dumpLayoutInfo (info);
-
-	return info;
+      return GetLayoutInfo (parent, sizeflag);
     }
 
     /**
@@ -682,7 +682,6 @@
      */
     protected void adjustForGravity (GridBagConstraints gbc, Rectangle rect)
     {
-	// FIXME
-	throw new Error ("Not implemented");
+      AdjustForGravity (gbc, rect);
     }
 }
Index: java/awt/LayoutManager2.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/LayoutManager2.java,v
retrieving revision 1.6
diff -u -r1.6 LayoutManager2.java
--- java/awt/LayoutManager2.java	9 Aug 2002 04:26:14 -0000	1.6
+++ java/awt/LayoutManager2.java	2 Feb 2004 17:41:48 -0000
@@ -52,12 +52,12 @@
 {
   /**
    * Adds the specified component to the layout, with the specified
-   * constraint object.
+   * constraints object.
    *
    * @param component the component to add
-   * @param constraint the constraint to satisfy
+   * @param constraints the constraints to satisfy
    */
-  void addLayoutComponent(Component component, Object contraint);
+  void addLayoutComponent(Component component, Object contraints);
 
   /**
    * Determines the maximum size of the specified target container.
Index: java/awt/List.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/List.java,v
retrieving revision 1.16
diff -u -r1.16 List.java
--- java/awt/List.java	19 Dec 2003 02:53:36 -0000	1.16
+++ java/awt/List.java	2 Feb 2004 17:41:48 -0000
@@ -175,7 +175,7 @@
 public int
 getItemCount()
 {
-  return(items.size());
+  return countItems ();
 }
 
 /*************************************************************************/
@@ -191,7 +191,7 @@
 public int
 countItems()
 {
-  return(getItemCount());
+  return items.size ();
 }
 
 /*************************************************************************/
@@ -249,7 +249,7 @@
 public boolean
 isMultipleMode()
 {
-  return(multipleMode);
+  return allowsMultipleSelections ();
 }
 
 /*************************************************************************/
@@ -266,7 +266,7 @@
 public boolean
 allowsMultipleSelections()
 {
-  return(multipleMode);
+  return multipleMode;
 }
 
 /*************************************************************************/
@@ -281,12 +281,7 @@
 public void
 setMultipleMode(boolean multipleMode)
 {
-  this.multipleMode = multipleMode;
-  if (peer != null)
-    {
-      ListPeer l = (ListPeer) peer;
-      l.setMultipleMode (multipleMode);
-    }
+  setMultipleSelections (multipleMode);
 }
 
 /*************************************************************************/
@@ -303,7 +298,11 @@
 public void
 setMultipleSelections(boolean multipleMode)
 {
-  setMultipleMode(multipleMode);
+  this.multipleMode = multipleMode;
+
+  ListPeer peer = (ListPeer) getPeer ();
+  if (peer != null)
+    peer.setMultipleMode (multipleMode);
 }
 
 /*************************************************************************/
@@ -316,7 +315,7 @@
 public Dimension
 getMinimumSize()
 {
-  return(getMinimumSize(rows));
+  return getMinimumSize (getRows ());
 }
 
 /*************************************************************************/
@@ -332,7 +331,7 @@
 public Dimension
 minimumSize()
 {
-  return(getMinimumSize(rows));
+  return minimumSize (getRows ());
 }
 
 /*************************************************************************/
@@ -348,11 +347,7 @@
 public Dimension
 getMinimumSize(int rows)
 {
-  ListPeer lp = (ListPeer)getPeer();
-  if (lp != null)
-    return(lp.minimumSize(rows));
-  else
-    return(new Dimension(0,0));
+  return minimumSize (rows);
 }
 
 /*************************************************************************/
@@ -371,7 +366,11 @@
 public Dimension
 minimumSize(int rows)
 {
-  return(getMinimumSize(rows));
+  ListPeer peer = (ListPeer) getPeer ();
+  if (peer != null)
+    return peer.minimumSize (rows);
+  else
+    return new Dimension (0, 0);
 }
 
 /*************************************************************************/
@@ -384,7 +383,7 @@
 public Dimension
 getPreferredSize()
 {
-  return(getPreferredSize(rows));
+  return getPreferredSize (getRows ());
 }
 
 /*************************************************************************/
@@ -400,7 +399,7 @@
 public Dimension
 preferredSize()
 {
-  return(getPreferredSize(rows));
+  return preferredSize (getRows ());
 }
 
 /*************************************************************************/
@@ -416,11 +415,7 @@
 public Dimension
 getPreferredSize(int rows)
 {
-  ListPeer lp = (ListPeer)getPeer();
-  if (lp != null)
-    return(lp.preferredSize(rows));
-  else
-    return(new Dimension(0,0));
+  return preferredSize (rows);
 }
 
 /*************************************************************************/
@@ -439,7 +434,11 @@
 public Dimension
 preferredSize(int rows)
 {
-  return(getPreferredSize(rows));
+  ListPeer peer = (ListPeer) getPeer ();
+  if (peer != null)
+    return peer.preferredSize (rows);
+  else
+    return new Dimension (0, 0);
 }
 
 /*************************************************************************/
@@ -452,7 +451,7 @@
 public void
 add(String item)
 {
-  add(item, -1);
+  add (item, -1);
 }
 
 /*************************************************************************/
@@ -467,7 +466,7 @@
 public void
 addItem(String item)
 {
-  addItem(item, -1);
+  addItem (item, -1);
 }
 
 /*************************************************************************/
@@ -484,16 +483,7 @@
 public void
 add(String item, int index)
 {
-  if ((index == -1) || (index >= items.size()))
-    items.addElement(item);
-  else
-    items.insertElementAt(item, index);
-
-  if (peer != null)
-    {
-      ListPeer l = (ListPeer) peer;
-      l.add (item, index);
-    }
+  addItem (item, index);
 }
 
 /*************************************************************************/
@@ -512,7 +502,14 @@
 public void
 addItem(String item, int index)
 {
-  add(item, index);
+  if ((index == -1) || (index >= items.size ()))
+    items.addElement (item);
+  else
+    items.insertElementAt (item, index);
+
+  ListPeer peer = (ListPeer) getPeer ();
+  if (peer != null)
+    peer.add (item, index);
 }
 
 /*************************************************************************/
@@ -529,7 +526,11 @@
 public void
 delItem(int index) throws IllegalArgumentException
 {
-  remove(index);
+  items.removeElementAt (index);
+
+  ListPeer peer = (ListPeer) getPeer ();
+  if (peer != null)
+    peer.delItems (index, index);
 }
 
 /*************************************************************************/
@@ -544,12 +545,7 @@
 public void
 remove(int index) throws IllegalArgumentException
 {
-  items.removeElementAt (index);
-  if (peer != null)
-    {
-      ListPeer l = (ListPeer) peer;
-      l.delItems (index, index);
-    }
+  delItem (index);
 }
 
 /*************************************************************************/
@@ -613,12 +609,7 @@
 public synchronized void
 removeAll()
 {
-  items.clear();
-  if (peer != null)
-    {
-      ListPeer l = (ListPeer) peer;
-      l.removeAll ();
-    }
+  clear ();
 }
 
 /*************************************************************************/
@@ -631,7 +622,11 @@
 public void
 clear()
 {
-  removeAll();
+  items.clear();
+
+  ListPeer peer = (ListPeer) getPeer ();
+  if (peer != null)
+    peer.removeAll ();
 }
 
 /*************************************************************************/
@@ -782,13 +777,7 @@
 public boolean
 isIndexSelected(int index)
 {
-  int[] indexes = getSelectedIndexes();
-
-  for (int i = 0; i < indexes.length; i++)
-    if (indexes[i] == index)
-      return(true);
-
-  return(false);
+  return isSelected (index);
 }
 
 /*************************************************************************/
@@ -807,7 +796,13 @@
 public boolean
 isSelected(int index)
 {
-  return(isIndexSelected(index));
+  int[] indexes = getSelectedIndexes ();
+
+  for (int i = 0; i < indexes.length; i++)
+    if (indexes[i] == index)
+      return true;
+
+  return false;
 }
 
 /*************************************************************************/
Index: java/awt/Menu.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Menu.java,v
retrieving revision 1.15
diff -u -r1.15 Menu.java
--- java/awt/Menu.java	27 Jan 2004 19:29:56 -0000	1.15
+++ java/awt/Menu.java	2 Feb 2004 17:41:48 -0000
@@ -171,7 +171,7 @@
 public int
 getItemCount()
 {
-  return(items.size());
+  return countItems ();
 }
 
 /**
@@ -183,7 +183,7 @@
  */
 public int countItems ()
 {
-  return getItemCount ();
+  return items.size ();
 }
  
 /*************************************************************************/
Index: java/awt/MenuBar.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/MenuBar.java,v
retrieving revision 1.12
diff -u -r1.12 MenuBar.java
--- java/awt/MenuBar.java	27 Jan 2004 19:29:56 -0000	1.12
+++ java/awt/MenuBar.java	2 Feb 2004 17:41:48 -0000
@@ -219,8 +219,7 @@
 public int
 getMenuCount()
 {
-  // FIXME: How does the help menu fit in here?
-  return(menus.size());
+  return countMenus ();
 }
 
 /*************************************************************************/
@@ -235,7 +234,8 @@
 public int
 countMenus()
 {
-  return(getMenuCount());
+  // FIXME: How does the help menu fit in here?
+  return menus.size ();
 }
 
 /*************************************************************************/
Index: java/awt/MenuItem.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/MenuItem.java,v
retrieving revision 1.15
diff -u -r1.15 MenuItem.java
--- java/awt/MenuItem.java	19 Jan 2004 14:27:45 -0000	1.15
+++ java/awt/MenuItem.java	2 Feb 2004 17:41:48 -0000
@@ -202,15 +202,7 @@
 public synchronized void
 setEnabled(boolean enabled)
 {
-  if (enabled == this.enabled)
-    return;
-
-  this.enabled = enabled;
-  if (peer != null)
-    {
-      MenuItemPeer mp = (MenuItemPeer) peer;
-      mp.setEnabled (enabled);
-    }
+  enable (enabled);
 }
 
 /*************************************************************************/
@@ -226,7 +218,10 @@
 public void
 enable(boolean enabled)
 {
-  setEnabled(enabled);
+  if (enabled)
+    enable ();
+  else
+    disable ();
 }
 
 /*************************************************************************/
@@ -239,7 +234,12 @@
 public void
 enable()
 {
-  setEnabled(true);
+  if (enabled)
+    return;
+
+  this.enabled = true;
+  if (peer != null)
+    ((MenuItemPeer) peer).setEnabled (true);
 }
 
 /*************************************************************************/
@@ -252,7 +252,12 @@
 public void
 disable()
 {
-  setEnabled(false);
+  if (!enabled)
+    return;
+
+  this.enabled = false;
+  if (peer != null)
+    ((MenuItemPeer) peer).setEnabled (false);
 }
 
 /*************************************************************************/
Index: java/awt/Polygon.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Polygon.java,v
retrieving revision 1.3
diff -u -r1.3 Polygon.java
--- java/awt/Polygon.java	8 Dec 2003 22:59:51 -0000	1.3
+++ java/awt/Polygon.java	2 Feb 2004 17:41:48 -0000
@@ -258,10 +258,24 @@
    */
   public Rectangle getBounds()
   {
+    return getBoundingBox ();
+  }
+
+  /**
+   * Returns the bounding box of this polygon. This is the smallest
+   * rectangle with sides parallel to the X axis that will contain this
+   * polygon.
+   *
+   * @return the bounding box for this polygon
+   * @see #getBounds2D()
+   * @deprecated use {@link #getBounds()} instead
+   */
+  public Rectangle getBoundingBox()
+  {
     if (bounds == null)
       {
         if (npoints == 0)
-          return bounds = new Rectangle();
+          return bounds = new Rectangle ();
         int i = npoints - 1;
         int minx = xpoints[i];
         int maxx = minx;
@@ -280,23 +294,9 @@
             else if (y > maxy)
               maxy = y;
           }
-        bounds = new Rectangle(minx, maxy, maxx - minx, maxy - miny);
+        bounds = new Rectangle (minx, maxy, maxx - minx, maxy - miny);
       }
     return bounds;
-  }
-
-  /**
-   * Returns the bounding box of this polygon. This is the smallest
-   * rectangle with sides parallel to the X axis that will contain this
-   * polygon.
-   *
-   * @return the bounding box for this polygon
-   * @see #getBounds2D()
-   * @deprecated use {@link #getBounds()} instead
-   */
-  public Rectangle getBoundingBox()
-  {
-    return getBounds();
   }
 
   /**
Index: java/awt/Rectangle.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Rectangle.java,v
retrieving revision 1.11
diff -u -r1.11 Rectangle.java
--- java/awt/Rectangle.java	5 Jun 2003 19:58:39 -0000	1.11
+++ java/awt/Rectangle.java	2 Feb 2004 17:41:48 -0000
@@ -281,10 +281,7 @@
    */
   public void setBounds(Rectangle r)
   {
-    x = r.x;
-    y = r.y;
-    width = r.width;
-    height = r.height;
+    setBounds (r.x, r.y, r.width, r.height);
   }
 
   /**
@@ -298,10 +295,7 @@
    */
   public void setBounds(int x, int y, int width, int height)
   {
-    this.x = x;
-    this.y = y;
-    this.width = width;
-    this.height = height;
+    reshape (x, y, width, height);
   }
 
   /**
@@ -333,7 +327,10 @@
    */
   public void reshape(int x, int y, int width, int height)
   {
-    setBounds(x, y, width, height);
+    this.x = x;
+    this.y = y;
+    this.width = width;
+    this.height = height;
   }
 
   /**
@@ -360,8 +357,7 @@
    */
   public void setLocation(Point p)
   {
-    this.x = p.x;
-    this.y = p.y;
+    setLocation (p.x, p.y);
   }
 
   /**
@@ -374,8 +370,7 @@
    */
   public void setLocation(int x, int y)
   {
-    this.x = x;
-    this.y = y;
+    move (x, y);
   }
 
   /**
@@ -388,7 +383,8 @@
    */
   public void move(int x, int y)
   {
-    setLocation(x, y);
+    this.x = x;
+    this.y = y;
   }
 
   /**
@@ -426,8 +422,7 @@
    */
   public void setSize(Dimension d)
   {
-    width = d.width;
-    height = d.height;
+    setSize (d.width, d.height);
   }
 
   /**
@@ -439,8 +434,7 @@
    */
   public void setSize(int width, int height)
   {
-    this.width = width;
-    this.height = height;
+    resize (width, height);
   }
 
   /**
@@ -452,7 +446,8 @@
    */
   public void resize(int width, int height)
   {
-    setSize(width, height);
+    this.width = width;
+    this.height = height;
   }
 
   /**
@@ -469,9 +464,7 @@
    */
   public boolean contains(Point p)
   {
-    return width > 0 && height > 0
-      && p.x >= x && p.x < x + width
-      && p.y >= y && p.y < y + height;
+    return contains (p.x, p.y);
   }
 
   /**
@@ -487,9 +480,7 @@
    */
   public boolean contains(int x, int y)
   {
-    return width > 0 && height > 0
-      && x >= this.x && x < this.x + width
-      && y >= this.y && y < this.y + height;
+    return inside (x, y);
   }
 
   /**
@@ -504,9 +495,7 @@
    */
   public boolean contains(Rectangle r)
   {
-    return width > 0 && height > 0 && r.width > 0 && r.height > 0
-      && r.x >= x && r.x + r.width <= x + width
-      && r.y >= y && r.y + r.height <= y + height;
+    return contains (r.x, r.y, r.width, r.height);
   }
 
   /**
@@ -537,7 +526,9 @@
    */
   public boolean inside(int x, int y)
   {
-    return contains(x, y);
+    return width > 0 && height > 0
+      && x >= this.x && x < this.x + width
+      && y >= this.y && y < this.y + height;
   }
 
   /**
Index: java/awt/ScrollPane.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/ScrollPane.java,v
retrieving revision 1.14
diff -u -r1.14 ScrollPane.java
--- java/awt/ScrollPane.java	5 Jan 2004 21:35:32 -0000	1.14
+++ java/awt/ScrollPane.java	2 Feb 2004 17:41:48 -0000
@@ -446,10 +446,25 @@
 public void
 doLayout()
 {
-  Component[] list = getComponents();
+  layout ();
+}
+
+/*************************************************************************/
+
+/**
+  * Lays out this component.  This consists of resizing the sole child
+  * component to its perferred size.
+  *
+  * @deprecated This method is deprecated in favor of
+  * <code>doLayout()</code>.
+  */
+public void
+layout()
+{
+  Component[] list = getComponents ();
   if ((list != null) && (list.length > 0))
     {
-      Dimension dim = list[0].getPreferredSize();
+      Dimension dim = list[0].getPreferredSize ();
       Dimension vp = getViewportSize ();
 
       if (dim.width < vp.width)
@@ -462,31 +477,16 @@
       if (peer != null)
 	peer.childResized (dim.width, dim.height);
 
-      list[0].resize (dim);
+      list[0].setSize (dim);
 
-      Point p = getScrollPosition();
+      Point p = getScrollPosition ();
       if (p.x > dim.width)
         p.x = dim.width;
       if (p.y > dim.height)
         p.y = dim.height;
 
-      setScrollPosition(p);
+      setScrollPosition (p);
     }
-}
-
-/*************************************************************************/
-
-/**
-  * Lays out this component.  This consists of resizing the sole child
-  * component to its perferred size.
-  *
-  * @deprecated This method is deprecated in favor of
-  * <code>doLayout()</code>.
-  */
-public void
-layout()
-{
-  doLayout();
 }
 
 /*************************************************************************/
Index: java/awt/Scrollbar.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Scrollbar.java,v
retrieving revision 1.15
diff -u -r1.15 Scrollbar.java
--- java/awt/Scrollbar.java	5 Jun 2003 19:58:39 -0000	1.15
+++ java/awt/Scrollbar.java	2 Feb 2004 17:41:49 -0000
@@ -333,7 +333,7 @@
 public int
 getVisibleAmount()
 {
-  return(visibleAmount);
+  return getVisible ();
 }
 
 /*************************************************************************/
@@ -350,7 +350,7 @@
 public int
 getVisible()
 {
-  return(getVisibleAmount());
+  return visibleAmount;
 }
 
 /*************************************************************************/
@@ -438,7 +438,7 @@
 public int
 getUnitIncrement()
 {
-  return(lineIncrement);
+  return getLineIncrement ();
 }
 
 /*************************************************************************/
@@ -455,7 +455,7 @@
 public int
 getLineIncrement()
 {
-  return(lineIncrement);
+  return lineIncrement;
 }
 
 /*************************************************************************/
@@ -469,26 +469,7 @@
 public synchronized void
 setUnitIncrement(int unitIncrement)
 {
-  if (unitIncrement < 0)
-    throw new IllegalArgumentException("Unit increment less than zero.");
-
-  int range = maximum - minimum;
-  if (unitIncrement > range)
-    {
-      if (range == 0)
-        unitIncrement = 1;
-      else
-        unitIncrement = range;
-    }
-
-  if (unitIncrement == lineIncrement)
-    return;
-
-  lineIncrement = unitIncrement;
-
-  ScrollbarPeer sp = (ScrollbarPeer)getPeer();
-  if (sp != null)
-    sp.setLineIncrement(lineIncrement);
+  setLineIncrement (unitIncrement);
 }
 
 /*************************************************************************/
@@ -505,7 +486,26 @@
 public void
 setLineIncrement(int lineIncrement)
 {
-  setUnitIncrement(lineIncrement);
+  if (lineIncrement < 0)
+    throw new IllegalArgumentException ("Unit increment less than zero.");
+
+  int range = maximum - minimum;
+  if (lineIncrement > range)
+    {
+      if (range == 0)
+        lineIncrement = 1;
+      else
+        lineIncrement = range;
+    }
+
+  if (lineIncrement == this.lineIncrement)
+    return;
+
+  this.lineIncrement = lineIncrement;
+
+  ScrollbarPeer sp = (ScrollbarPeer) getPeer ();
+  if (sp != null)
+    sp.setLineIncrement (this.lineIncrement);
 }
 
 /*************************************************************************/
@@ -519,7 +519,7 @@
 public int
 getBlockIncrement()
 {
-  return(pageIncrement);
+  return getPageIncrement ();
 }
 
 /*************************************************************************/
@@ -536,7 +536,7 @@
 public int
 getPageIncrement()
 {
-  return(pageIncrement);
+  return pageIncrement;
 }
 
 /*************************************************************************/
@@ -550,26 +550,7 @@
 public synchronized void
 setBlockIncrement(int blockIncrement)
 {
-  if (blockIncrement < 0)
-    throw new IllegalArgumentException("Block increment less than zero.");
-
-  int range = maximum - minimum;
-  if (blockIncrement > range)
-    {
-      if (range == 0)
-        blockIncrement = 1;
-      else
-        blockIncrement = range;
-    }
-
-  if (blockIncrement == pageIncrement)
-    return;
-
-  pageIncrement = blockIncrement;
-
-  ScrollbarPeer sp = (ScrollbarPeer)getPeer();
-  if (sp != null)
-    sp.setPageIncrement(pageIncrement);
+  setPageIncrement (pageIncrement);
 }
 
 /*************************************************************************/
@@ -586,7 +567,26 @@
 public void
 setPageIncrement(int pageIncrement)
 {
-  setBlockIncrement(pageIncrement);
+  if (pageIncrement < 0)
+    throw new IllegalArgumentException ("Block increment less than zero.");
+
+  int range = maximum - minimum;
+  if (pageIncrement > range)
+    {
+      if (range == 0)
+        pageIncrement = 1;
+      else
+        pageIncrement = range;
+    }
+
+  if (pageIncrement == this.pageIncrement)
+    return;
+
+  this.pageIncrement = pageIncrement;
+
+  ScrollbarPeer sp = (ScrollbarPeer) getPeer ();
+  if (sp != null)
+    sp.setPageIncrement (this.pageIncrement);
 }
 
 /*************************************************************************/
Index: java/awt/TextArea.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/TextArea.java,v
retrieving revision 1.9
diff -u -r1.9 TextArea.java
--- java/awt/TextArea.java	25 Jan 2004 18:36:04 -0000	1.9
+++ java/awt/TextArea.java	2 Feb 2004 17:41:49 -0000
@@ -288,13 +288,7 @@
    */
   public Dimension getMinimumSize (int rows, int columns)
   {
-    TextAreaPeer peer = (TextAreaPeer) getPeer ();
-
-    // Sun returns Dimension (0,0) in this case.
-    if (peer == null)
-      return new Dimension (0, 0);
-
-    return peer.getMinimumSize (rows, columns);
+    return minimumSize (rows, columns);
   }
 
   /**
@@ -311,7 +305,7 @@
    */
   public Dimension minimumSize ()
   {
-    return getMinimumSize (getRows (), getColumns ());
+    return minimumSize (getRows (), getColumns ());
   }
 
   /**
@@ -333,7 +327,13 @@
    */
   public Dimension minimumSize (int rows, int columns)
   {
-    return getMinimumSize (rows, columns);
+    TextAreaPeer peer = (TextAreaPeer) getPeer ();
+
+    // Sun returns Dimension (0,0) in this case.
+    if (peer == null)
+      return new Dimension (0, 0);
+
+    return peer.getMinimumSize (rows, columns);
   }
 
   /**
@@ -366,13 +366,7 @@
    */
   public Dimension getPreferredSize (int rows, int columns)
   {
-    TextAreaPeer peer = (TextAreaPeer) getPeer ();
-
-    // Sun returns Dimension (0,0) in this case.
-    if (peer == null)
-      return new Dimension (0, 0);
-
-    return peer.getPreferredSize (rows, columns);
+    return preferredSize (rows, columns);
   }
 
   /**
@@ -389,7 +383,7 @@
    */
   public Dimension preferredSize ()
   {
-    return getPreferredSize (getRows (), getColumns ());
+    return preferredSize (getRows (), getColumns ());
   }
 
   /**
@@ -411,7 +405,13 @@
    */
   public Dimension preferredSize (int rows, int columns)
   {
-    return getPreferredSize (rows, columns);
+    TextAreaPeer peer = (TextAreaPeer) getPeer ();
+
+    // Sun returns Dimension (0,0) in this case.
+    if (peer == null)
+      return new Dimension (0, 0);
+
+    return peer.getPreferredSize (rows, columns);
   }
 
   /**
@@ -440,59 +440,59 @@
   /**
    * Append the specified text to the end of the current text.
    *
-   * @param text The text to append.
+   * @param str The text to append.
    */
   public void append (String str)
   {
-    TextAreaPeer peer = (TextAreaPeer) getPeer ();
-    if (peer == null)
-      return;
-
-    peer.insert (str, peer.getText().length ());
+    appendText (str);
   }
 
   /**
    * Append the specified text to the end of the current text.
    *
-   * @param text The text to append.
+   * @param str The text to append.
    *
    * @deprecated This method is deprecated in favor of
    * <code>append ()</code>.
    */
-  public void appendText (String text)
+  public void appendText (String str)
   {
-    append (text);
+    TextAreaPeer peer = (TextAreaPeer) getPeer ();
+    if (peer == null)
+      return;
+
+    peer.insert (str, peer.getText().length ());
   }
 
   /**
    * Insert the specified text at the specified position.  The first
    * character in the text area is at position zero.
    *
-   * @param text The text to insert.
+   * @param str The text to insert.
    * @param pos The position at which to insert text.
    */
-  public void insert (String text, int pos)
+  public void insert (String str, int pos)
   {
-    TextAreaPeer peer = (TextAreaPeer) getPeer ();
-    if (peer == null)
-      return;
-
-    peer.insert (text, pos);
+    insertText (str, pos);
   }
 
   /**
    * Insert the specified text at the specified position.  The first
    * character in the text area is at position zero.
    *
-   * @param text The text to insert.
+   * @param str The text to insert.
    * @param pos The position at which to insert text.
    *
-   * @deprecated This method is depcreated in favor of
+   * @deprecated This method is deprecated in favor of
    * <code>insert ()</code>.
    */
-  public void insertText (String text, int pos)
+  public void insertText (String str, int pos)
   {
-    insert (text, pos);
+    TextAreaPeer peer = (TextAreaPeer) getPeer ();
+    if (peer == null)
+      return;
+
+    peer.insert (str, pos);
   }
 
   /**
@@ -503,17 +503,13 @@
    * length of the replacement text may differ from the length of the
    * text that is replaced.
    *
-   * @param text The new text for the range.
+   * @param str The new text for the range.
    * @param start The start position of the replacement range.
    * @param end The end position of the replacement range.
    */
-  public void replaceRange (String text, int start, int end)
+  public void replaceRange (String str, int start, int end)
   {
-    TextAreaPeer peer = (TextAreaPeer) getPeer ();
-    if (peer == null)
-      return;
-
-    peer.replaceRange (text, start, end);
+    replaceText (str, start, end);
   }
 
   /**
@@ -524,16 +520,20 @@
    * length of the replacement text may differ from the length of the
    * text that is replaced.
    *
-   * @param text The new text for the range.
+   * @param str The new text for the range.
    * @param start The start position of the replacement range.
    * @param end The end position of the replacement range.
    *
    * @deprecated This method is deprecated in favor of
    * <code>replaceRange ()</code>.
    */
-  public void replaceText (String text, int start, int end)
+  public void replaceText (String str, int start, int end)
   {
-    replaceRange (text, start, end);
+    TextAreaPeer peer = (TextAreaPeer) getPeer ();
+    if (peer == null)
+      return;
+
+    peer.replaceRange (str, start, end);
   }
 
   /**
Index: java/awt/TextField.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/TextField.java,v
retrieving revision 1.8
diff -u -r1.8 TextField.java
--- java/awt/TextField.java	5 Jun 2003 19:58:39 -0000	1.8
+++ java/awt/TextField.java	2 Feb 2004 17:41:49 -0000
@@ -212,11 +212,7 @@
 public void
 setEchoChar(char echoChar)
 {
-  this.echoChar = echoChar;
-
-  TextFieldPeer tfp = (TextFieldPeer)getPeer();
-  if (tfp != null)
-    tfp.setEchoChar(echoChar);
+  setEchoCharacter (echoChar);
 }
 
 /*************************************************************************/
@@ -233,7 +229,11 @@
 public void
 setEchoCharacter(char echoChar)
 {
-  setEchoChar(echoChar);
+  this.echoChar = echoChar;
+
+  TextFieldPeer peer = (TextFieldPeer) getPeer ();
+  if (peer != null)
+    peer.setEchoChar (echoChar);
 }
 
 /*************************************************************************/
@@ -264,7 +264,7 @@
 public Dimension
 getMinimumSize()
 {
-  return(getMinimumSize(getColumns()));
+  return getMinimumSize (getColumns ());
 }
 
 /*************************************************************************/
@@ -278,11 +278,7 @@
 public Dimension
 getMinimumSize(int columns)
 {
-  TextFieldPeer tfp = (TextFieldPeer)getPeer();
-  if (tfp == null)
-    return(null); // FIXME: What do we do if there is no peer?
-
-  return(tfp.getMinimumSize(columns));
+  return minimumSize (columns);
 }
 
 /*************************************************************************/
@@ -292,13 +288,13 @@
   *
   * @return The minimum size for this text field.
   *
-  * @deprecated This method is depcreated in favor of
+  * @deprecated This method is deprecated in favor of
   * <code>getMinimumSize()</code>.
   */
 public Dimension
 minimumSize()
 {
-  return(getMinimumSize(getColumns()));
+  return minimumSize (getColumns ());
 }
 
 /*************************************************************************/
@@ -315,7 +311,11 @@
 public Dimension
 minimumSize(int columns)
 {
-  return(getMinimumSize(columns));
+  TextFieldPeer peer = (TextFieldPeer) getPeer ();
+  if (peer == null)
+    return null; // FIXME: What do we do if there is no peer?
+
+  return peer.getMinimumSize (columns);
 }
 
 /*************************************************************************/
@@ -328,7 +328,7 @@
 public Dimension
 getPreferredSize()
 {
-  return(getPreferredSize(getColumns()));
+  return getPreferredSize (getColumns ());
 }
 
 /*************************************************************************/
@@ -342,12 +342,7 @@
 public Dimension
 getPreferredSize(int columns)
 {
-  TextFieldPeer tfp = (TextFieldPeer)getPeer();
-  if (tfp == null)
-    {
-      return new Dimension(0, 0);
-    }
-  return(tfp.getPreferredSize(columns));
+  return preferredSize (columns);
 }
 
 /*************************************************************************/
@@ -363,7 +358,7 @@
 public Dimension
 preferredSize()
 {
-  return(getPreferredSize(getColumns()));
+  return preferredSize (getColumns ());
 }
 
 /*************************************************************************/
@@ -380,7 +375,11 @@
 public Dimension
 preferredSize(int columns)
 {
-  return(getPreferredSize(columns));
+  TextFieldPeer peer = (TextFieldPeer) getPeer ();
+  if (peer == null)
+    return new Dimension (0, 0);
+
+  return peer.getPreferredSize (columns);
 }
 
 /*************************************************************************/
Index: java/awt/image/renderable/RenderContext.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/image/renderable/RenderContext.java,v
retrieving revision 1.1
diff -u -r1.1 RenderContext.java
--- java/awt/image/renderable/RenderContext.java	9 Aug 2002 04:29:59 -0000	1.1
+++ java/awt/image/renderable/RenderContext.java	2 Feb 2004 17:41:49 -0000
@@ -87,24 +87,24 @@
 
   public void preConcatenateTransform(AffineTransform pre)
   {
-    xform.preConcatenate(pre);
+    preConcetenateTransform (pre);
   }
 
-  /** @deprecated Sun can't spell concatenate */
+  /** @deprecated */
   public void preConcetenateTransform(AffineTransform pre)
   {
-    preConcetenateTransform(pre);
+    xform.preConcatenate (pre);
   }
 
   public void concatenateTransform(AffineTransform post)
   {
-    xform.concatenate(post);
+    concetenateTransform (post);
   }
 
-  /** @deprecated Sun can't spell concatenate */
+  /** @deprecated */
   public void concetenateTransform(AffineTransform post)
   {
-    concatenateTransform(post);
+    xform.concatenate (post);
   }
 
   public AffineTransform getTransform()
Index: javax/swing/JApplet.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/javax/swing/JApplet.java,v
retrieving revision 1.2
diff -u -r1.2 JApplet.java
--- javax/swing/JApplet.java	11 Jun 2003 13:20:39 -0000	1.2
+++ javax/swing/JApplet.java	2 Feb 2004 17:41:50 -0000
@@ -80,7 +80,7 @@
   public Dimension getPreferredSize()
   {
     Dimension d = super.getPreferredSize();
-    System.out.println("JFrame.getPrefSize(): " + d + " , comp="+countComponents() + ", layout=" + getLayout());
+    System.out.println("JFrame.getPrefSize(): " + d + " , comp="+ getComponentCount () + ", layout=" + getLayout());
     return d;
   }
 

--=-0c0P5AmxUYxnapg5GNNC--




From MAILER-DAEMON Mon Feb 02 16:07:41 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnlG2-0000o7-K0
	for mharc-classpath@gnu.org; Mon, 02 Feb 2004 16:05:26 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnlFi-0000gn-3j
	for classpath@gnu.org; Mon, 02 Feb 2004 16:05:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AnlEo-0000DL-DK
	for classpath@gnu.org; Mon, 02 Feb 2004 16:04:42 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AnlEn-00009o-Pi
	for classpath@gnu.org; Mon, 02 Feb 2004 16:04:09 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i12L43b19795;
	Mon, 2 Feb 2004 16:04:03 -0500
Received: from redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i12L42a04912; 
	Mon, 2 Feb 2004 16:04:03 -0500
Message-ID: <401EBB40.9000803@redhat.com>
Date: Mon, 02 Feb 2004 16:04:00 -0500
From: graydon hoare <graydon@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.6b) Gecko/20031205 Thunderbird/0.4
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: java-patches@gcc.gnu.org
Content-Type: multipart/mixed; boundary="------------050303040701080705020509"
Cc: classpath@gnu.org
Subject: [PATCH] fixes to LightweightDispatcher and SwingUtilities
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Feb 2004 21:05:09 -0000

This is a multi-part message in MIME format.
--------------050303040701080705020509
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

hi,

this patch implements and documents a number of functions in the 
javax.swing.SwingUtilities class, and updates 
java.awt.Container.LightweightDispatcher to use them. this corrects 
several behavioral bugs in the LightweightDispatcher, and moves most of 
the component-position arithmetic into the utility class, where it can 
be reused in other swing component logic.

it also includes a small touchup to the 
javax.swing.plaf.basic.BasicGraphicsUtils, which uses a method in 
SwingUtilities to perform layout, and has to call it slightly more 
carefully now.

ok to commit?

-graydon

2004-02-02  Graydon Hoare  <graydon@redhat.com>

	* javax/swing/SwingUtilities.java: Many new functions.
	* java/awt/Container.java (LightweightDispatcher): Reimplement.
	* javax/swing/basic/BasicGraphicsUtils.java
	(getPreferredButtonSize): Start layout from top-left corner.


--------------050303040701080705020509
Content-Type: text/x-patch;
 name="j2d-swingutils-and-dispatcher.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="j2d-swingutils-and-dispatcher.patch"

--- java/awt/Container.java	26 Jan 2004 21:55:41 -0000	1.32
+++ java/awt/Container.java	2 Feb 2004 20:53:03 -0000
@@ -52,6 +52,7 @@
 import java.util.EventListener;
 import java.util.Set;
 import javax.accessibility.Accessible;
+import javax.swing.SwingUtilities;
 
 /**
  * A generic window toolkit object that acts as a container for other objects.
@@ -1541,54 +1542,59 @@
     nativeContainer = c;
   }
 
-  void dispose()
-  {
-  }
-
   void enableEvents(long l)
   {
     eventMask |= l;
   }
 
-  void mouseExit (MouseEvent me, int x, int y)
-  {
-  }
-
   void acquireComponentForMouseEvent (MouseEvent me)
   {
     int x = me.getX ();
     int y = me.getY ();
-
     Component candidate = mouseEventTarget;
 
-    boolean candidate_is_container_with_children = 
-      ((candidate != null)
-       && (candidate instanceof Container)
-       && (((Container)candidate).getComponentCount () > 0));
-
-    boolean candidate_does_not_contain_point =
-      ((candidate != null)
-       && (! candidate.contains (x - candidate.getX (),
-                                 y - candidate.getY ())));
-
-    if (candidate == null
-        || candidate_is_container_with_children
-        || candidate_does_not_contain_point)
+    while(candidate != null)
+      {
+        if (candidate.isShowing())
+          {
+            // Convert our point to the candidate's parent's space.
+            Point cp = SwingUtilities.convertPoint(nativeContainer, x, y, candidate);
+            
+            // If the event lands inside candidate, we have a hit.
+            if (candidate.contains(cp.x, cp.y))
       {
-        // Try to reacquire.
-        candidate = nativeContainer.findComponentAt (x, y);
+                // If candidate has children, we refine the hit.
+                if (candidate instanceof Container &&
+                    ((Container)candidate).getComponentCount() > 0)              
+                  candidate = SwingUtilities.getDeepestComponentAt(candidate, cp.x, cp.y);
+                break;
+              }
+          }        
+        // If candidate isn't showing or doesn't contain point, we back out a level.
+        candidate = candidate.getParent();
+      }
+    
+    if (candidate == null)
+      {
+        // We either lost, or never had, a candidate; acquire from our native.
+        candidate = 
+          SwingUtilities.getDeepestComponentAt(nativeContainer, x, y);
       }
 
+
+    // If our candidate is new, inform the old target we're leaving.
     if (mouseEventTarget != null
+        && mouseEventTarget.isShowing()
         && mouseEventTarget != candidate)
       {
-        int nx = x - mouseEventTarget.getX ();
-        int ny = y - mouseEventTarget.getY ();
+        Point tp = 
+          SwingUtilities.convertPoint(nativeContainer, 
+                                      x, y, mouseEventTarget);
         MouseEvent exited = new MouseEvent (mouseEventTarget, 
                                             MouseEvent.MOUSE_EXITED,
                                             me.getWhen (), 
                                             me.getModifiers (), 
-                                            nx, ny,
+                                            tp.x, tp.y,
                                             me.getClickCount (),
                                             me.isPopupTrigger (),
                                             me.getButton ());
@@ -1596,25 +1602,22 @@
         mouseEventTarget = null;
       }
 
+    // If we have a candidate, maybe enter it.
     if (candidate != null)
       {
-        // Possibly set new state.
         if (candidate.isLightweight() 
+            && candidate.isShowing()
             && candidate != nativeContainer
             && candidate != mouseEventTarget)
 	  {
-			
             mouseEventTarget = candidate;
-			
-            int nx = x - mouseEventTarget.getX ();
-            int ny = y - mouseEventTarget.getY ();
-			
-            // If acquired, enter it.
+            Point cp = SwingUtilities.convertPoint(nativeContainer, 
+                                                   x, y, candidate);
             MouseEvent entered = new MouseEvent (mouseEventTarget, 
                                                  MouseEvent.MOUSE_ENTERED,
                                                  me.getWhen (), 
                                                  me.getModifiers (), 
-                                                 nx, ny,
+                                                 cp.x, cp.y,
                                                  me.getClickCount (),
                                                  me.isPopupTrigger (),
                                                  me.getButton ());
@@ -1633,22 +1636,15 @@
         MouseEvent me = (MouseEvent) e;
         acquireComponentForMouseEvent (me);
 
-        // Avoid dispatching an ENTERED event twice
+        // Avoid dispatching an ENTERED event twice.
         if (mouseEventTarget != null
+            && mouseEventTarget.isShowing()
             && e.getID() != MouseEvent.MOUSE_ENTERED)
           {
-            // Calculate point translation for the event target.
-            // We use absolute location on screen rather than relative
-            // location because the event target might be a nested child.
-            Point parentLocation = nativeContainer.getLocationOnScreen();
-            Point childLocation = mouseEventTarget.getLocationOnScreen();
-            me.translatePoint(parentLocation.x - childLocation.x,
-                              parentLocation.y - childLocation.y);
-
-            Component oldSource = (Component) me.getSource ();
-            me.setSource (mouseEventTarget);
-            mouseEventTarget.dispatchEvent (me);
-            me.setSource (oldSource);
+            MouseEvent newEvt = 
+              SwingUtilities.convertMouseEvent(nativeContainer, me, 
+                                               mouseEventTarget);
+            mouseEventTarget.dispatchEvent(newEvt);
           }
       }
     else if (e instanceof KeyEvent && focus != null)
--- javax/swing/plaf/basic/BasicGraphicsUtils.java	27 Jan 2004 18:55:11 -0000	1.6
+++ javax/swing/plaf/basic/BasicGraphicsUtils.java	2 Feb 2004 20:53:03 -0000
@@ -614,8 +614,8 @@
       b.getToolkit().getFontMetrics(b.getFont()), // see comment above
       b.getText(),
       b.getIcon(),
-      b.getVerticalAlignment(),
-      b.getHorizontalAlignment(),
+      SwingUtilities.TOP,    // important:
+      SwingUtilities.LEFT,   // large vrect, stick to the top left
       b.getVerticalTextPosition(),
       b.getHorizontalTextPosition(),
       viewRect, iconRect, textRect,
--- javax/swing/SwingUtilities.java	22 Jan 2004 09:54:15 -0000	1.4
+++ javax/swing/SwingUtilities.java	2 Feb 2004 20:53:03 -0000
@@ -35,10 +35,11 @@
 obligated to do so.  If you do not wish to do so, delete this
 exception statement from your version. */
 
-
 package javax.swing;
 
+import java.applet.Applet;
 import java.awt.Component;
+import java.awt.ComponentOrientation;
 import java.awt.Container;
 import java.awt.EventQueue;
 import java.awt.Font;
@@ -55,81 +56,623 @@
 import javax.accessibility.Accessible;
 import javax.accessibility.AccessibleStateSet;
 
+
+/**
+ * This class contains a number of static utility functions which are
+ * useful when drawing swing components, dispatching events, or calculating
+ * regions which need painting.
+ *
+ * @author Graydon Hoare (graydon&064;redhat.com)
+ */
 public class SwingUtilities implements SwingConstants
 {
+
+  /**
+   * Calculates the portion of the base rectangle which is inside the
+   * insets.
+   *
+   * @param base The rectangle to apply the insets to
+   * @param insets The insets to apply to the base rectangle
+   * @param ret A rectangle to use for storing the return value, or
+   * <code>null</code>
+   *
+   * @return The calculated area inside the base rectangle and its insets,
+   * either stored in ret or a new Rectangle if ret is <code>null</code>
+   *
+   * @see #calculateInnerArea
+   */
+  public static Rectangle calculateInsetArea(Rectangle base, Insets insets,
+                                             Rectangle ret)
+  {
+    if (ret == null)
+      ret = new Rectangle();
+    ret.setBounds(base.x + insets.left, base.y + insets.top,
+                  base.width - (insets.left + insets.right),
+                  base.height - (insets.top + insets.bottom));
+    return ret;
+  }
+
+  /**
+   * Calculates the portion of the component's bounds which is inside the
+   * component's border insets. This area is usually the area a component
+   * should confine its painting to.
+   *
+   * @param c The component to measure the bounds of
+   * @param r A Rectangle to store the return value in, or
+   * <code>null</code>
+   *
+   * @return The calculated area inside the component and its border
+   * insets
+   *
+   * @see #calculateInsetArea
+   */
+  public static Rectangle calculateInnerArea(JComponent c, Rectangle r)
+  {
+    return calculateInsetArea(c.getBounds(), c.getInsets(), r);
+  }
+
+  /**
+   * Calculates the bounds of a component in the component's own coordinate
+   * space. The result has the same height and width as the component's
+   * bounds, but its location is set to (0,0).
+   *
+   * @param aComponent The component to measure
+   *
+   * @return The component's bounds in its local coordinate space
+   */
+  public static Rectangle getLocalBounds(Component aComponent)
+  {
+    Rectangle bounds = aComponent.getBounds();
+    return new Rectangle(0, 0, bounds.x, bounds.y);
+  }
+
+  /**
+   * Returns the font metrics object for a given font. The metrics can be
+   * used to calculate crude bounding boxes and positioning information,
+   * for laying out components with textual elements.
+   *
+   * @param font The font to get metrics for
+   *
+   * @return The font's metrics
+   *
+   * @see java.awt.font.GlyphMetrics
+   */
   public static FontMetrics getFontMetrics (Font font)
   {
     return Toolkit.getDefaultToolkit ().getFontMetrics (font);
   }
 
-  public static JRootPane getRootPane (Component a)
+  /**
+   * If <code>comp</code> is a RootPaneContainer, return its JRootPane.
+   * Otherwise call <code>getAncestorOfClass(JRootPane.class, a)</code>.
+   *
+   * @param comp The component to get the JRootPane of
+   *
+   * @return a suitable JRootPane for <code>comp</code>, or <code>null</code>
+   * 
+   * @see javax.swing.RootPaneContainer#getRootPane
+   * @see #getAncestorOfClass
+   */
+  public static JRootPane getRootPane(Component comp)
   {
-    if (a instanceof JRootPane)
-      return (JRootPane) a;
+    if (comp instanceof RootPaneContainer)
+      return ((RootPaneContainer)comp).getRootPane();
+    else
+      return (JRootPane) getAncestorOfClass(JRootPane.class, comp);
+  }
 	
-    a = a.getParent();
+  /**
+   * Returns the least ancestor of <code>comp</code> which has the
+   * specified name.
+   *
+   * @param name The name to search for
+   * @param comp The component to search the ancestors of
+   *
+   * @return The nearest ancestor of <code>comp</code> with the given
+   * name, or <code>null</code> if no such ancestor exists
+   *
+   * @see java.awt.Component#getName
+   * @see #getAncestorOfClass
+   */
+  public static Container getAncestorNamed(String name, Component comp)
+  {
+    while (comp != null && (comp.getName() != name))
+      comp = comp.getParent();
+    return (Container) comp;
+  }
 
-    if (a != null)
+  /**
+   * Returns the least ancestor of <code>comp</code> which is an instance
+   * of the specified class.
+   *
+   * @param c The class to search for
+   * @param comp The component to search the ancestors of
+   *
+   * @return The nearest ancestor of <code>comp</code> which is an instance
+   * of the given class, or <code>null</code> if no such ancestor exists
+   *
+   * @see #getAncestorOfClass
+   * @see #windowForComponent
+   * @see 
+   * 
+   */
+  public static Container getAncestorOfClass(Class c, Component comp)
       {
-        return getRootPane(a);
+    while (comp != null && (! c.isInstance(comp)))
+      comp = comp.getParent();
+    return (Container) comp;
       }
     
+  /**
+   * Equivalent to calling <code>getAncestorOfClass(Window, comp)</code>.
+   *
+   * @param comp The component to search for an ancestor window 
+   *
+   * @return An ancestral window, or <code>null</code> if none exists
+   */
+  public static Window windowForComponent(Component comp)
+  {
+    return (Window) getAncestorOfClass(Window.class, comp);
+  }
+
+  /**
+   * Returns the "root" of the component tree containint <code>comp</code>
+   * The root is defined as either the <em>least</em> ancestor of
+   * <code>comp</code> which is a {@link Window}, or the <em>greatest</em>
+   * ancestor of <code>comp</code> which is a {@link Applet} if no {@link
+   * Window} ancestors are found.
+   *
+   * @param comp The component to search for a root
+   *
+   * @return The root of the component's tree, or <code>null</code>
+   */
+  public static Component getRoot(Component comp)
+  {
+    Applet app = null;
+    Window win = null;
+
+    while (comp != null)
+      {
+        if (win == null && comp instanceof Window)
+          win = (Window) comp;
+        else if (comp instanceof Applet)
+          app = (Applet) comp;
+        comp = comp.getParent();
+      }
+
+    if (win != null)
+      return win;
+    else
+      return app;
+  }
+
+  /**
+   * Return true if a descends from b, in other words if b is an
+   * ancestor of a.
+   *
+   * @param a The child to search the ancestry of
+   * @param b The potential ancestor to search for
+   *
+   * @return true if a is a descendent of b, false otherwise
+   */
+  public static boolean isDescendingFrom(Component a, Component b)
+  {
+    while (true)
+      {
+        if (a == null || b == null)
+          return false;
+        if (a == b)
+          return true;
+        a = a.getParent();
+      }
+  }
+
+  /**
+   * Returns the deepest descendent of parent which is both visible and
+   * contains the point <code>(x,y)</code>. Returns parent when either
+   * parent is not a container, or has no children which contain
+   * <code>(x,y)</code>. Returns <code>null</code> when either
+   * <code>(x,y)</code> is outside the bounds of parent, or parent is
+   * <code>null</code>.
+   * 
+   * @param parent The component to search the descendents of
+   * @param x Horizontal coordinate to search for
+   * @param y Vertical coordinate to search for
+   *
+   * @return A component containing <code>(x,y)</code>, or
+   * <code>null</code>
+   *
+   * @see java.awt.Container#findComponentAt
+   */
+  public static Component getDeepestComponentAt(Component parent, int x, int y)
+  {
+    if (parent == null || (! parent.contains(x, y)))
     return null;
+
+    if (! (parent instanceof Container))
+      return parent;
+
+    Container c = (Container) parent;
+    return c.findComponentAt(x, y);
   }
 
-  public static void updateComponentTreeUI(JFrame comp)
+  /**
+   * Converts a point from a component's local coordinate space to "screen"
+   * coordinates (such as the coordinate space mouse events are delivered
+   * in). This operation is equivalent to translating the point by the
+   * location of the component (which is the origin of its coordinate
+   * space).
+   *
+   * @param p The point to convert
+   * @param c The component which the point is expressed in terms of
+   *
+   * @see convertPointFromScreen
+   */
+  public static void convertPointToScreen(Point p, Component c)
   {
+    Point c0 = c.getLocationOnScreen();
+    p.translate(c0.x, c0.y);
   }
 
-  public static String layoutCompoundLabel(JComponent c, 
-                                           FontMetrics fm,
-                                           String text,
-                                           Icon i,
-                                           int vert_a, 
-                                           int hor_i, 
-                                           int vert_text_pos,
-                                           int hor_text_pos, 
-                                           Rectangle vr,
-                                           Rectangle ir, 
-                                           Rectangle tr,
-                                           int gap)
+  /**
+   * Converts a point from "screen" coordinates (such as the coordinate
+   * space mouse events are delivered in) to a component's local coordinate
+   * space. This operation is equivalent to translating the point by the
+   * negation of the component's location (which is the origin of its
+   * coordinate space).
+   *
+   * @param p The point to convert
+   * @param c The component which the point should be expressed in terms of
+   */
+  public static void convertPointFromScreen(Point p, Component c)
+  {
+    Point c0 = c.getLocationOnScreen();
+    p.translate(-c0.x, -c0.y);
+  }
+
+  /**
+   * Converts a point <code>(x,y)</code> from the coordinate space of one
+   * component to another. This is equivalent to converting the point from
+   * <code>source</code> space to screen space, then back from screen space
+   * to <code>destination</code> space. If exactly one of the two
+   * Components is <code>null</code>, it is taken to refer to the root
+   * ancestor of the other component. If both are <code>null</code>, no
+   * transformation is done.
+   *
+   * @param source The component which the point is expressed in terms of
+   * @param x Horizontal coordinate of point to transform
+   * @param y Vertical coordinate of point to transform
+   * @param destination The component which the return value will be
+   * expressed in terms of
+   *
+   * @return The point <code>(x,y)</code> converted from the coordinate space of the
+   * source component to the coordinate space of the destination component
+   *
+   * @see #convertPointToScreen
+   * @see #convertPointFromScreen
+   * @see #convertRectangle
+   * @see #getRoot
+   */
+  public static Point convertPoint(Component source, int x, int y,
+                                   Component destination)
+  {
+    Point pt = new Point(x, y);
+
+    if (source == null && destination == null)
+      return pt;
+
+    if (source == null)
+      source = getRoot(destination);
+
+    if (destination == null)
+      destination = getRoot(source);
+
+    convertPointToScreen(pt, source);
+    convertPointFromScreen(pt, destination);
+
+    return pt;
+  }
+
+  
+  /**
+   * Converts a rectangle from the coordinate space of one component to
+   * another. This is equivalent to converting the rectangle from
+   * <code>source</code> space to screen space, then back from screen space
+   * to <code>destination</code> space. If exactly one of the two
+   * Components is <code>null</code>, it is taken to refer to the root
+   * ancestor of the other component. If both are <code>null</code>, no
+   * transformation is done.
+   *
+   * @param source The component which the rectangle is expressed in terms of
+   * @param rect The rectangle to convert
+   * @param destination The component which the return value will be
+   * expressed in terms of
+   *
+   * @return A new rectangle, equal in size to the input rectangle, but
+   * with its position converted from the coordinate space of the source
+   * component to the coordinate space of the destination component
+   *
+   * @see #convertPointToScreen
+   * @see #convertPointFromScreen
+   * @see #convertPoint
+   * @see #getRoot
+   */
+  public static Rectangle convertRectangle(Component source,
+                                           Rectangle rect,
+                                           Component destination)
   {
-    // view rect 'vr' already ok, 
-    // we need to compute ir (icon rect) and tr (text-rect)
+    Point pt = convertPoint(source, rect.x, rect.y, destination);
+    return new Rectangle(pt.x, pt.y, rect.width, rect.height);
+  }
 	
-    int next_x = vr.x;
-    int next_y = vr.y;
+  /**
+   * Convert a mouse event which refrers to one component to another.  This
+   * includes changing the mouse event's coordinate space, as well as the
+   * source property of the event. If <code>source</code> is
+   * <code>null</code>, it is taken to refer to <code>destination</code>'s
+   * root component. If <code>destination</code> is <code>null</code>, the
+   * new event will remain expressed in <code>source</code>'s coordinate
+   * system.
+   *
+   * @param source The component the mouse event currently refers to
+   * @param sourceEvent The mouse event to convert
+   * @param destination The component the new mouse event should refer to
+   *
+   * @return A new mouse event expressed in terms of the destination
+   * component's coordinate space, and with the destination component as
+   * its source
+   *
+   * @see #convertPoint
+   */
+  public static MouseEvent convertMouseEvent(Component source,
+                                             MouseEvent sourceEvent,
+                                             Component destination)
+  {
+    Point newpt = convertPoint(source, sourceEvent.getX(), sourceEvent.getY(),
+                               destination);
 	
-    ir.height = ir.width = ir.y = ir.x = 0;
+    return new MouseEvent(destination, sourceEvent.getID(),
+                          sourceEvent.getWhen(), sourceEvent.getModifiers(),
+                          newpt.x, newpt.y, sourceEvent.getClickCount(),
+                          sourceEvent.isPopupTrigger(), sourceEvent.getButton());
+  }
 
-    if (i != null)
+  /**
+   * Recursively walk the component tree under <code>comp</code> calling
+   * <code>updateUI</code> on each {@link JComponent} found. This causes
+   * the entire tree to re-initialize its UI delegates.
+   *
+   * @param comp The component to walk the children of, calling <code>updateUI</code>
+   */
+  public static void updateComponentTreeUI(Component comp)
       {
-        ir.x = vr.x;
-        ir.y = vr.y;
-        ir.width = i.getIconWidth();
-        ir.height = i.getIconWidth();
+    if (comp == null)
+      return;
 
+    if (comp instanceof Container)
+      {
+        Component[] children = ((Container)comp).getComponents();
+        for (int i = 0; i < children.length; ++i)
+          updateComponentTreeUI(children[i]);
+      }
 
-        next_x += gap + i.getIconWidth();
-        next_y += gap + i.getIconHeight();
+    if (comp instanceof JComponent)
+      ((JComponent)comp).updateUI();
       }
 	
-    tr.x = next_x;
-    tr.y = vr.y; // + (vr.height/2);
+  /**
+   * <p>Layout a "compound label" consisting of a text string and an icon
+   * which is to be placed near the rendered text. Once the text and icon
+   * are laid out, the text rectangle and icon rectangle parameters are
+   * altered to store the calculated positions.</p>
+   *
+   * <p>The size of the text is calculated from the provided font metrics
+   * object.  This object should be the metrics of the font you intend to
+   * paint the label with.</p>
+   *
+   * <p>The position values control where the text is placed relative to
+   * the icon. The horizontal position value should be one of the constants
+   * <code>LEFT</code>, <code>RIGHT</code> or <code>CENTER</code>. The
+   * vertical position value should be one fo the constants
+   * <code>TOP</code>, <code>BOTTOM</code>, <code>CENTER</code>.</p>
+   *
+   * <p>The text-icon gap value controls the number of pixels between the
+   * icon and the text.</p>
+   *
+   * <p>The alignment values control where the text and icon are placed, as
+   * a combined unit, within the view rectangle. The horizontal alignment
+   * value should be one of the constants <code>LEADING</code>,
+   * <code>TRAILING</code>, <code>LEFT</code>, <code>RIGHT</code> or
+   * <code>CENTER</code>. The vertical alignment valus should be one of the
+   * constants <code>TOP</code>, <code>BOTTOM</code> or
+   * <code>CENTER</code>.</p>
+   *
+   * <p>If the <code>LEADING</code> or <code>TRAILING</code> constants are
+   * given for horizontal alignment, they are interpreted relative to the
+   * provided component's orientation property, a constant in the {@link
+   * java.awt.ComponentOrientation} class. For example, if the component's
+   * orientation is <code>LEFT_TO_RIGHT</code>, then the
+   * <code>LEADING</code> alignment is a synonym for <code>LEFT</code> and
+   * the <code>TRAILING</code> alignment is a synonym for
+   * <code>RIGHT</code></p>
+   *
+   * <p>If the text and icon are equal to or larger than the view
+   * rectangle, the horizontal and vertical alignment values have no
+   * affect.</p>
+   *
+   * @param c A component used for its orientation value
+   * @param fm The font metrics used to measure the text
+   * @param text The text to place in the compound label
+   * @param icon The icon to place next to the text
+   * @param verticalAlignment The vertical alignment of the label relative
+   * to its component
+   * @param horizontalAlignment The horizontal alignment of the label
+   * relative to its component
+   * @param verticalTextPosition The vertical position of the label's text
+   * relative to its icon
+   * @param horizontalTextPosition The horizontal position of the label's
+   * text relative to its icon
+   * @param viewR The view rectangle, specifying the area which layout is
+   * constrained to
+   * @param iconR A rectangle which is modified to hold the laid-out
+   * position of the icon
+   * @param textR A rectangle which is modified to hold the laid-out
+   * position of the text
+   * @param textIconGap The distance between text and icon
+   *
+   * @return The string of characters, possibly truncated with an elipsis,
+   * which is laid out in this label
+   */
+  public static String layoutCompoundLabel(JComponent c, 
+                                           FontMetrics fm,
+                                           String text, 
+                                           Icon icon, 
+                                           int verticalAlignment,
+                                           int horizontalAlignment, 
+                                           int verticalTextPosition,
+                                           int horizontalTextPosition, 
+                                           Rectangle viewR,
+                                           Rectangle iconR, 
+                                           Rectangle textR, 
+                                           int textIconGap)
+  {
 
-    tr.width  = fm.stringWidth(text);
-    tr.height = fm.getHeight(); // +  fm.getAscent()/2;
+    // Work out basic height and width.
 
-    return text;
+    if (icon == null)
+      {
+        textIconGap = 0;
+        iconR.width = 0;
+        iconR.height = 0;
+      }
+      else
+      {
+        iconR.width = icon.getIconWidth();
+        iconR.height = icon.getIconWidth();
   }
+    textR.width = fm.stringWidth(text);
+    textR.height = fm.getHeight(); 
 
+    // Work out the position of text and icon, assuming the top-left coord
+    // starts at (0,0). We will fix that up momentarily, after these
+    // "position" decisions are made and we look at alignment.
+
+    switch (horizontalTextPosition)
+      {
+      case LEFT:
+        textR.x = 0;
+        iconR.x = textR.width + textIconGap;
+        break;
+      case RIGHT:
+        iconR.x = 0;
+        textR.x = iconR.width + textIconGap;
+        break;
+      case CENTER:
+        int centerLine = Math.max(textR.width, iconR.width) / 2;
+        textR.x = centerLine - textR.width/2;
+        iconR.x = centerLine - iconR.width/2;
+        break;
 }
 
+    switch (verticalTextPosition)
+      {
+      case TOP:
+        textR.y = 0;
+        iconR.y = textR.height + textIconGap;
+        break;
+      case BOTTOM:
+        iconR.y = 0;
+        textR.y = iconR.height + textIconGap;
+        break;
+      case CENTER:
+        int centerLine = Math.max(textR.height, iconR.height) / 2;
+        textR.y = centerLine - textR.height/2;
+        iconR.y = centerLine - iconR.height/2;
+        break;
+      }
 
+    // Fix up the orientation-based alignments.
 
+    if (horizontalAlignment == LEADING)
+      {
+        if (c.getComponentOrientation() == ComponentOrientation.LEFT_TO_RIGHT)
+          horizontalAlignment = LEFT;
+        else if (c.getComponentOrientation() == ComponentOrientation.RIGHT_TO_LEFT)
+          horizontalAlignment = RIGHT;
+      }
+    else if (horizontalAlignment == TRAILING)
+      {
+        if (c.getComponentOrientation() == ComponentOrientation.LEFT_TO_RIGHT)
+          horizontalAlignment = RIGHT;
+        else if (c.getComponentOrientation() == ComponentOrientation.RIGHT_TO_LEFT)
+          horizontalAlignment = LEFT;
+      }
 
+    // The two rectangles are laid out correctly now, but only assuming
+    // that their upper left corner is at (0,0). If we have any alignment other
+    // than TOP and LEFT, we need to adjust them.
+
+    Rectangle u = textR.union(iconR);
+    int horizontalAdjustment = viewR.x;
+    int verticalAdjustment = viewR.y;
+    switch (verticalAlignment)
+      {
+      case TOP:
+        break;
+      case BOTTOM:
+        verticalAdjustment += (viewR.height - u.height);
+        break;
+      case CENTER:
+        verticalAdjustment += ((viewR.height/2) - (u.height/2));
+        break;
+      }
+    switch (horizontalAlignment)
+      {
+      case LEFT:
+        break;
+      case RIGHT:
+        horizontalAdjustment += (viewR.width - u.width);
+        break;
+      case CENTER:
+        horizontalAdjustment += ((viewR.width/2) - (u.width/2));
+        break;
+      }
 
+    iconR.x += horizontalAdjustment;
+    iconR.y += verticalAdjustment;
 
+    textR.x += horizontalAdjustment;
+    textR.y += verticalAdjustment;
 
+    return text;
+  }
+
+  /** 
+   * Calls {@link java.awt.EventQueue.invokeLater} with the
+   * specified {@link Runnable}. 
+   */
+  public static void invokeLater(Runnable doRun)
+  {
+    java.awt.EventQueue.invokeLater(doRun);
+  }
+
+  /** 
+   * Calls {@link java.awt.EventQueue.invokeAndWait} with the
+   * specified {@link Runnable}. 
+   */
+  public static void invokeAndWait(Runnable doRun)
+    throws InterruptedException,
+    InvocationTargetException
+  {
+    java.awt.EventQueue.invokeAndWait(doRun);
+  }
 
+  /** 
+   * Calls {@link java.awt.EventQueue.isEventDispatchThread}.
+   */
+  public static boolean isEventDispatchThread()
+  {
+    return java.awt.EventQueue.isDispatchThread();
+  }
 
+}

--------------050303040701080705020509--



From MAILER-DAEMON Mon Feb 02 20:59:43 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1Anpqo-0004ik-4D
	for mharc-classpath@gnu.org; Mon, 02 Feb 2004 20:59:42 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1Anpqc-0004cr-E7
	for classpath@gnu.org; Mon, 02 Feb 2004 20:59:30 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1Anpn1-0003GD-A6
	for classpath@gnu.org; Mon, 02 Feb 2004 20:56:18 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1Anpmh-0002tR-26
	for classpath@gnu.org; Mon, 02 Feb 2004 20:55:27 -0500
Received: from fleche.redhat.com (tf0208.peakpeak.com [204.144.239.208])
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id SAA31335;
	Mon, 2 Feb 2004 18:55:23 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 8BFD64F83E2; Mon,  2 Feb 2004 18:45:32 -0700 (MST)
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <1075748783.2449.66.camel@tortoise.toronto.redhat.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Yow!  It's a hole all the way to downtown Burbank!
Date: 02 Feb 2004 18:45:31 -0700
In-Reply-To: <1075748783.2449.66.camel@tortoise.toronto.redhat.com>
Message-ID: <87wu75lyv8.fsf@fleche.redhat.com>
Lines: 14
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath patches <classpath@gnu.org>,
	libgcj patches <java-patches@gcc.gnu.org>
Subject: Re: Patch: fix handling of AWT alias methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 01:59:32 -0000

>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> This patch fixes the way we handle "alias" methods in the AWT, where a
Tom> public or protected method has been deprecated in favour of a new one
Tom> that has the same function but a different name.

Tom> Comments?

Looks and sounds great to me.

Could you update classpath/doc/hacking.texinfo with this information,
so we can refer future classpath hackers to it?

Tom



From MAILER-DAEMON Tue Feb 03 01:49:46 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnuNW-0007IR-1s
	for mharc-classpath@gnu.org; Tue, 03 Feb 2004 01:49:46 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnuNT-0007ID-2g
	for classpath@gnu.org; Tue, 03 Feb 2004 01:49:43 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AnuMx-0006zB-Fk
	for classpath@gnu.org; Tue, 03 Feb 2004 01:49:42 -0500
Received: from [216.102.199.253] (helo=bothner.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AnuMx-0006yy-1r
	for classpath@gnu.org; Tue, 03 Feb 2004 01:49:11 -0500
Received: from bothner.com (persmac [192.168.1.10])
	by bothner.com (8.12.10/8.12.10) with ESMTP id i136oxbr027633
	for <classpath@gnu.org>; Mon, 2 Feb 2004 22:50:59 -0800
Message-ID: <401F4463.8090908@bothner.com>
Date: Mon, 02 Feb 2004 22:49:07 -0800
From: Per Bothner <per@bothner.com>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: classpath@gnu.org
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Subject: preliminary path for MappedByteBuffer and java.nio changes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 06:49:43 -0000

I've been working on implementing java.nio.MappedByteBuffer
and related (I hope) improvements to java.nio.  A patch is
(temporaily) at ftp://bothner.com/pub/libjava.patch . This
is a patch for GCJ, relative to the trunk.

See the "preliminary java.nio with MappedByteBuffer" on the
java-patcehs@gcc.gnu.org mailing list.

The basic idea is as discussed in previous emails:
FileDescriptor isn't much used any more and contains
no native methods; instead FileDescriptorImpl contains
most of the native code for working with files.
Also, note how the natFileChannelImpl.cc #includes
natFileChannel{Posix,Win32,Ecos}.cc depending on
#defines in platform.h, without any symlinks.

MappedByteWork works (at least for read-only mapping)
on both Posix (Fedora Linux) and Win32 (Windows Me).

The ByteBufferHelper methods now take an explicit
ByteOrder parameter.  This is needed because we're
supposed to use the ByteOrder of a ByteBuffer when
the various View classes are created, not whatever
the current ByteOrder of the underlying ByteBuffer.
Also, the DirectByteBuffer getXxx methods now use
ByteBufferHelper.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/





From MAILER-DAEMON Tue Feb 03 01:59:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnuWk-0002M3-9R
	for mharc-classpath@gnu.org; Tue, 03 Feb 2004 01:59:18 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnuWh-0002Lr-CC
	for classpath@gnu.org; Tue, 03 Feb 2004 01:59:15 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AnuWB-00020h-0D
	for classpath@gnu.org; Tue, 03 Feb 2004 01:59:14 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1AnuWA-0001qH-06
	for classpath@gnu.org; Tue, 03 Feb 2004 01:58:42 -0500
Received: from [212.227.126.186] (helo=moutng.kundenserver.de)
	by mx20.gnu.org with esmtp (Exim 4.24) id 1AnuT8-0001lg-IU
	for classpath@gnu.org; Tue, 03 Feb 2004 01:55:34 -0500
Received: from [212.227.126.207] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1AnuT6-00017D-00
	for classpath@gnu.org; Tue, 03 Feb 2004 07:55:32 +0100
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1AnuT6-0002SQ-00
	for classpath@gnu.org; Tue, 03 Feb 2004 07:55:32 +0100
Message-ID: <401F45E3.2090800@aicas.com>
Date: Tue, 03 Feb 2004 07:55:31 +0100
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
CC: classpath patches <classpath@gnu.org>
References: <1075748783.2449.66.camel@tortoise.toronto.redhat.com>
In-Reply-To: <1075748783.2449.66.camel@tortoise.toronto.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Re: Patch: fix handling of AWT alias methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 06:59:15 -0000

Hi,

this is a very nice explanation of the whole issue. Is there a place where we 
could put this on the website? I think it would be nice for people joining 
classpath to find documentation why we have to do it this roundabout way.

Ingo

Thomas Fitzsimmons wrote:
> Hello,
> 
> This patch fixes the way we handle "alias" methods in the AWT, where a
> public or protected method has been deprecated in favour of a new one
> that has the same function but a different name.  Sun does this a fair
> amount to fix cases where the original method's name did not follow
> their naming conventions.
> 
> Unfortunately, this practise complicates class library code that calls
> these aliased methods.  Library code must still call the deprecated
> method so that old client code that overrides it continues to work.  But
> library code must also call the new version, because new code is
> expected to override the new method.
> 
> The correct way to handle this (and the way Sun does it) may seem
> counterintuitive because it means that new code is less efficient than
> old code: the new method must call the deprecated method, and throughout
> the library code calls to the old method must be replaced with calls to
> the new one.
> 
> Take the example of a newly-written container laying out a component and
> wanting to know its preferred size.  The Component class has a
> deprecated preferredSize method and a new method, getPreferredSize. 
> Assume that the container is laying out an old component that overrides
> preferredSize and a new component that overrides getPreferredSize.  If
> the container calls getPreferredSize and the default implementation of
> getPreferredSize calls preferredSize, then the old component will have
> its preferredSize method called and new code will have its
> getPreferredSize method called.
> 
> Even using this calling scheme, an old component may still be laid out
> improperly if it implements a method, getPreferredSize, that has the
> same signature as the new Component.getPreferredSize.  But that is a
> general problem -- adding new public or protected methods to a
> widely-used class that calls those methods internally is risky, because
> existing client code may have already declared methods with the same
> signature.
> 
> The solution may still seem counterintuitive -- why not have the
> deprecated method call the new method, then have the library always call
> the old method.  One problem with that, using the preferred size example
> again, is that new containers, which will use the non-deprecated
> getPreferredSize, will not get the preferred size of old components.
> 
> Jeroen Frijters provides a good explanation of the problem in his IKVM
> web log [1].
> 
> Comments?
> 
> Tom
> 
> [1] GridBagLayout and more AWT, http://weblog.ikvm.net/commentview.aspx?guid=8B14C003-E16A-4E99-A52E-AD776CBB8CBF
> 
> 2004-02-02  Thomas Fitzsimmons  <fitzsim@redhat.com>
> [Patch was here ...]  


-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany



From MAILER-DAEMON Tue Feb 03 05:10:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AnxVs-0005NI-N6
	for mharc-classpath@gnu.org; Tue, 03 Feb 2004 05:10:36 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AnxVo-0005Lq-D8
	for classpath@gnu.org; Tue, 03 Feb 2004 05:10:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AnxVD-0005Av-Fd
	for classpath@gnu.org; Tue, 03 Feb 2004 05:10:26 -0500
Received: from [217.8.192.21] (helo=interway.li)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1AnxV8-0005AQ-Vm; Tue, 03 Feb 2004 05:09:51 -0500
Received: from [217.114.112.56] (HELO [192.168.1.33])
	by interway.li (CommuniGate Pro SMTP 4.1.8)
	with ESMTP id 541320; Tue, 03 Feb 2004 11:15:09 +0100
From: Sascha Brawer <brawer@dandelis.ch>
To: Classpath Commits <commit-classpath@gnu.org>
Date: Tue, 3 Feb 2004 11:09:47 +0100
Message-Id: <20040203100947.2197@smtp.mail.ch.easynet.net>
In-Reply-To: <10516201.1075762980@[192.168.1.3]>
References: <10516201.1075762980@[192.168.1.3]>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [WWW] FAQ added to site
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 10:10:34 -0000

Patrik Reali <reali@acm.org> wrote on Mon, 2 Feb 2004 23:03:01 +0100 [to
classpath-commit]:

>I've added the FAQ with a few entries to populate it. The layout is still 
>not perfect, but that's a start and allows to store this information 
>somewhere.

Last summer, I had started a Classpath FAQ with some preliminary content.
I had sent it to the classpath@gnu.org list, but did not get much feed-
back. Feel free to copy/change things from the old draft, in case it
turns out to be useful to you.

<http://www.dandelis.ch/cpfaq.html>

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Tue Feb 03 05:21:45 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1Anxgf-00086O-25
	for mharc-classpath@gnu.org; Tue, 03 Feb 2004 05:21:45 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1Anxgc-00085l-AE
	for classpath@gnu.org; Tue, 03 Feb 2004 05:21:42 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1Anxg5-0007yE-Dl
	for classpath@gnu.org; Tue, 03 Feb 2004 05:21:40 -0500
Received: from [217.8.192.21] (helo=interway.li)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AnxZy-0006Tk-UZ
	for classpath@gnu.org; Tue, 03 Feb 2004 05:14:51 -0500
Received: from [217.114.112.56] (HELO [192.168.1.33])
	by interway.li (CommuniGate Pro SMTP 4.1.8)
	with ESMTP id 541431; Tue, 03 Feb 2004 11:20:10 +0100
From: Sascha Brawer <brawer@dandelis.ch>
To: <java-patches@gcc.gnu.org>
Date: Tue, 3 Feb 2004 11:14:48 +0100
Message-Id: <20040203101448.19996@smtp.mail.ch.easynet.net>
In-Reply-To: <401EBB40.9000803@redhat.com>
References: <401EBB40.9000803@redhat.com>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: [PATCH] fixes to LightweightDispatcher and SwingUtilities
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2004 10:21:43 -0000

graydon hoare <graydon@redhat.com> wrote on Mon, 2 Feb 2004 16:04:00 -0500:

>2004-02-02  Graydon Hoare  <graydon@redhat.com>
>
>	* javax/swing/SwingUtilities.java: Many new functions.
>	* java/awt/Container.java (LightweightDispatcher): Reimplement.
>	* javax/swing/basic/BasicGraphicsUtils.java
>	(getPreferredButtonSize): Start layout from top-left corner.

Looks nice, IMHO.

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Wed Feb 04 00:34:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AoFg7-0007m9-L8
	for mharc-classpath@gnu.org; Wed, 04 Feb 2004 00:34:23 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AoFg4-0007lv-Nt
	for classpath@gnu.org; Wed, 04 Feb 2004 00:34:20 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AoFfY-0007KK-IV
	for classpath@gnu.org; Wed, 04 Feb 2004 00:34:19 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AoFfY-0007Cc-5J
	for classpath@gnu.org; Wed, 04 Feb 2004 00:33:48 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i145Xfb31646;
	Wed, 4 Feb 2004 00:33:41 -0500
Received: from redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i145Xfa29285; 
	Wed, 4 Feb 2004 00:33:41 -0500
Message-ID: <40208431.6030909@redhat.com>
Date: Wed, 04 Feb 2004 00:33:37 -0500
From: graydon hoare <graydon@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.6b) Gecko/20031205 Thunderbird/0.4
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Olga Rodimina <rodimina@redhat.com>
References: <1075491258.12488.44.camel@toby.toronto.redhat.com>
In-Reply-To: <1075491258.12488.44.camel@toby.toronto.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] Fixes to AffineTransform
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Feb 2004 05:34:21 -0000

Olga Rodimina wrote:

> Here is the patch that fixes few errors in the AffineTransform class. 
> It corrects a small error in shear transformation and fixes
> createInverse() to return correct inverse matrix.

hi olga,

this stuff looks good, thanks a lot! it's surprising this just sat there 
broken for so long. I've checked it against a few algebra texts I have 
kicking around and some geometry libraries (including cairo) and they 
seem to mostly agree with your calculation; though just to be difficult 
they all use different notation and half of them do it upside down :)

one comment: I this this "shear" function is written in a confusing way. 
I think it is slightly clearer -- to my lazy eyes -- if written as so:

     double n00 = m00 + (shy * m01);
     double n01 = m01 + (shx * m00);
     double n10 = m10 + (shy * m11);
     double n11 = m11 + (shx * m10);

though I suppose it's a matter of aesthetics. I find it easier to check 
that against what I see written elsewhere. assuming I didn't get the 
terms mixed up just now. ugh.

it might be nice to write up a mauve testsuite which generates a bunch 
of pseudorandom vectors and runs them through a bunch of pseudorandom 
scaled, sheared and translated transformations (and their inverses) and 
checks that the vectors pop out the same as they went in, within some 
epsilon to account for floating point error. anything to make this stuff 
less fidgety and prone to eyes-glossing-over would probably be good. 
it's too easy to make a minor arithmetic mistake which completely breaks it.

oh.. also just browsing the class, I notice that the comments on the 
field definitions in AffineTransform for m11 and m10 are backwards; it 
refers to m11 as the shearing element and m10 as the scaling. you might 
want to fix that when you commit.. assuming you can. did you get write 
access yet?

-graydon



From MAILER-DAEMON Wed Feb 04 11:33:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AoPy0-0005Lz-18
	for mharc-classpath@gnu.org; Wed, 04 Feb 2004 11:33:32 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AoPxw-0005KD-FB
	for classpath@gnu.org; Wed, 04 Feb 2004 11:33:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AoPxN-00059j-TV
	for classpath@gnu.org; Wed, 04 Feb 2004 11:33:25 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AoPkn-0001iF-PP
	for classpath@gnu.org; Wed, 04 Feb 2004 11:19:53 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i14GJjb14260;
	Wed, 4 Feb 2004 11:19:45 -0500
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i14GJha08911; 
	Wed, 4 Feb 2004 11:19:44 -0500
Received: from toby.toronto.redhat.com (toby.toronto.redhat.com [172.16.14.35])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i14GJeXd024347; Wed, 4 Feb 2004 11:19:40 -0500
From: Olga Rodimina <rodimina@redhat.com>
To: graydon hoare <graydon@redhat.com>
In-Reply-To: <40208431.6030909@redhat.com>
References: <1075491258.12488.44.camel@toby.toronto.redhat.com>
	<40208431.6030909@redhat.com>
Content-Type: multipart/mixed; boundary="=-EtcNXzrINF61B216yjxr"
Organization: 
Message-Id: <1075911580.28816.71.camel@toby.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) 
Date: 04 Feb 2004 11:19:40 -0500
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] Fixes to AffineTransform
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Feb 2004 16:33:29 -0000


--=-EtcNXzrINF61B216yjxr
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Wed, 2004-02-04 at 00:33, graydon hoare wrote:
> Olga Rodimina wrote:
> 
> > Here is the patch that fixes few errors in the AffineTransform class. 
> > It corrects a small error in shear transformation and fixes
> > createInverse() to return correct inverse matrix.
> 
> hi olga,
> 
> this stuff looks good, thanks a lot! it's surprising this just sat there 
> broken for so long. I've checked it against a few algebra texts I have 
> kicking around and some geometry libraries (including cairo) and they 
> seem to mostly agree with your calculation; though just to be difficult 
> they all use different notation and half of them do it upside down :)
> 

Hi,

I fixed the suggested changes. Attached is the revised patch that I'll
be committing.


> 
> it might be nice to write up a mauve testsuite which generates a bunch 
> of pseudorandom vectors and runs them through a bunch of pseudorandom 
> scaled, sheared and translated transformations (and their inverses) and 
> checks that the vectors pop out the same as they went in, within some 
> epsilon to account for floating point error. anything to make this stuff 
> less fidgety and prone to eyes-glossing-over would probably be good. 
> it's too easy to make a minor arithmetic mistake which completely breaks it.
> 

Sure. I'll do that.

Olga.

--=-EtcNXzrINF61B216yjxr
Content-Disposition: attachment; filename=patch
Content-Type: text/plain; name=patch; charset=UTF-8
Content-Transfer-Encoding: 7bit

? .snprj
? libjava.proj
? patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/libjava/ChangeLog,v
retrieving revision 1.2637
diff -c -p -u -r1.2637 ChangeLog
--- ChangeLog	4 Feb 2004 00:07:19 -0000	1.2637
+++ ChangeLog	4 Feb 2004 15:55:56 -0000
@@ -1,3 +1,13 @@
+2004-02-04  Olga Rodimina  <rodimina@redhat.com>
+
+	* java/awt/geom/AffineTransform.java: 
+	Corrected comments on the field definitions for
+	m11 and m10.
+	(shear): Fixed few errors that caused shear
+	transformation to be performed incorrectly.
+	(createInverse): Fixed to return correct
+	inverse of the given matrix.
+
 2004-02-03  Tom Tromey  <tromey@redhat.com>
 
 	* java/lang/natPosixProcess.cc (startProcess): Handle case where
Index: java/awt/geom/AffineTransform.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/geom/AffineTransform.java,v
retrieving revision 1.7
diff -c -p -u -r1.7 AffineTransform.java
--- java/awt/geom/AffineTransform.java	17 Sep 2003 19:06:55 -0000	1.7
+++ java/awt/geom/AffineTransform.java	4 Feb 2004 15:55:57 -0000
@@ -226,7 +226,7 @@ public class AffineTransform implements 
   private double m00;
 
   /**
-   * The Y coordinate scaling element of the transform matrix.
+   * The Y coordinate shearing element of the transform matrix.
    *
    * @serial matrix[1,0]
    */
@@ -240,7 +240,7 @@ public class AffineTransform implements 
   private double m01;
 
   /**
-   * The Y coordinate shearing element of the transform matrix.
+   * The Y coordinate scaling element of the transform matrix.
    *
    * @serial matrix[1,1]
    */
@@ -738,10 +738,10 @@ public class AffineTransform implements 
    */
   public void shear(double shx, double shy)
   {
-    double n00 = m00 + shx * m01;
-    double n01 = shx * m00 + m01;
-    double n10 = m10 * shy + m11;
-    double n11 = shx * m10 + m11;
+    double n00 = m00 + (shy * m01);
+    double n01 = m01 + (shx * m00);
+    double n10 = m10 + (shy * m11);
+    double n11 = m11 + (shx * m10);
     m00 = n00;
     m01 = n01;
     m10 = n10;
@@ -996,6 +996,38 @@ public class AffineTransform implements 
    * map multiple points to the same line or point). A transform exists only
    * if getDeterminant() has a non-zero value.
    *
+   * The inverse is calculated as:
+   * 
+   * <pre>
+   *
+   * Let A be the matrix for which we want to find the inverse:
+   *
+   * A = [ m00 m01 m02 ]
+   *     [ m10 m11 m12 ]
+   *     [ 0   0   1   ] 
+   *
+   *
+   *                 1    
+   * inverse (A) =  ---   x  adjoint(A) 
+   *                det 
+   *
+   *
+   *
+   *             =   1       [  m11  -m01   m01*m12-m02*m11  ]
+   *                ---   x  [ -m10   m00  -m00*m12+m10*m02  ]
+   *                det      [  0     0     m00*m11-m10*m01  ]
+   *
+   *
+   *
+   *             = [  m11/det  -m01/det   m01*m12-m02*m11/det ]
+   *               [ -m10/det   m00/det  -m00*m12+m10*m02/det ]
+   *               [   0           0          1               ]
+   *
+   *
+   * </pre>
+   *
+   *
+   *
    * @return a new inverse transform
    * @throws NoninvertibleTransformException if inversion is not possible
    * @see #getDeterminant()
@@ -1006,8 +1038,15 @@ public class AffineTransform implements 
     double det = getDeterminant();
     if (det == 0)
       throw new NoninvertibleTransformException("can't invert transform");
-    return new AffineTransform(m11 / det, -m10 / det, m01 / det, -m00 / det,
-                               -m02, -m12);
+    
+    double im00 = m11 / det;
+    double im10 = -m10 / det;
+    double im01 = -m01 / det;
+    double im11 = m00 / det;
+    double im02 = (m01 * m12 - m02 * m11) / det;
+    double im12 = (-m00 * m12 + m10 * m02) / det;
+    
+    return new AffineTransform (im00, im10, im01, im11, im02, im12);
   }
 
   /**

--=-EtcNXzrINF61B216yjxr--




From MAILER-DAEMON Thu Feb 05 15:16:53 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AopeS-000421-T9
	for mharc-classpath@gnu.org; Thu, 05 Feb 2004 14:59:04 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AopeD-00040D-AZ
	for classpath@gnu.org; Thu, 05 Feb 2004 14:58:49 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AopaF-0002J7-Gq
	for classpath@gnu.org; Thu, 05 Feb 2004 14:55:15 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AopYe-0001Zv-OU
	for classpath@gnu.org; Thu, 05 Feb 2004 14:53:04 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i15Jqqb02096;
	Thu, 5 Feb 2004 14:52:52 -0500
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i15Jqqa23184; 
	Thu, 5 Feb 2004 14:52:52 -0500
Received: from toby.toronto.redhat.com (toby.toronto.redhat.com [172.16.14.35])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i15JqpXd005296; Thu, 5 Feb 2004 14:52:51 -0500
From: Olga Rodimina <rodimina@redhat.com>
To: java-patches@gcc.gnu.org
Content-Type: multipart/mixed; boundary="=-96AGg/uk0/KCR3mB0h12"
Organization: 
Message-Id: <1076010771.25346.82.camel@toby.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) 
Date: 05 Feb 2004 14:52:51 -0500
Cc: classpath@gnu.org
Subject: [PATCH] Interpolation Rendering hints
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Feb 2004 19:58:52 -0000


--=-96AGg/uk0/KCR3mB0h12
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,

Attached is the patch that implements KEY_INTERPOLATION and
KEY_ALPHA_INTERPOLATION rendering hints in Graphics2D.

Ok to commit?


Olga.

--=-96AGg/uk0/KCR3mB0h12
Content-Disposition: attachment; filename=patch
Content-Type: text/plain; name=patch; charset=UTF-8
Content-Transfer-Encoding: 7bit

? .snprj
? libjava.proj
? patch
? patch_interpolation
Index: ChangeLog
===================================================================
RCS file: /cvs/gcc/gcc/libjava/ChangeLog,v
retrieving revision 1.2642
diff -c -p -u -r1.2642 ChangeLog
--- ChangeLog	5 Feb 2004 16:34:28 -0000	1.2642
+++ ChangeLog	5 Feb 2004 18:27:30 -0000
@@ -1,3 +1,15 @@
+2004-02-05  Olga Rodimina  <rodimina@redhat.com>
+
+	* gnu/java/awt/peer/gtk/GdkGraphics2D.java:
+	(setRenderingHint): Added implementation of 
+	Interpolation rendering hints.
+	(setRenderingHints): Ditto.
+	* jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics2D.c:
+	(drawPixels): fixed to allow user to choose type 
+	of filtering that should be used when displaying images.
+	(cairoSurfaceSetFilter): New method. Sets filter type for 
+	interpolation of pixel values.
+
 2004-02-05  Michael Koch  <konqueror@gmx.de>
 
 	* java/lang/Thread.java: Reordered fields, reformated much code,
Index: gnu/java/awt/peer/gtk/GdkGraphics2D.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/peer/gtk/GdkGraphics2D.java,v
retrieving revision 1.6
diff -c -p -u -r1.6 GdkGraphics2D.java
--- gnu/java/awt/peer/gtk/GdkGraphics2D.java	16 Jan 2004 14:22:23 -0000	1.6
+++ gnu/java/awt/peer/gtk/GdkGraphics2D.java	5 Feb 2004 18:27:30 -0000
@@ -91,6 +91,7 @@ public class GdkGraphics2D extends Graph
   native private void initState (int width, int height);
   native private void copyState (GdkGraphics2D g);
   native public void dispose ();
+  native private void cairoSurfaceSetFilter(int filter);
 
   public void finalize ()
   {
@@ -1061,6 +1062,28 @@ public class GdkGraphics2D extends Graph
                                Object hintValue)
   {
     hints.put (hintKey, hintValue);    
+    
+    if (hintKey.equals(RenderingHints.KEY_INTERPOLATION)
+        || hintKey.equals(RenderingHints.KEY_ALPHA_INTERPOLATION)) 
+      {
+			
+        if (hintValue.equals(RenderingHints.VALUE_INTERPOLATION_NEAREST_NEIGHBOR))
+           cairoSurfaceSetFilter(0);
+	   
+        else if (hintValue.equals(RenderingHints.VALUE_INTERPOLATION_BILINEAR))
+           cairoSurfaceSetFilter(1); 
+	   
+        else if (hintValue.equals(RenderingHints.VALUE_ALPHA_INTERPOLATION_SPEED))
+           cairoSurfaceSetFilter(2);
+	   
+        else if (hintValue.equals(RenderingHints.VALUE_ALPHA_INTERPOLATION_QUALITY))
+           cairoSurfaceSetFilter(3);
+	   
+        else if (hintValue.equals(RenderingHints.VALUE_ALPHA_INTERPOLATION_DEFAULT))
+           cairoSurfaceSetFilter(4);
+      
+      } 
+
   }
 
   public Object getRenderingHint(RenderingHints.Key hintKey)
@@ -1072,6 +1095,27 @@ public class GdkGraphics2D extends Graph
   {
     this.hints = new RenderingHints (getDefaultHints ());
     this.hints.add (new RenderingHints (hints));
+        
+    if (hints.containsKey(RenderingHints.KEY_INTERPOLATION)) 
+      {
+         if(hints.containsValue(RenderingHints.VALUE_INTERPOLATION_NEAREST_NEIGHBOR)) 
+            cairoSurfaceSetFilter(0);
+	    
+         else if(hints.containsValue(RenderingHints.VALUE_INTERPOLATION_BILINEAR)) 
+            cairoSurfaceSetFilter(1);  
+      }
+          
+    if (hints.containsKey(RenderingHints.KEY_ALPHA_INTERPOLATION)) 
+      { 
+         if (hints.containsValue(RenderingHints.VALUE_ALPHA_INTERPOLATION_SPEED)) 
+            cairoSurfaceSetFilter(2);
+	    
+         else if (hints.containsValue(RenderingHints.VALUE_ALPHA_INTERPOLATION_QUALITY)) 
+            cairoSurfaceSetFilter(3);
+	    
+         else if(hints.containsValue(RenderingHints.VALUE_ALPHA_INTERPOLATION_DEFAULT)) 
+            cairoSurfaceSetFilter(4);
+      }      
   }
 
   public void addRenderingHints(Map hints)
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics2D.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics2D.c,v
retrieving revision 1.5
diff -c -p -u -r1.5 gnu_java_awt_peer_gtk_GdkGraphics2D.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics2D.c	31 Dec 2003 08:58:31 -0000	1.5
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics2D.c	5 Feb 2004 18:27:32 -0000
@@ -114,6 +114,15 @@ enum java_awt_geom_path_iterator_winding
     java_awt_geom_path_iterator_WIND_NON_ZERO = 1
   };
 
+enum java_awt_rendering_hints_filter
+  {
+    java_awt_rendering_hints_VALUE_INTERPOLATION_NEAREST_NEIGHBOR = 0,    
+    java_awt_rendering_hints_VALUE_INTERPOLATION_BILINEAR = 1,
+    java_awt_rendering_hints_VALUE_ALPHA_INTERPOLATION_SPEED = 2,
+    java_awt_rendering_hints_VALUE_ALPHA_INTERPOLATION_QUALITY = 3,
+    java_awt_rendering_hints_VALUE_ALPHA_INTERPOLATION_DEFAULT = 4
+ 
+  };
 
 static void 
 grab_current_drawable (GtkWidget *widget, GdkDrawable **draw, GdkWindow **win)
@@ -683,21 +692,8 @@ JNIEXPORT void JNICALL Java_gnu_java_awt
 			    native_matrix[2], native_matrix[3],
 			    native_matrix[4], native_matrix[5]);
    cairo_surface_set_matrix (surf, mat);
-   if (native_matrix[0] != 1.
-       || native_matrix[1] != 0.
-       || native_matrix[2] != 0.
-       || native_matrix[3] != 1.)
-     {
-       cairo_surface_set_filter (surf, CAIRO_FILTER_BILINEAR);
-       cairo_surface_set_filter (gr->surface, CAIRO_FILTER_BILINEAR);
-     }
-   else
-     {
-       cairo_surface_set_filter (surf, CAIRO_FILTER_FAST);
-       cairo_surface_set_filter (gr->surface, CAIRO_FILTER_FAST);
-     }
+   cairo_surface_set_filter (surf, cairo_surface_get_filter(gr->surface));
    cairo_show_surface (gr->cr, surf, w, h);
-   cairo_surface_set_filter (gr->surface, CAIRO_FILTER_FAST);
    cairo_matrix_destroy (mat);
    cairo_surface_destroy (surf);
  }
@@ -1157,3 +1153,30 @@ JNIEXPORT void JNICALL Java_gnu_java_awt
   cairo_clip (gr->cr);
 }
 
+JNIEXPORT void JNICALL Java_gnu_java_awt_peer_gtk_GdkGraphics2D_cairoSurfaceSetFilter
+   (JNIEnv *env, jobject obj, jint filter)
+{
+
+   struct graphics2d *gr = NULL;   
+   gr = (struct graphics2d *) NSA_GET_G2D_PTR (env, obj);
+   g_assert (gr != NULL);
+   if (gr->debug) printf ("cairo_surface_set_filter %d\n", filter);   
+   switch ((enum java_awt_rendering_hints_filter) filter)
+     {
+     case java_awt_rendering_hints_VALUE_INTERPOLATION_NEAREST_NEIGHBOR:
+       cairo_surface_set_filter (gr->surface, CAIRO_FILTER_NEAREST);
+       break;
+     case java_awt_rendering_hints_VALUE_INTERPOLATION_BILINEAR:
+       cairo_surface_set_filter (gr->surface, CAIRO_FILTER_BILINEAR);
+       break; 
+     case java_awt_rendering_hints_VALUE_ALPHA_INTERPOLATION_SPEED:
+       cairo_surface_set_filter (gr->surface, CAIRO_FILTER_FAST);
+       break;
+     case java_awt_rendering_hints_VALUE_ALPHA_INTERPOLATION_DEFAULT:
+       cairo_surface_set_filter (gr->surface, CAIRO_FILTER_NEAREST);
+       break;
+     case java_awt_rendering_hints_VALUE_ALPHA_INTERPOLATION_QUALITY:
+       cairo_surface_set_filter (gr->surface, CAIRO_FILTER_BEST);
+       break;
+     }
+}

--=-96AGg/uk0/KCR3mB0h12--




From MAILER-DAEMON Mon Feb 09 17:16:00 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AqJh9-0004Iz-VR
	for mharc-classpath@gnu.org; Mon, 09 Feb 2004 17:15:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AqJh7-0004I4-9k
	for classpath@gnu.org; Mon, 09 Feb 2004 17:15:57 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AqJgW-00048F-Hl
	for classpath@gnu.org; Mon, 09 Feb 2004 17:15:51 -0500
Received: from [219.160.177.9] (helo=asao.gcd.org)
	by monty-python.gnu.org with smtp (Exim 4.24) id 1AqJgV-00046u-JJ
	for classpath@gnu.org; Mon, 09 Feb 2004 17:15:19 -0500
Received: (qmail 11518 invoked by uid 10); 10 Feb 2004 07:15:12 +0900
Received: (qmail 1599 invoked by uid 1000); 9 Feb 2004 22:14:55 -0000
Message-ID: <20040209221455.1598.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: classpath@gnu.org
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Tue, 10 Feb 2004 07:14:54 +0900
Sender: kaz@maczuka.gcd.org
Subject: java.io.ObjectInputStream throws ArrayIndexOutOfBoundsException
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Feb 2004 22:15:58 -0000

Hi,

As reported in the Kaffe mailing list[1], java.io.ObjectInputStream
throws ArrayIndexOutOfBoundsException in some unusual case.

[1] http://www.kaffe.org/pipermail/kaffe/2004-February/045180.html

And here is my proposed patch.

ChangeLog entry:

2004-02-09  Ito Kazumitsu  <kaz@maczuka.gcd.org>

	    * java/io/ObjectInputStream.java
	    (readClassDescriptor):
	    Avoid the overflow of fieldmapping.

--- java/io/ObjectInputStream.java.orig	Tue Feb  3 07:28:42 2004
+++ java/io/ObjectInputStream.java	Tue Feb 10 00:51:45 2004
@@ -491,7 +491,6 @@
     ObjectStreamField[] stream_fields = osc.fields;
     ObjectStreamField[] real_fields = ObjectStreamClass.lookup(clazz).fields;
     ObjectStreamField[] fieldmapping = new ObjectStreamField[2 * Math.max(stream_fields.length, real_fields.length)];
-    osc.fieldMapping = fieldmapping;
 
     int stream_idx = 0;
     int real_idx = 0;
@@ -543,9 +542,21 @@
 	  }
 	if (real_field != null && !real_field.isToSet())
 	    real_field = null;
+	/* If some of stream_fields does not correspond to any of real_fields,
+	 * or the opposite, then fieldmapping will go short.
+	 */
+	if (map_idx == fieldmapping.length)
+	  {
+	    ObjectStreamField[] newfieldmapping =
+	      new ObjectStreamField[fieldmapping.length + 2];
+	    System.arraycopy(fieldmapping, 0,
+	      newfieldmapping, 0, fieldmapping.length);
+	    fieldmapping = newfieldmapping;
+	  }
 	fieldmapping[map_idx++] = stream_field;
 	fieldmapping[map_idx++] = real_field;
       }
+    osc.fieldMapping = fieldmapping;
 
     return osc;
   }



From MAILER-DAEMON Mon Feb 09 23:33:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AqPan-0008KQ-GF
	for mharc-classpath@gnu.org; Mon, 09 Feb 2004 23:33:49 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AqPak-0008Ir-5H
	for classpath@gnu.org; Mon, 09 Feb 2004 23:33:46 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AqPaC-000889-Bz
	for classpath@gnu.org; Mon, 09 Feb 2004 23:33:43 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqPaB-00086I-DL
	for classpath@gnu.org; Mon, 09 Feb 2004 23:33:11 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i1A4X4b09126;
	Mon, 9 Feb 2004 23:33:04 -0500
Received: from redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1A4X4i25097; 
	Mon, 9 Feb 2004 23:33:04 -0500
Message-ID: <40285EF5.9070406@redhat.com>
Date: Mon, 09 Feb 2004 23:32:53 -0500
From: graydon hoare <graydon@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.6b) Gecko/20031205 Thunderbird/0.4
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: java-patches@gcc.gnu.org
Content-Type: multipart/mixed; boundary="------------020100060203080204080809"
Cc: classpath@gnu.org
Subject: [PATCH] many small swing fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2004 04:33:47 -0000

This is a multi-part message in MIME format.
--------------020100060203080204080809
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

hi,

the following is a rather fiddly patch. it doesn't actually change 
*much*, but it makes a lot of minor improvements and adjustments in a 
lot of places, bringing our swing closer in line with sun's swing.

broadly summarizing (detailed changelog follows), this patch:

   - corrects a number of errors in our UIDefaults and PLAF code.
   - removes a bunch of dead (or wrong) methods and classes which
     either don't exist in sun's libraries or do nothing.
   - replaces a bunch of hard-coded values with UIDefaults lookups.
   - fixes some semantic errors I made in the button model and utilities
     classes.
   - adds some code to implement various button subclasses (checkbox,
     toggle button, radio button), their icons, their behavior, etc.

the results of this, plus the Very Excellent JSlider implementation kho 
will be posting shortly, is on display for your viewing pleasure at
http://people.redhat.com/graydon/free-swing-feb-09-2004.png, running 
atop the GDK drawing backend.

comments? ok to commit?

-graydon

2004-02-09  Graydon Hoare  <graydon@redhat.com>

	* javax/swing/ToggleButtonModel.java: Remove dead class.
	* javax/swing/plaf/basic/BasicDefaults.java: Remove dead class.
	* javax/swing/plaf/basic/BasicButtonListener.java: New class.
	* javax/swing/plaf/basic/BasicRootPaneUI.java: New class.
	* Makefile.am: Update for new and removed files.

	* gnu/java/awt/peer/gtk/GdkGraphics2D.java: Initialize default hints.
	* javax/swing/AbstractButton.java
	(AbstractButton): Initialize fields correctly in ctor.
	* javax/swing/JCheckbox.java
	(JCheckBox): Override painting flags.
	* javax/swing/DefaultButtonModel.java: Conform to sun.
	* javax/swing/JComponent.java (paint): Fill with background color
	if available.
	(processComponentKeyEvent)
	(processFocusEvent)
	(processKeyEvent)
	(processMouseMotionEvent): Remove event-consuming empty methods.
	(getUIClassID): Return "ComponentUI" not "JComponent"
	* javax/swing/JFrame.java: Remove some debugging chatter.
	(JFrame): Subscribe to window events.
	* javax/swing/JRadioButton.java
	(JRadioButton): Override painting flags.
	* javax/swing/JRootPane.java
	(JRootPane): Set background from UIDefaults.
	* javax/swing/JToggleButton.java
	(ToggleButtonModel): New inner class.
	(JToggleButton): Override layout alighment.
	* javax/swing/SwingUtilities.java:
	(getLocalBounds): Return width and height, not x and y.
	(calculateInnerArea): Use local bounds, not bounds.
	(layoutCompoundLabel): Provide overridden form.
	(layoutCompoundLabel): Correct bugs.
	* javax/swing/UIDefaults.java: Correct comment.
	* javax/swing/plaf/basic/BasicButtonUI.java:
	Move most logic into defaults, external listener.
	(paintIcon): Implement icon painting.
	(paint): Fix state painting to conform to changes in model.
	* javax/swing/plaf/basic/BasicCheckBoxUI.java:
	Remove most dead/wrong methods.
	(getDefaultIcon): Return defaults.getIcon("CheckBox.icon").
	* javax/swing/plaf/basic/BasicIconFactory.java:
	(DummyIcon): New class.
	(getMenuItemCheckIcon)
	(getMenuItemArrowIcon)
	(getMenuArrowIcon)
	(getCheckBoxMenuItemIcon)
	(getRadioButtonMenuItemIcon)
	(createEmptyFrameIcon): Return DummyIcons, not null.
	(getCheckBoxIcon): Implement an icon that looks like sun's.
	(getRadioButtonIcon): Implement an icon that looks like sun's.
	* javax/swing/plaf/basic/BasicLookAndFeel.java
	(initComponentDefaults): Fix impossible values, add some missing.
	* javax/swing/plaf/basic/BasicPanelUI.java (gap): Remove field.
	* javax/swing/plaf/basic/BasicRadioButtonUI.java:
	Remove most dead/wrong methods.
	(icon): New field.
	(getDefaultIcon): New method.
	* javax/swing/plaf/basic/BasicToggleButtonUI.java:
	Remove most dead/wrong methods.
	* javax/swing/plaf/metal/MetalLookAndFeel.java
	(getDefaults): Return super.getDefaults(), not BasicDefaults.
	* jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c
	(Java_gnu_java_awt_peer_gtk_GdkGraphics_clearRect):
	Implement "clearing" as drawing, when on pixmap drawables.

	* javax/swing/JButton.java (getUIClassID):
	* javax/swing/JCheckBox.java (getUIClassID):
	* javax/swing/JEditorPane.java (getUIClassID):
	* javax/swing/JLabel.java (getUIClassID):
	* javax/swing/JList.java (getUIClassID):
	* javax/swing/JOptionPane.java (getUIClassID):
	* javax/swing/JPanel.java (getUIClassID):
	* javax/swing/JPasswordField.java (uiClassID):
	* javax/swing/JRadioButton.java (getUIClassID):
	* javax/swing/JRootPane.java (getUIClassID):
	* javax/swing/JScrollPane.java (getUIClassID):
	* javax/swing/JTabbedPane.java (getUIClassID):
	* javax/swing/JToggleButton.java (getUIClassID):
	* javax/swing/JTree.java (getUIClassID):
	* javax/swing/JViewport.java (getUIClassID):
	* javax/swing/text/JTextComponent.java (getUIClassID):
	Return "fooUI" not "Jfoo"


--------------020100060203080204080809
Content-Type: text/x-patch;
 name="j2d-swing-many-small-fixes-feb09.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline; filename="j2d-swing-many-small-fixes-feb09.patch"

--- Makefile.am	29 Jan 2004 19:28:24 -0000	1.359
+++ Makefile.am	10 Feb 2004 04:19:04 -0000
@@ -1287,16 +1241,18 @@
 javax/swing/GrayFilter.java \
 javax/swing/AbstractAction.java \
 javax/swing/AbstractButton.java \
+javax/swing/plaf/basic/BasicButtonListener.java \
 javax/swing/plaf/basic/BasicButtonUI.java \
 javax/swing/plaf/basic/BasicCheckBoxUI.java \
-javax/swing/plaf/basic/BasicDefaults.java \
 javax/swing/plaf/basic/BasicGraphicsUtils.java \
 javax/swing/plaf/basic/BasicLabelUI.java \
 javax/swing/plaf/basic/BasicListUI.java \
 javax/swing/plaf/basic/BasicOptionPaneUI.java \
 javax/swing/plaf/basic/BasicPanelUI.java \
+javax/swing/plaf/basic/BasicRootPaneUI.java \
 javax/swing/plaf/basic/BasicRadioButtonUI.java \
 javax/swing/plaf/basic/BasicScrollPaneUI.java \
+javax/swing/plaf/basic/BasicSliderUI.java \
 javax/swing/plaf/basic/BasicSplitPaneDivider.java \
 javax/swing/plaf/basic/BasicSplitPaneUI.java \
 javax/swing/plaf/basic/BasicTabbedPaneUI.java \
@@ -1416,7 +1372,6 @@
 javax/swing/SwingConstants.java \
 javax/swing/SwingUtilities.java \
 javax/swing/Timer.java \
-javax/swing/ToggleButtonModel.java \
 javax/swing/UIDefaults.java \
 javax/swing/UIManager.java \
 javax/swing/UnsupportedLookAndFeelException.java \
--- gnu/java/awt/peer/gtk/GdkGraphics2D.java	16 Jan 2004 14:22:23 -0000	1.6
+++ gnu/java/awt/peer/gtk/GdkGraphics2D.java	10 Feb 2004 04:19:06 -0000
@@ -158,7 +158,7 @@
     setFont (new Font("SansSerif", Font.PLAIN, 12));
     setTransform (new AffineTransform ());
     setStroke (new BasicStroke ());
-    setRenderingHints (new HashMap ());
+    setRenderingHints (getDefaultHints());
 
     stateStack = new Stack();
   }
@@ -174,7 +174,7 @@
     setFont (new Font("SansSerif", Font.PLAIN, 12));
     setTransform (new AffineTransform ());
     setStroke (new BasicStroke ());
-    setRenderingHints (new HashMap ());
+    setRenderingHints (getDefaultHints());
 
     stateStack = new Stack ();
   }
--- javax/swing/AbstractButton.java	22 Jan 2004 09:54:15 -0000	1.4
+++ javax/swing/AbstractButton.java	10 Feb 2004 04:19:07 -0000
@@ -186,19 +186,19 @@
   String text;
 
   /** The vertical alignment of the button's text and icon. */
-  int vert_align = CENTER;
+  int vert_align;
 
   /** The horizontal alignment of the button's text and icon. */
-  int hori_align = CENTER;
+  int hori_align;
 
   /** The horizontal position of the button's text relative to its icon. */
-  int hori_text_pos = CENTER;
+  int hori_text_pos;
 
   /** The vertical position of the button's text relative to its icon. */
-  int vert_text_pos = CENTER;
+  int vert_text_pos;
 
   /** Whether or not the button paints its border. */
-  boolean paint_border = true;
+  boolean paint_border;
 
   /** Whether or not the button paints its focus state. */
   boolean paint_focus;
@@ -487,8 +487,16 @@
     model.addChangeListener(changeListener);
     model.addItemListener(itemListener);
 
+    hori_align = CENTER;
+    hori_text_pos = TRAILING;
+    vert_align = CENTER;
+    vert_text_pos = CENTER;
+    paint_border = true;
+    content_area_filled = true;
+
     setAlignmentX(LEFT_ALIGNMENT);
     setAlignmentY(CENTER_ALIGNMENT);
+
     addFocusListener(new ButtonFocusListener());
     updateUI();
   }
--- javax/swing/DefaultButtonModel.java	22 Jan 2004 09:54:15 -0000	1.4
+++ javax/swing/DefaultButtonModel.java	10 Feb 2004 04:19:07 -0000
@@ -55,15 +55,23 @@
  * button. The concrete button type holding this state may be a a "toggle"
  * button (checkbox, radio button) or a "push" button (menu button, button).
  * 
- * Any change to the model's properties will trigger the firing of a
- * ChangeEvent.
+ * If the model is disabled, only the "selected" property can be changed.
+ * An attempt to change the "armed", "rollover" or "pressed" properties 
+ * while the model is disabled will be blocked.
+ *
+ * Any successful (non-blocked) change to the model's properties will
+ * trigger the firing of a ChangeEvent.
+ *
+ * Any change to the "selected" property will trigger the firing of an
+ * ItemEvent in addition to ChangeEvent. This is true whether the model is
+ * enabled or not.
+ *
+ * One other state change is special: the transition from "enabled, armed
+ * and pressd" to "enabled, armed and not-pressed". This is considered the
+ * "trailing edge" of a successful mouse click, and therefore fires an 
+ * ActionEvent in addition to a ChangeEvent.
  *
- * Any change to the "pressed" property will trigger the firing of an
- * ItemEvent in addition to ChangeEvent.
- *
- * Any change which causes the enabled, armed and pressed properties to
- * simultaneously become <code>true</code> will trigger the firing of an
- * ActionEvent in addition to the ChangeEvent.
+ * In all other respects this class is just a container of boolean flags.
  *
  * @author Graydon Hoare (graydon&064;redhat.com)
  */
@@ -80,9 +88,9 @@
    be pressed or selected unless they are enabled. */
   static int ENABLED = 2;
 
-  /** State constant indicating that the button has been fully
-   pressed. This usually happens when a user has released the mouse over a
-   previously "armed" button. */
+  /** State constant indicating that the user is holding down the button.
+   When this transitions from true to false, an ActionEvent may be fired,
+   depending on the value of the "armed" property.*/
   static int PRESSED = 4;
 
   /** State constant indicating that the mouse is currently positioned over
@@ -120,7 +128,8 @@
 
   public DefaultButtonModel()
   {
-    stateMask = 0;
+    stateMask = ENABLED;
+    mnemonic = java.awt.event.KeyEvent.VK_UNDEFINED;
     listenerList = new EventListenerList();    
     changeEvent = new ChangeEvent(this);
   }
@@ -262,13 +271,15 @@
     if (oldstate == newstate)
       return;
 
+    if ((stateflag != SELECTED) 
+        && (stateflag != ENABLED)
+        && (stateMask & ENABLED) == 0)
+      return;
+
     stateMask = newstate;
 
     fireStateChanged(changeEvent);
 
-    if ((newstate & ENABLED) == 0)
-      return;
-
     if ((oldstate & SELECTED) == 0
         && (newstate & SELECTED) == SELECTED)
       fireItemStateChanged(new ItemEvent(this, ItemEvent.ITEM_STATE_CHANGED, 
@@ -279,14 +290,13 @@
       fireItemStateChanged(new ItemEvent(this, ItemEvent.ITEM_STATE_CHANGED, 
                                          null, ItemEvent.DESELECTED));
 
-    else if ((newstate & ARMED) == ARMED
-             && (newstate & PRESSED) == PRESSED)
+    else if (((oldstate & ARMED) == ARMED && (oldstate & PRESSED) == PRESSED)
+             &&
+             ((newstate & ARMED) == ARMED && (newstate & PRESSED) == 0))
 	    {
         fireActionPerformed(new ActionEvent(this, ActionEvent.ACTION_PERFORMED,
                                             actionCommand));
-        stateMask = stateMask & ~(PRESSED | ARMED);
 	    }
-    
     }
 
   /**
--- javax/swing/JButton.java	9 Jan 2004 10:18:47 -0000	1.3
+++ javax/swing/JButton.java	10 Feb 2004 04:19:07 -0000
@@ -98,7 +98,7 @@
     public String getUIClassID()
     {
 	//Returns a string that specifies the name of the L&F class that renders this component.  
-	return "JButton";
+	return "ButtonUI";
     }
   
     public boolean isDefaultButton()
--- javax/swing/JCheckBox.java	11 Jun 2003 13:20:39 -0000	1.2
+++ javax/swing/JCheckBox.java	10 Feb 2004 04:19:07 -0000
@@ -70,6 +70,8 @@
     public JCheckBox(String text, Icon icon)
     {
 	super(text, icon);
+        paint_border = false;
+        content_area_filled = false;
     }
 
     
@@ -82,7 +84,7 @@
     public String getUIClassID()
     {
 	//Returns a string that specifies the name of the L&F class that renders this component.  
-	return "JCheckBox";
+	return "CheckBoxUI";
     }
   
     protected  String paramString()
--- javax/swing/JComponent.java	28 Jan 2004 19:37:58 -0000	1.6
+++ javax/swing/JComponent.java	10 Feb 2004 04:19:07 -0000
@@ -765,6 +765,14 @@
 		{
 			im = createImage (r.width, r.height);
 			g2 = im.getGraphics ();
+                  if (this.getBackground() != null)
+                    {
+                      Color save = g2.getColor();
+                      g2.setColor(this.getBackground());
+                      g2.fillRect (0, 0, r.width, r.height);
+                      g2.setColor(save);
+                    }
+                  else
 			g2.clearRect (0, 0, r.width, r.height);
 		}
 		
@@ -837,28 +845,6 @@
 		//      Returns a string representation of this JComponent.
 		return "JComponent";
 	}
-	protected  void processComponentKeyEvent(KeyEvent e)
-	{
-		//     Process any key events that the component itself recognizes.
-	    //System.out.println("COMP_KEY-EVENT: " + e);
-	}
-	protected  void processFocusEvent(FocusEvent e)
-	{
-		//      Processes focus events occurring on this component by dispatching them to any registered FocusListener objects.
-	    //System.out.println("FOCUS_EVENT: " + e);
-	}
-
-	protected  void processKeyEvent(KeyEvent e)
-	{
-		//      Override processKeyEvent to process events protected
-	    //System.out.println("KEY-EVENT: " + e);
-	}
-
-        public void processMouseMotionEvent(MouseEvent e)
-	{
-	    //      Processes mouse motion events occurring on this component by dispatching them to any registered MouseMotionListener objects.
-	    //System.out.println("COMP_MOUSE-EVENT: " + e + ", MEMORY = " + Runtime.getRuntime().freeMemory());
-	}
 
 	public void registerKeyboardAction(ActionListener anAction,
 	                            KeyStroke aKeyStroke,
@@ -1044,7 +1030,7 @@
         public String getUIClassID()
 	{
 		///          Return the UIDefaults key used to look up the name of the swing.
-		return "JComponent";
+		return "ComponentUI";
 	}
 
 	protected void setUI(ComponentUI newUI)
--- javax/swing/JEditorPane.java	5 Feb 2004 18:48:53 -0000	1.4
+++ javax/swing/JEditorPane.java	10 Feb 2004 04:19:07 -0000
@@ -137,7 +137,7 @@
     { return super.getText();    }
     
     public String getUIClassID()
-    {    return "JEditorPane";  }
+    {    return "EditorPaneUI";  }
 
     public boolean isFocusCycleRoot()
     { return focus_root;    }
--- javax/swing/JFrame.java	22 Nov 2003 00:03:35 -0000	1.3
+++ javax/swing/JFrame.java	10 Feb 2004 04:19:07 -0000
@@ -38,6 +38,7 @@
 
 package javax.swing;
 
+import java.awt.AWTEvent;
 import java.awt.BorderLayout;
 import java.awt.Component;
 import java.awt.Container;
@@ -105,6 +106,7 @@
     protected  void frameInit()
     {
       super.setLayout(new BorderLayout(1, 1));
+      enableEvents(AWTEvent.WINDOW_EVENT_MASK);
       getRootPane(); // will do set/create
     }
   
@@ -201,9 +203,7 @@
 
     protected  void processWindowEvent(WindowEvent e)
     {
-	//	System.out.println("PROCESS_WIN_EV-1: " + e);
 	super.processWindowEvent(e); 
-	//	System.out.println("PROCESS_WIN_EV-2: " + e);
 	switch (e.getID())
 	    {
 	    case WindowEvent.WINDOW_CLOSING:
@@ -212,13 +212,11 @@
 			{
 			case EXIT_ON_CLOSE:
 			    {
-				System.out.println("user requested exit on close");
 				System.exit(1);
 				break;
 			    }
 			case DISPOSE_ON_CLOSE:
 			    {
-				System.out.println("user requested dispose on close");
 				dispose();
 				break;
 			    }
--- javax/swing/JLabel.java	5 Feb 2004 18:48:53 -0000	1.3
+++ javax/swing/JLabel.java	10 Feb 2004 04:19:07 -0000
@@ -148,7 +148,7 @@
     {	return text;    }
 
     public String getUIClassID()
-    {	return "JLabel";    }
+    {	return "LabelUI";    }
 
     public int getVerticalAlignment()
     {
--- javax/swing/JList.java	5 Feb 2004 18:48:53 -0000	1.3
+++ javax/swing/JList.java	10 Feb 2004 04:19:07 -0000
@@ -212,7 +212,7 @@
 
     public String getUIClassID()
     {
-	return "JList";
+	return "ListUI";
     }
 
 
--- javax/swing/JOptionPane.java	11 Jun 2003 13:20:39 -0000	1.2
+++ javax/swing/JOptionPane.java	10 Feb 2004 04:19:07 -0000
@@ -161,7 +161,7 @@
     {	return val;    }
 
     public String getUIClassID()
-    {	return "JOptionPane";    }
+    {	return "OptionPaneUI";    }
 
 
     public void setUI(OptionPaneUI ui) {
--- javax/swing/JPanel.java	9 Jan 2004 10:18:47 -0000	1.3
+++ javax/swing/JPanel.java	10 Feb 2004 04:19:07 -0000
@@ -85,7 +85,7 @@
     } 
 
     public String getUIClassID()
-    {	return "JPanel";    }
+    {	return "PanelUI";    }
 
 
     public void setUI(PanelUI ui) {
--- javax/swing/JPasswordField.java	9 Jan 2004 10:18:47 -0000	1.3
+++ javax/swing/JPasswordField.java	10 Feb 2004 04:19:07 -0000
@@ -102,7 +102,7 @@
 	/**
 	 * uiClassID
 	 */
-	private static final String uiClassID = "PasswordFIeldUI";
+	private static final String uiClassID = "PasswordFieldUI";
 
 	/**
 	 * echoChar.  Default is 0
--- javax/swing/JRadioButton.java	11 Jun 2003 13:20:39 -0000	1.2
+++ javax/swing/JRadioButton.java	10 Feb 2004 04:19:07 -0000
@@ -65,6 +65,8 @@
     public JRadioButton(String text, Icon icon)
     {
 	super(text, icon);
+        paint_border = false;
+        content_area_filled = false;
     }
 
     
@@ -77,7 +79,7 @@
     public String getUIClassID()
     {
 	//Returns a string that specifies the name of the L&F class that renders this component.  
-	return "JRadioButton";
+	return "RadioButtonUI";
     }
   
     protected  String paramString()
--- javax/swing/JRootPane.java	22 Nov 2003 00:03:35 -0000	1.3
+++ javax/swing/JRootPane.java	10 Feb 2004 04:19:07 -0000
@@ -75,7 +75,6 @@
       public Dimension preferredLayoutSize ( Container c )
 	{	    
 	  Dimension p = super.preferredLayoutSize(c);
-	  System.out.println("              PREF-SIZE from RootLayout = " + p);
 	  return p;
 	}        
     }
@@ -97,7 +96,7 @@
     /********************************************************/
 
     public String getUIClassID()
-    {	return "JPanel";    }
+    {	return "RootPaneUI";    }
 
     
     void setJMenuBar(JMenuBar m)
@@ -169,7 +168,7 @@
     JRootPane()
     {
 	setLayout(createRootLayout());
-	
+	setBackground(UIManager.getColor("control"));
 	getGlassPane();
 	getLayeredPane();
 	getContentPane();
--- javax/swing/JScrollPane.java	11 Jun 2003 13:20:39 -0000	1.2
+++ javax/swing/JScrollPane.java	10 Feb 2004 04:19:07 -0000
@@ -86,7 +86,7 @@
     public String getUIClassID()
     {
 	//Returns a string that specifies the name of the L&F class that renders this component.  
-	return "JScrollPane";
+	return "ScrollPaneUI";
     }
 
     public JViewport getViewport()
--- javax/swing/JTabbedPane.java	11 Jun 2003 13:20:39 -0000	1.2
+++ javax/swing/JTabbedPane.java	10 Feb 2004 04:19:07 -0000
@@ -102,7 +102,7 @@
     }
     
     public String getUIClassID()
-    {	return "JTabbedPane";    }
+    {	return "TabbedPaneUI";    }
 
 
     public void setUI(TabbedPaneUI ui) {
--- javax/swing/JToggleButton.java	22 Jan 2004 09:54:15 -0000	1.3
+++ javax/swing/JToggleButton.java	10 Feb 2004 04:19:07 -0000
@@ -44,6 +44,24 @@
 
 public class JToggleButton extends AbstractButton implements Accessible
 {
+
+  public class ToggleButtonModel extends DefaultButtonModel
+  {
+    public void setPressed(boolean b)  
+    {
+      if (! isEnabled())
+        return;
+      
+      super.setPressed(b);
+      
+      // setPressed(false) == mouse release on us,
+      // if we were armed, we flip the selected state.
+      if (!b && isArmed())
+        setSelected(! isSelected());
+    }
+  }
+
+
     public JToggleButton()
     {
 	this(null, null);
@@ -73,9 +91,8 @@
     {
 	super(text, icon);
 
-        // Create the model
+    hori_align = LEADING;
         setModel(new ToggleButtonModel());
-	
         model.setSelected(selected);
     }
 
@@ -90,7 +107,7 @@
     public String getUIClassID()
     {
 	//Returns a string that specifies the name of the L&F class that renders this component.  
-	return "JToggleButton";
+    return "ToggleButtonUI";
     }
   
     protected  String paramString()
--- javax/swing/JTree.java	11 Jun 2003 13:20:39 -0000	1.2
+++ javax/swing/JTree.java	10 Feb 2004 04:19:07 -0000
@@ -83,7 +83,7 @@
     
     public String getUIClassID()
     {
-	return "JTree";
+	return "TreeUI";
     }
 
 
--- javax/swing/JViewport.java	11 Jun 2003 13:20:39 -0000	1.2
+++ javax/swing/JViewport.java	10 Feb 2004 04:19:07 -0000
@@ -69,7 +69,7 @@
 
     public String getUIClassID()
     {
-	return "JViewport";
+	return "ViewportUI";
     }
 
     public void updateUI()
--- javax/swing/SwingUtilities.java	4 Feb 2004 20:43:32 -0000	1.5
+++ javax/swing/SwingUtilities.java	10 Feb 2004 04:19:07 -0000
@@ -95,7 +95,9 @@
   /**
    * Calculates the portion of the component's bounds which is inside the
    * component's border insets. This area is usually the area a component
-   * should confine its painting to.
+   * should confine its painting to. The coordinates are returned in terms
+   * of the <em>component's</em> coordinate system, where (0,0) is the
+   * upper left corner of the component's bounds.
    *
    * @param c The component to measure the bounds of
    * @param r A Rectangle to store the return value in, or
@@ -108,7 +110,8 @@
    */
   public static Rectangle calculateInnerArea(JComponent c, Rectangle r)
   {
-    return calculateInsetArea(c.getBounds(), c.getInsets(), r);
+    Rectangle b = getLocalBounds(c);
+    return calculateInsetArea(b, c.getInsets(), r);
   }
 
   /**
@@ -123,7 +126,7 @@
   public static Rectangle getLocalBounds(Component aComponent)
   {
     Rectangle bounds = aComponent.getBounds();
-    return new Rectangle(0, 0, bounds.x, bounds.y);
+    return new Rectangle(0, 0, bounds.width, bounds.height);
   }
 
   /**
@@ -460,6 +463,7 @@
       ((JComponent)comp).updateUI();
   }
 
+
   /**
    * <p>Layout a "compound label" consisting of a text string and an icon
    * which is to be placed near the rendered text. Once the text and icon
@@ -472,9 +476,10 @@
    *
    * <p>The position values control where the text is placed relative to
    * the icon. The horizontal position value should be one of the constants
-   * <code>LEFT</code>, <code>RIGHT</code> or <code>CENTER</code>. The
-   * vertical position value should be one fo the constants
-   * <code>TOP</code>, <code>BOTTOM</code>, <code>CENTER</code>.</p>
+   * <code>LEADING</code>, <code>TRAILING</code>, <code>LEFT</code>,
+   * <code>RIGHT</code> or <code>CENTER</code>. The vertical position value
+   * should be one fo the constants <code>TOP</code>, <code>BOTTOM</code>
+   * or <code>CENTER</code>.</p>
    *
    * <p>The text-icon gap value controls the number of pixels between the
    * icon and the text.</p>
@@ -488,12 +493,12 @@
    * <code>CENTER</code>.</p>
    *
    * <p>If the <code>LEADING</code> or <code>TRAILING</code> constants are
-   * given for horizontal alignment, they are interpreted relative to the
-   * provided component's orientation property, a constant in the {@link
-   * java.awt.ComponentOrientation} class. For example, if the component's
-   * orientation is <code>LEFT_TO_RIGHT</code>, then the
-   * <code>LEADING</code> alignment is a synonym for <code>LEFT</code> and
-   * the <code>TRAILING</code> alignment is a synonym for
+   * given for horizontal alignment or horizontal text position, they are
+   * interpreted relative to the provided component's orientation property,
+   * a constant in the {@link java.awt.ComponentOrientation} class. For
+   * example, if the component's orientation is <code>LEFT_TO_RIGHT</code>,
+   * then the <code>LEADING</code> value is a synonym for <code>LEFT</code>
+   * and the <code>TRAILING</code> value is a synonym for
    * <code>RIGHT</code></p>
    *
    * <p>If the text and icon are equal to or larger than the view
@@ -523,6 +528,7 @@
    * @return The string of characters, possibly truncated with an elipsis,
    * which is laid out in this label
    */
+
   public static String layoutCompoundLabel(JComponent c, 
                                            FontMetrics fm,
                                            String text, 
@@ -537,6 +543,119 @@
                                            int textIconGap)
   {
 
+    // Fix up the orientation-based horizontal positions.
+
+    if (horizontalTextPosition == LEADING)
+      {
+        if (c.getComponentOrientation() == ComponentOrientation.RIGHT_TO_LEFT)
+          horizontalTextPosition = RIGHT;
+        else
+          horizontalTextPosition = LEFT;
+      }
+    else if (horizontalTextPosition == TRAILING)
+      {
+        if (c.getComponentOrientation() == ComponentOrientation.RIGHT_TO_LEFT)
+          horizontalTextPosition = LEFT;
+        else
+          horizontalTextPosition = RIGHT;
+      }
+
+    // Fix up the orientation-based alignments.
+
+    if (horizontalAlignment == LEADING)
+      {
+        if (c.getComponentOrientation() == ComponentOrientation.RIGHT_TO_LEFT)
+          horizontalAlignment = RIGHT;
+        else
+          horizontalAlignment = LEFT;
+      }
+    else if (horizontalAlignment == TRAILING)
+      {
+        if (c.getComponentOrientation() == ComponentOrientation.RIGHT_TO_LEFT)
+          horizontalAlignment = LEFT;
+        else
+          horizontalAlignment = RIGHT;
+      }
+    
+    return layoutCompoundLabel(fm, text, icon,
+                               verticalAlignment,
+                               horizontalAlignment,
+                               verticalTextPosition,
+                               horizontalTextPosition,
+                               viewR, iconR, textR, textIconGap);
+  }
+
+  /**
+   * <p>Layout a "compound label" consisting of a text string and an icon
+   * which is to be placed near the rendered text. Once the text and icon
+   * are laid out, the text rectangle and icon rectangle parameters are
+   * altered to store the calculated positions.</p>
+   *
+   * <p>The size of the text is calculated from the provided font metrics
+   * object.  This object should be the metrics of the font you intend to
+   * paint the label with.</p>
+   *
+   * <p>The position values control where the text is placed relative to
+   * the icon. The horizontal position value should be one of the constants
+   * <code>LEFT</code>, <code>RIGHT</code> or <code>CENTER</code>. The
+   * vertical position value should be one fo the constants
+   * <code>TOP</code>, <code>BOTTOM</code> or <code>CENTER</code>.</p>
+   *
+   * <p>The text-icon gap value controls the number of pixels between the
+   * icon and the text.</p>
+   *
+   * <p>The alignment values control where the text and icon are placed, as
+   * a combined unit, within the view rectangle. The horizontal alignment
+   * value should be one of the constants <code>LEFT</code>, <code>RIGHT</code> or
+   * <code>CENTER</code>. The vertical alignment valus should be one of the
+   * constants <code>TOP</code>, <code>BOTTOM</code> or
+   * <code>CENTER</code>.</p>
+   *
+   * <p>If the text and icon are equal to or larger than the view
+   * rectangle, the horizontal and vertical alignment values have no
+   * affect.</p>
+   *
+   * <p>Note that this method does <em>not</em> know how to deal with
+   * horizontal alignments or positions given as <code>LEADING</code> or
+   * <code>TRAILING</code> values. Use the other overloaded variant of this
+   * method if you wish to use such values.
+   *
+   * @param fm The font metrics used to measure the text
+   * @param text The text to place in the compound label
+   * @param icon The icon to place next to the text
+   * @param verticalAlignment The vertical alignment of the label relative
+   * to its component
+   * @param horizontalAlignment The horizontal alignment of the label
+   * relative to its component
+   * @param verticalTextPosition The vertical position of the label's text
+   * relative to its icon
+   * @param horizontalTextPosition The horizontal position of the label's
+   * text relative to its icon
+   * @param viewR The view rectangle, specifying the area which layout is
+   * constrained to
+   * @param iconR A rectangle which is modified to hold the laid-out
+   * position of the icon
+   * @param textR A rectangle which is modified to hold the laid-out
+   * position of the text
+   * @param textIconGap The distance between text and icon
+   *
+   * @return The string of characters, possibly truncated with an elipsis,
+   * which is laid out in this label
+   */
+
+  public static String layoutCompoundLabel(FontMetrics fm,
+                                           String text,
+                                           Icon icon,
+                                           int verticalAlignment,
+                                           int horizontalAlignment,
+                                           int verticalTextPosition,
+                                           int horizontalTextPosition,
+                                           Rectangle viewR,
+                                           Rectangle iconR,
+                                           Rectangle textR,
+                                           int textIconGap)
+  {
+
     // Work out basic height and width.
 
     if (icon == null)
@@ -589,23 +708,6 @@
         textR.y = centerLine - textR.height/2;
         iconR.y = centerLine - iconR.height/2;
         break;
-      }
-
-    // Fix up the orientation-based alignments.
-
-    if (horizontalAlignment == LEADING)
-      {
-        if (c.getComponentOrientation() == ComponentOrientation.LEFT_TO_RIGHT)
-          horizontalAlignment = LEFT;
-        else if (c.getComponentOrientation() == ComponentOrientation.RIGHT_TO_LEFT)
-          horizontalAlignment = RIGHT;
-      }
-    else if (horizontalAlignment == TRAILING)
-      {
-        if (c.getComponentOrientation() == ComponentOrientation.LEFT_TO_RIGHT)
-          horizontalAlignment = RIGHT;
-        else if (c.getComponentOrientation() == ComponentOrientation.RIGHT_TO_LEFT)
-          horizontalAlignment = LEFT;
       }
 
     // The two rectangles are laid out correctly now, but only assuming
--- javax/swing/UIDefaults.java	27 Nov 2003 09:04:01 -0000	1.6
+++ javax/swing/UIDefaults.java	10 Feb 2004 04:19:08 -0000
@@ -61,7 +61,7 @@
 /**
  * UIDefaults is a database where all settings and interface bindings are
  * stored into. An PLAF implementation fills one of these (see for example
- * plaf/basic/BasicDefaults.java) with "JButton" -> new BasicButtonUI().
+ * plaf/basic/BasicLookAndFeel.java) with "ButtonUI" -> new BasicButtonUI().
  *
  * @author Ronald Veldema (rveldema@cs.vu.nl)
  */
--- javax/swing/plaf/basic/BasicButtonUI.java	22 Jan 2004 09:54:17 -0000	1.5
+++ javax/swing/plaf/basic/BasicButtonUI.java	10 Feb 2004 04:19:08 -0000
@@ -47,14 +47,20 @@
 import java.awt.Stroke;
 import java.awt.Insets;
 import java.awt.Rectangle;
+import java.awt.event.FocusListener;
 import java.awt.event.FocusAdapter;
 import java.awt.event.FocusEvent;
 import java.awt.event.InputEvent;
 import java.awt.event.MouseAdapter;
 import java.awt.event.MouseEvent;
 import javax.swing.AbstractButton;
+import javax.swing.ButtonModel;
+import javax.swing.Icon;
 import javax.swing.JComponent;
 import javax.swing.SwingUtilities;
+import javax.swing.UIDefaults;
+import javax.swing.UIManager;
+import javax.swing.event.MouseInputListener;
 import javax.swing.plaf.ButtonUI;
 import javax.swing.plaf.ComponentUI;
 
@@ -62,21 +68,11 @@
 {
   /** A constant used to pad out elements in the button's layout and
       preferred size calculations. */
-    int gap = 3;
+  int defaultTextIconGap = 3;
 
-  /** The color that text will be painted when the button is enabled */
-  Color textColor;
-
-  /** The color that text will be painted when the button is disabled */
-  Color disabledTextColor;
-
-  /** The color that the button's background will be painted when the
-      button is pressed. */
-    Color pressedBackgroundColor;
-
-  /** The color that the button's background will be painted when the
-      button is not pressed. */
-  Color normalBackgroundColor;
+  /** A constant added to the defaultTextIconGap to adjust the text
+      within this particular button. */
+  int defaultTextShiftOffset = 0;
 
   /**
    * Factory method to create an instance of BasicButtonUI for a given
@@ -91,120 +87,60 @@
 	return new BasicButtonUI();
     }
 
-  /**
-   * Helper class which listens to a button's focus events and disarms the
-   * button's model when focus is lost.
-   */
-  private static class FocusUIListener extends FocusAdapter
+  public int getDefaultTextIconGap(AbstractButton b)
   {
-    /** Button to listen to focus events from */
-    AbstractButton button;
+    return defaultTextIconGap;
+  }
 
-    /**
-     * Creates a new FocusUIListener object.
-     *
-     * @param b The button to listen to
-     */
-    FocusUIListener(AbstractButton b)
+  protected void installDefaults(AbstractButton b)
     {
-      button = b;
+    UIDefaults defaults = UIManager.getLookAndFeelDefaults();
+    b.setForeground(defaults.getColor("Button.foreground"));
+    b.setBackground(defaults.getColor("Button.background"));
+    b.setMargin(defaults.getInsets("Button.margin"));
+    b.setBorder(defaults.getBorder("Button.border"));
     }
     
-    /**
-     * Called when the button loses focus.
-     *
-     * @param event The loss of focus event.
-     */
-    public void focusLost(FocusEvent event)
+  protected void uninstallDefaults(AbstractButton b)
     {
-      // System.err.println("ButtonUI :: lost focus -- disarming");
-      button.getModel().setArmed(false);
-    }
+    b.setForeground(null);
+    b.setBackground(null);
+    b.setBorder(null);
+    b.setMargin(null);
   }
 
-  /**
-   * A helper class which interprets mouse events as 
-   * state changes to the button's underlying model.
-   */
-  private static class ButtonUIListener extends MouseAdapter
-  {
-    /** The button to change the model of */
-    AbstractButton button;
+  protected BasicButtonListener listener;
 
-    /**
-     * Creates a new ButtonUIListener object.
-     *
-     * @param b The button to change the model of
-     */
-    public ButtonUIListener(AbstractButton b)
+  protected BasicButtonListener createButtonListener(AbstractButton b)
     {
-      button = b;
+    return new BasicButtonListener();
     }
 
-    /**
-     * Accept a mouse press event and arm the button's model.
-     *
-     * @param e The mouse press event to accept
-     */
-    public void mousePressed(MouseEvent e)
-    {
-      // System.err.println("ButtonUI :: mouse pressed");
-      if ((e.getModifiers() & InputEvent.BUTTON1_MASK) != 0)
+  public void installListeners(AbstractButton b)
         {
-          // System.err.println("ButtonUI :: arming");
-          button.getModel().setArmed(true);
-        }
+    listener = createButtonListener(b);
+    b.addChangeListener(listener);
+    b.addPropertyChangeListener(listener);
+    b.addFocusListener(listener);    
+    b.addMouseListener(listener);
+    b.addMouseMotionListener(listener);
     }
 
-    /**
-     * Accept a mouse enter event and set the button's model's
-     * "rollover" property to <code>true</code>. If the button's
-     * model is currently armed and the mouse button is not held
-     * down, this enter event will also disarm the model.
-     *
-     * @param e The mouse enter event to accept
-     */
-    public void mouseEntered(MouseEvent e)
+  public void uninstallListeners(AbstractButton b)
     {
-      // System.err.println("ButtonUI :: mouse entered");
-      // System.err.println("ButtonUI :: rolling over");
-      button.getModel().setRollover(true);
-      if (button.getModel().isArmed() 
-          && (e.getModifiers() & InputEvent.BUTTON1_MASK) == 0)
-        {
-          // System.err.println("ButtonUI :: no button pressed -- disarming");
-          button.getModel().setArmed(false);
-        }
+    b.removeChangeListener(listener);
+    b.removePropertyChangeListener(listener);
+    b.removeFocusListener(listener);    
+    b.removeMouseListener(listener);
+    b.removeMouseMotionListener(listener);
     }
 
-    /**
-     * Accept a mouse exit event and set the button's model's
-     * "rollover" property to <code>false</code>.
-     *
-     * @param e The mouse exit event to accept
-     */
-    public void mouseExited(MouseEvent e)
+  protected void installKeyboardActions(AbstractButton b)
     {
-      // System.err.println("ButtonUI :: mouse exited");
-      button.getModel().setRollover(false);
     }
 
-    /**
-     * Accept a mouse release event and set the button's model's
-     * "pressed" property to <code>true</code>, if the model
-     * is armed. If the model is not armed, ignore the event.
-     *
-     * @param e The mouse release event to accept
-     */
-    public void mouseReleased(MouseEvent e)
+  protected void uninstallKeyboardActions(AbstractButton b)
     {
-      // System.err.println("ButtonUI :: mouse released");
-      if (button.getModel().isArmed()
-          && (e.getModifiers() & InputEvent.BUTTON1_MASK) != 0)
-        {
-          button.getModel().setPressed(true);
-        }
-    }
   }
 
   /**
@@ -218,19 +154,13 @@
     public void installUI(final JComponent c) 
     {
 	super.installUI(c);
-
-	textColor                = new Color(0,0,0);
-	disabledTextColor        = new Color(130, 130, 130);
-	pressedBackgroundColor   = new Color(150,150,150);
-	pressedBackgroundColor   = new Color(150,150,150);
-	normalBackgroundColor    = new Color(192,192,192);
-
-    // this tells the border (if we have one) how to paint.
-    c.setBackground(normalBackgroundColor);
-    ((AbstractButton)c).setMargin (new Insets(10,10,10,10));
-
-    c.addMouseListener(new ButtonUIListener((AbstractButton) c));
-    c.addFocusListener(new FocusUIListener((AbstractButton) c));
+    if (c instanceof AbstractButton)
+      {
+        AbstractButton b = (AbstractButton) c;
+        installDefaults(b);
+        installListeners(b);
+        installKeyboardActions(b);
+      }
   }
 
   /**
@@ -244,10 +174,42 @@
     public Dimension getPreferredSize(JComponent c) 
     {
 	AbstractButton b = (AbstractButton)c;
-	Dimension d = BasicGraphicsUtils.getPreferredButtonSize(b, gap);
+    Dimension d = 
+      BasicGraphicsUtils.getPreferredButtonSize
+      (b, defaultTextIconGap + defaultTextShiftOffset);
 	return d;
     }
     
+  static private Icon currentIcon(AbstractButton b)
+  {
+    Icon i = b.getIcon();
+    ButtonModel model = b.getModel();
+
+    if (model.isPressed() && b.getPressedIcon() != null)
+      i = b.getPressedIcon();
+
+    else if (model.isRollover())
+      {
+        if (b.isSelected() && b.getRolloverSelectedIcon() != null)
+          i = b.getRolloverSelectedIcon();
+        else if (b.getRolloverIcon() != null)
+          i = b.getRolloverIcon();
+      }    
+
+    else if (b.isSelected())
+      {
+        if (b.isEnabled() && b.getSelectedIcon() != null)
+          i = b.getSelectedIcon();
+        else if (b.getDisabledSelectedIcon() != null)
+          i = b.getDisabledSelectedIcon();
+      }
+
+    else if (! b.isEnabled() && b.getDisabledIcon() != null)
+      i = b.getDisabledIcon();
+
+    return i;
+  }
+
   /**
    * Paint the component, which is an {@link AbstractButton}, according to 
    * its current state.
@@ -268,31 +230,21 @@
 
         g.setFont(f);
 
-        FontMetrics fm = g.getFontMetrics(f);
-
-    Insets border = b.getInsets();
-    Insets margin = b.getMargin();
-
-    br.x = border.left;
-    br.y = border.top;
-    br.width = b.getWidth() - (border.right + border.left);
-    br.height = b.getHeight() - (border.top + border.bottom);
-
-    vr.x = br.x + margin.left;
-    vr.y = br.y + margin.top;
-    vr.width = br.width - (margin.right + margin.left);
-    vr.height = br.height - (margin.top + margin.bottom);
-
-    String text = SwingUtilities.layoutCompoundLabel(c, fm, b.getText(),
-							 b.getIcon(),
+    SwingUtilities.calculateInnerArea(b, br);
+    SwingUtilities.calculateInsetArea(br, b.getMargin(), vr);    
+    String text = SwingUtilities.layoutCompoundLabel(c, g.getFontMetrics(f), 
+                                                     b.getText(),
+                                                     currentIcon(b),
 							 b.getVerticalAlignment(), 
 							 b.getHorizontalAlignment(),
 							 b.getVerticalTextPosition(), 
 							 b.getHorizontalTextPosition(),
-                                                     vr, ir, tr, gap);
+                                                     vr, ir, tr, 
+                                                     defaultTextIconGap 
+                                                     + defaultTextShiftOffset);
 
-    if ((b.getModel().isRollover() && b.getModel().isArmed()) 
-        || b.getModel().isSelected())
+    if ((b.getModel().isArmed() && b.getModel().isPressed()) 
+        || b.isSelected())
       paintButtonPressed(g, br, c);
 	else
       paintButtonNormal(g, br, c);
@@ -354,11 +306,13 @@
   protected void paintIcon(Graphics g, JComponent c, Rectangle iconRect)
     {
 	AbstractButton b = (AbstractButton) c;
-	if (b.getIcon() != null)
+    Icon i = currentIcon(b);
+
+    if (i != null)
 	    {
 		int x = iconRect.x;
 		int y = iconRect.y;
-		b.getIcon().paintIcon(c, g, x, y);
+        i.paintIcon(c, g, x, y);
 	    }
     }
 
@@ -373,11 +327,12 @@
    */
   protected void paintButtonPressed(Graphics g, Rectangle area, JComponent b)
     {
-	Dimension size = b.getSize();
-	
-	g.setColor(pressedBackgroundColor);
+    if (((AbstractButton)b).isContentAreaFilled())
+      {
+        g.setColor(b.getBackground().darker());
     g.fillRect(area.x, area.y, area.width, area.height);
     }
+  }
     
   /**
    * Paints the background area of an {@link AbstractButton} in the normal,
@@ -390,10 +345,12 @@
    */
   protected void paintButtonNormal(Graphics g, Rectangle area, JComponent b)
     {
-	Dimension size = b.getSize();
-	g.setColor(normalBackgroundColor);
+    if (((AbstractButton)b).isContentAreaFilled())
+      {
+        g.setColor(b.getBackground());
     g.fillRect(area.x, area.y, area.width, area.height);
     }
+  }
     
   /**
    * Paints the "text" property of an {@link AbstractButton}, using the
@@ -410,9 +367,8 @@
 	Font f = c.getFont();
         g.setFont(f);
         FontMetrics fm = g.getFontMetrics(f);
-	g.setColor(c.isEnabled() ? textColor : disabledTextColor);
-    BasicGraphicsUtils.drawString(g, text, 
-				      0,
+    g.setColor(c.getForeground());
+    BasicGraphicsUtils.drawString(g, text, 0,
 				      textRect.x, 
                                   textRect.y + fm.getAscent());
     } 
--- javax/swing/plaf/basic/BasicCheckBoxUI.java	10 Jan 2004 21:59:30 -0000	1.4
+++ javax/swing/plaf/basic/BasicCheckBoxUI.java	10 Feb 2004 04:19:08 -0000
@@ -38,81 +38,27 @@
 
 package javax.swing.plaf.basic;
 
-import java.awt.Component;
-import java.awt.Dimension;
-import java.awt.Graphics;
-import java.awt.Rectangle;
-import javax.swing.AbstractButton;
+import javax.swing.Icon;
 import javax.swing.JComponent;
+import javax.swing.UIDefaults;
+import javax.swing.UIManager;
 import javax.swing.plaf.ComponentUI;
 
 public class BasicCheckBoxUI extends BasicRadioButtonUI
 {  
+  
     public static ComponentUI createUI(final JComponent c)  {
 	return new BasicCheckBoxUI();
     }
 
-    
-    public void installUI(final JComponent c)  {
-	super.installUI(c);
-    }
-    
-    public Dimension getPreferredSize(JComponent c) 
-    {
-	AbstractButton b = (AbstractButton)c;
-	Dimension d = BasicGraphicsUtils.getPreferredButtonSize(b, gap);
-	//System.out.println("^^^^^^^^^^^^^^^^^^^^^^   BASIC-PREF="+d + ",T="+b.text);
-	return d;
-    }
-    
-    protected void paintFocus(Graphics g, 
-			      JComponent c,
-			      Rectangle vr,
-			      Rectangle tr,
-			      Rectangle ir)
-    {
-    }
-
-    protected void paintIcon(Graphics g, 
-			     JComponent c, 
-			     Rectangle iconRect)
-    {
-    }
-
-    protected void paintButtonPressed(Graphics g,
-				      JComponent b)
+  public Icon getDefaultIcon()
     {
-	Dimension size = b.getSize();
-	
-	g.setColor(pressedBackgroundColor);
-	g.fillRect(1,1,size.width-2, size.height-2);                
-
+    UIDefaults defaults = UIManager.getLookAndFeelDefaults();
+    return defaults.getIcon("CheckBox.icon");
     }
     
-    protected void paintButtonNormal(Graphics g,
-				     JComponent b)
-    {
-	Dimension size = b.getSize();
-	
-	g.setColor(normalBackgroundColor);
-	g.fillRect(1,1,size.width-2, size.height-2);                
-
-    }
-    protected void paintText(Graphics g,
-			     JComponent c,
-			     Rectangle textRect,
-			     String text) 
-    {
-	//        AbstractButton b = (AbstractButton) c;
-	
-	//	System.out.println("drawing string: " + text + ", at:" + textRect);
-	
-	g.setColor(textColor);
-	BasicGraphicsUtils.drawString(g,
-				      text, 
-				      0,
-				      textRect.x, 
-				      textRect.y);
+  public void installUI(final JComponent c)  {
+    super.installUI(c);
     } 
 }
 
--- javax/swing/plaf/basic/BasicIconFactory.java	10 May 2003 08:14:36 -0000	1.2
+++ javax/swing/plaf/basic/BasicIconFactory.java	10 Feb 2004 04:19:08 -0000
@@ -39,7 +39,14 @@
 package javax.swing.plaf.basic;
 
 import java.io.Serializable;
+import java.awt.Color;
+import java.awt.Component;
+import java.awt.Graphics;
+import java.awt.Polygon;
+import javax.swing.AbstractButton;
 import javax.swing.Icon;
+import javax.swing.UIDefaults;
+import javax.swing.UIManager;
 /**
  * STUBBED
  */
@@ -47,39 +54,156 @@
 {
   static final long serialVersionUID = 5605588811185324383L;
 
+  static private class DummyIcon 
+    implements Icon
+  {    
+    public int getIconHeight() { return 10; }
+    public int getIconWidth() { return 10; }
+    public void paintIcon(Component c, Graphics g, int x, int y)
+    {
+      Color save = g.getColor();
+      g.setColor(c.getForeground());
+      g.drawRect(x, y, 10, 10);
+      g.setColor(save);
+    }
+  }
+
+
   public BasicIconFactory()
   {
   }
   public static Icon getMenuItemCheckIcon()
   {
-    return null;
+    return new DummyIcon();
   }
   public static Icon getMenuItemArrowIcon()
   {
-    return null;
+    return new DummyIcon();
   }
   public static Icon getMenuArrowIcon()
   {
-    return null;
+    return new DummyIcon();
   }
+
   public static Icon getCheckBoxIcon()
   {
-    return null;
+    return new Icon()
+      {        
+        public int getIconHeight() 
+        { 
+          return 10; 
+        }
+        public int getIconWidth() 
+        { 
+          return 10; 
+        }
+        public void paintIcon(Component c, Graphics g, int x, int y)
+        {
+          if (c instanceof AbstractButton)
+            {
+              UIDefaults defaults;
+              defaults = UIManager.getLookAndFeelDefaults();
+              Color hi = defaults.getColor("CheckBox.highlight");
+              Color low = defaults.getColor("CheckBox.darkShadow");
+              Color sel = defaults.getColor("CheckBox.foreground");
+              Color dim = defaults.getColor("CheckBox.shadow");
+              Polygon check = new Polygon(new int[] {x+3, x+3, x+8},
+                                          new int[] {y+5, y+9, y+3}, 3);
+              AbstractButton b = (AbstractButton) c;
+              Color saved = g.getColor();
+              if (b.isEnabled())
+                {
+                  g.setColor(low);
+                  g.drawRect(x, y, 10, 10);
+                  g.setColor(hi);
+                  g.drawRect(x+1, y+1, 10, 10);
+                  if (b.isSelected())
+                    {
+                      g.setColor(sel);
+                      if (b.isSelected())
+                        {
+                          g.drawLine(x+3, y+5, x+3, y+8);
+                          g.drawLine(x+4, y+5, x+4, y+8);
+                          g.drawLine(x+3, y+8, x+8, y+3);
+                          g.drawLine(x+4, y+8, x+8, y+3);
+                        }
+                    }
+                }
+              else
+                {                  
+                  g.setColor(hi);
+                  g.drawRect(x, y, 10, 10);
+                  if (b.isSelected())
+                    {
+                      g.drawLine(x+3, y+5, x+3, y+9);
+                      g.drawLine(x+3, y+9, x+8, y+3);
   }
+                }
+              g.setColor(saved);
+            }
+        }
+      };
+  }
+
   public static Icon getRadioButtonIcon()
   {
-    return null;
+    return new Icon()
+      {        
+        public int getIconHeight() 
+        { 
+          return 12; 
+        }
+        public int getIconWidth() 
+        { 
+          return 12; 
+        }
+        public void paintIcon(Component c, Graphics g, int x, int y)
+        {
+          UIDefaults defaults;      
+          defaults = UIManager.getLookAndFeelDefaults();
+          Color hi = defaults.getColor("RadioButton.highlight");
+          Color low = defaults.getColor("RadioButton.darkShadow");
+          Color sel = defaults.getColor("RadioButton.foreground");
+          Color dim = defaults.getColor("RadioButton.shadow");
+
+          if (c instanceof AbstractButton)
+            {
+              AbstractButton b = (AbstractButton) c;
+              Color saved = g.getColor();
+              if (b.isEnabled())
+                {
+                  g.setColor(low);
+                  g.drawOval(x, y, 12, 12);
+                  g.setColor(hi);
+                  g.drawOval(x+1, y+1, 12, 12);
+                  if (b.isSelected())
+                    {
+                      g.setColor(sel);
+                      g.fillOval(x+4, y+4, 6, 6);
+                    }
+                }
+              else
+                {                  
+                  g.setColor(hi);
+                  g.drawOval(x, y, 12, 12);
+                  if (b.isSelected())
+                    g.fillOval(x+4, y+4, 6, 6);
+                }
+              g.setColor(saved);
+            }
+        }
+      };
   }
   public static Icon getCheckBoxMenuItemIcon()
   {
-    return null;
+    return new DummyIcon();
   }
   public static Icon getRadioButtonMenuItemIcon()
   {
-    return null;
+    return new DummyIcon();
   }
   public static Icon createEmptyFrameIcon()
   {
-    return null;
+    return new DummyIcon();
   }
 } // class BasicIconFactory
--- javax/swing/plaf/basic/BasicLookAndFeel.java	13 Jul 2003 15:29:11 -0000	1.3
+++ javax/swing/plaf/basic/BasicLookAndFeel.java	10 Feb 2004 04:19:08 -0000
@@ -227,29 +227,40 @@
   {
     Object[] uiDefaults;
     uiDefaults = new Object[] {
+
+      "AbstractUndoableEdit.undoText", "Undo",
+      "AbstractUndoableEdit.redoText", "Redo",
+
       "Button.background", new ColorUIResource(Color.lightGray),
-      "Button.border", new BorderUIResource.CompoundBorderUIResource(null,
-                                                                     null),
+      "Button.border", BorderUIResource.getEtchedBorderUIResource(),
+      "Button.darkShadow", new ColorUIResource(Color.darkGray),
       "Button.focusInputMap", new UIDefaults.LazyInputMap(new Object[] {
         "SPACE",  "pressed",
         "released SPACE", "released"
       }),
       "Button.font", new FontUIResource("Dialog", Font.PLAIN, 12),
       "Button.foreground", new ColorUIResource(Color.black),
+      "Button.highlight", new ColorUIResource(Color.white),
+      "Button.light", new ColorUIResource(Color.lightGray.brighter()),
       "Button.margin", new InsetsUIResource(2, 14, 2, 14),
+      "Button.shadow", new ColorUIResource(Color.gray),
       "Button.textIconGap", new Integer(4),
       "Button.textShiftOffset", new Integer(0),
       "CheckBox.background", new ColorUIResource(Color.lightGray),
       "CheckBox.border", new BorderUIResource.CompoundBorderUIResource(null,
                                                                        null),
+      "CheckBox.darkShadow", new ColorUIResource(Color.darkGray),
       "CheckBox.focusInputMap", new UIDefaults.LazyInputMap(new Object[] {
         "SPACE",  "pressed",
         "released SPACE", "released"
       }),
       "CheckBox.font", new FontUIResource("Dialog", Font.PLAIN, 12),
       "CheckBox.foreground", new ColorUIResource(Color.black),
+      "CheckBox.highlight", new ColorUIResource(Color.white),
       "CheckBox.icon", BasicIconFactory.getCheckBoxIcon(),
+      "CheckBox.light", new ColorUIResource(Color.lightGray.brighter()),
       "CheckBox.margin",new InsetsUIResource(2, 2, 2, 2),
+      "CheckBox.shadow", new ColorUIResource(Color.gray),
       "CheckBox.textIconGap", new Integer(4),
       "CheckBox.textShiftOffset", new Integer(0),
       "CheckBoxMenuItem.acceleratorFont", new FontUIResource("Dialog",
@@ -540,7 +551,7 @@
       "PopupMenu.font", new FontUIResource("Dialog", Font.PLAIN, 12),
       "PopupMenu.foreground", new ColorUIResource(Color.black),
       "ProgressBar.background", new ColorUIResource(Color.lightGray),
-      "ProgressBar.border", new BorderUIResource.LineBorderUIResource(null),
+      "ProgressBar.border", new BorderUIResource.LineBorderUIResource(Color.darkGray),
       "ProgressBar.cellLength", new Integer(1),
       "ProgressBar.cellSpacing", new Integer(0),
       "ProgressBar.font", new FontUIResource("Dialog", Font.PLAIN, 12),
@@ -550,14 +561,18 @@
       "RadioButton.background", new ColorUIResource(Color.lightGray),
       "RadioButton.border", new BorderUIResource.CompoundBorderUIResource(null,
                                                                           null),
+      "RadioButton.darkShadow", new ColorUIResource(Color.darkGray),
       "RadioButton.focusInputMap", new UIDefaults.LazyInputMap(new Object[] {
         "SPACE",  "pressed",
         "released SPACE", "released"
       }),
       "RadioButton.font", new FontUIResource("Dialog", Font.PLAIN, 12),
       "RadioButton.foreground", new ColorUIResource(Color.black),
+      "RadioButton.highlight", new ColorUIResource(Color.white),
       "RadioButton.icon", BasicIconFactory.getRadioButtonIcon(),
+      "RadioButton.light", new ColorUIResource(Color.lightGray.brighter()),
       "RadioButton.margin", new InsetsUIResource(2, 2, 2, 2),
+      "RadioButton.shadow", new ColorUIResource(Color.gray),
       "RadioButton.textIconGap", new Integer(4),
       "RadioButton.textShiftOffset", new Integer(0),
       "RadioButtonMenuItem.acceleratorFont", new FontUIResource("Dialog",
@@ -742,7 +757,7 @@
       "Table.background", new ColorUIResource(Color.white),
       "Table.focusCellBackground", new ColorUIResource(Color.white),
       "Table.focusCellForeground", new ColorUIResource(Color.black),
-      "Table.focusCellHighlightBorder", new BorderUIResource.LineBorderUIResource(null),
+      "Table.focusCellHighlightBorder", new BorderUIResource.LineBorderUIResource(Color.white),
       "Table.font", new FontUIResource("Dialog", Font.PLAIN, 12),
       "Table.foreground", new ColorUIResource(Color.black),
       "Table.gridColor", new ColorUIResource(Color.gray),
@@ -849,7 +864,7 @@
       "ToolBar.foreground", new ColorUIResource(Color.black),
       "ToolBar.separatorSize", new DimensionUIResource(10, 10),
       "ToolTip.background", new ColorUIResource(Color.white),
-      "ToolTip.border", new BorderUIResource.LineBorderUIResource(null),
+      "ToolTip.border", new BorderUIResource.LineBorderUIResource(Color.lightGray),
       "ToolTip.font", new FontUIResource("SansSerif", Font.PLAIN, 12),
       "ToolTip.foreground", new ColorUIResource(Color.black),
       "Tree.ancestorInputMap", new UIDefaults.LazyInputMap(new Object[] {
@@ -860,7 +875,7 @@
       // XXX Don't use gif
       "Tree.closedIcon", new IconUIResource(new ImageIcon("icons/TreeClosed.gif")),
       "Tree.drawsFocusBorderAroundIcon", Boolean.FALSE,
-      "Tree.editorBorder", new BorderUIResource.LineBorderUIResource(null),
+      "Tree.editorBorder", new BorderUIResource.LineBorderUIResource(Color.lightGray),
       "Tree.focusInputMap", new UIDefaults.LazyInputMap(new Object[] {
         "shift PAGE_DOWN", "scrollDownExtendSelection",
         "PAGE_DOWN", "scrollDownChangeSelection",
--- javax/swing/plaf/basic/BasicPanelUI.java	10 Jan 2004 21:59:30 -0000	1.3
+++ javax/swing/plaf/basic/BasicPanelUI.java	10 Feb 2004 04:19:08 -0000
@@ -44,8 +44,6 @@
 
 public class BasicPanelUI extends PanelUI
 {
-    int gap = 3;
-
     public static ComponentUI createUI(JComponent x) 
     {
         return new BasicPanelUI();
--- javax/swing/plaf/basic/BasicRadioButtonUI.java	10 Jan 2004 21:59:30 -0000	1.4
+++ javax/swing/plaf/basic/BasicRadioButtonUI.java	10 Feb 2004 04:19:08 -0000
@@ -38,116 +38,42 @@
 
 package javax.swing.plaf.basic;
 
-import java.awt.Color;
-import java.awt.Dimension;
-import java.awt.Graphics;
-import java.awt.Rectangle;
 import javax.swing.AbstractButton;
+import javax.swing.Icon;
 import javax.swing.JComponent;
+import javax.swing.UIDefaults;
+import javax.swing.UIManager;
 import javax.swing.plaf.ComponentUI;
 
 public class BasicRadioButtonUI extends BasicToggleButtonUI
 {
-  int large_circle_width = 20;
-  int circle_width = large_circle_width - 8; // FIXME: sun == ?
+
+  protected Icon icon;
   
     public static ComponentUI createUI(final JComponent c)  {
 	return new BasicRadioButtonUI();
     }
 
+  public BasicRadioButtonUI()
+  {
+    icon = getDefaultIcon();
+  }
     
     public void installUI(final JComponent c)  {
 	super.installUI(c);
-    }
-    
-    public Dimension getPreferredSize(JComponent c) 
+    if (c instanceof AbstractButton)
     {
 	AbstractButton b = (AbstractButton)c;
-	Dimension d = BasicGraphicsUtils.getPreferredButtonSize(b, gap);
-	
-	// and add a little something for the circles:
-
-	d.width += large_circle_width;
-	d.height = Math.max(large_circle_width, d.height);
-	
-	//System.out.println("^^^^^^^^^^^^^^^^^^^^^^   BASIC-PREF="+d + ",T="+b.text);
-	return d;
+        b.setIcon(icon);
     }
-    
-    protected void paintFocus(Graphics g, 
-			      JComponent c,
-			      Rectangle vr,
-			      Rectangle tr,
-			      Rectangle ir)
-    {
-    }
-
-    protected void paintIcon(Graphics g, 
-			     JComponent c, 
-			     Rectangle iconRect)
-    {
-    }
-
-    protected void paintButtonPressed(Graphics g,
-				      JComponent b)
-    {
-	Dimension size = b.getSize();
-	
-	paintButtonNormal(g, b);
-
-	int x = gap;
-	int y = gap;
-
-	int diffp = 2;
-	int diff = 3;
-	
-	g.setColor(textColor);
-	g.fillArc(x+diffp, y+diffp, 
-		  circle_width-diff, circle_width-diff,
-		  0, 360);
     }
     
-    protected void paintButtonNormal(Graphics g,
-				     JComponent c)
+  public Icon getDefaultIcon()
     {
-	AbstractButton b = (AbstractButton) c;
-	
-	Dimension size = b.getSize();
-	
-	g.setColor(normalBackgroundColor);
-	g.fillRect(1,1,size.width-2, size.height-2);  
-	
-	int x = gap;
-	int y = gap;
-	
-	g.setColor(pressedBackgroundColor);
-	g.drawArc(x, y,
-		  circle_width, circle_width,
-		  0, 360);
-
-	g.setColor(new Color(255,255,255));
-	g.drawArc(x, y,
-		  circle_width+1, circle_width+1,
-		  145, 160);
+    UIDefaults defaults = UIManager.getLookAndFeelDefaults();
+    return defaults.getIcon("RadioButton.icon");
     }
     
-    protected void paintText(Graphics g,
-			     JComponent c,
-			     Rectangle textRect,
-			     String text) 
-    {
-	//        AbstractButton b = (AbstractButton) c;
-	
-	//System.out.println("drawing string: " + text + ", " + c.isEnabled());
-	
-	g.setColor(c.isEnabled() ? textColor : disabledTextColor);
-	
-	BasicGraphicsUtils.drawString(g,
-				      text, 
-				      0,
-				      textRect.x + circle_width + gap, 
-				      textRect.y);
-    } 
 }
 
 
--- javax/swing/plaf/basic/BasicToggleButtonUI.java	10 Jan 2004 21:59:30 -0000	1.4
+++ javax/swing/plaf/basic/BasicToggleButtonUI.java	10 Feb 2004 04:19:08 -0000
@@ -51,71 +51,6 @@
     public static ComponentUI createUI(final JComponent c)  {
 	return new BasicToggleButtonUI();
     }
-
-    
-    public void installUI(final JComponent c)  {
-	super.installUI(c);
-    }
-    
-    public Dimension getPreferredSize(JComponent c) 
-    {
-	AbstractButton b = (AbstractButton)c;
-	Dimension d = BasicGraphicsUtils.getPreferredButtonSize(b, gap);
-							  
-	//System.out.println("^^^^^^^^^^^^^^^^^^^^^^   BASIC-PREF="+d + ",T="+b.text);
-	return d;
-    }
-    
-    protected void paintFocus(Graphics g, 
-			      JComponent c,
-			      Rectangle vr,
-			      Rectangle tr,
-			      Rectangle ir)
-    {
-    }
-
-    protected void paintIcon(Graphics g, 
-			     JComponent c, 
-			     Rectangle iconRect)
-    {
-    }
-
-    protected void paintButtonPressed(Graphics g,
-				      JComponent b)
-    {
-	Dimension size = b.getSize();
-	
-	g.setColor(pressedBackgroundColor);
-	g.fillRect(1,1,size.width-2, size.height-2);                
-
-    }
-    
-    protected void paintButtonNormal(Graphics g,
-				     JComponent b)
-    {
-	Dimension size = b.getSize();
-	
-	g.setColor(normalBackgroundColor);
-	g.fillRect(1,1,size.width-2, size.height-2);                
-
-    }
-    protected void paintText(Graphics g,
-			     JComponent c,
-			     Rectangle textRect,
-			     String text) 
-    {
-	//        AbstractButton b = (AbstractButton) c;
-	
-	//	System.out.println("drawing string: " + text + ", at:" + textRect);
-	
-	g.setColor(textColor);
-
-	BasicGraphicsUtils.drawString(g,
-				      text, 
-				      0,	
-				      textRect.x, 
-				      textRect.y);
-    } 
 }
 
 
--- javax/swing/plaf/metal/MetalLookAndFeel.java	12 Oct 2003 13:26:01 -0000	1.4
+++ javax/swing/plaf/metal/MetalLookAndFeel.java	10 Feb 2004 04:19:08 -0000
@@ -40,7 +40,6 @@
 package javax.swing.plaf.metal;
 
 import javax.swing.UIDefaults;
-import javax.swing.plaf.basic.BasicDefaults;
 import javax.swing.plaf.basic.BasicLookAndFeel;
 
 public class MetalLookAndFeel extends BasicLookAndFeel
@@ -61,7 +60,7 @@
      public UIDefaults getDefaults()
 	 {
 	   if (LAF_defaults == null)
-	     LAF_defaults = new BasicDefaults();
+	     LAF_defaults = super.getDefaults();
 	     
 	     //      Returns the default values for this look and feel. 
 	     return LAF_defaults;
--- javax/swing/text/JTextComponent.java	24 Jun 2003 09:51:28 -0000	1.3
+++ javax/swing/text/JTextComponent.java	10 Feb 2004 04:19:08 -0000
@@ -406,7 +406,7 @@
     public String getUIClassID()
     {
 	//          Returns a string that specifies the name of the l&f class that renders this component.  
-	return "JTextComponent";
+	return "TextComponentUI";
     }
     public int getVerticalAlignment()
     {
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c	8 Oct 2003 23:38:45 -0000	1.4
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphics.c	10 Feb 2004 04:19:08 -0000
@@ -316,12 +316,24 @@
   (JNIEnv *env, jobject obj, jint x, jint y, jint width, jint height)
 {
   struct graphics *g;
+  GdkGCValues saved;
 
   g = (struct graphics *) NSA_GET_PTR (env, obj);
 
   gdk_threads_enter ();
+  if (GDK_IS_WINDOW (g->drawable))
+    {
   gdk_window_clear_area ((GdkWindow *)g->drawable, 
 			 x + g->x_offset, y + g->y_offset, width, height);
+    }
+  else
+    {
+      gdk_gc_get_values (g->gc, &saved);
+      gdk_gc_set_foreground (g->gc, &(saved.background));
+      gdk_draw_rectangle (g->drawable, g->gc, TRUE, 
+			  x + g->x_offset, y + g->y_offset, width, height);
+      gdk_gc_set_foreground (g->gc, &(saved.foreground));
+    }
   gdk_threads_leave ();
 }
 
--- javax/swing/plaf/basic/BasicButtonListener.java
+++ javax/swing/plaf/basic/BasicButtonListener.java
@@ -0,0 +1,188 @@
+/* BasicButtonListener.java
+   Copyright (C) 2004 Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+package javax.swing.plaf.basic;
+
+import java.awt.event.FocusEvent;
+import java.awt.event.FocusListener;
+import java.awt.event.InputEvent;
+import java.awt.event.MouseEvent;
+import java.awt.event.MouseListener;
+import java.awt.event.MouseMotionListener;
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
+import javax.swing.AbstractButton;
+import javax.swing.ButtonModel;
+import javax.swing.UIDefaults;
+import javax.swing.UIManager;
+import javax.swing.event.ChangeEvent;
+import javax.swing.event.ChangeListener;
+import javax.swing.JComponent;
+
+public class BasicButtonListener
+  implements MouseListener, MouseMotionListener, FocusListener, 
+             ChangeListener, PropertyChangeListener
+{
+  public void propertyChange(PropertyChangeEvent e)
+  {
+  }
+  protected void checkOpacity(AbstractButton b) 
+  {    
+  }
+  public void focusGained(FocusEvent e) 
+  {    
+  }
+
+  public void focusLost(FocusEvent e)
+  {
+    if (e.getSource() instanceof AbstractButton)
+      {
+        AbstractButton button = (AbstractButton) e.getSource();
+        ButtonModel model = button.getModel();
+        model.setArmed(false);
+      }
+  }
+  public void installKeyboardActions(JComponent c)
+  {
+  }
+  public void uninstallKeyboardActions(JComponent c)
+  {
+  }
+  public void stateChanged(ChangeEvent e)
+  {
+  }
+  public void mouseMoved(MouseEvent e)
+  {
+    System.err.println("button got mouse move");
+  }
+  public void mouseDragged(MouseEvent e)
+  {
+    System.err.println("button got mouse drag");
+  }
+  public void mouseClicked(MouseEvent e)
+  {
+    System.err.println("button got mouse click");
+  }
+
+  /**
+   * Accept a mouse press event and arm the button.
+   *
+   * @param e The mouse press event to accept
+   */
+  public void mousePressed(MouseEvent e)
+  {
+    if (e.getSource() instanceof AbstractButton)
+      {
+        AbstractButton button = (AbstractButton) e.getSource();
+        ButtonModel model = button.getModel();
+        if ((e.getModifiers() & InputEvent.BUTTON1_MASK) != 0)
+          {
+            // It is important that these transitions happen in this order.
+            model.setArmed(true);
+            model.setPressed(true);
+          }
+      }
+  }
+
+
+  /**
+   * Accept a mouse release event and set the button's 
+   * "pressed" property to <code>true</code>, if the model
+   * is armed. If the model is not armed, ignore the event.
+   *
+   * @param e The mouse release event to accept
+   */
+  public void mouseReleased(MouseEvent e)
+  {
+    if (e.getSource() instanceof AbstractButton)
+      {
+        AbstractButton button = (AbstractButton) e.getSource();
+        ButtonModel model = button.getModel();
+        if ((e.getModifiers() & InputEvent.BUTTON1_MASK) != 0)
+          {
+            // It is important that these transitions happen in this order.
+            model.setPressed(false);
+            model.setArmed(false);
+          }
+      }
+  }
+
+
+  /**
+   * Accept a mouse enter event and set the button's "rollover" property to
+   * <code>true</code>, if the button's "rolloverEnabled" property is
+   * <code>true</code>. If the button is currently armed and the mouse
+   * button is not held down, this enter event will also disarm the model.
+   *
+   * @param e The mouse enter event to accept
+   */
+  public void mouseEntered(MouseEvent e)
+  {
+    if (e.getSource() instanceof AbstractButton)
+      {
+        AbstractButton button = (AbstractButton) e.getSource();
+        ButtonModel model = button.getModel();
+        if (button.isRolloverEnabled())
+          model.setRollover(true);
+        
+        if (model.isPressed() 
+            && (e.getModifiers() & InputEvent.BUTTON1_MASK) != 0)
+          model.setArmed(true);
+        else
+          model.setArmed(false);
+      }
+  }
+
+  /**
+   * Accept a mouse exit event and set the button's model's "rollover"
+   * property to <code>false</code>, if it's "rolloverEnabled" property is
+   * <code>true</code>. Also disarm the button.
+   *
+   * @param e The mouse exit event to accept
+   */
+  public void mouseExited(MouseEvent e)
+  {
+    if (e.getSource() instanceof AbstractButton)
+      {
+        AbstractButton button = (AbstractButton) e.getSource();
+        ButtonModel model = button.getModel();
+        if (button.isRolloverEnabled())
+          model.setRollover(false);
+        model.setArmed(false);
+      }
+  }
+}
--- javax/swing/plaf/basic/BasicRootPaneUI.java
+++ javax/swing/plaf/basic/BasicRootPaneUI.java
@@ -0,0 +1,57 @@
+/* BasicPanelUI.java
+   Copyright (C) 2002 Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+
+package javax.swing.plaf.basic;
+
+import javax.swing.*;
+import javax.swing.plaf.*;
+import java.awt.*;
+
+
+public class BasicRootPaneUI extends RootPaneUI
+{
+    public static ComponentUI createUI(JComponent x) 
+    {
+        return new BasicRootPaneUI();
+    }
+
+    public void installUI(JComponent c)
+    {
+      super.installUI(c);
+    }
+}

--------------020100060203080204080809--



From MAILER-DAEMON Tue Feb 10 02:31:02 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AqSMG-0000oa-JI
	for mharc-classpath@gnu.org; Tue, 10 Feb 2004 02:31:00 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AqSM8-0000ck-AK
	for classpath@gnu.org; Tue, 10 Feb 2004 02:30:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AqSLQ-0000Eb-Ar
	for classpath@gnu.org; Tue, 10 Feb 2004 02:30:39 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqSKn-0008OP-6o
	for classpath@gnu.org; Tue, 10 Feb 2004 02:29:29 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-MIMEOLE: Produced By Microsoft Exchange V6.5.6944.0
Date: Tue, 10 Feb 2004 08:29:12 +0100
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C8BF@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: java.io.ObjectInputStream throws ArrayIndexOutOfBoundsException
Thread-Index: AcPvW9NXBkfWvUugRNqbhyhPQopM7wASV1Yw
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Ito Kazumitsu" <kaz@maczuka.gcd.org>,
	<classpath@gnu.org>
Cc: 
Subject: RE: java.io.ObjectInputStream throws ArrayIndexOutOfBoundsException
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2004 07:30:56 -0000

Ito Kazumitsu wrote:
> As reported in the Kaffe mailing list[1], java.io.ObjectInputStream
> throws ArrayIndexOutOfBoundsException in some unusual case.

Sorry about that one. Fix looks good. I've checked it in.

Thanks!

Regards,
Jeroen



From MAILER-DAEMON Tue Feb 10 14:19:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AqdPe-00056A-EX
	for mharc-classpath@gnu.org; Tue, 10 Feb 2004 14:19:14 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AqdPc-00055m-06
	for classpath@gnu.org; Tue, 10 Feb 2004 14:19:12 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AqdP5-0004w6-4L
	for classpath@gnu.org; Tue, 10 Feb 2004 14:19:10 -0500
Received: from [66.33.197.214] (helo=ludo.dreamhost.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqdP4-0004tc-ES
	for classpath@gnu.org; Tue, 10 Feb 2004 14:18:38 -0500
Received: from dexter (c-24-6-46-122.client.comcast.net [24.6.46.122])
	by ludo.dreamhost.com (Postfix) with ESMTP id 6B04928398
	for <classpath@gnu.org>; Tue, 10 Feb 2004 11:18:35 -0800 (PST)
Received: by dexter (Postfix, from userid 1000)
	id 8830DC; Tue, 10 Feb 2004 11:18:34 -0800 (PST)
To: classpath@gnu.org
From: Casey Marshall <rsdio@metastatic.org>
Date: Tue, 10 Feb 2004 11:18:34 -0800
Message-ID: <87smhivj3p.fsf@metastatic.org>
User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Subject: Access control contexts (silly idea)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2004 19:19:12 -0000

--=-=-=

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I was looking into ways to implement the AccessController.getContext
method, and devised a way to do it without dipping into native
methods. In short, it uses the getStackTrace method of Throwable to
obtain the current stack, fetches each Class named in the stack, then
gets the ProtectionDomain for that Class.

This is a kludge, and I would not be surprised that certain conditions
cause this to fail.

At any rate, there is a bug in the AccessControlContext constructor
that references the protectionDomain array before it is created.

Patches attached. Comments?

2004-02-10  Casey Marshall <rsdio@metastatic.org>

	* java/security/AccessControlContext.java
	(<init>): compare entries in the `context' array.
	Use `equals', not `=='.
	(toString): new method.

2004-02-10  Casey Marshall <rsdio@metastatic.org>

	* java/security/AccessController.java
	(contexts): new class field.
	(defaultContext): new constant.
	(doPrivileged): put supplied contexts into `contexts'.
	(doPrivileged): likewise.
	(getContext): implemented.

	* java/lang/SecurityManager.java
	(getSecurityContext): use AccessController.getContext().
	(checkPermission): use AccessControlContext.checkPermission().
	(checkPermission): likewise.
	(checkConnect): likewise.

- -- 
Casey Marshall || rsdio@metastatic.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.7 <http://mailcrypt.sourceforge.net/>

iD8DBQFAKS4PgAuWMgRGsWsRAkO5AJ9uKub/3ocBRbYyYKzgnYZZ+KSbrwCeMRDc
mmymlIQIaDZrsJ2cwA/PlBU=
=DvZ9
-----END PGP SIGNATURE-----

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=ac.patch
Content-Description: Patch to AccessController

Index: java/security/AccessController.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/security/AccessController.java,v
retrieving revision 1.5
diff -u -w -r1.5 AccessController.java
--- java/security/AccessController.java	6 May 2002 16:19:20 -0000	1.5
+++ java/security/AccessController.java	10 Feb 2004 18:52:38 -0000
@@ -1,5 +1,5 @@
 /* AccessController.java --- Access control context and permission checker
-   Copyright (C) 2001 Free Software Foundation, Inc.
+   Copyright (C) 2001,2004 Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
 
@@ -37,6 +37,15 @@
 
 package java.security;
 
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
 /**
  * Access control context and permission checker.
  * Can check permissions in the access control context of the current thread
@@ -58,6 +67,27 @@
  */
 public final class AccessController
 {
+
+  /**
+   * A mapping between pairs (<i>thread</i>, <i>classname</i>) to access
+   * control contexts. The <i>thread</i> and <i>classname</i> are the thread
+   * and <i>classname</i> current as of the last call to doPrivileged with
+   * an AccessControlContext argument.
+   */
+  private final static Map contexts = Collections.synchronizedMap(new HashMap());
+
+  private final static AccessControlContext defaultContext;
+  static
+  {
+    CodeSource source = new CodeSource(null, null);
+    Permissions permissions = new Permissions();
+    permissions.add(new AllPermission());
+    ProtectionDomain[] domain = new ProtectionDomain[] {
+      new ProtectionDomain(source, permissions)
+    };
+    defaultContext = new AccessControlContext(domain);
+  }
+
   /**
    * This class only has static methods so there is no public contructor.
    */
@@ -115,8 +145,19 @@
   public static Object doPrivileged(PrivilegedAction action,
 				    AccessControlContext context)
   {
+    final List pair = new ArrayList(2);
+    pair.add(Thread.currentThread());
+    pair.add(action.getClass().getName());
+    contexts.put(pair, context);
+    try
+      {
     return action.run();
   }
+    finally
+      {
+        contexts.remove(pair);
+      }
+  }
 
   /**
    * Calls the <code>run()</code> method of the given action with as
@@ -170,6 +211,10 @@
 				    AccessControlContext context)
     throws PrivilegedActionException
   {
+    final List pair = new ArrayList(2);
+    pair.add(Thread.currentThread());
+    pair.add(action.getClass().getName());
+    contexts.put(pair, context);
 
     try
       {
@@ -179,6 +224,10 @@
       {
 	throw new PrivilegedActionException(e);
       }
+    finally
+      {
+        contexts.remove(pair);
+      }
   }
 
   /**
@@ -191,7 +240,61 @@
    */
   public static AccessControlContext getContext()
   {
-    // For now just return an new empty context
-    return new AccessControlContext(new ProtectionDomain[0]);
+    List domains = new LinkedList();
+    Set classes = new HashSet();
+    StackTraceElement[] stack = new Throwable().getStackTrace();
+
+    // Calls to Class.getProtectionDomain will recursively call this
+    // method, so we return a default context (one that is guaranteed
+    // to allow this class access) if we find that we are already in
+    // a call to getContext.
+    for (int i = 1; i < stack.length; i++)
+      {
+        if (stack[i].getClassName().equals(AccessController.class.getName())
+            && stack[i].getMethodName().equals("getContext"))
+          return defaultContext;
+      }
+
+    // We walk down the stack, adding each ProtectionDomain for each
+    // class in the call stack. If we reach a call to doPrivileged,
+    // we don't add any more stack frames. We skip the first stack frame
+    // since it is the call to getContext itself.
+    for (int i = 1; i < stack.length; i++)
+      {
+        // Don't add a class twice.
+        if (classes.contains(stack[i].getClassName()))
+          continue;
+
+        classes.add(stack[i].getClassName());
+
+        if (stack[i].getClassName().equals(AccessController.class.getName())
+            && stack[i].getMethodName().equals("doPrivileged"))
+          break;
+
+        // If there was a call to doPrivileged with a supplied context,
+        // return that context.
+        List pair = new ArrayList(2);
+        pair.add(Thread.currentThread());
+        pair.add(stack[i].getClassName());
+        if (contexts.containsKey(pair))
+          {
+            return (AccessControlContext) contexts.get(pair);
+          }
+
+        try
+          {
+            Class clazz = Class.forName(stack[i].getClassName());
+            ProtectionDomain domain = clazz.getProtectionDomain();
+            if (domain != null)
+              domains.add(domain);
+          }
+        catch (Exception x)
+          {
+            // XXX what to do if this fails?
+          }
+      }
+
+    return new AccessControlContext((ProtectionDomain[])
+      domains.toArray(new ProtectionDomain[domains.size()]));
   }
 }

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=acc.patch
Content-Description: Patch to AccessControlContext

Index: java/security/AccessControlContext.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/security/AccessControlContext.java,v
retrieving revision 1.5
diff -u -w -r1.5 AccessControlContext.java
--- java/security/AccessControlContext.java	22 Jan 2002 22:27:00 -0000	1.5
+++ java/security/AccessControlContext.java	10 Feb 2004 18:52:03 -0000
@@ -1,5 +1,5 @@
 /* AccessControlContext.java --- Access Control Context Class
-   Copyright (C) 1999 Free Software Foundation, Inc.
+   Copyright (C) 1999,2004 Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
 
@@ -37,6 +37,9 @@
 
 package java.security;
 
+import java.io.PrintWriter;
+import java.io.StringWriter;
+
 /**
    AccessControlContext makes system resource access decsion 
    based on permission rights.  
@@ -53,7 +56,7 @@
  */
 public final class AccessControlContext
 {
-  private ProtectionDomain protectionDomain[];
+  private final ProtectionDomain protectionDomain[];
   private DomainCombiner combiner;
 
   /**
@@ -69,7 +72,7 @@
     for (i = 0, j = 0; i < count; i++)
       {
 	for (k = 0; k < i; k++)
-	  if (context[k] == protectionDomain[i])
+          if (context[k].equals(context[i]))
 	    break;
 	if (k != i)		//it means previous loop did not complete
 	  continue;
@@ -81,7 +84,7 @@
     for (i = 0, j = 0; i < count2; i++)
       {
 	for (k = 0; k < i; k++)
-	  if (context[k] == protectionDomain[i])
+          if (context[k].equals(context[i]))
 	    break;
 	if (k != i)		//it means previous loop did not complete
 	  continue;
@@ -171,5 +174,25 @@
       h ^= protectionDomain[i].hashCode();
 
     return h;
+  }
+
+  public String toString()
+  {
+    StringWriter str = new StringWriter();
+    PrintWriter out = new PrintWriter(str, false);
+    out.print (AccessControlContext.class.getName());
+    out.println (" [ domains = ");
+    for (int i = 0; i < protectionDomain.length; i++)
+      {
+        out.println(protectionDomain[i]);
+      }
+    if (combiner != null)
+      {
+        out.print("domain combiner = ");
+        out.println(combiner);
+      }
+    out.println("]");
+    out.flush();
+    return str.toString();
   }
 }

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=sm.patch
Content-Description: Patch to SecurityManager.

Index: java/lang/SecurityManager.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/lang/SecurityManager.java,v
retrieving revision 1.16
diff -u -w -r1.16 SecurityManager.java
--- java/lang/SecurityManager.java	6 Jan 2004 09:56:04 -0000	1.16
+++ java/lang/SecurityManager.java	10 Feb 2004 18:53:10 -0000
@@ -45,6 +45,8 @@
 import java.lang.reflect.Member;
 import java.net.InetAddress;
 import java.net.SocketPermission;
+import java.security.AccessController;
+import java.security.AccessControlContext;
 import java.security.AllPermission;
 import java.security.Permission;
 import java.security.Security;
@@ -301,8 +303,7 @@
    */
   public Object getSecurityContext()
   {
-    // XXX Should be: return AccessController.getContext();
-    return new SecurityContext(getClassContext());
+    return AccessController.getContext();
   }
 
   /**
@@ -317,8 +318,7 @@
    */
   public void checkPermission(Permission perm)
   {
-    // XXX Should be: AccessController.checkPermission(perm);
-    throw new SecurityException("Operation not allowed");
+    AccessController.checkPermission(perm);
   }
 
   /**
@@ -339,11 +339,9 @@
    */
   public void checkPermission(Permission perm, Object context)
   {
-    // XXX Should be:
-    // if (! (context instanceof AccessControlContext))
-    //   throw new SecurityException("Missing context");
-    // ((AccessControlContext) context).checkPermission(perm);
-    throw new SecurityException("Operation not allowed");
+    if (!(context instanceof AccessControlContext))
+      throw new SecurityException("Missing context");
+    ((AccessControlContext) context).checkPermission(perm);
   }
 
   /**
@@ -656,19 +654,17 @@
    * @see #getSecurityContext()
    * @see AccessControlContext#checkPermission(Permission)
    */
-  public void checkConnect(String host, int port, Object securityContext)
+  public void checkConnect(String host, int port, Object context)
   {
-    // XXX Should be:
-    // if (! (context instanceof AccessControlContext))
-    //   throw new SecurityException("Missing context");
-    // AccessControlContext ac = (AccessControlContext) context;
-    // if (port == -1)
-    //   ac.checkPermission(new SocketPermission(host, "resolve"));
-    // else
-    //   // Use the toString() hack to do the null check.
-    //   ac.checkPermission(new SocketPermission(host.toString + ":" +port,
-    //                                           "connect"));
-    throw new SecurityException("Cannot make network connections.");
+    if (! (context instanceof AccessControlContext))
+      throw new SecurityException("Missing context");
+    AccessControlContext ac = (AccessControlContext) context;
+    if (port == -1)
+      ac.checkPermission(new SocketPermission(host, "resolve"));
+    else
+      // Use the toString() hack to do the null check.
+      ac.checkPermission(new SocketPermission(host.toString() + ":" + port,
+                                              "connect"));
   }
 
   /**

--=-=-=--



From MAILER-DAEMON Tue Feb 10 17:35:46 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AqgTp-0006vO-Ji
	for mharc-classpath@gnu.org; Tue, 10 Feb 2004 17:35:45 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AqgTh-0006r5-82
	for classpath@gnu.org; Tue, 10 Feb 2004 17:35:37 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AqgSz-0006at-RN
	for classpath@gnu.org; Tue, 10 Feb 2004 17:35:25 -0500
Received: from [64.172.11.17] (helo=younglogic.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqgSH-0006IF-CA
	for classpath@gnu.org; Tue, 10 Feb 2004 17:34:09 -0500
Received: from [10.10.2.130] (helo=younglogic.com ident=adam)
	by younglogic.com with esmtp (Exim 3.35 #1 (Debian))
	id 1AqfVl-0005dr-00
	for <classpath@gnu.org>; Tue, 10 Feb 2004 13:33:41 -0800
Message-ID: <40295C25.4020405@younglogic.com>
Date: Tue, 10 Feb 2004 14:33:09 -0800
From: Adam Young <adam@younglogic.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: classpath@gnu.org
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: New to list
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2004 22:35:40 -0000

Is anyone working on the javax.security.auth stuff?  I figured it would 
be a good place for me to cut my teeth.

Adam



From MAILER-DAEMON Tue Feb 10 18:30:19 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AqhKd-00036V-9L
	for mharc-classpath@gnu.org; Tue, 10 Feb 2004 18:30:19 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AqhKY-00033d-VA
	for classpath@gnu.org; Tue, 10 Feb 2004 18:30:14 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AqhK2-0002om-Do
	for classpath@gnu.org; Tue, 10 Feb 2004 18:30:13 -0500
Received: from [66.33.197.214] (helo=ludo.dreamhost.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqhJT-0002Yv-Lg
	for classpath@gnu.org; Tue, 10 Feb 2004 18:29:07 -0500
Received: from dexter (c-24-6-46-122.client.comcast.net [24.6.46.122])
	by ludo.dreamhost.com (Postfix) with ESMTP
	id A5EAF283E0; Tue, 10 Feb 2004 15:29:05 -0800 (PST)
Received: by dexter (Postfix, from userid 1000)
	id 0C412C; Tue, 10 Feb 2004 15:29:05 -0800 (PST)
To: Adam Young <adam@younglogic.com>
References: <40295C25.4020405@younglogic.com>
From: Casey Marshall <rsdio@metastatic.org>
Date: Tue, 10 Feb 2004 15:29:05 -0800
In-Reply-To: <40295C25.4020405@younglogic.com> (Adam Young's message of
	"Tue, 10 Feb 2004 14:33:09 -0800")
Message-ID: <87k72uv7i6.fsf@metastatic.org>
User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: New to list
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2004 23:30:16 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>>>>> "Adam" == Adam Young <adam@younglogic.com> writes:

Adam> Is anyone working on the javax.security.auth stuff?  I figured
Adam> it would be a good place for me to cut my teeth.

GNU Crypto <http://www.gnu.org/software/gnu-crypto/> has an
implementation of the javax.security.auth.callback package. The rest
are (AFAIK) up for grabs.

I was hacking away at this package a little, but don't have much.

The javax.security.auth.x500.X500Principal class needs improvement ---
it's wildly incorrect in places. I wrote a much better implementation
of a class similar to this for the PKI implementation I am writing for
Jessie (CVS :ext:savannah.gnu.org:/cvsroot/jessie, module pki).

- -- 
Casey Marshall || rsdio@metastatic.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.7 <http://mailcrypt.sourceforge.net/>

iD8DBQFAKWjkgAuWMgRGsWsRAnU4AJ99qN6NrvDIMl0wSxs3PjQ17rnavQCeNnll
6KFUlZHMOvGY1Pqo+tltSiI=
=3TYi
-----END PGP SIGNATURE-----



From MAILER-DAEMON Wed Feb 11 07:53:29 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1Aqtrt-00026o-7n
	for mharc-classpath@gnu.org; Wed, 11 Feb 2004 07:53:29 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1Aqtl4-0000na-UU
	for classpath@gnu.org; Wed, 11 Feb 2004 07:46:26 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1Aqtjm-0000bZ-7U
	for classpath@gnu.org; Wed, 11 Feb 2004 07:45:37 -0500
Received: from [217.8.192.21] (helo=interway.li)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AqtgZ-0000CA-DM
	for classpath@gnu.org; Wed, 11 Feb 2004 07:41:47 -0500
Received: from [217.8.199.158] (HELO [192.168.1.33])
	by interway.li (CommuniGate Pro SMTP 4.1.8)
	with ESMTP id 681390 for classpath@gnu.org;
	Wed, 11 Feb 2004 13:41:33 +0100
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Wed, 11 Feb 2004 13:41:28 +0100
Message-Id: <20040211124128.7259@smtp.mail.ch.easynet.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: javax.swing.undo works
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2004 12:53:26 -0000

Hi all,

With my check-in of a few minutes ago, javax.swing.undo is finished.

Mauve now contains 214 tests for this package. They succeed both with Sun
J2SE 1.4.1_1 and with JamVM (both on GNU/Linux on IA-32).

Also, it is possible to run the "Notepad" and "Stylepad" applications
from Sun JDK 1.4.1_1 while pre-pending the GNU implementation of
javax.swing.undo to the bootclasspath.

Best regards, and see you at FOSDEM,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Wed Feb 11 15:33:01 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1Ar12b-0000sg-4i
	for mharc-classpath@gnu.org; Wed, 11 Feb 2004 15:33:01 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1Ar12Z-0000sW-Il
	for classpath@gnu.org; Wed, 11 Feb 2004 15:32:59 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1Ar123-0000np-Ru
	for classpath@gnu.org; Wed, 11 Feb 2004 15:32:58 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1Ar123-0000m6-3N
	for classpath@gnu.org; Wed, 11 Feb 2004 15:32:27 -0500
Received: from fleche.redhat.com (tf0208.peakpeak.com [204.144.239.208])
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id NAA10024;
	Wed, 11 Feb 2004 13:32:17 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 7C4E94F82B0; Wed, 11 Feb 2004 13:21:48 -0700 (MST)
To: graydon hoare <graydon@redhat.com>
References: <40285EF5.9070406@redhat.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: The SAME WAVE keeps coming in and COLLAPSING like a rayon MUU-MUU..
Date: 11 Feb 2004 13:21:48 -0700
In-Reply-To: <40285EF5.9070406@redhat.com>
Message-ID: <87k72t8izn.fsf@fleche.redhat.com>
Lines: 14
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] many small swing fixes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Feb 2004 20:33:00 -0000

>>>>> "graydon" == graydon hoare <graydon@redhat.com> writes:

graydon> http://people.redhat.com/graydon/free-swing-feb-09-2004.png,

Very nice.

graydon> comments? ok to commit?

Looks great, thanks.  Most of these changes could have gone in as
obvious.  Stuff like removing public classes that aren't part of the
spec, changing getUIClassID results, fixing an obvious bug like using
".x" where ".width" is correct...

Tom



From MAILER-DAEMON Thu Feb 12 18:36:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ArQNb-0001Vs-Ub
	for mharc-classpath@gnu.org; Thu, 12 Feb 2004 18:36:23 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ArQNT-0001TW-7o
	for classpath@gnu.org; Thu, 12 Feb 2004 18:36:15 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ArQMx-0000zH-KP
	for classpath@gnu.org; Thu, 12 Feb 2004 18:36:14 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArQMx-0000vn-4s
	for classpath@gnu.org; Thu, 12 Feb 2004 18:35:43 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i1CNZab01884
	for <classpath@gnu.org>; Thu, 12 Feb 2004 18:35:36 -0500
Received: from redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1CNZai32167
	for <classpath@gnu.org>; Thu, 12 Feb 2004 18:35:36 -0500
Message-ID: <402C0DBB.10707@redhat.com>
Date: Thu, 12 Feb 2004 18:35:23 -0500
From: graydon hoare <graydon@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.6b) Gecko/20031205 Thunderbird/0.4
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: classpath@gnu.org
Content-Type: multipart/mixed; boundary="------------070101060709040601060904"
Subject: [Fwd: [FYI] new branch "java-gui-branch"]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2004 23:36:16 -0000

This is a multi-part message in MIME format.
--------------070101060709040601060904
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

hi,

I've just created a branch in gcj, just the gcc/libjava directory, to 
try to accelerate some of the AWT and swing work. partly this was done 
in gcc rather than classpath because it seems classpath loses 
synchronized compatibility with any particular VM more frequently than 
libjava does with gcj, partly just because it was a simple solution and 
we could get it working today. I forward the message I sent to 
java@gcc.gnu.org below; basically it means we'll be doing less-frequent 
merges to mainline gcc and classpath, and committing to the branch 
without mandatory pre-approval review, for a little while (maybe a few 
months), while the code is maturing rapidly.

one person this will likely affect is sascha: his swing work is going 
into classpath rather than gcj, so we will need to personally coordinate 
a little bit. however, since he tends to produce large, complete (well 
documented and tested!) "units" of work at a time, I don't forsee there 
being many problematic dependencies between our work and his, so long as 
we're not actually *duplicating* effort.

of course everyone is welcome to monitor our work in the libjava branch, 
or just wait for larger merges. up to you. please let me know if you 
have other concerns.

-graydon

--------------070101060709040601060904
Content-Type: message/rfc822;
 name="[FYI] new branch \"java-gui-branch\""
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="[FYI] new branch \"java-gui-branch\""

Path: dub.venge.net!main.gmane.org!not-for-mail
From: graydon hoare <graydon@redhat.com>
Newsgroups: gmane.comp.gcc.java.devel
Subject: [FYI] new branch "java-gui-branch"
Date: Thu, 12 Feb 2004 17:37:47 -0500
Sender: java-owner@gcc.gnu.org
Approved: news@gmane.org
Message-ID: <402C003B.6090100@redhat.com>
NNTP-Posting-Host: deer.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Trace: sea.gmane.org 1076625500 10531 80.91.224.253 (12 Feb 2004 22:38:20
	GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Thu, 12 Feb 2004 22:38:20 +0000 (UTC)
Cc: Olga Rodimina <rodimina@redhat.com>, Kim Ho <kho@redhat.com>,
	Andrew Overholt <overholt@redhat.com>, David Jee <djee@redhat.com>,
	Thomas Fitzsimmons <fitzsim@redhat.com>,
	Fernando Nasser <fnasser@redhat.com>
Original-X-From: java-return-17130-gcc-java=m.gmane.org@gcc.gnu.org Thu Feb 12
	23:38:14 2004
Return-path: <java-return-17130-gcc-java=m.gmane.org@gcc.gnu.org>
Original-Received: from sources.redhat.com ([67.72.78.213]) by deer.gmane.org
	with smtp (Exim 3.35 #1 (Debian)) id 1ArPTK-0007BE-00 for
	<gcc-java@gmane.org>; Thu, 12 Feb 2004 23:38:14 +0100
Original-Received: (qmail 5452 invoked by alias); 12 Feb 2004 22:38:05 -0000
Mailing-List: contact java-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:java-unsubscribe-gcc-java=m.gmane.org@gcc.gnu.org>
List-Subscribe: <mailto:java-subscribe@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/java/>
List-Post: <mailto:java@gcc.gnu.org>
List-Help: <mailto:java-help@gcc.gnu.org>, <http://gcc.gnu.org/ml/#faqs>
Delivered-To: mailing list java@gcc.gnu.org
Original-Received: (qmail 5441 invoked from network);
	12 Feb 2004 22:38:01 -0000
Original-Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by
	sources.redhat.com with SMTP; 12 Feb 2004 22:38:01 -0000
Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP
	id i1CMc1b13661 for <java@gcc.gnu.org>;
	Thu, 12 Feb 2004 17:38:01 -0500
Original-Received: from redhat.com (sebastian-int.corp.redhat.com
	[172.16.52.221]) by int-mx1.corp.redhat.com (8.11.6/8.11.6)
	with ESMTP id i1CMc0i13163; Thu, 12 Feb 2004 17:38:00 -0500
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.6b) Gecko/20031205 Thunderbird/0.4
Original-To: java@gcc.gnu.org
X-Report-Spam: http://spam.gmane.org/gmane.comp.gcc.java.devel:8059
Bytes: 1971
Xref: dub.venge.net gmane.comp.gcc.java.devel:2346

hi,

I've been talking recently with some of the other Red Hat people tasked 
with working on java GUI technology -- AWT and Swing -- and we've come 
to the conclusion that this work would be accelerated a bit if we 
temporarily relocated to a secondary branch, the goal being to improve 
the inter-group communication and minimize idle time associated with 
mainline's (rightly) conservative review and approval process.

unless someone has a serious objection, I would like the rules for this 
branch to be as follows: you can commit your work without per-patch 
review, assuming you're patching or adding files you're "supposed" to be 
working on (in java/awt, gnu/java/awt, javax/swing, etc.), but please 
continue to send patches showing the changes you make to 
java-patches@gcc.gnu.org, so that interested parties can review your 
work chronologically.

we'll do bulk merges back into the mainline (and classpath) once the 
activity settles down a bit, but at somewhat larger intervals. if you 
commit code which breaks, we'll sort it out on IRC or mailing lists. the 
intention here is to try to build up the GUI libraries *fast*, and 
communicate all our work to one another as quickly as possible.

this branch only applies to the gcc/libjava module; to move your working 
copy to this branch, do the following:

$ cd $SRCDIR/gcc/libjava
$ cvs update -r java-gui-branch

you can check to see that your files moved to the new branch using the
"cvs status" command, as such:

$ cvs status Makefile.am
===================================================================
File: Makefile.am       Status: Up-to-date

    Working revision:    1.361
    Repository revision: 1.361   /cvs/gcc/gcc/libjava/Makefile.am,v
    Sticky Tag:          java-gui-branch (branch: 1.361.2)
    Sticky Date:         (none)
    Sticky Options:      (none)

the thing to look for being the "sticky tag", set to java-gui-branch.

-graydon


--------------070101060709040601060904--



From MAILER-DAEMON Thu Feb 12 22:59:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ArUTs-0002c1-H8
	for mharc-classpath@gnu.org; Thu, 12 Feb 2004 22:59:08 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ArUTp-0002bM-Tn
	for classpath@gnu.org; Thu, 12 Feb 2004 22:59:05 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ArUTJ-0002XO-9A
	for classpath@gnu.org; Thu, 12 Feb 2004 22:59:04 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArUTI-0002XE-UY
	for classpath@gnu.org; Thu, 12 Feb 2004 22:58:32 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i1D3wVb10649;
	Thu, 12 Feb 2004 22:58:31 -0500
Received: from redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1D3wUi32118; 
	Thu, 12 Feb 2004 22:58:30 -0500
Message-ID: <402C4B59.7090805@redhat.com>
Date: Thu, 12 Feb 2004 22:58:17 -0500
From: graydon hoare <graydon@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.6b) Gecko/20031205 Thunderbird/0.4
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Olga Rodimina <rodimina@redhat.com>
References: <1076010771.25346.82.camel@toby.toronto.redhat.com>
In-Reply-To: <1076010771.25346.82.camel@toby.toronto.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: [PATCH] Interpolation Rendering hints
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Feb 2004 03:59:06 -0000

Olga Rodimina wrote:

> Attached is the patch that implements KEY_INTERPOLATION and
> KEY_ALPHA_INTERPOLATION rendering hints in Graphics2D.
> 
> Ok to commit?

I'm not sure if anyone else reviewed this yet, but it looks fine to me. 
please commit this to java-gui-branch when you update to it.

-graydon



From MAILER-DAEMON Sat Feb 14 05:17:33 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1Arwrd-0006jc-0Q
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 05:17:33 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1Arwra-0006jP-5y
	for classpath@gnu.org; Sat, 14 Feb 2004 05:17:30 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ArwrY-0006j7-RI
	for classpath@gnu.org; Sat, 14 Feb 2004 05:17:29 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArwrY-0006j4-BP
	for classpath@gnu.org; Sat, 14 Feb 2004 05:17:28 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ArwrT-00033r-00; Sat, 14 Feb 2004 11:17:23 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <1076748184.31881.7.camel@gadek.homelinux.org>
References: <1076748184.31881.7.camel@gadek.homelinux.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-njP7iV44n9N2uIWK+atA"
Message-Id: <1076753844.11504.238.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 14 Feb 2004 11:17:25 +0100
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>
Subject: Re: [Sablevm-developer] Release progress - problems w/ 'make
	distcheck' of classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 10:17:30 -0000


--=-njP7iV44n9N2uIWK+atA
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-02-14 at 09:43, Grzegorz B. Prokopski wrote:
> but 'make distcheck' in classpath dies with this output:
>=20
> Found 2 semantic errors compiling
> "../../external/jaxp/source/javax/xml/transform/TransformerFactory.java":
>=20
>     94.         throws TransformerFactoryConfigurationError
>                        ^----------------------------------^
> *** Semantic Error: Type
> javax.xml.transform.TransformerFactoryConfigurationError was not found.
>=20
>=20
>    104.                 throw new
> TransformerFactoryConfigurationError(e);
>                                   ^----------------------------------^
> *** Semantic Error: A candidate for type
> "TransformerFactoryConfigurationError" was found, but it is invalid and
> needs to be fixed before this type will successfully compile.
>=20
> Found 3 semantic errors compiling
> "../../external/jaxp/source/javax/xml/transform/ClassStuff.java":
>=20
>    141.             throw new TransformerFactoryConfigurationError (e,
>                               ^----------------------------------^
> *** Semantic Error: A candidate for type
> "TransformerFactoryConfigurationError" was found, but it is invalid and
> needs to be fixed before this type will successfully compile.
>=20
>=20
>    145.             throw new TransformerFactoryConfigurationError (e,
>                               ^----------------------------------^
> *** Semantic Error: A candidate for type
> "TransformerFactoryConfigurationError" was found, but it is invalid and
> needs to be fixed before this type will successfully compile.
>=20
>=20
>    149.             throw new TransformerFactoryConfigurationError (e,
>                               ^----------------------------------^
> *** Semantic Error: A candidate for type
> "TransformerFactoryConfigurationError" was found, but it is invalid and
> needs to be fixed before this type will successfully compile.
>=20
>=20
> I guess some .java files aren't included in the tarball? or...?
>=20
> Help w/ this issue would be greatly apprieciated.

Ugh, so it isn't my setup :{
I get the same with a clean "upstream" classpath.
Somehow one of the gnu jaxp .java files ends up in the root build dir!?!

I'll try to fix make distcheck for classpath soon (hopefully tonight).

Cheers,

Mark

P.S. To the Classpath hackers. Please do a make distcheeck from time to
time. Especially after you alter configure.ac, Makefile.am and/or added
a file.

--=-njP7iV44n9N2uIWK+atA
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBALfWzxVhZCJWr9QwRAnqcAKCBJMFJgRbddyNLDwAzHluRlZUoxQCeNMfn
D2knfUXMYtA40YOmvvQal7s=
=uSA/
-----END PGP SIGNATURE-----

--=-njP7iV44n9N2uIWK+atA--




From MAILER-DAEMON Sat Feb 14 05:37:29 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ArxAv-0006cz-3U
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 05:37:29 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ArxAt-0006cu-MU
	for classpath@gnu.org; Sat, 14 Feb 2004 05:37:27 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ArxAN-0006NF-7R
	for classpath@gnu.org; Sat, 14 Feb 2004 05:37:26 -0500
Received: from [62.253.162.41] (helo=mta01-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArxAM-0006El-IM
	for classpath@gnu.org; Sat, 14 Feb 2004 05:36:54 -0500
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta01-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040214103636.QMSD13477.mta01-svc.ntlworld.com@cuddles.cambridge.redhat.com>
	for <classpath@gnu.org>; Sat, 14 Feb 2004 10:36:36 +0000
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i1EAaACL004015; Sat, 14 Feb 2004 10:36:20 GMT
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i1EAa9gf004011;
	Sat, 14 Feb 2004 10:36:09 GMT
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16429.64024.271934.394424@cuddles.cambridge.redhat.com>
Date: Sat, 14 Feb 2004 10:36:08 +0000
To: classpath@gnu.org
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Subject: RMI and JOnAS
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 10:37:28 -0000

JOnAS (http://jonas.objectweb.org/) is, as you may know, the Open
Source implementation by ObjectWeb of the J2EE(TM) specification.

We're having trouble with running it.  The basic problem is (quoth
Simon Nieuviarts) "because Carol is an improvement or a replacement of
RMI. As such, it needs to plug low in the ORB in functions that are
not intended to be exported to the end user. AFAIK, without the use of
internal classes you can not implement mechanisms like interceptors
which propagate transaction contexts."  To do this, carol uses classes
in sun.rmi.transport.*.

What I would like to do is define an interface in Classpath which
exposes the functionality that JOnAS needs.

Trouble is, I know zip about RMI.

Andrew.



From MAILER-DAEMON Sat Feb 14 06:25:40 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ArxvY-0000Nr-6O
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 06:25:40 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ArxvV-0000Lq-9F
	for classpath@gnu.org; Sat, 14 Feb 2004 06:25:37 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ArxvO-0000JC-OU
	for classpath@gnu.org; Sat, 14 Feb 2004 06:25:31 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArxvN-0000IO-QT
	for classpath@gnu.org; Sat, 14 Feb 2004 06:25:29 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1ArxvD-0003Bg-00; Sat, 14 Feb 2004 12:25:19 +0100
From: Mark Wielaard <mark@klomp.org>
To: Andrew Haley <aph@redhat.com>
In-Reply-To: <16429.64024.271934.394424@cuddles.cambridge.redhat.com>
References: <16429.64024.271934.394424@cuddles.cambridge.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-dJ5eGwZRjabN1r6FYNs+"
Message-Id: <1076757920.11504.270.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 14 Feb 2004 12:25:20 +0100
Cc: John Catherino <cajo@dev.java.net>, classpath@gnu.org
Subject: Re: RMI and JOnAS (and Cajo)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 11:25:38 -0000


--=-dJ5eGwZRjabN1r6FYNs+
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-02-14 at 11:36, Andrew Haley wrote:
> JOnAS (http://jonas.objectweb.org/) is, as you may know, the Open
> Source implementation by ObjectWeb of the J2EE(TM) specification.
>=20
> We're having trouble with running it.  The basic problem is (quoth
> Simon Nieuviarts) "because Carol is an improvement or a replacement of
> RMI. As such, it needs to plug low in the ORB in functions that are
> not intended to be exported to the end user. AFAIK, without the use of
> internal classes you can not implement mechanisms like interceptors
> which propagate transaction contexts."  To do this, carol uses classes
> in sun.rmi.transport.*.
>=20
> What I would like to do is define an interface in Classpath which
> exposes the functionality that JOnAS needs.
>=20
> Trouble is, I know zip about RMI.

Good more interest in RMI. I know also almost zip about RMI, but I am
sure when pulling some knowledge together we can get somewhere. Once
upon a time the Orp developers got our RMI implementation working good
enough to support JBoss. And I know the kaffe developers recently fixed
up some little things to make a couple of standard RMI examples work on
kaffe. Also Norbert Frese has been posting a couple of RMI patches on
the gcj mailinglist <http://gcc.gnu.org/ml/java/2004-01/msg00022.html>,
<http://gcc.gnu.org/ml/java-patches/2004-q1/msg00080.html>,
<http://gcc.gnu.org/ml/java-patches/2004-q1/msg00081.html>
and he made a RMI interoperability testsuite
<http://www.scheinwelt.at/~norbertf/gcj/tests/>.

Yesterday have been looking a bit at the Cajo project
<https://cajo.dev.java.net/> which is a distributed object framework
build on top of RMI. (John Catherina has been CCed since he might have
some ideas and clearly knows more about RMI then most of us). Cajo
stress tests RMI and Serialization a lot. And we do have some way to go
before it works. Things I noticed that are currently broken:

- Our rmic implementation doesn't seem to handle 'super-interfaces'
correctly. This doesn't seem to be that hard to fix and can be easily
worked around by implementing the 'super-interface' directly.

- Our java.awt.Font serialization (which the main cajo example uses) is
broken. Not hard to fix, but to make it compatible with other
implementations might be hard since not everything is clearly
documented.

- When extending UnicastRemoteObject a object gets immediatly exported
through its constructor which might be to early since then not all
fields of the object are initialized. This looks like a harder problem
to solve.

BTW Florent Benoit from JOnAS will be at FOSDEM
    http://www.fosdem.org/index/speakers/speakers_benoit

Cheers,

Mark

--=-dJ5eGwZRjabN1r6FYNs+
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBALgWfxVhZCJWr9QwRAv2KAJ44JkpnSVCBoIG3NWQOXWDc1Q+U5ACeOKVu
PGfokCCw0mkKAN+GSrOlsmc=
=rdpl
-----END PGP SIGNATURE-----

--=-dJ5eGwZRjabN1r6FYNs+--




From MAILER-DAEMON Sat Feb 14 08:10:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1ArzYB-0000uW-J5
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 08:09:39 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1ArzXe-0000it-Ls
	for classpath@gnu.org; Sat, 14 Feb 2004 08:09:06 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1ArzWO-0000Ra-6P
	for classpath@gnu.org; Sat, 14 Feb 2004 08:08:19 -0500
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArzTf-0008A1-1v
	for classpath@gnu.org; Sat, 14 Feb 2004 08:04:59 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-95-139.ewetel.net
	[80.228.95.139])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id i1ED4jcX013167;
	Sat, 14 Feb 2004 14:04:45 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1ArzTR-0005VU-00; Sat, 14 Feb 2004 14:04:45 +0100
Date: Sat, 14 Feb 2004 14:04:45 +0100
From: Michael Koch <konqueror@gmx.de>
To: Mark Wielaard <mark@klomp.org>
Message-ID: <20040214130445.GD18654@mail.konqueror.de>
References: <1076748184.31881.7.camel@gadek.homelinux.org>
	<1076753844.11504.238.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1076753844.11504.238.camel@elsschot.wildebeest.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	classpath@gnu.org
Subject: Re: [Sablevm-developer] Release progress - problems w/ 'make
	distcheck' of classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 13:09:37 -0000

On Sat, Feb 14, 2004 at 11:17:25AM +0100, Mark Wielaard wrote:
> Hi,
> 
> On Sat, 2004-02-14 at 09:43, Grzegorz B. Prokopski wrote:
> > but 'make distcheck' in classpath dies with this output:
> > 
> > Found 2 semantic errors compiling
> > "../../external/jaxp/source/javax/xml/transform/TransformerFactory.java":
> > 
> >     94.         throws TransformerFactoryConfigurationError
> >                        ^----------------------------------^
> > *** Semantic Error: Type
> > javax.xml.transform.TransformerFactoryConfigurationError was not found.
> > 
> > 
> >    104.                 throw new
> > TransformerFactoryConfigurationError(e);
> >                                   ^----------------------------------^
> > *** Semantic Error: A candidate for type
> > "TransformerFactoryConfigurationError" was found, but it is invalid and
> > needs to be fixed before this type will successfully compile.
> > 
> > Found 3 semantic errors compiling
> > "../../external/jaxp/source/javax/xml/transform/ClassStuff.java":
> > 
> >    141.             throw new TransformerFactoryConfigurationError (e,
> >                               ^----------------------------------^
> > *** Semantic Error: A candidate for type
> > "TransformerFactoryConfigurationError" was found, but it is invalid and
> > needs to be fixed before this type will successfully compile.
> > 
> > 
> >    145.             throw new TransformerFactoryConfigurationError (e,
> >                               ^----------------------------------^
> > *** Semantic Error: A candidate for type
> > "TransformerFactoryConfigurationError" was found, but it is invalid and
> > needs to be fixed before this type will successfully compile.
> > 
> > 
> >    149.             throw new TransformerFactoryConfigurationError (e,
> >                               ^----------------------------------^
> > *** Semantic Error: A candidate for type
> > "TransformerFactoryConfigurationError" was found, but it is invalid and
> > needs to be fixed before this type will successfully compile.
> > 
> > 
> > I guess some .java files aren't included in the tarball? or...?
> > 
> > Help w/ this issue would be greatly apprieciated.
> 
> Ugh, so it isn't my setup :{
> I get the same with a clean "upstream" classpath.
> Somehow one of the gnu jaxp .java files ends up in the root build dir!?!
> 
> I'll try to fix make distcheck for classpath soon (hopefully tonight).
> 
> Cheers,
> 
> Mark
> 
> P.S. To the Classpath hackers. Please do a make distcheeck from time to
> time. Especially after you alter configure.ac, Makefile.am and/or added
> a file.

I do "make distcheck" on a daily basis in the daily build scripts on
Patrick Reali's server. They dont broke. I do this here locally too on a
regular basis and didnt broke.

I think this error occurs because of the compiler used to compile to
bytecode is buggy or configure did something strange. classpath uses
jikes (1.18) here locally to compile to bytecode and this works great.


Michael



From MAILER-DAEMON Sat Feb 14 11:40:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1As2qW-00053l-09
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 11:40:48 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1As2qT-00053X-4i
	for classpath@gnu.org; Sat, 14 Feb 2004 11:40:45 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1As2qR-00053F-IV
	for classpath@gnu.org; Sat, 14 Feb 2004 11:40:44 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1As2qR-00053B-2K
	for classpath@gnu.org; Sat, 14 Feb 2004 11:40:43 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1As2qL-0003nn-00; Sat, 14 Feb 2004 17:40:37 +0100
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <20040214130445.GD18654@mail.konqueror.de>
References: <1076748184.31881.7.camel@gadek.homelinux.org>
	<1076753844.11504.238.camel@elsschot.wildebeest.org>
	<20040214130445.GD18654@mail.konqueror.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-5ohmhvHiA14yjfy3EsxO"
Message-Id: <1076776839.11504.295.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 14 Feb 2004 17:40:39 +0100
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	classpath@gnu.org
Subject: Re: [Sablevm-developer] Release progress - problems w/ 'make
	distcheck' of classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 16:40:45 -0000


--=-5ohmhvHiA14yjfy3EsxO
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-02-14 at 14:04, Michael Koch wrote:
> > > *** Semantic Error: A candidate for type
> > > "TransformerFactoryConfigurationError" was found, but it is invalid a=
nd
> > > needs to be fixed before this type will successfully compile.
> > >=20
> > >=20
> > > I guess some .java files aren't included in the tarball? or...?
> > >=20
> > > Help w/ this issue would be greatly apprieciated.
> >=20
> > Ugh, so it isn't my setup :{
> > I get the same with a clean "upstream" classpath.
> > Somehow one of the gnu jaxp .java files ends up in the root build dir!?=
!
> >=20
> > I'll try to fix make distcheck for classpath soon (hopefully tonight).
> >=20
>
> I do "make distcheck" on a daily basis in the daily build scripts on
> Patrick Reali's server. They dont broke. I do this here locally too on a
> regular basis and didnt broke.
>=20
> I think this error occurs because of the compiler used to compile to
> bytecode is buggy or configure did something strange. classpath uses
> jikes (1.18) here locally to compile to bytecode and this works great.

It wasn't the compiler. It seems to be my version of tar !?!?!
I just downgraded tar from 1.13.92-4 to 1.13.25-6
(Debian unstable to Debian testing version) and everything works again.

For some mysterious reason this newer version of tar puts
classpath-0.07+cvs/external/jaxp/source/javax/xml/transform/TransformerFact=
oryConfigurationError.java
in the tar file as plain "TransformerFactoryConfigurationError.java"
without any directory path. Can someone confirm that downgrading tar
helps.

It sounds fishy, but maybe it is because this path is just one larger
then 100 (101) characters. I read somewhere that tar handles file names
longer then 100 chars special (and different depending on Posix/GNU/etc)

Cheers,

Mark

P.S. I get much further now, but at the end I get the following error:

ERROR: files left in build directory after distclean:
./native/fdlibm/DEPDIR
./native/fdlibm/=3D
./native/jni/classpath/DEPDIR
./native/jni/classpath/=3D
./native/jni/java-awt/DEPDIR
./native/jni/java-awt/=3D
./native/jni/java-io/DEPDIR
./native/jni/java-io/=3D
./native/jni/java-lang/DEPDIR
./native/jni/java-lang/=3D
./native/jni/java-net/DEPDIR
./native/jni/java-net/=3D
./native/jni/java-nio/DEPDIR
./native/jni/java-nio/=3D
./native/jni/java-util/DEPDIR
./native/jni/java-util/=3D
./native/jni/gtk-peer/DEPDIR
./native/jni/gtk-peer/=3D
make[1]: *** [distcleancheck] Error 1
make[1]: Leaving directory
`/home/mark/src/classpath-obj/classpath-0.07+cvs/_build'
make: *** [distcheck] Error 2

Still investigating.

--=-5ohmhvHiA14yjfy3EsxO
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBALk+GxVhZCJWr9QwRAt9wAKCK/xZHwOtHmeiDP7dZFJ+r8alptgCfQNL1
IQJvcffkcEG6ukW/U6Mg3y4=
=wKtx
-----END PGP SIGNATURE-----

--=-5ohmhvHiA14yjfy3EsxO--




From MAILER-DAEMON Sat Feb 14 11:54:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1As33N-00020A-Tq
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 11:54:05 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1As33M-0001zw-2x
	for classpath@gnu.org; Sat, 14 Feb 2004 11:54:04 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1As32q-0001sS-6d
	for classpath@gnu.org; Sat, 14 Feb 2004 11:54:03 -0500
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1As32p-0001sN-Nt
	for classpath@gnu.org; Sat, 14 Feb 2004 11:53:31 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-94-042.ewetel.net
	[80.228.94.42])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i1EGrJq7001398;
	Sat, 14 Feb 2004 17:53:19 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1As32d-0000YX-00; Sat, 14 Feb 2004 17:53:19 +0100
Date: Sat, 14 Feb 2004 17:53:19 +0100
From: Michael Koch <konqueror@gmx.de>
To: Mark Wielaard <mark@klomp.org>
Message-ID: <20040214165319.GB1222@mail.konqueror.de>
References: <1076748184.31881.7.camel@gadek.homelinux.org>
	<1076753844.11504.238.camel@elsschot.wildebeest.org>
	<20040214130445.GD18654@mail.konqueror.de>
	<1076776839.11504.295.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1076776839.11504.295.camel@elsschot.wildebeest.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: [Sablevm-developer] Release progress - problems w/ 'make
	distcheck' of classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 16:54:04 -0000

On Sat, Feb 14, 2004 at 05:40:39PM +0100, Mark Wielaard wrote:
> Hi,
> 
> On Sat, 2004-02-14 at 14:04, Michael Koch wrote:
> > > > *** Semantic Error: A candidate for type
> > > > "TransformerFactoryConfigurationError" was found, but it is invalid and
> > > > needs to be fixed before this type will successfully compile.
> > > > 
> > > > 
> > > > I guess some .java files aren't included in the tarball? or...?
> > > > 
> > > > Help w/ this issue would be greatly apprieciated.
> > > 
> > > Ugh, so it isn't my setup :{
> > > I get the same with a clean "upstream" classpath.
> > > Somehow one of the gnu jaxp .java files ends up in the root build dir!?!
> > > 
> > > I'll try to fix make distcheck for classpath soon (hopefully tonight).
> > > 
> >
> > I do "make distcheck" on a daily basis in the daily build scripts on
> > Patrick Reali's server. They dont broke. I do this here locally too on a
> > regular basis and didnt broke.
> > 
> > I think this error occurs because of the compiler used to compile to
> > bytecode is buggy or configure did something strange. classpath uses
> > jikes (1.18) here locally to compile to bytecode and this works great.
> 
> It wasn't the compiler. It seems to be my version of tar !?!?!
> I just downgraded tar from 1.13.92-4 to 1.13.25-6
> (Debian unstable to Debian testing version) and everything works again.
> 
> For some mysterious reason this newer version of tar puts
> classpath-0.07+cvs/external/jaxp/source/javax/xml/transform/TransformerFactoryConfigurationError.java
> in the tar file as plain "TransformerFactoryConfigurationError.java"
> without any directory path. Can someone confirm that downgrading tar
> helps.
> 
> It sounds fishy, but maybe it is because this path is just one larger
> then 100 (101) characters. I read somewhere that tar handles file names
> longer then 100 chars special (and different depending on Posix/GNU/etc)

Ah, yes. There is discussion about buggy tar in Debian unstable and
broken debs on debian-devel lately.

> P.S. I get much further now, but at the end I get the following error:
> 
> ERROR: files left in build directory after distclean:
> ./native/fdlibm/DEPDIR
> ./native/fdlibm/=
> ./native/jni/classpath/DEPDIR
> ./native/jni/classpath/=
> ./native/jni/java-awt/DEPDIR
> ./native/jni/java-awt/=
> ./native/jni/java-io/DEPDIR
> ./native/jni/java-io/=
> ./native/jni/java-lang/DEPDIR
> ./native/jni/java-lang/=
> ./native/jni/java-net/DEPDIR
> ./native/jni/java-net/=
> ./native/jni/java-nio/DEPDIR
> ./native/jni/java-nio/=
> ./native/jni/java-util/DEPDIR
> ./native/jni/java-util/=
> ./native/jni/gtk-peer/DEPDIR
> ./native/jni/gtk-peer/=
> make[1]: *** [distcleancheck] Error 1
> make[1]: Leaving directory
> `/home/mark/src/classpath-obj/classpath-0.07+cvs/_build'
> make: *** [distcheck] Error 2
> 
> Still investigating.

Hmmm, I dont get that either. What versions of autoconf/automake/libtool
are you using ?


Michael





From MAILER-DAEMON Sat Feb 14 12:47:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1As3so-0005c4-Ka
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 12:47:14 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1As3sc-0005Xl-1a
	for classpath@gnu.org; Sat, 14 Feb 2004 12:47:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1As3sY-0005Uh-IY
	for classpath@gnu.org; Sat, 14 Feb 2004 12:47:00 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1As3sX-0005Sw-Ge
	for classpath@gnu.org; Sat, 14 Feb 2004 12:46:57 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1As3sS-0003up-00; Sat, 14 Feb 2004 18:46:52 +0100
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <20040214165319.GB1222@mail.konqueror.de>
References: <1076748184.31881.7.camel@gadek.homelinux.org>
	<1076753844.11504.238.camel@elsschot.wildebeest.org>
	<20040214130445.GD18654@mail.konqueror.de>
	<1076776839.11504.295.camel@elsschot.wildebeest.org>
	<20040214165319.GB1222@mail.konqueror.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-NKDjXVuRp9X2kPxKmrNx"
Message-Id: <1076780814.11504.307.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 14 Feb 2004 18:46:54 +0100
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	classpath@gnu.org
Subject: Re: [Sablevm-developer] Release progress - problems w/ 'make
	distcheck' of classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 17:47:03 -0000


--=-NKDjXVuRp9X2kPxKmrNx
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-02-14 at 17:53, Michael Koch wrote:
> Ah, yes. There is discussion about buggy tar in Debian unstable and
> broken debs on debian-devel lately.

OK, then we are probably bitten by that one.
Do you have a bug number? I couldn't find it immediately on
bugs.debian.org.

> > P.S. I get much further now, but at the end I get the following error:
> >=20
> > ERROR: files left in build directory after distclean:
> > ./native/fdlibm/DEPDIR
> > ./native/fdlibm/=3D
> > ./native/jni/classpath/DEPDIR
> > ./native/jni/classpath/=3D
> > ./native/jni/java-awt/DEPDIR
> > ./native/jni/java-awt/=3D
> > ./native/jni/java-io/DEPDIR
> > ./native/jni/java-io/=3D
> > ./native/jni/java-lang/DEPDIR
> > ./native/jni/java-lang/=3D
> > ./native/jni/java-net/DEPDIR
> > ./native/jni/java-net/=3D
> > ./native/jni/java-nio/DEPDIR
> > ./native/jni/java-nio/=3D
> > ./native/jni/java-util/DEPDIR
> > ./native/jni/java-util/=3D
> > ./native/jni/gtk-peer/DEPDIR
> > ./native/jni/gtk-peer/=3D
> > make[1]: *** [distcleancheck] Error 1
> > make[1]: Leaving directory
> > `/home/mark/src/classpath-obj/classpath-0.07+cvs/_build'
> > make: *** [distcheck] Error 2
> >=20
> > Still investigating.
>=20
> Hmmm, I dont get that either. What versions of autoconf/automake/libtool
> are you using ?

Tried both automake 1.8.2 and 1.7.9.
autoconf 2.59 and libtool 1.5.2

Cheers,

Mark

--=-NKDjXVuRp9X2kPxKmrNx
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBALl8NxVhZCJWr9QwRAr5tAJsFO8nQyHNXwrt8ESZNOgkHJNUzWgCgoCm6
kvtJDitLLcg2PZPSLpq7wYg=
=iF4G
-----END PGP SIGNATURE-----

--=-NKDjXVuRp9X2kPxKmrNx--




From MAILER-DAEMON Sat Feb 14 14:05:30 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1As56Y-000479-Is
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 14:05:30 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1As56V-00043t-Ux
	for classpath@gnu.org; Sat, 14 Feb 2004 14:05:27 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1As55y-0003EU-4s
	for classpath@gnu.org; Sat, 14 Feb 2004 14:05:25 -0500
Received: from [212.6.122.96] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1As55w-0003Bt-QG
	for classpath@gnu.org; Sat, 14 Feb 2004 14:04:52 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-94-042.ewetel.net
	[80.228.94.42])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i1EJ4dkS007156;
	Sat, 14 Feb 2004 20:04:40 +0100 (MET)
Received: from mkoch by majestix.konqueror.de with local (Exim 3.35 #1
	(Debian)) id 1As55j-00010B-00; Sat, 14 Feb 2004 20:04:39 +0100
Date: Sat, 14 Feb 2004 20:04:39 +0100
From: Michael Koch <konqueror@gmx.de>
To: Mark Wielaard <mark@klomp.org>
Message-ID: <20040214190439.GC1222@mail.konqueror.de>
References: <1076748184.31881.7.camel@gadek.homelinux.org>
	<1076753844.11504.238.camel@elsschot.wildebeest.org>
	<20040214130445.GD18654@mail.konqueror.de>
	<1076776839.11504.295.camel@elsschot.wildebeest.org>
	<20040214165319.GB1222@mail.konqueror.de>
	<1076780814.11504.307.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1076780814.11504.307.camel@elsschot.wildebeest.org>
User-Agent: Mutt/1.3.28i
Sender: Michael Koch <mkoch@mail.konqueror.de>
X-CheckCompat: OK
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	classpath@gnu.org
Subject: Re: [Sablevm-developer] Release progress - problems w/ 'make
	distcheck' of classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 19:05:28 -0000

On Sat, Feb 14, 2004 at 06:46:54PM +0100, Mark Wielaard wrote:
> Hi,
> 
> On Sat, 2004-02-14 at 17:53, Michael Koch wrote:
> > Ah, yes. There is discussion about buggy tar in Debian unstable and
> > broken debs on debian-devel lately.
> 
> OK, then we are probably bitten by that one.
> Do you have a bug number? I couldn't find it immediately on
> bugs.debian.org.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=230910

I dont know if its related but it seems when downgrading helps you.


Michael



From MAILER-DAEMON Sat Feb 14 18:21:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1As96b-0001GP-5H
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 18:21:49 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1As96Y-0001G9-Jq
	for classpath@gnu.org; Sat, 14 Feb 2004 18:21:46 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1As96X-0001Fy-C0
	for classpath@gnu.org; Sat, 14 Feb 2004 18:21:45 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1As96W-0001Fv-Vk
	for classpath@gnu.org; Sat, 14 Feb 2004 18:21:45 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1As96O-0004WC-00; Sun, 15 Feb 2004 00:21:36 +0100
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <1076780814.11504.307.camel@elsschot.wildebeest.org>
References: <1076748184.31881.7.camel@gadek.homelinux.org>
	<1076753844.11504.238.camel@elsschot.wildebeest.org>
	<20040214130445.GD18654@mail.konqueror.de>
	<1076776839.11504.295.camel@elsschot.wildebeest.org>
	<20040214165319.GB1222@mail.konqueror.de>
	<1076780814.11504.307.camel@elsschot.wildebeest.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-TdXHGDxGROCmIoDVyxa9"
Message-Id: <1076800898.11504.344.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 15 Feb 2004 00:21:38 +0100
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	classpath@gnu.org
Subject: Re: [Sablevm-developer] Release progress - problems w/ 'make
	distcheck' of classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Feb 2004 23:21:47 -0000


--=-TdXHGDxGROCmIoDVyxa9
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-02-14 at 18:46, Mark Wielaard wrote:
> > > P.S. I get much further now, but at the end I get the following error=
:
> > >=20
> > > ERROR: files left in build directory after distclean:
> > > ./native/fdlibm/DEPDIR
> > > ./native/fdlibm/=3D
> > > [...]
> > > ./native/jni/gtk-peer/DEPDIR
> > > ./native/jni/gtk-peer/=3D
> > > make[1]: *** [distcleancheck] Error 1
> > > make[1]: Leaving directory
> > > `/home/mark/src/classpath-obj/classpath-0.07+cvs/_build'
> > > make: *** [distcheck] Error 2
> > >=20
> > > Still investigating.
> >=20
> > Hmmm, I dont get that either. What versions of autoconf/automake/libtoo=
l
> > are you using ?
>=20
> Tried both automake 1.8.2 and 1.7.9.
> autoconf 2.59 and libtool 1.5.2

Strange it now suddenly all works.
I don't know what changed though. But with both automake 1.8.2 and 1.7.9
make distcheck works now. Yeah!

Cheers,

Mark

--=-TdXHGDxGROCmIoDVyxa9
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBALq2BxVhZCJWr9QwRAiloAJ4n8y4F5wcugwJdbk5zt9ThzF+9hACgmOnl
Jk9eZP3iexFFLbSCbjsrmBg=
=AiWA
-----END PGP SIGNATURE-----

--=-TdXHGDxGROCmIoDVyxa9--




From MAILER-DAEMON Sat Feb 14 20:45:38 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AsBLk-0007jD-Vw
	for mharc-classpath@gnu.org; Sat, 14 Feb 2004 20:45:36 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AsBLg-0007gA-1s
	for classpath@gnu.org; Sat, 14 Feb 2004 20:45:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AsBL3-0007EG-7E
	for classpath@gnu.org; Sat, 14 Feb 2004 20:45:26 -0500
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AsBL0-00076i-3f
	for classpath@gnu.org; Sat, 14 Feb 2004 20:44:50 -0500
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i1F1PJHm025559;
	Sat, 14 Feb 2004 20:25:39 -0500 (EST)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004021420263403652 ; Sat, 14 Feb 2004 20:26:34 -0500
Received: from 162.29.internet.uqam.ca (162.29.internet.uqam.ca
	[132.208.29.162])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i1F1Mvnh019846; Sat, 14 Feb 2004 20:22:58 -0500 (EST)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
From: "Grzegorz B. Prokopski" <gadek@debian.org>
To: Mark Wielaard <mark@klomp.org>
In-Reply-To: <1076800898.11504.344.camel@elsschot.wildebeest.org>
References: <1076748184.31881.7.camel@gadek.homelinux.org>
	<1076753844.11504.238.camel@elsschot.wildebeest.org>
	<20040214130445.GD18654@mail.konqueror.de>
	<1076776839.11504.295.camel@elsschot.wildebeest.org>
	<20040214165319.GB1222@mail.konqueror.de>
	<1076780814.11504.307.camel@elsschot.wildebeest.org>
	<1076800898.11504.344.camel@elsschot.wildebeest.org>
Content-Type: text/plain
Organization: Debian GNU/Linux http://www.debian.org
Message-Id: <1076808170.16528.177.camel@gadek.homelinux.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 14 Feb 2004 20:22:54 -0500
Content-Transfer-Encoding: 7bit
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: [Sablevm-developer] Release progress - problems w/ 'make
	distcheck' of classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Feb 2004 01:45:34 -0000

> > Tried both automake 1.8.2 and 1.7.9.
> > autoconf 2.59 and libtool 1.5.2
> 
> Strange it now suddenly all works.
> I don't know what changed though. But with both automake 1.8.2 and 1.7.9
> make distcheck works now. Yeah!

Yup, downgrade of tar helped. We're at release 1.1.0 point now.

Thanks a lot!

					Grzegorz B. Prokopski

-- 
Grzegorz B. Prokopski <gadek@debian.org>
Debian GNU/Linux      http://www.debian.org
SableVM - LGPLed JVM  http://www.sablevm.org
Why SableVM ?!?       http://devel.sablevm.org/wiki/WhySableVM




From MAILER-DAEMON Wed Feb 18 04:48:22 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AtOJL-0001w4-2Z
	for mharc-classpath@gnu.org; Wed, 18 Feb 2004 04:48:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AtOJ7-0001nO-CK
	for classpath@gnu.org; Wed, 18 Feb 2004 04:47:53 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AtOIV-000165-VC
	for classpath@gnu.org; Wed, 18 Feb 2004 04:47:48 -0500
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AtOHc-0000dW-BI
	for classpath@gnu.org; Wed, 18 Feb 2004 04:46:20 -0500
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP id 55BF160DF6
	for <classpath@gnu.org>; Wed, 18 Feb 2004 09:46:18 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 50798-07 for <classpath@gnu.org>;
	Wed, 18 Feb 2004 09:46:17 +0000 (GMT)
Received: from reali.dnsalias.net (212-41-94-176.adsl.solnet.ch
	[212.41.94.176])
	by mail01.solnet.ch (Postfix) with ESMTP id E01EC60DEB
	for <classpath@gnu.org>; Wed, 18 Feb 2004 09:46:15 +0000 (GMT)
Received: from pcprr.elca.ch (reali.dnsalias.net [192.168.1.2])
	by reali.dnsalias.net (Postfix) with ESMTP id 1173978F06
	for <classpath@gnu.org>; Wed, 18 Feb 2004 10:45:30 +0100 (CET)
Date: Wed, 18 Feb 2004 10:46:11 +0100
From: Patrik Reali <reali@acm.org>
To: classpath@gnu.org
Message-ID: <515920885.1077101171@[10.40.10.54]>
X-Mailer: Mulberry/3.1.0 (Win32)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-Virus-Scanned: by SolNet
Subject: [Article] Sun Fires Back over Open Source Java Accusations
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Feb 2004 09:47:57 -0000

OSNews has some discussion on Sun's answer to ESR request to make Java open 
source.
<http://www.osnews.com/comment.php?news_id=6053>


-Patrik

------------------------
Patrik Reali
http://www.reali.ch/~patrik/




From MAILER-DAEMON Wed Feb 18 05:14:35 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AtOiw-0000rs-RG
	for mharc-classpath@gnu.org; Wed, 18 Feb 2004 05:14:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AtOiu-0000q7-4f
	for classpath@gnu.org; Wed, 18 Feb 2004 05:14:32 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AtOiO-0000dR-Eu
	for classpath@gnu.org; Wed, 18 Feb 2004 05:14:31 -0500
Received: from [64.4.37.81] (helo=hotmail.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AtOiO-0008Je-35
	for classpath@gnu.org; Wed, 18 Feb 2004 05:14:00 -0500
Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC;
	Wed, 18 Feb 2004 02:12:57 -0800
Received: from 195.224.225.50 by by10fd.bay10.hotmail.msn.com with HTTP;
	Wed, 18 Feb 2004 10:12:56 GMT
X-Originating-IP: [195.224.225.50]
X-Originating-Email: [robert_lougher@hotmail.com]
X-Sender: robert_lougher@hotmail.com
From: "Robert Lougher" <robert_lougher@hotmail.com>
To: reali@acm.org, classpath@gnu.org
Bcc: 
Date: Wed, 18 Feb 2004 10:12:56 +0000
Mime-Version: 1.0
Content-Type: text/plain; format=flowed
Message-ID: <BAY10-F81wRC6HixqDC000002c1@hotmail.com>
X-OriginalArrivalTime: 18 Feb 2004 10:12:57.0222 (UTC)
	FILETIME=[C7B4BA60:01C3F607]
Cc: 
Subject: RE: [Article] Sun Fires Back over Open Source Java Accusations
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Feb 2004 10:14:32 -0000

Hi,

A quite interesting response.  However, it's funny hearing Phipps slam IBM 
so much (considering their Linux technology center and support of Jikes).  
He used to be IBM's Java evangelist (based in Hursley, UK) before defecting 
to Sun.  Favourite phrase was "Tsunami"...

Rob.


----Original Message Follows----
From: Patrik Reali <reali@acm.org>
To: classpath@gnu.org
Subject: [Article] Sun Fires Back over Open Source Java Accusations
Date: Wed, 18 Feb 2004 10:46:11 +0100

OSNews has some discussion on Sun's answer to ESR request to make Java open 
source.
<http://www.osnews.com/comment.php?news_id=6053>


-Patrik

------------------------
Patrik Reali
http://www.reali.ch/~patrik/



_______________________________________________
Classpath mailing list
Classpath@gnu.org
http://mail.gnu.org/mailman/listinfo/classpath

_________________________________________________________________
Express yourself with cool emoticons - download MSN Messenger today! 
http://www.msn.co.uk/messenger




From MAILER-DAEMON Wed Feb 18 17:07:35 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AtZqw-0003rv-5Q
	for mharc-classpath@gnu.org; Wed, 18 Feb 2004 17:07:34 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AtZqn-0003qT-DJ
	for classpath@gnu.org; Wed, 18 Feb 2004 17:07:25 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AtZqG-0003gy-MJ
	for classpath@gnu.org; Wed, 18 Feb 2004 17:07:23 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AtZqG-0003g6-4s
	for classpath@gnu.org; Wed, 18 Feb 2004 17:06:52 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1AtZqC-0006eA-00
	for <classpath@gnu.org>; Wed, 18 Feb 2004 23:06:48 +0100
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AtZq9-0006bG-00; Wed, 18 Feb 2004 23:06:45 +0100
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i1IM6hLT019113;
	Wed, 18 Feb 2004 23:06:44 +0100 (MET)
Message-ID: <4033E1F3.4080406@kaffe.org>
Date: Wed, 18 Feb 2004 23:06:43 +0100
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3) Gecko/20030312
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Robert Lougher <robert_lougher@hotmail.com>
References: <BAY10-F81wRC6HixqDC000002c1@hotmail.com>
In-Reply-To: <BAY10-F81wRC6HixqDC000002c1@hotmail.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: classpath@gnu.org
Subject: Re: [Article] Sun Fires Back over Open Source Java Accusations
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Feb 2004 22:07:32 -0000

Robert Lougher wrote:
> Hi,
> 
> A quite interesting response.  However, it's funny hearing Phipps slam 
> IBM so much (considering their Linux technology center and support of 
> Jikes).  He used to be IBM's Java evangelist (based in Hursley, UK) 
> before defecting to Sun.  Favourite phrase was "Tsunami"...

The only thing that's going to make Sun open source any part of Java, is 
going to be the appearance of better, open-source solutions for those 
parts. And they'll probably use GNU Classpath ;)

cheers,
dalibor topic




From MAILER-DAEMON Wed Feb 18 19:50:26 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AtcKm-0004YA-K4
	for mharc-classpath@gnu.org; Wed, 18 Feb 2004 19:46:32 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AtcIC-0002mA-4Q
	for classpath@gnu.org; Wed, 18 Feb 2004 19:43:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AtcEl-0000FG-FX
	for classpath@gnu.org; Wed, 18 Feb 2004 19:40:50 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AtcCJ-00071r-6D
	for classpath@gnu.org; Wed, 18 Feb 2004 19:37:47 -0500
Received: from fleche.redhat.com (tf0208.peakpeak.com [204.144.239.208])
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id RAA22379;
	Wed, 18 Feb 2004 17:37:36 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 5CFAD4F82B2; Wed, 18 Feb 2004 17:26:46 -0700 (MST)
To: Patrik Reali <reali@acm.org>
References: <515920885.1077101171@[10.40.10.54]>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I've got to get these SNACK CAKES to NEWARK by DAWN!!
Date: 18 Feb 2004 17:26:46 -0700
In-Reply-To: <515920885.1077101171@[10.40.10.54]>
Message-ID: <87smh7ncc9.fsf@fleche.redhat.com>
Lines: 27
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: [Article] Sun Fires Back over Open Source Java Accusations
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2004 00:46:26 -0000

>>>>> "Patrik" == Patrik Reali <reali@acm.org> writes:

Patrik> OSNews has some discussion on Sun's answer to ESR request to make Java
Patrik> open source.
Patrik> <http://www.osnews.com/comment.php?news_id=6053>

IMO, while it would be helpful if Sun opened their source, we don't
really need it.

What we do need is 3 things:

1. Access to the TCK on acceptable terms,

2. Involvement in the JCP without contamination or other unacceptable
   constraints, and

3. Easing of the requirements on subsetting.  The free software
   community doesn't work well with the "one big perfect release"
   model that Sun seems to want.  They could lift these restrictions
   for free implementations only.  I think we all recognize
   compatibility as a major benefit of the Java platform; we differ
   only on how to get there.

The free Java implementors and Sun would make good allies if these
things were done.

Tom



From MAILER-DAEMON Wed Feb 18 20:40:12 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AtdAc-0002Rl-5Z
	for mharc-classpath@gnu.org; Wed, 18 Feb 2004 20:40:06 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AtdAT-0002M1-Mo
	for classpath@gnu.org; Wed, 18 Feb 2004 20:39:57 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1Atd9p-00024m-CW
	for classpath@gnu.org; Wed, 18 Feb 2004 20:39:48 -0500
Received: from [216.102.199.253] (helo=bothner.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1Atd9f-0001wR-2E
	for classpath@gnu.org; Wed, 18 Feb 2004 20:39:07 -0500
Received: from bothner.com (persmac [192.168.1.10])
	by bothner.com (8.12.10/8.12.10) with ESMTP id i1J1f7Za026767;
	Wed, 18 Feb 2004 17:41:07 -0800
Message-ID: <403413C5.8000402@bothner.com>
Date: Wed, 18 Feb 2004 17:39:17 -0800
From: Per Bothner <per@bothner.com>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <515920885.1077101171@[10.40.10.54]>
	<87smh7ncc9.fsf@fleche.redhat.com>
In-Reply-To: <87smh7ncc9.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: [Article] Sun Fires Back over Open Source Java Accusations
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2004 01:40:02 -0000

Tom Tromey wrote:

> IMO, while it would be helpful if Sun opened their source, we don't
> really need it.

On the other hand, I'm sure Red Hat would rather spend their
development resources on *not* having to re-implement Swing,
or all the new features of JDK 1.5 ...

It seems a waste to duplicate Sun's work, but of course
Sun is under no obligation to us.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/




From MAILER-DAEMON Thu Feb 19 00:20:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AtgbY-0000Ow-5W
	for mharc-classpath@gnu.org; Thu, 19 Feb 2004 00:20:08 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AtgbI-0008IA-W4
	for classpath@gnu.org; Thu, 19 Feb 2004 00:19:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AtgaS-0006Sr-MQ
	for classpath@gnu.org; Thu, 19 Feb 2004 00:19:32 -0500
Received: from [24.25.9.101] (helo=ms-smtp-02-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AtgaF-0005th-90
	for classpath@gnu.org; Thu, 19 Feb 2004 00:18:47 -0500
Received: from [10.0.0.2] (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-02-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	i1J5IckF006112; Thu, 19 Feb 2004 00:18:38 -0500 (EST)
From: "C. Brian Jones" <cbj@gnu.org>
To: Robert Lougher <robert_lougher@hotmail.com>
In-Reply-To: <BAY10-F81wRC6HixqDC000002c1@hotmail.com>
References: <BAY10-F81wRC6HixqDC000002c1@hotmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Q1Cu39+KFJ5Pa14a97Uq"
Message-Id: <1077167918.4096.70.camel@lyta.haphazard.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Thu, 19 Feb 2004 00:18:38 -0500
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: classpath@gnu.org
Subject: RE: [Article] Sun Fires Back over Open Source Java Accusations
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: cbj@gnu.org
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2004 05:20:01 -0000


--=-Q1Cu39+KFJ5Pa14a97Uq
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 2004-02-18 at 05:12, Robert Lougher wrote:
> Hi,
>=20
> A quite interesting response.  However, it's funny hearing Phipps slam IB=
M=20
> so much (considering their Linux technology center and support of Jikes).=
 =20
> He used to be IBM's Java evangelist (based in Hursley, UK) before defecti=
ng=20
> to Sun.  Favourite phrase was "Tsunami"...

I was recently in a small room with this man.  He makes some fair points
in response to Eric who really should have come here first before firing
off his open letter. =20

Rather than the rise of free software alternatives for Java I think the
thing which could push Java along the path of openoffice, netbeans, etc.
would be a wildly successful C# conversion of older Java software
resulting in significant declines in the Java rank and file.

I think Classpath isn't really looking to be branded 100% Java as much
as we'd like to know that some combination of Classpath and JVM can pass
the TCK with flying colors, in fact that the GNU Java platform can pass
all applicable TCKs and our own tests.  There is still a system
integration project left to be done, to pull together the compilers, the
tools, the JVM, the standard libraries and extensions and to make them
work together using similar naming and arguments for programs, etc. and
make the whole thing installable in one go instead of pulling bits and
pieces together from across the globe.

Brian

--=-Q1Cu39+KFJ5Pa14a97Uq
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQBANEctcEcmdY33uzYRAn0VAJ4i05xKoGsW5FHWNApMw6X7V0nqrwCfe78C
Y8eQczJ3rgDv2x5q/AJVNEw=
=6pp7
-----END PGP SIGNATURE-----

--=-Q1Cu39+KFJ5Pa14a97Uq--




From MAILER-DAEMON Thu Feb 19 10:38:53 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.24)
	id 1AtqGL-0002Ta-7F
	for mharc-classpath@gnu.org; Thu, 19 Feb 2004 10:38:53 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AtqG9-0002P1-9d
	for classpath@gnu.org; Thu, 19 Feb 2004 10:38:41 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AtqFd-00026x-4o
	for classpath@gnu.org; Thu, 19 Feb 2004 10:38:40 -0500
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.24) id 1AtqFc-00025a-2i
	for classpath@gnu.org; Thu, 19 Feb 2004 10:38:08 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-94-100.ewetel.net
	[80.228.94.100])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i1JFc4VA004921
	for <classpath@gnu.org>; Thu, 19 Feb 2004 16:38:04 +0100 (MET)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AtqFX-0005cD-00
	for <classpath@gnu.org>; Thu, 19 Feb 2004 16:38:03 +0100
From: Michael Koch <konqueror@gmx.de>
To: classpath@gnu.org
Date: Thu, 19 Feb 2004 10:25:53 +0100
User-Agent: KMail/1.5.4
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_hEINAmfZYv7yC0Q"
Message-Id: <200402191025.53504.konqueror@gmx.de>
X-CheckCompat: OK
Subject: Patch: java.net.URLConnection
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2004 15:38:47 -0000


--Boundary-00=_hEINAmfZYv7yC0Q
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi list,


Can someone take a look at the attached patch ? I would like to commit 
it to classpath. Its a merge from libgcj and tested there since months.

Okay for classpath ? Does someone see a problem in this ?


Michael


2004-02-12  Michael Koch  <konqueror@gmx.de>

	* java/net/URLConnection.java
	(dateFormat1, dateformat2, dateformat3): New fields.
	(dateformats_initialized): New field for lazy initialization of date
	format fields.
	(getHeaderFieldDate): Rewritten to use DateFormat.parse() instead of
	the deprecated Date(String) constructor. This implementation
	(initializeDateFormats): New method,

--Boundary-00=_hEINAmfZYv7yC0Q
Content-Type: text/x-diff;
  charset="us-ascii";
  name="url.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="url.diff"

Index: java/net/URLConnection.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/net/URLConnection.java,v
retrieving revision 1.22
diff -u -b -B -r1.22 URLConnection.java
--- java/net/URLConnection.java	25 Jan 2004 13:39:34 -0000	1.22
+++ java/net/URLConnection.java	12 Feb 2004 16:40:50 -0000
@@ -43,6 +43,8 @@
 import java.io.OutputStream;
 import java.security.AllPermission;
 import java.security.Permission;
+import java.text.ParsePosition;
+import java.text.SimpleDateFormat;
 import java.util.Collections;
 import java.util.Date;
 import java.util.Hashtable;
@@ -161,6 +163,8 @@
    */
   protected URL url;
 
+  private static SimpleDateFormat dateFormat1, dateFormat2, dateFormat3;
+  private static boolean dateformats_initialized = false;
 
   /**
    * Creates a URL connection to a given URL. A real connection is not made.
@@ -352,23 +356,24 @@
    */
   public long getHeaderFieldDate (String name, long defaultValue)
   {
-    String str = getHeaderField (name);
-    
-    if (str == null)
-      return defaultValue;
+    if (! dateformats_initialized)
+      initializeDateFormats ();
     
-    // This needs to change since Date(String) is deprecated, but DateFormat
-    // doesn't seem to be working for some reason
-    //DateFormat df = DateFormat.getDateInstance (DateFormat.FULL, Locale.US);
-    //df.setLenient (true);
-
-    //Date date = df.parse (value, new ParsePosition (0));
-    Date date = new Date (str);
+    long result = defaultValue;
+    String str = getHeaderField (name);
 
-    if (date == null)
-      return defaultValue;
+    if (str != null)
+      {
+	Date date;
+	if ((date = dateFormat1.parse (str, new ParsePosition (0))) != null)
+	  result = date.getTime ();
+	else if ((date = dateFormat2.parse (str, new ParsePosition (0))) != null)
+	  result = date.getTime ();
+	else if ((date = dateFormat3.parse (str, new ParsePosition (0))) != null)
+	  result = date.getTime ();
+      }
        
-    return (date.getTime() / 1000);
+    return result;
   }
 
   /**
@@ -953,4 +958,22 @@
 
     fileNameMap = map;
   }
-}
+  
+  // We don't put these in a static initializer, because it creates problems
+  // with initializer co-dependency: SimpleDateFormat's constructors eventually 
+  // depend on URLConnection (via the java.text.*Symbols classes).
+  private synchronized void initializeDateFormats()
+  {
+    if (dateformats_initialized)
+      return;
+
+    Locale locale = new Locale("En", "Us", "Unix");
+    dateFormat1 = new SimpleDateFormat("EEE, dd MMM yyyy hh:mm:ss 'GMT'", 
+                                       locale);
+    dateFormat2 = new SimpleDateFormat("EEEE, dd-MMM-yy hh:mm:ss 'GMT'", 
+                                       locale);
+    dateFormat3 = new SimpleDateFormat("EEE MMM d hh:mm:ss yyyy", locale);
+    dateformats_initialized = true;
+  }
+} // class URLConnection
+

--Boundary-00=_hEINAmfZYv7yC0Q--





From MAILER-DAEMON Thu Feb 19 23:37:55 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Au2QF-0007Xo-MT
	for mharc-classpath@gnu.org; Thu, 19 Feb 2004 23:37:55 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Au2QD-0007XU-Ae
	for classpath@gnu.org; Thu, 19 Feb 2004 23:37:53 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Au2Ph-0007Uo-Hr
	for classpath@gnu.org; Thu, 19 Feb 2004 23:37:52 -0500
Received: from [203.31.48.33] (helo=mailhost.netspeed.com.au)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Au2Pg-0007Sp-P0
	for classpath@gnu.org; Thu, 19 Feb 2004 23:37:21 -0500
Received: from tech.com.au (unverified [210.9.138.253]) 
	by netspeed.com.au (SurgeMail 1.6e2) with ESMTP id 19179672 
	for <classpath@gnu.org>; Fri, 20 Feb 2004 14:26:02 +1100
X-Verify-Failed: <chris@tech.com.au> Cached failure to verify from envelope
Message-ID: <40357D9D.60101@tech.com.au>
Date: Fri, 20 Feb 2004 14:23:09 +1100
From: "Chris B." <chris@tech.com.au>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: classpath@gnu.org
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Server: High Performance Mail Server - http://surgemail.com
Subject: MBOX and classpathx
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Feb 2004 04:37:53 -0000


The MBOX implementation in CLASSPATHX barfs on zero length files. But 
isn't a zero length file technically a valid MBOX file??





From MAILER-DAEMON Fri Feb 20 01:19:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Au3zN-0004aS-9o
	for mharc-classpath@gnu.org; Fri, 20 Feb 2004 01:18:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Au3yg-0003Ol-Fq
	for classpath@gnu.org; Fri, 20 Feb 2004 01:17:34 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Au3xm-0001NM-1B
	for classpath@gnu.org; Fri, 20 Feb 2004 01:17:09 -0500
Received: from [209.225.28.202] (helo=mxsf02.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Au3xM-0000k3-5G
	for classpath@gnu.org; Fri, 20 Feb 2004 01:16:12 -0500
Received: from InterJet.dellroad.org (public.cpe.mvllo.al.charter.com
	[24.196.18.156])
	by mxsf02.cluster1.charter.net (8.12.10/8.12.8) with ESMTP id
	i1K6F304017738
	for <classpath@gnu.org>; Fri, 20 Feb 2004 01:15:03 -0500 (EST)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id AAA52291
	for <classpath@gnu.org>; Fri, 20 Feb 2004 00:07:45 -0600 (CST)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i1K67j1f003572
	for <classpath@gnu.org>; Fri, 20 Feb 2004 00:07:45 -0600 (CST)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i1K67jsq003571
	for classpath@gnu.org; Fri, 20 Feb 2004 00:07:45 -0600 (CST)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200402200607.i1K67jsq003571@arch20m.dellroad.org>
To: classpath@gnu.org
Date: Fri, 20 Feb 2004 00:07:45 -0600 (CST)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Subject: JC 1.0.0 release
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Feb 2004 06:18:11 -0000

Now there's yet another JVM based on Classpath! Don't ask why :-)

    Announcing JC 1.0.0.

    JC is a Java virtual machine implementation that converts class 
    files into C source files using the Soot Java bytecode analysis
    framework, compiles them with GCC, and loads them using a built-in
    ELF object file loader. JC utilizes the GNU Classpath class library
    and provides support for ``most'' features you would expect such
    as reflection, user class loaders, etc.

    More info available at: http://jcvm.sourceforge.net/

Cheers,
-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Fri Feb 20 05:51:40 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Au8Fw-0000A5-Gg
	for mharc-classpath@gnu.org; Fri, 20 Feb 2004 05:51:40 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Au8Fu-000099-9W
	for classpath@gnu.org; Fri, 20 Feb 2004 05:51:38 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Au8FO-00005l-EM
	for classpath@gnu.org; Fri, 20 Feb 2004 05:51:37 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Au8FN-00005h-Vw
	for classpath@gnu.org; Fri, 20 Feb 2004 05:51:06 -0500
Received: (qmail 12371 invoked by uid 504); 20 Feb 2004 11:51:01 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 1.207679 secs); 20 Feb 2004 10:51:01 -0000
Received: from unknown (HELO oz.fapse.ulg.ac.be) ([139.165.77.198])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <tromey@redhat.com>; 20 Feb 2004 11:51:00 +0100
Received: from arnaud by oz.fapse.ulg.ac.be with local (Exim 4.30)
	id 1Au8FH-0002W2-Hc; Fri, 20 Feb 2004 11:50:59 +0100
To: tromey@redhat.com
References: <515920885.1077101171@[10.40.10.54]>
	<87smh7ncc9.fsf@fleche.redhat.com>
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
X-Face: >U]gI'=hKRtZE@~Svh"mU,aS"">yCT*dBkVAFl'!]!&k@R8fEr{-)Ql6{xhuXKb+!>}x;
	^2ck7Ytr'EABxt~)3q?AO}$:wwSva.$uNN9x.w4+uVmMMSB1~EbJgo|9E0yQXONuM'~c*20^
Date: Fri, 20 Feb 2004 11:50:59 +0100
In-Reply-To: <87smh7ncc9.fsf@fleche.redhat.com> (Tom Tromey's message of "18
	Feb 2004 17:26:46 -0700")
Message-ID: <87ad3ednxo.fsf@oz.fapse.ulg.ac.be>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
Cc: classpath@gnu.org
Subject: Re: [Article] Sun Fires Back over Open Source Java Accusations
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Feb 2004 10:51:38 -0000

Tom Tromey <tromey@redhat.com> writes:

>>>>>> "Patrik" == Patrik Reali <reali@acm.org> writes:
>
> Patrik> OSNews has some discussion on Sun's answer to ESR request to make Java
> Patrik> open source.
> Patrik> <http://www.osnews.com/comment.php?news_id=6053>
>
> IMO, while it would be helpful if Sun opened their source, we don't
> really need it.
>
> What we do need is 3 things:
>
> 1. Access to the TCK on acceptable terms,
>
> 2. Involvement in the JCP without contamination or other unacceptable
>    constraints, and
>
> 3. Easing of the requirements on subsetting.  The free software
>    community doesn't work well with the "one big perfect release"
>    model that Sun seems to want.  They could lift these restrictions
>    for free implementations only.  I think we all recognize
>    compatibility as a major benefit of the Java platform; we differ
>    only on how to get there.
>
> The free Java implementors and Sun would make good allies if these
> things were done.

Maybe this could be a good start for a better open letter, isn't it?!

-- 
Arnaud



From MAILER-DAEMON Fri Feb 20 05:53:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Au8Hc-0000vB-AC
	for mharc-classpath@gnu.org; Fri, 20 Feb 2004 05:53:24 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Au8CR-0007hc-W5
	for classpath@gnu.org; Fri, 20 Feb 2004 05:48:03 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Au8BK-0005ym-C3
	for classpath@gnu.org; Fri, 20 Feb 2004 05:47:19 -0500
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Au8AT-0004kS-9B
	for classpath@gnu.org; Fri, 20 Feb 2004 05:46:01 -0500
Received: (qmail 9689 invoked by uid 504); 20 Feb 2004 11:45:57 +0100
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.883695 secs); 20 Feb 2004 10:45:57 -0000
Received: from unknown (HELO oz.fapse.ulg.ac.be) ([139.165.77.198])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <chris@tech.com.au>; 20 Feb 2004 11:45:56 +0100
Received: from arnaud by oz.fapse.ulg.ac.be with local (Exim 4.30)
	id 1Au8AN-0002Vm-7m; Fri, 20 Feb 2004 11:45:55 +0100
To: "Chris B." <chris@tech.com.au>
References: <40357D9D.60101@tech.com.au>
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
X-Face: >U]gI'=hKRtZE@~Svh"mU,aS"">yCT*dBkVAFl'!]!&k@R8fEr{-)Ql6{xhuXKb+!>}x;
	^2ck7Ytr'EABxt~)3q?AO}$:wwSva.$uNN9x.w4+uVmMMSB1~EbJgo|9E0yQXONuM'~c*20^
Date: Fri, 20 Feb 2004 11:45:55 +0100
In-Reply-To: <40357D9D.60101@tech.com.au> (Chris B.'s message of "Fri, 20
	Feb 2004 14:23:09 +1100")
Message-ID: <87hdxmdo64.fsf@oz.fapse.ulg.ac.be>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
Cc: classpath@gnu.org
Subject: Re: MBOX and classpathx
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Feb 2004 10:53:21 -0000

"Chris B." <chris@tech.com.au> writes:

> The MBOX implementation in CLASSPATHX barfs on zero length files. But
> isn't a zero length file technically a valid MBOX file??

I did forward the mail to classpathx-javamail@gnu.org

-- 
Arnaud



From MAILER-DAEMON Sun Feb 22 17:16:17 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Av1tZ-0002d8-7p
	for mharc-classpath@gnu.org; Sun, 22 Feb 2004 17:16:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Av1tW-0002cV-7I
	for classpath@gnu.org; Sun, 22 Feb 2004 17:16:14 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Av1su-0002B1-EC
	for classpath@gnu.org; Sun, 22 Feb 2004 17:16:07 -0500
Received: from [209.225.28.217] (helo=mxsf17.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Av1si-0001uu-Bo
	for classpath@gnu.org; Sun, 22 Feb 2004 17:15:24 -0500
Received: from InterJet.dellroad.org (public.cpe.mvllo.al.charter.com
	[24.196.18.156])
	by mxsf17.cluster1.charter.net (8.12.10/8.12.8) with ESMTP id
	i1MMF2Kn087736
	for <classpath@gnu.org>; Sun, 22 Feb 2004 17:15:02 -0500 (EST)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id QAA93703
	for <classpath@gnu.org>; Sun, 22 Feb 2004 16:04:36 -0600 (CST)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i1MM4a19008053
	for <classpath@gnu.org>; Sun, 22 Feb 2004 16:04:36 -0600 (CST)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i1MM4aTX008052
	for classpath@gnu.org; Sun, 22 Feb 2004 16:04:36 -0600 (CST)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200402222204.i1MM4aTX008052@arch20m.dellroad.org>
To: classpath@gnu.org
Date: Sun, 22 Feb 2004 16:04:35 -0600 (CST)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Subject: Web site still locked down?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Feb 2004 22:16:15 -0000

Hi,

Just confirming: is the web site still "locked down" due to the
security problem? By "web site" I'm referring to "www.classpath.org",
(which redirects to "http://www.gnu.org/software/classpath/").
E.g., the download page still shows 0.06 as the latest release.

Thanks,
-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Sun Feb 22 18:01:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Av2bI-0000CT-6T
	for mharc-classpath@gnu.org; Sun, 22 Feb 2004 18:01:28 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Av2bF-0000Bi-5m
	for classpath@gnu.org; Sun, 22 Feb 2004 18:01:25 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Av2aj-0008Uz-Be
	for classpath@gnu.org; Sun, 22 Feb 2004 18:01:24 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1Av2aj-0008Qe-4f
	for classpath@gnu.org; Sun, 22 Feb 2004 18:00:53 -0500
Received: from [203.31.48.33] (helo=mailhost.netspeed.com.au)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1Av2Yw-0001yZ-1n
	for classpath@gnu.org; Sun, 22 Feb 2004 17:59:02 -0500
Received: from tech.com.au (unverified [210.9.143.249]) 
	by netspeed.com.au (SurgeMail 1.6e2) with ESMTP id 19530543 
	for <classpath@gnu.org>; Mon, 23 Feb 2004 10:01:01 +1100
Message-ID: <403933E4.8070106@tech.com.au>
Date: Mon, 23 Feb 2004 09:57:40 +1100
From: "Chris B." <chris@tech.com.au>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: classpath@gnu.org
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Server: High Performance Mail Server - http://surgemail.com
Subject: MBOX and classpathx
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Feb 2004 23:01:25 -0000


The MBOX implementation in CLASSPATHX barfs on zero length files. But
isn't a zero length file technically a valid MBOX file??






From MAILER-DAEMON Mon Feb 23 02:38:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvAej-0003a8-D0
	for mharc-classpath@gnu.org; Mon, 23 Feb 2004 02:37:33 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvAeC-0002W6-Nq
	for classpath@gnu.org; Mon, 23 Feb 2004 02:37:00 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvAdU-0001ie-QK
	for classpath@gnu.org; Mon, 23 Feb 2004 02:36:49 -0500
Received: from [212.74.117.6] (helo=dinopsis.arachsys.net)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1AvAdR-0001Xk-QK; Mon, 23 Feb 2004 02:36:13 -0500
Received: from dog by dinopsis.arachsys.net with local (Exim 3.35 #1)
	id 1AvAd5-0006qY-00; Mon, 23 Feb 2004 07:35:51 +0000
Date: Mon, 23 Feb 2004 07:35:51 +0000
From: Chris Burdess <dog@bluezoo.org>
To: "Chris B." <chris@tech.com.au>
Message-ID: <20040223073551.GA25738@bluezoo.org>
Mail-Followup-To: "Chris B." <chris@tech.com.au>, classpath@gnu.org,
	classpathx-javamail@gnu.org
References: <403933E4.8070106@tech.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <403933E4.8070106@tech.com.au>
User-Agent: Mutt/1.3.28i
X-URL: http://www.bluezoo.org/
Cc: classpath@gnu.org, classpathx-javamail@gnu.org
Subject: Re: MBOX and classpathx
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 07:37:25 -0000

Chris B. wrote:
> The MBOX implementation in CLASSPATHX barfs on zero length files. But
> isn't a zero length file technically a valid MBOX file??

Yes, probably. I'll sort this ASAP.
-- 
Chris Burdess



From MAILER-DAEMON Mon Feb 23 06:56:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvEhG-0005Kg-CB
	for mharc-classpath@gnu.org; Mon, 23 Feb 2004 06:56:26 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvEh9-0005JK-M7
	for classpath@gnu.org; Mon, 23 Feb 2004 06:56:19 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvEgR-00059F-Gz
	for classpath@gnu.org; Mon, 23 Feb 2004 06:56:06 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvEYh-00032A-6u
	for classpath@gnu.org; Mon, 23 Feb 2004 06:47:35 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 23 Feb 2004 12:47:25 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C9B8@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Object serialization patch
Thread-Index: AcP5IcTCxXZFAKd3SXmDtkUSzTdghwA4FkvA
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Guilhem Lavaux" <guilhem@kaffe.org>,
	<classpath@gnu.org>
Cc: 
Subject: RE: Object serialization patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 11:56:21 -0000

Hi,

Thanks for the patch.

I have one question.

> 	    int comp_val =3D
>-		real_fields[real_idx].compareTo
(stream_fields[stream_idx]);
>+		real_fields[real_idx].getName().compareTo
(stream_fields[stream_idx].getName());

By my reading of the spec, primitive fields are written before reference
fields, it's not simply sorted by name. See
http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc3.ht
ml

Regards,
Jeroen



From MAILER-DAEMON Mon Feb 23 08:25:17 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvG5F-0000t9-7r
	for mharc-classpath@gnu.org; Mon, 23 Feb 2004 08:25:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvG4d-0000fI-Ah
	for classpath@gnu.org; Mon, 23 Feb 2004 08:24:39 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvG3y-0000QQ-7C
	for classpath@gnu.org; Mon, 23 Feb 2004 08:24:29 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1AvG3x-0000PX-Og
	for classpath@gnu.org; Mon, 23 Feb 2004 08:23:57 -0500
Received: from [62.4.16.101] (helo=kraid.nerim.net)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1AvFyA-0005S3-E1
	for classpath@gnu.org; Mon, 23 Feb 2004 08:17:58 -0500
Received: from kaffe.org (lavaux.net1.nerim.net [62.212.115.70])
	by kraid.nerim.net (Postfix) with ESMTP
	id 486C840EFE; Mon, 23 Feb 2004 14:17:25 +0100 (CET)
Message-ID: <4039FD65.90203@kaffe.org>
Date: Mon, 23 Feb 2004 14:17:25 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC04C9B8@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC04C9B8@LEMBU.sumatrasoftware.com>
X-Enigmail-Version: 0.82.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: Object serialization patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 13:24:42 -0000

Jeroen Frijters wrote:

>Hi,
>
>Thanks for the patch.
>
>I have one question.
>
>  
>
>>	    int comp_val =
>>-		real_fields[real_idx].compareTo
>>    
>>
>(stream_fields[stream_idx]);
>  
>
>>+		real_fields[real_idx].getName().compareTo
>>    
>>
>(stream_fields[stream_idx].getName());
>
>By my reading of the spec, primitive fields are written before reference
>fields, it's not simply sorted by name. See
>http://java.sun.com/j2se/1.3/docs/guide/serialization/spec/class.doc3.ht
>ml
>  
>
Right. I've forgotten this problem. This was introduced to fix a 
specific problem when you have inconsistencies between the field 
descriptors from the stream and from the class definition.
For example, if you have:

class A { String x; }

and  in the stream you have 'int x' the former behaviour was not able to 
detect the inconsistency and was creating a new duplicate field 'int x'.
So maybe we should check this before the main loop by first comparing 
fields by name and then merging the two tables.

Regards,
Guilhem.




From MAILER-DAEMON Mon Feb 23 10:52:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvIN4-0000iB-IF
	for mharc-classpath@gnu.org; Mon, 23 Feb 2004 10:51:50 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvIMZ-00006a-5V
	for classpath@gnu.org; Mon, 23 Feb 2004 10:51:19 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvILi-0007Fr-8k
	for classpath@gnu.org; Mon, 23 Feb 2004 10:50:59 -0500
Received: from [62.4.16.101] (helo=kraid.nerim.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvILF-0006kB-Bk
	for classpath@gnu.org; Mon, 23 Feb 2004 10:49:57 -0500
Received: from kaffe.org (lavaux.net1.nerim.net [62.212.115.70])
	by kraid.nerim.net (Postfix) with ESMTP
	id BB57A4190B; Mon, 23 Feb 2004 16:49:51 +0100 (CET)
Message-ID: <403A2120.6000904@kaffe.org>
Date: Mon, 23 Feb 2004 16:49:52 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC04C9B8@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC04C9B8@LEMBU.sumatrasoftware.com>
X-Enigmail-Version: 0.82.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------050503000408090904030601"
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: Object serialization patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 15:51:39 -0000

This is a multi-part message in MIME format.
--------------050503000408090904030601
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is a new patch I propose. I've taken the suggestion 
into account and fix another small error reporting problem.

New changelog entry:

2004-02-23  Guilhem Lavaux <guilhem@kaffe.org>
	
	* libraries/javalib/java/io/ObjectInputStream.java
	(readClassDescriptor): Fixed field sorting. Keep
	elements of the mapping non null.
	(readFields): Fixed main loop and base logic. Small
	reindentation.
	(checkTypeConsistency): New method.

	* libraries/javalib/java/io/ObjectStreamField.java
	(lookupField): New method to update the field
	reference.
	(setBooleanField, setByteField, setCharField,
	setShortField, setIntField, setLongField,
	setFloatField, setDoubleField, setObjectField):
	Improved exception reporting.

	* libraries/javalib/java/io/ObjectStreamClass.java
	(setClass, setFields): Call lookupField when
	building the field database.

--------------050503000408090904030601
Content-Type: text/plain;
 name="obj_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="obj_patch"

Index: java/io/ObjectInputStream.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectInputStream.java,v
retrieving revision 1.38
diff -b -B -u -r1.38 ObjectInputStream.java
--- java/io/ObjectInputStream.java	10 Feb 2004 07:28:09 -0000	1.38
+++ java/io/ObjectInputStream.java	23 Feb 2004 15:30:11 -0000
@@ -412,6 +412,65 @@
   }
 
   /**
+   * This method makes a partial check of types for the fields
+   * contained given in arguments. It checks primitive types of
+   * fields1 against non primitive types of fields2. This method 
+   * assumes the two lists has already been sorted according to 
+   * the Java specification.
+   *
+   * @param name Name of the class owning the given fields.
+   * @param fields1 First list to check.
+   * @param fields2 Second list to check.
+   * @throws InvalidClassException if a field in fields1, which has a primitive type, is a present
+   * in the non primitive part in fields2.
+   */
+  private void checkTypeConsistency(String name, ObjectStreamField[] fields1, ObjectStreamField[] fields2)
+    throws InvalidClassException
+  {
+    int nonPrimitive = 0;
+    
+    for (nonPrimitive = 0; 
+	 nonPrimitive < fields1.length
+	   && fields1[nonPrimitive].isPrimitive(); nonPrimitive++)
+      {
+      }
+
+    if (nonPrimitive == fields1.length)
+      return;
+    
+    int i = 0;
+    ObjectStreamField f1;
+    ObjectStreamField f2;
+    
+    while (i < fields2.length
+	   && nonPrimitive < fields1.length)
+      {
+	f1 = fields1[nonPrimitive];
+	f2 = fields2[i];
+	
+	if (!f2.isPrimitive())
+	  break;
+
+	int compVal = f1.getName().compareTo (f2.getName());
+
+	if (compVal < 0)
+	  {
+	    nonPrimitive++;
+	  }
+	else if (compVal > 0)
+	  {
+	    i++;
+	  }
+	else
+	  {
+	    throw new InvalidClassException
+	      ("invalid field type for " + f2.getName() +
+	       " in class " + name);
+	  }
+      }
+  }
+
+  /**
    * This method reads a class descriptor from the real input stream
    * and use these data to create a new instance of ObjectStreamClass.
    * Fields are sorted and ordered for the real read which occurs for
@@ -496,6 +555,15 @@
     int real_idx = 0;
     int map_idx = 0;
 
+    /*
+     * Check that there is no type inconsistencies between the lists.
+     * A special checking must be done for the two groups: primitive types and
+     * not primitive types. 
+     */
+    checkTypeConsistency(name, real_fields, stream_fields);
+    checkTypeConsistency(name, stream_fields, real_fields);
+
+    
     while (stream_idx < stream_fields.length
 	   || real_idx < real_fields.length)
       {
@@ -527,21 +595,13 @@
 	      {
 		stream_field = stream_fields[stream_idx++];
 		real_field = real_fields[real_idx++];
-		if(stream_field.getType() != real_field.getType())
+		if (stream_field.getType() != real_field.getType())
 		    throw new InvalidClassException
 			("invalid field type for " + real_field.getName() +
 			" in class " + name);
 	      }
 	  }
-	if (stream_field != null)
-	  {
-	    if (stream_field.getOffset() < 0)
-		stream_field = null;
-	    else if (!stream_field.isToSet())
-		real_field = null;
-	  }
-	if (real_field != null && !real_field.isToSet())
-	    real_field = null;
+
 	/* If some of stream_fields does not correspond to any of real_fields,
 	 * or the opposite, then fieldmapping will go short.
 	 */
@@ -1576,12 +1636,11 @@
       {
 	ObjectStreamField stream_field = fields[i];
 	ObjectStreamField real_field = fields[i + 1];
-	if(stream_field != null || real_field != null)
-	  {
-	    boolean read_value = stream_field != null;
-	    boolean set_value = real_field != null;
+	boolean read_value = (stream_field != null && stream_field.getOffset() >= 0 && stream_field.isToSet());
+	boolean set_value = (real_field != null && real_field.isToSet());
 	    String field_name;
 	    char type;
+
 	    if (stream_field != null)
 	      {
 		field_name = stream_field.getName();
@@ -1680,8 +1739,8 @@
 		  {
 		    Object value =
 			read_value ? readObject() : null;
-		    if (set_value)
-			real_field.setObjectField(obj, value);
+	      if (set_value && stream_field != null)
+		real_field.setObjectField(obj, stream_field.getTypeString(), value);
 		    break;
 		  }
 		default:
@@ -1689,7 +1748,6 @@
 	      }
 	  }
       }
-  }
 
   // Toggles writing primitive data to block-data buffer.
   private boolean setBlockDataMode (boolean on)
Index: java/io/ObjectStreamClass.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectStreamClass.java,v
retrieving revision 1.30
diff -b -B -u -r1.30 ObjectStreamClass.java
--- java/io/ObjectStreamClass.java	2 Feb 2004 10:26:51 -0000	1.30
+++ java/io/ObjectStreamClass.java	23 Feb 2004 15:30:11 -0000
@@ -344,6 +344,13 @@
 		newFieldList[k] = exportedFields[j];
 		newFieldList[k].setPersistent(true);
 		newFieldList[k].setToSet(false);
+		try
+		  {
+		    newFieldList[k].lookupField(clazz);
+		  }
+		catch (NoSuchFieldException _)
+		  {
+		  }
 		j++;
 	      }
 	    else
@@ -554,6 +561,19 @@
 	    if (fields != null)
 	      {
 		Arrays.sort (fields);
+		// Retrieve field reference.
+		for (int i=0; i < fields.length; i++)
+		  {
+		    try
+		      {
+			fields[i].lookupField(cl);
+		      }
+		    catch (NoSuchFieldException _)
+		      {
+			fields[i].setToSet(false);
+		      }
+		  }
+		
 		calculateOffsets();
 		return;
 	      }
Index: java/io/ObjectStreamField.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectStreamField.java,v
retrieving revision 1.13
diff -b -B -u -r1.13 ObjectStreamField.java
--- java/io/ObjectStreamField.java	2 Feb 2004 10:26:51 -0000	1.13
+++ java/io/ObjectStreamField.java	23 Feb 2004 15:30:11 -0000
@@ -41,6 +41,8 @@
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
 import gnu.java.lang.reflect.TypeSignature;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
 
 /**
  * This class intends to describe the field of a class for the serialization
@@ -99,7 +101,7 @@
  
   /**
    * There are many cases you can not get java.lang.Class from typename 
-   * if your context class loader cann not load it, then use typename to
+   * if your context class loader cannot load it, then use typename to
    * construct the field.
    *
    * @param name Name of the field to export.
@@ -292,7 +294,7 @@
   }
 
   /**
-   * This methods returns true if the field is marked as to be
+   * This method returns true if the field is marked as to be
    * set.
    *
    * @return True if it is to be set, false in the other cases.
@@ -303,112 +305,191 @@
     return toset;
   }
 
+  /**
+   * This method searches for its field reference in the specified class
+   * object. It requests privileges. If an error occurs the internal field
+   * reference is not modified.
+   *
+   * @throws NoSuchFieldException if the field name does not exist in this class.
+   * @throws SecurityException if there was an error requesting the privileges.
+   */
+  void lookupField(Class clazz) throws NoSuchFieldException, SecurityException
+  {
+    final Field f = clazz.getDeclaredField(name);
+    
+    AccessController.doPrivileged(new PrivilegedAction()
+      {
+	public Object run()
+	{
+	  f.setAccessible(true);
+	  return null;
+	}
+      });
+    
+    this.field = f;
+  }
+
   public String toString ()
   {
     return "ObjectStreamField< " + type + " " + name + " >";
   }
 
-  final void setBooleanField(Object obj, boolean val)
+  /*
+   * These methods set the required field in the class instance obj.
+   * They may throw NullPointerException if the field does not really exist.
+   */
+
+  final void setBooleanField(Object obj, boolean val) throws IOException
   {
       try
       {
 	  field.setBoolean(obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);
+      }
       catch(IllegalAccessException x)
       {
 	  throw new InternalError(x.getMessage());
       }
   }
 
-  final void setByteField(Object obj, byte val)
+  final void setByteField(Object obj, byte val) throws IOException
   {
       try
       {
 	  field.setByte(obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);
+      }
       catch(IllegalAccessException x)
       {
 	  throw new InternalError(x.getMessage());
       }
   }
 
-  final void setCharField(Object obj, char val)
+  final void setCharField(Object obj, char val) throws IOException
   {
       try
       {
 	  field.setChar(obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);
+      }
       catch(IllegalAccessException x)
       {
 	  throw new InternalError(x.getMessage());
       }
   }
 
-  final void setShortField(Object obj, short val)
+  final void setShortField(Object obj, short val) throws IOException
   {
       try
       {
 	  field.setShort(obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);
+      }
       catch(IllegalAccessException x)
       {
 	  throw new InternalError(x.getMessage());
       }
   }
 
-  final void setIntField(Object obj, int val)
+  final void setIntField(Object obj, int val) throws IOException
   {
       try
       {
 	  field.setInt(obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);
+      }
       catch(IllegalAccessException x)
       {
 	  throw new InternalError(x.getMessage());
       }
   }
 
-  final void setLongField(Object obj, long val)
+  final void setLongField(Object obj, long val) throws IOException
   {
       try
       {
 	  field.setLong(obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);
+      }
       catch(IllegalAccessException x)
       {
 	  throw new InternalError(x.getMessage());
       }
   }
 
-  final void setFloatField(Object obj, float val)
+  final void setFloatField(Object obj, float val) throws IOException
   {
       try
       {
 	  field.setFloat(obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);
+      }
       catch(IllegalAccessException x)
       {
 	  throw new InternalError(x.getMessage());
       }
   }
 
-  final void setDoubleField(Object obj, double val)
+  final void setDoubleField(Object obj, double val) throws IOException
   {
       try
       {
 	  field.setDouble(obj, val);
       }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);
+      }
       catch(IllegalAccessException x)
       {
 	  throw new InternalError(x.getMessage());
       }
   }
 
-  final void setObjectField(Object obj, Object val)
+  final void setObjectField(Object obj, String valtype, Object val) throws IOException
   {
+    if (valtype == null ||
+	!typename.equals(valtype))
+      throw new InvalidClassException("incompatible field type for " + 
+				      obj.getClass().getName() + "." + name);
+ 
     try
       {
 	field.set(obj, val);
+      }
+    catch (IllegalArgumentException _)
+      {
+	throw new InvalidClassException("incompatible field type for " +
+					obj.getClass().getName() + "." + name);	
       }
     catch(IllegalAccessException x)
       {

--------------050503000408090904030601--




From MAILER-DAEMON Mon Feb 23 11:43:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvJAh-0002oT-K7
	for mharc-classpath@gnu.org; Mon, 23 Feb 2004 11:43:07 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvJAb-0002o2-Ev
	for classpath@gnu.org; Mon, 23 Feb 2004 11:43:01 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvJAZ-0002mY-Eu
	for classpath@gnu.org; Mon, 23 Feb 2004 11:43:00 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvJAX-0002mO-Aw
	for classpath@gnu.org; Mon, 23 Feb 2004 11:42:57 -0500
Received: from slauerhoff.wildebeest.org ([192.168.1.27] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AvJAM-0002Rd-00
	for <classpath@gnu.org>; Mon, 23 Feb 2004 17:42:46 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-amNjkLYMjJSPj5PrpI2i"
Message-Id: <1077550600.1105.91.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 23 Feb 2004 17:42:52 +0100
Subject: FOSDEM report
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 16:43:02 -0000


--=-amNjkLYMjJSPj5PrpI2i
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi all,

FOSDEM was really, really nice!

There were between 20 and 50 people following the different
presentations, talks and discussions in our developer room. And Tom
Tromey his talk on gcj in the big room got 120 interested people.
There was a surprize talk on JDesktop. And Sascha stayed up till 4am on
Saturday night to create a Free Java & Security talk to help out the
organisation when at the last minute one of the original talks in the
security track couldn't be given. (With thanks to Dalibor and Chris for
input and to everybody else who started up their laptops late at night
to check various methods to hang and/or crash the various VMs.) This
talk also seemed to be well received. And we got a couple of people
interested in helping out on the various projects.

The presentation that I prepared with Sascha is online at:
http://www.dandelis.ch/people/brawer/articles/classpathFeb2004/

It makes nice material when you want to present something on GNU
Classpath or on one of the other free java-like projects in the future.
If other presentations are also online, please post them to the list.

I also made a flyer to attract some people to the talks that can be
adapted for future events (but make sure you spell Februari and Saterday
correctly on your version... sigh)
http://www.klomp.org/mark/classpath/fosdem/

I told the FOSDEM organizers how much all their organisational work was
appreciated and especially how nice the buffet on Saturday night was.
There was so much energy in the room and so much discussion and
interaction between Free Software developers of different groups and
projects. (For example Petter Reinholdtsen one of the original Japhar
developers was there.)

We could have had more in depth technical discussions. Most of the
presentations now were more overviews of what was already there. Which
is great for attracting new developers and explaining our goals to
outsiders. But for next time we must really appoint people that lead
some technical issue. Many thanks to Andrew for just standing up and
starting the pluggable JIT interface discussion by telling how gcj would
like to support it.

One thing I completely forgot was organising some key-signing between
the developers. That would have been really nice to get a tighter
web-of-trust, especially since savannah CVS will in the future support
signed commits. Next time hackers meet be sure to have some fingerprints
on you so you can sign each others keys.

But all in all the meeting was a great success.
Thanks all that attended and hopefully we will meet again in the future.

There were also some photos taken so you might actually find out how
some of our hackers look in the near future :)

Some people said that they didn't know that some of us virtually meet
from time to time on irc. So please join #classpath, #kaffe or #sablevm
on irc.gnu.org or #gcj on irc.oftc.net next time you have internet
access.

Cheers,

Mark

--=-amNjkLYMjJSPj5PrpI2i
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAOh4HxVhZCJWr9QwRAmboAKCZ6TmQoqLA6bqbHgPKoB+wlDnvSwCgnNrD
JC9Q5lR6OjKmwoq66XsGlZY=
=DIqk
-----END PGP SIGNATURE-----

--=-amNjkLYMjJSPj5PrpI2i--




From MAILER-DAEMON Mon Feb 23 12:23:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvJo6-0004bN-4R
	for mharc-classpath@gnu.org; Mon, 23 Feb 2004 12:23:50 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvJo3-0004bF-NP
	for classpath@gnu.org; Mon, 23 Feb 2004 12:23:47 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvJnW-0004Xk-Je
	for classpath@gnu.org; Mon, 23 Feb 2004 12:23:46 -0500
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvJnW-0004Xb-5K
	for classpath@gnu.org; Mon, 23 Feb 2004 12:23:14 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-95-130.ewetel.net
	[80.228.95.130])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i1NHN7VA027497;
	Mon, 23 Feb 2004 18:23:08 +0100 (MET)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AvJnO-0007Qc-00; Mon, 23 Feb 2004 18:23:06 +0100
From: Michael Koch <konqueror@gmx.de>
To: Mark Wielaard <mark@klomp.org>, classpath@gnu.org
Date: Mon, 23 Feb 2004 18:27:08 +0100
User-Agent: KMail/1.5.4
References: <1077550600.1105.91.camel@localhost>
In-Reply-To: <1077550600.1105.91.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200402231827.09095.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: FOSDEM report
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 17:23:48 -0000

Am Montag, 23. Februar 2004 17:42 schrieb Mark Wielaard:
> Hi all,
>
> FOSDEM was really, really nice!
>
> There were between 20 and 50 people following the different
> presentations, talks and discussions in our developer room. And Tom
> Tromey his talk on gcj in the big room got 120 interested people.
> There was a surprize talk on JDesktop. And Sascha stayed up till 4am
> on Saturday night to create a Free Java & Security talk to help out
> the organisation when at the last minute one of the original talks in
> the security track couldn't be given. (With thanks to Dalibor and
> Chris for input and to everybody else who started up their laptops
> late at night to check various methods to hang and/or crash the
> various VMs.) This talk also seemed to be well received. And we got a
> couple of people interested in helping out on the various projects.
>
> The presentation that I prepared with Sascha is online at:
> http://www.dandelis.ch/people/brawer/articles/classpathFeb2004/
>
> It makes nice material when you want to present something on GNU
> Classpath or on one of the other free java-like projects in the
> future. If other presentations are also online, please post them to
> the list.
>
> I also made a flyer to attract some people to the talks that can be
> adapted for future events (but make sure you spell Februari and
> Saterday correctly on your version... sigh)
> http://www.klomp.org/mark/classpath/fosdem/
>
> I told the FOSDEM organizers how much all their organisational work
> was appreciated and especially how nice the buffet on Saturday night
> was. There was so much energy in the room and so much discussion and
> interaction between Free Software developers of different groups and
> projects. (For example Petter Reinholdtsen one of the original Japhar
> developers was there.)
>
> We could have had more in depth technical discussions. Most of the
> presentations now were more overviews of what was already there.
> Which is great for attracting new developers and explaining our goals
> to outsiders. But for next time we must really appoint people that
> lead some technical issue. Many thanks to Andrew for just standing up
> and starting the pluggable JIT interface discussion by telling how
> gcj would like to support it.
>
> One thing I completely forgot was organising some key-signing between
> the developers. That would have been really nice to get a tighter
> web-of-trust, especially since savannah CVS will in the future
> support signed commits. Next time hackers meet be sure to have some
> fingerprints on you so you can sign each others keys.
>
> But all in all the meeting was a great success.
> Thanks all that attended and hopefully we will meet again in the
> future.
>
> There were also some photos taken so you might actually find out how
> some of our hackers look in the near future :)
>
> Some people said that they didn't know that some of us virtually meet
> from time to time on irc. So please join #classpath, #kaffe or
> #sablevm on irc.gnu.org or #gcj on irc.oftc.net next time you have
> internet access.

Thanks for the report.

I heard you all had much fun, even with one bed missing ...


Michael




From MAILER-DAEMON Mon Feb 23 12:57:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvKK5-0006w9-UU
	for mharc-classpath@gnu.org; Mon, 23 Feb 2004 12:56:53 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvKJg-0006aS-CF
	for classpath@gnu.org; Mon, 23 Feb 2004 12:56:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvKIy-00068h-Hq
	for classpath@gnu.org; Mon, 23 Feb 2004 12:56:16 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvKIv-00062c-OX
	for classpath@gnu.org; Mon, 23 Feb 2004 12:55:43 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 23 Feb 2004 18:55:29 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C9C5@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Object serialization patch
Thread-Index: AcP6JLSmgRjqfYfpT+CMBMbDPjVauwADS0rg
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Guilhem Lavaux" <guilhem@kaffe.org>
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: RE: Object serialization patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 17:56:52 -0000

Hi,=20

> Here is a new patch I propose. I've taken the suggestion=20
> into account and fix another small error reporting problem.

I don't understand checkTypeConsistency, it looks odd and I'm having a
hard time believing that it is correct. BTW, Shouldn't "nonPrimitive" be
named "primitive"?

Also, I really don't like the type checking being done in the various
setXxxField methods, there is no reason to do this every time, it can be
done once when the fields are mapped.

Regards,
Jeroen



From MAILER-DAEMON Mon Feb 23 13:19:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvKfd-00081m-Rh
	for mharc-classpath@gnu.org; Mon, 23 Feb 2004 13:19:09 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvKfb-00081I-Br
	for classpath@gnu.org; Mon, 23 Feb 2004 13:19:07 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvKf4-0007dU-7K
	for classpath@gnu.org; Mon, 23 Feb 2004 13:19:06 -0500
Received: from [62.4.16.101] (helo=kraid.nerim.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvKf3-0007bE-Lm
	for classpath@gnu.org; Mon, 23 Feb 2004 13:18:33 -0500
Received: from kaffe.org (lavaux.net1.nerim.net [62.212.115.70])
	by kraid.nerim.net (Postfix) with ESMTP
	id 86ABE4131E; Mon, 23 Feb 2004 19:18:28 +0100 (CET)
Message-ID: <403A43F5.3010009@kaffe.org>
Date: Mon, 23 Feb 2004 19:18:29 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC04C9C5@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC04C9C5@LEMBU.sumatrasoftware.com>
X-Enigmail-Version: 0.82.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: Object serialization patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 18:19:07 -0000

Jeroen Frijters wrote:
> Hi, 
> 
> 
>>Here is a new patch I propose. I've taken the suggestion 
>>into account and fix another small error reporting problem.
> 
> 
> I don't understand checkTypeConsistency, it looks odd and I'm having a
> hard time believing that it is correct. BTW, Shouldn't "nonPrimitive" be
> named "primitive"?

The problem if you sort fields using 
ObjectStreamField.compareTo is that you separate names which 
are alphabetically sorted. I will explain this on the 
following example.

Imagine that in the stream you have the following field names:

int a;
int e;
String b;
String d;

They will be sorted as: a, e, b, d. (They will be written as 
a1, e1, b1, d1).

Now the class may declare the same field names but with 
different types:

int a;
String e;
String b;
String d;

And they will be sorted as: a, b, d, e. (They will be 
written as a2, b2, d2, e2).

Now we want to check that the types are consistent between 
the stream and the class. Previously we compared a1 with a2, 
b1 with b2, d1 with d2 and the code was generating two more 
extra fields: e1 and e2 (aka int e and String e). They 
represent the same field but with two different types which 
is wrong.

Now checkTypeConsistency compares two field pools. We 
extract the non primitive fields F1 from the first pool and 
the primitive fields F2 from the second pool. If we find a 
field which has the same name both in F1 and F2 there is an 
inconsistency.

This operation must be done both when the first pool is the 
"stream" fields and the second pool the "class" fields, and 
when the roles are reversed.

I think that 'nonPrimitive' is correctly named as the 
primitive fields came in first and we are looking for the 
non primitive fields.

> 
> Also, I really don't like the type checking being done in the various
> setXxxField methods, there is no reason to do this every time, it can be
> done once when the fields are mapped.

Yes, I'm also not completely satisfied with this method. But 
there exists cases where it is needed. For example, if 
serialPersistentFields declares class types wrongly. The 
types are not checked previously in that case and this 
results in an IllegalArgumentException (which is wrong). The 
solution would be to check the types of all fields when we 
are building the ObjectStreamClass from serialPersistentFields.


Regards,
Guilhem.




From MAILER-DAEMON Tue Feb 24 04:56:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvZIX-0006RD-RD
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 04:56:17 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvZIW-0006Qg-2p
	for classpath@gnu.org; Tue, 24 Feb 2004 04:56:16 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvZFY-0004tP-KA
	for classpath@gnu.org; Tue, 24 Feb 2004 04:53:46 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvZFX-0004gn-Fe
	for classpath@gnu.org; Tue, 24 Feb 2004 04:53:11 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 24 Feb 2004 10:52:57 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C9C9@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Object serialization patch
Thread-Index: AcP6OXGRbcekqTVOQLSN9CHA6XQaoAAgeZWw
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Guilhem Lavaux" <guilhem@kaffe.org>
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: RE: Object serialization patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 09:56:16 -0000

Guilhem Lavaux wrote:
> The problem if you sort fields using=20
> ObjectStreamField.compareTo is that you separate names which=20
> are alphabetically sorted. I will explain this on the=20
> following example.
[...explanation deleted...]

Thanks for explaining it! Now it makes sense and the patch looks good to
me.

> Yes, I'm also not completely satisfied with this method. But=20
> there exists cases where it is needed. For example, if=20
> serialPersistentFields declares class types wrongly. The=20
> types are not checked previously in that case and this=20
> results in an IllegalArgumentException (which is wrong). The=20
> solution would be to check the types of all fields when we=20
> are building the ObjectStreamClass from serialPersistentFields.

Yes, that would definitely be better. Looking at it again, I think that
the check in setObjectField might be wrong. I'm not sure, but there
might be class loader issues (two classes with the same name, but loaded
by a different class loader) and I think it is legal to change the type
of a field to a super class.

Regards,
Jeroen



From MAILER-DAEMON Tue Feb 24 11:05:31 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Avf3r-0002Hp-76
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 11:05:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Avf3o-0002Gy-DK
	for classpath@gnu.org; Tue, 24 Feb 2004 11:05:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Avf3I-00027U-86
	for classpath@gnu.org; Tue, 24 Feb 2004 11:05:27 -0500
Received: from [66.187.237.31] (helo=mx2.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Avf1J-0001lo-3o
	for classpath@gnu.org; Tue, 24 Feb 2004 11:02:53 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.11.6/8.11.6) with ESMTP id i1OFbji10973
	for <classpath@gnu.org>; Tue, 24 Feb 2004 10:37:45 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1OG2cM24016
	for <classpath@gnu.org>; Tue, 24 Feb 2004 11:02:38 -0500
Received: from escape (vpn26-5.sfbay.redhat.com [172.16.26.5])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i1OG2aX19298
	for <classpath@gnu.org>; Tue, 24 Feb 2004 08:02:36 -0800
From: Anthony Green <green@redhat.com>
To: classpath@gnu.org
Content-Type: text/plain
Organization: Red Hat, Inc.
Message-Id: <1077638553.3462.21.camel@escape>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 24 Feb 2004 08:02:33 -0800
Content-Transfer-Encoding: 7bit
Subject: Patch: remove redundant loop in StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 16:05:29 -0000

What do people think of this StringBuffer de-pessimization?


2004-02-24  Anthony Green  <green@redhat.com>

	* java/lang/StringBuffer.java: No need to NULL out remainder of
	buffer since ensureCapacity_unsynchronized will have done this for
	us.


Index: java/lang/StringBuffer.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/lang/StringBuffer.java,v
retrieving revision 1.25
diff -c -p -r1.25 StringBuffer.java
*** java/lang/StringBuffer.java	18 Oct 2003 08:45:37 -0000	1.25
--- java/lang/StringBuffer.java	24 Feb 2004 15:57:28 -0000
***************
*** 1,5 ****
  /* StringBuffer.java -- Growable strings
!    Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  This file is part of GNU Classpath.
  
--- 1,6 ----
  /* StringBuffer.java -- Growable strings
!    Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003, 2004
!    Free Software Foundation, Inc.
  
  This file is part of GNU Classpath.
  
*************** public final class StringBuffer implemen
*** 206,213 ****
        throw new StringIndexOutOfBoundsException(newLength);
  
      ensureCapacity_unsynchronized(newLength);
!     while (count < newLength)
!       value[count++] = '\0';
      count = newLength;
    }
  
--- 207,219 ----
        throw new StringIndexOutOfBoundsException(newLength);
  
      ensureCapacity_unsynchronized(newLength);
! 
!     /* If the StringBuffer just grew, then we know that value is newly
!        allocated and the region between count and newLength is filled
!        with '\0'.  If the StringBuffer just shrunk, we don't do
!        anything.  No part of StringBuffer depends on padding out the
!        rest of the StringBuffer with '\0'.  */
! 
      count = newLength;
    }
  

-- 
Anthony Green <green@redhat.com>
Red Hat, Inc.




From MAILER-DAEMON Tue Feb 24 11:38:43 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvfZz-0007Cl-Hy
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 11:38:43 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvfZv-0007BK-Mz
	for classpath@gnu.org; Tue, 24 Feb 2004 11:38:39 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvfZI-0006xs-JM
	for classpath@gnu.org; Tue, 24 Feb 2004 11:38:31 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1AvfZI-0006xd-2A
	for classpath@gnu.org; Tue, 24 Feb 2004 11:38:00 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1AvfQO-0001i3-VE
	for classpath@gnu.org; Tue, 24 Feb 2004 11:28:49 -0500
Received: from fleche.redhat.com (tf0208.peakpeak.com [204.144.239.208])
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id JAA08723
	for <classpath@gnu.org>; Tue, 24 Feb 2004 09:28:37 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 4A78F4F82AF; Tue, 24 Feb 2004 09:17:55 -0700 (MST)
To: Anthony Green <green@redhat.com>
References: <1077638553.3462.21.camel@escape>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: If a person is FAMOUS in this country, they have to go on the ROAD
	for MONTHS at a time and have their name misspelled on the SIDE
	of a GREYHOUND SCENICRUISER!!
Date: 24 Feb 2004 09:17:54 -0700
In-Reply-To: <1077638553.3462.21.camel@escape>
Message-ID: <87u11g78p9.fsf@fleche.redhat.com>
Lines: 17
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Patch: remove redundant loop in StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 16:38:41 -0000

>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:

Anthony> 2004-02-24  Anthony Green  <green@redhat.com>
Anthony> * java/lang/StringBuffer.java: No need to NULL out remainder of
Anthony> buffer since ensureCapacity_unsynchronized will have done this for
Anthony> us.

I think the loop is still needed for the case where you resize the
StringBuffer but the underlying array is not resized.  For instance,
you might fill in the buffer, shrink it, then regrow it.  In this
case, don't we need the newly visible slots to be \0 instead of
whatever appeared in them earlier?

It is an unusual situation though.  We could test for it and only zero
parts in the case where it is needed.

Tom



From MAILER-DAEMON Tue Feb 24 11:38:44 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Avfa0-0007D1-4c
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 11:38:44 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvfZw-0007Bp-TD
	for classpath@gnu.org; Tue, 24 Feb 2004 11:38:40 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvfZN-00070H-Iq
	for classpath@gnu.org; Tue, 24 Feb 2004 11:38:36 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1AvfZM-0006zy-Vj
	for classpath@gnu.org; Tue, 24 Feb 2004 11:38:05 -0500
Received: from [66.187.237.31] (helo=mx2.redhat.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1AvfTq-00024s-B3
	for classpath@gnu.org; Tue, 24 Feb 2004 11:32:22 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.11.6/8.11.6) with ESMTP id i1OG7Mi12349
	for <classpath@gnu.org>; Tue, 24 Feb 2004 11:07:22 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1OGWAM25100; 
	Tue, 24 Feb 2004 11:32:10 -0500
Received: from escape (vpn26-5.sfbay.redhat.com [172.16.26.5])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i1OGW9X20632; 
	Tue, 24 Feb 2004 08:32:09 -0800
From: Anthony Green <green@redhat.com>
To: Tom Tromey <tromey@redhat.com>
In-Reply-To: <87u11g78p9.fsf@fleche.redhat.com>
References: <1077638553.3462.21.camel@escape>
	<87u11g78p9.fsf@fleche.redhat.com>
Content-Type: text/plain
Organization: Red Hat, Inc.
Message-Id: <1077640328.3462.28.camel@escape>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 24 Feb 2004 08:32:09 -0800
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: Patch: remove redundant loop in StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 16:38:41 -0000

On Tue, 2004-02-24 at 08:17, Tom Tromey wrote:
> I think the loop is still needed for the case where you resize the
> StringBuffer but the underlying array is not resized.  For instance,
> you might fill in the buffer, shrink it, then regrow it.  In this
> case, don't we need the newly visible slots to be \0 instead of
> whatever appeared in them earlier?

No, I don't think so.  That's what I meant in my comment by "No part of
StringBuffer depends on padding out the rest of the StringBuffer with
'\0'".  I looked through the code and couldn't find where this would
matter.

AG

-- 
Anthony Green <green@redhat.com>
Red Hat, Inc.




From MAILER-DAEMON Tue Feb 24 11:39:20 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Avfaa-0007SN-49
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 11:39:20 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvfaQ-0007OI-EZ
	for classpath@gnu.org; Tue, 24 Feb 2004 11:39:10 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvfZr-00079H-Ro
	for classpath@gnu.org; Tue, 24 Feb 2004 11:39:08 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvfXj-0006Hr-Pq
	for classpath@gnu.org; Tue, 24 Feb 2004 11:36:23 -0500
Received: from fleche.redhat.com (tf0208.peakpeak.com [204.144.239.208])
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id JAA11355
	for <classpath@gnu.org>; Tue, 24 Feb 2004 09:36:07 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 7DD934F82AF; Tue, 24 Feb 2004 09:25:25 -0700 (MST)
To: Anthony Green <green@redhat.com>
References: <1077638553.3462.21.camel@escape>
	<87u11g78p9.fsf@fleche.redhat.com> <1077640328.3462.28.camel@escape>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I always have fun because I'm out of my mind!!!
Date: 24 Feb 2004 09:25:25 -0700
In-Reply-To: <1077640328.3462.28.camel@escape>
Message-ID: <87n07878cq.fsf@fleche.redhat.com>
Lines: 18
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Patch: remove redundant loop in StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 16:39:16 -0000

>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:

Anthony> No, I don't think so.  That's what I meant in my comment by
Anthony> "No part of StringBuffer depends on padding out the rest of
Anthony> the StringBuffer with '\0'".  I looked through the code and
Anthony> couldn't find where this would matter.

Suppose you do:

sb = new StringBuffer ("abcdefgh");
sb.setLength(1);
sb.setLength(3);
sb.toString();

I think the result should be "a\0\0", not "abc".  This is why the loop
matters.

Tom



From MAILER-DAEMON Tue Feb 24 13:49:29 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvhcW-00061N-Er
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 13:49:28 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvhcR-0005ya-8L
	for classpath@gnu.org; Tue, 24 Feb 2004 13:49:23 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Avhbu-0005l8-3e
	for classpath@gnu.org; Tue, 24 Feb 2004 13:49:21 -0500
Received: from [62.4.16.102] (helo=kraid.nerim.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvgZJ-0002Sr-Tp
	for classpath@gnu.org; Tue, 24 Feb 2004 12:42:06 -0500
Received: from kaffe.org (lavaux.net1.nerim.net [62.212.115.70])
	by kraid.nerim.net (Postfix) with ESMTP
	id 3D8F441984; Tue, 24 Feb 2004 18:41:59 +0100 (CET)
Message-ID: <403B8CE8.5050406@kaffe.org>
Date: Tue, 24 Feb 2004 18:42:00 +0100
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC04C9C9@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC04C9C9@LEMBU.sumatrasoftware.com>
X-Enigmail-Version: 0.82.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed; boundary="------------080700060509040200070708"
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: Re: Object serialization patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 18:49:25 -0000

This is a multi-part message in MIME format.
--------------080700060509040200070708
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Jeroen Frijters wrote:
> Guilhem Lavaux wrote:
> 
>>Yes, I'm also not completely satisfied with this method. But 
>>there exists cases where it is needed. For example, if 
>>serialPersistentFields declares class types wrongly. The 
>>types are not checked previously in that case and this 
>>results in an IllegalArgumentException (which is wrong). The 
>>solution would be to check the types of all fields when we 
>>are building the ObjectStreamClass from serialPersistentFields.
> 
> 
> Yes, that would definitely be better. Looking at it again, I think that
> the check in setObjectField might be wrong. I'm not sure, but there
> might be class loader issues (two classes with the same name, but loaded
> by a different class loader) and I think it is legal to change the type
> of a field to a super class.
> 

In that case I'm proposing this patch. I have replaced the 
type checks in setXXXField by a type check in 
ObjectStreamClass.setClass by invoking a new method 
ObjectStreamField.checkFieldType. Here I'm only checking 
that the field is really assignable with a value which would 
have the type given in the serialPersistentFields list.

BTW, I've found that there was another error in fields 
sorting in setClass() this is now replaced by the good one.

Regards,
Guilhem.


--------------080700060509040200070708
Content-Type: text/plain;
 name="obj_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="obj_patch"

Index: java/io/ObjectInputStream.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectInputStream.java,v
retrieving revision 1.38
diff -u -b -B -r1.38 ObjectInputStream.java
--- java/io/ObjectInputStream.java	10 Feb 2004 07:28:09 -0000	1.38
+++ java/io/ObjectInputStream.java	24 Feb 2004 17:15:57 -0000
@@ -412,6 +412,65 @@
   }
 
   /**
+   * This method makes a partial check of types for the fields
+   * contained given in arguments. It checks primitive types of
+   * fields1 against non primitive types of fields2. This method 
+   * assumes the two lists has already been sorted according to 
+   * the Java specification.
+   *
+   * @param name Name of the class owning the given fields.
+   * @param fields1 First list to check.
+   * @param fields2 Second list to check.
+   * @throws InvalidClassException if a field in fields1, which has a primitive type, is a present
+   * in the non primitive part in fields2.
+   */
+  private void checkTypeConsistency(String name, ObjectStreamField[] fields1, ObjectStreamField[] fields2)
+    throws InvalidClassException
+  {
+    int nonPrimitive = 0;
+    
+    for (nonPrimitive = 0; 
+	 nonPrimitive < fields1.length
+	   && fields1[nonPrimitive].isPrimitive(); nonPrimitive++)
+      {
+      }
+
+    if (nonPrimitive == fields1.length)
+      return;
+    
+    int i = 0;
+    ObjectStreamField f1;
+    ObjectStreamField f2;
+    
+    while (i < fields2.length
+	   && nonPrimitive < fields1.length)
+      {
+	f1 = fields1[nonPrimitive];
+	f2 = fields2[i];
+	
+	if (!f2.isPrimitive())
+	  break;
+
+	int compVal = f1.getName().compareTo (f2.getName());
+
+	if (compVal < 0)
+	  {
+	    nonPrimitive++;
+	  }
+	else if (compVal > 0)
+	  {
+	    i++;
+	  }
+	else
+	  {
+	    throw new InvalidClassException
+	      ("invalid field type for " + f2.getName() +
+	       " in class " + name);
+	  }
+      }
+  }
+
+  /**
    * This method reads a class descriptor from the real input stream
    * and use these data to create a new instance of ObjectStreamClass.
    * Fields are sorted and ordered for the real read which occurs for
@@ -496,6 +555,15 @@
     int real_idx = 0;
     int map_idx = 0;
 
+    /*
+     * Check that there is no type inconsistencies between the lists.
+     * A special checking must be done for the two groups: primitive types and
+     * not primitive types. 
+     */
+    checkTypeConsistency(name, real_fields, stream_fields);
+    checkTypeConsistency(name, stream_fields, real_fields);
+
+    
     while (stream_idx < stream_fields.length
 	   || real_idx < real_fields.length)
       {
@@ -527,21 +595,13 @@
 	      {
 		stream_field = stream_fields[stream_idx++];
 		real_field = real_fields[real_idx++];
-		if(stream_field.getType() != real_field.getType())
+		if (stream_field.getType() != real_field.getType())
 		    throw new InvalidClassException
 			("invalid field type for " + real_field.getName() +
 			" in class " + name);
 	      }
 	  }
-	if (stream_field != null)
-	  {
-	    if (stream_field.getOffset() < 0)
-		stream_field = null;
-	    else if (!stream_field.isToSet())
-		real_field = null;
-	  }
-	if (real_field != null && !real_field.isToSet())
-	    real_field = null;
+
 	/* If some of stream_fields does not correspond to any of real_fields,
 	 * or the opposite, then fieldmapping will go short.
 	 */
@@ -1576,12 +1636,11 @@
       {
 	ObjectStreamField stream_field = fields[i];
 	ObjectStreamField real_field = fields[i + 1];
-	if(stream_field != null || real_field != null)
-	  {
-	    boolean read_value = stream_field != null;
-	    boolean set_value = real_field != null;
+	boolean read_value = (stream_field != null && stream_field.getOffset() >= 0 && stream_field.isToSet());
+	boolean set_value = (real_field != null && real_field.isToSet());
 	    String field_name;
 	    char type;
+
 	    if (stream_field != null)
 	      {
 		field_name = stream_field.getName();
@@ -1689,7 +1748,6 @@
 	      }
 	  }
       }
-  }
 
   // Toggles writing primitive data to block-data buffer.
   private boolean setBlockDataMode (boolean on)
Index: java/io/ObjectStreamClass.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectStreamClass.java,v
retrieving revision 1.30
diff -u -b -B -r1.30 ObjectStreamClass.java
--- java/io/ObjectStreamClass.java	2 Feb 2004 10:26:51 -0000	1.30
+++ java/io/ObjectStreamClass.java	24 Feb 2004 17:15:57 -0000
@@ -327,7 +327,7 @@
 	i = 0; j = 0; k = 0;
 	while (i < fields.length && j < exportedFields.length)
 	  {
-	    int comp = fields[i].getName().compareTo(exportedFields[j].getName());
+	    int comp = fields[i].compareTo(exportedFields[j]);
 
 	    if (comp < 0)
 	      {
@@ -344,10 +344,27 @@
 		newFieldList[k] = exportedFields[j];
 		newFieldList[k].setPersistent(true);
 		newFieldList[k].setToSet(false);
+		try
+		  {
+		    newFieldList[k].lookupField(clazz);
+		    newFieldList[k].checkFieldType();
+		  }
+		catch (NoSuchFieldException _)
+		  {
+		  }
 		j++;
 	      }
 	    else
 	      {
+		try
+		  {
+		    exportedFields[j].lookupField(clazz);
+		    exportedFields[j].checkFieldType();
+		  }
+		catch (NoSuchFieldException _)
+		  {
+		  }
+
 		if (!fields[i].getType().equals(exportedFields[j].getType()))
 		  throw new InvalidClassException
 		    ("serialPersistentFields must be compatible with" +
@@ -554,6 +571,19 @@
 	    if (fields != null)
 	      {
 		Arrays.sort (fields);
+		// Retrieve field reference.
+		for (int i=0; i < fields.length; i++)
+		  {
+		    try
+		      {
+			fields[i].lookupField(cl);
+		      }
+		    catch (NoSuchFieldException _)
+		      {
+			fields[i].setToSet(false);
+		      }
+		  }
+		
 		calculateOffsets();
 		return;
 	      }
Index: java/io/ObjectStreamField.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectStreamField.java,v
retrieving revision 1.13
diff -u -b -B -r1.13 ObjectStreamField.java
--- java/io/ObjectStreamField.java	2 Feb 2004 10:26:51 -0000	1.13
+++ java/io/ObjectStreamField.java	24 Feb 2004 17:15:57 -0000
@@ -41,6 +41,8 @@
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
 import gnu.java.lang.reflect.TypeSignature;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
 
 /**
  * This class intends to describe the field of a class for the serialization
@@ -99,7 +101,7 @@
  
   /**
    * There are many cases you can not get java.lang.Class from typename 
-   * if your context class loader cann not load it, then use typename to
+   * if your context class loader cannot load it, then use typename to
    * construct the field.
    *
    * @param name Name of the field to export.
@@ -292,7 +294,7 @@
   }
 
   /**
-   * This methods returns true if the field is marked as to be
+   * This method returns true if the field is marked as to be
    * set.
    *
    * @return True if it is to be set, false in the other cases.
@@ -303,6 +305,49 @@
     return toset;
   }
 
+  /**
+   * This method searches for its field reference in the specified class
+   * object. It requests privileges. If an error occurs the internal field
+   * reference is not modified.
+   *
+   * @throws NoSuchFieldException if the field name does not exist in this class.
+   * @throws SecurityException if there was an error requesting the privileges.
+   */
+  void lookupField(Class clazz) throws NoSuchFieldException, SecurityException
+  {
+    final Field f = clazz.getDeclaredField(name);
+    
+    AccessController.doPrivileged(new PrivilegedAction()
+      {
+	public Object run()
+	{
+	  f.setAccessible(true);
+	  return null;
+	}
+      });
+    
+    this.field = f;
+  }
+
+  /**
+   * This method check whether the field described by this
+   * instance of ObjectStreamField is compatible with the
+   * actual implementation of this field.
+   *
+   * @throws NullPointerException if this field does not exist
+   * in the real class.
+   * @throws InvalidClassException if the types are incompatible.
+   */
+  void checkFieldType() throws InvalidClassException
+  {
+    Class ftype = field.getType();
+
+    if (!ftype.isAssignableFrom(type))
+      throw new InvalidClassException
+	("invalid field type for " + name +
+	 " in class " + field.getDeclaringClass());
+  }
+
   public String toString ()
   {
     return "ObjectStreamField< " + type + " " + name + " >";

--------------080700060509040200070708--




From MAILER-DAEMON Tue Feb 24 14:28:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvgOW-0007rG-3l
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 12:30:56 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvgMe-0007Cv-FU
	for classpath@gnu.org; Tue, 24 Feb 2004 12:29:00 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvgM3-0006yD-AT
	for classpath@gnu.org; Tue, 24 Feb 2004 12:28:55 -0500
Received: from [66.187.237.31] (helo=mx2.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvgJv-0006NP-GG
	for classpath@gnu.org; Tue, 24 Feb 2004 12:26:11 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.11.6/8.11.6) with ESMTP id i1OH1Ei14442
	for <classpath@gnu.org>; Tue, 24 Feb 2004 12:01:14 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i1OHQ7M26777; 
	Tue, 24 Feb 2004 12:26:07 -0500
Received: from escape (vpn26-5.sfbay.redhat.com [172.16.26.5])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i1OHQ6X22743; 
	Tue, 24 Feb 2004 09:26:06 -0800
From: Anthony Green <green@redhat.com>
To: Tom Tromey <tromey@redhat.com>
In-Reply-To: <87n07878cq.fsf@fleche.redhat.com>
References: <1077638553.3462.21.camel@escape>
	<87u11g78p9.fsf@fleche.redhat.com> <1077640328.3462.28.camel@escape>
	<87n07878cq.fsf@fleche.redhat.com>
Content-Type: text/plain
Organization: Red Hat, Inc.
Message-Id: <1077643565.3462.32.camel@escape>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 24 Feb 2004 09:26:06 -0800
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: Patch: remove redundant loop in StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 17:30:54 -0000

On Tue, 2004-02-24 at 08:25, Tom Tromey wrote:
> Suppose you do:

Oh, right - because we're growing the string, and not just the
underlying array.

Ok - here's a revised patch that eliminates the redundant loop in the
most common case.


2004-02-24  Anthony Green  <green@redhat.com>

	* java/lang/StringBuffer.java: No need to NULL out remainder of
	buffer since ensureCapacity_unsynchronized will have done this for
	us.


Index: java/lang/StringBuffer.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/lang/StringBuffer.java,v
retrieving revision 1.25
diff -c -p -r1.25 StringBuffer.java
*** java/lang/StringBuffer.java	18 Oct 2003 08:45:37 -0000	1.25
--- java/lang/StringBuffer.java	24 Feb 2004 17:20:43 -0000
***************
*** 1,5 ****
  /* StringBuffer.java -- Growable strings
!    Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
  
  This file is part of GNU Classpath.
  
--- 1,6 ----
  /* StringBuffer.java -- Growable strings
!    Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003, 2004
!    Free Software Foundation, Inc.
  
  This file is part of GNU Classpath.
  
*************** public final class StringBuffer implemen
*** 205,214 ****
      if (newLength < 0)
        throw new StringIndexOutOfBoundsException(newLength);
  
      ensureCapacity_unsynchronized(newLength);
!     while (count < newLength)
!       value[count++] = '\0';
!     count = newLength;
    }
  
    /**
--- 206,231 ----
      if (newLength < 0)
        throw new StringIndexOutOfBoundsException(newLength);
  
+     int valueLength = value.length;
+ 
+     /* Always call ensureCapacity_unsynchronized in order to preserve
+        copy-on-write semantics.  */
      ensureCapacity_unsynchronized(newLength);
! 
!     if (newLength < valueLength)
!       {
!         /* If the StringBuffer's value just grew, then we know that
!            value is newly allocated and the region between count and
!            newLength is filled with '\0'.  */
! 	count = newLength;
!       }
!     else
!       {
! 	/* The StringBuffer's value didn't grow.  However,
! 	   we should clear out any cruft that may exist.  */
! 	while (count < newLength)
!           value[count++] = '\0';
!       }
    }
  
    /**


-- 
Anthony Green <green@redhat.com>
Red Hat, Inc.




From MAILER-DAEMON Tue Feb 24 17:10:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvklX-000670-Nz
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 17:10:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvPLz-0006n0-Cc
	for classpath@gnu.org; Mon, 23 Feb 2004 18:19:11 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvPEN-0003DY-Jn
	for classpath@gnu.org; Mon, 23 Feb 2004 18:11:52 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1AvPBO-0008W9-Mq; Mon, 23 Feb 2004 18:08:14 -0500
Received: from [64.243.24.210] (helo=mail.savaJe.com)
	by mx20.gnu.org with esmtp (Exim 4.30)
	id 1AvPBJ-0004Er-PT; Mon, 23 Feb 2004 18:08:09 -0500
Received: from localhost.localdomain (fearless [127.0.0.1])
	by mail.savaJe.com (8.12.10/8.12.10) with ESMTP id i1NN86PT020140;
	Mon, 23 Feb 2004 18:08:06 -0500
From: Michael Emmel <memmel@savaJe.com>
To: gnu@gnu.org, classpath@gnu.org, Onno.Kluyt@Sun.COM
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Ximian Evolution 1.0.8 (1.0.8-10) 
Date: 23 Feb 2004 17:18:11 -0500
Message-Id: <1077574692.1409.201.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailman-Approved-At: Tue, 24 Feb 2004 17:10:57 -0500
Cc: 
Subject: SCSL and FSF
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2004 23:20:19 -0000


Sun has offered to clarify the SCSL license and its effect on projects
such and Gnu Classpath.


This happened in the following discussion thread

http://www.javalobby.org/thread.jspa?messageID=91789909&threadID=11559&forumID=61

I'll also send this to the classpath mailing list.







From MAILER-DAEMON Tue Feb 24 17:27:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Avl14-0002Pw-PY
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 17:27:02 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Avl0Y-0001kQ-3z
	for classpath@gnu.org; Tue, 24 Feb 2004 17:26:30 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Avkzd-0000Sp-F9
	for classpath@gnu.org; Tue, 24 Feb 2004 17:26:05 -0500
Received: from [207.174.178.17] (helo=gash2.peakpeak.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Avkye-0007R9-Nz
	for classpath@gnu.org; Tue, 24 Feb 2004 17:24:33 -0500
Received: from fleche.redhat.com (tf0208.peakpeak.com [204.144.239.208])
	by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id PAA14115
	for <classpath@gnu.org>; Tue, 24 Feb 2004 15:23:27 -0700
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 8B27E4F82AF; Tue, 24 Feb 2004 15:12:44 -0700 (MST)
To: Anthony Green <green@redhat.com>
References: <1077638553.3462.21.camel@escape>
	<87u11g78p9.fsf@fleche.redhat.com> <1077640328.3462.28.camel@escape>
	<87n07878cq.fsf@fleche.redhat.com> <1077643565.3462.32.camel@escape>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I feel like I'm in a Toilet Bowl with a thumbtack in my forehead!!
Date: 24 Feb 2004 15:12:44 -0700
In-Reply-To: <1077643565.3462.32.camel@escape>
Message-ID: <87eksk3z4z.fsf@fleche.redhat.com>
Lines: 6
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Patch: remove redundant loop in StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 22:26:51 -0000

Anthony> Ok - here's a revised patch that eliminates the redundant loop in the
Anthony> most common case.

Yeah, that looks good to me.  Thanks.

Tom



From MAILER-DAEMON Tue Feb 24 18:51:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvmK3-0005dA-4Y
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 18:50:43 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvmHO-0003DF-UD
	for classpath@gnu.org; Tue, 24 Feb 2004 18:47:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvmGf-0002VD-RP
	for classpath@gnu.org; Tue, 24 Feb 2004 18:47:16 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1AvmFK-0001ce-Qz; Tue, 24 Feb 2004 18:45:51 -0500
Received: from slauerhoff.wildebeest.org ([192.168.1.27] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AvmF1-0006yz-00; Wed, 25 Feb 2004 00:45:31 +0100
From: Mark Wielaard <mark@klomp.org>
To: Michael Emmel <memmel@savaJe.com>
In-Reply-To: <1077574692.1409.201.camel@localhost.localdomain>
References: <1077574692.1409.201.camel@localhost.localdomain>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-1/GTZe1wLHd23eLD13KJ"
Message-Id: <1077666338.880.38.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Wed, 25 Feb 2004 00:45:38 +0100
Cc: Onno.Kluyt@Sun.COM, gnu@gnu.org, classpath@gnu.org
Subject: Re: SCSL and FSF
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2004 23:50:40 -0000


--=-1/GTZe1wLHd23eLD13KJ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2004-02-23 at 23:18, Michael Emmel wrote:
> Sun has offered to clarify the SCSL license and its effect on projects
> such and Gnu Classpath.
>
> This happened in the following discussion thread
>=20
> http://www.javalobby.org/thread.jspa?messageID=3D91789909&threadID=3D1155=
9&forumID=3D61

Thanks for forwarding this.
Good to see so much enthousiasm about our FOSDEM meeting. It really does
feel like we have enough critical mass now. There is now enough free
code for the libraries, VMs and compilers to do useful things. And
people are now actually using it to creating completely free
applications. So we will see lots of interesting things for the free
platforms in the near future.

I'll try to formulate the concerns of the Free Software projects about
the SCSL, contributions of people who have studied other implementations
of the core classes that want to help the free projects (contributions
which we currently cannot accept since legal counsel has advised against
that) and the way we think the JCP process and the TCK
licensing/distribution terms are unhelpful now for collaboration on Free
Software implementations.

Please give me a couple of days to contact the right people. And to make
sure we formulate our questions and concerns coherently. I want to avoid
an ESR style letter which I think is not helpful. Hopefully we can start
a dialog that helps both the people that care about the Free Software
movement and people that care about standardization of jave-like
platforms. I'll make sure to contact Onno with some specific issues in
the next two weeks

Sincerely,

Mark Wielaard
GNU Classpath Maintainer

--=-1/GTZe1wLHd23eLD13KJ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAO+IhxVhZCJWr9QwRAlhsAJ9bEDdIEOeqmEVo6mdCuOzIAzIZPgCePILj
KQeoji4wSCaALceHnKoj93o=
=mrix
-----END PGP SIGNATURE-----

--=-1/GTZe1wLHd23eLD13KJ--




From MAILER-DAEMON Tue Feb 24 19:25:20 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvmpV-0000IX-Sb
	for mharc-classpath@gnu.org; Tue, 24 Feb 2004 19:23:13 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Avmoc-0008BO-Eh
	for classpath@gnu.org; Tue, 24 Feb 2004 19:22:18 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Avmmz-0006rp-OR
	for classpath@gnu.org; Tue, 24 Feb 2004 19:20:42 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Avmmy-0006qi-Fk
	for classpath@gnu.org; Tue, 24 Feb 2004 19:20:36 -0500
Received: from slauerhoff.wildebeest.org ([192.168.1.27] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1Avmmn-00074Q-00
	for <classpath@gnu.org>; Wed, 25 Feb 2004 01:20:25 +0100
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <1077666338.880.38.camel@localhost>
References: <1077574692.1409.201.camel@localhost.localdomain>
	<1077666338.880.38.camel@localhost>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-kLQAOHqOBFXQcWJmdpJa"
Message-Id: <1077668432.877.57.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Wed, 25 Feb 2004 01:20:32 +0100
Subject: Re: SCSL and FSF
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2004 00:23:11 -0000


--=-kLQAOHqOBFXQcWJmdpJa
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi all,

On Wed, 2004-02-25 at 00:45, Mark Wielaard wrote:
> Please give me a couple of days to contact the right people. And to make
> sure we formulate our questions and concerns coherently. I want to avoid
> an ESR style letter which I think is not helpful. Hopefully we can start
> a dialog that helps both the people that care about the Free Software
> movement and people that care about standardization of jave-like
> platforms. I'll make sure to contact Onno with some specific issues in
> the next two weeks

Tom Tromey already made some excellent points in a comment on that
javalobby article:
http://www.javalobby.org/thread.jspa?messageID=3D91790015&threadID=3D11559&=
forumID=3D61
The one thing that I want to add is that it would be nice to have a
formal statement from Sun that they will not sue a project for studying
their code and implementing something compatible. (This is the biggest
complaint we get from people that want to help us, but that we currently
turn down because we want to have a really clear clean-room policy.)

The reason I said it would take some time (even though we do know pretty
well what we want to ask clarification on) is that I want to run the
request/letter through FSF legal and point to specific JCP
agreements/clauses and/or click-through licenses that people have to
accept. That way we will hopefully get a much more specific reply. I did
already discuss JCP issues with RMS and some other people a few weeks
ago so we can hopefully come up with some really specific questions
pretty quickly.

Besides that I need some sleep now and won't have any classpath time
tomorrow. But I'll make sure to start the real discussion on Thursday
when I will have time to more coherently formulate our concerns. Please
let me know of any specifics that you think are important/relevant for
this discussion with Sun.

Cheers,

Mark

--=-kLQAOHqOBFXQcWJmdpJa
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAO+pQxVhZCJWr9QwRApxfAJ93AR0F5SrQSG47eOpuUs/RYLjUjQCeI0az
oiUrHl7so7RYArulq9RULys=
=SyMS
-----END PGP SIGNATURE-----

--=-kLQAOHqOBFXQcWJmdpJa--




From MAILER-DAEMON Wed Feb 25 03:34:32 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvuUx-0007n6-Hw
	for mharc-classpath@gnu.org; Wed, 25 Feb 2004 03:34:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvuUt-0007kg-CP
	for classpath@gnu.org; Wed, 25 Feb 2004 03:34:27 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvuUL-0007We-VX
	for classpath@gnu.org; Wed, 25 Feb 2004 03:34:25 -0500
Received: from [80.91.224.249] (helo=main.gmane.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvuRI-0006xV-8E
	for classpath@gnu.org; Wed, 25 Feb 2004 03:30:44 -0500
Received: from root by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1AvuRC-0008Nq-00
	for <classpath@gnu.org>; Wed, 25 Feb 2004 09:30:38 +0100
Received: from pd9e1f65b.dip.t-dialin.net ([217.225.246.91])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00 for <classpath@gnu.org>; Wed Feb 25 08:30:38 2004
Received: from jens.lehmann by pd9e1f65b.dip.t-dialin.net with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <classpath@gnu.org>; Wed Feb 25 08:30:38 2004
X-Injected-Via-Gmane: http://gmane.org/
To: classpath@gnu.org
From: Jens Lehmann <jens.lehmann@goldmail.de>
Date: Wed, 25 Feb 2004 09:29:41 +0100
Lines: 29
Message-ID: <c1hmd8$o9b$1@sea.gmane.org>
References: <515920885.1077101171@[10.40.10.54]>
	<87smh7ncc9.fsf@fleche.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Complaints-To: usenet@sea.gmane.org
X-Gmane-NNTP-Posting-Host: pd9e1f65b.dip.t-dialin.net
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.5) Gecko/20031107 Debian/1.5-3
X-Accept-Language: de-de, en-us, en
In-Reply-To: <87smh7ncc9.fsf@fleche.redhat.com>
Sender: news <news@sea.gmane.org>
Subject: Re: [Article] Sun Fires Back over Open Source Java Accusations
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2004 08:34:29 -0000

Tom Tromey wrote:
>>>>>>"Patrik" == Patrik Reali <reali@acm.org> writes:
> 
> 
> Patrik> OSNews has some discussion on Sun's answer to ESR request to make Java
> Patrik> open source.
> Patrik> <http://www.osnews.com/comment.php?news_id=6053>
> 
> IMO, while it would be helpful if Sun opened their source, we don't
> really need it.
> 
> What we do need is 3 things:
> 
> 1. Access to the TCK on acceptable terms,

A Sun member recently said to me: "We can't make the tests free because 
they are labor intensive but we *DID* endow a number of grants top cover 
the costs of such tests for important open source projects.  If someone 
has a good open source VM implementation and all they were missing was 
the funding to get it tested so it could be called Java, then they 
should approach Sun with it and I would be willing to bet a weeks salary 
something could be worked out."

This means that, if any of the free VMs believes it is 1.x compatible, 
it would be worth a try to contact Sun and ask politely what they can 
do. Having a certified Java implementation would be a huge step forward.

Jens





From MAILER-DAEMON Wed Feb 25 06:08:17 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Avwtk-0001zT-Sa
	for mharc-classpath@gnu.org; Wed, 25 Feb 2004 06:08:16 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Avwti-0001wZ-5V
	for classpath@gnu.org; Wed, 25 Feb 2004 06:08:14 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Avws5-00016e-Jh
	for classpath@gnu.org; Wed, 25 Feb 2004 06:07:05 -0500
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Avws4-00014z-OB
	for classpath@gnu.org; Wed, 25 Feb 2004 06:06:32 -0500
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 25 Feb 2004 12:06:24 +0100
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC04C9F0@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Object serialization patch
Thread-Index: AcP7D20lg2sE5hRPQh+FOUM2CI/WCAAf7cEQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Guilhem Lavaux" <guilhem@kaffe.org>
Cc: classpath@gnu.org, java-patches@gcc.gnu.org
Subject: RE: Object serialization patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2004 11:08:15 -0000

Guilhem Lavaux wrote:
> In that case I'm proposing this patch. I have replaced the=20
> type checks in setXXXField by a type check in=20
> ObjectStreamClass.setClass by invoking a new method=20
> ObjectStreamField.checkFieldType. Here I'm only checking=20
> that the field is really assignable with a value which would=20
> have the type given in the serialPersistentFields list.
>=20
> BTW, I've found that there was another error in fields=20
> sorting in setClass() this is now replaced by the good one.

Thanks. Patch looks good to me.

Regards,
Jeroen



From MAILER-DAEMON Wed Feb 25 06:26:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AvxB7-0003k8-RT
	for mharc-classpath@gnu.org; Wed, 25 Feb 2004 06:26:13 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AvxAz-0003iA-Bf
	for classpath@gnu.org; Wed, 25 Feb 2004 06:26:05 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AvxAP-0003Xl-EY
	for classpath@gnu.org; Wed, 25 Feb 2004 06:26:00 -0500
Received: from [217.8.192.21] (helo=interway.li)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvxA6-0003Qj-UO
	for classpath@gnu.org; Wed, 25 Feb 2004 06:25:11 -0500
Received: from [217.8.199.82] (HELO [192.168.1.33])
	by interway.li (CommuniGate Pro SMTP 4.1.8)
	with ESMTP id 897445; Wed, 25 Feb 2004 12:25:10 +0100
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Wed, 25 Feb 2004 12:25:04 +0100
Message-Id: <20040225112504.11198@smtp.mail.ch.easynet.net>
In-Reply-To: <1077550600.1105.91.camel@localhost>
References: <1077550600.1105.91.camel@localhost>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Raphael Bauduin <rb@raphinou.com>, info@fosdem.org, avdyk@debian.org
Subject: FOSDEM slides
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2004 11:26:11 -0000

>If other presentations are also online, please post them to the list.

--------------------------------
Java Security: How Free Software Is Secured Using the Java Language

After a general introduction to why Java seems a reasonable choice for
writing large and robust free software packages, the talk discusses the
security features of the Java platform. It is shown how several actors
play together to ensure type safety, encapsulation and declarative access
control. Four concrete denial-of-service attacks illustrate the
importance of enhancing the platform by techniques for managing resource
consumption.

http://www.dandelis.ch/people/brawer/articles/classpathSecurity/
--------------------------------

As Mark said on this list, one of the talks in the FOSDEM security track
couldn't be given, which was an unexpected opportunity to present Java
security (and the existence of free Java implementations) to a broader
audience. Because there was so little time for preparation, we had to
mangle the general presentation into something that might be of interest
to a security audience. IMHO, this just-in-time squeezing has left some
visible scratches and rough edges, but the audience didn't seem to
complain. Some people even came and asked how they could help Classpath.

Thanks heaps to Chris, Dalibor, Mark and everyone else who helped with
last-minute comments, late-night hacking, etc.

Best regards,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Wed Feb 25 11:56:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Aw2In-0006IU-6g
	for mharc-classpath@gnu.org; Wed, 25 Feb 2004 11:54:29 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Aw2HB-0005Y9-Nv
	for classpath@gnu.org; Wed, 25 Feb 2004 11:52:49 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Aw2GT-0005Ih-EE
	for classpath@gnu.org; Wed, 25 Feb 2004 11:52:37 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1Aw2GT-0005IC-0C
	for classpath@gnu.org; Wed, 25 Feb 2004 11:52:05 -0500
Received: from [209.225.28.214] (helo=mxsf14.cluster1.charter.net)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1Aw2CE-0001lr-Go
	for classpath@gnu.org; Wed, 25 Feb 2004 11:47:42 -0500
Received: from InterJet.dellroad.org (E6V6Q8.cpe.mvllo.al.charter.com
	[24.196.29.251])
	by mxsf14.cluster1.charter.net (8.12.10/8.12.8) with ESMTP id
	i1PGj375084254
	for <classpath@gnu.org>; Wed, 25 Feb 2004 11:45:06 -0500 (EST)
	(envelope-from archie@dellroad.org)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id JAA40962
	for <classpath@gnu.org>; Wed, 25 Feb 2004 09:30:46 -0600 (CST)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i1PFUj19002504
	for <classpath@gnu.org>; Wed, 25 Feb 2004 09:30:45 -0600 (CST)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i1PFUjYQ002495
	for classpath@gnu.org; Wed, 25 Feb 2004 09:30:45 -0600 (CST)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200402251530.i1PFUjYQ002495@arch20m.dellroad.org>
To: classpath@gnu.org
Date: Wed, 25 Feb 2004 09:30:44 -0600 (CST)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Subject: Current Mauve status
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2004 16:54:24 -0000

Hi,

I'm trying to resolve some Mauve test failures with a new JVM (JC)
and am wondering which failures are "expected" (i.e., known bugs
in Classpath) and which are specific to this JVM. Unfortunately the
"Mauve status" section of the website is down.

Does anyone have the output of a "normal" Mauve test run handy that
they could email me for comparison?

Thanks!
-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Wed Feb 25 12:17:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Aw2XR-00053u-Lw
	for mharc-classpath@gnu.org; Wed, 25 Feb 2004 12:09:37 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Aw2XK-0004sm-Dl
	for classpath@gnu.org; Wed, 25 Feb 2004 12:09:30 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Aw2WK-0003vr-WD
	for classpath@gnu.org; Wed, 25 Feb 2004 12:09:00 -0500
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1Aw2Uv-00033Z-Fc
	for classpath@gnu.org; Wed, 25 Feb 2004 12:07:01 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-95-226.ewetel.net
	[80.228.95.226])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i1PH6rfq027789;
	Wed, 25 Feb 2004 18:06:54 +0100 (MET)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1Aw2Un-0004wl-00; Wed, 25 Feb 2004 18:06:53 +0100
From: Michael Koch <konqueror@gmx.de>
To: Archie Cobbs <archie@dellroad.org>, classpath@gnu.org
Date: Wed, 25 Feb 2004 18:10:58 +0100
User-Agent: KMail/1.5.4
References: <200402251530.i1PFUjYQ002495@arch20m.dellroad.org>
In-Reply-To: <200402251530.i1PFUjYQ002495@arch20m.dellroad.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200402251810.58601.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: Current Mauve status
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Feb 2004 17:09:33 -0000

Am Mittwoch, 25. Februar 2004 16:30 schrieb Archie Cobbs:
> Hi,
>
> I'm trying to resolve some Mauve test failures with a new JVM (JC)
> and am wondering which failures are "expected" (i.e., known bugs
> in Classpath) and which are specific to this JVM. Unfortunately the
> "Mauve status" section of the website is down.
>
> Does anyone have the output of a "normal" Mauve test run handy that
> they could email me for comparison?

I could send you a full mauve run for libgcj but some things are know to 
be different to classpath. Interested ?


Michael




From MAILER-DAEMON Fri Feb 27 00:50:40 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AwatU-0002z5-KJ
	for mharc-classpath@gnu.org; Fri, 27 Feb 2004 00:50:40 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AwatS-0002ys-H3
	for classpath@gnu.org; Fri, 27 Feb 2004 00:50:38 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Awasw-0002wE-NZ
	for classpath@gnu.org; Fri, 27 Feb 2004 00:50:37 -0500
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1Awasv-0002wB-W1
	for classpath@gnu.org; Fri, 27 Feb 2004 00:50:06 -0500
Received: from dholmeslaptop (dholmes.dltech.com.au [203.222.72.2])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i1R5nCH7070946
	for <classpath@gnu.org>; Fri, 27 Feb 2004 16:49:13 +1100 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "classpath" <classpath@gnu.org>
Date: Fri, 27 Feb 2004 15:49:32 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCKEPKDNAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Importance: Normal
Subject: Query on stacktrace management logic
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2004 05:50:39 -0000

Hello all,

I'm somewhat baffled why Throwable's stacktrace management is implemented
like this:

  private transient VMThrowable vmState;
  private StackTraceElement[] stackTrace;

  public Throwable fillInStackTrace() {
    vmState = VMThrowable.fillInStackTrace(this);
    stackTrace = null; // Should be regenerated when used.
    return this;
  }

  public StackTraceElement[] getStackTrace() {
    if (stackTrace == null)
      if (vmState == null)
        stackTrace = new StackTraceElement[0];
      else {
	  stackTrace = vmState.getStackTrace(this);
	  vmState = null; // No longer needed
	}
    return stackTrace;
  }

Rather than the much simpler:

  private StackTraceElement[] stackTrace;

  public Throwable fillInStackTrace() {
    stackTrace = VMThrowable.fillInStackTrace(this).getStackTrace(this);
    return this;
  }

  public StackTraceElement[] getStackTrace() {
    return stackTrace;
  }

Give that VMThrowable guarantees to return a non-null array if there is no
stack trace, and given that fillinStackTrace is called at construction, this
would seem adequate.

What did I miss?

The reason this came up is that I'm looking for a way to construct
throwables (specifically certain instances of OutOfMemoryError) without
having the stacktrace filled in. I can obviously hack Throwable but I'd
prefer to deal with this only through VMThrowable if possible - but it's not
looking possible. I need to add a private constructor to Throwable that
doesn't do fillInstackTrace by default, which I can then call from the VM.

Any insights appreciated. :)

Cheers,
David Holmes




From MAILER-DAEMON Fri Feb 27 01:04:00 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1Awb6O-0000So-6V
	for mharc-classpath@gnu.org; Fri, 27 Feb 2004 01:04:00 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Awb6M-0000Sh-6S
	for classpath@gnu.org; Fri, 27 Feb 2004 01:03:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Awb5p-0000Py-0I
	for classpath@gnu.org; Fri, 27 Feb 2004 01:03:56 -0500
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1Awb5o-0000Pn-B5
	for classpath@gnu.org; Fri, 27 Feb 2004 01:03:24 -0500
Received: from dholmeslaptop (dholmes.dltech.com.au [203.222.72.2])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i1R62vZt081352
	for <classpath@gnu.org>; Fri, 27 Feb 2004 17:02:58 +1100 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "classpath" <classpath@gnu.org>
Date: Fri, 27 Feb 2004 16:03:17 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCIEPLDNAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
In-Reply-To: <NFBBKALFDCPFIDBNKAPCKEPKDNAA.dholmes@dltech.com.au>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Importance: Normal
Subject: RE: Query on stacktrace management logic
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2004 06:03:58 -0000

I wrote:
> Rather than the much simpler:
>
>   private StackTraceElement[] stackTrace;
>
>   public Throwable fillInStackTrace() {
>     stackTrace = VMThrowable.fillInStackTrace(this).getStackTrace(this);
>     return this;
>   }
>
>   public StackTraceElement[] getStackTrace() {
>     return stackTrace;
>   }
>
> ...
> What did I miss?

Well the first thing I missed is that fillInStacktrace can return null so
the above should be:
   public Throwable fillInStackTrace() {
     VMThrowable vmt = VMThrowable.fillInStackTrace(this);
     if (vmt != null)
       stackTrace = vmt.getStackTrace(this);
     else // could check if already  zero length array
       stacktrace = new StackTraceElement[0];
     return this;
   }

I thought it might have to do with making defensive copies but as far as I
can see the original code doesn't achieve that either.

David Holmes




From MAILER-DAEMON Fri Feb 27 06:49:33 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AwgUa-0006bh-RU
	for mharc-classpath@gnu.org; Fri, 27 Feb 2004 06:49:20 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AwgUI-00067e-69
	for classpath@gnu.org; Fri, 27 Feb 2004 06:49:02 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AwgTK-0005eg-Jh
	for classpath@gnu.org; Fri, 27 Feb 2004 06:48:34 -0500
Received: from [62.253.162.42] (helo=mta02-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AwgTJ-0005Yy-GW
	for classpath@gnu.org; Fri, 27 Feb 2004 06:48:01 -0500
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta02-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040227114719.OAYH14417.mta02-svc.ntlworld.com@cuddles.cambridge.redhat.com>
	for <classpath@gnu.org>; Fri, 27 Feb 2004 11:47:20 +0000
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i1RBksCL026935; Fri, 27 Feb 2004 11:47:04 GMT
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i1RBklMj026928;
	Fri, 27 Feb 2004 11:46:47 GMT
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16447.11815.502415.871255@cuddles.cambridge.redhat.com>
Date: Fri, 27 Feb 2004 11:46:47 +0000
To: "David Holmes" <dholmes@dltech.com.au>
In-Reply-To: <NFBBKALFDCPFIDBNKAPCKEPKDNAA.dholmes@dltech.com.au>
References: <NFBBKALFDCPFIDBNKAPCKEPKDNAA.dholmes@dltech.com.au>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: classpath <classpath@gnu.org>
Subject: Query on stacktrace management logic
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2004 11:49:15 -0000

David Holmes writes:
 > 
 > I'm somewhat baffled why Throwable's stacktrace management is implemented
 > like this:
 > 
 >   private transient VMThrowable vmState;
 >   private StackTraceElement[] stackTrace;
 > 
 >   public Throwable fillInStackTrace() {
 >     vmState = VMThrowable.fillInStackTrace(this);
 >     stackTrace = null; // Should be regenerated when used.
 >     return this;
 >   }
 > 
 >   public StackTraceElement[] getStackTrace() {
 >     if (stackTrace == null)
 >       if (vmState == null)
 >         stackTrace = new StackTraceElement[0];
 >       else {
 > 	  stackTrace = vmState.getStackTrace(this);
 > 	  vmState = null; // No longer needed
 > 	}
 >     return stackTrace;
 >   }
 > 
 > Rather than the much simpler:
 > 
 >   private StackTraceElement[] stackTrace;
 > 
 >   public Throwable fillInStackTrace() {
 >     stackTrace = VMThrowable.fillInStackTrace(this).getStackTrace(this);
 >     return this;
 >   }
 > 
 >   public StackTraceElement[] getStackTrace() {
 >     return stackTrace;
 >   }

Well consider what happens in a VM.  VMThrowable.fillInStackTrace() is
very fast -- it's just a chain of addresses.
VMThrowable.getStackTrace() is very slow, because it has to convert
all those addresses into StackTraceElements.  I suspect that you can
get the trace for the whole stack in less time than it takes to create
a single StackTraceElement.  For this reason, the vmState is stored
and lazily converted to a StackTraceElement[].

All this assumes a particular VM design, of course, but I don't think
it's atypical.

Andrew.



From MAILER-DAEMON Fri Feb 27 20:09:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AwsyX-0006KB-Gc
	for mharc-classpath@gnu.org; Fri, 27 Feb 2004 20:09:05 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1Awst7-00045V-8V
	for classpath@gnu.org; Fri, 27 Feb 2004 20:03:29 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1Awsrb-0003e5-3M
	for classpath@gnu.org; Fri, 27 Feb 2004 20:02:27 -0500
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1AwsqH-00030s-Ti
	for classpath@gnu.org; Fri, 27 Feb 2004 20:00:34 -0500
Received: from dholmeslaptop (233-130.ip.internex.net.au [210.9.233.130])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i1S0wOa7096418;
	Sat, 28 Feb 2004 11:58:39 +1100 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "Andrew Haley" <aph@redhat.com>
Date: Sat, 28 Feb 2004 10:59:01 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCKEADDOAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Importance: Normal
In-Reply-To: <16447.11815.502415.871255@cuddles.cambridge.redhat.com>
Cc: classpath <classpath@gnu.org>
Subject: RE: Query on stacktrace management logic
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Feb 2004 01:04:26 -0000

Andrew Haley wrote:
> Well consider what happens in a VM.  VMThrowable.fillInStackTrace() is
> very fast -- it's just a chain of addresses.
> VMThrowable.getStackTrace() is very slow, because it has to convert
> all those addresses into StackTraceElements.  I suspect that you can
> get the trace for the whole stack in less time than it takes to create
> a single StackTraceElement.  For this reason, the vmState is stored
> and lazily converted to a StackTraceElement[].

Thanks - I see now. Unfortunately in our system (at present) this is not the
case. But now I have an idea of how to change that.

I still need a hook to not get the stacktrace filled in for
OutOfMemoryError - though perhaps I can do something without requiring
allocation using a different approach.

Thanks again.

David Holmes




From MAILER-DAEMON Sat Feb 28 16:57:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AxCSF-0007Mr-W1
	for mharc-classpath@gnu.org; Sat, 28 Feb 2004 16:57:03 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AxCSB-0007LT-0I
	for classpath@gnu.org; Sat, 28 Feb 2004 16:56:59 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AxCRd-0007AK-Eq
	for classpath@gnu.org; Sat, 28 Feb 2004 16:56:56 -0500
Received: from [64.4.37.37] (helo=hotmail.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AxCRd-00079w-2n
	for classpath@gnu.org; Sat, 28 Feb 2004 16:56:25 -0500
Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC;
	Sat, 28 Feb 2004 12:53:03 -0800
Received: from 80.177.127.218 by by10fd.bay10.hotmail.msn.com with HTTP;
	Sat, 28 Feb 2004 20:53:03 GMT
X-Originating-IP: [80.177.127.218]
X-Originating-Email: [robert_lougher@hotmail.com]
X-Sender: robert_lougher@hotmail.com
From: "Robert Lougher" <robert_lougher@hotmail.com>
To: dholmes@dltech.com.au, aph@redhat.com
Bcc: 
Date: Sat, 28 Feb 2004 20:53:03 +0000
Mime-Version: 1.0
Content-Type: text/plain; format=flowed
Message-ID: <BAY10-F37ymPHpzwLua00002264@hotmail.com>
X-OriginalArrivalTime: 28 Feb 2004 20:53:03.0729 (UTC)
	FILETIME=[DBE61E10:01C3FE3C]
Cc: classpath@gnu.org
Subject: RE: Query on stacktrace management logic
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Feb 2004 21:57:00 -0000

Well, if it's of any interest, JamVM takes advantage of this.  When 
VMThrowable.fillInStackTrace() is called I store the backtrace in a compact, 
internal format.  Then, if and when getStackTrace() is called I convert this 
into StackTraceElements.  Remember, unless you do something like 
printStackTrace in your catch block the StackTraceElements will never be 
needed.  Creating them up front will greatly increase the cost of 
throwing/catching exceptions as Andrew stated.

As to your point about out of memory.  Surely you _want_ the stacktrace if 
it all possible?  You may not be able to satisfy an allocation request but 
still be able to construct an OutOfMemoryException.  If you use the scheme 
above, constructing the backtrace shouldn't use much memory.  If the 
stacktrace is printed, _lots_ of memory will be required but by this stage 
it's been caught, (or more likely printed as an uncaught exception) so lots 
of frames have been popped, enabling lots of memory to be collected.

If we can't construct an OutOfMemoryException, as a last resort, JamVM 
throws an "empty" OutOfMemoryException pre-allocated at VM startup.

Hope this helps,

Rob.

P.S.  What is your system?

----Original Message Follows----
From: "David Holmes" <dholmes@dltech.com.au>
To: "Andrew Haley" <aph@redhat.com>
CC: classpath <classpath@gnu.org>
Subject: RE: Query on stacktrace management logic
Date: Sat, 28 Feb 2004 10:59:01 +1000

Andrew Haley wrote:
 > Well consider what happens in a VM.  VMThrowable.fillInStackTrace() is
 > very fast -- it's just a chain of addresses.
 > VMThrowable.getStackTrace() is very slow, because it has to convert
 > all those addresses into StackTraceElements.  I suspect that you can
 > get the trace for the whole stack in less time than it takes to create
 > a single StackTraceElement.  For this reason, the vmState is stored
 > and lazily converted to a StackTraceElement[].

Thanks - I see now. Unfortunately in our system (at present) this is not the
case. But now I have an idea of how to change that.

I still need a hook to not get the stacktrace filled in for
OutOfMemoryError - though perhaps I can do something without requiring
allocation using a different approach.

Thanks again.

David Holmes



_______________________________________________
Classpath mailing list
Classpath@gnu.org
http://mail.gnu.org/mailman/listinfo/classpath

_________________________________________________________________
Express yourself with cool new emoticons http://www.msn.co.uk/specials/myemo




From MAILER-DAEMON Sat Feb 28 23:44:13 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AxIoG-0007wF-TW
	for mharc-classpath@gnu.org; Sat, 28 Feb 2004 23:44:12 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AxIoC-0007rP-PM
	for classpath@gnu.org; Sat, 28 Feb 2004 23:44:08 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AxIng-0007PW-NQ
	for classpath@gnu.org; Sat, 28 Feb 2004 23:44:07 -0500
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AxIng-0007P3-Dn
	for classpath@gnu.org; Sat, 28 Feb 2004 23:43:36 -0500
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i1T4F5Hm005689;
	Sat, 28 Feb 2004 23:15:14 -0500 (EST)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004022823161513220 ; Sat, 28 Feb 2004 23:16:15 -0500
Received: from 118.30.internet.uqam.ca (118.30.internet.uqam.ca
	[132.208.30.118])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i1T4BbFk003893; Sat, 28 Feb 2004 23:11:37 -0500 (EST)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
From: "Grzegorz B. Prokopski" <gadek@debian.org>
To: GNU Classpath <classpath@gnu.org>
Content-Type: text/plain
Organization: Debian GNU/Linux http://www.debian.org
Message-Id: <1078027891.1097.157.camel@gadek.homelinux.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 28 Feb 2004 23:11:33 -0500
Content-Transfer-Encoding: 7bit
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>
Subject: Fixing 'make distcheck' w/ newer tar - autotools usage problem?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Feb 2004 04:44:09 -0000

Hi!

Thanks to help from Bdale the problem seems to boil down to using "o"
option in 'tar chof' which turns on old, v7 mode, which doesn't allow
for paths longer than 100 chars. Old tar worked because it forced usage
of POSIX tar settings even when asked otherwise (it was a bug).

$ grep -R chof .
./Makefile:	$(AMTAR) chof - $(distdir) | GZIP=$(GZIP_ENV) gzip -c
>$(distdir).tar.gz
./Makefile:	$(AMTAR) chof - $(distdir) | GZIP=$(GZIP_ENV) gzip -c
>$(distdir).tar.gz
./Makefile.in:	$(AMTAR) chof - $(distdir) | GZIP=$(GZIP_ENV) gzip -c
>$(distdir).tar.gz
./Makefile.in:	$(AMTAR) chof - $(distdir) | GZIP=$(GZIP_ENV) gzip -c
>$(distdir).tar.gz

So this options seems to come from automake as it's not present in
Makefile.am, but put into Makefile.in. Is there some way to persuade
automake not to enforce old compatibility mode when using tar?

HTH

					Grzegorz B. Prokopski

PS: The test case is ex. this:

cd /tmp
mkdir -p
sablevm-classpath-1.1.0/external/jaxp/source/javax/xml/transform
echo "AAAAAA"
>./sablevm-classpath-1.1.0/external/jaxp/source/javax/xml/transform/TransformerConfigurationException.java
tar chof - sablevm-classpath-1.1.0 | GZIP=--best gzip -c
>sablevm-classpath-1.1.0.tar.gz
tar zxvf ./sablevm-classpath-1.1.0.tar.gz

If you s/chof/chf/ - it works as expected.

-- 
Grzegorz B. Prokopski <gadek@debian.org>
Debian GNU/Linux      http://www.debian.org
SableVM - LGPLed JVM  http://www.sablevm.org
Why SableVM ?!?       http://devel.sablevm.org/wiki/WhySableVM




From MAILER-DAEMON Sun Feb 29 06:06:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AxOly-0003to-1u
	for mharc-classpath@gnu.org; Sun, 29 Feb 2004 06:06:14 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AxOlv-0003q7-Nm
	for classpath@gnu.org; Sun, 29 Feb 2004 06:06:11 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AxOlN-0003W9-Or
	for classpath@gnu.org; Sun, 29 Feb 2004 06:06:10 -0500
Received: from [212.6.122.96] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AxOlM-0003Tp-Na
	for classpath@gnu.org; Sun, 29 Feb 2004 06:05:36 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-94-051.ewetel.net
	[80.228.94.51])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i1TB5Now005719;
	Sun, 29 Feb 2004 12:05:23 +0100 (MET)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1AxOl8-0001kB-00; Sun, 29 Feb 2004 12:05:22 +0100
From: Michael Koch <konqueror@gmx.de>
To: "Grzegorz B. Prokopski" <gadek@debian.org>,
	GNU Classpath <classpath@gnu.org>
Date: Sun, 29 Feb 2004 12:05:23 +0100
User-Agent: KMail/1.5.4
References: <1078027891.1097.157.camel@gadek.homelinux.org>
In-Reply-To: <1078027891.1097.157.camel@gadek.homelinux.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200402291205.24466.konqueror@gmx.de>
X-CheckCompat: OK
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>
Subject: Re: Fixing 'make distcheck' w/ newer tar - autotools usage problem?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Feb 2004 11:06:12 -0000

Am Sonntag, 29. Februar 2004 05:11 schrieb Grzegorz B. Prokopski:
> Hi!
>
> Thanks to help from Bdale the problem seems to boil down to using "o"
> option in 'tar chof' which turns on old, v7 mode, which doesn't allow
> for paths longer than 100 chars. Old tar worked because it forced
> usage of POSIX tar settings even when asked otherwise (it was a bug).
>
> $ grep -R chof .
> ./Makefile:	$(AMTAR) chof - $(distdir) | GZIP=$(GZIP_ENV) gzip -c
>
> >$(distdir).tar.gz
>
> ./Makefile:	$(AMTAR) chof - $(distdir) | GZIP=$(GZIP_ENV) gzip -c
>
> >$(distdir).tar.gz
>
> ./Makefile.in:	$(AMTAR) chof - $(distdir) | GZIP=$(GZIP_ENV) gzip -c
>
> >$(distdir).tar.gz
>
> ./Makefile.in:	$(AMTAR) chof - $(distdir) | GZIP=$(GZIP_ENV) gzip -c
>
> >$(distdir).tar.gz
>
> So this options seems to come from automake as it's not present in
> Makefile.am, but put into Makefile.in. Is there some way to persuade
> automake not to enforce old compatibility mode when using tar?

Thanks for debugging this. What versions of automake have you tried ? 
Perhaps we should get more restrict on the version. Have you considered 
writting a bug report agains automake ?


Michael




From MAILER-DAEMON Sun Feb 29 17:57:32 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1AxZsJ-0005UY-TT
	for mharc-classpath@gnu.org; Sun, 29 Feb 2004 17:57:31 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AxZsH-0005Tf-5a
	for classpath@gnu.org; Sun, 29 Feb 2004 17:57:29 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AxZrl-0005Jj-4H
	for classpath@gnu.org; Sun, 29 Feb 2004 17:57:28 -0500
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AxZrf-0005JJ-U1
	for classpath@gnu.org; Sun, 29 Feb 2004 17:56:51 -0500
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i1TMj4Hc022495;
	Sun, 29 Feb 2004 17:45:12 -0500 (EST)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004022917461215405 ; Sun, 29 Feb 2004 17:46:12 -0500
Received: from 118.30.internet.uqam.ca (118.30.internet.uqam.ca
	[132.208.30.118])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i1TMeTlH016461; Sun, 29 Feb 2004 17:40:30 -0500 (EST)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
From: "Grzegorz B. Prokopski" <gadek@debian.org>
To: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	GNU Classpath <classpath@gnu.org>,
	Debian Java <debian-java@lists.debian.org>
Content-Type: text/plain
Organization: Debian GNU/Linux http://www.debian.org
Message-Id: <1078094425.1097.308.camel@gadek.homelinux.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 29 Feb 2004 17:40:26 -0500
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Announcing SableVM 1.1.0 development release
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Feb 2004 22:57:29 -0000

Hi all!

It's been long months without any official release of SableVM but now
1.1.0 release is out and available for download and testdrive. I know
that before and after FOSDEM many people wanted to download SableVM
but our development server was down. I hope that this release will
be good occasion, expecially for those who were hurt by the server
downtime, to actually give new SableVM a ride.

In SableVM 1.1.0 you can find, among others:
* Update to GNU Classpath from 1st Februray 2004, 
* SableVM's fastest inlined engine ported to most of the platforms, 
* Many fills in reflection and JNI, 
* Nice improvements like java-sablevm wrapper and manual pages,
* Bugfixes.

Altough these tarballs are considered to be "development" release - they
are far, far superior in almost every way to what was our last 1.0.9
version. Ex. very recent GNU Classpath allows for some graphical
applications to more-or-less work, we support many more architectures...

To get the tarballs go to http://devel.sablevm.org/download/1.1.0/
and get sablevm-1.1.0.tar.gz and sablevm-classpath-1.1.0.tar.gz.
Installation instructions are included in sablevm tarball in
INSTALL-DEVEL file or you can find them online at
http://devel.sablevm.org/docs/INSTALL.txt

We appreciate your feedback. Please feel invited to mail us (see
http://devel.sablevm.org/wiki/MailingLists) or use #sablevm IRC
channel on irc.freenode.net (irc.debian.org, irc.sablevm.org).

We hope to make more frequent development releases in the future, but
please note that we also have daily SVN snapshots readily available at
http://devel.sablevm.org/shot

Debian packages have just been uploaded into incoming (for the impatient
http://incoming.debian.org/) and will be available shortly for unstable
distribution, but they should be usable with testing too.

We wish you great fun using SableVM!

				SableVM Project Developers

PS: For those who would like to get more deeply into SableVM code
- we're happy to offer our support and Subversion accounts with
freely-usable, own sandbox.

-- 
Grzegorz B. Prokopski <gadek@debian.org>
Debian GNU/Linux      http://www.debian.org
SableVM - LGPLed JVM  http://www.sablevm.org
Why SableVM ?!?       http://devel.sablevm.org/wiki/WhySableVM




