From MAILER-DAEMON Thu Apr 01 04:37:38 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B8ydm-0000jU-Fs
	for mharc-classpath@gnu.org; Thu, 01 Apr 2004 04:37:38 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B8ydj-0000io-Ss
	for classpath@gnu.org; Thu, 01 Apr 2004 04:37:35 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B8ydD-0000WU-D2
	for classpath@gnu.org; Thu, 01 Apr 2004 04:37:34 -0500
Received: from [213.51.128.197] (helo=smtpq2.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B8ydC-0000VL-PO
	for classpath@gnu.org; Thu, 01 Apr 2004 04:37:02 -0500
Received: from [213.51.128.134] (port=35748 helo=smtp3.home.nl)
	by smtpq2.home.nl with esmtp (Exim 4.30) id 1B8ydA-0000jv-Vl
	for classpath@gnu.org; Thu, 01 Apr 2004 11:37:00 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:33043
	helo=dumas.thomas.planescape.com)
	by smtp3.home.nl with esmtp (Exim 4.30) id 1B8ydA-00006c-4a
	for classpath@gnu.org; Thu, 01 Apr 2004 11:37:00 +0200
From: Thomas Zander <zander@javalobby.org>
To: GNU Classpath <classpath@gnu.org>
Date: Thu, 1 Apr 2004 10:37:17 +0200
User-Agent: KMail/1.6.1
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_9S9aANUIihRAkOn"
Message-Id: <200404011037.22444.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: [PATCH] Mauve is too hard to run.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2004 09:37:36 -0000


--Boundary-00=_9S9aANUIihRAkOn
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I think that there are 2 distinct user groups for the 'mauve' tool. One is=
=20
the JVM developers which need to use the lowest common dominator in Java=20
implementations. So it runs on a minimal Java implementation.

The other group is where I find myself in; the group that has extensive=20
experience with Java, its huge toolset and can't imagine working on a=20
halve-implemented JVM.
=46or that latter group the automake-autoconf toolset is just too hard to=20
use.

Because of that I created an ant-task including an ant build file which=20
means absolutely no CLI usage is needed to start running the mauve test=20
suite.
The ant-based runnables assumes a fully implemented JVM and therefor uses a=
=20
completely seperate buildflow from the 'make' equivalent. You can run ant=20
and then run make to test 2 seperate JVMs, for example.

Can someone please commit these files/diff to the mauve test suite?

ps. notice that this makes the Mauve toolset immidiately Windows=20
compatible...

Cheers!
=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAa9TACojCW6H2z/QRAs3YAJ9h3zFwA9o9Q+OKhOazFgLjo810CgCffj3t
zEZfhDMM1RKIj/nOA8XI4JQ=3D
=3Dn9L8
=2D----END PGP SIGNATURE-----

--Boundary-00=_9S9aANUIihRAkOn
Content-Type: application/x-tgz;
  name="antMauve.tgz"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
	filename="antMauve.tgz"

H4sIAHnUa0AAA+0aa2/bRtJfy18xIYKGsiWKkh/CVZYbxbFj4fyCpTTIFUVAkSuJMcVVyaVtXeD/
fjPLh0hKlpM4Sa93HAS1uTs7O++ZHdf0xJkZ3rD6xvcDw9gxWq1d/Gk0WrtG9mcCGw3D2G62dpuN
veaG0Wg2Ws0N2P2OPKUQBsL0ATb+bXo28x/Ge2z/bwpmYv+xF34vH/gC+zdakf1bLaO0/4+AnP3x
Q5jB9bf2gy+K/51ttP/OTrNV2v9HwEr7X4XegAUi0D+aN+bT7zDQuHs7Ow/Zf293t1Wwf8toNTbA
ePrVj8P/uf3rm8ohn819ZzwRoFkVaGK0wmDCp2YA/5Iyw34k+8trm+ncHx8oymDiBDByXAb4c2b6
AvgIpB/piiJ/0sbIZwwCPhK3ps/aMOchWKYHPrOdQPjOMBSIJgCJ17kPU247o7mCC6G8VUwYCOZP
A6JNH2/O38Ib5jHfdOEyHLqOBaeOxbyAAfI6o5VgwmwYzhVCP6bb+/HtcMyRqikc7rWBObjvww3z
A/yGZhXwes0UxKEPfEZYFcX05uCaYoGYFW0hgQ2OJ9mb8BkyPEEyKMKt47owZBAGbBS6VQUx4V1v
cHLxdgDd8/fwrnt11T0fvG8jpphw3GU3LKLjTGeug2SRbR8Dco7iK2dHV4cniN991TvtDd4Tv8e9
wflRvw/HF1fQhcvu1aB3+Pa0ewWXb68uL/pHOkCfEUNMWaO4kVQ86sdmwnTcAGV8j2YKkCXXhomJ
0vrMYs4NMmSChZ7yuDUU0+XeWAoW+UQbgoiTyGUOLy7f987fIIO9EXhcVOHWd9AVBF9rtyrs/gMG
DLXD4NI1LQY16Id0cHvbqCqveCAI6awLRrPRaNQa20arCm/7XR0264oyM61rc8wA85we57m2oqCy
OXovLQrMeC4T+mY7WaXspzu8uBIKx6W1ZBFDQjeR/ITpgnPUIZLPnFm5TdfbbBQ8ijefMYmkzCId
W64ZBJAkaGB3gnl2gHoW1sTxxgOkC58UQJj5zg26LwyRGMOwQy8e8oB1RqYbsCoafBiOk4+J6YoL
7xg9IPRTjBF+XnhHvs/9jvBD1s6RvTTRvAEGjMVeO37HC103j/AbswR6F5k8YCLoeOw2XtMqKI9E
jWS64Y6NkjALw0mroKP4/DaAV6Hj2kd3FpPxGAtFcDYn2U9M32Ooikn8swN0QX5Pi2WOpS3ImXBB
0MM4N4ldhwK+k3KtO/EG8Zwg305wV6MdfWIG52gDrVLJMEhwjCh9JmBEnGnxV0WS1z15op3DF/68
QIEANSs1Nu9j4sRYA5vIoduMmSjuabh26fOPuIjstJdopSJKFzo3p4xodTHJzNHXglPMaJotKfc8
yw1tZhPXAdJaqYS8MhY0H1ZJAn3MnJgfSMUeniD9REuVDGsrlZSAM9Keped1CoB3mGw0VZfn1Upl
5SkCi3vC8dCXoV4H7rnzOKCkvR+6K70JUVE5Nru7GGnqc7UCB7ByjxSnBwwLI2ntc9nxOJYSMrJk
ifVXnkru66QXB+EwkOrTjGqGHeaNUSWV2t4DOlwm5LMZpdUC94cYYFV4ob/IhksW4gDU/Sgnpdpa
ce99buUeuwHMWqAVIn3IVnkOKshOPB5szgLvBRbNO/RaqoZYkrGSYK0ybXPosqXTzgi0TD5bbRGZ
ePD6ZcYZJsSVR1w+1oaMguYMdYD1RatU4yDUz/pvPmCdPy8oYqGE6Lf75VyImee3KHNpheyd1YzA
JkyP1zGI4t/aa4i+piyYkpQ5cYmgXEVy8uc6YifZXJoSxc4pQzGXb5Eodl9rKB4vDPQAvYwJ11Mz
7Sh7MZHkXrogRyrJ8Iiq0V5KK1fF8HUg0rKbry5J7e1Tx8ayO4tbikU4p5CFX6BzR9SodxzWLRP7
RiyuU8Y9apx4SN05bsV9Gbm67M2SpoB7mAJCig3s4NK7o80c00V/qkLOG6qrGS3GYxDOsN4Ui6ts
G4pljVyq6AUPKOFeyaiNCwwhbDqlNePUktQJkOnl0T4h5ZRSE3V32oq0hOk9z97PP8M4ckX8wuqH
Od5YThdRqqCOI3+9piYn1Up7KdDvlb/6ubcE6ft/SHLod1P329/x2Pu/ube3eP8bezT/MRp75fv/
R8D+r2jy5IXbURu6of56oOw/q9W+YixAXr52NEAITxsPyJj9FiOCKIqfPiYgOqtGBTlRv3RcQIef
ODKQ9z9pbEAUvmx0QCeePj6QGv3qEcJjdn1kjEDH140SajX08/1Z1OLJQtRRp8ShinoYmaErOirV
GhWGZoCe7HdUXY1Dg6JKVkRsG01sHIhNNBeMXT5ENSBRLFbCwXcZ3SJPxGtzKXZHff4JPQRfndgZ
3NdpQFCLzuqLs2o9uS09G3EZ+JYKN6YbMmKpXrwgQpJVIEWLvh5AtbkVpJj4sbiYxLRkFxHOIHqT
URSD/tGM5wELATH5YrmNScpDpMjA8h0ZXx31MGoD0d0tPp3hYTsioR6k5TW60MQQim4d+XyK/ZRJ
Nq5JGaTTJHfKIzZzGdpcGuj5J4l0n0i6AoGETff36xHXWXl7570BWPj+QONLw/rszxDfK3b6aiG7
khbWKcDxHJEVTGBxms6ybE2vkd4atnP7Oa5TVvEtRF6HTVGAuYTJpIu5Z+YzgcYNqAlCAShl4m8W
94l9Pa89lIGyneDXDE3Uvzp83btKfSF2UuQhf3f+0ODsMn8ombaJ6UwehYfPHp4cHf7zw2V3cPKh
f4Q5rDu4yFKamWKyeMCuYyIidNw7PVpJaJR7CecJyWSWRCXG1r38C0o8RKxjRz5yxnokk6cu94/8
c44un0uGeCoN5Ja3I+mwRY4RYI3HHp52+33SYSbb0EzPsTGjzWXU6rSQ9Uf6xriYMvQfl1tmFKKp
Iy6uI8RcOohiFyMAo5TCI5ocPpgIInRKBTN6Y8WRUcgMEZIkuZQSSH0WoHLjUCA1y/MiHzv5x0A0
+MLryCCbm/XNFWaQmiH5fDYqaCqHFw1YVe49aIWcyJRB14orHxpyAk2oBVFxCeIJN5GLJEhG2kW+
ZJlid4msc9RcASPVkswg9a9TwK3j2fxWOIIcPWqFiCHoXvZUOMih7uM9EvFg/9nvh6+7g+7v+5PG
Qf7Qfh2X/vjjYL+eYi+UUI+18BmajspzTtXVjMNlVI4pMu4xA5Hzrnh8n6//Ug/RSuaPDHoyq1cX
iitUVklSEkmcZjm61wQ+vV8xZ8TDe1U+w/MYtMex16JJfkSgoP54GFKoK4V4SBIUaRqDI5egv47K
XT1AJxkXie3XpTKKpsSsErVdB/99z+i/LaTv/6UpFhbw0eib3CHf/3sPvv+N3Z2d5P1v7DTp7/97
O9ut8v3/I6CGxTkblstuQIFa4679E40AavSvAQ3jlyb+29bT/4EHtgzcV7a2tj6DXJFU4xejuUTq
5Uuo7RrVPdjC/zYa8PKlAj9FCWILVNC8cDrETk7FL83C553AXxoV2quks7d7BZQtZSs7UHTowZUb
8H0iBMCGXYS+B3EeDdq0eo+nIT9ZtibMuoZ0joqYWEzjAWE6e6Q/NzxL9/5qG5dQQgkllFBCCSWU
UEIJJZRQQgkllFBCCSWUUEIJJZRQQgkllFBCCSWUUEIJJZTwvwf/AdCyP9oAUAAA

--Boundary-00=_9S9aANUIihRAkOn--



From MAILER-DAEMON Thu Apr 01 05:50:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B8zmO-0006zg-S7
	for mharc-classpath@gnu.org; Thu, 01 Apr 2004 05:50:36 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B8zmL-0006xd-BY
	for classpath@gnu.org; Thu, 01 Apr 2004 05:50:33 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B8zmH-0006t6-K1
	for classpath@gnu.org; Thu, 01 Apr 2004 05:50:30 -0500
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B8zmG-0006rj-Fg
	for classpath@gnu.org; Thu, 01 Apr 2004 05:50:28 -0500
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1B8zly-0006lA-00; Thu, 01 Apr 2004 12:50:10 +0200
From: Mark Wielaard <mark@klomp.org>
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <1080239008.18716.170.camel@elsschot.wildebeest.org>
References: <1079862783.1979.21.camel@gadek.homelinux.org>
	<20040321085006.A22782@urbanophile.com> <4061AA6C.5030903@redhat.com>
	<4061D5C8.1080000@uqam.ca>
	<1080239008.18716.170.camel@elsschot.wildebeest.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-1xxJL2x9aOD8J4Gud60Y"
Message-Id: <1080816612.26699.155.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Thu, 01 Apr 2004 12:50:12 +0200
Cc: SableVM-devel ML <sablevm-developer@lists.sourceforge.net>,
	graydon hoare <graydon@redhat.com>, GNU Classpath <classpath@gnu.org>,
	"Aaron M. Renn" <arenn@urbanophile.com>
Subject: Re: Starting to swing... [screenshots]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2004 10:50:34 -0000


--=-1xxJL2x9aOD8J4Gud60Y
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2004-03-25 at 19:23, Mark Wielaard wrote:
> On Wed, 2004-03-24 at 19:39, Etienne Gagnon wrote:
> >  >   http://people.redhat.com/~graydon/free-swing-mar-23-2004.png
> >=20
> > OK SableVM guys!  I'd like to see this in SableVM's staging tree *now*!
> [...]
> > What's missing?
>=20
> [...]
> - Although we have a TestAWT application, we don't have a TestSwing
> application. It would be nice if Graydon could post the sources of the
> demos he used for the nice shots at http://people.redhat.com/~graydon/
> Hint, hint, ... ;)

OK, this one is fixed now!
http://people.redhat.com/~graydon/testswing.java

And it actually works with GNU Classpath from CVS, hurray!
Although it certainly has some drawing bugs (and you have to click
slightly under the buttons to actually hit them!).
I just checked in one little (compile) fix that I discussed with Graydon
on irc. The rest of the free Swing fixes will come later this month when
we sync again with the libgcj gui-branch.

Other happy news on the GUI front is the release of Odonata 0.1 by
Stephane Meslin-Weber. "Odonata is a set of 100% Java AWT peers for use
with framebuffers. It is  released under the GPL and the ultimate aim is
to provide an alternative replacement for native bindings such as QtAWT,
Gtk or MFC. Replacing AWT peers is a transparent method of extending the
range of platforms and hardware that Java's AWT can be used on."
See for source, screenshots, etc. http://odonata.tangency.co.uk/

Quickly tried it out with jamvm + GNU Classpath cvs and gij (CVS, not
gui-branch) on the VNC backend (it actually includes and runs a VNCj
server!) and there are clearly some drawing/layout problems [lots of
black backgrounds] in our code, but some of the basics work. (For
current GNU Classpath it seems you have to comment out the drawLogo()
call in the uk.co.tangency.odonata.Toolkit constructor - although the
logo shows fine under gij 3.4/CVS.)

Cheers,

Mark

--=-1xxJL2x9aOD8J4Gud60Y
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAa/PkxVhZCJWr9QwRAvu+AKCQ8+6OOo2n8dxH0DRKn8lp7WwI6QCcC+oQ
cMWu856qXRmWoizzucItu7I=
=cWbs
-----END PGP SIGNATURE-----

--=-1xxJL2x9aOD8J4Gud60Y--




From MAILER-DAEMON Thu Apr 01 16:35:26 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B99pn-0005Kz-0U
	for mharc-classpath@gnu.org; Thu, 01 Apr 2004 16:34:47 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B99pe-0005H0-Gl
	for classpath@gnu.org; Thu, 01 Apr 2004 16:34:38 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B99p8-0004qW-4I
	for classpath@gnu.org; Thu, 01 Apr 2004 16:34:37 -0500
Received: from [64.172.11.17] (helo=younglogic.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B99nK-0003HO-6l
	for classpath@gnu.org; Thu, 01 Apr 2004 16:32:14 -0500
Received: from [10.10.2.90] (helo=younglogic.com ident=adam)
	by younglogic.com with esmtp (Exim 3.35 #1 (Debian))
	id 1B98sW-0000cw-00
	for <classpath@gnu.org>; Thu, 01 Apr 2004 12:33:32 -0800
Message-ID: <406C8A4A.9080809@younglogic.com>
Date: Thu, 01 Apr 2004 13:31:54 -0800
From: Adam Young <adam@younglogic.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
CC: GNU Classpath <classpath@gnu.org>
References: <200404011037.22444.zander@javalobby.org>
In-Reply-To: <200404011037.22444.zander@javalobby.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] Mauve is too hard to run.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2004 21:34:39 -0000

Thomas,

Thanks for doing that.  As someone wo was trying to implement something 
other than core functionality, I found it quite difficult to use the 
Mauve tests as is.

Adam


Thomas Zander wrote:

>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>I think that there are 2 distinct user groups for the 'mauve' tool. One is 
>the JVM developers which need to use the lowest common dominator in Java 
>implementations. So it runs on a minimal Java implementation.
>
>The other group is where I find myself in; the group that has extensive 
>experience with Java, its huge toolset and can't imagine working on a 
>halve-implemented JVM.
>For that latter group the automake-autoconf toolset is just too hard to 
>use.
>
>Because of that I created an ant-task including an ant build file which 
>means absolutely no CLI usage is needed to start running the mauve test 
>suite.
>The ant-based runnables assumes a fully implemented JVM and therefor uses a 
>completely seperate buildflow from the 'make' equivalent. You can run ant 
>and then run make to test 2 seperate JVMs, for example.
>
>Can someone please commit these files/diff to the mauve test suite?
>
>ps. notice that this makes the Mauve toolset immidiately Windows 
>compatible...
>
>Cheers!
>- -- 
>Thomas
>-----BEGIN PGP SIGNATURE-----
>Version: GnuPG v1.2.4 (GNU/Linux)
>
>iD8DBQFAa9TACojCW6H2z/QRAs3YAJ9h3zFwA9o9Q+OKhOazFgLjo810CgCffj3t
>zEZfhDMM1RKIj/nOA8XI4JQ=
>=n9L8
>-----END PGP SIGNATURE-----
>  
>
>------------------------------------------------------------------------
>
>_______________________________________________
>Classpath mailing list
>Classpath@gnu.org
>http://mail.gnu.org/mailman/listinfo/classpath
>  
>




From MAILER-DAEMON Fri Apr 02 03:49:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9KN3-0002Eu-4z
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 03:49:49 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9KMz-0002D5-In
	for classpath@gnu.org; Fri, 02 Apr 2004 03:49:45 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9KMS-0001zZ-Uo
	for classpath@gnu.org; Fri, 02 Apr 2004 03:49:44 -0500
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1B9KLu-0001iW-2A; Fri, 02 Apr 2004 03:48:38 -0500
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i328jRKx009432;
	Fri, 2 Apr 2004 03:45:37 -0500 (EST)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040203465108446 ; Fri, 02 Apr 2004 03:46:51 -0500
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i328fvk0004103; Fri, 2 Apr 2004 03:41:58 -0500 (EST)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1B9KFS-0006ZX-1w; Fri, 02 Apr 2004 03:41:58 -0500
Message-ID: <406D1FCF.5080208@uqam.ca>
Date: Fri, 02 Apr 2004 03:09:51 -0500
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040314 Debian/1.6-3
X-Accept-Language: en
MIME-Version: 1.0
To: tromey@redhat.com
References: <40671825.1070100@uqam.ca>
	<406719C5.2030806@uqam.ca>	<40671B8B.7000209@uqam.ca>
	<87d66sfp9m.fsf@fleche.redhat.com>
In-Reply-To: <87d66sfp9m.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, commit-classpath@gnu.org
Subject: Re: Rant [Was: Unresolved CVS conflict]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 08:49:46 -0000

Tom Tromey wrote:
> Etienne> It would be so much easier if we had something like:
> Etienne> $ svn st
> 
> I don't know what this is.
> 
> If it is some kind of "what is the status of my working tree?" query,
> I recommend the cvsutils (or is it cvs-utils?  I recommend both...)
> for this sort of thing.  I probably use "cvsu" 50 times a day.

It is somewhat similar, but this is a "client-side"-only operation
with Subversion (much faster and does not require network access).

> Etienne> I vote for Subversion (I see no need for distributed
> Etienne> classpath repository).
> 
> I've been hoping to use monotone (http://www.venge.net/monotone/) to
> help with classpath/libgcj merges.  A system like this would help us a
> lot...  unfortunately it isn't quite ready for this yet.

Subversion is now stable.  I have been using it since May 2003, and have
had no problem with it.  It has many interesting features.  It is not
a "patches flowing across the Internet" find of system (like arch,
monotone, bit-keeper), but a more traditional "central repository"
system.  But, this central repository is stored in a database, which
is very good for many reasons:
1- real transactions on commits
2- no problems associated with the number of created files for huge
    projects (e.g. granularity of space allocation in file system, etc).
3- easy to back-up (even *hot* backups!)

I think the best way to see what it is all about is to look at
  http://subversion.tigris.org/
and read the *excellent* Free online book at:
  http://svnbook.red-bean.com/


> Etienne> Arch is nice but does not allow a single file to be split
> Etienne> (which does happen regularly, specially when doing
> Etienne> Object-Oriented development, e.g. spin-off package classes
> Etienne> [Method=> Method + VMMethod]).
> 
> Subversion can do this?

Of course!  Arch's main architect thinks that this should not be needed
(and argues strongly about "splitting" files), as it would break Arch's
view of "merging".  But, my experience is that splitting a file *does*
happen.  It has happened in the past in Classpath, and I have also
experienced a few file splits in my SableCC project.  Preserving history
in case of splits is, in my opinion, as needed as preserving history
in case of file rename/move (which is broken in CVS).

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Fri Apr 02 06:55:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9NH2-0002Dj-BN
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 06:55:48 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9NGy-0002Bg-JV
	for classpath@gnu.org; Fri, 02 Apr 2004 06:55:44 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9NGR-0001ty-Ce
	for classpath@gnu.org; Fri, 02 Apr 2004 06:55:42 -0500
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1B9NEi-0001Sw-Vv; Fri, 02 Apr 2004 06:53:25 -0500
Received: from [195.18.123.2] (helo=kiev.dev.factotummedia.nl)
	by mx20.gnu.org with esmtp (Exim 4.30)
	id 1B9N3L-0001Tc-OF; Fri, 02 Apr 2004 06:41:39 -0500
Received: from amavis by kiev.dev.factotummedia.nl with scanned-ok (Exim 3.35
	#1 (Debian)) id 1B9N0l-0002bF-00; Fri, 02 Apr 2004 13:38:59 +0200
Received: from kiev.dev.factotummedia.nl ([127.0.0.1])
	by localhost (kiev [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
	id 09933-01; Fri, 2 Apr 2004 13:38:58 +0200 (CEST)
Received: from pc-thomas.dev.factotummedia.nl ([192.168.3.104])
	by kiev.dev.factotummedia.nl with esmtp (Exim 3.35 #1 (Debian))
	id 1B9N0k-0002b8-00; Fri, 02 Apr 2004 13:38:58 +0200
From: Thomas <zander@javalobby.org>
To: classpath@gnu.org
Date: Fri, 2 Apr 2004 13:41:56 +0200
User-Agent: KMail/1.6.1
References: <40671825.1070100@uqam.ca> <87d66sfp9m.fsf@fleche.redhat.com>
	<406D1FCF.5080208@uqam.ca>
In-Reply-To: <406D1FCF.5080208@uqam.ca>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404021342.23992.zander@javalobby.org>
X-Virus-Scanned: by amavisd-new (Debian) at dev.factotummedia.nl
Cc: commit-classpath@gnu.org
Subject: Re: Rant [Was: Unresolved CVS conflict]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 11:55:45 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 02 April 2004 10:09, Etienne Gagnon wrote:
> > Etienne> Arch is nice but does not allow a single file to be split
> > Etienne> (which does happen regularly, specially when doing
> > Etienne> Object-Oriented development, e.g. spin-off package classes
> > Etienne> [Method=3D> Method + VMMethod]).
> >
> > Subversion can do this?
>
> Of course! =A0Arch's main architect thinks that this should not be needed
> (and argues strongly about "splitting" files), as it would break Arch's
> view of "merging". =A0But, my experience is that splitting a file *does*
> happen.

I tried Arch and found it impossible to use; and really impossible to expla=
in=20
to co-workers that just want to commit. Its very clear the main architect i=
s=20
a long time c-hacker. As arch does not really fit OO code structuring very=
=20
well.  It certainly failed miserably in the error handling and (therefor)=20
usability department.

I never tried subversion; but I still plan to do a pilot on it for my=20
companies development team.

=2D --=20
Regards
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAbVGaCojCW6H2z/QRAjjrAKC5lmyUxjKfJyJOxJd/JVNaeiMJ5wCfcg3P
pHSD95TDlzNfyoVseQEax7k=3D
=3D6Jce
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Fri Apr 02 11:21:55 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9RPf-0002bF-L1
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 11:20:59 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9RLG-0007Xw-TN
	for classpath@gnu.org; Fri, 02 Apr 2004 11:16:26 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9RJx-0006A1-Dd
	for classpath@gnu.org; Fri, 02 Apr 2004 11:15:37 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B9RHs-0004ZR-LR
	for classpath@gnu.org; Fri, 02 Apr 2004 11:12:56 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1B9RHr-0000hy-00
	for <classpath@gnu.org>; Fri, 02 Apr 2004 18:12:55 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1B9RHi-0000cz-00; Fri, 02 Apr 2004 18:12:46 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i32GCfLT009178;
	Fri, 2 Apr 2004 18:12:46 +0200 (MEST)
Message-ID: <406D90F9.802@kaffe.org>
Date: Fri, 02 Apr 2004 18:12:41 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <40659FCD.6010201@uqam.ca>
	<200403290835.47405.konqueror@gmx.de>	<1080564267.18936.12.camel@lyta.haphazard.org>
	<200403291440.29006.konqueror@gmx.de>
In-Reply-To: <200403291440.29006.konqueror@gmx.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: by AMaViS perl-11
Cc: cbj@gnu.org, Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>
Subject: Re: generated files in CVS?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 16:20:40 -0000

Michael Koch wrote:
> Am Montag, 29. März 2004 14:44 schrieb C. Brian Jones:
> 
>>On Mon, 2004-03-29 at 01:35, Michael Koch wrote:
>>
>>>Am Sonntag, 28. März 2004 21:29 schrieb Etienne Gagnon:
>>>
>>>>Mark Wielaard wrote:
>>>>
>>>>>Unless running with --force the auto* tools shouldn't override
>>>>>these files so normally you won't see any diffs when following
>>>>>the HACKING instructions. But there is no particular reason. So
>>>>>please remove them. Make sure to update the HACKING file and
>>>>>send a message to the list how to regenerate these when you do.
>>>>
>>>>I have added a ./autogen.sh script that calls the auto* tools
>>>>with the appropriate arguments, and updated the HACKING files
>>>>accordingly.
>>>>
>>>>So, those of you that "cvs up", simply type:
>>>>   ./autogen.sh
>>>>after updating.
>>>
>>>I really wonder if this primitive script really works on some
>>>non-linux platforms. I will commit an improved version later.
>>
>>Why not just use autoreconf which is usually installed with the
>>autotools.
> 
> 
> Yeah, I totally forgot about this. In the HACKING file I read this:
> 
> The autoreconf script does not always run these as might be expected.
> 
> Does this still apply ? I think it would be best to just use 
> "autoreconf" and give good instructions for uncommon cases in HACKING.

It works well enough with up-to-date versions of autotools. The only 
problem is to teach autoreconf about needing to patch libltdl, and such 
things, which is why we have an autogen.sh script in kaffe.

cheers,
dalibor topic



From MAILER-DAEMON Fri Apr 02 12:01:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9Ry7-0002Mk-5P
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 11:56:35 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9RwH-0000uZ-5T
	for classpath@gnu.org; Fri, 02 Apr 2004 11:54:41 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9Rri-0006Sa-9H
	for classpath@gnu.org; Fri, 02 Apr 2004 11:50:30 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1B9RoD-0003pd-7v; Fri, 02 Apr 2004 11:46:21 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i32GkFjj021819;
	Fri, 2 Apr 2004 11:46:15 -0500
Received: from redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i32GkFj17621; 
	Fri, 2 Apr 2004 11:46:15 -0500
Message-ID: <406D98A3.1010901@redhat.com>
Date: Fri, 02 Apr 2004 11:45:23 -0500
From: graydon hoare <graydon@redhat.com>
User-Agent: Mozilla Thunderbird 0.5 (X11/20040208)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: classpath@gnu.org
References: <4065D116.60308@uqam.ca>
	<1080501381.17922.148.camel@elsschot.wildebeest.org>
	<87ptauku6o.fsf@fleche.redhat.com>
In-Reply-To: <87ptauku6o.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: commit-classpath@gnu.org
Subject: Re: GNU indent for C code
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 16:56:32 -0000

Tom Tromey wrote:

> Perhaps we could just run indent on the code there now.
> Graydon?  Anyone?
> 
> I think it is great to have an indentation style that can be handled
> automatically.

I agree. I am perfectly happy to merge indentation changes to the gui 
branch's C files, I just need to know when you want it to happen and 
what indentation style is preferred. an automatic one would be best; we 
are already committed to reformatting things under jalopy whenever 
possible. I'll need to warn a few people around here to get any 
uncommitted C code changes in (essentially a "flag day" around the office).

managing the divergence caused by java-gui-branch is my responsibility; 
I'll merge it as necessary. it's a choice we made to speed up our 
development, nobody else should pay for that choice.

-graydon




From MAILER-DAEMON Fri Apr 02 13:38:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9TYK-0007Hu-2X
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 13:38:04 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9TYH-0007He-Fg
	for classpath@gnu.org; Fri, 02 Apr 2004 13:38:01 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9TXl-0007Dw-6d
	for classpath@gnu.org; Fri, 02 Apr 2004 13:38:00 -0500
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1B9TXk-0007DX-Dy
	for classpath@gnu.org; Fri, 02 Apr 2004 13:37:28 -0500
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i32IbRjj027511
	for <classpath@gnu.org>; Fri, 2 Apr 2004 13:37:27 -0500
Received: from redhat.com (sebastian-int.corp.redhat.com [172.16.52.221])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i32IbRj25017
	for <classpath@gnu.org>; Fri, 2 Apr 2004 13:37:27 -0500
Message-ID: <406DB2B4.4060706@redhat.com>
Date: Fri, 02 Apr 2004 13:36:36 -0500
From: graydon hoare <graydon@redhat.com>
User-Agent: Mozilla Thunderbird 0.5 (X11/20040208)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: classpath@gnu.org
References: <40671825.1070100@uqam.ca> <87d66sfp9m.fsf@fleche.redhat.com>
	<406D1FCF.5080208@uqam.ca>
	<200404021342.23992.zander__34625.3785341561$1080909746@javalobby.org>
In-Reply-To: <200404021342.23992.zander__34625.3785341561$1080909746@javalobby.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: Rant [Was: Unresolved CVS conflict]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 18:38:02 -0000

Thomas wrote:

> I never tried subversion; but I still plan to do a pilot on it for my 
> companies development team.

subversion's merging capabilities unfortunately aren't much more 
"automatic" than CVS. to be fair to both, if you are "very careful" with 
your assignment of branchpoint and mergepoint tags, you can get a 
reasonable merging experience with them.

but managing all those tags is a fragile pain, so people tend not to do 
it, or to make mistakes. that's a valid complaint; an automation system 
which is too hard to use is not much of an automation system at all. I'm 
working on a distributed VC system (http://www.venge.net/monotone) which 
is a hopefully a bit easier to use. I used it for the last gui -> 
classpath merge and it went well enough.

anyways, for the time being I don't think it's CVS per-se which is 
hurting classpath. I think we can live with CVS well enough for a while.

-graydon



From MAILER-DAEMON Fri Apr 02 13:40:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9Tae-0007qp-Kj
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 13:40:28 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9Tac-0007qK-Kd
	for classpath@gnu.org; Fri, 02 Apr 2004 13:40:26 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9Ta5-0007iF-CS
	for classpath@gnu.org; Fri, 02 Apr 2004 13:40:25 -0500
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1B9TZY-0007cs-Uo; Fri, 02 Apr 2004 13:39:21 -0500
Received: from majestix.konqueror.de (dynadsl-080-228-94-140.ewetel.net
	[80.228.94.140])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i32IcNre002378;
	Fri, 2 Apr 2004 20:38:24 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1B9Sch-0004TN-00; Fri, 02 Apr 2004 19:38:31 +0200
From: Michael Koch <konqueror@gmx.de>
To: Dalibor Topic <robilad@kaffe.org>
Date: Fri, 2 Apr 2004 20:38:12 +0200
User-Agent: KMail/1.5.4
References: <40659FCD.6010201@uqam.ca> <200403291440.29006.konqueror@gmx.de>
	<406D90F9.802@kaffe.org>
In-Reply-To: <406D90F9.802@kaffe.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404022038.12221.konqueror@gmx.de>
X-CheckCompat: OK
Cc: cbj@gnu.org, Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>
Subject: Re: generated files in CVS?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 18:40:27 -0000

Am Freitag, 2. April 2004 18:12 schrieb Dalibor Topic:
>
> It works well enough with up-to-date versions of autotools. The only
> problem is to teach autoreconf about needing to patch libltdl, and
> such things, which is why we have an autogen.sh script in kaffe.

Yes, and exactly this is not needed for GNU classpath so autoreconf 
should fit us.


Michael




From MAILER-DAEMON Fri Apr 02 14:53:26 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9UjF-0007sk-Mi
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 14:53:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9Uj6-0007rV-6V
	for classpath@gnu.org; Fri, 02 Apr 2004 14:53:16 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9UiZ-0007k8-3t
	for classpath@gnu.org; Fri, 02 Apr 2004 14:53:15 -0500
Received: from [213.228.0.169] (helo=postfix3-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B9UiV-0007in-Q3
	for classpath@gnu.org; Fri, 02 Apr 2004 14:52:39 -0500
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112]) by postfix3-2.free.fr (Postfix) with ESMTP
	id 2D545C1FC; Fri,  2 Apr 2004 21:52:31 +0200 (CEST)
Message-ID: <406DC47B.3040703@kaffe.org>
Date: Fri, 02 Apr 2004 21:52:27 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <40633EE9.9040103@kaffe.org>
	<1080489299.17922.11.camel@elsschot.wildebeest.org>
In-Reply-To: <1080489299.17922.11.camel@elsschot.wildebeest.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig5F6BFF5D7EFD60B9B6F0E9BD"
Cc: Classpath List <classpath@gnu.org>
Subject: Re: Object serialization and final fields
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 19:53:24 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig5F6BFF5D7EFD60B9B6F0E9BD
Content-Type: multipart/mixed; boundary="------------040703060709010305020505"

This is a multi-part message in MIME format.
--------------040703060709010305020505
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is the real patch for object serialization. I've added new static 
methods to VMObjectStreamClass and changed the methods called in 
ObjectStreamField accordingly. Note that we need to check all exceptions 
now as the native functions may fail for some other obscure reasons.

ChangeLog entry:

2004-04-02  Guilhem Lavaux <guilhem@kaffe.org>

	* java/io/ObjectStreamField.java
	(setBooleanField, setCharField, setByteField, setShortField,
	setIntField, setLongField, setFloatField, setDoubleField): Use
	native methods directly to be able to set final fields.

	* vm/reference/java/io/VMObjectStreamClass.java
	(setBooleanNative, setCharNative, setByteNative, setShortNative,
	setIntNative, setLongNative, setFloatNative, setDoubleNative):
	New methods for serialization to be able to set final fields.

	* native/jni/java-io/java_io_VMObjectStreamClass.c:
	Implemented new native methods of java.io.VMObjectStreamClass
	accordingly.

Cheers,

Guilhem.

P.S.: If nobody is against, I'll check it in on sunday.

--------------040703060709010305020505
Content-Type: text/plain;
 name="serial_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="serial_patch"

Index: java/io/ObjectStreamField.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectStreamField.java,v
retrieving revision 1.14
diff -u -b -B -r1.14 ObjectStreamField.java
--- java/io/ObjectStreamField.java	26 Feb 2004 07:53:15 -0000	1.14
+++ java/io/ObjectStreamField.java	2 Apr 2004 19:42:15 -0000
@@ -38,9 +38,9 @@
 
 package java.io;
 
+import gnu.java.lang.reflect.TypeSignature;
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
-import gnu.java.lang.reflect.TypeSignature;
 import java.security.AccessController;
 import java.security.PrivilegedAction;
 
@@ -64,7 +64,6 @@
   {
     this (field.getName(), field.getType());
     this.field = field;
-    toset = !Modifier.isFinal(field.getModifiers());
   }
 
   /**
@@ -357,9 +356,9 @@
   {
     try
       {
-	field.setBoolean(obj, val);
+	VMObjectStreamClass.setBooleanNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
@@ -369,9 +368,9 @@
   {
     try
       {
-	field.setByte(obj, val);
+	VMObjectStreamClass.setByteNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
@@ -381,9 +380,9 @@
   {
     try
       {
-	field.setChar(obj, val);
+	VMObjectStreamClass.setCharNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
@@ -393,9 +392,9 @@
   {
     try
       {
-	field.setShort(obj, val);
+	VMObjectStreamClass.setShortNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
@@ -405,9 +404,9 @@
   {
     try
       {
-	field.setInt(obj, val);
+	VMObjectStreamClass.setIntNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
@@ -417,9 +416,9 @@
   {
     try
       {
-	field.setLong(obj, val);
+	VMObjectStreamClass.setLongNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
@@ -429,9 +428,9 @@
   {
     try
       {
-	field.setFloat(obj, val);
+	VMObjectStreamClass.setFloatNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
@@ -441,21 +440,22 @@
   {
     try
       {
-	field.setDouble(obj, val);
+	VMObjectStreamClass.setDoubleNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
   }
   
+  
   final void setObjectField(Object obj, Object val)
   { 
     try
       {
-	field.set(obj, val);
+	VMObjectStreamClass.setObjectNative(field, obj, val);
       }
-    catch(IllegalAccessException x)
+    catch(Exception x)
       {
 	throw new InternalError(x.getMessage());
       }
Index: native/jni/java-io/java_io_VMObjectStreamClass.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-io/java_io_VMObjectStreamClass.c,v
retrieving revision 1.3
diff -u -b -B -r1.3 java_io_VMObjectStreamClass.c
--- native/jni/java-io/java_io_VMObjectStreamClass.c	29 Mar 2004 07:07:27 -0000	1.3
+++ native/jni/java-io/java_io_VMObjectStreamClass.c	2 Apr 2004 19:42:17 -0000
@@ -59,3 +59,195 @@
     }
   return JNI_TRUE;
 }
+
+static jfieldID getFieldReference(JNIEnv *env, jobject field, jobject object, const char *type)
+{
+  jclass fieldClass;
+  jclass objectClass;
+  jfieldID fid;
+  const jbyte *field_name;
+  jmethodID mid;
+  jstring name;
+
+  fieldClass = (*env)->GetObjectClass(env, field);
+
+  mid = (*env)->GetMethodID(env, fieldClass, "getName", "()Ljava/lang/String;");
+  if (mid == NULL)
+    return NULL;
+
+  name = (*env)->CallObjectMethod(env, field, mid);
+  field_name = (*env)->GetStringUTFChars(env, name, NULL);
+  
+  objectClass = (*env)->GetObjectClass(env, object);
+  fid = (*env)->GetFieldID(env, objectClass, field_name, type);
+  if (fid == NULL)
+      return NULL;
+  (*env)->ReleaseStringUTFChars(env, name, field_name);
+  
+  return fid;
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setBooleanNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;Z)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setBooleanNative( JNIEnv * env,
+						   jclass vmosklass,
+						   jobject field,
+						   jobject object,
+						   jboolean value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "Z");
+
+  if (fid != NULL)
+    (*env)->SetBooleanField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setCharNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;C)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setCharNative( JNIEnv * env,
+						jclass vmosklass,
+						jobject field,
+						jobject object,
+						jchar value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "C");
+
+  if (fid != NULL)
+    (*env)->SetCharField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setByteNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;B)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setByteNative( JNIEnv * env,
+						jclass vmosklass,
+						jobject field,
+						jobject object,
+						jbyte value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "B");
+
+  if (fid != NULL)
+    (*env)->SetByteField(env, object, fid, value);
+}
+
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setShortNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;S)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setShortNative( JNIEnv * env,
+						 jclass vmosklass,
+						 jobject field,
+						 jobject object,
+						 jshort value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "S");
+
+  if (fid != NULL)
+    (*env)->SetShortField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setIntNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;I)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setIntNative( JNIEnv * env,
+					       jclass vmosklass,
+					       jobject field,
+					       jobject object,
+					       jint value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "I");
+
+  if (fid != NULL)
+    (*env)->SetIntField(env, object, fid, value);
+}
+
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setLongNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;J)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setLongNative( JNIEnv * env,
+					       jclass vmosklass,
+					       jobject field,
+					       jobject object,
+					       jlong value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "J");
+
+  if (fid != NULL)
+    (*env)->SetLongField(env, object, fid, value);
+}
+
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setFloatNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;F)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setFloatNative( JNIEnv * env,
+						 jclass vmosklass,
+						 jobject field,
+						 jobject object,
+						 jfloat value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "F");
+
+  if (fid != NULL)
+    (*env)->SetFloatField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setDoubleNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;D)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setDoubleNative( JNIEnv * env,
+						 jclass vmosklass,
+						 jobject field,
+						 jobject object,
+						 jdouble value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "D");
+
+  if (fid != NULL)
+    (*env)->SetDoubleField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setObjectNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;Ljava/lang/Object;)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setObjectNative( JNIEnv * env,
+						 jclass vmosklass,
+						 jobject field,
+						 jobject object,
+						 jobject value )
+{
+  jfieldID fid = getFieldReference (env, field, object, NULL);
+
+  if (fid != NULL)
+    (*env)->SetObjectField(env, object, fid, value);
+}
Index: vm/reference/java/io/VMObjectStreamClass.java
===================================================================
RCS file: /cvsroot/classpath/classpath/vm/reference/java/io/VMObjectStreamClass.java,v
retrieving revision 1.1
diff -u -b -B -r1.1 VMObjectStreamClass.java
--- vm/reference/java/io/VMObjectStreamClass.java	17 Jan 2003 16:45:29 -0000	1.1
+++ vm/reference/java/io/VMObjectStreamClass.java	2 Apr 2004 19:42:17 -0000
@@ -38,7 +38,7 @@
 
 package java.io;
 
-import java.lang.reflect.Method;
+import java.lang.reflect.Field;
 
 final class VMObjectStreamClass
 {
@@ -47,4 +47,111 @@
     * (a.k.a. <clinit>).
     */
   static native boolean hasClassInitializer (Class clazz);
+
+  /**
+   * Sets the value of the specified field. This method handles "double".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setDoubleNative(Field field, Object obj, double val);
+
+  /**
+   * Sets the value of the specified field. This method handles "float".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setFloatNative(Field field, Object obj, float val);
+
+  /**
+   * Sets the value of the specified field. This method handles "long".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setLongNative(Field field, Object obj, long val);
+  
+  /**
+   * Sets the value of the specified field. This method handles "int".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setIntNative(Field field, Object obj, int val) 
+    throws IllegalAccessException;
+  
+  /**
+   * Sets the value of the specified field. This method handles "short".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setShortNative(Field field, Object obj, short val) 
+    throws IllegalAccessException;
+
+  /**
+   * Sets the value of the specified field. This method handles "char".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setCharNative(Field field, Object obj, char val) 
+    throws IllegalAccessException;
+
+  /**
+   * Sets the value of the specified field. This method handles "byte".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setByteNative(Field field, Object obj, byte val) 
+    throws IllegalAccessException;
+
+  /**
+   * Sets the value of the specified field. This method handles "boolean".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setBooleanNative(Field field, Object obj, boolean val) 
+    throws IllegalAccessException;
+
+  /**
+   * Sets the value of the specified field. This method handles "object".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setObjectNative(Field field, Object obj, Object val) 
+    throws IllegalAccessException;
+  
 }
+

--------------040703060709010305020505--

--------------enig5F6BFF5D7EFD60B9B6F0E9BD
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAbcR+WRk4qbNiTwgRAhpIAKCO4xnl50+rW/6G+8YGpG5JwRO+WQCfe6XK
2jWMa3iVO4AL1w5aKX9/B8I=
=EGe+
-----END PGP SIGNATURE-----

--------------enig5F6BFF5D7EFD60B9B6F0E9BD--




From MAILER-DAEMON Fri Apr 02 17:09:02 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9WqU-0003Uq-8g
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 17:09:02 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9WqQ-0003U4-Vi
	for classpath@gnu.org; Fri, 02 Apr 2004 17:08:58 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9Wo7-0002LW-79
	for classpath@gnu.org; Fri, 02 Apr 2004 17:07:08 -0500
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1B9WWm-0005L4-M4
	for classpath@gnu.org; Fri, 02 Apr 2004 16:48:40 -0500
Received: (qmail 24162 invoked from network); 2 Apr 2004 21:50:06 -0000
Received: from tf0229.peakpeak.com (HELO fleche.redhat.com) ([204.144.239.229])
	(envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 2 Apr 2004 21:50:06 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id DA9484F82A2; Fri,  2 Apr 2004 14:35:19 -0700 (MST)
To: GNU Classpath Project <classpath@gnu.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Yow!! It's LIBERACE and TUESDAY WELD!! High on a HILL... driving a
	LITTLE CAR...  I wanna be in that LITTLE CAR, too!!  I wanna drive off
	with LIBBY and TUESDAY!
Date: 02 Apr 2004 14:35:19 -0700
Message-ID: <873c7mawrs.fsf@fleche.redhat.com>
Lines: 21
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Proposed coding standard updates
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 22:08:59 -0000

I'd like to propose a couple new extensions to our Java coding
standard.

This comes from ZipEntry:

	dostime = (cal.get(cal.YEAR) - 1980 & 0x7f) << 25

Here, `cal' is a local variable and YEAR is a static field in
Calendar.  This is valid code, but I find it somewhat confusing; the
stuff before "." is evaluated for side effects only.  I'd rather we
not use static members with a non-static qualifier, and instead write
`Calendar.YEAR'.

I'd also like to get rid of unused `import' statements.

These might just be academic for the time being, I don't know if any
current compiler except the one in Eclipse can detect these things.
Still, I'd like to update hacking.texinfo and change these constructs
when they are found.

Tom



From MAILER-DAEMON Fri Apr 02 17:17:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9Wz7-000674-8S
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 17:17:57 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9Wyx-00064U-UJ
	for classpath@gnu.org; Fri, 02 Apr 2004 17:17:47 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9WyQ-0005rG-62
	for classpath@gnu.org; Fri, 02 Apr 2004 17:17:45 -0500
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B9WyP-0005r1-Or
	for classpath@gnu.org; Fri, 02 Apr 2004 17:17:13 -0500
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1B9WyP-0001zE-00
	for <classpath@gnu.org>; Sat, 03 Apr 2004 00:17:13 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1B9WyL-0001yY-00; Sat, 03 Apr 2004 00:17:09 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i32MH9LT013867;
	Sat, 3 Apr 2004 00:17:09 +0200 (MEST)
Message-ID: <406DE665.6070905@kaffe.org>
Date: Sat, 03 Apr 2004 00:17:09 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <873c7mawrs.fsf@fleche.redhat.com>
In-Reply-To: <873c7mawrs.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath Project <classpath@gnu.org>
Subject: Re: Proposed coding standard updates
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 22:17:49 -0000

Tom Tromey wrote:
> I'd like to propose a couple new extensions to our Java coding
> standard.
> 
> This comes from ZipEntry:
> 
> 	dostime = (cal.get(cal.YEAR) - 1980 & 0x7f) << 25
> 
> Here, `cal' is a local variable and YEAR is a static field in
> Calendar.  This is valid code, but I find it somewhat confusing; the
> stuff before "." is evaluated for side effects only.  I'd rather we
> not use static members with a non-static qualifier, and instead write
> `Calendar.YEAR'.
> 
> I'd also like to get rid of unused `import' statements.
> 
> These might just be academic for the time being, I don't know if any
> current compiler except the one in Eclipse can detect these things.
> Still, I'd like to update hacking.texinfo and change these constructs
> when they are found.

I'd like to add that 1980, 0x7f and 25 could also be replaced by more 
meaningfully named constants.

cheers,
dalibor topic



From MAILER-DAEMON Fri Apr 02 17:50:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9XUK-0006bw-7g
	for mharc-classpath@gnu.org; Fri, 02 Apr 2004 17:50:12 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9XUG-0006aL-Q2
	for classpath@gnu.org; Fri, 02 Apr 2004 17:50:08 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9XTi-0006P2-UE
	for classpath@gnu.org; Fri, 02 Apr 2004 17:50:07 -0500
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1B9XTi-0006Ol-IS
	for classpath@gnu.org; Fri, 02 Apr 2004 17:49:34 -0500
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id 70b3dbc4_84f5_11d8_822d_00304811e8c8_25202;
	Fri, 02 Apr 2004 16:31:10 -0600 (CST)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i32Mf2B4023011; 
	Fri, 2 Apr 2004 16:41:02 -0600 (CST)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i32Mf2l3023010;
	Fri, 2 Apr 2004 16:41:02 -0600 (CST) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404022241.i32Mf2l3023010@arch20m.dellroad.org>
In-Reply-To: <406DE665.6070905@kaffe.org>
To: Dalibor Topic <robilad@kaffe.org>
Date: Fri, 2 Apr 2004 16:41:02 -0600 (CST)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: tromey@redhat.com, GNU Classpath Project <classpath@gnu.org>
Subject: Re: Proposed coding standard updates
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Apr 2004 22:50:10 -0000

Dalibor Topic wrote:
> > I'd like to propose a couple new extensions to our Java coding
> > standard.
> > 
> > This comes from ZipEntry:
> > 
> > 	dostime = (cal.get(cal.YEAR) - 1980 & 0x7f) << 25
> > 
> > Here, `cal' is a local variable and YEAR is a static field in
> > Calendar.  This is valid code, but I find it somewhat confusing; the
> > stuff before "." is evaluated for side effects only.  I'd rather we
> > not use static members with a non-static qualifier, and instead write
> > `Calendar.YEAR'.
> > 
> > I'd also like to get rid of unused `import' statements.
> > 
> > These might just be academic for the time being, I don't know if any
> > current compiler except the one in Eclipse can detect these things.
> > Still, I'd like to update hacking.texinfo and change these constructs
> > when they are found.
> 
> I'd like to add that 1980, 0x7f and 25 could also be replaced by more 
> meaningfully named constants.

FYI,

I've found that this book is a good place to start when trying to
define a set of "accepted" coding conventions:

  https://jjguidelines.dev.java.net/book/html/apa.html

Some projects have defined their coding conventions basically
as a "diff" from the ones defined there.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Sat Apr 03 05:41:47 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9iab-0002Nm-OX
	for mharc-classpath@gnu.org; Sat, 03 Apr 2004 05:41:25 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9ia4-0001WE-LK
	for classpath@gnu.org; Sat, 03 Apr 2004 05:40:52 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9iZD-00008h-61
	for classpath@gnu.org; Sat, 03 Apr 2004 05:40:32 -0500
Received: from [62.253.162.46] (helo=mta06-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B9iYE-0006y5-8T
	for classpath@gnu.org; Sat, 03 Apr 2004 05:38:58 -0500
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta06-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040403103852.BQUX10390.mta06-svc.ntlworld.com@cuddles.cambridge.redhat.com>
	for <classpath@gnu.org>; Sat, 3 Apr 2004 11:38:53 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i33AbUCL007595; Sat, 3 Apr 2004 11:37:40 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i33AbT6Y007591;
	Sat, 3 Apr 2004 11:37:29 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16494.37865.120175.70808@cuddles.cambridge.redhat.com>
Date: Sat, 3 Apr 2004 11:37:29 +0100
To: Archie Cobbs <archie@dellroad.org>
In-Reply-To: <200404022241.i32Mf2l3023010@arch20m.dellroad.org>
References: <406DE665.6070905@kaffe.org>
	<200404022241.i32Mf2l3023010@arch20m.dellroad.org>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: tromey@redhat.com, GNU Classpath Project <classpath@gnu.org>
Subject: Re: Proposed coding standard updates
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Apr 2004 10:41:12 -0000

Archie Cobbs writes:
 > Dalibor Topic wrote:
 > > > I'd like to propose a couple new extensions to our Java coding
 > > > standard.
 > > > 
 > > > This comes from ZipEntry:
 > > > 
 > > > 	dostime = (cal.get(cal.YEAR) - 1980 & 0x7f) << 25
 > > > 
 > > > Here, `cal' is a local variable and YEAR is a static field in
 > > > Calendar.  This is valid code, but I find it somewhat confusing; the
 > > > stuff before "." is evaluated for side effects only.  I'd rather we
 > > > not use static members with a non-static qualifier, and instead write
 > > > `Calendar.YEAR'.

I think the writer's intention was to show that the YEAR field was in
the class of the member `cal'.  I don't think you can determine with a
simple one-size-fits-all rule whether this is never an appropriate
thing to do.

 > > > 
 > > > I'd also like to get rid of unused `import' statements.

I won't argue with that.

 > I've found that this book is a good place to start when trying to
 > define a set of "accepted" coding conventions:
 > 
 >   https://jjguidelines.dev.java.net/book/html/apa.html
 > 
 > Some projects have defined their coding conventions basically
 > as a "diff" from the ones defined there.

Some of these are sensible, some of them are not.  I would hope that
patches that break the more obviously sensible ones would be caught at
patch submission time.

Some things are almost an admission of bad language design:

"The synchronized modifier on methods can sometimes cause confusion
during maintenance as well as during debugging. This rule therefore
recommends using synchronized statements as replacements instead."

Andrew.



From MAILER-DAEMON Sat Apr 03 08:01:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9kmV-00072W-9L
	for mharc-classpath@gnu.org; Sat, 03 Apr 2004 08:01:51 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9kmP-0006zl-K6
	for classpath@gnu.org; Sat, 03 Apr 2004 08:01:45 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9kkl-0006NZ-T6
	for classpath@gnu.org; Sat, 03 Apr 2004 08:00:35 -0500
Received: from [213.51.128.198] (helo=smtpq3.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1B9kiM-0005O9-6q
	for classpath@gnu.org; Sat, 03 Apr 2004 07:57:34 -0500
Received: from [213.51.128.133] (port=59802 helo=smtp2.home.nl)
	by smtpq3.home.nl with esmtp (Exim 4.30) id 1B9kiK-0003GR-GS
	for classpath@gnu.org; Sat, 03 Apr 2004 14:57:32 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:33551
	helo=dumas.thomas.planescape.com)
	by smtp2.home.nl with esmtp (Exim 4.30) id 1B9kiJ-0007h7-P2
	for classpath@gnu.org; Sat, 03 Apr 2004 14:57:31 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Sat, 3 Apr 2004 14:56:47 +0200
User-Agent: KMail/1.6.1
References: <406DE665.6070905@kaffe.org>
	<200404022241.i32Mf2l3023010@arch20m.dellroad.org>
	<16494.37865.120175.70808@cuddles.cambridge.redhat.com>
In-Reply-To: <16494.37865.120175.70808@cuddles.cambridge.redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404031456.51892.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: Re: Proposed coding standard updates
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Apr 2004 13:01:47 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 03 April 2004 12:37, Andrew Haley wrote:
> =A0> > > Here, `cal' is a local variable and YEAR is a static field in
> =A0> > > Calendar. =A0This is valid code, but I find it somewhat confusin=
g;
> the > > > stuff before "." is evaluated for side effects only. =A0I'd
> rather we > > > not use static members with a non-static qualifier, and
> instead write > > > `Calendar.YEAR'.
>
> I think the writer's intention was to show that the YEAR field was in
> the class of the member `cal'. =A0I don't think you can determine with a
> simple one-size-fits-all rule whether this is never an appropriate
> thing to do.

Remember that javac gives errors when the 'cal' variable has not been=20
initialized? Even while the used member is a static.
The reason it does that is since a class that extends Calendar could have=20
re-defined the static and the code will use a different value.

To see why; you have to know a little bit more about how the runtime=20
interprets static members.

Consider this:
bla() {
	boolean var =3D Boolean.TRUE.booleanValue();
}

At runtime 'var' will be allocated on the stack.
Then the class 'Boolean' will get parsed and initialized.
Then the TRUE member will be instanciated and placed on the class.
After which the newly created instance 'TRUE" will be used to call=20
booleanValue() upon.

Notice that in case of a basetype this is slightly different.


So, to avoid NullPointerExceptions, wierd assignments etc, it is NEVER a=20
good idea to use an instance to reach a static. Most Java IDEs rightfully=20
bark at such usage since they create misconceptions and real bugs.

I fixed quite some silly bugs in our companies library using IDEA and the=20
detection for this kind of mistakes.

I suggest to run http://findbugs.sourceforge.net/ to search for this (and=20
many other) kind of bugs.

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAbrSPCojCW6H2z/QRAr+PAJ9oSnDRHTjVJELw/pQ960t0ESK9LwCfaV9M
9BXNlgSMyzcYqT1YcaYoNYE=3D
=3Dz8Ol
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Sat Apr 03 21:17:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1B9xCo-0001ZC-Oj
	for mharc-classpath@gnu.org; Sat, 03 Apr 2004 21:17:50 -0500
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1B9xCd-0001J3-DL
	for classpath@gnu.org; Sat, 03 Apr 2004 21:17:39 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1B9xAh-00077B-8d
	for classpath@gnu.org; Sat, 03 Apr 2004 21:16:10 -0500
Received: from [141.45.4.9] (helo=blackhole.ipv6.fhtw-berlin.de)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1B9xAf-0006vC-O6
	for classpath@gnu.org; Sat, 03 Apr 2004 21:15:37 -0500
Received: from threejane.lichteblau.com ([141.45.32.5])
	by blackhole.ipv6.fhtw-berlin.de with smtp (Exim 3.31 #15)
	id 1B9xAY-0009F9-00
	for classpath@gnu.org; Sun, 04 Apr 2004 04:15:30 +0200
Received: (qmail 16527 invoked by uid 1000); 4 Apr 2004 02:15:31 -0000
From: "David Lichteblau" <dave@lichteblau.com>
Date: Sun, 4 Apr 2004 04:15:31 +0200
To: classpath@gnu.org
Message-ID: <20040404021530.GC14262@lichteblau.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ncSAzJYg3Aa9+CRW"
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
Subject: reflection work
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 02:17:43 -0000


--ncSAzJYg3Aa9+CRW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

Grzegorz Prokopski provided a patch (merged from SableVM, I believe)
implementing some tricky parts of the reflection methods in Java.

The patch seems interesting to me in that it handles security checks
portably, so that virtual machines do not have to worry about them.

However, below some comments on other parts of the patch.

Part of the issue here is the handling of native methods.  Reflection
does not currently use VM* classes (neither before nor with the patch),
though the patch tries to go into this direction, I believe.


Regards,
David

>  public final class Constructor
>  extends AccessibleObject implements Member
>  {
> -  private Class clazz;
> -  private int slot;
> +
> +  private Class declaringClass;

Renaming `clazz' to `declaringClass' in Constructor is probably a good
idea given that other reflection classes use the latter name.

> -  private Constructor(Class declaringClass,int slot)
> -  {
> -    this.clazz =3D declaringClass;
> -    this.slot =3D slot;
> -  }
> =20
> -  private Constructor()
> +  byte[] vmData;
> +  private Constructor(byte[] vmData)
>    {
> +    this.vmData =3D vmData;
>    }

As discussed for the vmdata slot in java.lang.Class, the slot (if any)
must be typed java.lang.Object (not byte[]) for some virtual machines.

However, the reflection classes in Classpath currently use the pair of
class object and slot number to identify class members.  While it might
be possible to replace this with a vmdata slot, I do not see a clear
benefit of this change.

There needs to be _some_ way of getting from reflection objects to
virtual machine data, of course.  But java.lang.Class with its vmdata
already solves this problem in a central place.

Keeping this problem centralized instead of introducing vmdata slots all
over the place seems vaguely preferable to me.

>     */
>    public Class getDeclaringClass()
>    {
> -    return clazz;
> +    if (declaringClass =3D=3D null)
> +      {
> +	declaringClass =3D nativeGetDeclaringClass(vmData);
> +      }
> +
> +    return declaringClass;
> +
>    }
> =20
> +  public static native Class nativeGetDeclaringClass(byte[] vmData);

This native method would not be necessary.  The class is already known
at instantiation time.

> -  public native int getModifiers();
> +  public int getModifiers()
> +  {
> +    return nativeGetModifiers(vmData);
> +  }
> +  public native int nativeGetModifiers(byte[] vmData);
> +

The are many such changes in the patch.  (I note that the method was
probably intended to be static.)

Following previous decisions in classpath, the native methods should
probably be moved into VM* classes.

(Personally I am not entirely convinced that making all these methods
static is necessary, except that the VM* class design enforces it.)

>    public Class[] getParameterTypes()
>    {
>      if (parameterTypes =3D=3D null)
> -      return new Class[0];
> +    {
> +      parameterTypes =3D
> +        ReflectUtil.getParameterTypes(nativeGetDescriptor(vmData));
> +
> +    }
>      return parameterTypes;
>    }

Sounds OK to me, except that the virtual machine should know how to do
this anyway, so there is perhaps no pressing need to do this in Java.
It does not save a native method in the end.

> @@ -251,11 +273,174 @@
>      throws InstantiationException, IllegalAccessException,
>             InvocationTargetException
>    {
> -    return constructNative(args, clazz, slot);
> +    /* The following code is more of a hack, than real
> +     * implementation, as it lacks checking and widening. To be
> +     * fixed...*/
[...]

This Java code needs to be fixed before it can replace existing native
implementations.

Also, this and other methods are redundant with similar methods in the
Method class.

> +  private void checkField(Class type, Object o, Class[] acceptTypes) {
> +    if (!Modifier.isStatic(getModifiers())) {
> +      // instance field checks
> +      if (o =3D=3D null) {
> +	throw new NullPointerException();
> +      }
> +
> +      if (!(getDeclaringClass().isInstance(o))) {
> +	throw new IllegalArgumentException();
> +      }
> +    }
> +
> +
> +    // access check
> + =20
> +    // *** TODO ***

Should be completed before commit.

--ncSAzJYg3Aa9+CRW
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAb2/BiGoiD4YyHUgRAn/QAJ4uP0qpYSh7UNY26Qa8JA9OkhXQBACfZ7jQ
awFlRXJ163a5khmx9VsZ/E8=
=YZZa
-----END PGP SIGNATURE-----

--ncSAzJYg3Aa9+CRW--



From MAILER-DAEMON Sun Apr 04 10:16:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BA8Qi-0000A9-3O
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 10:16:56 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BA8QZ-0008N7-Al
	for classpath@gnu.org; Sun, 04 Apr 2004 10:16:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BA8Pg-0007W0-UB
	for classpath@gnu.org; Sun, 04 Apr 2004 10:15:55 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BA8PQ-0007DP-5H
	for classpath@gnu.org; Sun, 04 Apr 2004 10:15:36 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BA8Or-0000WV-00; Sun, 04 Apr 2004 16:15:01 +0200
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200403291647.23978.konqueror@gmx.de>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<406835C9.9060508@dellroad.org>
	<16488.15570.843211.147562@cuddles.cambridge.redhat.com>
	<200403291647.23978.konqueror@gmx.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-QD2E/puQbfp/LTkCzWFb"
Message-Id: <1081088103.7548.102.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 04 Apr 2004 16:15:03 +0200
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 14:16:50 -0000


--=-QD2E/puQbfp/LTkCzWFb
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2004-03-29 at 16:47, Michael Koch wrote:
> Am Montag, 29. M=E4rz 2004 17:12 schrieb Andrew Haley:
> > Archie Cobbs writes:
> [...]
> >  > Object is good because it is automatically the size of a pointer
> >  > on any platform. However, it has one significant disadvantage,
> >  > which is that you must special case all such fields in your
> >  > garbage collector (unless you have a conservative collector).
> >  > byte[] avoids this problem.
> >
> > Indeed, but so does long.  I suppose it's possible that on some weird
> > platform a pointer mat not fit in long.  In gcj was have a class
> > RawData, which we know points to something that isn't an Object and
> > isn't gcable.
>=20
> Yes, gcj has gnu.gcj.RawData.
>=20
> Classpath has gnu.classpath.RawData for the same purpose. It would be=20
> really nice to unify this. I tried once but I saw its a lot of work=20
> needed to change gnu.gcj.RawData to gnu.classpath.RawData (or=20
> gnu.lang.RawData or whatever).

To be honest I think we should not have RawData in Classpath.
It is used in VMClass, but it seems no VM implementor actually likes how
that is setup now. And it is used in some of the new nio implementation
classes. But I have a hard time seeing how our reference JNI
implementation will make use of it. All places where it is used have
unimplemented native jni parts. How are you planning to use this?
Maybe we could add state (a Object or byte[] field to the class) that
holds the real data (=3D=3D address). And some access method to get add the
address it represents (that then might be optimized by a particular VM).
But that would mean that it isn't the same type as the one from libgcj
(or Ptr from kaffe) since those classes are not actually accessed
through normal java code or through JNI, but handled specially through
CNI or Kaffe native/vm code.

As Andrew says we could maybe just use long if we want to store an
address. Andrew also worked hard on getting SWT (Eclipse) 64 bit clean.
What I have seen from the (huge) patch this was mainly done by turning
addresses as stored by JNI from int to long. BTW, was this work ever
accepted into Eclipse?

Cheers,

Mark

--=-QD2E/puQbfp/LTkCzWFb
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAcBhlxVhZCJWr9QwRAkYXAJ4h/V0wOl+68+HQOhWBOrjD2Yra1QCfZ4zY
ADJbkOcqC133KBrSiVIVGog=
=EJat
-----END PGP SIGNATURE-----

--=-QD2E/puQbfp/LTkCzWFb--




From MAILER-DAEMON Sun Apr 04 10:29:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BA8dD-0006g4-8Q
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 10:29:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BA8dA-0006df-6o
	for classpath@gnu.org; Sun, 04 Apr 2004 10:29:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BA8d7-0006ct-QC
	for classpath@gnu.org; Sun, 04 Apr 2004 10:29:46 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BA8d6-0006cB-Uc
	for classpath@gnu.org; Sun, 04 Apr 2004 10:29:45 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BA8ch-0000Y8-00; Sun, 04 Apr 2004 16:29:19 +0200
From: Mark Wielaard <mark@klomp.org>
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <406851DE.1090704@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<16487.60581.925614.63544@cuddles.cambridge.redhat.com>
	<406835C9.9060508@dellroad.org> <40684E49.5080706@uqam.ca>
	<406851DE.1090704@uqam.ca>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-UoTpy7FZv8sC/DkghkXV"
Message-Id: <1081088961.7548.109.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 04 Apr 2004 16:29:21 +0200
Cc: GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 14:29:49 -0000


--=-UoTpy7FZv8sC/DkghkXV
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2004-03-29 at 18:42, Etienne Gagnon wrote:
> Etienne Gagnon wrote:
> >   vmData =3D new byte[PTR_SIZE];
> > or
> >   vmData =3D new RawData();
> > or whatever.
> > So what's the problem, with this?
>=20
> And for those who want to do:
>=20
>    vmData =3D [internalVMpointer]
>=20
> They can deal with it in many ways, such as:
>=20
> 1- make sure [internalVMpointer] points to
>     a non-GC'ed memory, so that GC can  identify
>     it as special;
> 2- Set their internal compiler/interpreter to deal
>     specially with all accesses to vmData (and use
>     flow analysis to track the value propagation).
>=20
> I really think "Object" is the most "general" approach, as Classpath has
> decided to have a "unique, good-for-all-vms" source base approach.

I think I agree when it comes to specific VM state in the VM-interface
classes since those should not even "leak" into the rest of the code at
all. For general state as hold for some native JNI call (which GNU
Classpath also provides for java.net, java.nio, java.io, java.util, etc)
I don't think this is the right approach though. There a combination of
VMClass-shadow-object with possibly a long to hold native JNI (address)
state seems a better approach. There providing a VMClass-shadow-object
also allows VMs that don't use out JNI/Posix/C implementation for these
methods to completely override/replace these classes with their own
implementation (and defines a clear interface that has to be provided).

Cheers,

Mark

--=-UoTpy7FZv8sC/DkghkXV
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAcBvBxVhZCJWr9QwRAsqFAJ9V2HdRShkkPi+HfvAz7dbVwNmufACeJZOP
1gs4qAob5dd6bKiWT2uIA5E=
=01jg
-----END PGP SIGNATURE-----

--=-UoTpy7FZv8sC/DkghkXV--




From MAILER-DAEMON Sun Apr 04 10:39:08 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BA8m4-0006rh-Oj
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 10:39:00 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BA8lw-0006e5-E6
	for classpath@gnu.org; Sun, 04 Apr 2004 10:38:52 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BA8lL-0005pk-P0
	for classpath@gnu.org; Sun, 04 Apr 2004 10:38:47 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BA8lK-0005m1-1u
	for classpath@gnu.org; Sun, 04 Apr 2004 10:38:14 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-151.ewetel.net
	[80.228.94.151])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i34Ebdre014069;
	Sun, 4 Apr 2004 16:37:44 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BA7oq-0004Gx-00; Sun, 04 Apr 2004 15:37:48 +0200
From: Michael Koch <konqueror@gmx.de>
To: Mark Wielaard <mark@klomp.org>
Date: Sun, 4 Apr 2004 16:37:29 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200403291647.23978.konqueror@gmx.de>
	<1081088103.7548.102.camel@elsschot.wildebeest.org>
In-Reply-To: <1081088103.7548.102.camel@elsschot.wildebeest.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Disposition: inline
Message-Id: <200404041637.29773.konqueror@gmx.de>
X-CheckCompat: OK
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mail2.ewetel.de id
	i34Ebdre014069
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 14:38:54 -0000

Am Sonntag, 4. April 2004 16:15 schrieb Mark Wielaard:
> Hi,
>
> On Mon, 2004-03-29 at 16:47, Michael Koch wrote:
> > Am Montag, 29. M=E4rz 2004 17:12 schrieb Andrew Haley:
> > > Archie Cobbs writes:
> >
> > [...]
> >
> > >  > Object is good because it is automatically the size of a
> > >  > pointer on any platform. However, it has one significant
> > >  > disadvantage, which is that you must special case all such
> > >  > fields in your garbage collector (unless you have a
> > >  > conservative collector). byte[] avoids this problem.
> > >
> > > Indeed, but so does long.  I suppose it's possible that on some
> > > weird platform a pointer mat not fit in long.  In gcj was have a
> > > class RawData, which we know points to something that isn't an
> > > Object and isn't gcable.
> >
> > Yes, gcj has gnu.gcj.RawData.
> >
> > Classpath has gnu.classpath.RawData for the same purpose. It would
> > be really nice to unify this. I tried once but I saw its a lot of
> > work needed to change gnu.gcj.RawData to gnu.classpath.RawData (or
> > gnu.lang.RawData or whatever).
>
> To be honest I think we should not have RawData in Classpath.
> It is used in VMClass, but it seems no VM implementor actually likes
> how that is setup now. And it is used in some of the new nio
> implementation classes. But I have a hard time seeing how our
> reference JNI implementation will make use of it. All places where it
> is used have unimplemented native jni parts. How are you planning to
> use this? Maybe we could add state (a Object or byte[] field to the
> class) that holds the real data (=3D=3D address). And some access metho=
d
> to get add the address it represents (that then might be optimized by
> a particular VM). But that would mean that it isn't the same type as
> the one from libgcj (or Ptr from kaffe) since those classes are not
> actually accessed through normal java code or through JNI, but
> handled specially through CNI or Kaffe native/vm code.
>
> As Andrew says we could maybe just use long if we want to store an
> address. Andrew also worked hard on getting SWT (Eclipse) 64 bit
> clean. What I have seen from the (huge) patch this was mainly done by
> turning addresses as stored by JNI from int to long. BTW, was this
> work ever accepted into Eclipse?

The RawData pointer will get the real address to a native memory region.=20
It can be directly used and has always the pointer size of the=20
platform. There will never be problems on platforms with more then 64=20
bit. Its really simply. Its just not done in classpath yet because I=20
developed NIO on gcj so far. This hopefully changes now. (JamVM, be my=20
friend ...).


Michael




From MAILER-DAEMON Sun Apr 04 10:42:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BA8oR-0000yw-Q4
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 10:41:27 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BA8mv-0007ke-So
	for classpath@gnu.org; Sun, 04 Apr 2004 10:39:53 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BA8mC-0006tU-LT
	for classpath@gnu.org; Sun, 04 Apr 2004 10:39:40 -0400
Received: from [62.253.162.43] (helo=mta03-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BA8mB-0006be-37
	for classpath@gnu.org; Sun, 04 Apr 2004 10:39:07 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta03-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040404142331.EGME19713.mta03-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Sun, 4 Apr 2004 15:23:31 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i34EMWCL023173; Sun, 4 Apr 2004 15:22:42 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i34EMVG1023169;
	Sun, 4 Apr 2004 15:22:31 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16496.6695.50788.502328@cuddles.cambridge.redhat.com>
Date: Sun, 4 Apr 2004 15:22:31 +0100
To: Mark Wielaard <mark@klomp.org>
In-Reply-To: <1081088103.7548.102.camel@elsschot.wildebeest.org>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<406835C9.9060508@dellroad.org>
	<16488.15570.843211.147562@cuddles.cambridge.redhat.com>
	<200403291647.23978.konqueror@gmx.de>
	<1081088103.7548.102.camel@elsschot.wildebeest.org>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	Jeroen Frijters <jeroen@sumatra.nl>, GNU Classpath <classpath@gnu.org>,
	Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 14:41:16 -0000

Mark Wielaard writes:
 > 
 > As Andrew says we could maybe just use long if we want to store an
 > address. Andrew also worked hard on getting SWT (Eclipse) 64 bit clean.
 > What I have seen from the (huge) patch this was mainly done by turning
 > addresses as stored by JNI from int to long. BTW, was this work ever
 > accepted into Eclipse?

It's in Eclipse 3, but it's not totally stable yet.  See
https://bugs.eclipse.org/bugs/show_bug.cgi?id=37775 for all the gory
details.

Andrew.



From MAILER-DAEMON Sun Apr 04 14:01:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BABwU-0008Ly-Nd
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 14:01:58 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BABwQ-0008F0-EP
	for classpath@gnu.org; Sun, 04 Apr 2004 14:01:54 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BABwO-0008Dn-2z
	for classpath@gnu.org; Sun, 04 Apr 2004 14:01:53 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BABvh-0007E6-SD
	for classpath@gnu.org; Sun, 04 Apr 2004 14:01:10 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BABva-0000zH-00; Sun, 04 Apr 2004 20:01:02 +0200
From: Mark Wielaard <mark@klomp.org>
To: Guilhem Lavaux <guilhem@kaffe.org>
In-Reply-To: <406DC47B.3040703@kaffe.org>
References: <40633EE9.9040103@kaffe.org>
	<1080489299.17922.11.camel@elsschot.wildebeest.org>
	<406DC47B.3040703@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-n1qWjWcUxjBR7gcgDlUK"
Message-Id: <1081101664.7548.158.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 04 Apr 2004 20:01:04 +0200
Cc: Classpath List <classpath@gnu.org>
Subject: Re: Object serialization and final fields
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 18:01:56 -0000


--=-n1qWjWcUxjBR7gcgDlUK
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Guilhem,

On Fri, 2004-04-02 at 21:52, Guilhem Lavaux wrote:
> Here is the real patch for object serialization. I've added new static=20
> methods to VMObjectStreamClass and changed the methods called in=20
> ObjectStreamField accordingly. Note that we need to check all exceptions=20
> now as the native functions may fail for some other obscure reasons.
>
> 2004-04-02  Guilhem Lavaux <guilhem@kaffe.org>
>=20
> 	* java/io/ObjectStreamField.java
> 	(setBooleanField, setCharField, setByteField, setShortField,
> 	setIntField, setLongField, setFloatField, setDoubleField): Use
> 	native methods directly to be able to set final fields.
>=20
> 	* vm/reference/java/io/VMObjectStreamClass.java
> 	(setBooleanNative, setCharNative, setByteNative, setShortNative,
> 	setIntNative, setLongNative, setFloatNative, setDoubleNative):
> 	New methods for serialization to be able to set final fields.
>=20
> 	* native/jni/java-io/java_io_VMObjectStreamClass.c:
> 	Implemented new native methods of java.io.VMObjectStreamClass
> 	accordingly.
>
> P.S.: If nobody is against, I'll check it in on sunday.

This looks very nice. Thanks.
Some nitpicks:

- You forgot the addition of setObjectNative() in the ChangeLog entry.
- You should regenerate include/java_io_VMObjectStreamClass.h
  This is automatically done when configuring with
  --enable-regen-headers. But should be mentioned in the
  ChangeLog/patch.
- Please chain exceptions. Don't just get the message, use initCause().
- Also catching Exception will miss Error (and subclasses) so you might
  want to catch Throwable.
- But isn't it simpler to let the setXnative() methods throw
  InternalError() directly (or maybe VirtualMachineError or
  IllegalArgumentException which seem more appropriate).
- Then also don't declare the setXNative() methods throws
  IllegalAccessException. Some are declared as such and some not.
  But it seems this is the only exception that should never be thrown.

Could you also add a short notice to the NEWS file about this VM
interface change. You should at least mention that the standard
implementation assumes that the JNI setXField() methods can be used on
final fields.

BTW. Note to VM/Compiler implementers!
--------------------------------------
We discussed "final" fields a bit more on irc.
We came to the conclusion the the VM spec authors and the JLS spec
authors have a different interpretation of "final".
According to the VM spec a final field is non-private read-only, but
rewritable by the Class defining the field.
According the the JLS spec a final field is single assignable (in a
[static] constructor method).
JNI doesn't seem to define precisely what/how final fields can change.
The above patch depends on the fact that in practice JNI setXField() can
be used to set a final field (this was already the case for the
System.setIn()/setOut()/setError() methods).

The following bug reports are also interesting:

http://developer.java.sun.com/developer/bugParade/bugs/4027808.html
Synopsis: [JNI] SetObjectField modifies a final field value
State: Closed, will not be fixed
Evaluation: JNI does not guard against illegal access to objects [...].

http://developer.java.sun.com/developer/bugParade/bugs/4115974.html
Synopsis: Need to be able to tell JIT not to optimize certain finals.
State: Closed, will not be fixed
Evaluation: These are the only thing which should ever behave this way,
so there's no need for a special interface for this.  The JIT just needs
to handle these specially.

http://developer.java.sun.com/developer/bugParade/bugs/4174797.html
Synopsis: Serialization should not use reflection to set final fields
State: Closed, fixed
Evaluation: [...] Serialization needs to use JNI Set<type>Field Routines
to set fields, instead of Field.set*(). [...]

All this seems a bit unfortunate since it basically means that a runtime
cannot optimize final field access since they can always be changed
through JNI and this "feature" is at least necessary for both
System.setIn/Out/Err() and reflection.

Cheers,

Mark

--=-n1qWjWcUxjBR7gcgDlUK
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAcE1fxVhZCJWr9QwRAowIAJ0f7g8yfqCUirgJIOmKdb36f+9IIQCcDcsB
OZCgTsukmOojencD2zYgFY4=
=5zkJ
-----END PGP SIGNATURE-----

--=-n1qWjWcUxjBR7gcgDlUK--




From MAILER-DAEMON Sun Apr 04 14:07:22 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAC1i-0004kn-48
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 14:07:22 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAC1e-0004iu-NH
	for classpath@gnu.org; Sun, 04 Apr 2004 14:07:18 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAByH-0002G0-Fb
	for classpath@gnu.org; Sun, 04 Apr 2004 14:03:54 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BABxo-0001gG-N6
	for classpath@gnu.org; Sun, 04 Apr 2004 14:03:20 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BABxh-00013v-00; Sun, 04 Apr 2004 20:03:13 +0200
From: Mark Wielaard <mark@klomp.org>
To: Guilhem Lavaux <guilhem@kaffe.org>
In-Reply-To: <1081101664.7548.158.camel@elsschot.wildebeest.org>
References: <40633EE9.9040103@kaffe.org>
	<1080489299.17922.11.camel@elsschot.wildebeest.org>
	<406DC47B.3040703@kaffe.org>
	<1081101664.7548.158.camel@elsschot.wildebeest.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-8yuPpSemS3XLD8z3xM8x"
Message-Id: <1081101795.7548.161.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 04 Apr 2004 20:03:15 +0200
Cc: Classpath List <classpath@gnu.org>
Subject: Re: Object serialization and final fields
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 18:07:19 -0000


--=-8yuPpSemS3XLD8z3xM8x
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, 2004-04-04 at 20:01, Mark Wielaard wrote:
> This looks very nice. Thanks.
> Some nitpicks:
> [...]

Last nitpick. I promise!
- Do you have a test case that can be added to Mauve?

Thanks,

Mark

--=-8yuPpSemS3XLD8z3xM8x
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAcE3ixVhZCJWr9QwRAmDTAJ4xu3AAtYNd+D2m+XIIlmdxJNV0XwCgiZOM
EWmqcKyXl9uzMUidjC8kfLs=
=ESZZ
-----END PGP SIGNATURE-----

--=-8yuPpSemS3XLD8z3xM8x--




From MAILER-DAEMON Sun Apr 04 14:37:53 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BACVD-0004ll-84
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 14:37:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BACUy-0004Oa-Fj
	for classpath@gnu.org; Sun, 04 Apr 2004 14:37:36 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BACUn-0004Gl-Dp
	for classpath@gnu.org; Sun, 04 Apr 2004 14:37:26 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BACUm-0004Fn-PL
	for classpath@gnu.org; Sun, 04 Apr 2004 14:37:24 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BACUf-00015C-00; Sun, 04 Apr 2004 20:37:17 +0200
From: Mark Wielaard <mark@klomp.org>
To: Jeroen Frijters <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADC89@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC89@LEMBU.sumatrasoftware.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-aL7dUOiOIfc/9dJaNsGp"
Message-Id: <1081103839.7548.177.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 04 Apr 2004 20:37:19 +0200
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Next release?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 18:37:45 -0000


--=-aL7dUOiOIfc/9dJaNsGp
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2004-03-31 at 10:32, Jeroen Frijters wrote:
> I'm planning my first real IKVM release (to be included with the Mono
> 1.0 release) and I'd like to know when the next GNU Classpath release is
> approximately due. Do you know have a date planned already?

I like our time-based release cycle. We used to do it every three
months, but I think there is enough progress to do it every two months.
The 0.08 release was late by two weeks, but I think we have enough new
things already to just ignore that and do a 0.09 snapshot in the last
week of April. And then 0.10 in the last week of June (hope that is just
in time to make it for that mono 1.0 thing.)

I did think a bit about whether we could guarantee more then just a
time-based snapshot. Some sort of minimal feature based release. But I
am afraid there is just to much to do just yet to make any promise. This
does mean that we will not guarantee that 0.11 or 0.10 will be backwards
compatible with 0.09 though. So you should be prepared for that even
though you want to be included in a 1.0 mono release.

How do other Compiler/VM-integrators feel about this?
gcj and kaffe seem to go their own way mostly. The rest seems to follow
the GNU Classpath release snapshots and recommend out latest release be
combined with their latest release.

Cheers,

Mark

--=-aL7dUOiOIfc/9dJaNsGp
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAcFXexVhZCJWr9QwRAsJvAJ9uMrVJLNsYhTs9o7GeV3B7h9py4ACfSWOU
8140WdvGbw8gPkSVKuxKoKI=
=QnAO
-----END PGP SIGNATURE-----

--=-aL7dUOiOIfc/9dJaNsGp--




From MAILER-DAEMON Sun Apr 04 16:01:31 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BADo8-0003ds-6D
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 16:01:28 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BADo5-0003dA-C0
	for classpath@gnu.org; Sun, 04 Apr 2004 16:01:25 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BADo3-0003cp-RH
	for classpath@gnu.org; Sun, 04 Apr 2004 16:01:24 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BADo3-0003cT-F4
	for classpath@gnu.org; Sun, 04 Apr 2004 16:01:23 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BADna-0001Fx-00; Sun, 04 Apr 2004 22:00:54 +0200
From: Mark Wielaard <mark@klomp.org>
To: Thomas Fitzsimmons <fitzsim@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-GX8R9ZG3m9rpDOJc6JqR"
Message-Id: <1081108856.7548.203.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 04 Apr 2004 22:00:56 +0200
Cc: jikes-dev@www-124.ibm.com, classpath@gnu.org
Subject: jikes CVS vs GNU Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 20:01:26 -0000


--=-GX8R9ZG3m9rpDOJc6JqR
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Thomas,

I can confirm that jikes from CVS is not able anymore to compile GNU
Classpath. But both jikes 1.18 and 1.19 are (1.19 does produce lots and
lots of warnings though).

It seems that it started failing somewhere between jikes CVS from 5 and
8 weeks ago. But I haven't had time to really look into it. It seems
that it is a general problem when the source file arguments contain ".."
in their path (and not our use of the @classes-file construct) as can be
seen by the following example.

$ /usr/local/jikes/bin/jikes +P -bootclasspath /usr/local/classpath/share/c=
lasspath/glibj.zip ../odonata-0.1/src/uk/co/tangency/odonata/test/Demo.java
=20
Found 1 system error:
=20
*** Semantic Error: The input file "../odonata-0.1/src/uk/co/tangency/odona=
ta/test/Demo.java" was not found.

I have CCed the jikes-dev mailinglist since they might know more about
this new/buggy(?) behavior. Should ".." (or in general a path as above
were the directory name is larger then the package name) be allowed in
the source file name? We currently depend on that working for the GNU
Classpath build.

Cheers,

Mark

--=-GX8R9ZG3m9rpDOJc6JqR
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAcGl4xVhZCJWr9QwRAnAcAKCBML56OYGWS9PI8/xk/nUWyjb7VACfb/Y0
f6UTc9DXwq7wtHxaa1qvnVg=
=wyLn
-----END PGP SIGNATURE-----

--=-GX8R9ZG3m9rpDOJc6JqR--




From MAILER-DAEMON Sun Apr 04 17:53:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAFW4-0001gj-C3
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 17:50:56 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAEqK-0006ko-UN
	for classpath@gnu.org; Sun, 04 Apr 2004 17:07:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAEmp-0003zW-22
	for classpath@gnu.org; Sun, 04 Apr 2004 17:04:42 -0400
Received: from [24.159.197.94] (helo=tweedle.cabbey.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAEmo-0003uP-BC
	for classpath@gnu.org; Sun, 04 Apr 2004 17:04:10 -0400
Received: from tweedle (tweedle [10.20.30.32])
	by tweedle.cabbey.net (8.9.3/8.9.3) with ESMTP id QAA24724;
	Sun, 4 Apr 2004 16:03:38 -0500
Date: Sun, 4 Apr 2004 16:03:38 -0500 (CDT)
From: Chris Abbey <jikes@cabbey.net>
X-X-Sender: <cabbey@tweedle.cabbey.net>
To: Mark Wielaard <mark@klomp.org>, <jikes-dev@www-124.southbury.usf.ibm.com>
In-Reply-To: <1081108856.7548.203.camel@elsschot.wildebeest.org>
Message-ID: <Pine.LNX.4.33.0404041525020.17787-100000@tweedle.cabbey.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Mailman-Approved-At: Sun, 04 Apr 2004 17:50:53 -0400
Cc: classpath@gnu.org
Subject: Re: [Jikes-dev] jikes CVS vs GNU Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 21:07:52 -0000

Hey Mark, bad news....

I can confirm the same failure with a simplified test case. In fact it
looks like the handling of .. in any directory path is currently badly
borked in cvs.

I've raised bug 3920 as a sev 9 regression, it will be fixed prior to
1.20, which is on paper for this month. Thanks for the heads up on this,
we'll need to add some "interesting" variations to jacks to see about
covering this.... I'm not even sure that jacks *can* cover this, but we'll
see what we can do.

I don't even want to think about how many build scripts this breaks. :(

-- 
Never make a technical decision based upon the politics of the situation.
Never make a political decision based upon technical issues.
The only place these realms meet is in the mind of the unenlightened.
			-- Geoffrey James, The Zen of Programming







From MAILER-DAEMON Sun Apr 04 18:24:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAG2H-0007TY-4g
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 18:24:13 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAG28-0007MW-4Y
	for classpath@gnu.org; Sun, 04 Apr 2004 18:24:04 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAG1O-0006nm-DJ
	for classpath@gnu.org; Sun, 04 Apr 2004 18:23:57 -0400
Received: from [66.187.237.31] (helo=mx2.redhat.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAG1N-0006cJ-8t
	for classpath@gnu.org; Sun, 04 Apr 2004 18:23:17 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx2.redhat.com (8.11.6/8.11.6) with ESMTP id i34LuWG01543;
	Sun, 4 Apr 2004 17:56:32 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i34MN0j13177; 
	Sun, 4 Apr 2004 18:23:00 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i34MMwe1029437; Sun, 4 Apr 2004 18:22:59 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: James Henstridge <james@daa.com.au>
Content-Type: text/plain
Message-Id: <1081117378.16358.4.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Sun, 04 Apr 2004 18:22:58 -0400
Content-Transfer-Encoding: 7bit
Cc: classpath list <classpath@gnu.org>
Subject: jhbuild and classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 22:24:09 -0000

Hi James,

I've been experimenting with using jhbuild for GNU Classpath
development.  My compliments on jhbuild; it's a very nice tool!

Our AWT implementation relies on GTK, so jhbuild is a natural fit for
us.  And it looks like jhbuild has the potential to make bootstrapping a
Classpath-based development environment dramatically simpler.

I've run into one problem though.  In the GNU Classpath world, we prefer
to have builddir != srcdir, whereas it seems most GNOME modules, and
hence jhbuild, assume builddir == srcdir.  What do you think about
having a builddir != srcdir mode that could be set in .jhbuildrc?

Tom





From MAILER-DAEMON Sun Apr 04 18:41:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAGJJ-0007x3-OA
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 18:41:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAGJG-0007uw-8d
	for classpath@gnu.org; Sun, 04 Apr 2004 18:41:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAGId-0007kv-KW
	for classpath@gnu.org; Sun, 04 Apr 2004 18:41:39 -0400
Received: from [219.160.177.9] (helo=asao.gcd.org)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BAGEj-0005Yp-Jb
	for classpath@gnu.org; Sun, 04 Apr 2004 18:37:05 -0400
Received: (qmail 14336 invoked by uid 10); 5 Apr 2004 07:37:02 +0900
Received: (qmail 97364 invoked by uid 1000); 4 Apr 2004 22:36:50 -0000
Message-ID: <20040404223650.97363.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: GNU Classpath <classpath@gnu.org>
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Mon, 05 Apr 2004 07:36:47 +0900
Sender: kaz@maczuka.gcd.org
Subject: java.nio.channels.FileChannel#lock not implemented
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 22:41:47 -0000

Hi,

java/nio/channels/FileChannelImpl.java has, for example,

  public FileLock lock (long position, long size, boolean shared)
    throws IOException
  {
    ...
    throw new Error ("Not implemented");
  }

What is the schedule for implementing this?

I would like to have this implemented because HSQLDB 1.7.2
(http://hsqldb.sourceforge.net/) requires it.



From MAILER-DAEMON Sun Apr 04 18:50:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAGRJ-0004NX-Hc
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 18:50:05 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAGR0-00040p-7S
	for classpath@gnu.org; Sun, 04 Apr 2004 18:49:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAGQp-0003tt-FP
	for classpath@gnu.org; Sun, 04 Apr 2004 18:49:36 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAGQn-0003pu-CF
	for classpath@gnu.org; Sun, 04 Apr 2004 18:49:33 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BAGQQ-0001g9-00; Mon, 05 Apr 2004 00:49:10 +0200
From: Mark Wielaard <mark@klomp.org>
To: tromey@redhat.com
In-Reply-To: <871xn8h9mt.fsf@fleche.redhat.com>
References: <1080236148.18716.161.camel@elsschot.wildebeest.org>
	<87wu58qpmw.fsf@fleche.redhat.com>
	<1080295746.18716.463.camel@elsschot.wildebeest.org>
	<200403261128.55981.konqueror@gmx.de>
	<1080301292.18716.480.camel@elsschot.wildebeest.org>
	<871xn8h9mt.fsf@fleche.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-NTrEaH5+i63h9aJVQEJH"
Message-Id: <1081118952.7548.253.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 05 Apr 2004 00:49:12 +0200
Cc: classpath@gnu.org, java-patches@gcc.gnu.org,
	Michael Koch <konqueror@gmx.de>
Subject: Re: gtk-peer compile fixes for gcc-2.95
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 22:49:49 -0000


--=-NTrEaH5+i63h9aJVQEJH
Content-Type: multipart/mixed; boundary="=-QNG8Q2ezIARSgL6mTkhh"


--=-QNG8Q2ezIARSgL6mTkhh
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2004-04-01 at 01:36, Tom Tromey wrote:
> It is better to set AM_CFLAGS instead.  You can set this
> in configure.ac just fine.  There's also a standard trick for
> handling gcc-specific options:
>=20
>     AM_CFLAGS=3D
>     if test "$GCC" =3D yes; then
>       AM_CFLAGS=3D'-std=3Dc89 -Wfoo -Wbar'
>     fi
>     AC_SUBST(AM_CFLAGS)

Thanks for that tip.
The attached patch does that and enables -Wall for GNU Classpath.
There are some interesting warnings in the code and I think I already
found one issue with TARGET_NATIVE_FILE_FILEPERMISSION_READONLY that
could prevent proper compilation/execution on certain platforms.

> We set CFLAGS to -g in a specific case, that is sort of different
> since it claims to work around bugs in the infamous gcc "2.96".  I'd
> prefer we avoid this in general.

I have just removed this for now.
Will test on a system with 2.96 when I can.

The patch also removes some of the special JAPHAR and KAFFE support that
hasn't worked for years anyway. (Since as Tom pointed out, we should
remove code that isn't supported anymore anyway.

It fixes all issues found when compiling with -std=3Dc89. Lots in the gtk
peers I am afraid. So please yell and scream if this is to intrusive. It
would be good if the gtk-peer stuff in libgcj was also compiled with
this flag.

No ChangeLog entry for now and not tested much yet (it doesn't seem to
break things spectacularly so I think this is generally OK). Will finish
this later this week. But please let me know if the general idea of the
patch is objectionable.

Cheers,

Mark

--=-QNG8Q2ezIARSgL6mTkhh
Content-Disposition: inline; filename=stdc98.diff
Content-Type: text/x-patch; name=stdc98.diff; charset=iso-8859-1
Content-Transfer-Encoding: base64

SW5kZXg6IGFjaW5jbHVkZS5tNA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2NsYXNz
cGF0aC9jbGFzc3BhdGgvYWNpbmNsdWRlLm00LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMg0K
ZGlmZiAtdSAtcjEuMzIgYWNpbmNsdWRlLm00DQotLS0gYWNpbmNsdWRlLm00CTI5IE1hciAyMDA0
IDA3OjA3OjI0IC0wMDAwCTEuMzINCisrKyBhY2luY2x1ZGUubTQJNCBBcHIgMjAwNCAyMjo0MTo1
MiAtMDAwMA0KQEAgLTEsMTkzICsxLDUgQEANCiBkbmwgVXNlZCBieSBhY2xvY2FsIHRvIGdlbmVy
YXRlIGNvbmZpZ3VyZQ0KIA0KLWRubCBKQVBIQVJfR1JFUF9DRkxBR1MoZmxhZywgY21kX2lmX21p
c3NpbmcsIGNtZF9pZl9wcmVzZW50KQ0KLUFDX0RFRlVOKFtKQVBIQVJfR1JFUF9DRkxBR1NdLA0K
LVtjYXNlICIkQ0ZMQUdTIiBpbg0KLSIkMSIgfCAiJDEgIiogfCAqIiAkMSIgfCAqIiAkMSAiKiAp
DQotICBpZmVsc2UoJCMsIDMsIFskM10sIFs6XSkNCi0gIDs7DQotKikNCi0gICQyDQotICA7Ow0K
LWVzYWMNCi1dKQ0KLQ0KLWRubCBDTEFTU1BBVEhfQ0hFQ0tfSkFQSEFSDQotQUNfREVGVU4oW0NM
QVNTUEFUSF9DSEVDS19KQVBIQVJdLA0KLVsNCi0gIGlmIHRlc3QgIngkMSIgPSB4OyB0aGVuDQot
ICAgIEFDX1BBVEhfUFJPRyhKQVBIQVJfQ09ORklHLCBqYXBoYXItY29uZmlnLCAiIiwgJFBBVEg6
L3Vzci9sb2NhbC9qYXBoYXIvYmluOi91c3IvamFwaGFyL2JpbikNCi0gIGVsc2UNCi0gICAgQUNf
UEFUSF9QUk9HKEpBUEhBUl9DT05GSUcsIGphcGhhci1jb25maWcsICIiLCAkMS9iaW46JFBBVEgp
DQotICBmaQ0KLSAgaWYgdGVzdCAieCR7SkFQSEFSX0NPTkZJR30iID0geDsgdGhlbg0KLSAgICBl
Y2hvICJjb25maWd1cmU6IGNhbm5vdCBmaW5kIGphcGhhci1jb25maWc6IGlzIEphcGhhciBpbnN0
YWxsZWQ/IiAxPiYyDQotICAgIGV4aXQgMQ0KLSAgZmkNCi0gIEFDX01TR19DSEVDS0lORyhmb3Ig
SmFwaGFyKQ0KLSAgSkFQSEFSX1BSRUZJWD0iYCRKQVBIQVJfQ09ORklHIC0tcHJlZml4YCINCi0g
IEpBUEhBUl9DRkxBR1M9ImAkSkFQSEFSX0NPTkZJRyBjb21waWxlYCINCi0gIEpBUEhBUl9MSUJT
PSJgJEpBUEhBUl9DT05GSUcgbGlua2AiDQotICBKVk09InllcyINCi0gIEpWTV9SRUZFUkVOQ0U9
InJlZmVyZW5jZSINCi0gIEFDX1NVQlNUKEpBUEhBUl9QUkVGSVgpDQotICBBQ19TVUJTVChKQVBI
QVJfQ0ZMQUdTKQ0KLSAgQUNfU1VCU1QoSkFQSEFSX0xJQlMpDQotICBBQ19TVUJTVChKVk0pDQot
ICBBQ19TVUJTVChKVk1fUkVGRVJFTkNFKQ0KLSAgY29uZGl0aW9uYWxfd2l0aF9qYXBoYXI9dHJ1
ZQ0KLSAgQUNfTVNHX1JFU1VMVCh5ZXMpDQotDQotICBkbmwgZGVmaW5lIFdJVEhfSkFQSEFSIGZv
ciBuYXRpdmUgY29tcGlsYXRpb24NCi0gIEFDX0RFRklORShXSVRIX0pBUEhBUikNCi0NCi0gIGRu
bCBSZXNldCBwcmVmaXggc28gdGhhdCB3ZSBpbnN0YWxsIGludG8gSmFwaGFyIGRpcmVjdG9yeQ0K
LSAgcHJlZml4PSRKQVBIQVJfUFJFRklYDQotICBBQ19TVUJTVChwcmVmaXgpDQotDQotICBkbmwg
cHJvZ3JhbXMgd2UgcHJvYmFibHkgbmVlZCBzb21ld2hlcmUNCi0gIF90X2JpbmRpcj1gJEpBUEhB
Ul9DT05GSUcgaW5mbyBiaW5kaXJgDQotICBfdF9kYXRhZGlyPWAkSkFQSEFSX0NPTkZJRyBpbmZv
IGRhdGFkaXJgDQotICBBQ19QQVRIX1BST0coSkFQSEFSX0pBQkJBLCBqYXBoYXIsICIiLCAkX3Rf
YmluZGlyOiRQQVRIKQ0KLSAgQUNfUEFUSF9QUk9HKEpBUEhBUl9KQVZBQywgamF2YWMsICIiLCAk
X3RfYmluZGlyOiRQQVRIKQ0KLSAgQUNfUEFUSF9QUk9HKEpBUEhBUl9KQVZBSCwgamF2YWgsICIi
LCAkX3RfYmluZGlyOiRQQVRIKQ0KLSAgQUNfTVNHX0NIRUNLSU5HKGZvciBKYXBoYXIgY2xhc3Nl
cykNCi0gIGlmIHRlc3QgLWUgJF90X2RhdGFkaXIvY2xhc3Nlcy56aXA7IHRoZW4NCi0gICAgSkFQ
SEFSX0NMQVNTTElCPSRfdF9kYXRhZGlyL2NsYXNzZXMuemlwDQotICBlbGlmIHRlc3QgLWUgJF90
X2RhdGFkaXIvY2xhc3Nlcy5qYXI7IHRoZW4NCi0gICAgSkFQSEFSX0NMQVNTTElCPSRfdF9kYXRh
ZGlyL2NsYXNzZXMuamFyDQotICBlbGlmIHRlc3QgLWUgJF90X2RhdGFkaXIvcnQuamFyOyB0aGVu
DQotICAgIEpBUEhBUl9DTEFTU0xJQj0kX3RfZGF0YWRpci9ydC5qYXINCi0gIGVsaWYgdGVzdCAt
ZSAkX3RfZGF0YWRpci9ydC56aXA7IHRoZW4NCi0gICAgSkFQSEFSX0NMQVNTTElCPSRfdF9kYXRh
ZGlyL3J0LnppcA0KLSAgZmkNCi0gIGlmIHRlc3QgJEpBUEhBUl9DTEFTU0xJQiA7IHRoZW4NCi0g
ICAgQUNfTVNHX1JFU1VMVCh5ZXMpDQotICBlbHNlDQotICAgIEFDX01TR19SRVNVTFQobm8pDQot
ICBmaQ0KLSAgQUNfU1VCU1QoSkFQSEFSX0NMQVNTTElCKQ0KLV0pDQotDQotZG5sIENMQVNTUEFU
SF9DSEVDS19LQUZGRQ0KLUFDX0RFRlVOKFtDTEFTU1BBVEhfQ0hFQ0tfS0FGRkVdLA0KLVsNCi0g
IEFDX1BBVEhfUFJPRyhLQUZGRV9DT05GSUcsIGthZmZlLWNvbmZpZywgIiIsICRQQVRIOi91c3Iv
bG9jYWwva2FmZmUvYmluOi91c3Iva2FmZmUvYmluKQ0KLSAgaWYgdGVzdCAieCR7S0FGRkVfQ09O
RklHfSIgPSB4OyB0aGVuDQotICAgIGVjaG8gImNvbmZpZ3VyZTogY2Fubm90IGZpbmQga2FmZmUt
Y29uZmlnOiBpcyBLYWZmZSBpbnN0YWxsZWQ/IiAxPiYyDQotICAgIGV4aXQgMQ0KLSAgZmkNCi0g
IEFDX01TR19DSEVDS0lORyhmb3IgS2FmZmUpDQotDQotICBLQUZGRV9QUkVGSVg9ImAkS0FGRkVf
Q09ORklHIC0tcHJlZml4YCINCi0gIEtBRkZFX0NGTEFHUz0iYCRLQUZGRV9DT05GSUcgY29tcGls
ZWAiDQotICBLQUZGRV9MSUJTPSJgJEtBRkZFX0NPTkZJRyBsaW5rYCINCi0gIEpWTT0ieWVzIg0K
LSAgSlZNX1JFRkVSRU5DRT0ia2FmZmUiDQotICBBQ19TVUJTVChLQUZGRV9QUkVGSVgpDQotICBB
Q19TVUJTVChLQUZGRV9DRkxBR1MpDQotICBBQ19TVUJTVChLQUZGRV9MSUJTKQ0KLSAgQUNfU1VC
U1QoSlZNKQ0KLSAgQUNfU1VCU1QoSlZNX1JFRkVSRU5DRSkNCi0NCi0gIGNvbmRpdGlvbmFsX3dp
dGhfa2FmZmU9dHJ1ZQ0KLSAgQUNfTVNHX1JFU1VMVCh5ZXMpDQotDQotICBkbmwgZGVmaW5lIFdJ
VEhfS0FGRkUgZm9yIG5hdGl2ZSBjb21waWxhdGlvbg0KLSAgQUNfREVGSU5FKFdJVEhfS0FGRkUp
DQotDQotICBkbmwgUmVzZXQgcHJlZml4IHNvIHRoYXQgd2UgaW5zdGFsbCBpbnRvIHRoZSBLYWZm
ZSBkaXJlY3RvcnkNCi0gIHByZWZpeD0kS0FGRkVfUFJFRklYDQotICBBQ19TVUJTVChwcmVmaXgp
DQotDQotICBkbmwgcHJvZ3JhbXMgd2UgcHJvYmFibHkgbmVlZCBzb21ld2hlcmUNCi0gIF90X2Jp
bmRpcj1gJEtBRkZFX0NPTkZJRyBpbmZvIGJpbmRpcmANCi0gIF90X2RhdGFkaXI9YCRLQUZGRV9D
T05GSUcgaW5mbyBkYXRhZGlyYA0KLSAgQUNfUEFUSF9QUk9HKEtBRkZFX0pBQkJBLCBrYWZmZSwg
IiIsICRfdF9iaW5kaXI6JFBBVEgpDQotDQotICBBQ19NU0dfQ0hFQ0tJTkcoZm9yIGtqYykNCi0g
IGlmIHRlc3QgLWUgJF90X2RhdGFkaXIva2FmZmUva2pjLmphcjsgdGhlbg0KLSAgICBLSkNfQ0xB
U1NQQVRIPSRfdF9kYXRhZGlyL2thZmZlL2tqYy5qYXINCi0gICAgQUNfU1VCU1QoS0pDX0NMQVNT
UEFUSCkNCi0gICAgY29uZGl0aW9uYWxfd2l0aF9ramM9dHJ1ZQ0KLSAgICBBQ19NU0dfUkVTVUxU
KCR7d2l0aHZhbH0pDQotICBlbGlmIHRlc3QgLWUgJF90X2RhdGFkaXIva2pjLmphcjsgdGhlbg0K
LSAgICBLSkNfQ0xBU1NQQVRIPSRfdF9kYXRhZGlyL2tqYy5qYXINCi0gICAgQUNfU1VCU1QoS0pD
X0NMQVNTUEFUSCkNCi0gICAgY29uZGl0aW9uYWxfd2l0aF9ramM9dHJ1ZQ0KLSAgICBBQ19NU0df
UkVTVUxUKCR7d2l0aHZhbH0pDQotICBlbHNlDQotICAgIGNvbmRpdGlvbmFsX3dpdGhfa2pjPWZh
bHNlDQotICAgIEFDX01TR19SRVNVTFQobm8pDQotICBmaQ0KLSAgDQotICBBQ19QQVRIX1BST0co
S0FGRkVfSkFWQUgsIGthZmZlaCwgIiIsICRfdF9iaW5kaXI6JFBBVEgpDQotDQotICBBQ19NU0df
Q0hFQ0tJTkcoZm9yIEthZmZlIGNsYXNzZXMpDQotICBLQUZGRV9DTEFTU0xJQj0iIg0KLSAgaWYg
dGVzdCAtZSAkX3RfZGF0YWRpci9nbGliai5qYXI7IHRoZW4NCi0gICAgS0FGRkVfQ0xBU1NMSUI9
JF90X2RhdGFkaXIvZ2xpYmouamFyDQotICBlbGlmIHRlc3QgLWUgJF90X2RhdGFkaXIva2FmZmUv
Z2xpYmouamFyOyB0aGVuDQotICAgIEtBRkZFX0NMQVNTTElCPSRfdF9kYXRhZGlyL2thZmZlL2ds
aWJqLmphcg0KLSAgZWxpZiB0ZXN0IC1lICRfdF9kYXRhZGlyL0tsYXNzZXMuamFyOyB0aGVuDQot
ICAgIEtBRkZFX0NMQVNTTElCPSRfdF9kYXRhZGlyL0tsYXNzZXMuamFyDQotICBlbGlmIHRlc3Qg
LWUgJF90X2RhdGFkaXIva2FmZmUvS2xhc3Nlcy5qYXI7IHRoZW4NCi0gICAgS0FGRkVfQ0xBU1NM
SUI9JF90X2RhdGFkaXIva2FmZmUvS2xhc3Nlcy5qYXINCi0gIGVsc2UNCi0gICAgQUNfTVNHX1JF
U1VMVChubykNCi0gIGZpDQotICBBQ19NU0dfUkVTVUxUKHllcykNCi0gIGlmIHRlc3QgLWUgJF90
X2RhdGFkaXIvcm1pLmphcjsgdGhlbg0KLSAgICBLQUZGRV9DTEFTU0xJQj0kS0FGRkVfQ0xBU1NM
SUI6JF90X2RhdGFkaXIvcm1pLmphcg0KLSAgZmkNCi0gIGlmIHRlc3QgLWUgJF90X2RhdGFkaXIv
a2FmZmUvcm1pLmphcjsgdGhlbg0KLSAgICBLQUZGRV9DTEFTU0xJQj0kS0FGRkVfQ0xBU1NMSUI6
JF90X2RhdGFkaXIva2FmZmUvcm1pLmphcg0KLSAgZmkNCi0gIGlmIHRlc3QgLWUgJF90X2RhdGFk
aXIvdG9vbHMuamFyOyB0aGVuDQotICAgIEtBRkZFX0NMQVNTTElCPSRLQUZGRV9DTEFTU0xJQjok
X3RfZGF0YWRpci90b29scy5qYXINCi0gIGZpDQotICBpZiB0ZXN0IC1lICRfdF9kYXRhZGlyL2th
ZmZlL3Rvb2xzLmphcjsgdGhlbg0KLSAgICBLQUZGRV9DTEFTU0xJQj0kS0FGRkVfQ0xBU1NMSUI6
JF90X2RhdGFkaXIva2FmZmUvdG9vbHMuamFyDQotICBmaQ0KLQ0KLSAgQUNfU1VCU1QoS0FGRkVf
Q0xBU1NMSUIpDQotXSkNCi0NCi1kbmwgQ0xBU1NQQVRIX1dJVEhfSkFQSEFSIC0gY2hlY2tzIGZv
ciBqYXBoYXINCi1BQ19ERUZVTihbQ0xBU1NQQVRIX1dJVEhfSkFQSEFSXSwNCi1bDQotICBBQ19B
UkdfV0lUSChqYXBoYXIsIA0KLSAgWyAgLS13aXRoLWphcGhhcgkJICBjb25maWd1cmUgR05VIENs
YXNzcGF0aCBmb3IgSmFwaGFyIFtkZWZhdWx0PXllc11dLA0KLSAgWw0KLSAgICBpZiB0ZXN0ICJ4
JHt3aXRodmFsfSIgPSB4eWVzIHx8IHRlc3QgIngke3dpdGh2YWx9IiA9IHg7IHRoZW4NCi0gICAg
ICBDTEFTU1BBVEhfQ0hFQ0tfSkFQSEFSDQotICAgIGVsaWYgdGVzdCAieCR7d2l0aHZhbH0iICE9
IHhubyB8fCB0ZXN0ICJ4JHt3aXRodmFsfSIgIT0geGZhbHNlOyB0aGVuDQotICAgICAgQ0xBU1NQ
QVRIX0NIRUNLX0pBUEhBUigke3dpdGh2YWx9KQ0KLSAgICBmaQ0KLSAgXSwNCi0gIFsgDQotICAg
IGNvbmRpdGlvbmFsX3dpdGhfamFwaGFyPWZhbHNlDQotICAgIEpBUEhBUl9DRkxBR1M9IiINCi0g
ICAgQUNfU1VCU1QoSkFQSEFSX0NGTEFHUykNCi0gIF0pDQotXSkNCi0NCi1kbmwgQ0xBU1NQQVRI
X1dJVEhfS0FGRkUgLSBjaGVja3MgZm9yIHdoaWNoIGphdmEgdmlydHVhbCBtYWNoaW5lIHRvIHVz
ZQ0KLUFDX0RFRlVOKFtDTEFTU1BBVEhfV0lUSF9LQUZGRV0sDQotWw0KLSAgQUNfQVJHX1dJVEgo
a2FmZmUsIA0KLSAgWyAgLS13aXRoLWthZmZlCQkgIGNvbmZpZ3VyZSBHTlUgQ2xhc3NwYXRoIGZv
ciBLYWZmZSBbZGVmYXVsdD1ub11dLA0KLSAgWyAgIA0KLSAgICBpZiB0ZXN0ICJ4JHt3aXRodmFs
fSIgPSB4eWVzIHx8IHRlc3QgIngke3dpdGh2YWx9IiA9IHg7IHRoZW4NCi0gICAgICBDTEFTU1BB
VEhfQ0hFQ0tfS0FGRkUNCi0gICAgZmkNCi0gIF0sDQotICBbIGNvbmRpdGlvbmFsX3dpdGhfa2Fm
ZmU9ZmFsc2UNCi0gICAgS0FGRkVfQ0ZMQUdTPSIiDQotICAgIEFDX1NVQlNUKEtBRkZFX0NGTEFH
UykNCi0gIF0pDQotXSkNCi0NCiBkbmwgdGhyZWFkcyBwYWNrYWdlcyAobW9zdGx5IHN0b2xlbiBm
cm9tIEphcGhhcikNCiBkbmwgZ2l2ZW4gdGhhdCBqYXBoYXItY29uZmlnIGdpdmVzIC1scHRocmVh
ZCwgbWF5IG5vdCBuZWVkIHRoaXMgKGNiaikNCiBBQ19ERUZVTihbQ0xBU1NQQVRIX0NIRUNLX1RI
UkVBRFNdLA0KSW5kZXg6IGNvbmZpZ3VyZS5hYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNy
b290L2NsYXNzcGF0aC9jbGFzc3BhdGgvY29uZmlndXJlLmFjLHYNCnJldHJpZXZpbmcgcmV2aXNp
b24gMS4xMw0KZGlmZiAtdSAtcjEuMTMgY29uZmlndXJlLmFjDQotLS0gY29uZmlndXJlLmFjCTI5
IE1hciAyMDA0IDA3OjA3OjI0IC0wMDAwCTEuMTMNCisrKyBjb25maWd1cmUuYWMJNCBBcHIgMjAw
NCAyMjo0MTo1MiAtMDAwMA0KQEAgLTExMCwxNSArMTEwLDExIEBADQogICBkbmwgRklYTUUgLSBk
b2VzIG5vdCBhbGxvdyBjcm9zcyBjb21waWxpbmcNCiAgIEFDX0NfQklHRU5ESUFODQogDQotICBk
bmwgV2Ugd2FudCB0byBhdm9pZCAtTzIgYXQgdGhlIG1vbWVudCwgZ2NjIDIuOTYgZnJvbSBSZWQg
SGF0IDcNCi0gIGRubCBjYW5ub3QgY29tcGlsZSBzb21lIG5hdGl2ZSBmdW5jdGlvbnMgKGdjYyBl
cnJvcnMpIHdpdGggdGhpcw0KLSAgZG5sIGZsYWcuDQotICBDRkxBR1M9Ii1nIiANCi0NCi0gIGRu
bCBXZSB3YW50IHdhcm5pbmdzLCBsb3RzIG9mIHdhcm5pbmdzIDotKQ0KKyAgQU1fQ0ZMQUdTPQ0K
ICAgaWYgdGVzdCAieCR7R0NDfSIgPSB4eWVzOyB0aGVuDQotICAgIEpBUEhBUl9HUkVQX0NGTEFH
UygtV2FsbCwgWyBDRkxBR1M9IiRDRkxBR1MgLVdhbGwiIF0pDQorICAgIEFNX0NGTEFHUz0nLXN0
ZD1jODkgLVdhbGwnDQogICBmaQ0KKyAgQUNfU1VCU1QoQU1fQ0ZMQUdTKQ0KIA0KICAgZG5sIENo
ZWNrIGZvciBBV1QgcmVsYXRlZCBndGhyZWFkL2d0ay9saWJhcnRfbGdwbA0KICAgaWYgdGVzdCAi
eCR7Q09NUElMRV9HVEtfUEVFUn0iID0geHllczsgdGhlbg0KQEAgLTIxNCwyMyArMjEwLDYgQEAN
CiAgICAgICAgICAgICAgICAgZmkNCiAgICAgICAgICAgICAgIF0pDQogQUNfU1VCU1QoSU5JVF9M
T0FEX0xJQlJBUlkpDQotZG5sIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tDQotDQotDQotZG5sIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQotZG5sIFNtYWxsIGxvb3AgdG8g
YWRkIG90aGVyIHRoaW5ncyB0byBFWFRSQV9JTkNMVURFUyBmcm9tIGEgVk0NCi1kbmwgLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCi1k
bmwgZm9yIGkgaW4gJEpBUEhBUl9DRkxBR1MgJEtBRkZFX0NGTEFHUyA7IGRvDQotZG5sICAgYWRk
X3RvX2V4dHJhX2luY2x1ZGVzPTENCi1kbmwgICBmb3IgaiBpbiAkRVhUUkFfSU5DTFVERVMgOyBk
bw0KLWRubCAgICAgaWYgdGVzdCAkaSA9ICRqIDsgdGhlbg0KLWRubCAgICAgICBhZGRfdG9fZXh0
cmFfaW5jbHVkZXM9MA0KLWRubCAgICAgZmkNCi1kbmwgICBkb25lDQotZG5sICAgaWYgdGVzdCAk
YWRkX3RvX2V4dHJhX2luY2x1ZGVzIC1lcSAxOyB0aGVuDQotZG5sICAgICBFWFRSQV9JTkNMVURF
Uz0iJEVYVFJBX0lOQ0xVREVTICRpIg0KLWRubCAgIGZpDQotZG5sIGRvbmUNCiBkbmwgLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCiAN
CiANCkluZGV4OiBuYXRpdmUvZmRsaWJtL01ha2VmaWxlLmFtDQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmls
ZTogL2N2c3Jvb3QvY2xhc3NwYXRoL2NsYXNzcGF0aC9uYXRpdmUvZmRsaWJtL01ha2VmaWxlLmFt
LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4yDQpkaWZmIC11IC1yMS4yIE1ha2VmaWxlLmFtDQot
LS0gbmF0aXZlL2ZkbGlibS9NYWtlZmlsZS5hbQk3IEZlYiAyMDAyIDE0OjE4OjQ1IC0wMDAwCTEu
Mg0KKysrIG5hdGl2ZS9mZGxpYm0vTWFrZWZpbGUuYW0JNCBBcHIgMjAwNCAyMjo0MTo1NCAtMDAw
MA0KQEAgLTE1LDcgKzE1LDYgQEANCiAJCQllX3NxcnQuYyBcDQogCQkJZmRsaWJtLmggXA0KIAkJ
CWllZWVmcC5oIFwNCi0JCQlqYXZhLWFzc2VydC5oIFwNCiAJCQlrX2Nvcy5jIFwNCiAJCQlrX3Jl
bV9waW8yLmMgXA0KIAkJCWtfc2luLmMgXA0KSW5kZXg6IG5hdGl2ZS9mZGxpYm0vamF2YS1hc3Nl
cnQuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IG5hdGl2ZS9mZGxpYm0vamF2YS1hc3NlcnQuaA0K
ZGlmZiAtTiBuYXRpdmUvZmRsaWJtL2phdmEtYXNzZXJ0LmgNCi0tLSBuYXRpdmUvZmRsaWJtL2ph
dmEtYXNzZXJ0LmgJNSBOb3YgMjAwMSAwMjo1Njo0NyAtMDAwMAkxLjENCisrKyAvZGV2L251bGwJ
MSBKYW4gMTk3MCAwMDowMDowMCAtMDAwMA0KQEAgLTEsMzggKzAsMCBAQA0KLS8vIGphdmEtYXNz
ZXJ0LmggLSBIZWFkZXIgZmlsZSBob2xkaW5nIGFzc2VydGlvbiBkZWZpbml0aW9ucy4gIC0qLSBj
KysgLSotDQotDQotLyogQ29weXJpZ2h0IChDKSAxOTk4LCAxOTk5ICBGcmVlIFNvZnR3YXJlIEZv
dW5kYXRpb24NCi0NCi0gICBUaGlzIGZpbGUgaXMgcGFydCBvZiBsaWJnY2ouDQotDQotVGhpcyBz
b2Z0d2FyZSBpcyBjb3B5cmlnaHRlZCB3b3JrIGxpY2Vuc2VkIHVuZGVyIHRoZSB0ZXJtcyBvZiB0
aGUNCi1MaWJnY2ogTGljZW5zZS4gIFBsZWFzZSBjb25zdWx0IHRoZSBmaWxlICJMSUJHQ0pfTElD
RU5TRSIgZm9yDQotZGV0YWlscy4gICovDQotDQotI2lmbmRlZiBfX0pBVkFfQVNTRVJUX0hfXw0K
LSNkZWZpbmUgX19KQVZBX0FTU0VSVF9IX18NCi0NCi0vLyBUaGlzIGlzIGEgbGliZ2NqIGltcGxl
bWVudGF0aW9uIGhlYWRlci4NCi0NCi12b2lkIF9Kdl9BYm9ydCAoY29uc3QgY2hhciAqLCBjb25z
dCBjaGFyICosIGludCwgY29uc3QgY2hhciAqKQ0KLSAgX19hdHRyaWJ1dGVfXyAoKF9fbm9yZXR1
cm5fXykpOw0KLQ0KLSNpZmRlZiBERUJVRw0KLSNkZWZpbmUgX0p2X0Fzc2VydERvQ2FsbChNZXNz
YWdlKSBfSnZfQWJvcnQgKF9fRlVOQ1RJT05fXywgX19GSUxFX18sIF9fTElORV9fLCBNZXNzYWdl
KQ0KLQ0KLSNkZWZpbmUgSnZBc3NlcnRNZXNzYWdlKEV4cHIsIE1lc3NhZ2UpIFwNCi0gICBkbyB7
IGlmICghIChFeHByKSkgX0p2X0Fzc2VydERvQ2FsbCAoTWVzc2FnZSk7IH0gd2hpbGUgKDApDQot
I2RlZmluZSBKdkFzc2VydChFeHByKSBcDQotICAgZG8geyBpZiAoISAoRXhwcikpIF9Kdl9Bc3Nl
cnREb0NhbGwgKCMgRXhwcik7IH0gd2hpbGUgKDApDQotDQotI2RlZmluZSBKdkZhaWwoTWVzc2Fn
ZSkgX0p2X0Fzc2VydERvQ2FsbCAoTWVzc2FnZSkNCi0NCi0jZWxzZSAvKiBERUJVRyAqLw0KLQ0K
LSNkZWZpbmUgX0p2X0Fzc2VydERvQ2FsbChNZXNzYWdlKQ0KLSNkZWZpbmUgSnZBc3NlcnRNZXNz
YWdlKEV4cHIsIE1lc3NhZ2UpDQotI2RlZmluZSBKdkFzc2VydChFeHByKQ0KLSNkZWZpbmUgSnZG
YWlsKE1lc3NhZ2UpIF9Kdl9BYm9ydCAoMCwgMCwgMCwgTWVzc2FnZSkNCi0NCi0jZW5kaWYgLyog
bm90IERFQlVHICovDQotDQotI2VuZGlmIC8qIF9fSkFWQV9BU1NFUlRfSF9fICovDQpJbmRleDog
bmF0aXZlL2ZkbGlibS9tcHJlYy5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3QvY2xh
c3NwYXRoL2NsYXNzcGF0aC9uYXRpdmUvZmRsaWJtL21wcmVjLmMsdg0KcmV0cmlldmluZyByZXZp
c2lvbiAxLjMNCmRpZmYgLXUgLXIxLjMgbXByZWMuYw0KLS0tIG5hdGl2ZS9mZGxpYm0vbXByZWMu
YwkyOSBNYXIgMjAwNCAwNzowNzoyNiAtMDAwMAkxLjMNCisrKyBuYXRpdmUvZmRsaWJtL21wcmVj
LmMJNCBBcHIgMjAwNCAyMjo0MTo1NCAtMDAwMA0KQEAgLTgyLDcgKzgyLDYgQEANCiANCiAjaW5j
bHVkZSA8c3RkbGliLmg+DQogI2luY2x1ZGUgPHN0cmluZy5oPg0KLSNpbmNsdWRlIDxqYXZhLWFz
c2VydC5oPg0KICNpbmNsdWRlICJtcHJlYy5oIg0KIA0KIC8qIHJlZW50LmMga25vd3MgdGhpcyB2
YWx1ZSAqLw0KSW5kZXg6IG5hdGl2ZS9mZGxpYm0vbXByZWMuaA0KPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp
bGU6IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvbmF0aXZlL2ZkbGlibS9tcHJlYy5oLHYN
CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zDQpkaWZmIC11IC1yMS4zIG1wcmVjLmgNCi0tLSBuYXRp
dmUvZmRsaWJtL21wcmVjLmgJMjkgTWFyIDIwMDQgMDc6MDc6MjYgLTAwMDAJMS4zDQorKysgbmF0
aXZlL2ZkbGlibS9tcHJlYy5oCTQgQXByIDIwMDQgMjI6NDE6NTQgLTAwMDANCkBAIC0zMiwxMCAr
MzIsNiBAQA0KICNpbmNsdWRlIDxjb25maWcuaD4NCiAjaW5jbHVkZSAiaWVlZWZwLmgiDQogDQot
Ly8gI2luY2x1ZGUgPG1hdGguaD4NCi0vLyAjaW5jbHVkZSA8ZmxvYXQuaD4NCi0vLyAjaW5jbHVk
ZSA8ZXJybm8uaD4NCi0NCiAjaWYgZGVmaW5lZCBIQVZFX1NURElOVF9IDQogI2luY2x1ZGUgPHN0
ZGludC5oPg0KICNlbGlmIGRlZmluZWQgSEFWRV9JTlRUWVBFU19IDQpAQCAtNjEsNyArNTcsNyBA
QA0KICNlbmRpZg0KIA0KICNpZiAhZGVmaW5lZCBIQVZFX0JTRF9JTlQzMl9ERUZJTkVEICYmICFk
ZWZpbmVkIEhBVkVfSU5UMzJfREVGSU5FRA0KLS8vIEZJWE1FIC0tIHRoaXMgY291bGQgaGF2ZSBw
cm9ibGVtcyB3aXRoIHN5c3RlbXMgdGhhdCBkb24ndCBkZWZpbmUgU0kgdG8gYmUgNA0KKy8qIEZJ
WE1FIHRoaXMgY291bGQgaGF2ZSBwcm9ibGVtcyB3aXRoIHN5c3RlbXMgdGhhdCBkb24ndCBkZWZp
bmUgU0kgdG8gYmUgNCAqLw0KIHR5cGVkZWYgaW50IGludDMyX3QgX19hdHRyaWJ1dGVfXygobW9k
ZShTSSkpKTsNCiANCiAvKiBUaGlzIGlzIGEgYmxhdGFudCBoYWNrOiBvbiBTb2xhcmlzIDIuNSwg
cHRocmVhZC5oIGRlZmluZXMgdWludDMyX3QNCkluZGV4OiBuYXRpdmUvam5pL2d0ay1wZWVyL2du
dV9qYXZhX2F3dF9wZWVyX2d0a19HdGtDaGVja2JveFBlZXIuYw0KPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZp
bGU6IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvbmF0aXZlL2puaS9ndGstcGVlci9nbnVf
amF2YV9hd3RfcGVlcl9ndGtfR3RrQ2hlY2tib3hQZWVyLmMsdg0KcmV0cmlldmluZyByZXZpc2lv
biAxLjEwDQpkaWZmIC11IC1yMS4xMCBnbnVfamF2YV9hd3RfcGVlcl9ndGtfR3RrQ2hlY2tib3hQ
ZWVyLmMNCi0tLSBuYXRpdmUvam5pL2d0ay1wZWVyL2dudV9qYXZhX2F3dF9wZWVyX2d0a19HdGtD
aGVja2JveFBlZXIuYwkyOSBNYXIgMjAwNCAwNzowNzoyNiAtMDAwMAkxLjEwDQorKysgbmF0aXZl
L2puaS9ndGstcGVlci9nbnVfamF2YV9hd3RfcGVlcl9ndGtfR3RrQ2hlY2tib3hQZWVyLmMJNCBB
cHIgMjAwNCAyMjo0MTo1NCAtMDAwMA0KQEAgLTIzMCw3ICsyMzAsNiBAQA0KIHN0YXRpYyB2b2lk
DQogaXRlbV90b2dnbGVkIChHdGtUb2dnbGVCdXR0b24gKml0ZW0sIGpvYmplY3QgcGVlcikNCiB7
DQotICAvL2dfcHJpbnQgKCJ0b2dnbGVkXG4iKTsNCiAgICgqZ2RrX2VudiktPkNhbGxWb2lkTWV0
aG9kIChnZGtfZW52LCBwZWVyLA0KIAkJCSAgICAgIHBvc3RJdGVtRXZlbnRJRCwNCiAJCQkgICAg
ICBwZWVyLA0KSW5kZXg6IG5hdGl2ZS9qbmkvZ3RrLXBlZXIvZ251X2phdmFfYXd0X3BlZXJfZ3Rr
X0d0a0NvbXBvbmVudFBlZXIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2NsYXNz
cGF0aC9jbGFzc3BhdGgvbmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9hd3RfcGVlcl9ndGtf
R3RrQ29tcG9uZW50UGVlci5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMw0KZGlmZiAtdSAt
cjEuMjMgZ251X2phdmFfYXd0X3BlZXJfZ3RrX0d0a0NvbXBvbmVudFBlZXIuYw0KLS0tIG5hdGl2
ZS9qbmkvZ3RrLXBlZXIvZ251X2phdmFfYXd0X3BlZXJfZ3RrX0d0a0NvbXBvbmVudFBlZXIuYwky
OSBNYXIgMjAwNCAwNzowNzoyNiAtMDAwMAkxLjIzDQorKysgbmF0aXZlL2puaS9ndGstcGVlci9n
bnVfamF2YV9hd3RfcGVlcl9ndGtfR3RrQ29tcG9uZW50UGVlci5jCTQgQXByIDIwMDQgMjI6NDE6
NTQgLTAwMDANCkBAIC02MTAsMTAgKzYxMCwxMiBAQA0KIGdib29sZWFuDQogZmlsdGVyX2V4cG9z
ZV9ldmVudF9oYW5kbGVyIChHdGtXaWRnZXQgKndpZGdldCwgR2RrRXZlbnQgKmV2ZW50LCBqb2Jq
ZWN0IHBlZXIpDQogew0KLSAgLy8gUHJldmVudCB0aGUgZGVmYXVsdCBldmVudCBoYW5kbGVyIGZy
b20gZ2V0dGluZyB0aGlzIHNpZ25hbCBpZiBhcHBsaWNhYmxlDQotICAvLyBGSVhNRTogSSBjYW1l
IHVwIHdpdGggdGhlc2UgZmlsdGVycyBieSBsb29raW5nIGZvciBwYXR0ZXJucyBpbiB0aGUgdW53
YW50ZWQNCi0gIC8vICAgICAgICBleHBvc2UgZXZlbnRzIHRoYXQgYXJlIGZlZCBiYWNrIHRvIHVz
IGZyb20gZ3RrL1guIFBlcmhhcHMgdGhlcmUgaXMNCi0gIC8vICAgICAgICBhIHdheSB0byBwcmV2
ZW50IHRoZW0gZnJvbSBvY2N1cmluZyBpbiB0aGUgZmlyc3QgcGxhY2UuDQorICAvKg0KKyAgICog
UHJldmVudCB0aGUgZGVmYXVsdCBldmVudCBoYW5kbGVyIGZyb20gZ2V0dGluZyB0aGlzIHNpZ25h
bCBpZiBhcHBsaWNhYmxlDQorICAgKiBGSVhNRTogSSBjYW1lIHVwIHdpdGggdGhlc2UgZmlsdGVy
cyBieSBsb29raW5nIGZvciBwYXR0ZXJucyBpbiB0aGUgdW53YW50ZWQNCisgICAqICAgICAgICBl
eHBvc2UgZXZlbnRzIHRoYXQgYXJlIGZlZCBiYWNrIHRvIHVzIGZyb20gZ3RrL1guIFBlcmhhcHMg
dGhlcmUgaXMNCisgICAqICAgICAgICBhIHdheSB0byBwcmV2ZW50IHRoZW0gZnJvbSBvY2N1cmlu
ZyBpbiB0aGUgZmlyc3QgcGxhY2UuDQorICAgKi8NCiAgIGlmIChldmVudC0+dHlwZSA9PSBHREtf
RVhQT1NFICYmICghR1RLX0lTX0xBWU9VVCh3aWRnZXQpDQogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgfHwgZXZlbnQtPmFueS53aW5kb3cgIT0gd2lkZ2V0LT53aW5kb3cpKQ0K
ICAgICB7DQpAQCAtNjIyLDggKzYyNCw4IEBADQogICAgIH0NCiAgIGVsc2UNCiAgICAgew0KLSAg
ICAgIC8vIFRoZXJlIG1heSBiZSBub24tZXhwb3NlIGV2ZW50cyB0aGF0IGFyZSB0cmlnZ2VyZWQg
d2hpbGUgd2UncmUNCi0gICAgICAvLyBwYWludGluZyBhIGhlYXZ5d2VpZ2h0IHBlZXIuDQorICAg
ICAgLyogVGhlcmUgbWF5IGJlIG5vbi1leHBvc2UgZXZlbnRzIHRoYXQgYXJlIHRyaWdnZXJlZCB3
aGlsZSB3ZSdyZQ0KKyAgICAgICAgcGFpbnRpbmcgYSBoZWF2eXdlaWdodCBwZWVyLiAqLw0KICAg
ICAgIHJldHVybiBwcmVfZXZlbnRfaGFuZGxlcih3aWRnZXQsIGV2ZW50LCBwZWVyKTsNCiAgICAg
fQ0KIH0NCkBAIC02NDEsOCArNjQzLDggQEANCiANCiAgIGdka190aHJlYWRzX2VudGVyICgpOw0K
IA0KLSAgLy8gR3RrRnJhbWVQZWVyIGlzIGJ1aWx0IGFzIGEgR3RrTGF5b3V0IGluc2lkZSBhIEd0
a1ZCb3ggaW5zaWRlIGEgR3RrV2luZG93Lg0KLSAgLy8gRXZlbnRzIGdvIHRvIHRoZSBHdGtMYXlv
dXQgbGF5ZXIsIHNvIHdlIGZpbHRlciB0aGVtIHRoZXJlLg0KKyAgLyogR3RrRnJhbWVQZWVyIGlz
IGJ1aWx0IGFzIGEgR3RrTGF5b3V0IGluc2lkZSBhIEd0a1ZCb3ggaW5zaWRlIGEgR3RrV2luZG93
Lg0KKyAgICAgRXZlbnRzIGdvIHRvIHRoZSBHdGtMYXlvdXQgbGF5ZXIsIHNvIHdlIGZpbHRlciB0
aGVtIHRoZXJlLiAqLw0KICAgaWYgKEdUS19JU19XSU5ET1cocHRyKSkNCiAgICAgew0KICAgICAg
IGNoaWxkcmVuID0gZ3RrX2NvbnRhaW5lcl9nZXRfY2hpbGRyZW4oR1RLX0NPTlRBSU5FUihwdHIp
KTsNCkBAIC02ODUsOCArNjg3LDggQEANCiANCiAgIGdka190aHJlYWRzX2VudGVyICgpOw0KIA0K
LSAgLy8gR3RrRnJhbWVQZWVyIGlzIGJ1aWx0IGFzIGEgR3RrTGF5b3V0IGluc2lkZSBhIEd0a1ZC
b3ggaW5zaWRlIGEgR3RrV2luZG93Lg0KLSAgLy8gRXZlbnRzIGdvIHRvIHRoZSBHdGtMYXlvdXQg
bGF5ZXIsIHNvIHdlIGZpbHRlciB0aGVtIHRoZXJlLg0KKyAgLyogR3RrRnJhbWVQZWVyIGlzIGJ1
aWx0IGFzIGEgR3RrTGF5b3V0IGluc2lkZSBhIEd0a1ZCb3ggaW5zaWRlIGEgR3RrV2luZG93Lg0K
KyAgICAgRXZlbnRzIGdvIHRvIHRoZSBHdGtMYXlvdXQgbGF5ZXIsIHNvIHdlIGZpbHRlciB0aGVt
IHRoZXJlLiAqLw0KICAgaWYgKEdUS19JU19XSU5ET1cocHRyKSkNCiAgICAgew0KICAgICAgIGNo
aWxkcmVuID0gZ3RrX2NvbnRhaW5lcl9nZXRfY2hpbGRyZW4oR1RLX0NPTlRBSU5FUihwdHIpKTsN
CkluZGV4OiBuYXRpdmUvam5pL2d0ay1wZWVyL2dudV9qYXZhX2F3dF9wZWVyX2d0a19HdGtFdmVu
dHMuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgv
bmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9hd3RfcGVlcl9ndGtfR3RrRXZlbnRzLmMsdg0K
cmV0cmlldmluZyByZXZpc2lvbiAxLjI0DQpkaWZmIC11IC1yMS4yNCBnbnVfamF2YV9hd3RfcGVl
cl9ndGtfR3RrRXZlbnRzLmMNCi0tLSBuYXRpdmUvam5pL2d0ay1wZWVyL2dudV9qYXZhX2F3dF9w
ZWVyX2d0a19HdGtFdmVudHMuYwkyOSBNYXIgMjAwNCAwNzowNzoyNiAtMDAwMAkxLjI0DQorKysg
bmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9hd3RfcGVlcl9ndGtfR3RrRXZlbnRzLmMJNCBB
cHIgMjAwNCAyMjo0MTo1NCAtMDAwMA0KQEAgLTkzNCw5ICs5MzQsOSBAQA0KIAkJCQkgICAgY2xp
Y2tfY291bnQsDQogCQkJCSAgICBKTklfRkFMU0UpOw0KIA0KLQkvLyBHZW5lcmF0ZSBhbiBBV1Qg
Y2xpY2sgZXZlbnQgb25seSBpZiB0aGUgcmVsZWFzZSBvY2N1cmVkIGluIHRoZQ0KLQkvLyB3aW5k
b3cgaXQgd2FzIHByZXNzZWQgaW4sIGFuZCB0aGUgbW91c2UgaGFzIG5vdCBiZWVuIGRyYWdnZWQg
c2luY2UNCi0JLy8gdGhlIGxhc3QgdGltZSBpdCB3YXMgcHJlc3NlZC4NCisJLyogR2VuZXJhdGUg
YW4gQVdUIGNsaWNrIGV2ZW50IG9ubHkgaWYgdGhlIHJlbGVhc2Ugb2NjdXJlZCBpbiB0aGUNCisJ
ICAgd2luZG93IGl0IHdhcyBwcmVzc2VkIGluLCBhbmQgdGhlIG1vdXNlIGhhcyBub3QgYmVlbiBk
cmFnZ2VkIHNpbmNlDQorCSAgIHRoZSBsYXN0IHRpbWUgaXQgd2FzIHByZXNzZWQuICovDQogCWdk
a193aW5kb3dfZ2V0X3NpemUgKGV2ZW50LT5hbnkud2luZG93LCAmd2lkdGgsICZoZWlnaHQpOw0K
IAlpZiAoISBoYXNCZWVuRHJhZ2dlZA0KIAkgICAgJiYgZXZlbnQtPmJ1dHRvbi54ID49IDANCkBA
IC0xMDM4LDExICsxMDM4LDExIEBADQogICAgICAgYnJlYWs7DQogICAgIGNhc2UgR0RLX0VYUE9T
RToNCiAgICAgICB7DQotICAgICAgICAvLyBUaGlzIGZpbHRlcnMgb3V0IHVud2FudGVkIGZlZWRi
YWNrIGV4cG9zZSBldmVudHMgZnJvbSBndGsvWA0KLSAgICAgICAgLy8gd2hlbiB3ZSBleHBsaWN0
bHkgaW52YWxpZGF0ZSBhbmQgdXBkYXRlIGhlYXZ5d2VpZ2h0IGNvbXBvbmVudHMsDQotICAgICAg
ICAvLyB0aHVzIGF2b2lkaW5nIGFuIGluZmluaXRlIGxvb3AuDQotICAgICAgICAvLyBGSVhNRTog
SSdtIG5vdCBxdWl0ZSBzdXJlIHdoeSB3ZSdyZSBnZXR0aW5nIHRoZXNlIGV4cG9zZSBldmVudHMu
IA0KLSAgICAgICAgLy8gICAgICAgIE1heWJlIHRoZXJlIGlzIGEgd2F5IHRvIGF2b2lkIHRoZW0/
DQorICAgICAgICAvKiBUaGlzIGZpbHRlcnMgb3V0IHVud2FudGVkIGZlZWRiYWNrIGV4cG9zZSBl
dmVudHMgZnJvbSBndGsvWA0KKyAgICAgICAgICAgd2hlbiB3ZSBleHBsaWN0bHkgaW52YWxpZGF0
ZSBhbmQgdXBkYXRlIGhlYXZ5d2VpZ2h0IGNvbXBvbmVudHMsDQorICAgICAgICAgICB0aHVzIGF2
b2lkaW5nIGFuIGluZmluaXRlIGxvb3AuDQorICAgICAgICAgICBGSVhNRTogSSdtIG5vdCBxdWl0
ZSBzdXJlIHdoeSB3ZSdyZSBnZXR0aW5nIHRoZXNlIGV4cG9zZSBldmVudHMuIA0KKyAgICAgICAg
ICAgICAgICAgIE1heWJlIHRoZXJlIGlzIGEgd2F5IHRvIGF2b2lkIHRoZW0/ICovDQogICAgICAg
ICBpZigoZXZlbnQtPmFueS53aW5kb3cgPT0gd2lkZ2V0LT53aW5kb3cgJiYgZXZlbnQtPmFueS5z
ZW5kX2V2ZW50KQ0KICAgICAgICAgICAgfHwgR1RLX0lTX0xBWU9VVCh3aWRnZXQpKQ0KICAgICAg
ICAgICB7DQpAQCAtMTE4MSw3ICsxMTgxLDYgQEANCiAJCQkgfCBHREtfS0VZX1BSRVNTX01BU0sN
CiAJCQkgfCBHREtfRk9DVVNfQ0hBTkdFX01BU0spOw0KIA0KLSAgLy8gIGdfcHJpbnQoInN0b3Jp
bmcgb2JqICVwIHByb3BlcnR5IG9uIHdpbmRvdyAlcFxuIiwgb2JqLCB3aW5kb3cpOw0KICAgZ2Rr
X3Byb3BlcnR5X2NoYW5nZSAod2luZG93LA0KIAkJICAgICAgIGFkZHJfYXRvbSwNCiAJCSAgICAg
ICB0eXBlX2F0b20sDQpAQCAtMTE5NiwxMCArMTE5NSw4IEBADQogew0KICAgdmFfbGlzdCBhcDsN
CiAgIGpvYmplY3QgKm9iajsNCi0gIC8vdm9pZCAqcHRyID0gTlNBX0dFVF9QVFIgKGVudiwgcGVl
cl9vYmopOw0KIA0KICAgb2JqID0gTlNBX0dFVF9HTE9CQUxfUkVGIChlbnYsIHBlZXJfb2JqKTsN
Ci0gIC8vZ19wcmludCgiQ29ubmVjdGlvbiBvYmogJXNcbiIsIGd0a193aWRnZXRfZ2V0X25hbWUg
KEdUS19XSURHRVQgKHB0cikpKTsNCiAgIGdfYXNzZXJ0IChvYmopOw0KIA0KICAgdmFfc3RhcnQg
KGFwLCBud2luZG93cyk7DQpJbmRleDogbmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9hd3Rf
cGVlcl9ndGtfR3RrRmlsZURpYWxvZ1BlZXIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNy
b290L2NsYXNzcGF0aC9jbGFzc3BhdGgvbmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9hd3Rf
cGVlcl9ndGtfR3RrRmlsZURpYWxvZ1BlZXIuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOQ0K
ZGlmZiAtdSAtcjEuOSBnbnVfamF2YV9hd3RfcGVlcl9ndGtfR3RrRmlsZURpYWxvZ1BlZXIuYw0K
LS0tIG5hdGl2ZS9qbmkvZ3RrLXBlZXIvZ251X2phdmFfYXd0X3BlZXJfZ3RrX0d0a0ZpbGVEaWFs
b2dQZWVyLmMJMjkgTWFyIDIwMDQgMDc6MDc6MjcgLTAwMDAJMS45DQorKysgbmF0aXZlL2puaS9n
dGstcGVlci9nbnVfamF2YV9hd3RfcGVlcl9ndGtfR3RrRmlsZURpYWxvZ1BlZXIuYwk0IEFwciAy
MDA0IDIyOjQxOjU0IC0wMDAwDQpAQCAtMTU2LDcgKzE1Niw3IEBADQogICBzdGF0aWMgam1ldGhv
ZElEIGRpc3Bvc2VJRDsNCiAgIHZvaWQgKnB0cjsNCiANCi0gIC8vIFdlIG9ubHkgbmVlZCB0aGlz
IGZvciB0aGUgY2FzZSB3aGVuIHRoZSB1c2VyIGNsb3NlZCB0aGUgd2luZG93DQorICAvKiBXZSBv
bmx5IG5lZWQgdGhpcyBmb3IgdGhlIGNhc2Ugd2hlbiB0aGUgdXNlciBjbG9zZWQgdGhlIHdpbmRv
dy4gKi8NCiAgIGlmIChyZXNwb25zZUlkICE9IEdUS19SRVNQT05TRV9ERUxFVEVfRVZFTlQpDQog
ICAgIHJldHVybjsNCiANCkluZGV4OiBuYXRpdmUvam5pL2d0ay1wZWVyL2dudV9qYXZhX2F3dF9w
ZWVyX2d0a19HdGtMaXN0UGVlci5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3QvY2xh
c3NwYXRoL2NsYXNzcGF0aC9uYXRpdmUvam5pL2d0ay1wZWVyL2dudV9qYXZhX2F3dF9wZWVyX2d0
a19HdGtMaXN0UGVlci5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMA0KZGlmZiAtdSAtcjEu
MTAgZ251X2phdmFfYXd0X3BlZXJfZ3RrX0d0a0xpc3RQZWVyLmMNCi0tLSBuYXRpdmUvam5pL2d0
ay1wZWVyL2dudV9qYXZhX2F3dF9wZWVyX2d0a19HdGtMaXN0UGVlci5jCTI5IE1hciAyMDA0IDA3
OjA3OjI3IC0wMDAwCTEuMTANCisrKyBuYXRpdmUvam5pL2d0ay1wZWVyL2dudV9qYXZhX2F3dF9w
ZWVyX2d0a19HdGtMaXN0UGVlci5jCTQgQXByIDIwMDQgMjI6NDE6NTQgLTAwMDANCkBAIC0zMjQs
NyArMzI0LDYgQEANCiAJICAgICBHZGtFdmVudEJ1dHRvbiAqZXZlbnQgX19hdHRyaWJ1dGVfXygo
dW51c2VkKSksIA0KIAkgICAgIGpvYmplY3QgcGVlcl9vYmopDQogew0KLSAgLy9nX3ByaW50ICgi
c2VsZWN0X3Jvd1xuIik7DQogICAoKmdka19lbnYpLT5DYWxsVm9pZE1ldGhvZCAoZ2RrX2Vudiwg
cGVlcl9vYmosDQogCQkJICAgICAgcG9zdExpc3RJdGVtRXZlbnRJRCwNCiAJCQkgICAgICByb3cs
DQpAQCAtMzM4LDcgKzMzNyw2IEBADQogCSAgICAgICBHZGtFdmVudEJ1dHRvbiAqZXZlbnQgX19h
dHRyaWJ1dGVfXygodW51c2VkKSksDQogCSAgICAgICBqb2JqZWN0IHBlZXJfb2JqKQ0KIHsNCi0g
IC8vZ19wcmludCAoInVuc2VsZWN0X3Jvd1xuIik7DQogICAoKmdka19lbnYpLT5DYWxsVm9pZE1l
dGhvZCAoZ2RrX2VudiwgcGVlcl9vYmosDQogCQkJICAgICAgcG9zdExpc3RJdGVtRXZlbnRJRCwN
CiAJCQkgICAgICByb3csDQpJbmRleDogbmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9hd3Rf
cGVlcl9ndGtfR3RrVGV4dENvbXBvbmVudFBlZXIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9j
dnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvbmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9h
d3RfcGVlcl9ndGtfR3RrVGV4dENvbXBvbmVudFBlZXIuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9u
IDEuMTMNCmRpZmYgLXUgLXIxLjEzIGdudV9qYXZhX2F3dF9wZWVyX2d0a19HdGtUZXh0Q29tcG9u
ZW50UGVlci5jDQotLS0gbmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9hd3RfcGVlcl9ndGtf
R3RrVGV4dENvbXBvbmVudFBlZXIuYwkyOSBNYXIgMjAwNCAwNzowNzoyNyAtMDAwMAkxLjEzDQor
KysgbmF0aXZlL2puaS9ndGstcGVlci9nbnVfamF2YV9hd3RfcGVlcl9ndGtfR3RrVGV4dENvbXBv
bmVudFBlZXIuYwk0IEFwciAyMDA0IDIyOjQxOjU0IC0wMDAwDQpAQCAtMTEyLDggKzExMiw4IEBA
DQogew0KICAgdm9pZCAqcHRyOw0KICAgaW50IHBvcyA9IDA7DQotICBHdGtFZGl0YWJsZSAqZWRp
dGFibGU7ICAgIC8vIHR5cGUgb2YgR3RrRW50cnkgICAgKFRleHRGaWVsZCkNCi0gIEd0a1dpZGdl
dCAqdGV4dCA9IE5VTEw7ICAgLy8gdHlwZSBvZiBHdGtUZXh0VmlldyAoVGV4dEFyZWEpDQorICBH
dGtFZGl0YWJsZSAqZWRpdGFibGU7ICAgIC8qIHR5cGUgb2YgR3RrRW50cnkgICAgKFRleHRGaWVs
ZCkgKi8NCisgIEd0a1dpZGdldCAqdGV4dCA9IE5VTEw7ICAgLyogdHlwZSBvZiBHdGtUZXh0Vmll
dyAoVGV4dEFyZWEpICovDQogICBHdGtUZXh0QnVmZmVyICpidWY7DQogICBHdGtUZXh0TWFyayAq
bWFyazsNCiAgIEd0a1RleHRJdGVyIGl0ZXI7DQpAQCAtMTU3LDggKzE1Nyw4IEBADQogICAoSk5J
RW52ICplbnYsIGpvYmplY3Qgb2JqLCBqaW50IHBvcykNCiB7DQogICB2b2lkICpwdHI7DQotICBH
dGtFZGl0YWJsZSAqZWRpdGFibGU7ICAgIC8vIHR5cGUgb2YgR3RrRW50cnkgICAgKFRleHRGaWVs
ZCkNCi0gIEd0a1dpZGdldCAqdGV4dCA9IE5VTEw7ICAgLy8gdHlwZSBvZiBHdGtUZXh0VmlldyAo
VGV4dEFyZWEpDQorICBHdGtFZGl0YWJsZSAqZWRpdGFibGU7ICAgIC8qIHR5cGUgb2YgR3RrRW50
cnkgICAgKFRleHRGaWVsZCkgKi8NCisgIEd0a1dpZGdldCAqdGV4dCA9IE5VTEw7ICAgLyogdHlw
ZSBvZiBHdGtUZXh0VmlldyAoVGV4dEFyZWEpICovDQogICBHdGtUZXh0QnVmZmVyICpidWY7DQog
ICBHdGtUZXh0SXRlciBpdGVyOw0KIA0KQEAgLTE5OCw4ICsxOTgsOCBAQA0KIHsNCiAgIHZvaWQg
KnB0cjsNCiAgIGludCBwb3MgPSAwOw0KLSAgR3RrRWRpdGFibGUgKmVkaXRhYmxlOyAgICAvLyB0
eXBlIG9mIEd0a0VudHJ5ICAgIChUZXh0RmllbGQpDQotICBHdGtXaWRnZXQgKnRleHQgPSBOVUxM
OyAgIC8vIHR5cGUgb2YgR3RrVGV4dFZpZXcgKFRleHRBcmVhKQ0KKyAgR3RrRWRpdGFibGUgKmVk
aXRhYmxlOyAgICAvKiB0eXBlIG9mIEd0a0VudHJ5ICAgIChUZXh0RmllbGQpICovDQorICBHdGtX
aWRnZXQgKnRleHQgPSBOVUxMOyAgIC8qIHR5cGUgb2YgR3RrVGV4dFZpZXcgKFRleHRBcmVhKSAq
Lw0KICAgR3RrVGV4dEJ1ZmZlciAqYnVmOw0KICAgR3RrVGV4dEl0ZXIgc3RhcnQ7DQogICBHdGtU
ZXh0SXRlciBlbmQ7DQpAQCAtMjU1LDggKzI1NSw4IEBADQogew0KICAgdm9pZCAqcHRyOw0KICAg
aW50IHBvcyA9IDA7DQotICBHdGtFZGl0YWJsZSAqZWRpdGFibGU7ICAgIC8vIHR5cGUgb2YgR3Rr
RW50cnkgICAgKFRleHRGaWVsZCkNCi0gIEd0a1dpZGdldCAqdGV4dCA9IE5VTEw7ICAgLy8gdHlw
ZSBvZiBHdGtUZXh0VmlldyAoVGV4dEFyZWEpDQorICBHdGtFZGl0YWJsZSAqZWRpdGFibGU7ICAg
IC8qIHR5cGUgb2YgR3RrRW50cnkgICAgKFRleHRGaWVsZCkgKi8NCisgIEd0a1dpZGdldCAqdGV4
dCA9IE5VTEw7ICAgLyogdHlwZSBvZiBHdGtUZXh0VmlldyAoVGV4dEFyZWEpICovDQogICBHdGtU
ZXh0QnVmZmVyICpidWY7DQogICBHdGtUZXh0SXRlciBzdGFydDsNCiAgIEd0a1RleHRJdGVyIGVu
ZDsNCkBAIC0zMTEsOCArMzExLDggQEANCiAgIChKTklFbnYgKmVudiwgam9iamVjdCBvYmosIGpp
bnQgc3RhcnQsIGppbnQgZW5kKQ0KIHsNCiAgIHZvaWQgKnB0cjsNCi0gIEd0a0VkaXRhYmxlICpl
ZGl0YWJsZTsgICAgLy8gdHlwZSBvZiBHdGtFbnRyeSAgICAoVGV4dEZpZWxkKQ0KLSAgR3RrV2lk
Z2V0ICp0ZXh0ID0gTlVMTDsgICAvLyB0eXBlIG9mIEd0a1RleHRWaWV3IChUZXh0QXJlYSkNCisg
IEd0a0VkaXRhYmxlICplZGl0YWJsZTsgICAgLyogdHlwZSBvZiBHdGtFbnRyeSAgICAoVGV4dEZp
ZWxkKSAqLw0KKyAgR3RrV2lkZ2V0ICp0ZXh0ID0gTlVMTDsgICAvKiB0eXBlIG9mIEd0a1RleHRW
aWV3IChUZXh0QXJlYSkgKi8NCiAgIEd0a1RleHRCdWZmZXIgKmJ1ZjsNCiAgIEd0a1RleHRJdGVy
IGl0ZXI7DQogDQpAQCAtMzU3LDggKzM1Nyw4IEBADQogICAoSk5JRW52ICplbnYsIGpvYmplY3Qg
b2JqLCBqYm9vbGVhbiBzdGF0ZSkNCiB7DQogICB2b2lkICpwdHI7DQotICBHdGtFZGl0YWJsZSAq
ZWRpdGFibGU7ICAgIC8vIHR5cGUgb2YgR3RrRW50cnkgICAgKFRleHRGaWVsZCkNCi0gIEd0a1dp
ZGdldCAqdGV4dCA9IE5VTEw7ICAgLy8gdHlwZSBvZiBHdGtUZXh0VmlldyAoVGV4dEFyZWEpDQor
ICBHdGtFZGl0YWJsZSAqZWRpdGFibGU7ICAgIC8qIHR5cGUgb2YgR3RrRW50cnkgICAgKFRleHRG
aWVsZCkgKi8NCisgIEd0a1dpZGdldCAqdGV4dCA9IE5VTEw7ICAgLyogdHlwZSBvZiBHdGtUZXh0
VmlldyAoVGV4dEFyZWEpICovDQogDQogICBwdHIgPSBOU0FfR0VUX1BUUiAoZW52LCBvYmopOw0K
IA0KQEAgLTM5Niw4ICszOTYsOCBAQA0KICAgdm9pZCAqcHRyOw0KICAgY2hhciAqY29udGVudHMg
PSBOVUxMOw0KICAganN0cmluZyBqY29udGVudHM7DQotICBHdGtFZGl0YWJsZSAqZWRpdGFibGU7
ICAgIC8vIHR5cGUgb2YgR3RrRW50cnkgICAgKFRleHRGaWVsZCkNCi0gIEd0a1dpZGdldCAqdGV4
dCA9IE5VTEw7ICAgLy8gdHlwZSBvZiBHdGtUZXh0VmlldyAoVGV4dEFyZWEpDQorICBHdGtFZGl0
YWJsZSAqZWRpdGFibGU7ICAgIC8qIHR5cGUgb2YgR3RrRW50cnkgICAgKFRleHRGaWVsZCkgKi8N
CisgIEd0a1dpZGdldCAqdGV4dCA9IE5VTEw7ICAgLyogdHlwZSBvZiBHdGtUZXh0VmlldyAoVGV4
dEFyZWEpICovDQogICBHdGtUZXh0QnVmZmVyICpidWY7DQogICBHdGtUZXh0SXRlciBzdGFydCwg
ZW5kOw0KIA0KQEAgLTQ0NCw3ICs0NDQsNyBAQA0KIHsNCiAgIHZvaWQgKnB0cjsNCiAgIGNvbnN0
IGNoYXIgKnN0cjsNCi0gIEd0a1dpZGdldCAqdGV4dCA9IE5VTEw7ICAgLy8gdHlwZSBvZiBHdGtU
ZXh0VmlldyAoVGV4dEFyZWEpDQorICBHdGtXaWRnZXQgKnRleHQgPSBOVUxMOyAgIC8qIHR5cGUg
b2YgR3RrVGV4dFZpZXcgKFRleHRBcmVhKSAqLw0KICAgR3RrVGV4dEJ1ZmZlciAqYnVmOw0KIA0K
ICAgcHRyID0gTlNBX0dFVF9QVFIgKGVudiwgb2JqKTsNCkluZGV4OiBuYXRpdmUvam5pL2d0ay1w
ZWVyL2d0aHJlYWQtam5pLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9jbGFzc3Bh
dGgvY2xhc3NwYXRoL25hdGl2ZS9qbmkvZ3RrLXBlZXIvZ3RocmVhZC1qbmkuYyx2DQpyZXRyaWV2
aW5nIHJldmlzaW9uIDEuOA0KZGlmZiAtdSAtcjEuOCBndGhyZWFkLWpuaS5jDQotLS0gbmF0aXZl
L2puaS9ndGstcGVlci9ndGhyZWFkLWpuaS5jCTI5IE1hciAyMDA0IDA3OjA3OjI3IC0wMDAwCTEu
OA0KKysrIG5hdGl2ZS9qbmkvZ3RrLXBlZXIvZ3RocmVhZC1qbmkuYwk0IEFwciAyMDA0IDIyOjQx
OjU0IC0wMDAwDQpAQCAtMjA0LDcgKzIwNCw3IEBADQogc3RhdGljIGdib29sZWFuIGdfbXV0ZXhf
dHJ5bG9ja19qbmlfaW1wbA0KICAgKEdNdXRleCAqbXV0ZXggX19hdHRyaWJ1dGVfXygodW51c2Vk
KSkpDQogew0KLSAgLy8gU2hhbGwgd2UgaW1wbGVtZW50IHRoaXMgaW4gYSBKaWtlc1JWTS1zcGVj
aWZpYyB3YXkgdW5kZXIgYSBmbGFnPw0KKyAgLyogWFhYIFNoYWxsIHdlIGltcGxlbWVudCB0aGlz
IGluIGEgSmlrZXNSVk0tc3BlY2lmaWMgd2F5IHVuZGVyIGEgZmxhZz8gKi8NCiAgIHJldHVybiBG
QUxTRTsNCiB9DQogDQpJbmRleDogbmF0aXZlL2puaS9qYXZhLWlvL0ZpbGVEZXNjcmlwdG9yLmMN
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9jbGFzc3BhdGgvY2xhc3NwYXRoL25hdGl2
ZS9qbmkvamF2YS1pby9GaWxlRGVzY3JpcHRvci5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4x
Nw0KZGlmZiAtdSAtcjEuMTcgRmlsZURlc2NyaXB0b3IuYw0KLS0tIG5hdGl2ZS9qbmkvamF2YS1p
by9GaWxlRGVzY3JpcHRvci5jCTI5IE1hciAyMDA0IDA3OjA3OjI3IC0wMDAwCTEuMTcNCisrKyBu
YXRpdmUvam5pL2phdmEtaW8vRmlsZURlc2NyaXB0b3IuYwk0IEFwciAyMDA0IDIyOjQxOjU1IC0w
MDAwDQpAQCAtNjUsMTkgKzY1LDE5IEBADQogDQogI2luY2x1ZGUgImphdmFfaW9fRmlsZURlc2Ny
aXB0b3IuaCINCiANCi0vLyBGSVhNRTogVGhpcyBjYW4ndCBiZSByaWdodC4gIE5lZWQgY29udmVy
dGVyIG1hY3Jvcw0KKy8qIEZJWE1FOiBUaGlzIGNhbid0IGJlIHJpZ2h0LiAgTmVlZCBjb252ZXJ0
ZXIgbWFjcm9zICovDQogI2RlZmluZSBDT05WRVJUX0pMT05HX1RPX0lOVCh4KSBUQVJHRVRfTkFU
SVZFX01BVEhfSU5UX0lOVDY0X1RPX0lOVDMyKHgpDQogI2RlZmluZSBDT05WRVJUX0lOVF9UT19K
TE9ORyh4KSBUQVJHRVRfTkFUSVZFX01BVEhfSU5UX0lOVDMyX1RPX0lOVDY0KHgpDQogDQotLy8g
RklYTUU6IFRoaXMgY2FuJ3QgYmUgcmlnaHQuICBOZWVkIGNvbnZlcnRlciBtYWNyb3MNCisvKiBG
SVhNRTogVGhpcyBjYW4ndCBiZSByaWdodC4gIE5lZWQgY29udmVydGVyIG1hY3JvcyAqLw0KICNk
ZWZpbmUgQ09OVkVSVF9KTE9OR19UT19PRkZfVCh4KSBUQVJHRVRfTkFUSVZFX01BVEhfSU5UX0lO
VDY0X1RPX0lOVDMyKHgpDQogI2RlZmluZSBDT05WRVJUX09GRl9UX1RPX0pMT05HKHgpIFRBUkdF
VF9OQVRJVkVfTUFUSF9JTlRfSU5UMzJfVE9fSU5UNjQoeCkNCiANCi0vLyBGSVhNRTogVGhpcyBj
YW4ndCBiZSByaWdodC4gIE5lZWQgY29udmVydGVyIG1hY3Jvcw0KKy8qIEZJWE1FOiBUaGlzIGNh
bid0IGJlIHJpZ2h0LiAgTmVlZCBjb252ZXJ0ZXIgbWFjcm9zICovDQogI2RlZmluZSBDT05WRVJU
X0pJTlRfVE9fSU5UKHgpICgoaW50KSh4ICYgMHhGRkZGRkZGRikpDQogI2RlZmluZSBDT05WRVJU
X0lOVF9UT19KSU5UKHgpICgoaW50KSh4ICYgMHhGRkZGRkZGRikpDQogDQotLy8gRklYTUU6IFRo
aXMgY2FuJ3QgYmUgcmlnaHQuICBOZWVkIGNvbnZlcnRlciBtYWNyb3MNCisvKiBGSVhNRTogVGhp
cyBjYW4ndCBiZSByaWdodC4gIE5lZWQgY29udmVydGVyIG1hY3JvcyAqLw0KICNkZWZpbmUgQ09O
VkVSVF9TU0laRV9UX1RPX0pJTlQoeCkgKChqaW50KSh4ICYgMHhGRkZGRkZGRikpDQogI2RlZmlu
ZSBDT05WRVJUX0pJTlRfVE9fU1NJWkVfVCh4KSAoeCkNCiANCkBAIC00MjAsNyArNDIwLDcgQEAN
CiAgICAgICByZXR1cm4oMCk7DQogICAgIH0NCiANCi0vLyBGSVhNRSBOWUkgPz8/IHdoeSBvbmx5
IGppbnQgYW5kIG5vdCBqbG9uZz8NCisvKiBGSVhNRSBOWUkgPz8/IHdoeSBvbmx5IGppbnQgYW5k
IG5vdCBqbG9uZz8gKi8NCiAgIHJldHVybihUQVJHRVRfTkFUSVZFX01BVEhfSU5UX0lOVDY0X1RP
X0lOVDMyKGJ5dGVzX2F2YWlsYWJsZSkpOw0KIH0NCiANCkluZGV4OiBuYXRpdmUvam5pL2phdmEt
aW8vamF2YV9pb19GaWxlLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9jbGFzc3Bh
dGgvY2xhc3NwYXRoL25hdGl2ZS9qbmkvamF2YS1pby9qYXZhX2lvX0ZpbGUuYyx2DQpyZXRyaWV2
aW5nIHJldmlzaW9uIDEuMTINCmRpZmYgLXUgLXIxLjEyIGphdmFfaW9fRmlsZS5jDQotLS0gbmF0
aXZlL2puaS9qYXZhLWlvL2phdmFfaW9fRmlsZS5jCTI5IE1hciAyMDA0IDA3OjA3OjI3IC0wMDAw
CTEuMTINCisrKyBuYXRpdmUvam5pL2phdmEtaW8vamF2YV9pb19GaWxlLmMJNCBBcHIgMjAwNCAy
Mjo0MTo1NSAtMDAwMA0KQEAgLTgxLDcgKzgxLDcgQEANCiAgIFRBUkdFVF9OQVRJVkVfRklMRV9P
UEVOX0NSRUFURShmaWxlbmFtZSxmZCxyZXN1bHQpOw0KICAgaWYgKHJlc3VsdCAhPSBUQVJHRVRf
TkFUSVZFX09LKQ0KICAgICB7DQotLy8/Pz8gTllJDQorICAgICAgLyogWFhYIE5ZSSA/Pz8gKi8N
CiAgICAgICBpZiAoZXJybm8gIT0gRUVYSVNUKQ0KICAgICAgICAgSkNMX1Rocm93RXhjZXB0aW9u
KGVudiwNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAiamF2YS9pby9JT0V4Y2VwdGlvbiIs
DQpJbmRleDogbmF0aXZlL2puaS9qYXZhLWlvL2phdmFpby5jDQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmls
ZTogL2N2c3Jvb3QvY2xhc3NwYXRoL2NsYXNzcGF0aC9uYXRpdmUvam5pL2phdmEtaW8vamF2YWlv
LmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjExDQpkaWZmIC11IC1yMS4xMSBqYXZhaW8uYw0K
LS0tIG5hdGl2ZS9qbmkvamF2YS1pby9qYXZhaW8uYwkyOSBNYXIgMjAwNCAwNzowNzoyNyAtMDAw
MAkxLjExDQorKysgbmF0aXZlL2puaS9qYXZhLWlvL2phdmFpby5jCTQgQXByIDIwMDQgMjI6NDE6
NTUgLTAwMDANCkBAIC02NCw3ICs2NCw2IEBADQogICBpbnQgICAgICAgIGZkOw0KICAgaW50ICAg
ICAgICByZXN1bHQ7DQogDQotLy8gZnByaW50ZihzdGRlcnIsImNhbGwgJXMgKGxpbmUgJWQpOlxu
IixfX0ZVTkNUSU9OX18sX19MSU5FX18pOw0KICAgZmlsZW5hbWUgPSBKQ0xfanN0cmluZ190b19j
c3RyaW5nKGVudiwgbmFtZSk7IA0KICAgaWYgKGZpbGVuYW1lID09IE5VTEwpDQogICAgIHJldHVy
bigtMSk7DQpAQCAtMTAxLDcgKzEwMCw2IEBADQogICBpbnQgICAgICAgIGZkOw0KICAgaW50ICAg
ICAgICByZXN1bHQ7DQogDQotLy8gZnByaW50ZihzdGRlcnIsImNhbGwgJXMgKGxpbmUgJWQpOlxu
IixfX0ZVTkNUSU9OX18sX19MSU5FX18pOw0KICAgZmlsZW5hbWUgPSBKQ0xfanN0cmluZ190b19j
c3RyaW5nKGVudiwgbmFtZSk7IA0KICAgaWYgKGZpbGVuYW1lID09IE5VTEwpDQogICAgIHJldHVy
bigtMSk7DQpAQCAtMTYzLDcgKzE2MSw2IEBADQogICBqbG9uZyBjdXJyZW50X29mZnNldCwgbmV3
X29mZnNldDsNCiAgIGludCAgIHJlc3VsdDsNCiANCi0vLyBmcHJpbnRmKHN0ZGVyciwiY2FsbCAl
cyAobGluZSAlZCk6XG4iLF9fRlVOQ1RJT05fXyxfX0xJTkVfXyk7DQogICBUQVJHRVRfTkFUSVZF
X0ZJTEVfU0VFS19DVVJSRU5UKGZkLFRBUkdFVF9OQVRJVkVfTUFUSF9JTlRfSU5UNjRfQ09OU1Rf
MCxjdXJyZW50X29mZnNldCxyZXN1bHQpOw0KICAgaWYgKHJlc3VsdCAhPSBUQVJHRVRfTkFUSVZF
X09LKQ0KICAgICBKQ0xfVGhyb3dFeGNlcHRpb24oZW52LA0KQEAgLTE5NSw3ICsxOTIsNiBAQA0K
ICAgamxvbmcgbGVuZ3RoOw0KICAgaW50ICAgcmVzdWx0Ow0KIA0KLS8vIGZwcmludGYoc3RkZXJy
LCJjYWxsICVzIChsaW5lICVkKTpcbiIsX19GVU5DVElPTl9fLF9fTElORV9fKTsNCiAgIFRBUkdF
VF9OQVRJVkVfRklMRV9TSVpFKGZkLGxlbmd0aCxyZXN1bHQpOw0KICAgaWYgKHJlc3VsdCAhPSBU
QVJHRVRfTkFUSVZFX09LKQ0KICAgICB7DQpAQCAtMjI5LDcgKzIyNSw2IEBADQogICBhc3NlcnQo
b2Zmc2V0Pj0wKTsNCiAgIGFzc2VydChsZW4+PTApOw0KIA0KLS8vIGZwcmludGYoc3RkZXJyLCJj
YWxsICVzIChsaW5lICVkKTpcbiIsX19GVU5DVElPTl9fLF9fTElORV9fKTsNCiAgIGlmIChsZW4g
PT0gMCkNCiAgICAgcmV0dXJuIDA7IC8qIE5vdGhpbmcgdG9kbywgYW5kIEdldEJ5dGVBcnJheUVs
ZW1lbnRzKCkgc2VlbXMgdW5kZWZpbmVkLiAqLw0KIA0KQEAgLTI1OCw3ICsyNTMsNiBAQA0KICAg
YXNzZXJ0KG9mZnNldD49MCk7DQogICBhc3NlcnQobGVuPj0wKTsNCiANCi0vLyBmcHJpbnRmKHN0
ZGVyciwiY2FsbCAlcyAobGluZSAlZCk6XG4iLF9fRlVOQ1RJT05fXyxfX0xJTkVfXyk7DQogICBp
ZiAoKGZkPT0wKSB8fCAoZmQ9PTEpIHx8IChmZD09MikpDQogICB7DQogICAgIGlmIChsZW4gPT0g
MCkNCkluZGV4OiBuYXRpdmUvam5pL2phdmEtbmV0L2phdmFuZXQuYw0KPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNT
IGZpbGU6IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvbmF0aXZlL2puaS9qYXZhLW5ldC9q
YXZhbmV0LmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjE1DQpkaWZmIC11IC1yMS4xNSBqYXZh
bmV0LmMNCi0tLSBuYXRpdmUvam5pL2phdmEtbmV0L2phdmFuZXQuYwkyOSBNYXIgMjAwNCAwNzow
NzozOSAtMDAwMAkxLjE1DQorKysgbmF0aXZlL2puaS9qYXZhLW5ldC9qYXZhbmV0LmMJNCBBcHIg
MjAwNCAyMjo0MTo1NSAtMDAwMA0KQEAgLTEsNSArMSw1IEBADQogLyogamF2YW5ldC5jIC0gQ29t
bW9uIGludGVybmFsIGZ1bmN0aW9ucyBmb3IgdGhlIGphdmEubmV0IHBhY2thZ2UNCi0gICBDb3B5
cmlnaHQgKEMpIDE5OTgsIDIwMDIgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuDQorICAg
Q29weXJpZ2h0IChDKSAxOTk4LCAyMDAyLCAyMDA0IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwg
SW5jLg0KIA0KIFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBDbGFzc3BhdGguDQogDQpAQCAtNjgx
LDcgKzY4MSw3IEBADQogICAgIH0NCiAgIERCRygiX2phdmFuZXRfYmluZCgpOiBQYXN0IG5hdGl2
ZV9mZCBsb29rdXBcbiIpOw0KIA0KLS8vIE5ZSSA/Pz8NCisvKiBYWFggTllJID8/PyAqLw0KICAg
X2phdmFuZXRfc2V0X29wdGlvbiAoZW52LCB0aGlzLCBTT0NLT1BUX1NPX1JFVVNFQUREUiwgDQog
CQkgICAgICAgX2phdmFuZXRfY3JlYXRlX2Jvb2xlYW4gKGVudiwgSk5JX1RSVUUpKTsNCiANCkBA
IC0xMDk5LDcgKzEwOTksOCBAQA0KIA0KICAgICAgICAgVEFSR0VUX05BVElWRV9ORVRXT1JLX1NP
Q0tFVF9TRVRfT1BUSU9OX1NPX1RJTUVPVVQoZmQsb3B0dmFsLHJlc3VsdCk7DQogI2VuZGlmDQot
CXJlc3VsdCA9IFRBUkdFVF9OQVRJVkVfT0s7ICAvLyBpZ25vcmUgZXJyb3JzIGFuZCBkbyBub3Qg
dGhyb3cgYW4gZXhjZXB0aW9uDQorCS8qIElnbm9yZSBlcnJvcnMgYW5kIGRvIG5vdCB0aHJvdyBh
biBleGNlcHRpb24uICovDQorCXJlc3VsdCA9IFRBUkdFVF9OQVRJVkVfT0s7DQogICAgICAgICBi
cmVhazsNCiANCiAgICAgICBjYXNlIFNPQ0tPUFRfU09fU05EQlVGOg0KSW5kZXg6IG5hdGl2ZS90
YXJnZXQvZ2VuZXJpYy90YXJnZXRfZ2VuZXJpY19maWxlLmgNCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxl
OiAvY3Zzcm9vdC9jbGFzc3BhdGgvY2xhc3NwYXRoL25hdGl2ZS90YXJnZXQvZ2VuZXJpYy90YXJn
ZXRfZ2VuZXJpY19maWxlLmgsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjE1DQpkaWZmIC11IC1y
MS4xNSB0YXJnZXRfZ2VuZXJpY19maWxlLmgNCi0tLSBuYXRpdmUvdGFyZ2V0L2dlbmVyaWMvdGFy
Z2V0X2dlbmVyaWNfZmlsZS5oCTI5IE1hciAyMDA0IDA3OjA3OjQwIC0wMDAwCTEuMTUNCisrKyBu
YXRpdmUvdGFyZ2V0L2dlbmVyaWMvdGFyZ2V0X2dlbmVyaWNfZmlsZS5oCTQgQXByIDIwMDQgMjI6
NDE6NTUgLTAwMDANCkBAIC0xLDUgKzEsNSBAQA0KLS8qIGdlbmVyaWNfbWF0aF9pbnQ2NC5oIC0g
TmF0aXZlIG1ldGhvZHMgZm9yIDY0Yml0IG1hdGggb3BlcmF0aW9ucw0KLSAgIENvcHlyaWdodCAo
QykgMTk5OCBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4NCisvKiB0YXJnZXRfZ2VuZXJp
Y19maWxlLmggLSBHZW5lcmljIG5hdGl2ZSBtZXRob2RzL2RlZmluZXMgZm9yIGZpbGUgb3BlcmF0
aW9ucy4NCisgICBDb3B5cmlnaHQgKEMpIDE5OTgsIDIwMDQgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0
aW9uLCBJbmMuDQogDQogVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIENsYXNzcGF0aC4NCiANCkBA
IC0xMTcsNyArMTE3LDcgQEANCiAjZW5kaWYNCiANCiAjaWZuZGVmIFRBUkdFVF9OQVRJVkVfRklM
RV9GSUxFUEVSTUlTU0lPTl9SRUFET05MWQ0KLSAgI2RlZmluZSBUQVJHRVRfTkFUSVZFX0ZJTEVf
RklMRVBFUk1JU1NJT05fUkVBRE9OTFkgKH4oU19JV1JJVEV8U19JV0dSUHxTX0lXT1RIKSkNCisg
ICNkZWZpbmUgVEFSR0VUX05BVElWRV9GSUxFX0ZJTEVQRVJNSVNTSU9OX1JFQURPTkxZICh+KFNf
SVdVU1J8U19JV0dSUHxTX0lXT1RIKSkNCiAjZW5kaWYNCiANCiAvKioqKioqKioqKioqKioqKioq
KioqKioqKioqKiogRGF0YXR5cGVzICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovDQpA
QCAtNzk1LDcgKzc5NSw3IEBADQogKiBOb3RlcyAgICAgIDogLQ0KIFwqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8N
CiANCi0vLz8/PyBuYW1lIGFscyBidWZmZXI/DQorLyogWFhYID8/PyBuYW1lIGFscyBidWZmZXI/
ICovDQogI2lmbmRlZiBUQVJHRVRfTkFUSVZFX0ZJTEVfUkVBRF9ESVINCiAgICNpbmNsdWRlIDxz
eXMvdHlwZXMuaD4NCiAgICNpbmNsdWRlIDxkaXJlbnQuaD4NCkluZGV4OiBuYXRpdmUvdGFyZ2V0
L2dlbmVyaWMvdGFyZ2V0X2dlbmVyaWNfbmV0d29yay5oDQo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTog
L2N2c3Jvb3QvY2xhc3NwYXRoL2NsYXNzcGF0aC9uYXRpdmUvdGFyZ2V0L2dlbmVyaWMvdGFyZ2V0
X2dlbmVyaWNfbmV0d29yay5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMA0KZGlmZiAtdSAt
cjEuMTAgdGFyZ2V0X2dlbmVyaWNfbmV0d29yay5oDQotLS0gbmF0aXZlL3RhcmdldC9nZW5lcmlj
L3RhcmdldF9nZW5lcmljX25ldHdvcmsuaAkyOSBNYXIgMjAwNCAwNzowNzo0MCAtMDAwMAkxLjEw
DQorKysgbmF0aXZlL3RhcmdldC9nZW5lcmljL3RhcmdldF9nZW5lcmljX25ldHdvcmsuaAk0IEFw
ciAyMDA0IDIyOjQxOjU1IC0wMDAwDQpAQCAtMTQzLDcgKzE0Myw3IEBADQogKiBOb3RlcyAgICAg
IDogLQ0KIFwqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKi8NCiANCi0vL05ZST8/PyByZWVudHJhbnQ/DQorLyogWFhY
IE5ZST8/PyByZWVudHJhbnQ/ICovDQogI2lmbmRlZiBUQVJHRVRfTkFUSVZFX05FVFdPUktfR0VU
X0hPU1ROQU1FX0JZX0FERFJFU1MNCiAgICNpbmNsdWRlIDxuZXRkYi5oPg0KICAgI2RlZmluZSBU
QVJHRVRfTkFUSVZFX05FVFdPUktfR0VUX0hPU1ROQU1FX0JZX0FERFJFU1MoYWRkcmVzcyxuYW1l
LG1heE5hbWVMZW4scmVzdWx0KSBcDQpAQCAtMTgxLDcgKzE4MSw3IEBADQogKiBOb3RlcyAgICAg
IDogLQ0KIFwqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKi8NCiANCi0vL05ZST8/PyByZWVudHJhbnQ/DQorLyogWFhY
IE5ZST8/PyByZWVudHJhbnQ/ICovDQogI2lmbmRlZiBUQVJHRVRfTkFUSVZFX05FVFdPUktfR0VU
X0hPU1ROQU1FX0JZX05BTUUNCiAgICNpbmNsdWRlIDxuZXRkYi5oPg0KICAgI2RlZmluZSBUQVJH
RVRfTkFUSVZFX05FVFdPUktfR0VUX0hPU1ROQU1FX0JZX05BTUUobmFtZSxhZGRyZXNzZXMsbWF4
QWRkcmVzc1NpemUsYWRkcmVzc0NvdW50LHJlc3VsdCkgXA0KQEAgLTMxNyw3ICszMTcsNyBAQA0K
ICogTm90ZXMgICAgICA6IC0NCiBcKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovDQogDQotLy8/Pz8gYWRkcmVzcyBp
biBuZXR3b3JrIGJ5dGUgb3JkZXI/DQorLyogWFhYID8/PyBhZGRyZXNzIGluIG5ldHdvcmsgYnl0
ZSBvcmRlcj8gKi8NCiAjaWZuZGVmIFRBUkdFVF9OQVRJVkVfTkVUV09SS19TT0NLRVRfQklORA0K
ICAgI2luY2x1ZGUgPHN5cy90eXBlcy5oPg0KICAgI2luY2x1ZGUgPHN5cy9zb2NrZXQuaD4NCkBA
IC0zNDcsNyArMzQ3LDcgQEANCiAqIE5vdGVzICAgICAgOiAtDQogXCoqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqLw0K
IA0KLS8vPz8/IGFkZHJlc3MgaW4gbmV0d29yayBieXRlIG9yZGVyPw0KKy8qIFhYWCA/Pz8gYWRk
cmVzcyBpbiBuZXR3b3JrIGJ5dGUgb3JkZXI/ICovDQogI2lmbmRlZiBUQVJHRVRfTkFUSVZFX05F
VFdPUktfU09DS0VUX0xJU1RFTg0KICAgI2luY2x1ZGUgPHN5cy9zb2NrZXQuaD4NCiAgICNkZWZp
bmUgVEFSR0VUX05BVElWRV9ORVRXT1JLX1NPQ0tFVF9MSVNURU4oc29ja2V0RGVzY3JpcHRvcixt
YXhRdWV1ZUxlbmd0aCxyZXN1bHQpIFwNCkBAIC0zNjcsNyArMzY3LDcgQEANCiAqIE5vdGVzICAg
ICAgOiAtDQogXCoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq
KioqKioqKioqKioqKioqKioqKioqKioqLw0KIA0KLS8vPz8/IGFkZHJlc3MgaW4gbmV0d29yayBi
eXRlIG9yZGVyPw0KKy8qIFhYWCA/Pz8gYWRkcmVzcyBpbiBuZXR3b3JrIGJ5dGUgb3JkZXI/ICov
DQogI2lmbmRlZiBUQVJHRVRfTkFUSVZFX05FVFdPUktfU09DS0VUX0FDQ0VQVA0KICAgI2luY2x1
ZGUgPHN5cy90eXBlcy5oPg0KICAgI2luY2x1ZGUgPHN5cy9zb2NrZXQuaD4NCg==

--=-QNG8Q2ezIARSgL6mTkhh--

--=-NTrEaH5+i63h9aJVQEJH
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAcJDoxVhZCJWr9QwRAkNzAKCYk5+HUaA5wepqY1yIo33qNVBNSQCeJubg
gbhFax9+bF6WFNyTgf9TFvU=
=WpNB
-----END PGP SIGNATURE-----

--=-NTrEaH5+i63h9aJVQEJH--




From MAILER-DAEMON Sun Apr 04 19:10:03 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAGkc-0000lK-TV
	for mharc-classpath@gnu.org; Sun, 04 Apr 2004 19:10:02 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAGkX-0000hm-C3
	for classpath@gnu.org; Sun, 04 Apr 2004 19:09:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAGjz-0000M7-Vg
	for classpath@gnu.org; Sun, 04 Apr 2004 19:09:55 -0400
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAGjt-0000If-I9
	for classpath@gnu.org; Sun, 04 Apr 2004 19:09:17 -0400
Received: from dholmeslaptop (dholmes.dltech.com.au [203.222.72.2])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i34N4EYG022853;
	Mon, 5 Apr 2004 09:04:15 +1000 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "Mark Wielaard" <mark@klomp.org>
Date: Mon, 5 Apr 2004 09:04:28 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCCECNEAAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
Importance: Normal
In-Reply-To: <1081101664.7548.158.camel@elsschot.wildebeest.org>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Cc: Classpath List <classpath@gnu.org>
Subject: RE: Object serialization and final fields
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Apr 2004 23:09:58 -0000

Mark Wielaard wrote:
> BTW. Note to VM/Compiler implementers!
> --------------------------------------
> We discussed "final" fields a bit more on irc.
> We came to the conclusion the the VM spec authors and the JLS spec
> authors have a different interpretation of "final".
> According to the VM spec a final field is non-private read-only, but
> rewritable by the Class defining the field.
> According the the JLS spec a final field is single assignable (in a
> [static] constructor method).
> JNI doesn't seem to define precisely what/how final fields can change.
> The above patch depends on the fact that in practice JNI setXField() can
> be used to set a final field (this was already the case for the
> System.setIn()/setOut()/setError() methods).
>
> The following bug reports are also interesting:
>
> http://developer.java.sun.com/developer/bugParade/bugs/4027808.html
> Synopsis: [JNI] SetObjectField modifies a final field value
> State: Closed, will not be fixed
> Evaluation: JNI does not guard against illegal access to objects [...].
>
> http://developer.java.sun.com/developer/bugParade/bugs/4115974.html
> Synopsis: Need to be able to tell JIT not to optimize certain finals.
> State: Closed, will not be fixed
> Evaluation: These are the only thing which should ever behave this way,
> so there's no need for a special interface for this.  The JIT just needs
> to handle these specially.
>
> http://developer.java.sun.com/developer/bugParade/bugs/4174797.html
> Synopsis: Serialization should not use reflection to set final fields
> State: Closed, fixed
> Evaluation: [...] Serialization needs to use JNI Set<type>Field Routines
> to set fields, instead of Field.set*(). [...]
>
> All this seems a bit unfortunate since it basically means that a runtime
> cannot optimize final field access since they can always be changed
> through JNI and this "feature" is at least necessary for both
> System.setIn/Out/Err() and reflection.

These issues may be addressed in the near future - though it is a bit of a
mess. The new Java Memory Model basically allows all the optimisations you
want and says that native modification of final fields, beyond use of
SetIn/Out/Err, need not cause a change by one thread to become visible in
another. In other words any application using this is on its own. There are
also special rules for handling the deserialisation issue with finals.

See http://www.cs.umd.edu/~pugh/java/memoryModel for details.

David Holmes




From MAILER-DAEMON Mon Apr 05 01:59:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAN8z-0000ex-AT
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 01:59:37 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAN8v-0000aD-Mt
	for classpath@gnu.org; Mon, 05 Apr 2004 01:59:33 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAN8P-0000JX-1M
	for classpath@gnu.org; Mon, 05 Apr 2004 01:59:32 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAN6h-0007uj-J6
	for classpath@gnu.org; Mon, 05 Apr 2004 01:57:15 -0400
Received: from [212.6.122.96] (helo=mail0.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAN6U-0006BQ-Ir
	for classpath@gnu.org; Mon, 05 Apr 2004 01:57:02 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-252.ewetel.net
	[80.228.94.252])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i355uJX3010538;
	Mon, 5 Apr 2004 07:56:23 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BAM9r-0000Mf-00; Mon, 05 Apr 2004 06:56:27 +0200
From: Michael Koch <konqueror@gmx.de>
To: Ito Kazumitsu <kaz@maczuka.gcd.org>, GNU Classpath <classpath@gnu.org>
Date: Mon, 5 Apr 2004 07:56:06 +0200
User-Agent: KMail/1.5.4
References: <20040404223650.97363.qmail@maczuka.gcd.org>
In-Reply-To: <20040404223650.97363.qmail@maczuka.gcd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404050756.07221.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: java.nio.channels.FileChannel#lock not implemented
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 05:59:34 -0000

Am Montag, 5. April 2004 00:36 schrieb Ito Kazumitsu:
> Hi,
>
> java/nio/channels/FileChannelImpl.java has, for example,
>
>   public FileLock lock (long position, long size, boolean shared)
>     throws IOException
>   {
>     ...
>     throw new Error ("Not implemented");
>   }
>
> What is the schedule for implementing this?

I have a big patch (> 150 kb) pending for this. I havent commited it yet 
because it makes jamvm just segfault and we are investigating this.

> I would like to have this implemented because HSQLDB 1.7.2
> (http://hsqldb.sourceforge.net/) requires it.

Many projects like to depend on this lately, Eclipse too.


Michael




From MAILER-DAEMON Mon Apr 05 04:31:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAPWH-0007L6-SL
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 04:31:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAPWF-0007KS-6T
	for classpath@gnu.org; Mon, 05 Apr 2004 04:31:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAPVi-0007AW-NJ
	for classpath@gnu.org; Mon, 05 Apr 2004 04:31:45 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAPRz-0005OD-7B
	for classpath@gnu.org; Mon, 05 Apr 2004 04:27:23 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 5 Apr 2004 10:27:14 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADCE8@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQaUml/e8IWFGECQOGzI4zpnD4soAAkW2Kg
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Michael Koch" <konqueror@gmx.de>,
	"Mark Wielaard" <mark@klomp.org>
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 08:31:48 -0000

Michael Koch wrote:
> The RawData pointer will get the real address to a native=20
> memory region.=20
> It can be directly used and has always the pointer size of the=20
> platform. There will never be problems on platforms with more then 64=20
> bit. Its really simply. Its just not done in classpath yet because I=20
> developed NIO on gcj so far. This hopefully changes now.=20
> (JamVM, be my friend ...).

For what it's worth, I really like this approach (using RawData in NIO)
and I'm looking forward on getting NIO working on IKVM.

Regards,
Jeroen



From MAILER-DAEMON Mon Apr 05 04:34:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAPYf-0000QN-8S
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 04:34:17 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAPYS-0000G6-03
	for classpath@gnu.org; Mon, 05 Apr 2004 04:34:04 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAPXt-0008Fy-U2
	for classpath@gnu.org; Mon, 05 Apr 2004 04:34:01 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAPS2-0005OD-0D
	for classpath@gnu.org; Mon, 05 Apr 2004 04:27:26 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 5 Apr 2004 10:27:14 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADCE9@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Next release?
Thread-Index: AcQac9+XRSFxvg5qTEK1a363DwG5jAAcFvtA
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Mark Wielaard" <mark@klomp.org>
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: Next release?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 08:34:12 -0000

Mark Wielaard wrote:
> On Wed, 2004-03-31 at 10:32, Jeroen Frijters wrote:
> > I'm planning my first real IKVM release (to be included=20
> with the Mono
> > 1.0 release) and I'd like to know when the next GNU=20
> Classpath release is
> > approximately due. Do you know have a date planned already?
>=20
> I like our time-based release cycle.

To be clear, I think it's fine too. I didn't mean to imply otherwise. I
just wasn't clear on when the next scheduled drop would be.

> The 0.08 release was late by two weeks, but I think we have enough new
> things already to just ignore that and do a 0.09 snapshot in the last
> week of April. And then 0.10 in the last week of June (hope=20
> that is just in time to make it for that mono 1.0 thing.)

In that case I think I'll probably stick to 0.09 for the Mono release.
How do people feel about the Class/VMClass changes? Should we include
those in 0.09?

Regards,
Jeroen



From MAILER-DAEMON Mon Apr 05 05:00:16 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAPxW-0006rn-9N
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 04:59:58 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAPw8-0006G4-Ks
	for classpath@gnu.org; Mon, 05 Apr 2004 04:58:32 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAPv0-0004ud-1N
	for classpath@gnu.org; Mon, 05 Apr 2004 04:57:53 -0400
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAPqR-0001N2-9P
	for classpath@gnu.org; Mon, 05 Apr 2004 04:52:39 -0400
Received: from localhost (localhost [127.0.0.1]) (uid 1000)
	by tangency.co.uk with local; Mon, 05 Apr 2004 09:47:01 +0100
Date: Mon, 5 Apr 2004 09:47:01 +0100
From: "S. Meslin-Weber" <twiun@adorphuye.com>
To: GNU Classpath <classpath@gnu.org>
Message-ID: <20040405084701.GF5755@tangency.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
Subject: Bad link for 0.08 download?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 08:59:56 -0000

Hi guys,

I tried downloading classpath-0.08.tgz from the downloads page last
night and it looks like the URL is pointing to the alpha gnu ftp site.
Shouldn't that be poiting to the regular gnu ftp site?

Thanks,

Stephane



From MAILER-DAEMON Mon Apr 05 05:38:19 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAQXv-0002t4-4c
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 05:37:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAQJX-0005Ro-1u
	for classpath@gnu.org; Mon, 05 Apr 2004 05:22:43 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAQHq-0003Sl-Sv
	for classpath@gnu.org; Mon, 05 Apr 2004 05:21:30 -0400
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAQGc-0002El-IA
	for classpath@gnu.org; Mon, 05 Apr 2004 05:19:42 -0400
Received: from localhost (localhost [127.0.0.1]) (uid 1000)
	by tangency.co.uk with local; Mon, 05 Apr 2004 10:14:11 +0100
Date: Mon, 5 Apr 2004 10:14:11 +0100
From: "S. Meslin-Weber" <twiun@adorphuye.com>
To: SableVM <sablevm-developer@lists.sourceforge.net>
Message-ID: <20040405091411.GG5755@tangency.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
Cc: GNU Classpath <classpath@gnu.org>
Subject: Odonata+SableVM+Classpath works! (and bootclasspath question)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 09:37:15 -0000

Hi everyone,

As reported on #sablevm I'm happy to say that Odonata[1] runs well under
SableVM. I haven't measured any speeds or memory usage but with regards
to visual output SableVM is on a par with GIJ (both use GNU Classpath,
I know, but I didn't want to assume that all JVM using GNU Classpath
would give the same results). I believe that the GNUClasspath AWT is the
cause of any visual/behavioural discrepancies I see when running Odonata
on SableVM (and GIJ) and on Sun's 1.4.2 Java2 SDK.

On a related note, I develop Odonata against Sun's 1.4.2 Java2 SDK and
make use of the -Xbootclasspath/p feature to prepend my classes ahead of
the JVM's own classes so that mine will be loaded in preference to any
default ones.

With SableVM I had to resort to extracting my jar file *over* SableVM's
core classpath installation. This is due to the bootclasspath argument
in SableVM seemingly not being able to take more than one path. Ideally,
Sun-like arguments to override, append or prepend to the bootclasspath
would be highly beneficial.

Thanks for the great work on SableVM!

Stephane

[1] Odonata is a set of 100% Java AWT peers for use with framebuffers.
    It is  released under the GPL and further information can be found
		at: http://odonata.tangency.co.uk



From MAILER-DAEMON Mon Apr 05 07:29:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BASI1-000101-K9
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 07:29:17 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BASHx-0000zQ-8g
	for classpath@gnu.org; Mon, 05 Apr 2004 07:29:13 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BASHP-0000tO-Gp
	for classpath@gnu.org; Mon, 05 Apr 2004 07:29:11 -0400
Received: from [212.227.126.176] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAS0v-0007X1-QZ
	for classpath@gnu.org; Mon, 05 Apr 2004 07:11:38 -0400
Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAS0r-0004bd-00
	for classpath@gnu.org; Mon, 05 Apr 2004 13:11:33 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAS0q-0005RM-00
	for classpath@gnu.org; Mon, 05 Apr 2004 13:11:33 +0200
Message-ID: <40713EEC.1070205@aicas.com>
Date: Mon, 05 Apr 2004 13:11:40 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------030200010408050802010406"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch for java.awt.image.ColorModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 11:29:14 -0000

This is a multi-part message in MIME format.
--------------030200010408050802010406
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

I suggest the following patch

2004-04-05  Ingo Proetel <proetel@aicas.com>

	* java/awt/image/ColorModel.java (getRGBdefault): Default ColorModel has 32 bit pixels not 8 bit 
pixels.
	(isCompatibleRaster): Added javadoc comment.

ingo

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------030200010408050802010406
Content-Type: text/plain;
 name="ColorModel.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ColorModel.diff"

Index: java/awt/image/ColorModel.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/image/ColorModel.java,v
retrieving revision 1.17
diff -u -r1.17 ColorModel.java
--- java/awt/image/ColorModel.java	24 Jun 2003 17:07:07 -0000	1.17
+++ java/awt/image/ColorModel.java	5 Apr 2004 11:06:05 -0000
@@ -166,7 +166,7 @@
    */
   public static ColorModel getRGBdefault()
   {
-    return new DirectColorModel(8, 0xff0000, 0xff00, 0xff, 0xff000000);
+    return new DirectColorModel(32, 0xff0000, 0xff00, 0xff, 0xff000000);
   }
 
   public final boolean hasAlpha()
@@ -597,7 +597,11 @@
     return null;
   }
     
-  // Typically overridden
+  /**
+   * Checks if the given raster has a compatible data-layout (SampleModel).
+   * @param raster The Raster to test.
+   * @return true if raster is compatible.
+   */ 
   public boolean isCompatibleRaster(Raster raster)
   {
     SampleModel sampleModel = raster.getSampleModel();

--------------030200010408050802010406--



From MAILER-DAEMON Mon Apr 05 08:13:36 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BASyt-0007hi-TG
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 08:13:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BASyo-0007fP-Vi
	for classpath@gnu.org; Mon, 05 Apr 2004 08:13:30 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BASyA-0007WX-HY
	for classpath@gnu.org; Mon, 05 Apr 2004 08:13:21 -0400
Received: from [212.227.126.173] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BASUO-0002vm-FK
	for classpath@gnu.org; Mon, 05 Apr 2004 07:42:04 -0400
Received: from [212.227.126.207] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BASUG-0004xt-00
	for classpath@gnu.org; Mon, 05 Apr 2004 13:41:56 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BASUF-00006F-00
	for classpath@gnu.org; Mon, 05 Apr 2004 13:41:55 +0200
Message-ID: <4071460B.3070303@aicas.com>
Date: Mon, 05 Apr 2004 13:42:03 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------020104060807020007070804"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch for java.awt.image.Raster
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 12:13:32 -0000

This is a multi-part message in MIME format.
--------------020104060807020007070804
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

I suggest the following patch
2004-04-05  Ingo Proetel  <proetel@aicas.com>

	* java/awt/image/Raster.java (toString): Added method.

ingo


-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------020104060807020007070804
Content-Type: text/plain;
 name="Raster.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="Raster.diff"

Repository : iproetel@savannah.gnu.org:/cvsroot/classpath
Module     : classpath
Working dir: ~/GNUCP/classpath/



In directory .:
              Modified                ChangeLog
              Unknown                 buildIt
              Unknown                 text.diff
In directory doc:
In directory doc/api:
In directory doc/www.gnu.org:
In directory gnu:
In directory gnu/classpath:
In directory gnu/java:
In directory gnu/java/nio:
In directory java:
In directory java/awt:
              Modified                java/awt/Polygon.java
              Modified                java/awt/TextField.java
              Modified                java/awt/Window.java
In directory java/awt/image:
              Modified                java/awt/image/BufferedImage.java
              Modified                java/awt/image/ColorModel.java
              Modified                java/awt/image/ComponentSampleModel.java
              Modified                java/awt/image/Raster.java
              Modified                java/awt/image/SampleModel.java
              Modified                java/awt/image/SinglePixelPackedSampleModel.java
In directory javax:
In directory javax/swing:
In directory javax/swing/plaf:
In directory lib:
              Unknown                 lib/org
              Unknown                 lib/resources
In directory native:
In directory native/jni:
In directory native/jni/java-net:
              Modified                native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
              Modified                native/jni/java-net/gnu_java_net_PlainSocketImpl.c
              Modified                native/jni/java-net/java_net_InetAddress.c
              Modified                native/jni/java-net/java_net_NetworkInterface.c
              Modified                native/jni/java-net/javanet.c
In directory native/jni/java-nio:
              Modified                native/jni/java-nio/java_nio_DirectByteBufferImpl.c
              Modified                native/jni/java-nio/java_nio_FileChannelImpl.c
              Modified                native/jni/java-nio/java_nio_FileLockImpl.c
In directory test:
In directory test/java.beans:
In directory testsuite:
In directory vm:
In directory vm/reference:

--------------------- End ---------------------
-- last cmd: cvs -f diff -u -N java/awt/image/Raster.java --

--------------020104060807020007070804--



From MAILER-DAEMON Mon Apr 05 08:18:11 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAT3K-0000Ja-5a
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 08:18:10 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAT3F-0000IJ-Ff
	for classpath@gnu.org; Mon, 05 Apr 2004 08:18:05 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAT2i-0000Am-3c
	for classpath@gnu.org; Mon, 05 Apr 2004 08:18:03 -0400
Received: from [212.227.126.177] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BASpG-0005x1-TC
	for classpath@gnu.org; Mon, 05 Apr 2004 08:03:39 -0400
Received: from [212.227.126.161] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BASpG-0007lJ-00
	for classpath@gnu.org; Mon, 05 Apr 2004 14:03:38 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BASpF-0004b8-00
	for classpath@gnu.org; Mon, 05 Apr 2004 14:03:37 +0200
Message-ID: <40714B20.4050602@aicas.com>
Date: Mon, 05 Apr 2004 14:03:44 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------070200050902070909050301"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch for java.awt.image.SinglePixelPackedSampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 12:18:06 -0000

This is a multi-part message in MIME format.
--------------070200050902070909050301
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

I suggest the following patch

2004-04-05  Ingo Proetel  <proetel@aicas.com>

	* java/awt/image/SinglePixelPackedSampleModel.java (getDataElements): New method.
	(setDataElements): New method.
	(setPixels): New method.
	(toString): New method.

ingo

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------070200050902070909050301
Content-Type: text/plain;
 name="SinglePixelPackedSampleModel.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="SinglePixelPackedSampleModel.diff"

Index: java/awt/image/SinglePixelPackedSampleModel.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/image/SinglePixelPackedSampleModel.java,v
retrieving revision 1.4
diff -u -r1.4 SinglePixelPackedSampleModel.java
--- java/awt/image/SinglePixelPackedSampleModel.java	9 Jan 2004 08:59:30 -0000	1.4
+++ java/awt/image/SinglePixelPackedSampleModel.java	5 Apr 2004 11:58:49 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 2000, 2002, 2003  Free Software Foundation
+/* Copyright (C) 2000, 2002, 2003, 2004  Free Software Foundation
 
 This file is part of GNU Classpath.
 
@@ -162,6 +162,63 @@
 			   1  // length
 			   );
   }
+  
+  /**
+   * This is a more efficient implementation of the default implementation in the super
+   * class. 
+   * @param x The x-coordinate of the pixel rectangle to store in <code>obj</code>.
+   * @param y The y-coordinate of the pixel rectangle to store in <code>obj</code>.
+   * @param w The width of the pixel rectangle to store in <code>obj</code>.
+   * @param h The height of the pixel rectangle to store in <code>obj</code>.
+   * @param obj The primitive array to store the pixels into or null to force creation.
+   * @param data The DataBuffer that is the source of the pixel data.
+   * @return The primitive array containing the pixel data.
+   * @see java.awt.image.SampleModel#getDataElements(int, int, int, int, java.lang.Object, java.awt.image.DataBuffer)
+   */
+  public Object getDataElements(int x, int y, int w, int h, Object obj,
+							DataBuffer data)
+  {
+    int size = w*h;
+    int dataSize = size;
+    Object pixelData = null;
+    switch (getTransferType())
+    {
+      case DataBuffer.TYPE_BYTE:
+        pixelData = ((DataBufferByte) data).getData();
+        if (obj == null) obj = new byte[dataSize];
+        break;
+       case DataBuffer.TYPE_USHORT:
+         pixelData = ((DataBufferUShort) data).getData();
+         if (obj == null) obj = new short[dataSize];
+         break;
+        case DataBuffer.TYPE_INT:
+          pixelData = ((DataBufferInt) data).getData();
+          if (obj == null) obj = new int[dataSize];
+          break;
+         default:
+             // Seems like the only sensible thing to do.
+           throw new ClassCastException();
+      }
+      if(x==0 && scanlineStride == w)
+      { 
+        // The full width need to be copied therefore we can copy in one shot.
+        System.arraycopy(pixelData, scanlineStride*y + data.getOffset(), obj, 0, size);
+      }
+      else
+      {  
+        // Since we do not need the full width we need to copy line by line.
+        int outOffset = 0;
+        int dataOffset = scanlineStride*y + x + data.getOffset();
+        for (int yy = y; yy<(y+h); yy++)
+        {
+          System.arraycopy(pixelData, dataOffset, obj, outOffset, w);
+          dataOffset += scanlineStride;
+          outOffset += w;
+        }
+      }
+    return obj;
+  }
+  
 
   public int[] getPixel(int x, int y, int[] iArray, DataBuffer data)
   {
@@ -201,7 +258,51 @@
     int samples = data.getElem(offset);
     return (samples & bitMasks[b]) >>> bitOffsets[b];
   }
-
+  
+  /**
+   * This method implements a more efficient way to set data elements than the default
+   * implementation of the super class. It sets the data elements line by line instead 
+   * of pixel by pixel.
+   * @param x The x-coordinate of the data elements in <code>obj</code>.
+   * @param y The y-coordinate of the data elements in <code>obj</code>.
+   * @param w The width of the data elements in <code>obj</code>.
+   * @param h The height of the data elements in <code>obj</code>.
+   * @param obj The primitive array containing the data elements to set.
+   * @param data The DataBuffer to store the data elements into.
+   * @see java.awt.image.SampleModel#setDataElements(int, int, int, int, java.lang.Object, java.awt.image.DataBuffer)
+   */
+  public void setDataElements(int x, int y, int w, int h,
+				Object obj, DataBuffer data)
+  {
+    
+    Object pixelData;
+    switch (getTransferType())
+    {
+      case DataBuffer.TYPE_BYTE:
+        pixelData = ((DataBufferByte) data).getData();
+        break;
+       case DataBuffer.TYPE_USHORT:
+         pixelData = ((DataBufferUShort) data).getData();
+         break;
+       case DataBuffer.TYPE_INT:
+         pixelData = ((DataBufferInt) data).getData();
+         break;
+       default:
+          // Seems like the only sensible thing to do.
+          throw new ClassCastException();
+    }
+    
+    int inOffset = 0;
+    int dataOffset = scanlineStride*y + x + data.getOffset();
+    for (int yy=y; yy<(y+h); yy++)
+    {
+      System.arraycopy(obj,inOffset,pixelData,dataOffset,w);
+      dataOffset += scanlineStride;
+      inOffset += w;
+    }
+  }
+  
+  
   public void setDataElements(int x, int y, Object obj, DataBuffer data)
   {
     int offset = scanlineStride*y + x + data.getOffset();
@@ -273,6 +374,39 @@
     data.setElem(offset, samples);
   }
 
+  /**
+   * This method implements a more efficient way to set pixels than the default
+   * implementation of the super class. It copies the pixel components directly
+   * from the input array instead of creating a intermediate buffer.
+   * @param x The x-coordinate of the pixel rectangle in <code>obj</code>.
+   * @param y The y-coordinate of the pixel rectangle in <code>obj</code>.
+   * @param w The width of the pixel rectangle in <code>obj</code>.
+   * @param h The height of the pixel rectangle in <code>obj</code>.
+   * @param obj The primitive array containing the pixels to set.
+   * @param data The DataBuffer to store the pixels into.
+   * @see java.awt.image.SampleModel#setPixels(int, int, int, int, int[], java.awt.image.DataBuffer)
+   */
+  public void setPixels(int x, int y, int w, int h, int[] iArray,
+						DataBuffer data)
+  {
+    int inOffset = 0;
+    int[] pixel = new int[numBands];
+    for (int yy=y; yy<(y+h); yy++)
+     {
+      int offset = scanlineStride*yy + x;
+      for (int xx=x; xx<(x+w); xx++)
+       { 
+        int samples = 0;
+        for (int b=0; b<numBands; b++)
+          samples |= (iArray[inOffset+b] << bitOffsets[b]) & bitMasks[b];
+        data.setElem(0, offset, samples);
+        inOffset += numBands;
+        offset += 1;
+      }
+    }
+  }
+  
+  
   public void setSample(int x, int y, int b, int s, DataBuffer data)
   {
     int offset = scanlineStride*y + x;
@@ -281,5 +415,25 @@
     samples &= ~bitMask;
     samples |= (s << bitOffsets[b]) & bitMask;
     data.setElem(offset, samples);
+  }
+  
+  /**
+   * Creates a String with some information about this SampleModel.
+   * @return A String describing this SampleModel.
+   * @see java.lang.Object#toString()
+   */
+  public String toString()
+  {
+    StringBuffer result = new StringBuffer();
+    result.append(getClass().getName());
+    result.append("[");
+    result.append("scanlineStride=").append(scanlineStride);
+    for(int i=0; i < bitMasks.length; i+=1)
+    {
+      result.append(", mask[").append(i).append("]=0x").append(Integer.toHexString(bitMasks[i]));
+    }
+    
+    result.append("]");
+    return result.toString();
   }
 }

--------------070200050902070909050301--



From MAILER-DAEMON Mon Apr 05 08:43:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BATRv-00068j-76
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 08:43:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BARN0-00087o-3m
	for classpath@gnu.org; Mon, 05 Apr 2004 06:30:22 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BARLT-0007MC-Iv
	for classpath@gnu.org; Mon, 05 Apr 2004 06:29:19 -0400
Received: from [203.17.251.1] (helo=quoll.daa.com.au)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAR71-0000s2-8K
	for classpath@gnu.org; Mon, 05 Apr 2004 06:13:51 -0400
Received: from daa.com.au (narbalek.daa.com.au [203.17.251.34])
	by quoll.daa.com.au (Postfix) with ESMTP
	id D2FAD4C122; Mon,  5 Apr 2004 18:13:49 +0800 (WST)
Message-ID: <4071315D.7030202@daa.com.au>
Date: Mon, 05 Apr 2004 18:13:49 +0800
From: James Henstridge <james@daa.com.au>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-AU;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-au, en
MIME-Version: 1.0
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <1081117378.16358.4.camel@tortoise.toronto.redhat.com>
In-Reply-To: <1081117378.16358.4.camel@tortoise.toronto.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Mon, 05 Apr 2004 08:43:32 -0400
Cc: classpath list <classpath@gnu.org>
Subject: Re: jhbuild and classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 10:35:24 -0000

On 5/04/2004 6:22 AM, Thomas Fitzsimmons wrote:

>Hi James,
>
>I've been experimenting with using jhbuild for GNU Classpath
>development.  My compliments on jhbuild; it's a very nice tool!
>  
>
Cool.  I put a fair bit of work into making jhbuild usable outside of 
Gnome (primarily for some of the freedesktop.org projects such as the X 
server), so it'll be good if it benefits you too.

If you use a URL for the module set in ~/.jhbuildrc, jhbuild should 
download and cache the module information from

>Our AWT implementation relies on GTK, so jhbuild is a natural fit for
>us.  And it looks like jhbuild has the potential to make bootstrapping a
>Classpath-based development environment dramatically simpler.
>
>I've run into one problem though.  In the GNU Classpath world, we prefer
>to have builddir != srcdir, whereas it seems most GNOME modules, and
>hence jhbuild, assume builddir == srcdir.  What do you think about
>having a builddir != srcdir mode that could be set in .jhbuildrc?
>  
>
Shouldn't be too difficult to implement.  What layout do you use for 
your source/build trees in this setup?

James.

-- 
Email: james@daa.com.au
WWW:   http://www.daa.com.au/~james/





From MAILER-DAEMON Mon Apr 05 09:30:53 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BATUz-00079G-Pd
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 08:46:45 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BARvX-0006g3-Oo
	for classpath@gnu.org; Mon, 05 Apr 2004 07:06:03 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BARup-0006V4-Bz
	for classpath@gnu.org; Mon, 05 Apr 2004 07:05:50 -0400
Received: from [212.227.126.176] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BARuo-0006U9-3q
	for classpath@gnu.org; Mon, 05 Apr 2004 07:05:18 -0400
Received: from [212.227.126.160] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BARum-0002QS-00
	for classpath@gnu.org; Mon, 05 Apr 2004 13:05:16 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BARum-0006yY-00
	for classpath@gnu.org; Mon, 05 Apr 2004 13:05:16 +0200
Message-ID: <40713D73.1070002@aicas.com>
Date: Mon, 05 Apr 2004 13:05:23 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------000901010205010602080308"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch for java.awt.image.ComponentSampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 12:46:26 -0000

This is a multi-part message in MIME format.
--------------000901010205010602080308
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

I suggest the following patch:

2004-04-05  Ingo Proetel  <proetel@aicas.com>

	* java/awt/image/ComponentSampleModel.java (setDataSamples):Do not reset scanline stride.

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------000901010205010602080308
Content-Type: text/plain;
 name="ComponentSampleModel.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ComponentSampleModel.diff"

Repository : iproetel@savannah.gnu.org:/cvsroot/classpath
Module     : classpath
Working dir: ~/GNUCP/classpath/



In directory .:
              Unknown                 buildIt
              Unknown                 text.diff
In directory doc:
In directory doc/api:
In directory doc/www.gnu.org:
In directory gnu:
In directory gnu/classpath:
In directory gnu/java:
In directory gnu/java/nio:
In directory java:
In directory java/awt:
              Modified                java/awt/Polygon.java
              Modified                java/awt/TextField.java
              Modified                java/awt/Window.java
In directory java/awt/image:
              Modified                java/awt/image/BufferedImage.java
              Modified                java/awt/image/ColorModel.java
              Modified                java/awt/image/ComponentSampleModel.java
              Modified                java/awt/image/Raster.java
              Modified                java/awt/image/SampleModel.java
              Modified                java/awt/image/SinglePixelPackedSampleModel.java
In directory javax:
In directory javax/swing:
In directory javax/swing/plaf:
In directory lib:
              Unknown                 lib/org
              Unknown                 lib/resources
In directory native:
In directory native/jni:
In directory native/jni/java-net:
              Modified                native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
              Modified                native/jni/java-net/gnu_java_net_PlainSocketImpl.c
              Modified                native/jni/java-net/java_net_InetAddress.c
              Modified                native/jni/java-net/java_net_NetworkInterface.c
              Modified                native/jni/java-net/javanet.c
In directory native/jni/java-nio:
              Modified                native/jni/java-nio/java_nio_DirectByteBufferImpl.c
              Modified                native/jni/java-nio/java_nio_FileChannelImpl.c
              Modified                native/jni/java-nio/java_nio_FileLockImpl.c
In directory test:
In directory test/java.beans:
In directory testsuite:
In directory vm:
In directory vm/reference:

--------------------- End ---------------------
-- last cmd: cvs -f diff -u -N java/awt/image/ComponentSampleModel.java --

--------------000901010205010602080308--



From MAILER-DAEMON Mon Apr 05 09:36:42 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAUHK-0001eU-3r
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 09:36:42 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAUHH-0001dj-D1
	for classpath@gnu.org; Mon, 05 Apr 2004 09:36:39 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAUGl-0001X0-9L
	for classpath@gnu.org; Mon, 05 Apr 2004 09:36:38 -0400
Received: from [212.227.126.183] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BASh3-0004pD-RP
	for classpath@gnu.org; Mon, 05 Apr 2004 07:55:09 -0400
Received: from [212.227.126.208] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BASh3-0002LL-00
	for classpath@gnu.org; Mon, 05 Apr 2004 13:55:09 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BASh2-0000vy-00
	for classpath@gnu.org; Mon, 05 Apr 2004 13:55:08 +0200
Message-ID: <40714921.4050709@aicas.com>
Date: Mon, 05 Apr 2004 13:55:13 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------090507030503030006090600"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch for java.awt.image.SampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 13:36:40 -0000

This is a multi-part message in MIME format.
--------------090507030503030006090600
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

I suggest the following patch
2004-04-05  Ingo Proetel  <proetel@aicas.com>

	* java/awt/image/SampleModel.java (<init>): Added error cause information to
	thrown exception.

ingo

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------090507030503030006090600
Content-Type: text/plain;
 name="SampleModel.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="SampleModel.diff"

Repository : iproetel@savannah.gnu.org:/cvsroot/classpath
Module     : classpath
Working dir: ~/GNUCP/classpath/



In directory .:
              Modified                ChangeLog
              Unknown                 buildIt
              Unknown                 text.diff
In directory doc:
In directory doc/api:
In directory doc/www.gnu.org:
In directory gnu:
In directory gnu/classpath:
In directory gnu/java:
In directory gnu/java/nio:
In directory java:
In directory java/awt:
              Modified                java/awt/Polygon.java
              Modified                java/awt/TextField.java
              Modified                java/awt/Window.java
In directory java/awt/image:
              Modified                java/awt/image/BufferedImage.java
              Modified                java/awt/image/ColorModel.java
              Modified                java/awt/image/ComponentSampleModel.java
              Modified                java/awt/image/Raster.java
              Modified                java/awt/image/SampleModel.java
              Modified                java/awt/image/SinglePixelPackedSampleModel.java
In directory javax:
In directory javax/swing:
In directory javax/swing/plaf:
In directory lib:
              Unknown                 lib/org
              Unknown                 lib/resources
In directory native:
In directory native/jni:
In directory native/jni/java-net:
              Modified                native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
              Modified                native/jni/java-net/gnu_java_net_PlainSocketImpl.c
              Modified                native/jni/java-net/java_net_InetAddress.c
              Modified                native/jni/java-net/java_net_NetworkInterface.c
              Modified                native/jni/java-net/javanet.c
In directory native/jni/java-nio:
              Modified                native/jni/java-nio/java_nio_DirectByteBufferImpl.c
              Modified                native/jni/java-nio/java_nio_FileChannelImpl.c
              Modified                native/jni/java-nio/java_nio_FileLockImpl.c
In directory test:
In directory test/java.beans:
In directory testsuite:
In directory vm:
In directory vm/reference:

--------------------- End ---------------------
-- last cmd: cvs -f diff -u -N java/awt/image/SampleModel.java --

--------------090507030503030006090600--



From MAILER-DAEMON Mon Apr 05 09:40:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAUKZ-0002f9-1c
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 09:40:03 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BATRG-0005w8-4c
	for classpath@gnu.org; Mon, 05 Apr 2004 08:42:54 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BATHU-0003RR-2f
	for classpath@gnu.org; Mon, 05 Apr 2004 08:33:19 -0400
Received: from [212.227.126.184] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BASvC-0006yD-0k
	for classpath@gnu.org; Mon, 05 Apr 2004 08:09:46 -0400
Received: from [212.227.126.162] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BASvB-0006xE-00
	for classpath@gnu.org; Mon, 05 Apr 2004 14:09:45 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BASvA-0004TU-00
	for classpath@gnu.org; Mon, 05 Apr 2004 14:09:45 +0200
Message-ID: <40714C90.3070904@aicas.com>
Date: Mon, 05 Apr 2004 14:09:52 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------060508040001040600020802"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch for java.awt.Polygon
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 13:39:54 -0000

This is a multi-part message in MIME format.
--------------060508040001040600020802
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

I suggest the following patch
2004-04-05  Ingo Proetel  <proetel@aicas.com>

	* java/awt/Polygon.java (getBoundingBox): Use correct y-coordinate
	in Rectangle constructor.

ingo

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------060508040001040600020802
Content-Type: text/plain;
 name="Polygon.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="Polygon.diff"

Repository : iproetel@savannah.gnu.org:/cvsroot/classpath
Module     : classpath
Working dir: ~/GNUCP/classpath/



In directory .:
              Modified                ChangeLog
              Unknown                 buildIt
              Unknown                 text.diff
In directory doc:
In directory doc/api:
In directory doc/www.gnu.org:
In directory gnu:
In directory gnu/classpath:
In directory gnu/java:
In directory gnu/java/nio:
In directory java:
In directory java/awt:
              Modified                java/awt/Polygon.java
              Modified                java/awt/TextField.java
              Modified                java/awt/Window.java
In directory java/awt/image:
              Modified                java/awt/image/BufferedImage.java
              Modified                java/awt/image/ColorModel.java
              Modified                java/awt/image/ComponentSampleModel.java
              Modified                java/awt/image/Raster.java
              Modified                java/awt/image/SampleModel.java
              Modified                java/awt/image/SinglePixelPackedSampleModel.java
In directory javax:
In directory javax/swing:
In directory javax/swing/plaf:
In directory lib:
              Unknown                 lib/org
              Unknown                 lib/resources
In directory native:
In directory native/jni:
In directory native/jni/java-net:
              Modified                native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
              Modified                native/jni/java-net/gnu_java_net_PlainSocketImpl.c
              Modified                native/jni/java-net/java_net_InetAddress.c
              Modified                native/jni/java-net/java_net_NetworkInterface.c
              Modified                native/jni/java-net/javanet.c
In directory native/jni/java-nio:
              Modified                native/jni/java-nio/java_nio_DirectByteBufferImpl.c
              Modified                native/jni/java-nio/java_nio_FileChannelImpl.c
              Modified                native/jni/java-nio/java_nio_FileLockImpl.c
In directory test:
In directory test/java.beans:
In directory testsuite:
In directory vm:
In directory vm/reference:

--------------------- End ---------------------
-- last cmd: cvs -f diff -u -N java/awt/Polygon.java --

--------------060508040001040600020802--



From MAILER-DAEMON Mon Apr 05 10:07:25 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BATiK-0001HV-CL
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 09:00:32 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BATi3-0001DT-OO
	for classpath@gnu.org; Mon, 05 Apr 2004 09:00:15 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAThT-00010J-1M
	for classpath@gnu.org; Mon, 05 Apr 2004 09:00:11 -0400
Received: from [212.227.126.187] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAThS-0000zq-9N
	for classpath@gnu.org; Mon, 05 Apr 2004 08:59:38 -0400
Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAThR-0002oa-00
	for classpath@gnu.org; Mon, 05 Apr 2004 14:59:37 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAThQ-0003C3-00
	for classpath@gnu.org; Mon, 05 Apr 2004 14:59:36 +0200
Message-ID: <4071583F.7060408@aicas.com>
Date: Mon, 05 Apr 2004 14:59:43 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------080802090009080106020402"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch to implement ColorGraphicsContext
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 13:00:19 -0000

This is a multi-part message in MIME format.
--------------080802090009080106020402
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

I suggest the following patch
2004-04-05  Ingo Proetel  <proetel@aicas.com>

	* java/awt/ColorPaintContext.java (<init>): Added ColorModel to signature.
	(getColorModel): Return the actual color model.
	(getRaster): Implemented.
	(ColorRaster): New inner class.
	* java/awt/SystemColor.java (createContext): Use ColorModel when creating
	a PaintContext.
	* java/awt/Color.java (<init>): Make exception more verbose.
	(createContext): Use ColorModel when creating a PaintContext.
	

ingo

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------080802090009080106020402
Content-Type: text/plain;
 name="ColorModel.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ColorModel.diff"

Index: java/awt/image/ColorModel.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/image/ColorModel.java,v
retrieving revision 1.17
diff -u -r1.17 ColorModel.java
--- java/awt/image/ColorModel.java	24 Jun 2003 17:07:07 -0000	1.17
+++ java/awt/image/ColorModel.java	5 Apr 2004 11:06:05 -0000
@@ -166,7 +166,7 @@
    */
   public static ColorModel getRGBdefault()
   {
-    return new DirectColorModel(8, 0xff0000, 0xff00, 0xff, 0xff000000);
+    return new DirectColorModel(32, 0xff0000, 0xff00, 0xff, 0xff000000);
   }
 
   public final boolean hasAlpha()
@@ -597,7 +597,11 @@
     return null;
   }
     
-  // Typically overridden
+  /**
+   * Checks if the given raster has a compatible data-layout (SampleModel).
+   * @param raster The Raster to test.
+   * @return true if raster is compatible.
+   */ 
   public boolean isCompatibleRaster(Raster raster)
   {
     SampleModel sampleModel = raster.getSampleModel();

--------------080802090009080106020402
Content-Type: text/plain;
 name="ColorPaintContext.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ColorPaintContext.diff"

Index: java/awt/ColorPaintContext.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/ColorPaintContext.java,v
retrieving revision 1.1
diff -u -r1.1 ColorPaintContext.java
--- java/awt/ColorPaintContext.java	8 May 2002 03:07:24 -0000	1.1
+++ java/awt/ColorPaintContext.java	5 Apr 2004 12:43:00 -0000
@@ -39,7 +39,13 @@
 package java.awt;
 
 import java.awt.image.ColorModel;
+import java.awt.image.DataBuffer;
+import java.awt.image.DataBufferByte;
+import java.awt.image.DataBufferInt;
+import java.awt.image.DataBufferUShort;
 import java.awt.image.Raster;
+import java.awt.image.SampleModel;
+import java.util.Arrays;
 
 /**
  * This class provides a paint context which will fill a rectanglar region of
@@ -55,15 +61,19 @@
    * SystemColor.
    */
   final int color;
+  final ColorModel colorModel;
 
+  private ColorRaster mCachedRaster;
+ 
   /**
    * Create the context for a given color.
    *
    * @param c the solid color to use
    */
-  ColorPaintContext(int c)
+  ColorPaintContext(ColorModel cm,int c)
   {
     color = c;
+    colorModel = cm;
   }
 
   /**
@@ -75,14 +85,13 @@
   }
 
   /**
-   * Return the color model of this context. This ignores the model passed
-   * in the request, since colors are always in sRGB.
+   * Return the color model of this context. 
    *
    * @return the context color model
    */
   public ColorModel getColorModel()
   {
-    return ColorModel.getRGBdefault();
+    return colorModel;
   }
 
   /**
@@ -96,8 +105,71 @@
    */
   public Raster getRaster(int x, int y, int w, int h)
   {
-    // XXX Implement. Sun uses undocumented implementation class
-    // sun.awt.image.IntegerInterleavedRaster.
-    throw new Error("not implemented");
+   if(  mCachedRaster == null 
+       || mCachedRaster.getWidth() < w
+       || mCachedRaster.getHeight() < h)
+    {
+     mCachedRaster = new ColorRaster(colorModel, 0, 0, w, h, color);
+    }
+   return mCachedRaster.createChild(0,0,w,h,x,y,null);
   }
+  
+  private class ColorRaster extends Raster{
+      
+        /**
+         * 
+         * @param cm
+         * @param rgbPixel
+         */
+        ColorRaster(ColorModel cm,int x, int y, int width, int height, int rgbPixel)
+        {         
+          super(cm.createCompatibleSampleModel(width,height),new Point(x,y));
+          Object pixel = cm.getDataElements(rgbPixel,null);
+          getSampleModel().setDataElements(0, 0,width,height,multiplyData(pixel,null,width*height),dataBuffer);
+        }
+               
+        
+        
+        private Object multiplyData(Object src, Object dest, int factor)
+        {
+          Object from;
+          int srcLength = 0;
+          if (src instanceof byte[])
+           {
+            srcLength = ((byte[])src).length;
+            
+            if (dest == null) dest = new byte[factor * srcLength];
+          }
+          else if (src instanceof short[])
+           {
+            srcLength = ((short[])src).length;
+            if (dest == null) dest = new short[factor * srcLength];
+          }
+          else if (src instanceof int[])
+           {
+            srcLength = ((int[]) src).length;
+            if (dest == null) dest = new int[factor * srcLength];
+          }
+          else
+           {
+            throw new ClassCastException("Unknown data buffer type");
+          }
+
+          System.arraycopy(src,0,dest,0,srcLength);
+          
+          int count = 1;
+          while(count*2 < factor)
+          {
+            System.arraycopy(dest, 0, dest, count * srcLength, count*srcLength);
+            count *= 2; 
+          }
+          
+          if(factor > count)
+            System.arraycopy(dest,0, dest, count * srcLength, (factor - count) * srcLength );
+    
+            return dest;
+        }
+        
+  }
+  
 } // class ColorPaintContext

--------------080802090009080106020402
Content-Type: text/plain;
 name="SystemColor.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="SystemColor.diff"

Index: java/awt/SystemColor.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/SystemColor.java,v
retrieving revision 1.5
diff -u -r1.5 SystemColor.java
--- java/awt/SystemColor.java	8 May 2002 03:07:25 -0000	1.5
+++ java/awt/SystemColor.java	5 Apr 2004 12:36:04 -0000
@@ -427,7 +427,7 @@
    * as the system color is solid, the context does not need any of the
    * passed parameters to do its job.
    *
-   * @param cm the requested color model, ignored
+   * @param cm the requested color model
    * @param deviceBounds the bounding box in device coordinates, ignored
    * @param userBounds the bounding box in user coordinates, ignored
    * @param xform the bounds transformation, ignored
@@ -441,8 +441,8 @@
   {
     Toolkit.getDefaultToolkit().loadSystemColors(colors);
     int color = colors[value] | ALPHA_MASK;
-    if (context == null || color != context.color)
-      context = new ColorPaintContext(color);
+    if (context == null || color != context.color || !context.getColorModel().equals(cm))
+      context = new ColorPaintContext(cm,color);
     return context;
   }    
 

--------------080802090009080106020402--



From MAILER-DAEMON Mon Apr 05 10:08:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAUmU-0000xR-0w
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 10:08:54 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAUmP-0000wQ-M8
	for classpath@gnu.org; Mon, 05 Apr 2004 10:08:49 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAUlt-0000pS-Lm
	for classpath@gnu.org; Mon, 05 Apr 2004 10:08:48 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAUlt-0000pL-0k
	for classpath@gnu.org; Mon, 05 Apr 2004 10:08:17 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-109.ewetel.net
	[80.228.94.109])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i35E7pre004938;
	Mon, 5 Apr 2004 16:07:52 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BATSJ-0001Lg-00; Mon, 05 Apr 2004 14:43:59 +0200
From: Michael Koch <konqueror@gmx.de>
To: Andrew Haley <aph@redhat.com>
Date: Mon, 5 Apr 2004 15:43:34 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404041637.29773.konqueror@gmx.de>
	<16497.23262.932225.980277@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.23262.932225.980277@cuddles.cambridge.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404051543.34346.konqueror@gmx.de>
X-CheckCompat: OK
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 14:08:50 -0000

Am Montag, 5. April 2004 15:10 schrieb Andrew Haley:
> Michael Koch writes:
>  > > To be honest I think we should not have RawData in Classpath.
>
> The trouble with RawData (as it is used in gcj) is that it breaks the
> Java type system.  Its bizarre semantics mean that you have something
> that looks like an object reference but you can't use it as one.  You
> can't convert it to an instance of Object, for example.  A garbage
> collector can't inspect it.  A VM that doesn't expect this behaviour
> might crash.  If we use RawData like that in Classpath, a VM may need
> to be modified.  It might not even be possible.  For that reason, I
> believe that we should not use RawData in Classpath, although some VM
> implementors might choose to.
>
> I think we need a better abstraction.  Perhaps a Pointer class that
> may be subclassed to swtPeerPointer, nativeIntPointer, and so on.
> That will get over the enormous and painful maintenance problem with
> SWT, where you have no idea what type a pointer is, because
> everything is implicily void*.  This is truly Evil.
>
> If some VM implementers want to use a RawData reference as a raw
> pointer, fine.  But IMO our reference JNI shouldn't.
>
>  > > It is used in VMClass, but it seems no VM implementor actually
>  > > likes how that is setup now. And it is used in some of the new
>  > > nio implementation classes. But I have a hard time seeing how
>  > > our reference JNI implementation will make use of it. All places
>  > > where it is used have unimplemented native jni parts. How are
>  > > you planning to use this? Maybe we could add state (a Object or
>  > > byte[] field to the class) that holds the real data (==
>  > > address).
>
> Better.
>
>  > > And some access method to get add the address it represents
>  > > (that then might be optimized by a particular VM). But that
>  > > would mean that it isn't the same type as the one from libgcj
>  > > (or Ptr from kaffe) since those classes are not actually
>  > > accessed through normal java code or through JNI, but handled
>  > > specially through CNI or Kaffe native/vm code.
>  > >
>  > > As Andrew says we could maybe just use long if we want to store
>  > > an address. Andrew also worked hard on getting SWT (Eclipse) 64
>  > > bit clean. What I have seen from the (huge) patch this was
>  > > mainly done by turning addresses as stored by JNI from int to
>  > > long. BTW, was this work ever accepted into Eclipse?
>  >
>  > The RawData pointer will get the real address to a native memory
>  > region. It can be directly used and has always the pointer size of
>  > the platform.
>
> Uh, I don't understand what you mean, sorry.  Why is a Java reference
> the same size as a native pointer?  Perhaps I misunderstood you.

AFAIK a java refernce is a pointer and this pointer can point 
everywhere. Right ? Tell me when I'm wrong.


Michael




From MAILER-DAEMON Mon Apr 05 10:15:22 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAUsd-0002hD-Kc
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 10:15:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAUsY-0002ev-EZ
	for classpath@gnu.org; Mon, 05 Apr 2004 10:15:10 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAUBl-0000is-5s
	for classpath@gnu.org; Mon, 05 Apr 2004 09:31:29 -0400
Received: from [62.253.162.48] (helo=mta08-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BATvq-0004Ca-Pr
	for classpath@gnu.org; Mon, 05 Apr 2004 09:14:30 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta08-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405131239.TUJH5004.mta08-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 14:12:39 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35DAvCL028089; Mon, 5 Apr 2004 14:11:07 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35DAskv028083;
	Mon, 5 Apr 2004 14:10:54 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.23262.932225.980277@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 14:10:54 +0100
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404041637.29773.konqueror@gmx.de>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200403291647.23978.konqueror@gmx.de>
	<1081088103.7548.102.camel@elsschot.wildebeest.org>
	<200404041637.29773.konqueror@gmx.de>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 14:15:12 -0000

Michael Koch writes:
 > >
 > > To be honest I think we should not have RawData in Classpath.

The trouble with RawData (as it is used in gcj) is that it breaks the
Java type system.  Its bizarre semantics mean that you have something
that looks like an object reference but you can't use it as one.  You
can't convert it to an instance of Object, for example.  A garbage
collector can't inspect it.  A VM that doesn't expect this behaviour
might crash.  If we use RawData like that in Classpath, a VM may need
to be modified.  It might not even be possible.  For that reason, I
believe that we should not use RawData in Classpath, although some VM
implementors might choose to.

I think we need a better abstraction.  Perhaps a Pointer class that
may be subclassed to swtPeerPointer, nativeIntPointer, and so on.
That will get over the enormous and painful maintenance problem with
SWT, where you have no idea what type a pointer is, because everything
is implicily void*.  This is truly Evil.

If some VM implementers want to use a RawData reference as a raw
pointer, fine.  But IMO our reference JNI shouldn't.

 > > It is used in VMClass, but it seems no VM implementor actually likes
 > > how that is setup now. And it is used in some of the new nio
 > > implementation classes. But I have a hard time seeing how our
 > > reference JNI implementation will make use of it. All places where it
 > > is used have unimplemented native jni parts. How are you planning to
 > > use this? Maybe we could add state (a Object or byte[] field to the
 > > class) that holds the real data (== address).

Better.

 > > And some access method to get add the address it represents (that
 > > then might be optimized by a particular VM). But that would mean
 > > that it isn't the same type as the one from libgcj (or Ptr from
 > > kaffe) since those classes are not actually accessed through
 > > normal java code or through JNI, but handled specially through
 > > CNI or Kaffe native/vm code.
 > >
 > > As Andrew says we could maybe just use long if we want to store an
 > > address. Andrew also worked hard on getting SWT (Eclipse) 64 bit
 > > clean. What I have seen from the (huge) patch this was mainly done by
 > > turning addresses as stored by JNI from int to long. BTW, was this
 > > work ever accepted into Eclipse?
 > 
 > The RawData pointer will get the real address to a native memory region. 
 > It can be directly used and has always the pointer size of the 
 > platform.

Uh, I don't understand what you mean, sorry.  Why is a Java reference
the same size as a native pointer?  Perhaps I misunderstood you.

Andrew.



From MAILER-DAEMON Mon Apr 05 10:37:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAV5k-0006se-UT
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 10:28:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAV4L-0006Nm-Kl
	for classpath@gnu.org; Mon, 05 Apr 2004 10:27:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAUyq-0004bM-E7
	for classpath@gnu.org; Mon, 05 Apr 2004 10:22:11 -0400
Received: from [62.253.162.41] (helo=mta01-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAUvf-0003VV-9V
	for classpath@gnu.org; Mon, 05 Apr 2004 10:18:23 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta01-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405141757.JDBS17631.mta01-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 15:17:59 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35EGcCL028545; Mon, 5 Apr 2004 15:16:48 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35EGaLK028541;
	Mon, 5 Apr 2004 15:16:36 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.27204.226097.182524@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 15:16:36 +0100
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404051543.34346.konqueror@gmx.de>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404041637.29773.konqueror@gmx.de>
	<16497.23262.932225.980277@cuddles.cambridge.redhat.com>
	<200404051543.34346.konqueror@gmx.de>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 14:28:37 -0000

Michael Koch writes:
 > >
 > > Uh, I don't understand what you mean, sorry.  Why is a Java reference
 > > the same size as a native pointer?  Perhaps I misunderstood you.
 > 
 > AFAIK a java refernce is a pointer and this pointer can point 
 > everywhere. Right ?

No, not at all.  A java reference is simply a handle by which an
object may be found.  It might well be a hash code, or a table index.

Andrew.



From MAILER-DAEMON Mon Apr 05 11:00:05 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAVZm-0006xA-Mm
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 10:59:50 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAVZL-0006dr-PV
	for classpath@gnu.org; Mon, 05 Apr 2004 10:59:23 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAV2V-0005fo-FO
	for classpath@gnu.org; Mon, 05 Apr 2004 10:25:58 -0400
Received: from [62.253.162.45] (helo=mta05-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAV2U-0005f5-Nm
	for classpath@gnu.org; Mon, 05 Apr 2004 10:25:26 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta05-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405142416.ZCMH21130.mta05-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 15:24:16 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35ENjCL028594; Mon, 5 Apr 2004 15:23:55 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35ENi69028590;
	Mon, 5 Apr 2004 15:23:44 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.27631.897154.186927@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 15:23:43 +0100
To: Michael Koch <konqueror@gmx.de>, Mark Wielaard <mark@klomp.org>,
	Archie Cobbs <archie@dellroad.org>,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
In-Reply-To: <16497.27204.226097.182524@cuddles.cambridge.redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404041637.29773.konqueror@gmx.de>
	<16497.23262.932225.980277@cuddles.cambridge.redhat.com>
	<200404051543.34346.konqueror@gmx.de>
	<16497.27204.226097.182524@cuddles.cambridge.redhat.com>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: 
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 14:59:48 -0000

Andrew Haley writes:
 > Michael Koch writes:
 >  > >
 >  > > Uh, I don't understand what you mean, sorry.  Why is a Java reference
 >  > > the same size as a native pointer?  Perhaps I misunderstood you.
 >  > 
 >  > AFAIK a java refernce is a pointer and this pointer can point 
 >  > everywhere. Right ?
 > 
 > No, not at all.  A java reference is simply a handle by which an
 > object may be found.  It might well be a hash code, or a table index.

Or -- and this is by no means unlikely -- you might have a 32-bit
addressable heap on a 64-bit system.  This would be a pretty good
implementation strategy on some systems.

Andrew.



From MAILER-DAEMON Mon Apr 05 11:00:12 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAVZL-0006dc-Lz
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 10:59:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAVXb-0005js-21
	for classpath@gnu.org; Mon, 05 Apr 2004 10:57:35 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAVWy-0005Ld-W7
	for classpath@gnu.org; Mon, 05 Apr 2004 10:57:29 -0400
Received: from [212.227.126.187] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAVWy-0005L5-DO
	for classpath@gnu.org; Mon, 05 Apr 2004 10:56:56 -0400
Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAVWx-0000CT-00
	for classpath@gnu.org; Mon, 05 Apr 2004 16:56:55 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAVWx-0008LV-00
	for classpath@gnu.org; Mon, 05 Apr 2004 16:56:55 +0200
Message-ID: <407173BF.9030309@aicas.com>
Date: Mon, 05 Apr 2004 16:57:03 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
References: <40714C90.3070904@aicas.com>
In-Reply-To: <40714C90.3070904@aicas.com>
Content-Type: multipart/mixed; boundary="------------060907060206080202060000"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Re: Patch for java.awt.Polygon
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 14:59:21 -0000

This is a multi-part message in MIME format.
--------------060907060206080202060000
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Let try this again with the correct attachment.

Ingo Prötel wrote:
> I suggest the following patch
> 2004-04-05  Ingo Proetel  <proetel@aicas.com>
> 
>     * java/awt/Polygon.java (getBoundingBox): Use correct y-coordinate
>     in Rectangle constructor.
> 
> ingo
> 
> 
> ------------------------------------------------------------------------
> 
> Repository : iproetel@savannah.gnu.org:/cvsroot/classpath
> Module     : classpath
> Working dir: ~/GNUCP/classpath/
> 
> 
> 
> In directory .:
>               Modified                ChangeLog
>               Unknown                 buildIt
>               Unknown                 text.diff
> In directory doc:
> In directory doc/api:
> In directory doc/www.gnu.org:
> In directory gnu:
> In directory gnu/classpath:
> In directory gnu/java:
> In directory gnu/java/nio:
> In directory java:
> In directory java/awt:
>               Modified                java/awt/Polygon.java
>               Modified                java/awt/TextField.java
>               Modified                java/awt/Window.java
> In directory java/awt/image:
>               Modified                java/awt/image/BufferedImage.java
>               Modified                java/awt/image/ColorModel.java
>               Modified                java/awt/image/ComponentSampleModel.java
>               Modified                java/awt/image/Raster.java
>               Modified                java/awt/image/SampleModel.java
>               Modified                java/awt/image/SinglePixelPackedSampleModel.java
> In directory javax:
> In directory javax/swing:
> In directory javax/swing/plaf:
> In directory lib:
>               Unknown                 lib/org
>               Unknown                 lib/resources
> In directory native:
> In directory native/jni:
> In directory native/jni/java-net:
>               Modified                native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
>               Modified                native/jni/java-net/gnu_java_net_PlainSocketImpl.c
>               Modified                native/jni/java-net/java_net_InetAddress.c
>               Modified                native/jni/java-net/java_net_NetworkInterface.c
>               Modified                native/jni/java-net/javanet.c
> In directory native/jni/java-nio:
>               Modified                native/jni/java-nio/java_nio_DirectByteBufferImpl.c
>               Modified                native/jni/java-nio/java_nio_FileChannelImpl.c
>               Modified                native/jni/java-nio/java_nio_FileLockImpl.c
> In directory test:
> In directory test/java.beans:
> In directory testsuite:
> In directory vm:
> In directory vm/reference:
> 
> --------------------- End ---------------------
> -- last cmd: cvs -f diff -u -N java/awt/Polygon.java --
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------060907060206080202060000
Content-Type: text/plain;
 name="Polygon.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="Polygon.diff"

Index: java/awt/Polygon.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/Polygon.java,v
retrieving revision 1.8
diff -u -r1.8 Polygon.java
--- java/awt/Polygon.java	3 Feb 2004 17:17:29 -0000	1.8
+++ java/awt/Polygon.java	5 Apr 2004 14:55:56 -0000
@@ -294,7 +294,7 @@
             else if (y > maxy)
               maxy = y;
           }
-        bounds = new Rectangle (minx, maxy, maxx - minx, maxy - miny);
+        bounds = new Rectangle (minx, miny, maxx - minx, maxy - miny);
       }
     return bounds;
   }

--------------060907060206080202060000--



From MAILER-DAEMON Mon Apr 05 11:01:39 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAVam-0007at-73
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 11:00:52 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAVaT-0007P6-LQ
	for classpath@gnu.org; Mon, 05 Apr 2004 11:00:33 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAVZJ-0006ce-68
	for classpath@gnu.org; Mon, 05 Apr 2004 10:59:53 -0400
Received: from [212.227.126.177] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAVZ0-0006S7-68
	for classpath@gnu.org; Mon, 05 Apr 2004 10:59:02 -0400
Received: from [212.227.126.161] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAVYz-0002wH-00
	for classpath@gnu.org; Mon, 05 Apr 2004 16:59:01 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAVYz-0005g4-00
	for classpath@gnu.org; Mon, 05 Apr 2004 16:59:01 +0200
Message-ID: <4071743C.6090204@aicas.com>
Date: Mon, 05 Apr 2004 16:59:08 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
References: <40714921.4050709@aicas.com>
In-Reply-To: <40714921.4050709@aicas.com>
Content-Type: multipart/mixed; boundary="------------040800020204050500020409"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Re: Patch for java.awt.image.SampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 15:00:50 -0000

This is a multi-part message in MIME format.
--------------040800020204050500020409
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Note new attachment.

ingo

Ingo Prötel wrote:
> I suggest the following patch
> 2004-04-05  Ingo Proetel  <proetel@aicas.com>
> 
>     * java/awt/image/SampleModel.java (<init>): Added error cause 
> information to
>     thrown exception.
> 
> ingo
> 
> 
> ------------------------------------------------------------------------
> 
> Repository : iproetel@savannah.gnu.org:/cvsroot/classpath
> Module     : classpath
> Working dir: ~/GNUCP/classpath/
> 
> 
> 
> In directory .:
>               Modified                ChangeLog
>               Unknown                 buildIt
>               Unknown                 text.diff
> In directory doc:
> In directory doc/api:
> In directory doc/www.gnu.org:
> In directory gnu:
> In directory gnu/classpath:
> In directory gnu/java:
> In directory gnu/java/nio:
> In directory java:
> In directory java/awt:
>               Modified                java/awt/Polygon.java
>               Modified                java/awt/TextField.java
>               Modified                java/awt/Window.java
> In directory java/awt/image:
>               Modified                java/awt/image/BufferedImage.java
>               Modified                java/awt/image/ColorModel.java
>               Modified                java/awt/image/ComponentSampleModel.java
>               Modified                java/awt/image/Raster.java
>               Modified                java/awt/image/SampleModel.java
>               Modified                java/awt/image/SinglePixelPackedSampleModel.java
> In directory javax:
> In directory javax/swing:
> In directory javax/swing/plaf:
> In directory lib:
>               Unknown                 lib/org
>               Unknown                 lib/resources
> In directory native:
> In directory native/jni:
> In directory native/jni/java-net:
>               Modified                native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
>               Modified                native/jni/java-net/gnu_java_net_PlainSocketImpl.c
>               Modified                native/jni/java-net/java_net_InetAddress.c
>               Modified                native/jni/java-net/java_net_NetworkInterface.c
>               Modified                native/jni/java-net/javanet.c
> In directory native/jni/java-nio:
>               Modified                native/jni/java-nio/java_nio_DirectByteBufferImpl.c
>               Modified                native/jni/java-nio/java_nio_FileChannelImpl.c
>               Modified                native/jni/java-nio/java_nio_FileLockImpl.c
> In directory test:
> In directory test/java.beans:
> In directory testsuite:
> In directory vm:
> In directory vm/reference:
> 
> --------------------- End ---------------------
> -- last cmd: cvs -f diff -u -N java/awt/image/SampleModel.java --
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------040800020204050500020409
Content-Type: text/plain;
 name="SampleModel.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="SampleModel.diff"

Index: java/awt/image/SampleModel.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/image/SampleModel.java,v
retrieving revision 1.2
diff -u -r1.2 SampleModel.java
--- java/awt/image/SampleModel.java	22 Jan 2002 22:26:59 -0000	1.2
+++ java/awt/image/SampleModel.java	5 Apr 2004 14:57:53 -0000
@@ -58,7 +58,9 @@
 
   public SampleModel(int dataType, int w, int h, int numBands)
   {
-    if ((w<=0) || (h<=0)) throw new IllegalArgumentException();
+    if ((w<=0) || (h<=0)) 
+      throw new IllegalArgumentException( (w<=0?" width<=0":" width is ok")
+                                         +(h<=0?" height<=0":" height is ok"));
 	
     // FIXME: How can an int be greater than Integer.MAX_VALUE?
     // FIXME: How do we identify an unsupported data type?

--------------040800020204050500020409--



From MAILER-DAEMON Mon Apr 05 11:03:00 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAVcq-0008PH-2Q
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 11:03:00 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAVbi-0007vh-FR
	for classpath@gnu.org; Mon, 05 Apr 2004 11:01:50 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAVZt-00072G-R4
	for classpath@gnu.org; Mon, 05 Apr 2004 11:00:37 -0400
Received: from [212.6.122.96] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAV1K-0005LL-PB
	for classpath@gnu.org; Mon, 05 Apr 2004 10:24:14 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-109.ewetel.net
	[80.228.94.109])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i35ENsX3017918;
	Mon, 5 Apr 2004 16:23:54 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BAU56-0001Tj-00; Mon, 05 Apr 2004 15:24:04 +0200
From: Michael Koch <konqueror@gmx.de>
To: Andrew Haley <aph@redhat.com>
Date: Mon, 5 Apr 2004 16:23:38 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051543.34346.konqueror@gmx.de>
	<16497.27204.226097.182524@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.27204.226097.182524@cuddles.cambridge.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404051623.38704.konqueror@gmx.de>
X-CheckCompat: OK
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 15:02:57 -0000

Am Montag, 5. April 2004 16:16 schrieb Andrew Haley:
> Michael Koch writes:
>  > > Uh, I don't understand what you mean, sorry.  Why is a Java
>  > > reference the same size as a native pointer?  Perhaps I
>  > > misunderstood you.
>  >
>  > AFAIK a java refernce is a pointer and this pointer can point
>  > everywhere. Right ?
>
> No, not at all.  A java reference is simply a handle by which an
> object may be found.  It might well be a hash code, or a table index.

Oh, didnt knew this. Perhaps I'm too much oriented towards CNI ...


Michael




From MAILER-DAEMON Mon Apr 05 11:06:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAVe6-0000ZK-HN
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 11:04:18 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAVdr-0000RD-7t
	for classpath@gnu.org; Mon, 05 Apr 2004 11:04:03 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAVdJ-00008h-GH
	for classpath@gnu.org; Mon, 05 Apr 2004 11:04:00 -0400
Received: from [212.227.126.183] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAVcI-0008C3-85
	for classpath@gnu.org; Mon, 05 Apr 2004 11:02:26 -0400
Received: from [212.227.126.162] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAVcI-0007dj-00
	for classpath@gnu.org; Mon, 05 Apr 2004 17:02:26 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAVcH-00055d-00
	for classpath@gnu.org; Mon, 05 Apr 2004 17:02:25 +0200
Message-ID: <40717508.4000008@aicas.com>
Date: Mon, 05 Apr 2004 17:02:32 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
References: <40713D73.1070002@aicas.com>
In-Reply-To: <40713D73.1070002@aicas.com>
Content-Type: multipart/mixed; boundary="------------090801030401060608060802"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Re: Patch for java.awt.image.ComponentSampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 15:04:12 -0000

This is a multi-part message in MIME format.
--------------090801030401060608060802
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Note new attachment.

Ingo Prötel wrote:
> I suggest the following patch:
> 
> 2004-04-05  Ingo Proetel  <proetel@aicas.com>
> 
>     * java/awt/image/ComponentSampleModel.java (setDataSamples):Do not 
> reset scanline stride.
> 
> 
> ------------------------------------------------------------------------
> 
> Repository : iproetel@savannah.gnu.org:/cvsroot/classpath
> Module     : classpath
> Working dir: ~/GNUCP/classpath/
> 
> 
> 
> In directory .:
>               Unknown                 buildIt
>               Unknown                 text.diff
> In directory doc:
> In directory doc/api:
> In directory doc/www.gnu.org:
> In directory gnu:
> In directory gnu/classpath:
> In directory gnu/java:
> In directory gnu/java/nio:
> In directory java:
> In directory java/awt:
>               Modified                java/awt/Polygon.java
>               Modified                java/awt/TextField.java
>               Modified                java/awt/Window.java
> In directory java/awt/image:
>               Modified                java/awt/image/BufferedImage.java
>               Modified                java/awt/image/ColorModel.java
>               Modified                java/awt/image/ComponentSampleModel.java
>               Modified                java/awt/image/Raster.java
>               Modified                java/awt/image/SampleModel.java
>               Modified                java/awt/image/SinglePixelPackedSampleModel.java
> In directory javax:
> In directory javax/swing:
> In directory javax/swing/plaf:
> In directory lib:
>               Unknown                 lib/org
>               Unknown                 lib/resources
> In directory native:
> In directory native/jni:
> In directory native/jni/java-net:
>               Modified                native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
>               Modified                native/jni/java-net/gnu_java_net_PlainSocketImpl.c
>               Modified                native/jni/java-net/java_net_InetAddress.c
>               Modified                native/jni/java-net/java_net_NetworkInterface.c
>               Modified                native/jni/java-net/javanet.c
> In directory native/jni/java-nio:
>               Modified                native/jni/java-nio/java_nio_DirectByteBufferImpl.c
>               Modified                native/jni/java-nio/java_nio_FileChannelImpl.c
>               Modified                native/jni/java-nio/java_nio_FileLockImpl.c
> In directory test:
> In directory test/java.beans:
> In directory testsuite:
> In directory vm:
> In directory vm/reference:
> 
> --------------------- End ---------------------
> -- last cmd: cvs -f diff -u -N java/awt/image/ComponentSampleModel.java --
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------090801030401060608060802
Content-Type: text/plain;
 name="ComponentSampleModel.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ComponentSampleModel.diff"

Index: java/awt/image/ComponentSampleModel.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/image/ComponentSampleModel.java,v
retrieving revision 1.2
diff -u -r1.2 ComponentSampleModel.java
--- java/awt/image/ComponentSampleModel.java	22 Jan 2002 22:26:59 -0000	1.2
+++ java/awt/image/ComponentSampleModel.java	5 Apr 2004 15:00:39 -0000
@@ -349,7 +349,7 @@
     if (scanlineStride == rowSize)
       {
 	// Collapse scan lines:
-	scanlineStride = rowSize *= h;
+	rowSize *= h;
 	h = 1;
       }
 

--------------090801030401060608060802--



From MAILER-DAEMON Mon Apr 05 11:18:13 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAVrZ-0004co-2k
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 11:18:13 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAVrS-0004a1-O5
	for classpath@gnu.org; Mon, 05 Apr 2004 11:18:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAVqt-0004Qv-5U
	for classpath@gnu.org; Mon, 05 Apr 2004 11:18:03 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAVqs-0004QA-DG
	for classpath@gnu.org; Mon, 05 Apr 2004 11:17:30 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 5 Apr 2004 17:17:25 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD04@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQbD8Osnuga01SATI2vJkTxq6xIpgAEE83A
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "GNU Classpath" <classpath@gnu.org>
Cc: Mark Wielaard <mark@klomp.org>, Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 15:18:09 -0000

Andrew Haley wrote:
> Michael Koch writes:
>  > > To be honest I think we should not have RawData in Classpath.
>=20
> The trouble with RawData (as it is used in gcj) is that it breaks the
> Java type system.  Its bizarre semantics mean that you have something
> that looks like an object reference but you can't use it as one.  You
> can't convert it to an instance of Object, for example.

Not necessarily. On my (admittedly weird) VM, RawData is a direct
pointer, but it can also be treated as an object, this is not
particularly efficient way of using it (it gets boxed), but it does
work.

Etienne Gagnon wrote:
> IMO, the cleanest approach is really the use of a byte array.=20

But it is inefficient and hard to optimize. I don't see why RawData
doesn't give you the same capabilities as a byte array (as an extreme
example, you can replace Classpath's RawData with your own version that
wraps a byte array).

Regards,
Jeroen



From MAILER-DAEMON Mon Apr 05 11:24:19 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAVq5-0004Bn-Pa
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 11:16:41 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAVpu-00048q-Tk
	for classpath@gnu.org; Mon, 05 Apr 2004 11:16:30 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAVpM-0003vR-Ef
	for classpath@gnu.org; Mon, 05 Apr 2004 11:16:27 -0400
Received: from [212.227.126.176] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAVgP-0001b1-Cw
	for classpath@gnu.org; Mon, 05 Apr 2004 11:06:41 -0400
Received: from [212.227.126.162] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAVgL-0002cz-00
	for classpath@gnu.org; Mon, 05 Apr 2004 17:06:37 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAVgJ-0005oh-00
	for classpath@gnu.org; Mon, 05 Apr 2004 17:06:35 +0200
Message-ID: <40717603.6010900@aicas.com>
Date: Mon, 05 Apr 2004 17:06:43 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
References: <4071460B.3070303@aicas.com>
In-Reply-To: <4071460B.3070303@aicas.com>
Content-Type: multipart/mixed; boundary="------------090101010706060800030708"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Re: Patch for java.awt.image.Raster
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 15:16:33 -0000

This is a multi-part message in MIME format.
--------------090101010706060800030708
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Note new attachment.

Ingo Prötel wrote:
> I suggest the following patch
> 2004-04-05  Ingo Proetel  <proetel@aicas.com>
> 
>     * java/awt/image/Raster.java (toString): Added method.
> 
> ingo
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Repository : iproetel@savannah.gnu.org:/cvsroot/classpath
> Module     : classpath
> Working dir: ~/GNUCP/classpath/
> 
> 
> 
> In directory .:
>               Modified                ChangeLog
>               Unknown                 buildIt
>               Unknown                 text.diff
> In directory doc:
> In directory doc/api:
> In directory doc/www.gnu.org:
> In directory gnu:
> In directory gnu/classpath:
> In directory gnu/java:
> In directory gnu/java/nio:
> In directory java:
> In directory java/awt:
>               Modified                java/awt/Polygon.java
>               Modified                java/awt/TextField.java
>               Modified                java/awt/Window.java
> In directory java/awt/image:
>               Modified                java/awt/image/BufferedImage.java
>               Modified                java/awt/image/ColorModel.java
>               Modified                java/awt/image/ComponentSampleModel.java
>               Modified                java/awt/image/Raster.java
>               Modified                java/awt/image/SampleModel.java
>               Modified                java/awt/image/SinglePixelPackedSampleModel.java
> In directory javax:
> In directory javax/swing:
> In directory javax/swing/plaf:
> In directory lib:
>               Unknown                 lib/org
>               Unknown                 lib/resources
> In directory native:
> In directory native/jni:
> In directory native/jni/java-net:
>               Modified                native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
>               Modified                native/jni/java-net/gnu_java_net_PlainSocketImpl.c
>               Modified                native/jni/java-net/java_net_InetAddress.c
>               Modified                native/jni/java-net/java_net_NetworkInterface.c
>               Modified                native/jni/java-net/javanet.c
> In directory native/jni/java-nio:
>               Modified                native/jni/java-nio/java_nio_DirectByteBufferImpl.c
>               Modified                native/jni/java-nio/java_nio_FileChannelImpl.c
>               Modified                native/jni/java-nio/java_nio_FileLockImpl.c
> In directory test:
> In directory test/java.beans:
> In directory testsuite:
> In directory vm:
> In directory vm/reference:
> 
> --------------------- End ---------------------
> -- last cmd: cvs -f diff -u -N java/awt/image/Raster.java --
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------090101010706060800030708
Content-Type: text/plain;
 name="Raster.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="Raster.diff"

Index: java/awt/image/Raster.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/image/Raster.java,v
retrieving revision 1.4
diff -u -r1.4 Raster.java
--- java/awt/image/Raster.java	25 Sep 2003 15:00:14 -0000	1.4
+++ java/awt/image/Raster.java	5 Apr 2004 14:59:40 -0000
@@ -452,4 +452,25 @@
 				  y-sampleModelTranslateY,
 				  w, h, b, dArray, dataBuffer);
   }
+  
+  /**
+   * Create a String representing the stat of this Raster.
+   * @return A String representing the stat of this Raster.
+   * @see java.lang.Object#toString()
+   */
+  public String toString()
+  {
+    StringBuffer result = new StringBuffer();
+    
+    result.append(getClass().getName());
+    result.append("[(");
+    result.append(minX).append(",").append(minY).append("), ");
+    result.append(width).append(" x ").append(height).append(",");
+    result.append(sampleModel).append(",");
+    result.append(dataBuffer);
+    result.append("]");
+    
+    return result.toString();
+  }
+  
 }

--------------090101010706060800030708--



From MAILER-DAEMON Mon Apr 05 11:31:41 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAW43-0000tW-0Z
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 11:31:07 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAVyx-0007LM-C3
	for classpath@gnu.org; Mon, 05 Apr 2004 11:25:51 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAVxm-0006qE-49
	for classpath@gnu.org; Mon, 05 Apr 2004 11:25:09 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAVwk-0006SS-OX
	for classpath@gnu.org; Mon, 05 Apr 2004 11:23:34 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAVS7-00009s-Ai
	for classpath@gnu.org; Mon, 05 Apr 2004 10:51:55 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i35EnC5D005333;
	Mon, 5 Apr 2004 10:49:12 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i35EnBj18932; 
	Mon, 5 Apr 2004 10:49:11 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35EnAe1027451; Mon, 5 Apr 2004 10:49:11 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: James Henstridge <james@daa.com.au>
In-Reply-To: <4071315D.7030202@daa.com.au>
References: <1081117378.16358.4.camel@tortoise.toronto.redhat.com>
	<4071315D.7030202@daa.com.au>
Content-Type: text/plain
Message-Id: <1081176550.16358.53.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Mon, 05 Apr 2004 10:49:10 -0400
Content-Transfer-Encoding: 7bit
Cc: classpath list <classpath@gnu.org>
Subject: Re: jhbuild and classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 15:31:03 -0000

On Mon, 2004-04-05 at 06:13, James Henstridge wrote:
> On 5/04/2004 6:22 AM, Thomas Fitzsimmons wrote:
> 
> >Hi James,
> >
> >I've been experimenting with using jhbuild for GNU Classpath
> >development.  My compliments on jhbuild; it's a very nice tool!
> >  
> >
> Cool.  I put a fair bit of work into making jhbuild usable outside of 
> Gnome (primarily for some of the freedesktop.org projects such as the X 
> server), so it'll be good if it benefits you too.
> 
> If you use a URL for the module set in ~/.jhbuildrc, jhbuild should 
> download and cache the module information from
> 

Oh, cool!  I was going to submit classpath.modules for inclusion in the
jhbuild repository, but hosting it at a URL is much better.

> >Our AWT implementation relies on GTK, so jhbuild is a natural fit for
> >us.  And it looks like jhbuild has the potential to make bootstrapping a
> >Classpath-based development environment dramatically simpler.
> >
> >I've run into one problem though.  In the GNU Classpath world, we prefer
> >to have builddir != srcdir, whereas it seems most GNOME modules, and
> >hence jhbuild, assume builddir == srcdir.  What do you think about
> >having a builddir != srcdir mode that could be set in .jhbuildrc?
> >  
> >
> Shouldn't be too difficult to implement.  What layout do you use for 
> your source/build trees in this setup?
> 

Usually we keep the build directory completely separate.  For example, I
have ~/sources and ~/build directories.

Ideally the layout would look like this:

~/sources/jhbuild-src/jhbuild
~/sources/jhbuild-src/module1
~/sources/jhbuild-src/module2
...


~/build/jhbuild-bld/module1-bld
~/build/jhbuild-bld/module2-bld
...


I like to append -bld to the build directories so that I can easily
differentiate them from the corresponding source directories.

Tom





From MAILER-DAEMON Mon Apr 05 11:33:07 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAW4Y-00019h-Nu
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 11:31:38 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAW3R-0000SJ-BM
	for classpath@gnu.org; Mon, 05 Apr 2004 11:30:29 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAW1b-00086N-JU
	for classpath@gnu.org; Mon, 05 Apr 2004 11:29:06 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAVz5-0007Lj-NW
	for classpath@gnu.org; Mon, 05 Apr 2004 11:25:59 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAVPl-0008IN-T5
	for classpath@gnu.org; Mon, 05 Apr 2004 10:49:29 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i35EW5Kx022039;
	Mon, 5 Apr 2004 10:32:18 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040510333302548 ; Mon, 05 Apr 2004 10:33:33 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i35ESDRh002859; Mon, 5 Apr 2004 10:28:13 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAV5C-0002eN-58; Mon, 05 Apr 2004 10:28:14 -0400
Message-ID: <40716CFD.8000609@uqam.ca>
Date: Mon, 05 Apr 2004 10:28:13 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404041637.29773.konqueror@gmx.de>
	<16497.23262.932225.980277@cuddles.cambridge.redhat.com>
	<200404051543.34346.konqueror@gmx.de>
In-Reply-To: <200404051543.34346.konqueror@gmx.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 15:31:30 -0000

I Agree with Andrew, regarding the reference JNI library code;  this code is
*NOT* the VM*.java interface, so it should be written to be compatible
with any JNI compliant JVM.  As far as I know, disguising a native
pointer into a Java reference is not portable across JVMs.

IMO, the cleanest approach is really the use of a byte array.  It allows
for *any* native pointer length, without making this length explicit in
any Java source code (assuming these arrays are allocated in the native
JNI parts).  The Garbage collector can move this array as it wishes, yet
the value will be preserved.

I oppose the use of long-term maintenance trouble things such as "int" or
"long".  As for performance, the additional indirection cost, to get the
byte array content value (e.g. the native pointer) is offset by the cost
of the JNI call itself.

Etienne
-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Mon Apr 05 12:21:43 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAWr1-0002OC-3q
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 12:21:43 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAWqx-0002ND-Kh
	for classpath@gnu.org; Mon, 05 Apr 2004 12:21:39 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAWqR-0002AI-Ax
	for classpath@gnu.org; Mon, 05 Apr 2004 12:21:38 -0400
Received: from [62.253.162.43] (helo=mta03-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAWqR-000282-0O
	for classpath@gnu.org; Mon, 05 Apr 2004 12:21:07 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta03-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405162010.BBDX29451.mta03-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 17:20:10 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35GIhCL029174; Mon, 5 Apr 2004 17:18:53 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35GIfjP029170;
	Mon, 5 Apr 2004 17:18:41 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.34529.173189.759552@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 17:18:41 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <40716CFD.8000609@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404041637.29773.konqueror@gmx.de>
	<16497.23262.932225.980277@cuddles.cambridge.redhat.com>
	<200404051543.34346.konqueror@gmx.de> <40716CFD.8000609@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 16:21:40 -0000

Etienne Gagnon writes:
 > 
 > IMO, the cleanest approach is really the use of a byte array.

Well, I tell you what: we could wrap the {byte[],long} in an opaque
type, call it a "native pointer", and be done with it.

- Everyone who can use a long as a pointer (and, in practice, this is
  everyone) will do so.

- Anyone who needs to use a byte[] as a pointer will do so.

- We can still have some type safety and readability by making
  subclasses of "native pointer".

Andrew.



From MAILER-DAEMON Mon Apr 05 12:36:45 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAX5Z-0001lW-4u
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 12:36:45 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAX5V-0001j0-MM
	for classpath@gnu.org; Mon, 05 Apr 2004 12:36:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAX4z-0001Wr-D4
	for classpath@gnu.org; Mon, 05 Apr 2004 12:36:40 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAX4y-0001WF-Uy
	for classpath@gnu.org; Mon, 05 Apr 2004 12:36:09 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i35GPoL5014300;
	Mon, 5 Apr 2004 12:26:11 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040512272615579 ; Mon, 05 Apr 2004 12:27:26 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i35GLxUQ024245; Mon, 5 Apr 2004 12:21:59 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAWrH-0002ji-Fd; Mon, 05 Apr 2004 12:21:59 -0400
Message-ID: <407187A6.8090804@uqam.ca>
Date: Mon, 05 Apr 2004 12:21:58 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD04@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD04@LEMBU.sumatrasoftware.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 16:36:42 -0000

Jeroen,

Jeroen Frijters wrote:
 >>IMO, the cleanest approach is really the use of a byte array.
 >
 > But it is inefficient and hard to optimize. I don't see why RawData
 > doesn't give you the same capabilities as a byte array (as an extreme
 > example, you can replace Classpath's RawData with your own version that
 > wraps a byte array).

You miss an important point:  it *has* to be VM independent!  Classpath's
JNI libraries should be VM independent.  Do you expect RawData to work
with, e.g., Sun VM?

Note: We are *NOT* talking about the VM*.java interface, here.

Etienne
-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Mon Apr 05 13:03:34 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAXVT-0002rn-FB
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 13:03:31 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAXV4-0002SV-VJ
	for classpath@gnu.org; Mon, 05 Apr 2004 13:03:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAXUE-0000zQ-S6
	for classpath@gnu.org; Mon, 05 Apr 2004 13:02:48 -0400
Received: from [62.253.162.45] (helo=mta05-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAXUB-0000rV-LM
	for classpath@gnu.org; Mon, 05 Apr 2004 13:02:11 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta05-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405160858.KYKD21130.mta05-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 17:08:58 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35G7vCL029134; Mon, 5 Apr 2004 17:08:08 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35G7udw029130;
	Mon, 5 Apr 2004 17:07:56 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.33884.314223.620150@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 17:07:56 +0100
To: "Jeroen Frijters" <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD04@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD04@LEMBU.sumatrasoftware.com>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 17:03:28 -0000

Jeroen Frijters writes:
 > Andrew Haley wrote:
 > > Michael Koch writes:
 > >  > > To be honest I think we should not have RawData in Classpath.
 > > 
 > > The trouble with RawData (as it is used in gcj) is that it breaks the
 > > Java type system.  Its bizarre semantics mean that you have something
 > > that looks like an object reference but you can't use it as one.  You
 > > can't convert it to an instance of Object, for example.
 > 
 > Not necessarily. On my (admittedly weird) VM, RawData is a direct
 > pointer, but it can also be treated as an object, this is not
 > particularly efficient way of using it (it gets boxed), but it does
 > work.

Yeah, but that's a special case.  In general, on most VMs, you can't
convert a RawData to an Object.

 > Etienne Gagnon wrote:
 > > IMO, the cleanest approach is really the use of a byte array. 
 > 
 > But it is inefficient and hard to optimize.

Right.  The choice of a byte array is the worst of all possible
worlds.  Well okay, it is at least portable, but it has no other
virtues.

Andrew.



From MAILER-DAEMON Mon Apr 05 13:13:02 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAXed-000261-Us
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 13:13:00 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAXeN-0001l3-8W
	for classpath@gnu.org; Mon, 05 Apr 2004 13:12:43 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAXdl-0000pg-C1
	for classpath@gnu.org; Mon, 05 Apr 2004 13:12:36 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAXdf-0000oH-TG
	for classpath@gnu.org; Mon, 05 Apr 2004 13:12:00 -0400
Received: from [212.227.126.176] (helo=moutng.kundenserver.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAWJe-0008Og-0N
	for classpath@gnu.org; Mon, 05 Apr 2004 11:47:14 -0400
Received: from [212.227.126.206] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAWJb-0004YL-00
	for classpath@gnu.org; Mon, 05 Apr 2004 17:47:11 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAWJb-0000VR-00
	for classpath@gnu.org; Mon, 05 Apr 2004 17:47:11 +0200
Message-ID: <40717F86.6030805@aicas.com>
Date: Mon, 05 Apr 2004 17:47:18 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------060600020708000704000206"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch for java.util.zip.InflaterInputStream
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 17:12:53 -0000

This is a multi-part message in MIME format.
--------------060600020708000704000206
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

I suggest the following patch to skip more than 2k bytes:
2004-04-05  IngoProetel  <proetel@aicas.com>

	* java/util/zip/InflaterInputStream.java (skip): Copied implementation
	from java.io.InputStream.


ingo
-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------060600020708000704000206
Content-Type: text/plain;
 name="InflaterInputStream.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="InflaterInputStream.diff"

Index: java/util/zip/InflaterInputStream.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/util/zip/InflaterInputStream.java,v
retrieving revision 1.10
diff -u -r1.10 InflaterInputStream.java
--- java/util/zip/InflaterInputStream.java	4 Nov 2003 10:04:16 -0000	1.10
+++ java/util/zip/InflaterInputStream.java	5 Apr 2004 15:41:10 -0000
@@ -215,13 +215,23 @@
    */
   public long skip(long n) throws IOException
   {
-    if (n < 0)
-      throw new IllegalArgumentException();
-    int len = 2048;
-    if (n < len)
-      len = (int) n;
-    byte[] tmp = new byte[len];
-    return (long) read(tmp);
+    // Implementation copied from InputStream
+    // Throw away n bytes by reading them into a temp byte[].
+    // Limit the temp array to 2Kb so we don't grab too much memory.
+    final int buflen = n > 2048 ? 2048 : (int) n;
+    byte[] tmpbuf = new byte[buflen];
+    final long origN = n;
+
+    while (n > 0L)
+      {
+	int numread = read(tmpbuf, 0, n > buflen ? buflen : (int) n);
+	if (numread <= 0)
+	  break;
+	n -= numread;
+      }
+
+    return origN - n;
+
   }
 
   /**

--------------060600020708000704000206--



From MAILER-DAEMON Mon Apr 05 13:13:47 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAXfP-0002N2-Ch
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 13:13:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAXfM-0002Mb-Fx
	for classpath@gnu.org; Mon, 05 Apr 2004 13:13:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAXeo-0002Be-7v
	for classpath@gnu.org; Mon, 05 Apr 2004 13:13:41 -0400
Received: from [212.6.122.141] (helo=mail4.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAXem-0002AJ-Ku
	for classpath@gnu.org; Mon, 05 Apr 2004 13:13:08 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-109.ewetel.net
	[80.228.94.109])
	by mail4.ewetel.de (8.12.1/8.12.9) with ESMTP id i35HCvPZ006478;
	Mon, 5 Apr 2004 19:12:58 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BAWih-0001uC-00; Mon, 05 Apr 2004 18:13:07 +0200
From: Michael Koch <konqueror@gmx.de>
To: Andrew Haley <aph@redhat.com>
Date: Mon, 5 Apr 2004 19:12:41 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD04@LEMBU.sumatrasoftware.com>
	<16497.33884.314223.620150@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.33884.314223.620150@cuddles.cambridge.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404051912.41988.konqueror@gmx.de>
X-CheckCompat: OK
Cc: classpath@gnu.org
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 17:13:45 -0000

Am Montag, 5. April 2004 18:07 schrieb Andrew Haley:
> Jeroen Frijters writes:
>  > Andrew Haley wrote:
>  > > Michael Koch writes:
>  > >  > > To be honest I think we should not have RawData in
>  > >  > > Classpath.
>  > >
>  > > The trouble with RawData (as it is used in gcj) is that it
>  > > breaks the Java type system.  Its bizarre semantics mean that
>  > > you have something that looks like an object reference but you
>  > > can't use it as one.  You can't convert it to an instance of
>  > > Object, for example.
>  >
>  > Not necessarily. On my (admittedly weird) VM, RawData is a direct
>  > pointer, but it can also be treated as an object, this is not
>  > particularly efficient way of using it (it gets boxed), but it
>  > does work.
>
> Yeah, but that's a special case.  In general, on most VMs, you can't
> convert a RawData to an Object.
>
>  > Etienne Gagnon wrote:
>  > > IMO, the cleanest approach is really the use of a byte array.
>  >
>  > But it is inefficient and hard to optimize.
>
> Right.  The choice of a byte array is the worst of all possible
> worlds.  Well okay, it is at least portable, but it has no other
> virtues.

I'm not really experienced with JNI and look what you all come up with.
To me the byte[] solutions seems to be the most complicated to use 
because its easy possible to cast it to void*.


Michael




From MAILER-DAEMON Mon Apr 05 13:19:41 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAXl6-0004HX-NV
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 13:19:40 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAXkx-0004FD-Fr
	for classpath@gnu.org; Mon, 05 Apr 2004 13:19:31 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAXkO-0003zg-Oh
	for classpath@gnu.org; Mon, 05 Apr 2004 13:19:28 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAXkO-0003zF-1s
	for classpath@gnu.org; Mon, 05 Apr 2004 13:18:56 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i35GtIL3003932;
	Mon, 5 Apr 2004 12:55:34 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040512564818461 ; Mon, 05 Apr 2004 12:56:48 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i35GoIVu003536; Mon, 5 Apr 2004 12:50:18 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAXIg-0002lH-Vu; Mon, 05 Apr 2004 12:50:18 -0400
Message-ID: <40718E4A.4090608@uqam.ca>
Date: Mon, 05 Apr 2004 12:50:18 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404041637.29773.konqueror@gmx.de>	<16497.23262.932225.980277@cuddles.cambridge.redhat.com>	<200404051543.34346.konqueror@gmx.de>
	<40716CFD.8000609@uqam.ca>
	<16497.34529.173189.759552@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.34529.173189.759552@cuddles.cambridge.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 17:19:33 -0000

Andrew,

Andrew Haley wrote:
> - Everyone who can use a long as a pointer (and, in practice, this is
>   everyone) will do so.

It's *NOT* the VM interface!  There is a single JNI source code source base,
used by everyone.

So, there is no "SableVM" does it this way, gcj that way, and Kaffe the other.
It has to work also with Sun VM, for example.

AGAIN:  I AM NOT TALKING ABOUT THE VM INTERFACE.  I hope the message is clear!

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Mon Apr 05 13:34:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAXzk-0006nu-AD
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 13:34:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAXyw-0006NG-0d
	for classpath@gnu.org; Mon, 05 Apr 2004 13:33:58 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAXy8-0005xt-JI
	for classpath@gnu.org; Mon, 05 Apr 2004 13:33:39 -0400
Received: from [62.253.162.41] (helo=mta01-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAXxY-0005li-RV
	for classpath@gnu.org; Mon, 05 Apr 2004 13:32:32 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta01-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405173213.BRCN17631.mta01-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 18:32:13 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35HUtCL003002; Mon, 5 Apr 2004 18:31:05 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35HUp5P002982;
	Mon, 5 Apr 2004 18:30:51 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.38859.782758.253972@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 18:30:51 +0100
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404051926.48137.konqueror@gmx.de>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<16497.34529.173189.759552@cuddles.cambridge.redhat.com>
	<40718E4A.4090608@uqam.ca> <200404051926.48137.konqueror@gmx.de>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 17:34:46 -0000

Michael Koch writes:

 >  I think Andrew's solution might be viable. His solution is already
 > used in SWT. SWT runs with SUN JRE so it seems to be portable
 > enough for us.

Well, not exactly: I'm suggesting that we wrap all those longs in an
opaque type.  But otherwise, yes.

Andrew.



From MAILER-DAEMON Mon Apr 05 13:44:03 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAY8g-0001Ol-Ty
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 13:44:02 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAY8X-0001Md-OP
	for classpath@gnu.org; Mon, 05 Apr 2004 13:43:53 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAY7z-0001FI-0U
	for classpath@gnu.org; Mon, 05 Apr 2004 13:43:50 -0400
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAY7y-0001FC-JQ
	for classpath@gnu.org; Mon, 05 Apr 2004 13:43:18 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-109.ewetel.net
	[80.228.94.109])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id i35HguNj025058;
	Mon, 5 Apr 2004 19:42:57 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BAXBi-0001vy-00; Mon, 05 Apr 2004 18:43:06 +0200
From: Michael Koch <konqueror@gmx.de>
To: Andrew Haley <aph@redhat.com>
Date: Mon, 5 Apr 2004 19:42:41 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.38859.782758.253972@cuddles.cambridge.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404051942.41173.konqueror@gmx.de>
X-CheckCompat: OK
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 17:43:54 -0000

Am Montag, 5. April 2004 19:30 schrieb Andrew Haley:
> Michael Koch writes:
>  >  I think Andrew's solution might be viable. His solution is
>  > already used in SWT. SWT runs with SUN JRE so it seems to be
>  > portable enough for us.
>
> Well, not exactly: I'm suggesting that we wrap all those longs in an
> opaque type.  But otherwise, yes.

Can you give an example on how to do this ?


Michael




From MAILER-DAEMON Mon Apr 05 13:56:01 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAYKC-0007BV-53
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 13:55:56 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAYJx-00077Q-Pa
	for classpath@gnu.org; Mon, 05 Apr 2004 13:55:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAYJK-0006sY-UM
	for classpath@gnu.org; Mon, 05 Apr 2004 13:55:35 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAYHr-0006OS-1o
	for classpath@gnu.org; Mon, 05 Apr 2004 13:53:31 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAXth-0002HP-TQ
	for classpath@gnu.org; Mon, 05 Apr 2004 13:28:34 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-109.ewetel.net
	[80.228.94.109])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i35HR3pH009521;
	Mon, 5 Apr 2004 19:27:04 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BAWwL-0001vG-00; Mon, 05 Apr 2004 18:27:13 +0200
From: Michael Koch <konqueror@gmx.de>
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>, Andrew Haley <aph@redhat.com>
Date: Mon, 5 Apr 2004 19:26:48 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<16497.34529.173189.759552@cuddles.cambridge.redhat.com>
	<40718E4A.4090608@uqam.ca>
In-Reply-To: <40718E4A.4090608@uqam.ca>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404051926.48137.konqueror@gmx.de>
X-CheckCompat: OK
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 17:55:50 -0000

Am Montag, 5. April 2004 18:50 schrieb Etienne Gagnon:
> Andrew,
>
> Andrew Haley wrote:
> > - Everyone who can use a long as a pointer (and, in practice, this
> > is everyone) will do so.
>
> It's *NOT* the VM interface!  There is a single JNI source code
> source base, used by everyone.
>
> So, there is no "SableVM" does it this way, gcj that way, and Kaffe
> the other. It has to work also with Sun VM, for example.

To be clear, gcj uses CNI. In CNI references are pointers and the 
RawData reference is used as pointer to something (e.g. an address 
space).

> AGAIN:  I AM NOT TALKING ABOUT THE VM INTERFACE.  I hope the message
> is clear!

We should come up with a portable way to do this in JNI. I think 
everybody is aware of the fact that this is not the VM interface. We 
just think that byte[] is not really straigt forward and some people 
try to come up with something different. I think Andrew's solution 
might be viable. His solution is already used in SWT. SWT runs with SUN 
JRE so it seems to be portable enough for us.


Michael




From MAILER-DAEMON Mon Apr 05 14:02:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAYQI-0002Os-Ty
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 14:02:14 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAYQ9-0002Kc-G1
	for classpath@gnu.org; Mon, 05 Apr 2004 14:02:05 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAYPa-0001ZV-6G
	for classpath@gnu.org; Mon, 05 Apr 2004 14:02:02 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAYPZ-0001Y5-E2
	for classpath@gnu.org; Mon, 05 Apr 2004 14:01:29 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i35HoeKt004256;
	Mon, 5 Apr 2004 13:50:40 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040513515523747 ; Mon, 05 Apr 2004 13:51:55 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i35HjnID000546; Mon, 5 Apr 2004 13:45:49 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAYAP-0002nn-CU; Mon, 05 Apr 2004 13:45:49 -0400
Message-ID: <40719B4C.6040706@uqam.ca>
Date: Mon, 05 Apr 2004 13:45:48 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<16497.34529.173189.759552@cuddles.cambridge.redhat.com>	<40718E4A.4090608@uqam.ca>	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.38859.782758.253972@cuddles.cambridge.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 18:02:08 -0000

Andrew Haley wrote:
> Well, not exactly: I'm suggesting that we wrap all those longs in an
> opaque type.  But otherwise, yes.

So, how do you do opaque types, in Java?  And how do you guarantee portability
to 128bit systems?

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Mon Apr 05 14:08:11 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAYVp-0006mF-Vf
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 14:07:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAYVV-0006T2-Gb
	for classpath@gnu.org; Mon, 05 Apr 2004 14:07:37 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAYUs-0005dn-Sq
	for classpath@gnu.org; Mon, 05 Apr 2004 14:07:30 -0400
Received: from [62.253.162.47] (helo=mta07-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAYU0-0004nw-NM
	for classpath@gnu.org; Mon, 05 Apr 2004 14:06:04 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta07-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405172651.HTBY10756.mta07-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 18:26:52 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35HPICL014814; Mon, 5 Apr 2004 18:25:28 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35HPFvd014463;
	Mon, 5 Apr 2004 18:25:15 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.38523.116895.492691@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 18:25:15 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <40718E4A.4090608@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404041637.29773.konqueror@gmx.de>
	<16497.23262.932225.980277@cuddles.cambridge.redhat.com>
	<200404051543.34346.konqueror@gmx.de> <40716CFD.8000609@uqam.ca>
	<16497.34529.173189.759552@cuddles.cambridge.redhat.com>
	<40718E4A.4090608@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 18:07:53 -0000

Etienne Gagnon writes:
 > Andrew,
 > 
 > Andrew Haley wrote:
 > > - Everyone who can use a long as a pointer (and, in practice, this is
 > >   everyone) will do so.
 > 
 > It's *NOT* the VM interface!  There is a single JNI source code
 > source base, used by everyone.

It's easy to parameterize.

Andrew.



From MAILER-DAEMON Mon Apr 05 14:09:00 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAYWp-0007f4-QV
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 14:08:59 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAYWk-0007Zq-M6
	for classpath@gnu.org; Mon, 05 Apr 2004 14:08:54 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAYWA-00076t-Li
	for classpath@gnu.org; Mon, 05 Apr 2004 14:08:50 -0400
Received: from [62.253.162.48] (helo=mta08-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAYW5-00072b-B3
	for classpath@gnu.org; Mon, 05 Apr 2004 14:08:13 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta08-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405180807.LXQJ10788.mta08-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 19:08:07 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35I6DCL021014; Mon, 5 Apr 2004 19:06:26 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35I6A42021010;
	Mon, 5 Apr 2004 19:06:10 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.40977.775693.474482@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 19:06:09 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <40719B4C.6040706@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<16497.34529.173189.759552@cuddles.cambridge.redhat.com>
	<40718E4A.4090608@uqam.ca> <200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<40719B4C.6040706@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 18:08:56 -0000

Etienne Gagnon writes:
 > Andrew Haley wrote:
 > > Well, not exactly: I'm suggesting that we wrap all those longs in an
 > > opaque type.  But otherwise, yes.
 > 
 > So, how do you do opaque types, in Java?  

You write the code using a class that wraps your native pointer: a
class with a single member.

 > And how do you guarantee portability to 128bit systems?

You tell people "if you have a pointer that won't fit in a jlong,
you'll need to change three lines of code".

Andrew.



From MAILER-DAEMON Mon Apr 05 14:24:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAYlb-000814-4C
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 14:24:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAYha-00067X-Mq
	for classpath@gnu.org; Mon, 05 Apr 2004 14:20:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAYgc-00056b-Dr
	for classpath@gnu.org; Mon, 05 Apr 2004 14:19:39 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAYfU-0003tp-HA
	for classpath@gnu.org; Mon, 05 Apr 2004 14:17:56 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-109.ewetel.net
	[80.228.94.109])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i35IHare025434;
	Mon, 5 Apr 2004 20:17:36 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BAXjE-00023k-00; Mon, 05 Apr 2004 19:17:44 +0200
From: Michael Koch <konqueror@gmx.de>
To: Andrew Haley <aph@redhat.com>, Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Date: Mon, 5 Apr 2004 20:17:19 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<40719B4C.6040706@uqam.ca>
	<16497.40977.775693.474482@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.40977.775693.474482@cuddles.cambridge.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404052017.19068.konqueror@gmx.de>
X-CheckCompat: OK
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 18:24:13 -0000

Am Montag, 5. April 2004 20:06 schrieb Andrew Haley:
> Etienne Gagnon writes:
>  > Andrew Haley wrote:
>  > > Well, not exactly: I'm suggesting that we wrap all those longs
>  > > in an opaque type.  But otherwise, yes.
>  >
>  > So, how do you do opaque types, in Java?
>
> You write the code using a class that wraps your native pointer: a
> class with a single member.
>
>  > And how do you guarantee portability to 128bit systems?
>
> You tell people "if you have a pointer that won't fit in a jlong,
> you'll need to change three lines of code".

So we will have code like this:


package gnu.java.lang:

public class NativePointer
{
public long address;
}



Michael ?




From MAILER-DAEMON Mon Apr 05 14:49:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAZ9c-0000KX-S4
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 14:49:04 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAZ8P-000843-IL
	for classpath@gnu.org; Mon, 05 Apr 2004 14:47:49 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAZ7U-0007Y8-Qu
	for classpath@gnu.org; Mon, 05 Apr 2004 14:47:24 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAZ7U-0007Xd-60
	for classpath@gnu.org; Mon, 05 Apr 2004 14:46:52 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i35IVVKt023802;
	Mon, 5 Apr 2004 14:31:31 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040514324628329 ; Mon, 05 Apr 2004 14:32:46 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i35IRwwM026367; Mon, 5 Apr 2004 14:27:58 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAYpD-0002rg-2p; Mon, 05 Apr 2004 14:27:59 -0400
Message-ID: <4071A52E.2040501@uqam.ca>
Date: Mon, 05 Apr 2004 14:27:58 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.40308.789463.146357@cuddles.cambridge.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 18:49:01 -0000

Andrew Haley wrote:
> Sure.  Instead of putting a native pointer in a long or in a byte[],
> you just declare a class with a single field that contains the
> pointer.  Everyone who needs a pointer makes a suitably named
> subclass, so they'll know what they're pointing to.

How is that more efficient than a byte array?

Here's a concrete example:


class SomeRandomLibraryClass
{
   static
   {
     System.loadLibrary("SomeRandomJNILibrary");
   }

   private byte[] nativePointer;

   private native byte[] initNativeData(...);
   private native void someNativeMethod(byte[] nativePointer, ...);

   public SomeRandomLibraryClass(...)
   {
     ...
     nativePointer = initNativeData(...);
   }

   public void someMethod(...)
   {
     someNativeMethod(nativePointer, ...)  /**  THE REAL CALL **/
   }
}

In the C code, we'll have:

JNIEXPORT void JNICALL
Java_somepackage_someNativeMethod
   (JNIEnv *env, jobject this, jbyteArray nativePointer, ...)

{
   void *ptr;
   (*env)->GetByteArrayRegion(env, nativePointer, 0, sizeof(void *), (jbyte *) &ptr);
   ...
   /* do whatever with ptr */
   ...
}

So, how is your opaque type more efficient (and portable)?

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Mon Apr 05 15:01:45 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAZLt-0004bF-4G
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 15:01:45 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAZLp-0004YC-TZ
	for classpath@gnu.org; Mon, 05 Apr 2004 15:01:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAZLJ-0004RJ-C8
	for classpath@gnu.org; Mon, 05 Apr 2004 15:01:40 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAZE6-0002FT-3W
	for classpath@gnu.org; Mon, 05 Apr 2004 14:53:54 -0400
Received: from [207.189.223.52] (helo=email3.peakpeak.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAYLH-0006N6-T1
	for classpath@gnu.org; Mon, 05 Apr 2004 13:57:04 -0400
Received: (qmail 14816 invoked from network); 5 Apr 2004 18:09:23 -0000
Received: from tf0229.peakpeak.com (HELO fleche.redhat.com) ([204.144.239.229])
	(envelope-sender <tromey@redhat.com>)
	by email3.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <java-patches@gcc.gnu.org>; 5 Apr 2004 18:09:23 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id E0D3E4F82AF; Mon,  5 Apr 2004 11:43:12 -0600 (MDT)
To: Mark Wielaard <mark@klomp.org>
References: <1080236148.18716.161.camel@elsschot.wildebeest.org>
	<87wu58qpmw.fsf@fleche.redhat.com>
	<1080295746.18716.463.camel@elsschot.wildebeest.org>
	<200403261128.55981.konqueror@gmx.de>
	<1080301292.18716.480.camel@elsschot.wildebeest.org>
	<871xn8h9mt.fsf@fleche.redhat.com>
	<1081118952.7548.253.camel@elsschot.wildebeest.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I have nostalgia for the late Sixties! In 1969 I left my laundry with
	a hippie!! During an unauthorized Tupperware party it was chopped &
	diced!
Date: 05 Apr 2004 11:43:12 -0600
In-Reply-To: <1081118952.7548.253.camel@elsschot.wildebeest.org>
Message-ID: <87ekr28gnj.fsf@fleche.redhat.com>
Lines: 39
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, java-patches@gcc.gnu.org,
	Michael Koch <konqueror@gmx.de>
Subject: Re: gtk-peer compile fixes for gcc-2.95
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 19:01:43 -0000

>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:

Mark> The attached patch does that and enables -Wall for GNU Classpath.

Nice.  I skimmed it and it generally looks fine to me.

Mark> It fixes all issues found when compiling with -std=c89. Lots in the gtk
Mark> peers I am afraid. So please yell and scream if this is to intrusive. It
Mark> would be good if the gtk-peer stuff in libgcj was also compiled with
Mark> this flag.

I think it is a requirement, not just nice to have.  Otherwise we're
going to end up reintroducing code that isn't C89.

Here's an untested patch for the GUI branch.

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* Makefile.am (WARNINGS): Added -std=c89.

Index: Makefile.am
===================================================================
RCS file: /cvs/gcc/gcc/libjava/Makefile.am,v
retrieving revision 1.361.2.6
diff -u -r1.361.2.6 Makefile.am
--- Makefile.am 4 Mar 2004 17:31:02 -0000 1.361.2.6
+++ Makefile.am 5 Apr 2004 17:50:07 -0000
@@ -105,7 +105,7 @@
 
 GCC_UNWIND_INCLUDE = @GCC_UNWIND_INCLUDE@
 
-WARNINGS = -W -Wall
+WARNINGS = -W -Wall -std=c89
 ## We need _GNU_SOURCE defined for some Linux builds.  It doesn't hurt
 ## to always define it.
 AM_CXXFLAGS = -fno-rtti -fnon-call-exceptions $(THREADCXXFLAGS) \



From MAILER-DAEMON Mon Apr 05 15:04:05 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAZBL-0001wk-Pc
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 14:50:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAZ9R-00008a-0f
	for classpath@gnu.org; Mon, 05 Apr 2004 14:48:53 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAZ4h-0006ID-Kj
	for classpath@gnu.org; Mon, 05 Apr 2004 14:44:31 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAYzR-0003ow-77
	for classpath@gnu.org; Mon, 05 Apr 2004 14:38:33 -0400
Received: from [62.253.162.44] (helo=mta04-svc.ntlworld.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAYoC-0000ZX-Q8
	for classpath@gnu.org; Mon, 05 Apr 2004 14:26:56 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta04-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405182455.KHRM12324.mta04-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 19:24:56 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35INRCL028505; Mon, 5 Apr 2004 19:23:37 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35INPVs028499;
	Mon, 5 Apr 2004 19:23:25 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.42013.750485.960361@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 19:23:25 +0100
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404052017.19068.konqueror@gmx.de>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<40719B4C.6040706@uqam.ca>
	<16497.40977.775693.474482@cuddles.cambridge.redhat.com>
	<200404052017.19068.konqueror@gmx.de>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 18:50:35 -0000

Michael Koch writes:
 > Am Montag, 5. April 2004 20:06 schrieb Andrew Haley:
 > > Etienne Gagnon writes:
 > >  > Andrew Haley wrote:
 > >  > > Well, not exactly: I'm suggesting that we wrap all those longs
 > >  > > in an opaque type.  But otherwise, yes.
 > >  >
 > >  > So, how do you do opaque types, in Java?
 > >
 > > You write the code using a class that wraps your native pointer: a
 > > class with a single member.
 > >
 > >  > And how do you guarantee portability to 128bit systems?
 > >
 > > You tell people "if you have a pointer that won't fit in a jlong,
 > > you'll need to change three lines of code".
 > 
 > So we will have code like this:
 > 
 > 
 > package gnu.java.lang:
 > 
 > public class NativePointer
 > {
 > public long address;
 > }

Yes.  But don't use it directly: use

class gtkPeerPointer extends NativePointer
{
}

Andrew.



From MAILER-DAEMON Mon Apr 05 15:06:21 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAZQK-00080Q-P3
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 15:06:20 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAZQ8-0007id-US
	for classpath@gnu.org; Mon, 05 Apr 2004 15:06:08 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAZPX-00073r-A6
	for classpath@gnu.org; Mon, 05 Apr 2004 15:06:03 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAZCn-00026T-9w
	for classpath@gnu.org; Mon, 05 Apr 2004 14:52:21 -0400
Received: from [62.253.162.41] (helo=mta01-svc.ntlworld.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAYKx-0006Kw-0X
	for classpath@gnu.org; Mon, 05 Apr 2004 13:56:43 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta01-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405175612.EEUB17631.mta01-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 18:56:12 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35Ht2CL004289; Mon, 5 Apr 2004 18:55:13 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35Ht1xW004281;
	Mon, 5 Apr 2004 18:55:01 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.40308.789463.146357@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 18:55:00 +0100
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404051942.41173.konqueror@gmx.de>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 19:06:15 -0000

Michael Koch writes:
 > Am Montag, 5. April 2004 19:30 schrieb Andrew Haley:
 > > Michael Koch writes:
 > >  >  I think Andrew's solution might be viable. His solution is
 > >  > already used in SWT. SWT runs with SUN JRE so it seems to be
 > >  > portable enough for us.
 > >
 > > Well, not exactly: I'm suggesting that we wrap all those longs in an
 > > opaque type.  But otherwise, yes.
 > 
 > Can you give an example on how to do this ?

Sure.  Instead of putting a native pointer in a long or in a byte[],
you just declare a class with a single field that contains the
pointer.  Everyone who needs a pointer makes a suitably named
subclass, so they'll know what they're pointing to.

Andrew.



From MAILER-DAEMON Mon Apr 05 15:15:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAZYv-0004U1-Al
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 15:15:13 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAZYr-0004TH-Hy
	for classpath@gnu.org; Mon, 05 Apr 2004 15:15:09 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAZYL-00046C-GD
	for classpath@gnu.org; Mon, 05 Apr 2004 15:15:08 -0400
Received: from [62.253.162.46] (helo=mta06-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAZYK-00044N-Fj
	for classpath@gnu.org; Mon, 05 Apr 2004 15:14:36 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta06-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405185729.ERHS21321.mta06-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 19:57:29 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35IthCL028810; Mon, 5 Apr 2004 19:55:53 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35Itfn4028806;
	Mon, 5 Apr 2004 19:55:41 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.43949.570690.83069@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 19:55:41 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <4071A52E.2040501@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 19:15:10 -0000

Etienne Gagnon writes:
 > Andrew Haley wrote:
 > > Sure.  Instead of putting a native pointer in a long or in a byte[],
 > > you just declare a class with a single field that contains the
 > > pointer.  Everyone who needs a pointer makes a suitably named
 > > subclass, so they'll know what they're pointing to.
 > 
 > How is that more efficient than a byte array?

It's a heck of a lot *better* than a byte array.  Whether it's more
efficient or not depends on the design of your VM.


class SomeRandomLibraryClass
{
   static
   {
     System.loadLibrary("SomeRandomJNILibrary");
   }

   private RandomPointer extends nativePointer;

   private native RandomPointer initNativeData(...);
   private native void someNativeMethod(RandomPointer nativePointer, ...);

   public SomeRandomLibraryClass(...)
   {
     ...
     nativePointer = initNativeData(...);
   }

   public void someMethod(...)
   {
     someNativeMethod(nativePointer, ...)  /**  THE REAL CALL **/
   }
}

In the C code, we'll have:

 > JNIEXPORT void JNICALL
 > Java_somepackage_someNativeMethod
 >    (JNIEnv *env, jobject this, jbyteArray nativePointer, ...)
 > 
 > {
 >    void *ptr;
 >    (*env)->GetByteArrayRegion(env, nativePointer, 0, sizeof(void *), (jbyte *) &ptr);

Danger, Will Robinson!  This is not legal C!!!!  You can *not* take
the address of a pointer and cast it to a jbyte*.

Try finding a legal way to do this.

Andrew.



From MAILER-DAEMON Mon Apr 05 15:39:03 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAZvy-0002Ok-Pv
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 15:39:02 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAZvw-0002NQ-CF
	for classpath@gnu.org; Mon, 05 Apr 2004 15:39:00 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAZvQ-0002D5-Na
	for classpath@gnu.org; Mon, 05 Apr 2004 15:38:59 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAZvQ-0002C1-FL
	for classpath@gnu.org; Mon, 05 Apr 2004 15:38:28 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAZli-0000Up-IK
	for classpath@gnu.org; Mon, 05 Apr 2004 15:28:26 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i35JKDLV008953;
	Mon, 5 Apr 2004 15:21:20 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040515223500850 ; Mon, 05 Apr 2004 15:22:35 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i35JHKwM021890; Mon, 5 Apr 2004 15:17:20 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAZay-0003Bn-Gg; Mon, 05 Apr 2004 15:17:20 -0400
Message-ID: <4071B0BF.7020302@uqam.ca>
Date: Mon, 05 Apr 2004 15:17:19 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.43949.570690.83069@cuddles.cambridge.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 19:39:01 -0000

For one thing, you have not shown me *your* native part.

Second, see below.

Andrew Haley wrote:
>  > JNIEXPORT void JNICALL
>  > Java_somepackage_someNativeMethod
>  >    (JNIEnv *env, jobject this, jbyteArray nativePointer, ...)
>  > 
>  > {
>  >    void *ptr;
>  >    (*env)->GetByteArrayRegion(env, nativePointer, 0, sizeof(void *), (jbyte *) &ptr);
> 
> Danger, Will Robinson!  This is not legal C!!!!  You can *not* take
> the address of a pointer and cast it to a jbyte*.

What's wrong with it?  What do you think you are doing, every time you use
malloc(), e.g.:

  buffer = (some cast) malloc(...);


All I am doing is the same, and is perfectly legal ANSI/ISO C.  Prove me wrong
with a specific ISO C specification clause, if you claim otherwise.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Mon Apr 05 15:46:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAa2w-0008BN-Ji
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 15:46:14 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAa2l-0007vx-0H
	for classpath@gnu.org; Mon, 05 Apr 2004 15:46:03 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAa23-0006vl-T8
	for classpath@gnu.org; Mon, 05 Apr 2004 15:45:51 -0400
Received: from [62.253.162.41] (helo=mta01-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAa0u-0005w0-2L
	for classpath@gnu.org; Mon, 05 Apr 2004 15:44:08 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta01-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405194348.PVNN17631.mta01-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 20:43:48 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35JhiIi029203; Mon, 5 Apr 2004 20:43:44 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35Jhh2f029197;
	Mon, 5 Apr 2004 20:43:43 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.46830.975278.681383@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 20:43:42 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <4071B0BF.7020302@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 19:46:10 -0000

Etienne Gagnon writes:
 > For one thing, you have not shown me *your* native part.
 > 
 > Second, see below.
 > 
 > Andrew Haley wrote:
 > >  > JNIEXPORT void JNICALL
 > >  > Java_somepackage_someNativeMethod
 > >  >    (JNIEnv *env, jobject this, jbyteArray nativePointer, ...)
 > >  > 
 > >  > {
 > >  >    void *ptr;
 > >  >    (*env)->GetByteArrayRegion(env, nativePointer, 0, sizeof(void *), (jbyte *) &ptr);
 > > 
 > > Danger, Will Robinson!  This is not legal C!!!!  You can *not* take
 > > the address of a pointer and cast it to a jbyte*.
 > 
 > What's wrong with it?  What do you think you are doing, every time you use
 > malloc(), e.g.:
 > 
 >   buffer = (some cast) malloc(...);

malloc() returns a char*, not a jbyte*.

 > All I am doing is the same, and is perfectly legal ANSI/ISO C. 

Sigh.  No it isn't, and this code will break with gcc.

 > Prove me wrong with a specific ISO C specification clause, if you
 > claim otherwise.

I spent a long time working on and supporting gcc, and this is the
rule I've had to refer people to more times than any other.  It's
amazing how many programmers don't know the specfication.

All that C guarantees is that you can convert a pointer to a different
pointer type and then back again, and the result will compare equal to
the original pointer.  Also, "when a pointer to an object is converted
to a pointer to a character type, the result points to the lowest
addressed byte of the object.  Successive increments of the result, up
to the size of the object, yield pointers to the remaining bytes of
the object."  Except for this, you may not convert pointers of
different type and dereference them.

Scetion 6.2.2.3, Para 7.

Andrew.



From MAILER-DAEMON Mon Apr 05 16:43:55 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAawl-0001Hu-4i
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 16:43:55 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAawi-0001Fi-J7
	for classpath@gnu.org; Mon, 05 Apr 2004 16:43:52 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAawC-00012h-8s
	for classpath@gnu.org; Mon, 05 Apr 2004 16:43:51 -0400
Received: from [209.225.28.216] (helo=mxsf16.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAauG-00004y-Lt
	for classpath@gnu.org; Mon, 05 Apr 2004 16:41:20 -0400
Received: from InterJet.dellroad.org (E6V6Q8.cpe.mvllo.al.charter.com
	[24.196.29.251])
	by mxsf16.cluster1.charter.net (8.12.11/8.12.11) with ESMTP id
	i35KU28H001305; Mon, 5 Apr 2004 16:30:03 -0400 (EDT)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id PAA18358;
	Mon, 5 Apr 2004 15:28:11 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i35KSAQO000658; 
	Mon, 5 Apr 2004 15:28:10 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i35KS939000657;
	Mon, 5 Apr 2004 15:28:09 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404052028.i35KS939000657@arch20m.dellroad.org>
In-Reply-To: <16497.46830.975278.681383@cuddles.cambridge.redhat.com>
To: Andrew Haley <aph@redhat.com>
Date: Mon, 5 Apr 2004 15:28:09 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 20:43:53 -0000

Andrew Haley wrote:
>  > Prove me wrong with a specific ISO C specification clause, if you
>  > claim otherwise.
> 
> I spent a long time working on and supporting gcc, and this is the
> rule I've had to refer people to more times than any other.  It's
> amazing how many programmers don't know the specfication.

You guys are going off into the weeds. All that's required from C
for the byte[] strategy to work is that this works:

   void *ptr;
   char *buf;

   ptr = <any valid pointer value>
   buf = malloc(sizeof(ptr));
   memcpy(buf, &ptr, sizeof(ptr));

   ... then sometime later ...

   memcpy(&ptr, buf, sizeof(ptr));
   <continue using the fully restored ptr>

I'm not a specophile but I would guess that C does at least guarantee this.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Mon Apr 05 17:11:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAbN1-0007NU-HL
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 17:11:03 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAbMn-000792-5A
	for classpath@gnu.org; Mon, 05 Apr 2004 17:10:49 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAbMC-0006K2-DJ
	for classpath@gnu.org; Mon, 05 Apr 2004 17:10:43 -0400
Received: from [62.253.162.43] (helo=mta03-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAbM4-00063m-Fz
	for classpath@gnu.org; Mon, 05 Apr 2004 17:10:04 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta03-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040405205356.IAPL17872.mta03-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Mon, 5 Apr 2004 21:53:56 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35Ks1Ii029668; Mon, 5 Apr 2004 21:54:02 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i35Krx2K029664;
	Mon, 5 Apr 2004 21:53:59 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16497.51047.543607.474464@cuddles.cambridge.redhat.com>
Date: Mon, 5 Apr 2004 21:53:59 +0100
To: Archie Cobbs <archie@dellroad.org>
In-Reply-To: <200404052028.i35KS939000657@arch20m.dellroad.org>
References: <16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<200404052028.i35KS939000657@arch20m.dellroad.org>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 21:10:52 -0000

Archie Cobbs writes:
 > Andrew Haley wrote:
 > >  > Prove me wrong with a specific ISO C specification clause, if you
 > >  > claim otherwise.
 > > 
 > > I spent a long time working on and supporting gcc, and this is the
 > > rule I've had to refer people to more times than any other.  It's
 > > amazing how many programmers don't know the specfication.
 > 
 > You guys are going off into the weeds. All that's required from C
 > for the byte[] strategy to work is that this works:
 > 
 >    void *ptr;
 >    char *buf;
 > 
 >    ptr = <any valid pointer value>
 >    buf = malloc(sizeof(ptr));
 >    memcpy(buf, &ptr, sizeof(ptr));
 > 
 >    ... then sometime later ...
 > 
 >    memcpy(&ptr, buf, sizeof(ptr));
 >    <continue using the fully restored ptr>
 > 
 > I'm not a specophile but I would guess that C does at least guarantee this.

It does.  I'm not trying to get into a debate about micro-
optimization: given the overhead of JNI, it's probably not important.
What I care about is that the code should be legal, maintainable, and
efficient -- in that order.

Having spent a lot of time working on SWT, the ability to subclass a
native pointer is IMO very important indeed.  It would have saved me a
huge amount of time if native pointers had types.  This is more
important than quibbles about efficiency.

However, if someone posts code that I don't believe is legal, I will
point it out.  I mean, I can't help it.  :-)

Andrew.




From MAILER-DAEMON Mon Apr 05 17:46:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAbvg-000805-Eg
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 17:46:52 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAbvX-0007yY-46
	for classpath@gnu.org; Mon, 05 Apr 2004 17:46:43 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAbuz-0007ep-S6
	for classpath@gnu.org; Mon, 05 Apr 2004 17:46:42 -0400
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAbuz-0007e5-CX
	for classpath@gnu.org; Mon, 05 Apr 2004 17:46:09 -0400
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP
	id 720E860DFD; Mon,  5 Apr 2004 21:46:06 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 82461-01; Mon,  5 Apr 2004 21:46:05 +0000 (GMT)
Received: from reali.dnsalias.net (212-41-79-89.adsl.solnet.ch [212.41.79.89])
	by mail01.solnet.ch (Postfix) with ESMTP
	id CEA8E60DEB; Mon,  5 Apr 2004 21:46:00 +0000 (GMT)
Received: from mc-reali (reali.dnsalias.net [192.168.1.2])
	by reali.dnsalias.net (Postfix) with ESMTP
	id E3D343EBC4; Mon,  5 Apr 2004 23:44:15 +0200 (CEST)
Date: Mon, 05 Apr 2004 23:46:59 +0200
From: Patrik Reali <reali@acm.org>
To: "S. Meslin-Weber" <twiun@adorphuye.com>, GNU Classpath <classpath@gnu.org>
Message-ID: <287624151.1081208819@[192.168.1.4]>
In-Reply-To: <20040405084701.GF5755@tangency.co.uk>
References: <20040405084701.GF5755@tangency.co.uk>
X-Mailer: Mulberry/3.1.0 (Win32)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-Virus-Scanned: by SolNet mail01.solnet.ch
Cc: 
Subject: Re: Bad link for 0.08 download?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 21:46:43 -0000

Hi Stephane,

you are right! The file was renamed. (Anyone know more?)

Have a look into <ftp://alpha.gnu.org/gnu/classpath/> for the released 
files.

Classpath is released on the alpha server, because is still heavily under 
development.

-Patrik

--On Montag, 5. April 2004 09:47 +0100 "S. Meslin-Weber" 
<twiun@adorphuye.com> wrote:

> Hi guys,
>
> I tried downloading classpath-0.08.tgz from the downloads page last
> night and it looks like the URL is pointing to the alpha gnu ftp site.
> Shouldn't that be poiting to the regular gnu ftp site?
>
> Thanks,
>
> Stephane
>
>
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath
>





From MAILER-DAEMON Mon Apr 05 18:08:26 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAcGY-0007ol-6H
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 18:08:26 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAcGQ-0007mQ-7b
	for classpath@gnu.org; Mon, 05 Apr 2004 18:08:18 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAcGN-0007lN-Ib
	for classpath@gnu.org; Mon, 05 Apr 2004 18:08:16 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAcG2-0007a9-7s
	for classpath@gnu.org; Mon, 05 Apr 2004 18:07:54 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BAcFs-0005HP-00; Tue, 06 Apr 2004 00:07:44 +0200
From: Mark Wielaard <mark@klomp.org>
To: Patrik Reali <reali@acm.org>
In-Reply-To: <287624151.1081208819@[192.168.1.4]>
References: <20040405084701.GF5755@tangency.co.uk>
	<287624151.1081208819@[192.168.1.4]>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-oycy3H7nUjrRstB405eM"
Message-Id: <1081202866.5672.37.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 06 Apr 2004 00:07:46 +0200
Cc: GNU Classpath <classpath@gnu.org>, "S. Meslin-Weber" <twiun@adorphuye.com>
Subject: Re: Bad link for 0.08 download?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 22:08:23 -0000


--=-oycy3H7nUjrRstB405eM
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2004-04-05 at 23:46, Patrik Reali wrote:
> you are right! The file was renamed. (Anyone know more?)
>=20
> Have a look into <ftp://alpha.gnu.org/gnu/classpath/> for the released=20
> files.
>=20
> Classpath is released on the alpha server, because is still heavily under=
=20
> development.

No sorry. I thought I had announced it clearly. But obviously I didn't.
Since 0.08 the snapshot releases are only hosted on ftp.gnu.org. We now
only put test releases on alpha.gnu.org. alpha.gnu.org doesn't keep
backups and although we see the GNU Classpath snapshots as works in
progress it seems people do rely on them. So from now on we put them on
ftp://ftp.gnu.org/gnu/classpath/ to make sure they are mirrored and
backed up.

The 0.08-test1 release found on alpha is indeed just a test release made
a few days before the real 0.08 release.

Cheers,

Mark

P.S. This is also the reason we don't have any official pre 0.06
releases anymore. They were never backed up and nobody had the official
old release files anymore. We could regenerate them from CVS of course,
but nobody bothered to do that.

--=-oycy3H7nUjrRstB405eM
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD4DBQBAcdiyxVhZCJWr9QwRAhMKAJ9lY7xrAQ4dfiJTT1FMNTuyRoA8YACXXFJq
1O7eDH/1XmW+BqE6lpy9Mw==
=xPwZ
-----END PGP SIGNATURE-----

--=-oycy3H7nUjrRstB405eM--




From MAILER-DAEMON Mon Apr 05 18:42:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAcmS-0003dT-UP
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 18:41:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAcmI-0003ar-Fi
	for classpath@gnu.org; Mon, 05 Apr 2004 18:41:14 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAchS-0002Vh-Cr
	for classpath@gnu.org; Mon, 05 Apr 2004 18:36:45 -0400
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAcgm-0002Lx-7O
	for classpath@gnu.org; Mon, 05 Apr 2004 18:35:32 -0400
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP
	id 71A0E62263; Mon,  5 Apr 2004 22:35:31 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 84419-01; Mon,  5 Apr 2004 22:35:30 +0000 (GMT)
Received: from reali.dnsalias.net (212-41-79-89.adsl.solnet.ch [212.41.79.89])
	by mail01.solnet.ch (Postfix) with ESMTP
	id DAD9462252; Mon,  5 Apr 2004 22:35:29 +0000 (GMT)
Received: from mc-reali (reali.dnsalias.net [192.168.1.2])
	by reali.dnsalias.net (Postfix) with ESMTP
	id 516C61C419; Tue,  6 Apr 2004 00:33:44 +0200 (CEST)
Date: Tue, 06 Apr 2004 00:36:28 +0200
From: Patrik Reali <reali@acm.org>
To: Mark Wielaard <mark@klomp.org>
Message-ID: <290593180.1081211788@[192.168.1.4]>
In-Reply-To: <1081202866.5672.37.camel@elsschot.wildebeest.org>
References: <20040405084701.GF5755@tangency.co.uk>	
	<287624151.1081208819@[192.168.1.4]>
	<1081202866.5672.37.camel@elsschot.wildebeest.org>
X-Mailer: Mulberry/3.1.0 (Win32)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-Virus-Scanned: by SolNet mail01.solnet.ch
Cc: GNU Classpath <classpath@gnu.org>, "S. Meslin-Weber" <twiun@adorphuye.com>
Subject: Re: Bad link for 0.08 download?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 22:41:16 -0000

ok, I'm sorry for the confusion. I'll update the download page accordingly.

-Patrik


--On Dienstag, 6. April 2004 00:07 +0200 Mark Wielaard <mark@klomp.org> 
wrote:

> Hi,
>
> On Mon, 2004-04-05 at 23:46, Patrik Reali wrote:
>> you are right! The file was renamed. (Anyone know more?)
>>
>> Have a look into <ftp://alpha.gnu.org/gnu/classpath/> for the released
>> files.
>>
>> Classpath is released on the alpha server, because is still heavily
>> under  development.
>
> No sorry. I thought I had announced it clearly. But obviously I didn't.
> Since 0.08 the snapshot releases are only hosted on ftp.gnu.org. We now
> only put test releases on alpha.gnu.org. alpha.gnu.org doesn't keep
> backups and although we see the GNU Classpath snapshots as works in
> progress it seems people do rely on them. So from now on we put them on
> ftp://ftp.gnu.org/gnu/classpath/ to make sure they are mirrored and
> backed up.
>
> The 0.08-test1 release found on alpha is indeed just a test release made
> a few days before the real 0.08 release.
>
> Cheers,
>
> Mark
>
> P.S. This is also the reason we don't have any official pre 0.06
> releases anymore. They were never backed up and nobody had the official
> old release files anymore. We could regenerate them from CVS of course,
> but nobody bothered to do that.





From MAILER-DAEMON Mon Apr 05 18:42:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAcnP-0004D8-PG
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 18:42:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAcmr-0003wI-FZ
	for classpath@gnu.org; Mon, 05 Apr 2004 18:41:49 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAclL-0003LX-OC
	for classpath@gnu.org; Mon, 05 Apr 2004 18:40:48 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAcjB-0002vh-1L
	for classpath@gnu.org; Mon, 05 Apr 2004 18:38:01 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i35Mbs5D023508;
	Mon, 5 Apr 2004 18:37:54 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i35Mbrj02649; 
	Mon, 5 Apr 2004 18:37:53 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35Mbre1012035; Mon, 5 Apr 2004 18:37:53 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <40713EEC.1070205@aicas.com>
References: <40713EEC.1070205@aicas.com>
Content-Type: text/plain; charset=UTF-8
Message-Id: <1081204672.11618.127.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Mon, 05 Apr 2004 18:37:53 -0400
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	i35Mbs5D023508
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.ColorModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 22:42:14 -0000

On Mon, 2004-04-05 at 07:11, Ingo Pr=C3=B6tel wrote:
> I suggest the following patch
>=20
> 2004-04-05  Ingo Proetel <proetel@aicas.com>
>=20
> 	* java/awt/image/ColorModel.java (getRGBdefault): Default ColorModel h=
as 32 bit pixels not 8 bit=20
> pixels.
> 	(isCompatibleRaster): Added javadoc comment.
>=20
> ingo


> -  // Typically overridden
> +  /**
> +   * Checks if the given raster has a compatible data-layout
> (SampleModel).
> +   * @param raster The Raster to test.
> +   * @return true if raster is compatible.
> +   */=20

This implementation is different from the description in Sun's
javadocs.  Their default implementation is to throw an
UnsupportedOperationException, since ColorModel is an abstract class.=20
Does the implementation here need to be moved into one of the derived
classes?

>    public boolean isCompatibleRaster(Raster raster)
>    {
>      SampleModel sampleModel =3D raster.getSampleModel();

Tom





From MAILER-DAEMON Mon Apr 05 18:50:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAcvY-0002Du-97
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 18:50:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAcuu-0001nn-8N
	for classpath@gnu.org; Mon, 05 Apr 2004 18:50:08 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BActj-0000bz-UC
	for classpath@gnu.org; Mon, 05 Apr 2004 18:49:03 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAct8-0000Fo-JA
	for classpath@gnu.org; Mon, 05 Apr 2004 18:48:18 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i35MmH5D027025;
	Mon, 5 Apr 2004 18:48:17 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i35MmGj07252; 
	Mon, 5 Apr 2004 18:48:16 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i35MmGe1012406; Mon, 5 Apr 2004 18:48:16 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <40717603.6010900@aicas.com>
References: <4071460B.3070303@aicas.com>  <40717603.6010900@aicas.com>
Content-Type: text/plain; charset=UTF-8
Message-Id: <1081205295.11618.135.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Mon, 05 Apr 2004 18:48:15 -0400
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	i35MmH5D027025
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.Raster
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 22:50:45 -0000

On Mon, 2004-04-05 at 11:06, Ingo Pr=C3=B6tel wrote:
> Note new attachment.
>=20
> Ingo Pr=C3=B6tel wrote:
> > I suggest the following patch
> > 2004-04-05  Ingo Proetel  <proetel@aicas.com>
> >=20
> >     * java/awt/image/Raster.java (toString): Added method.
> >=20
> > ingo
> >=20
> >=20

+ =20
+  /**
+   * Create a String representing the stat of this Raster.
                                       ^
                                       state?

+   * @return A String representing the stat of this Raster.
+   * @see java.lang.Object#toString()
+   */
+  public String toString()
+  {
+    StringBuffer result =3D new StringBuffer();
+   =20
+    result.append(getClass().getName());
+    result.append("[(");
+    result.append(minX).append(",").append(minY).append("), ");
+    result.append(width).append(" x ").append(height).append(",");
+    result.append(sampleModel).append(",");
+    result.append(dataBuffer);
+    result.append("]");
+   =20

Is this result in the same format as the result produced by Sun's
Raster.toString?=20

Tom





From MAILER-DAEMON Mon Apr 05 19:19:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAdN8-0005vG-AE
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 19:19:18 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAdN5-0005uS-4F
	for classpath@gnu.org; Mon, 05 Apr 2004 19:19:15 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAdMY-0005kP-1a
	for classpath@gnu.org; Mon, 05 Apr 2004 19:19:13 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAdMX-0005jp-E6
	for classpath@gnu.org; Mon, 05 Apr 2004 19:18:41 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i35NAFLB010795;
	Mon, 5 Apr 2004 19:10:49 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040519120422633 ; Mon, 05 Apr 2004 19:12:04 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i35N76WU006838; Mon, 5 Apr 2004 19:07:06 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAdBK-0003Sv-Mv; Mon, 05 Apr 2004 19:07:06 -0400
Message-ID: <4071E699.8020809@uqam.ca>
Date: Mon, 05 Apr 2004 19:07:05 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
In-Reply-To: <16497.46830.975278.681383@cuddles.cambridge.redhat.com>
Content-Type: multipart/mixed; boundary="------------070206000304060608040505"
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 23:19:16 -0000

This is a multi-part message in MIME format.
--------------070206000304060608040505
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Andrew Haley wrote:
> malloc() returns a char*, not a jbyte*.

So, can you tell me the difference between a jbyte and a "signed char"?

> Sigh.  No it isn't, and this code will break with gcc.

OK, maybe I am tired and I don't see it.  GCC -Wall does not complain
about the attached example.

> ...  Also, "when a pointer to an object is converted
> to a pointer to a character type, the result points to the lowest
> addressed byte of the object.  Successive increments of the result, up
> to the size of the object, yield pointers to the remaining bytes of
> the object."


We agree on this.  Now: what's different between "signed char" and "jbyte"?
Can they actually be distinct on some platform?

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/

--------------070206000304060608040505
Content-Type: text/x-c-header;
 name="JNITest.h"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="JNITest.h"

/* DO NOT EDIT THIS FILE - it is machine generated */
#include <jni.h>
/* Header for class JNITest */

#ifndef _Included_JNITest
#define _Included_JNITest
#ifdef __cplusplus
extern "C"
{
#endif
/*
 * Class:     JNITest
 * Method:    getPtr
 * Signature: ()[B
 */
  JNIEXPORT jbyteArray JNICALL Java_JNITest_getPtr (JNIEnv *, jclass);

/*
 * Class:     JNITest
 * Method:    testPtr
 * Signature: ([B)V
 */
  JNIEXPORT void JNICALL Java_JNITest_testPtr (JNIEnv *, jclass, jbyteArray);

#ifdef __cplusplus
}
#endif
#endif

--------------070206000304060608040505
Content-Type: text/x-java;
 name="JNITest.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="JNITest.java"

public class JNITest
{
    static
    {
	System.loadLibrary("test");
    }

    public static void main(String[] args)
    {
	byte[] nativePtr = getPtr();
	testPtr(nativePtr);
    }

    private static native byte[] getPtr();
    private static native void testPtr(byte[] nativPtr);
}

--------------070206000304060608040505
Content-Type: text/x-csrc;
 name="libtest.c"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="libtest.c"

#include <jni.h>
#include <stdio.h>
#include <stdlib.h>

/*
 * Class:     JNITest
 * Method:    getPtr
 * Signature: ()[B
 */
JNIEXPORT jbyteArray JNICALL
Java_JNITest_getPtr (JNIEnv * env, jclass class)
{
  int *int_ptr = (int *) malloc (sizeof (int));;
  *int_ptr = 0x47;
 
  jbyteArray nativePtr = (*env)->NewByteArray (env, (jint) sizeof (int *));

  if (nativePtr == NULL)
    return NULL;

  (*env)->SetByteArrayRegion (env, nativePtr, 0, (int) sizeof (int *),
			      (char *) &int_ptr);

  return nativePtr;
}

/*
 * Class:     JNITest
 * Method:    testPtr
 * Signature: ([B)V
 */
JNIEXPORT void JNICALL
Java_JNITest_testPtr (JNIEnv * env, jclass class, jbyteArray nativePtr)
{
  int *int_ptr;
  (*env)->GetByteArrayRegion (env, nativePtr, 0, (jint) sizeof (int *),
			      (jbyte *) & int_ptr);
  printf ("value = %x\n", *int_ptr);
}

--------------070206000304060608040505--



From MAILER-DAEMON Mon Apr 05 19:35:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAdd5-0001N7-OI
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 19:35:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAdd1-0001La-QW
	for classpath@gnu.org; Mon, 05 Apr 2004 19:35:43 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAdcT-0001A3-HR
	for classpath@gnu.org; Mon, 05 Apr 2004 19:35:41 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAdcO-00017r-9y
	for classpath@gnu.org; Mon, 05 Apr 2004 19:35:04 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i35NP9L3028073;
	Mon, 5 Apr 2004 19:25:18 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040519263223707 ; Mon, 05 Apr 2004 19:26:32 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i35NKSWU014128; Mon, 5 Apr 2004 19:20:28 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAdOG-0003TP-3m; Mon, 05 Apr 2004 19:20:28 -0400
Message-ID: <4071E9BA.6080504@uqam.ca>
Date: Mon, 05 Apr 2004 19:20:26 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca>
In-Reply-To: <4071E699.8020809@uqam.ca>
Content-Type: multipart/mixed; boundary="------------020605070302040803050309"
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 23:35:45 -0000

This is a multi-part message in MIME format.
--------------020605070302040803050309
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

I should have compiled with -pedantic, of course...  I've included a few fixes
in the attachment.

>> malloc() returns a char*, not a jbyte*.

        [#1] byte
        addressable  unit  of  data storage large enough to hold any
        member  of  the  basic  character  set  of   the   execution
        environment

        [#2]  NOTE 1 It  is  possible to express the address of each
        individual byte of an object uniquely.

        [#3] NOTE 2 A byte is composed of a contiguous  sequence  of
        bits,  the  number  of which is implementation-defined.  The
        least significant bit is called the low-order bit; the  most
        significant bit is called the high-order bit.

        3.5
        [#1] character
        bit representation that fits in a byte                       *


Do we actually have to deal with platforms that have non 8-bit chars?
I guess quite a few other things/algorithms in the class library would
break if it is so...

It's fine to be pedantic, but up to a point...

FYI: The JNI specification guarantees that jbyte is an 8-bit signed value.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/

--------------020605070302040803050309
Content-Type: text/x-csrc;
 name="libtest.c"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="libtest.c"

#include <jni.h>
#include <stdio.h>
#include <stdlib.h>

/*
 * Class:     JNITest
 * Method:    getPtr
 * Signature: ()[B
 */
JNIEXPORT jbyteArray JNICALL
Java_JNITest_getPtr (JNIEnv * env, jclass class)
{
  int *int_ptr;
  jbyteArray nativePtr;

  int_ptr = (int *) malloc (sizeof (int));;
  *int_ptr = 0x47;

  nativePtr = (*env)->NewByteArray (env, (jint) sizeof (int *));
 
  if (nativePtr == NULL)
    return NULL;

  (*env)->SetByteArrayRegion (env, nativePtr, 0, (int) sizeof (int *),
			      (jbyte *) &int_ptr);

  return nativePtr;
}

/*
 * Class:     JNITest
 * Method:    testPtr
 * Signature: ([B)V
 */
JNIEXPORT void JNICALL
Java_JNITest_testPtr (JNIEnv * env, jclass class, jbyteArray nativePtr)
{
  int *int_ptr;
  (*env)->GetByteArrayRegion (env, nativePtr, 0, (jint) sizeof (int *),
			      (jbyte *) & int_ptr);
  printf ("value = %x\n", *int_ptr);
}

--------------020605070302040803050309--



From MAILER-DAEMON Mon Apr 05 20:06:20 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAe6d-0004vK-IG
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 20:06:19 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAe6Z-0004t8-TD
	for classpath@gnu.org; Mon, 05 Apr 2004 20:06:15 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAe63-0004k7-IE
	for classpath@gnu.org; Mon, 05 Apr 2004 20:06:14 -0400
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAe62-0004jn-Gj
	for classpath@gnu.org; Mon, 05 Apr 2004 20:05:42 -0400
Received: from dholmeslaptop (dholmes.dltech.com.au [203.222.72.2])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i3600x05071065;
	Tue, 6 Apr 2004 10:01:00 +1000 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "Etienne Gagnon" <gagnon.etienne_m@uqam.ca>,
	"Andrew Haley" <aph@redhat.com>
Date: Tue, 6 Apr 2004 10:01:14 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCAEEGEAAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
In-Reply-To: <4071E9BA.6080504@uqam.ca>
Importance: Normal
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 00:06:17 -0000

Well if we're being pedantic and imprecise to boot ...

> >> malloc() returns a char*, not a jbyte*.

malloc() returns void* not char*. It hasn't returned char* since pre ANSI C.
Hence the pointer returned by malloc can be legally converted to any real
pointer type with clearly defined semantics.

Taking the address of a void* and pretending that it is the address of a
jbyte* is not legal. However, it is legal to convert between an int and a
pointer type and a pointer type and an int. If the address represented by
the int is incorrectly aligned for the pointer type then the result is
undefined. Otherwise the result is implementation specific. Hence you can
write legal but (by definition) non-portable code to do what you want.

David Holmes




From MAILER-DAEMON Mon Apr 05 20:39:25 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAecf-0006Lx-KU
	for mharc-classpath@gnu.org; Mon, 05 Apr 2004 20:39:25 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAecb-0006KI-U4
	for classpath@gnu.org; Mon, 05 Apr 2004 20:39:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAec4-0006Br-Tj
	for classpath@gnu.org; Mon, 05 Apr 2004 20:39:20 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAeZD-0005B5-7p
	for classpath@gnu.org; Mon, 05 Apr 2004 20:35:51 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAeOt-0004uu-CJ
	for classpath@gnu.org; Mon, 05 Apr 2004 20:25:11 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i360K8LV021701;
	Mon, 5 Apr 2004 20:20:53 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040520220827872 ; Mon, 05 Apr 2004 20:22:08 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i360IfKU019107; Mon, 5 Apr 2004 20:18:41 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAeIb-0003VF-RW; Mon, 05 Apr 2004 20:18:41 -0400
Message-ID: <4071F761.8080603@uqam.ca>
Date: Mon, 05 Apr 2004 20:18:41 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>	<4071E699.8020809@uqam.ca>
	<4071E9BA.6080504@uqam.ca>
In-Reply-To: <4071E9BA.6080504@uqam.ca>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 00:39:22 -0000

Etienne Gagnon wrote:
> FYI: The JNI specification guarantees that jbyte is an 8-bit signed value.

Hmmm...  Thinking about all this mess of "non-specified" C byte length...

Can JNI actually be implemented on a 16-bit per byte system?
Anybody has a reasonable answer?

To consider:
       5.2.4.2.1  Sizes of integer types <limits.h>

        [#1]  The  values  given below shall be replaced by constant
        expressions  suitable   for   use   in   #if   preprocessing
        directives...
...
          -- number  of  bits for smallest object that is not a bit-
             field (byte)
             CHAR_BIT                         8
...

So, what how would one define "jbyte" on a platform where CHAR_BIT is
defined as 16?  JNI depends on having such a type.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Tue Apr 06 03:39:21 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAlB2-0004tR-PA
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 03:39:20 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAlAz-0004sA-Nb
	for classpath@gnu.org; Tue, 06 Apr 2004 03:39:17 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAlAQ-0004XW-Vu
	for classpath@gnu.org; Tue, 06 Apr 2004 03:39:14 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAl3d-0002aX-CH
	for classpath@gnu.org; Tue, 06 Apr 2004 03:31:41 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 6 Apr 2004 09:31:34 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD0B@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQbMhlKb6CJ8Uo9QHypW4nozP2v6gAdt4LQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Etienne Gagnon" <gagnon.etienne_m@uqam.ca>,
	"Andrew Haley" <aph@redhat.com>
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 07:39:18 -0000

Etienne Gagnon wrote:
> There is a single JNI source code source base, used by everyone.

Please don't say that. Not everyone uses the C part of Classpath.
Besides, if you want NIO (we are still talking about NIO, right?) to
perform well, you're going to need some VM magic.

Regards,
Jeroen



From MAILER-DAEMON Tue Apr 06 03:56:12 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAlRM-0005k4-1D
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 03:56:12 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAlRH-0005hp-Ra
	for classpath@gnu.org; Tue, 06 Apr 2004 03:56:07 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAlQh-0005Ua-GD
	for classpath@gnu.org; Tue, 06 Apr 2004 03:56:03 -0400
Received: from [195.18.123.2] (helo=kiev.dev.factotummedia.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAlQg-0005U9-DQ
	for classpath@gnu.org; Tue, 06 Apr 2004 03:55:30 -0400
Received: from amavis by kiev.dev.factotummedia.nl with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BAlNv-0007yM-00; Tue, 06 Apr 2004 09:52:39 +0200
Received: from kiev.dev.factotummedia.nl ([127.0.0.1])
	by localhost (kiev [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
	id 30278-08; Tue, 6 Apr 2004 09:52:39 +0200 (CEST)
Received: from pc-thomas.dev.factotummedia.nl ([192.168.3.104])
	by kiev.dev.factotummedia.nl with esmtp (Exim 3.35 #1 (Debian))
	id 1BAlNu-0007yF-00; Tue, 06 Apr 2004 09:52:38 +0200
From: Thomas <zander@javalobby.org>
To: mauve-discuss@sources.redhat.com,
 GNU Classpath <classpath@gnu.org>
Date: Tue, 6 Apr 2004 09:56:13 +0200
User-Agent: KMail/1.6.2
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404060956.14298.zander@javalobby.org>
X-Virus-Scanned: by amavisd-new (Debian) at dev.factotummedia.nl
Cc: 
Subject: Mauve patches.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 07:56:10 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I've submitted several patches to both list and hear nothing; is there anyo=
ne=20
who can comment/commit on these?

Please!
=2D --=20
Regards
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAcmKdCojCW6H2z/QRAvZpAKDd5gaoHFbHLIMM/RsAMWA5VSj2HgCgi4na
KTB8qTvzHh02ysf+loktnGI=3D
=3DOWa0
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Tue Apr 06 04:55:31 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAmMe-0007sC-Pv
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 04:55:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAmMY-0007p8-HI
	for classpath@gnu.org; Tue, 06 Apr 2004 04:55:18 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAmM2-0007fE-KI
	for classpath@gnu.org; Tue, 06 Apr 2004 04:55:17 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAmLn-0007c8-M1
	for classpath@gnu.org; Tue, 06 Apr 2004 04:54:31 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAmEP-00050u-K3
	for classpath@gnu.org; Tue, 06 Apr 2004 04:46:53 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-170.ewetel.net
	[80.228.95.170])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i368kjre005595;
	Tue, 6 Apr 2004 10:46:45 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BAlIO-0000N3-00; Tue, 06 Apr 2004 09:46:56 +0200
From: Michael Koch <konqueror@gmx.de>
To: Thomas <zander@javalobby.org>, mauve-discuss@sources.redhat.com,
	GNU Classpath <classpath@gnu.org>
Date: Tue, 6 Apr 2004 10:46:26 +0200
User-Agent: KMail/1.5.4
References: <200404060956.14298.zander@javalobby.org>
In-Reply-To: <200404060956.14298.zander@javalobby.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404061046.27919.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: Mauve patches.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 08:55:20 -0000

Am Dienstag, 6. April 2004 09:56 schrieb Thomas:
> I've submitted several patches to both list and hear nothing; is
> there anyone who can comment/commit on these?

We are all doing this in our freetime so we need some time nee out 
backlogs sometimes.

Personally I have Mauve CVS access but I'm using not using ant so I cant 
really vote on your patch. I think Tom Tromey or Mark Wielaard will 
look into this in some days. If not please ping me and I will do it.


Michael




From MAILER-DAEMON Tue Apr 06 05:12:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAmd8-0005gq-Ly
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 05:12:26 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAmd0-0005em-LR
	for classpath@gnu.org; Tue, 06 Apr 2004 05:12:18 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAmcT-0005QX-L5
	for classpath@gnu.org; Tue, 06 Apr 2004 05:12:16 -0400
Received: from [62.253.162.42] (helo=mta02-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAmcT-0005QB-70
	for classpath@gnu.org; Tue, 06 Apr 2004 05:11:45 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta02-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040406091056.CEGI27528.mta02-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Tue, 6 Apr 2004 10:10:56 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i369BGIi032306; Tue, 6 Apr 2004 10:11:16 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i369BE05032302;
	Tue, 6 Apr 2004 10:11:14 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16498.29746.633423.548960@cuddles.cambridge.redhat.com>
Date: Tue, 6 Apr 2004 10:11:14 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <4071E699.8020809@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 09:12:19 -0000

Etienne Gagnon writes:
 > Andrew Haley wrote:
 > > malloc() returns a char*, not a jbyte*.
 > 
 > So, can you tell me the difference between a jbyte and a "signed char"?
 > 
 > > Sigh.  No it isn't, and this code will break with gcc.
 > 
 > OK, maybe I am tired and I don't see it.  GCC -Wall does not complain
 > about the attached example.

When you have aliasing errors, the result is usually incorrect code,
not compile time warnings.

 > > ...  Also, "when a pointer to an object is converted
 > > to a pointer to a character type, the result points to the lowest
 > > addressed byte of the object.  Successive increments of the result, up
 > > to the size of the object, yield pointers to the remaining bytes of
 > > the object."
 > 
 > We agree on this.  Now: what's different between "signed char" and "jbyte"?
 > Can they actually be distinct on some platform?

Sure.  That's the question, really: whether on all platforms a jbyte
is necessarily a character type.  It isn't descibed as one on the JNI
spec, so it may or may not be.  On existing platforms it probably is,
but on those platforms a pointer will always fit into a long.

It all depends on how jbyte is defined: it can either be a signed
character type or not.  I'm suggesting that we should not depend on
that.

Andrew.



From MAILER-DAEMON Tue Apr 06 05:19:40 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAmk4-0008H7-44
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 05:19:36 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAmk1-0008Fu-8w
	for classpath@gnu.org; Tue, 06 Apr 2004 05:19:33 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAmjT-0007wU-M2
	for classpath@gnu.org; Tue, 06 Apr 2004 05:19:31 -0400
Received: from [62.253.162.46] (helo=mta06-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAmjS-0007uz-SB
	for classpath@gnu.org; Tue, 06 Apr 2004 05:18:59 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta06-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040406091802.CKHN4667.mta06-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Tue, 6 Apr 2004 10:18:02 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i369HrIi032344; Tue, 6 Apr 2004 10:17:54 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i369HqaV032340;
	Tue, 6 Apr 2004 10:17:52 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16498.30144.189924.141228@cuddles.cambridge.redhat.com>
Date: Tue, 6 Apr 2004 10:17:52 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <4071E9BA.6080504@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca> <4071E9BA.6080504@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 09:19:34 -0000

Etienne Gagnon writes:
 > I should have compiled with -pedantic, of course...  I've included a few fixes
 > in the attachment.
 > 
 > >> malloc() returns a char*, not a jbyte*.
 > 
 >         [#1] byte
 >         addressable  unit  of  data storage large enough to hold any
 >         member  of  the  basic  character  set  of   the   execution
 >         environment
 > 
 >         [#2]  NOTE 1 It  is  possible to express the address of each
 >         individual byte of an object uniquely.
 > 
 >         [#3] NOTE 2 A byte is composed of a contiguous  sequence  of
 >         bits,  the  number  of which is implementation-defined.  The
 >         least significant bit is called the low-order bit; the  most
 >         significant bit is called the high-order bit.
 > 
 >         3.5
 >         [#1] character
 >         bit representation that fits in a byte                       *
 > 
 > 
 > Do we actually have to deal with platforms that have non 8-bit chars?

Maybe, but that's not the only thing.  It's possible to define jbyte
so that it is an 8 bit signed value but not a character type, and JNI
does not forbid this.  I suspect that all the platforms we use define
jbyte to be a character type, but I can see no overpowering reason to
introduce a dependency on that.

 > I guess quite a few other things/algorithms in the class library would
 > break if it is so...

Perhaps it's time to fix them, then.

 > It's fine to be pedantic, but up to a point...

That depends on what you mean by pedantry.  Both issues are in a sense
pedantic: the 128-bit pointer type and the non-character jbyte type.

Andrew.



From MAILER-DAEMON Tue Apr 06 05:23:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAmnb-0001Ap-5A
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 05:23:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAmnZ-0001AJ-1w
	for classpath@gnu.org; Tue, 06 Apr 2004 05:23:13 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAmn2-00011w-8D
	for classpath@gnu.org; Tue, 06 Apr 2004 05:23:12 -0400
Received: from [62.253.162.42] (helo=mta02-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAmn1-00011k-W9
	for classpath@gnu.org; Tue, 06 Apr 2004 05:22:40 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta02-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040406092152.DFRM27528.mta02-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Tue, 6 Apr 2004 10:21:52 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i369LuIi032395; Tue, 6 Apr 2004 10:21:56 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i369LsJ3032391;
	Tue, 6 Apr 2004 10:21:54 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16498.30386.746859.521410@cuddles.cambridge.redhat.com>
Date: Tue, 6 Apr 2004 10:21:54 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <4071F761.8080603@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca> <4071E9BA.6080504@uqam.ca>
	<4071F761.8080603@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 09:23:13 -0000

Etienne Gagnon writes:
 > Etienne Gagnon wrote:
 > > FYI: The JNI specification guarantees that jbyte is an 8-bit signed value.
 > 
 > Hmmm...  Thinking about all this mess of "non-specified" C byte length...
 > 
 > Can JNI actually be implemented on a 16-bit per byte system?
 > Anybody has a reasonable answer?
 > 
 > To consider:
 >        5.2.4.2.1  Sizes of integer types <limits.h>
 > 
 >         [#1]  The  values  given below shall be replaced by constant
 >         expressions  suitable   for   use   in   #if   preprocessing
 >         directives...
 > ...
 >           -- number  of  bits for smallest object that is not a bit-
 >              field (byte)
 >              CHAR_BIT                         8
 > ...
 > 
 > So, what how would one define "jbyte" on a platform where CHAR_BIT is
 > defined as 16?  JNI depends on having such a type.

You'd have to do something non-ANS.  I suspect that compilers on
machines with non 8-bit bytes would define a byte type as an ANS
extension.

Andrew.



From MAILER-DAEMON Tue Apr 06 05:28:02 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAmsD-00032y-5N
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 05:28:01 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAms2-0002qy-7n
	for classpath@gnu.org; Tue, 06 Apr 2004 05:27:50 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAmrT-0002Md-S2
	for classpath@gnu.org; Tue, 06 Apr 2004 05:27:47 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAmrT-0002MX-LA
	for classpath@gnu.org; Tue, 06 Apr 2004 05:27:15 -0400
Received: from [62.253.162.46] (helo=mta06-svc.ntlworld.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAmp0-0002Ve-Sn
	for classpath@gnu.org; Tue, 06 Apr 2004 05:24:42 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta06-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040406092003.CPWO4667.mta06-svc.ntlworld.com@cuddles.cambridge.redhat.com>
	for <classpath@gnu.org>; Tue, 6 Apr 2004 10:20:03 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i369JhIi032365; Tue, 6 Apr 2004 10:19:43 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i369Jfga032361;
	Tue, 6 Apr 2004 10:19:41 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16498.30253.559805.692834@cuddles.cambridge.redhat.com>
Date: Tue, 6 Apr 2004 10:19:41 +0100
To: "David Holmes" <dholmes@dltech.com.au>
In-Reply-To: <NFBBKALFDCPFIDBNKAPCAEEGEAAA.dholmes@dltech.com.au>
References: <4071E9BA.6080504@uqam.ca>
	<NFBBKALFDCPFIDBNKAPCAEEGEAAA.dholmes@dltech.com.au>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 09:27:52 -0000

David Holmes writes:
 > Well if we're being pedantic and imprecise to boot ...
 > 
 > > >> malloc() returns a char*, not a jbyte*.
 > 
 > malloc() returns void* not char*. It hasn't returned char* since pre ANSI C.

True, yes.

 > Hence the pointer returned by malloc can be legally converted to any real
 > pointer type with clearly defined semantics.

 > Taking the address of a void* and pretending that it is the address of a
 > jbyte* is not legal. However, it is legal to convert between an int and a
 > pointer type and a pointer type and an int. If the address represented by
 > the int is incorrectly aligned for the pointer type then the result is
 > undefined. Otherwise the result is implementation specific. Hence you can
 > write legal but (by definition) non-portable code to do what you want.

No, because of aliasing rules.  You can't convert a pointer between
two types that are not character types and then dereference it.

Andrew.



From MAILER-DAEMON Tue Apr 06 10:39:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BArjF-0001nE-Hb
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 10:39:05 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BArjB-0001mM-VD
	for classpath@gnu.org; Tue, 06 Apr 2004 10:39:01 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAric-0001Tg-Ob
	for classpath@gnu.org; Tue, 06 Apr 2004 10:38:57 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAric-0001TI-8S
	for classpath@gnu.org; Tue, 06 Apr 2004 10:38:26 -0400
Received: from sp1n293en1.watson.ibm.com (sp1n293en1.watson.ibm.com
	[129.34.20.41])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i36EcPq50176 for <classpath@gnu.org>; Tue, 6 Apr 2004 10:38:25 -0400
Received: from watson.ibm.com (localhost [127.0.0.1])
	by sp1n293en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i36EcNr36086; Tue, 6 Apr 2004 10:38:24 -0400
Message-ID: <4072C0DA.5000801@watson.ibm.com>
Date: Tue, 06 Apr 2004 10:38:18 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en, it, eo, pt, gl, es-ec, es-us, es, fr, ast, el
MIME-Version: 1.0
To: classpath@gnu.org
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Configuration class and --enable-native-sync
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 14:39:03 -0000

I would like to be able to figure out whether Classpath was compiled 
with --enable-portable-native-sync or not.  There have been times (and 
will be again soon) when Jikes RVM has required this option in order 
to run some kinds of graphical apps properly.

We currently usually automatically download and build Classpath for 
the user.  The biggest reason for this (so I'm told) is that, in the 
past, some users had run into problems because they hadn't configured 
Classpath properly.

It would be good for the VM to be able to confirm that an 
already-build Classpath installation was configured with the 
appropriate options.

I was thinking that the easiest way to do this would be to add a 
boolean variable to the Configuration class.

Besides --enable-portable-native-sync, the other config flags whose 
values I'd want to check are:
	--enable-jni
	--enable-load-library
	
and possibly

	--enable-gtk-peer

Are there any thoughts on the best way to do this?


-- 
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm



From MAILER-DAEMON Tue Apr 06 11:10:13 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAsDN-0001HW-15
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 11:10:13 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAsDH-0001F4-HW
	for classpath@gnu.org; Tue, 06 Apr 2004 11:10:07 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAsCf-00010M-11
	for classpath@gnu.org; Tue, 06 Apr 2004 11:10:00 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BAsAt-0000Sx-0S
	for classpath@gnu.org; Tue, 06 Apr 2004 11:07:39 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id 751aa322_87da_11d8_88b9_00304811e8c8_24120;
	Tue, 06 Apr 2004 09:55:34 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i36F5rax000452; 
	Tue, 6 Apr 2004 10:05:54 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i36F5qqu000451;
	Tue, 6 Apr 2004 10:05:52 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404061505.i36F5qqu000451@arch20m.dellroad.org>
In-Reply-To: <4072C0DA.5000801@watson.ibm.com>
To: Steven Augart <augart@watson.ibm.com>
Date: Tue, 6 Apr 2004 10:05:52 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: classpath@gnu.org
Subject: Re: Configuration class and --enable-native-sync
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 15:10:09 -0000

Steven Augart wrote:
> Besides --enable-portable-native-sync, the other config flags whose 
> values I'd want to check are:
> 	--enable-jni
> 	--enable-load-library
> 	
> and possibly
> 
> 	--enable-gtk-peer
> 
> Are there any thoughts on the best way to do this?

How about including all the build options in the Configuration class?

    public class Configuration {
      public static final String BUILD_OPTIONS = {
	 "--enable-jni", "--enable-load-library", ...
      };
      ...
    }

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Tue Apr 06 13:16:07 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAuBC-0001uA-9R
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 13:16:06 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAuAw-0001WI-Ly
	for classpath@gnu.org; Tue, 06 Apr 2004 13:15:50 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAuAK-0000Q3-1R
	for classpath@gnu.org; Tue, 06 Apr 2004 13:15:44 -0400
Received: from [212.227.126.183] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAuAJ-0000Ob-JG
	for classpath@gnu.org; Tue, 06 Apr 2004 13:15:11 -0400
Received: from [212.227.126.160] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAuAG-0002On-00; Tue, 06 Apr 2004 19:15:08 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAuAG-0006q2-00; Tue, 06 Apr 2004 19:15:08 +0200
Message-ID: <4072E5A5.2010102@aicas.com>
Date: Tue, 06 Apr 2004 19:15:17 +0200
From: =?UTF-8?B?SW5nbyBQcsO2dGVs?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <40713EEC.1070205@aicas.com>
	<1081204672.11618.127.camel@tortoise.toronto.redhat.com>
In-Reply-To: <1081204672.11618.127.camel@tortoise.toronto.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.ColorModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 17:15:55 -0000



Thomas Fitzsimmons wrote:
> On Mon, 2004-04-05 at 07:11, Ingo PrÃ¶tel wrote:
> 
>>I suggest the following patch
>>
>>2004-04-05  Ingo Proetel <proetel@aicas.com>
>>
>>	* java/awt/image/ColorModel.java (getRGBdefault): Default ColorModel has 32 bit pixels not 8 bit 
>>pixels.
>>	(isCompatibleRaster): Added javadoc comment.
>>
>>ingo
> 
> 
> 
>>-  // Typically overridden
>>+  /**
>>+   * Checks if the given raster has a compatible data-layout
>>(SampleModel).
>>+   * @param raster The Raster to test.
>>+   * @return true if raster is compatible.
>>+   */ 
> 
> 
> This implementation is different from the description in Sun's
> javadocs.  Their default implementation is to throw an
> UnsupportedOperationException, since ColorModel is an abstract class. 
> Does the implementation here need to be moved into one of the derived
> classes?
> 
> 
>>   public boolean isCompatibleRaster(Raster raster)
>>   {
>>     SampleModel sampleModel = raster.getSampleModel();
> 
> 
> Tom
> 
Again one of the cases where I put something for convenience (the comment).
But looking at the doc this method should be changed. I will look into it.

ingo

-- 
Ingo PrÃ¶tel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany



From MAILER-DAEMON Tue Apr 06 13:29:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAuNo-0001JI-Jz
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 13:29:08 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAuNg-0001Gr-1a
	for classpath@gnu.org; Tue, 06 Apr 2004 13:29:00 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAuN9-00016o-Lb
	for classpath@gnu.org; Tue, 06 Apr 2004 13:28:58 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAuKt-0000Z0-0B
	for classpath@gnu.org; Tue, 06 Apr 2004 13:26:07 -0400
Received: from [212.227.126.185] (helo=moutng.kundenserver.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAu8a-0003oK-5l
	for classpath@gnu.org; Tue, 06 Apr 2004 13:13:24 -0400
Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BAu8U-0008WD-00; Tue, 06 Apr 2004 19:13:18 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BAu8U-00010v-00; Tue, 06 Apr 2004 19:13:18 +0200
Message-ID: <4072E537.1020604@aicas.com>
Date: Tue, 06 Apr 2004 19:13:27 +0200
From: =?UTF-8?B?SW5nbyBQcsO2dGVs?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <4071460B.3070303@aicas.com> <40717603.6010900@aicas.com>
	<1081205295.11618.135.camel@tortoise.toronto.redhat.com>
In-Reply-To: <1081205295.11618.135.camel@tortoise.toronto.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.Raster
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 17:29:06 -0000



Thomas Fitzsimmons wrote:
> On Mon, 2004-04-05 at 11:06, Ingo PrÃ¶tel wrote:
> 
>>Note new attachment.
>>
>>Ingo PrÃ¶tel wrote:
>>
>>>I suggest the following patch
>>>2004-04-05  Ingo Proetel  <proetel@aicas.com>
>>>
>>>    * java/awt/image/Raster.java (toString): Added method.
>>>
>>>ingo
>>>
>>>
> 
> 
> +  
> +  /**
> +   * Create a String representing the stat of this Raster.
>                                        ^
>                                        state?
> 
> +   * @return A String representing the stat of this Raster.
> +   * @see java.lang.Object#toString()
> +   */
> +  public String toString()
> +  {
> +    StringBuffer result = new StringBuffer();
> +    
> +    result.append(getClass().getName());
> +    result.append("[(");
> +    result.append(minX).append(",").append(minY).append("), ");
> +    result.append(width).append(" x ").append(height).append(",");
> +    result.append(sampleModel).append(",");
> +    result.append(dataBuffer);
> +    result.append("]");
> +    
> 
> Is this result in the same format as the result produced by Sun's
> Raster.toString? 
> 
> Tom
> 
Actually, I don't know. The doc says Raster does not overwrite the toString method. So I guess it 
looks different. I just found it helpful to debug.

-- 
Ingo PrÃ¶tel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany



From MAILER-DAEMON Tue Apr 06 13:49:44 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAuhj-0005Zh-QE
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 13:49:43 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAuhg-0005Yi-NY
	for classpath@gnu.org; Tue, 06 Apr 2004 13:49:40 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAuhI-0005JB-W0
	for classpath@gnu.org; Tue, 06 Apr 2004 13:49:35 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAuhH-0005I6-Ke
	for classpath@gnu.org; Tue, 06 Apr 2004 13:49:15 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i36Hn95D005852;
	Tue, 6 Apr 2004 13:49:09 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i36Hn9j20900; 
	Tue, 6 Apr 2004 13:49:09 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i36Hn8e1016874; Tue, 6 Apr 2004 13:49:08 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <4072E537.1020604@aicas.com>
References: <4071460B.3070303@aicas.com>  <40717603.6010900@aicas.com>
	<1081205295.11618.135.camel@tortoise.toronto.redhat.com>
	<4072E537.1020604@aicas.com>
Content-Type: text/plain; charset=UTF-8
Message-Id: <1081273748.11618.142.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 06 Apr 2004 13:49:08 -0400
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	i36Hn95D005852
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.Raster
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 17:49:41 -0000

On Tue, 2004-04-06 at 13:13, Ingo Pr=C3=B6tel wrote:
> Thomas Fitzsimmons wrote:
> > On Mon, 2004-04-05 at 11:06, Ingo Pr=C3=B6tel wrote:
> >=20
> >>Note new attachment.
> >>
> >>Ingo Pr=C3=B6tel wrote:
> >>
> >>>I suggest the following patch
> >>>2004-04-05  Ingo Proetel  <proetel@aicas.com>
> >>>
> >>>    * java/awt/image/Raster.java (toString): Added method.
> >>>
> >>>ingo
> >>>
> >>>
> >=20
> >=20
> > + =20
> > +  /**
> > +   * Create a String representing the stat of this Raster.
> >                                        ^
> >                                        state?
> >=20
> > +   * @return A String representing the stat of this Raster.
> > +   * @see java.lang.Object#toString()
> > +   */
> > +  public String toString()
> > +  {
> > +    StringBuffer result =3D new StringBuffer();
> > +   =20
> > +    result.append(getClass().getName());
> > +    result.append("[(");
> > +    result.append(minX).append(",").append(minY).append("), ");
> > +    result.append(width).append(" x ").append(height).append(",");
> > +    result.append(sampleModel).append(",");
> > +    result.append(dataBuffer);
> > +    result.append("]");
> > +   =20
> >=20
> > Is this result in the same format as the result produced by Sun's
> > Raster.toString?=20
> >=20
> > Tom
> >=20
> Actually, I don't know. The doc says Raster does not overwrite the toSt=
ring method. So I guess it=20
> looks different. I just found it helpful to debug.

OK.  We may want to change it later to match Sun's output for
mauve/testing purposes, but for now this is fine.

Tom





From MAILER-DAEMON Tue Apr 06 14:32:44 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAvNM-0001mE-F3
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 14:32:44 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAvNJ-0001lG-Ok
	for classpath@gnu.org; Tue, 06 Apr 2004 14:32:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAvMn-0001el-H0
	for classpath@gnu.org; Tue, 06 Apr 2004 14:32:40 -0400
Received: from [62.253.162.48] (helo=mta08-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAvMn-0001cj-8I
	for classpath@gnu.org; Tue, 06 Apr 2004 14:32:09 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta08-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040406183207.FSJC10788.mta08-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Tue, 6 Apr 2004 19:32:07 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i36IVxIi027565; Tue, 6 Apr 2004 19:31:59 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i36IVvVd027561;
	Tue, 6 Apr 2004 19:31:57 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16498.63389.200004.130504@cuddles.cambridge.redhat.com>
Date: Tue, 6 Apr 2004 19:31:57 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <4071E9BA.6080504@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca> <4071E9BA.6080504@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 18:32:42 -0000

Etienne Gagnon writes:
 > 
 > Do we actually have to deal with platforms that have non 8-bit chars?
 > I guess quite a few other things/algorithms in the class library would
 > break if it is so...
 > 
 > It's fine to be pedantic, but up to a point...
 > 
 > FYI: The JNI specification guarantees that jbyte is an 8-bit signed value.

Yes, but it's not a question of whether the type jbyte is the same
size as a character type, but whether it is treated in the same way as
a character by the compiler.

I asked the question on the gcc mailing list.  (BTW: Alias set zero is
the set of types that may alias every other type.  In ISO C, character
types are in alias set zero.)

---------------------------------------------------------------------------
From: Richard Henderson <rth@redhat.com>
To: Andrew Haley <aph@redhat.com>
Cc: gcc@gcc.gnu.org
Subject: Re: Byte types and aliasing
Date: Tue, 6 Apr 2004 11:20:09 -0700

On Tue, Apr 06, 2004 at 01:27:55PM +0100, Andrew Haley wrote:
> Is a type of mode(byte) guaranteed to be in alias set zero?

No.  A language can do whatever they want.

---------------------------------------------------------------------------

By this reading, I take it that a JNI implementor could define jbyte
not to be a character type.

Andrew.



From MAILER-DAEMON Tue Apr 06 15:58:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAwio-00015I-UF
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 15:58:58 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAwic-00010R-Au
	for classpath@gnu.org; Tue, 06 Apr 2004 15:58:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAwi5-0000on-Oh
	for classpath@gnu.org; Tue, 06 Apr 2004 15:58:44 -0400
Received: from [213.228.0.44] (helo=postfix3-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAwi5-0000ND-0M
	for classpath@gnu.org; Tue, 06 Apr 2004 15:58:13 -0400
Received: from free.fr (cachan-3-82-66-125-112.fbx.proxad.net [82.66.125.112])
	by postfix3-1.free.fr (Postfix) with ESMTP
	id 05940C40BA; Tue,  6 Apr 2004 21:56:47 +0200 (CEST)
Message-ID: <40730B7C.504@free.fr>
Date: Tue, 06 Apr 2004 21:56:44 +0200
From: Guilhem Lavaux <guilhem.lavaux@free.fr>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <40633EE9.9040103@kaffe.org>	
	<1080489299.17922.11.camel@elsschot.wildebeest.org>	
	<406DC47B.3040703@kaffe.org>
	<1081101664.7548.158.camel@elsschot.wildebeest.org>
In-Reply-To: <1081101664.7548.158.camel@elsschot.wildebeest.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig61A24BAB582AE4C23FB192CE"
Cc: Classpath List <classpath@gnu.org>
Subject: Re: Object serialization and final fields
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 19:58:47 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig61A24BAB582AE4C23FB192CE
Content-Type: multipart/mixed; boundary="------------050609050705010900000106"

This is a multi-part message in MIME format.
--------------050609050705010900000106
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Mark Wielaard wrote:
> Hi Guilhem,
> 
> On Fri, 2004-04-02 at 21:52, Guilhem Lavaux wrote:
> 
>>Here is the real patch for object serialization. I've added new static 
>>methods to VMObjectStreamClass and changed the methods called in 
>>ObjectStreamField accordingly. Note that we need to check all exceptions 
>>now as the native functions may fail for some other obscure reasons.
>>
>>2004-04-02  Guilhem Lavaux <guilhem@kaffe.org>
>>
>>	* java/io/ObjectStreamField.java
>>	(setBooleanField, setCharField, setByteField, setShortField,
>>	setIntField, setLongField, setFloatField, setDoubleField): Use
>>	native methods directly to be able to set final fields.
>>
>>	* vm/reference/java/io/VMObjectStreamClass.java
>>	(setBooleanNative, setCharNative, setByteNative, setShortNative,
>>	setIntNative, setLongNative, setFloatNative, setDoubleNative):
>>	New methods for serialization to be able to set final fields.
>>
>>	* native/jni/java-io/java_io_VMObjectStreamClass.c:
>>	Implemented new native methods of java.io.VMObjectStreamClass
>>	accordingly.
>>
>>P.S.: If nobody is against, I'll check it in on sunday.
> 
> 
> This looks very nice. Thanks.
> Some nitpicks:
> 
> - You forgot the addition of setObjectNative() in the ChangeLog entry.

Ok.

> - You should regenerate include/java_io_VMObjectStreamClass.h
>   This is automatically done when configuring with
>   --enable-regen-headers. But should be mentioned in the
>   ChangeLog/patch.

Ok.

> - Please chain exceptions. Don't just get the message, use initCause().
> - Also catching Exception will miss Error (and subclasses) so you might
>   want to catch Throwable.

Ok, I'm modifying this.

> - But isn't it simpler to let the setXnative() methods throw
>   InternalError() directly (or maybe VirtualMachineError or
>   IllegalArgumentException which seem more appropriate).
> - Then also don't declare the setXNative() methods throws
>   IllegalAccessException. Some are declared as such and some not.
>   But it seems this is the only exception that should never be thrown.

It was a mistake. First I wanted to make them throw nothing because I 
don't really know what may happen in the VM. At some point JNI calls may 
raise any type of exceptions. Maybe we may catch all exceptions directly 
  in the native code and only throw InternalError.



> 
> Could you also add a short notice to the NEWS file about this VM
> interface change. You should at least mention that the standard
> implementation assumes that the JNI setXField() methods can be used on
> final fields.
> 

Ok.

The mauve testcase is in CVS (added into 
gnu/testlet/java/io/ObjectInputOutput/Test).
Here is the new patch and the new changelog entry (hoping everything is 
alright now):

2004-04-06  Guilhem Lavaux <guilhem@kaffe.org>

	* java/io/ObjectStreamField.java
	(setBooleanField, setCharField, setByteField, setShortField,
	setIntField, setLongField, setFloatField, setDoubleField,
	setObjectField): Use native methods directly to be able to set
	final fields.

	* vm/reference/java/io/VMObjectStreamClass.java
	(setBooleanNative, setCharNative, setByteNative, setShortNative,
	setIntNative, setLongNative, setFloatNative, setDoubleNative,
	setObjectNative): New methods for serialization to be able to
	set final fields.

	* native/jni/java-io/java_io_VMObjectStreamClass.c:
	Implemented new native methods of java.io.VMObjectStreamClass
	accordingly.

	* include/java_io_VMObjectStreamClass.h: Regenerated.

	* NEWS: Added a warning clause about the VM Interface change.

Cheers,

Guilhem.

--------------050609050705010900000106
Content-Type: text/plain;
 name="serial_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="serial_patch"

Index: NEWS
===================================================================
RCS file: /cvsroot/classpath/classpath/NEWS,v
retrieving revision 1.36
diff -u -b -B -r1.36 NEWS
--- NEWS	13 Mar 2004 02:18:39 -0000	1.36
+++ NEWS	6 Apr 2004 19:55:20 -0000
@@ -1,3 +1,11 @@
+New in release 0.09
+
+VM Interface changes:
+
+* GNU Classpath now assumes that JNI calls SetXField can modify final
+fields. This was previously used silently for System.in/out/err and should
+be considered as a feature now. 
+
 New in release 0.08 (2004/12/03)
 
 * java.util.regexp implementation through gnu.regexp wrappers.
Index: native/jni/java-io/java_io_VMObjectStreamClass.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-io/java_io_VMObjectStreamClass.c,v
retrieving revision 1.3
diff -u -b -B -r1.3 java_io_VMObjectStreamClass.c
--- native/jni/java-io/java_io_VMObjectStreamClass.c	29 Mar 2004 07:07:27 -0000	1.3
+++ native/jni/java-io/java_io_VMObjectStreamClass.c	6 Apr 2004 19:55:20 -0000
@@ -59,3 +59,238 @@
     }
   return JNI_TRUE;
 }
+
+static void throwInternalError(JNIEnv *env)
+{
+  jclass internalErrorClass;
+  jthrowable previousException, newException;
+  jmethodID initException, getMessageID, initCauseID;
+  jstring message;
+
+  internalErrorClass = (*env)->FindClass(env, "java/lang/InternalError");
+  previousException = (*env)->ExceptionOccurred(env);
+
+  if (previousException == NULL)
+    {
+      (*env)->ThrowNew(env, internalErrorClass, "Unknown error raised by the VM");
+      return;
+    }
+  
+  initException = (*env)->GetMethodID
+    (env, internalErrorClass, "<init>", "(Ljava/lang/String;)V");
+  getMessageID = (*env)->GetMethodID
+    (env, (*env)->GetObjectClass(env, previousException),
+     "getMessage", "()Ljava/lang/String;");
+  initCauseID = (*env)->GetMethodID
+    (env, internalErrorClass, "initCause", "(Ljava/lang/Throwable;)V");
+
+  message = (*env)->CallObjectMethod(env, previousException,
+				     getMessageID);
+
+  newException = (*env)->NewObject(env, internalErrorClass, initException,
+				   message);
+  (*env)->CallVoidMethod(env, newException, initCauseID,
+			 previousException);
+
+  (*env)->ExceptionClear(env);
+  (*env)->Throw(env, newException);
+}
+
+static jfieldID getFieldReference(JNIEnv *env, jobject field, 
+				  jobject object, const char *type)
+{
+  jclass fieldClass;
+  jclass objectClass;
+  jfieldID fid;
+  const jbyte *field_name;
+  jmethodID mid;
+  jstring name;
+
+  fieldClass = (*env)->GetObjectClass(env, field);
+
+  mid = (*env)->GetMethodID(env, fieldClass, "getName", "()Ljava/lang/String;");
+  if (mid == NULL || (*env)->ExceptionOccurred(env) != NULL)
+    {
+      throwInternalError(env);
+      return NULL;
+    }
+
+  name = (*env)->CallObjectMethod(env, field, mid);
+  field_name = (*env)->GetStringUTFChars(env, name, NULL);
+  
+  objectClass = (*env)->GetObjectClass(env, object);
+  fid = (*env)->GetFieldID(env, objectClass, field_name, type);
+  if (fid == NULL)
+    {
+      throwInternalError(env);
+      return NULL;
+    }
+  (*env)->ReleaseStringUTFChars(env, name, field_name);
+  
+  return fid;
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setBooleanNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;Z)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setBooleanNative( JNIEnv * env,
+						   jclass vmosklass,
+						   jobject field,
+						   jobject object,
+						   jboolean value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "Z");
+
+  if (fid != NULL)
+    (*env)->SetBooleanField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setCharNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;C)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setCharNative( JNIEnv * env,
+						jclass vmosklass,
+						jobject field,
+						jobject object,
+						jchar value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "C");
+
+  if (fid != NULL)
+    (*env)->SetCharField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setByteNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;B)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setByteNative( JNIEnv * env,
+						jclass vmosklass,
+						jobject field,
+						jobject object,
+						jbyte value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "B");
+
+  if (fid != NULL)
+    (*env)->SetByteField(env, object, fid, value);
+}
+
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setShortNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;S)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setShortNative( JNIEnv * env,
+						 jclass vmosklass,
+						 jobject field,
+						 jobject object,
+						 jshort value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "S");
+
+  if (fid != NULL)
+    (*env)->SetShortField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setIntNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;I)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setIntNative( JNIEnv * env,
+					       jclass vmosklass,
+					       jobject field,
+					       jobject object,
+					       jint value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "I");
+
+  if (fid != NULL)
+    (*env)->SetIntField(env, object, fid, value);
+}
+
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setLongNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;J)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setLongNative( JNIEnv * env,
+					       jclass vmosklass,
+					       jobject field,
+					       jobject object,
+					       jlong value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "J");
+
+  if (fid != NULL)
+    (*env)->SetLongField(env, object, fid, value);
+}
+
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setFloatNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;F)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setFloatNative( JNIEnv * env,
+						 jclass vmosklass,
+						 jobject field,
+						 jobject object,
+						 jfloat value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "F");
+
+  if (fid != NULL)
+    (*env)->SetFloatField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setDoubleNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;D)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setDoubleNative( JNIEnv * env,
+						 jclass vmosklass,
+						 jobject field,
+						 jobject object,
+						 jdouble value )
+{
+  jfieldID fid = getFieldReference (env, field, object, "D");
+
+  if (fid != NULL)
+    (*env)->SetDoubleField(env, object, fid, value);
+}
+
+/*
+ * Class:     java_io_VMObjectOutputStream
+ * Method:    setObjectNative
+ * Signature: (Ljava/lang/reflect/Field;Ljava/lang/Object;Ljava/lang/Object;)V
+ */
+JNIEXPORT void JNICALL
+Java_java_io_VMObjectStreamClass_setObjectNative( JNIEnv * env,
+						 jclass vmosklass,
+						 jobject field,
+						 jobject object,
+						 jobject value )
+{
+  jfieldID fid = getFieldReference (env, field, object, NULL);
+
+  if (fid != NULL)
+    (*env)->SetObjectField(env, object, fid, value);
+}
Index: vm/reference/java/io/VMObjectStreamClass.java
===================================================================
RCS file: /cvsroot/classpath/classpath/vm/reference/java/io/VMObjectStreamClass.java,v
retrieving revision 1.1
diff -u -b -B -r1.1 VMObjectStreamClass.java
--- vm/reference/java/io/VMObjectStreamClass.java	17 Jan 2003 16:45:29 -0000	1.1
+++ vm/reference/java/io/VMObjectStreamClass.java	6 Apr 2004 19:55:20 -0000
@@ -38,7 +38,7 @@
 
 package java.io;
 
-import java.lang.reflect.Method;
+import java.lang.reflect.Field;
 
 final class VMObjectStreamClass
 {
@@ -47,4 +47,114 @@
     * (a.k.a. <clinit>).
     */
   static native boolean hasClassInitializer (Class clazz);
+
+  /**
+   * Sets the value of the specified field. This method handles "double".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setDoubleNative(Field field, Object obj, double val)
+    throws InternalError;
+
+  /**
+   * Sets the value of the specified field. This method handles "float".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setFloatNative(Field field, Object obj, float val)
+    throws InternalError;
+
+  /**
+   * Sets the value of the specified field. This method handles "long".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setLongNative(Field field, Object obj, long val)
+    throws InternalError;
+  
+  /**
+   * Sets the value of the specified field. This method handles "int".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setIntNative(Field field, Object obj, int val) 
+    throws InternalError;
+  
+  /**
+   * Sets the value of the specified field. This method handles "short".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setShortNative(Field field, Object obj, short val) 
+    throws InternalError;
+
+  /**
+   * Sets the value of the specified field. This method handles "char".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setCharNative(Field field, Object obj, char val) 
+    throws InternalError;
+
+  /**
+   * Sets the value of the specified field. This method handles "byte".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setByteNative(Field field, Object obj, byte val) 
+    throws InternalError;
+
+  /**
+   * Sets the value of the specified field. This method handles "boolean".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setBooleanNative(Field field, Object obj, boolean val) 
+    throws InternalError;
+
+  /**
+   * Sets the value of the specified field. This method handles "object".
+   * Warning ! The types are not truely checked here and final values may be
+   * assigned.
+   *
+   * @param field Field to set the value.
+   * @param obj Instance which will have its field set.
+   * @param val Value to put in the field.
+   */
+  static native void setObjectNative(Field field, Object obj, Object val) 
+    throws InternalError;
+  
 }
+
Index: java/io/ObjectStreamField.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectStreamField.java,v
retrieving revision 1.14
diff -u -b -B -r1.14 ObjectStreamField.java
--- java/io/ObjectStreamField.java	26 Feb 2004 07:53:15 -0000	1.14
+++ java/io/ObjectStreamField.java	6 Apr 2004 19:55:20 -0000
@@ -38,9 +38,9 @@
 
 package java.io;
 
+import gnu.java.lang.reflect.TypeSignature;
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
-import gnu.java.lang.reflect.TypeSignature;
 import java.security.AccessController;
 import java.security.PrivilegedAction;
 
@@ -64,7 +64,6 @@
   {
     this (field.getName(), field.getType());
     this.field = field;
-    toset = !Modifier.isFinal(field.getModifiers());
   }
 
   /**
@@ -355,109 +354,46 @@
 
   final void setBooleanField(Object obj, boolean val)
   {
-    try
-      {
-	field.setBoolean(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setBooleanNative(field, obj, val);  
   }
   
   final void setByteField(Object obj, byte val)
   {
-    try
-      {
-	field.setByte(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setByteNative(field, obj, val);
   }
   
   final void setCharField(Object obj, char val)
   {
-    try
-      {
-	field.setChar(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setCharNative(field, obj, val);
   }
   
   final void setShortField(Object obj, short val)
   {
-    try
-      {
-	field.setShort(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setShortNative(field, obj, val);
   }
   
   final void setIntField(Object obj, int val)
   {
-    try
-      {
-	field.setInt(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setIntNative(field, obj, val);
   }
   
   final void setLongField(Object obj, long val)
   {
-    try
-      {
-	field.setLong(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setLongNative(field, obj, val);
   }
   
   final void setFloatField(Object obj, float val)
   {
-    try
-      {
-	field.setFloat(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setFloatNative(field, obj, val);
   }
   
   final void setDoubleField(Object obj, double val)
   {
-    try
-      {
-	field.setDouble(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setDoubleNative(field, obj, val);
   }
   
   final void setObjectField(Object obj, Object val)
   { 
-    try
-      {
-	field.set(obj, val);
-      }
-    catch(IllegalAccessException x)
-      {
-	throw new InternalError(x.getMessage());
-      }
+    VMObjectStreamClass.setObjectNative(field, obj, val);
   }
 }

--------------050609050705010900000106--

--------------enig61A24BAB582AE4C23FB192CE
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAcwt+WRk4qbNiTwgRApwSAJ0b3rqihRXcnHCD2V7bjx6yRnh0/gCfT5KS
tHpuSRCJbRk2G5S/b8bHAdU=
=Reh3
-----END PGP SIGNATURE-----

--------------enig61A24BAB582AE4C23FB192CE--




From MAILER-DAEMON Tue Apr 06 16:34:30 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAxHB-0004oE-St
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 16:34:29 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAxH9-0004na-7T
	for classpath@gnu.org; Tue, 06 Apr 2004 16:34:27 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAxDw-0004Ju-Jg
	for classpath@gnu.org; Tue, 06 Apr 2004 16:31:39 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAxBJ-0003UL-FM
	for classpath@gnu.org; Tue, 06 Apr 2004 16:28:25 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i36KKbLF001390;
	Tue, 6 Apr 2004 16:21:26 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040616224218200 ; Tue, 06 Apr 2004 16:22:42 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i36KHSOj023396; Tue, 6 Apr 2004 16:17:28 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAx0i-0004j1-Gx; Tue, 06 Apr 2004 16:17:28 -0400
Message-ID: <40731058.2060208@uqam.ca>
Date: Tue, 06 Apr 2004 16:17:28 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>	<4071E699.8020809@uqam.ca>	<4071E9BA.6080504@uqam.ca>
	<16498.30144.189924.141228@cuddles.cambridge.redhat.com>
In-Reply-To: <16498.30144.189924.141228@cuddles.cambridge.redhat.com>
Content-Type: multipart/mixed; boundary="------------030104090801010706040806"
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 20:34:27 -0000

This is a multi-part message in MIME format.
--------------030104090801010706040806
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Andrew Haley wrote:
> Maybe, but that's not the only thing.  It's possible to define jbyte
> so that it is an 8 bit signed value but not a character type, and JNI
> does not forbid this.  I suspect that all the platforms we use define
> jbyte to be a character type, but I can see no overpowering reason to
> introduce a dependency on that.

"jbyte" must have a single platform-specific definition, as all JVMs on that
platform should be able to execute the same JNI library code (no recompilation
required).  I would argue that if a char type has 8 bits on a platform, there
is a strong case for it to be defined as "typedef signed char jbyte", and I would
gues VM implementors would be veery unhappy if Sum (or any other) decided to
define jbyte otherwise on that platform.

BUT....  I agree, it could be false on some system.  So, assuming the worst-case
scenario, I have attached an updated version of my byte array proposal that
is, as far as I can tell, robust across all possible platforms.

It contains 2 utility "inline" functions: wrap and unwrap.  I provide 2 versions
of each, one version for systems where jbyte == signed char, and one version
for systems where jbyte != signed char.  A test function, ideal for use in
an autoconf macro, is provided that issues a warning when jbyte != signed char.

So, Andrew, does this version pass the portability test?

I would really like to see the native counterpart of your opaque types and
compare the "theoretical" performance of it relative to the byte array
proposal.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/

--------------030104090801010706040806
Content-Type: text/x-c-header;
 name="JNITest.h"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="JNITest.h"

/* Put in the public domain by Etienne M. Gagnon <gagnon.etienne_m@uqam.ca> */

/* DO NOT EDIT THIS FILE - it is machine generated */
#include <jni.h>
/* Header for class JNITest */

#ifndef _Included_JNITest
#define _Included_JNITest
#ifdef __cplusplus
extern "C"
{
#endif
/*
 * Class:     JNITest
 * Method:    getPtr
 * Signature: ()[B
 */
  JNIEXPORT jbyteArray JNICALL Java_JNITest_getPtr (JNIEnv *, jclass);

/*
 * Class:     JNITest
 * Method:    testPtr
 * Signature: ([B)V
 */
  JNIEXPORT void JNICALL Java_JNITest_testPtr (JNIEnv *, jclass, jbyteArray);

#ifdef __cplusplus
}
#endif
#endif

--------------030104090801010706040806
Content-Type: text/x-java;
 name="JNITest.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="JNITest.java"

/* Put in the public domain by Etienne M. Gagnon <gagnon.etienne_m@uqam.ca> */

public class JNITest
{
    static
    {
	System.loadLibrary("test");
    }

    public static void main(String[] args)
    {
	byte[] nativePtr = getPtr();
	testPtr(nativePtr);
    }

    private static native byte[] getPtr();
    private static native void testPtr(byte[] nativPtr);
}

--------------030104090801010706040806
Content-Type: text/x-csrc;
 name="libtest.c"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="libtest.c"

/* Put in the public domain by Etienne M. Gagnon <gagnon.etienne_m@uqam.ca> */

#include <jni.h>
#include <stdio.h>
#include <stdlib.h>

#include "wrap.c"

/*
 * Class:     JNITest
 * Method:    getPtr
 * Signature: ()[B
 */
JNIEXPORT jbyteArray JNICALL
Java_JNITest_getPtr (JNIEnv *env, jclass class)
{
  int *int_ptr;

  int_ptr = (int *) malloc (sizeof (int));
  *int_ptr = 0x47;

  return wrap (env, int_ptr);
}

/*
 * Class:     JNITest
 * Method:    testPtr
 * Signature: ([B)V
 */
JNIEXPORT void JNICALL
Java_JNITest_testPtr (JNIEnv *env, jclass class, jbyteArray nativePtr)
{
  int *int_ptr = unwrap (env, nativePtr);

  printf ("value = %x\n", *int_ptr);
}

--------------030104090801010706040806
Content-Type: text/x-csrc;
 name="wrap.c"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="wrap.c"

#include <jni.h>
#include <stdio.h>
#include <stddef.h>
#include <limits.h>

/* On platforms where jbyte != signed char, you must
 * define JBYTE_IS_NOT_SIGNED_CHAR. 
 *
 * See the "test" function below that causes compiler
 * warnings when jbyte != signed char to remind you
 * of defining JBYTE_IS_NOT_SIGNED_CHAR in such case.
 *
 * On most platforms, this shouldn't matter.
 */

/* Uncomment the following if necessary. */
/* #define JBYTE_IS_NOT_SIGNED_CHAR 1 */

#ifndef JBYTE_IS_NOT_SIGNED_CHAR


/* Assuming that jbyte == signed char */

/* test function (unused).  This function will cause a compiler
 * warning when jbyte != signed char */
static void
test ()
{
  jbyte *j = NULL;

  /*
   * IMPORTANT
   * =========
   *
   * If you get a warning for the assignment below, you *MUST* define
   * JBYTE_IS_NOT_UNSIGNED_CHAR.
   */
  signed char *k = j;

  /* just to get rid of compile warnings */
  j = k;
  test ();
}

/* ----------------------------------------------------------------
   wrap: wraps a pointer into a jbyteArray in order to store in into a
   Java object instance.
   ---------------------------------------------------------------- */

inline static jbyteArray
wrap (JNIEnv *env, void *ptr)
{
  jbyteArray nativePtr;

  nativePtr = (*env)->NewByteArray (env, (jint) sizeof (void *));

  if (nativePtr == NULL)	/* Exception raised */
    return NULL;

  (*env)->SetByteArrayRegion (env, nativePtr, 0, (jint) sizeof (void *),
			      (jbyte *) &ptr);

  return nativePtr;
}

/* ----------------------------------------------------------------
   unwrap: unwraps a pointer stored in a jbyteArray.
   ---------------------------------------------------------------- */

inline static void *
unwrap (JNIEnv *env, jbyteArray nativePtr)
{
  void *ptr;

  (*env)->GetByteArrayRegion (env, nativePtr, 0, (jint) sizeof (void *),
			      (jbyte *) &ptr);

  return ptr;
}


#else /* JBYTE_IS_NOT_SIGNED_CHAR */


/* Assuming that jbyte != signed char */

#define PTRDIFF_BIT (sizeof(ptrdiff_t) * CHAR_BIT)
#define BARRAY_SIZE ((PTRDIFF_BIT + 7) / 8)

/* ----------------------------------------------------------------
   wrap: wraps a pointer into a jbyteArray in order to store in into a
   Java object instance.
   ---------------------------------------------------------------- */

inline static jbyteArray
wrap (JNIEnv *env, void *ptr)
{
  jbyteArray nativePtr;
  jbyte bytes[BARRAY_SIZE];

  /* make a robust integer out of pointer value */
  ptrdiff_t value = (char *) ptr - (char *) 0;
  size_t i;

  for (i = 0; i < BARRAY_SIZE; i++)
    {
      bytes[i] = (value & 0x0ff);
      value >>= 8;
    }

  nativePtr = (*env)->NewByteArray (env, (jint) BARRAY_SIZE);

  if (nativePtr == NULL)	/* Exception raised */
    return NULL;

  (*env)->SetByteArrayRegion (env, nativePtr, 0, (jint) BARRAY_SIZE, bytes);

  return nativePtr;
}

/* ----------------------------------------------------------------
   unwrap: unwraps a pointer stored in a jbyteArray.
   ---------------------------------------------------------------- */

inline static void *
unwrap (JNIEnv *env, jbyteArray nativePtr)
{
  jbyte bytes[BARRAY_SIZE];
  ptrdiff_t value = 0;
  size_t i;
  void *ptr;

  (*env)->GetByteArrayRegion (env, nativePtr, 0, (jint) BARRAY_SIZE, bytes);


  for (i = BARRAY_SIZE; i > 0; i--)
    {
      value <<= 8;
      value |= (bytes[i - 1] & 0x0ff);
    }

  /* retrieve pointer from robust integer */
  ptr = value + (char *) 0;
  return ptr;
}

#endif /* JBYTE_IS_NOT_SIGNED_CHAR */

--------------030104090801010706040806--



From MAILER-DAEMON Tue Apr 06 17:00:01 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAxey-0001i9-Sa
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 16:59:04 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAxen-0001cR-D4
	for classpath@gnu.org; Tue, 06 Apr 2004 16:58:53 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAxe5-0001RG-2m
	for classpath@gnu.org; Tue, 06 Apr 2004 16:58:40 -0400
Received: from [141.45.4.9] (helo=blackhole.ipv6.fhtw-berlin.de)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAxdk-0001L4-4C
	for classpath@gnu.org; Tue, 06 Apr 2004 16:57:48 -0400
Received: from threejane.lichteblau.com ([141.45.32.5])
	by blackhole.ipv6.fhtw-berlin.de with smtp (Exim 3.31 #15)
	id 1BAxdf-000AXg-00
	for classpath@gnu.org; Tue, 06 Apr 2004 22:57:43 +0200
Received: (qmail 21245 invoked by uid 1000); 6 Apr 2004 20:57:44 -0000
From: "David Lichteblau" <dave@lichteblau.com>
Date: Tue, 6 Apr 2004 22:57:44 +0200
To: GNU Classpath <classpath@gnu.org>
Message-ID: <20040406205743.GA21097@lichteblau.com>
References: <200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca> <4071E9BA.6080504@uqam.ca>
	<16498.30144.189924.141228@cuddles.cambridge.redhat.com>
	<40731058.2060208@uqam.ca>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/"
Content-Disposition: inline
In-Reply-To: <40731058.2060208@uqam.ca>
User-Agent: Mutt/1.3.28i
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 20:59:00 -0000


--pWyiEgJYm5f9v55/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Quoting Etienne Gagnon (gagnon.etienne_m@uqam.ca):
> I would really like to see the native counterpart of your opaque types and
> compare the "theoretical" performance of it relative to the byte array
> proposal.

Sorry if I lost track of the discussion, but when the proposal of an
abstract class for virtual machine data came up, I thought that one of
the reasons for this boxing was the portability to virtual machines of
any kind.  A byte array approach would have performance and design
implications not for JNI-based implementations, but for more exotic VMs
which do not have any native pointers at all (IKVM?).

Also, is this still about the Class.vmData slot?  I note that the
proposed java.nio patch already uses a RawData class.


d.
--=20
Common Lisp is the Borg of programming languages
	-- Bill Clementson

--pWyiEgJYm5f9v55/
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAcxnGiGoiD4YyHUgRAkRdAJ9915Ms792f/tCTm6lXxGRN/0iYoACgk4Su
F62KcyRO0ziDnBvmxef1d0A=
=cY7k
-----END PGP SIGNATURE-----

--pWyiEgJYm5f9v55/--



From MAILER-DAEMON Tue Apr 06 17:07:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAxS7-0007FR-8m
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 16:45:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAxS0-0007Cm-DZ
	for classpath@gnu.org; Tue, 06 Apr 2004 16:45:40 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAxQi-0006qr-VL
	for classpath@gnu.org; Tue, 06 Apr 2004 16:44:52 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAxQi-0006qb-HW
	for classpath@gnu.org; Tue, 06 Apr 2004 16:44:20 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BAxJV-0005pW-VN
	for classpath@gnu.org; Tue, 06 Apr 2004 16:36:54 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i36KRNL5002516;
	Tue, 6 Apr 2004 16:27:43 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040616285918863 ; Tue, 06 Apr 2004 16:28:59 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i36KNKOj015477; Tue, 6 Apr 2004 16:23:20 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BAx6O-0004jS-7l; Tue, 06 Apr 2004 16:23:20 -0400
Message-ID: <407311B6.7040507@uqam.ca>
Date: Tue, 06 Apr 2004 16:23:18 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>	<4071E699.8020809@uqam.ca>
	<4071E9BA.6080504@uqam.ca>
	<16498.63389.200004.130504@cuddles.cambridge.redhat.com>
In-Reply-To: <16498.63389.200004.130504@cuddles.cambridge.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 20:45:43 -0000

Andrew Haley wrote:
> Yes, but it's not a question of whether the type jbyte is the same
> size as a character type, but whether it is treated in the same way as
> a character by the compiler.

Hi Andrew.  Please look carefully at my proposal (sent minutes ago),
and tell me if it still contains non-portable bits.  I provide in it
a piece of C code that will generate warnings if jbyte is not treated
as signed char by the compiler, if I am right.  [Look at the test()
function].

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Tue Apr 06 17:51:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAyU0-0002Rq-Cs
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 17:51:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAyTr-0002Qk-AD
	for classpath@gnu.org; Tue, 06 Apr 2004 17:51:39 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAyTI-0002Dk-UZ
	for classpath@gnu.org; Tue, 06 Apr 2004 17:51:37 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BAyTI-0002DH-Fp
	for classpath@gnu.org; Tue, 06 Apr 2004 17:51:04 -0400
Received: from sp1n294en1.watson.ibm.com (sp1n294en1.watson.ibm.com
	[129.34.20.40])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i36Lp2q105284; Tue, 6 Apr 2004 17:51:02 -0400
Received: from sp1n294en1.watson.ibm.com (localhost [127.0.0.1])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i36Lp1O41416; Tue, 6 Apr 2004 17:51:01 -0400
Received: from watson.ibm.com (bilbo.watson.ibm.com [9.2.32.197])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i36Lp1x26772; Tue, 6 Apr 2004 17:51:01 -0400
Message-ID: <40732645.3010906@watson.ibm.com>
Date: Tue, 06 Apr 2004 17:51:01 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en, it
MIME-Version: 1.0
To: Archie Cobbs <archie@dellroad.org>
References: <200404061505.i36F5qqu000451@arch20m.dellroad.org>
In-Reply-To: <200404061505.i36F5qqu000451@arch20m.dellroad.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: Configuration class and --enable-native-sync
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 21:51:40 -0000

Archie Cobbs wrote:
[...]
> How about including all the build options in the Configuration class?
> 
>     public class Configuration {
>       public static final String BUILD_OPTIONS = {
> 	 "--enable-jni", "--enable-load-library", ...
>       };
>       ...
>     }
Perhaps we could include even the build options that automatically had 
their default values set?  So, even if the user had not explicitly 
stated "--enable-jni", we would still include "--enable-jni", since 
it's the default?

I'm trying to guard against the defaults possibly changing.  If we 
were to, for example, one day make Classpath's default be 
--enable-portable-native-sync, I'd still want Jikes RVM to correctly 
read that the Classpath installation had that feature enabled.

--Steve


-- 
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm




From MAILER-DAEMON Tue Apr 06 18:10:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAylt-0008SP-U8
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 18:10:17 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAylg-0008DT-Lu
	for classpath@gnu.org; Tue, 06 Apr 2004 18:10:04 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAyjs-0007Qe-9u
	for classpath@gnu.org; Tue, 06 Apr 2004 18:08:43 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BAyZQ-000487-QA
	for classpath@gnu.org; Tue, 06 Apr 2004 17:57:24 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id ce2f2044_8813_11d8_8521_00304811e8c8_28999;
	Tue, 06 Apr 2004 16:46:05 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i36LuPax002392; 
	Tue, 6 Apr 2004 16:56:25 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i36LuPdL002391;
	Tue, 6 Apr 2004 16:56:25 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404062156.i36LuPdL002391@arch20m.dellroad.org>
In-Reply-To: <40732645.3010906@watson.ibm.com>
To: Steven Augart <augart@watson.ibm.com>
Date: Tue, 6 Apr 2004 16:56:25 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: classpath@gnu.org
Subject: Re: Configuration class and --enable-native-sync
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 22:10:15 -0000

Steven Augart wrote:
> > How about including all the build options in the Configuration class?
> > 
> >     public class Configuration {
> >       public static final String BUILD_OPTIONS = {
> > 	 "--enable-jni", "--enable-load-library", ...
> >       };
> >       ...
> >     }
> Perhaps we could include even the build options that automatically had 
> their default values set?  So, even if the user had not explicitly 
> stated "--enable-jni", we would still include "--enable-jni", since 
> it's the default?
> 
> I'm trying to guard against the defaults possibly changing.  If we 
> were to, for example, one day make Classpath's default be 
> --enable-portable-native-sync, I'd still want Jikes RVM to correctly 
> read that the Classpath installation had that feature enabled.

Agreed.. in general more info is better. E.g., why not also throw in
the output of "uname -a", the classpath version, etc.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Tue Apr 06 18:59:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAzXB-0003e4-9w
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 18:59:09 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAzX8-0003cz-9D
	for classpath@gnu.org; Tue, 06 Apr 2004 18:59:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAzWc-0003SU-Hz
	for classpath@gnu.org; Tue, 06 Apr 2004 18:59:05 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAzWX-0003Pw-Jy
	for classpath@gnu.org; Tue, 06 Apr 2004 18:58:29 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i36MwMWB017722;
	Tue, 6 Apr 2004 18:58:23 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i36MwMj23058; 
	Tue, 6 Apr 2004 18:58:22 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i36MwLe1028016; Tue, 6 Apr 2004 18:58:21 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <40714B20.4050602@aicas.com>
References: <40714B20.4050602@aicas.com>
Content-Type: text/plain; charset=UTF-8
Message-Id: <1081292301.11618.191.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 06 Apr 2004 18:58:21 -0400
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	i36MwMWB017722
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.SinglePixelPackedSampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 22:59:07 -0000

On Mon, 2004-04-05 at 08:03, Ingo Pr=C3=B6tel wrote:
> I suggest the following patch
>=20
> 2004-04-05  Ingo Proetel  <proetel@aicas.com>
>=20
> 	* java/awt/image/SinglePixelPackedSampleModel.java (getDataElements): =
New method.
> 	(setDataElements): New method.
> 	(setPixels): New method.
> 	(toString): New method.
>=20
> ingo

This looks great.

Thanks!
Tom





From MAILER-DAEMON Tue Apr 06 19:09:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAzgs-0000Lx-3t
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 19:09:10 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAzgo-0000IT-JR
	for classpath@gnu.org; Tue, 06 Apr 2004 19:09:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAzgG-0008NX-Lr
	for classpath@gnu.org; Tue, 06 Apr 2004 19:09:03 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAzed-0007dB-TP
	for classpath@gnu.org; Tue, 06 Apr 2004 19:06:51 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i36N6oWB020410;
	Tue, 6 Apr 2004 19:06:50 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i36N6oj25689; 
	Tue, 6 Apr 2004 19:06:50 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i36N6ne1028356; Tue, 6 Apr 2004 19:06:49 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <40717508.4000008@aicas.com>
References: <40713D73.1070002@aicas.com>  <40717508.4000008@aicas.com>
Content-Type: text/plain; charset=UTF-8
Message-Id: <1081292809.11618.202.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 06 Apr 2004 19:06:49 -0400
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	i36N6oWB020410
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.ComponentSampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 23:09:08 -0000

On Mon, 2004-04-05 at 11:02, Ingo Pr=C3=B6tel wrote:
> Note new attachment.
>=20
> Ingo Pr=C3=B6tel wrote:
> > I suggest the following patch:
> >=20
> > 2004-04-05  Ingo Proetel  <proetel@aicas.com>
> >=20
> >     * java/awt/image/ComponentSampleModel.java (setDataSamples):Do no=
t=20
> > reset scanline stride.
> >=20
> >


>      if (scanlineStride =3D=3D rowSize)
>        {
>         // Collapse scan lines:
> -       scanlineStride =3D rowSize *=3D h;
> +       rowSize *=3D h;
>         h =3D 1;
>        }

Can you accompany your patches with a description of the problem they
solve?  What's the rationale for this change?

Tom





From MAILER-DAEMON Tue Apr 06 19:12:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAzkV-0002Q7-Qt
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 19:12:55 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAzkO-0002Oy-D2
	for classpath@gnu.org; Tue, 06 Apr 2004 19:12:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAzjq-0002Ds-Kk
	for classpath@gnu.org; Tue, 06 Apr 2004 19:12:45 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAzjp-0002DU-MJ
	for classpath@gnu.org; Tue, 06 Apr 2004 19:12:13 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i36NCCWB021680;
	Tue, 6 Apr 2004 19:12:12 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i36NCBj26747; 
	Tue, 6 Apr 2004 19:12:11 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i36NCBe1028532; Tue, 6 Apr 2004 19:12:11 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <4071743C.6090204@aicas.com>
References: <40714921.4050709@aicas.com>  <4071743C.6090204@aicas.com>
Content-Type: text/plain; charset=UTF-8
Message-Id: <1081293130.11618.215.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 06 Apr 2004 19:12:11 -0400
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	i36NCCWB021680
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.SampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 23:12:49 -0000

On Mon, 2004-04-05 at 10:59, Ingo Pr=C3=B6tel wrote:
> Note new attachment.


> Index: java/awt/image/SampleModel.java
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/classpath/classpath/java/awt/image/SampleModel.java,=
v
> retrieving revision 1.2
> diff -u -r1.2 SampleModel.java
> --- java/awt/image/SampleModel.java     22 Jan 2002 22:26:59 -0000     =
 1.2
> +++ java/awt/image/SampleModel.java     5 Apr 2004 14:57:53 -0000
> @@ -58,7 +58,9 @@
> =20
>    public SampleModel(int dataType, int w, int h, int numBands)
>    {
> -    if ((w<=3D0) || (h<=3D0)) throw new IllegalArgumentException();
> +    if ((w<=3D0) || (h<=3D0))=20
> +      throw new IllegalArgumentException( (w<=3D0?" width<=3D0":" widt=
h is ok")
> +                                         +(h<=3D0?" height<=3D0":" hei=
ght is ok"));

This patch is fine, except for the formatting.  The GNU coding style
that Classpath uses mandates that there should always be spaces between
operators and their operands.

(w<=3D0?" width<=3D0":" width is ok")

should be:

(w <=3D 0 ? " width<=3D0" : " width is ok")

Thanks,
Tom





From MAILER-DAEMON Tue Apr 06 19:14:56 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BAzmR-0003Ms-Et
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 19:14:55 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BAzm0-00038Y-0X
	for classpath@gnu.org; Tue, 06 Apr 2004 19:14:28 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BAzkv-0002cV-H3
	for classpath@gnu.org; Tue, 06 Apr 2004 19:13:45 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BAzku-0002bh-QV
	for classpath@gnu.org; Tue, 06 Apr 2004 19:13:20 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i36NDJWB021979;
	Tue, 6 Apr 2004 19:13:19 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i36NDIj27011; 
	Tue, 6 Apr 2004 19:13:18 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i36NDHe1028551; Tue, 6 Apr 2004 19:13:17 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <407173BF.9030309@aicas.com>
References: <40714C90.3070904@aicas.com>  <407173BF.9030309@aicas.com>
Content-Type: text/plain; charset=UTF-8
Message-Id: <1081293197.11618.218.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 06 Apr 2004 19:13:17 -0400
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	i36NDJWB021979
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.Polygon
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2004 23:14:51 -0000

On Mon, 2004-04-05 at 10:57, Ingo Pr=C3=B6tel wrote:
> Let try this again with the correct attachment.
>=20

Looks good.

Thanks,
Tom





From MAILER-DAEMON Tue Apr 06 20:06:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BB0Z0-0005b4-Uq
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 20:05:06 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BB0Yp-0005Xg-HC
	for classpath@gnu.org; Tue, 06 Apr 2004 20:04:55 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BB0Y4-000552-MJ
	for classpath@gnu.org; Tue, 06 Apr 2004 20:04:40 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BB0KQ-0000mf-IK
	for classpath@gnu.org; Tue, 06 Apr 2004 19:50:02 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i36No0WB031661;
	Tue, 6 Apr 2004 19:50:00 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i36Nnvj03462; 
	Tue, 6 Apr 2004 19:49:58 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i36Nnue1029717; Tue, 6 Apr 2004 19:49:56 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <4071583F.7060408@aicas.com>
References: <4071583F.7060408@aicas.com>
Content-Type: text/plain; charset=UTF-8
Message-Id: <1081295395.11618.238.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 06 Apr 2004 19:49:56 -0400
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	i36No0WB031661
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch to implement ColorGraphicsContext
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 00:04:57 -0000

On Mon, 2004-04-05 at 08:59, Ingo Pr=C3=B6tel wrote:
> I suggest the following patch
> 2004-04-05  Ingo Proetel  <proetel@aicas.com>
>=20
> 	* java/awt/ColorPaintContext.java (<init>): Added ColorModel to signat=
ure.
> 	(getColorModel): Return the actual color model.
> 	(getRaster): Implemented.
> 	(ColorRaster): New inner class.
> 	* java/awt/SystemColor.java (createContext): Use ColorModel when creat=
ing
> 	a PaintContext.
> 	* java/awt/Color.java (<init>): Make exception more verbose.
> 	(createContext): Use ColorModel when creating a PaintContext.
> =09
>=20
> ingo


> Index: java/awt/ColorPaintContext.java
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file:
> /cvsroot/classpath/classpath/java/awt/ColorPaintContext.java,v
> retrieving revision 1.1
> diff -u -r1.1 ColorPaintContext.java
> --- java/awt/ColorPaintContext.java     8 May 2002 03:07:24
> -0000       1.1
> +++ java/awt/ColorPaintContext.java     5 Apr 2004 12:43:00 -0000
> @@ -39,7 +39,13 @@
>  package java.awt;
> =20
>  import java.awt.image.ColorModel;
> +import java.awt.image.DataBuffer;
> +import java.awt.image.DataBufferByte;
> +import java.awt.image.DataBufferInt;
> +import java.awt.image.DataBufferUShort;
>  import java.awt.image.Raster;
> +import java.awt.image.SampleModel;
> +import java.util.Arrays;
> =20
>  /**
>   * This class provides a paint context which will fill a rectanglar
> region of
> @@ -55,15 +61,19 @@
>     * SystemColor.
>     */
>    final int color;
> +  final ColorModel colorModel;
> =20
> +  private ColorRaster mCachedRaster;
> +=20

We don't use the 'm' prefix on fields.

>    /**
>     * Create the context for a given color.
>     *
>     * @param c the solid color to use
>     */
> -  ColorPaintContext(int c)
> +  ColorPaintContext(ColorModel cm,int c)

You should probably create a new constructor (that uses the previous
default colour model), rather than changing the old one.  Color.java,
for example, calls ColorPaintContext(int c).

>    {
>      color =3D c;
> +    colorModel =3D cm;
>    }
> =20
>    /**
> @@ -75,14 +85,13 @@
>    }
> =20
>    /**
> -   * Return the color model of this context. This ignores the model
> passed
> -   * in the request, since colors are always in sRGB.
> +   * Return the color model of this context.=20
>     *
>     * @return the context color model
>     */
>    public ColorModel getColorModel()
>    {
> -    return ColorModel.getRGBdefault();
> +    return colorModel;
>    }
> =20
>    /**
> @@ -96,8 +105,71 @@
>     */
>    public Raster getRaster(int x, int y, int w, int h)
>    {
> -    // XXX Implement. Sun uses undocumented implementation class
> -    // sun.awt.image.IntegerInterleavedRaster.
> -    throw new Error("not implemented");
> +   if(  mCachedRaster =3D=3D null=20
> +       || mCachedRaster.getWidth() < w
> +       || mCachedRaster.getHeight() < h)
> +    {
> +     mCachedRaster =3D new ColorRaster(colorModel, 0, 0, w, h, color);
> +    }
> +   return mCachedRaster.createChild(0,0,w,h,x,y,null);

                                       ^^^^^^^^^^^^^^^^

Arguments should be separated by spaces.

>    }
> + =20
> +  private class ColorRaster extends Raster{
> +     =20
> +        /**
> +         *=20
> +         * @param cm
> +         * @param rgbPixel
> +         */
> +        ColorRaster(ColorModel cm,int x, int y, int width, int
> height, int rgbPixel)
> +        {        =20
> +          super(cm.createCompatibleSampleModel(width,height),new
> Point(x,y));
> +          Object pixel =3D cm.getDataElements(rgbPixel,null);
> +          getSampleModel().setDataElements(0,
> 0,width,height,multiplyData(pixel,null,width*height),dataBuffer);


Lines should be no more than 80 characters long, so lines like this need
to be wrapped.


> +        }
> +              =20
> +       =20
> +       =20
> +        private Object multiplyData(Object src, Object dest, int
> factor)
> +        {
> +          Object from;
> +          int srcLength =3D 0;
> +          if (src instanceof byte[])
> +           {
> +            srcLength =3D ((byte[])src).length;
> +           =20
> +            if (dest =3D=3D null) dest =3D new byte[factor * srcLength=
];
> +          }
> +          else if (src instanceof short[])
> +           {
> +            srcLength =3D ((short[])src).length;
> +            if (dest =3D=3D null) dest =3D new short[factor * srcLengt=
h];
> +          }
> +          else if (src instanceof int[])
> +           {
> +            srcLength =3D ((int[]) src).length;
> +            if (dest =3D=3D null) dest =3D new int[factor * srcLength]=
;
> +          }
> +          else
> +           {
> +            throw new ClassCastException("Unknown data buffer type");
> +          }
> +
> +          System.arraycopy(src,0,dest,0,srcLength);
> +         =20
> +          int count =3D 1;
> +          while(count*2 < factor)
> +          {
> +            System.arraycopy(dest, 0, dest, count * srcLength,
> count*srcLength);
> +            count *=3D 2;=20
> +          }
> +         =20
> +          if(factor > count)
> +            System.arraycopy(dest,0, dest, count * srcLength, (factor
> - count) * srcLength );
> +   =20
> +            return dest;
> +        }

The indentation is a little wonky in this section (e.g. some open/close
braces don't line up).

> +       =20
> +  }
> + =20
>  } // class ColorPaintContext

Sorry to nit-pick about formatting.  Don't worry too much about stuff
that's already committed.  One day, hopefully soon, Jalopy will be ready
to reformat Classpath, and we can do this stuff automatically from then
on.

Thanks,
Tom





From MAILER-DAEMON Tue Apr 06 21:33:38 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BB1wg-0000Kq-EP
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 21:33:38 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BB1wd-0000KU-O9
	for classpath@gnu.org; Tue, 06 Apr 2004 21:33:35 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BB1w7-0000FJ-JM
	for classpath@gnu.org; Tue, 06 Apr 2004 21:33:34 -0400
Received: from [24.25.9.103] (helo=ms-smtp-04-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BB1w7-0000FD-4l
	for classpath@gnu.org; Tue, 06 Apr 2004 21:33:03 -0400
Received: from [10.0.0.2] (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-04-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	i371WxC8024145; Tue, 6 Apr 2004 21:32:59 -0400 (EDT)
From: "C. Brian Jones" <cbj@gnu.org>
To: Archie Cobbs <archie@dellroad.org>
In-Reply-To: <200404062156.i36LuPdL002391@arch20m.dellroad.org>
References: <200404062156.i36LuPdL002391@arch20m.dellroad.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-cFScUXViMB7RQgIrd9h3"
Message-Id: <1081301578.3175.2.camel@lyta.haphazard.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Tue, 06 Apr 2004 21:32:59 -0400
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: classpath@gnu.org
Subject: Re: Configuration class and --enable-native-sync
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: cbj@gnu.org
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 01:33:36 -0000


--=-cFScUXViMB7RQgIrd9h3
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 2004-04-06 at 17:56, Archie Cobbs wrote:
> Steven Augart wrote:
> > > How about including all the build options in the Configuration class?
> > >=20
> > >     public class Configuration {
> > >       public static final String BUILD_OPTIONS =3D {
> > > 	 "--enable-jni", "--enable-load-library", ...
> > >       };
> > >       ...
> > >     }
> > Perhaps we could include even the build options that automatically had=20
> > their default values set?  So, even if the user had not explicitly=20
> > stated "--enable-jni", we would still include "--enable-jni", since=20
> > it's the default?
> >=20
> > I'm trying to guard against the defaults possibly changing.  If we=20
> > were to, for example, one day make Classpath's default be=20
> > --enable-portable-native-sync, I'd still want Jikes RVM to correctly=20
> > read that the Classpath installation had that feature enabled.
>=20
> Agreed.. in general more info is better. E.g., why not also throw in
> the output of "uname -a", the classpath version, etc.

I'm not sure if the intention is to be able to tell prior to runtime
what the options were or if it is only necessary during runtime.  So it
would be easy enough to add something to the Configuration class, but I
thought folks wanted to not abuse it too much.  Another option perhaps
even in addition to is to simply add these to standard classpath
specific system properties at startup for use via System.getProperty()?
--=20
Brian Jones <cbj@gnu.org>

--=-cFScUXViMB7RQgIrd9h3
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQBAc1pJcEcmdY33uzYRAiXAAJ4vZsM8Q8PF2Kb62DTZFszgjrVS0ACeIjDP
Oay62k69vGzAPaWhLYatJBE=
=kH+C
-----END PGP SIGNATURE-----

--=-cFScUXViMB7RQgIrd9h3--




From MAILER-DAEMON Tue Apr 06 22:47:05 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BB35l-000411-7N
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 22:47:05 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BB356-0003lE-Cc
	for classpath@gnu.org; Tue, 06 Apr 2004 22:46:24 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BB33T-0003NN-6c
	for classpath@gnu.org; Tue, 06 Apr 2004 22:45:15 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BB32Z-0002m1-I8; Tue, 06 Apr 2004 22:43:47 -0400
Received: from sp1n294en1.watson.ibm.com (sp1n294en1.watson.ibm.com
	[129.34.20.40])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i372heq57798; Tue, 6 Apr 2004 22:43:40 -0400
Received: from sp1n294en1.watson.ibm.com (localhost [127.0.0.1])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i372hdO42974; Tue, 6 Apr 2004 22:43:39 -0400
Received: from watson.ibm.com (sig-9-65-199-174.mts.ibm.com [9.65.199.174])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i372hcx52692; Tue, 6 Apr 2004 22:43:39 -0400
Message-ID: <40736AD7.7010004@watson.ibm.com>
Date: Tue, 06 Apr 2004 22:43:35 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en, it, eo, pt, gl, es-ec, es-us, es, fr, ast, el
MIME-Version: 1.0
To: cbj@gnu.org
References: <200404062156.i36LuPdL002391@arch20m.dellroad.org>
	<1081301578.3175.2.camel@lyta.haphazard.org>
In-Reply-To: <1081301578.3175.2.camel@lyta.haphazard.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: Configuration class and --enable-native-sync
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 02:47:01 -0000

C. Brian Jones wrote:
> On Tue, 2004-04-06 at 17:56, Archie Cobbs wrote:
>>Agreed.. in general more info is better. E.g., why not also throw in
>>the output of "uname -a", the classpath version, etc.

The classpath version is already present in the Configuration class, 
but I don't quite see what you'd like to do with the output of "uname 
-a".  I agree it might be nice to be able to get at that information 
programmatically, but I would think that it would be more useful to 
get the information about the computer you're running on, instead of 
about the computer that Classpath was built on.

> I'm not sure if the intention is to be able to tell prior to runtime
> what the options were or if it is only necessary during runtime.  So it
> would be easy enough to add something to the Configuration class, but I
> thought folks wanted to not abuse it too much.  Another option perhaps
> even in addition to is to simply add these to standard classpath
> specific system properties at startup for use via System.getProperty()?

In my case, I want to be able to check at the time I build Jikes RVM. 
  If the user has build GNU Classpath in a configuration that doesn't 
work well with Jikes RVM (e.g., with CNI instead of JNI), I want to 
warn her or him so that she or he can build it appropriately.  I was 
prepared to do this by having the host VM run a little Java program 
that reads the gnu.classpath.Configuration class, and then makes the 
decision.

(Yeah, a host VM that uses Classpath will normally get 
gnu.classpath.Configuration from its own bootstrap class loader; you 
have to do some tricks with class loaders so that the VM's bootstrap 
class loader reads one version and then a non-delegating class loader 
reads in another gnu.classpath.Configuration from the version of 
Classpath that is being used for the build.)

I don't think Jikes RVM will have a great use for getting at it via 
System.getProperty() -- I suppose it might be nice for the VM to be do 
some extra sanity checking on what version of Classpath it's been 
slipped -- but I won't object to the data being available there if 
some other VM has a use for it.

-- 
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm



From MAILER-DAEMON Tue Apr 06 23:00:07 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BB3IN-0003kL-Gr
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 23:00:07 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BB3IL-0003jb-6Y
	for classpath@gnu.org; Tue, 06 Apr 2004 23:00:05 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BB3Hn-0003dL-Uq
	for classpath@gnu.org; Tue, 06 Apr 2004 23:00:03 -0400
Received: from [209.225.28.201] (helo=mxsf01.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BB3GI-0003Qs-5A; Tue, 06 Apr 2004 22:57:58 -0400
Received: from InterJet.dellroad.org (E6V6Q8.cpe.mvllo.al.charter.com
	[24.196.29.251])
	by mxsf01.cluster1.charter.net (8.12.11/8.12.11) with ESMTP id
	i372j3VI061777; Tue, 6 Apr 2004 22:45:04 -0400 (EDT)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id VAA34928;
	Tue, 6 Apr 2004 21:36:05 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i372a5D2045704; 
	Tue, 6 Apr 2004 21:36:05 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i372a4Fs045703;
	Tue, 6 Apr 2004 21:36:04 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404070236.i372a4Fs045703@arch20m.dellroad.org>
In-Reply-To: <1081301578.3175.2.camel@lyta.haphazard.org>
To: cbj@gnu.org
Date: Tue, 6 Apr 2004 21:36:04 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: classpath@gnu.org
Subject: Re: Configuration class and --enable-native-sync
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 03:00:06 -0000

C. Brian Jones wrote:
> thought folks wanted to not abuse it too much.  Another option perhaps
> even in addition to is to simply add these to standard classpath
> specific system properties at startup for use via System.getProperty()?

That's a good idea... and a more Java-centric approach.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Tue Apr 06 23:05:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BB3O3-0005EX-DZ
	for mharc-classpath@gnu.org; Tue, 06 Apr 2004 23:05:59 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BB3O1-0005EC-AS
	for classpath@gnu.org; Tue, 06 Apr 2004 23:05:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BB3NV-00055p-E6
	for classpath@gnu.org; Tue, 06 Apr 2004 23:05:56 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BB3NV-00055a-71
	for classpath@gnu.org; Tue, 06 Apr 2004 23:05:25 -0400
Received: from sp1n294en1.watson.ibm.com (sp1n294en1.watson.ibm.com
	[129.34.20.40])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i37357q59564; Tue, 6 Apr 2004 23:05:07 -0400
Received: from sp1n294en1.watson.ibm.com (localhost [127.0.0.1])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i37356O43132; Tue, 6 Apr 2004 23:05:06 -0400
Received: from watson.ibm.com (sig-9-65-199-174.mts.ibm.com [9.65.199.174])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i37355x42858; Tue, 6 Apr 2004 23:05:05 -0400
Message-ID: <40736FDD.2060108@watson.ibm.com>
Date: Tue, 06 Apr 2004 23:05:01 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en, it, eo, pt, gl, es-ec, es-us, es, fr, ast, el
MIME-Version: 1.0
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>	<4071E699.8020809@uqam.ca>	<4071E9BA.6080504@uqam.ca>
	<4071F761.8080603@uqam.ca>
In-Reply-To: <4071F761.8080603@uqam.ca>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 03:05:57 -0000

Etienne Gagnon wrote:
 > Can JNI actually be implemented on a 16-bit per byte system?
 > Anybody has a reasonable answer?

Such a system, to implement JNI, will have to have a compiler-defined 
extension for a signed 8-bit byte type, a bit like the GNU "long long" 
extension.  ANSI C allows a compiler to add additional types, as long 
as it implements the standard ones.

It will also need an unsigned 8 bit quantity (jboolean), signed and 
unsigned 16 bit ones (jshort, jchar), signed 32 and 64 bit quantities 
(jint, jlong), and (the stinger) 32 bit and 64 bit floating point 
values (jfloat, jdouble).

Now, I'm not sure how many people who use JNI are going to actually 
depend upon a jfloat being exactly 32 bits long (and not one bit 
more!) or a jdouble being exactly 64 bits long, but according to table 
3-1 in the JNI spec they are indeed entitled to make that assumption. 
  So, any C compiler that you want to write JNI code with had better 
have a way to specify floating point types with those lengths.


-- 
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm



From MAILER-DAEMON Wed Apr 07 03:00:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BB72u-00067p-Mp
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 03:00:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BB72i-0005z9-BX
	for classpath@gnu.org; Wed, 07 Apr 2004 03:00:12 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BB72B-0005gt-0u
	for classpath@gnu.org; Wed, 07 Apr 2004 03:00:10 -0400
Received: from [212.227.126.187] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BB72A-0005gF-K8
	for classpath@gnu.org; Wed, 07 Apr 2004 02:59:38 -0400
Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BB727-0003DT-00; Wed, 07 Apr 2004 08:59:35 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BB727-0007mW-00; Wed, 07 Apr 2004 08:59:35 +0200
Message-ID: <4073A6E0.1030904@aicas.com>
Date: Wed, 07 Apr 2004 08:59:44 +0200
From: =?UTF-8?B?SW5nbyBQcsO2dGVs?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <40713D73.1070002@aicas.com> <40717508.4000008@aicas.com>
	<1081292809.11618.202.camel@tortoise.toronto.redhat.com>
In-Reply-To: <1081292809.11618.202.camel@tortoise.toronto.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch for java.awt.image.ComponentSampleModel
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 07:00:13 -0000

The actual problem here was that the scalinestride gets modified when setDataSamples is called. But 
scanlinestride is a field of this class that gets used in other methods too. So it happend to me 
that I did set data elements for the whole model (therfore it was optimized and touched the showen 
code) and later I called getDataElements on parts of the sample model but then I got in trouble 
because the scanlinestride had the wrong value. My understanding is that the optimization in 
setDataElements should only be local to this method and not modify the data layout.

ingo

Thomas Fitzsimmons wrote:
> On Mon, 2004-04-05 at 11:02, Ingo PrÃ¶tel wrote:
> 
>>Note new attachment.
>>
>>Ingo PrÃ¶tel wrote:
>>
>>>I suggest the following patch:
>>>
>>>2004-04-05  Ingo Proetel  <proetel@aicas.com>
>>>
>>>    * java/awt/image/ComponentSampleModel.java (setDataSamples):Do not 
>>>reset scanline stride.
>>>
>>>
> 
> 
> 
>>     if (scanlineStride == rowSize)
>>       {
>>        // Collapse scan lines:
>>-       scanlineStride = rowSize *= h;
>>+       rowSize *= h;
>>        h = 1;
>>       }
> 
> 
> Can you accompany your patches with a description of the problem they
> solve?  What's the rationale for this change?
> 
> Tom
> 
> 
> 

-- 
Ingo PrÃ¶tel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany



From MAILER-DAEMON Wed Apr 07 04:03:17 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BB81k-00030D-U6
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 04:03:16 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BB81a-0002xE-Gg
	for classpath@gnu.org; Wed, 07 Apr 2004 04:03:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BB814-0002fc-1v
	for classpath@gnu.org; Wed, 07 Apr 2004 04:03:05 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BB80X-0002P2-Id; Wed, 07 Apr 2004 04:02:01 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 7 Apr 2004 10:00:50 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD2D@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Configuration class and --enable-native-sync
Thread-Index: AcQcTQgZU6CDj6W5TemFt6DsrjZ4MgAKUhJA
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Archie Cobbs" <archie@dellroad.org>,
	<cbj@gnu.org>
Cc: classpath@gnu.org
Subject: RE: Configuration class and --enable-native-sync
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 08:03:07 -0000

Archie Cobbs wrote:
> C. Brian Jones wrote:
> > thought folks wanted to not abuse it too much.  Another=20
> option perhaps
> > even in addition to is to simply add these to standard classpath
> > specific system properties at startup for use via=20
> System.getProperty()?
>=20
> That's a good idea... and a more Java-centric approach.

I don't particularly like it. The properties are bloated enough as it
is.

Regards,
Jeroen



From MAILER-DAEMON Wed Apr 07 06:22:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBACl-0007gb-TN
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 06:22:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBACi-0007fT-EI
	for classpath@gnu.org; Wed, 07 Apr 2004 06:22:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBACB-0007N5-QU
	for classpath@gnu.org; Wed, 07 Apr 2004 06:22:43 -0400
Received: from [62.253.162.42] (helo=mta02-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBABU-0006r4-NQ
	for classpath@gnu.org; Wed, 07 Apr 2004 06:21:28 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta02-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407102038.WDRD3246.mta02-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Wed, 7 Apr 2004 11:20:38 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37ALNIi032232; Wed, 7 Apr 2004 11:21:23 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37ALLCJ032228;
	Wed, 7 Apr 2004 11:21:21 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16499.54817.926455.879175@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 11:21:21 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <407311B6.7040507@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca> <4071E9BA.6080504@uqam.ca>
	<16498.63389.200004.130504@cuddles.cambridge.redhat.com>
	<407311B6.7040507@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 10:22:45 -0000

Etienne Gagnon writes:
 > Andrew Haley wrote:
 > > Yes, but it's not a question of whether the type jbyte is the same
 > > size as a character type, but whether it is treated in the same way as
 > > a character by the compiler.
 > 
 > Hi Andrew.  Please look carefully at my proposal (sent minutes ago),
 > and tell me if it still contains non-portable bits.  I provide in it
 > a piece of C code that will generate warnings if jbyte is not treated
 > as signed char by the compiler, if I am right.  [Look at the test()
 > function].

OK, done that.

Cheers,
Andrew.



From MAILER-DAEMON Wed Apr 07 06:39:01 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBARi-0003v5-Da
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 06:38:14 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBARR-0003pU-Oi
	for classpath@gnu.org; Wed, 07 Apr 2004 06:37:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBAQu-0003Tq-8s
	for classpath@gnu.org; Wed, 07 Apr 2004 06:37:55 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBAQs-0003S9-I0
	for classpath@gnu.org; Wed, 07 Apr 2004 06:37:22 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 7 Apr 2004 12:37:18 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQcieQhfLFebO7jSoejJSbcaJNtLgAATtcQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Andrew Haley" <aph@redhat.com>,
	"Etienne Gagnon" <gagnon.etienne_m@uqam.ca>
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>,
	Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 10:37:59 -0000

Andrew Haley wrote:
>  > "jbyte" must have a single platform-specific definition, as all
>  > JVMs on that platform should be able to execute the same JNI
>  > library code (no recompilation required).
>=20
> I didn't know that.  Is that requirement documented anywhere?  I can't
> see how you'd do it on a machine with 32-bit and 64-bit modes, for
> example.

Platform =3D Machine + OS. I don't have any reference, but I believe =
that
Etienne is right in saying that the same library should be usuable with
all JVMs on a specific platform.

> Clearly the highest performance comes from using a naked long.

No, the highest performance comes from using a platform specific
pointer. I think that for a JIT it is easier to replace a typed object
reference with a native pointer then a long. That's why I'm very much in
favor of using RawData. It can even be abstract, that way the JNI layer
can allocate sub types that contain the appropriate number of bits to
contain a native pointer.

For example:

public abstract class RawData {}

public final class RawData32 extends RawData
{
  private int pointer;
}

public final class RawData64 extends RawData
{
  private long pointer;
}

All the Java code would ever see are RawData references, but the JNI
layer knows that all RawData references are actually 32 or 64 bit (or
whatever that platform requires).

Regards,
Jeroen



From MAILER-DAEMON Wed Apr 07 06:45:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBAZ7-0007AK-QA
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 06:45:53 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBAYp-00072N-1D
	for classpath@gnu.org; Wed, 07 Apr 2004 06:45:35 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBAYI-0006q7-4W
	for classpath@gnu.org; Wed, 07 Apr 2004 06:45:33 -0400
Received: from [62.253.162.48] (helo=mta08-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBAVh-0005yB-3k
	for classpath@gnu.org; Wed, 07 Apr 2004 06:42:21 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta08-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407104217.GYUL10788.mta08-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Wed, 7 Apr 2004 11:42:17 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37AgAIi032363; Wed, 7 Apr 2004 11:42:10 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37Ag8Fx032357;
	Wed, 7 Apr 2004 11:42:08 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16499.56064.752037.38405@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 11:42:08 +0100
To: "Jeroen Frijters" <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 10:45:36 -0000
X-List-Received-Date: Wed, 07 Apr 2004 10:45:36 -0000

Jeroen Frijters writes:
 > Andrew Haley wrote:
 > >  > "jbyte" must have a single platform-specific definition, as all
 > >  > JVMs on that platform should be able to execute the same JNI
 > >  > library code (no recompilation required).
 > > 
 > > I didn't know that.  Is that requirement documented anywhere?  I can't
 > > see how you'd do it on a machine with 32-bit and 64-bit modes, for
 > > example.
 > 
 > Platform = Machine + OS. I don't have any reference, but I believe that
 > Etienne is right in saying that the same library should be usuable with
 > all JVMs on a specific platform.

But it's not necessarily possible.  Clearly it's desirable, no
argument there.

 > > Clearly the highest performance comes from using a naked long.
 > 
 > No, the highest performance comes from using a platform specific
 > pointer.

 > I think that for a JIT it is easier to replace a typed object
 > reference with a native pointer then a long. That's why I'm very
 > much in favor of using RawData. It can even be abstract, that way
 > the JNI layer can allocate sub types that contain the appropriate
 > number of bits to contain a native pointer.
 > 
 > For example:
 > 
 > public abstract class RawData {}
 > 
 > public final class RawData32 extends RawData
 > {
 >   private int pointer;
 > }
 > 
 > public final class RawData64 extends RawData
 > {
 >   private long pointer;
 > }
 > 
 > All the Java code would ever see are RawData references, but the JNI
 > layer knows that all RawData references are actually 32 or 64 bit (or
 > whatever that platform requires).

This seems to be identical to my proposal.

I no longer understand what we're arguing about...

Andrew.



From MAILER-DAEMON Wed Apr 07 07:07:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBAu8-0003ff-CC
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 07:07:36 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBAu4-0003et-W8
	for classpath@gnu.org; Wed, 07 Apr 2004 07:07:32 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBAtY-0003Xm-2s
	for classpath@gnu.org; Wed, 07 Apr 2004 07:07:31 -0400
Received: from [62.253.162.46] (helo=mta06-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBAtX-0003X6-4T
	for classpath@gnu.org; Wed, 07 Apr 2004 07:06:59 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta06-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407101956.DVTZ675.mta06-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Wed, 7 Apr 2004 11:19:56 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37AJmIi032200; Wed, 7 Apr 2004 11:19:49 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37AJlqw032194;
	Wed, 7 Apr 2004 11:19:47 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16499.54723.302361.515836@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 11:19:47 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <40731058.2060208@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>
	<200404051926.48137.konqueror@gmx.de>
	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>
	<200404051942.41173.konqueror@gmx.de>
	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca> <4071E9BA.6080504@uqam.ca>
	<16498.30144.189924.141228@cuddles.cambridge.redhat.com>
	<40731058.2060208@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 11:07:34 -0000

Etienne Gagnon writes:
 > Andrew Haley wrote:
 > > Maybe, but that's not the only thing.  It's possible to define jbyte
 > > so that it is an 8 bit signed value but not a character type, and JNI
 > > does not forbid this.  I suspect that all the platforms we use define
 > > jbyte to be a character type, but I can see no overpowering reason to
 > > introduce a dependency on that.
 > 
 > "jbyte" must have a single platform-specific definition, as all
 > JVMs on that platform should be able to execute the same JNI
 > library code (no recompilation required).

I didn't know that.  Is that requirement documented anywhere?  I can't
see how you'd do it on a machine with 32-bit and 64-bit modes, for
example.  Do we know that every JVM will use the same calling
convention for CNI?

 > I would argue that if a char type has 8 bits on a platform, there
 > is a strong case for it to be defined as "typedef signed char
 > jbyte", and I would gues VM implementors would be veery unhappy if
 > Sum (or any other) decided to define jbyte otherwise on that
 > platform.
 > 
 > BUT....  I agree, it could be false on some system.  So, assuming
 > the worst-case scenario, I have attached an updated version of my
 > byte array proposal that is, as far as I can tell, robust across
 > all possible platforms.
 > 
 > It contains 2 utility "inline" functions: wrap and unwrap.  I
 > provide 2 versions of each, one version for systems where jbyte ==
 > signed char, and one version for systems where jbyte != signed
 > char.  A test function, ideal for use in an autoconf macro, is
 > provided that issues a warning when jbyte != signed char.
 > 
 > So, Andrew, does this version pass the portability test?
 > 
 > I would really like to see the native counterpart of your opaque types and
 > compare the "theoretical" performance of it relative to the byte array
 > proposal.

Well, the proposals for this and opaque types aren't really
equivalent, in that I make no performance claims for using an opaque
wrapper for a native pointer.  I do claim a maintenace and
understandability advantage, however.  

Clearly the highest performance comes from using a naked long.  But
both long and byte array have the disadvantage in that they're
untyped.  The lack of typedef in Java is lamentable, but in its
absence we just have to do the best we can.

 > /* test function (unused).  This function will cause a compiler
 >  * warning when jbyte != signed char */

Maybe, maybe not.  Is this guaranteed by the standard to cause a
warning?

 > /* Assuming that jbyte != signed char */
 > 
 > #define PTRDIFF_BIT (sizeof(ptrdiff_t) * CHAR_BIT)
 > #define BARRAY_SIZE ((PTRDIFF_BIT + 7) / 8)
 > 
 > /* ----------------------------------------------------------------
 >    wrap: wraps a pointer into a jbyteArray in order to store in into a
 >    Java object instance.
 >    ---------------------------------------------------------------- */
 > 
 > inline static jbyteArray
 > wrap (JNIEnv *env, void *ptr)
 > {
 >   jbyteArray nativePtr;
 >   jbyte bytes[BARRAY_SIZE];
 > 
 >   /* make a robust integer out of pointer value */
 >   ptrdiff_t value = (char *) ptr - (char *) 0;

Don't do this subtraction, it isn't portable.  Use intptr_t instead.

 >   size_t i;
 > 
 >   for (i = 0; i < BARRAY_SIZE; i++)
 >     {
 >       bytes[i] = (value & 0x0ff);

I don't think the & 0x0ff is needed, but that probably doesn't matter.

And a little stylistic nit: it isn't a good idea to cat return values
from malloc().

Andrew.



From MAILER-DAEMON Wed Apr 07 07:56:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBBfm-0006GQ-1C
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 07:56:50 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBBfj-0006Fc-Fq
	for classpath@gnu.org; Wed, 07 Apr 2004 07:56:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBBdu-0005jb-Rf
	for classpath@gnu.org; Wed, 07 Apr 2004 07:55:26 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBBXE-0004jZ-ET
	for classpath@gnu.org; Wed, 07 Apr 2004 07:48:00 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 7 Apr 2004 13:47:55 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD33@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQcjQJgA+LLFOYrRCmbPsH37vMTzAACPQzw
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Andrew Haley" <aph@redhat.com>
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 11:56:48 -0000

Andrew Haley wrote:
> This seems to be identical to my proposal.
>=20
> I no longer understand what we're arguing about...

I know. I thought we were still trying to convince Etienne :-)

Regards,
Jeroen



From MAILER-DAEMON Wed Apr 07 08:11:19 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBBp9-0008F3-P3
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 08:06:31 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBBmm-0007s6-Ok
	for classpath@gnu.org; Wed, 07 Apr 2004 08:04:04 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBBjB-0007Aq-VH
	for classpath@gnu.org; Wed, 07 Apr 2004 08:00:53 -0400
Received: from [32.97.182.105] (helo=e5.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBBi0-0006na-8i
	for classpath@gnu.org; Wed, 07 Apr 2004 07:59:08 -0400
Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com
	[9.56.224.206])
	by e5.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id i37Bx667493556
	for <classpath@gnu.org>; Wed, 7 Apr 2004 07:59:06 -0400
Received: from d01ml604.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by northrelay04.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id
	i37BxQ9D087696
	for <classpath@gnu.org>; Wed, 7 Apr 2004 07:59:27 -0400
In-Reply-To: <16499.54723.302361.515836@cuddles.cambridge.redhat.com>
To: GNU Classpath <classpath@gnu.org>
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
X-MIMETrack: S/MIME Sign by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/07/2004 07:58:22 AM,
	Serialize by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/07/2004 07:58:22 AM,
	Serialize complete at 04/07/2004 07:58:22 AM,
	S/MIME Sign failed at 04/07/2004 07:58:22 AM: The cryptographic key was
	not found,
	Serialize by Router on D01ML604/01/M/IBM(Release 6.51HF87 | March 11,
	2004) at 04/07/2004 07:59:04,
	Serialize complete at 04/07/2004 07:59:04
Message-ID: <OF881E385D.8FAA4528-ON85256E6F.00414539-85256E6F.0041C74F@us.ibm.com>
Date: Wed, 7 Apr 2004 07:59:03 -0400
Content-Type: multipart/alternative;
	boundary="=_alternative 0041C51685256E6F_="
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 12:06:28 -0000

This is a multipart message in MIME format.
--=_alternative 0041C51685256E6F_=
Content-Type: text/plain; charset="US-ASCII"

So,

        I have to admit that I haven't been following this thread in all 
of its glory :-), but the JNI spec is quite clear on the sizes of the 
various primitives.  See the table in section 12.1.1 of the spec.  A jbyte 
is signed 8 bit quantity.  A jchar is an unsigned 16 bit quantity, etc. 
There are not defined in terms of things like C's char and int.  It 
doesn't matter what the native platform thinks an int is, a jint is a 
signed 32 bit quantity.

--dave
--=_alternative 0041C51685256E6F_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">So,</font>
<br>
<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; I
have to admit that I haven't been following this thread in all of its glory
:-), but the JNI spec is quite clear on the sizes of the various primitives.
&nbsp;See the table in section 12.1.1 of the spec. &nbsp;A jbyte is signed
8 bit quantity. &nbsp;A jchar is an unsigned 16 bit quantity, etc. &nbsp;There
are not defined in terms of things like C's char and int. &nbsp;It doesn't
matter what the native platform thinks an int is, a jint is a signed 32
bit quantity.</font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
--=_alternative 0041C51685256E6F_=--



From MAILER-DAEMON Wed Apr 07 08:56:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBCYl-00023B-3q
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 08:53:39 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBCYR-0001ty-CI
	for classpath@gnu.org; Wed, 07 Apr 2004 08:53:19 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBBzM-0002BE-VB
	for classpath@gnu.org; Wed, 07 Apr 2004 08:17:36 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBBrD-0008Pg-Nj
	for classpath@gnu.org; Wed, 07 Apr 2004 08:08:39 -0400
Received: from [62.253.162.47] (helo=mta07-svc.ntlworld.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBBgX-0002E5-0z
	for classpath@gnu.org; Wed, 07 Apr 2004 07:57:37 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta07-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407115557.GZQD15087.mta07-svc.ntlworld.com@cuddles.cambridge.redhat.com>
	for <classpath@gnu.org>; Wed, 7 Apr 2004 12:55:57 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37BtnIi032684; Wed, 7 Apr 2004 12:55:49 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37Btme4032680;
	Wed, 7 Apr 2004 12:55:48 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16499.60484.672951.758578@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 12:55:48 +0100
To: "GNU Classpath" <classpath@gnu.org>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Subject: FOSDEM group photo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 12:53:34 -0000

Who has this photo?  Can we put it on the web?

Thanks,
Andrew.



From MAILER-DAEMON Wed Apr 07 09:11:29 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBCq1-0008Ql-A7
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 09:11:29 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBCpx-0008PF-IZ
	for classpath@gnu.org; Wed, 07 Apr 2004 09:11:25 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBCpN-0008CW-Iv
	for classpath@gnu.org; Wed, 07 Apr 2004 09:11:21 -0400
Received: from [62.253.162.44] (helo=mta04-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBCn0-0007jX-Be
	for classpath@gnu.org; Wed, 07 Apr 2004 09:08:22 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta04-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407130758.GVUO1202.mta04-svc.ntlworld.com@cuddles.cambridge.redhat.com>
	for <classpath@gnu.org>; Wed, 7 Apr 2004 14:07:58 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37D8IIi016132; Wed, 7 Apr 2004 14:08:19 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37D8HV9016113;
	Wed, 7 Apr 2004 14:08:17 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16499.64833.101788.424889@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 14:08:17 +0100
To: "Jeroen Frijters" <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD35@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD35@LEMBU.sumatrasoftware.com>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: FOSDEM group photo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 13:11:27 -0000

Jeroen Frijters writes:
 > Andrew Haley wrote:
 > > Who has this photo?  Can we put it on the web?
 > 
 > http://adorphuye.com/gallery/FOSDEM2004/IMGP0234?full=1

Cool, thanks!

Andrew.



From MAILER-DAEMON Wed Apr 07 09:20:56 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBCz9-0001of-Bn
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 09:20:55 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBCyv-0001lb-RZ
	for classpath@gnu.org; Wed, 07 Apr 2004 09:20:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBCyO-0001bA-Il
	for classpath@gnu.org; Wed, 07 Apr 2004 09:20:39 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBCyO-0001ax-4Q
	for classpath@gnu.org; Wed, 07 Apr 2004 09:20:08 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBCxB-0005Oz-6y
	for classpath@gnu.org; Wed, 07 Apr 2004 09:18:53 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i37DC2Kt018663;
	Wed, 7 Apr 2004 09:12:02 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040709131703379 ; Wed, 07 Apr 2004 09:13:17 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i37D5COj027509; Wed, 7 Apr 2004 09:05:12 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from egagnon by perseval.info.uqam.ca with local (Exim 4.30)
	id 1BBCjw-0005S8-G0; Wed, 07 Apr 2004 09:05:12 -0400
Date: Wed, 7 Apr 2004 09:05:12 -0400
To: Andrew Haley <aph@redhat.com>
Message-ID: <20040407130512.GA20855@perseval.info.uqam.ca>
References: <16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca> <4071E9BA.6080504@uqam.ca>
	<16498.30144.189924.141228@cuddles.cambridge.redhat.com>
	<40731058.2060208@uqam.ca>
	<16499.54723.302361.515836@cuddles.cambridge.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16499.54723.302361.515836@cuddles.cambridge.redhat.com>
User-Agent: Mutt/1.5.5.1+cvs20040105i
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 13:20:42 -0000

On Wed, Apr 07, 2004 at 11:19:47AM +0100, Andrew Haley wrote:
>  > "jbyte" must have a single platform-specific definition, as all
>  > JVMs on that platform should be able to execute the same JNI
>  > library code (no recompilation required).
> 
> I didn't know that.  Is that requirement documented anywhere?  I can't
> see how you'd do it on a machine with 32-bit and 64-bit modes, for
> example.  Do we know that every JVM will use the same calling
> convention for CNI?

CNI is a gcj-specific thing, so gcj can do whatever they like...

As for JNI, yes it is a requirement.  JNI was *specifically*
developed to get rid of the multiple VM-specific native interfaces
that were developed in early Java implementations (Sun's, Netscape's,
Microsoft's).

In the JNI specification (e.g. chapters 11 to 13 of ISBN 0-201-32577-2
"The Java Native Interface, Programmer's Guide and Specification), you
find the following text:

  11.1 Design Goals

  The most important goal of the JNI design is ensuring that it offers
  binary compatibility among different Java virtual machine
  implementations on a given host environment. The same native library
  binary will run on different virtual machine implementations on a
  given host environment without the need for recompilation.


>  > /* test function (unused).  This function will cause a compiler
>  >  * warning when jbyte != signed char */
> 
> Maybe, maybe not.  Is this guaranteed by the standard to cause a
> warning?

Do we really care?  I think that it is sufficient to clearly document
the requirement to define or not JBYTE_IS_NOT_SIGNED_CHAR
appropriately.  We both probably know very few platforms (I know of
none, but I don't currently work on embedded processors...) that do
not have 8-bit bytes (=> chars).

This function is simply an appropriate test to add to a configure
script in a GNU environment, for the programmer's convenience *only*.

>  >   /* make a robust integer out of pointer value */
>  >   ptrdiff_t value = (char *) ptr - (char *) 0;
> 
> Don't do this subtraction, it isn't portable.  Use intptr_t instead.

ANSI/ISO 9899-1990 (the old standard, I guess) does not have intptr_t.

> And a little stylistic nit: it isn't a good idea to cat return values
> from malloc().


"cat"?  What do you mean?  [I know the example JNI code should have
checked that malloc() had actually succeeded.  And the code has a
memory leak, as the malloc()ed memory isn't freed, but this code was
simply meant as a test for wrapping/unwrapping native pointer...
Writing robust and portable C code is painful. ;-)]


Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Wed Apr 07 09:26:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBD4V-0003Or-NH
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 09:26:27 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBD4S-0003Nd-MQ
	for classpath@gnu.org; Wed, 07 Apr 2004 09:26:24 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBD1Q-0002Sp-8A
	for classpath@gnu.org; Wed, 07 Apr 2004 09:23:47 -0400
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBD1P-0002Q2-4z
	for classpath@gnu.org; Wed, 07 Apr 2004 09:23:15 -0400
Received: from localhost (localhost [127.0.0.1]) (uid 1000)
	by tangency.co.uk with local; Wed, 07 Apr 2004 14:07:24 +0100
Date: Wed, 7 Apr 2004 14:07:24 +0100
From: "S. Meslin-Weber" <twiun@adorphuye.com>
To: Andrew Haley <aph@redhat.com>
Message-ID: <20040407130724.GK15152@tangency.co.uk>
References: <16499.60484.672951.758578@cuddles.cambridge.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <16499.60484.672951.758578@cuddles.cambridge.redhat.com>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: FOSDEM group photo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 13:26:25 -0000

Hi Andrew!

On Wed, Apr 07, 2004 at 12:55:48PM +0100, Andrew Haley wrote:
> Who has this photo?  Can we put it on the web?
> 
> Thanks,
> Andrew.

I have it up on my gallery at the moment - I believe Jim Pick also has a
version. Feel free to put it up elsewhere if needed :)

direct link to the image in question:
http://adorphuye.com/gallery/FOSDEM2004/IMGP0234

I've also got some of the other FOSDEM images I could find in the same
album.

<plug>Odonata website http://odonata.tangency.co.uk and screenshots http://adorphuye.com/gallery/Odonata</plug>

Thanks,

Stephane



From MAILER-DAEMON Wed Apr 07 09:34:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBDBx-0005pf-Gk
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 09:34:09 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBDAi-0005E8-10
	for classpath@gnu.org; Wed, 07 Apr 2004 09:32:52 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBD1O-0002Rc-0C
	for classpath@gnu.org; Wed, 07 Apr 2004 09:23:46 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBD1N-0002Qq-8O
	for classpath@gnu.org; Wed, 07 Apr 2004 09:23:13 -0400
Received: from [62.253.162.44] (helo=mta04-svc.ntlworld.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBCxI-0005R5-PK
	for classpath@gnu.org; Wed, 07 Apr 2004 09:19:00 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta04-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407131822.HWJO1202.mta04-svc.ntlworld.com@cuddles.cambridge.redhat.com>
	for <classpath@gnu.org>; Wed, 7 Apr 2004 14:18:22 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37DIgIi003401; Wed, 7 Apr 2004 14:18:43 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37DIgjN003397;
	Wed, 7 Apr 2004 14:18:42 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16499.65458.172125.581860@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 14:18:42 +0100
To: "S. Meslin-Weber" <twiun@adorphuye.com>
In-Reply-To: <20040407130724.GK15152@tangency.co.uk>
References: <16499.60484.672951.758578@cuddles.cambridge.redhat.com>
	<20040407130724.GK15152@tangency.co.uk>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: FOSDEM group photo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 13:34:07 -0000

S. Meslin-Weber writes:
 > Hi Andrew!
 > 
 > On Wed, Apr 07, 2004 at 12:55:48PM +0100, Andrew Haley wrote:
 > > Who has this photo?  Can we put it on the web?
 > > 
 > > Thanks,
 > > Andrew.
 > 
 > I have it up on my gallery at the moment - I believe Jim Pick also has a
 > version. Feel free to put it up elsewhere if needed :)
 > 
 > direct link to the image in question:
 > http://adorphuye.com/gallery/FOSDEM2004/IMGP0234
 > 
 > I've also got some of the other FOSDEM images I could find in the same
 > album.
 > 
 > <plug>Odonata website http://odonata.tangency.co.uk and screenshots http://adorphuye.com/gallery/Odonata</plug>
 
Terrific, thanks.  I have no FOSDEM images because I, ah, dropped the
camera I took to the conference.  Cost about 1000 Euros to have it
rebuilt.  Never mind, I'll be more careful in the future!

Thanks,
Andrew.



From MAILER-DAEMON Wed Apr 07 09:37:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBDF5-0006tv-HF
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 09:37:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBDF2-0006sq-Q9
	for classpath@gnu.org; Wed, 07 Apr 2004 09:37:20 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBD9G-0004iU-Ok
	for classpath@gnu.org; Wed, 07 Apr 2004 09:31:53 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBCk4-0007Gv-NG
	for classpath@gnu.org; Wed, 07 Apr 2004 09:05:21 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 7 Apr 2004 15:05:15 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD35@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: FOSDEM group photo
Thread-Index: AcQcn9zR32bG9kUgTbKVPLFIhCS1GQAAQojQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Andrew Haley" <aph@redhat.com>,
	"GNU Classpath" <classpath@gnu.org>
Cc: 
Subject: RE: FOSDEM group photo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 13:37:21 -0000

Andrew Haley wrote:
> Who has this photo?  Can we put it on the web?

http://adorphuye.com/gallery/FOSDEM2004/IMGP0234?full=3D1

Regards,
Jeroen



From MAILER-DAEMON Wed Apr 07 10:07:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBDif-0008RR-12
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 10:07:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBDic-0008Qv-Lx
	for classpath@gnu.org; Wed, 07 Apr 2004 10:07:54 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBDUp-0004j2-0b
	for classpath@gnu.org; Wed, 07 Apr 2004 09:54:10 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBDUE-0004Q9-0h
	for classpath@gnu.org; Wed, 07 Apr 2004 09:53:02 -0400
Received: from [62.253.162.47] (helo=mta07-svc.ntlworld.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBDBF-000792-VV
	for classpath@gnu.org; Wed, 07 Apr 2004 09:33:26 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta07-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407133247.QHTY15087.mta07-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Wed, 7 Apr 2004 14:32:47 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37DWCIi003488; Wed, 7 Apr 2004 14:32:12 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37DWB5p003484;
	Wed, 7 Apr 2004 14:32:11 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16500.730.818712.833827@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 14:32:10 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <20040407130512.GA20855@perseval.info.uqam.ca>
References: <16497.40308.789463.146357@cuddles.cambridge.redhat.com>
	<4071A52E.2040501@uqam.ca>
	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>
	<4071B0BF.7020302@uqam.ca>
	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>
	<4071E699.8020809@uqam.ca> <4071E9BA.6080504@uqam.ca>
	<16498.30144.189924.141228@cuddles.cambridge.redhat.com>
	<40731058.2060208@uqam.ca>
	<16499.54723.302361.515836@cuddles.cambridge.redhat.com>
	<20040407130512.GA20855@perseval.info.uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 14:07:55 -0000

Etienne Gagnon writes:
 > On Wed, Apr 07, 2004 at 11:19:47AM +0100, Andrew Haley wrote:
 > >  > "jbyte" must have a single platform-specific definition, as all
 > >  > JVMs on that platform should be able to execute the same JNI
 > >  > library code (no recompilation required).
 > > 
 > > I didn't know that.  Is that requirement documented anywhere?  I can't
 > > see how you'd do it on a machine with 32-bit and 64-bit modes, for
 > > example.  Do we know that every JVM will use the same calling
 > > convention for CNI?
 > 
 > CNI is a gcj-specific thing, so gcj can do whatever they like...

Uh, thinko.  I mean JNI.

 > As for JNI, yes it is a requirement.  JNI was *specifically*
 > developed to get rid of the multiple VM-specific native interfaces
 > that were developed in early Java implementations (Sun's, Netscape's,
 > Microsoft's).
 > 
 > In the JNI specification (e.g. chapters 11 to 13 of ISBN 0-201-32577-2
 > "The Java Native Interface, Programmer's Guide and Specification), you
 > find the following text:
 > 
 >   11.1 Design Goals
 > 
 >   The most important goal of the JNI design is ensuring that it offers
 >   binary compatibility among different Java virtual machine
 >   implementations on a given host environment. The same native library
 >   binary will run on different virtual machine implementations on a
 >   given host environment without the need for recompilation.

That looks good, where it's possible.

 > >  > /* test function (unused).  This function will cause a compiler
 > >  >  * warning when jbyte != signed char */
 > > 
 > > Maybe, maybe not.  Is this guaranteed by the standard to cause a
 > > warning?
 > 
 > Do we really care?

No, not particularly.  I just wondered why you say this.

 > >  >   /* make a robust integer out of pointer value */
 > >  >   ptrdiff_t value = (char *) ptr - (char *) 0;
 > > 
 > > Don't do this subtraction, it isn't portable.  Use intptr_t instead.
 > 
 > ANSI/ISO 9899-1990 (the old standard, I guess) does not have intptr_t.

Okay, but ANS specifically does not allow you to do this subtraction.
Also, there is no guarantee that every pointer is representable as a
ptrdiff_t.  (6.5.6 Para 9, if you're interested)

 > > And a little stylistic nit: it isn't a good idea to cat return values
 > > from malloc().
 > 
 > 
 > "cat"?  What do you mean?

It's a special kind of typo that isn't detected by a spell checker.
:-)

It isn't a good idea to cast return values from malloc().  This is
because it can disguise a failure to #include <stdlib.h>.

 > [I know the example JNI code should have checked that malloc() had
 > actually succeeded.  And the code has a memory leak, as the
 > malloc()ed memory isn't freed, but this code was simply meant as a
 > test for wrapping/unwrapping native pointer...  Writing robust and
 > portable C code is painful. ;-)]

It certainly is!

Andrew.



From MAILER-DAEMON Wed Apr 07 10:21:22 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBDvd-0005YS-Ty
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 10:21:21 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBDvX-0005Sw-9n
	for classpath@gnu.org; Wed, 07 Apr 2004 10:21:15 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBDup-00054q-GI
	for classpath@gnu.org; Wed, 07 Apr 2004 10:21:02 -0400
Received: from [195.159.0.145] (helo=smtp1.powertech.no)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBDu4-0004eA-Cr
	for classpath@gnu.org; Wed, 07 Apr 2004 10:19:44 -0400
Received: from bothner.com (s01i34-0330.no.powertech.net [195.159.183.74])
	by smtp1.powertech.no (Postfix) with ESMTP
	id 869347E50; Wed,  7 Apr 2004 16:19:42 +0200 (CEST)
Message-ID: <40740DFF.50108@bothner.com>
Date: Wed, 07 Apr 2004 07:19:43 -0700
From: Per Bothner <per@bothner.com>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 14:21:19 -0000

Jeroen Frijters wrote:

> That's why I'm very much in favor of using RawData.  ...
> 
> public abstract class RawData {}
> 
> public final class RawData32 extends RawData
> {
>   private int pointer;
> }
> 
> public final class RawData64 extends RawData
> {
>   private long pointer;
> }
> 
> All the Java code would ever see are RawData references, but the JNI
> layer knows that all RawData references are actually 32 or 64 bit (or
> whatever that platform requires).

But this is a completely different model than the CNI RawData,
since you're adding an extra layer of indirection.

In CNI, a RawData is not an object that *contains* a pointer;
the pointer is the RawData reference itself.

I.e.
inline void* RawData_to_pointer (RawData *rd)
{
   return (void*) (rd);
}

*not*

inline void* RawData_to_pointer (RawData *rd)
{
   return (void*) (rd->pointer);
}

Adding the extra indirection seems like a bad idea to me.
I'd rather use jlong.  But I don't see any real reason not to
use RawData.  I can see on a few JVMs it may cause problems,
but they can easily sed the source to convert RawData to long.
Just think of RawData has a macro.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/



From MAILER-DAEMON Wed Apr 07 10:22:42 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBDwv-0006Ab-NO
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 10:22:41 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBDws-00068e-Tm
	for classpath@gnu.org; Wed, 07 Apr 2004 10:22:38 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBDwL-0005yS-Qy
	for classpath@gnu.org; Wed, 07 Apr 2004 10:22:36 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBDvr-0005h5-Vc
	for classpath@gnu.org; Wed, 07 Apr 2004 10:21:36 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i37ED4Cw020673;
	Wed, 7 Apr 2004 10:13:05 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040710141900247 ; Wed, 07 Apr 2004 10:14:19 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i37DMO5D026821; Wed, 7 Apr 2004 09:22:24 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from egagnon by perseval.info.uqam.ca with local (Exim 4.30)
	id 1BBD0a-0005Sw-DQ; Wed, 07 Apr 2004 09:22:24 -0400
Date: Wed, 7 Apr 2004 09:22:24 -0400
To: Andrew Haley <aph@redhat.com>
Message-ID: <20040407132224.GB20855@perseval.info.uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
	<16499.56064.752037.38405@cuddles.cambridge.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16499.56064.752037.38405@cuddles.cambridge.redhat.com>
User-Agent: Mutt/1.5.5.1+cvs20040105i
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 14:22:39 -0000

On Wed, Apr 07, 2004 at 11:42:08AM +0100, Andrew Haley wrote:
>  > Platform = Machine + OS. I don't have any reference, but I believe that
>  > Etienne is right in saying that the same library should be usuable with
>  > all JVMs on a specific platform.
> 
> But it's not necessarily possible.  Clearly it's desirable, no
> argument there.

The JNI specification says otherwise.

>  > All the Java code would ever see are RawData references, but the JNI
>  > layer knows that all RawData references are actually 32 or 64 bit (or
>  > whatever that platform requires).
> 
> This seems to be identical to my proposal.
> 
> I no longer understand what we're arguing about...

Why don't you show me the native couterpart of your proposal?  I've
been asking for it for some time, now, so that we can comment on it.
If it's better than my proposal, fine, but I need to actually see it
to make my mind about it.

I've been showing code specifically so that we discuss about
*concrete* things. 

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Wed Apr 07 10:40:03 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBEDi-0004g9-TA
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 10:40:02 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBEDf-0004ei-D1
	for classpath@gnu.org; Wed, 07 Apr 2004 10:39:59 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBED0-0004P3-K1
	for classpath@gnu.org; Wed, 07 Apr 2004 10:39:50 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBED0-0004OG-07
	for classpath@gnu.org; Wed, 07 Apr 2004 10:39:18 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Wed, 7 Apr 2004 16:37:05 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD37@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQcq2H5QlVSCZc/RvmCVC6zhRl+fgAAga3Q
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Per Bothner" <per@bothner.com>
Cc: GNU Classpath <classpath@gnu.org>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 14:40:01 -0000

Per Bothner wrote:
> Jeroen Frijters wrote:
>=20
> > That's why I'm very much in favor of using RawData.  ...
> >=20
> > public abstract class RawData {}
> >=20
> > public final class RawData32 extends RawData
> > {
> >   private int pointer;
> > }
> >=20
> > public final class RawData64 extends RawData
> > {
> >   private long pointer;
> > }
> >=20
> > All the Java code would ever see are RawData references, but the JNI
> > layer knows that all RawData references are actually 32 or=20
> 64 bit (or
> > whatever that platform requires).
>=20
> But this is a completely different model than the CNI RawData,
> since you're adding an extra layer of indirection.

No. In CNI you would continue to use RawData as the pointer. I'm doing
the same in my VM. The subclassing is only for JNI.

Regards,
Jeroen



From MAILER-DAEMON Wed Apr 07 10:46:11 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBEJf-0005vk-J3
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 10:46:11 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBEJb-0005uH-Ee
	for classpath@gnu.org; Wed, 07 Apr 2004 10:46:07 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBEJ5-0005kM-9d
	for classpath@gnu.org; Wed, 07 Apr 2004 10:46:06 -0400
Received: from [62.253.162.42] (helo=mta02-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBEJ4-0005kC-QQ
	for classpath@gnu.org; Wed, 07 Apr 2004 10:45:35 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta02-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407144446.WGDK3246.mta02-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Wed, 7 Apr 2004 15:44:46 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37EjSIi005010; Wed, 7 Apr 2004 15:45:30 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37EjRiu005006;
	Wed, 7 Apr 2004 15:45:27 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16500.5127.311848.971975@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 15:45:27 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <20040407132224.GB20855@perseval.info.uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
	<16499.56064.752037.38405@cuddles.cambridge.redhat.com>
	<20040407132224.GB20855@perseval.info.uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 14:46:08 -0000

Etienne Gagnon writes:
 > On Wed, Apr 07, 2004 at 11:42:08AM +0100, Andrew Haley wrote:
 > >  > Platform = Machine + OS. I don't have any reference, but I believe that
 > >  > Etienne is right in saying that the same library should be usuable with
 > >  > all JVMs on a specific platform.
 > > 
 > > But it's not necessarily possible.  Clearly it's desirable, no
 > > argument there.
 > 
 > The JNI specification says otherwise.

No, it doesn't.  It says that it's a goal.

 > >  > All the Java code would ever see are RawData references, but the JNI
 > >  > layer knows that all RawData references are actually 32 or 64 bit (or
 > >  > whatever that platform requires).
 > > 
 > > This seems to be identical to my proposal.
 > > 
 > > I no longer understand what we're arguing about...
 > 
 > Why don't you show me the native couterpart of your proposal?  I've
 > been asking for it for some time, now, so that we can comment on it.
 > If it's better than my proposal, fine, but I need to actually see it
 > to make my mind about it.
 > 
 > I've been showing code specifically so that we discuss about
 > *concrete* things. 

Okay.  Since there's been so much confusion I agree that's a good idea.

Andrew.



From MAILER-DAEMON Wed Apr 07 10:50:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBEOC-0007XJ-DU
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 10:50:52 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBEO7-0007Um-Lp
	for classpath@gnu.org; Wed, 07 Apr 2004 10:50:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBENZ-0007NN-07
	for classpath@gnu.org; Wed, 07 Apr 2004 10:50:44 -0400
Received: from [62.253.162.48] (helo=mta08-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBENY-0007ND-Kx
	for classpath@gnu.org; Wed, 07 Apr 2004 10:50:12 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta08-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040407145013.FASZ10788.mta08-svc.ntlworld.com@cuddles.cambridge.redhat.com>
	for <classpath@gnu.org>; Wed, 7 Apr 2004 15:50:13 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i37Eo6Ii005060; Wed, 7 Apr 2004 15:50:07 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i37Eo5Wt005054;
	Wed, 7 Apr 2004 15:50:05 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16500.5405.848191.706071@cuddles.cambridge.redhat.com>
Date: Wed, 7 Apr 2004 15:50:05 +0100
To: Per Bothner <per@bothner.com>
In-Reply-To: <40740DFF.50108@bothner.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
	<40740DFF.50108@bothner.com>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 14:50:49 -0000

Per Bothner writes:
 > Jeroen Frijters wrote:
 > 
 > > That's why I'm very much in favor of using RawData.  ...
 > > 
 > > public abstract class RawData {}
 > > 
 > > public final class RawData32 extends RawData
 > > {
 > >   private int pointer;
 > > }
 > > 
 > > public final class RawData64 extends RawData
 > > {
 > >   private long pointer;
 > > }
 > > 
 > > All the Java code would ever see are RawData references, but the JNI
 > > layer knows that all RawData references are actually 32 or 64 bit (or
 > > whatever that platform requires).
 > 
 > But this is a completely different model than the CNI RawData,
 > since you're adding an extra layer of indirection.
 > 
 > In CNI, a RawData is not an object that *contains* a pointer;
 > the pointer is the RawData reference itself.
 > 
 > I.e.
 > inline void* RawData_to_pointer (RawData *rd)
 > {
 >    return (void*) (rd);
 > }
 > 
 > *not*
 > 
 > inline void* RawData_to_pointer (RawData *rd)
 > {
 >    return (void*) (rd->pointer);
 > }
 > 
 > Adding the extra indirection seems like a bad idea to me.
 > I'd rather use jlong.

I take your point.  However, if Eclipse used named pointer types
rather than just "int" or "long" I would probably saved about a
month's work.  I'd like us not to repeat that mistake.

Okay, we could agree that documentation along the lines of "foo is a
native pointer" would help.  But I have a keen bias for self
documenting code where possible.

 > But I don't see any real reason not to use RawData.  I can see on a
 > few JVMs it may cause problems, but they can easily sed the source
 > to convert RawData to long.  Just think of RawData has a macro.

Or perhaps redefine RawData from its current "raw" form to the form
with an extra layer of indirection -- that wouldn't require the Java
client code to change.

Andrew.



From MAILER-DAEMON Wed Apr 07 11:36:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBF62-00016U-GB
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 11:36:10 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBF5v-00014L-Vv
	for classpath@gnu.org; Wed, 07 Apr 2004 11:36:03 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBF4y-00008t-6Z
	for classpath@gnu.org; Wed, 07 Apr 2004 11:35:36 -0400
Received: from [212.227.126.177] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBF4j-0008JX-AY
	for classpath@gnu.org; Wed, 07 Apr 2004 11:34:49 -0400
Received: from [212.227.126.179] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BBF4g-0001ri-00; Wed, 07 Apr 2004 17:34:46 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BBF4g-0002kf-00; Wed, 07 Apr 2004 17:34:46 +0200
Message-ID: <40741F95.2000303@aicas.com>
Date: Wed, 07 Apr 2004 17:34:45 +0200
From: =?UTF-8?B?SW5nbyBQcsO2dGVs?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Thomas Fitzsimmons <fitzsim@redhat.com>
References: <4071583F.7060408@aicas.com>
	<1081295395.11618.238.camel@tortoise.toronto.redhat.com>
In-Reply-To: <1081295395.11618.238.camel@tortoise.toronto.redhat.com>
Content-Type: multipart/mixed; boundary="------------060503000106030507050903"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch to implement ColorGraphicsContext
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 15:36:05 -0000

This is a multi-part message in MIME format.
--------------060503000106030507050903
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

this is my revised patch for ColorPaintContext.

ingo

Thomas Fitzsimmons wrote:
> On Mon, 2004-04-05 at 08:59, Ingo PrÃ¶tel wrote:
> 
>>I suggest the following patch
>>2004-04-05  Ingo Proetel  <proetel@aicas.com>
>>
>>	* java/awt/ColorPaintContext.java (<init>): Added ColorModel to signature.
>>	(getColorModel): Return the actual color model.
>>	(getRaster): Implemented.
>>	(ColorRaster): New inner class.
>>	* java/awt/SystemColor.java (createContext): Use ColorModel when creating
>>	a PaintContext.
>>	* java/awt/Color.java (<init>): Make exception more verbose.
>>	(createContext): Use ColorModel when creating a PaintContext.
>>	
>>
>>ingo
> 
> 
> 
>>Index: java/awt/ColorPaintContext.java
>>===================================================================
>>RCS file:
>>/cvsroot/classpath/classpath/java/awt/ColorPaintContext.java,v
>>retrieving revision 1.1
>>diff -u -r1.1 ColorPaintContext.java
>>--- java/awt/ColorPaintContext.java     8 May 2002 03:07:24
>>-0000       1.1
>>+++ java/awt/ColorPaintContext.java     5 Apr 2004 12:43:00 -0000
>>@@ -39,7 +39,13 @@
>> package java.awt;
>> 
>> import java.awt.image.ColorModel;
>>+import java.awt.image.DataBuffer;
>>+import java.awt.image.DataBufferByte;
>>+import java.awt.image.DataBufferInt;
>>+import java.awt.image.DataBufferUShort;
>> import java.awt.image.Raster;
>>+import java.awt.image.SampleModel;
>>+import java.util.Arrays;
>> 
>> /**
>>  * This class provides a paint context which will fill a rectanglar
>>region of
>>@@ -55,15 +61,19 @@
>>    * SystemColor.
>>    */
>>   final int color;
>>+  final ColorModel colorModel;
>> 
>>+  private ColorRaster mCachedRaster;
>>+ 
> 
> 
> We don't use the 'm' prefix on fields.
> 
> 
>>   /**
>>    * Create the context for a given color.
>>    *
>>    * @param c the solid color to use
>>    */
>>-  ColorPaintContext(int c)
>>+  ColorPaintContext(ColorModel cm,int c)
> 
> 
> You should probably create a new constructor (that uses the previous
> default colour model), rather than changing the old one.  Color.java,
> for example, calls ColorPaintContext(int c).
>
I added a constructor. But I think it is not useful at all. And people really should not use it 
because it has the potential of been a big efficiency draw back.
> 
>>   {
>>     color = c;
>>+    colorModel = cm;
>>   }
>> 
>>   /**
>>@@ -75,14 +85,13 @@
>>   }
>> 
>>   /**
>>-   * Return the color model of this context. This ignores the model
>>passed
>>-   * in the request, since colors are always in sRGB.
>>+   * Return the color model of this context. 
>>    *
>>    * @return the context color model
>>    */
>>   public ColorModel getColorModel()
>>   {
>>-    return ColorModel.getRGBdefault();
>>+    return colorModel;
>>   }
>> 
>>   /**
>>@@ -96,8 +105,71 @@
>>    */
>>   public Raster getRaster(int x, int y, int w, int h)
>>   {
>>-    // XXX Implement. Sun uses undocumented implementation class
>>-    // sun.awt.image.IntegerInterleavedRaster.
>>-    throw new Error("not implemented");
>>+   if(  mCachedRaster == null 
>>+       || mCachedRaster.getWidth() < w
>>+       || mCachedRaster.getHeight() < h)
>>+    {
>>+     mCachedRaster = new ColorRaster(colorModel, 0, 0, w, h, color);
>>+    }
>>+   return mCachedRaster.createChild(0,0,w,h,x,y,null);
> 
> 
>                                        ^^^^^^^^^^^^^^^^
> 
> Arguments should be separated by spaces.
Ok.
> 
> 
>>   }
>>+  
>>+  private class ColorRaster extends Raster{
>>+      
>>+        /**
>>+         * 
>>+         * @param cm
>>+         * @param rgbPixel
>>+         */
>>+        ColorRaster(ColorModel cm,int x, int y, int width, int
>>height, int rgbPixel)
>>+        {         
>>+          super(cm.createCompatibleSampleModel(width,height),new
>>Point(x,y));
>>+          Object pixel = cm.getDataElements(rgbPixel,null);
>>+          getSampleModel().setDataElements(0,
>>0,width,height,multiplyData(pixel,null,width*height),dataBuffer);
> 
> 
> 
> Lines should be no more than 80 characters long, so lines like this need
> to be wrapped.
> 
Ok.
> 
> 
>>+        }
>>+               
>>+        
>>+        
>>+        private Object multiplyData(Object src, Object dest, int
>>factor)
>>+        {
>>+          Object from;
>>+          int srcLength = 0;
>>+          if (src instanceof byte[])
>>+           {
>>+            srcLength = ((byte[])src).length;
>>+            
>>+            if (dest == null) dest = new byte[factor * srcLength];
>>+          }
>>+          else if (src instanceof short[])
>>+           {
>>+            srcLength = ((short[])src).length;
>>+            if (dest == null) dest = new short[factor * srcLength];
>>+          }
>>+          else if (src instanceof int[])
>>+           {
>>+            srcLength = ((int[]) src).length;
>>+            if (dest == null) dest = new int[factor * srcLength];
>>+          }
>>+          else
>>+           {
>>+            throw new ClassCastException("Unknown data buffer type");
>>+          }
>>+
>>+          System.arraycopy(src,0,dest,0,srcLength);
>>+          
>>+          int count = 1;
>>+          while(count*2 < factor)
>>+          {
>>+            System.arraycopy(dest, 0, dest, count * srcLength,
>>count*srcLength);
>>+            count *= 2; 
>>+          }
>>+          
>>+          if(factor > count)
>>+            System.arraycopy(dest,0, dest, count * srcLength, (factor
>>- count) * srcLength );
>>+    
>>+            return dest;
>>+        }
> 
> 
> The indentation is a little wonky in this section (e.g. some open/close
> braces don't line up).
>
Fixed. I think.

> 
>>+        
>>+  }
>>+  
>> } // class ColorPaintContext
> 
> 
> Sorry to nit-pick about formatting.  Don't worry too much about stuff
> that's already committed.  One day, hopefully soon, Jalopy will be ready
> to reformat Classpath, and we can do this stuff automatically from then
> on.
> 
> Thanks,
> Tom
> 
> 
> 

-- 
Ingo PrÃ¶tel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------060503000106030507050903
Content-Type: text/plain;
 name="ColorPaintContext.diff"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="ColorPaintContext.diff"

SW5kZXg6IGphdmEvYXd0L0NvbG9yUGFpbnRDb250ZXh0LmphdmEKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS
Q1MgZmlsZTogL2N2c3Jvb3QvY2xhc3NwYXRoL2NsYXNzcGF0aC9qYXZhL2F3dC9Db2xvclBh
aW50Q29udGV4dC5qYXZhLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEKZGlmZiAtdSAtcjEu
MSBDb2xvclBhaW50Q29udGV4dC5qYXZhCi0tLSBqYXZhL2F3dC9Db2xvclBhaW50Q29udGV4
dC5qYXZhCTggTWF5IDIwMDIgMDM6MDc6MjQgLTAwMDAJMS4xCisrKyBqYXZhL2F3dC9Db2xv
clBhaW50Q29udGV4dC5qYXZhCTcgQXByIDIwMDQgMTU6Mjc6MDkgLTAwMDAKQEAgLTEsNSAr
MSw1IEBACiAvKiBDb2xvclBhaW50Q29udGV4dC5qYXZhIC0tIGNvbnRleHQgZm9yIHBhaW50
aW5nIHNvbGlkIGNvbG9ycwotICAgQ29weXJpZ2h0IChDKSAyMDAyIEZyZWUgU29mdHdhcmUg
Rm91bmRhdGlvbiwgSW5jLgorICAgQ29weXJpZ2h0IChDKSAyMDAyLCAyMDA0IEZyZWUgU29m
dHdhcmUgRm91bmRhdGlvbiwgSW5jLgogCiBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgQ2xh
c3NwYXRoLgogCkBAIC01NSwxNSArNTUsMzEgQEAKICAgICogU3lzdGVtQ29sb3IuCiAgICAq
LwogICBmaW5hbCBpbnQgY29sb3I7CisgIGZpbmFsIENvbG9yTW9kZWwgY29sb3JNb2RlbDsK
IAorICBwcml2YXRlIENvbG9yUmFzdGVyIGNhY2hlZFJhc3RlcjsKKworICAKICAgLyoqCiAg
ICAqIENyZWF0ZSB0aGUgY29udGV4dCBmb3IgYSBnaXZlbiBjb2xvci4KICAgICoKLSAgICog
QHBhcmFtIGMgdGhlIHNvbGlkIGNvbG9yIHRvIHVzZQorICAgKiBAcGFyYW0gYyBUaGUgc29s
aWQgY29sb3IgdG8gdXNlLgogICAgKi8KLSAgQ29sb3JQYWludENvbnRleHQoaW50IGMpCisg
IENvbG9yUGFpbnRDb250ZXh0KGludCBjb2xvclJHQikKICAgewotICAgIGNvbG9yID0gYzsK
KyAgICB0aGlzKENvbG9yTW9kZWwuZ2V0UkdCZGVmYXVsdCgpLCBjb2xvclJHQik7CisgIH0K
KyAgCisgIC8qKgorICAgKiBDcmVhdGUgdGhlIGNvbnRleHQgZm9yIGEgZ2l2ZW4gY29sb3Iu
CisgICAqCisgICAqIEBwYXJhbSBjbSBUaGUgY29sb3IgbW9kZWwgb2YgdGhpcyBjb250ZXh0
LiAKKyAgICogQHBhcmFtIGMgVGhlIHNvbGlkIGNvbG9yIHRvIHVzZS4KKyAgICovCisgIENv
bG9yUGFpbnRDb250ZXh0KENvbG9yTW9kZWwgY20saW50IGNvbG9yUkdCKQorICB7CisgICAg
Y29sb3IgPSBjb2xvclJHQjsKKyAgICBjb2xvck1vZGVsID0gY207CiAgIH0KIAogICAvKioK
QEAgLTc1LDE0ICs5MSwxMyBAQAogICB9CiAKICAgLyoqCi0gICAqIFJldHVybiB0aGUgY29s
b3IgbW9kZWwgb2YgdGhpcyBjb250ZXh0LiBUaGlzIGlnbm9yZXMgdGhlIG1vZGVsIHBhc3Nl
ZAotICAgKiBpbiB0aGUgcmVxdWVzdCwgc2luY2UgY29sb3JzIGFyZSBhbHdheXMgaW4gc1JH
Qi4KKyAgICogUmV0dXJuIHRoZSBjb2xvciBtb2RlbCBvZiB0aGlzIGNvbnRleHQuIAogICAg
KgogICAgKiBAcmV0dXJuIHRoZSBjb250ZXh0IGNvbG9yIG1vZGVsCiAgICAqLwogICBwdWJs
aWMgQ29sb3JNb2RlbCBnZXRDb2xvck1vZGVsKCkKICAgewotICAgIHJldHVybiBDb2xvck1v
ZGVsLmdldFJHQmRlZmF1bHQoKTsKKyAgICByZXR1cm4gY29sb3JNb2RlbDsKICAgfQogCiAg
IC8qKgpAQCAtOTQsMTAgKzEwOSw4NyBAQAogICAgKiBAcGFyYW0gaCB0aGUgaGVpZ2h0LCBp
biBkZXZpY2Ugc3BhY2UKICAgICogQHJldHVybiBhIHJhc3RlciBmb3IgdGhlIGdpdmVuIGFy
ZWEgYW5kIGNvbG9yCiAgICAqLwotICBwdWJsaWMgUmFzdGVyIGdldFJhc3RlcihpbnQgeCwg
aW50IHksIGludCB3LCBpbnQgaCkKKyAgcHVibGljIFJhc3RlciBnZXRSYXN0ZXIoaW50IHgs
IGludCB5LCBpbnQgd2lkdGgsIGludCBoZWlnaHQpCisgIHsKKyAgIGlmKCAgY2FjaGVkUmFz
dGVyID09IG51bGwgCisgICAgICAgfHwgY2FjaGVkUmFzdGVyLmdldFdpZHRoKCkgPCB3aWR0
aAorICAgICAgIHx8IGNhY2hlZFJhc3Rlci5nZXRIZWlnaHQoKSA8IGhlaWdodCkKKyAgIHsK
KyAgICAgY2FjaGVkUmFzdGVyID0gbmV3IENvbG9yUmFzdGVyKGNvbG9yTW9kZWwsIDAsIDAs
IHdpZHRoLCBoZWlnaHQsIGNvbG9yKTsKKyAgIH0KKyAgIHJldHVybiBjYWNoZWRSYXN0ZXIu
Y3JlYXRlQ2hpbGQoMCAsMCAsd2lkdGggLGhlaWdodCAseCAseSAsIG51bGwpOworICB9Cisg
IAorICAvKioKKyAgICogQSBDb2xvclJhc3RlciBpcyBhIHJhc3RlciB0aGF0IGlzIGNvbXBs
ZXRlbHkgZmlsbGVkIHdpdGggb25lIGNvbG9yLiBUaGUgCisgICAqIGRhdGEgbGF5b3V0IGlz
IHRha2VuIGZyb20gdGhlIGNvbG9yIG1vZGVsIGdpdmVuIHRvIHRoZSBjb25zdHJ1Y3Rvci4K
KyAgICovCisgIHByaXZhdGUgY2xhc3MgQ29sb3JSYXN0ZXIgZXh0ZW5kcyBSYXN0ZXIKICAg
ewotICAgIC8vIFhYWCBJbXBsZW1lbnQuIFN1biB1c2VzIHVuZG9jdW1lbnRlZCBpbXBsZW1l
bnRhdGlvbiBjbGFzcwotICAgIC8vIHN1bi5hd3QuaW1hZ2UuSW50ZWdlckludGVybGVhdmVk
UmFzdGVyLgotICAgIHRocm93IG5ldyBFcnJvcigibm90IGltcGxlbWVudGVkIik7CisgICAg
CisgICAgLyoqCisgICAgICogQ3JlYXRlIGEgcmFzdGVyIHRoYXQgaXMgY29tcGFsdGlibGUg
d2l0aCB0aGUgZ2l2ZW4gY29sb3IgbW9kZWwgYW5kIAorICAgICAqIGZpbGxlZCB3aXRoIHRo
ZSBnaXZlbiBjb2xvci4KKyAgICAgKiBAcGFyYW0gY20gVGhlIGNvbG9yIG1vZGVsIGZvciB0
aGlzIHJhc3Rlci4KKyAgICAgKiBAcGFyYW0geCBUaGUgc21hbGxlc3QgaG9yaXpvbnRhbCBj
b3JyZGluYXRlIGluIHRoZSByYXN0ZXIuCisgICAgICogQHBhcmFtIHkgVGhlIHNtYWxsZXN0
IHZlcnRpY2FsIGNvb3JkaW5hdGUgaW4gdGhlIHJhc3Rlci4KKyAgICAgKiBAcGFyYW0gd2lk
dGggVGhlIHdpZHRoIG9mIHRoZSByYXN0ZXIuCisgICAgICogQHBhcmFtIGhlaWdodCBUaGUg
aGVpZ2h0IG9mIHRoZSByYXN0ZXIuCisgICAgICogQHBhcmFtIHJnYlBpeGVsIFRoZSBSR0Ig
dmFsdWUgb2YgdGhlIGNvbG9yIGZvciB0aGlzIHJhc3Rlci4KKyAgICAgKi8KKyAgICBDb2xv
clJhc3RlcihDb2xvck1vZGVsIGNtLGludCB4LCBpbnQgeSwgaW50IHdpZHRoLCBpbnQgaGVp
Z2h0LCBpbnQgcmdiUGl4ZWwpCisgICAgeyAgICAgICAgIAorICAgICAgc3VwZXIoY20uY3Jl
YXRlQ29tcGF0aWJsZVNhbXBsZU1vZGVsKHdpZHRoLGhlaWdodCksbmV3IFBvaW50KHgseSkp
OworICAgICAgT2JqZWN0IHBpeGVsID0gY20uZ2V0RGF0YUVsZW1lbnRzKHJnYlBpeGVsLG51
bGwpOworICAgICAgZ2V0U2FtcGxlTW9kZWwoKS5zZXREYXRhRWxlbWVudHMoMCwgMCwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdpZHRoLCBoZWlnaHQsCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtdWx0aXBseURhdGEocGl4
ZWwsbnVsbCx3aWR0aCpoZWlnaHQpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZGF0YUJ1ZmZlcik7CisgICAgfQorICAgIAorICAgIAorICAgIAorICAgIHBy
aXZhdGUgT2JqZWN0IG11bHRpcGx5RGF0YShPYmplY3Qgc3JjLCBPYmplY3QgZGVzdCwgaW50
IGZhY3RvcikKKyAgICB7CisgICAgICBPYmplY3QgZnJvbTsKKyAgICAgIGludCBzcmNMZW5n
dGggPSAwOworICAgICAgaWYgKHNyYyBpbnN0YW5jZW9mIGJ5dGVbXSkKKyAgICAgIHsKKyAg
ICAgICAgc3JjTGVuZ3RoID0gKChieXRlW10pc3JjKS5sZW5ndGg7CisgICAgICAgIAorICAg
ICAgICBpZiAoZGVzdCA9PSBudWxsKSBkZXN0ID0gbmV3IGJ5dGVbZmFjdG9yICogc3JjTGVu
Z3RoXTsKKyAgICAgIH0KKyAgICAgIGVsc2UgaWYgKHNyYyBpbnN0YW5jZW9mIHNob3J0W10p
CisgICAgICB7CisgICAgICAgIHNyY0xlbmd0aCA9ICgoc2hvcnRbXSlzcmMpLmxlbmd0aDsK
KyAgICAgICAgaWYgKGRlc3QgPT0gbnVsbCkgZGVzdCA9IG5ldyBzaG9ydFtmYWN0b3IgKiBz
cmNMZW5ndGhdOworICAgICAgfQorICAgICAgZWxzZSBpZiAoc3JjIGluc3RhbmNlb2YgaW50
W10pCisgICAgICB7CisgICAgICAgIHNyY0xlbmd0aCA9ICgoaW50W10pIHNyYykubGVuZ3Ro
OworICAgICAgICBpZiAoZGVzdCA9PSBudWxsKSBkZXN0ID0gbmV3IGludFtmYWN0b3IgKiBz
cmNMZW5ndGhdOworICAgICAgfQorICAgICAgZWxzZQorICAgICAgeworICAgICAgICB0aHJv
dyBuZXcgQ2xhc3NDYXN0RXhjZXB0aW9uKCJVbmtub3duIGRhdGEgYnVmZmVyIHR5cGUiKTsK
KyAgICAgIH0KKyAgICAgIAorICAgICAgU3lzdGVtLmFycmF5Y29weShzcmMsMCxkZXN0LDAs
c3JjTGVuZ3RoKTsKKyAgICAgIAorICAgICAgaW50IGNvdW50ID0gMTsKKyAgICAgIHdoaWxl
KGNvdW50KjIgPCBmYWN0b3IpCisgICAgICB7CisgICAgICAgIFN5c3RlbS5hcnJheWNvcHko
ZGVzdCwgMCwgZGVzdCwgY291bnQgKiBzcmNMZW5ndGgsIGNvdW50KnNyY0xlbmd0aCk7Cisg
ICAgICAgIGNvdW50ICo9IDI7IAorICAgICAgfQorICAgICAgCisgICAgICBpZihmYWN0b3Ig
PiBjb3VudCkKKyAgICAgICAgU3lzdGVtLmFycmF5Y29weShkZXN0LDAsIGRlc3QsIGNvdW50
ICogc3JjTGVuZ3RoLCAKKyAgICAgICAgICAgICAgICAgICAgICAgICAoZmFjdG9yIC0gY291
bnQpICogc3JjTGVuZ3RoICk7CisgICAgICAKKyAgICAgIHJldHVybiBkZXN0OworICAgIH0K
KyAgICAKICAgfQorICAKIH0gLy8gY2xhc3MgQ29sb3JQYWludENvbnRleHQK
--------------060503000106030507050903--



From MAILER-DAEMON Wed Apr 07 12:33:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBFzQ-0000YA-1m
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 12:33:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBFzN-0000X5-8g
	for classpath@gnu.org; Wed, 07 Apr 2004 12:33:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBFyp-0000JL-4V
	for classpath@gnu.org; Wed, 07 Apr 2004 12:33:19 -0400
Received: from [212.227.126.188] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBFym-0000IK-Ma
	for classpath@gnu.org; Wed, 07 Apr 2004 12:32:44 -0400
Received: from [212.227.126.162] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BBFyl-0004uy-00
	for classpath@gnu.org; Wed, 07 Apr 2004 18:32:43 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BBFyl-0004VP-00
	for classpath@gnu.org; Wed, 07 Apr 2004 18:32:43 +0200
Message-ID: <40742D2A.7040206@aicas.com>
Date: Wed, 07 Apr 2004 18:32:42 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath Discussion Mailing List <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------000106040107080800090203"
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Subject: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 16:33:22 -0000

This is a multi-part message in MIME format.
--------------000106040107080800090203
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

I would like to suggest removing all C++ keywords as names in the native implementations of GNU 
Classpath. We have a customer who insists on using C++ because of the more thorough code inspection.
To be able to compile with such a compiler we need to change all names that are C++ keywords.

I have attached cases where we already have changed this.
My feeling is that if we have the 'extern "C"' construct in the header files we should also try to 
have the code compilable with a C++ compiler.

Let me know what you think.
ingo

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany

--------------000106040107080800090203
Content-Type: text/plain;
 name="CppKeyWords.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="CppKeyWords.diff"

cvs server: Diffing native/jni
cvs server: Diffing native/jni/classpath
cvs server: Diffing native/jni/gtk-peer
cvs server: Diffing native/jni/java-awt
cvs server: Diffing native/jni/java-io
cvs server: Diffing native/jni/java-lang
cvs server: Diffing native/jni/java-net
Index: native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c,v
retrieving revision 1.4
diff -u -r1.4 gnu_java_net_PlainDatagramSocketImpl.c
--- native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c	29 Mar 2004 07:07:39 -0000	1.4
+++ native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c	7 Apr 2004 16:22:06 -0000
@@ -67,13 +67,13 @@
  * Creates a new datagram socket
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_create(JNIEnv *env, jobject this)
+Java_gnu_java_net_PlainDatagramSocketImpl_create(JNIEnv *env, jobject thiz)
 {
   assert(env!=NULL);
   assert((*env)!=NULL);
 
 #ifndef WITHOUT_NETWORK
-  _javanet_create(env, this, 0);
+  _javanet_create(env, thiz, 0);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -84,13 +84,13 @@
  * Close the socket.
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_close(JNIEnv *env, jobject this)
+Java_gnu_java_net_PlainDatagramSocketImpl_close(JNIEnv *env, jobject thiz)
 {
   assert(env!=NULL);
   assert((*env)!=NULL);
 
 #ifndef WITHOUT_NETWORK
-  _javanet_close(env, this, 0);
+  _javanet_close(env, thiz, 0);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -103,14 +103,14 @@
  * variables. 
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_bind(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainDatagramSocketImpl_bind(JNIEnv *env, jobject thiz, 
                                            jint port, jobject addr)
 {
   assert(env!=NULL);
   assert((*env)!=NULL);
 
 #ifndef WITHOUT_NETWORK
-  _javanet_bind(env, this, addr, port, 0);
+  _javanet_bind(env, thiz, addr, port, 0);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -121,14 +121,14 @@
  * This method sets the specified option for a socket
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_setOption(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainDatagramSocketImpl_setOption(JNIEnv *env, jobject thiz, 
                                                 jint option_id, jobject val)
 {
   assert(env!=NULL);
   assert((*env)!=NULL);
 
 #ifndef WITHOUT_NETWORK
-  _javanet_set_option(env, this, option_id, val);
+  _javanet_set_option(env, thiz, option_id, val);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -139,14 +139,14 @@
  * This method sets the specified option for a socket
  */
 JNIEXPORT jobject JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_getOption(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainDatagramSocketImpl_getOption(JNIEnv *env, jobject thiz, 
                                                 jint option_id)
 {
   assert(env!=NULL);
   assert((*env)!=NULL);
 
 #ifndef WITHOUT_NETWORK
-  return(_javanet_get_option(env, this, option_id));
+  return(_javanet_get_option(env, thiz, option_id));
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -157,7 +157,7 @@
  * Reads a buffer from a remote host
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_receive0(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainDatagramSocketImpl_receive0(JNIEnv *env, jobject thiz, 
                                               jobject packet)
 {
 #ifndef WITHOUT_NETWORK
@@ -228,7 +228,7 @@
 
   /* Receive the packet */
   /* should we try some sort of validation on the length? */
-  bytes_read = _javanet_recvfrom(env, this, arr, offset, maxlen, &addr, &port); 
+  bytes_read = _javanet_recvfrom(env, thiz, arr, offset, maxlen, &addr, &port); 
   if ((bytes_read == -1) || (*env)->ExceptionOccurred(env))
     {
       JCL_ThrowException(env, IO_EXCEPTION, "Internal error: receive");
@@ -343,7 +343,7 @@
  * Writes a buffer to the remote host
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_sendto(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainDatagramSocketImpl_sendto(JNIEnv *env, jobject thiz, 
                                              jobject addr, jint port, jarray buf, 
                                              jint offset, jint len)
 {
@@ -359,7 +359,7 @@
 
   DBG("PlainDatagramSocketImpl.sendto(): have addr\n");
 
-  _javanet_sendto(env, this, buf, offset, len, netAddress, port);
+  _javanet_sendto(env, thiz, buf, offset, len, netAddress, port);
   if ((*env)->ExceptionOccurred(env))
     { JCL_ThrowException(env, IO_EXCEPTION, "Internal error: send data"); return; }
 
@@ -374,7 +374,7 @@
  * Joins a multicast group
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_join(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainDatagramSocketImpl_join(JNIEnv *env, jobject thiz, 
                                            jobject addr)
 {
 #ifndef WITHOUT_NETWORK
@@ -392,7 +392,7 @@
       return;
     }
 
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if ((*env)->ExceptionOccurred(env))
     {
       JCL_ThrowException(env, IO_EXCEPTION, "Internal error");
@@ -420,7 +420,7 @@
  * Leaves a multicast group
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainDatagramSocketImpl_leave(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainDatagramSocketImpl_leave(JNIEnv *env, jobject thiz, 
                                             jobject addr)
 {
 #ifndef WITHOUT_NETWORK
@@ -438,7 +438,7 @@
       return;
     }
 
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if ((*env)->ExceptionOccurred(env))
     { JCL_ThrowException(env, IO_EXCEPTION, "Internal error"); return; }
 
@@ -455,3 +455,4 @@
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
+
Index: native/jni/java-net/gnu_java_net_PlainSocketImpl.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-net/gnu_java_net_PlainSocketImpl.c,v
retrieving revision 1.3
diff -u -r1.3 gnu_java_net_PlainSocketImpl.c
--- native/jni/java-net/gnu_java_net_PlainSocketImpl.c	29 Mar 2004 07:07:39 -0000	1.3
+++ native/jni/java-net/gnu_java_net_PlainSocketImpl.c	7 Apr 2004 16:22:06 -0000
@@ -68,13 +68,13 @@
  * Creates a new stream or datagram socket
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainSocketImpl_create(JNIEnv *env, jobject this, jboolean stream)
+Java_gnu_java_net_PlainSocketImpl_create(JNIEnv *env, jobject thiz, jboolean stream)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  _javanet_create(env, this, stream);
+  _javanet_create(env, thiz, stream);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -86,13 +86,13 @@
  * action as well.
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainSocketImpl_close(JNIEnv *env, jobject this)
+Java_gnu_java_net_PlainSocketImpl_close(JNIEnv *env, jobject thiz)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  _javanet_close(env, this, 1);
+  _javanet_close(env, thiz, 1);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -103,14 +103,14 @@
  * Connects to the specified destination.
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainSocketImpl_connect(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainSocketImpl_connect(JNIEnv *env, jobject thiz, 
                                       jobject addr, jint port)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  _javanet_connect(env, this, addr, port);
+  _javanet_connect(env, thiz, addr, port);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -123,14 +123,14 @@
  * variables. 
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainSocketImpl_bind(JNIEnv *env, jobject this, jobject addr,
+Java_gnu_java_net_PlainSocketImpl_bind(JNIEnv *env, jobject thiz, jobject addr,
                                    jint port)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  _javanet_bind(env, this, addr, port, 1);
+  _javanet_bind(env, thiz, addr, port, 1);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -142,13 +142,13 @@
  * connections allowed.
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainSocketImpl_listen(JNIEnv *env, jobject this, jint queuelen)
+Java_gnu_java_net_PlainSocketImpl_listen(JNIEnv *env, jobject thiz, jint queuelen)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  _javanet_listen(env, this, queuelen);
+  _javanet_listen(env, thiz, queuelen);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -160,13 +160,13 @@
  * object. Note that we assume this is a PlainSocketImpl just like us.
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainSocketImpl_accept(JNIEnv *env, jobject this, jobject impl)
+Java_gnu_java_net_PlainSocketImpl_accept(JNIEnv *env, jobject thiz, jobject impl)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  _javanet_accept(env, this, impl);
+  _javanet_accept(env, thiz, impl);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -174,7 +174,7 @@
 /*************************************************************************/
 
 JNIEXPORT jint JNICALL
-Java_gnu_java_net_PlainSocketImpl_available(JNIEnv *env, jobject this)
+Java_gnu_java_net_PlainSocketImpl_available(JNIEnv *env, jobject thiz)
 {
 #ifndef WITHOUT_NETWORK
   jclass   cls;
@@ -186,7 +186,7 @@
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  cls = (*env)->GetObjectClass(env, this);
+  cls = (*env)->GetObjectClass(env, thiz);
   if (cls == 0)
     {
       JCL_ThrowException(env, IO_EXCEPTION, "internal error");
@@ -200,7 +200,7 @@
       return 0;
     }
 
-  fd = (*env)->GetIntField(env, this, fid);
+  fd = (*env)->GetIntField(env, thiz, fid);
   
   TARGET_NATIVE_NETWORK_SOCKET_RECEIVE_AVAILABLE(fd,bytesAvailable,result);
   if (result != TARGET_NATIVE_OK)
@@ -220,14 +220,14 @@
  * This method sets the specified option for a socket
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainSocketImpl_setOption(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainSocketImpl_setOption(JNIEnv *env, jobject thiz, 
                                         jint option_id, jobject val)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  _javanet_set_option(env, this, option_id, val);
+  _javanet_set_option(env, thiz, option_id, val);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -238,14 +238,14 @@
  * This method sets the specified option for a socket
  */
 JNIEXPORT jobject JNICALL
-Java_gnu_java_net_PlainSocketImpl_getOption(JNIEnv *env, jobject this, 
+Java_gnu_java_net_PlainSocketImpl_getOption(JNIEnv *env, jobject thiz, 
                                         jint option_id)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  return(_javanet_get_option(env, this, option_id));
+  return(_javanet_get_option(env, thiz, option_id));
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -256,14 +256,14 @@
  * Reads a buffer from a remote host
  */
 JNIEXPORT jint JNICALL
-Java_gnu_java_net_PlainSocketImpl_read(JNIEnv *env, jobject this, jarray buf,
+Java_gnu_java_net_PlainSocketImpl_read(JNIEnv *env, jobject thiz, jarray buf,
                                    jint offset, jint len)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  return(_javanet_recvfrom(env, this, buf, offset, len, 0, 0));
+  return(_javanet_recvfrom(env, thiz, buf, offset, len, 0, 0));
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
@@ -274,14 +274,14 @@
  * Writes a buffer to the remote host
  */
 JNIEXPORT void JNICALL
-Java_gnu_java_net_PlainSocketImpl_write(JNIEnv *env, jobject this, jarray buf,
+Java_gnu_java_net_PlainSocketImpl_write(JNIEnv *env, jobject thiz, jarray buf,
                                     jint offset, jint len)
 {
 #ifndef WITHOUT_NETWORK
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  _javanet_sendto(env, this, buf, offset, len, 0, 0);
+  _javanet_sendto(env, thiz, buf, offset, len, 0, 0);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
 }
Index: native/jni/java-net/java_net_InetAddress.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-net/java_net_InetAddress.c,v
retrieving revision 1.9
diff -u -r1.9 java_net_InetAddress.c
--- native/jni/java-net/java_net_InetAddress.c	29 Mar 2004 07:07:39 -0000	1.9
+++ native/jni/java-net/java_net_InetAddress.c	7 Apr 2004 16:22:06 -0000
@@ -61,7 +61,7 @@
  * Function to return the local hostname
  */
 JNIEXPORT jstring JNICALL
-Java_java_net_InetAddress_getLocalHostname(JNIEnv *env, jclass class)
+Java_java_net_InetAddress_getLocalHostname(JNIEnv *env, jclass clazz)
 {
   char    hostname[256];
   int     result;
@@ -91,7 +91,7 @@
  * Returns the value of the special IP address INADDR_ANY 
  */
 JNIEXPORT jarray JNICALL
-Java_java_net_InetAddress_lookupInaddrAny(JNIEnv *env, jclass class)
+Java_java_net_InetAddress_lookupInaddrAny(JNIEnv *env, jclass clazz)
 {
   jarray IParray; 
   jbyte  *octets;
@@ -135,7 +135,7 @@
  * in as a byte array
  */
 JNIEXPORT jstring JNICALL
-Java_java_net_InetAddress_getHostByAddr(JNIEnv *env, jclass class, jarray arr)
+Java_java_net_InetAddress_getHostByAddr(JNIEnv *env, jclass clazz, jarray arr)
 {
 #ifndef WITHOUT_NETWORK
   jbyte   *octets;
@@ -193,7 +193,7 @@
 /*************************************************************************/
 
 JNIEXPORT jobjectArray JNICALL
-Java_java_net_InetAddress_getHostByName(JNIEnv *env, jclass class, jstring host)
+Java_java_net_InetAddress_getHostByName(JNIEnv *env, jclass clazz, jstring host)
 {
 #ifndef WITHOUT_NETWORK
   const char     *hostname;
@@ -201,7 +201,7 @@
   int            addresses[64];
   jsize          addresses_count;
   int            result;
-  jclass         arr_class;
+  jclass         arr_clazz;
   jobjectArray   addrs;
   int            i;
   jbyte          *octets;
@@ -221,7 +221,7 @@
   /* Look up the host */
   TARGET_NATIVE_NETWORK_GET_HOSTNAME_BY_NAME(hostname,
                                              addresses,
-                                             sizeof(addresses)/sizeof(addresses[0]),
+                                             ((jsize)(sizeof(addresses)/sizeof(addresses[0]))),
                                              addresses_count,
                                              result
                                             );
@@ -232,14 +232,14 @@
     }
   (*env)->ReleaseStringUTFChars(env, host, hostname);
 
-  arr_class = (*env)->FindClass(env,"[B");
-  if (!arr_class)
+  arr_clazz = (*env)->FindClass(env,"[B");
+  if (!arr_clazz)
     {
       JCL_ThrowException(env, UNKNOWN_HOST_EXCEPTION, "Internal Error");
       return (jobjectArray)NULL;
     }
 
-  addrs = (*env)->NewObjectArray(env, addresses_count, arr_class, 0);
+  addrs = (*env)->NewObjectArray(env, addresses_count, arr_clazz, 0);
   if (!addrs)
     {
       JCL_ThrowException(env, UNKNOWN_HOST_EXCEPTION, "Internal Error");
Index: native/jni/java-net/java_net_NetworkInterface.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-net/java_net_NetworkInterface.c,v
retrieving revision 1.5
diff -u -r1.5 java_net_NetworkInterface.c
--- native/jni/java-net/java_net_NetworkInterface.c	29 Mar 2004 07:07:39 -0000	1.5
+++ native/jni/java-net/java_net_NetworkInterface.c	7 Apr 2004 16:22:06 -0000
@@ -54,7 +54,7 @@
  * Returns all local network interfaces as vector
  */
 JNIEXPORT jobject JNICALL
-Java_java_net_NetworkInterface_getRealNetworkInterfaces (JNIEnv* env, jclass class)
+Java_java_net_NetworkInterface_getRealNetworkInterfaces (JNIEnv* env, jclass clazz)
 {
   JCL_ThrowException (env, IO_EXCEPTION, "java.net.NetworkInterface.getRealNetworkInterfaces(): not implemented");
   return 0;
Index: native/jni/java-net/javanet.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-net/javanet.c,v
retrieving revision 1.15
diff -u -r1.15 javanet.c
--- native/jni/java-net/javanet.c	29 Mar 2004 07:07:39 -0000	1.15
+++ native/jni/java-net/javanet.c	7 Apr 2004 16:22:07 -0000
@@ -1,4 +1,4 @@
-/* javanet.c - Common internal functions for the java.net package
+
/* javanet.c - Common internal functions for the java.net package
    Copyright (C) 1998, 2002 Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
@@ -71,7 +71,7 @@
  * Sets an integer field in the specified object.
  */
 static void
-_javanet_set_int_field(JNIEnv *env, jobject obj, char *class, char *field, 
+_javanet_set_int_field(JNIEnv *env, jobject obj, char *clazz, char *field, 
                        int val)
 {
   jclass   cls;
@@ -80,7 +80,7 @@
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  cls = (*env)->FindClass(env, class);
+  cls = (*env)->FindClass(env, clazz);
   if (cls == NULL)
     return;
 
@@ -133,7 +133,7 @@
  * need to include it.
  */
 static void
-_javanet_create_localfd(JNIEnv *env, jobject this)
+_javanet_create_localfd(JNIEnv *env, jobject thiz)
 {
   jclass    this_cls, fd_cls;
   jfieldID  fid;
@@ -176,7 +176,7 @@
   DBG("_javanet_create_localfd(): Created FileDescriptor\n");
 
   /* Now set the pointer to the new FileDescriptor */
-  (*env)->SetObjectField(env, this, fid, fd_obj);
+  (*env)->SetObjectField(env, thiz, fid, fd_obj);
   DBG("_javanet_create_localfd(): Set fd field\n");
 
   return;
@@ -317,7 +317,7 @@
 /*************************************************************************/
 
 static void
-_javanet_set_remhost_addr(JNIEnv *env, jobject this, jobject ia)
+_javanet_set_remhost_addr(JNIEnv *env, jobject thiz, jobject ia)
 {
   jclass   this_cls;
   jfieldID fid;
@@ -336,7 +336,7 @@
 
   DBG("_javanet_set_remhost_addr(): Found address field\n");
 
-  (*env)->SetObjectField(env, this, fid, ia);
+  (*env)->SetObjectField(env, thiz, fid, ia);
   DBG("_javanet_set_remhost_addr(): Set field\n");
 }
 
@@ -345,7 +345,7 @@
  * InetAddress for the specified addr
  */
 static void
-_javanet_set_remhost(JNIEnv *env, jobject this, int netaddr)
+_javanet_set_remhost(JNIEnv *env, jobject thiz, int netaddr)
 {
   jobject ia;
 
@@ -359,7 +359,7 @@
   if (ia == NULL)
     return;
 
-  _javanet_set_remhost_addr(env, this, ia);
+  _javanet_set_remhost_addr(env, thiz, ia);
 }
 
 
@@ -436,7 +436,7 @@
  * Creates a new stream or datagram socket
  */
 void
-_javanet_create(JNIEnv *env, jobject this, jboolean stream)
+_javanet_create(JNIEnv *env, jobject thiz, jboolean stream)
 {
 #ifndef WITHOUT_NETWORK
   int fd;
@@ -473,10 +473,10 @@
     }
     
   if (stream)
-    _javanet_set_int_field(env, this, "gnu/java/net/PlainSocketImpl", 
+    _javanet_set_int_field(env, thiz, "gnu/java/net/PlainSocketImpl", 
                            "native_fd", fd);
   else
-    _javanet_set_int_field(env, this, "gnu/java/net/PlainDatagramSocketImpl", 
+    _javanet_set_int_field(env, thiz, "gnu/java/net/PlainDatagramSocketImpl", 
                            "native_fd", fd);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
@@ -489,7 +489,7 @@
  * action as well.
  */
 void
-_javanet_close(JNIEnv *env, jobject this, int stream)
+_javanet_close(JNIEnv *env, jobject thiz, int stream)
 {
 #ifndef WITHOUT_NETWORK
   int fd;
@@ -498,17 +498,17 @@
   assert(env!=NULL);
   assert((*env)!=NULL);
 
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     return;
  
   TARGET_NATIVE_NETWORK_SOCKET_CLOSE(fd,result);
 
   if (stream)
-    _javanet_set_int_field(env, this, "gnu/java/net/PlainSocketImpl",
+    _javanet_set_int_field(env, thiz, "gnu/java/net/PlainSocketImpl",
                            "native_fd", -1);
   else
-    _javanet_set_int_field(env, this, "gnu/java/net/PlainDatagramSocketImpl",
+    _javanet_set_int_field(env, thiz, "gnu/java/net/PlainDatagramSocketImpl",
                            "native_fd", -1);
 #else /* not WITHOUT_NETWORK */
 #endif /* not WITHOUT_NETWORK */
@@ -520,7 +520,7 @@
  * Connects to the specified destination.
  */
 void 
-_javanet_connect(JNIEnv *env, jobject this, jobject addr, jint port)
+_javanet_connect(JNIEnv *env, jobject thiz, jobject addr, jint port)
 {
 #ifndef WITHOUT_NETWORK
   int netaddr, fd;
@@ -543,7 +543,7 @@
   DBG("_javanet_connect(): Got network address\n");
 
   /* Grab the real socket file descriptor */
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     { 
       JCL_ThrowException(env, IO_EXCEPTION, 
@@ -570,7 +570,7 @@
       return;
     }
 
-  _javanet_create_localfd(env, this);
+  _javanet_create_localfd(env, thiz);
   if ((*env)->ExceptionOccurred(env))
     {
       TARGET_NATIVE_NETWORK_SOCKET_CLOSE(fd,result);
@@ -578,7 +578,7 @@
     }
   DBG("_javanet_connect(): Created fd\n");
 
-  _javanet_set_int_field(env, this, "java/net/SocketImpl", "localport", 
+  _javanet_set_int_field(env, thiz, "java/net/SocketImpl", "localport", 
                          local_port);
   if ((*env)->ExceptionOccurred(env))
     {
@@ -597,11 +597,11 @@
 
   if (remote_address == netaddr)
     {
-      _javanet_set_remhost_addr(env, this, addr);
+      _javanet_set_remhost_addr(env, thiz, addr);
     }
   else
     {
-      _javanet_set_remhost(env, this, remote_address);
+      _javanet_set_remhost(env, thiz, remote_address);
     }
   if ((*env)->ExceptionOccurred(env))
     {
@@ -610,7 +610,7 @@
     }
   DBG("_javanet_connect(): Set the remote host\n");
 
-  _javanet_set_int_field(env, this, "java/net/SocketImpl", "port", 
+  _javanet_set_int_field(env, thiz, "java/net/SocketImpl", "port", 
                          remote_port);
   if ((*env)->ExceptionOccurred(env))
     {
@@ -630,7 +630,7 @@
  * port public instance variables. 
  */
 void
-_javanet_bind(JNIEnv *env, jobject this, jobject addr, jint port, int stream)
+_javanet_bind(JNIEnv *env, jobject thiz, jobject addr, jint port, int stream)
 {
 #ifndef WITHOUT_NETWORK
   jclass     cls;
@@ -671,7 +671,7 @@
   DBG("_javanet_bind(): Past grab array\n");
 
   /* Get the native socket file descriptor */
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     {
       (*env)->ReleaseByteArrayElements(env, arr, octets, 0);
@@ -682,7 +682,7 @@
   DBG("_javanet_bind(): Past native_fd lookup\n");
 
 // NYI ???
-  _javanet_set_option (env, this, SOCKOPT_SO_REUSEADDR, 
+  _javanet_set_option (env, thiz, SOCKOPT_SO_REUSEADDR, 
 		       _javanet_create_boolean (env, JNI_TRUE));
 
 
@@ -713,10 +713,10 @@
     }
 
   if (stream)
-    _javanet_set_int_field(env, this, "java/net/SocketImpl", 
+    _javanet_set_int_field(env, thiz, "java/net/SocketImpl", 
                            "localport", local_port);
   else
-    _javanet_set_int_field(env, this, "java/net/DatagramSocketImpl", 
+    _javanet_set_int_field(env, thiz, "java/net/DatagramSocketImpl", 
                            "localPort", local_port);
   DBG("_javanet_bind(): Past update port number\n");
 
@@ -732,7 +732,7 @@
  * connections allowed.
  */
 void 
-_javanet_listen(JNIEnv *env, jobject this, jint queuelen)
+_javanet_listen(JNIEnv *env, jobject thiz, jint queuelen)
 {
 #ifndef WITHOUT_NETWORK
   int fd;
@@ -742,7 +742,7 @@
   assert((*env)!=NULL);
 
   /* Get the real file descriptor */
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     { 
       JCL_ThrowException(env, IO_EXCEPTION, 
@@ -768,7 +768,7 @@
  * object. Note that we assume this is a PlainSocketImpl just like us
  */
 void 
-_javanet_accept(JNIEnv *env, jobject this, jobject impl)
+_javanet_accept(JNIEnv *env, jobject thiz, jobject impl)
 {
 #ifndef WITHOUT_NETWORK
   int fd, newfd;
@@ -780,7 +780,7 @@
   assert((*env)!=NULL);
 
   /* Get the real file descriptor */
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     { 
       JCL_ThrowException(env, IO_EXCEPTION, 
@@ -873,7 +873,7 @@
  * The actual number of bytes read is returned.
  */
 int
-_javanet_recvfrom(JNIEnv *env, jobject this, jarray buf, int offset, int len,
+_javanet_recvfrom(JNIEnv *env, jobject thiz, jarray buf, int offset, int len,
                   int *addr, int *port)
 {
 #ifndef WITHOUT_NETWORK
@@ -888,7 +888,7 @@
   DBG("_javanet_recvfrom(): Entered _javanet_recvfrom\n");
 
   /* Get the real file descriptor */
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     { 
       JCL_ThrowException(env, IO_EXCEPTION, 
@@ -953,7 +953,7 @@
  * port - The port number to send to (may be 0)
  */
 void 
-_javanet_sendto(JNIEnv *env, jobject this, jarray buf, int offset, int len,
+_javanet_sendto(JNIEnv *env, jobject thiz, jarray buf, int offset, int len,
                 int addr, int port)
 {
 #ifndef WITHOUT_NETWORK
@@ -965,7 +965,7 @@
   assert((*env)!=NULL);
 
   /* Get the real file descriptor */
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     { 
       JCL_ThrowException(env, IO_EXCEPTION, 
@@ -1008,7 +1008,7 @@
  * Sets the specified option for a socket
  */
 void 
-_javanet_set_option(JNIEnv *env, jobject this, jint option_id, jobject val)
+_javanet_set_option(JNIEnv *env, jobject thiz, jint option_id, jobject val)
 {
 #ifndef WITHOUT_NETWORK
   int       fd;
@@ -1022,7 +1022,7 @@
   assert((*env)!=NULL);
 
   /* Get the real file descriptor */
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     { 
       JCL_ThrowException(env, IO_EXCEPTION, 
@@ -1197,7 +1197,7 @@
  * Retrieves the specified option values for a socket
  */
 jobject 
-_javanet_get_option(JNIEnv *env, jobject this, jint option_id)
+_javanet_get_option(JNIEnv *env, jobject thiz, jint option_id)
 {
 #ifndef WITHOUT_NETWORK
   int fd;
@@ -1209,7 +1209,7 @@
   assert((*env)!=NULL);
 
   /* Get the real file descriptor */
-  fd = _javanet_get_int_field(env, this, "native_fd");
+  fd = _javanet_get_int_field(env, thiz, "native_fd");
   if (fd == -1)
     { 
       JCL_ThrowException(env, SOCKET_EXCEPTION, 
cvs server: Diffing native/jni/java-nio
Index: native/jni/java-nio/java_nio_DirectByteBufferImpl.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-nio/java_nio_DirectByteBufferImpl.c,v
retrieving revision 1.5
diff -u -r1.5 java_nio_DirectByteBufferImpl.c
--- native/jni/java-nio/java_nio_DirectByteBufferImpl.c	29 Mar 2004 07:07:39 -0000	1.5
+++ native/jni/java-nio/java_nio_DirectByteBufferImpl.c	7 Apr 2004 16:22:07 -0000
@@ -46,27 +46,27 @@
 #define IO_EXCEPTION "java/io/IOException"
 
 JNIEXPORT jobject JNICALL
-Java_java_nio_DirectByteBufferImpl_allocateImpl (JNIEnv *env, jclass class, jint size)
+Java_java_nio_DirectByteBufferImpl_allocateImpl (JNIEnv *env, jclass clazz, jint size)
 {
   JCL_ThrowException (env, IO_EXCEPTION, "java.nio.DirectByteBufferImpl.allocateImpl(): not implemented");
   return 0;
 }
 
 JNIEXPORT void JNICALL
-Java_java_nio_DirectByteBufferImpl_freeImpl (JNIEnv *env, jclass class, jobject address)
+Java_java_nio_DirectByteBufferImpl_freeImpl (JNIEnv *env, jclass clazz, jobject address)
 {
   JCL_ThrowException (env, IO_EXCEPTION, "java.nio.DirectByteBufferImpl.freeImpl(): not implemented");
 }
 
 JNIEXPORT jbyte JNICALL
-Java_java_nio_DirectByteBufferImpl_getImpl (JNIEnv *env, jclass class, jint index)
+Java_java_nio_DirectByteBufferImpl_getImpl (JNIEnv *env, jclass clazz, jint index)
 {
   JCL_ThrowException (env, IO_EXCEPTION, "java.nio.DirectByteBufferImpl.getImpl(): not implemented");
   return 0;
 }
 
 JNIEXPORT void JNICALL
-Java_java_nio_DirectByteBufferImpl_putImpl (JNIEnv *env, jclass class, jint index, jbyte value)
+Java_java_nio_DirectByteBufferImpl_putImpl (JNIEnv *env, jclass clazz, jint index, jbyte value)
 {
   JCL_ThrowException (env, IO_EXCEPTION, "java.nio.DirectByteBufferImpl.putImpl(): not implemented");
 }
Index: native/jni/java-nio/java_nio_FileChannelImpl.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-nio/java_nio_FileChannelImpl.c,v
retrieving revision 1.8
diff -u -r1.8 java_nio_FileChannelImpl.c
--- native/jni/java-nio/java_nio_FileChannelImpl.c	29 Mar 2004 07:07:39 -0000	1.8
+++ native/jni/java-nio/java_nio_FileChannelImpl.c	7 Apr 2004 16:22:07 -0000
@@ -87,14 +87,14 @@
 Java_java_nio_channels_FileChannelImpl_nio_1unmmap_1file (JNIEnv *env, jclass clazz, jobject map_address, jint size)
 {
   JCL_ThrowException (env, IO_EXCEPTION, "java.nio.FileChannelImpl.nio_unmmap_file(): not implemented");
-  return 0;
+  return;
 }
 
 JNIEXPORT void JNICALL
 Java_java_nio_channels_FileChannelImpl_nio_1msync (JNIEnv *env, jclass clazz, jobject map_address, jint length)
 {
   JCL_ThrowException (env, IO_EXCEPTION, "java.nio.FileChannelImpl.nio_msync(): not implemented");
-  return 0;
+  return;
 }
 
 JNIEXPORT jint JNICALL
Index: native/jni/java-nio/java_nio_FileLockImpl.c
===================================================================
RCS file: /cvsroot/classpath/classpath/native/jni/java-nio/java_nio_FileLockImpl.c,v
retrieving revision 1.3
diff -u -r1.3 java_nio_FileLockImpl.c
--- native/jni/java-nio/java_nio_FileLockImpl.c	29 Mar 2004 07:07:39 -0000	1.3
+++ native/jni/java-nio/java_nio_FileLockImpl.c	7 Apr 2004 16:22:07 -0000
@@ -46,7 +46,7 @@
 #define IO_EXCEPTION "java/io/IOException"
 
 JNIEXPORT void JNICALL
-Java_gnu_java_nio_FileLockImpl_releaseImpl (JNIEnv *env, jclass class)
+Java_gnu_java_nio_FileLockImpl_releaseImpl (JNIEnv *env, jclass clazz)
 {
   JCL_ThrowException (env, IO_EXCEPTION, "java.nio.FileChannelImpl.(): not implemented");
 }
cvs server: Diffing native/jni/java-util

--------------000106040107080800090203--



From MAILER-DAEMON Wed Apr 07 13:19:55 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBGfQ-000768-Su
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 13:16:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BB1ON-0006L6-L2
	for classpath@gnu.org; Tue, 06 Apr 2004 20:58:11 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BB1Mv-0005y1-EL
	for classpath@gnu.org; Tue, 06 Apr 2004 20:57:12 -0400
Received: from [192.18.98.43] (helo=brmea-mail-2.sun.com)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BB1MN-0005rr-IG; Tue, 06 Apr 2004 20:56:07 -0400
Received: from esunmail ([129.147.156.34])
	by brmea-mail-2.sun.com (8.12.10/8.12.9) with ESMTP id i370u3t1015692; 
	Tue, 6 Apr 2004 18:56:03 -0600 (MDT)
Received: from fe7 (esunmail [129.147.156.34]) by edgemail1.Central.Sun.COM
	(iPlanet Messaging Server 5.2 HotFix 1.21 (built Sep  8 2003))
	with ESMTP id <0HVR006RCZXESP@edgemail1.Central.Sun.COM>; Tue,
	06 Apr 2004 18:56:02 -0600 (MDT)
Received: from [129.145.239.154] by mail.sun.net
	(iPlanet Messaging Server 5.2 HotFix 1.21 (built Sep  8 2003))
	with ESMTPSA id <0HVR00KH8ZXD3N@mail.sun.net>; Tue,
	06 Apr 2004 18:56:02 -0600 (MDT)
Date: Tue, 06 Apr 2004 17:56:00 -0700
From: Onno Kluyt <Onno.Kluyt@Sun.COM>
In-reply-to: <1077666338.880.38.camel@localhost>
To: Mark Wielaard <mark@klomp.org>
Message-id: <56CEE68E-882E-11D8-ADD1-0030656A0676@Sun.Com>
MIME-version: 1.0
X-Mailer: Apple Mail (2.613)
Content-type: multipart/signed; micalg=sha1; boundary=Apple-Mail-36--87053684; 
	protocol="application/pkcs7-signature"
References: <1077574692.1409.201.camel@localhost.localdomain>
	<1077666338.880.38.camel@localhost>
X-Mailman-Approved-At: Wed, 07 Apr 2004 13:16:46 -0400
Cc: gnu@gnu.org, classpath@gnu.org, Michael Emmel <memmel@savaJe.com>
Subject: Re: SCSL and FSF
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 00:58:12 -0000


--Apple-Mail-36--87053684
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=US-ASCII;
	delsp=yes;
	format=flowed

Any progress?

Onno.

On Feb 24, 2004, at 15:45, Mark Wielaard wrote:

> Hi,
>
> On Mon, 2004-02-23 at 23:18, Michael Emmel wrote:
>> Sun has offered to clarify the SCSL license and its effect on projects
>> such and Gnu Classpath.
>>
>> This happened in the following discussion thread
>>
>> http://www.javalobby.org/thread.jspa? 
>> messageID=91789909&threadID=11559&forumID=61
>
> Thanks for forwarding this.
> Good to see so much enthousiasm about our FOSDEM meeting. It really  
> does
> feel like we have enough critical mass now. There is now enough free
> code for the libraries, VMs and compilers to do useful things. And
> people are now actually using it to creating completely free
> applications. So we will see lots of interesting things for the free
> platforms in the near future.
>
> I'll try to formulate the concerns of the Free Software projects about
> the SCSL, contributions of people who have studied other  
> implementations
> of the core classes that want to help the free projects (contributions
> which we currently cannot accept since legal counsel has advised  
> against
> that) and the way we think the JCP process and the TCK
> licensing/distribution terms are unhelpful now for collaboration on  
> Free
> Software implementations.
>
> Please give me a couple of days to contact the right people. And to  
> make
> sure we formulate our questions and concerns coherently. I want to  
> avoid
> an ESR style letter which I think is not helpful. Hopefully we can  
> start
> a dialog that helps both the people that care about the Free Software
> movement and people that care about standardization of jave-like
> platforms. I'll make sure to contact Onno with some specific issues in
> the next two weeks
>
> Sincerely,
>
> Mark Wielaard
> GNU Classpath Maintainer

--Apple-Mail-36--87053684
Content-Transfer-Encoding: base64
Content-Type: application/pkcs7-signature;
	name=smime.p7s
Content-Disposition: attachment;
	filename=smime.p7s

MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGGDCCAtEw
ggI6oAMCAQICAwu/QzANBgkqhkiG9w0BAQQFADBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhh
d3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVt
YWlsIElzc3VpbmcgQ0EwHhcNMDQwMjE4MTgxNjU4WhcNMDUwMjE3MTgxNjU4WjBEMR8wHQYDVQQD
ExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMSEwHwYJKoZIhvcNAQkBFhJPbm5vLktsdXl0QFN1bi5D
b20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC78DD+F68Wcentk7v4XvZjHmIZUUyM
FNP111WcxR4pRvSDZ/wSIvjeHISE3n2GAlVsM80mdoFWPLReYuEbVdTRIs7qefzwadKdR2BOG6Wp
oZ3YxIDqQUu3/61fs+TjRoey4FLfAr33Cy/Nxl6eFJkJZAX8K1qeikyM4LvWngAD6b37LmZEChbR
Loonv7B+r+HlDjlJU5gbuq1NSP7rs4u1iefvoW/aqI6JzYO5VzEilTm1lCDVeQu2Ro3gKhjxMcc2
+qOhZf3dPlMD9xOY9x8AsqyMz/xuIq/mkRmAFggfJUmv1PEBItyT0+oMFpf5AOJMXKmZ5c+IRVV/
LTzUUfM3AgMBAAGjLzAtMB0GA1UdEQQWMBSBEk9ubm8uS2x1eXRAU3VuLkNvbTAMBgNVHRMBAf8E
AjAAMA0GCSqGSIb3DQEBBAUAA4GBAHYXAApZvniohGZlQux2xd14Peq9SZvNX92Gzhw7+a3CRdz+
dU6+rkB5QbcTe2WZG8P8XwzeK7qoUOZZBnwr3l4jm5+ooLKJeGsASJ7JzVdkSJNpxdzKKny1c6YE
K9I7flOYX2cTGbPPYVKwmG67DGK+fhDAs+lXQ+5B17vN7O9vMIIDPzCCAqigAwIBAgIBDTANBgkq
hkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkExFTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UE
BxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlm
aWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEkMCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVt
YWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJzb25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAz
MDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVowYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0
ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFp
bCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1
BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fx
H5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTXp6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wID
AQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8CAQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2Ny
bC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFsRnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkG
A1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOB
gQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aUnX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZ
foSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4
gtwhGTXeJLHTHUb/XV9lTzGCAucwggLjAgEBMGkwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRo
YXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVl
bWFpbCBJc3N1aW5nIENBAgMLv0MwCQYFKw4DAhoFAKCCAVMwGAYJKoZIhvcNAQkDMQsGCSqGSIb3
DQEHATAcBgkqhkiG9w0BCQUxDxcNMDQwNDA3MDA1NjAxWjAjBgkqhkiG9w0BCQQxFgQUDHQdENzy
2dLp2Ng4NttuM8rg2z0weAYJKwYBBAGCNxAEMWswaTBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMc
VGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZy
ZWVtYWlsIElzc3VpbmcgQ0ECAwu/QzB6BgsqhkiG9w0BCRACCzFroGkwYjELMAkGA1UEBhMCWkEx
JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ
ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAgMLv0MwDQYJKoZIhvcNAQEBBQAEggEAKNEIjv24
vxvnodRzQ+Kj1r/9A12AWSSHsVvAWVKbkLN6Dd/Ovk4HzrwH++DQ13aMb53P9vZkkwcQbZrnMeDT
NxuFcSb9A89MANBrDEcao/kNx+iAwdb5wtXnrUXXJTCdgx7vOix3Nmo+c0cp2/lPpds/i8rVrBn5
dxInOo5E/YgTm5dI6ta8cBoO5krXubfDSrHeL0RETpHwWQWsF/jE85m+gVjh1KoAV6deQ3koXFzn
RIbhCg/YfIVJjTEAXIZFsl3uaDLsKxHufukM2TFjFfDugMmUvIPfLM6qdUTaW8OhhFt6cM7JhBvg
5yFwd6/pOWVQMhXphU37q4q/aA+SUQAAAAAAAA==

--Apple-Mail-36--87053684--




From MAILER-DAEMON Wed Apr 07 13:59:08 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBHKN-00072U-2A
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 13:59:07 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBHKD-0006yw-Km
	for classpath@gnu.org; Wed, 07 Apr 2004 13:58:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBHJf-0006jv-7Q
	for classpath@gnu.org; Wed, 07 Apr 2004 13:58:54 -0400
Received: from [194.9.168.22] (helo=sites.presencepark.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBHA3-0003qD-UL
	for classpath@gnu.org; Wed, 07 Apr 2004 13:48:28 -0400
Received: from dsl-082-082-156-031.arcor-ip.net ([82.82.156.31] helo=moe)
	by sites.presencepark.de with smtp (Exim 3.16 #3) id 1BBHA2-00021P-00
	for classpath@gnu.org; Wed, 07 Apr 2004 19:48:26 +0200
Message-ID: <001501c41cc8$86ecf690$897ba8c0@moe>
From: "Chr. Ullenboom" <C.Ullenboom@java-tutor.com>
To: <classpath@gnu.org>
Date: Wed, 7 Apr 2004 19:48:24 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1158
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Subject: An interessting change for shared char[] in String/StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 17:58:59 -0000

>From http://java.sun.com/j2se/1.5.0/jcp/beta1/index.html#java.lang:

"In this release, the sharing between String and StringBuffer has been
eliminated."

Does this mean to change to change the implementation in Classpath too? I
like this optimization...

Bye,

Chr. Ullenboom




From MAILER-DAEMON Wed Apr 07 14:00:13 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBHLQ-0007Vr-Vd
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 14:00:12 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBHLO-0007UO-1X
	for classpath@gnu.org; Wed, 07 Apr 2004 14:00:10 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBHKm-0007FE-JI
	for classpath@gnu.org; Wed, 07 Apr 2004 14:00:03 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBHKm-0007EC-2X
	for classpath@gnu.org; Wed, 07 Apr 2004 13:59:32 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-006.ewetel.net
	[80.228.94.6])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i37HxTpH008463;
	Wed, 7 Apr 2004 19:59:29 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBGOr-0001s9-00; Wed, 07 Apr 2004 18:59:41 +0200
From: Michael Koch <konqueror@gmx.de>
To: Ingo =?iso-8859-1?q?Pr=F6tel?= <proetel@aicas.com>,
	Classpath Discussion Mailing List <classpath@gnu.org>
Date: Wed, 7 Apr 2004 19:59:14 +0200
User-Agent: KMail/1.5.4
References: <40742D2A.7040206@aicas.com>
In-Reply-To: <40742D2A.7040206@aicas.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Disposition: inline
Message-Id: <200404071959.14273.konqueror@gmx.de>
X-CheckCompat: OK
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mail3.ewetel.de id
	i37HxTpH008463
Cc: 
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 18:00:10 -0000

Am Mittwoch, 7. April 2004 18:32 schrieb Ingo Pr=F6tel:
> Hi,
>
> I would like to suggest removing all C++ keywords as names in the
> native implementations of GNU Classpath. We have a customer who
> insists on using C++ because of the more thorough code inspection. To
> be able to compile with such a compiler we need to change all names
> that are C++ keywords.
>
> I have attached cases where we already have changed this.
> My feeling is that if we have the 'extern "C"' construct in the
> header files we should also try to have the code compilable with a
> C++ compiler.
>
> Let me know what you think.

Personally I think using "obj" or so is better then using "thiz".



Michael




From MAILER-DAEMON Wed Apr 07 14:28:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBHn9-0004nq-Ui
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 14:28:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBHn6-0004n5-SO
	for classpath@gnu.org; Wed, 07 Apr 2004 14:28:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBHma-0004dH-Nm
	for classpath@gnu.org; Wed, 07 Apr 2004 14:28:47 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBHma-0004d6-B8
	for classpath@gnu.org; Wed, 07 Apr 2004 14:28:16 -0400
Received: from [212.6.122.96] (helo=mail0.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBHc0-0006mm-VK
	for classpath@gnu.org; Wed, 07 Apr 2004 14:17:21 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-006.ewetel.net
	[80.228.94.6])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i37IG6X3023371;
	Wed, 7 Apr 2004 20:16:07 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBGew-0001yi-00; Wed, 07 Apr 2004 19:16:18 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Chr. Ullenboom" <C.Ullenboom@java-tutor.com>, <classpath@gnu.org>
Date: Wed, 7 Apr 2004 20:15:51 +0200
User-Agent: KMail/1.5.4
References: <001501c41cc8$86ecf690$897ba8c0@moe>
In-Reply-To: <001501c41cc8$86ecf690$897ba8c0@moe>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404072015.51700.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: An interessting change for shared char[] in String/StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 18:28:49 -0000

Am Mittwoch, 7. April 2004 19:48 schrieb Chr. Ullenboom:
> From http://java.sun.com/j2se/1.5.0/jcp/beta1/index.html#java.lang:
>
> "In this release, the sharing between String and StringBuffer has
> been eliminated."
>
> Does this mean to change to change the implementation in Classpath
> too? I like this optimization...

Let us wait until 1.5.0 final is out. I wouldnt like changing it now 
then reverting it later again because Sun removed it again ...


Michael




From MAILER-DAEMON Wed Apr 07 16:38:46 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBJor-0000TX-Ev
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 16:38:45 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBJoi-0000R8-C1
	for classpath@gnu.org; Wed, 07 Apr 2004 16:38:36 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBJoB-0000Hz-Po
	for classpath@gnu.org; Wed, 07 Apr 2004 16:38:34 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBJoB-0000HU-Ji
	for classpath@gnu.org; Wed, 07 Apr 2004 16:38:03 -0400
Received: from [132.206.3.88] (helo=relay10.cs.mcgill.ca)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBJnV-0004EK-Ox
	for classpath@gnu.org; Wed, 07 Apr 2004 16:37:21 -0400
Received: from pinto.cs.mcgill.ca (pinto.CS.McGill.CA [132.206.3.79])
	by relay10.cs.mcgill.ca (Postfix) with ESMTP id 01296536F4D;
	Wed,  7 Apr 2004 16:37:19 -0400 (EDT)
Received: from pinto.cs.mcgill.ca (dbelan2@localhost [127.0.0.1])
	by pinto.cs.mcgill.ca (8.12.3/8.12.3/Debian-6.6) with ESMTP id
	i37KbIes027069; Wed, 7 Apr 2004 16:37:18 -0400
Received: (from dbelan2@localhost)
	by pinto.cs.mcgill.ca (8.12.3/8.12.3/Debian-6.6) id i37KbIH4027067;
	Wed, 7 Apr 2004 16:37:18 -0400
Date: Wed, 7 Apr 2004 16:37:18 -0400
From: David =?iso-8859-1?Q?B=E9langer?= <dbelan2@cs.mcgill.ca>
To: "S. Meslin-Weber" <twiun@adorphuye.com>
Message-ID: <20040407203718.GB26956@pinto.cs.mcgill.ca>
References: <20040405091411.GG5755@tangency.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20040405091411.GG5755@tangency.co.uk>
User-Agent: Mutt/1.3.28i
Content-Transfer-Encoding: quoted-printable
Cc: SableVM <sablevm-developer@lists.sourceforge.net>,
	GNU Classpath <classpath@gnu.org>
Subject: Re: Odonata+SableVM+Classpath works! (and bootclasspath question)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 20:38:37 -0000

On Mon, Apr 05, 2004 at 10:14:11AM +0100, S. Meslin-Weber wrote:
> Hi everyone,
>=20
> As reported on #sablevm I'm happy to say that Odonata[1] runs well unde=
r
> SableVM. I haven't measured any speeds or memory usage but with regards
> to visual output SableVM is on a par with GIJ (both use GNU Classpath,
> I know, but I didn't want to assume that all JVM using GNU Classpath
> would give the same results). I believe that the GNUClasspath AWT is th=
e
> cause of any visual/behavioural discrepancies I see when running Odonat=
a
> on SableVM (and GIJ) and on Sun's 1.4.2 Java2 SDK.
>=20

Hi,

Good work!

> On a related note, I develop Odonata against Sun's 1.4.2 Java2 SDK and
> make use of the -Xbootclasspath/p feature to prepend my classes ahead o=
f
> the JVM's own classes so that mine will be loaded in preference to any
> default ones.
>=20
> With SableVM I had to resort to extracting my jar file *over* SableVM's
> core classpath installation. This is due to the bootclasspath argument
> in SableVM seemingly not being able to take more than one path. Ideally=
,
> Sun-like arguments to override, append or prepend to the bootclasspath
> would be highly beneficial.
>=20

Yes, this functionality is currently not in SableVM.

In case you or some SableVM developer is interested, it should
be relatively easy to change the code in:
function _svmh_bootcl_internal_load_class_file
in file src/libsablevm/class_loader.c
to parse the boot class path property for multiple paths.

This will allow an override but with multiple paths.  Ex:
your_path:sablevm_boot_classpath

The next step will consist of playing with src/sablevm/sablevm.c
to add append, prepend options.



David

---

David B=E9langer
Graduate Student
School of Computer Science
McGill University
Office: MC226

Web page:   http://www.cs.mcgill.ca/~dbelan2/
Public key: http://www.cs.mcgill.ca/~dbelan2/public_key.txt




From MAILER-DAEMON Wed Apr 07 17:26:20 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBKYt-0000yV-IG
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 17:26:19 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBKYm-0000v3-2a
	for classpath@gnu.org; Wed, 07 Apr 2004 17:26:12 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBKYE-0000gr-6x
	for classpath@gnu.org; Wed, 07 Apr 2004 17:26:09 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBKYD-0000fm-Kp
	for classpath@gnu.org; Wed, 07 Apr 2004 17:25:37 -0400
Received: (qmail 312 invoked from network); 7 Apr 2004 21:27:21 -0000
Received: from tf0229.peakpeak.com (HELO fleche.redhat.com) ([204.144.239.229])
	(envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <proetel@aicas.com>; 7 Apr 2004 21:27:21 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 86D934F82AF; Wed,  7 Apr 2004 15:13:57 -0600 (MDT)
To: =?iso-8859-15?q?Ingo_Pr=F6tel?= <proetel@aicas.com>
References: <40742D2A.7040206@aicas.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Half a mind is a terrible thing to waste!
Date: 07 Apr 2004 15:13:57 -0600
In-Reply-To: <40742D2A.7040206@aicas.com>
Message-ID: <87y8p7v6cq.fsf@fleche.redhat.com>
Lines: 26
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 21:26:16 -0000

>>>>> "Ingo" == Ingo Prötel <proetel@aicas.com> writes:

Ingo> I would like to suggest removing all C++ keywords as names in
Ingo> the native implementations of GNU Classpath. We have a customer
Ingo> who insists on using C++ because of the more thorough code
Ingo> inspection.  To be able to compile with such a compiler we need
Ingo> to change all names that are C++ keywords.

I think this idea is fine.  It doesn't bother me anyway... though I'd
suggest waiting for a response from folks who hack on the JNI code
more than me :-)

My only comment or criticism is that, in the absence of regular
checking for this, we'll just see more code like it checked in.
That's been the experience with non-C89 constructs, I don't see why
this would be any different.  It's just too hard to remember to write
in some language subset without compiler-assisted checking.

We could declare all the JNI code to actually be C++, of course.  But
then we'd see real C++ usage slip in.

A third option would be for you to periodically try it out and check
in patches like the one you sent :-).  Assuming the other developers
are ok with this, it wouldn't be unreasonable, just a bit messy.

Tom



From MAILER-DAEMON Wed Apr 07 17:28:45 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBKbF-00021C-Nb
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 17:28:45 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBKb6-0001yA-C0
	for classpath@gnu.org; Wed, 07 Apr 2004 17:28:36 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBKaZ-0001kQ-OB
	for classpath@gnu.org; Wed, 07 Apr 2004 17:28:34 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBKaY-0001k6-Ur
	for classpath@gnu.org; Wed, 07 Apr 2004 17:28:03 -0400
Received: (qmail 1788 invoked from network); 7 Apr 2004 21:29:49 -0000
Received: from tf0229.peakpeak.com (HELO fleche.redhat.com) ([204.144.239.229])
	(envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 7 Apr 2004 21:29:49 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 9D66C4F82AF; Wed,  7 Apr 2004 15:16:25 -0600 (MDT)
To: "Chr. Ullenboom" <C.Ullenboom@java-tutor.com>
References: <001501c41cc8$86ecf690$897ba8c0@moe>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Two with FLUFFO, hold th' BEETS..side of SOYETTES!
Date: 07 Apr 2004 15:16:25 -0600
In-Reply-To: <001501c41cc8$86ecf690$897ba8c0@moe>
Message-ID: <87u0zvv68m.fsf@fleche.redhat.com>
Lines: 14
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: An interessting change for shared char[] in String/StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 21:28:44 -0000

>>>>> ">" == Chr Ullenboom <C.Ullenboom@java-tutor.com> writes:

>> From http://java.sun.com/j2se/1.5.0/jcp/beta1/index.html#java.lang:
>> "In this release, the sharing between String and StringBuffer has been
>> eliminated."
>> Does this mean to change to change the implementation in Classpath too? I
>> like this optimization...

I don't think we necessarily have to change this.  IMO it would depend
on whether the change is observable by user code.  Our implementation
doesn't always share, anyway.  It only shares if the buffer is mostly
in use.

Tom



From MAILER-DAEMON Wed Apr 07 19:29:08 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBMPz-0000IB-Cy
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 19:25:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBMPl-0000Eh-4l
	for classpath@gnu.org; Wed, 07 Apr 2004 19:25:01 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBMPB-0008Vy-S9
	for classpath@gnu.org; Wed, 07 Apr 2004 19:24:58 -0400
Received: from [213.180.130.37] (helo=smtp3k.poczta.onet.pl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBMPB-0008VU-5i
	for classpath@gnu.org; Wed, 07 Apr 2004 19:24:25 -0400
Received: from mizzar.multicon.pl ([213.77.83.2]:11012 "EHLO adres.pl")
	by kps3.test.onet.pl with ESMTP id <S2660777AbUDGXYP>;
	Thu, 8 Apr 2004 01:24:15 +0200
Message-ID: <40748D9A.6070406@adres.pl>
Date: Thu, 08 Apr 2004 01:24:10 +0200
From: Artur Biesiadowski <abies@adres.pl>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
CC: classpath@gnu.org
References: <001501c41cc8$86ecf690$897ba8c0@moe>
	<87u0zvv68m.fsf@fleche.redhat.com>
In-Reply-To: <87u0zvv68m.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
To: unlisted-recipients:; (no To-header on input)
Subject: Re: An interessting change for shared char[] in String/StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: abies@pg.gda.pl
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2004 23:25:11 -0000

Tom Tromey wrote:

>>>From http://java.sun.com/j2se/1.5.0/jcp/beta1/index.html#java.lang:
>>>"In this release, the sharing between String and StringBuffer has been
>>>eliminated."
>>>Does this mean to change to change the implementation in Classpath too? I
>>>like this optimization...
> 
> 
> I don't think we necessarily have to change this.  IMO it would depend
> on whether the change is observable by user code.  Our implementation
> doesn't always share, anyway.  It only shares if the buffer is mostly
> in use.

'Observable by user code' is very broad term. It is possible to write a 
short program which will throw OutOfMemoryException with sharing on and 
work without problems when data is always copied - does it counts as 
observation from user code ?

Artur



From MAILER-DAEMON Wed Apr 07 20:19:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBNGn-0006dm-Ad
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 20:19:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBNGj-0006cm-BM
	for classpath@gnu.org; Wed, 07 Apr 2004 20:19:45 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBNGC-0006Tf-Ie
	for classpath@gnu.org; Wed, 07 Apr 2004 20:19:43 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBNGC-0006Sh-85
	for classpath@gnu.org; Wed, 07 Apr 2004 20:19:12 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i37KRjD4013414;
	Wed, 7 Apr 2004 16:28:09 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040716292302945 ; Wed, 07 Apr 2004 16:29:24 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i37I9FtS027608; Wed, 7 Apr 2004 14:09:15 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BBHUB-0005iF-HD; Wed, 07 Apr 2004 14:09:15 -0400
Message-ID: <407443C9.3060808@uqam.ca>
Date: Wed, 07 Apr 2004 14:09:13 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Per Bothner <per@bothner.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
	<40740DFF.50108@bothner.com>
In-Reply-To: <40740DFF.50108@bothner.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 00:19:46 -0000

Per Bothner wrote:
 > ....  I can see on a few JVMs it may cause problems,
 > but they can easily sed the source to convert RawData to long.
 > Just think of RawData has a macro.

I am starting to have difficulty understanding Classpath's goals and 
motivations.

When I proposed to add to Classpath some mechanism to allow it to be 
customized to each VM, I was told that it would be a heresy to encode 
any VM-specific thing into Classpath, as the vision was: a single 
Classpath installation would be shared by many VMs on a single system, 
e.g. common class libraries, common JNI libraries, etc.

Now, what you are proposing is that JNI libraries would be compiled 
specifically for each VM.  What have I missed?

Etienne



-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Wed Apr 07 20:26:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBNNa-0001Tu-Lg
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 20:26:50 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBNNW-0001Pr-IH
	for classpath@gnu.org; Wed, 07 Apr 2004 20:26:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBNMy-0001HU-Vf
	for classpath@gnu.org; Wed, 07 Apr 2004 20:26:45 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBNLc-0000yE-7T
	for classpath@gnu.org; Wed, 07 Apr 2004 20:24:48 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i37MSSDS001619;
	Wed, 7 Apr 2004 18:28:47 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040718300220003 ; Wed, 07 Apr 2004 18:30:02 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i37JH80T018637; Wed, 7 Apr 2004 15:17:08 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BBIXs-0005l4-2q; Wed, 07 Apr 2004 15:17:08 -0400
Message-ID: <407453B0.9020402@uqam.ca>
Date: Wed, 07 Apr 2004 15:17:04 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>	<4071E699.8020809@uqam.ca>	<4071E9BA.6080504@uqam.ca>	<16498.30144.189924.141228@cuddles.cambridge.redhat.com>	<40731058.2060208@uqam.ca>	<16499.54723.302361.515836@cuddles.cambridge.redhat.com>	<20040407130512.GA20855@perseval.info.uqam.ca>
	<16500.730.818712.833827@cuddles.cambridge.redhat.com>
In-Reply-To: <16500.730.818712.833827@cuddles.cambridge.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 00:26:47 -0000

Andrew Haley wrote:
> Okay, but ANS specifically does not allow you to do this subtraction.
> Also, there is no guarantee that every pointer is representable as a
> ptrdiff_t.  (6.5.6 Para 9, if you're interested)

The point is: if your platform is one that does *not* have 8-bit chars (!!!),
then you can simply rewrite the appropriate code to put some bit representation
of your pointer into a jbyte array (using whatever trick you need), and the only
  place where you would have to do it is the the wrap/unwarp functions.  No
modification on the Java side.

MORE IMPORTANTLY: As long as your platform has 8-bit chars/bytes (99,9%),
[and that no crasy person decided that on such platform jbyte would be
different from signed char!!!!], then my proposed code will just work
out-of-the-box, and be quite efficient (for JNI code).

Comment: Now that you raised 6.5.6 para 9: how do you intend to cast such
pointer to a jlong, in your proposal?  [ironic]

OK. Let's stop splitting hairs in half.  I have showed you a valuable and
practical proposal.  I'd like to see your full proposal, JNI part included.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Wed Apr 07 21:16:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBO9X-0002wU-Ff
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 21:16:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBO9U-0002ut-Oj
	for classpath@gnu.org; Wed, 07 Apr 2004 21:16:20 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBO8v-0002X2-LC
	for classpath@gnu.org; Wed, 07 Apr 2004 21:16:16 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBO6S-0001JW-Gr
	for classpath@gnu.org; Wed, 07 Apr 2004 21:13:12 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBNqQ-0001wB-0m
	for classpath@gnu.org; Wed, 07 Apr 2004 20:56:38 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i380pH1a013005;
	Wed, 7 Apr 2004 20:52:09 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040720532406730 ; Wed, 07 Apr 2004 20:53:24 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i37LVFbM001540; Wed, 7 Apr 2004 17:31:15 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BBKdf-0005pr-IH; Wed, 07 Apr 2004 17:31:15 -0400
Message-ID: <40747320.50501@uqam.ca>
Date: Wed, 07 Apr 2004 17:31:12 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <40742D2A.7040206@aicas.com> <200404071959.14273.konqueror@gmx.de>
In-Reply-To: <200404071959.14273.konqueror@gmx.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 01:16:21 -0000

Michael Koch wrote:
>>Let me know what you think.

Makes sense to me.

> Personally I think using "obj" or so is better then using "thiz".

Agree. I like "obj" instead of "this".  [I don't like "thiz"]
Similarly, I like "cls" instead of "class".  [I don't like "clazz"]

Etienne


-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Wed Apr 07 21:29:22 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBOM6-0002ET-GR
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 21:29:22 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBOM3-0002E2-Mu
	for classpath@gnu.org; Wed, 07 Apr 2004 21:29:19 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBOLX-0002B4-Nd
	for classpath@gnu.org; Wed, 07 Apr 2004 21:29:18 -0400
Received: from [212.227.126.176] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBOLX-0002Ay-0k
	for classpath@gnu.org; Wed, 07 Apr 2004 21:28:47 -0400
Received: from [212.227.126.155] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BB92Y-0007bW-00; Wed, 07 Apr 2004 11:08:10 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BB91b-0006Qe-00; Wed, 07 Apr 2004 11:07:11 +0200
Message-ID: <4073C4C8.7070609@aicas.com>
Date: Wed, 07 Apr 2004 11:07:20 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADC0E@LEMBU.sumatrasoftware.com>	<200404051926.48137.konqueror@gmx.de>	<16497.38859.782758.253972@cuddles.cambridge.redhat.com>	<200404051942.41173.konqueror@gmx.de>	<16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>	<4071E699.8020809@uqam.ca>	<4071E9BA.6080504@uqam.ca>	<16498.30144.189924.141228@cuddles.cambridge.redhat.com>
	<40731058.2060208@uqam.ca>
In-Reply-To: <40731058.2060208@uqam.ca>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 01:29:20 -0000

Hi Etienne,

while I think that your proposal would work with our VM it would also be quite ineficient.
Our arrays can be fragemented so we nee to do some magic when accessing them in native code.

Do you have any system that requires a pointer size larger than 64bits ?
My feeling is that once we hit systems of that size Java is in trouble for having "only" 63bits for 
file size and 31 bits array indces.

ingo

Etienne Gagnon wrote:
> Andrew Haley wrote:
> 
>> Maybe, but that's not the only thing.  It's possible to define jbyte
>> so that it is an 8 bit signed value but not a character type, and JNI
>> does not forbid this.  I suspect that all the platforms we use define
>> jbyte to be a character type, but I can see no overpowering reason to
>> introduce a dependency on that.
> 
> 
> "jbyte" must have a single platform-specific definition, as all JVMs on 
> that
> platform should be able to execute the same JNI library code (no 
> recompilation
> required).  I would argue that if a char type has 8 bits on a platform, 
> there
> is a strong case for it to be defined as "typedef signed char jbyte", 
> and I would
> gues VM implementors would be veery unhappy if Sum (or any other) 
> decided to
> define jbyte otherwise on that platform.
> 
> BUT....  I agree, it could be false on some system.  So, assuming the 
> worst-case
> scenario, I have attached an updated version of my byte array proposal that
> is, as far as I can tell, robust across all possible platforms.
> 
> It contains 2 utility "inline" functions: wrap and unwrap.  I provide 2 
> versions
> of each, one version for systems where jbyte == signed char, and one 
> version
> for systems where jbyte != signed char.  A test function, ideal for use in
> an autoconf macro, is provided that issues a warning when jbyte != 
> signed char.
> 
> So, Andrew, does this version pass the portability test?
> 
> I would really like to see the native counterpart of your opaque types and
> compare the "theoretical" performance of it relative to the byte array
> proposal.
> 
> Etienne
> 
> 

-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany



From MAILER-DAEMON Wed Apr 07 23:10:25 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBPvt-0002MQ-Hq
	for mharc-classpath@gnu.org; Wed, 07 Apr 2004 23:10:25 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBPvq-0002Lm-Je
	for classpath@gnu.org; Wed, 07 Apr 2004 23:10:22 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBPvK-0002Gq-FG
	for classpath@gnu.org; Wed, 07 Apr 2004 23:10:21 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBPs9-0001vZ-2l
	for classpath@gnu.org; Wed, 07 Apr 2004 23:06:33 -0400
Received: from sp1n294en1.watson.ibm.com (sp1n294en1.watson.ibm.com
	[129.34.20.40])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i3836Nq58030 for <classpath@gnu.org>; Wed, 7 Apr 2004 23:06:24 -0400
Received: from sp1n294en1.watson.ibm.com (localhost [127.0.0.1])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i3836MO44774
	for <classpath@gnu.org>; Wed, 7 Apr 2004 23:06:23 -0400
Received: from watson.ibm.com (sig-9-49-150-146.mts.ibm.com [9.49.150.146])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i3836Lx44772; Wed, 7 Apr 2004 23:06:21 -0400
Message-ID: <4074C1A8.5020009@watson.ibm.com>
Date: Wed, 07 Apr 2004 23:06:16 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en, it, eo, pt, gl, es-ec, es-us, es, fr, ast, el
MIME-Version: 1.0
To: classpath@gnu.org
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by igw2.watson.ibm.com id
	i3836Nq58030
Subject: Localization patches for gnu.regexp
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 03:10:23 -0000

Here are some localization patches for the gnu.regexp package's
messages.

Index: ChangeLog
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/classpath/classpath/ChangeLog,v
retrieving revision 1.1982
diff -I*.class -u -r1.1982 ChangeLog
--- ChangeLog	7 Apr 2004 14:38:23 -0000	1.1982
+++ ChangeLog	7 Apr 2004 18:38:53 -0000
@@ -1,3 +1,21 @@
+2004-04-07  Steven Augart  <augart@watson.ibm.com>
+
+	* resource/gnu/regexp/MessageBundle.properties: Replaced the
+	incorrect use of "expected" with "unexpected"
+
+	* resource/gnu/regexp/MessageBundle_fr.properties:  Corrected use of
+	apostrophe.  In properties files, a literal apostrophe has to be
+	doubled:
+	   l''=E9l=E9ment
+	instead of
+	   l'=E9l=E9ment
+
+        Translated the above "expected" =3D> "unexpected" change as
+	"attendue" =3D> "non attendue"
+=09
+	* resource/gnu/regexp/MessageBundle_it.properties: New file; a
+	translation into Italian.
+=09
  2004-04-07  Ingo Proetel  <proetel@aicas.com>

  	* java/awt/image/SampleModel.java (<init>): Added error cause informat=
ion to
Index: resource/gnu/regexp/MessagesBundle.properties
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/classpath/classpath/resource/gnu/regexp/MessagesBundle=
.properties,v
retrieving revision 1.1
diff -I*.class -u -r1.1 MessagesBundle.properties
--- resource/gnu/regexp/MessagesBundle.properties	7 Mar 2004 23:58:54 -00=
00	1.1
+++ resource/gnu/regexp/MessagesBundle.properties	7 Apr 2004 18:38:53 -00=
00
@@ -11,11 +11,11 @@
  unmatched.brace=3Dunmatched brace
  unmatched.bracket=3Dunmatched bracket
  unmatched.paren=3Dunmatched parenthesis
-interval.no.end=3Dexpected end of interval
-class.no.end=3Dexpected end of character class
-subexpr.no.end=3Dexpected end of subexpression
-interval.order=3Dinterval minimum is greater than maximum
-interval.error=3Dinterval is empty or contains illegal characters
+interval.no.end=3Dunexpected end of interval
+class.no.end=3Dunexpected end of character class
+subexpr.no.end=3Dunexpected end of subexpression
+interval.order=3Dan interval''s minimum is greater than its maximum
+interval.error=3Dan interval is empty or contains illegal characters
  ends.with.backslash=3Dbackslash at end of pattern

  # RESyntax message
Index: resource/gnu/regexp/MessagesBundle_fr.properties
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/classpath/classpath/resource/gnu/regexp/MessagesBundle=
_fr.properties,v
retrieving revision 1.1
diff -I*.class -u -r1.1 MessagesBundle_fr.properties
--- resource/gnu/regexp/MessagesBundle_fr.properties	7 Mar 2004 23:58:54 =
-0000	1.1
+++ resource/gnu/regexp/MessagesBundle_fr.properties	7 Apr 2004 18:38:53 =
-0000
@@ -4,18 +4,18 @@
  error.prefix=3DA l''index {0} dans le mod=E8le d''expression r=E9guli=E8=
re:

  # REException (parse error) messages
-repeat.assertion=3Dl'=E9l=E9ment r=E9p=E9t=E9 est de largeur z=E9ro
-repeat.chained=3Dtentative de r=E9p=E9tition d'un =E9l=E9ment d=E9j=E0 r=
=E9p=E9t=E9
+repeat.assertion=3Dl''=E9l=E9ment r=E9p=E9t=E9 est de largeur z=E9ro
+repeat.chained=3Dtentative de r=E9p=E9tition d''un =E9l=E9ment d=E9j=E0 =
r=E9p=E9t=E9
  repeat.no.token=3Dquantifieur (?*+{}) sans =E9l=E9ment pr=E9c=E9dent
-repeat.empty.token=3Dl'=E9l=E9ment r=E9p=E9t=E9 peut =EAtre vide
+repeat.empty.token=3Dl''=E9l=E9ment r=E9p=E9t=E9 peut =EAtre vide
  unmatched.brace=3Daccolade in=E9gal=E9e
  unmatched.bracket=3Dcrochet in=E9gal=E9
  unmatched.paren=3Dparenth=E8se in=E9gal=E9e
-interval.no.end=3Dfin d'interval attendue
-class.no.end=3Dfin de classe de caract=E8res attendue
-subexpr.no.end=3Dfin de sous-expression attendue
-interval.order=3Dl'interval minimum est sup=E9rieur =E0 l'interval maxim=
um
-interval.error=3Dl'interval est vide ou contient des caract=E8res ill=E9=
gaux
+interval.no.end=3Dfin d''interval non attendue
+class.no.end=3Dfin de classe de caract=E8res non attendue
+subexpr.no.end=3Dfin de sous-expression non attendue
+interval.order=3Dl''interval minimum est sup=E9rieur =E0 l''interval max=
imum
+interval.error=3Dl''interval est vide ou contient des caract=E8res ill=E9=
gaux
  ends.with.backslash=3Dantislash =E0 la fin du mod=E8le

  # RESyntax message

Index: resource/gnu/regexp/MessagesBundle_it.properties
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- /dev/null	2003-01-30 05:24:37.000000000 -0500
+++ resource/gnu/regexp/MessagesBundle_it.properties	2004-04-07 14:30:22.=
000000000 -0400
@@ -0,0 +1,31 @@
+# Localized error messages for gnu.regexp, in Italian.
+# $Id$
+# Messaggi italiani per gnu.regexp.
+#
+# Attenzione: Questa traduzione fu scritto da un italo-americano.
+#	Per favore correggete l'italiano bestemmiato e mandate i patch
+#	al listo <classpath at gnu dot org>.
+#
+# @author Steven Augart <steve at watson dot ibm dot com>, <steve at aug=
art dot com>
+
+# Prefix for REException messages
+error.prefix=3DAl indice {0} nel modello dell''espressione regulare:
+
+# REException (parse error) messages
+repeat.assertion=3Dl''elemento ripetuto ha larghezza zero
+repeat.chained=3Dprova di ripetere un elemento gi=E1 ripetuto
+repeat.no.token=3Dquantificatore (?*+{}) senza elemento precedente
+repeat.empty.token=3Dl''elemento ripetuto pu=F2 essere vuoto
+unmatched.brace=3Dparentesi quadra senza corrispondente
+unmatched.bracket=3Dgraffa senza corrispondente
+unmatched.paren=3Dparentesi senza corrispondente
+interval.no.end=3Dla fine dell''intervallo =E9 imprevista
+class.no.end=3Dla fine della classe di caratteri =E9 imprevista
+subexpr.no.end=3Dla fine del sub-espressione =E9 imprevista
+interval.order=3Dil valore minimo dell''intervallo =E9 pi=F9 grande del =
suo valore massimo
+interval.error=3Dl''intervallo =E9 vuoto o contiene caratteri impermessi=
bili
+#  Non so come si dice "backslash" in italiano.
+ends.with.backslash=3Dil modello finisce con un backslash (il carattere =
"\")
+
+# RESyntax message
+syntax.final=3DIl sintasso =E9 dichiarato "final" (finale) e non si pu=F2=
 modificarla






From MAILER-DAEMON Thu Apr 08 02:18:20 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBSrj-0001lc-Oj
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 02:18:19 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBSrf-0001i7-9d
	for classpath@gnu.org; Thu, 08 Apr 2004 02:18:15 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBSr9-0001QC-E7
	for classpath@gnu.org; Thu, 08 Apr 2004 02:18:14 -0400
Received: from [212.227.126.188] (helo=moutng.kundenserver.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBSr8-0001Oa-Sb
	for classpath@gnu.org; Thu, 08 Apr 2004 02:17:43 -0400
Received: from [212.227.126.162] (helo=mrelayng.kundenserver.de)
	by moutng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BBSr5-0007vM-00; Thu, 08 Apr 2004 08:17:39 +0200
Received: from [212.126.196.45] (helo=aicas.com)
	by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128)
	(Exim 3.35 #1) id 1BBSr4-0007Ds-00; Thu, 08 Apr 2004 08:17:38 +0200
Message-ID: <4074EE81.8010400@aicas.com>
Date: Thu, 08 Apr 2004 08:17:37 +0200
From: =?ISO-8859-1?Q?Ingo_Pr=F6tel?= <proetel@aicas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <40742D2A.7040206@aicas.com> <87y8p7v6cq.fsf@fleche.redhat.com>
In-Reply-To: <87y8p7v6cq.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
X-Provags-ID: kundenserver.de abuse@kundenserver.de
	auth:ebd3e0372cc3ac236a2e2611be1a8528
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 06:18:16 -0000

Tom Tromey wrote:
>>>>>>"Ingo" == Ingo Prötel <proetel@aicas.com> writes:
> 
> 
> Ingo> I would like to suggest removing all C++ keywords as names in
> Ingo> the native implementations of GNU Classpath. We have a customer
> Ingo> who insists on using C++ because of the more thorough code
> Ingo> inspection.  To be able to compile with such a compiler we need
> Ingo> to change all names that are C++ keywords.
> 
> I think this idea is fine.  It doesn't bother me anyway... though I'd
> suggest waiting for a response from folks who hack on the JNI code
> more than me :-)
> 
I guess I will wait a week or so. (Going on a long Easter weekend anyway ;-)

> My only comment or criticism is that, in the absence of regular
> checking for this, we'll just see more code like it checked in.
> That's been the experience with non-C89 constructs, I don't see why
> this would be any different.  It's just too hard to remember to write
> in some language subset without compiler-assisted checking.
> 
> We could declare all the JNI code to actually be C++, of course.  But
> then we'd see real C++ usage slip in.
No we should stay within C. But compiling was C++ code once in a while does give a little code review.
> 
> A third option would be for you to periodically try it out and check
> in patches like the one you sent :-).  Assuming the other developers
> are ok with this, it wouldn't be unreasonable, just a bit messy.
> 
> Tom
> 
We are currently in the works of making our complete VM C++ compilable. Once we have achieved this 
we will have a nightly integration build with a C++ compiler. I will then be glad to submit patches 
to fix the C++ building (we will need to do those anyway).

ingo


-- 
Ingo Prötel                                          proetel@aicas.com
aicas GmbH                                        http://www.aicas.com
Haid-und-Neu-Str. 18                        phone   +49 721 663 968-32
76131 Karlsruhe                             fax     +49 721 663 968-93
Germany



From MAILER-DAEMON Thu Apr 08 02:27:33 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBT08-0006Xt-Qn
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 02:27:00 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBSzs-0006K9-37
	for classpath@gnu.org; Thu, 08 Apr 2004 02:26:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBSyW-000529-Pu
	for classpath@gnu.org; Thu, 08 Apr 2004 02:25:55 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBSyV-0004zZ-3b
	for classpath@gnu.org; Thu, 08 Apr 2004 02:25:19 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-229.ewetel.net
	[80.228.94.229])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i386P9pH017308;
	Thu, 8 Apr 2004 08:25:10 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBS2V-0000Oa-00; Thu, 08 Apr 2004 07:25:23 +0200
From: Michael Koch <konqueror@gmx.de>
To: Steven Augart <augart@watson.ibm.com>, classpath@gnu.org
Date: Thu, 8 Apr 2004 08:24:54 +0200
User-Agent: KMail/1.5.4
References: <4074C1A8.5020009@watson.ibm.com>
In-Reply-To: <4074C1A8.5020009@watson.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404080824.54934.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: Localization patches for gnu.regexp
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 06:26:46 -0000

Am Donnerstag, 8. April 2004 05:06 schrieb Steven Augart:
> Here are some localization patches for the gnu.regexp package's
> messages.

Shouldnt this get submitted upstream first ?


Michael




From MAILER-DAEMON Thu Apr 08 04:42:36 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBV7L-0001By-ST
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 04:42:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBV7I-0001BZ-Rk
	for classpath@gnu.org; Thu, 08 Apr 2004 04:42:32 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBV6l-0000nI-AV
	for classpath@gnu.org; Thu, 08 Apr 2004 04:42:30 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBV6k-0000mB-UT
	for classpath@gnu.org; Thu, 08 Apr 2004 04:41:59 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 8 Apr 2004 10:37:37 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD49@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQc1SgZ6ttOX++kRMaLb7E2MFaCigAZWmYQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Grzegorz B. Prokopski" <gadek@debian.org>
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 08:42:33 -0000

Grzegorz B. Prokopski wrote:
> On (07/04/04 13:47), Jeroen Frijters wrote:
> > Andrew Haley wrote:
> > > This seems to be identical to my proposal.
> > >=20
> > > I no longer understand what we're arguing about...
> >=20
> > I know. I thought we were still trying to convince Etienne :-)
>=20
> I thought the goal was finding the optimal solution that would be spec
> compliant, portable and efficient.

Indeed. The goal is to find the optimal solution that would be spec
compliant, portable and efficient. Since I obviously believe that my
proposal is better than the byte[] proposal, I would like to convice
Etienne (and you) of this. I fail to see how you can take issue with
that.

> And I still haven't seen good example from Andrew about how native
> part of his "opaque class" would look like and what burden would it
have.

I don't feel like writing real JNI code, but here is the general idea:

jobject WrapPointer(JNIEnv* env, void* p)
{
#if PLATFORM_HAS_32_BIT_NATIVE_POINTER
  jclass pclass =3D env->FindClass("RawData32");
  jmethodID mid =3D env->GetMethodID(pclass, "<init>", "(I)V");
  return env->NewObject(pclass, mid, p);
#else if PLATFORM_HAS_64_BIT_NATIVE_POINTER
  jclass pclass =3D env->FindClass("RawData64");
  jmethodID mid =3D env->GetMethodID(pclass, "<init>", "(J)V");
  return env->NewObject(pclass, mid, p);
#else if PLATFORM_HAS_128_BIT_NATIVE_POINTER
  jclass pclass =3D env->FindClass("RawData128");
  jmethodID mid =3D env->GetMethodID(pclass, "<init>", "(JJ)V");
  jlong hi =3D HI_FROM_PTR(p);
  jlong lo =3D LO_FROM_PTR(p);
  return env->NewObject(pclass, mid, hi, lo);
#else
  #error unsupported
#endif
}

void* UnwrapPointer(JNIEnv* env, jobject pobj)
{
#if PLATFORM_HAS_32_BIT_NATIVE_POINTER
  jclass pclass =3D env->FindClass("RawData32");
  jfieldID fid =3D env->GetFieldID(pclass, "ptr", "I");
  return (void*)env->GetIntField(pobj, fid);
#else if PLATFORM_HAS_64_BIT_NATIVE_POINTER
  jclass pclass =3D env->FindClass("RawData64");
  jfieldID fid =3D env->GetFieldID(pclass, "ptr", "J");
  return (void*)env->GetLongField(pobj, fid);
#else if PLATFORM_HAS_128_BIT_NATIVE_POINTER
  jclass pclass =3D env->FindClass("RawData128");
  jfieldID fidHi =3D env->GetFieldID(pclass, "ptrHi", "J");
  jfieldID fidLo =3D env->GetFieldID(pclass, "ptrLo", "J");
  jlong hi =3D env->GetLongField(pobj, fidLo);
  jlong lo =3D env->GetLongField(pobj, fidLo);
  return PTR_FROM_HI_LO(hi, lo);
#else
  #error unsupported
#endif
}

I a real implementation you'd obviously cache the jclass and
jmethodID/jfieldID. I don't think this is less efficient or less
portable than using a byte[]. It only requires a (tiny) bit of extra
code to support different pointer sizes.

> About the other "solution" - a comment. Why again use=20
> something "magical"?
> A magica class in this case called RawData.

There is nothing magical about it, but it does allow JITs (on VMs that
don't use JNI to interact with the RawData pointers) to optimize access.

Regards,
Jeroen



From MAILER-DAEMON Thu Apr 08 05:07:16 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBVVD-0003A5-Ie
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 05:07:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBVV9-000372-7v
	for classpath@gnu.org; Thu, 08 Apr 2004 05:07:11 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBVUb-0002tx-Tu
	for classpath@gnu.org; Thu, 08 Apr 2004 05:07:10 -0400
Received: from [213.51.128.198] (helo=smtpq3.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBVSx-0002OA-No
	for classpath@gnu.org; Thu, 08 Apr 2004 05:04:55 -0400
Received: from [213.51.128.136] (port=49633 helo=smtp5.home.nl)
	by smtpq3.home.nl with esmtp (Exim 4.30) id 1BBVSw-0006s4-Sv
	for classpath@gnu.org; Thu, 08 Apr 2004 11:04:54 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:33044
	helo=dumas.thomas.planescape.com)
	by smtp5.home.nl with esmtp (Exim 4.30) id 1BBVSt-0002Fb-2V
	for classpath@gnu.org; Thu, 08 Apr 2004 11:04:51 +0200
From: Thomas Zander <zander@javalobby.org>
To: GNU Classpath <classpath@gnu.org>
Date: Thu, 8 Apr 2004 11:04:08 +0200
User-Agent: KMail/1.6.1
References: <001501c41cc8$86ecf690$897ba8c0@moe>
	<87u0zvv68m.fsf@fleche.redhat.com> <40748D9A.6070406@adres.pl>
In-Reply-To: <40748D9A.6070406@adres.pl>
MIME-Version: 1.0
Content-Disposition: inline
X-UID: 42
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200404081104.11683.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: Re: An interessting change for shared char[] in String/StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 09:07:12 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 08 April 2004 01:24, Artur Biesiadowski wrote:
> Tom Tromey wrote:
> >>>From http://java.sun.com/j2se/1.5.0/jcp/beta1/index.html#java.lang:
> >>>"In this release, the sharing between String and StringBuffer has
> >>> been eliminated."
> >>>Does this mean to change to change the implementation in Classpath
> >>> too? I like this optimization...
> >
> > I don't think we necessarily have to change this.  IMO it would depend
> > on whether the change is observable by user code.  Our implementation
> > doesn't always share, anyway.  It only shares if the buffer is mostly
> > in use.
>
> 'Observable by user code' is very broad term. It is possible to write a
> short program which will throw OutOfMemoryException with sharing on and
> work without problems when data is always copied - does it counts as
> observation from user code ?

No, I don't think so.
If the only difference (as I understand from Tom's email) is
faster/effecient implementation then copying behavior from Sus JVM is not
needed in the first place.
Waiting for the 1.5 release and seeing if this proved too unstable for the
Sun JVM gives you a good indication weather this feature is a nice
advancement in Classpath..

Just my 2 cents.
- --
Thomas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAdRWJCojCW6H2z/QRAt2aAKClbQqTWl8NU5rjZDH08JzXVvj/ywCeJkZn
X3IMy1RwPHMrHs3oXh0J+Sc=
=1AOO
-----END PGP SIGNATURE-----



From MAILER-DAEMON Thu Apr 08 05:57:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBWIH-0007pI-Pq
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 05:57:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBWI7-0007mc-TU
	for classpath@gnu.org; Thu, 08 Apr 2004 05:57:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBWHZ-0007ZI-6B
	for classpath@gnu.org; Thu, 08 Apr 2004 05:57:45 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBW8R-0005Bf-UY
	for classpath@gnu.org; Thu, 08 Apr 2004 05:47:48 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BBW8Q-0000Ti-00
	for <classpath@gnu.org>; Thu, 08 Apr 2004 11:47:46 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBW8K-0000SV-00; Thu, 08 Apr 2004 11:47:40 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i389lSLT009324;
	Thu, 8 Apr 2004 11:47:29 +0200 (MEST)
Message-ID: <40751FB0.6080109@kaffe.org>
Date: Thu, 08 Apr 2004 11:47:28 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
References: <16497.40308.789463.146357@cuddles.cambridge.redhat.com>	<4071A52E.2040501@uqam.ca>	<16497.43949.570690.83069@cuddles.cambridge.redhat.com>	<4071B0BF.7020302@uqam.ca>	<16497.46830.975278.681383@cuddles.cambridge.redhat.com>	<4071E699.8020809@uqam.ca>	<4071E9BA.6080504@uqam.ca>	<16498.30144.189924.141228@cuddles.cambridge.redhat.com>	<40731058.2060208@uqam.ca>	<16499.54723.302361.515836@cuddles.cambridge.redhat.com>	<20040407130512.GA20855@perseval.info.uqam.ca>	<16500.730.818712.833827@cuddles.cambridge.redhat.com>
	<407453B0.9020402@uqam.ca>
In-Reply-To: <407453B0.9020402@uqam.ca>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 09:57:49 -0000

Etienne Gagnon wrote:
> Andrew Haley wrote:
> 
>> Okay, but ANS specifically does not allow you to do this subtraction.
>> Also, there is no guarantee that every pointer is representable as a
>> ptrdiff_t.  (6.5.6 Para 9, if you're interested)
> 
> 
> The point is: if your platform is one that does *not* have 8-bit chars 
> (!!!),

http://www.36bit.org/ for platforms where CHAR_BITS is 9.

And for some non-related fun, 
http://www-1.ibm.com/servers/enable/site/porting/iseries/overview/faq_misc.html 
for a platform with 128 bit pointers.

cheers,
dalibor topic



From MAILER-DAEMON Thu Apr 08 06:50:31 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBX4z-0004Rx-AA
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 06:48:17 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBX4l-0004Oz-Mp
	for classpath@gnu.org; Thu, 08 Apr 2004 06:48:03 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBX3a-0004DV-KI
	for classpath@gnu.org; Thu, 08 Apr 2004 06:47:22 -0400
Received: from [202.1.236.232] (helo=web17011.mail.tpe.yahoo.com)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BBX2s-0002pA-HD
	for classpath@gnu.org; Thu, 08 Apr 2004 06:46:06 -0400
Message-ID: <20040408104350.42470.qmail@web17011.mail.tpe.yahoo.com>
Received: from [210.66.36.141] by web17011.mail.tpe.yahoo.com via HTTP;
	Thu, 08 Apr 2004 18:43:50 CST
Date: Thu, 8 Apr 2004 18:43:50 +0800 (CST)
From: =?big5?q?=20=20=20?= <newbie_tw@yahoo.com.tw>
To: classpath@gnu.org
MIME-Version: 1.0
Content-Type: text/plain; charset=big5
Content-Transfer-Encoding: 8bit
Subject: [Problem]glibj.zip conflict with kaffe vm's rt.jar
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 10:48:15 -0000

hi, 
i'm a java developer, yet new to use classpath such
project. currently i test how to use classpath to
develop my project. however, after kaffe
(/usr/local/kaffe) and classpath
(/usr/local/classpath) installed, when compiling a
simple HelloWorld program, there's a dilemma occurred.
if i put classpath lib - glibj.zip, in env variable
CLASSPATH. the kaffe vm issues problem that has
package conflict with kaffe's lib, rt.jar. what can i
do to that, if i want to use classpath's glibj.zip? or
where did i do it wrong?
i appreacite any suggestions, sincerely.



-----------------------------------------------------------------
§Ûªñ¸ô¡I¡IEmail³B³B¦¬¡I
§K¶O¤U¸üYahoo!©_¼¯±¶®|¦C
http://tw.companion.yahoo.com/



From MAILER-DAEMON Thu Apr 08 07:19:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBXXQ-0003Jg-MW
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 07:17:40 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBXW8-0002ax-LQ
	for classpath@gnu.org; Thu, 08 Apr 2004 07:16:20 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBXJo-0008AM-6N
	for classpath@gnu.org; Thu, 08 Apr 2004 07:04:07 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBXJm-00089Q-O4
	for classpath@gnu.org; Thu, 08 Apr 2004 07:03:34 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BBXJl-0002kJ-00
	for <classpath@gnu.org>; Thu, 08 Apr 2004 13:03:33 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBXJi-0002ip-00; Thu, 08 Apr 2004 13:03:30 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i38B3ULT026448;
	Thu, 8 Apr 2004 13:03:30 +0200 (MEST)
Message-ID: <40753182.4000504@kaffe.org>
Date: Thu, 08 Apr 2004 13:03:30 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: newbie_tw@yahoo.com.tw
References: <20040408104350.42470.qmail@web17011.mail.tpe.yahoo.com>
In-Reply-To: <20040408104350.42470.qmail@web17011.mail.tpe.yahoo.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: classpath@gnu.org
Subject: Re: [Problem]glibj.zip conflict with kaffe vm's rt.jar
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 11:17:25 -0000

Hi Arsene,

newbie_tw@yahoo.com.tw wrote:
> hi, 
> i'm a java developer, yet new to use classpath such
> project. currently i test how to use classpath to
> develop my project. however, after kaffe
> (/usr/local/kaffe) and classpath
> (/usr/local/classpath) installed, when compiling a
> simple HelloWorld program, there's a dilemma occurred.
> if i put classpath lib - glibj.zip, in env variable
> CLASSPATH. the kaffe vm issues problem that has
> package conflict with kaffe's lib, rt.jar. what can i
> do to that, if i want to use classpath's glibj.zip? or
> where did i do it wrong?
> i appreacite any suggestions, sincerely.

you can not use Classpath's class library with Kaffe, since some
fundamental classes conflict.

when compiling programs, yuu can usually pass the compiler a specific
classpath to use for the compilation. I assume you're using kjc, so that
should be the  --classpath option.

cheers,
dalibor topic



From MAILER-DAEMON Thu Apr 08 08:08:08 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBYKF-0006er-B9
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 08:08:07 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBYK9-0006cs-Fy
	for classpath@gnu.org; Thu, 08 Apr 2004 08:08:01 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBYJc-0006WJ-PC
	for classpath@gnu.org; Thu, 08 Apr 2004 08:07:59 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBYEh-0005eK-2U
	for classpath@gnu.org; Thu, 08 Apr 2004 08:02:23 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 8 Apr 2004 14:02:14 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD55@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQdXiGGFywrVkaPT66cqqtXnWaMJAAAIWoQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Etienne Gagnon" <gagnon.etienne_m@uqam.ca>
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 12:08:03 -0000

Etienne Gagnon wrote:
> Jeroen Frijters wrote:
> > Indeed. The goal is to find the optimal solution that would be spec
> > compliant, portable and efficient. Since I obviously believe that my
> > proposal is better than the byte[] proposal, I would like to convice
> > Etienne (and you) of this. I fail to see how you can take issue with
> > that.
>=20
> Fair.
>=20
> > I don't feel like writing real JNI code, but here is the=20
> general idea:
>=20
> So, you don't have a real proposal...  We need to compare *real* JNI
> code to real JNI code, otherwise, we'll be arguing about=20
> misconceptions.
>=20
> I still think that my proposal is better than the one you=20
> sketched below.
>=20
> > jobject WrapPointer(JNIEnv* env, void* p)
> > {
> > #if PLATFORM_HAS_32_BIT_NATIVE_POINTER
>=20
> For one thing, my proposal does not need any specific #ifdef=20
> per pointer size.

Absolutely, that is a big advantage of the byte[] approach, but IMHO it
optimizes for the wrong scenario. I (and I suspect most others) don't
care about pointer sizes other than 32/64 bit.

> >   jclass pclass =3D env->FindClass("RawData32");
> >   jmethodID mid =3D env->GetMethodID(pclass, "<init>", "(I)V");
>=20
> That's supposed to be faster than my proposal????

This is only done once. But you are missing my point about efficiency.
The JNI approach isn't about performance, it is going to be slow, no
matter what. I just want the option the make my implementation fast. The
byte[] approach doesn't give me this option. It forces me into
suboptimal implementation.

> >   return env->NewObject(pclass, mid, p);
>=20
> ** Bzzzt *** Please try again...
>=20
> Now that my proposal has been criticised to death on the smallest
> nitpicks of pure ISO C portability, let me comment on the portability
> ]of your code.

I'm not the one nitpicking about pure ISO C portability (I don't use
JNI, so I couldn't care less), but we could use the exact same trick you
used in your JBYTE_IS_NOT_SIGNED_CHAR versions of wrap/unwrap. So this
is a non-issue.

> So, no, your proposal is NOT portable,

It is portable (can be made portable by someone who cares, i.e. not me).

> and is of thus ranks lower than my proposal on 2 counts:
> 1- Efficiency:

For a JNI based implementation, maybe, but I'd argue that anyone using
JNI doesn't care about performance anyway.

Regards,
Jeroen



From MAILER-DAEMON Thu Apr 08 08:22:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBYYT-0001de-R2
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 08:22:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBYVP-0001Cm-JO
	for classpath@gnu.org; Thu, 08 Apr 2004 08:19:39 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBYTb-0000bh-Th
	for classpath@gnu.org; Thu, 08 Apr 2004 08:18:19 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBYQp-0008OG-VN
	for classpath@gnu.org; Thu, 08 Apr 2004 08:14:56 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBXsC-0006SO-65
	for classpath@gnu.org; Thu, 08 Apr 2004 07:39:08 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i38BZM12003085;
	Thu, 8 Apr 2004 07:35:22 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040807363818869 ; Thu, 08 Apr 2004 07:36:38 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i38BBKb3008921; Thu, 8 Apr 2004 07:11:20 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BBXRI-0006UK-Mi; Thu, 08 Apr 2004 07:11:20 -0400
Message-ID: <40753354.4020507@uqam.ca>
Date: Thu, 08 Apr 2004 07:11:16 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD49@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD49@LEMBU.sumatrasoftware.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 12:22:41 -0000

Jeroen Frijters wrote:
> Indeed. The goal is to find the optimal solution that would be spec
> compliant, portable and efficient. Since I obviously believe that my
> proposal is better than the byte[] proposal, I would like to convice
> Etienne (and you) of this. I fail to see how you can take issue with
> that.

Fair.

> I don't feel like writing real JNI code, but here is the general idea:

So, you don't have a real proposal...  We need to compare *real* JNI
code to real JNI code, otherwise, we'll be arguing about misconceptions.

I still think that my proposal is better than the one you sketched below.

> jobject WrapPointer(JNIEnv* env, void* p)
> {
> #if PLATFORM_HAS_32_BIT_NATIVE_POINTER

For one thing, my proposal does not need any specific #ifdef per pointer
size.

>   jclass pclass = env->FindClass("RawData32");
>   jmethodID mid = env->GetMethodID(pclass, "<init>", "(I)V");

That's supposed to be faster than my proposal????

>   return env->NewObject(pclass, mid, p);

** Bzzzt *** Please try again...

Now that my proposal has been criticised to death on the smallest
nitpicks of pure ISO C portability, let me comment on the portability
]of your code.


The ISO C standard says:

        [#6]  Any  pointer type may be converted to an integer type;
        the result is implementation-defined.  If the result  cannot
        be   represented  in  the  integer  type,  the  behavior  is
        undefined.  The result need not be in the range of values of |
        any integer type.

So, the conversion of "p" to "jlong" or "jint" yields a *compiler-specific*
value; ISO C does not guarantees anything about the actual value resulting
from the cast.  In other words, a compiler would be allowed to change
the bits of the pointer value when converting.

Now, *my* proposal, when "jbyte == signed char", does not convert
the pointer to an integer, which is something non-portable across
*compilers* on a same platform.  [Remember: the *main* objective of
JNI is portability across VMs (and compilers) on the same platform,
because you shouldn't have to recompile the library to work with
another VM].

So, no, your proposal is NOT portable, and is of thus ranks lower than
my proposal on 2 counts:
1- Efficiency:
      - my approach needs no call to FindClass & GetMethodID
      - wrapping the pointer causes no execution of Java byte code,
        but in your case, the constructor <init> must be executed.
2- Portability:
      - Your code uses an implementation-defined (i.e. compiler-specific)
        conversion; and cannot guarantee that the pointer will be actually
        restored on unwrapping.

FYI: Annex K "portability Issues" (informative) of the ISO C specification
specifically points out the following as being implementation defined:

        K.3.7  Arrays and pointers

        [#1]

          -- The  result  of  converting  a pointer to an integer or
             vice versa (6.3.2.3).

Your proposal fails portability on this account.

> I a real implementation you'd obviously cache the jclass and
> jmethodID/jfieldID. I don't think this is less efficient or less
> portable than using a byte[].

Caching jclass/jmethodID/jfieldID will not solve all the problems;
you still call the constructor <init>.  Not only will this cause
execution of Java code (which is not required in my proposal), but
on non-optimizing JVMs, it will cause execution of 3 constructors(!!):
1- RawData32.<init>
2- RawData.<init>
3- Object.<init>

 > It only requires a (tiny) bit of extra
> code to support different pointer sizes.

Mine requires none.

Also, it is highly probable that we'll get to 128-bit platforms one
day: just imagine if you could use a secure hash, like SHA-1 as
hashcode to store data in a virtual memory implementation with 128-bit
addresses! :-)  I *am* serious.

> There is nothing magical about it, but it does allow JITs (on VMs that
> don't use JNI to interact with the RawData pointers) to optimize access.

Your proposal is slower for JNI-compliant VMs, and it is not portable.

You see: this is why I wanted you to show me JNI code, as I have thought
about the problem for quite a while before settling with the idea of
byte arrays.

Etienne


-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Thu Apr 08 08:59:13 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBZ7h-0001SH-9g
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 08:59:13 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBYuV-0006S5-Ha
	for classpath@gnu.org; Thu, 08 Apr 2004 08:45:35 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBYtx-0006Jn-41
	for classpath@gnu.org; Thu, 08 Apr 2004 08:45:32 -0400
Received: from [62.253.162.44] (helo=mta04-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBYtw-0006H1-FU
	for classpath@gnu.org; Thu, 08 Apr 2004 08:45:00 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta04-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040408124424.DVFF1202.mta04-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Thu, 8 Apr 2004 13:44:24 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i38ChKP0005699; Thu, 8 Apr 2004 13:43:30 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i38ChIkL005693;
	Thu, 8 Apr 2004 13:43:18 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16501.18662.283815.635484@cuddles.cambridge.redhat.com>
Date: Thu, 8 Apr 2004 13:43:18 +0100
To: "Jeroen Frijters" <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD55@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD55@LEMBU.sumatrasoftware.com>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 12:59:11 -0000

Jeroen Frijters writes:
 > 
 > > >   return env->NewObject(pclass, mid, p);
 > > 
 > > ** Bzzzt *** Please try again...
 > > 
 > > Now that my proposal has been criticised to death on the smallest
 > > nitpicks of pure ISO C portability, let me comment on the portability
 > > of your code.

That wasn't my point in nitpicking.  What I was attempting was showing
that to prefer one approach to another soley on the grounds of pure
ISO compatibility is probably a mistake.  Every approach so far has
lacked correctness in some way.

Strong typing for legibility and reliability is IMO for more
important.

Here's a real example from SWT:

public static final synchronized native int 
g_signal_handlers_unblock_matched(long /*PTR*/ instance, 
				       int mask, 
				       int signal_id, 
				       int detail, 
				       long /*PTR*/ closure, 
				       long /*PTR*/ func, 
				       long /*PTR*/ data);

Here it is with passing the pointers as byte arrays:

public static final synchronized native int 
g_signal_handlers_unblock_matched(byte[] instance, 
				       int mask, 
				       int signal_id, 
				       int detail, 
				       byte[] closure, 
				       byte[] func, 
				       byte[] data);


And here it is with named opaque types:

public static final synchronized native int
g_signal_handlers_unblock_matched(gpointer instance, 
				       int mask, 
				       int signal_id, 
				       int detail, 
				       GClosurePointer closure, 
				       gpointer func, 
				       gpointer data);

Just for reference, here is the corresponding C declaration:

guint  g_signal_handlers_unblock_matched
                                 (gpointer instance,
                                  GSignalMatchType mask,
                                  guint signal_id,
                                  GQuark detail,
                                  GClosure *closure,
                                  gpointer func,
                                  gpointer data);

Andrew.



From MAILER-DAEMON Thu Apr 08 09:13:41 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBZJd-0005Gd-6D
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 09:11:33 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBZHL-0004Fk-G1
	for classpath@gnu.org; Thu, 08 Apr 2004 09:09:11 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBZFI-0003Sc-Eb
	for classpath@gnu.org; Thu, 08 Apr 2004 09:07:35 -0400
Received: from [62.253.162.48] (helo=mta08-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBYwq-0006l8-3a
	for classpath@gnu.org; Thu, 08 Apr 2004 08:48:00 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta08-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040408124753.RPVZ10788.mta08-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Thu, 8 Apr 2004 13:47:53 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i38CkAP0005730; Thu, 8 Apr 2004 13:46:20 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i38Ck9Uf005724;
	Thu, 8 Apr 2004 13:46:09 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16501.18833.288610.221158@cuddles.cambridge.redhat.com>
Date: Thu, 8 Apr 2004 13:46:09 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <40753354.4020507@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD49@LEMBU.sumatrasoftware.com>
	<40753354.4020507@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 13:11:30 -0000

Etienne Gagnon writes:
 > 
 > Now that my proposal has been criticised to death on the smallest
 > nitpicks of pure ISO C portability, let me comment on the portability
 > ]of your code.
 > 
 > 
 > The ISO C standard says:
 > 
 >         [#6]  Any  pointer type may be converted to an integer type;
 >         the result is implementation-defined.  If the result  cannot
 >         be   represented  in  the  integer  type,  the  behavior  is
 >         undefined.  The result need not be in the range of values of |
 >         any integer type.
 > 
 > So, the conversion of "p" to "jlong" or "jint" yields a *compiler-specific*
 > value; ISO C does not guarantees anything about the actual value resulting
 > from the cast.  In other words, a compiler would be allowed to change
 > the bits of the pointer value when converting.

Exactly: the only reliable way I can see to do this is to use memcpy()
from the big pointer to a byte array.  But, compared to the overhead
of a JNI call, that is no big deal.

Andrew.



From MAILER-DAEMON Thu Apr 08 09:29:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBZVu-0002gV-Of
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 09:24:14 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBZVo-0002df-1U
	for classpath@gnu.org; Thu, 08 Apr 2004 09:24:08 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBZVG-0002TT-Qq
	for classpath@gnu.org; Thu, 08 Apr 2004 09:24:06 -0400
Received: from [204.127.202.64] (helo=sccrmhc13.comcast.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBZVG-0002Q5-BR
	for classpath@gnu.org; Thu, 08 Apr 2004 09:23:34 -0400
Received: from byu.net (c-24-10-254-137.client.comcast.net[24.10.254.137])
	by comcast.net (sccrmhc13) with SMTP id <20040408132327016003bjo0e>
	(Authid: ericblake); Thu, 8 Apr 2004 13:23:28 +0000
Message-ID: <4075527D.3040201@byu.net>
Date: Thu, 08 Apr 2004 07:24:13 -0600
From: Eric Blake <ebb9@byu.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <001501c41cc8$86ecf690$897ba8c0@moe>
	<87u0zvv68m.fsf@fleche.redhat.com>
In-Reply-To: <87u0zvv68m.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: An interessting change for shared char[] in String/StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 13:24:10 -0000

Tom Tromey wrote:
>>>>>>">" == Chr Ullenboom <C.Ullenboom@java-tutor.com> writes:
> 
> 
>>>From http://java.sun.com/j2se/1.5.0/jcp/beta1/index.html#java.lang:
>>>"In this release, the sharing between String and StringBuffer has been
>>>eliminated."
>>>Does this mean to change to change the implementation in Classpath too? I
>>>like this optimization...
> 
> 
> I don't think we necessarily have to change this.  IMO it would depend
> on whether the change is observable by user code.  Our implementation
> doesn't always share, anyway.  It only shares if the buffer is mostly
> in use.

Part of Sun's rationale for their change is that in 1.5, they introduced 
java.lang.StringBuilder, a non-synchronized copy of StringBuffer with 
otherwise identical semantics.  Similar to gnu.java.lang.StringBuffer used in 
gcj, if StringBuilder exists, it allows the compiler to emit more efficient 
string concatenation (and jikes already knows how to use it).  My 
understanding of Sun's implementation of StringBuilder is that it is rather 
simplistic (based on a bug report to Sun's site complaining that the javadoc 
was misleading because of the non-public superclass) - they renamed the old 
StringBuffer into a new package-private class java.lang.AbstractStringBuffer 
(or some such name) for all the implementation, then created StringBuffer and 
StringBuilder as public extension classes with no further implementation 
(other than the fact that all the StringBuffer methods add synchronization). 
So perhaps they made the change on sharing the char[] because their 
class-shuffling broke something.

I agree with Tom that we would have to benchmark it to see if sharing or not 
sharing is more efficient, before blindly choosing one way over the other just 
to match Sun.  If I understand correctly, back in JDK 1.0, Sun did NOT use 
char[] sharing - it was added later as an optimization before JIT compilers 
were as good as they are now (and now Sun claims to be deleting it as an 
optimization).  Also, we will have to be careful that we handle serialization 
of StringBuffer correctly, whichever way we choose.

I also wonder if the following implementation would be more efficient.  In the 
common case, StringBuffer/StringBuilder is used for appends, and then 
converted to a String just before being discarded.  Currently, for every 
append, we adjust the underlying char[] and copy the appended String into that 
array.  Would it be better to just build a String[] that caches all the 
appended Strings, and then create a single char[] at the time toString() is 
called, rather than updating the char[] for every append()?  Of course, we 
would have to create the char[] for any non-append() method.  And one of the 
disadvantages of this method is that we end up creating intermediate Strings 
when we append primitive types, whereas the current implementation can update 
the char[] without creating any intermediate objects.  I haven't coded this up 
to experiment on the difference, but it would be an interesting experiment.

-- 
Someday, I might put a cute statement here.

Eric Blake             ebb9@byu.net




From MAILER-DAEMON Thu Apr 08 09:59:08 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBZtb-0003ct-Tv
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 09:48:43 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBZsh-00039q-UH
	for classpath@gnu.org; Thu, 08 Apr 2004 09:47:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBZq5-0002G7-UT
	for classpath@gnu.org; Thu, 08 Apr 2004 09:45:38 -0400
Received: from [213.51.128.197] (helo=smtpq2.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBZq4-0002FB-Si
	for classpath@gnu.org; Thu, 08 Apr 2004 09:45:05 -0400
Received: from [213.51.128.135] (port=49766 helo=smtp4.home.nl)
	by smtpq2.home.nl with esmtp (Exim 4.30) id 1BBZq4-0002UT-7R
	for classpath@gnu.org; Thu, 08 Apr 2004 15:45:04 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:33359
	helo=dumas.thomas.planescape.com)
	by smtp4.home.nl with esmtp (Exim 4.30) id 1BBZqB-0002HU-4C
	for classpath@gnu.org; Thu, 08 Apr 2004 15:45:11 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Thu, 8 Apr 2004 15:44:18 +0200
User-Agent: KMail/1.6.1
References: <001501c41cc8$86ecf690$897ba8c0@moe>
	<87u0zvv68m.fsf@fleche.redhat.com> <4075527D.3040201@byu.net>
In-Reply-To: <4075527D.3040201@byu.net>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404081544.23195.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: Re: An interessting change for shared char[] in String/StringBuffer
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 13:48:42 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 08 April 2004 15:24, Eric Blake wrote:
> Tom Tromey wrote:

> I also wonder if the following implementation would be more efficient.=20
> In the common case, StringBuffer/StringBuilder is used for appends, and
> then converted to a String just before being discarded.  Currently, for
> every append, we adjust the underlying char[] and copy the appended
> String into that array.  Would it be better ...

An alternate approach;
some time ago I noticed that the ByteArrayOutputStream copied all data=20
already present on each add, which is when we came up with the following=20
approach that would be usefull here as well;

Use a list of byte[] 's (or char[]'s) and optimistically allocate space in=
=20
the first array.
At appends copy all the bytes that will fit into the already allocated=20
byte[], and allocate a second one for the rest.  Use some algoritm that=20
allocates based on previous size (say; 20% of current size) so you will=20
get increasingly bigger arrays which you copy into.

At the end you will have a list of arrays which you can copy into one big=20
array on toString() or similar.

We found that this is the most effecient way of accumulating data in one=20
class with minimum garbage collection / allocations.

Hope thats clear.
=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAdVc1CojCW6H2z/QRAqsSAKDrtFYdfBLrpSmVgd20zR+uDOespgCgnhBz
Q3bBChRLpbavbuKmP2lePdY=3D
=3Dx02e
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Thu Apr 08 13:01:53 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBcty-0008Ag-8c
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 13:01:18 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBcto-000874-7W
	for classpath@gnu.org; Thu, 08 Apr 2004 13:01:08 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBcpG-0006B9-EL
	for classpath@gnu.org; Thu, 08 Apr 2004 12:56:58 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBcni-0005ZD-16
	for classpath@gnu.org; Thu, 08 Apr 2004 12:54:50 -0400
Received: from [130.102.176.1] (helo=piglet.dstc.edu.au)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBce7-0002s4-71
	for classpath@gnu.org; Thu, 08 Apr 2004 12:44:55 -0400
Received: from dstc.edu.au (credence.dstc.edu.au [130.102.177.137])
	by piglet.dstc.edu.au (8.12.10/8.12.10) with ESMTP id i38GiZmT002491
	for <classpath@gnu.org>; Fri, 9 Apr 2004 02:44:35 +1000 (EST)
Message-Id: <200404081644.i38GiZmT002491@piglet.dstc.edu.au>
X-Mailer: exmh version 2.6.1 02/18/2003 with nmh-1.0.4
To: classpath@gnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Fri, 09 Apr 2004 02:44:39 +1000
From: Stephen Crawley <crawley@dstc.edu.au>
X-Scanned-By: MIMEDefang 2.39 (DSTC)
Subject: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 17:01:15 -0000


Folks,

I've just checked in a new version of the Mauve testcase for Unicode
character handling.  This fixes previous problems that resulted in
huge numbers of test failures with the current version of Classpath.
[It turns out that they were partly because the testcase used an old
Unicode table, but mostly because of testcase bugs; i.e. tests that
were wrong vis-a-vis the JDK 1.4 javadoc.]

The testcase now runs clean for JDK 1.4.2 as well as Kissme/Classpath
from CVS.

The interesting thing is that the test run 200 times faster with JDK 1.4.2
than with Kissme.  Yes TWO HUNDRED TIMES!

$ cat /tmp/foo
gnu.testlet.java.lang.Character.unicode

$ /usr/java/j2sdk1.4.2/bin/java -cp ../mauve gnu.testlet.SimpleTestHarness \
   -debug < /tmp/foo
Reading unicode database...
done
Benchmark : load:288ms   tests:505ms
0 of 3578944 tests failed

$ useful_scripts/kissme -cp ../mauve gnu.testlet.SimpleTestHarness -debug < /tmp/foo
Reading unicode database...
done
Benchmark : load:13892ms   tests:104699ms
0 of 3578944 tests failed

(This is on a 2.5Ghz Pentium IV)

Question: what figures do people get with other open source VMs?

-- Steve




From MAILER-DAEMON Thu Apr 08 13:06:11 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBcyd-0002Cw-Hp
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 13:06:07 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBcwp-0001OG-5e
	for classpath@gnu.org; Thu, 08 Apr 2004 13:04:15 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBcuw-0000L4-SB
	for classpath@gnu.org; Thu, 08 Apr 2004 13:02:50 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBctu-00087e-Hw
	for classpath@gnu.org; Thu, 08 Apr 2004 13:01:14 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i38GjuQK025177;
	Thu, 8 Apr 2004 12:46:18 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004040812473418085 ; Thu, 08 Apr 2004 12:47:34 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i38GgpIb016411; Thu, 8 Apr 2004 12:42:52 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30)
	id 1BBcc8-0006dX-29; Thu, 08 Apr 2004 12:42:52 -0400
Message-ID: <4075810B.5080409@uqam.ca>
Date: Thu, 08 Apr 2004 12:42:51 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD55@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD55@LEMBU.sumatrasoftware.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 17:06:06 -0000

Jeroen Frijters wrote:
>>>Indeed. The goal is to find the optimal solution that would be spec
>>>compliant, portable and efficient.

and later:
> I'm not the one nitpicking about pure ISO C portability (I don't use
> JNI, so I couldn't care less), ...

and later:
>>and is of thus ranks lower than my proposal on 2 counts:
>>1- Efficiency:
> 
> For a JNI based implementation, maybe, but I'd argue that anyone using
> JNI doesn't care about performance anyway.

You contradict yourself.  First you say that the optimal is spec compliant,
portable, and efficient.  Then you say that you couldn't care less about
the spec compliant JNI interface, that portability across JVMs/compilers
on a single platform is of no interest, and that efficiency of JNI is
not an objective of your proposal.

OK. So, it is clear that I am wasting my time, here.  I now clearly understand
that the main motivation is for Classpath to use less portable approaches when
they make CNI faster, as the performance of CNI and the other non-spec compliant
interfaces is the main objective.

Fine.  I'll devote my time elsewhere.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Thu Apr 08 13:25:07 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBdA4-0000Yw-Ct
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 13:17:56 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBd9p-0000NP-05
	for classpath@gnu.org; Thu, 08 Apr 2004 13:17:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBd9D-0008Q5-Tp
	for classpath@gnu.org; Thu, 08 Apr 2004 13:17:36 -0400
Received: from [213.228.0.169] (helo=postfix3-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBd9D-0008Mc-Bi
	for classpath@gnu.org; Thu, 08 Apr 2004 13:17:03 -0400
Received: from free.fr (cachan-3-82-66-125-112.fbx.proxad.net [82.66.125.112])
	by postfix3-2.free.fr (Postfix) with ESMTP
	id 41963DDF1; Thu,  8 Apr 2004 19:17:00 +0200 (CEST)
Message-ID: <4075890B.6070908@free.fr>
Date: Thu, 08 Apr 2004 19:16:59 +0200
From: Guilhem Lavaux <guilhem.lavaux@free.fr>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Stephen Crawley <crawley@dstc.edu.au>
References: <200404081644.i38GiZmT002491@piglet.dstc.edu.au>
In-Reply-To: <200404081644.i38GiZmT002491@piglet.dstc.edu.au>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 17:17:53 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stephen Crawley wrote:
| Folks,
|
| I've just checked in a new version of the Mauve testcase for Unicode
| character handling.  This fixes previous problems that resulted in
| huge numbers of test failures with the current version of Classpath.
| [It turns out that they were partly because the testcase used an old
| Unicode table, but mostly because of testcase bugs; i.e. tests that
| were wrong vis-a-vis the JDK 1.4 javadoc.]
|
| The testcase now runs clean for JDK 1.4.2 as well as Kissme/Classpath
| from CVS.
|
| The interesting thing is that the test run 200 times faster with JDK 1.4.2
| than with Kissme.  Yes TWO HUNDRED TIMES!
|
| $ cat /tmp/foo
| gnu.testlet.java.lang.Character.unicode
|
| $ /usr/java/j2sdk1.4.2/bin/java -cp ../mauve
gnu.testlet.SimpleTestHarness \
|    -debug < /tmp/foo
| Reading unicode database...
| done
| Benchmark : load:288ms   tests:505ms
| 0 of 3578944 tests failed
|
| $ useful_scripts/kissme -cp ../mauve gnu.testlet.SimpleTestHarness
- -debug < /tmp/foo
| Reading unicode database...
| done
| Benchmark : load:13892ms   tests:104699ms
| 0 of 3578944 tests failed
|
| (This is on a 2.5Ghz Pentium IV)
|
| Question: what figures do people get with other open source VMs?
|

Thanks for fixing unicode !

On my PIV 2.5 it gives with kaffe jit3:

[guilhem@taniquetil mauve]$ echo gnu.testlet.java.lang.Character.unicode
| kaffe gnu.testlet.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:1052ms   tests:334ms
0 of 3578944 tests failed
[guilhem@taniquetil mauve]$ echo gnu.testlet.java.lang.Character.unicode
| /usr/j2sdk1.4.2/bin/java gnu.testlet.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:266ms   tests:406ms
0 of 3578944 tests failed

Answer: hmmmm.... 70ms faster for tests but 5 times slower for loading.

Cheers,
Guilhem.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAdYkLWRk4qbNiTwgRArf+AKCOFjQu0gMirvywMCGUdNHvbE1q2QCgjceY
GkG9MpJGgZIDsh1auJQ/RpY=
=Pft5
-----END PGP SIGNATURE-----




From MAILER-DAEMON Thu Apr 08 13:29:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBdLi-00038b-5e
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 13:29:58 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBdLc-00035t-7a
	for classpath@gnu.org; Thu, 08 Apr 2004 13:29:52 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBdL0-0002wx-MR
	for classpath@gnu.org; Thu, 08 Apr 2004 13:29:45 -0400
Received: from [62.253.162.45] (helo=mta05-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBdK1-0002hy-5d
	for classpath@gnu.org; Thu, 08 Apr 2004 13:28:13 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta05-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040408172700.QYJZ4091.mta05-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Thu, 8 Apr 2004 18:27:00 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i38HQfP0013434; Thu, 8 Apr 2004 18:26:51 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i38HQeEX013430;
	Thu, 8 Apr 2004 18:26:40 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16501.35664.147201.496370@cuddles.cambridge.redhat.com>
Date: Thu, 8 Apr 2004 18:26:40 +0100
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <4075810B.5080409@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD55@LEMBU.sumatrasoftware.com>
	<4075810B.5080409@uqam.ca>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 17:29:54 -0000

Etienne Gagnon writes:
 > Jeroen Frijters wrote:
 > >>>Indeed. The goal is to find the optimal solution that would be spec
 > >>>compliant, portable and efficient.
 > 
 > and later:
 > > I'm not the one nitpicking about pure ISO C portability (I don't use
 > > JNI, so I couldn't care less), ...
 > 
 > and later:
 > >>and is of thus ranks lower than my proposal on 2 counts:
 > >>1- Efficiency:
 > > 
 > > For a JNI based implementation, maybe, but I'd argue that anyone using
 > > JNI doesn't care about performance anyway.
 > 
 > You contradict yourself.  First you say that the optimal is spec compliant,
 > portable, and efficient.  Then you say that you couldn't care less about
 > the spec compliant JNI interface, that portability across JVMs/compilers
 > on a single platform is of no interest, and that efficiency of JNI is
 > not an objective of your proposal.
 > 
 > OK. So, it is clear that I am wasting my time, here.  I now clearly understand
 > that the main motivation is for Classpath to use less portable approaches when
 > they make CNI faster, as the performance of CNI and the other non-spec compliant
 > interfaces is the main objective.

Come on now.  We need to find a clean way to do this, and although it
may seem like I'm being overly pushy, my main concern is to do what's
right for everyone who uses JNI in Classpath, long term.

Perhaps we need to define what we're really aiming at.

I would have thought:

1.  Correctness (well-defined on the platforms we care about.)
2.  Portability (to the platforms we care about.)
3.  Maintainability/Readability of code.
4.  Efficiency.

Does anyone really disagree with these priorities?  Okay, perhaps we
need to agree what platforms we care about.

 > Fine.  I'll devote my time elsewhere.

That's a shame.  I wouldn't like to think I was responsible in some
way for pushing you (and SableVM) away form the Classpath list.

It seems to me that we've been focussing on small details without
agreeing on our goals.  The goals of IKVM and SableVM are different,
but I feel sure that a compromise is possible.

Andrew.



From MAILER-DAEMON Thu Apr 08 14:29:21 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBeH9-00071q-Qd
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 14:29:19 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBeGv-0006sr-Vq
	for classpath@gnu.org; Thu, 08 Apr 2004 14:29:05 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBeGF-0006UR-Md
	for classpath@gnu.org; Thu, 08 Apr 2004 14:28:55 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBeFL-0005oc-7y
	for classpath@gnu.org; Thu, 08 Apr 2004 14:27:27 -0400
Received: from sp1n293en1.watson.ibm.com (sp1n293en1.watson.ibm.com
	[129.34.20.41])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i38IRKq83718; Thu, 8 Apr 2004 14:27:22 -0400
Received: from watson.ibm.com (localhost [127.0.0.1])
	by sp1n293en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i38IRKQ50752; Thu, 8 Apr 2004 14:27:20 -0400
Message-ID: <40759987.1080008@watson.ibm.com>
Date: Thu, 08 Apr 2004 14:27:19 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en, it
MIME-Version: 1.0
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD55@LEMBU.sumatrasoftware.com>
	<4075810B.5080409@uqam.ca>
In-Reply-To: <4075810B.5080409@uqam.ca>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 18:29:16 -0000

Etienne Gagnon wrote:
> the main motivation is for Classpath to use less portable 
> approaches when
> they make CNI faster, as the performance of CNI and the other non-spec 
> compliant
> interfaces is the main objective.

Jikes RVM uses JNI and is unlikely to ever implement CNI.  There are 
other classpath-using VMs that implement JNI.

Obviously, most of those of us who work on a specific VM are thinking 
about what proposals will mean for our particular VM.  For the Jikes 
RVM crowd, Dave Grove, Mike Hind, and I will object loudly to anything 
that really messes up JNI, and I'm sure the other JNI users will speak 
up for their VMs.

-- 
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm




From MAILER-DAEMON Thu Apr 08 14:55:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBeg9-0001op-8x
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 14:55:09 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBeg4-0001n8-PY
	for classpath@gnu.org; Thu, 08 Apr 2004 14:55:04 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBefV-0001V9-QY
	for classpath@gnu.org; Thu, 08 Apr 2004 14:55:02 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BBeer-0000sW-1T
	for classpath@gnu.org; Thu, 08 Apr 2004 14:53:49 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id 74799d5c_898c_11d8_935c_00304811e8c8_21946;
	Thu, 08 Apr 2004 13:42:15 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i38IqSnK010496; 
	Thu, 8 Apr 2004 13:52:28 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i38IqQj5010495;
	Thu, 8 Apr 2004 13:52:26 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404081852.i38IqQj5010495@arch20m.dellroad.org>
In-Reply-To: <16501.35664.147201.496370@cuddles.cambridge.redhat.com>
To: Andrew Haley <aph@redhat.com>
Date: Thu, 8 Apr 2004 13:52:26 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	Jeroen Frijters <jeroen@sumatra.nl>, GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 18:55:06 -0000

Andrew Haley wrote:
> Perhaps we need to define what we're really aiming at.
> 
> I would have thought:
> 
> 1.  Correctness (well-defined on the platforms we care about.)
> 2.  Portability (to the platforms we care about.)
> 3.  Maintainability/Readability of code.
> 4.  Efficiency.
> 
> Does anyone really disagree with these priorities?

Not me.

> Okay, perhaps we need to agree what platforms we care about.

Here are my votes... 

- We don't care about platforms that don't have 8 bit bytes or where
  typeof(jchar) != signed char.

- We don't care about platforms where 'jlong' is insufficient to hold
  VM private data. E.g., on a platform with 128 bit pointers, then
  the VM must use a hash table or something to derive the actual
  pointer (or whatever it needs). I.e., we deem 64 bits enough to
  uniquely describe all unique VM-private data structures.

- We don't use ``because it runs faster on my VM'' as evidence of being
  more efficient; It must run faster on ALL VM's for it to mean anything.

- When there are non-obvious tradeoffs in efficiency (i.e., it's faster
  on some VMs, slower on others, or otherwise muddy) then we choose the
  option which is the most portable and/or generic.

- Requiring the VM to specially recognize and not trace a "RawData" object
  pointer type decreases portability (having a "RawData" type that merely
  is a normal object holding a long does not).

Note: by this logic byte[] is the most portable/generic way to hold
VM private data. It places no portability restrictions, only (possibly)
performance ones. However, I have yet to hear a convincing argument
that proves byte[] is slower than RawData (or whatever) on ALL platforms.

E.g., take JC as an example. byte[] and "RawData containing long" both
require one "unwrap" to get the pointer. "RawData containing long"
wastes 4 bytes on 32-bit platforms, but byte[]->length also costs 4 bytes,
so size is a wash. byte[] is portable to 128 bit platforms while
"RawData containing long" is not (sure, probably won't happen in my
lifetime, but... ). Finally, "RawData as opaque pointer" doesn't require
any unwraping but does hit GC cycle time severely as every object has
to be check for being in this special RawData class. So for JC byte[]
is best.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Thu Apr 08 14:58:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBej2-000355-KC
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 14:58:08 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBeiJ-0002ng-Qf
	for classpath@gnu.org; Thu, 08 Apr 2004 14:57:23 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBehj-0002VR-2p
	for classpath@gnu.org; Thu, 08 Apr 2004 14:57:18 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBefV-000137-2q
	for classpath@gnu.org; Thu, 08 Apr 2004 14:54:29 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBeZy-0006U8-Lr
	for classpath@gnu.org; Thu, 08 Apr 2004 14:48:46 -0400
Received: from sp1n293en1.watson.ibm.com (sp1n293en1.watson.ibm.com
	[129.34.20.41])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i38Imeq37208; Thu, 8 Apr 2004 14:48:41 -0400
Received: from watson.ibm.com (localhost [127.0.0.1])
	by sp1n293en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i38ImeS62802; Thu, 8 Apr 2004 14:48:40 -0400
Message-ID: <40759E88.2010500@watson.ibm.com>
Date: Thu, 08 Apr 2004 14:48:40 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en, it
MIME-Version: 1.0
To: Andrew Haley <aph@redhat.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD55@LEMBU.sumatrasoftware.com>
	<16501.18662.283815.635484@cuddles.cambridge.redhat.com>
In-Reply-To: <16501.18662.283815.635484@cuddles.cambridge.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 18:58:05 -0000

Andrew Haley wrote:
> Strong typing for legibility and reliability is IMO for more
> important.

I strongly agree with this, on software engineering grounds.

 > And here it is with named opaque types:
 >
 > public static final synchronized native int
 > g_signal_handlers_unblock_matched(gpointer instance,
 > 				       int mask,
 > 				       int signal_id,
 > 				       int detail,
 > 				       GClosurePointer closure,
 > 				       gpointer func,
 > 				       gpointer data);

These are great examples from SWT.

If we were to do this in the GNU Classpath Java code, then the only 
solution I see is to use a preprocessor, and expand gpointer to an int 
or long as appropriate, based upon the standard pointer representation 
in that platform's usual ABI.

I have no idea what we will do when 128-bit machines become available. 
   Probably by that time Sun will have added a type called "long long" 
or "long128", and we'll expand "gpointer" to that on the 128-bit machines.

Like Andrew, I am uncomfortable with using byte[] to represent a raw 
pointer.  I also see Etienne's point of view that a class to 
encapsulate the data is pretty heavy-weight, and that only a few VMs 
would implement special handling for the RawPointer type.  Worse, a VM 
that did handle it specially would not binary-compatible with one that 
treated it as just another class.  Ick; there are no good solutions.

I hate to introduce the notion of a preprocessor.  Oh well, I guess I 
just did.
-- 
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm




From MAILER-DAEMON Thu Apr 08 15:04:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBeoC-0005CG-Rd
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 15:03:28 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBeo1-00057a-0h
	for classpath@gnu.org; Thu, 08 Apr 2004 15:03:17 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBenT-0004xQ-Pz
	for classpath@gnu.org; Thu, 08 Apr 2004 15:03:14 -0400
Received: from [192.195.228.35] (helo=csserver.evansville.edu)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBell-0004Em-Ec
	for classpath@gnu.org; Thu, 08 Apr 2004 15:00:57 -0400
Received: from csserver.evansville.edu (localhost.localdomain [127.0.0.1])
	by csserver.evansville.edu (8.12.8/8.12.8) with ESMTP id i38J0okc000508;
	Thu, 8 Apr 2004 14:00:50 -0500
Received: (from sc87@localhost)
	by csserver.evansville.edu (8.12.8/8.12.8/Submit) id i38J0oAT000504;
	Thu, 8 Apr 2004 14:00:50 -0500
X-Authentication-Warning: csserver.evansville.edu: sc87 set sender to
	s11@member.fsf.org using -f
Sender: sc87@csserver.evansville.edu
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
From: Stephen Compall <s11@member.fsf.org>
References: <40742D2A.7040206@aicas.com> <200404071959.14273.konqueror@gmx.de>
	<40747320.50501@uqam.ca>
Date: 08 Apr 2004 14:00:49 -0500
In-Reply-To: <40747320.50501@uqam.ca>
Message-ID: <xfyad1m70ri.fsf@csserver.evansville.edu>
Lines: 26
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Classpath Discussion Mailing List <classpath@gnu.org>,
	Michael Koch <konqueror@gmx.de>
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 19:03:25 -0000

Etienne Gagnon <gagnon.etienne_m@uqam.ca> writes:

> Michael Koch wrote:
> > Personally I think using "obj" or so is better then using "thiz".
> 
> Agree. I like "obj" instead of "this".  [I don't like "thiz"]
> Similarly, I like "cls" instead of "class".  [I don't like "clazz"]

thiz makes sense if you are trying to maintain proper indentation w/o
reindenting in some cases, e.g.

(*(thiz->closure)) (one,      vs     (*(obj->closure)) (one,
                    two);                                two);

I suggest `self', which I like better than `this' anyway, being a
Python/Smalltalk fan.

I can't think of an alternative for class.

--
Stephen Compall or s11 or sirian

<Errata> f y cn rd ths y cn gt gd jb n cmptr prgrmng (146656)

MD5 Consul AVN World Trade Center radar lock picking Nazi ARPA high
security Exon Shell White House global ISEC 22nd SAS Craig Livingstone



From MAILER-DAEMON Thu Apr 08 15:12:32 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBewy-0007o1-0y
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 15:12:32 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBewt-0007mP-TK
	for classpath@gnu.org; Thu, 08 Apr 2004 15:12:27 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBewH-0007Xb-SH
	for classpath@gnu.org; Thu, 08 Apr 2004 15:12:22 -0400
Received: from [62.253.162.48] (helo=mta08-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBewH-0007X4-90
	for classpath@gnu.org; Thu, 08 Apr 2004 15:11:49 -0400
Received: from cuddles.cambridge.redhat.com ([81.96.64.123])
	by mta08-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP id
	<20040408191151.GUDG10788.mta08-svc.ntlworld.com@cuddles.cambridge.redhat.com>;
	Thu, 8 Apr 2004 20:11:51 +0100
Received: from redhat.com (localhost.localdomain [127.0.0.1])
	by cuddles.cambridge.redhat.com (8.12.8/8.12.8) with ESMTP id
	i38JA0P0014693; Thu, 8 Apr 2004 20:10:10 +0100
Received: (from aph@localhost)
	by redhat.com (8.12.8/8.12.8/Submit) id i38J9wXH014683;
	Thu, 8 Apr 2004 20:09:58 +0100
From: Andrew Haley <aph@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <16501.41862.828335.127032@cuddles.cambridge.redhat.com>
Date: Thu, 8 Apr 2004 20:09:58 +0100
To: Archie Cobbs <archie@dellroad.org>
In-Reply-To: <200404081852.i38IqQj5010495@arch20m.dellroad.org>
References: <16501.35664.147201.496370@cuddles.cambridge.redhat.com>
	<200404081852.i38IqQj5010495@arch20m.dellroad.org>
X-Mailer: VM 7.14 under Emacs 21.3.50.1
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	Jeroen Frijters <jeroen@sumatra.nl>, GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 19:12:30 -0000

Archie Cobbs writes:
 > 
 > Note: by this logic byte[] is the most portable/generic way to hold
 > VM private data. It places no portability restrictions, only
 > (possibly) performance ones. However, I have yet to hear a
 > convincing argument that proves byte[] is slower than RawData (or
 > whatever) on ALL platforms.
 > 
 > E.g., take JC as an example. byte[] and "RawData containing long"
 > both require one "unwrap" to get the pointer. "RawData containing
 > long" wastes 4 bytes on 32-bit platforms, but byte[]->length also
 > costs 4 bytes, so size is a wash. byte[] is portable to 128 bit
 > platforms while "RawData containing long" is not (sure, probably
 > won't happen in my lifetime, but... ).

Am I the only one who cares about type checking?  :-)

 > Finally, "RawData as opaque
 > pointer" doesn't require any unwraping but does hit GC cycle time
 > severely as every object has to be check for being in this special
 > RawData class. So for JC byte[] is best.

We get away with this in GCJ because a pointer outside the heap is
ignored.  I would have thought that many other GCs do this too.

Andrew.



From MAILER-DAEMON Thu Apr 08 15:30:31 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBfEH-0005cO-3z
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 15:30:25 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBfED-0005aY-B4
	for classpath@gnu.org; Thu, 08 Apr 2004 15:30:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBfDg-0005Ia-KO
	for classpath@gnu.org; Thu, 08 Apr 2004 15:30:19 -0400
Received: from [209.152.205.226] (helo=NR-EXCHANGE.netreach.core)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBfDf-0005HR-TH
	for classpath@gnu.org; Thu, 08 Apr 2004 15:29:48 -0400
Received: from netreach.com ([209.152.205.123]) by NR-EXCHANGE.netreach.core
	with Microsoft SMTPSVC(6.0.3790.0); Thu, 8 Apr 2004 15:31:43 -0400
Message-ID: <4075A81C.2020809@netreach.com>
Date: Thu, 08 Apr 2004 15:29:32 -0400
From: Stuart Ballard <sballard@netreach.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.5) Gecko/20031107 Debian/1.5-3
X-Accept-Language: en
MIME-Version: 1.0
To: Archie Cobbs <archie@dellroad.org>
References: <200404081852.i38IqQj5010495@arch20m.dellroad.org>
In-Reply-To: <200404081852.i38IqQj5010495@arch20m.dellroad.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 08 Apr 2004 19:31:43.0947 (UTC)
	FILETIME=[1FD879B0:01C41DA0]
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 19:30:22 -0000

Archie Cobbs wrote:
>>Okay, perhaps we need to agree what platforms we care about.
> 
> Here are my votes... 
> 
> - We don't care about platforms that don't have 8 bit bytes or where
>   typeof(jchar) != signed char.
> 
> - We don't care about platforms where 'jlong' is insufficient to hold
>   VM private data. E.g., on a platform with 128 bit pointers, then
>   the VM must use a hash table or something to derive the actual
>   pointer (or whatever it needs). I.e., we deem 64 bits enough to
>   uniquely describe all unique VM-private data structures.

I'd like to see some qualification of "don't care". Seems to me that 
there are multiple levels of caring:

1) "Normal" VMs on "Normal" platforms. Use JNI, don't have any 
weirdnesses about the sizes or types of JNI data types.

2) "Unusual" VMs: Things where JNI-centric assumptions don't hold true. 
For example, IKVM and Jaos(?) don't use JNI at all within Classpath, and 
their natural "pointer" type is just a normal object reference. gcj with 
CNI also falls into this category.

3) "Unusual" platforms: Any real and existing platforms to which a 
Classpath port is a real possibility, but violate one of the two 
criteria above, or other normally reasonable assumptions about the 
behavior of the CPU, OS or C compiler.

4) Non-free VMs: generally JDK derivatives that we have no control over 
and are unlikely to change to adopt our practices, or even optimize for 
them.

5) Nonexistent VMs or nonexistent platforms: VMs or platforms that are 
theoretically possible or theoretically permitted by the standards, but 
which never actually occur in any real platform now or in the forseeable 
future, or will never be able to run even a minimal JVM (Z80 or 6502 
chips probably fall into the latter category?)

Seems to me that whatever is adopted needs to take into account the 
existence of types 2 and 3, but it's okay to optimize for performance on 
type 1. I'm not sure that we should invest *any* time worrying about 
types 4 or 5 (although I can conceive of situations where portability to 
type 4 is desirable, it's certainly not the general case *within Classpath*)

The byte array solution has negative implications for, at least, type 2: 
it's generally impossible to round-trip between an object reference and 
a byte[] without a hashtable and serious inefficiency.

The opaque RawData class may have negative performance implications for 
type 1 (does everyone agree on this? hard to tell), which makes it 
undesirable, but it is at least usable on all types (including the ones 
we don't care about).

Nobody yet in this thread has talked about the possibility of just using 
Object references, unless I've missed it. The advantage would be that 
you can store whatever type you like - byte[] or an opaque RawData class 
or a native pointer or anything - the disadvantage would be that the 
native code couldn't be shared when different things were stored there. 
This solution would help type 2 systems (which generally don't share the 
JNI native code anyway) while still allowing the JNI default code to use 
byte[] (or for the flamewar to continue over what it should use ;) )


I think that it's important to draw a distinction between these various 
types of VM, because they have different needs, different performance 
characteristics, and in some cases (like the byte[] solution on type 2) 
can't use one particular approach *at all* - or at least, not without 
severe, orders-of-magnitude-worse performance problems.

Stuart.
-- 
Stuart Ballard, Senior Web Developer
NetReach, Inc.
(215) 283-2300, ext. 126
http://www.netreach.com/




From MAILER-DAEMON Thu Apr 08 15:32:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBfG5-0006I9-VF
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 15:32:17 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBfG3-0006H3-A4
	for classpath@gnu.org; Thu, 08 Apr 2004 15:32:15 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBfFU-00063D-3U
	for classpath@gnu.org; Thu, 08 Apr 2004 15:32:11 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BBfFT-00062H-Bc
	for classpath@gnu.org; Thu, 08 Apr 2004 15:31:39 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id bac16056_8991_11d8_9874_00304811e8c8_27934;
	Thu, 08 Apr 2004 14:20:00 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i38JUCnK010817; 
	Thu, 8 Apr 2004 14:30:13 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i38JUA5x010816;
	Thu, 8 Apr 2004 14:30:10 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404081930.i38JUA5x010816@arch20m.dellroad.org>
In-Reply-To: <16501.41862.828335.127032@cuddles.cambridge.redhat.com>
To: Andrew Haley <aph@redhat.com>
Date: Thu, 8 Apr 2004 14:30:10 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: Mark Wielaard <mark@klomp.org>, Jeroen Frijters <jeroen@sumatra.nl>,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 19:32:15 -0000

Andrew Haley wrote:
>  > Finally, "RawData as opaque
>  > pointer" doesn't require any unwraping but does hit GC cycle time
>  > severely as every object has to be check for being in this special
>  > RawData class. So for JC byte[] is best.
> 
> We get away with this in GCJ because a pointer outside the heap is
> ignored.  I would have thought that many other GCs do this too.

They probably do, but JC doesn't right now.. it assumes objects live
either in the heap or in per-loader memory, and in the latter case,
it assumes the object must be a Class instance. Relaxing these assumptions
wouldn't cost that much, but the point is of course that there would
be a non-zero impact so the change wouldn't be "free".

In the future JC may support stack-allocated objects, in which case
it would then know to ignore any reference pointing to a "weird" place,
so this will probably change.

As I've stated before, there are lots of different tradeoffs with
all the VM's out there and IMHO Classpath should not try to assume
too much about what's efficient, how things "should" be done, etc.
but rather specific a fairly generic way of doing things and let
the VM implementors do their VM-specific tweaks, as they are surely
going to have to do anyway.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Thu Apr 08 15:36:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBfK3-0000Fn-If
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 15:36:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBfK1-0000EZ-A0
	for classpath@gnu.org; Thu, 08 Apr 2004 15:36:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBfJV-0008Mi-5u
	for classpath@gnu.org; Thu, 08 Apr 2004 15:36:20 -0400
Received: from [213.51.128.197] (helo=smtpq2.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBfI4-0007NC-8F
	for classpath@gnu.org; Thu, 08 Apr 2004 15:34:20 -0400
Received: from [213.51.128.135] (port=56614 helo=smtp4.home.nl)
	by smtpq2.home.nl with esmtp (Exim 4.30)
	id 1BBfHy-0000hc-M2; Thu, 08 Apr 2004 21:34:14 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:33785
	helo=dumas.thomas.planescape.com)
	by smtp4.home.nl with esmtp (Exim 4.30)
	id 1BBfI5-0000I6-8O; Thu, 08 Apr 2004 21:34:21 +0200
From: Thomas Zander <zander@javalobby.org>
To: mauve-discuss@sources.redhat.com
Date: Thu, 8 Apr 2004 21:33:31 +0200
User-Agent: KMail/1.6.1
References: <200404060956.14298.zander@javalobby.org>
	<200404061046.27919.konqueror@gmx.de>
In-Reply-To: <200404061046.27919.konqueror@gmx.de>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404082133.32680.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Mauve patches.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 19:36:22 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I'd really like to see my stuff committed, or commented on if just=20
committing is unacceptable.

Are there any people actually maintaining mauve?  Nobody commented on the=20
fixed needed for the website either.
In short who is the core maintainer for mauve?

On Tuesday 06 April 2004 10:46, Michael Koch wrote:
> Am Dienstag, 6. April 2004 09:56 schrieb Thomas:
> > I've submitted several patches to both list and hear nothing; is
> > there anyone who can comment/commit on these?
>
> We are all doing this in our freetime so we need some time nee out
> backlogs sometimes.
>
> Personally I have Mauve CVS access but I'm using not using ant so I cant
> really vote on your patch. I think Tom Tromey or Mark Wielaard will
> look into this in some days. If not please ping me and I will do it.
>
>
> Michael

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAdakLCojCW6H2z/QRAvPAAJ9VIVsdIvvJo9XvNIKvkKtho1FqgQCglYT1
004SB9mIxk/3Z8FF04TrxHE=3D
=3DdK+F
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Thu Apr 08 15:57:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBfeR-00080K-59
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 15:57:27 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBfeM-0007y9-Ro
	for classpath@gnu.org; Thu, 08 Apr 2004 15:57:22 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBfdl-0007mw-Ib
	for classpath@gnu.org; Thu, 08 Apr 2004 15:57:17 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBfax-0006Cx-4k
	for classpath@gnu.org; Thu, 08 Apr 2004 15:53:51 -0400
Received: from [212.6.122.96] (helo=mail0.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBfXz-0002vH-0Y
	for classpath@gnu.org; Thu, 08 Apr 2004 15:50:47 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-108.ewetel.net
	[80.228.94.108])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i38JocX3020778;
	Thu, 8 Apr 2004 21:50:39 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBec0-0002qO-00; Thu, 08 Apr 2004 20:50:52 +0200
From: Michael Koch <konqueror@gmx.de>
To: Thomas Zander <zander@javalobby.org>, mauve-discuss@sources.redhat.com
Date: Thu, 8 Apr 2004 21:50:24 +0200
User-Agent: KMail/1.5.4
References: <200404060956.14298.zander@javalobby.org>
	<200404061046.27919.konqueror@gmx.de>
	<200404082133.32680.zander@javalobby.org>
In-Reply-To: <200404082133.32680.zander@javalobby.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404082150.24907.konqueror@gmx.de>
X-CheckCompat: OK
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Mauve patches.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 19:57:24 -0000

Am Donnerstag, 8. April 2004 21:33 schrieb Thomas Zander:
> I'd really like to see my stuff committed, or commented on if just
> committing is unacceptable.
>
> Are there any people actually maintaining mauve?  Nobody commented on
> the fixed needed for the website either.
> In short who is the core maintainer for mauve?

Mauve has no real maintainer. There are just some people that commit 
stuff in a chaotic way.

Michael

> On Tuesday 06 April 2004 10:46, Michael Koch wrote:
> > Am Dienstag, 6. April 2004 09:56 schrieb Thomas:
> > > I've submitted several patches to both list and hear nothing; is
> > > there anyone who can comment/commit on these?
> >
> > We are all doing this in our freetime so we need some time nee out
> > backlogs sometimes.
> >
> > Personally I have Mauve CVS access but I'm using not using ant so I
> > cant really vote on your patch. I think Tom Tromey or Mark Wielaard
> > will look into this in some days. If not please ping me and I will
> > do it.
> >
> >
> > Michael




From MAILER-DAEMON Thu Apr 08 16:05:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBflz-0002Np-Od
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 16:05:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBflx-0002Mk-57
	for classpath@gnu.org; Thu, 08 Apr 2004 16:05:13 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBflR-00021K-AU
	for classpath@gnu.org; Thu, 08 Apr 2004 16:05:12 -0400
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBflQ-000209-CV
	for classpath@gnu.org; Thu, 08 Apr 2004 16:04:40 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-108.ewetel.net
	[80.228.94.108])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id i38K4cNj018244
	for <classpath@gnu.org>; Thu, 8 Apr 2004 22:04:39 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBepY-0002wh-00
	for <classpath@gnu.org>; Thu, 08 Apr 2004 21:04:52 +0200
From: Michael Koch <konqueror@gmx.de>
To: classpath@gnu.org
Date: Thu, 8 Apr 2004 22:04:24 +0200
User-Agent: KMail/1.5.4
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404082204.24821.konqueror@gmx.de>
X-CheckCompat: OK
Subject: The big NIO
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 20:05:13 -0000

Hi list,


I just commited my big NIO patch. I doesnt contain yet anything from the 
big pointer discussion. It is just a merge from libgcj. It reworks 
java.io file operations to use java.nio.channels internally for 
performance. I have done a full mauve run and found no new strange 
failures with jamvm. If any problems occur please mail to me.


Michael




From MAILER-DAEMON Thu Apr 08 16:37:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBgHd-0002v0-Hd
	for mharc-classpath@gnu.org; Thu, 08 Apr 2004 16:37:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBgHS-0002qB-5c
	for classpath@gnu.org; Thu, 08 Apr 2004 16:37:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBgGw-0002cI-AC
	for classpath@gnu.org; Thu, 08 Apr 2004 16:37:45 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBgGv-0002bt-MS
	for classpath@gnu.org; Thu, 08 Apr 2004 16:37:13 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-108.ewetel.net
	[80.228.94.108])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i38KbBpH001968
	for <classpath@gnu.org>; Thu, 8 Apr 2004 22:37:12 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBfL3-0002xw-00
	for <classpath@gnu.org>; Thu, 08 Apr 2004 21:37:25 +0200
From: Michael Koch <konqueror@gmx.de>
To: classpath@gnu.org
Date: Thu, 8 Apr 2004 22:36:58 +0200
User-Agent: KMail/1.5.4
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404082236.58046.konqueror@gmx.de>
X-CheckCompat: OK
Subject: Support for installation of glibj.zip and separate class files
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2004 20:37:46 -0000

Hi all, 



With my big NIO commit I accidently commited the first part (the parts 
in configure.ac) for this patch and so I decided to commit it fully.
We now have two options for installing our classes

--enable-glibj
installs glibj.zip (enabled by default)

--enable-class-install
installs all classes as separate files as needed by jamvm and sablevm 
(disabled by default)

Both options are indepedently from each other. You can even disable both 
options but this does not make really sense.

I'm not really satisfied with the name "--enable-class-install". If 
someone finds a better name please shout at me.


Michael




From MAILER-DAEMON Fri Apr 09 03:09:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBq95-00066x-Hi
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 03:09:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBq8v-0005zA-Ip
	for classpath@gnu.org; Fri, 09 Apr 2004 03:09:37 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBq8O-0005eg-0o
	for classpath@gnu.org; Fri, 09 Apr 2004 03:09:36 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBq8N-0005Xj-Ff
	for classpath@gnu.org; Fri, 09 Apr 2004 03:09:03 -0400
Received: from [195.18.123.2] (helo=kiev.dev.factotummedia.nl)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBq6X-0006FB-6i
	for classpath@gnu.org; Fri, 09 Apr 2004 03:07:09 -0400
Received: from amavis by kiev.dev.factotummedia.nl with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BBq3e-0006sM-00
	for <classpath@gnu.org>; Fri, 09 Apr 2004 09:04:10 +0200
Received: from kiev.dev.factotummedia.nl ([127.0.0.1])
	by localhost (kiev [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
	id 26197-05 for <classpath@gnu.org>;
	Fri, 9 Apr 2004 09:04:10 +0200 (CEST)
Received: from pc-thomas.dev.factotummedia.nl ([192.168.3.104])
	by kiev.dev.factotummedia.nl with esmtp (Exim 3.35 #1 (Debian))
	id 1BBq3e-0006sF-00
	for <classpath@gnu.org>; Fri, 09 Apr 2004 09:04:10 +0200
From: Thomas <zander@javalobby.org>
To: classpath@gnu.org
Date: Fri, 9 Apr 2004 09:07:56 +0200
User-Agent: KMail/1.6.2
References: <200404082236.58046.konqueror@gmx.de>
In-Reply-To: <200404082236.58046.konqueror@gmx.de>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404090907.58220.zander@javalobby.org>
X-Virus-Scanned: by amavisd-new (Debian) at dev.factotummedia.nl
Subject: Re: Support for installation of glibj.zip and separate class files
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 07:09:38 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Perhaps a better interface (more intuitive) would be something like this:
=2D --enable-install=3D[both|classes|zip]



On Thursday 08 April 2004 22:36, Michael Koch wrote:
> Hi all,
>
>
>
> With my big NIO commit I accidently commited the first part (the parts
> in configure.ac) for this patch and so I decided to commit it fully.
> We now have two options for installing our classes
>
> --enable-glibj
> installs glibj.zip (enabled by default)
>
> --enable-class-install
> installs all classes as separate files as needed by jamvm and sablevm
> (disabled by default)
>
> Both options are indepedently from each other. You can even disable both
> options but this does not make really sense.
>
> I'm not really satisfied with the name "--enable-class-install". If
> someone finds a better name please shout at me.
>
>
> Michael
>
>
>
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath

=2D --=20
Regards
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAdkvMCojCW6H2z/QRAmqSAJ4tYJtHMT+pXXaO5Orm7QWBeKoLQQCgtcWu
K56xK+ssGRlT2ONCqXur0fA=3D
=3DYVXS
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Fri Apr 09 04:17:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBrCx-0006UG-SU
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 04:17:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBrCu-0006SY-Tp
	for classpath@gnu.org; Fri, 09 Apr 2004 04:17:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBrCO-0006An-ON
	for classpath@gnu.org; Fri, 09 Apr 2004 04:17:47 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBrCO-0006AC-AH
	for classpath@gnu.org; Fri, 09 Apr 2004 04:17:16 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 9 Apr 2004 10:17:09 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD65@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQdix40nBmXxAjaT7uL8raxBJ6L9wAcmBWA
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Etienne Gagnon" <gagnon.etienne_m@uqam.ca>
Cc: Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>,
	GNU Classpath <classpath@gnu.org>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 08:17:50 -0000

Etienne Gagnon wrote:
> Jeroen Frijters wrote:
> >>>Indeed. The goal is to find the optimal solution that would be spec
> >>>compliant, portable and efficient.
>=20
> and later:
> > I'm not the one nitpicking about pure ISO C portability (I don't use
> > JNI, so I couldn't care less), ...
>=20
> and later:
> >>and is of thus ranks lower than my proposal on 2 counts:
> >>1- Efficiency:
> >=20
> > For a JNI based implementation, maybe, but I'd argue that=20
> anyone using
> > JNI doesn't care about performance anyway.
>=20
> You contradict yourself.  First you say that the optimal is=20
> spec compliant, portable, and efficient.  Then you say that
> you couldn't care less about the spec compliant JNI interface,
> that portability across JVMs/compilers on a single platform is
> of no interest, and that efficiency of JNI is not an objective
> of your proposal.

Let me explain. I don't see Classpath as a monolithic entitity. I see
Classpath as two parts, Java and native. I use the Java part, I don't
use the native part. I care about Classpath as a whole. I think the
native part is valuable (because it increases the value of Classpath as
a whole, it also increases the value of the Java part).

In the particular case we are discussing (memory mapped NIO), I think
that JNI is a lousy interface. I think it will prove to be far too slow,
therefor I want to use the proper abstractions that allow VMs to
optimize these operations. IMHO, RawData is better abstraction than a
byte[] for this particular purpose.

I just wrote a little benchmark comparing byte[] and RawData for reading
bytes (i.e. dereferencing the pointer) and another one that tests
alloc/free. It turns out that RawData is actually marginally faster (in
both cases). This is on x86 32bit on Sun JDK 1.4.1 using standard JNI.

I'm not going to give the code, because that'll just trigger another
round of language lawyering, but I'm convinced that C language issues do
not have any significant impact on the performance of either solution.

For reference, my (partially) optimized implementation of dereferencing
the RawData pointer is almost an order of magnitude faster than the JNI
implementation running on the Sun JVM (and two orders of magnitude
faster than the JNI implementation running on my VM).

Regards,
Jeroen



From MAILER-DAEMON Fri Apr 09 04:36:39 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBrV8-00025a-QS
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 04:36:38 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBrUy-00021R-26
	for classpath@gnu.org; Fri, 09 Apr 2004 04:36:28 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBrUP-0001lE-PD
	for classpath@gnu.org; Fri, 09 Apr 2004 04:36:24 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBrUP-0001iF-8X
	for classpath@gnu.org; Fri, 09 Apr 2004 04:35:53 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 9 Apr 2004 10:31:56 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD68@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQdmtf8VU01zXOrQyObsHpJ7DNdbwAcRsfA
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Archie Cobbs" <archie@dellroad.org>,
	"Andrew Haley" <aph@redhat.com>
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 08:36:34 -0000

Archie Cobbs wrote:
> Note: by this logic byte[] is the most portable/generic way to hold
> VM private data. It places no portability restrictions, only=20
> (possibly) performance ones. However, I have yet to hear a
> convincing argument that proves byte[] is slower than RawData
> (or whatever) on ALL platforms.

IMHO, that is a flawed argument. RawData allows better performance (for
VMs that do extra work), byte[] actively prevents that. So the trade-off
is *marginally* better portability (byte[]) or the option of better
performance (RawData).

Not to mention the fact that RawData is a distinct type and opaque from
the Java side. The contents byte[] can be manipulated in Java, or a
completely wrong byte array could be passed. So I agree with Andrew and
Steve, that it is also a better option from a software engineering pov.

> E.g., take JC as an example. byte[] and "RawData containing long" both
> require one "unwrap" to get the pointer. "RawData containing long"
> wastes 4 bytes on 32-bit platforms, but byte[]->length also=20
> costs 4 bytes, so size is a wash.

But the beauty of RawData is that you can use 32 bit pointers on 32 bit
platforms!

Regards,
Jeroen



From MAILER-DAEMON Fri Apr 09 04:36:39 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBrV9-00025y-Bb
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 04:36:39 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBrV1-00021a-Te
	for classpath@gnu.org; Fri, 09 Apr 2004 04:36:31 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBrUO-0001kF-St
	for classpath@gnu.org; Fri, 09 Apr 2004 04:36:25 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBrUN-0001iF-K7
	for classpath@gnu.org; Fri, 09 Apr 2004 04:35:52 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 9 Apr 2004 10:35:50 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD67@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQdmiXx8fJP7X3PSi2fV2xbDGG5MQAcSwKw
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Steven Augart" <augart@watson.ibm.com>,
	"Andrew Haley" <aph@redhat.com>
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 08:36:34 -0000

Steven Augart wrote:
> If we were to do this in the GNU Classpath Java code, then the only=20
> solution I see is to use a preprocessor, and expand gpointer=20
> to an int  or long as appropriate, based upon the standard pointer=20
> representation in that platform's usual ABI.

That wouldn't work for me. My (single) binary runs on both 32 and 64 bit
platforms. That's why I like using an object reference. BTW, I don't
actually store a native pointer in an object reference. I replace
RawData references with a native pointer type that the CLI support
(System.IntPtr). This is a primitive type, but it can also be boxed when
you assign it to an object reference.

Regards,
Jeroen



From MAILER-DAEMON Fri Apr 09 04:36:40 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBrVA-00026I-2x
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 04:36:40 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBrV3-00022M-2J
	for classpath@gnu.org; Fri, 09 Apr 2004 04:36:33 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBrUQ-0001la-PH
	for classpath@gnu.org; Fri, 09 Apr 2004 04:36:25 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBrUQ-0001iF-7X
	for classpath@gnu.org; Fri, 09 Apr 2004 04:35:54 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 9 Apr 2004 10:35:47 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD69@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQdn+F2Op4C9/v5RCC12CQAvtzY9gAbVAbg
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Stuart Ballard" <sballard@netreach.com>,
	"Archie Cobbs" <archie@dellroad.org>
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 08:36:35 -0000

Stuart Ballard wrote:
> 2) "Unusual" VMs: Things where JNI-centric assumptions don't=20
> hold true.=20
> For example, IKVM and Jaos(?) don't use JNI at all within=20
> Classpath, and their natural "pointer" type is just a normal
> object reference. gcj with CNI also falls into this category.

I'd like to qualify this. IKVM does have native pointers. This
discussion is about RawData use in NIO, in which case we are talking
about native memory (presumably in most/all VM types). For general VM
state, I wouldn't like to see RawData used, because on IKVM, Jaos and
Jikes RVM, you'd typically want the VM state to be in a Java heap object
as well.

Regards,
Jeroen



From MAILER-DAEMON Fri Apr 09 08:45:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBvOK-000730-3u
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 08:45:52 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBvCb-0004H8-Iy
	for classpath@gnu.org; Fri, 09 Apr 2004 08:33:45 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBv2k-0002XV-6K
	for classpath@gnu.org; Fri, 09 Apr 2004 08:24:05 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBv0Q-00021v-Fj
	for classpath@gnu.org; Fri, 09 Apr 2004 08:21:10 -0400
Received: from sp1n293en1.watson.ibm.com (sp1n293en1.watson.ibm.com
	[129.34.20.41])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i39CL5q103938; Fri, 9 Apr 2004 08:21:05 -0400
Received: from watson.ibm.com (localhost [127.0.0.1])
	by sp1n293en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i39CL4F56380; Fri, 9 Apr 2004 08:21:04 -0400
Message-ID: <40769526.20001@watson.ibm.com>
Date: Fri, 09 Apr 2004 08:20:54 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en, it, eo, pt, gl, es-ec, es-us, es, fr, ast, el
MIME-Version: 1.0
To: Jeroen Frijters <jeroen@sumatra.nl>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD67@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD67@LEMBU.sumatrasoftware.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 12:45:50 -0000

If the RawData type were to be used, would you be able to share a 
Classpath installation with other Classpath-based virtual machines?

--Steve Augart

Jeroen Frijters wrote:
> Steven Augart wrote:
> 
>>If we were to do this in the GNU Classpath Java code, then the only 
>>solution I see is to use a preprocessor, and expand gpointer 
>>to an int  or long as appropriate, based upon the standard pointer 
>>representation in that platform's usual ABI.
> 
> 
> That wouldn't work for me. My (single) binary runs on both 32 and 64 bit
> platforms. That's why I like using an object reference. BTW, I don't
> actually store a native pointer in an object reference. I replace
> RawData references with a native pointer type that the CLI support
> (System.IntPtr). This is a primitive type, but it can also be boxed when
> you assign it to an object reference.

-- 
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm



From MAILER-DAEMON Fri Apr 09 08:48:53 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBvRF-00089d-70
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 08:48:53 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBvRC-00087I-9F
	for classpath@gnu.org; Fri, 09 Apr 2004 08:48:50 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBvQf-0007vm-Ae
	for classpath@gnu.org; Fri, 09 Apr 2004 08:48:48 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBvQe-0007sb-Pi
	for classpath@gnu.org; Fri, 09 Apr 2004 08:48:16 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 9 Apr 2004 14:45:51 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD78@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Classpath build process and VM-specific issues
Thread-Index: AcQeLTTmaiupFeSrTCuQi+pXfQH7ZwAAm50g
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Steven Augart" <augart@watson.ibm.com>
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>,
	GNU Classpath <classpath@gnu.org>,
	Mark Wielaard <mark@klomp.org>, Michael Koch <konqueror@gmx.de>
Subject: RE: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 12:48:51 -0000

Steven Augart wrote:
> If the RawData type were to be used, would you be able to share a=20
> Classpath installation with other Classpath-based virtual machines?

For some purposes yes. For performance (and some bootstrapping) reasons
I compile Classpath code ahead of time to a CLI assembly, so at runtime
there wouldn't be any sharing, but the compilation process could use the
shared Classpath installation.

Regards,
Jeroen



From MAILER-DAEMON Fri Apr 09 09:29:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBw3q-0006tU-CT
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 09:28:46 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBw3Z-0006T4-GR
	for classpath@gnu.org; Fri, 09 Apr 2004 09:28:29 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBw2M-0003qs-AJ
	for classpath@gnu.org; Fri, 09 Apr 2004 09:27:47 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBw2C-0003fM-Q4
	for classpath@gnu.org; Fri, 09 Apr 2004 09:27:04 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C41E36.0D2934B8"
Date: Fri, 9 Apr 2004 15:24:51 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD7C@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator: 
Thread-Topic: The big NIO
Thread-Index: AcQdpQhUhHx2u7NvRMiYmn9pxo571QAkH5NQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Michael Koch" <konqueror@gmx.de>,
	<classpath@gnu.org>
Cc: 
Subject: RE: The big NIO
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 13:28:44 -0000

This is a multi-part message in MIME format.

------_=_NextPart_001_01C41E36.0D2934B8
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Michael Koch wrote:
> I just commited my big NIO patch. I doesnt contain yet=20
> anything from the big pointer discussion. It is just a merge from
libgcj.
> It reworks java.io file operations to use java.nio.channels internally
> for performance. I have done a full mauve run and found no new strange

> failures with jamvm. If any problems occur please mail to me.

Thanks! I integrated the changes and everything went very smooth. I
really appreciate your efforts. Attached are a few minor suggestions for
FileChannelImpl. I removed some things that appeared to be unused, but
if someone does use it, please just ignore that part of the patch.

Regards,
Jeroen

------_=_NextPart_001_01C41E36.0D2934B8
Content-Type: application/octet-stream;
	name="FileChannelImpl.diff"
Content-Transfer-Encoding: base64
Content-Description: FileChannelImpl.diff
Content-Disposition: attachment;
	filename="FileChannelImpl.diff"

SW5kZXg6IGdudS9qYXZhL25pby9jaGFubmVscy9GaWxlQ2hhbm5lbEltcGwuamF2YQ0KPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvZ251L2phdmEvbmlv
L2NoYW5uZWxzL0ZpbGVDaGFubmVsSW1wbC5qYXZhLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4x
DQpkaWZmIC11IC1yMS4xIEZpbGVDaGFubmVsSW1wbC5qYXZhDQotLS0gZ251L2phdmEvbmlvL2No
YW5uZWxzL0ZpbGVDaGFubmVsSW1wbC5qYXZhCTggQXByIDIwMDQgMjA6MDQ6MTIgLTAwMDAJMS4x
DQorKysgZ251L2phdmEvbmlvL2NoYW5uZWxzL0ZpbGVDaGFubmVsSW1wbC5qYXZhCTkgQXByIDIw
MDQgMTM6MjA6MjAgLTAwMDANCkBAIC05NywxMSArOTcsOSBAQA0KICAgLy8gSG93ZXZlciwgdGhp
cyBpcyBuZWNlc3NhcnkgYmVjYXVzZSBpZiBvcGVuKCkgdGhyb3dzIGFuIGV4Y2VwdGlvbg0KICAg
Ly8gd2Ugd2FudCB0byBtYWtlIHN1cmUgdGhpcyBoYXMgdGhlIHZhbHVlIC0xLiAgVGhpcyBpcyB0
aGUgbW9zdA0KICAgLy8gZWZmaWNpZW50IHdheSB0byBhY2NvbXBsaXNoIHRoYXQuDQotICBpbnQg
ZmQgPSAtMTsNCisgIHByaXZhdGUgaW50IGZkID0gLTE7DQogDQotICBpbnQgbW9kZTsNCi0gIGlu
dCBsZW5ndGg7DQotICBsb25nIHBvczsNCisgIHByaXZhdGUgaW50IG1vZGU7DQogDQogICBwdWJs
aWMgRmlsZUNoYW5uZWxJbXBsICgpDQogICB7DQpAQCAtMTIwLDE5ICsxMTgsMTIgQEANCiANCiAg
IHByaXZhdGUgbmF0aXZlIGludCBvcGVuIChTdHJpbmcgcGF0aCwgaW50IG1vZGUpIHRocm93cyBG
aWxlTm90Rm91bmRFeGNlcHRpb247DQogDQotICAvKiogQXR0YWNoIHRvIGFuIGFscmVhZHktb3Bl
bmVkIGZpbGUuICAqLw0KLSAgcHVibGljIEZpbGVDaGFubmVsSW1wbCAoaW50IGRlc2MsIGludCBt
b2RlKQ0KLSAgew0KLSAgICBmZCA9IGRlc2M7DQotICAgIHRoaXMubW9kZSA9IG1vZGU7DQotICB9
DQotDQogICBwdWJsaWMgbmF0aXZlIGludCBhdmFpbGFibGUgKCkgdGhyb3dzIElPRXhjZXB0aW9u
Ow0KLSAgcHJpdmF0ZSBuYXRpdmUgbG9uZyBpbXBsUG9zaXRpb24gKCk7DQotICBwcml2YXRlIG5h
dGl2ZSB2b2lkIHNlZWsgKGxvbmcgbmV3UG9zaXRpb24pOw0KLSAgcHJpdmF0ZSBuYXRpdmUgdm9p
ZCBpbXBsVHJ1bmNhdGUgKGxvbmcgc2l6ZSk7DQorICBwcml2YXRlIG5hdGl2ZSBsb25nIGltcGxQ
b3NpdGlvbiAoKSB0aHJvd3MgSU9FeGNlcHRpb247DQorICBwcml2YXRlIG5hdGl2ZSB2b2lkIHNl
ZWsgKGxvbmcgbmV3UG9zaXRpb24pIHRocm93cyBJT0V4Y2VwdGlvbjsNCisgIHByaXZhdGUgbmF0
aXZlIHZvaWQgaW1wbFRydW5jYXRlIChsb25nIHNpemUpIHRocm93cyBJT0V4Y2VwdGlvbjsNCiAg
IA0KLSAgcHVibGljIG5hdGl2ZSB2b2lkIHVubG9jayAobG9uZyBwb3MsIGxvbmcgbGVuKTsNCisg
IHB1YmxpYyBuYXRpdmUgdm9pZCB1bmxvY2sgKGxvbmcgcG9zLCBsb25nIGxlbikgdGhyb3dzIElP
RXhjZXB0aW9uOw0KIA0KICAgcHVibGljIG5hdGl2ZSBsb25nIHNpemUgKCkgdGhyb3dzIElPRXhj
ZXB0aW9uOw0KICAgICANCkBAIC0zNTYsNyArMzQ3LDcgQEANCiAgICAqIE90aGVyd2lzZSByZXR1
cm4gZmFsc2UuDQogICAgKi8NCiAgIHByaXZhdGUgbmF0aXZlIGJvb2xlYW4gbG9jayhsb25nIHBv
c2l0aW9uLCBsb25nIHNpemUsDQotCQkJICAgICAgYm9vbGVhbiBzaGFyZWQsIGJvb2xlYW4gd2Fp
dCk7DQorCQkJICAgICAgYm9vbGVhbiBzaGFyZWQsIGJvb2xlYW4gd2FpdCkgdGhyb3dzIElPRXhj
ZXB0aW9uOw0KICAgDQogICBwdWJsaWMgRmlsZUxvY2sgbG9jayAobG9uZyBwb3NpdGlvbiwgbG9u
ZyBzaXplLCBib29sZWFuIHNoYXJlZCkNCiAgICAgdGhyb3dzIElPRXhjZXB0aW9uDQo=

------_=_NextPart_001_01C41E36.0D2934B8--



From MAILER-DAEMON Fri Apr 09 09:44:07 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBwGq-0005Br-Ho
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 09:42:12 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBwGZ-00054L-T8
	for classpath@gnu.org; Fri, 09 Apr 2004 09:41:55 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBwFr-0004gd-MN
	for classpath@gnu.org; Fri, 09 Apr 2004 09:41:49 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBwDV-0003jh-3D
	for classpath@gnu.org; Fri, 09 Apr 2004 09:38:45 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C41E37.F87C9166"
Date: Fri, 9 Apr 2004 15:38:36 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD7D@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator: 
Thread-Topic: FileDescriptor patch
Thread-Index: AcQeN/Vv+qGcdcxLTii9bU4uEAkQhA==
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: <classpath@gnu.org>,
	"Michael Koch" <konqueror@gmx.de>
Cc: 
Subject: FileDescriptor patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 13:42:05 -0000

This is a multi-part message in MIME format.

------_=_NextPart_001_01C41E37.F87C9166
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi,

If there aren't any objections, I'll commit the attached fix.

Regards,
Jeroen

------_=_NextPart_001_01C41E37.F87C9166
Content-Type: application/octet-stream;
	name="FileDescriptor.patch"
Content-Transfer-Encoding: base64
Content-Description: FileDescriptor.patch
Content-Disposition: attachment;
	filename="FileDescriptor.patch"

SW5kZXg6IGphdmEvaW8vRmlsZURlc2NyaXB0b3IuamF2YQ0KPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6
IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvamF2YS9pby9GaWxlRGVzY3JpcHRvci5qYXZh
LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMQ0KZGlmZiAtdSAtcjEuMjEgRmlsZURlc2NyaXB0
b3IuamF2YQ0KLS0tIGphdmEvaW8vRmlsZURlc2NyaXB0b3IuamF2YQk4IEFwciAyMDA0IDIwOjA0
OjEyIC0wMDAwCTEuMjENCisrKyBqYXZhL2lvL0ZpbGVEZXNjcmlwdG9yLmphdmEJOSBBcHIgMjAw
NCAxMzozODoxNCAtMDAwMA0KQEAgLTgzLDYgKzgzLDE0IEBADQogICAvKioNCiAgICAqIFRoaXMg
bWV0aG9kIGlzIHVzZWQgdG8gaW5pdGlhbGl6ZSBhbiBpbnZhbGlkIEZpbGVEZXNjcmlwdG9yIG9i
amVjdC4NCiAgICAqLw0KKyAgcHVibGljIEZpbGVEZXNjcmlwdG9yKCkNCisgIHsNCisgICAgY2hh
bm5lbCA9IG51bGw7DQorICB9DQorDQorICAvKioNCisgICAqIFRoaXMgbWV0aG9kIGlzIHVzZWQg
dG8gaW5pdGlhbGl6ZSBhIEZpbGVEZXNjcmlwdG9yIG9iamVjdC4NCisgICAqLw0KICAgRmlsZURl
c2NyaXB0b3IoQnl0ZUNoYW5uZWwgY2hhbm5lbCkNCiAgIHsNCiAgICAgdGhpcy5jaGFubmVsID0g
Y2hhbm5lbDsNCkBAIC0xMjUsNiArMTMzLDYgQEANCiAgICAqLw0KICAgcHVibGljIGJvb2xlYW4g
dmFsaWQgKCkNCiAgIHsNCi0gICAgcmV0dXJuIGNoYW5uZWwuaXNPcGVuKCk7DQorICAgIHJldHVy
biBjaGFubmVsICE9IG51bGwgJiYgY2hhbm5lbC5pc09wZW4oKTsNCiAgIH0NCiB9DQo=

------_=_NextPart_001_01C41E37.F87C9166--



From MAILER-DAEMON Fri Apr 09 09:46:29 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBwKy-0006qa-TS
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 09:46:28 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBwKw-0006po-6j
	for classpath@gnu.org; Fri, 09 Apr 2004 09:46:26 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBwKP-0006hK-Kz
	for classpath@gnu.org; Fri, 09 Apr 2004 09:46:24 -0400
Received: from [130.102.176.1] (helo=piglet.dstc.edu.au)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBwKN-0006gg-TN
	for classpath@gnu.org; Fri, 09 Apr 2004 09:45:52 -0400
Received: from dstc.edu.au (credence.dstc.edu.au [130.102.177.137])
	by piglet.dstc.edu.au (8.12.10/8.12.10) with ESMTP id i39DjfmT009694;
	Fri, 9 Apr 2004 23:45:41 +1000 (EST)
Message-Id: <200404091345.i39DjfmT009694@piglet.dstc.edu.au>
X-Mailer: exmh version 2.6.1 02/18/2003 with nmh-1.0.4
To: Guilhem Lavaux <guilhem.lavaux@free.fr>
In-Reply-To: Message from Guilhem Lavaux <guilhem.lavaux@free.fr> 
	of "Thu, 08 Apr 2004 19:16:59 +0200." <4075890B.6070908@free.fr> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Fri, 09 Apr 2004 23:45:44 +1000
From: Stephen Crawley <crawley@dstc.edu.au>
X-Scanned-By: MIMEDefang 2.39 (DSTC)
Cc: crawley@dstc.edu.au, classpath@gnu.org
Subject: Re: The Mauve unicode testcase and VM performance 
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 13:46:27 -0000


Hi Guilhelm,

Thanks for the info.  Your numbers tend to confirm my suspicion that the
factor of 200 is a Kissme-specific  problem. 

In the meantime, I think I have come across a problem in Kissme's
implementation of the CONSTANT_STRING instruction that does some way
towards explaining this.

-- Steve





From MAILER-DAEMON Fri Apr 09 09:49:34 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBwNx-00083P-0H
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 09:49:33 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBwNn-0007zM-10
	for classpath@gnu.org; Fri, 09 Apr 2004 09:49:23 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBwNG-0007eW-2q
	for classpath@gnu.org; Fri, 09 Apr 2004 09:49:21 -0400
Received: from [216.148.227.85] (helo=rwcrmhc12.comcast.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBwNF-0007cN-P4
	for classpath@gnu.org; Fri, 09 Apr 2004 09:48:49 -0400
Received: from byu.net (c-24-10-254-137.client.comcast.net[24.10.254.137])
	by comcast.net (rwcrmhc12) with SMTP id <20040409134837014009gg6te>
	(Authid: ericblake); Fri, 9 Apr 2004 13:48:43 +0000
Message-ID: <4076A9E7.8080308@byu.net>
Date: Fri, 09 Apr 2004 07:49:27 -0600
From: Eric Blake <ebb9@byu.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.4) Gecko/20030624
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: tromey@redhat.com
References: <40742D2A.7040206@aicas.com> <87y8p7v6cq.fsf@fleche.redhat.com>
In-Reply-To: <87y8p7v6cq.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 13:49:24 -0000

Tom Tromey wrote:

> My only comment or criticism is that, in the absence of regular
> checking for this, we'll just see more code like it checked in.
> That's been the experience with non-C89 constructs, I don't see why
> this would be any different.  It's just too hard to remember to write
> in some language subset without compiler-assisted checking.

To avoid regressions, would we want to use a common header file to #define the 
C++ keywords into something that will generate a compile-time error when 
compiling under C?  That is

#define this do not use C++ keywords, JNI must compile in C and C++

-- 
Someday, I might put a cute statement here.

Eric Blake             ebb9@byu.net




From MAILER-DAEMON Fri Apr 09 10:27:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBwz8-0004pK-JM
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 10:27:58 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBwz4-0004l7-OU
	for classpath@gnu.org; Fri, 09 Apr 2004 10:27:54 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBwyX-0004Ca-R4
	for classpath@gnu.org; Fri, 09 Apr 2004 10:27:52 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBwyX-0004B6-Gf
	for classpath@gnu.org; Fri, 09 Apr 2004 10:27:21 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 9 Apr 2004 16:27:14 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD7E@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: FileDescriptor patch
Thread-Index: AcQePSLaAff6UXshS86fsoZaTW0r6AAAXJEg
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Michael Koch" <konqueror@gmx.de>,
	<classpath@gnu.org>
Cc: 
Subject: RE: FileDescriptor patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 14:27:56 -0000

Michael Koch wrote:
> Am Freitag, 9. April 2004 15:38 schrieb Jeroen Frijters:
> > Hi,
> >
> > If there aren't any objections, I'll commit the attached fix.
>=20
> Why do you need this ? Is this for network related stuff ?

No, FileDescriptor is documented to have a public constructor. I don't
see the point either.

Regards,
Jeroen



From MAILER-DAEMON Fri Apr 09 10:30:39 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBwzg-0005HZ-6l
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 10:28:32 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBwzR-00053k-5B
	for classpath@gnu.org; Fri, 09 Apr 2004 10:28:17 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBwyg-0004GD-G9
	for classpath@gnu.org; Fri, 09 Apr 2004 10:28:02 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBwnW-0006sv-Li
	for classpath@gnu.org; Fri, 09 Apr 2004 10:15:58 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BBwnE-0000SW-KC
	for classpath@gnu.org; Fri, 09 Apr 2004 10:15:40 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-018.ewetel.net
	[80.228.95.18])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i39EFWpH013167;
	Fri, 9 Apr 2004 16:15:32 +0200 (MEST)
Received: from asterix.konqueror.de ([192.168.1.3])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBvrH-0002et-00; Fri, 09 Apr 2004 15:15:47 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Jeroen Frijters" <jeroen@sumatra.nl>, <classpath@gnu.org>
Date: Fri, 9 Apr 2004 16:26:09 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD7D@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD7D@LEMBU.sumatrasoftware.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: clearsigned data
Content-Disposition: inline
Message-Id: <200404091626.09423.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: FileDescriptor patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 14:28:21 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Freitag, 9. April 2004 15:38 schrieb Jeroen Frijters:
> Hi,
>
> If there aren't any objections, I'll commit the attached fix.

Why do you need this ? Is this for network related stuff ?


Michael
=2D --=20
Homepage: http://www.worldforge.org/
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAdrKBWSOgCCdjSDsRAu03AKCHyuR1cQ3L5n5XOfAvCC06cSSctQCgi8tm
BLzYTOBHmIV7MIoXEfOb0g0=3D
=3DPyRl
=2D----END PGP SIGNATURE-----




From MAILER-DAEMON Fri Apr 09 10:34:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBx5P-0008AJ-HW
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 10:34:27 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBx5M-000895-Ge
	for classpath@gnu.org; Fri, 09 Apr 2004 10:34:24 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBx4m-0007tl-SC
	for classpath@gnu.org; Fri, 09 Apr 2004 10:34:19 -0400
Received: from [212.6.122.141] (helo=mail4.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBx4m-0007tZ-Em
	for classpath@gnu.org; Fri, 09 Apr 2004 10:33:48 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-018.ewetel.net
	[80.228.95.18])
	by mail4.ewetel.de (8.12.1/8.12.9) with ESMTP id i39EXdPZ006278;
	Fri, 9 Apr 2004 16:33:39 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBw8o-0003Qu-00; Fri, 09 Apr 2004 15:33:54 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Jeroen Frijters" <jeroen@sumatra.nl>, <classpath@gnu.org>
Date: Fri, 9 Apr 2004 16:33:26 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD7E@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD7E@LEMBU.sumatrasoftware.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404091633.26068.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: FileDescriptor patch
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 14:34:25 -0000

Am Freitag, 9. April 2004 16:27 schrieb Jeroen Frijters:
> Michael Koch wrote:
> > Am Freitag, 9. April 2004 15:38 schrieb Jeroen Frijters:
> > > Hi,
> > >
> > > If there aren't any objections, I'll commit the attached fix.
> >
> > Why do you need this ? Is this for network related stuff ?
>
> No, FileDescriptor is documented to have a public constructor. I
> don't see the point either.

Ouch, you are right. I should look into japitools output more often ...
Please commit.


Michael




From MAILER-DAEMON Fri Apr 09 10:37:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBx8T-00012g-8p
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 10:37:37 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBx8Q-000111-G3
	for classpath@gnu.org; Fri, 09 Apr 2004 10:37:34 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBx7q-0000hc-4c
	for classpath@gnu.org; Fri, 09 Apr 2004 10:37:29 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBx7o-0000fW-J5
	for classpath@gnu.org; Fri, 09 Apr 2004 10:36:56 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-018.ewetel.net
	[80.228.95.18])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i39EaqpH025815;
	Fri, 9 Apr 2004 16:36:52 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBwBv-0003RH-00; Fri, 09 Apr 2004 15:37:07 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Jeroen Frijters" <jeroen@sumatra.nl>, <classpath@gnu.org>
Date: Fri, 9 Apr 2004 16:36:39 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD7C@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD7C@LEMBU.sumatrasoftware.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404091636.39343.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: The big NIO
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 14:37:35 -0000

Am Freitag, 9. April 2004 15:24 schrieb Jeroen Frijters:
> Michael Koch wrote:
> > I just commited my big NIO patch. I doesnt contain yet
> > anything from the big pointer discussion. It is just a merge from
>
> libgcj.
>
> > It reworks java.io file operations to use java.nio.channels
> > internally for performance. I have done a full mauve run and found
> > no new strange
> >
> > failures with jamvm. If any problems occur please mail to me.
>
> Thanks! I integrated the changes and everything went very smooth. I
> really appreciate your efforts. Attached are a few minor suggestions
> for FileChannelImpl. I removed some things that appeared to be
> unused, but if someone does use it, please just ignore that part of
> the patch.

Please commit this.


Michael




From MAILER-DAEMON Fri Apr 09 10:55:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBxQ7-0001oA-0F
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 10:55:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBxQ3-0001ml-Rf
	for classpath@gnu.org; Fri, 09 Apr 2004 10:55:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBxOA-0001Dy-7V
	for classpath@gnu.org; Fri, 09 Apr 2004 10:54:21 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BBxMz-0000Ve-No; Fri, 09 Apr 2004 10:52:37 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 9 Apr 2004 16:47:35 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD81@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: FYI: Patch: URLConnection
Thread-Index: AcQeQZjcetaqHsODQVC+VFq4U9xV5A==
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "commit-classpath" <commit-classpath@gnu.org>
Cc: classpath@gnu.org
Subject: FYI: Patch: URLConnection
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 14:55:49 -0000

Hi,

Committed.

Regards,
Jeroen

2004-04-09  Jeroen Frijters  <jeroen@frijters.net>

        * java/net/URLConnection.java: (setContentHandlerFactory): Fixed
        to check static field instead of argument.

Index: java/net/URLConnection.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/classpath/classpath/java/net/URLConnection.java,v
retrieving revision 1.24
diff -u -r1.24 URLConnection.java
--- java/net/URLConnection.java	8 Apr 2004 17:25:02 -0000	1.24
+++ java/net/URLConnection.java	9 Apr 2004 14:44:49 -0000
@@ -872,7 +872,7 @@
    */
   public static synchronized void
setContentHandlerFactory(ContentHandlerFactory factory)
   {
-    if (factory !=3D null)
+    if (URLConnection.factory !=3D null)
       throw new Error("ContentHandlerFactory already set");
=20
     // Throw an exception if an extant security mgr precludes



From MAILER-DAEMON Fri Apr 09 11:09:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBxdm-0006Do-88
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 11:09:58 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBxdj-0006D4-H4
	for classpath@gnu.org; Fri, 09 Apr 2004 11:09:55 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBxd8-00061M-Ao
	for classpath@gnu.org; Fri, 09 Apr 2004 11:09:49 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBxd7-00060u-6G
	for classpath@gnu.org; Fri, 09 Apr 2004 11:09:17 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BBxd6-0007Ld-00
	for <classpath@gnu.org>; Fri, 09 Apr 2004 17:09:16 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBxd2-0007Kc-00; Fri, 09 Apr 2004 17:09:12 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i39F9BLT029114;
	Fri, 9 Apr 2004 17:09:12 +0200 (MEST)
Message-ID: <4076BC97.70301@kaffe.org>
Date: Fri, 09 Apr 2004 17:09:11 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath Commits <classpath-commit@gnu.org>,
	GNU Classpath <classpath@gnu.org>
Content-Type: multipart/mixed; boundary="------------030206060707040506020809"
X-Virus-Scanned: by AMaViS perl-11
Cc: 
Subject: FYI: Patch: java/lang/SecurityManager.java
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 15:09:56 -0000

This is a multi-part message in MIME format.
--------------030206060707040506020809
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi all,

I've committed the attached patch to clean up a direct use of an 
internal field in java.lang.Thread  instead of using the API method for 
it. I've tried to improve the docs a little bit, too.

2004-04-09  Dalibor Topic  <robilad@kaffe.org>

         * java/lang/SecurityManager.java: (checkAccess): Use
	getThreadGroup(). Improved documentation.

cheers,
dalibor topic


--------------030206060707040506020809
Content-Type: text/plain;
 name="cpath-diff-secman"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cpath-diff-secman"

Index: java/lang/SecurityManager.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/lang/SecurityManager.java,v
retrieving revision 1.16
diff -u -r1.16 SecurityManager.java
--- java/lang/SecurityManager.java	6 Jan 2004 09:56:04 -0000	1.16
+++ java/lang/SecurityManager.java	8 Apr 2004 15:31:04 -0000
@@ -375,9 +375,9 @@
    * <code>RuntimePermission("modifyThread")</code>, return silently, so that
    * core classes (the Classpath library!) can modify any thread.
    *
-   * @param t the other Thread to check
+   * @param thread the other Thread to check
    * @throws SecurityException if permission is denied
-   * @throws NullPointerException if t is null
+   * @throws NullPointerException if thread is null
    * @see Thread#stop()
    * @see Thread#suspend()
    * @see Thread#resume()
@@ -385,9 +385,10 @@
    * @see Thread#setName(String)
    * @see Thread#setDaemon(boolean)
    */
-  public void checkAccess(Thread t)
+  public void checkAccess(Thread thread)
   {
-    if (t.group != null && t.group.getParent() != null)
+    if (thread.getThreadGroup() != null 
+	&& thread.getThreadGroup().getParent() != null)
       checkPermission(new RuntimePermission("modifyThread"));
   }
 

--------------030206060707040506020809--



From MAILER-DAEMON Fri Apr 09 11:22:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBxpH-0003fg-IJ
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 11:21:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBxp7-0003YO-ND
	for classpath@gnu.org; Fri, 09 Apr 2004 11:21:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBxoY-00038a-60
	for classpath@gnu.org; Fri, 09 Apr 2004 11:21:38 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BBxo8-0001xD-67; Fri, 09 Apr 2004 11:20:40 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30)
	id 1BBxn0-00064y-Rs; Fri, 09 Apr 2004 11:19:30 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-018.ewetel.net
	[80.228.95.18])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i39FJEre016598;
	Fri, 9 Apr 2004 17:19:15 +0200 (MEST)
Received: from asterix.konqueror.de ([192.168.1.3])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BBwqv-0005SQ-00; Fri, 09 Apr 2004 16:19:29 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Jeroen Frijters" <jeroen@sumatra.nl>,
	"commit-classpath" <commit-classpath@gnu.org>
Date: Fri, 9 Apr 2004 17:29:50 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD81@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD81@LEMBU.sumatrasoftware.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Description: clearsigned data
Content-Disposition: inline
Message-Id: <200404091729.51341.konqueror@gmx.de>
X-CheckCompat: OK
Cc: classpath@gnu.org
Subject: Re: FYI: Patch: URLConnection
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 15:21:46 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Freitag, 9. April 2004 16:47 schrieb Jeroen Frijters:

> @@ -872,7 +872,7 @@
>     */
>    public static synchronized void
> setContentHandlerFactory(ContentHandlerFactory factory)
>    {
> -    if (factory != null)
> +    if (URLConnection.factory != null)
>        throw new Error("ContentHandlerFactory already set");

Thx, but how did you find this ? By reading source or using some tool?


Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAdsFvWSOgCCdjSDsRAgV7AJ0ctFAlxVSYRIM3pxN+NOhuXjNc/QCfWgXp
mVHDnKiVBmIGCk+bX0Xsgk8=
=yFsJ
-----END PGP SIGNATURE-----




From MAILER-DAEMON Fri Apr 09 11:34:00 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BBy12-0002bB-7o
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 11:34:00 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BBy0X-0001tY-BJ
	for classpath@gnu.org; Fri, 09 Apr 2004 11:33:29 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BBxzx-00010S-B5
	for classpath@gnu.org; Fri, 09 Apr 2004 11:33:24 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BBxzO-0000Bs-Rk; Fri, 09 Apr 2004 11:32:18 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 9 Apr 2004 17:32:05 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD85@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: FYI: Patch: URLConnection
Thread-Index: AcQeRg9AyY5A85h+QiOT+mlHACnBVgAAaQhw
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Michael Koch" <konqueror@gmx.de>,
	"commit-classpath" <commit-classpath@gnu.org>
Cc: classpath@gnu.org
Subject: RE: FYI: Patch: URLConnection
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 15:33:58 -0000

Michael Koch wrote:
> Am Freitag, 9. April 2004 16:47 schrieb Jeroen Frijters:
>=20
> > @@ -872,7 +872,7 @@
> >     */
> >    public static synchronized void
> > setContentHandlerFactory(ContentHandlerFactory factory)
> >    {
> > -    if (factory !=3D null)
> > +    if (URLConnection.factory !=3D null)
> >        throw new Error("ContentHandlerFactory already set");
>=20
> Thx, but how did you find this ? By reading source or using some tool?

I was trying to start Eclipse 3.0M8 and it barfed on this. Of course,
after I fixed that it barfed on something else ;-)

Regards,
Jeroen



From MAILER-DAEMON Fri Apr 09 13:51:21 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BC09x-0003YF-69
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 13:51:21 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BC09u-0003Wt-0c
	for classpath@gnu.org; Fri, 09 Apr 2004 13:51:18 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BC09N-00031N-3J
	for classpath@gnu.org; Fri, 09 Apr 2004 13:51:16 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BC09M-0002WG-Qm
	for classpath@gnu.org; Fri, 09 Apr 2004 13:50:44 -0400
Received: from [213.51.128.198] (helo=smtpq3.home.nl)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BC05r-0007hs-G9
	for classpath@gnu.org; Fri, 09 Apr 2004 13:47:07 -0400
Received: from [213.51.128.135] (port=49994 helo=smtp4.home.nl)
	by smtpq3.home.nl with esmtp (Exim 4.30) id 1BC05l-0008QI-NS
	for classpath@gnu.org; Fri, 09 Apr 2004 19:47:01 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:32971
	helo=dumas.thomas.planescape.com)
	by smtp4.home.nl with esmtp (Exim 4.30) id 1BC05r-0002Tl-I0
	for classpath@gnu.org; Fri, 09 Apr 2004 19:47:07 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Fri, 9 Apr 2004 19:46:14 +0200
User-Agent: KMail/1.6.1
References: <40742D2A.7040206@aicas.com> <87y8p7v6cq.fsf@fleche.redhat.com>
	<4076A9E7.8080308@byu.net>
In-Reply-To: <4076A9E7.8080308@byu.net>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404091946.19161.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 17:51:18 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thats a hack; its dirty and its non-intuitive. I'd advice against that.

What about having a source formatter that checks this? A make check seems=20
like a good candidate to report warnings like these.

On Friday 09 April 2004 15:49, Eric Blake wrote:
> Tom Tromey wrote:
> > My only comment or criticism is that, in the absence of regular
> > checking for this, we'll just see more code like it checked in.
> > That's been the experience with non-C89 constructs, I don't see why
> > this would be any different.  It's just too hard to remember to write
> > in some language subset without compiler-assisted checking.
>
> To avoid regressions, would we want to use a common header file to
> #define the C++ keywords into something that will generate a
> compile-time error when compiling under C?  That is
>
> #define this do not use C++ keywords, JNI must compile in C and C++

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAduFpCojCW6H2z/QRAhmgAKCQQi2bMbb6WwOu47cRKlpKKRL9PwCgxG1I
1S/Pv3uNVguHiOY0yLBkzbM=3D
=3DiStU
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Fri Apr 09 14:31:01 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BC0mL-00055y-25
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 14:31:01 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BC0mD-00053t-AO
	for classpath@gnu.org; Fri, 09 Apr 2004 14:30:53 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BC0lf-0004qT-Qf
	for classpath@gnu.org; Fri, 09 Apr 2004 14:30:51 -0400
Received: from [129.34.20.6] (helo=igw2.watson.ibm.com)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BC0lf-0004qA-Bc; Fri, 09 Apr 2004 14:30:19 -0400
Received: from sp1n294en1.watson.ibm.com (sp1n294en1.watson.ibm.com
	[129.34.20.40])
	by igw2.watson.ibm.com (8.11.7-20030924/8.11.4) with ESMTP id
	i39IUAq84306; Fri, 9 Apr 2004 14:30:10 -0400
Received: from sp1n294en1.watson.ibm.com (localhost [127.0.0.1])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i39IU9O04510; Fri, 9 Apr 2004 14:30:09 -0400
Received: from watson.ibm.com (bilbo.watson.ibm.com [9.2.32.197])
	by sp1n294en1.watson.ibm.com (8.11.7-20030924/8.11.7/8.11.7-01-14-2004)
	with ESMTP id i39IU8x04508; Fri, 9 Apr 2004 14:30:08 -0400
Message-ID: <4076EBB0.4080705@watson.ibm.com>
Date: Fri, 09 Apr 2004 14:30:08 -0400
From: Steven Augart <augart@watson.ibm.com>
Organization: IBM Watson Research Ctr., Jikes RVM Project
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031007
X-Accept-Language: en-us, en, it
MIME-Version: 1.0
To: tromey@redhat.com
References: <40742D2A.7040206@aicas.com> <87y8p7v6cq.fsf@fleche.redhat.com>
In-Reply-To: <87y8p7v6cq.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 18:30:54 -0000

Tom Tromey wrote:
[...]
> A third option would be for you to periodically try it out and check
> in patches like the one you sent :-).  Assuming the other developers
> are ok with this, it wouldn't be unreasonable, just a bit messy.
This seems like the best way to handle the situation.

I have a minor readability nit to pick with the class=>clazz and 
this=>thiz : There are many places in English when "s" has the 
phonetic spelling of "z" (when it's "voiced"), but the words "this" 
and "class" aren't among those places.  So, if one is doing a straight 
substitution, I prefer class=>klass, where at least the phonetic 
spelling matches the mainstream pronounciation of the word.  I also 
like Stephen Compall's suggestion of maintaining the author's 
indentation by keeping the replacement text the same length, so his 
suggestion of this=>self seems to be the best choice to me.

-- 
Steven Augart

Jikes RVM, a free, open source, Virtual Machine:
http://oss.software.ibm.com/jikesrvm




From MAILER-DAEMON Fri Apr 09 17:57:11 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BC3zq-0000nQ-VI
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 17:57:10 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BC3zk-0000eZ-9h
	for classpath@gnu.org; Fri, 09 Apr 2004 17:57:04 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BC3xU-0007cb-B1
	for classpath@gnu.org; Fri, 09 Apr 2004 17:55:16 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BC3xM-0007Fk-Ca
	for classpath@gnu.org; Fri, 09 Apr 2004 17:54:37 -0400
Received: from [24.25.9.100] (helo=ms-smtp-01-eri0.southeast.rr.com)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BC3nk-0001rX-Ml
	for classpath@gnu.org; Fri, 09 Apr 2004 17:44:40 -0400
Received: from [10.0.0.2] (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-01-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	i39LiYSm025044; Fri, 9 Apr 2004 17:44:34 -0400 (EDT)
From: "C. Brian Jones" <cbj@gnu.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404082236.58046.konqueror@gmx.de>
References: <200404082236.58046.konqueror@gmx.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-SIE9n8taSg5vLdivIKiR"
Message-Id: <1081547073.3175.4.camel@lyta.haphazard.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Fri, 09 Apr 2004 17:44:34 -0400
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: classpath@gnu.org
Subject: Re: Support for installation of glibj.zip and separate class files
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: cbj@gnu.org
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 21:57:08 -0000


--=-SIE9n8taSg5vLdivIKiR
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Thu, 2004-04-08 at 16:36, Michael Koch wrote:
> Hi all,=20
>=20
>=20
>=20
> With my big NIO commit I accidently commited the first part (the parts=20
> in configure.ac) for this patch and so I decided to commit it fully.
> We now have two options for installing our classes
>=20
> --enable-glibj
> installs glibj.zip (enabled by default)
>=20
> --enable-class-install
> installs all classes as separate files as needed by jamvm and sablevm=20
> (disabled by default)
>=20
> Both options are indepedently from each other. You can even disable both=20
> options but this does not make really sense.
>=20
> I'm not really satisfied with the name "--enable-class-install". If=20
> someone finds a better name please shout at me.

Michael I thought this logic was already in lib/Makefile.am anyway
without the extra config option?  Maybe that was an old version I was
thinking about.

Brian

--=-SIE9n8taSg5vLdivIKiR
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQBAdxlBcEcmdY33uzYRAh5FAJ0WbP+0JJ4S/Y1CoBNaCptL1ZRaVgCdFtxn
JtyFAjhHWeMN2IhjVGEdhfg=
=pFRY
-----END PGP SIGNATURE-----

--=-SIE9n8taSg5vLdivIKiR--




From MAILER-DAEMON Fri Apr 09 18:54:39 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BC4tS-0006Tb-RY
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 18:54:38 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BC4tP-0006SQ-9h
	for classpath@gnu.org; Fri, 09 Apr 2004 18:54:35 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BC4ss-0006I7-SF
	for classpath@gnu.org; Fri, 09 Apr 2004 18:54:33 -0400
Received: from [64.164.98.52] (helo=mtaw4.prodigy.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BC4sr-0006Hs-QH
	for classpath@gnu.org; Fri, 09 Apr 2004 18:54:01 -0400
Received: from bothner.com (ppp-68-120-205-59.dialup.pltn13.pacbell.net
	[68.120.205.59] (may be forged))
	by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i39Mrw1O023907;
	Fri, 9 Apr 2004 15:53:59 -0700 (PDT)
Message-ID: <40772986.5070003@bothner.com>
Date: Fri, 09 Apr 2004 15:53:58 -0700
From: Per Bothner <per@bothner.com>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD30@LEMBU.sumatrasoftware.com>
	<40740DFF.50108@bothner.com> <407443C9.3060808@uqam.ca>
In-Reply-To: <407443C9.3060808@uqam.ca>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: GNU Classpath <classpath@gnu.org>, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: Classpath build process and VM-specific issues
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Apr 2004 22:54:36 -0000

Etienne Gagnon wrote:

> I am starting to have difficulty understanding Classpath's goals and 
> motivations.
> 
> When I proposed to add to Classpath some mechanism to allow it to be 
> customized to each VM, I was told that it would be a heresy to encode 
> any VM-specific thing into Classpath, as the vision was: a single 
> Classpath installation would be shared by many VMs on a single system, 
> e.g. common class libraries, common JNI libraries, etc.
> 
> Now, what you are proposing is that JNI libraries would be compiled 
> specifically for each VM.  What have I missed?

That I do not speak for Classpath, and that different people have
different goals and opinions.

Personally, I don't see much point in "common class libraries, common
JNI libraries".  It might be neat, but:
(a) it complicates getting good performance, and
(b) coordinating Classpath and VM releses would be too difficult.

Yes, it's more elegant to install a single copy of Classpath, but
GCJ is not going to use the "system installation" of Classpath, and
I wouldn't expect others to do so either.
-- 
	--Per Bothner
per@bothner.com   http://per.bothner.com/



From MAILER-DAEMON Fri Apr 09 20:16:42 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BC6As-0008EJ-6o
	for mharc-classpath@gnu.org; Fri, 09 Apr 2004 20:16:42 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BC6Ap-0008DB-M3
	for classpath@gnu.org; Fri, 09 Apr 2004 20:16:39 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BC6AJ-00088L-Op
	for classpath@gnu.org; Fri, 09 Apr 2004 20:16:38 -0400
Received: from [64.4.37.90] (helo=hotmail.com)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BC69T-00060x-Ua; Fri, 09 Apr 2004 20:15:16 -0400
Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC;
	Fri, 9 Apr 2004 17:14:14 -0700
Received: from 80.177.127.218 by by10fd.bay10.hotmail.msn.com with HTTP;
	Sat, 10 Apr 2004 00:14:13 GMT
X-Originating-IP: [80.177.127.218]
X-Originating-Email: [robert_lougher@hotmail.com]
X-Sender: robert_lougher@hotmail.com
From: "Robert Lougher" <robert_lougher@hotmail.com>
To: cbj@gnu.org, konqueror@gmx.de
Bcc: 
Date: Sat, 10 Apr 2004 00:14:13 +0000
Mime-Version: 1.0
Content-Type: text/plain; format=flowed
Message-ID: <BAY10-F90hHbuUULsUD000410ea@hotmail.com>
X-OriginalArrivalTime: 10 Apr 2004 00:14:14.0329 (UTC)
	FILETIME=[C1794290:01C41E90]
Cc: classpath@gnu.org
Subject: Re: Support for installation of glibj.zip and separate class files
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 00:16:40 -0000

Brian,

I think you're thinking of --without-zip?  This option still exists, but it 
hasn't seemed to work since classpath 0.05...

Rob.

----Original Message Follows----
From: "C. Brian Jones" <cbj@gnu.org>
Reply-To: cbj@gnu.org
To: Michael Koch <konqueror@gmx.de>
CC: classpath@gnu.org
Subject: Re: Support for installation of glibj.zip and separate class files
Date: Fri, 09 Apr 2004 17:44:34 -0400

On Thu, 2004-04-08 at 16:36, Michael Koch wrote:
 > Hi all,
 >
 >
 >
 > With my big NIO commit I accidently commited the first part (the parts
 > in configure.ac) for this patch and so I decided to commit it fully.
 > We now have two options for installing our classes
 >
 > --enable-glibj
 > installs glibj.zip (enabled by default)
 >
 > --enable-class-install
 > installs all classes as separate files as needed by jamvm and sablevm
 > (disabled by default)
 >
 > Both options are indepedently from each other. You can even disable both
 > options but this does not make really sense.
 >
 > I'm not really satisfied with the name "--enable-class-install". If
 > someone finds a better name please shout at me.

Michael I thought this logic was already in lib/Makefile.am anyway
without the extra config option?  Maybe that was an old version I was
thinking about.

Brian
<< signature.asc >>
_______________________________________________
Classpath mailing list
Classpath@gnu.org
http://mail.gnu.org/mailman/listinfo/classpath

_________________________________________________________________
Find a cheaper internet access deal - choose one to suit you. 
http://www.msn.co.uk/internetaccess




From MAILER-DAEMON Sat Apr 10 04:25:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCDoH-0000lQ-Uw
	for mharc-classpath@gnu.org; Sat, 10 Apr 2004 04:25:53 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCDo5-0000Wh-4P
	for classpath@gnu.org; Sat, 10 Apr 2004 04:25:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCDnT-0008AC-Pw
	for classpath@gnu.org; Sat, 10 Apr 2004 04:25:35 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BCDmx-0007gX-Ni; Sat, 10 Apr 2004 04:24:31 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-116.ewetel.net
	[80.228.94.116])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i3A8OTpH006638;
	Sat, 10 Apr 2004 10:24:30 +0200 (MEST)
Received: from asterix.konqueror.de ([192.168.1.3])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BCCr7-0000PL-00; Sat, 10 Apr 2004 09:24:45 +0200
From: Michael Koch <konqueror@gmx.de>
To: cbj@gnu.org
Date: Sat, 10 Apr 2004 10:35:02 +0200
User-Agent: KMail/1.5.4
References: <200404082236.58046.konqueror@gmx.de>
	<1081547073.3175.4.camel@lyta.haphazard.org>
In-Reply-To: <1081547073.3175.4.camel@lyta.haphazard.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Description: clearsigned data
Content-Disposition: inline
Message-Id: <200404101035.06456.konqueror@gmx.de>
X-CheckCompat: OK
Cc: classpath@gnu.org
Subject: Re: Support for installation of glibj.zip and separate class files
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 08:25:51 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Freitag, 9. April 2004 23:44 schrieb C. Brian Jones:
> On Thu, 2004-04-08 at 16:36, Michael Koch wrote:
> > Hi all,
> >
> >
> >
> > With my big NIO commit I accidently commited the first part (the
> > parts in configure.ac) for this patch and so I decided to commit
> > it fully. We now have two options for installing our classes
> >
> > --enable-glibj
> > installs glibj.zip (enabled by default)
> >
> > --enable-class-install
> > installs all classes as separate files as needed by jamvm and
> > sablevm (disabled by default)
> >
> > Both options are indepedently from each other. You can even
> > disable both options but this does not make really sense.
> >
> > I'm not really satisfied with the name "--enable-class-install".
> > If someone finds a better name please shout at me.
>
> Michael I thought this logic was already in lib/Makefile.am anyway
> without the extra config option?  Maybe that was an old version I
> was thinking about.

Yeah, and it was never really working when I tried it. Its=20
implementation in lib/Makefile.am was very weird. So I decided to=20
make it more easy to understand and maintain


Michael
=2D --=20
Homepage: http://www.worldforge.org/
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAd7G6WSOgCCdjSDsRAvRuAJ4wTMuIDxAPNoqRdnFBYijl1H5glwCgm+pE
lmDNN5vYkJVd7RDfa2uxK1E=3D
=3DhsUa
=2D----END PGP SIGNATURE-----




From MAILER-DAEMON Sat Apr 10 08:46:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCHsE-00074T-O2
	for mharc-classpath@gnu.org; Sat, 10 Apr 2004 08:46:14 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCHrG-0006RC-QF
	for classpath@gnu.org; Sat, 10 Apr 2004 08:45:14 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCHqZ-00060m-2G
	for classpath@gnu.org; Sat, 10 Apr 2004 08:45:02 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BCHop-0004u2-H5
	for classpath@gnu.org; Sat, 10 Apr 2004 08:42:43 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BCHmc-0003dY-UE
	for classpath@gnu.org; Sat, 10 Apr 2004 08:40:27 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BCHmT-00053I-00; Sat, 10 Apr 2004 14:40:17 +0200
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404082236.58046.konqueror@gmx.de>
References: <200404082236.58046.konqueror@gmx.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-PmtuIWNg/hAE9qZmka93"
Message-Id: <1081600819.13170.305.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 10 Apr 2004 14:40:20 +0200
Cc: classpath@gnu.org
Subject: Re: Support for installation of glibj.zip and separate class files
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 12:46:13 -0000


--=-PmtuIWNg/hAE9qZmka93
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Michael,

On Thu, 2004-04-08 at 22:36, Michael Koch wrote:
> With my big NIO commit I accidently commited the first part (the parts=20
> in configure.ac) for this patch and so I decided to commit it fully.

Could you post the exact patch you committed?
java source files aren't compiled any more and/or glibj isn't created
correctly on my system and I am trying figure out what changed.

The only ChangeLog entry I see is:

2004-04-08  Michael Koch  <konqueror@gmx.de>

        * ChangeLog, acinclude.m4, lib/Makefile.am:
        Added support for building and installing glibj.zip and separate
        class files.

Which doesn't describe at all what changes were actually made.

Thanks,

Mark

--=-PmtuIWNg/hAE9qZmka93
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAd+syxVhZCJWr9QwRAsXzAKCAF3o2RyIjx2ObMKGegSGqEE9RoQCfb1Va
DhyYWDoP8gFg17ul10Y70zg=
=GbqA
-----END PGP SIGNATURE-----

--=-PmtuIWNg/hAE9qZmka93--




From MAILER-DAEMON Sat Apr 10 09:47:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCIpn-0002e9-Vv
	for mharc-classpath@gnu.org; Sat, 10 Apr 2004 09:47:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCIpk-0002dC-Vr
	for classpath@gnu.org; Sat, 10 Apr 2004 09:47:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCIpC-0001mQ-Gd
	for classpath@gnu.org; Sat, 10 Apr 2004 09:47:44 -0400
Received: from [213.51.128.197] (helo=smtpq2.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCIp5-0001kk-Ia
	for classpath@gnu.org; Sat, 10 Apr 2004 09:47:03 -0400
Received: from [213.51.128.133] (port=50728 helo=smtp2.home.nl)
	by smtpq2.home.nl with esmtp (Exim 4.30) id 1BCIp5-0008VX-2Z
	for classpath@gnu.org; Sat, 10 Apr 2004 15:47:03 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:33605
	helo=dumas.thomas.planescape.com)
	by smtp2.home.nl with esmtp (Exim 4.30) id 1BCIp3-0002lX-TL
	for classpath@gnu.org; Sat, 10 Apr 2004 15:47:02 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Sat, 10 Apr 2004 15:46:20 +0200
User-Agent: KMail/1.6.1
References: <200404082236.58046.konqueror@gmx.de>
	<1081600819.13170.305.camel@elsschot.wildebeest.org>
In-Reply-To: <1081600819.13170.305.camel@elsschot.wildebeest.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404101546.20901.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: Re: Support for installation of glibj.zip and separate class files
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 13:47:45 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

CVS is your friend; just type a cvs diff..
something like:
cvs diff -D "08 apr 2004" -D "09 apr 2004" | less
in the root.

On Saturday 10 April 2004 14:40, Mark Wielaard wrote:
> Hi Michael,
>
> On Thu, 2004-04-08 at 22:36, Michael Koch wrote:
> > With my big NIO commit I accidently commited the first part (the parts
> > in configure.ac) for this patch and so I decided to commit it fully.
>
> Could you post the exact patch you committed?
> java source files aren't compiled any more and/or glibj isn't created
> correctly on my system and I am trying figure out what changed.
>
> The only ChangeLog entry I see is:
>
> 2004-04-08  Michael Koch  <konqueror@gmx.de>
>
>         * ChangeLog, acinclude.m4, lib/Makefile.am:
>         Added support for building and installing glibj.zip and separate
>         class files.
>
> Which doesn't describe at all what changes were actually made.
>
> Thanks,
>
> Mark

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAd/qsCojCW6H2z/QRAqXUAJ9ohapE79h2u4eE5Wq+mUtjQvV0vQCdHtJz
qO+0N3k4ltd0Wv00IJR66cU=3D
=3D8f3H
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Sat Apr 10 11:19:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCKGt-0005J8-Bh
	for mharc-classpath@gnu.org; Sat, 10 Apr 2004 11:19:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCKGq-0005HT-5j
	for classpath@gnu.org; Sat, 10 Apr 2004 11:19:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCKGS-0004wA-Hr
	for classpath@gnu.org; Sat, 10 Apr 2004 11:19:47 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BCKGS-0004uY-C6
	for classpath@gnu.org; Sat, 10 Apr 2004 11:19:24 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BCKG0-0000dj-UY
	for classpath@gnu.org; Sat, 10 Apr 2004 11:18:57 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BCKFq-0005SO-00; Sat, 10 Apr 2004 17:18:46 +0200
From: Mark Wielaard <mark@klomp.org>
To: Thomas Zander <zander@javalobby.org>
In-Reply-To: <200404101546.20901.zander@javalobby.org>
References: <200404082236.58046.konqueror@gmx.de>
	<1081600819.13170.305.camel@elsschot.wildebeest.org>
	<200404101546.20901.zander@javalobby.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-MawMOvoSd5OmFZ/5uLoy"
Message-Id: <1081610327.13170.319.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 10 Apr 2004 17:18:48 +0200
Cc: classpath@gnu.org
Subject: Re: Support for installation of glibj.zip and separate class files
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 15:19:49 -0000


--=-MawMOvoSd5OmFZ/5uLoy
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-04-10 at 15:46, Thomas Zander wrote:
> CVS is your friend; just type a cvs diff..
> something like:
> cvs diff -D "08 apr 2004" -D "09 apr 2004" | less
> in the root.

Yes, but then I only see what changed, not what Michael intended to
change. That is why patches should be send to the mailinglist before
committing. The patch was munged in with another nio changes in the CVS
commit.

Anyway, I talked to Michael on irc. He is working on a fix. In the
meantime you have to explicitly give --enable-glibj and/or
--enable-class-install to your configure command.

You also need to revert Jeroen his patch to FileChannelImpl.java when
you need the native JNI implementation to work again.

Cheers,

Mark

--=-MawMOvoSd5OmFZ/5uLoy
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAeBBWxVhZCJWr9QwRAuAVAJ9MYE/i/Nul8xESQ38Ns13xlxr0DgCfQcI6
BwFyP2WIihscx9SPejQPhVk=
=kgdN
-----END PGP SIGNATURE-----

--=-MawMOvoSd5OmFZ/5uLoy--




From MAILER-DAEMON Sat Apr 10 13:22:17 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCLyl-0003A5-Pp
	for mharc-classpath@gnu.org; Sat, 10 Apr 2004 13:09:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCLyb-000378-Ta
	for classpath@gnu.org; Sat, 10 Apr 2004 13:09:05 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCLYR-0003aY-0L
	for classpath@gnu.org; Sat, 10 Apr 2004 12:42:34 -0400
Received: from [213.228.0.169] (helo=postfix3-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCLOG-00079k-3n
	for classpath@gnu.org; Sat, 10 Apr 2004 12:31:32 -0400
Received: from free.fr (cachan-3-82-66-125-112.fbx.proxad.net [82.66.125.112])
	by postfix3-2.free.fr (Postfix) with ESMTP
	id F2FCBC0A1; Sat, 10 Apr 2004 18:30:41 +0200 (CEST)
Message-ID: <40782130.2030409@free.fr>
Date: Sat, 10 Apr 2004 18:30:40 +0200
From: Guilhem Lavaux <guilhem.lavaux@free.fr>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Guilhem Lavaux <guilhem@kaffe.org>
References: <4069A55D.9060102@kaffe.org>
In-Reply-To: <4069A55D.9060102@kaffe.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Tom Tromey <tromey@redhat.com>, Classpath List <classpath@gnu.org>
Subject: Re: Comparison ICU/java.text
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 17:09:13 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi again !

I must add that I've found it may support full locales: ICU includes a
locale converter: Java to ICU and POSIX to ICU.

Tom, have you received any answer from IBM ?

Cheers,
Guilhem.

Guilhem Lavaux wrote:
|
| To the request of Tom Tromey I have made a small comparison between ICU
| text and java.text. As it is MIT licenced and has a strong
| implementation it would have been great to be able to import classes
| though I don't really like to have some pure IBM code around. So here is
| a list of the features and differences:
|
| * classes which has the same name: BreakIterator,
| CollationElementIterator, RuleBasedCollator, Collator,
| CollationKey, DateFormat, DateFormatSymbols,
| DecimalFormat, DecimalFormatSymbols, NumberFormat,
| SimpleDateFormat, StringCharacterIterator.
|
| * classes unavailable in ICU: Annotation,
| AttributedCharacterIterator, AttributedString, Bidi,
| ChoiceFormat, FieldPosition, MessageFormat,
| MessageFormat.Field, NumberFormat.Field,
| ParsePosition, ParseException.
|
| Concerning shared classes:
|
| * BreakIterator: all methods implemented.
| * CollationElementIterator: all methods implemented.
| * RuleBasedCollator: rules slightly different (possibility of putting
| '&' in front of rules). Besides that all methods implemented.
| * Collator: FULL_DECOMPOSITION is missing. All methods implemented.
| * CollationKey: constructors are public unlike JDK's. All methods
| implemented.
| * DateFormat: no Field subclass. All methods implemented.
| * DateFormatSymbols: All methods implemented.
| * DecimalFormat: formatToCharacterIterator, getCurrency are missing.
| * DecimalFormatSymbols: get/setCurrency are missing.
| * NumberFormat: Field is missing.
| * SimpleDateFormat: format prototype is different (Date for JDK,
| Calendar for ICU). formatToCharacterIterator is missing. parse is
| different.
| * StringCharacterIterator is deprecated in ICU.
|
| Other interesting features of ICU:
| * More calendars: Gregorian, Hebrew, Islamic, Japanese, BuddhistCalendar.
| * Calendar: all methods implemented.
|

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAeCEvWRk4qbNiTwgRAnRQAJ91tghsgPLozR9GtXRf0C9FlncDvwCfatN2
/NgGI0OXxzqybG23Jy8UBOk=
=MZhr
-----END PGP SIGNATURE-----




From MAILER-DAEMON Sat Apr 10 13:42:43 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCMV8-0003UM-Kr
	for mharc-classpath@gnu.org; Sat, 10 Apr 2004 13:42:42 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCMV5-0003TX-44
	for classpath@gnu.org; Sat, 10 Apr 2004 13:42:39 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCMUZ-0003Or-Cq
	for classpath@gnu.org; Sat, 10 Apr 2004 13:42:38 -0400
Received: from [213.228.0.169] (helo=postfix3-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCMUY-0003OZ-FX
	for classpath@gnu.org; Sat, 10 Apr 2004 13:42:06 -0400
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix3-2.free.fr (Postfix) with ESMTP id 47166C171
	for <classpath@gnu.org>; Sat, 10 Apr 2004 19:42:05 +0200 (CEST)
Message-ID: <407831EA.2020508@kaffe.org>
Date: Sat, 10 Apr 2004 19:42:02 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig2E49171D15CCBA52250296F5"
Subject: java.text attributes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 17:42:39 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig2E49171D15CCBA52250296F5
Content-Type: multipart/mixed; boundary="------------000503070105070501070901"

This is a multi-part message in MIME format.
--------------000503070105070501070901
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here are some new classes which will be used in an upcoming patch for 
java.text to support attributes. These files consists as an interface 
and two implementations for it. If we want to build attributed iterators 
we will use one implementation and if not we will use the other (much 
faster).

By the way, I am moving FormatCharacterIterator.java to gnu.java.text.

I know there may be some code redundancy between FormatCharacterIterator 
and FormatBuffers but it seems cleanest to me that way for the rest of 
java.text classes.

ChangeLog entry:

2004-04-10  Guilhem Lavaux <guilhem@kaffe.org>

	* gnu/java/text/FormatBuffer.java,
	gnu/java/text/AttributedFormatBuffer.java,
	gnu/java/text/StringFormatBuffer.java: New classes to implement
	attributed iterators in java.text.

	* gnu/java/text/FormatCharacterIterator.java: Moved from
	java/text.

Cheers,
Guilhem.

--------------000503070105070501070901
Content-Type: text/plain;
 name="AttributedFormatBuffer.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="AttributedFormatBuffer.java"

/* AttributedFormatBuffer.java -- Implements an attributed FormatBuffer.
   Copyright (C) 2004 Free Software Foundation, Inc.

This file is part of GNU Classpath.

GNU Classpath is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2, or (at your option)
any later version.
 
GNU Classpath is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with GNU Classpath; see the file COPYING.  If not, write to the
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA.

Linking this library statically or dynamically with other modules is
making a combined work based on this library.  Thus, the terms and
conditions of the GNU General Public License cover the whole
combination.

As a special exception, the copyright holders of this library give you
permission to link this library with independent modules to produce an
executable, regardless of the license terms of these independent
modules, and to copy and distribute the resulting executable under
terms of your choice, provided that you also meet, for each linked
independent module, the terms and conditions of the license of that
module.  An independent module is a module which is not derived from
or based on this library.  If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so.  If you do not wish to do so, delete this
exception statement from your version. */
package gnu.java.text;

import java.text.AttributedCharacterIterator;
import java.util.ArrayList;
import java.util.HashMap;

/**
 * This class is an implementation of a FormatBuffer with attributes.
 * 
 * @author Guilhem Lavaux <guilhem@kaffe.org>
 * @date April 10, 2004
 */
public class AttributedFormatBuffer implements FormatBuffer
{
  private StringBuffer buffer;
  private ArrayList ranges;
  private ArrayList attributes;
  private int[] a_ranges;
  private HashMap[] a_attributes; 
  private int startingRange;
  AttributedCharacterIterator.Attribute defaultAttr;

  /**
   * This constructor accepts a StringBuffer. If the buffer contains
   * already some characters they will not be attributed. 
   */
  public AttributedFormatBuffer(StringBuffer buffer)
  {
    this.buffer = buffer;
    this.ranges = new ArrayList();
    this.attributes = new ArrayList();
    this.defaultAttr = null;
    if (buffer.length() != 0)
      {
	this.startingRange = buffer.length();
	addAttribute(buffer.length(), null);
      }
    else
      this.startingRange = -1;
  }

  public AttributedFormatBuffer(int prebuffer)
  {
    this(new StringBuffer(prebuffer));
  }

  public AttributedFormatBuffer()
  {
    this(10);
  }

  /**
   * This method is a helper function for formatters. Given a set of ranges
   * and attributes it adds exactly one attribute for the range of characters
   * comprised between the last entry in 'ranges' and the specified new range.
   *
   * @param new_range A new range to insert in the list.
   * @param new_attribute A new attribute to insert in the list.
   */  
  private final void addAttribute(int new_range, AttributedCharacterIterator.Attribute attr)
  {
    HashMap map;

    if (attr != null)
      {
	map = new HashMap();
	map.put(attr, attr);
	attributes.add(map);
      }
    else
      attributes.add(null);

    ranges.add(new Integer(new_range));
  }

  public void append(String s)
  {
    if (startingRange < 0)
      startingRange = 0;
    buffer.append(s);
  }
  
  public void append(String s, AttributedCharacterIterator.Attribute attr)
  {
    setDefaultAttribute(attr);
    startingRange = buffer.length();
    append(s);
    setDefaultAttribute(null);
  }

  public void append(String s, int[] ranges, HashMap[] attrs)
  {
    int curPos = buffer.length();

    setDefaultAttribute(null);
    if (ranges != null)
      {
	for (int i = 0; i < ranges.length; i++)
	  {	    
	    this.ranges.add(new Integer(ranges[i] + curPos));
	    this.attributes.add(attrs[i]);
	  }
      }
    startingRange = buffer.length();
    buffer.append(s);
  }

  public void append(char c)
  {
    if (startingRange < 0)
      startingRange = buffer.length();
    buffer.append(c);
  }

  public void append(char c, AttributedCharacterIterator.Attribute attr)
  {
    setDefaultAttribute(attr);
    buffer.append(c);
    setDefaultAttribute(null);
  }

  public void setDefaultAttribute(AttributedCharacterIterator.Attribute attr)
  {
    if (attr == defaultAttr)
      return;

    int currentPos = buffer.length();

    if (startingRange != currentPos && startingRange >= 0)
      {
	addAttribute(currentPos, defaultAttr);
      }
    defaultAttr = attr;
    startingRange = currentPos;
  }

  public AttributedCharacterIterator.Attribute getDefaultAttribute()
  {
    return defaultAttr;
  }

  public void cutTail(int length)
  {
    buffer.setLength(buffer.length()-length);
  }

  public int length()
  {
    return buffer.length();
  }

  public void clear()
  {
    buffer.setLength(0);
    ranges.clear();
    attributes.clear();
    defaultAttr = null;
    startingRange = -1;
  }

  /**
   * This method synchronizes the state of the attribute array.
   * After calling it you may call {@link #getDefaultAttribute()}.
   */
  public void sync()
  {
    if (startingRange < 0 || startingRange == buffer.length())
      return;

    addAttribute(buffer.length(), defaultAttr);

    a_ranges = new int[ranges.size()];
    for (int i = 0; i < a_ranges.length; i++)
      a_ranges[i] = ((Integer)(ranges.get (i))).intValue();
    
    a_attributes = new HashMap[attributes.size()];
    System.arraycopy(attributes.toArray(), 0, a_attributes, 0, a_attributes.length);
  }

  /**
   * This method returns the internal StringBuffer describing
   * the attributed string.
   *
   * @return An instance of StringBuffer which contains the string.
   */
  public StringBuffer getBuffer()
  {
    return buffer;
  }

  /**
   * This method returns the ranges for the attributes.
   *
   * @return An array of int describing the ranges.
   */
  public int[] getRanges()
  {
    return a_ranges;
  }

  /**
   * This method returns the array containing the map on the 
   * attributes.
   *
   * @return An array of {@link java.util.Map} containing the attributes.
   */
  public HashMap[] getAttributes()
  {
    return a_attributes;
  }
}

--------------000503070105070501070901
Content-Type: text/plain;
 name="FormatBuffer.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="FormatBuffer.java"

/* FormatBuffer.java -- General interface to build attributed strings.
   Copyright (C) 2004 Free Software Foundation, Inc.

This file is part of GNU Classpath.

GNU Classpath is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2, or (at your option)
any later version.
 
GNU Classpath is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with GNU Classpath; see the file COPYING.  If not, write to the
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA.

Linking this library statically or dynamically with other modules is
making a combined work based on this library.  Thus, the terms and
conditions of the GNU General Public License cover the whole
combination.

As a special exception, the copyright holders of this library give you
permission to link this library with independent modules to produce an
executable, regardless of the license terms of these independent
modules, and to copy and distribute the resulting executable under
terms of your choice, provided that you also meet, for each linked
independent module, the terms and conditions of the license of that
module.  An independent module is a module which is not derived from
or based on this library.  If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so.  If you do not wish to do so, delete this
exception statement from your version. */
package gnu.java.text;

import java.text.AttributedCharacterIterator;
import java.util.HashMap;

/**
 * This interface describes a modifiable buffer which contains attributed
 * characters. The implementation may or may not implements attributes. It
 * aims to greatly simplify and clarify the implementation of java.text 
 * formatters. The buffer may be appended or have its tail cut. It may also
 * be completely cleant up.
 *
 * @author Guilhem Lavaux <guilhem@kaffe.org>
 * @date April 10, 2004
 */
public interface FormatBuffer 
{
  /**
   * This method appends a simple string to the buffer. This part of
   * the buffer will be attributed using the default attribute.
   *
   * @param s The string to append to the buffer.
   */
  public void append(String s);

  /**
   * This method appends a simple string to the buffer. This part of
   * the buffer will have the specified attribute (and only this one).
   * The default attribute may be changed after calling this method.
   *
   * @param s The string to append to the buffer.
   * @param attr Attribute to use for the string in the buffer.
   */
  public void append(String s, AttributedCharacterIterator.Attribute attr);

  /**
   * This method appends a simple string to the buffer. This part of
   * the buffer will be attributed using the specified ranges and attributes.
   * To have an example on how to specify ranges see {@link gnu.java.text.FormatCharacterIterator}. 
   * 
   * @param s The string to append to the buffer.
   * @param ranges The ranges describing how the attributes should be applied
   * to the string.
   * @param attrs The attributes of the string in the buffer.
   */
  public void append(String s, int[] ranges, HashMap[] attrs);

  /**
   * This method appends a simple char to the buffer. This part of
   * the buffer will be attributed using the default attribute.
   *
   * @param c The character to append to the buffer.
   */
  public void append(char c);

  /**
   * This method appends a simple character to the buffer. This part of
   * the buffer will have the specified attribute (and only this one).
   * The default attribute may be changed after calling this method.
   *
   * @param c The character to append to the buffer.
   * @param attr Attribute to use for the character in the buffer.
   */
  public void append(char c, AttributedCharacterIterator.Attribute attr);

  /**
   * This method changes the current default attribute for the next string
   * or character which will be appended to the buffer.
   *
   * @param attr The attribute which will be used by default.
   */
  public void setDefaultAttribute(AttributedCharacterIterator.Attribute attr);

  /**
   * This method returns the current default attribute for the buffer.
   *
   * @return The default attribute for the buffer.
   */
  public AttributedCharacterIterator.Attribute getDefaultAttribute();

  /**
   * This method cuts the last characters of the buffer. The number of
   * characters to cut is given by "length".
   *
   * @param length Number of characters to cut at the end of the buffer.
   */
  public void cutTail(int length);
  
  /**
   * This method resets completely the buffer.
   */
  public void clear();

  /**
   * This method returns the number of character in the buffer.
   *
   * @return The number of character in the buffer.
   */
  public int length();
}

--------------000503070105070501070901
Content-Type: text/plain;
 name="StringFormatBuffer.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="StringFormatBuffer.java"

/* StringFormatBuffer.java -- Implements FormatBuffer using StringBuffer.
   Copyright (C) 2004 Free Software Foundation, Inc.

This file is part of GNU Classpath.

GNU Classpath is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2, or (at your option)
any later version.
 
GNU Classpath is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with GNU Classpath; see the file COPYING.  If not, write to the
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA.

Linking this library statically or dynamically with other modules is
making a combined work based on this library.  Thus, the terms and
conditions of the GNU General Public License cover the whole
combination.

As a special exception, the copyright holders of this library give you
permission to link this library with independent modules to produce an
executable, regardless of the license terms of these independent
modules, and to copy and distribute the resulting executable under
terms of your choice, provided that you also meet, for each linked
independent module, the terms and conditions of the license of that
module.  An independent module is a module which is not derived from
or based on this library.  If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so.  If you do not wish to do so, delete this
exception statement from your version. */
package gnu.java.text;

import java.text.AttributedCharacterIterator;
import java.util.HashMap;

/**
 * This class is an implementation of a FormatBuffer without attributes.
 * 
 * @author Guilhem Lavaux <guilhem@kaffe.org>
 * @date April 10, 2004
 */
public class StringFormatBuffer implements FormatBuffer
{
  private StringBuffer buffer;
  private AttributedCharacterIterator.Attribute defaultAttr;

  public StringFormatBuffer(int prebuffer)
  {
    buffer = new StringBuffer(prebuffer);
  }

  public StringFormatBuffer(StringBuffer buffer)
  {
    this.buffer = buffer;
  }

  public void append(String s)
  {
    buffer.append(s);
  }
  
  public void append(String s, AttributedCharacterIterator.Attribute attr)
  {
    buffer.append(s);
  }

  public void append(String s, int[] ranges, HashMap[] attrs)
  {
    buffer.append(s);
  }

  public void append(char c)
  {
    buffer.append(c);
  }

  public void append(char c, AttributedCharacterIterator.Attribute attr)
  {
    buffer.append(c);
  }

  public void setDefaultAttribute(AttributedCharacterIterator.Attribute attr)
  {
    defaultAttr = attr;
  }

  public AttributedCharacterIterator.Attribute getDefaultAttribute()
  {
    return defaultAttr;
  }

  public void cutTail(int length)
  {
    buffer.setLength(buffer.length()-length);
  }

  public int length()
  {
    return buffer.length();
  }

  public void clear()
  {
    buffer.setLength(0);
  }

  /**
   * This method returns the internal {@link java.lang.StringBuffer} which 
   * contains the string of character.
   */
  public StringBuffer getBuffer()
  {
    return buffer;
  }
}

--------------000503070105070501070901--

--------------enig2E49171D15CCBA52250296F5
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAeDHsWRk4qbNiTwgRAjNhAJkBOcl08iWj8G3xFV2WTJWvhM5pLQCeMqrs
AeCJgN3zmVNs/HKWejeCtXc=
=JfoP
-----END PGP SIGNATURE-----

--------------enig2E49171D15CCBA52250296F5--




From MAILER-DAEMON Sat Apr 10 14:16:36 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCN1w-0003e3-B8
	for mharc-classpath@gnu.org; Sat, 10 Apr 2004 14:16:36 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCN1k-0003JT-Cj
	for classpath@gnu.org; Sat, 10 Apr 2004 14:16:24 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCN0v-0002Lh-NT
	for classpath@gnu.org; Sat, 10 Apr 2004 14:16:05 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCN0v-0002LM-5q
	for classpath@gnu.org; Sat, 10 Apr 2004 14:15:33 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-116.ewetel.net
	[80.228.94.116])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i3AIEvpH020771;
	Sat, 10 Apr 2004 20:14:59 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BCM4X-0008Qi-00; Sat, 10 Apr 2004 19:15:13 +0200
From: Michael Koch <konqueror@gmx.de>
To: Guilhem Lavaux <guilhem@kaffe.org>, Classpath List <classpath@gnu.org>
Date: Sat, 10 Apr 2004 20:14:44 +0200
User-Agent: KMail/1.5.4
References: <407831EA.2020508@kaffe.org>
In-Reply-To: <407831EA.2020508@kaffe.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404102014.45174.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: java.text attributes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 18:16:32 -0000

Am Samstag, 10. April 2004 19:42 schrieb Guilhem Lavaux:
> Hi,
>
> Here are some new classes which will be used in an upcoming patch for
> java.text to support attributes. These files consists as an interface
> and two implementations for it. If we want to build attributed
> iterators we will use one implementation and if not we will use the
> other (much faster).
>
> By the way, I am moving FormatCharacterIterator.java to
> gnu.java.text.
>
> I know there may be some code redundancy between
> FormatCharacterIterator and FormatBuffers but it seems cleanest to me
> that way for the rest of java.text classes.
>
> ChangeLog entry:
>
> 2004-04-10  Guilhem Lavaux <guilhem@kaffe.org>
>
> 	* gnu/java/text/FormatBuffer.java,
> 	gnu/java/text/AttributedFormatBuffer.java,
> 	gnu/java/text/StringFormatBuffer.java: New classes to implement
> 	attributed iterators in java.text.
>
> 	* gnu/java/text/FormatCharacterIterator.java: Moved from
> 	java/text.

Sorry Guilhem, but I cant find the parts where you fix the 
Makefile.ams ;-)


Michael




From MAILER-DAEMON Sat Apr 10 18:16:35 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCQjI-0004OA-5b
	for mharc-classpath@gnu.org; Sat, 10 Apr 2004 18:13:36 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCQiw-0004MB-94
	for classpath@gnu.org; Sat, 10 Apr 2004 18:13:14 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCQhc-0002Ab-Bz
	for classpath@gnu.org; Sat, 10 Apr 2004 18:12:24 -0400
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCQha-00022f-H7
	for classpath@gnu.org; Sat, 10 Apr 2004 18:11:50 -0400
Received: (qmail 8169 invoked by uid 504); 11 Apr 2004 00:11:47 +0200
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 0.725046 secs); 10 Apr 2004 22:11:47 -0000
Received: from unknown (HELO oz.fapse.ulg.ac.be) ([139.165.201.24])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 11 Apr 2004 00:11:46 +0200
Received: from arnaud by oz.fapse.ulg.ac.be with local (Exim 4.31)
	id 1BCQhV-0000ZM-EJ
	for classpath@gnu.org; Sun, 11 Apr 2004 00:11:45 +0200
To: GNU Classpath <classpath@gnu.org>
References: <16499.60484.672951.758578@cuddles.cambridge.redhat.com>
	<20040407130724.GK15152@tangency.co.uk>
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
X-Face: >U]gI'=hKRtZE@~Svh"mU,aS"">yCT*dBkVAFl'!]!&k@R8fEr{-)Ql6{xhuXKb+!>}x;
	^2ck7Ytr'EABxt~)3q?AO}$:wwSva.$uNN9x.w4+uVmMMSB1~EbJgo|9E0yQXONuM'~c*20^
Date: Sun, 11 Apr 2004 00:11:45 +0200
In-Reply-To: <20040407130724.GK15152@tangency.co.uk> (S. Meslin-Weber's
	message of "Wed, 7 Apr 2004 14:07:24 +0100")
Message-ID: <87lll3mqji.fsf@oz.fapse.ulg.ac.be>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
Subject: Re: FOSDEM group photo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 22:13:33 -0000

"S. Meslin-Weber" <twiun@adorphuye.com> writes:

> direct link to the image in question:
> http://adorphuye.com/gallery/FOSDEM2004/IMGP0234

Bad! GNU Classpathx maintainer and Debian Developer was not on it :-/

When did you took that photo?! I thought I was always with you ;-)

-- 
~/.signature not found

This is Unix we're talking about, remember.  It's not supposed to be
nice for the applications programmer.
		-- Matthew Danish on debian-devel



From MAILER-DAEMON Sun Apr 11 02:38:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCYcD-00019u-G1
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 02:38:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCYcA-00017Z-D8
	for classpath@gnu.org; Sun, 11 Apr 2004 02:38:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCYba-0000ID-Bh
	for classpath@gnu.org; Sun, 11 Apr 2004 02:38:42 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BCYbX-000075-QW
	for classpath@gnu.org; Sun, 11 Apr 2004 02:38:07 -0400
Received: from [213.228.0.176] (helo=postfix4-2.free.fr)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BCYYv-0004eA-Mh
	for classpath@gnu.org; Sun, 11 Apr 2004 02:35:25 -0400
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112]) by postfix4-2.free.fr (Postfix) with ESMTP
	id BC82092A69; Sun, 11 Apr 2004 08:34:51 +0200 (CEST)
Message-ID: <4078E708.4040508@kaffe.org>
Date: Sun, 11 Apr 2004 08:34:48 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <407831EA.2020508@kaffe.org> <200404102014.45174.konqueror@gmx.de>
In-Reply-To: <200404102014.45174.konqueror@gmx.de>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig560EF4DEB9F177C2517CF2E5"
Cc: Classpath List <classpath@gnu.org>
Subject: Re: java.text attributes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 06:38:47 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig560EF4DEB9F177C2517CF2E5
Content-Type: multipart/mixed; boundary="------------050201090002020400070609"

This is a multi-part message in MIME format.
--------------050201090002020400070609
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable


>=20
> Sorry Guilhem, but I cant find the parts where you fix the=20
> Makefile.ams ;-)
>=20
>=20

H=E9h=E9 ! Actually it is partial as I don't fix the java either here. ;-=
)=20
But here are the makefiles.


> Michael
>=20
>=20


--------------050201090002020400070609
Content-Type: text/plain;
 name="text_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="text_patch"

Index: java/text/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/Makefile.am,v
retrieving revision 1.5
diff -u -r1.5 Makefile.am
--- java/text/Makefile.am	24 Oct 2003 15:17:16 -0000	1.5
+++ java/text/Makefile.am	11 Apr 2004 06:33:39 -0000
@@ -17,7 +17,6 @@
 DecimalFormatSymbols.java \
 FieldPosition.java \
 Format.java \
-FormatCharacterIterator.java \
 MessageFormat.java \
 NumberFormat.java \
 ParseException.java \
Index: gnu/java/text/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/gnu/java/text/Makefile.am,v
retrieving revision 1.1
diff -u -r1.1 Makefile.am
--- gnu/java/text/Makefile.am	5 Sep 2001 00:00:19 -0000	1.1
+++ gnu/java/text/Makefile.am	11 Apr 2004 06:33:39 -0000
@@ -1,8 +1,12 @@
 ## Input file for automake to generate the Makefile.in used by configure
 
 EXTRA_DIST = \
+AttributedFormatBuffer.java \
 BaseBreakIterator.java \
 CharacterBreakIterator.java \
+FormatBuffer.java \
+FormatCharacterIterator.java \
 LineBreakIterator.java \
 SentenceBreakIterator.java \
+StringFormatBuffer.java \
 WordBreakIterator.java

--------------050201090002020400070609--

--------------enig560EF4DEB9F177C2517CF2E5
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAeOcLWRk4qbNiTwgRAn/ZAJ0YGODXf9nKZ0yca/1cw/sKL6wExACeJE3V
CpSbGsJk4Rh3xpwxWj6az9U=
=FxQd
-----END PGP SIGNATURE-----

--------------enig560EF4DEB9F177C2517CF2E5--




From MAILER-DAEMON Sun Apr 11 02:49:36 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCYmd-0007Lr-Np
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 02:49:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCYmR-0007Av-12
	for classpath@gnu.org; Sun, 11 Apr 2004 02:49:23 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCYlu-0006sD-9X
	for classpath@gnu.org; Sun, 11 Apr 2004 02:49:21 -0400
Received: from [213.51.128.197] (helo=smtpq2.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCYlt-0006s5-Oq
	for classpath@gnu.org; Sun, 11 Apr 2004 02:48:49 -0400
Received: from [213.51.128.136] (port=52555 helo=smtp5.home.nl)
	by smtpq2.home.nl with esmtp (Exim 4.30)
	id 1BCYlr-0007El-Br; Sun, 11 Apr 2004 08:48:47 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:32791
	helo=dumas.thomas.planescape.com)
	by smtp5.home.nl with esmtp (Exim 4.30)
	id 1BCYlq-00007e-Jw; Sun, 11 Apr 2004 08:48:46 +0200
From: Thomas Zander <zander@javalobby.org>
To: Andrew Haley <aph@redhat.com>
Date: Sun, 11 Apr 2004 08:48:02 +0200
User-Agent: KMail/1.6.1
References: <200404060956.14298.zander@javalobby.org>
	<200404082150.24907.konqueror@gmx.de>
	<16501.44635.43431.486147@cuddles.cambridge.redhat.com>
In-Reply-To: <16501.44635.43431.486147@cuddles.cambridge.redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404110848.06673.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Cc: GNU Classpath <classpath@gnu.org>, mauve-discuss@sources.redhat.com,
	Michael Koch <konqueror@gmx.de>
Subject: Re: Mauve patches.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 06:49:24 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 08 April 2004 21:56, Andrew Haley wrote:
> =A0> > I'd really like to see my stuff committed, or commented on if just
> =A0> > committing is unacceptable.
=2E..
> I was intending to do it at the start of this week, sorry.

Its next week now; so your schedule was probably too full. (No offence!)

I hope you'll agree that its more important to have people creating patches=
=20
and moving the project forward then to always have a 100% correct CVS.=20
(problems can be fixed post-commit)
In that case; what about providing me with a writable CVS account so I=20
won't have to bother you anymore.

Oh; and a explanation of the correct changelog format; or a link to that=20
since you said there was something wrong with it; but I don't know what.

Hope to hear from you; Mauve is growing way too slow for my taste this way.

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAeOolCojCW6H2z/QRAtQNAKCeeKJpauJkytXf1iYfV8QDxv4H+gCfbYRw
6fhgQWbMbRMOwFI71OahauA=3D
=3DEvsI
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Sun Apr 11 03:05:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCZ1g-00075W-Ld
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 03:05:08 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCZ1c-0006yw-Bu
	for classpath@gnu.org; Sun, 11 Apr 2004 03:05:04 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCZ16-0006Uc-Lb
	for classpath@gnu.org; Sun, 11 Apr 2004 03:05:03 -0400
Received: from [213.228.0.176] (helo=postfix4-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCZ15-0006Tl-Vi
	for classpath@gnu.org; Sun, 11 Apr 2004 03:04:32 -0400
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix4-2.free.fr (Postfix) with ESMTP id 28B0393690
	for <classpath@gnu.org>; Sun, 11 Apr 2004 09:04:31 +0200 (CEST)
Message-ID: <4078EDFE.2090608@kaffe.org>
Date: Sun, 11 Apr 2004 09:04:30 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigDDF40A24184342719A95825B"
Subject: java.text.MessageFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 07:05:05 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigDDF40A24184342719A95825B
Content-Type: multipart/mixed; boundary="------------020606070906050800040802"

This is a multi-part message in MIME format.
--------------020606070906050800040802
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is patch for java.text.MessageFormat. It adds support for
MessageFormat.Field, attributed iterators, FieldPos support and adds two
simple missing methods. There is also one or two documentation updates.

ChangeLog entry:

2004-04-10  Guilhem Lavaux <guilhem@kaffe.org>

	* java/text/MessageFormat.java:
	(class Field): New class.
	(formatToCharacterIterator): New method.
	(format): Use formatInternal now.
	(formatInternal): New method. String formatter should
	be done here (with attributes). Attributes merging supported.
	(parse): More documentation.
	(getFormatsByArgumentIndex): New method.
	(setFormatByArgumentIndex): New method.
	(setFormatsByArgumentIndex): New method.

Cheers,

Guilhem.


--------------020606070906050800040802
Content-Type: text/plain;
 name="message_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="message_patch"

Index: java/text/MessageFormat.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/MessageFormat.java,v
retrieving revision 1.9
diff -u -b -B -r1.9 MessageFormat.java
--- java/text/MessageFormat.java	14 Jan 2004 21:37:33 -0000	1.9
+++ java/text/MessageFormat.java	10 Apr 2004 17:07:21 -0000
@@ -38,7 +38,11 @@
 
 package java.text;
 
+import gnu.java.text.FormatCharacterIterator;
+
+import java.io.InvalidObjectException;
 import java.util.Date;
+import java.util.HashMap;
 import java.util.Locale;
 import java.util.Vector;
 
@@ -145,6 +149,43 @@
 {
   private static final long serialVersionUID = 6479157306784022952L;
 
+  public static class Field extends Format.Field
+  {
+    static final long serialVersionUID = 7899943957617360810L;
+
+    /**
+     * This is the attribute set for all characters produced
+     * by MessageFormat during a formatting.
+     */
+    public static final MessageFormat.Field ARGUMENT = new Field("argument");
+
+    // For deserialization
+    private Field()
+    {
+      super("");
+    }
+    
+    private Field(String s)
+    {
+      super(s);
+    }
+
+    /**
+     * invoked to resolve the true static constant by
+     * comparing the deserialized object to know name.
+     *
+     * @return object constant
+     */
+    protected Object readResolve() throws InvalidObjectException
+    {
+      if (getName().equals(ARGUMENT.getName()))
+	return ARGUMENT;
+
+      throw new InvalidObjectException("no such MessageFormat field called " + getName());
+    }
+
+  }
+
   // Helper that returns the text up to the next format opener.  The
   // text is put into BUFFER.  Returns index of character after end of
   // string.  Throws IllegalArgumentException on error.
@@ -326,12 +367,28 @@
    * @param aPattern The pattern used when formatting.
    * @param arguments The array containing the objects to be formatted.
    */
+  public AttributedCharacterIterator formatToCharacterIterator (Object arguments)
+  {
+    Object[] arguments_array = (Object[])arguments;
+    FormatCharacterIterator iterator = new FormatCharacterIterator();
+    
+    formatInternal(arguments_array, new StringBuffer(), null, iterator);
+  
+    return iterator;
+  }
+
+  /**
+   * A convinience method to format patterns.
+   *
+   * @param aPattern The pattern used when formatting.
+   * @param arguments The array containing the objects to be formatted.
+   */
   public static String format (String pattern, Object arguments[])
   {
     MessageFormat mf = new MessageFormat (pattern);
     StringBuffer sb = new StringBuffer ();
     FieldPosition fp = new FieldPosition (NumberFormat.INTEGER_FIELD);
-    return mf.format(arguments, sb, fp).toString();
+    return mf.formatInternal(arguments, sb, fp, null).toString();
   }
 
   /**
@@ -342,9 +399,18 @@
    * @param fp A FieldPosition object (it is ignored).
    */
   public final StringBuffer format (Object arguments[], StringBuffer appendBuf,
-				    FieldPosition ignore)
+				    FieldPosition fp)
+  {
+    return formatInternal(arguments, appendBuf, fp, null);
+  }
+
+  protected final StringBuffer formatInternal (Object arguments[], StringBuffer appendBuf,
+					       FieldPosition fp,
+					       FormatCharacterIterator output_iterator)
   {
     appendBuf.append(leader);
+    if (output_iterator != null)
+      output_iterator.append(leader);
 
     for (int i = 0; i < elements.length; ++i)
       {
@@ -352,8 +418,13 @@
 	  throw new IllegalArgumentException("Not enough arguments given");
 
 	Object thisArg = arguments[elements[i].argNumber];
+	AttributedCharacterIterator iterator = null;
 
 	Format formatter = null;
+
+	if (fp != null && i == fp.getField() && fp.getFieldAttribute() == Field.ARGUMENT)
+	  fp.setBeginIndex(appendBuf.length());
+
 	if (elements[i].setFormat != null)
 	  formatter = elements[i].setFormat;
 	else if (elements[i].format != null)
@@ -371,20 +442,51 @@
 	else
 	  appendBuf.append(thisArg);
 
+	if (fp != null && fp.getField() == i && fp.getFieldAttribute() == Field.ARGUMENT)
+	  fp.setEndIndex(appendBuf.length());
+
 	if (formatter != null)
 	  {
 	    // Special-case ChoiceFormat.
 	    if (formatter instanceof ChoiceFormat)
 	      {
 		StringBuffer buf = new StringBuffer ();
-		formatter.format(thisArg, buf, ignore);
+		formatter.format(thisArg, buf, fp);
 		MessageFormat mf = new MessageFormat ();
 		mf.setLocale(locale);
 		mf.applyPattern(buf.toString());
-		mf.format(arguments, appendBuf, ignore);
+		mf.format(arguments, appendBuf, fp);
+	      }
+	    else
+	      {
+		if (output_iterator != null)
+		  iterator = formatter.formatToCharacterIterator(thisArg);
+		else
+		  formatter.format(thisArg, appendBuf, fp);
+	      }
+
+	    elements[i].format = formatter;
+	  }
+
+	if (output_iterator != null)
+	  {
+	    HashMap hash_argument = new HashMap();
+	    int position = output_iterator.getEndIndex();
+	    
+	    hash_argument.put (MessageFormat.Field.ARGUMENT,
+			       new Integer(elements[i].argNumber));
+
+	    
+	    if (iterator != null)
+	      {
+		output_iterator.append(iterator);
+		output_iterator.addAttributes(hash_argument, position, 
+					      output_iterator.getEndIndex());
 	      }
 	    else
-	      formatter.format(thisArg, appendBuf, ignore);
+	      output_iterator.append(thisArg.toString(), hash_argument);
+	    
+	    output_iterator.append(elements[i].trailer);
 	  }
 
 	appendBuf.append(elements[i].trailer);
@@ -398,10 +500,10 @@
    *
    * @param source The object to be formatted.
    * @param result The StringBuffer where the text is appened.
-   * @param fp A FieldPosition object (it is ignored).
+   * @param fpos A FieldPosition object (it is ignored).
    */
   public final StringBuffer format (Object singleArg, StringBuffer appendBuf,
-				    FieldPosition ignore)
+				    FieldPosition fpos)
   {
     Object[] args;
 
@@ -416,7 +518,7 @@
 	args = new Object[1];
 	args[0] = singleArg;
       }
-    return format (args, appendBuf, ignore);
+    return format (args, appendBuf, fpos);
   }
 
   /**
@@ -478,6 +580,15 @@
     applyPattern (pattern);
   }
 
+  /**
+   * Parse a string <code>sourceStr</code> against the pattern specified
+   * to the MessageFormat constructor.
+   *
+   * @param sourceStr the string to be parsed.
+   * @param pos the current parse position (and eventually the error position).
+   * @return the array of parsed objects sorted according to their argument number
+   * in the pattern.
+   */ 
   public Object[] parse (String sourceStr, ParsePosition pos)
   {
     // Check initial text.
@@ -626,6 +737,72 @@
   public String toPattern ()
   {
     return pattern;
+  }
+
+  /**
+   * Return the formatters used sorted by argument index. It uses the
+   * internal table to fill in this array: if a format has been
+   * set using <code>setFormat</code> or <code>setFormatByArgumentIndex</code>
+   * then it returns it at the right index. If not it uses the detected
+   * formatters during a <code>format</code> call. If nothing is known
+   * about that argument index it just puts null at that position.
+   * To get useful informations you may have to call <code>format</code>
+   * at least once.
+   *
+   * @return an array of formatters sorted by argument index.
+   */
+  public Format[] getFormatsByArgumentIndex()
+  {
+    int argNumMax = 0;
+    // First, find the greatest argument number.
+    for (int i=0;i<elements.length;i++)
+      if (elements[i].argNumber > argNumMax)
+	argNumMax = elements[i].argNumber;
+
+    Format[] formats = new Format[argNumMax];
+    for (int i=0;i<elements.length;i++)
+      {
+	if (elements[i].setFormat != null)
+	  formats[elements[i].argNumber] = elements[i].setFormat;
+	else if (elements[i].format != null)
+	  formats[elements[i].argNumber] = elements[i].format;
+      }
+    return formats;
+  }
+
+  /**
+   * Set the format to used using the argument index number.
+   *
+   * @param argumentIndex the argument index.
+   * @param newFormat the format to use for this argument.
+   */
+  public void setFormatByArgumentIndex(int argumentIndex,
+				       Format newFormat)
+  {
+    for (int i=0;i<elements.length;i++)
+      {
+	if (elements[i].argNumber == argumentIndex)
+	  elements[i].setFormat = newFormat;
+      }
+  }
+
+  /**
+   * Set the format for argument using a specified array of formatters
+   * which is sorted according to the argument index. If the number of
+   * elements in the array is fewer than the number of arguments only
+   * the arguments specified by the array are touched.
+   *
+   * @param newFormats array containing the new formats to set.
+   *
+   * @throws NullPointerException if newFormats is null
+   */
+  public void setFormatsByArgumentIndex(Format[] newFormats)
+  {
+    for (int i=0;i<newFormats.length;i++)
+      {
+	// Nothing better than that can exist here.
+	setFormatByArgumentIndex(i, newFormats[i]);
+      }
   }
 
   // The pattern string.

--------------020606070906050800040802--

--------------enigDDF40A24184342719A95825B
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAeO3+WRk4qbNiTwgRAs77AKCJIrrTEi1P5CbC3ZkzOxw2D2a5mwCfR6lr
uNPDJiZ9k5LutbdUX3Tq8fw=
=rR7t
-----END PGP SIGNATURE-----

--------------enigDDF40A24184342719A95825B--




From MAILER-DAEMON Sun Apr 11 03:17:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCZDk-0006lF-8J
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 03:17:36 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCZDG-00069Z-D1
	for classpath@gnu.org; Sun, 11 Apr 2004 03:17:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCZCc-0005W5-AC
	for classpath@gnu.org; Sun, 11 Apr 2004 03:16:57 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BCZBP-0004Qr-TB
	for classpath@gnu.org; Sun, 11 Apr 2004 03:15:12 -0400
Received: from [213.228.0.176] (helo=postfix4-2.free.fr)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BCZAw-0001aS-Dq
	for classpath@gnu.org; Sun, 11 Apr 2004 03:14:42 -0400
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix4-2.free.fr (Postfix) with ESMTP id 6676893636
	for <classpath@gnu.org>; Sun, 11 Apr 2004 09:14:41 +0200 (CEST)
Message-ID: <4078F05D.4060308@kaffe.org>
Date: Sun, 11 Apr 2004 09:14:37 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig6E5FC9F3370AA4B5904DA916"
Subject: java.text.SimpleDateFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 07:17:29 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig6E5FC9F3370AA4B5904DA916
Content-Type: multipart/mixed; boundary="------------030009060206000304060000"

This is a multi-part message in MIME format.
--------------030009060206000304060000
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is patch to implement attributes in SimpleDateFormat.

ChangeLog entry:

2004-11-04  Guilhem Lavaux <guilhem@kaffe.org>

	* java/text/SimpleDateFormat.java:
	(formatWithAttribute): New method. It implements
	the formatting process with attributes.
	(format): Use formatWithAttribute.
	(formatToCharacterIterator): New method. Use
	formatWithAttribute.

Cheers,

Guilhem.

--------------030009060206000304060000
Content-Type: text/plain;
 name="date_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="date_patch"

Index: java/text/SimpleDateFormat.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/SimpleDateFormat.java,v
retrieving revision 1.25
diff -u -b -B -r1.25 SimpleDateFormat.java
--- java/text/SimpleDateFormat.java	28 Nov 2003 23:33:06 -0000	1.25
+++ java/text/SimpleDateFormat.java	10 Apr 2004 17:07:21 -0000
@@ -39,16 +39,21 @@
 
 package java.text;
 
+import gnu.java.text.AttributedFormatBuffer;
+import gnu.java.text.FormatBuffer;
+import gnu.java.text.FormatCharacterIterator;
+import gnu.java.text.StringFormatBuffer;
+
+import java.io.IOException;
+import java.io.ObjectInputStream;
 import java.util.ArrayList;
 import java.util.Calendar;
 import java.util.Date;
 import java.util.GregorianCalendar;
 import java.util.Iterator;
 import java.util.Locale;
-import java.util.TimeZone;
 import java.util.SimpleTimeZone;
-import java.io.ObjectInputStream;
-import java.io.IOException;
+import java.util.TimeZone;
 
 /**
  * SimpleDateFormat provides convenient methods for parsing and formatting
@@ -411,109 +416,164 @@
    * appending to the specified StringBuffer.  The input StringBuffer
    * is returned as output for convenience.
    */
-  public StringBuffer format(Date date, StringBuffer buffer, FieldPosition pos)
+  final private void formatWithAttribute(Date date, FormatBuffer buffer, FieldPosition pos)
   {
     String temp;
+    AttributedCharacterIterator.Attribute attribute;
     calendar.setTime(date);
     
-    // go through ArrayList, filling in fields where applicable, else toString
-    Iterator i = tokens.iterator();
-    while (i.hasNext()) {
-      Object o = i.next();
-      if (o instanceof FieldSizePair) {
+    // go through vector, filling in fields where applicable, else toString
+    Iterator iter = tokens.iterator();
+    while (iter.hasNext())
+      {
+	Object o = iter.next();
+	if (o instanceof FieldSizePair)
+	  {
 	FieldSizePair p = (FieldSizePair) o;
 	int beginIndex = buffer.length();
-	switch (p.field) {
+	    
+	    switch (p.field)
+	      {
 	case ERA_FIELD:
-	  buffer.append(formatData.eras[calendar.get(Calendar.ERA)]);
+		buffer.append (formatData.eras[calendar.get (Calendar.ERA)], DateFormat.Field.ERA);
 	  break;
 	case YEAR_FIELD:
 	  // If we have two digits, then we truncate.  Otherwise, we
 	  // use the size of the pattern, and zero pad.
+		buffer.setDefaultAttribute (DateFormat.Field.YEAR);
 	  if (p.size == 2)
 	    {
-	      temp = String.valueOf(calendar.get(Calendar.YEAR));
-	      buffer.append(temp.substring(temp.length() - 2));
+		    temp = String.valueOf (calendar.get (Calendar.YEAR));
+		    buffer.append (temp.substring (temp.length() - 2));
 	    }
 	  else
-	    withLeadingZeros(calendar.get(Calendar.YEAR), p.size, buffer);
+		  withLeadingZeros (calendar.get (Calendar.YEAR), p.size, buffer);
 	  break;
 	case MONTH_FIELD:
+		buffer.setDefaultAttribute (DateFormat.Field.MONTH);
 	  if (p.size < 3)
-	    withLeadingZeros(calendar.get(Calendar.MONTH)+1,p.size,buffer);
+		  withLeadingZeros (calendar.get (Calendar.MONTH) + 1, p.size, buffer);
 	  else if (p.size < 4)
-	    buffer.append(formatData.shortMonths[calendar.get(Calendar.MONTH)]);
+		  buffer.append (formatData.shortMonths[calendar.get (Calendar.MONTH)]);
 	  else
-	    buffer.append(formatData.months[calendar.get(Calendar.MONTH)]);
+		  buffer.append (formatData.months[calendar.get (Calendar.MONTH)]);
 	  break;
 	case DATE_FIELD:
-	  withLeadingZeros(calendar.get(Calendar.DATE),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.DAY_OF_MONTH);
+		withLeadingZeros (calendar.get (Calendar.DATE), p.size, buffer);
 	  break;
 	case HOUR_OF_DAY1_FIELD: // 1-24
-	  withLeadingZeros(((calendar.get(Calendar.HOUR_OF_DAY)+23)%24)+1,p.size,buffer);
+		buffer.setDefaultAttribute(DateFormat.Field.HOUR_OF_DAY1);
+		withLeadingZeros ( ((calendar.get (Calendar.HOUR_OF_DAY) + 23) % 24) + 1, 
+				   p.size, buffer);
 	  break;
 	case HOUR_OF_DAY0_FIELD: // 0-23
-	  withLeadingZeros(calendar.get(Calendar.HOUR_OF_DAY),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.HOUR_OF_DAY0);
+		withLeadingZeros (calendar.get (Calendar.HOUR_OF_DAY), p.size, buffer);
 	  break;
 	case MINUTE_FIELD:
-	  withLeadingZeros(calendar.get(Calendar.MINUTE),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.MINUTE);
+		withLeadingZeros (calendar.get (Calendar.MINUTE),
+				  p.size, buffer);
 	  break;
 	case SECOND_FIELD:
-	  withLeadingZeros(calendar.get(Calendar.SECOND),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.SECOND);
+		withLeadingZeros(calendar.get (Calendar.SECOND), 
+				 p.size, buffer);
 	  break;
 	case MILLISECOND_FIELD:
-	  withLeadingZeros(calendar.get(Calendar.MILLISECOND),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.MILLISECOND);
+		withLeadingZeros (calendar.get (Calendar.MILLISECOND), p.size, buffer);
 	  break;
 	case DAY_OF_WEEK_FIELD:
+		buffer.setDefaultAttribute (DateFormat.Field.DAY_OF_WEEK);
 	  if (p.size < 4)
-	    buffer.append(formatData.shortWeekdays[calendar.get(Calendar.DAY_OF_WEEK)]);
+		  buffer.append (formatData.shortWeekdays[calendar.get (Calendar.DAY_OF_WEEK)]);
 	  else
-	    buffer.append(formatData.weekdays[calendar.get(Calendar.DAY_OF_WEEK)]);
+		  buffer.append (formatData.weekdays[calendar.get (Calendar.DAY_OF_WEEK)]);
 	  break;
 	case DAY_OF_YEAR_FIELD:
-	  withLeadingZeros(calendar.get(Calendar.DAY_OF_YEAR),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.DAY_OF_YEAR);
+		withLeadingZeros (calendar.get (Calendar.DAY_OF_YEAR), p.size, buffer);
 	  break;
 	case DAY_OF_WEEK_IN_MONTH_FIELD:
-	  withLeadingZeros(calendar.get(Calendar.DAY_OF_WEEK_IN_MONTH),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.DAY_OF_WEEK_IN_MONTH);
+		withLeadingZeros (calendar.get (Calendar.DAY_OF_WEEK_IN_MONTH), 
+				 p.size, buffer);
 	  break;
 	case WEEK_OF_YEAR_FIELD:
-	  withLeadingZeros(calendar.get(Calendar.WEEK_OF_YEAR),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.WEEK_OF_YEAR);
+		withLeadingZeros (calendar.get (Calendar.WEEK_OF_YEAR),
+				  p.size, buffer);
 	  break;
 	case WEEK_OF_MONTH_FIELD:
-	  withLeadingZeros(calendar.get(Calendar.WEEK_OF_MONTH),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.WEEK_OF_MONTH);
+		withLeadingZeros (calendar.get (Calendar.WEEK_OF_MONTH),
+				  p.size, buffer);
 	  break;
 	case AM_PM_FIELD:
-	  buffer.append(formatData.ampms[calendar.get(Calendar.AM_PM)]);
+		buffer.setDefaultAttribute (DateFormat.Field.AM_PM);
+		buffer.append (formatData.ampms[calendar.get (Calendar.AM_PM)]);
 	  break;
 	case HOUR1_FIELD: // 1-12
-	  withLeadingZeros(((calendar.get(Calendar.HOUR)+11)%12)+1,p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.HOUR1);
+		withLeadingZeros (((calendar.get (Calendar.HOUR) + 11) % 12) + 1, p.size, buffer);
 	  break;
 	case HOUR0_FIELD: // 0-11
-	  withLeadingZeros(calendar.get(Calendar.HOUR),p.size,buffer);
+		buffer.setDefaultAttribute (DateFormat.Field.HOUR0);
+		withLeadingZeros (calendar.get (Calendar.HOUR), p.size, buffer);
 	  break;
 	case TIMEZONE_FIELD:
+		buffer.setDefaultAttribute (DateFormat.Field.TIME_ZONE);
 	  TimeZone zone = calendar.getTimeZone();
-	  boolean isDST = calendar.get(Calendar.DST_OFFSET) != 0;
+		boolean isDST = calendar.get (Calendar.DST_OFFSET) != 0;
 	  // FIXME: XXX: This should be a localized time zone.
-	  String zoneID = zone.getDisplayName(isDST, p.size > 3 ? TimeZone.LONG : TimeZone.SHORT);
-	  buffer.append(zoneID);
+		String zoneID = zone.getDisplayName (isDST, p.size > 3 ? TimeZone.LONG : TimeZone.SHORT);
+		buffer.append (zoneID);
 	  break;
 	default:
-	  throw new IllegalArgumentException("Illegal pattern character");
+		throw new IllegalArgumentException ("Illegal pattern character " + p.field);
 	}
-	if (pos != null && p.field == pos.getField())
+	    if (pos != null && (buffer.getDefaultAttribute() == pos.getFieldAttribute()
+				|| p.field == pos.getField()))
 	  {
 	    pos.setBeginIndex(beginIndex);
 	    pos.setEndIndex(buffer.length());
 	  }
-      } else {
-	buffer.append(o.toString());
+	  } 
+      else
+	{  
+	  buffer.append(o.toString(), null);
       }
     }
+  }
+  
+  public StringBuffer format(Date date, StringBuffer buffer, FieldPosition pos)
+  {
+    formatWithAttribute(date, new StringFormatBuffer (buffer), pos);
+
     return buffer;
   }
 
-  private void withLeadingZeros(int value, int length, StringBuffer buffer) 
+  public AttributedCharacterIterator formatToCharacterIterator(Object date)
+    throws IllegalArgumentException
+  {
+    if (date == null)
+      throw new NullPointerException("null argument");
+    if (!(date instanceof Date))
+      throw new IllegalArgumentException("argument should be an instance of java.util.Date");
+
+    AttributedFormatBuffer buf = new AttributedFormatBuffer();
+    formatWithAttribute((Date)date, buf,
+			null);
+    buf.sync();
+        
+    return new FormatCharacterIterator(buf.getBuffer().toString(),
+				       buf.getRanges(),
+				       buf.getAttributes());
+  }
+
+  private void withLeadingZeros(int value, int length, FormatBuffer buffer) 
   {
     String valStr = String.valueOf(value);
     for (length -= valStr.length(); length > 0; length--)

--------------030009060206000304060000--

--------------enig6E5FC9F3370AA4B5904DA916
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAePBhWRk4qbNiTwgRAnHXAJ9t859J8ZGOWsLVLBR3cKnTQhTIvgCeMSpa
DF7GaTKpjcpB91XrYjUgYHI=
=v93j
-----END PGP SIGNATURE-----

--------------enig6E5FC9F3370AA4B5904DA916--




From MAILER-DAEMON Sun Apr 11 03:54:38 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCZnZ-0003KC-V0
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 03:54:37 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCZnW-0003J5-KZ
	for classpath@gnu.org; Sun, 11 Apr 2004 03:54:34 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCZki-0001MQ-8p
	for classpath@gnu.org; Sun, 11 Apr 2004 03:52:12 -0400
Received: from [213.228.0.176] (helo=postfix4-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCZkg-0001JD-Hy
	for classpath@gnu.org; Sun, 11 Apr 2004 03:51:38 -0400
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix4-2.free.fr (Postfix) with ESMTP id 92FA7936CC
	for <classpath@gnu.org>; Sun, 11 Apr 2004 09:51:37 +0200 (CEST)
Message-ID: <4078F905.7070702@kaffe.org>
Date: Sun, 11 Apr 2004 09:51:33 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig5FDE830878DADD84DD766EC6"
Subject: java.text.DecimalFormat
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 07:54:35 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig5FDE830878DADD84DD766EC6
Content-Type: multipart/mixed; boundary="------------090802000908040901020208"

This is a multi-part message in MIME format.
--------------090802000908040901020208
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is patch to implement attributes and fixes the exponential 
notation. The formatting has been rebuilt to be able to construct the 
output string without inserting characters in the middle of the string.

ChangeLog entry:

2004-04-11  Guilhem Lavaux <guilhem@kaffe.org>

	* java/text/DecimalFormat.java
	(scanFix): Build attribute array. Fixed error reporting.
	(applyPatternWithSymbols): Store attributes for the prefix and
	suffix.
	(formatInternal): New method. Changed the way the string is
	computed. Implemented attributes. Cleant up rounding in
	exponential notation.
	(format): Use formatInternal.
	(formatToCharacterIterator): New method.
	(exponentRound, negativePrefixRanges, positivePrefixRanges,
	negativePrefixAttrs, positivePrefixAttrs, negativeSuffixRanges,
	positiveSuffixRanges, negativeSuffixAttrs, positiveSuffixAttrs):
	New fields.

Cheers,

Guilhem.

--------------090802000908040901020208
Content-Type: text/plain;
 name="text_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="text_patch"

Index: java/text/DecimalFormat.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/DecimalFormat.java,v
retrieving revision 1.12
diff -u -b -B -r1.12 DecimalFormat.java
--- java/text/DecimalFormat.java	1 Apr 2004 12:28:12 -0000	1.12
+++ java/text/DecimalFormat.java	10 Apr 2004 17:07:21 -0000
@@ -37,12 +37,16 @@
 
 package java.text;
 
+import gnu.java.text.AttributedFormatBuffer;
+import gnu.java.text.FormatBuffer;
+import gnu.java.text.FormatCharacterIterator;
+import gnu.java.text.StringFormatBuffer;
+
+import java.io.IOException;
+import java.io.ObjectInputStream;
 import java.util.Currency;
+import java.util.HashMap;
 import java.util.Locale;
-import java.util.MissingResourceException;
-import java.util.ResourceBundle;
-import java.io.ObjectInputStream;
-import java.io.IOException;
 
 /**
  * @author Tom Tromey <tromey@cygnus.com>
@@ -58,37 +62,48 @@
 {
   // This is a helper for applyPatternWithSymbols.  It reads a prefix
   // or a suffix.  It can cause some side-effects.
-  private final int scanFix (String pattern, int index, StringBuffer buf,
+  private final int scanFix (String pattern, int index, FormatBuffer buf,
 			     String patChars, DecimalFormatSymbols syms,
 			     boolean is_suffix)
   {
     int len = pattern.length();
-    buf.setLength(0);
+    boolean quoteStarted = false;
+    buf.clear();
+    
     boolean multiplierSet = false;
     while (index < len)
       {
 	char c = pattern.charAt(index);
+
+	if (quoteStarted)
+	  {
+	    if (c == '\'')
+	      quoteStarted = false;
+	    else
+	      buf.append(c);
+	    index++;
+	    continue;
+	  }
+
 	if (c == '\'' && index + 1 < len
 	    && pattern.charAt(index + 1) == '\'')
 	  {
 	    buf.append(c);
-	    ++index;
+	    index++;
 	  }
-	else if (c == '\'' && index + 2 < len
-		 && pattern.charAt(index + 2) == '\'')
+	else if (c == '\'')
 	  {
-	    buf.append(pattern.charAt(index + 1));
-	    index += 2;
+	    quoteStarted = true;
 	  }
 	else if (c == '\u00a4')
 	  {
 	    if (index + 1 < len && pattern.charAt(index + 1) == '\u00a4')
 	      {
-		buf.append(syms.getInternationalCurrencySymbol());
-		++index;
+		buf.append(syms.getInternationalCurrencySymbol(), NumberFormat.Field.CURRENCY);
+		index++;
 	      }
 	    else
-	      buf.append(syms.getCurrencySymbol());
+	      buf.append(syms.getCurrencySymbol(), NumberFormat.Field.CURRENCY);
 	  }
 	else if (c == syms.getPercent())
 	  {
@@ -97,7 +112,7 @@
 						  "- index: " + index);
 	    multiplierSet = true;
 	    multiplier = 100;
-	    buf.append(c);
+	    buf.append(c, NumberFormat.Field.PERCENT);
 	  }
 	else if (c == syms.getPerMill())
 	  {
@@ -106,7 +121,7 @@
 						  "- index: " + index);
 	    multiplierSet = true;
 	    multiplier = 1000;
-	    buf.append(c);
+	    buf.append(c, NumberFormat.Field.PERMILLE);
 	  }
 	else if (patChars.indexOf(c) != -1)
 	  {
@@ -115,9 +130,12 @@
 	  }
 	else
 	  buf.append(c);
-	++index;
+	index++;
       }
 
+    if (quoteStarted)
+      throw new IllegalArgumentException ("pattern is lacking a closing quote");
+
     return index;
   }
 
@@ -259,6 +277,16 @@
 	    useExponentialNotation = true;
 	    minExponentDigits = (byte) zeroCount;
 	  }
+
+	maximumIntegerDigits = groupingSize;
+	groupingSize = 0;
+	if (maximumIntegerDigits > minimumIntegerDigits && maximumIntegerDigits > 0)
+	  {
+	    minimumIntegerDigits = 1;
+	    exponentRound = maximumIntegerDigits;
+	  }
+	else
+	  exponentRound = 1;
       }
 
     return index;
@@ -304,17 +332,23 @@
     minimumFractionDigits = 0;
     minimumIntegerDigits = 1;
 
-    StringBuffer buf = new StringBuffer ();
+    AttributedFormatBuffer buf = new AttributedFormatBuffer ();
     String patChars = patternChars (syms);
 
     int max = pattern.length();
     int index = scanFix (pattern, 0, buf, patChars, syms, false);
-    positivePrefix = buf.toString();
+    buf.sync();
+    positivePrefix = buf.getBuffer().toString();
+    positivePrefixRanges = buf.getRanges();
+    positivePrefixAttrs = buf.getAttributes();
 
     index = scanFormat (pattern, index, patChars, syms, true);
 
     index = scanFix (pattern, index, buf, patChars, syms, true);
-    positiveSuffix = buf.toString();
+    buf.sync();
+    positiveSuffix = buf.getBuffer().toString();
+    positiveSuffixRanges = buf.getRanges();
+    positiveSuffixAttrs = buf.getAttributes();
 
     if (index == pattern.length())
       {
@@ -329,14 +363,20 @@
 					      "expected - index: " + index);
 
 	index = scanFix (pattern, index + 1, buf, patChars, syms, false);
-	negativePrefix = buf.toString();
+	buf.sync();
+	negativePrefix = buf.getBuffer().toString();
+	negativePrefixRanges = buf.getRanges();
+	negativePrefixAttrs = buf.getAttributes();
 
 	// We parse the negative format for errors but we don't let
 	// it side-effect this object.
 	index = scanFormat (pattern, index, patChars, syms, false);
 
 	index = scanFix (pattern, index, buf, patChars, syms, true);
-	negativeSuffix = buf.toString();
+	buf.sync();
+	negativeSuffix = buf.getBuffer().toString();
+	negativeSuffixRanges = buf.getRanges();
+	negativeSuffixAttrs = buf.getAttributes();
 
 	if (index != pattern.length())
 	  throw new IllegalArgumentException ("end of pattern expected " +
@@ -409,39 +449,43 @@
 	    && useExponentialNotation == dup.useExponentialNotation);
   }
 
-  public StringBuffer format (double number, StringBuffer dest,
+  protected void formatInternal (double number, FormatBuffer dest,
 			      FieldPosition fieldPos)
   {
     // A very special case.
     if (Double.isNaN(number))
       {
 	dest.append(symbols.getNaN());
-	if (fieldPos != null && fieldPos.getField() == INTEGER_FIELD)
+	if (fieldPos != null && 
+	    (fieldPos.getField() == INTEGER_FIELD ||
+	     fieldPos.getFieldAttribute() == NumberFormat.Field.INTEGER))
 	  {
 	    int index = dest.length();
 	    fieldPos.setBeginIndex(index - symbols.getNaN().length());
 	    fieldPos.setEndIndex(index);
 	  }
-	return dest;
+	return;
       }
 
     boolean is_neg = number < 0;
     if (is_neg)
       {
 	if (negativePrefix != null)
-	  dest.append(negativePrefix);
+	  dest.append(negativePrefix, negativePrefixRanges, negativePrefixAttrs);
 	else
 	  {
-	    dest.append(symbols.getMinusSign());
-	    dest.append(positivePrefix);
+	    dest.append(symbols.getMinusSign(), NumberFormat.Field.SIGN);
+	    dest.append(positivePrefix, positivePrefixRanges, positivePrefixAttrs);
 	  }
 	number = - number;
       }
     else
-      dest.append(positivePrefix);
+      dest.append(positivePrefix, positivePrefixRanges, positivePrefixAttrs);
 
     int integerBeginIndex = dest.length();
     int integerEndIndex = 0;
+    int zeroStart = symbols.getZeroDigit() - '0';
+
     if (Double.isInfinite (number))
       {
 	dest.append(symbols.getInfinity());
@@ -457,6 +501,7 @@
 	if (useExponentialNotation)
 	  {
 	    exponent = (long) Math.floor (Math.log(number) / Math.log(10));
+	    exponent = exponent - (exponent % exponentRound);
 	    if (minimumIntegerDigits > 0)
 	      exponent -= minimumIntegerDigits - 1;
 	    baseNumber = (number / Math.pow(10.0, exponent));
@@ -468,22 +513,32 @@
 	baseNumber += 5 * Math.pow(10.0, - maximumFractionDigits - 1);
 
 	int index = dest.length();
-	double intPart = Math.floor(baseNumber);
-	int count = 0;
-	while (count < maximumIntegerDigits
-	       && (intPart > 0 || count < minimumIntegerDigits))
+	//double intPart = Math.floor(baseNumber);
+	String intPart = Long.toString((long)Math.floor(baseNumber));
+	int count, groupPosition = intPart.length();
+
+	dest.setDefaultAttribute(NumberFormat.Field.INTEGER);
+
+	for (count = 0; count < minimumIntegerDigits-intPart.length(); count++)
+	  dest.append(symbols.getZeroDigit());
+
+	for (count = 0;
+	     count < maximumIntegerDigits && count < intPart.length();
+	     count++)
 	  {
-	    long dig = (long) (intPart % 10);
-	    intPart = Math.floor(intPart / 10);
+	    int dig = intPart.charAt(count);
 
 	    // Append group separator if required.
-	    if (groupingUsed && count > 0 && groupingSize != 0 && count % groupingSize == 0)
-	      dest.insert(index, symbols.getGroupingSeparator());
-
-	    dest.insert(index, (char) (symbols.getZeroDigit() + dig));
+	    if (groupingUsed && count > 0 && groupingSize != 0 && groupPosition % groupingSize == 0)
+	      {
+		dest.append(symbols.getGroupingSeparator(), NumberFormat.Field.GROUPING_SEPARATOR);
+		dest.setDefaultAttribute(NumberFormat.Field.INTEGER);
+	      }
+	    dest.append((char) (zeroStart + dig));
 
-	    ++count;
+	    groupPosition--;
 	  }
+	dest.setDefaultAttribute(null);
 
 	integerEndIndex = dest.length();
 
@@ -491,10 +546,24 @@
 	int consecutive_zeros = 0;
 	int total_digits = 0;
 
+	int localMaximumFractionDigits = maximumFractionDigits;
+
+	if (useExponentialNotation)
+	  localMaximumFractionDigits += minimumIntegerDigits - count;
+
 	// Strip integer part from NUMBER.
 	double fracPart = baseNumber - Math.floor(baseNumber);
+	
+	if ( ((fracPart != 0 || minimumFractionDigits > 0) && localMaximumFractionDigits > 0)
+	     || decimalSeparatorAlwaysShown)
+	  {
+	    dest.append (symbols.getDecimalSeparator(), NumberFormat.Field.DECIMAL_SEPARATOR);
+	  }
+
+
+	dest.setDefaultAttribute(NumberFormat.Field.FRACTION);
 	for (count = 0;
-	     count < maximumFractionDigits
+	     count < localMaximumFractionDigits
 	       && (fracPart != 0 || count < minimumFractionDigits);
 	     ++count)
 	  {
@@ -517,55 +586,76 @@
 				    total_digits - minimumFractionDigits);
 	if (extra_zeros > 0)
 	  {
-	    dest.setLength(dest.length() - extra_zeros);
+	    dest.cutTail(extra_zeros);
 	    total_digits -= extra_zeros;
-	  }
-
-	// If required, add the decimal symbol.
-	if (decimalSeparatorAlwaysShown
-	    || total_digits > 0)
-	  {
-	    dest.insert(decimal_index, symbols.getDecimalSeparator());
-	    if (fieldPos != null && fieldPos.getField() == FRACTION_FIELD)
-	      {
-		fieldPos.setBeginIndex(decimal_index + 1);
-		fieldPos.setEndIndex(dest.length());
-	      }
+	    if (total_digits == 0 && !decimalSeparatorAlwaysShown)
+	      dest.cutTail(1);
 	  }
 
 	// Finally, print the exponent.
 	if (useExponentialNotation)
 	  {
-	    dest.append(symbols.getExponential());
+	    dest.append(symbols.getExponential(), NumberFormat.Field.EXPONENT_SYMBOL);	    
 	    if (exponent < 0)
 	      {
-		dest.append (symbols.getMinusSign ());
+		dest.append (symbols.getMinusSign (), NumberFormat.Field.EXPONENT_SIGN);
 		exponent = - exponent;
 	      }
 	    index = dest.length();
+	    dest.setDefaultAttribute(NumberFormat.Field.EXPONENT);
+	    String exponentString = Long.toString ((long) exponent);
+	    
+	    for (count = 0; count < minExponentDigits-exponentString.length();
+		 count++)
+	      dest.append((char) symbols.getZeroDigit());
+
 	    for (count = 0;
-		 exponent > 0 || count < minExponentDigits;
+		 count < exponentString.length();
 		 ++count)
 	      {
-		long dig = exponent % 10;
-		exponent /= 10;
-		dest.insert(index, (char) (symbols.getZeroDigit() + dig));
+		int dig = exponentString.charAt(count);
+		dest.append((char) (zeroStart + dig));
 	      }
 	  }
       }
 
-    if (fieldPos != null && fieldPos.getField() == INTEGER_FIELD)
+    if (fieldPos != null && 
+	(fieldPos.getField() == INTEGER_FIELD ||
+	 fieldPos.getFieldAttribute() == NumberFormat.Field.INTEGER))
       {
 	fieldPos.setBeginIndex(integerBeginIndex);
 	fieldPos.setEndIndex(integerEndIndex);
       }
 
-    dest.append((is_neg && negativeSuffix != null)
-		? negativeSuffix
-		: positiveSuffix);
+    if (is_neg && negativeSuffix != null)
+      dest.append(negativeSuffix, negativeSuffixRanges, negativeSuffixAttrs);
+    else
+      dest.append(positiveSuffix, positiveSuffixRanges, positiveSuffixAttrs);
+  }
+
+  public StringBuffer format (double number, StringBuffer dest,
+			      FieldPosition fieldPos)
+  {
+    formatInternal (number, new StringFormatBuffer(dest), fieldPos);
     return dest;
   }
 
+  public AttributedCharacterIterator formatToCharacterIterator (Object value)
+  {
+    AttributedFormatBuffer sbuf = new AttributedFormatBuffer();
+
+    if (value instanceof Number)
+      formatInternal(((Number) value).doubleValue(), sbuf, null);
+    else
+      throw new IllegalArgumentException 
+	("Cannot format given Object as a Number");
+    
+    sbuf.sync();
+    return new FormatCharacterIterator(sbuf.getBuffer().toString(), 
+				       sbuf.getRanges(), 
+				       sbuf.getAttributes());
+  }
+
   public StringBuffer format (long number, StringBuffer dest,
 			      FieldPosition fieldPos)
   {
@@ -964,7 +1054,7 @@
     // digits.  Past that we need hash marks up to the grouping
     // separator (and one beyond).
     int total_digits = Math.max(minimumIntegerDigits,
-				groupingUsed ? groupingSize + 1: 0);
+				groupingUsed ? groupingSize + 1: groupingSize);
     for (int i = 0; i < total_digits - minimumIntegerDigits; ++i)
       mainPattern.append(syms.getDigit());
     for (int i = total_digits - minimumIntegerDigits; i < total_digits; ++i)
@@ -1022,11 +1112,16 @@
   private boolean decimalSeparatorAlwaysShown;
   private byte groupingSize;
   private byte minExponentDigits;
+  private int exponentRound;
   private int multiplier;
   private String negativePrefix;
   private String negativeSuffix;
   private String positivePrefix;
   private String positiveSuffix;
+  private int[] negativePrefixRanges, positivePrefixRanges;
+  private HashMap[] negativePrefixAttrs, positivePrefixAttrs;
+  private int[] negativeSuffixRanges, positiveSuffixRanges;
+  private HashMap[] negativeSuffixAttrs, positiveSuffixAttrs;
   private int serialVersionOnStream = 1;
   private DecimalFormatSymbols symbols;
   private boolean useExponentialNotation;
--------------090802000908040901020208--

--------------enig5FDE830878DADD84DD766EC6
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAePkJWRk4qbNiTwgRAqKfAJ9JnRYGmfmwPrFEqOf/+yH5MAvi8gCcCxB9
8dVjPg45zeFNX5PuGrlqwj8=
=tioN
-----END PGP SIGNATURE-----

--------------enig5FDE830878DADD84DD766EC6--




From MAILER-DAEMON Sun Apr 11 03:58:33 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCZrN-0004O1-0L
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 03:58:33 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCZrK-0004NK-Bz
	for classpath@gnu.org; Sun, 11 Apr 2004 03:58:30 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCZqo-0004H3-PC
	for classpath@gnu.org; Sun, 11 Apr 2004 03:58:29 -0400
Received: from [213.228.0.176] (helo=postfix4-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCZmV-000375-2R
	for classpath@gnu.org; Sun, 11 Apr 2004 03:53:31 -0400
Received: from kaffe.org (cachan-3-82-66-125-112.fbx.proxad.net
	[82.66.125.112])
	by postfix4-2.free.fr (Postfix) with ESMTP id 813F7936D1
	for <classpath@gnu.org>; Sun, 11 Apr 2004 09:53:30 +0200 (CEST)
Message-ID: <4078F97A.9030108@kaffe.org>
Date: Sun, 11 Apr 2004 09:53:30 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030630
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Classpath List <classpath@gnu.org>
X-Enigmail-Version: 0.76.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigD48890DC006AB9844730F30D"
Subject: java.text.Format
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 07:58:31 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigD48890DC006AB9844730F30D
Content-Type: multipart/mixed; boundary="------------010609030403040707060707"

This is a multi-part message in MIME format.
--------------010609030403040707060707
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

Here is the latest patch (that one is really obvious) concerning java.text.Format.

ChangeLog entry:

2004-04-11  Guilhem Lavaux <guilhem@kaffe.org>

	* java/text/Format.java: Updated importations. Removed unnecessary classes.

Cheers,

Guilhem.


--------------010609030403040707060707
Content-Type: text/plain;
 name="text_patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="text_patch"

Index: java/text/Format.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/text/Format.java,v
retrieving revision 1.8
diff -u -r1.8 Format.java
--- java/text/Format.java	26 Dec 2003 22:33:20 -0000	1.8
+++ java/text/Format.java	11 Apr 2004 07:52:06 -0000
@@ -38,10 +38,8 @@
 
 package java.text;
 
-import java.util.Set;
-import java.util.Map;
-import java.util.HashSet;
-import java.util.HashMap;
+import gnu.java.text.FormatCharacterIterator;
+
 import java.io.Serializable;
 
 /**

--------------010609030403040707060707--

--------------enigD48890DC006AB9844730F30D
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAePl6WRk4qbNiTwgRAk/5AJ9+g8IT19WrK0IR5xpFW+vB3gE1BACfVeED
CHlnHop6GWcUuZtNcUKmaU0=
=ujJX
-----END PGP SIGNATURE-----

--------------enigD48890DC006AB9844730F30D--




From MAILER-DAEMON Sun Apr 11 08:19:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCdLQ-0002GB-Qe
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 07:41:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCdIj-0001Z9-Bp
	for classpath@gnu.org; Sun, 11 Apr 2004 07:39:01 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCdI2-0001MO-2k
	for classpath@gnu.org; Sun, 11 Apr 2004 07:38:50 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BCdDL-0000dg-C1
	for classpath@gnu.org; Sun, 11 Apr 2004 07:33:27 -0400
Received: from [212.101.4.135] (helo=mail01.solnet.ch)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BCd5p-0003wE-QZ
	for classpath@gnu.org; Sun, 11 Apr 2004 07:25:41 -0400
Received: from localhost (localhost [127.0.0.1])
	by mail01.solnet.ch (Postfix) with ESMTP id 4A8846232D
	for <classpath@gnu.org>; Sun, 11 Apr 2004 11:24:02 +0000 (GMT)
Received: from localhost ([127.0.0.1])
	by localhost (mail01.solnet.ch [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 32487-08 for <classpath@gnu.org>;
	Sun, 11 Apr 2004 11:24:01 +0000 (GMT)
Received: from reali.dnsalias.net (212-41-80-190.adsl.solnet.ch
	[212.41.80.190])
	by mail01.solnet.ch (Postfix) with ESMTP id DEA8F621F4
	for <classpath@gnu.org>; Sun, 11 Apr 2004 11:23:50 +0000 (GMT)
Received: from mc-reali (reali.dnsalias.net [192.168.1.2])
	by reali.dnsalias.net (Postfix) with ESMTP id F165233707
	for <classpath@gnu.org>; Sun, 11 Apr 2004 13:21:58 +0200 (CEST)
Date: Sun, 11 Apr 2004 13:24:51 +0200
From: Patrik Reali <reali@acm.org>
To: classpath@gnu.org
Message-ID: <93607480.1081689891@[192.168.1.4]>
X-Mailer: Mulberry/3.1.0 (Win32)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-Virus-Scanned: by SolNet mail01.solnet.ch
Subject: Q: How do you keep your sources in synch?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 11:41:46 -0000

Hi,

I'd like to add this topic to the FAQ, thus I'm looking for hard evidence 
on this topic.

I was wondering, how the various VM deal with changes in the classpath code 
(I assume you have a "customized" version of classpath). Are you importing 
them by hand or rely on some automated tool?

Before being able to use classpath out of the box, I relied on cvs (cvs 
import and cvs checkout -jOLDVERSION -jNEWVERSION), which worked well as 
long as the differences were not to big.

What is your experience?

-Patrik



From MAILER-DAEMON Sun Apr 11 09:30:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCf2W-00016K-7H
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 09:30:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCf2I-0000zB-NU
	for classpath@gnu.org; Sun, 11 Apr 2004 09:30:10 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCf1j-0000Si-TS
	for classpath@gnu.org; Sun, 11 Apr 2004 09:30:07 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BCf1j-0000Kl-Ec
	for classpath@gnu.org; Sun, 11 Apr 2004 09:29:35 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BCeys-0005ML-HC
	for classpath@gnu.org; Sun, 11 Apr 2004 09:26:38 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BCeyi-0000X5-00; Sun, 11 Apr 2004 15:26:28 +0200
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404082204.24821.konqueror@gmx.de>
References: <200404082204.24821.konqueror@gmx.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-vl/lcIKzaxd628D6pEFc"
Message-Id: <1081689990.13170.372.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Sun, 11 Apr 2004 15:26:30 +0200
Cc: classpath@gnu.org
Subject: Re: The big NIO
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 13:30:20 -0000


--=-vl/lcIKzaxd628D6pEFc
Content-Type: multipart/mixed; boundary="=-OoKHcXvlblXOetZDoJcL"


--=-OoKHcXvlblXOetZDoJcL
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Michael,

On Thu, 2004-04-08 at 22:04, Michael Koch wrote:
> I just commited my big NIO patch. I doesnt contain yet anything from the=20
> big pointer discussion. It is just a merge from libgcj. It reworks=20
> java.io file operations to use java.nio.channels internally for=20
> performance. I have done a full mauve run and found no new strange=20
> failures with jamvm. If any problems occur please mail to me.

I am very surprised that you didn't have problems with Mauve tests.
There were a very large number of new failures for me. I had two major
issues which took me quite some time to analyze and resolve. In part
because I knew you claimed that there were no regressions with the new
code.

One was fixed by implementing FileChannelImpl.size() so
[RandomAccess]File[Descriptor] worked again for anything that wanted to
get the size/length of a file. (See email to commit-classpath.)

The other was because of a bug in jamvm with overloaded native JNI
methods were one such method had no (parameter) signature
[FileChannelImpl_read()]. Patch attached. I hope Robert got this in time
to integrate with the upcoming jamvm 1.1.3 release.

Cheers,

Mark

--=-OoKHcXvlblXOetZDoJcL
Content-Disposition: inline; filename=dll.patch
Content-Type: text/x-patch; name=dll.patch; charset=iso-8859-1
Content-Transfer-Encoding: base64

LS0tIHNyYy9kbGwuYy5vcmlnCTIwMDQtMDMtMjYgMTY6Mzg6MjQuMDAwMDAwMDAwICswMTAwDQor
Kysgc3JjL2RsbC5jCTIwMDQtMDQtMTEgMTM6Mjk6NDcuMDAwMDAwMDAwICswMjAwDQpAQCAtMjk1
LDEzICsyOTYsMTEgQEANCiANCiAgICAgaWYoZnVuYyA9PSBOVUxMKSB7DQogICAgICAgICBjaGFy
ICptYW5nbGVkU2lnID0gbWFuZ2xlU2lnbmF0dXJlKG1iKTsNCi0gICAgICAgIGlmKCptYW5nbGVk
U2lnICE9ICdcMCcpIHsNCi0gICAgICAgICAgICBjaGFyICpmdWxseU1hbmdsZWQgPSAoY2hhciop
c3lzTWFsbG9jKHN0cmxlbihtYW5nbGVkKStzdHJsZW4obWFuZ2xlZFNpZykrMyk7DQotICAgICAg
ICAgICAgc3ByaW50ZihmdWxseU1hbmdsZWQsICIlc19fJXMiLCBtYW5nbGVkLCBtYW5nbGVkU2ln
KTsNCi0NCi0gICAgICAgICAgICBmdW5jID0gbG9va3VwTG9hZGVkRGxsczAoZnVsbHlNYW5nbGVk
KTsNCi0gICAgICAgICAgICBmcmVlKGZ1bGx5TWFuZ2xlZCk7DQotICAgICAgICB9DQorICAgICAg
ICBjaGFyICpmdWxseU1hbmdsZWQgPSAoY2hhciopc3lzTWFsbG9jKHN0cmxlbihtYW5nbGVkKStz
dHJsZW4obWFuZ2xlZFNpZykrMyk7DQorICAgICAgICBzcHJpbnRmKGZ1bGx5TWFuZ2xlZCwgIiVz
X18lcyIsIG1hbmdsZWQsIG1hbmdsZWRTaWcpOw0KKw0KKyAgICAgICAgZnVuYyA9IGxvb2t1cExv
YWRlZERsbHMwKGZ1bGx5TWFuZ2xlZCk7DQorICAgICAgICBmcmVlKGZ1bGx5TWFuZ2xlZCk7DQog
ICAgICAgICBmcmVlKG1hbmdsZWRTaWcpOw0KICAgICB9DQogICAgIGZyZWUobWFuZ2xlZCk7DQo=

--=-OoKHcXvlblXOetZDoJcL--

--=-vl/lcIKzaxd628D6pEFc
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAeUeGxVhZCJWr9QwRAh4XAKCdtEbgRMIf64zgWiMKGVmJ/ZfUwwCfbHus
uAfBDe2pOiBJPEIEonxJlS4=
=nDDX
-----END PGP SIGNATURE-----

--=-vl/lcIKzaxd628D6pEFc--




From MAILER-DAEMON Sun Apr 11 11:56:47 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BChKB-0004Ap-AK
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 11:56:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BChK6-00047a-7H
	for classpath@gnu.org; Sun, 11 Apr 2004 11:56:42 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BChJZ-0003rN-6c
	for classpath@gnu.org; Sun, 11 Apr 2004 11:56:41 -0400
Received: from [209.225.28.204] (helo=mxsf04.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BChJY-0003rG-Vk
	for classpath@gnu.org; Sun, 11 Apr 2004 11:56:09 -0400
Received: from InterJet.dellroad.org (E6V6Q8.cpe.mvllo.al.charter.com
	[24.196.29.251])
	by mxsf04.cluster1.charter.net (8.12.11/8.12.11) with ESMTP id
	i3BFj6Wi007863; Sun, 11 Apr 2004 11:45:06 -0400 (EDT)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id KAA92722;
	Sun, 11 Apr 2004 10:44:17 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i3BFiGuI040299; 
	Sun, 11 Apr 2004 10:44:16 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3BFiGbN040298;
	Sun, 11 Apr 2004 10:44:16 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404111544.i3BFiGbN040298@arch20m.dellroad.org>
In-Reply-To: <200404110848.06673.zander@javalobby.org>
To: Thomas Zander <zander@javalobby.org>
Date: Sun, 11 Apr 2004 10:44:16 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=UNKNOWN-8BIT
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by
	mxsf04.cluster1.charter.net id i3BFj6Wi007863
Cc: GNU Classpath <classpath@gnu.org>, mauve-discuss@sources.redhat.com,
	Michael Koch <konqueror@gmx.de>
Subject: Re: Mauve patches.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 15:56:43 -0000

Thomas Zander wrote:
> On Thursday 08 April 2004 21:56, Andrew Haley wrote:
> > =A0> > I'd really like to see my stuff committed, or commented on if =
just
> > =A0> > committing is unacceptable.
> ...
> > I was intending to do it at the start of this week, sorry.
>=20
> Its next week now; so your schedule was probably too full. (No offence!=
)
>=20
> I hope you'll agree that its more important to have people creating pat=
ches=20
> and moving the project forward then to always have a 100% correct CVS.=20
> (problems can be fixed post-commit)
> In that case; what about providing me with a writable CVS account so I=20
> won't have to bother you anymore.

Me too :-)

-Archie

_________________________________________________________________________=
_
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.co=
m



From MAILER-DAEMON Sun Apr 11 12:07:17 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BChUL-0003ky-DR
	for mharc-classpath@gnu.org; Sun, 11 Apr 2004 12:07:17 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BChUI-0003iO-EG
	for classpath@gnu.org; Sun, 11 Apr 2004 12:07:14 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BChTk-0002s1-Rj
	for classpath@gnu.org; Sun, 11 Apr 2004 12:07:12 -0400
Received: from [209.225.28.218] (helo=mxsf18.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BChTj-0002p7-4N
	for classpath@gnu.org; Sun, 11 Apr 2004 12:06:39 -0400
Received: from InterJet.dellroad.org (E6V6Q8.cpe.mvllo.al.charter.com
	[24.196.29.251])
	by mxsf18.cluster1.charter.net (8.12.11/8.12.11) with ESMTP id
	i3BG03Ql003021; Sun, 11 Apr 2004 12:00:03 -0400 (EDT)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id KAA92791;
	Sun, 11 Apr 2004 10:49:53 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i3BFnquI040453; 
	Sun, 11 Apr 2004 10:49:52 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3BFnq52040452;
	Sun, 11 Apr 2004 10:49:52 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404111549.i3BFnq52040452@arch20m.dellroad.org>
In-Reply-To: <93607480.1081689891@[192.168.1.4]>
To: Patrik Reali <reali@acm.org>
Date: Sun, 11 Apr 2004 10:49:52 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: classpath@gnu.org
Subject: Re: Q: How do you keep your sources in synch?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2004 16:07:15 -0000

Patrik Reali wrote:
> I was wondering, how the various VM deal with changes in the classpath code 
> (I assume you have a "customized" version of classpath). Are you importing 
> them by hand or rely on some automated tool?
> 
> Before being able to use classpath out of the box, I relied on cvs (cvs 
> import and cvs checkout -jOLDVERSION -jNEWVERSION), which worked well as 
> long as the differences were not to big.
> 
> What is your experience?

JC overrides several Classpath classes. Each upgrade is pretty much
done by hand by examining the diffs and merging in the new stuff.
I try to keep the CP <-> JC patch as small as possible to ease
future merges.

This was especially fun for 0.07 -> 0.08 because somebody rearranged
the order of all the methods in Class.java and Thread.java :-)

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Mon Apr 12 00:46:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCtKk-0001Yd-Le
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 00:46:10 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCt6K-0004xU-Li
	for classpath@gnu.org; Mon, 12 Apr 2004 00:31:16 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCt5e-0004ik-H5
	for classpath@gnu.org; Mon, 12 Apr 2004 00:30:35 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BCt3m-0003Sb-KC
	for classpath@gnu.org; Mon, 12 Apr 2004 00:28:38 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BCool-0000zw-B2
	for classpath@gnu.org; Sun, 11 Apr 2004 19:56:51 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BCokS-0001ye-00; Mon, 12 Apr 2004 01:52:24 +0200
From: Mark Wielaard <mark@klomp.org>
To: tromey@redhat.com
In-Reply-To: <1081118952.7548.253.camel@elsschot.wildebeest.org>
References: <1080236148.18716.161.camel@elsschot.wildebeest.org>
	<87wu58qpmw.fsf@fleche.redhat.com>
	<1080295746.18716.463.camel@elsschot.wildebeest.org>
	<200403261128.55981.konqueror@gmx.de>
	<1080301292.18716.480.camel@elsschot.wildebeest.org>
	<871xn8h9mt.fsf@fleche.redhat.com>
	<1081118952.7548.253.camel@elsschot.wildebeest.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-xywm1oz74zEyFQtGC3+X"
Message-Id: <1081727546.13170.542.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 12 Apr 2004 01:52:27 +0200
Cc: classpath@gnu.org, java-patches@gcc.gnu.org,
	Michael Koch <konqueror@gmx.de>
Subject: Re: gtk-peer compile fixes for gcc-2.95
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 04:46:03 -0000


--=-xywm1oz74zEyFQtGC3+X
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2004-04-05 at 00:49, Mark Wielaard wrote:
> > We set CFLAGS to -g in a specific case, that is sort of different
> > since it claims to work around bugs in the infamous gcc "2.96".  I'd
> > prefer we avoid this in general.
>=20
> I have just removed this for now.
> Will test on a system with 2.96 when I can.

OK, finally had time to test it on gcc 3.3.3 and 2.95 (Debian GNU/Linux
unstable, 686) and gcc 3.2.2 and 2.96 (Red Hat 9, 686). Test results
were the same whether or not the native JNI libraries were compiled with
or without -O2. So I will now remove this CFLAGS clobbering.
Also had to remove the -std=3Dc89 option to AM_CFLAGS because gcc-2.95 has
a bug when -ansi and -std=3Dc89 are simultaneously defined. This should
not be a real issue though since -ansi implies ISO C90 (for 2.95, 2.96,
3.2.2 and 3.3.3 at least).

2004-04-11  Mark Wielaard  <mark@klomp.org>

        * configure.ac (CFLAGS): Remove definition.
        (AM_CFLAGS): Remove -std=3Dc89 option.

Cheers,

Mark

P.S. The flakiness of the [Server]SocketTests in Mauve make comparing
tests result much harder then it should be :{
=20

diff -u -r1.16 configure.ac
--- configure.ac        9 Apr 2004 17:35:56 -0000       1.16
+++ configure.ac        11 Apr 2004 23:29:56 -0000
@@ -115,17 +115,12 @@
   dnl FIXME - does not allow cross compiling
   AC_C_BIGENDIAN
 =20
-  dnl We want to avoid -O2 at the moment, gcc 2.96 from Red Hat 7
-  dnl cannot compile some native functions (gcc errors) with this
-  dnl flag.
-  CFLAGS=3D"-g"
-
   dnl We want warnings, lots of warnings :-)
   AM_CFLAGS=3D
   if test "x${GCC}" =3D xyes; then
     dnl We want ISO C90 pedantic ansi, but with longlong (jlong) support
     dnl and modern POSIX and BSD C library funtions/prototypes.
-    AM_CFLAGS=3D'-ansi -std=3Dc89 -pedantic -Wall -Wno-long-long -D_BSD_SO=
URCE'
+    AM_CFLAGS=3D'-ansi -pedantic -Wall -Wno-long-long -D_BSD_SOURCE'
   fi
   AC_SUBST(AM_CFLAGS)
 =20


--=-xywm1oz74zEyFQtGC3+X
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAedo5xVhZCJWr9QwRAuzPAJ98tV7Ss3d/RXGbvDpg0NDUXW1aVACfTMVO
fbUzKv4OxGnbtVJAPL7nnPI=
=5VXb
-----END PGP SIGNATURE-----

--=-xywm1oz74zEyFQtGC3+X--




From MAILER-DAEMON Mon Apr 12 06:17:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BCyVI-0001O0-FJ
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 06:17:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BCyVF-0001MG-1I
	for classpath@gnu.org; Mon, 12 Apr 2004 06:17:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BCyV3-0001Gh-Mv
	for classpath@gnu.org; Mon, 12 Apr 2004 06:17:10 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCyV2-0001FD-Ue
	for classpath@gnu.org; Mon, 12 Apr 2004 06:17:09 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BCzQz-0003ev-00; Mon, 12 Apr 2004 13:17:01 +0200
From: Mark Wielaard <mark@klomp.org>
To: Patrik Reali <reali@acm.org>
In-Reply-To: <93607480.1081689891@[192.168.1.4]>
References: <93607480.1081689891@[192.168.1.4]>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Lt0N2QvV+AGdYpwO8TVP"
Message-Id: <1081768623.13170.557.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 12 Apr 2004 13:17:04 +0200
Cc: classpath@gnu.org
Subject: Re: Q: How do you keep your sources in synch?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 10:17:22 -0000


--=-Lt0N2QvV+AGdYpwO8TVP
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Patrik,

On Sun, 2004-04-11 at 13:24, Patrik Reali wrote:
> I'd like to add this topic to the FAQ, thus I'm looking for hard evidence=
=20
> on this topic.

Thanks for asking this question. It is good to know how precisely the
different projects are using GNU Classpath to create more fully featured
development environments.

> I was wondering, how the various VM deal with changes in the classpath co=
de=20
> (I assume you have a "customized" version of classpath). Are you importin=
g=20
> them by hand or rely on some automated tool?

One interesting approach is libgcj which is almost always trying to bee
as synchronized as possible with GNU Classpath CVS. They have a script
that runs daily which produces a (colored) differences overview
(including patch/diffs). They also put in special markers into the
source for gcj specific changes that the script recognizes.

Script can be found at:
http://savannah.gnu.org/cgi-bin/viewcvs/gcc/wwwdocs/bin/gen-classpath-compa=
re

Daily updated result:
http://gcc.gnu.org/java/libgcj-classpath-compare.html

When something changes a note is automatically send to the mailinglist:
http://gcc.gnu.org/ml/java-patches/current/

Cheers,

Mark

--=-Lt0N2QvV+AGdYpwO8TVP
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAenquxVhZCJWr9QwRAg8YAJ4rSvG5tK1gck0IOuIQLG3EZuDSUwCgqk2L
PygeUUIm9xQ04K+3w92Emcs=
=lS/u
-----END PGP SIGNATURE-----

--=-Lt0N2QvV+AGdYpwO8TVP--




From MAILER-DAEMON Mon Apr 12 08:54:16 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD0x5-0001gI-DP
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 08:54:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD0ws-0001dW-7V
	for classpath@gnu.org; Mon, 12 Apr 2004 08:54:02 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD0wp-0001aA-47
	for classpath@gnu.org; Mon, 12 Apr 2004 08:54:00 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BD0wo-0001ZN-7c
	for classpath@gnu.org; Mon, 12 Apr 2004 08:53:58 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BD1sg-00044g-00; Mon, 12 Apr 2004 15:53:46 +0200
From: Mark Wielaard <mark@klomp.org>
To: Stephen Crawley <crawley@dstc.edu.au>
In-Reply-To: <200404081644.i38GiZmT002491@piglet.dstc.edu.au>
References: <200404081644.i38GiZmT002491@piglet.dstc.edu.au>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-uzTlk4bhwdtM+kVPMrrs"
Message-Id: <1081778028.13170.623.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 12 Apr 2004 15:53:48 +0200
Cc: classpath@gnu.org
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 12:54:03 -0000


--=-uzTlk4bhwdtM+kVPMrrs
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2004-04-08 at 18:44, Stephen Crawley wrote:
> The testcase now runs clean for JDK 1.4.2 as well as Kissme/Classpath
> from CVS.

Thanks a lot for that!

> The interesting thing is that the test run 200 times faster with JDK 1.4.=
2
> than with Kissme.  Yes TWO HUNDRED TIMES!
> [...]
> Question: what figures do people get with other open source VMs?

There are quite some differences between the free runtime environments.
(Total) running time goes from 1.2 seconds (native gcj) to 1.5 minutes
(kissme). This is on a AMD Athlon XP 1600+ (1.4 Ghz).
Note the interesting differences between the load, test and total time.
All times are best of three runs.

(gij 3.3.3)
$ time echo gnu.testlet.java.lang.Character.unicode | gij gnu.testlet.Simpl=
eTestHarness -debug
Reading unicode database...
done
Benchmark : load:1236ms   tests:5646ms
0 of 3578944 tests failed
=20
real    0m7.141s
user    0m6.687s
sys     0m0.068s

(Kissme from CVS a few weeks ago)
$ time echo gnu.testlet.java.lang.Character.unicode | ~/src/kissme/useful_s=
cripts/kissme gnu.testlet.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:11434ms   tests:81436ms
0 of 3578944 tests failed
=20
real    1m33.086s
user    1m30.842s
sys     0m0.499s

(Native compiled mauve with gcj 3.3.3 -O2)
$ time echo gnu.testlet.java.lang.Character.unicode | ./mauve-native -debug
Reading unicode database...
done
Benchmark : load:594ms   tests:386ms
0 of 3578944 tests failed
=20
real    0m1.211s
user    0m0.906s
sys     0m0.041s

(prototype Jikes RVM 2.3.2, don't have a development build handy.)
$ time echo gnu.testlet.java.lang.Character.unicode | rvm gnu.testlet.Simpl=
eTestHarness -debug
Reading unicode database...
done
Benchmark : load:1703ms   tests:1292ms
0 of 3578944 tests failed
=20
real    0m6.169s
user    0m3.637s
sys     0m0.232s

(JamVM 1.1.2 with some local patches - that shouldn't impact runtime speed.=
)
$ time echo gnu.testlet.java.lang.Character.unicode | jamvm gnu.testlet.Sim=
pleTestHarness -debug
Reading unicode database...
done
Benchmark : load:3927ms   tests:7478ms
0 of 3578944 tests failed
=20
real    0m11.572s
user    0m10.721s
sys     0m0.447s

(SableVM 1.1.2-pre as posted by Grzegorz on Planet Classpath yesterday.)
$ time echo gnu.testlet.java.lang.Character.unicode | sablevm -Y gnu.testle=
t.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:2296ms   tests:6114ms
0 of 3578944 tests failed
=20
real    0m8.714s
user    0m8.186s
sys     0m0.067s

(Kaffe 1.1.4 Just-in-time v3)
$ time echo gnu.testlet.java.lang.Character.unicode | kaffe gnu.testlet.Sim=
pleTestHarness -debug
Reading unicode database...
done
Benchmark : load:1080ms   tests:618ms
0 of 3578944 tests failed
=20
real    0m1.985s
user    0m1.622s
sys     0m0.067s

(IKVM.NET 1.0.1549.20346 [latest snaphot]
 with Mono JIT compiler version 0.31)
$ time echo gnu.testlet.java.lang.Character.unicode | mono ikvm.exe gnu.tes=
tlet.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:2725ms   tests:1393ms
0 of 3578944 tests failed
=20
real    0m5.656s
user    0m0.075s
sys     0m0.013s


--=-uzTlk4bhwdtM+kVPMrrs
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAep9rxVhZCJWr9QwRAtLyAJ4q5i2hINlInyOYufHlzX2Ag4ptkACgnO6i
gwqibKzJz72K1ZjV13jUIV8=
=95GF
-----END PGP SIGNATURE-----

--=-uzTlk4bhwdtM+kVPMrrs--




From MAILER-DAEMON Mon Apr 12 09:44:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD1k9-0007Qq-Bm
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 09:44:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD1k2-0007AE-6M
	for classpath@gnu.org; Mon, 12 Apr 2004 09:44:50 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD1jr-0006mD-Ub
	for classpath@gnu.org; Mon, 12 Apr 2004 09:44:43 -0400
Received: from [32.97.182.101] (helo=e1.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BD1jk-0004zt-Vf
	for classpath@gnu.org; Mon, 12 Apr 2004 09:44:33 -0400
Received: from northrelay02.pok.ibm.com (northrelay02.pok.ibm.com
	[9.56.224.150])
	by e1.ny.us.ibm.com (8.12.10/NS PXFA) with ESMTP id i3CEhYDX308550
	for <classpath@gnu.org>; Mon, 12 Apr 2004 10:43:34 -0400
Received: from d01ml604.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by northrelay02.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id
	i3CEhWIi137182
	for <classpath@gnu.org>; Mon, 12 Apr 2004 10:43:33 -0400
In-Reply-To: <1081778028.13170.623.camel@elsschot.wildebeest.org>
To: classpath@gnu.org
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
X-MIMETrack: S/MIME Sign by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/12/2004 10:41:05 AM,
	Serialize by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/12/2004 10:41:05 AM,
	Serialize complete at 04/12/2004 10:41:05 AM,
	S/MIME Sign failed at 04/12/2004 10:41:05 AM: The cryptographic key was
	not found,
	Serialize by Router on D01ML604/01/M/IBM(Release 6.51HF87 | March 11,
	2004) at 04/12/2004 10:43:33,
	Serialize complete at 04/12/2004 10:43:33
Message-ID: <OF3ACDAF93.A7437E40-ON85256E74.00502604-85256E74.0050E3F8@us.ibm.com>
Date: Mon, 12 Apr 2004 10:43:31 -0400
Content-Type: multipart/alternative;
	boundary="=_alternative 0050AA9585256E74_="
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 13:44:53 -0000

This is a multipart message in MIME format.
--=_alternative 0050AA9585256E74_=
Content-Type: text/plain; charset="US-ASCII"

Development Jikes RVM can take a while to build, but does buy some 
performance.  Probably not worth it for classpath development or mauve 
tests, but if you want to run some apps it can pay off.   I have prototype 
and development 2.3.2 images sitting around on my machine, so just for 
fun. 

prototype:
[dgrove@angmar mauve]$ time echo gnu.testlet.java.lang.Character.unicode | 
rvm gnu.testlet.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:1580ms   tests:796ms
0 of 3578944 tests failed

development
[dgrove@angmar mauve]$ time echo gnu.testlet.java.lang.Character.unicode | 
rvm gnu.testlet.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:564ms   tests:700ms
0 of 3578944 tests failed

About 10% on the tests; About 3x on the load phase. 

--dave
--=_alternative 0050AA9585256E74_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">Development Jikes RVM can take a while
to build, but does buy some performance. &nbsp;Probably not worth it for
classpath development or mauve tests, but if you want to run some apps
it can pay off. &nbsp; I have prototype and development 2.3.2 images sitting
around on my machine, so just for fun. </font>
<br>
<br><font size=2 face="sans-serif">prototype:</font>
<br><font size=2 face="sans-serif">[dgrove@angmar mauve]$ time echo gnu.testlet.java.lang.Character.unicode
| rvm gnu.testlet.SimpleTestHarness -debug</font>
<br><font size=2 face="sans-serif">Reading unicode database...</font>
<br><font size=2 face="sans-serif">done</font>
<br><font size=2 face="sans-serif">Benchmark : load:1580ms &nbsp; tests:796ms</font>
<br><font size=2 face="sans-serif">0 of 3578944 tests failed</font>
<br>
<br><font size=2 face="sans-serif">development</font>
<br><font size=2 face="sans-serif">[dgrove@angmar mauve]$ time echo gnu.testlet.java.lang.Character.unicode
| rvm gnu.testlet.SimpleTestHarness -debug</font>
<br><font size=2 face="sans-serif">Reading unicode database...</font>
<br><font size=2 face="sans-serif">done</font>
<br><font size=2 face="sans-serif">Benchmark : load:564ms &nbsp; tests:700ms</font>
<br><font size=2 face="sans-serif">0 of 3578944 tests failed</font>
<br>
<br><font size=2 face="sans-serif">About 10% on the tests; About 3x on
the load phase. </font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
--=_alternative 0050AA9585256E74_=--



From MAILER-DAEMON Mon Apr 12 09:48:40 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD1nk-0001Rm-0f
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 09:48:40 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD1na-0001P8-Tx
	for classpath@gnu.org; Mon, 12 Apr 2004 09:48:30 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD1nY-0001NJ-2l
	for classpath@gnu.org; Mon, 12 Apr 2004 09:48:29 -0400
Received: from [209.225.28.211] (helo=mxsf11.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BD1nX-0001M6-Ep
	for classpath@gnu.org; Mon, 12 Apr 2004 09:48:27 -0400
Received: from InterJet.dellroad.org (E6V6Q8.cpe.mvllo.al.charter.com
	[24.196.29.251])
	by mxsf11.cluster1.charter.net (8.12.11/8.12.11) with ESMTP id
	i3CEU2j5084851; Mon, 12 Apr 2004 10:30:03 -0400 (EDT)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id JAA05128;
	Mon, 12 Apr 2004 09:19:07 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i3CEJ6uI029463; 
	Mon, 12 Apr 2004 09:19:06 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3CEJ6gM029462;
	Mon, 12 Apr 2004 09:19:06 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404121419.i3CEJ6gM029462@arch20m.dellroad.org>
In-Reply-To: <1081778028.13170.623.camel@elsschot.wildebeest.org>
To: Mark Wielaard <mark@klomp.org>
Date: Mon, 12 Apr 2004 09:19:06 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: Stephen Crawley <crawley@dstc.edu.au>, classpath@gnu.org
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 13:48:32 -0000

Mark Wielaard wrote:
> There are quite some differences between the free runtime environments.

Here are some results from JC, although this is on a much faster machine
(Intel(R) Pentium(R) 4 CPU 2.40GHz):

  $ time echo gnu.testlet.java.lang.Character.unicode | jc gnu.testlet.SimpleTestHarness -debug
  Reading unicode database...
  done
  Benchmark : load:1734ms   tests:402ms
  0 of 3578944 tests failed

  real    0m2.760s
  user    0m1.970s
  sys     0m0.780s

JC was configured with "--disable-assertions".

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Mon Apr 12 10:10:22 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD28k-00049A-1n
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 10:10:22 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD28h-000481-Ut
	for classpath@gnu.org; Mon, 12 Apr 2004 10:10:19 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD28g-00046G-9i
	for classpath@gnu.org; Mon, 12 Apr 2004 10:10:19 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BD28f-00045P-Kz
	for classpath@gnu.org; Mon, 12 Apr 2004 10:10:17 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BD34f-0004Kj-00
	for <classpath@gnu.org>; Mon, 12 Apr 2004 17:10:13 +0200
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
In-Reply-To: <1081778028.13170.623.camel@elsschot.wildebeest.org>
References: <200404081644.i38GiZmT002491@piglet.dstc.edu.au>
	<1081778028.13170.623.camel@elsschot.wildebeest.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-sYewM6c42pHKyNeu+fW+"
Message-Id: <1081782615.13170.635.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 12 Apr 2004 17:10:15 +0200
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 14:10:20 -0000


--=-sYewM6c42pHKyNeu+fW+
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2004-04-12 at 15:53, Mark Wielaard wrote:
> There are quite some differences between the free runtime environments.
> (Total) running time goes from 1.2 seconds (native gcj) to 1.5 minutes
> (kissme). This is on a AMD Athlon XP 1600+ (1.4 Ghz).
> Note the interesting differences between the load, test and total time.
> All times are best of three runs.

Since a picture says more then a bunch of numbers:
http://www.klomp.org/mark/free-vm-benchmarks/getallen.html

Sorry, I left out kissme because it was so much slower then the rest.
Interesting to see how much time each runtime spend in loading, testing
and overhead. Hope I have time next week to update it with at least rvm
development results and maybe IKVM ahead of time results (Jeroen, any
hints on how to do that in this case?)

Caution! This is a micro-benchmark for one very specialized small and
repetitive task, so don't take the number to serious.

Cheers,

Mark

--=-sYewM6c42pHKyNeu+fW+
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAerFWxVhZCJWr9QwRAoNfAJ9NHLZ7z9TPRPs6RMXadsNQf6eZEACfYno0
fmpqVhZIoJ1H/DSelvsTdug=
=+9gk
-----END PGP SIGNATURE-----

--=-sYewM6c42pHKyNeu+fW+--




From MAILER-DAEMON Mon Apr 12 10:33:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD2V2-0002eW-Ik
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 10:33:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD2Uy-0002c9-Pc
	for classpath@gnu.org; Mon, 12 Apr 2004 10:33:20 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD2Ux-0002bl-5p
	for classpath@gnu.org; Mon, 12 Apr 2004 10:33:19 -0400
Received: from [209.152.205.226] (helo=NR-EXCHANGE.netreach.core)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BD2Uw-0002bg-Vd
	for classpath@gnu.org; Mon, 12 Apr 2004 10:33:19 -0400
Received: from netreach.com ([209.152.205.123]) by NR-EXCHANGE.netreach.core
	with Microsoft SMTPSVC(6.0.3790.0); Mon, 12 Apr 2004 11:35:00 -0400
Message-ID: <407AB6A8.8060003@netreach.com>
Date: Mon, 12 Apr 2004 11:32:56 -0400
From: Stuart Ballard <sballard@netreach.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.5) Gecko/20031107 Debian/1.5-3
X-Accept-Language: en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <200404081644.i38GiZmT002491@piglet.dstc.edu.au>	<1081778028.13170.623.camel@elsschot.wildebeest.org>
	<1081782615.13170.635.camel@elsschot.wildebeest.org>
In-Reply-To: <1081782615.13170.635.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 12 Apr 2004 15:35:00.0114 (UTC)
	FILETIME=[B75A8F20:01C420A3]
Cc: classpath@gnu.org
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 14:33:21 -0000

Mark Wielaard wrote:
> and overhead. Hope I have time next week to update it with at least rvm
> development results and maybe IKVM ahead of time results (Jeroen, any
> hints on how to do that in this case?)

I don't know whether you have a zip/jar or individual classfiles but 
assuming it's a single jar file, presumably it would be (commands 
separated by blank lines - ignore any mailer-induced wordwrapping):

mono ikvmc.exe -target:exe -out:mauve.exe -reference:classpath.dll 
-main:gnu.testlet.SimpleTestHarness mauve.jar

time echo gnu.testlet.java.lang.Character.unicode | mono mauve.exe -debug

You may need to arrange for all IKVM's DLLs to be in the same directory 
as mauve.exe. The other thing to try would be using Mono's --aot option 
to pre-JIT (as it were) the generated exe and dlls. I've never tried 
this but in theory it appears that you should be able to do:

mono --aot mauve.exe
(and possibly also:
mono --aot classpath.dll
mono --aot IK.VM.NET.dll
etc...)

prior to running mauve.exe itself.

Of course, I'm not Jeroen and I could be missing something significant...

Stuart.

-- 
Stuart Ballard, Senior Web Developer
NetReach, Inc.
(215) 283-2300, ext. 126
http://www.netreach.com/




From MAILER-DAEMON Mon Apr 12 10:35:14 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD2Wo-00038i-1g
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 10:35:14 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD2WZ-00034M-Dy
	for classpath@gnu.org; Mon, 12 Apr 2004 10:34:59 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD2WS-00032S-KE
	for classpath@gnu.org; Mon, 12 Apr 2004 10:34:53 -0400
Received: from [32.97.182.101] (helo=e1.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BD2WR-00031t-S9
	for classpath@gnu.org; Mon, 12 Apr 2004 10:34:51 -0400
Received: from northrelay04.pok.ibm.com (northrelay04.pok.ibm.com
	[9.56.224.206])
	by e1.ny.us.ibm.com (8.12.10/NS PXFA) with ESMTP id i3CFYuDX310418
	for <classpath@gnu.org>; Mon, 12 Apr 2004 11:34:56 -0400
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay04.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id
	i3CFZIMc079036; Mon, 12 Apr 2004 11:35:19 -0400
To: jikesrvm-researchers@www-124.ibm.com, jikesrvm-announce@www-124.ibm.com,
	classpath@gnu.org
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
X-MIMETrack: S/MIME Sign by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/12/2004 11:34:19 AM,
	Serialize by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/12/2004 11:34:19 AM,
	Serialize complete at 04/12/2004 11:34:19 AM,
	S/MIME Sign failed at 04/12/2004 11:34:19 AM: The cryptographic key was
	not found,
	Serialize by Router on D01ML604/01/M/IBM(Release 6.51HF87 | March 11,
	2004) at 04/12/2004 11:34:54,
	Serialize complete at 04/12/2004 11:34:54
Message-ID: <OF84C2976A.0331FA30-ON85256E74.0052DD6C-85256E74.0055979C@us.ibm.com>
Date: Mon, 12 Apr 2004 11:34:53 -0400
Content-Type: multipart/alternative;
	boundary="=_alternative 00558A5B85256E74_="
Cc: 
Subject: Jikes RVM 2.3.2 is now available
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 14:35:01 -0000

This is a multipart message in MIME format.
--=_alternative 00558A5B85256E74_=
Content-Type: text/plain; charset="US-ASCII"

Jikes RVM 2.3.2 is now available from the developerworks web site (
http://www-124.ibm.com/developerworks/oss/jikesrvm/). 

The release notes are appended below.  Of particular note is that of 
version 2.3.2 it is possible to build Jikes RVM entirely with free 
software tools. 

*Highlights of this release include:

** Jikes RVM 2.3.2 requires classpath 0.08.

**64-bit port of baseline compiler and runtime system to PowerPC64/AIX is
complete. We have been passing all regression tests on PPC64/AIX for
over a month. NOTE: porting of the optimizing compiler has not yet begun
(contributions/collaborations welcome) and therefore no configuration
with the optimizing compiler will work in 64 bit mode.

** The default GC plan for the prototype, prototype-opt, development,
and production configurations has been changed from CopyMS to GenMS.
GenMS is a generational collector with an Appel-style nursery and a
mark-sweep mature space.

** Jikes RVM now runs on newer versions of Linux/PowerPC that store the
pthread id in R2. Building Jikes RVM with 
RVM_FOR_SINGLE_VIRTUAL_PROCESSOR=0
is reported to work on top of these newer Linux releases, which resolves a
long-standing limitation of Jikes RVM on Linux/PowerPC.

**Source Code editing support
There are now VIM and Emacs style files supporting the Jikes RVM coding
style for C, Java, and C++. See rvm/etc/README. (This should have
been in the 2.3.1 release announcement but was not.)

**You can build Jikes RVM entirely with free software tools
You can now build Jikes RVM using the Kaffe virtual machine. Details
in the installation section in the user's guide.

*Other notes:

**Performance improvements in VM_Memory copying routines used by
System.arraycopy and copying GC resulted in 10% improvement in
SPECjbb2000 throughput.

*Bug Fixes:
** Fixed problems in alignment support in JMTk that were causing crashes
in GC on PowerPC/AIX when doubleword alignment of long[] and double[]
was enabled. This is a bug that was introduced in version 2.3.1 and is
fixed in 2.3.2.

** Fixed performance problem in profile-directed inlining where the
AI Organizer forces recompilation of methods in an attempt to inline
runtime service routines that won't be inlined no matter how many
times we try. Problem has always existed, but became much more severe
in 2.3.0 release when we disabled the inlining of allocation sequences
if the size of the object was not known at compile time.

** Fixed bug in which non-virtualizable interface calls where not being
considered as candidates for feedback-directed inlining.

** We now provide all of the mandatory system properties
for the Java 1.4.2 API.

** Fixed bug in which the time zone code always thought
the user was on New York time.

** We now can print a meaningful message when we get
an ErrorInInitializerError in the early stages of booting the VM
before it is able to load in new classes. We had incorrectly left
ErrorInInitializerError out of the VM's list of boot classes.

** If an uncaught exception is thrown while booting,
we no longer try to print to the uninitialized System.err stream.
That used to trigger a NullPointerException.

--=_alternative 00558A5B85256E74_=
Content-Type: text/html; charset="US-ASCII"


<table width=100%>
<tr valign=top>
<td width=100%><font size=3 face="Arial">Jikes RVM 2.3.2 is now available
from the developerworks web site (</font><a href="http://www-124.ibm.com/developerworks/oss/jikesrvm/" target=_blank><font size=3 color=#006699 face="Arial"><u>http://www-124.ibm.com/developerworks/oss/jikesrvm/</u></font></a><font size=3 face="Arial">).
<br>
<br>
The release notes are appended below. &nbsp;Of particular note is that
of version 2.3.2 it is possible to build Jikes RVM entirely with free software
tools. </font>
<br><font size=3 face="Arial"><br>
*Highlights of this release include:<br>
<br>
** Jikes RVM 2.3.2 requires classpath 0.08.<br>
<br>
**64-bit port of baseline compiler and runtime system to PowerPC64/AIX
is<br>
complete. We have been passing all regression tests on PPC64/AIX for<br>
over a month. NOTE: porting of the optimizing compiler has not yet begun<br>
(contributions/collaborations welcome) and therefore no configuration<br>
with the optimizing compiler will work in 64 bit mode.<br>
<br>
** The default GC plan for the prototype, prototype-opt, development,<br>
and production configurations has been changed from CopyMS to GenMS.<br>
GenMS is a generational collector with an Appel-style nursery and a<br>
mark-sweep mature space.<br>
<br>
** Jikes RVM now runs on newer versions of Linux/PowerPC that store the<br>
pthread id in R2. Building Jikes RVM with RVM_FOR_SINGLE_VIRTUAL_PROCESSOR=0<br>
is reported to work on top of these newer Linux releases, which resolves
a<br>
long-standing limitation of Jikes RVM on Linux/PowerPC.<br>
<br>
**Source Code editing support<br>
There are now VIM and Emacs style files supporting the Jikes RVM coding<br>
style for C, Java, and C++. See rvm/etc/README. (This should have<br>
been in the 2.3.1 release announcement but was not.)<br>
<br>
**You can build Jikes RVM entirely with free software tools<br>
You can now build Jikes RVM using the Kaffe virtual machine. Details<br>
in the installation section in the user's guide.<br>
<br>
*Other notes:<br>
<br>
**Performance improvements in VM_Memory copying routines used by<br>
System.arraycopy and copying GC resulted in 10% improvement in<br>
SPECjbb2000 throughput.<br>
<br>
*Bug Fixes:<br>
** Fixed problems in alignment support in JMTk that were causing crashes<br>
in GC on PowerPC/AIX when doubleword alignment of long[] and double[]<br>
was enabled. This is a bug that was introduced in version 2.3.1 and is<br>
fixed in 2.3.2.<br>
<br>
** Fixed performance problem in profile-directed inlining where the<br>
AI Organizer forces recompilation of methods in an attempt to inline<br>
runtime service routines that won't be inlined no matter how many<br>
times we try. Problem has always existed, but became much more severe<br>
in 2.3.0 release when we disabled the inlining of allocation sequences<br>
if the size of the object was not known at compile time.<br>
<br>
** Fixed bug in which non-virtualizable interface calls where not being<br>
considered as candidates for feedback-directed inlining.<br>
<br>
** We now provide all of the mandatory system properties<br>
for the Java 1.4.2 API.<br>
<br>
** Fixed bug in which the time zone code always thought<br>
the user was on New York time.<br>
<br>
** We now can print a meaningful message when we get<br>
an ErrorInInitializerError in the early stages of booting the VM<br>
before it is able to load in new classes. We had incorrectly left<br>
ErrorInInitializerError out of the VM's list of boot classes.<br>
<br>
** If an uncaught exception is thrown while booting,<br>
we no longer try to print to the uninitialized System.err stream.<br>
That used to trigger a NullPointerException.</font></table>
<br>
--=_alternative 00558A5B85256E74_=--



From MAILER-DAEMON Mon Apr 12 10:55:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD2m1-0003ic-8P
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 10:50:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD2lX-0003UD-VV
	for classpath@gnu.org; Mon, 12 Apr 2004 10:50:27 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD2lM-0003Pu-VW
	for classpath@gnu.org; Mon, 12 Apr 2004 10:50:18 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BD2lL-0003OO-Mn
	for classpath@gnu.org; Mon, 12 Apr 2004 10:50:15 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id b22b18ac_8c97_11d8_92fb_00304811e8c8_2295;
	Mon, 12 Apr 2004 10:40:16 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i3CFoImZ000871
	for <classpath@gnu.org>; Mon, 12 Apr 2004 10:50:18 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3CFoIa2000870
	for classpath@gnu.org; Mon, 12 Apr 2004 10:50:18 -0500 (CDT)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404121550.i3CFoIa2000870@arch20m.dellroad.org>
To: classpath@gnu.org
Date: Mon, 12 Apr 2004 10:50:18 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Subject: JC release 1.1
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 14:50:47 -0000

FYI,

JC version 1.1 is available. Changes from version 1.0.1 include:

  - New heap layout and GC algorithm:
    - Added support for object finalization.
    - Added support for soft, weak, and phantom references.
    - Improvements in tracing algorithm and GC statistics.
    - Fat locks are now recycled.
  - Updated for Classpath version 0.08.
  - Class loader memory is allocated in larger chunks.
  - Fixed some reflection bugs:
    - Accessibility is now being checked.
    - Interfaces were not being returned in declared order.
    - Inner classes sometimes had the wrong permissions.
  - Fixed some erroneous mutex assertions.
  - Fixed infinite loop when local native references exceeded.
  - Fixed some build problems.

Cheers,
-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Mon Apr 12 15:40:13 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD7Hv-0000EW-Vv
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 15:40:11 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD7Hh-0008PF-IA
	for classpath@gnu.org; Mon, 12 Apr 2004 15:39:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD7HZ-00087c-PN
	for classpath@gnu.org; Mon, 12 Apr 2004 15:39:51 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BD7HY-00084q-L6
	for classpath@gnu.org; Mon, 12 Apr 2004 15:39:48 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BD8DL-0005B0-00; Mon, 12 Apr 2004 22:39:31 +0200
From: Mark Wielaard <mark@klomp.org>
To: Christian Grothoff <grothoff@cs.purdue.edu>
In-Reply-To: <200403200104.38351.grothoff@cs.purdue.edu>
References: <200403200104.38351.grothoff@cs.purdue.edu>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-9x42rfLgSRK8nGFM9ZuZ"
Message-Id: <1081802373.13170.654.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Mon, 12 Apr 2004 22:39:33 +0200
Cc: classpath@gnu.org
Subject: Re: access modifier for FileDescriptor.setNativeFd(long)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 19:40:01 -0000


--=-9x42rfLgSRK8nGFM9ZuZ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-03-20 at 07:04, Christian Grothoff wrote:
> I'm currently porting parts of GNU classpath to OVM (http://www.ovmj.org)=
.  In=20
> the process I hit a problem with the access modifier of=20
> FileDescriptor.setNativeFd(long).  In order to avoid having to set that f=
ield=20
> using reflection, I would need that method to be default (currently priva=
te).=20
>=20
> I believe that change is generally the right thing to do. First, a privat=
e=20
> accessor method makes little sense anyway.  Also, in a similar context th=
e=20
> native_fd field in gnu.java.net.PlainSocketImpl is also package-scoped=20
> (default) (there is a tiny difference in that PlainSocketImpl does not us=
e=20
> accessor methods, but I don't think it matters either way).

I agree that these method/fields should be package private where
possible. It helps several execution environments easier access to these
(more or less vm specific) things.  CNI for example will make package
private fields/methods accessible to C++ code. And when you do
everything in java then adding a class to the package will make it
possible to manipulate these things easily without having to go through
reflection or JNI).  With all the restructuring of java.io (through
java.nio) going on your patch is not applicable anymore.  Could you
check that the new setup?  Just saw this patch from Jeroen which might
bite you:

2004-04-09  Jeroen Frijters  <jeroen@frijters.net>

    * gnu/java/nio/channels/FileChannelImpl.java (fd, mode): Made
    private.
    [...]

Jeroen, was there a particular reason to make these things private here?
(I admit to not having studied this code very hard, so maybe the
similarity with the FileDescriptor setup is not one-on-one.)

Cheers,

Mark

--=-9x42rfLgSRK8nGFM9ZuZ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAev6FxVhZCJWr9QwRArpdAJwJOgkbbB7kdRkEKDHOp5atCiRn6wCggjMi
KiPlvb9yAkvKQRxebYlY23I=
=d8n1
-----END PGP SIGNATURE-----

--=-9x42rfLgSRK8nGFM9ZuZ--




From MAILER-DAEMON Mon Apr 12 16:37:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BD8BL-0001R0-PJ
	for mharc-classpath@gnu.org; Mon, 12 Apr 2004 16:37:27 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BD8BG-0001HM-0W
	for classpath@gnu.org; Mon, 12 Apr 2004 16:37:22 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BD8BB-0001Ac-SN
	for classpath@gnu.org; Mon, 12 Apr 2004 16:37:19 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BD8BB-0000wq-7a
	for classpath@gnu.org; Mon, 12 Apr 2004 16:37:17 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i3CLUATH007148
	for <classpath@gnu.org>; Mon, 12 Apr 2004 17:30:47 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004041217320616160
	for <classpath@gnu.org>; Mon, 12 Apr 2004 17:32:06 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i3CLSJ3J003959
	for <classpath@gnu.org>; Mon, 12 Apr 2004 17:28:19 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.30) id 1BD8yZ-0002tT-Im
	for classpath@gnu.org; Mon, 12 Apr 2004 17:28:19 -0400
Message-ID: <407B09EF.3050406@uqam.ca>
Date: Mon, 12 Apr 2004 17:28:15 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040402 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Subject: SableVM 1.1.3 Released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2004 20:37:24 -0000

Download
========

http://sourceforge.net/project/showfiles.php?group_id=5523&package_id=5567&release_id=230647


Changes
=======

- Cleaned up build process so that "./configure ; make ; make install"
   works out of the box for both sablevm-classpath (as it does for
   sablevm).


Notes
=====

To build SableVM, you must download both:
- sablevm-1.1.3.tar.gz
- sablevm-classpath-1.1.3.tar.gz

Then, you must run the following commands:

su
tar -xzf sablevm-1.1.3.tar.gz
cd sablevm-1.1.3
./configure && make && make install
cd ..
tar -xzf sablevm-classpath-1.1.3.tar.gz
cd sablevm-classpath-1.1.3
./configure && make && make install
exit

After this, SableVM will be installed in /usr/local.  To run it, assuming
you have a HelloWorld.class file in the current directory, you can type:

/usr/local/bin/java-sablevm HelloWorld

Enjoy!

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/







From MAILER-DAEMON Tue Apr 13 05:39:33 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDKOD-0007nY-Av
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 05:39:33 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDKOA-0007my-DM
	for classpath@gnu.org; Tue, 13 Apr 2004 05:39:30 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDKNd-0007Yu-IB
	for classpath@gnu.org; Tue, 13 Apr 2004 05:39:28 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDKNc-0007XD-Q9
	for classpath@gnu.org; Tue, 13 Apr 2004 05:38:56 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 13 Apr 2004 11:38:54 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: The Mauve unicode testcase and VM performance
Thread-Index: AcQgpJwNBdsVGm/sRMWz6vpXpFeXPQAjju+Q
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Stuart Ballard" <sballard@netreach.com>, "Mark Wielaard" <mark@klomp.org>
Cc: classpath@gnu.org
Subject: RE: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 09:39:31 -0000

Stuart Ballard wrote:
> Mark Wielaard wrote:
> > and overhead. Hope I have time next week to update it with=20
> at least rvm
> > development results and maybe IKVM ahead of time results=20
> (Jeroen, any
> > hints on how to do that in this case?)
>=20
> I don't know whether you have a zip/jar or individual classfiles but=20
> assuming it's a single jar file, presumably it would be (commands=20
> separated by blank lines - ignore any mailer-induced wordwrapping):
>=20
> mono ikvmc.exe -target:exe -out:mauve.exe -reference:classpath.dll=20
> -main:gnu.testlet.SimpleTestHarness mauve.jar

This is what I did:
#cd mauve
#mono ../ikvm/bin/ikvmc.exe -out:mauve.exe
-main:gnu.testlet.SimpleTestHarness `find | grep -v altered | grep
.*class$` -reference:../ikvm/bin/classpath.dll
#cp ../ikvm/bin/*.dll .
#time echo gnu.testlet.java.lang.Character.unicode | mono mauve.exe
-debug
Reading unicode database...
done
Benchmark : load:2151ms   tests:328ms
0 of 3578944 tests failed

real    0m2.979s
user    0m0.030s
sys     0m0.050s

On Windows I got:
C:\mauve>echo gnu.testlet.java.lang.Character.unicode| mono mauve.exe
-debug
Reading unicode database...
done
Benchmark : load:1763ms   tests:731ms
0 of 3578944 tests failed

C:\mauve>echo gnu.testlet.java.lang.Character.unicode| mauve.exe -debug
Reading unicode database...
done
Benchmark : load:180ms   tests:170ms
0 of 3578944 tests failed

C:\mauve>echo gnu.testlet.java.lang.Character.unicode| ikvm
gnu.testlet.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:180ms   tests:170ms
0 of 3578944 tests failed

So for the run time it doesn't make any difference if it is precompiled
or not, total time is a bit longer though (about 1.5 second versus 1.0
seconds).

Note also that IKVM running on the Microsoft framework is faster than
Hotspot (but overall elapsed time for Hotspot is less, about 0.7
seconds):
C:\mauve>echo gnu.testlet.java.lang.Character.unicode|
\j2re1.4.1\bin\java gnu.testlet.SimpleTestHarness -debug
Reading unicode database...
done
Benchmark : load:220ms   tests:250ms
0 of 3578944 tests failed

All tests are on a 1.7 GHz Pentium M, the Linux test was running in a
VMWare session.

> The other thing to try would be using Mono's --aot option=20
> to pre-JIT (as it were) the generated exe and dlls.

I couldn't get that to work.

Regards,
Jeroen



From MAILER-DAEMON Tue Apr 13 05:39:41 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDKOG-0007oo-Gw
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 05:39:36 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDKOD-0007nX-A5
	for classpath@gnu.org; Tue, 13 Apr 2004 05:39:33 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDKNf-0007Zm-97
	for classpath@gnu.org; Tue, 13 Apr 2004 05:39:31 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDKNd-0007XD-Sk
	for classpath@gnu.org; Tue, 13 Apr 2004 05:38:58 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 13 Apr 2004 11:38:54 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADD98@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: access modifier for FileDescriptor.setNativeFd(long)
Thread-Index: AcQgzp19NQzXVTjBQa6jyd3imy7R1AAZkkhQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Mark Wielaard" <mark@klomp.org>,
	"Christian Grothoff" <grothoff@cs.purdue.edu>
Cc: classpath@gnu.org
Subject: RE: access modifier for FileDescriptor.setNativeFd(long)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 09:39:34 -0000

Mark Wielaard wrote:
> 2004-04-09  Jeroen Frijters  <jeroen@frijters.net>
>=20
>     * gnu/java/nio/channels/FileChannelImpl.java (fd, mode): Made
>     private.
>     [...]
>=20
> Jeroen, was there a particular reason to make these things=20
> private here?
> (I admit to not having studied this code very hard, so maybe the
> similarity with the FileDescriptor setup is not one-on-one.)

No, you're right, I should have made it package private instead of
private. I'll fix it.

Regards,
Jeroen



From MAILER-DAEMON Tue Apr 13 09:09:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDNfC-0007eK-5X
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 09:09:18 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDNf9-0007dh-4o
	for classpath@gnu.org; Tue, 13 Apr 2004 09:09:15 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDNed-0007Ym-Hs
	for classpath@gnu.org; Tue, 13 Apr 2004 09:09:14 -0400
Received: from [64.4.37.42] (helo=hotmail.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDNed-0007YH-4p
	for classpath@gnu.org; Tue, 13 Apr 2004 09:08:43 -0400
Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC;
	Tue, 13 Apr 2004 06:08:38 -0700
Received: from 195.224.225.50 by by10fd.bay10.hotmail.msn.com with HTTP;
	Tue, 13 Apr 2004 13:08:38 GMT
X-Originating-IP: [195.224.225.50]
X-Originating-Email: [robert_lougher@hotmail.com]
X-Sender: robert_lougher@hotmail.com
From: "Robert Lougher" <robert_lougher@hotmail.com>
To: classpath@gnu.org
Bcc: 
Date: Tue, 13 Apr 2004 13:08:38 +0000
Mime-Version: 1.0
Content-Type: text/plain; format=flowed
Message-ID: <BAY10-F42g42rguTtuB0000c7ac@hotmail.com>
X-OriginalArrivalTime: 13 Apr 2004 13:08:38.0716 (UTC)
	FILETIME=[6FA54FC0:01C42158]
Subject: JamVM 1.1.3 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 13:09:15 -0000

Hi,

A quick post to say JamVM 1.1.3 has been released.  It's primarily another 
bug-fix release -- the release notes are at 
http://sourceforge.net/project/shownotes.php?release_id=230695.

Thanks to everybody on this list who provided feedback on 1.1.2 (in 
particular Mark Wielaard and Michael Koch).  BTW Stephane, I've added 
-bootclasspath/a and -bootclasspath/p, which should make working with 
Odonata easier!

Rob.

_________________________________________________________________
Find a cheaper internet access deal - choose one to suit you. 
http://www.msn.co.uk/internetaccess




From MAILER-DAEMON Tue Apr 13 10:05:16 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDOXL-0007HM-NJ
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 10:05:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDOXH-0007GQ-Rd
	for classpath@gnu.org; Tue, 13 Apr 2004 10:05:11 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDOFq-0001ph-43
	for classpath@gnu.org; Tue, 13 Apr 2004 09:47:41 -0400
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BDOBC-0000Ro-DR
	for classpath@gnu.org; Tue, 13 Apr 2004 09:42:22 -0400
Received: from localhost (localhost [127.0.0.1]) (uid 1000)
	by tangency.co.uk with local; Tue, 13 Apr 2004 14:36:34 +0100
Date: Tue, 13 Apr 2004 14:36:34 +0100
From: "S. Meslin-Weber" <twiun@adorphuye.com>
To: Robert Lougher <robert_lougher@hotmail.com>
Message-ID: <20040413133634.GU15152@tangency.co.uk>
References: <BAY10-F42g42rguTtuB0000c7ac@hotmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <BAY10-F42g42rguTtuB0000c7ac@hotmail.com>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Cc: classpath@gnu.org
Subject: Re: JamVM 1.1.3 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 14:05:12 -0000

> Thanks to everybody on this list who provided feedback on 1.1.2 (in 
> particular Mark Wielaard and Michael Koch).  BTW Stephane, I've added 
> -bootclasspath/a and -bootclasspath/p, which should make working with 
> Odonata easier!

Thanks Rob! I'll give it a spin today when I get home :) (must also
remember to test the latest SableVM too)

Stephane



From MAILER-DAEMON Tue Apr 13 11:14:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDPci-0006y0-CE
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 11:14:52 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDPcf-0006xF-BB
	for classpath@gnu.org; Tue, 13 Apr 2004 11:14:49 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDPZc-0005wG-QX
	for classpath@gnu.org; Tue, 13 Apr 2004 11:12:12 -0400
Received: from [64.4.37.80] (helo=hotmail.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDPSS-0004PX-BN
	for classpath@gnu.org; Tue, 13 Apr 2004 11:04:16 -0400
Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC;
	Tue, 13 Apr 2004 08:04:08 -0700
Received: from 195.224.225.50 by by10fd.bay10.hotmail.msn.com with HTTP;
	Tue, 13 Apr 2004 15:04:08 GMT
X-Originating-IP: [195.224.225.50]
X-Originating-Email: [robert_lougher@hotmail.com]
X-Sender: robert_lougher@hotmail.com
From: "Robert Lougher" <robert_lougher@hotmail.com>
To: brawer@dandelis.ch
Bcc: 
Date: Tue, 13 Apr 2004 15:04:08 +0000
Mime-Version: 1.0
Content-Type: text/plain; format=flowed
Message-ID: <BAY10-F80Bk7L0jRGjI0000cf5d@hotmail.com>
X-OriginalArrivalTime: 13 Apr 2004 15:04:08.0635 (UTC)
	FILETIME=[923308B0:01C42168]
Cc: classpath@gnu.org
Subject: Re: JamVM 1.1.3 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 15:14:50 -0000

Hi Sascha,

Yes, I know :)  I couldn't decide whether it was a good idea to slavishly 
follow Sun's options or not. The -X (as you're obviously aware) means 
"non-standard options", and includes -Xms and -Xmx which I also do not have 
an X in front of (as used to be in JDK 1.1.x).  Also, on Sun's VM, 
-classpath is specified as -classpath xxx:yyy whereas -Xbootclasspath is 
-Xbootclasspath:xxx:yyy which is (in my mind anyway) confusing.  On JamVM 
it's -bootclasspath xxx:yyy (added in 1.1.1), so I'd have had to change that 
as well.

CC'ing to the mailing list, as I'm interested in other people's opinions on 
this!

Rob.

----Original Message Follows----
From: Sascha Brawer <brawer@dandelis.ch>
To: Robert Lougher <robert_lougher@hotmail.com>
Subject: Re: JamVM 1.1.3 released
Date: Tue, 13 Apr 2004 15:30:07 +0200

Robert Lougher <robert_lougher@hotmail.com> wrote on Tue, 13 Apr 2004 13:
08:38 +0000:

 >particular Mark Wielaard and Michael Koch).  BTW Stephane, I've added
 >-bootclasspath/a and -bootclasspath/p, which should make working with
 >Odonata easier!

I guess you are aware that these are called -Xbootclasspath/a and
-Xbootclasspath/p on the Sun JVM, but if you're not, I just wanted
to tell...

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/

_________________________________________________________________
Stay in touch with absent friends - get MSN Messenger 
http://www.msn.co.uk/messenger




From MAILER-DAEMON Tue Apr 13 11:34:36 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDPvm-0003A8-96
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 11:34:34 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDPvX-0002wt-Uz
	for classpath@gnu.org; Tue, 13 Apr 2004 11:34:19 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDPrQ-00080V-AY
	for classpath@gnu.org; Tue, 13 Apr 2004 11:30:36 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BDPqm-0007LH-QY
	for classpath@gnu.org; Tue, 13 Apr 2004 11:29:24 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3DFTFu6032563;
	Tue, 13 Apr 2004 11:29:15 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3DFTDj05967; 
	Tue, 13 Apr 2004 11:29:13 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i3DFTBcU009554; Tue, 13 Apr 2004 11:29:11 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: Robert Lougher <robert_lougher@hotmail.com>
In-Reply-To: <BAY10-F80Bk7L0jRGjI0000cf5d@hotmail.com>
References: <BAY10-F80Bk7L0jRGjI0000cf5d@hotmail.com>
Content-Type: text/plain
Message-Id: <1081870151.4417.12.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Tue, 13 Apr 2004 11:29:11 -0400
Content-Transfer-Encoding: 7bit
Cc: classpath list <classpath@gnu.org>, brawer@dandelis.ch
Subject: Re: JamVM 1.1.3 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 15:34:23 -0000

On Tue, 2004-04-13 at 11:04, Robert Lougher wrote:
> Hi Sascha,
> 
> Yes, I know :)  I couldn't decide whether it was a good idea to slavishly 
> follow Sun's options or not. The -X (as you're obviously aware) means 
> "non-standard options", and includes -Xms and -Xmx which I also do not have 
> an X in front of (as used to be in JDK 1.1.x).  Also, on Sun's VM, 
> -classpath is specified as -classpath xxx:yyy whereas -Xbootclasspath is 
> -Xbootclasspath:xxx:yyy which is (in my mind anyway) confusing.  On JamVM 
> it's -bootclasspath xxx:yyy (added in 1.1.1), so I'd have had to change that 
> as well.
> 
> CC'ing to the mailing list, as I'm interested in other people's opinions on 
> this!
> 

I'd prefer that JamVM slavishly follow the options provided by Sun's
latest released java command.  There may be many scripts and tools that
assume e.g. the -Xbootclasspath:xxx:yyy syntax.  I think drop-in
compatibility is more important than a self-consistent set of
command-line options.

Tom





From MAILER-DAEMON Tue Apr 13 13:07:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDRLz-0005M6-RX
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 13:05:43 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDRKw-0003fO-8Z
	for classpath@gnu.org; Tue, 13 Apr 2004 13:04:38 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDRK4-0002MQ-Nd
	for classpath@gnu.org; Tue, 13 Apr 2004 13:04:17 -0400
Received: from [213.51.128.197] (helo=smtpq2.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDRK1-0002Dy-PB
	for classpath@gnu.org; Tue, 13 Apr 2004 13:03:41 -0400
Received: from [213.51.128.132] (port=50398 helo=smtp1.home.nl)
	by smtpq2.home.nl with esmtp (Exim 4.30)
	id 1BDRK0-0000ID-4c; Tue, 13 Apr 2004 19:03:40 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:32846
	helo=dumas.thomas.planescape.com)
	by smtp1.home.nl with esmtp (Exim 4.30)
	id 1BDRJz-0000JP-6c; Tue, 13 Apr 2004 19:03:39 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Tue, 13 Apr 2004 19:02:52 +0200
User-Agent: KMail/1.6.1
References: <BAY10-F80Bk7L0jRGjI0000cf5d@hotmail.com>
In-Reply-To: <BAY10-F80Bk7L0jRGjI0000cf5d@hotmail.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404131902.56842.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Cc: brawer@dandelis.ch
Subject: Re: JamVM 1.1.3 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 17:05:33 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 13 April 2004 17:04, Robert Lougher wrote:
> Hi Sascha,
>
> Yes, I know :)  I couldn't decide whether it was a good idea to
> slavishly follow Sun's options or not. The -X (as you're obviously
> aware) means "non-standard options", and includes -Xms and -Xmx which I
> also do not have an X in front of (as used to be in JDK 1.1.x).  Also,
> on Sun's VM, -classpath is specified as -classpath xxx:yyy whereas
> -Xbootclasspath is -Xbootclasspath:xxx:yyy which is (in my mind anyway)
> confusing.  On JamVM it's -bootclasspath xxx:yyy (added in 1.1.1), so
> I'd have had to change that as well.
>
> CC'ing to the mailing list, as I'm interested in other people's opinions
> on this!

In my opinion the GNU standard makes a lot more sense for any command line=
=20
tool; even Java.
This means I would go even further; to have the 'classpath' option start=20
with 2 dashes (--classpath) as we are used to from GNU tools.

The opinion that everything should look as much the same as possible seems=
=20
a bit naive (to me personally) in that I doubt any JVM could ever approach=
=20
100% compatibility with the moving target of Sun.
Remember that the options and installation and various other little things=
=20
change with each release! I surely hope the open source community will not=
=20
follow Sun with that :}

Just my 2 cents.
=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAfB08CojCW6H2z/QRAqLXAJ9zGi8A3pq+8baaZJsHxJnj97nAgwCghbGH
lLWua8N3FIg6XILMik9CYco=3D
=3D9ZqN
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Tue Apr 13 13:35:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDRpC-0002ms-2H
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 13:35:54 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDRp8-0002kd-MP
	for classpath@gnu.org; Tue, 13 Apr 2004 13:35:50 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDRoc-0002Xk-HB
	for classpath@gnu.org; Tue, 13 Apr 2004 13:35:49 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BDRoc-0002Wr-1R
	for classpath@gnu.org; Tue, 13 Apr 2004 13:35:18 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id 645be006_8d6f_11d8_9c00_00304811e8c8_17311;
	Tue, 13 Apr 2004 12:24:17 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i3DHYFu1002029; 
	Tue, 13 Apr 2004 12:34:15 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3DHYE92002028;
	Tue, 13 Apr 2004 12:34:14 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404131734.i3DHYE92002028@arch20m.dellroad.org>
In-Reply-To: <BAY10-F80Bk7L0jRGjI0000cf5d@hotmail.com>
To: Robert Lougher <robert_lougher@hotmail.com>
Date: Tue, 13 Apr 2004 12:34:14 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: classpath@gnu.org, brawer@dandelis.ch
Subject: Re: JamVM 1.1.3 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 17:35:51 -0000

Robert Lougher wrote:
> Yes, I know :)  I couldn't decide whether it was a good idea to slavishly 
> follow Sun's options or not. The -X (as you're obviously aware) means 
> "non-standard options", and includes -Xms and -Xmx which I also do not have 
> an X in front of (as used to be in JDK 1.1.x).  Also, on Sun's VM, 
> -classpath is specified as -classpath xxx:yyy whereas -Xbootclasspath is 
> -Xbootclasspath:xxx:yyy which is (in my mind anyway) confusing.  On JamVM 
> it's -bootclasspath xxx:yyy (added in 1.1.1), so I'd have had to change that 
> as well.
> 
> CC'ing to the mailing list, as I'm interested in other people's opinions on 
> this!

I think as a practical matter it's a good idea to support some of
the more obvious flags like "-classpath".. however, full compatibility
is probably not worth the trouble.

Also, note that the specification for these flags is part of the
JNI invocation interface, and there is no specification (that I
know of) for the java(1) command line itself. Sun apparently just
copies over the command line flags into the JNI_CreateJavaVM() call,
which is why they look the same.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Tue Apr 13 14:09:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDSLJ-00006e-Vx
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 14:09:05 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDSLG-00005G-FO
	for classpath@gnu.org; Tue, 13 Apr 2004 14:09:02 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDSKi-0008I1-G8
	for classpath@gnu.org; Tue, 13 Apr 2004 14:09:00 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BDSKi-0008H5-1s
	for classpath@gnu.org; Tue, 13 Apr 2004 14:08:28 -0400
Received: (qmail 5959 invoked from network); 13 Apr 2004 18:10:40 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <brawer@dandelis.ch>; 13 Apr 2004 18:10:40 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 6084F4F8080; Tue, 13 Apr 2004 11:56:57 -0600 (MDT)
To: Thomas Zander <zander@javalobby.org>
References: <BAY10-F80Bk7L0jRGjI0000cf5d@hotmail.com>
	<200404131902.56842.zander@javalobby.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I don't know WHY I said that..  I think it came from the FILLINGS
	in my rear molars..
Date: 13 Apr 2004 11:56:57 -0600
In-Reply-To: <200404131902.56842.zander@javalobby.org>
Message-ID: <87r7urahhy.fsf@fleche.redhat.com>
Lines: 19
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: brawer@dandelis.ch, classpath@gnu.org
Subject: Re: JamVM 1.1.3 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 18:09:03 -0000

>>>>> "Thomas" == Thomas Zander <zander@javalobby.org> writes:

Thomas> In my opinion the GNU standard makes a lot more sense for any
Thomas> command line tool; even Java.  This means I would go even
Thomas> further; to have the 'classpath' option start with 2 dashes
Thomas> (--classpath) as we are used to from GNU tools.

Yeah.  For `gij' we accept both.

Thomas> The opinion that everything should look as much the same as
Thomas> possible seems a bit naive (to me personally) in that I doubt
Thomas> any JVM could ever approach 100% compatibility with the moving
Thomas> target of Sun.

That's true, but there is still some benefit if you are mostly
compatible.  For one thing you don't have to hack every wrapper script
to make it work with your VM.

Tom



From MAILER-DAEMON Tue Apr 13 14:46:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDSvO-0004Ht-LE
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 14:46:22 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDSub-0003iD-B7
	for classpath@gnu.org; Tue, 13 Apr 2004 14:45:33 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDStt-00034o-O6
	for classpath@gnu.org; Tue, 13 Apr 2004 14:44:57 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDSr4-0001Jz-9T
	for classpath@gnu.org; Tue, 13 Apr 2004 14:41:54 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BDSqr-0000pb-00; Tue, 13 Apr 2004 20:41:41 +0200
From: Mark Wielaard <mark@klomp.org>
To: Jeroen Frijters <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-ida5eTrdaiIES2WYxWdM"
Message-Id: <1081881703.4890.22.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 13 Apr 2004 20:41:43 +0200
Cc: classpath@gnu.org, Stuart Ballard <sballard@netreach.com>
Subject: RE: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 18:46:19 -0000


--=-ida5eTrdaiIES2WYxWdM
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 2004-04-13 at 11:38, Jeroen Frijters wrote:
> This is what I did:
> #cd mauve
> #mono ../ikvm/bin/ikvmc.exe -out:mauve.exe
> -main:gnu.testlet.SimpleTestHarness `find | grep -v altered | grep
> .*class$` -reference:../ikvm/bin/classpath.dll
> #cp ../ikvm/bin/*.dll .

Aha! OK I actually did:
mono ../ikvm/bin/ikvmc.exe -out:mauve.exe \
     -main:gnu.testlet.SimpleTestHarness \
     gnu/testlet/*.class gnu/testlet/java/lang/Character/*.class \
     -reference:../ikvm/bin/classpath.dll

Which seemed to give a slightly faster executable then when including
all mauve classes.

$ time echo gnu.testlet.java.lang.Character.unicode | mono mauve.exe -debug
Reading unicode database...
done
Benchmark : load:2944ms   tests:1337ms
0 of 3578944 tests failed
=20
real    0m4.905s
user    0m0.072s
sys     0m0.012s

(Best of three runs again)

     load  test  overhead  total
Old: 1703  1292  3174      6169
New: 2944  1337   624      4905

So the overhead/startup cost is way down, but both load and test take
much longer. Why is that do you think?

> > The other thing to try would be using Mono's --aot option=20
> > to pre-JIT (as it were) the generated exe and dlls.
>=20
> I couldn't get that to work.

OK seems that it simply:
$ mono -O=3Dall --aot mauve.exe
Mono Ahead of Time compiler - compiling assembly mauve.exe
Executing the native assembler: as /tmp/mono_aot_hSe8Lr -o
/tmp/mono_aot_hSe8Lr.o
Executing the native linker: ld -shared -o mauve.exe.so
/tmp/mono_aot_hSe8Lr.o
Compiled 103 out of 104 methods (99%)
0 methods contain absolute addresses (0%)
1 methods contain wrapper references (0%)
0 methods contain lmf pointers (0%)
0 methods have other problems (0%)
AOT RESULT 0

You then still need the original "exe" for execution.
The man page says about --aot:

	This  option is used to precompile the CIL code in the specified
	assembly to native code.  The generated code is stored in a file
	with  the extension .so.  This file will be automatically picked
	up by the runtime when the assembly is executed.

	This pre-compiles the methods,  but  the  original  assembly  is
	still  required to execute as this one contains the metadata and
	exception information which is not  availble  on  the  generated
	file.   When  precompiling  code, you might want to compile with
	all optimizations (-O=3Dall).  Pre-compiled code is position inde-
	pendent code.
       =20
$ time echo gnu.testlet.java.lang.Character.unicode | mono mauve.exe -debug
Reading unicode database...
done
Benchmark : load:2944ms   tests:1312ms
0 of 3578944 tests failed
=20
real    0m4.882s
user    0m0.068s
sys     0m0.017s

(Best of three again)

     load  test  overhead  total
Old: 1703  1292  3174      6169
New: 2944  1337   624      4905
Oat: 2944  1312   626      4882

So that doesn't seem to help in this case (or I did something wrong and
it isn't picking up the mauve.exe.so after all).

Cheers,

Mark

--=-ida5eTrdaiIES2WYxWdM
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAfDRmxVhZCJWr9QwRAiHQAJ9q2z5vZz3eYXyPLwrE0k/yNKeTlACdFI3i
02JVAsLQbSjQHU4IW+WZWyU=
=ql4s
-----END PGP SIGNATURE-----

--=-ida5eTrdaiIES2WYxWdM--




From MAILER-DAEMON Tue Apr 13 14:57:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDT67-0002Fm-12
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 14:57:27 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDT64-0002EO-6v
	for classpath@gnu.org; Tue, 13 Apr 2004 14:57:24 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDT5X-00027R-2V
	for classpath@gnu.org; Tue, 13 Apr 2004 14:57:23 -0400
Received: from [209.152.205.226] (helo=NR-EXCHANGE.netreach.core)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDT5W-00027I-Ps
	for classpath@gnu.org; Tue, 13 Apr 2004 14:56:50 -0400
Received: from netreach.com ([209.152.205.123]) by NR-EXCHANGE.netreach.core
	with Microsoft SMTPSVC(6.0.3790.0); Tue, 13 Apr 2004 14:58:39 -0400
Message-ID: <407C3787.2090704@netreach.com>
Date: Tue, 13 Apr 2004 14:55:03 -0400
From: Stuart Ballard <sballard@netreach.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.5) Gecko/20031107 Debian/1.5-3
X-Accept-Language: en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
	<1081881703.4890.22.camel@elsschot.wildebeest.org>
In-Reply-To: <1081881703.4890.22.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 13 Apr 2004 18:58:39.0066 (UTC)
	FILETIME=[54D46BA0:01C42189]
Cc: mono-list <mono-list@lists.ximian.com>, classpath@gnu.org,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 18:57:24 -0000

Mark Wielaard wrote:
> You then still need the original "exe" for execution.
> The man page says about --aot:
> 
> 	This  option is used to precompile the CIL code in the specified
> 	assembly to native code.  The generated code is stored in a file
> 	with  the extension .so.  This file will be automatically picked
> 	up by the runtime when the assembly is executed.
> 
> 	This pre-compiles the methods,  but  the  original  assembly  is
> 	still  required to execute as this one contains the metadata and
> 	exception information which is not  availble  on  the  generated
> 	file.   When  precompiling  code, you might want to compile with
> 	all optimizations (-O=all).  Pre-compiled code is position inde-
> 	pendent code.
>         
>      load  test  overhead  total
> Old: 1703  1292  3174      6169
> New: 2944  1337   624      4905
> Oat: 2944  1312   626      4882
> 
> So that doesn't seem to help in this case (or I did something wrong and
> it isn't picking up the mauve.exe.so after all).

Did you try --aot'ing classpath.dll, IK.VM.NET.dll etc?

I'd imagine that this particular microbenchmark spends a large 
proportion of its time inside classpath itself, suggesting that merely 
JITing the mauve part wouldn't help much.

The man page you cited says that --aot "precompiles the CIL code in the 
specified assembly". In .NET terminology, each dll or exe is a separate 
assembly. So I take that doc to imply that you need to separately AOT 
each dll as well as the exe itself.

Interestingly, my installation of mono (from debian sid) doesn't even 
come with its own libraries AOT'd. I'd have thought that you'd get the 
best performance by AOT'ing *all* the libraries, including (and 
especially) the low-level platform ones such as System.dll and 
System.Xml.dll.

CC'ing mono-list for any insight they might have into why (or why not) 
you might want to AOT the platform libraries...

Stuart.

-- 
Stuart Ballard, Senior Web Developer
NetReach, Inc.
(215) 283-2300, ext. 126
http://www.netreach.com/




From MAILER-DAEMON Tue Apr 13 15:02:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDTAs-0004Tr-L7
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 15:02:22 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDTAn-0004PG-T9
	for classpath@gnu.org; Tue, 13 Apr 2004 15:02:17 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDTAG-0003x3-VK
	for classpath@gnu.org; Tue, 13 Apr 2004 15:02:16 -0400
Received: from [213.51.128.198] (helo=smtpq3.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDTAG-0003wT-7u
	for classpath@gnu.org; Tue, 13 Apr 2004 15:01:44 -0400
Received: from [213.51.128.133] (port=34025 helo=smtp2.home.nl)
	by smtpq3.home.nl with esmtp (Exim 4.30) id 1BDTAB-0004vd-Mk
	for classpath@gnu.org; Tue, 13 Apr 2004 21:01:39 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:33091
	helo=dumas.thomas.planescape.com)
	by smtp2.home.nl with esmtp (Exim 4.30) id 1BDTAA-0000Ip-Pe
	for classpath@gnu.org; Tue, 13 Apr 2004 21:01:38 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Tue, 13 Apr 2004 21:00:53 +0200
User-Agent: KMail/1.6.1
References: <BAY10-F80Bk7L0jRGjI0000cf5d@hotmail.com>
	<200404131902.56842.zander@javalobby.org>
	<87r7urahhy.fsf@fleche.redhat.com>
In-Reply-To: <87r7urahhy.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404132100.55975.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: Re: JamVM 1.1.3 released
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 19:02:18 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 13 April 2004 19:56, Tom Tromey wrote:
> Thomas> The opinion that everything should look as much the same as
> Thomas> possible seems a bit naive (to me personally) in that I doubt
> Thomas> any JVM could ever approach 100% compatibility with the moving
> Thomas> target of Sun.
>
> That's true, but there is still some benefit if you are mostly
> compatible. =A0For one thing you don't have to hack every wrapper script
> to make it work with your VM.

Just 1 wrapper-script is enough :)

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAfDjlCojCW6H2z/QRAozVAJ4yr25gByRb7NVh7QLtFp7t9ZaRoACePUsh
0lNTxmsSdoR8hhN5YJJhjnA=3D
=3DK2Vk
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Tue Apr 13 15:11:03 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDTJH-0001ut-55
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 15:11:03 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDTJD-0001tm-BG
	for classpath@gnu.org; Tue, 13 Apr 2004 15:10:59 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDTJB-0001tL-KU
	for classpath@gnu.org; Tue, 13 Apr 2004 15:10:58 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDTJB-0001tH-3k
	for classpath@gnu.org; Tue, 13 Apr 2004 15:10:57 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BDTIw-0000y0-00; Tue, 13 Apr 2004 21:10:42 +0200
From: Mark Wielaard <mark@klomp.org>
To: Stuart Ballard <sballard@netreach.com>
In-Reply-To: <407C3787.2090704@netreach.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
	<1081881703.4890.22.camel@elsschot.wildebeest.org>
	<407C3787.2090704@netreach.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-iIMUui5gsvw2M+oqYqaD"
Message-Id: <1081883444.4890.33.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 13 Apr 2004 21:10:44 +0200
Cc: mono-list <mono-list@lists.ximian.com>, classpath@gnu.org,
	Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 19:10:59 -0000


--=-iIMUui5gsvw2M+oqYqaD
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 2004-04-13 at 20:55, Stuart Ballard wrote:
> Did you try --aot'ing classpath.dll, IK.VM.NET.dll etc?
>=20
> I'd imagine that this particular microbenchmark spends a large=20
> proportion of its time inside classpath itself, suggesting that merely=20
> JITing the mauve part wouldn't help much.

Should have thought about that.
Just tried it, but:

$ for i in *.dll; do mono --aot -O=3Dall $i; done
Mono Ahead of Time compiler - compiling assembly OpenSystem.Java.dll
Executing the native assembler: as /tmp/mono_aot_ZNn0Pd -o /tmp/mono_aot_ZN=
n0Pd.o
Executing the native linker: ld -shared -o OpenSystem.Java.dll.so /tmp/mono=
_aot_ZNn0Pd.o
Compiled 12 out of 12 methods (100%)
0 methods contain absolute addresses (0%)
0 methods contain wrapper references (0%)
0 methods contain lmf pointers (0%)
0 methods have other problems (0%)
AOT RESULT 0
Mono Ahead of Time compiler - compiling assembly SharpZipLib.dll
Executing the native assembler: as /tmp/mono_aot_SVrc0t -o /tmp/mono_aot_SV=
rc0t.o
Executing the native linker: ld -shared -o SharpZipLib.dll.so /tmp/mono_aot=
_SVrc0t.o
Compiled 508 out of 540 methods (94%)
31 methods contain absolute addresses (5%)
1 methods contain wrapper references (0%)
0 methods contain lmf pointers (0%)
0 methods have other problems (0%)
AOT RESULT 0
Mono Ahead of Time compiler - compiling assembly awt.dll
Executing the native assembler: as /tmp/mono_aot_DbmJ3s -o /tmp/mono_aot_Db=
mJ3s.o
Executing the native linker: ld -shared -o awt.dll.so /tmp/mono_aot_DbmJ3s.=
o
Compiled 320 out of 342 methods (93%)
0 methods contain absolute addresses (0%)
22 methods contain wrapper references (6%)
0 methods contain lmf pointers (0%)
0 methods have other problems (0%)
AOT RESULT 0
Mono Ahead of Time compiler - compiling assembly classpath.dll
Executing the native assembler: as /tmp/mono_aot_NrbGZa -o /tmp/mono_aot_Nr=
bGZa.o
Executing the native linker: ld -shared -o classpath.dll.so /tmp/mono_aot_N=
rbGZa.o
Compiled 18338 out of 18766 methods (97%)
0 methods contain absolute addresses (0%)
428 methods contain wrapper references (2%)
0 methods contain lmf pointers (0%)
0 methods have other problems (0%)
AOT RESULT 0
Mono Ahead of Time compiler - compiling assembly ik.vm.jni.dll
=20
** ERROR **: file object.c: line 466 (mono_class_vtable): assertion failed:=
 (fklass->byval_arg.type =3D=3D MONO_TYPE_PTR)
aborting...
Aborted
Mono Ahead of Time compiler - compiling assembly ik.vm.net.dll
Executing the native assembler: as /tmp/mono_aot_PGuh22 -o /tmp/mono_aot_PG=
uh22.o
Executing the native linker: ld -shared -o ik.vm.net.dll.so /tmp/mono_aot_P=
Guh22.o
Compiled 1067 out of 1092 methods (97%)
0 methods contain absolute addresses (0%)
25 methods contain wrapper references (2%)
0 methods contain lmf pointers (0%)
0 methods have other problems (0%)
AOT RESULT 0
[mark@elsschot:~/src/mauve]
$ time echo gnu.testlet.java.lang.Character.unicode | mono mauve.exe -debug
=20
Unhandled Exception: System.TypeInitializationException: An exception was t=
hrown by the type initializer for java.io.File ---> System.TypeInitializati=
onException: An exception was thrown by the type initializer for java.lang.=
System ---> System.TypeInitializationException: An exception was thrown by =
the type initializer for gnu.java.io.EncodingManager ---> System.TypeInitia=
lizationException: An exception was thrown by the type initializer for java=
.lang.Class ---> System.ArrayTypeMismatchException: Source array type canno=
t be assigned to destination array type.
in <0x000dc> MethodDescriptor:FromMethodBase (System.Reflection.MethodBase)
in <0x00011> CompiledTypeWrapper:CreateMethodWrapper (System.Reflection.Met=
hodBase)
in <0x000c9> CompiledTypeWrapper:LazyPublishMembers ()
in <0x00041> LazyTypeWrapper:Finish ()
in <0x0004d> NativeCode.java.lang.VMClass:CreateClassInstance (TypeWrapper)
in <0x00063> NativeCode.java.lang.VMClass:getClassFromWrapper (TypeWrapper)
in <0x00022> NativeCode.java.lang.VMClass:getClassFromType (System.Type)
in <0x00025> java.lang.Object:instancehelper_getClass (object)
in <0x000cd> java.security.Permissions:add (java.security.Permission)
in <0x00055> java.lang.Class:.cctor ()
--- End of inner exception stack trace ---
=20
in <0x00429> gnu.java.io.EncodingManager:.cctor ()
--- End of inner exception stack trace ---
=20
in (unmanaged) gnu.java.io.EncodingManager:getEncoder (java.io.OutputStream=
)
in <0x0003a> java.io.OutputStreamWriter:.ctor (java.io.OutputStream)
in <0x0003c> java.io.PrintWriter:.ctor (java.io.OutputStream)
in <0x00019> java.io.PrintWriter:.ctor (java.io.OutputStream,bool)
in <0x00073> java.io.PrintStream:.ctor (java.io.OutputStream,bool)
in <0x0006d> java.lang.VMSystem:makeStandardOutputStream ()
in <0x00899> java.lang.System:.cctor ()
--- End of inner exception stack trace ---
=20
in (unmanaged) java.lang.System:getProperty (string)
in <0x00010> java.io.File:.cctor ()
--- End of inner exception stack trace ---
=20
in (unmanaged) java.io.File:.ctor (string)
in <0x0003e> java.io.FileReader:.ctor (string)
in <0x000bf> gnu.testlet.SimpleTestHarness:.ctor (bool,bool,bool)
in <0x001fc> gnu.testlet.SimpleTestHarness:main (string[])
=20
=20
real    0m0.519s
user    0m0.039s
sys     0m0.021s


--=-iIMUui5gsvw2M+oqYqaD
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAfDs0xVhZCJWr9QwRApFfAKCjw5yRMIZYFWcrUYKnLbUFCprbbACgqIBz
BwG9Qa/+5BWH9kRbrvgejLM=
=j1ow
-----END PGP SIGNATURE-----

--=-iIMUui5gsvw2M+oqYqaD--




From MAILER-DAEMON Tue Apr 13 15:16:02 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDTO5-0004CE-Ti
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 15:16:01 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDTO3-0004BH-Lz
	for classpath@gnu.org; Tue, 13 Apr 2004 15:15:59 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDTGk-000125-LY
	for classpath@gnu.org; Tue, 13 Apr 2004 15:08:27 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDTFr-0000Qe-PW
	for classpath@gnu.org; Tue, 13 Apr 2004 15:07:31 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BDTFE-0000xt-00; Tue, 13 Apr 2004 21:06:52 +0200
From: Mark Wielaard <mark@klomp.org>
To: David P Grove <groved@us.ibm.com>
In-Reply-To: <OF3ACDAF93.A7437E40-ON85256E74.00502604-85256E74.0050E3F8@us.ibm.com>
References: <OF3ACDAF93.A7437E40-ON85256E74.00502604-85256E74.0050E3F8@us.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-zcsfuj+C2TufhgLnmJ6H"
Message-Id: <1081883215.4890.29.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 
Date: Tue, 13 Apr 2004 21:06:55 +0200
Cc: classpath@gnu.org
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 19:16:00 -0000


--=-zcsfuj+C2TufhgLnmJ6H
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, 2004-04-12 at 16:43, David P Grove wrote:
> Development Jikes RVM can take a while to build, but does buy some
> performance.  Probably not worth it for classpath development or mauve
> tests, but if you want to run some apps it can pay off.   I have
> prototype and development 2.3.2 images sitting around on my machine,
> so just for fun.=20

Created a development build and tried it. But...

$ time echo gnu.testlet.java.lang.Character.unicode | ~/src/rvm/bin/rvm gnu=
.testlet.SimpleTestHarness -debug
Reading unicode database...
OPT_Compiler failure during compilation of gnu.testlet.java.lang.Character.=
UnicodeBase.getNext (Ljava/io/Reader;)Ljava/lang/String;
Ljava/lang/ClassCastException;
VM_StackTrace.print(): *UNEXPECTED* Throwable while displaying stack trace =
# 24
    The Throwable was: Ljava/lang/NullPointerException;
VM_StackTrace.print(): And its stack trace was:
Ljava/lang/NullPointerException;
VM_StackTrace.print(): *UNEXPECTED* Throwable while displaying stack trace =
# 26
    The Throwable was: Ljava/lang/NullPointerException;
VM_StackTrace.print(): And its stack trace was:
Ljava/lang/NullPointerException;
VM_StackTrace.print(): *UNEXPECTED* Throwable while displaying stack trace =
# 27
    The Throwable was: Ljava/lang/NullPointerException;
VM_StackTrace.print(): And its stack trace was:
We got 7 deep in printing stack traces; trouble.  Aborting.
JikesRVM: exit 99

This is a development build bootstrap with a prototype build which was
build with kaffe 1.1.4 though. Some other mauve tests do run with it.
Will post a bigger report to jikesrvnm-core later.

Cheers,

Mark

--=-zcsfuj+C2TufhgLnmJ6H
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAfDpNxVhZCJWr9QwRAtNBAJ4o1RxQVGf+mYgwN3WWag+BQnHgMgCfek6I
b5fx2bF8LQeDpzN00VbSqTc=
=xIps
-----END PGP SIGNATURE-----

--=-zcsfuj+C2TufhgLnmJ6H--




From MAILER-DAEMON Tue Apr 13 18:27:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDWMc-0000ix-95
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 18:26:42 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDW90-0003cT-Tq
	for classpath@gnu.org; Tue, 13 Apr 2004 18:12:38 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDW8L-0003Al-03
	for classpath@gnu.org; Tue, 13 Apr 2004 18:12:29 -0400
Received: from [216.148.227.85] (helo=rwcrmhc12.comcast.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDW7b-0002ck-8k
	for classpath@gnu.org; Tue, 13 Apr 2004 18:11:11 -0400
Received: from [192.168.231.11]
	(c-24-125-86-58.va.client2.attbi.com[24.125.86.58])
	by comcast.net (rwcrmhc12) with SMTP
	id <20040413221105014001cvdqe>; Tue, 13 Apr 2004 22:11:06 +0000
From: Jonathan Pryor <jonpryor@vt.edu>
To: Stuart Ballard <sballard@netreach.com>
In-Reply-To: <407C3787.2090704@netreach.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
	<1081881703.4890.22.camel@elsschot.wildebeest.org>
	<407C3787.2090704@netreach.com>
Content-Type: text/plain
Message-Id: <1081894138.19677.8.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 (1.4.6-1) 
Date: Tue, 13 Apr 2004 18:08:59 -0400
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Tue, 13 Apr 2004 18:26:29 -0400
Cc: mono-list <mono-list@lists.ximian.com>, Mark Wielaard <mark@klomp.org>,
	classpath@gnu.org, Jeroen Frijters <jeroen@sumatra.nl>
Subject: Re: [Mono-list] Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Apr 2004 22:12:41 -0000

Below...

On Tue, 2004-04-13 at 14:55, Stuart Ballard wrote:
<snip/>
> Interestingly, my installation of mono (from debian sid) doesn't even 
> come with its own libraries AOT'd. I'd have thought that you'd get the 
> best performance by AOT'ing *all* the libraries, including (and 
> especially) the low-level platform ones such as System.dll and 
> System.Xml.dll.

AOT (or pre-JITing) assemblies is not as useful as you'd think.  It has
two primary effects:

  - Reduce memory requirements, as memory doesn't need to be allocated
    for the JITed code
  - Decrease startup time, as (again) the JITing doesn't need to be 
    done.

This isn't without consequence.  Here are some highlights, but see Chris
Brumme's blog[1] for *lots* of details:

  - Fewer opportunities to inline during the JIT, as many methods you'd 
    like to inline will already have been compiled.
  - The real killer: AOT/pre-JIT code is AppDomain-neutral
    - Builds on the above inlining issue
    - Slows down access to class statics fields, as you need to go 
      through an indirection (for AppDomain lookup)
    - The JIT can't emit a direct function call to AOT code

You should (obviously) always run a performance analysis to see what the
impacts of AOT/pre-JIT are, but the general consensus from the .NET
developers is that it should be avoided unless you really can't afford
the startup penalty or the memory requirements.

Personally, I haven't had any problems with startup time under Mono, so
I don't see the point in shipping AOT-compiled assemblies.

 - Jon

[1] http://blogs.msdn.com/cbrumme/





From MAILER-DAEMON Tue Apr 13 22:09:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDZq7-0002UG-Aw
	for mharc-classpath@gnu.org; Tue, 13 Apr 2004 22:09:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDZpG-0001So-Nq
	for classpath@gnu.org; Tue, 13 Apr 2004 22:08:30 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDZoJ-0000NG-QG
	for classpath@gnu.org; Tue, 13 Apr 2004 22:08:04 -0400
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BDZo8-0008WS-O3
	for classpath@gnu.org; Tue, 13 Apr 2004 22:07:21 -0400
Received: from dholmeslaptop (dholmes.dltech.com.au [203.222.72.2])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i3E23JCi074082
	for <classpath@gnu.org>; Wed, 14 Apr 2004 12:03:20 +1000 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "classpath" <classpath@gnu.org>
Date: Wed, 14 Apr 2004 12:03:39 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCCEAHEBAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
Importance: Normal
Subject: NIO Channel  Synchronization bugs
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 02:09:02 -0000

I'm having trouble with my savannah account at present and so can't submit a
bug report.

Looking at some of the java.nio.channel classes I'm seeing incorrectly
synchronized code:

AbstractSelectableChannel: boolean blocking

This field is set under synchronization but isBlocking() reads it without
synchronization. Either isBlocking() needs to synchronize on the
blockingLock() object, or else blocking needs to be volatile


AbstractInterruptibleChannel: boolean closed

This is field is both set (close()) and read (isOpen()) without any
synchronization. At a minimum this field should be volatile.

Note that close() as it stands allows for implCloseChannel to be invoked
concurrently by more than one thread. Hence implCloseChannel will have to be
written to deal with that correctly.

gnu.java.nio.channels.FileChannelImpl

This class contains lots of methods of the form:

  if (!isOpen()) throw ClosedChannelException();
  // proceed with operation

but there seems to be no synchronization that prevents the channel from
being closed the moment after isOpen is checked. Am I to assume that all the
implXXX and other native methods have responsibility for dealing with this?
And for dealing with concurrent invocations?


There may be others but that was all I saw while browsing for other things.

Cheers,
David Holmes




From MAILER-DAEMON Wed Apr 14 04:25:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDfiX-00027U-9q
	for mharc-classpath@gnu.org; Wed, 14 Apr 2004 04:25:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDfiU-00024Z-Do
	for classpath@gnu.org; Wed, 14 Apr 2004 04:25:54 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDfhy-0001u9-Od
	for classpath@gnu.org; Wed, 14 Apr 2004 04:25:53 -0400
Received: from [62.131.71.108] (helo=server.intern.prangsma.net)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BDfVZ-0007Hu-Bp
	for classpath@gnu.org; Wed, 14 Apr 2004 04:12:33 -0400
Received: (qmail 26693 invoked from network); 14 Apr 2004 08:14:26 -0000
Received: from unknown (HELO lt1epr) (192.168.253.96)
	by 192.168.253.110 with SMTP; 14 Apr 2004 08:14:26 -0000
Message-ID: <001b01c421f8$4356e230$60fda8c0@lt1epr>
From: "Ewout Prangsma" <ewout@prangsma.net>
To: <classpath@gnu.org>
Date: Wed, 14 Apr 2004 10:12:43 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1409
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Subject: Wrapping all native methods in VM... classes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 08:25:55 -0000

Hi all,

In JNode we're also using a version of classpath, which I'm trying to get as
close to the latest classpath version as possible.
A topic that makes this difficult is that there are a lot of native methods
in the normal classes (e.g. java.lang.Double). Since JNode does not use
native method (except in 1 VM specific class), I'm stuck with lots of diffs.

Is it possible to move all the native methods to these VM.... classes so
every VM can decide whether to use native or something else?

If needed i don't mind to help out to get this done.

Ewout




From MAILER-DAEMON Wed Apr 14 07:33:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDieP-00087n-Mr
	for mharc-classpath@gnu.org; Wed, 14 Apr 2004 07:33:53 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDieK-00086n-FM
	for classpath@gnu.org; Wed, 14 Apr 2004 07:33:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDidm-00082v-Nt
	for classpath@gnu.org; Wed, 14 Apr 2004 07:33:45 -0400
Received: from [217.8.192.20] (helo=interway.li)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDiSk-0006To-5h
	for classpath@gnu.org; Wed, 14 Apr 2004 07:21:50 -0400
Received: from [217.8.220.212] (HELO [192.168.1.33])
	by interway.li (CommuniGate Pro SMTP 4.1.8)
	with ESMTP id 1736557; Wed, 14 Apr 2004 13:21:49 +0200
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Wed, 14 Apr 2004 13:21:43 +0200
Message-Id: <20040414112144.189@smtp.mail.ch.easynet.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: graydon hoare <graydon@redhat.com>
Subject: Patch: java.awt.image.DataBuffer[Short|Float|Double]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 11:33:49 -0000

Hi,

the following would provide support for java.awt.image.DataBuffer
of TYPE_SHORT, TYPE_FLOAT and TYPE_DOUBLE. OK to commit?

(The content of the new files has been added manually; cvs diff
complained "cvs server: <XXX>.java is a new entry, no comparison
available).

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 


2004-04-14  Sascha Brawer  <brawer@dandelis.ch>

	* java/awt/image/DataBufferShort.java,
	java/awt/image/DataBufferFloat.java,
	java/awt/image/DataBufferDouble.java: New files.

	* java/awt/image/Makefile.am (EXTRA_DIST): Added
	DataBufferShort.java, DataBufferFloat.java, and
	DataBufferDouble.java.

	* gnu/java/awt/Buffers.java (createBuffer, createBufferFromData,
	getData): Added support	for TYPE_SHORT, TYPE_FLOAT and TYPE_DOUBLE.


Index: java/awt/image/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/java/awt/image/Makefile.am,v
retrieving revision 1.8
diff -u -r1.8 Makefile.am
--- java/awt/image/Makefile.am	14 Apr 2004 11:01:13 -0000	1.8
+++ java/awt/image/Makefile.am	14 Apr 2004 11:08:22 -0000
@@ -12,7 +12,10 @@
 CropImageFilter.java \
 DataBuffer.java	\
 DataBufferByte.java \
+DataBufferDouble.java \
+DataBufferFloat.java \
 DataBufferInt.java \
+DataBufferShort.java \
 DataBufferUShort.java \
 DirectColorModel.java \
 FilteredImageSource.java \
Index: gnu/java/awt/Buffers.java
===================================================================
RCS file: /cvsroot/classpath/classpath/gnu/java/awt/Buffers.java,v
retrieving revision 1.2
diff -u -r1.2 Buffers.java
--- gnu/java/awt/Buffers.java	22 Jan 2002 22:26:56 -0000	1.2
+++ gnu/java/awt/Buffers.java	14 Apr 2004 11:08:22 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 2000, 2002  Free Software Foundation
+/* Copyright (C) 2000, 2002, 2004  Free Software Foundation
 
 This file is part of GNU Classpath.
 
@@ -83,10 +83,16 @@
       {
       case DataBuffer.TYPE_BYTE:
 	return new DataBufferByte(size, numBanks);
+      case DataBuffer.TYPE_SHORT:
+	return new DataBufferShort(size, numBanks);
       case DataBuffer.TYPE_USHORT:
 	return new DataBufferUShort(size, numBanks);
       case DataBuffer.TYPE_INT:
 	return new DataBufferInt(size, numBanks);
+      case DataBuffer.TYPE_FLOAT:
+	return new DataBufferFloat(size, numBanks);
+      case DataBuffer.TYPE_DOUBLE:
+	return new DataBufferDouble(size, numBanks);
       default:
 	throw new UnsupportedOperationException();
       }
@@ -106,10 +112,16 @@
       {
       case DataBuffer.TYPE_BYTE:
 	return new DataBufferByte((byte[]) data, size);
+      case DataBuffer.TYPE_SHORT:
+	return new DataBufferShort((short[]) data, size);
       case DataBuffer.TYPE_USHORT:
 	return new DataBufferUShort((short[]) data, size);
       case DataBuffer.TYPE_INT:
 	return new DataBufferInt((int[]) data, size);
+      case DataBuffer.TYPE_FLOAT:
+	return new DataBufferFloat((float[]) data, size);
+      case DataBuffer.TYPE_DOUBLE:
+	return new DataBufferDouble((double[]) data, size);
       default:
 	throw new UnsupportedOperationException();
       }
@@ -126,10 +138,22 @@
   {
     if (buffer instanceof DataBufferByte)
       return ((DataBufferByte) buffer).getData();
+
+    if (buffer instanceof DataBufferShort)
+      return ((DataBufferShort) buffer).getData();
+
     if (buffer instanceof DataBufferUShort)
       return ((DataBufferUShort) buffer).getData();
+
     if (buffer instanceof DataBufferInt)
       return ((DataBufferInt) buffer).getData();
+
+    if (buffer instanceof DataBufferFloat)
+      return ((DataBufferFloat) buffer).getData();
+
+    if (buffer instanceof DataBufferDouble)
+      return ((DataBufferDouble) buffer).getData();
+
     throw new ClassCastException("Unknown data buffer type");
   }
 
@@ -149,6 +173,11 @@
 	from = ((DataBufferByte) src).getData();
 	if (dest == null) dest = new byte[length+destOffset];
       }
+    else if (src instanceof DataBufferShort)
+      {
+	from = ((DataBufferShort) src).getData();
+	if (dest == null) dest = new short[length+destOffset];
+      }
     else if (src instanceof DataBufferUShort)
       {
 	from = ((DataBufferUShort) src).getData();
@@ -158,6 +187,16 @@
       {
 	from = ((DataBufferInt) src).getData();
 	if (dest == null) dest = new int[length+destOffset];
+      }
+    else if (src instanceof DataBufferFloat)
+      {
+	from = ((DataBufferFloat) src).getData();
+	if (dest == null) dest = new float[length+destOffset];
+      }
+    else if (src instanceof DataBufferDouble)
+      {
+	from = ((DataBufferDouble) src).getData();
+	if (dest == null) dest = new double[length+destOffset];
       }
     else
       {

===================================================================
java/awt/image/DataBufferShort.java

/* Copyright (C) 2004  Free Software Foundation

This file is part of GNU Classpath.

GNU Classpath is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2, or (at your option)
any later version.

GNU Classpath is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with GNU Classpath; see the file COPYING.  If not, write to the
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA.

Linking this library statically or dynamically with other modules is
making a combined work based on this library.  Thus, the terms and
conditions of the GNU General Public License cover the whole
combination.

As a special exception, the copyright holders of this library give you
permission to link this library with independent modules to produce an
executable, regardless of the license terms of these independent
modules, and to copy and distribute the resulting executable under
terms of your choice, provided that you also meet, for each linked
independent module, the terms and conditions of the license of that
module.  An independent module is a module which is not derived from
or based on this library.  If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so.  If you do not wish to do so, delete this
exception statement from your version. */

package java.awt.image;

/* This is one of several classes that are nearly identical. Maybe we
   should have a central template and generate all these files. This
   is one of the cases where templates or macros would have been
   useful to have in Java.

   This file has been created using search-replace. My only fear is
   that these classes will grow out-of-sync as of a result of changes
   that are not propagated to the other files. As always, mirroring
   code is a maintenance nightmare.  */

/**
 * @author Rolf W. Rasmussen <rolfwr@ii.uib.no>
 */
public final class DataBufferShort extends DataBuffer
{
  private short[] data;
  private short[][] bankData;
  
  public DataBufferShort(int size)
  {
    super(TYPE_SHORT, size);
    data = new short[size];
  }

  public DataBufferShort(int size, int numBanks)
  {
    super(TYPE_SHORT, size, numBanks);
    bankData = new short[numBanks][size];
    data = bankData[0];
  }

  public DataBufferShort(short[] dataArray, int size)
  {
    super(TYPE_SHORT, size);
    data = dataArray;
  }
    
  public DataBufferShort(short[] dataArray, int size, int offset)
  {
    super(TYPE_SHORT, size, 1, offset);
    data = dataArray;
  }

  public DataBufferShort(short[][] dataArray, int size)
  {
    super(TYPE_SHORT, size, dataArray.length);
    bankData = dataArray;
    data = bankData[0];
  }

  public DataBufferShort(short[][] dataArray, int size, int[] offsets)
  {
    super(TYPE_SHORT, size, dataArray.length, offsets);
    bankData = dataArray;
    data = bankData[0];
  }

  public short[] getData()
  {
    return data;
  }
    
  public short[] getData(int bank)
  {
    return bankData[bank];
  }
    
  public short[][] getBankData()
  {
    return bankData;
  }
  
  public int getElem(int i)
  {
    return data[i+offset];
  }

  public int getElem(int bank, int i)
  {
    return bankData[bank][i+offsets[bank]];
  }

  public void setElem(int i, int val)
  {
    data[i+offset] = (short) val;
  }

  public void setElem(int bank, int i, int val)
  {
    bankData[bank][i+offsets[bank]] = (short) val;
  }
}


===================================================================
java/awt/image/DataBufferFloat.java

/* Copyright (C) 2004  Free Software Foundation

This file is part of GNU Classpath.

GNU Classpath is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2, or (at your option)
any later version.

GNU Classpath is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with GNU Classpath; see the file COPYING.  If not, write to the
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA.

Linking this library statically or dynamically with other modules is
making a combined work based on this library.  Thus, the terms and
conditions of the GNU General Public License cover the whole
combination.

As a special exception, the copyright holders of this library give you
permission to link this library with independent modules to produce an
executable, regardless of the license terms of these independent
modules, and to copy and distribute the resulting executable under
terms of your choice, provided that you also meet, for each linked
independent module, the terms and conditions of the license of that
module.  An independent module is a module which is not derived from
or based on this library.  If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so.  If you do not wish to do so, delete this
exception statement from your version. */

package java.awt.image;

/* This is one of several classes that are nearly identical. Maybe we
   should have a central template and generate all these files. This
   is one of the cases where templates or macros would have been
   useful to have in Java.

   This file has been created using search-replace. My only fear is
   that these classes will grow out-of-sync as of a result of changes
   that are not propagated to the other files. As always, mirroring
   code is a maintenance nightmare.  */

/**
 * @author <a href="mailto:rolfwr@ii.uib.no">Rolf W. Rasmussen</a>
 * @author <a href="mailto:brawer@dandelis.ch">Sascha Brawer</a>
 */
public final class DataBufferFloat
  extends DataBuffer
{
  private float[] data;
  private float[][] bankData;
  
  public DataBufferFloat(int size)
  {
    super(TYPE_FLOAT, size);
    data = new float[size];
  }

  public DataBufferFloat(int size, int numBanks)
  {
    super(TYPE_FLOAT, size, numBanks);
    bankData = new float[numBanks][size];
    data = bankData[0];
  }

  public DataBufferFloat(float[] dataArray, int size)
  {
    super(TYPE_FLOAT, size);
    data = dataArray;
  }
    
  public DataBufferFloat(float[] dataArray, int size, int offset)
  {
    super(TYPE_FLOAT, size, 1, offset);
    data = dataArray;
  }

  public DataBufferFloat(float[][] dataArray, int size)
  {
    super(TYPE_FLOAT, size, dataArray.length);
    bankData = dataArray;
    data = bankData[0];
  }

  public DataBufferFloat(float[][] dataArray, int size, int[] offsets)
  {
    super(TYPE_FLOAT, size, dataArray.length, offsets);
    bankData = dataArray;
    data = bankData[0];
  }

  public float[] getData()
  {
    return data;
  }
    
  public float[] getData(int bank)
  {
    return bankData[bank];
  }
    
  public float[][] getBankData()
  {
    return bankData;
  }
  
  public int getElem(int i)
  {
    return (int) data[i+offset];
  }

  public int getElem(int bank, int i)
  {
    return (int) bankData[bank][i+offsets[bank]];
  }

  public void setElem(int i, int val)
  {
    data[i+offset] = (float) val;
  }

  public void setElem(int bank, int i, int val)
  {
    bankData[bank][i+offsets[bank]] = (float) val;
  }

  public float getElemFloat(int i)
  {
    return data[i+offset];
  }
    
  public float getElemFloat(int bank, int i)
  {
    return bankData[bank][i+offsets[bank]];
  }

  public void setElemFloat(int i, float val)
  {
    data[i+offset] = val;
  }

  public void setElemFloat(int bank, int i, float val)
  {
    bankData[bank][i+offsets[bank]] = val;
  }

  public double getElemDouble(int i)
  {
    return getElemFloat(i);
  }
    
  public double getElemDouble(int bank, int i)
  {
    return getElemFloat(bank, i);
  }

  public void setElemDouble(int i, double val)
  {
    setElemFloat(i, (float) val);
  }

  public void setElemDouble(int bank, int i, double val)
  {
    setElemFloat(bank, i, (float) val);
  }
}


===================================================================
java/awt/image/DataBufferDouble.java

/* Copyright (C) 2004  Free Software Foundation

This file is part of GNU Classpath.

GNU Classpath is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2, or (at your option)
any later version.

GNU Classpath is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with GNU Classpath; see the file COPYING.  If not, write to the
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA.

Linking this library statically or dynamically with other modules is
making a combined work based on this library.  Thus, the terms and
conditions of the GNU General Public License cover the whole
combination.

As a special exception, the copyright holders of this library give you
permission to link this library with independent modules to produce an
executable, regardless of the license terms of these independent
modules, and to copy and distribute the resulting executable under
terms of your choice, provided that you also meet, for each linked
independent module, the terms and conditions of the license of that
module.  An independent module is a module which is not derived from
or based on this library.  If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so.  If you do not wish to do so, delete this
exception statement from your version. */

package java.awt.image;

/* This is one of several classes that are nearly identical. Maybe we
   should have a central template and generate all these files. This
   is one of the cases where templates or macros would have been
   useful to have in Java.

   This file has been created using search-replace. My only fear is
   that these classes will grow out-of-sync as of a result of changes
   that are not propagated to the other files. As always, mirroring
   code is a maintenance nightmare.  */

/**
 * @since 1.4
 *
 * @author <a href="mailto:rolfwr@ii.uib.no">Rolf W. Rasmussen</a>
 * @author <a href="mailto:brawer@dandelis.ch">Sascha Brawer</a>
 */
public final class DataBufferDouble
  extends DataBuffer
{
  private double[] data;
  private double[][] bankData;
  
  public DataBufferDouble(int size)
  {
    super(TYPE_DOUBLE, size);
    data = new double[size];
  }

  public DataBufferDouble(int size, int numBanks)
  {
    super(TYPE_DOUBLE, size, numBanks);
    bankData = new double[numBanks][size];
    data = bankData[0];
  }

  public DataBufferDouble(double[] dataArray, int size)
  {
    super(TYPE_DOUBLE, size);
    data = dataArray;
  }
    
  public DataBufferDouble(double[] dataArray, int size, int offset)
  {
    super(TYPE_DOUBLE, size, 1, offset);
    data = dataArray;
  }

  public DataBufferDouble(double[][] dataArray, int size)
  {
    super(TYPE_DOUBLE, size, dataArray.length);
    bankData = dataArray;
    data = bankData[0];
  }

  public DataBufferDouble(double[][] dataArray, int size, int[] offsets)
  {
    super(TYPE_DOUBLE, size, dataArray.length, offsets);
    bankData = dataArray;
    data = bankData[0];
  }

  public double[] getData()
  {
    return data;
  }
    
  public double[] getData(int bank)
  {
    return bankData[bank];
  }
    
  public double[][] getBankData()
  {
    return bankData;
  }
  
  public int getElem(int i)
  {
    return (int) data[i+offset];
  }

  public int getElem(int bank, int i)
  {
    return (int) bankData[bank][i+offsets[bank]];
  }

  public void setElem(int i, int val)
  {
    data[i+offset] = (double) val;
  }

  public void setElem(int bank, int i, int val)
  {
    bankData[bank][i+offsets[bank]] = (double) val;
  }

  public float getElemFloat(int i)
  {
    return (float) data[i+offset];
  }
    
  public float getElemFloat(int bank, int i)
  {
    return (float) bankData[bank][i+offsets[bank]];
  }

  public void setElemFloat(int i, float val)
  {
    data[i+offset] = val;
  }

  public void setElemFloat(int bank, int i, float val)
  {
    bankData[bank][i+offsets[bank]] = val;
  }

  public double getElemDouble(int i)
  {
    return data[i + offset];
  }
    
  public double getElemDouble(int bank, int i)
  {
    return bankData[bank][i + offsets[bank]];
  }

  public void setElemDouble(int i, double val)
  {
    data[i + offset] = val;
  }

  public void setElemDouble(int bank, int i, double val)
  {
    bankData[bank][i + offsets[bank]] = val;
  }
}





From MAILER-DAEMON Wed Apr 14 10:31:44 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDlQV-0004zW-VG
	for mharc-classpath@gnu.org; Wed, 14 Apr 2004 10:31:43 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDlQT-0004yR-GR
	for classpath@gnu.org; Wed, 14 Apr 2004 10:31:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDlPx-0004pR-Rl
	for classpath@gnu.org; Wed, 14 Apr 2004 10:31:40 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BDlP0-0004d2-1d
	for classpath@gnu.org; Wed, 14 Apr 2004 10:30:10 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3EEU3u6030853;
	Wed, 14 Apr 2004 10:30:04 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3EEU2j23763; 
	Wed, 14 Apr 2004 10:30:03 -0400
Received: from to-dhcp28.toronto.redhat.com (to-dhcp28.toronto.redhat.com
	[172.16.14.128])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i3EEU0cU020473; Wed, 14 Apr 2004 10:30:01 -0400
From: Anthony Green <green@redhat.com>
To: Jonathan Pryor <jonpryor@vt.edu>
In-Reply-To: <1081894138.19677.8.camel@localhost.localdomain>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
	<1081881703.4890.22.camel@elsschot.wildebeest.org>
	<407C3787.2090704@netreach.com>
	<1081894138.19677.8.camel@localhost.localdomain>
Content-Type: text/plain
Organization: Red Hat, Inc.
Message-Id: <1081953000.3425.6.camel@escape>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Wed, 14 Apr 2004 07:30:00 -0700
Content-Transfer-Encoding: 7bit
Cc: mono-list <mono-list@lists.ximian.com>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>, classpath@gnu.org,
	Stuart Ballard <sballard@netreach.com>
Subject: Re: [Mono-list] Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 14:31:42 -0000

On Tue, 2004-04-13 at 15:08, Jonathan Pryor wrote:
> AOT (or pre-JITing) assemblies is not as useful as you'd think.  It has
> two primary effects:
> 
>   - Reduce memory requirements, as memory doesn't need to be allocated
>     for the JITed code
>   - Decrease startup time, as (again) the JITing doesn't need to be 
>     done.

Are you saying that mono doesn't have the ability to create shared
libraries?

AG

-- 
Anthony Green <green@redhat.com>
Red Hat, Inc.




From MAILER-DAEMON Wed Apr 14 14:42:40 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDpLL-0004Nq-Me
	for mharc-classpath@gnu.org; Wed, 14 Apr 2004 14:42:39 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDpLH-0004IS-Uk
	for classpath@gnu.org; Wed, 14 Apr 2004 14:42:35 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDpJy-0003Pl-VT
	for classpath@gnu.org; Wed, 14 Apr 2004 14:41:46 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BDpJn-00037A-Ra
	for classpath@gnu.org; Wed, 14 Apr 2004 14:41:04 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id b9f9e990_8e41_11d8_966f_00304811e8c8_1916;
	Wed, 14 Apr 2004 13:29:55 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i3EIdoe7001645; 
	Wed, 14 Apr 2004 13:39:50 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3EIdntI001644;
	Wed, 14 Apr 2004 13:39:49 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404141839.i3EIdntI001644@arch20m.dellroad.org>
In-Reply-To: <20040414112144.189@smtp.mail.ch.easynet.net>
To: Sascha Brawer <brawer@dandelis.ch>
Date: Wed, 14 Apr 2004 13:39:49 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Patch: java.awt.image.DataBuffer[Short|Float|Double]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 18:42:37 -0000

Sascha Brawer wrote:
> (The content of the new files has been added manually; cvs diff
> complained "cvs server: <XXX>.java is a new entry, no comparison
> available).

Add the -N flag to cvs diff to get it to include new files.
(just learned this a few weeks ago myself :-)

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Wed Apr 14 15:11:38 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDpmz-0004al-L7
	for mharc-classpath@gnu.org; Wed, 14 Apr 2004 15:11:13 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDmfk-0000P1-US
	for classpath@gnu.org; Wed, 14 Apr 2004 11:51:32 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDmf8-0008UZ-A7
	for classpath@gnu.org; Wed, 14 Apr 2004 11:51:31 -0400
Received: from [130.57.169.10] (helo=peabody.ximian.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BDmf7-0008Sq-D1
	for classpath@gnu.org; Wed, 14 Apr 2004 11:50:53 -0400
Received: (qmail 26333 invoked from network); 14 Apr 2004 15:50:51 -0000
Received: from peabody.ximian.com (HELO localhost.localdomain) (130.57.169.10)
	by peabody.ximian.com with SMTP; 14 Apr 2004 15:50:51 -0000
Received: by localhost.localdomain (Postfix, from userid 500)
	id 1A715438492; Wed, 14 Apr 2004 11:50:50 -0400 (EDT)
From: Miguel de Icaza <miguel@ximian.com>
To: Jonathan Pryor <jonpryor@vt.edu>
In-Reply-To: <1081894138.19677.8.camel@localhost.localdomain>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
	<1081881703.4890.22.camel@elsschot.wildebeest.org>
	<407C3787.2090704@netreach.com>
	<1081894138.19677.8.camel@localhost.localdomain>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1081957849.4105.1769.camel@erandi.boston.ximian.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Wed, 14 Apr 2004 11:50:49 -0400
X-Mailman-Approved-At: Wed, 14 Apr 2004 15:11:07 -0400
Cc: mono-list <mono-list@lists.ximian.com>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>, classpath@gnu.org,
	Stuart Ballard <sballard@netreach.com>
Subject: Re: [Mono-list] Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 15:51:33 -0000

Hello,

> <snip/>
> > Interestingly, my installation of mono (from debian sid) doesn't even 
> > come with its own libraries AOT'd. I'd have thought that you'd get the 
> > best performance by AOT'ing *all* the libraries, including (and 
> > especially) the low-level platform ones such as System.dll and 
> > System.Xml.dll.
> 
> AOT (or pre-JITing) assemblies is not as useful as you'd think.  It has
> two primary effects:
> 
>   - Reduce memory requirements, as memory doesn't need to be allocated
>     for the JITed code
>   - Decrease startup time, as (again) the JITing doesn't need to be 
>     done.

Another effect is that you can run the most time consuming
optimizations on those assemblies.   For example, using AOT with -O=all
on mcs.exe gives about 15% performance increase:

	mono --aot -O=all /usr/bin/mcs.exe

If you also apply this to mscorlib and System, you get another 7-12%.  
Useful when you are doing a lot of compilations.

Miguel



From MAILER-DAEMON Wed Apr 14 17:17:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDrlf-0003xk-19
	for mharc-classpath@gnu.org; Wed, 14 Apr 2004 17:17:59 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDrlc-0003xK-2n
	for classpath@gnu.org; Wed, 14 Apr 2004 17:17:56 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDrl4-0003ng-Ti
	for classpath@gnu.org; Wed, 14 Apr 2004 17:17:54 -0400
Received: from [32.97.182.102] (helo=e2.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BDrl4-0003n0-H4
	for classpath@gnu.org; Wed, 14 Apr 2004 17:17:22 -0400
Received: from northrelay02.pok.ibm.com (northrelay02.pok.ibm.com
	[9.56.224.150])
	by e2.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id i3ELHJFp439438;
	Wed, 14 Apr 2004 17:17:19 -0400
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay02.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id
	i3ELHICP095022; Wed, 14 Apr 2004 17:17:19 -0400
In-Reply-To: <1081883215.4890.29.camel@elsschot.wildebeest.org>
To: Mark Wielaard <mark@klomp.org>
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
X-MIMETrack: S/MIME Sign by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/14/2004 05:13:59 PM,
	Serialize by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/14/2004 05:13:59 PM,
	Serialize complete at 04/14/2004 05:13:59 PM,
	S/MIME Sign failed at 04/14/2004 05:13:59 PM: The cryptographic key was
	not found,
	Serialize by Router on D01ML604/01/M/IBM(Release 6.51HF87 | March 11,
	2004) at 04/14/2004 17:17:19,
	Serialize complete at 04/14/2004 17:17:19
Message-ID: <OFD0604FE1.0A994DF9-ON85256E76.00741013-85256E76.0074F0BD@us.ibm.com>
Date: Wed, 14 Apr 2004 17:17:17 -0400
Content-Type: multipart/alternative;
	boundary="=_alternative 0074A30485256E76_="
Cc: classpath@gnu.org
Subject: Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2004 21:17:56 -0000

This is a multipart message in MIME format.
--=_alternative 0074A30485256E76_=
Content-Type: text/plain; charset="US-ASCII"

Sigh.

        Building a development version of Jikes RVM is pretty stressful on 
the hosting VM.  It's found bugs in more than one product VM in the past. 
This looks like one of the nastier forms; the host VM managed to write the 
RVM.image file without any obvious error, but the image file is slightly 
wrong with the result being that Jikes RVM crashes some of the time when 
you try to run it.  I know Steve Augart was looking into a similar failure 
last week, but it's often a long and painful process unless one can get 
lucky (especially as building the development image on kaffe is _slow_ so 
the turnaround time for each injecting of debugging code is a couple of 
hours). 
        I'm sure this will work eventually, but maybe stick with prototype 
versions of Jikes RVM for now. 

--dave


Created a development build and tried it. But...

$ time echo gnu.testlet.java.lang.Character.unicode | ~/src/rvm/bin/rvm 
gnu.testlet.SimpleTestHarness -debug
Reading unicode database...
OPT_Compiler failure during compilation of 
gnu.testlet.java.lang.Character.UnicodeBase.getNext 
(Ljava/io/Reader;)Ljava/lang/String;
Ljava/lang/ClassCastException;
VM_StackTrace.print(): *UNEXPECTED* Throwable while displaying stack trace 
# 24
    The Throwable was: Ljava/lang/NullPointerException;
VM_StackTrace.print(): And its stack trace was:
Ljava/lang/NullPointerException;
--=_alternative 0074A30485256E76_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">Sigh.</font>
<br>
<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; Building
a development version of Jikes RVM is pretty stressful on the hosting VM.
&nbsp;It's found bugs in more than one product VM in the past. &nbsp;This
looks like one of the nastier forms; the host VM managed to write the RVM.image
file without any obvious error, but the image file is slightly wrong with
the result being that Jikes RVM crashes some of the time when you try to
run it. &nbsp;I know Steve Augart was looking into a similar failure last
week, but it's often a long and painful process unless one can get lucky
(especially as building the development image on kaffe is _slow_ so the
turnaround time for each injecting of debugging code is a couple of hours).
</font>
<br><font size=2 face="sans-serif">&nbsp; &nbsp; &nbsp; &nbsp; I'm
sure this will work eventually, but maybe stick with prototype versions
of Jikes RVM for now. &nbsp;</font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
<br>
<br>
<br><font size=2><tt>Created a development build and tried it. But...<br>
<br>
$ time echo gnu.testlet.java.lang.Character.unicode | ~/src/rvm/bin/rvm
gnu.testlet.SimpleTestHarness -debug<br>
Reading unicode database...<br>
OPT_Compiler failure during compilation of gnu.testlet.java.lang.Character.UnicodeBase.getNext
(Ljava/io/Reader;)Ljava/lang/String;<br>
Ljava/lang/ClassCastException;<br>
VM_StackTrace.print(): *UNEXPECTED* Throwable while displaying stack trace
# 24<br>
 &nbsp; &nbsp;The Throwable was: Ljava/lang/NullPointerException;<br>
VM_StackTrace.print(): And its stack trace was:<br>
Ljava/lang/NullPointerException;</tt></font>
--=_alternative 0074A30485256E76_=--



From MAILER-DAEMON Wed Apr 14 22:51:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BDwyr-0006W7-AL
	for mharc-classpath@gnu.org; Wed, 14 Apr 2004 22:51:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDwyo-0006V3-RU
	for classpath@gnu.org; Wed, 14 Apr 2004 22:51:54 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDwyI-0006Py-6B
	for classpath@gnu.org; Wed, 14 Apr 2004 22:51:53 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BDwyH-0006Pr-S9
	for classpath@gnu.org; Wed, 14 Apr 2004 22:51:21 -0400
Received: (qmail 14781 invoked from network); 15 Apr 2004 02:53:39 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 15 Apr 2004 02:53:39 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 927194F853E; Wed, 14 Apr 2004 20:39:45 -0600 (MDT)
To: GNU Classpath Project <classpath@gnu.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Two LITTLE black dots and one BIG black dot...nice 'n' FLUFFY!!
Date: 14 Apr 2004 20:39:44 -0600
Message-ID: <87u0zmynf3.fsf@fleche.redhat.com>
Lines: 16
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Vadim Nasardinov <vadimn@redhat.com>
Subject: duplicated code
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 02:51:55 -0000

A fellow Red Hatter, Vadim Nasardinov, has a program that looks for
cut-and-paste code.  He ran it on Classpath, you can see the results
here:

http://people.redhat.com/~vadimn/scratch/classpath-cpd.txt

The program itself is here:

http://pmd.sourceforge.net

I looked through the results briefly... some of it is unavoidable
(either machine generated code like the Locale stuff or multiple
copies of code in Arrays).  However, at least the character set tables
could be shared between the input and output classes.

Tom



From MAILER-DAEMON Thu Apr 15 02:21:13 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BE0FM-0008TZ-N2
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 02:21:12 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BDwx6-00060R-Ra
	for classpath@gnu.org; Wed, 14 Apr 2004 22:50:08 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BDwwZ-0005kY-G0
	for classpath@gnu.org; Wed, 14 Apr 2004 22:50:06 -0400
Received: from [204.127.198.35] (helo=rwcrmhc11.comcast.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BDwwZ-0005je-6V
	for classpath@gnu.org; Wed, 14 Apr 2004 22:49:35 -0400
Received: from [192.168.231.11]
	(c-24-125-86-58.va.client2.attbi.com[24.125.86.58])
	by comcast.net (rwcrmhc11) with SMTP
	id <2004041502493201300ffeibe>; Thu, 15 Apr 2004 02:49:34 +0000
From: Jonathan Pryor <jonpryor@vt.edu>
To: Anthony Green <green@redhat.com>
In-Reply-To: <1081953000.3425.6.camel@escape>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
	<1081881703.4890.22.camel@elsschot.wildebeest.org>
	<407C3787.2090704@netreach.com>
	<1081894138.19677.8.camel@localhost.localdomain>
	<1081953000.3425.6.camel@escape>
Content-Type: text/plain
Message-Id: <1081997254.6432.2.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 (1.4.6-1) 
Date: Wed, 14 Apr 2004 22:47:35 -0400
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Thu, 15 Apr 2004 02:21:10 -0400
Cc: mono-list <mono-list@lists.ximian.com>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>, classpath@gnu.org,
	Stuart Ballard <sballard@netreach.com>
Subject: Re: [Mono-list] Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 02:50:10 -0000

Below...

On Wed, 2004-04-14 at 10:30, Anthony Green wrote:
> On Tue, 2004-04-13 at 15:08, Jonathan Pryor wrote:
> > AOT (or pre-JITing) assemblies is not as useful as you'd think.  It has
> > two primary effects:
> > 
> >   - Reduce memory requirements, as memory doesn't need to be allocated
> >     for the JITed code
> >   - Decrease startup time, as (again) the JITing doesn't need to be 
> >     done.
> 
> Are you saying that mono doesn't have the ability to create shared
> libraries?

How did you get that interpretation from my statements?  It boggles my
mind...

Mono AOT creates shared libraries.  That's how startup time is reduced
-- the shared libraries contain the AOT code, so the code doesn't need
to be JITted.

 - Jon





From MAILER-DAEMON Thu Apr 15 04:01:41 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BE1oa-00084Q-SU
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 04:01:40 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BE1oR-00082I-31
	for classpath@gnu.org; Thu, 15 Apr 2004 04:01:31 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BE1nt-0007pA-TU
	for classpath@gnu.org; Thu, 15 Apr 2004 04:01:29 -0400
Received: from [217.8.192.20] (helo=interway.li)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BE1bm-0004YT-KW; Thu, 15 Apr 2004 03:48:26 -0400
Received: from [217.8.199.55] (HELO [192.168.1.33])
	by interway.li (CommuniGate Pro SMTP 4.1.8)
	with ESMTP id 1755098; Thu, 15 Apr 2004 09:48:26 +0200
From: Sascha Brawer <brawer@dandelis.ch>
To: GNU Classpath <classpath@gnu.org>
Date: Thu, 15 Apr 2004 09:48:21 +0200
Message-Id: <20040415074821.9796@smtp.mail.ch.easynet.net>
In-Reply-To: <20040414112144.189@smtp.mail.ch.easynet.net>
References: <20040414112144.189@smtp.mail.ch.easynet.net>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="==_20040415074821.24817-1_=="
Cc: commit-classpath@gnu.org, graydon hoare <graydon@redhat.com>
Subject: Re: Patch: java.awt.image.DataBuffer[Short|Float|Double]
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 08:01:37 -0000

--==_20040415074821.24817-1_==
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Sascha Brawer <brawer@dandelis.ch> wrote on Wed, 14 Apr 2004 13:21:43 +0200:

>the following would provide support for java.awt.image.DataBuffer
>of TYPE_SHORT, TYPE_FLOAT and TYPE_DOUBLE. OK to commit?

Since nobody has expressed their objections, I've committed the attached
patch.
Thanks, by the way, for teaching me about cvs diff -N.

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 


2004-04-14  Sascha Brawer  <brawer@dandelis.ch>

	* java/awt/image/DataBufferShort.java,
	java/awt/image/DataBufferFloat.java,
	java/awt/image/DataBufferDouble.java: New files.

	* java/awt/image/Makefile.am (EXTRA_DIST): Added
	DataBufferShort.java, DataBufferFloat.java, and
	DataBufferDouble.java.

	* gnu/java/awt/Buffers.java (createBuffer, createBufferFromData,
	getData): Added support	for TYPE_SHORT, TYPE_FLOAT and TYPE_DOUBLE.

--==_20040415074821.24817-1_==
Content-Type: application/octet-stream; name="bufs.diff";
	x-mac-type="00000000"; x-mac-creator="00000000"
Content-Disposition: attachment
Content-Transfer-Encoding: base64

SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zzcm9vdC9jbGFz
c3BhdGgvY2xhc3NwYXRoL0NoYW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMDMx
CmRpZmYgLXUgLXIxLjIwMzEgQ2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMTQgQXByIDIwMDQg
MTE6MDE6MTMgLTAwMDAJMS4yMDMxCisrKyBDaGFuZ2VMb2cJMTUgQXByIDIwMDQgMDc6NDE6
MDUgLTAwMDAKQEAgLTEsNSArMSwxOCBAQAogMjAwNC0wNC0xNCAgU2FzY2hhIEJyYXdlciAg
PGJyYXdlckBkYW5kZWxpcy5jaD4KIAorCSogamF2YS9hd3QvaW1hZ2UvRGF0YUJ1ZmZlclNo
b3J0LmphdmEsCisJamF2YS9hd3QvaW1hZ2UvRGF0YUJ1ZmZlckZsb2F0LmphdmEsCisJamF2
YS9hd3QvaW1hZ2UvRGF0YUJ1ZmZlckRvdWJsZS5qYXZhOiBOZXcgZmlsZXMuCisKKwkqIGph
dmEvYXd0L2ltYWdlL01ha2VmaWxlLmFtIChFWFRSQV9ESVNUKTogQWRkZWQKKwlEYXRhQnVm
ZmVyU2hvcnQuamF2YSwgRGF0YUJ1ZmZlckZsb2F0LmphdmEsIGFuZAorCURhdGFCdWZmZXJE
b3VibGUuamF2YS4KKworCSogZ251L2phdmEvYXd0L0J1ZmZlcnMuamF2YSAoY3JlYXRlQnVm
ZmVyLCBjcmVhdGVCdWZmZXJGcm9tRGF0YSwKKwlnZXREYXRhKTogQWRkZWQgc3VwcG9ydAlm
b3IgVFlQRV9TSE9SVCwgVFlQRV9GTE9BVCBhbmQgVFlQRV9ET1VCTEUuCisKKzIwMDQtMDQt
MTQgIFNhc2NoYSBCcmF3ZXIgIDxicmF3ZXJAZGFuZGVsaXMuY2g+CisKIAkqIGphdmEvYXd0
L2ltYWdlL01ha2VmaWxlLmFtIChFWFRSQV9ESVNUKToKIAlBZGRlZCBQaXhlbEludGVybGVh
dmVkU2FtcGxlTW9kZWwuamF2YQogCkluZGV4OiBqYXZhL2F3dC9pbWFnZS9NYWtlZmlsZS5h
bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zzcm9vdC9jbGFzc3BhdGgvY2xhc3NwYXRo
L2phdmEvYXd0L2ltYWdlL01ha2VmaWxlLmFtLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjgK
ZGlmZiAtdSAtcjEuOCBNYWtlZmlsZS5hbQotLS0gamF2YS9hd3QvaW1hZ2UvTWFrZWZpbGUu
YW0JMTQgQXByIDIwMDQgMTE6MDE6MTMgLTAwMDAJMS44CisrKyBqYXZhL2F3dC9pbWFnZS9N
YWtlZmlsZS5hbQkxNSBBcHIgMjAwNCAwNzo0MTowNSAtMDAwMApAQCAtMTIsNyArMTIsMTAg
QEAKIENyb3BJbWFnZUZpbHRlci5qYXZhIFwKIERhdGFCdWZmZXIuamF2YQlcCiBEYXRhQnVm
ZmVyQnl0ZS5qYXZhIFwKK0RhdGFCdWZmZXJEb3VibGUuamF2YSBcCitEYXRhQnVmZmVyRmxv
YXQuamF2YSBcCiBEYXRhQnVmZmVySW50LmphdmEgXAorRGF0YUJ1ZmZlclNob3J0LmphdmEg
XAogRGF0YUJ1ZmZlclVTaG9ydC5qYXZhIFwKIERpcmVjdENvbG9yTW9kZWwuamF2YSBcCiBG
aWx0ZXJlZEltYWdlU291cmNlLmphdmEgXApJbmRleDogamF2YS9hd3QvaW1hZ2UvRGF0YUJ1
ZmZlckRvdWJsZS5qYXZhCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IGphdmEvYXd0L2ltYWdl
L0RhdGFCdWZmZXJEb3VibGUuamF2YQpkaWZmIC1OIGphdmEvYXd0L2ltYWdlL0RhdGFCdWZm
ZXJEb3VibGUuamF2YQotLS0gL2Rldi9udWxsCTEgSmFuIDE5NzAgMDA6MDA6MDAgLTAwMDAK
KysrIGphdmEvYXd0L2ltYWdlL0RhdGFCdWZmZXJEb3VibGUuamF2YQkxNSBBcHIgMjAwNCAw
Nzo0MTowNSAtMDAwMApAQCAtMCwwICsxLDE3NCBAQAorLyogQ29weXJpZ2h0IChDKSAyMDA0
ICBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24KKworVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05V
IENsYXNzcGF0aC4KKworR05VIENsYXNzcGF0aCBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2Fu
IHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CitpdCB1bmRlciB0aGUgdGVybXMgb2Yg
dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQordGhlIEZy
ZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiwgb3IgKGF0IHlvdXIg
b3B0aW9uKQorYW55IGxhdGVyIHZlcnNpb24uCisKK0dOVSBDbGFzc3BhdGggaXMgZGlzdHJp
YnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwgYnV0CitXSVRIT1VU
IEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCitN
RVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBT
ZWUgdGhlIEdOVQorR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgor
CitZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQ
dWJsaWMgTGljZW5zZQorYWxvbmcgd2l0aCBHTlUgQ2xhc3NwYXRoOyBzZWUgdGhlIGZpbGUg
Q09QWUlORy4gIElmIG5vdCwgd3JpdGUgdG8gdGhlCitGcmVlIFNvZnR3YXJlIEZvdW5kYXRp
b24sIEluYy4sIDU5IFRlbXBsZSBQbGFjZSwgU3VpdGUgMzMwLCBCb3N0b24sIE1BCiswMjEx
MS0xMzA3IFVTQS4KKworTGlua2luZyB0aGlzIGxpYnJhcnkgc3RhdGljYWxseSBvciBkeW5h
bWljYWxseSB3aXRoIG90aGVyIG1vZHVsZXMgaXMKK21ha2luZyBhIGNvbWJpbmVkIHdvcmsg
YmFzZWQgb24gdGhpcyBsaWJyYXJ5LiAgVGh1cywgdGhlIHRlcm1zIGFuZAorY29uZGl0aW9u
cyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgY292ZXIgdGhlIHdob2xlCitj
b21iaW5hdGlvbi4KKworQXMgYSBzcGVjaWFsIGV4Y2VwdGlvbiwgdGhlIGNvcHlyaWdodCBo
b2xkZXJzIG9mIHRoaXMgbGlicmFyeSBnaXZlIHlvdQorcGVybWlzc2lvbiB0byBsaW5rIHRo
aXMgbGlicmFyeSB3aXRoIGluZGVwZW5kZW50IG1vZHVsZXMgdG8gcHJvZHVjZSBhbgorZXhl
Y3V0YWJsZSwgcmVnYXJkbGVzcyBvZiB0aGUgbGljZW5zZSB0ZXJtcyBvZiB0aGVzZSBpbmRl
cGVuZGVudAorbW9kdWxlcywgYW5kIHRvIGNvcHkgYW5kIGRpc3RyaWJ1dGUgdGhlIHJlc3Vs
dGluZyBleGVjdXRhYmxlIHVuZGVyCit0ZXJtcyBvZiB5b3VyIGNob2ljZSwgcHJvdmlkZWQg
dGhhdCB5b3UgYWxzbyBtZWV0LCBmb3IgZWFjaCBsaW5rZWQKK2luZGVwZW5kZW50IG1vZHVs
ZSwgdGhlIHRlcm1zIGFuZCBjb25kaXRpb25zIG9mIHRoZSBsaWNlbnNlIG9mIHRoYXQKK21v
ZHVsZS4gIEFuIGluZGVwZW5kZW50IG1vZHVsZSBpcyBhIG1vZHVsZSB3aGljaCBpcyBub3Qg
ZGVyaXZlZCBmcm9tCitvciBiYXNlZCBvbiB0aGlzIGxpYnJhcnkuICBJZiB5b3UgbW9kaWZ5
IHRoaXMgbGlicmFyeSwgeW91IG1heSBleHRlbmQKK3RoaXMgZXhjZXB0aW9uIHRvIHlvdXIg
dmVyc2lvbiBvZiB0aGUgbGlicmFyeSwgYnV0IHlvdSBhcmUgbm90CitvYmxpZ2F0ZWQgdG8g
ZG8gc28uICBJZiB5b3UgZG8gbm90IHdpc2ggdG8gZG8gc28sIGRlbGV0ZSB0aGlzCitleGNl
cHRpb24gc3RhdGVtZW50IGZyb20geW91ciB2ZXJzaW9uLiAqLworCitwYWNrYWdlIGphdmEu
YXd0LmltYWdlOworCisvKiBUaGlzIGlzIG9uZSBvZiBzZXZlcmFsIGNsYXNzZXMgdGhhdCBh
cmUgbmVhcmx5IGlkZW50aWNhbC4gTWF5YmUgd2UKKyAgIHNob3VsZCBoYXZlIGEgY2VudHJh
bCB0ZW1wbGF0ZSBhbmQgZ2VuZXJhdGUgYWxsIHRoZXNlIGZpbGVzLiBUaGlzCisgICBpcyBv
bmUgb2YgdGhlIGNhc2VzIHdoZXJlIHRlbXBsYXRlcyBvciBtYWNyb3Mgd291bGQgaGF2ZSBi
ZWVuCisgICB1c2VmdWwgdG8gaGF2ZSBpbiBKYXZhLgorCisgICBUaGlzIGZpbGUgaGFzIGJl
ZW4gY3JlYXRlZCB1c2luZyBzZWFyY2gtcmVwbGFjZS4gTXkgb25seSBmZWFyIGlzCisgICB0
aGF0IHRoZXNlIGNsYXNzZXMgd2lsbCBncm93IG91dC1vZi1zeW5jIGFzIG9mIGEgcmVzdWx0
IG9mIGNoYW5nZXMKKyAgIHRoYXQgYXJlIG5vdCBwcm9wYWdhdGVkIHRvIHRoZSBvdGhlciBm
aWxlcy4gQXMgYWx3YXlzLCBtaXJyb3JpbmcKKyAgIGNvZGUgaXMgYSBtYWludGVuYW5jZSBu
aWdodG1hcmUuICAqLworCisvKioKKyAqIEBzaW5jZSAxLjQKKyAqCisgKiBAYXV0aG9yIDxh
IGhyZWY9Im1haWx0bzpyb2xmd3JAaWkudWliLm5vIj5Sb2xmIFcuIFJhc211c3NlbjwvYT4K
KyAqIEBhdXRob3IgPGEgaHJlZj0ibWFpbHRvOmJyYXdlckBkYW5kZWxpcy5jaCI+U2FzY2hh
IEJyYXdlcjwvYT4KKyAqLworcHVibGljIGZpbmFsIGNsYXNzIERhdGFCdWZmZXJEb3VibGUK
KyAgZXh0ZW5kcyBEYXRhQnVmZmVyCit7CisgIHByaXZhdGUgZG91YmxlW10gZGF0YTsKKyAg
cHJpdmF0ZSBkb3VibGVbXVtdIGJhbmtEYXRhOworICAKKyAgcHVibGljIERhdGFCdWZmZXJE
b3VibGUoaW50IHNpemUpCisgIHsKKyAgICBzdXBlcihUWVBFX0RPVUJMRSwgc2l6ZSk7Cisg
ICAgZGF0YSA9IG5ldyBkb3VibGVbc2l6ZV07CisgIH0KKworICBwdWJsaWMgRGF0YUJ1ZmZl
ckRvdWJsZShpbnQgc2l6ZSwgaW50IG51bUJhbmtzKQorICB7CisgICAgc3VwZXIoVFlQRV9E
T1VCTEUsIHNpemUsIG51bUJhbmtzKTsKKyAgICBiYW5rRGF0YSA9IG5ldyBkb3VibGVbbnVt
QmFua3NdW3NpemVdOworICAgIGRhdGEgPSBiYW5rRGF0YVswXTsKKyAgfQorCisgIHB1Ymxp
YyBEYXRhQnVmZmVyRG91YmxlKGRvdWJsZVtdIGRhdGFBcnJheSwgaW50IHNpemUpCisgIHsK
KyAgICBzdXBlcihUWVBFX0RPVUJMRSwgc2l6ZSk7CisgICAgZGF0YSA9IGRhdGFBcnJheTsK
KyAgfQorICAgIAorICBwdWJsaWMgRGF0YUJ1ZmZlckRvdWJsZShkb3VibGVbXSBkYXRhQXJy
YXksIGludCBzaXplLCBpbnQgb2Zmc2V0KQorICB7CisgICAgc3VwZXIoVFlQRV9ET1VCTEUs
IHNpemUsIDEsIG9mZnNldCk7CisgICAgZGF0YSA9IGRhdGFBcnJheTsKKyAgfQorCisgIHB1
YmxpYyBEYXRhQnVmZmVyRG91YmxlKGRvdWJsZVtdW10gZGF0YUFycmF5LCBpbnQgc2l6ZSkK
KyAgeworICAgIHN1cGVyKFRZUEVfRE9VQkxFLCBzaXplLCBkYXRhQXJyYXkubGVuZ3RoKTsK
KyAgICBiYW5rRGF0YSA9IGRhdGFBcnJheTsKKyAgICBkYXRhID0gYmFua0RhdGFbMF07Cisg
IH0KKworICBwdWJsaWMgRGF0YUJ1ZmZlckRvdWJsZShkb3VibGVbXVtdIGRhdGFBcnJheSwg
aW50IHNpemUsIGludFtdIG9mZnNldHMpCisgIHsKKyAgICBzdXBlcihUWVBFX0RPVUJMRSwg
c2l6ZSwgZGF0YUFycmF5Lmxlbmd0aCwgb2Zmc2V0cyk7CisgICAgYmFua0RhdGEgPSBkYXRh
QXJyYXk7CisgICAgZGF0YSA9IGJhbmtEYXRhWzBdOworICB9CisKKyAgcHVibGljIGRvdWJs
ZVtdIGdldERhdGEoKQorICB7CisgICAgcmV0dXJuIGRhdGE7CisgIH0KKyAgICAKKyAgcHVi
bGljIGRvdWJsZVtdIGdldERhdGEoaW50IGJhbmspCisgIHsKKyAgICByZXR1cm4gYmFua0Rh
dGFbYmFua107CisgIH0KKyAgICAKKyAgcHVibGljIGRvdWJsZVtdW10gZ2V0QmFua0RhdGEo
KQorICB7CisgICAgcmV0dXJuIGJhbmtEYXRhOworICB9CisgIAorICBwdWJsaWMgaW50IGdl
dEVsZW0oaW50IGkpCisgIHsKKyAgICByZXR1cm4gKGludCkgZGF0YVtpK29mZnNldF07Cisg
IH0KKworICBwdWJsaWMgaW50IGdldEVsZW0oaW50IGJhbmssIGludCBpKQorICB7CisgICAg
cmV0dXJuIChpbnQpIGJhbmtEYXRhW2JhbmtdW2krb2Zmc2V0c1tiYW5rXV07CisgIH0KKwor
ICBwdWJsaWMgdm9pZCBzZXRFbGVtKGludCBpLCBpbnQgdmFsKQorICB7CisgICAgZGF0YVtp
K29mZnNldF0gPSAoZG91YmxlKSB2YWw7CisgIH0KKworICBwdWJsaWMgdm9pZCBzZXRFbGVt
KGludCBiYW5rLCBpbnQgaSwgaW50IHZhbCkKKyAgeworICAgIGJhbmtEYXRhW2JhbmtdW2kr
b2Zmc2V0c1tiYW5rXV0gPSAoZG91YmxlKSB2YWw7CisgIH0KKworICBwdWJsaWMgZmxvYXQg
Z2V0RWxlbUZsb2F0KGludCBpKQorICB7CisgICAgcmV0dXJuIChmbG9hdCkgZGF0YVtpK29m
ZnNldF07CisgIH0KKyAgICAKKyAgcHVibGljIGZsb2F0IGdldEVsZW1GbG9hdChpbnQgYmFu
aywgaW50IGkpCisgIHsKKyAgICByZXR1cm4gKGZsb2F0KSBiYW5rRGF0YVtiYW5rXVtpK29m
ZnNldHNbYmFua11dOworICB9CisKKyAgcHVibGljIHZvaWQgc2V0RWxlbUZsb2F0KGludCBp
LCBmbG9hdCB2YWwpCisgIHsKKyAgICBkYXRhW2krb2Zmc2V0XSA9IHZhbDsKKyAgfQorCisg
IHB1YmxpYyB2b2lkIHNldEVsZW1GbG9hdChpbnQgYmFuaywgaW50IGksIGZsb2F0IHZhbCkK
KyAgeworICAgIGJhbmtEYXRhW2JhbmtdW2krb2Zmc2V0c1tiYW5rXV0gPSB2YWw7CisgIH0K
KworICBwdWJsaWMgZG91YmxlIGdldEVsZW1Eb3VibGUoaW50IGkpCisgIHsKKyAgICByZXR1
cm4gZGF0YVtpICsgb2Zmc2V0XTsKKyAgfQorICAgIAorICBwdWJsaWMgZG91YmxlIGdldEVs
ZW1Eb3VibGUoaW50IGJhbmssIGludCBpKQorICB7CisgICAgcmV0dXJuIGJhbmtEYXRhW2Jh
bmtdW2kgKyBvZmZzZXRzW2JhbmtdXTsKKyAgfQorCisgIHB1YmxpYyB2b2lkIHNldEVsZW1E
b3VibGUoaW50IGksIGRvdWJsZSB2YWwpCisgIHsKKyAgICBkYXRhW2kgKyBvZmZzZXRdID0g
dmFsOworICB9CisKKyAgcHVibGljIHZvaWQgc2V0RWxlbURvdWJsZShpbnQgYmFuaywgaW50
IGksIGRvdWJsZSB2YWwpCisgIHsKKyAgICBiYW5rRGF0YVtiYW5rXVtpICsgb2Zmc2V0c1ti
YW5rXV0gPSB2YWw7CisgIH0KK30KSW5kZXg6IGphdmEvYXd0L2ltYWdlL0RhdGFCdWZmZXJG
bG9hdC5qYXZhCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IGphdmEvYXd0L2ltYWdlL0RhdGFC
dWZmZXJGbG9hdC5qYXZhCmRpZmYgLU4gamF2YS9hd3QvaW1hZ2UvRGF0YUJ1ZmZlckZsb2F0
LmphdmEKLS0tIC9kZXYvbnVsbAkxIEphbiAxOTcwIDAwOjAwOjAwIC0wMDAwCisrKyBqYXZh
L2F3dC9pbWFnZS9EYXRhQnVmZmVyRmxvYXQuamF2YQkxNSBBcHIgMjAwNCAwNzo0MTowNSAt
MDAwMApAQCAtMCwwICsxLDE3MiBAQAorLyogQ29weXJpZ2h0IChDKSAyMDA0ICBGcmVlIFNv
ZnR3YXJlIEZvdW5kYXRpb24KKworVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIENsYXNzcGF0
aC4KKworR05VIENsYXNzcGF0aCBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJp
YnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CitpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBH
ZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQordGhlIEZyZWUgU29mdHdh
cmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiwgb3IgKGF0IHlvdXIgb3B0aW9uKQor
YW55IGxhdGVyIHZlcnNpb24uCisKK0dOVSBDbGFzc3BhdGggaXMgZGlzdHJpYnV0ZWQgaW4g
dGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwgYnV0CitXSVRIT1VUIEFOWSBXQVJS
QU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCitNRVJDSEFOVEFC
SUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdO
VQorR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCitZb3Ugc2hv
dWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGlj
ZW5zZQorYWxvbmcgd2l0aCBHTlUgQ2xhc3NwYXRoOyBzZWUgdGhlIGZpbGUgQ09QWUlORy4g
IElmIG5vdCwgd3JpdGUgdG8gdGhlCitGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4s
IDU5IFRlbXBsZSBQbGFjZSwgU3VpdGUgMzMwLCBCb3N0b24sIE1BCiswMjExMS0xMzA3IFVT
QS4KKworTGlua2luZyB0aGlzIGxpYnJhcnkgc3RhdGljYWxseSBvciBkeW5hbWljYWxseSB3
aXRoIG90aGVyIG1vZHVsZXMgaXMKK21ha2luZyBhIGNvbWJpbmVkIHdvcmsgYmFzZWQgb24g
dGhpcyBsaWJyYXJ5LiAgVGh1cywgdGhlIHRlcm1zIGFuZAorY29uZGl0aW9ucyBvZiB0aGUg
R05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgY292ZXIgdGhlIHdob2xlCitjb21iaW5hdGlv
bi4KKworQXMgYSBzcGVjaWFsIGV4Y2VwdGlvbiwgdGhlIGNvcHlyaWdodCBob2xkZXJzIG9m
IHRoaXMgbGlicmFyeSBnaXZlIHlvdQorcGVybWlzc2lvbiB0byBsaW5rIHRoaXMgbGlicmFy
eSB3aXRoIGluZGVwZW5kZW50IG1vZHVsZXMgdG8gcHJvZHVjZSBhbgorZXhlY3V0YWJsZSwg
cmVnYXJkbGVzcyBvZiB0aGUgbGljZW5zZSB0ZXJtcyBvZiB0aGVzZSBpbmRlcGVuZGVudAor
bW9kdWxlcywgYW5kIHRvIGNvcHkgYW5kIGRpc3RyaWJ1dGUgdGhlIHJlc3VsdGluZyBleGVj
dXRhYmxlIHVuZGVyCit0ZXJtcyBvZiB5b3VyIGNob2ljZSwgcHJvdmlkZWQgdGhhdCB5b3Ug
YWxzbyBtZWV0LCBmb3IgZWFjaCBsaW5rZWQKK2luZGVwZW5kZW50IG1vZHVsZSwgdGhlIHRl
cm1zIGFuZCBjb25kaXRpb25zIG9mIHRoZSBsaWNlbnNlIG9mIHRoYXQKK21vZHVsZS4gIEFu
IGluZGVwZW5kZW50IG1vZHVsZSBpcyBhIG1vZHVsZSB3aGljaCBpcyBub3QgZGVyaXZlZCBm
cm9tCitvciBiYXNlZCBvbiB0aGlzIGxpYnJhcnkuICBJZiB5b3UgbW9kaWZ5IHRoaXMgbGli
cmFyeSwgeW91IG1heSBleHRlbmQKK3RoaXMgZXhjZXB0aW9uIHRvIHlvdXIgdmVyc2lvbiBv
ZiB0aGUgbGlicmFyeSwgYnV0IHlvdSBhcmUgbm90CitvYmxpZ2F0ZWQgdG8gZG8gc28uICBJ
ZiB5b3UgZG8gbm90IHdpc2ggdG8gZG8gc28sIGRlbGV0ZSB0aGlzCitleGNlcHRpb24gc3Rh
dGVtZW50IGZyb20geW91ciB2ZXJzaW9uLiAqLworCitwYWNrYWdlIGphdmEuYXd0LmltYWdl
OworCisvKiBUaGlzIGlzIG9uZSBvZiBzZXZlcmFsIGNsYXNzZXMgdGhhdCBhcmUgbmVhcmx5
IGlkZW50aWNhbC4gTWF5YmUgd2UKKyAgIHNob3VsZCBoYXZlIGEgY2VudHJhbCB0ZW1wbGF0
ZSBhbmQgZ2VuZXJhdGUgYWxsIHRoZXNlIGZpbGVzLiBUaGlzCisgICBpcyBvbmUgb2YgdGhl
IGNhc2VzIHdoZXJlIHRlbXBsYXRlcyBvciBtYWNyb3Mgd291bGQgaGF2ZSBiZWVuCisgICB1
c2VmdWwgdG8gaGF2ZSBpbiBKYXZhLgorCisgICBUaGlzIGZpbGUgaGFzIGJlZW4gY3JlYXRl
ZCB1c2luZyBzZWFyY2gtcmVwbGFjZS4gTXkgb25seSBmZWFyIGlzCisgICB0aGF0IHRoZXNl
IGNsYXNzZXMgd2lsbCBncm93IG91dC1vZi1zeW5jIGFzIG9mIGEgcmVzdWx0IG9mIGNoYW5n
ZXMKKyAgIHRoYXQgYXJlIG5vdCBwcm9wYWdhdGVkIHRvIHRoZSBvdGhlciBmaWxlcy4gQXMg
YWx3YXlzLCBtaXJyb3JpbmcKKyAgIGNvZGUgaXMgYSBtYWludGVuYW5jZSBuaWdodG1hcmUu
ICAqLworCisvKioKKyAqIEBhdXRob3IgPGEgaHJlZj0ibWFpbHRvOnJvbGZ3ckBpaS51aWIu
bm8iPlJvbGYgVy4gUmFzbXVzc2VuPC9hPgorICogQGF1dGhvciA8YSBocmVmPSJtYWlsdG86
YnJhd2VyQGRhbmRlbGlzLmNoIj5TYXNjaGEgQnJhd2VyPC9hPgorICovCitwdWJsaWMgZmlu
YWwgY2xhc3MgRGF0YUJ1ZmZlckZsb2F0CisgIGV4dGVuZHMgRGF0YUJ1ZmZlcgoreworICBw
cml2YXRlIGZsb2F0W10gZGF0YTsKKyAgcHJpdmF0ZSBmbG9hdFtdW10gYmFua0RhdGE7Cisg
IAorICBwdWJsaWMgRGF0YUJ1ZmZlckZsb2F0KGludCBzaXplKQorICB7CisgICAgc3VwZXIo
VFlQRV9GTE9BVCwgc2l6ZSk7CisgICAgZGF0YSA9IG5ldyBmbG9hdFtzaXplXTsKKyAgfQor
CisgIHB1YmxpYyBEYXRhQnVmZmVyRmxvYXQoaW50IHNpemUsIGludCBudW1CYW5rcykKKyAg
eworICAgIHN1cGVyKFRZUEVfRkxPQVQsIHNpemUsIG51bUJhbmtzKTsKKyAgICBiYW5rRGF0
YSA9IG5ldyBmbG9hdFtudW1CYW5rc11bc2l6ZV07CisgICAgZGF0YSA9IGJhbmtEYXRhWzBd
OworICB9CisKKyAgcHVibGljIERhdGFCdWZmZXJGbG9hdChmbG9hdFtdIGRhdGFBcnJheSwg
aW50IHNpemUpCisgIHsKKyAgICBzdXBlcihUWVBFX0ZMT0FULCBzaXplKTsKKyAgICBkYXRh
ID0gZGF0YUFycmF5OworICB9CisgICAgCisgIHB1YmxpYyBEYXRhQnVmZmVyRmxvYXQoZmxv
YXRbXSBkYXRhQXJyYXksIGludCBzaXplLCBpbnQgb2Zmc2V0KQorICB7CisgICAgc3VwZXIo
VFlQRV9GTE9BVCwgc2l6ZSwgMSwgb2Zmc2V0KTsKKyAgICBkYXRhID0gZGF0YUFycmF5Owor
ICB9CisKKyAgcHVibGljIERhdGFCdWZmZXJGbG9hdChmbG9hdFtdW10gZGF0YUFycmF5LCBp
bnQgc2l6ZSkKKyAgeworICAgIHN1cGVyKFRZUEVfRkxPQVQsIHNpemUsIGRhdGFBcnJheS5s
ZW5ndGgpOworICAgIGJhbmtEYXRhID0gZGF0YUFycmF5OworICAgIGRhdGEgPSBiYW5rRGF0
YVswXTsKKyAgfQorCisgIHB1YmxpYyBEYXRhQnVmZmVyRmxvYXQoZmxvYXRbXVtdIGRhdGFB
cnJheSwgaW50IHNpemUsIGludFtdIG9mZnNldHMpCisgIHsKKyAgICBzdXBlcihUWVBFX0ZM
T0FULCBzaXplLCBkYXRhQXJyYXkubGVuZ3RoLCBvZmZzZXRzKTsKKyAgICBiYW5rRGF0YSA9
IGRhdGFBcnJheTsKKyAgICBkYXRhID0gYmFua0RhdGFbMF07CisgIH0KKworICBwdWJsaWMg
ZmxvYXRbXSBnZXREYXRhKCkKKyAgeworICAgIHJldHVybiBkYXRhOworICB9CisgICAgCisg
IHB1YmxpYyBmbG9hdFtdIGdldERhdGEoaW50IGJhbmspCisgIHsKKyAgICByZXR1cm4gYmFu
a0RhdGFbYmFua107CisgIH0KKyAgICAKKyAgcHVibGljIGZsb2F0W11bXSBnZXRCYW5rRGF0
YSgpCisgIHsKKyAgICByZXR1cm4gYmFua0RhdGE7CisgIH0KKyAgCisgIHB1YmxpYyBpbnQg
Z2V0RWxlbShpbnQgaSkKKyAgeworICAgIHJldHVybiAoaW50KSBkYXRhW2krb2Zmc2V0XTsK
KyAgfQorCisgIHB1YmxpYyBpbnQgZ2V0RWxlbShpbnQgYmFuaywgaW50IGkpCisgIHsKKyAg
ICByZXR1cm4gKGludCkgYmFua0RhdGFbYmFua11baStvZmZzZXRzW2JhbmtdXTsKKyAgfQor
CisgIHB1YmxpYyB2b2lkIHNldEVsZW0oaW50IGksIGludCB2YWwpCisgIHsKKyAgICBkYXRh
W2krb2Zmc2V0XSA9IChmbG9hdCkgdmFsOworICB9CisKKyAgcHVibGljIHZvaWQgc2V0RWxl
bShpbnQgYmFuaywgaW50IGksIGludCB2YWwpCisgIHsKKyAgICBiYW5rRGF0YVtiYW5rXVtp
K29mZnNldHNbYmFua11dID0gKGZsb2F0KSB2YWw7CisgIH0KKworICBwdWJsaWMgZmxvYXQg
Z2V0RWxlbUZsb2F0KGludCBpKQorICB7CisgICAgcmV0dXJuIGRhdGFbaStvZmZzZXRdOwor
ICB9CisgICAgCisgIHB1YmxpYyBmbG9hdCBnZXRFbGVtRmxvYXQoaW50IGJhbmssIGludCBp
KQorICB7CisgICAgcmV0dXJuIGJhbmtEYXRhW2JhbmtdW2krb2Zmc2V0c1tiYW5rXV07Cisg
IH0KKworICBwdWJsaWMgdm9pZCBzZXRFbGVtRmxvYXQoaW50IGksIGZsb2F0IHZhbCkKKyAg
eworICAgIGRhdGFbaStvZmZzZXRdID0gdmFsOworICB9CisKKyAgcHVibGljIHZvaWQgc2V0
RWxlbUZsb2F0KGludCBiYW5rLCBpbnQgaSwgZmxvYXQgdmFsKQorICB7CisgICAgYmFua0Rh
dGFbYmFua11baStvZmZzZXRzW2JhbmtdXSA9IHZhbDsKKyAgfQorCisgIHB1YmxpYyBkb3Vi
bGUgZ2V0RWxlbURvdWJsZShpbnQgaSkKKyAgeworICAgIHJldHVybiBnZXRFbGVtRmxvYXQo
aSk7CisgIH0KKyAgICAKKyAgcHVibGljIGRvdWJsZSBnZXRFbGVtRG91YmxlKGludCBiYW5r
LCBpbnQgaSkKKyAgeworICAgIHJldHVybiBnZXRFbGVtRmxvYXQoYmFuaywgaSk7CisgIH0K
KworICBwdWJsaWMgdm9pZCBzZXRFbGVtRG91YmxlKGludCBpLCBkb3VibGUgdmFsKQorICB7
CisgICAgc2V0RWxlbUZsb2F0KGksIChmbG9hdCkgdmFsKTsKKyAgfQorCisgIHB1YmxpYyB2
b2lkIHNldEVsZW1Eb3VibGUoaW50IGJhbmssIGludCBpLCBkb3VibGUgdmFsKQorICB7Cisg
ICAgc2V0RWxlbUZsb2F0KGJhbmssIGksIChmbG9hdCkgdmFsKTsKKyAgfQorfQpJbmRleDog
amF2YS9hd3QvaW1hZ2UvRGF0YUJ1ZmZlclNob3J0LmphdmEKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg
ZmlsZTogamF2YS9hd3QvaW1hZ2UvRGF0YUJ1ZmZlclNob3J0LmphdmEKZGlmZiAtTiBqYXZh
L2F3dC9pbWFnZS9EYXRhQnVmZmVyU2hvcnQuamF2YQotLS0gL2Rldi9udWxsCTEgSmFuIDE5
NzAgMDA6MDA6MDAgLTAwMDAKKysrIGphdmEvYXd0L2ltYWdlL0RhdGFCdWZmZXJTaG9ydC5q
YXZhCTE1IEFwciAyMDA0IDA3OjQxOjA1IC0wMDAwCkBAIC0wLDAgKzEsMTMwIEBACisvKiBD
b3B5cmlnaHQgKEMpIDIwMDQgIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbgorCitUaGlzIGZp
bGUgaXMgcGFydCBvZiBHTlUgQ2xhc3NwYXRoLgorCitHTlUgQ2xhc3NwYXRoIGlzIGZyZWUg
c29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKK2l0IHVu
ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVi
bGlzaGVkIGJ5Cit0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIgdmVyc2lv
biAyLCBvciAoYXQgeW91ciBvcHRpb24pCithbnkgbGF0ZXIgdmVyc2lvbi4KKworR05VIENs
YXNzcGF0aCBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl
ZnVsLCBidXQKK1dJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxp
ZWQgd2FycmFudHkgb2YKK01FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJ
Q1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCitHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZv
ciBtb3JlIGRldGFpbHMuCisKK1lvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg
dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCithbG9uZyB3aXRoIEdOVSBDbGFzc3Bh
dGg7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLiAgSWYgbm90LCB3cml0ZSB0byB0aGUKK0ZyZWUg
U29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNTkgVGVtcGxlIFBsYWNlLCBTdWl0ZSAzMzAs
IEJvc3RvbiwgTUEKKzAyMTExLTEzMDcgVVNBLgorCitMaW5raW5nIHRoaXMgbGlicmFyeSBz
dGF0aWNhbGx5IG9yIGR5bmFtaWNhbGx5IHdpdGggb3RoZXIgbW9kdWxlcyBpcworbWFraW5n
IGEgY29tYmluZWQgd29yayBiYXNlZCBvbiB0aGlzIGxpYnJhcnkuICBUaHVzLCB0aGUgdGVy
bXMgYW5kCitjb25kaXRpb25zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBj
b3ZlciB0aGUgd2hvbGUKK2NvbWJpbmF0aW9uLgorCitBcyBhIHNwZWNpYWwgZXhjZXB0aW9u
LCB0aGUgY29weXJpZ2h0IGhvbGRlcnMgb2YgdGhpcyBsaWJyYXJ5IGdpdmUgeW91CitwZXJt
aXNzaW9uIHRvIGxpbmsgdGhpcyBsaWJyYXJ5IHdpdGggaW5kZXBlbmRlbnQgbW9kdWxlcyB0
byBwcm9kdWNlIGFuCitleGVjdXRhYmxlLCByZWdhcmRsZXNzIG9mIHRoZSBsaWNlbnNlIHRl
cm1zIG9mIHRoZXNlIGluZGVwZW5kZW50Cittb2R1bGVzLCBhbmQgdG8gY29weSBhbmQgZGlz
dHJpYnV0ZSB0aGUgcmVzdWx0aW5nIGV4ZWN1dGFibGUgdW5kZXIKK3Rlcm1zIG9mIHlvdXIg
Y2hvaWNlLCBwcm92aWRlZCB0aGF0IHlvdSBhbHNvIG1lZXQsIGZvciBlYWNoIGxpbmtlZAor
aW5kZXBlbmRlbnQgbW9kdWxlLCB0aGUgdGVybXMgYW5kIGNvbmRpdGlvbnMgb2YgdGhlIGxp
Y2Vuc2Ugb2YgdGhhdAorbW9kdWxlLiAgQW4gaW5kZXBlbmRlbnQgbW9kdWxlIGlzIGEgbW9k
dWxlIHdoaWNoIGlzIG5vdCBkZXJpdmVkIGZyb20KK29yIGJhc2VkIG9uIHRoaXMgbGlicmFy
eS4gIElmIHlvdSBtb2RpZnkgdGhpcyBsaWJyYXJ5LCB5b3UgbWF5IGV4dGVuZAordGhpcyBl
eGNlcHRpb24gdG8geW91ciB2ZXJzaW9uIG9mIHRoZSBsaWJyYXJ5LCBidXQgeW91IGFyZSBu
b3QKK29ibGlnYXRlZCB0byBkbyBzby4gIElmIHlvdSBkbyBub3Qgd2lzaCB0byBkbyBzbywg
ZGVsZXRlIHRoaXMKK2V4Y2VwdGlvbiBzdGF0ZW1lbnQgZnJvbSB5b3VyIHZlcnNpb24uICov
CisKK3BhY2thZ2UgamF2YS5hd3QuaW1hZ2U7CisKKy8qIFRoaXMgaXMgb25lIG9mIHNldmVy
YWwgY2xhc3NlcyB0aGF0IGFyZSBuZWFybHkgaWRlbnRpY2FsLiBNYXliZSB3ZQorICAgc2hv
dWxkIGhhdmUgYSBjZW50cmFsIHRlbXBsYXRlIGFuZCBnZW5lcmF0ZSBhbGwgdGhlc2UgZmls
ZXMuIFRoaXMKKyAgIGlzIG9uZSBvZiB0aGUgY2FzZXMgd2hlcmUgdGVtcGxhdGVzIG9yIG1h
Y3JvcyB3b3VsZCBoYXZlIGJlZW4KKyAgIHVzZWZ1bCB0byBoYXZlIGluIEphdmEuCisKKyAg
IFRoaXMgZmlsZSBoYXMgYmVlbiBjcmVhdGVkIHVzaW5nIHNlYXJjaC1yZXBsYWNlLiBNeSBv
bmx5IGZlYXIgaXMKKyAgIHRoYXQgdGhlc2UgY2xhc3NlcyB3aWxsIGdyb3cgb3V0LW9mLXN5
bmMgYXMgb2YgYSByZXN1bHQgb2YgY2hhbmdlcworICAgdGhhdCBhcmUgbm90IHByb3BhZ2F0
ZWQgdG8gdGhlIG90aGVyIGZpbGVzLiBBcyBhbHdheXMsIG1pcnJvcmluZworICAgY29kZSBp
cyBhIG1haW50ZW5hbmNlIG5pZ2h0bWFyZS4gICovCisKKy8qKgorICogQGF1dGhvciBSb2xm
IFcuIFJhc211c3NlbiA8cm9sZndyQGlpLnVpYi5ubz4KKyAqLworcHVibGljIGZpbmFsIGNs
YXNzIERhdGFCdWZmZXJTaG9ydCBleHRlbmRzIERhdGFCdWZmZXIKK3sKKyAgcHJpdmF0ZSBz
aG9ydFtdIGRhdGE7CisgIHByaXZhdGUgc2hvcnRbXVtdIGJhbmtEYXRhOworICAKKyAgcHVi
bGljIERhdGFCdWZmZXJTaG9ydChpbnQgc2l6ZSkKKyAgeworICAgIHN1cGVyKFRZUEVfU0hP
UlQsIHNpemUpOworICAgIGRhdGEgPSBuZXcgc2hvcnRbc2l6ZV07CisgIH0KKworICBwdWJs
aWMgRGF0YUJ1ZmZlclNob3J0KGludCBzaXplLCBpbnQgbnVtQmFua3MpCisgIHsKKyAgICBz
dXBlcihUWVBFX1NIT1JULCBzaXplLCBudW1CYW5rcyk7CisgICAgYmFua0RhdGEgPSBuZXcg
c2hvcnRbbnVtQmFua3NdW3NpemVdOworICAgIGRhdGEgPSBiYW5rRGF0YVswXTsKKyAgfQor
CisgIHB1YmxpYyBEYXRhQnVmZmVyU2hvcnQoc2hvcnRbXSBkYXRhQXJyYXksIGludCBzaXpl
KQorICB7CisgICAgc3VwZXIoVFlQRV9TSE9SVCwgc2l6ZSk7CisgICAgZGF0YSA9IGRhdGFB
cnJheTsKKyAgfQorICAgIAorICBwdWJsaWMgRGF0YUJ1ZmZlclNob3J0KHNob3J0W10gZGF0
YUFycmF5LCBpbnQgc2l6ZSwgaW50IG9mZnNldCkKKyAgeworICAgIHN1cGVyKFRZUEVfU0hP
UlQsIHNpemUsIDEsIG9mZnNldCk7CisgICAgZGF0YSA9IGRhdGFBcnJheTsKKyAgfQorCisg
IHB1YmxpYyBEYXRhQnVmZmVyU2hvcnQoc2hvcnRbXVtdIGRhdGFBcnJheSwgaW50IHNpemUp
CisgIHsKKyAgICBzdXBlcihUWVBFX1NIT1JULCBzaXplLCBkYXRhQXJyYXkubGVuZ3RoKTsK
KyAgICBiYW5rRGF0YSA9IGRhdGFBcnJheTsKKyAgICBkYXRhID0gYmFua0RhdGFbMF07Cisg
IH0KKworICBwdWJsaWMgRGF0YUJ1ZmZlclNob3J0KHNob3J0W11bXSBkYXRhQXJyYXksIGlu
dCBzaXplLCBpbnRbXSBvZmZzZXRzKQorICB7CisgICAgc3VwZXIoVFlQRV9TSE9SVCwgc2l6
ZSwgZGF0YUFycmF5Lmxlbmd0aCwgb2Zmc2V0cyk7CisgICAgYmFua0RhdGEgPSBkYXRhQXJy
YXk7CisgICAgZGF0YSA9IGJhbmtEYXRhWzBdOworICB9CisKKyAgcHVibGljIHNob3J0W10g
Z2V0RGF0YSgpCisgIHsKKyAgICByZXR1cm4gZGF0YTsKKyAgfQorICAgIAorICBwdWJsaWMg
c2hvcnRbXSBnZXREYXRhKGludCBiYW5rKQorICB7CisgICAgcmV0dXJuIGJhbmtEYXRhW2Jh
bmtdOworICB9CisgICAgCisgIHB1YmxpYyBzaG9ydFtdW10gZ2V0QmFua0RhdGEoKQorICB7
CisgICAgcmV0dXJuIGJhbmtEYXRhOworICB9CisgIAorICBwdWJsaWMgaW50IGdldEVsZW0o
aW50IGkpCisgIHsKKyAgICByZXR1cm4gZGF0YVtpK29mZnNldF07CisgIH0KKworICBwdWJs
aWMgaW50IGdldEVsZW0oaW50IGJhbmssIGludCBpKQorICB7CisgICAgcmV0dXJuIGJhbmtE
YXRhW2JhbmtdW2krb2Zmc2V0c1tiYW5rXV07CisgIH0KKworICBwdWJsaWMgdm9pZCBzZXRF
bGVtKGludCBpLCBpbnQgdmFsKQorICB7CisgICAgZGF0YVtpK29mZnNldF0gPSAoc2hvcnQp
IHZhbDsKKyAgfQorCisgIHB1YmxpYyB2b2lkIHNldEVsZW0oaW50IGJhbmssIGludCBpLCBp
bnQgdmFsKQorICB7CisgICAgYmFua0RhdGFbYmFua11baStvZmZzZXRzW2JhbmtdXSA9IChz
aG9ydCkgdmFsOworICB9Cit9CkluZGV4OiBnbnUvamF2YS9hd3QvQnVmZmVycy5qYXZhCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvZ251
L2phdmEvYXd0L0J1ZmZlcnMuamF2YSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yCmRpZmYg
LXUgLXIxLjIgQnVmZmVycy5qYXZhCi0tLSBnbnUvamF2YS9hd3QvQnVmZmVycy5qYXZhCTIy
IEphbiAyMDAyIDIyOjI2OjU2IC0wMDAwCTEuMgorKysgZ251L2phdmEvYXd0L0J1ZmZlcnMu
amF2YQkxNSBBcHIgMjAwNCAwNzo0MTowNSAtMDAwMApAQCAtMSw0ICsxLDQgQEAKLS8qIENv
cHlyaWdodCAoQykgMjAwMCwgMjAwMiAgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uCisvKiBD
b3B5cmlnaHQgKEMpIDIwMDAsIDIwMDIsIDIwMDQgIEZyZWUgU29mdHdhcmUgRm91bmRhdGlv
bgogCiBUaGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgQ2xhc3NwYXRoLgogCkBAIC04MywxMCAr
ODMsMTYgQEAKICAgICAgIHsKICAgICAgIGNhc2UgRGF0YUJ1ZmZlci5UWVBFX0JZVEU6CiAJ
cmV0dXJuIG5ldyBEYXRhQnVmZmVyQnl0ZShzaXplLCBudW1CYW5rcyk7CisgICAgICBjYXNl
IERhdGFCdWZmZXIuVFlQRV9TSE9SVDoKKwlyZXR1cm4gbmV3IERhdGFCdWZmZXJTaG9ydChz
aXplLCBudW1CYW5rcyk7CiAgICAgICBjYXNlIERhdGFCdWZmZXIuVFlQRV9VU0hPUlQ6CiAJ
cmV0dXJuIG5ldyBEYXRhQnVmZmVyVVNob3J0KHNpemUsIG51bUJhbmtzKTsKICAgICAgIGNh
c2UgRGF0YUJ1ZmZlci5UWVBFX0lOVDoKIAlyZXR1cm4gbmV3IERhdGFCdWZmZXJJbnQoc2l6
ZSwgbnVtQmFua3MpOworICAgICAgY2FzZSBEYXRhQnVmZmVyLlRZUEVfRkxPQVQ6CisJcmV0
dXJuIG5ldyBEYXRhQnVmZmVyRmxvYXQoc2l6ZSwgbnVtQmFua3MpOworICAgICAgY2FzZSBE
YXRhQnVmZmVyLlRZUEVfRE9VQkxFOgorCXJldHVybiBuZXcgRGF0YUJ1ZmZlckRvdWJsZShz
aXplLCBudW1CYW5rcyk7CiAgICAgICBkZWZhdWx0OgogCXRocm93IG5ldyBVbnN1cHBvcnRl
ZE9wZXJhdGlvbkV4Y2VwdGlvbigpOwogICAgICAgfQpAQCAtMTA2LDEwICsxMTIsMTYgQEAK
ICAgICAgIHsKICAgICAgIGNhc2UgRGF0YUJ1ZmZlci5UWVBFX0JZVEU6CiAJcmV0dXJuIG5l
dyBEYXRhQnVmZmVyQnl0ZSgoYnl0ZVtdKSBkYXRhLCBzaXplKTsKKyAgICAgIGNhc2UgRGF0
YUJ1ZmZlci5UWVBFX1NIT1JUOgorCXJldHVybiBuZXcgRGF0YUJ1ZmZlclNob3J0KChzaG9y
dFtdKSBkYXRhLCBzaXplKTsKICAgICAgIGNhc2UgRGF0YUJ1ZmZlci5UWVBFX1VTSE9SVDoK
IAlyZXR1cm4gbmV3IERhdGFCdWZmZXJVU2hvcnQoKHNob3J0W10pIGRhdGEsIHNpemUpOwog
ICAgICAgY2FzZSBEYXRhQnVmZmVyLlRZUEVfSU5UOgogCXJldHVybiBuZXcgRGF0YUJ1ZmZl
ckludCgoaW50W10pIGRhdGEsIHNpemUpOworICAgICAgY2FzZSBEYXRhQnVmZmVyLlRZUEVf
RkxPQVQ6CisJcmV0dXJuIG5ldyBEYXRhQnVmZmVyRmxvYXQoKGZsb2F0W10pIGRhdGEsIHNp
emUpOworICAgICAgY2FzZSBEYXRhQnVmZmVyLlRZUEVfRE9VQkxFOgorCXJldHVybiBuZXcg
RGF0YUJ1ZmZlckRvdWJsZSgoZG91YmxlW10pIGRhdGEsIHNpemUpOwogICAgICAgZGVmYXVs
dDoKIAl0aHJvdyBuZXcgVW5zdXBwb3J0ZWRPcGVyYXRpb25FeGNlcHRpb24oKTsKICAgICAg
IH0KQEAgLTEyNiwxMCArMTM4LDIyIEBACiAgIHsKICAgICBpZiAoYnVmZmVyIGluc3RhbmNl
b2YgRGF0YUJ1ZmZlckJ5dGUpCiAgICAgICByZXR1cm4gKChEYXRhQnVmZmVyQnl0ZSkgYnVm
ZmVyKS5nZXREYXRhKCk7CisKKyAgICBpZiAoYnVmZmVyIGluc3RhbmNlb2YgRGF0YUJ1ZmZl
clNob3J0KQorICAgICAgcmV0dXJuICgoRGF0YUJ1ZmZlclNob3J0KSBidWZmZXIpLmdldERh
dGEoKTsKKwogICAgIGlmIChidWZmZXIgaW5zdGFuY2VvZiBEYXRhQnVmZmVyVVNob3J0KQog
ICAgICAgcmV0dXJuICgoRGF0YUJ1ZmZlclVTaG9ydCkgYnVmZmVyKS5nZXREYXRhKCk7CisK
ICAgICBpZiAoYnVmZmVyIGluc3RhbmNlb2YgRGF0YUJ1ZmZlckludCkKICAgICAgIHJldHVy
biAoKERhdGFCdWZmZXJJbnQpIGJ1ZmZlcikuZ2V0RGF0YSgpOworCisgICAgaWYgKGJ1ZmZl
ciBpbnN0YW5jZW9mIERhdGFCdWZmZXJGbG9hdCkKKyAgICAgIHJldHVybiAoKERhdGFCdWZm
ZXJGbG9hdCkgYnVmZmVyKS5nZXREYXRhKCk7CisKKyAgICBpZiAoYnVmZmVyIGluc3RhbmNl
b2YgRGF0YUJ1ZmZlckRvdWJsZSkKKyAgICAgIHJldHVybiAoKERhdGFCdWZmZXJEb3VibGUp
IGJ1ZmZlcikuZ2V0RGF0YSgpOworCiAgICAgdGhyb3cgbmV3IENsYXNzQ2FzdEV4Y2VwdGlv
bigiVW5rbm93biBkYXRhIGJ1ZmZlciB0eXBlIik7CiAgIH0KIApAQCAtMTQ5LDYgKzE3Mywx
MSBAQAogCWZyb20gPSAoKERhdGFCdWZmZXJCeXRlKSBzcmMpLmdldERhdGEoKTsKIAlpZiAo
ZGVzdCA9PSBudWxsKSBkZXN0ID0gbmV3IGJ5dGVbbGVuZ3RoK2Rlc3RPZmZzZXRdOwogICAg
ICAgfQorICAgIGVsc2UgaWYgKHNyYyBpbnN0YW5jZW9mIERhdGFCdWZmZXJTaG9ydCkKKyAg
ICAgIHsKKwlmcm9tID0gKChEYXRhQnVmZmVyU2hvcnQpIHNyYykuZ2V0RGF0YSgpOworCWlm
IChkZXN0ID09IG51bGwpIGRlc3QgPSBuZXcgc2hvcnRbbGVuZ3RoK2Rlc3RPZmZzZXRdOwor
ICAgICAgfQogICAgIGVsc2UgaWYgKHNyYyBpbnN0YW5jZW9mIERhdGFCdWZmZXJVU2hvcnQp
CiAgICAgICB7CiAJZnJvbSA9ICgoRGF0YUJ1ZmZlclVTaG9ydCkgc3JjKS5nZXREYXRhKCk7
CkBAIC0xNTgsNiArMTg3LDE2IEBACiAgICAgICB7CiAJZnJvbSA9ICgoRGF0YUJ1ZmZlcklu
dCkgc3JjKS5nZXREYXRhKCk7CiAJaWYgKGRlc3QgPT0gbnVsbCkgZGVzdCA9IG5ldyBpbnRb
bGVuZ3RoK2Rlc3RPZmZzZXRdOworICAgICAgfQorICAgIGVsc2UgaWYgKHNyYyBpbnN0YW5j
ZW9mIERhdGFCdWZmZXJGbG9hdCkKKyAgICAgIHsKKwlmcm9tID0gKChEYXRhQnVmZmVyRmxv
YXQpIHNyYykuZ2V0RGF0YSgpOworCWlmIChkZXN0ID09IG51bGwpIGRlc3QgPSBuZXcgZmxv
YXRbbGVuZ3RoK2Rlc3RPZmZzZXRdOworICAgICAgfQorICAgIGVsc2UgaWYgKHNyYyBpbnN0
YW5jZW9mIERhdGFCdWZmZXJEb3VibGUpCisgICAgICB7CisJZnJvbSA9ICgoRGF0YUJ1ZmZl
ckRvdWJsZSkgc3JjKS5nZXREYXRhKCk7CisJaWYgKGRlc3QgPT0gbnVsbCkgZGVzdCA9IG5l
dyBkb3VibGVbbGVuZ3RoK2Rlc3RPZmZzZXRdOwogICAgICAgfQogICAgIGVsc2UKICAgICAg
IHsK
--==_20040415074821.24817-1_==--




From MAILER-DAEMON Thu Apr 15 09:23:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BE6qS-0003Oy-VN
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 09:23:56 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BE6qG-0003MG-8D
	for classpath@gnu.org; Thu, 15 Apr 2004 09:23:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BE6pf-0003Aq-8X
	for classpath@gnu.org; Thu, 15 Apr 2004 09:23:38 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BE6pe-00037S-Ut
	for classpath@gnu.org; Thu, 15 Apr 2004 09:23:07 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 15 Apr 2004 15:22:56 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADDE0@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Wrapping all native methods in VM... classes
Thread-Index: AcQh+ppLJL7D5AYkSpOusFBXqTEAqgA8cQEg
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Ewout Prangsma" <ewout@prangsma.net>,
	<classpath@gnu.org>
Cc: 
Subject: RE: Wrapping all native methods in VM... classes
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 13:23:46 -0000

Ewout Prangsma wrote:
> In JNode we're also using a version of classpath, which I'm=20
> trying to get as close to the latest classpath version as
> possible.
> A topic that makes this difficult is that there are a lot of=20
> native methods in the normal classes (e.g. java.lang.Double).
> Since JNode does not use native method (except in 1 VM
> specific class), I'm stuck with lots of diffs.
>=20
> Is it possible to move all the native methods to these VM....=20
> classes so every VM can decide whether to use native or
> something else?

This is a (long term) goal for Classpath. It is somewhat complicated by
the fact that the people that really want this, don't use the Classpath
native JNI code, so they cannot test the rewritten JNI code on their own
VM. At least this is what's holding me back...

> If needed i don't mind to help out to get this done.

Patches are welcome, but I think they are unlikely to be accepted unless
you also modify (and test) the JNI code.

Regards,
Jeroen



From MAILER-DAEMON Thu Apr 15 10:23:47 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BE7mN-0001VE-Fk
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 10:23:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BE7mJ-0001Tk-UU
	for classpath@gnu.org; Thu, 15 Apr 2004 10:23:43 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BE7hG-00007L-3I
	for classpath@gnu.org; Thu, 15 Apr 2004 10:19:02 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BE7d1-0007OI-Kd
	for classpath@gnu.org; Thu, 15 Apr 2004 10:14:07 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3FEE2u6030586;
	Thu, 15 Apr 2004 10:14:02 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3FEE2j07560; 
	Thu, 15 Apr 2004 10:14:02 -0400
Received: from to-dhcp28.toronto.redhat.com (to-dhcp28.toronto.redhat.com
	[172.16.14.128])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i3FEE1cU032057; Thu, 15 Apr 2004 10:14:01 -0400
From: Anthony Green <green@redhat.com>
To: Jonathan Pryor <jonpryor@vt.edu>
In-Reply-To: <1081997254.6432.2.camel@localhost.localdomain>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
	<1081881703.4890.22.camel@elsschot.wildebeest.org>
	<407C3787.2090704@netreach.com>
	<1081894138.19677.8.camel@localhost.localdomain>
	<1081953000.3425.6.camel@escape>
	<1081997254.6432.2.camel@localhost.localdomain>
Content-Type: text/plain
Organization: Red Hat, Inc.
Message-Id: <1082016551.4846.8.camel@escape>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Thu, 15 Apr 2004 07:14:00 -0700
Content-Transfer-Encoding: 7bit
Cc: mono-list <mono-list@lists.ximian.com>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>, classpath@gnu.org,
	Stuart Ballard <sballard@netreach.com>
Subject: Re: [Mono-list] Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 14:23:45 -0000

On Wed, 2004-04-14 at 19:47, Jonathan Pryor wrote:
> Below...
> 
> On Wed, 2004-04-14 at 10:30, Anthony Green wrote:
> > On Tue, 2004-04-13 at 15:08, Jonathan Pryor wrote:
> > > AOT (or pre-JITing) assemblies is not as useful as you'd think.  It has
> > > two primary effects:
> > > 
> > >   - Reduce memory requirements, as memory doesn't need to be allocated
> > >     for the JITed code
> > >   - Decrease startup time, as (again) the JITing doesn't need to be 
> > >     done.
> > 
> > Are you saying that mono doesn't have the ability to create shared
> > libraries?
> 
> How did you get that interpretation from my statements?  It boggles my
> mind...

Because you didn't mention the key advantage that you get from
AOT-compiled shared libraries: saving memory from sharing library code
between processes.  You're only two points were about saving time and
memory from not having to JIT compile code.

AG

-- 
Anthony Green <green@redhat.com>
Red Hat, Inc.




From MAILER-DAEMON Thu Apr 15 11:06:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BE7e8-0007kF-Eu
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 10:15:16 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BE5pl-00033r-DU
	for classpath@gnu.org; Thu, 15 Apr 2004 08:19:09 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BE5p8-0002yA-NF
	for classpath@gnu.org; Thu, 15 Apr 2004 08:19:01 -0400
Received: from [207.180.207.241] (helo=gm004.hawken.edu)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BE5bK-0000rh-Mq
	for classpath@gnu.org; Thu, 15 Apr 2004 08:04:14 -0400
Received: from HawkSchl-MTA by gm004.hawken.edu
	with Novell_GroupWise; Thu, 15 Apr 2004 08:04:13 -0400
Message-Id: <s07e41fd.066@gm004.hawken.edu>
X-Mailer: Novell GroupWise Internet Agent 6.0.2
Date: Thu, 15 Apr 2004 08:04:04 -0400
From: "Ben Maurer" <05mauben@hawken.edu>
To: <green@redhat.com>,<jonpryor@vt.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-Mailman-Approved-At: Thu, 15 Apr 2004 10:15:13 -0400
Cc: mono-list@lists.ximian.com, mark@klomp.org, jeroen@sumatra.nl,
	classpath@gnu.org, sballard@netreach.com
Subject: Re: [Mono-list] Re: The Mauve unicode testcase and VM
	performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 12:34:51 -0000

No, he is not.

YOu can run

mono -O=shared my.exe

or, if you would like to aot:
mono -O=shared --aot my.exe

However, as miguel stated earlier, the need for shared code is very
rare. What shared means here is that the same code can be used by
multiple appdomains (look that up if you are not familar with the .NET
appdomain system). The use of this functionality is pretty rare, the
only example I can think of is ASP.net.

-- Ben

>>> Anthony Green <green@redhat.com> 04/15/04 04:21 AM >>>
On Tue, 2004-04-13 at 15:08, Jonathan Pryor wrote:
> AOT (or pre-JITing) assemblies is not as useful as you'd think.  It
has
> two primary effects:
> 
>   - Reduce memory requirements, as memory doesn't need to be allocated
>     for the JITed code
>   - Decrease startup time, as (again) the JITing doesn't need to be 
>     done.

Are you saying that mono doesn't have the ability to create shared
libraries?

AG

-- 
Anthony Green <green@redhat.com>
Red Hat, Inc.

_______________________________________________
Mono-list maillist  -  Mono-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-list




From MAILER-DAEMON Thu Apr 15 13:49:00 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEAyx-0007nX-PR
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 13:48:59 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEAyu-0007m3-C8
	for classpath@gnu.org; Thu, 15 Apr 2004 13:48:56 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEAyL-0007V5-Kp
	for classpath@gnu.org; Thu, 15 Apr 2004 13:48:54 -0400
Received: from [62.131.71.108] (helo=server.intern.prangsma.net)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BEAyK-0006zt-ST
	for classpath@gnu.org; Thu, 15 Apr 2004 13:48:21 -0400
Received: (qmail 15859 invoked from network); 15 Apr 2004 17:49:15 -0000
Received: from unknown (HELO lt1epr) (192.168.253.96)
	by 192.168.253.110 with SMTP; 15 Apr 2004 17:49:15 -0000
Message-ID: <001101c42311$b8f0c6e0$60fda8c0@lt1epr>
From: "Ewout Prangsma" <ewout@prangsma.net>
To: <classpath@gnu.org>
Date: Thu, 15 Apr 2004 19:47:29 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1409
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Subject: System.getProperty & SecurityManager
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 17:48:57 -0000

Hi all,

I've noticed lots of System.getProperty calls in classpath.
These calls can throw security exceptions when a security manager is active.

To avoid this wrap the getProperty call in a PrivilegedAction. I've written
some helper classes to avoid retyping that every time. I'm happy to send
them.

PS. The security manager also causes other issues, but getProperty is most
frequent.

Ewout




From MAILER-DAEMON Thu Apr 15 14:38:29 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEBkr-0004xV-6s
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 14:38:29 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEBkn-0004w3-6D
	for classpath@gnu.org; Thu, 15 Apr 2004 14:38:25 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEBVJ-0001LZ-Qf
	for classpath@gnu.org; Thu, 15 Apr 2004 14:22:57 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BEBVG-0001KS-Vz
	for classpath@gnu.org; Thu, 15 Apr 2004 14:22:23 -0400
Received: (qmail 13810 invoked from network); 15 Apr 2004 18:24:43 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 15 Apr 2004 18:24:43 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id E1C484F82A2; Thu, 15 Apr 2004 12:10:43 -0600 (MDT)
To: "Ewout Prangsma" <ewout@prangsma.net>
References: <001101c42311$b8f0c6e0$60fda8c0@lt1epr>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: All I can think of is a platter of organic PRUNE CRISPS being trampled
	by an army of swarthy, Italian LOUNGE SINGERS...
Date: 15 Apr 2004 12:10:43 -0600
In-Reply-To: <001101c42311$b8f0c6e0$60fda8c0@lt1epr>
Message-ID: <873c75xgbg.fsf@fleche.redhat.com>
Lines: 19
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: System.getProperty & SecurityManager
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 18:38:26 -0000

>>>>> "Ewout" == Ewout Prangsma <ewout@prangsma.net> writes:

Ewout> I've noticed lots of System.getProperty calls in classpath.
Ewout> These calls can throw security exceptions when a security
Ewout> manager is active.

Ewout> To avoid this wrap the getProperty call in a
Ewout> PrivilegedAction. I've written some helper classes to avoid
Ewout> retyping that every time. I'm happy to send them.

Ewout> PS. The security manager also causes other issues, but
Ewout> getProperty is most frequent.

The security manager code hasn't been used very much.  It's great that
you're trying this out.  We're definitely interested in patches to
wrap these calls.  In some cases it would also be good to just cache
the result...

Tom



From MAILER-DAEMON Thu Apr 15 15:31:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BECaS-0000xV-Dy
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 15:31:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEC8O-0004vT-NW
	for classpath@gnu.org; Thu, 15 Apr 2004 15:02:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEC7m-0004dR-5D
	for classpath@gnu.org; Thu, 15 Apr 2004 15:02:41 -0400
Received: from [130.57.169.10] (helo=peabody.ximian.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BEC7l-0004ch-Ai
	for classpath@gnu.org; Thu, 15 Apr 2004 15:02:09 -0400
Received: (qmail 3822 invoked from network); 15 Apr 2004 19:02:08 -0000
Received: from peabody.ximian.com (HELO localhost.localdomain) (130.57.169.10)
	by peabody.ximian.com with SMTP; 15 Apr 2004 19:02:08 -0000
Received: by localhost.localdomain (Postfix, from userid 500)
	id E3045438492; Thu, 15 Apr 2004 15:02:06 -0400 (EDT)
From: Miguel de Icaza <miguel@ximian.com>
To: Anthony Green <green@redhat.com>
In-Reply-To: <1082016551.4846.8.camel@escape>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADD97@LEMBU.sumatrasoftware.com>
	<1081881703.4890.22.camel@elsschot.wildebeest.org>
	<407C3787.2090704@netreach.com>
	<1081894138.19677.8.camel@localhost.localdomain>
	<1081953000.3425.6.camel@escape>
	<1081997254.6432.2.camel@localhost.localdomain>
	<1082016551.4846.8.camel@escape>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Message-Id: <1082055726.4737.71.camel@erandi.boston.ximian.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Thu, 15 Apr 2004 15:02:06 -0400
X-Mailman-Approved-At: Thu, 15 Apr 2004 15:31:46 -0400
Cc: Jonathan Pryor <jonpryor@vt.edu>, Mark Wielaard <mark@klomp.org>,
	Jeroen Frijters <jeroen@sumatra.nl>, classpath@gnu.org,
	Stuart Ballard <sballard@netreach.com>,
	mono-list <mono-list@lists.ximian.com>
Subject: Re: [Mono-list] Re: The Mauve unicode testcase and VM performance
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 19:04:26 -0000

Hello,

> Because you didn't mention the key advantage that you get from
> AOT-compiled shared libraries: saving memory from sharing library code
> between processes.  You're only two points were about saving time and
> memory from not having to JIT compile code.

Ah, that is correct, and I had at least completely ignored that fact. 

Using --aot will indeed use shared mapping between various Mono
processes, so it is an extra advantage.

Miguel



From MAILER-DAEMON Thu Apr 15 17:10:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEE8H-00033J-JJ
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 17:10:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEE86-0002yU-TG
	for classpath@gnu.org; Thu, 15 Apr 2004 17:10:38 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEE81-0002uR-GC
	for classpath@gnu.org; Thu, 15 Apr 2004 17:10:35 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BEE80-0002u3-Jf
	for classpath@gnu.org; Thu, 15 Apr 2004 17:10:32 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BEE7t-0005oB-00; Thu, 15 Apr 2004 23:10:25 +0200
From: Mark Wielaard <mark@klomp.org>
To: Thomas Zander <zander@javalobby.org>
In-Reply-To: <200404110848.06673.zander@javalobby.org>
References: <200404060956.14298.zander@javalobby.org>
	<200404082150.24907.konqueror@gmx.de>
	<16501.44635.43431.486147@cuddles.cambridge.redhat.com>
	<200404110848.06673.zander@javalobby.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-1P7BDX4XB/F92xXAh7i2"
Message-Id: <1082063426.1986.14.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Thu, 15 Apr 2004 23:10:26 +0200
Cc: GNU Classpath <classpath@gnu.org>, mauve-discuss@sources.redhat.com
Subject: Re: Mauve patches.
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 21:10:41 -0000


--=-1P7BDX4XB/F92xXAh7i2
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Thomas,

On Sun, 2004-04-11 at 08:48, Thomas Zander wrote:
> Oh; and a explanation of the correct changelog format; or a link to that=20
> since you said there was something wrong with it; but I don't know what.

Look at the new and improved GNU Classpath Hackers Guide:
(7.1 Documenting what changed when with ChangeLog entries)
http://www.gnu.org/software/classpath/docs/hacking.html#SEC9

> Hope to hear from you; Mauve is growing way too slow for my taste this wa=
y.

My apologies for not following up on this sooner.
I am happy that Andrew helped you out.

Your help is really appreciated. Especially since we are all short on
time. So, please don't see the slow reactions as rejections of your
work. I am really, really happy you want to pick this up and make it
easier for others. Mauve is very important but indeed far to difficult
to setup and hack on.

Thanks,

Mark

--=-1P7BDX4XB/F92xXAh7i2
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAfvpBxVhZCJWr9QwRAp+mAKCQ5Jcqx0udsWcHKyQFv8d/ny3DFgCeNtEu
IiZPRaDs9MV9VnYf730RPss=
=Xf/Q
-----END PGP SIGNATURE-----

--=-1P7BDX4XB/F92xXAh7i2--




From MAILER-DAEMON Thu Apr 15 19:06:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEFwA-0001JV-Ka
	for mharc-classpath@gnu.org; Thu, 15 Apr 2004 19:06:26 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEFvy-0001Ev-FT
	for classpath@gnu.org; Thu, 15 Apr 2004 19:06:14 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEFvP-0000z4-7B
	for classpath@gnu.org; Thu, 15 Apr 2004 19:06:10 -0400
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BEFvO-0000vp-3y
	for classpath@gnu.org; Thu, 15 Apr 2004 19:05:38 -0400
Received: from dholmeslaptop (dholmes.dltech.com.au [203.222.72.2])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i3FN15eI031592;
	Fri, 16 Apr 2004 09:01:17 +1000 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "Ewout Prangsma" <ewout@prangsma.net>, <classpath@gnu.org>
Date: Fri, 16 Apr 2004 09:01:26 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCKECNEBAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
In-reply-to: <001101c42311$b8f0c6e0$60fda8c0@lt1epr>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Importance: Normal
Cc: 
Subject: RE: System.getProperty & SecurityManager
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 23:06:22 -0000

> I've noticed lots of System.getProperty calls in classpath.
> These calls can throw security exceptions when a security manager
> is active.

Yes they can. Are you saying they shouldn't? Perhaps some shouldn't, or need
not, but you'd have to go through an establish which ones.

> To avoid this wrap the getProperty call in a PrivilegedAction.

If the code is in java.lang then it can access the system properties
directly to avoid the security check. This is already done in a number of
places.

David Holmes




From MAILER-DAEMON Fri Apr 16 02:28:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEMpj-00072i-En
	for mharc-classpath@gnu.org; Fri, 16 Apr 2004 02:28:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEMpZ-0006lw-EA
	for classpath@gnu.org; Fri, 16 Apr 2004 02:28:05 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEMp1-00064e-TC
	for classpath@gnu.org; Fri, 16 Apr 2004 02:28:04 -0400
Received: from [62.131.71.108] (helo=server.intern.prangsma.net)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BEMp1-00062d-06
	for classpath@gnu.org; Fri, 16 Apr 2004 02:27:31 -0400
Received: (qmail 26383 invoked from network); 16 Apr 2004 06:29:32 -0000
Received: from unknown (HELO lt1epr) (192.168.253.96)
	by 192.168.253.110 with SMTP; 16 Apr 2004 06:29:32 -0000
Message-ID: <003a01c4237b$ee1e4fd0$60fda8c0@lt1epr>
From: "Ewout Prangsma" <ewout@prangsma.net>
To: <classpath@gnu.org>,
	<tromey@redhat.com>
References: <001101c42311$b8f0c6e0$60fda8c0@lt1epr>
	<873c75xgbg.fsf@fleche.redhat.com>
Date: Fri, 16 Apr 2004 08:27:44 +0200
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="----=_NextPart_000_0037_01C4238C.B143CA20"
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1409
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Cc: 
Subject: Re: System.getProperty & SecurityManager ; patches
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2004 06:28:06 -0000

This is a multi-part message in MIME format.

------=_NextPart_000_0037_01C4238C.B143CA20
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit

Hi all,

I've attached the utilities classes and listed the placed that need
patching.
I'm sorry i'm not able to send you normal patch files, I've got a bit too
much changed for that still.

The principle is very simple.
Replace every
System.getProperty(..)
with
(String)AccessController.doPrivileged(new GetPropertyAction(key[, default]))


Here are the places i've found so far.


gnu.java.io.EncodingManager#<clinit>:

encoding_path = (String) AccessController.doPrivileged(new
GetPropertyAction("file.encoding.pkg"));

String default_encoding = (String) AccessController.doPrivileged(new
GetPropertyAction("file.encoding", "8859_1"));


gnu.java.io.EncodingManager#findDecoderConstructor(String, boolean):
String alias = (String) AccessController.doPrivileged(new
GetPropertyAction("gnu.java.io.encoding_scheme_alias." encoding));

gnu.java.io.EncodingManager#findEncoderConstructor(String, boolean):
String alias = (String) AccessController.doPrivileged(new
GetPropertyAction("gnu.java.io.encoding_scheme_alias."+ encoding));

gnu.java.net.protocol.http.Connection#<clinit>:
static {
// Recognize some networking properties listed at
// http://java.sun.com/j2se/1.4/docs/guide/net/properties.html.
proxyHost = (String)AccessController.doPrivileged(new
GetPropertyAction("http.proxyHost"));
if (proxyHost != null) {
proxyInUse = true;
final String port;
port = (String)AccessController.doPrivileged(new
GetPropertyAction("http.proxyPort"));
if (port != null) {
try {
proxyPort = Integer.parseInt(port);
} catch (Throwable t) {
// Nothing.
}
}
}
}

gnu.java.net.protocol.http.Connection#sendRequest:
if (getRequestProperty("user-agent") == null) {
// @classpath-bugfix
final String version = (String)AccessController.doPrivileged(new
GetPropertyAction("classpath.version"));
setRequestProperty("user-agent", "gnu-classpath/" + version);
}


java.awt.Toolkit#getDefaultToolkit:
final String toolkit_name = (String)AccessController.doPrivileged(new
GetPropertyAction("awt.toolkit", default_toolkit_name));

java.net.URL#<clinit>:
static {
final String s = (String) AccessController
.doPrivileged(new GetPropertyAction(
"gnu.java.net.nocache_protocol_handlers"));
cache_handlers = (s == null);
ph_search_path = (String) AccessController
.doPrivileged(new GetPropertyAction(
"java.protocol.handler.pkgs"));
// Tack our default package on at the ends
if (ph_search_path != null) {
ph_search_path = "org.jnode.protocol" + "|" + ph_search_path + "|"
+ "gnu.java.net.protocol";
} else {
ph_search_path = "org.jnode.protocol" + "|"
+ "gnu.java.net.protocol";
}
}

java.util.Locale#<clinit>:
private static Locale defaultLocale;
static {
final String lang = (String)AccessController.doPrivileged(new
GetPropertyAction("user.language", "en"));
final String region = (String)AccessController.doPrivileged(new
GetPropertyAction("user.region", ""));
final String variant= (String)AccessController.doPrivileged(new
GetPropertyAction("user.variant", ""));
defaultLocale = new Locale(lang, region, variant);
}
java.util.TimeZone#<clinit>:
static {
String tzid = (String)AccessController.doPrivileged(new
GetPropertyAction("user.timezone"));


Ewout

------=_NextPart_000_0037_01C4238C.B143CA20
Content-Type: application/octet-stream;
	name="SetPropertyAction.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="SetPropertyAction.java"

/*
 * $Id: SetPropertyAction.java,v 1.1 2004/03/14 09:20:08 epr Exp $
 */
package gnu.java.security.actions;

import java.security.PrivilegedAction;


/**
 * Utility class for setting properties in a privileged action.
 * 
 * @author Ewout Prangsma (epr@users.sourceforge.net)
 */
public class SetPropertyAction implements PrivilegedAction {

    private final String key;
    private final String value;
    
    /**
     * Initialize this instance.
     * @param key
     */
    public SetPropertyAction(String key, String value) {
        this.key = key;
        this.value = value;
    }
    
    /**
     * Set the property
     * @see java.security.PrivilegedAction#run()
     */
    public Object run() {
        System.setProperty(key, value);
        return null;
    }
}

------=_NextPart_000_0037_01C4238C.B143CA20
Content-Type: application/octet-stream;
	name="GetBooleanAction.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="GetBooleanAction.java"

/*
 * $Id: GetBooleanAction.java,v 1.1 2004/03/14 09:20:08 epr Exp $
 */
package gnu.java.security.actions;

import java.security.PrivilegedAction;

/**
 * Utility class for getting Boolean properties in a privileged action.
 * 
 * @see Boolean#getBoolean(String)
 * @author Ewout Prangsma (epr@users.sourceforge.net)
 */
public class GetBooleanAction implements PrivilegedAction {

    private final String key;

    public GetBooleanAction(String key) {
        this.key = key;
    }

    /**
     * @see java.security.PrivilegedAction#run()
     */
    public Object run() {
        return Boolean.valueOf(Boolean.getBoolean(key));
    }
}

------=_NextPart_000_0037_01C4238C.B143CA20
Content-Type: application/octet-stream;
	name="GetIntegerAction.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="GetIntegerAction.java"

/*
 * $Id: GetIntegerAction.java,v 1.1 2004/03/14 09:20:08 epr Exp $
 */
package gnu.java.security.actions;

import java.security.PrivilegedAction;


/**
 * Utility class for getting Integer properties in a privileged action.
 * 
 * @see Integer#getInteger(String, Integer)
 * @author Ewout Prangsma (epr@users.sourceforge.net)
 */
public class GetIntegerAction implements PrivilegedAction {

    private final String key;
    private final Integer defaultValue;
    
    public GetIntegerAction(String key) {
        this(key, null);
    }
    
    public GetIntegerAction(String key, int defaultValue) {
        this(key, new Integer(defaultValue));
    }

    public GetIntegerAction(String key, Integer defaultValue) {
        this.key = key;
        this.defaultValue = defaultValue;
    }
    
    /**
     * @see java.security.PrivilegedAction#run()
     */
    public Object run() {
        return Integer.getInteger(key, defaultValue);
    }
}

------=_NextPart_000_0037_01C4238C.B143CA20
Content-Type: application/octet-stream;
	name="GetPolicyAction.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="GetPolicyAction.java"

/*
 * $Id: GetPolicyAction.java,v 1.1 2004/03/14 09:20:08 epr Exp $
 */
package gnu.java.security.actions;

import java.security.Policy;
import java.security.PrivilegedAction;

/**
 * Utility class for getting the current Policy in a privileged action.
 * 
 * @see java.security.Policy
 * @author Ewout Prangsma (epr@users.sourceforge.net)
 */
public class GetPolicyAction implements PrivilegedAction {

    private static final GetPolicyAction instance = new GetPolicyAction();
    
    /**
     * Gets the single instance of this class.
     * @return
     */
    public static GetPolicyAction getInstance() {
        return instance;
    }
    
    /**
     * @see java.security.PrivilegedAction#run()
     */
    public Object run() {
        return Policy.getPolicy();
    }
    
    /**
     * Singleton constructor.
     */
    private GetPolicyAction() {
        // Do nothing
    }
}

------=_NextPart_000_0037_01C4238C.B143CA20
Content-Type: application/octet-stream;
	name="GetPropertiesAction.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="GetPropertiesAction.java"

/*
 * $Id: GetPropertiesAction.java,v 1.1 2004/03/14 09:20:08 epr Exp $
 */
package gnu.java.security.actions;

import java.security.PrivilegedAction;


/**
 * Utility class for getting all system properties in a privileged action.
 * 
 * @author Ewout Prangsma (epr@users.sourceforge.net)
 */
public class GetPropertiesAction implements PrivilegedAction {

    /**
     * @see java.security.PrivilegedAction#run()
     */
    public Object run() {
        return System.getProperties();
    }
}

------=_NextPart_000_0037_01C4238C.B143CA20
Content-Type: application/octet-stream;
	name="GetPropertyAction.java"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="GetPropertyAction.java"

/*
 * $Id: GetPropertyAction.java,v 1.1 2004/03/14 09:20:08 epr Exp $
 */
package gnu.java.security.actions;

import java.security.PrivilegedAction;


/**
 * Utility class for getting properties in a privileged action.
 * 
 * @author Ewout Prangsma (epr@users.sourceforge.net)
 */
public class GetPropertyAction implements PrivilegedAction {
    
    private final String key;
    private final String defaultValue;
    
    /**
     * Initialize this instance.
     * @param key
     */
    public GetPropertyAction(String key) {
        this(key, null);
    }
    
    /**
     * Initialize this instance.
     * @param key
     */
    public GetPropertyAction(String key, String defaultValue) {
        this.key = key;
        this.defaultValue = defaultValue;
    }
    
    /**
     * Get the property
     * @see java.security.PrivilegedAction#run()
     */
    public Object run() {
        return System.getProperty(key, defaultValue);
    }
}

------=_NextPart_000_0037_01C4238C.B143CA20
Content-Type: application/octet-stream;
	name="InvokeAction.java"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="InvokeAction.java"

/*
 * $Id: InvokeAction.java,v 1.1 2004/03/14 09:20:08 epr Exp $
 */
package gnu.java.security.actions;

import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.security.PrivilegedExceptionAction;


/**
 * Utility class for invoking a method in a privileged action.
 *=20
 * @author Ewout Prangsma (epr@users.sourceforge.net)
 */
public class InvokeAction implements PrivilegedExceptionAction {

    private final Method method;
    private final Object object;
    private final Object[] args;
   =20
    /**
     * Initialize this instance.
     * @param method
     * @param object
     * @param args
     */
    public InvokeAction(Method method, Object object, Object[] args) {
        this.method =3D method;
        this.object =3D object;
        this.args =3D args;
    }
   =20
    /**
     * @see java.security.PrivilegedExceptionAction#run()
     */
    public Object run() throws IllegalAccessException, =
InvocationTargetException {
        return method.invoke(object, args);
    }
}

------=_NextPart_000_0037_01C4238C.B143CA20--




From MAILER-DAEMON Fri Apr 16 04:21:55 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEOYx-0004rc-Qn
	for mharc-classpath@gnu.org; Fri, 16 Apr 2004 04:19:03 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEOXe-0003cg-8N
	for classpath@gnu.org; Fri, 16 Apr 2004 04:17:42 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEOVk-0002fO-4i
	for classpath@gnu.org; Fri, 16 Apr 2004 04:16:15 -0400
Received: from [212.6.122.141] (helo=mail4.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BEOV8-0002Tu-Nm
	for classpath@gnu.org; Fri, 16 Apr 2004 04:15:06 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-042.ewetel.net
	[80.228.94.42])
	by mail4.ewetel.de (8.12.1/8.12.9) with ESMTP id i3G8EnD2006924;
	Fri, 16 Apr 2004 10:14:50 +0200 (MEST)
Received: from asterix.konqueror.de ([192.168.1.3])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BENZB-00011f-00; Fri, 16 Apr 2004 09:15:13 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Ewout Prangsma" <ewout@prangsma.net>, <classpath@gnu.org>,
	<tromey@redhat.com>
Date: Fri, 16 Apr 2004 10:25:34 +0200
User-Agent: KMail/1.5.4
References: <001101c42311$b8f0c6e0$60fda8c0@lt1epr>
	<873c75xgbg.fsf@fleche.redhat.com>
	<003a01c4237b$ee1e4fd0$60fda8c0@lt1epr>
In-Reply-To: <003a01c4237b$ee1e4fd0$60fda8c0@lt1epr>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: clearsigned data
Content-Disposition: inline
Message-Id: <200404161025.41550.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: System.getProperty & SecurityManager ; patches
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2004 08:18:57 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Freitag, 16. April 2004 08:27 schrieb Ewout Prangsma:
> Hi all,
>
> I've attached the utilities classes and listed the placed that need
> patching.
> I'm sorry i'm not able to send you normal patch files, I've got a
> bit too much changed for that still.
>
> The principle is very simple.
> Replace every
> System.getProperty(..)
> with
> (String)AccessController.doPrivileged(new GetPropertyAction(key[,
> default]))

In general thats the right idea and I have thought about it already.=20
The only problem is that AccessController isnt really working yet so=20
this would break classpath totally.


Michael
=2D --=20
Homepage: http://www.worldforge.org/
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAf5iFWSOgCCdjSDsRAqbwAJ9d+rFp8uGTr16/Jo87BqAPr2rqlACcD3BW
=46xkD6mW5NRw+uQ5i1kRjFGs=3D
=3DlK+N
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Fri Apr 16 04:29:35 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEOj9-0003Ze-Dn
	for mharc-classpath@gnu.org; Fri, 16 Apr 2004 04:29:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEOj5-0003Y3-Lt
	for classpath@gnu.org; Fri, 16 Apr 2004 04:29:31 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEOiW-0003H8-WE
	for classpath@gnu.org; Fri, 16 Apr 2004 04:29:28 -0400
Received: from [62.131.71.108] (helo=server.intern.prangsma.net)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BEOiW-0003H2-G0
	for classpath@gnu.org; Fri, 16 Apr 2004 04:28:56 -0400
Received: (qmail 26565 invoked from network); 16 Apr 2004 08:30:58 -0000
Received: from unknown (HELO lt1epr) (192.168.253.96)
	by 192.168.253.110 with SMTP; 16 Apr 2004 08:30:58 -0000
Message-ID: <005c01c4238c$e50acb60$60fda8c0@lt1epr>
From: "Ewout Prangsma" <ewout@prangsma.net>
To: "Michael Koch" <konqueror@gmx.de>, <classpath@gnu.org>, <tromey@redhat.com>
References: <001101c42311$b8f0c6e0$60fda8c0@lt1epr>
	<873c75xgbg.fsf@fleche.redhat.com>
	<003a01c4237b$ee1e4fd0$60fda8c0@lt1epr>
	<200404161025.41550.konqueror@gmx.de>
Date: Fri, 16 Apr 2004 10:29:11 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1409
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Cc: 
Subject: Re: System.getProperty & SecurityManager ; patches
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2004 08:29:33 -0000

Hi,

> In general thats the right idea and I have thought about it already.
> The only problem is that AccessController isnt really working yet so
> this would break classpath totally.

I've checked accesscontroller, it performs a "return action.run()" which
should not break anything.

Ewout



Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAf5iFWSOgCCdjSDsRAqbwAJ9d+rFp8uGTr16/Jo87BqAPr2rqlACcD3BW
FxkD6mW5NRw+uQ5i1kRjFGs=
=lK+N
-----END PGP SIGNATURE-----




From MAILER-DAEMON Fri Apr 16 04:38:46 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEOs1-00070u-AI
	for mharc-classpath@gnu.org; Fri, 16 Apr 2004 04:38:45 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEOrs-0006qz-7w
	for classpath@gnu.org; Fri, 16 Apr 2004 04:38:36 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEOrC-0006MJ-Fv
	for classpath@gnu.org; Fri, 16 Apr 2004 04:38:25 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BEOrC-0006L0-25
	for classpath@gnu.org; Fri, 16 Apr 2004 04:37:54 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-042.ewetel.net
	[80.228.94.42])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i3G8bbnV001852;
	Fri, 16 Apr 2004 10:37:37 +0200 (MEST)
Received: from asterix.konqueror.de ([192.168.1.3])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BENaW-00011n-00; Fri, 16 Apr 2004 09:16:36 +0200
From: Michael Koch <konqueror@gmx.de>
To: tromey@redhat.com, "Ewout Prangsma" <ewout@prangsma.net>
Date: Fri, 16 Apr 2004 10:27:04 +0200
User-Agent: KMail/1.5.4
References: <001101c42311$b8f0c6e0$60fda8c0@lt1epr>
	<873c75xgbg.fsf@fleche.redhat.com>
In-Reply-To: <873c75xgbg.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Description: clearsigned data
Content-Disposition: inline
Message-Id: <200404161027.04398.konqueror@gmx.de>
X-CheckCompat: OK
Cc: classpath@gnu.org
Subject: Re: System.getProperty & SecurityManager
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Apr 2004 08:38:39 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag, 15. April 2004 20:10 schrieb Tom Tromey:
> >>>>> "Ewout" =3D=3D Ewout Prangsma <ewout@prangsma.net> writes:
>
> Ewout> I've noticed lots of System.getProperty calls in classpath.
> Ewout> These calls can throw security exceptions when a security
> Ewout> manager is active.
>
> Ewout> To avoid this wrap the getProperty call in a
> Ewout> PrivilegedAction. I've written some helper classes to avoid
> Ewout> retyping that every time. I'm happy to send them.
>
> Ewout> PS. The security manager also causes other issues, but
> Ewout> getProperty is most frequent.
>
> The security manager code hasn't been used very much.  It's great
> that you're trying this out.  We're definitely interested in
> patches to wrap these calls.  In some cases it would also be good
> to just cache the result...

Caching can be dangerous because the SecurityManager may decide=20
differently depending on who called a method, or the SecurityManager=20
may hav changed totally ... This has to be carefully thought out.


Michael
=2D --=20
Homepage: http://www.worldforge.org/
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAf5jYWSOgCCdjSDsRAnxgAJ4wL3zqKzOTe5uW4HI2CSBalH752ACglJMZ
VMoEhm1iAp8tShl1WAKM05k=3D
=3D8hSM
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Fri Apr 16 20:42:03 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BEduE-0005Wt-7B
	for mharc-classpath@gnu.org; Fri, 16 Apr 2004 20:42:02 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BEdu3-0005KH-PX
	for classpath@gnu.org; Fri, 16 Apr 2004 20:41:51 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BEdtN-0004eq-CS
	for classpath@gnu.org; Fri, 16 Apr 2004 20:41:40 -0400
Received: from [219.160.177.9] (helo=asao.gcd.org)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BEdtM-0004Zd-6o
	for classpath@gnu.org; Fri, 16 Apr 2004 20:41:08 -0400
Received: (qmail 28791 invoked by uid 10); 17 Apr 2004 09:41:04 +0900
Received: (qmail 4154 invoked by uid 1000); 17 Apr 2004 00:40:42 -0000
Message-ID: <20040417004042.4153.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: GNU Classpath <classpath@gnu.org>
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Sat, 17 Apr 2004 09:40:41 +0900
Sender: kaz@maczuka.gcd.org
Subject: Sockets remain unclosed
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Apr 2004 00:41:57 -0000

Hi,

As discussed in the Kaffe mailing list[1],  in some cases,
GNU Classpath's java.net.Socket creates sockets which will
never be closed.

[1] http://www.kaffe.org/pipermail/kaffe/2004-April/045856.html
    http://www.kaffe.org/pipermail/kaffe/2004-April/045866.html

And here is a patch:

ChangeLog entry:
2004-04-16  Helmer Kraemer <hkraemer@freenet.de>
	* libraries/javalib/java/net/Socket.java
	getImpl(): Avoid creating a redundant file descriptor.

--- java/net/Socket.java.orig	Sat Apr 17 08:54:56 2004
+++ java/net/Socket.java	Sat Apr 17 09:26:28 2004
@@ -81,12 +81,6 @@
   private SocketImpl impl;
 
   /**
-   * True if socket implementation was created by calling their
-   * create() method.
-   */
-  private boolean implCreated;
-
-  /**
    * True if the socket is bound.
    */
   private boolean bound;
@@ -312,19 +306,6 @@
   // This has to be accessible from java.net.ServerSocket.
   SocketImpl getImpl() throws SocketException
   {
-    try
-      {
-	if (! implCreated)
-	  {
-	    impl.create(true);
-	    implCreated = true;
-	  }
-      }
-    catch (IOException e)
-      {
-	throw new SocketException(e.getMessage());
-      }
-
     return impl;
   }
 
@@ -358,6 +339,7 @@
     // bind to address/port
     try
       {
+	getImpl().create(true);
 	getImpl().bind(tmp.getAddress(), tmp.getPort());
 	bound = true;
       }



From MAILER-DAEMON Sat Apr 17 11:00:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BErJN-000731-Ko
	for mharc-classpath@gnu.org; Sat, 17 Apr 2004 11:00:53 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BErJK-00071a-HY
	for classpath@gnu.org; Sat, 17 Apr 2004 11:00:50 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BErIo-0006u1-Ey
	for classpath@gnu.org; Sat, 17 Apr 2004 11:00:49 -0400
Received: from [212.6.122.105] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BErIo-0006te-27
	for classpath@gnu.org; Sat, 17 Apr 2004 11:00:18 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-130.ewetel.net
	[80.228.94.130])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i3HExfGS017679;
	Sat, 17 Apr 2004 16:59:43 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BErIE-0001NN-00; Sat, 17 Apr 2004 16:59:42 +0200
From: Michael Koch <konqueror@gmx.de>
To: Ito Kazumitsu <kaz@maczuka.gcd.org>, GNU Classpath <classpath@gnu.org>
Date: Sat, 17 Apr 2004 16:59:20 +0200
User-Agent: KMail/1.5.4
References: <20040417004042.4153.qmail@maczuka.gcd.org>
In-Reply-To: <20040417004042.4153.qmail@maczuka.gcd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404171659.21214.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: Sockets remain unclosed
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Apr 2004 15:00:51 -0000

Am Samstag, 17. April 2004 02:40 schrieb Ito Kazumitsu:
> Hi,
>
> As discussed in the Kaffe mailing list[1],  in some cases,
> GNU Classpath's java.net.Socket creates sockets which will
> never be closed.
>
> [1] http://www.kaffe.org/pipermail/kaffe/2004-April/045856.html
>     http://www.kaffe.org/pipermail/kaffe/2004-April/045866.html

The patch breaks setting/getting socket options on sockets created with 
Socket() or Socket(SocketImpl impl) constructors. The get/set[some 
option] rely on created socket implementations. But with your patch 
they are only created when the socket is locally bound. I know some 
apps that set/get socket options before they do this. And it is valid. 
JDK allows it too.


Michael




From MAILER-DAEMON Sun Apr 18 17:42:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFK41-0002Ki-Ub
	for mharc-classpath@gnu.org; Sun, 18 Apr 2004 17:42:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFK3r-0002E6-HL
	for classpath@gnu.org; Sun, 18 Apr 2004 17:42:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFK17-0000ao-8S
	for classpath@gnu.org; Sun, 18 Apr 2004 17:40:29 -0400
Received: from [219.160.177.9] (helo=asao.gcd.org)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BFK0l-0008PK-5s
	for classpath@gnu.org; Sun, 18 Apr 2004 17:39:35 -0400
Received: (qmail 2026 invoked by uid 10); 19 Apr 2004 06:39:30 +0900
Received: (qmail 2030 invoked by uid 1000); 18 Apr 2004 21:39:23 -0000
Message-ID: <20040418213923.2029.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: GNU Classpath <classpath@gnu.org>
In-reply-to: Your message of "Sat, 17 Apr 2004 16:59:20 +0200"
References: <20040417004042.4153.qmail@maczuka.gcd.org>
	<200404171659.21214.konqueror@gmx.de>
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Mon, 19 Apr 2004 06:39:22 +0900
Sender: kaz@maczuka.gcd.org
Subject: Re: Sockets remain unclosed
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Apr 2004 21:42:49 -0000

>>>>> ":" == Michael Koch <konqueror@gmx.de> writes:

:> The patch breaks setting/getting socket options on sockets created with 
:> Socket() or Socket(SocketImpl impl) constructors. The get/set[some 
:> option] rely on created socket implementations. But with your patch 
:> they are only created when the socket is locally bound. I know some 
:> apps that set/get socket options before they do this. And it is valid. 
:> JDK allows it too.

I understand.

But java.net.Socket creating redundant sockets is a real problem.
Let's look for a solution of this.



From MAILER-DAEMON Mon Apr 19 05:58:22 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFVXi-0003z7-3u
	for mharc-classpath@gnu.org; Mon, 19 Apr 2004 05:58:22 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFVXf-0003ye-Js
	for classpath@gnu.org; Mon, 19 Apr 2004 05:58:19 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFVX9-0003rU-Jk
	for classpath@gnu.org; Mon, 19 Apr 2004 05:58:18 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFVX9-0003qt-7R
	for classpath@gnu.org; Mon, 19 Apr 2004 05:57:47 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BFVX7-0007pS-00
	for <classpath@gnu.org>; Mon, 19 Apr 2004 11:57:45 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BFVWw-0007l7-00
	for <classpath@gnu.org>; Mon, 19 Apr 2004 11:57:34 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i3J9vXLT024500
	for <classpath@gnu.org>; Mon, 19 Apr 2004 11:57:33 +0200 (MEST)
Message-ID: <4083A28D.4@kaffe.org>
Date: Mon, 19 Apr 2004 11:57:33 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: GNU Classpath <classpath@gnu.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Subject: syntax error near unexpected token `PKG_CHECK_MODULES(GTK,
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2004 09:58:20 -0000

Howdy,

I ocassionally try out classpath's configury mechanism, and it always 
breaks down on me, so I must be doing something really 'special' to it.

Since I'm only interested in building the java part of classpath, and 
not the associated native parts, I was wondering how to configure it to 
do that. I've tried

../classpath/configure --with-jikes --disable-gtk-peer --disable-jni

but that tried to execute that PKG_CHECK_MODULES thing, whatever it is. 
It's not part of autotools, so autoreconf did not put it in there :(

Is there a way to do what I'd like to do, or do I have to write my own 
build-script [1]? Or could we just include the m4 code classpath depends 
on in the tree, given that these files are not generated?

They apparently need to be dug out from the web somewhere, where search 
engines do not dare to go :)

cheers,
dalibor topic

[1] build.xml would seem like the obvious choice for PKG_CHECK_MODULES 
challenged users like me :)



From MAILER-DAEMON Mon Apr 19 06:20:29 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFVqb-000114-P8
	for mharc-classpath@gnu.org; Mon, 19 Apr 2004 06:17:53 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFVpy-0000eX-58
	for classpath@gnu.org; Mon, 19 Apr 2004 06:17:14 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFVhM-0006kt-Je
	for classpath@gnu.org; Mon, 19 Apr 2004 06:08:53 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFVd0-0005Zc-6W
	for classpath@gnu.org; Mon, 19 Apr 2004 06:03:50 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BFVcz-00032R-00
	for <classpath@gnu.org>; Mon, 19 Apr 2004 12:03:49 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BFVcx-000327-00; Mon, 19 Apr 2004 12:03:47 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i3JA3kLT028186;
	Mon, 19 Apr 2004 12:03:46 +0200 (MEST)
Message-ID: <4083A402.20708@kaffe.org>
Date: Mon, 19 Apr 2004 12:03:46 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Dalibor Topic <robilad@kaffe.org>
References: <4083A28D.4@kaffe.org>
In-Reply-To: <4083A28D.4@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: syntax error near unexpected token `PKG_CHECK_MODULES(GTK,
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2004 10:17:51 -0000

Dalibor Topic wrote:
> Howdy,
> 
> I ocassionally try out classpath's configury mechanism, and it always 
> breaks down on me, so I must be doing something really 'special' to it.

I've tried the autogen.sh script too, preparing to reach for the brown 
paper bag ...

but nope, that still breaks in the same way.

Something tells me that the PKG_* stuff is in pkg.m4, but for some 
reason it does not get picked up aut either autoreconf, nor autogen.sh

cheers,
dalibor topic



From MAILER-DAEMON Mon Apr 19 06:28:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFW0s-0005CK-LA
	for mharc-classpath@gnu.org; Mon, 19 Apr 2004 06:28:30 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFVzM-00047s-9l
	for classpath@gnu.org; Mon, 19 Apr 2004 06:26:56 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFVyf-0003mo-Bh
	for classpath@gnu.org; Mon, 19 Apr 2004 06:26:45 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFVye-0003mk-Ol
	for classpath@gnu.org; Mon, 19 Apr 2004 06:26:12 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BFVye-0005aJ-00
	for <classpath@gnu.org>; Mon, 19 Apr 2004 12:26:12 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BFVyb-0005a1-00; Mon, 19 Apr 2004 12:26:09 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i3JAQ9LT010554;
	Mon, 19 Apr 2004 12:26:09 +0200 (MEST)
Message-ID: <4083A941.5010703@kaffe.org>
Date: Mon, 19 Apr 2004 12:26:09 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Dalibor Topic <robilad@kaffe.org>
References: <4083A28D.4@kaffe.org> <4083A402.20708@kaffe.org>
In-Reply-To: <4083A402.20708@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: syntax error near unexpected token `PKG_CHECK_MODULES(GTK,
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2004 10:28:25 -0000

Dalibor Topic wrote:
> Dalibor Topic wrote:
> 
>> Howdy,
>>
>> I ocassionally try out classpath's configury mechanism, and it always 
>> breaks down on me, so I must be doing something really 'special' to it.
> 
> 
> I've tried the autogen.sh script too, preparing to reach for the brown 
> paper bag ...
> 
> but nope, that still breaks in the same way.
> 
> Something tells me that the PKG_* stuff is in pkg.m4, but for some 
> reason it does not get picked up aut either autoreconf, nor autogen.sh

The reason is that they are not being told where to look for the 
thrid-party m4 files. No idea if that's something particular to my setup 
(am 1.8.3, ac 2.59, libtool 1.5.6), but an

${ACLOCAL} -I .

in autogen.sh fixes it, as far as I can tell.

Adding a AC_CONFIG_MACRO_DIR([.]) in configure.ac doesn't seem to work 
though. I haven't tried moving the m4 files into their own subdirectory, 
  though.

cheers,
dalibor topic



From MAILER-DAEMON Mon Apr 19 09:42:13 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFZ2K-00027L-Vp
	for mharc-classpath@gnu.org; Mon, 19 Apr 2004 09:42:12 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFYpT-0007G2-B2
	for classpath@gnu.org; Mon, 19 Apr 2004 09:28:55 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFXr5-0004wN-7t
	for classpath@gnu.org; Mon, 19 Apr 2004 08:27:03 -0400
Received: from [24.25.9.103] (helo=ms-smtp-04-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFXp9-0004TJ-Cx
	for classpath@gnu.org; Mon, 19 Apr 2004 08:24:31 -0400
Received: from [10.0.0.2] (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-04-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	i3JCOMC8013593; Mon, 19 Apr 2004 08:24:23 -0400 (EDT)
From: "C. Brian Jones" <cbj@gnu.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <4083A941.5010703@kaffe.org>
References: <4083A28D.4@kaffe.org> <4083A402.20708@kaffe.org>
	<4083A941.5010703@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Qj3kaOfE8o1RudlLT8KS"
Message-Id: <1082377462.3175.67.camel@lyta.haphazard.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Mon, 19 Apr 2004 08:24:22 -0400
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: syntax error near unexpected token `PKG_CHECK_MODULES(GTK,
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: cbj@gnu.org
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2004 13:42:10 -0000


--=-Qj3kaOfE8o1RudlLT8KS
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 2004-04-19 at 06:26, Dalibor Topic wrote:
> Dalibor Topic wrote:
> > Dalibor Topic wrote:
> >=20
> >> Howdy,
> >>
> >> I ocassionally try out classpath's configury mechanism, and it always=20
> >> breaks down on me, so I must be doing something really 'special' to it=
.
> >=20
> >=20
> > I've tried the autogen.sh script too, preparing to reach for the brown=20
> > paper bag ...
> >=20
> > but nope, that still breaks in the same way.
> >=20
> > Something tells me that the PKG_* stuff is in pkg.m4, but for some=20
> > reason it does not get picked up aut either autoreconf, nor autogen.sh
>=20
> The reason is that they are not being told where to look for the=20
> thrid-party m4 files. No idea if that's something particular to my setup=20
> (am 1.8.3, ac 2.59, libtool 1.5.6), but an
>=20
> ${ACLOCAL} -I .
>=20
> in autogen.sh fixes it, as far as I can tell.
>=20
> Adding a AC_CONFIG_MACRO_DIR([.]) in configure.ac doesn't seem to work=20
> though. I haven't tried moving the m4 files into their own subdirectory,=20
>   though.
>=20
> cheers,
> dalibor topic

For some reason, yet unknown, Michael put this macro in pkg.m4 instead
of adding it to acinclude.m4 which is where all our local macros go.=20
Why it would be there, and augogen.sh would not have the appropriate
arguments to pick it up, is beyond me.  It isn't a standard file name, I
checked the 1.7.8 autoconf manual.  It needs to be moved to
acinclude.m4.

As to the configure options you need, it's supposed to be just
--disable-jni for what you want.  However, the link between this option
and the gtk-peer option may be broken, you may need to specify both.

Brian

--=-Qj3kaOfE8o1RudlLT8KS
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQBAg8T1cEcmdY33uzYRAnH4AKCRnmwRqIKkobLzKO/naFngCWu0bQCfe6b4
M63JZbrsEqz1FFSzZ/85RmU=
=EyKQ
-----END PGP SIGNATURE-----

--=-Qj3kaOfE8o1RudlLT8KS--




From MAILER-DAEMON Mon Apr 19 11:32:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFalN-0006Sv-EO
	for mharc-classpath@gnu.org; Mon, 19 Apr 2004 11:32:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFaYM-0003nF-5L
	for classpath@gnu.org; Mon, 19 Apr 2004 11:19:22 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFaRM-0002Ir-FF
	for classpath@gnu.org; Mon, 19 Apr 2004 11:12:40 -0400
Received: from [212.6.122.105] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BFaQo-000293-A6; Mon, 19 Apr 2004 11:11:34 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-93-146.ewetel.net
	[80.228.93.146])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i3JFAkA8028412;
	Mon, 19 Apr 2004 17:10:46 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BFaQC-0004Bd-00; Mon, 19 Apr 2004 17:10:56 +0200
From: Michael Koch <konqueror@gmx.de>
To: cbj@gnu.org, Dalibor Topic <robilad@kaffe.org>
Date: Mon, 19 Apr 2004 17:10:23 +0200
User-Agent: KMail/1.5.4
References: <4083A28D.4@kaffe.org> <4083A941.5010703@kaffe.org>
	<1082377462.3175.67.camel@lyta.haphazard.org>
In-Reply-To: <1082377462.3175.67.camel@lyta.haphazard.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404191710.24672.konqueror@gmx.de>
X-CheckCompat: OK
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: syntax error near unexpected token `PKG_CHECK_MODULES(GTK,
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Apr 2004 15:32:46 -0000

Am Montag, 19. April 2004 14:24 schrieb C. Brian Jones:
> On Mon, 2004-04-19 at 06:26, Dalibor Topic wrote:
> > Dalibor Topic wrote:
> > > Dalibor Topic wrote:
> > >> Howdy,
> > >>
> > >> I ocassionally try out classpath's configury mechanism, and it
> > >> always breaks down on me, so I must be doing something really
> > >> 'special' to it.
> > >
> > > I've tried the autogen.sh script too, preparing to reach for the
> > > brown paper bag ...
> > >
> > > but nope, that still breaks in the same way.
> > >
> > > Something tells me that the PKG_* stuff is in pkg.m4, but for
> > > some reason it does not get picked up aut either autoreconf, nor
> > > autogen.sh
> >
> > The reason is that they are not being told where to look for the
> > thrid-party m4 files. No idea if that's something particular to my
> > setup (am 1.8.3, ac 2.59, libtool 1.5.6), but an
> >
> > ${ACLOCAL} -I .
> >
> > in autogen.sh fixes it, as far as I can tell.
> >
> > Adding a AC_CONFIG_MACRO_DIR([.]) in configure.ac doesn't seem to
> > work though. I haven't tried moving the m4 files into their own
> > subdirectory, though.
> >
> > cheers,
> > dalibor topic
>
> For some reason, yet unknown, Michael put this macro in pkg.m4
> instead of adding it to acinclude.m4 which is where all our local
> macros go. Why it would be there, and augogen.sh would not have the
> appropriate arguments to pick it up, is beyond me.  It isn't a
> standard file name, I checked the 1.7.8 autoconf manual.  It needs to
> be moved to
> acinclude.m4.

This error only occurs on systems where pkk-config is not installed (or 
pkg.m4 is not reachable). The code is in pkg.m4 because this is the 
file we copied over from pkg-config. I would like to not put its 
content into acinclude.m4. This makes maintaining (e.g. updating) it 
harder. Instead we should just add "-I ." to autogen.sh. This adds the 
code to aclocal.m4 and this is all we need.

> As to the configure options you need, it's supposed to be just
> --disable-jni for what you want.  However, the link between this
> option and the gtk-peer option may be broken, you may need to specify
> both.

I will look into this.


Michael




From MAILER-DAEMON Tue Apr 20 03:16:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFpUM-0006O0-JK
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 03:16:14 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFpUJ-0006NR-9h
	for classpath@classpath.org; Tue, 20 Apr 2004 03:16:11 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFpTn-0006GI-KG
	for classpath@classpath.org; Tue, 20 Apr 2004 03:16:10 -0400
Received: from [213.228.0.169] (helo=postfix3-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFpTn-0006G0-4f
	for classpath@classpath.org; Tue, 20 Apr 2004 03:15:39 -0400
Received: from 192.168.1.247 (lns-th2-11-82-64-167-76.adsl.proxad.net
	[82.64.167.76])
	by postfix3-2.free.fr (Postfix) with ESMTP id 66AEDC0DE
	for <classpath@classpath.org>; Tue, 20 Apr 2004 09:15:37 +0200 (CEST)
From: Guilhem Lavaux <guilhem@kaffe.org>
To: classpath@classpath.org
Content-Type: text/plain
Message-Id: <1082445328.5635.55.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4-8mdk 
Date: Tue, 20 Apr 2004 09:15:28 +0200
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Http headers
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 07:16:11 -0000

Hi,

If you try the mauve test URLConnection/Http you may notice there is
failure due to an unknown header "server" which should be "Server".
Apparently to make the search throught header fields independent from
the case we have using toLowerCase for all header keys and values: this
is not right. I suggest we build keep the original value in the array in
HeaderFieldHelper so we are able to return the exact value returned by
the server.

Comments ?

Cheers,

Guilhem.




From MAILER-DAEMON Tue Apr 20 03:23:02 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFpav-0000At-N5
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 03:23:01 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFpat-0000AO-02
	for classpath@gnu.org; Tue, 20 Apr 2004 03:22:59 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFpaM-0008V9-GY
	for classpath@gnu.org; Tue, 20 Apr 2004 03:22:57 -0400
Received: from [213.228.0.176] (helo=postfix4-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFpY6-0007mu-13
	for classpath@gnu.org; Tue, 20 Apr 2004 03:20:06 -0400
Received: from 192.168.1.247 (lns-th2-11-82-64-167-76.adsl.proxad.net
	[82.64.167.76])
	by postfix4-2.free.fr (Postfix) with ESMTP id E98379366B
	for <classpath@gnu.org>; Tue, 20 Apr 2004 09:20:04 +0200 (CEST)
From: Guilhem Lavaux <guilhem@kaffe.org>
To: classpath@gnu.org
Content-Type: multipart/mixed; boundary="=-FeZpGWeZJwCOJIaquTP2"
Message-Id: <1082445596.5640.61.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4-8mdk 
Date: Tue, 20 Apr 2004 09:19:56 +0200
Subject: java.net.URL authority/userInfo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 07:22:59 -0000


--=-FeZpGWeZJwCOJIaquTP2
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,

Here is a patch for URL.java and URLStreamHandler.java to implement
support for authority and cleanup userInfo handling. I have updated a
small testcase in mauve for authority and there does not seem to be any
regression. Please review.

Cheers,

Guilhem.

ChangeLog entry:

2004-04-20  Guilhem Lavaux <guilhem@kaffe.org>

	* java/net/URL.java
	(userInfo): New field.
	(URL): Set authority to the right value.
	(getContent, openStream): Made final as in the Java spec.
	(setURL): Fixed authority and file initialization.
	
	* java/net/URLStreamHandler.java
	(parseURL): Take care of the query tag. Build authority.
	(toExternalForm): Fixed URL building using authority.

--=-FeZpGWeZJwCOJIaquTP2
Content-Disposition: attachment; filename=url_patch
Content-Type: text/x-patch; name=url_patch; charset=
Content-Transfer-Encoding: 7bit

Index: java/net/URL.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/net/URL.java,v
retrieving revision 1.26
diff -u -r1.26 URL.java
--- java/net/URL.java	8 Apr 2004 17:25:02 -0000	1.26
+++ java/net/URL.java	20 Apr 2004 06:27:29 -0000
@@ -141,6 +141,11 @@
   private String host;
 
   /**
+   * The user information necessary to establish the connection.
+   */
+  private String userInfo;
+
+  /**
    * The port number of this protocol or -1 if the port number used is
    * the default for this protocol.
    */
@@ -276,7 +281,9 @@
 
     this.host = host;
     this.port = port;
-    this.authority = null;
+    this.authority = (host != null) ? host : "";
+    if (port >= 0)
+	this.authority += ":" + port;
 
     int hashAt = file.indexOf('#');
     if (hashAt < 0)
@@ -480,7 +487,7 @@
    *
    * @since 1.3
    */
-  public Object getContent() throws IOException
+  public final Object getContent() throws IOException
   {
     return openConnection().getContent();
   }
@@ -494,7 +501,7 @@
    *
    * @exception IOException If an error occurs
    */
-  public Object getContent(Class[] classes) throws IOException
+  public final Object getContent(Class[] classes) throws IOException
   {
     // FIXME: implement this
     return getContent();
@@ -653,7 +660,7 @@
    *
    * @exception IOException If an error occurs
    */
-  public InputStream openStream() throws IOException
+  public final InputStream openStream() throws IOException
   {
     return openConnection().getInputStream();
   }
@@ -694,11 +701,17 @@
     // be aware of this.
     this.ph = getURLStreamHandler(protocol);
     this.protocol = protocol.toLowerCase();
-    this.authority = null;
+    this.authority = "";
     this.port = port;
     this.host = host;
     this.file = file;
     this.ref = ref;
+
+    if (host != null)
+      this.authority += host;
+    if (port >= 0)
+      this.authority += ":" + port;
+
     hashCode = hashCode(); // Used for serialization.
   }
 
@@ -727,15 +740,15 @@
     // be aware of this.
     this.ph = getURLStreamHandler(protocol);
     this.protocol = protocol.toLowerCase();
-    if (userInfo == null)
-      this.host = host;
-    else
-      this.host = userInfo + "@" + host;
+    this.host = host;
+    this.userInfo = userInfo;
     this.port = port;
+    this.file = path;
+    this.authority = authority;
     if (query == null)
-      this.file = path;
+      this.file = file;
     else
-      this.file = path + "?" + query;
+      this.file = file + "?" + query;
     this.ref = ref;
     hashCode = hashCode(); // Used for serialization.
   }
Index: java/net/URLStreamHandler.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/net/URLStreamHandler.java,v
retrieving revision 1.26
diff -u -r1.26 URLStreamHandler.java
--- java/net/URLStreamHandler.java	8 Apr 2004 17:25:02 -0000	1.26
+++ java/net/URLStreamHandler.java	20 Apr 2004 06:27:29 -0000
@@ -126,6 +126,9 @@
     int port = url.getPort();
     String file = url.getFile();
     String ref = url.getRef();
+    String userInfo = url.getUserInfo();
+    String authority = url.getAuthority();
+    String query = null;
 
     if (spec.regionMatches(start, "//", 0, 2))
       {
@@ -141,14 +144,17 @@
 	else
 	  hostEnd = end;
 
-	host = spec.substring(start, hostEnd);
+	authority = host = spec.substring(start, hostEnd);
 
 	// We first need a genuine host name (with userinfo).
 	// So we check for '@': if it's present check the port in the
 	// section after '@' in the other case check it in the full string.
 	// P.S.: We don't care having '@' at the beginning of the string.
 	if ((at_host = host.indexOf('@')) >= 0)
-	  genuineHost = host.substring(at_host);
+	  {
+	    genuineHost = host.substring(at_host);
+	    userInfo = host.substring(0, at_host);
+	  }
 	else
 	  genuineHost = host;
 
@@ -238,10 +244,21 @@
 	  }
       }
 
+    // We care about the query tag only if there is no reference at all.
+    if (ref == null)
+      {
+	  int queryTag = file.indexOf('?');
+	  if (queryTag != -1)
+	    {
+	      query = file.substring(queryTag + 1);
+	      file = file.substring(0, queryTag);
+	    }
+      }
+
     // XXX - Classpath used to call PlatformHelper.toCanonicalForm() on
     // the file part. It seems like overhead, but supposedly there is some
     // benefit in windows based systems (it also lowercased the string).
-    setURL(url, url.getProtocol(), host, port, file, ref);
+    setURL(url, url.getProtocol(), host, port, authority, userInfo, file, query, ref);
   }
 
   /*
@@ -492,42 +509,31 @@
     String file;
     String ref;
     String user;
+    String authority;
     int port;
 
     protocol = url.getProtocol();
-
-    // JDK 1.2 online doc infers that host could be null because it
-    // explicitly states that file cannot be null, but is silent on host.
-    host = url.getHost();
-    if (host == null)
-      host = "";
-
-    port = url.getPort();
+    authority = url.getAuthority();
+    if (authority == null)
+      authority = "";
+    
     file = url.getFile();
     ref = url.getRef();
-    user = url.getUserInfo();
 
     // Guess a reasonable size for the string buffer so we have to resize
     // at most once.
-    int size = protocol.length() + host.length() + file.length() + 24;
+    int size = protocol.length() + authority.length() + file.length() + 24;
     StringBuffer sb = new StringBuffer(size);
 
-    if (protocol.length() != 0)
+    if (protocol != null && protocol.length() > 0)
       {
 	sb.append(protocol);
 	sb.append(":");
       }
-
-    if (host.length() != 0)
+    
+    if (authority.length() != 0)
       {
-	sb.append("//");
-	if (user != null && ! "".equals(user))
-	  sb.append(user).append('@');
-	sb.append(host);
-
-	// Append port if port was in URL spec.
-	if (port >= 0)
-	  sb.append(':').append(port);
+	sb.append("//").append(authority);
       }
 
     sb.append(file);

--=-FeZpGWeZJwCOJIaquTP2--




From MAILER-DAEMON Tue Apr 20 03:27:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFpdu-0002Hg-B2
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 03:26:06 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFpdd-00020y-Vv
	for classpath@gnu.org; Tue, 20 Apr 2004 03:25:49 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFpcq-0001ML-3Y
	for classpath@gnu.org; Tue, 20 Apr 2004 03:25:31 -0400
Received: from [213.228.0.44] (helo=postfix3-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFpc4-0000m5-Lr
	for classpath@gnu.org; Tue, 20 Apr 2004 03:24:12 -0400
Received: from 192.168.1.247 (lns-th2-11-82-64-167-76.adsl.proxad.net
	[82.64.167.76])
	by postfix3-1.free.fr (Postfix) with ESMTP id 7C8D9C41B0
	for <classpath@gnu.org>; Tue, 20 Apr 2004 09:24:11 +0200 (CEST)
From: Guilhem Lavaux <guilhem@kaffe.org>
To: classpath@gnu.org
Content-Type: multipart/mixed; boundary="=-08K1VgumnjMZnwhYZb24"
Message-Id: <1082445842.5634.66.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4-8mdk 
Date: Tue, 20 Apr 2004 09:24:02 +0200
Subject: gnu.java.net.protocol.file.Handler update
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 07:25:52 -0000


--=-08K1VgumnjMZnwhYZb24
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,

Apparently the special parseURL implementation in
gnu.java.net.protocol.file.Handler is not required anymore and even
broken according to mauve test gnu.testlet.java.net.URL.URLTest. If we
replace it using GCJ implementation (attached) 39 failures are fixed and
no regression happens. So I suggest to use it directly. I haven't yet
tested the URL "file:/d|/test.txt" on windows but on Linux GNU Classpath
and JDK gives the same result if we suppress this implementation...

Cheers,

Guilhem.

--=-08K1VgumnjMZnwhYZb24
Content-Disposition: attachment; filename=Handler.java
Content-Type: text/x-java; name=Handler.java; charset=
Content-Transfer-Encoding: 7bit

/* Handler.java -- "file" protocol handler for java.net
   Copyright (C) 1998, 1999, 2000, 2002, 2003 Free Software Foundation, Inc.

This file is part of GNU Classpath.

GNU Classpath is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2, or (at your option)
any later version.

GNU Classpath is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
General Public License for more details.

You should have received a copy of the GNU General Public License
along with GNU Classpath; see the file COPYING.  If not, write to the
Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA.

Linking this library statically or dynamically with other modules is
making a combined work based on this library.  Thus, the terms and
conditions of the GNU General Public License cover the whole
combination.

As a special exception, the copyright holders of this library give you
permission to link this library with independent modules to produce an
executable, regardless of the license terms of these independent
modules, and to copy and distribute the resulting executable under
terms of your choice, provided that you also meet, for each linked
independent module, the terms and conditions of the license of that
module.  An independent module is a module which is not derived from
or based on this library.  If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so.  If you do not wish to do so, delete this
exception statement from your version. */

package gnu.java.net.protocol.file;

import java.io.IOException;
import java.net.URL;
import java.net.URLConnection;
import java.net.URLStreamHandler;

/**
 * This is the protocol handler for the "file" protocol.
 * It implements the abstract openConnection() method from
 * URLStreamHandler by returning a new FileURLConnection object (from
 * this package).  All other methods are inherited
 *
 * @author Aaron M. Renn (arenn@urbanophile.com)
 * @author Warren Levy <warrenl@cygnus.com>
 */
public class Handler extends URLStreamHandler
{
  /**
   * A do nothing constructor
   */
  public Handler()
  {
  }

  /**
   * This method returs a new FileURLConnection for the specified URL
   *
   * @param url The URL to return a connection for
   *
   * @return The URLConnection
   *
   * @exception IOException If an error occurs
   */
  protected URLConnection openConnection(URL url) throws IOException
  {
    // If a hostname is set, then we need to switch protocols to ftp
    // in order to transfer this from the remote host.
    String host = url.getHost();
    if ((host != null) && (! host.equals("")))
      {
//        throw new IOException("ftp protocol handler not yet implemented.");
//        /*
	// Reset the protocol (and implicitly the handler) for this URL.
	// Then have the URL attempt the connection again, as it will
	// get the changed handler the next time around.
	setURL (url, "ftp", url.getHost(), url.getPort(), url.getFile(),
		url.getRef());
	// Until the ftp protocol handler is written, this will cause
	// a NullPointerException.
	return url.openConnection();
//	*/
      }

    return new Connection(url);
  }
} // class Handler

--=-08K1VgumnjMZnwhYZb24--




From MAILER-DAEMON Tue Apr 20 09:36:40 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFvQV-0002zM-LL
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 09:36:39 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFvQT-0002yb-36
	for classpath@gnu.org; Tue, 20 Apr 2004 09:36:37 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFvPv-0002n9-QK
	for classpath@gnu.org; Tue, 20 Apr 2004 09:36:34 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFvPv-0002mh-2E
	for classpath@gnu.org; Tue, 20 Apr 2004 09:36:03 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-054.ewetel.net
	[80.228.94.54])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i3KDZQMo010908;
	Tue, 20 Apr 2004 15:35:27 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BFvPZ-0001FP-00; Tue, 20 Apr 2004 15:35:41 +0200
From: Michael Koch <konqueror@gmx.de>
To: Guilhem Lavaux <guilhem@kaffe.org>, classpath@gnu.org
Date: Tue, 20 Apr 2004 15:35:05 +0200
User-Agent: KMail/1.5.4
References: <1082445596.5640.61.camel@localhost>
In-Reply-To: <1082445596.5640.61.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404201535.05943.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: java.net.URL authority/userInfo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 13:36:37 -0000

Am Dienstag, 20. April 2004 09:19 schrieb Guilhem Lavaux:
> Hi,
>
> Here is a patch for URL.java and URLStreamHandler.java to implement
> support for authority and cleanup userInfo handling. I have updated a
> small testcase in mauve for authority and there does not seem to be
> any regression. Please review.

I'm okay with except one little nitpick. Class java.net.URL is final, 
this implicitely makes all its methods final too. Our policy is to not 
write redundant modifiers. So should not add them. (I know they are in 
libgcj's version of java.net.URL but they should be removed.)


Michael




From MAILER-DAEMON Tue Apr 20 09:38:33 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFvSL-0003Td-41
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 09:38:33 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFvSG-0003S9-Oa
	for classpath@classpath.org; Tue, 20 Apr 2004 09:38:28 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFvRc-0003H4-TQ
	for classpath@classpath.org; Tue, 20 Apr 2004 09:38:19 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFvRc-0003Gr-FH
	for classpath@classpath.org; Tue, 20 Apr 2004 09:37:48 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-054.ewetel.net
	[80.228.94.54])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i3KDbDMo012362;
	Tue, 20 Apr 2004 15:37:14 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BFvRH-0001FV-00; Tue, 20 Apr 2004 15:37:27 +0200
From: Michael Koch <konqueror@gmx.de>
To: Guilhem Lavaux <guilhem@kaffe.org>, classpath@classpath.org
Date: Tue, 20 Apr 2004 15:36:52 +0200
User-Agent: KMail/1.5.4
References: <1082445328.5635.55.camel@localhost>
In-Reply-To: <1082445328.5635.55.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404201536.52190.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: Http headers
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 13:38:29 -0000

Am Dienstag, 20. April 2004 09:15 schrieb Guilhem Lavaux:
> Hi,
>
> If you try the mauve test URLConnection/Http you may notice there is
> failure due to an unknown header "server" which should be "Server".
> Apparently to make the search throught header fields independent from
> the case we have using toLowerCase for all header keys and values:
> this is not right. I suggest we build keep the original value in the
> array in HeaderFieldHelper so we are able to return the exact value
> returned by the server.

Do we have a mauve testcase for this ? Different http server may act 
differently. I'm not sure this is bug in our implementation or in 
mauve. I have locally changed mauve to make it pass.


Michael




From MAILER-DAEMON Tue Apr 20 09:38:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFvSk-0003dM-If
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 09:38:58 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFvSe-0003bG-MM
	for classpath@gnu.org; Tue, 20 Apr 2004 09:38:52 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFvS4-0003Om-4V
	for classpath@gnu.org; Tue, 20 Apr 2004 09:38:47 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFvMe-00023m-1O
	for classpath@gnu.org; Tue, 20 Apr 2004 09:32:40 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C426DB.DE06B0F0"
Date: Tue, 20 Apr 2004 15:32:06 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADE50@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator: 
Thread-Topic: gnu.java.net.protocol.file.Handler update
Thread-Index: AcQmqUJUz/4zd7R0TCOfv8PpezN8MAACJoDw
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Guilhem Lavaux" <guilhem@kaffe.org>,
	<classpath@gnu.org>
Cc: 
Subject: RE: gnu.java.net.protocol.file.Handler update
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 13:38:54 -0000

This is a multi-part message in MIME format.

------_=_NextPart_001_01C426DB.DE06B0F0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Guilhem Lavaux wrote:
> Apparently the special parseURL implementation in
> gnu.java.net.protocol.file.Handler is not required anymore and even
> broken according to mauve test gnu.testlet.java.net.URL.URLTest. If we
> replace it using GCJ implementation (attached) 39 failures=20
> are fixed and no regression happens. So I suggest to use it directly.
> I haven't yet tested the URL "file:/d|/test.txt" on windows but on
Linux=20
> GNU Classpath and JDK gives the same result if we suppress this
> implementation...

I spent almost the entire day on it, but I finally have it working :-)

I hope I never have to see another URL ever again... <g>

BTW, using a pipe instead of a colon doesn't work on the Sun JDK, so I
don't think we need to bother with that.

Attached is the patch I ended up with (this includes your patch). I
think all the URL Mauve tests now pass on Windows and Eclipse 3.0 M8
continues to run (this was an extremely good test case).

I'm pretty sure I didn't break non-Windows behavior, but please do take
a look at the code.

Here's what I did:

File.toURL(): Use constructor that doesn't require parsing, to bypass
problems that arise from the fact that absolute Windows paths do not
start with a slash (Unix "/foo" should result in file:///foo, while on
Windows "c:/foo" should result in file:///c:/foo).

URL: No additional changes.

URLStreamHandler.parseURL(): Added code to change File.separatorChar to
/ for "file" protocol. The Sun JDK does the same, URLs always use /, but
when parsing they accept backslashes too.
Removed code that deals with backslashes. Added code to change
File.separatorChar to / after using File.getCanonicalPath to
canonicalize the path (which had the unintended side effect of
introducing the backslashes again).

Regards,
Jeroen

------_=_NextPart_001_01C426DB.DE06B0F0
Content-Type: application/octet-stream;
	name="url.patch"
Content-Transfer-Encoding: base64
Content-Description: url.patch
Content-Disposition: attachment;
	filename="url.patch"

SW5kZXg6IGphdmEvaW8vRmlsZS5qYXZhDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3Qv
Y2xhc3NwYXRoL2NsYXNzcGF0aC9qYXZhL2lvL0ZpbGUuamF2YSx2DQpyZXRyaWV2aW5nIHJldmlz
aW9uIDEuMzkNCmRpZmYgLXUgLXIxLjM5IEZpbGUuamF2YQ0KLS0tIGphdmEvaW8vRmlsZS5qYXZh
CTMgTWFyIDIwMDQgMjE6MjA6NDggLTAwMDAJMS4zOQ0KKysrIGphdmEvaW8vRmlsZS5qYXZhCTIw
IEFwciAyMDA0IDEzOjE1OjQ4IC0wMDAwDQpAQCAtODYxLDEwICs4NjEsOCBAQA0KICAgCSAgYWJz
cGF0aCA9IGFic3BhdGggKyBzZXBhcmF0b3I7DQogICAgICAgfQ0KICAgICBjYXRjaChFeGNlcHRp
b24gXykgeyB9DQotICAgIA0KLSAgICBTdHJpbmcgdXJsX3N0cmluZyA9ICJmaWxlOi8vIiArIGFi
c3BhdGg7DQotICAgIA0KLSAgICByZXR1cm4gbmV3IFVSTCh1cmxfc3RyaW5nKTsNCisNCisgICAg
cmV0dXJuIG5ldyBVUkwoImZpbGUiLCAiIiwgYWJzcGF0aC5yZXBsYWNlKHNlcGFyYXRvckNoYXIs
ICcvJykpOw0KICAgfQ0KIA0KICAgLyoNCkluZGV4OiBqYXZhL25ldC9VUkwuamF2YQ0KPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2NsYXNzcGF0aC9jbGFzc3BhdGgvamF2YS9uZXQvVVJM
LmphdmEsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjI2DQpkaWZmIC11IC1yMS4yNiBVUkwuamF2
YQ0KLS0tIGphdmEvbmV0L1VSTC5qYXZhCTggQXByIDIwMDQgMTc6MjU6MDIgLTAwMDAJMS4yNg0K
KysrIGphdmEvbmV0L1VSTC5qYXZhCTIwIEFwciAyMDA0IDEzOjE2OjAzIC0wMDAwDQpAQCAtMTQx
LDYgKzE0MSwxMSBAQA0KICAgcHJpdmF0ZSBTdHJpbmcgaG9zdDsNCiANCiAgIC8qKg0KKyAgICog
VGhlIHVzZXIgaW5mb3JtYXRpb24gbmVjZXNzYXJ5IHRvIGVzdGFibGlzaCB0aGUgY29ubmVjdGlv
bi4NCisgICAqLw0KKyAgcHJpdmF0ZSBTdHJpbmcgdXNlckluZm87DQorDQorICAvKioNCiAgICAq
IFRoZSBwb3J0IG51bWJlciBvZiB0aGlzIHByb3RvY29sIG9yIC0xIGlmIHRoZSBwb3J0IG51bWJl
ciB1c2VkIGlzDQogICAgKiB0aGUgZGVmYXVsdCBmb3IgdGhpcyBwcm90b2NvbC4NCiAgICAqLw0K
QEAgLTI3Niw3ICsyODEsOSBAQA0KIA0KICAgICB0aGlzLmhvc3QgPSBob3N0Ow0KICAgICB0aGlz
LnBvcnQgPSBwb3J0Ow0KLSAgICB0aGlzLmF1dGhvcml0eSA9IG51bGw7DQorICAgIHRoaXMuYXV0
aG9yaXR5ID0gKGhvc3QgIT0gbnVsbCkgPyBob3N0IDogIiI7DQorICAgIGlmIChwb3J0ID49IDAp
DQorCXRoaXMuYXV0aG9yaXR5ICs9ICI6IiArIHBvcnQ7DQogDQogICAgIGludCBoYXNoQXQgPSBm
aWxlLmluZGV4T2YoJyMnKTsNCiAgICAgaWYgKGhhc2hBdCA8IDApDQpAQCAtNDgwLDcgKzQ4Nyw3
IEBADQogICAgKg0KICAgICogQHNpbmNlIDEuMw0KICAgICovDQotICBwdWJsaWMgT2JqZWN0IGdl
dENvbnRlbnQoKSB0aHJvd3MgSU9FeGNlcHRpb24NCisgIHB1YmxpYyBmaW5hbCBPYmplY3QgZ2V0
Q29udGVudCgpIHRocm93cyBJT0V4Y2VwdGlvbg0KICAgew0KICAgICByZXR1cm4gb3BlbkNvbm5l
Y3Rpb24oKS5nZXRDb250ZW50KCk7DQogICB9DQpAQCAtNDk0LDcgKzUwMSw3IEBADQogICAgKg0K
ICAgICogQGV4Y2VwdGlvbiBJT0V4Y2VwdGlvbiBJZiBhbiBlcnJvciBvY2N1cnMNCiAgICAqLw0K
LSAgcHVibGljIE9iamVjdCBnZXRDb250ZW50KENsYXNzW10gY2xhc3NlcykgdGhyb3dzIElPRXhj
ZXB0aW9uDQorICBwdWJsaWMgZmluYWwgT2JqZWN0IGdldENvbnRlbnQoQ2xhc3NbXSBjbGFzc2Vz
KSB0aHJvd3MgSU9FeGNlcHRpb24NCiAgIHsNCiAgICAgLy8gRklYTUU6IGltcGxlbWVudCB0aGlz
DQogICAgIHJldHVybiBnZXRDb250ZW50KCk7DQpAQCAtNjUzLDcgKzY2MCw3IEBADQogICAgKg0K
ICAgICogQGV4Y2VwdGlvbiBJT0V4Y2VwdGlvbiBJZiBhbiBlcnJvciBvY2N1cnMNCiAgICAqLw0K
LSAgcHVibGljIElucHV0U3RyZWFtIG9wZW5TdHJlYW0oKSB0aHJvd3MgSU9FeGNlcHRpb24NCisg
IHB1YmxpYyBmaW5hbCBJbnB1dFN0cmVhbSBvcGVuU3RyZWFtKCkgdGhyb3dzIElPRXhjZXB0aW9u
DQogICB7DQogICAgIHJldHVybiBvcGVuQ29ubmVjdGlvbigpLmdldElucHV0U3RyZWFtKCk7DQog
ICB9DQpAQCAtNjk0LDExICs3MDEsMTcgQEANCiAgICAgLy8gYmUgYXdhcmUgb2YgdGhpcy4NCiAg
ICAgdGhpcy5waCA9IGdldFVSTFN0cmVhbUhhbmRsZXIocHJvdG9jb2wpOw0KICAgICB0aGlzLnBy
b3RvY29sID0gcHJvdG9jb2wudG9Mb3dlckNhc2UoKTsNCi0gICAgdGhpcy5hdXRob3JpdHkgPSBu
dWxsOw0KKyAgICB0aGlzLmF1dGhvcml0eSA9ICIiOw0KICAgICB0aGlzLnBvcnQgPSBwb3J0Ow0K
ICAgICB0aGlzLmhvc3QgPSBob3N0Ow0KICAgICB0aGlzLmZpbGUgPSBmaWxlOw0KICAgICB0aGlz
LnJlZiA9IHJlZjsNCisNCisgICAgaWYgKGhvc3QgIT0gbnVsbCkNCisgICAgICB0aGlzLmF1dGhv
cml0eSArPSBob3N0Ow0KKyAgICBpZiAocG9ydCA+PSAwKQ0KKyAgICAgIHRoaXMuYXV0aG9yaXR5
ICs9ICI6IiArIHBvcnQ7DQorDQogICAgIGhhc2hDb2RlID0gaGFzaENvZGUoKTsgLy8gVXNlZCBm
b3Igc2VyaWFsaXphdGlvbi4NCiAgIH0NCiANCkBAIC03MjcsMTUgKzc0MCwxNSBAQA0KICAgICAv
LyBiZSBhd2FyZSBvZiB0aGlzLg0KICAgICB0aGlzLnBoID0gZ2V0VVJMU3RyZWFtSGFuZGxlcihw
cm90b2NvbCk7DQogICAgIHRoaXMucHJvdG9jb2wgPSBwcm90b2NvbC50b0xvd2VyQ2FzZSgpOw0K
LSAgICBpZiAodXNlckluZm8gPT0gbnVsbCkNCi0gICAgICB0aGlzLmhvc3QgPSBob3N0Ow0KLSAg
ICBlbHNlDQotICAgICAgdGhpcy5ob3N0ID0gdXNlckluZm8gKyAiQCIgKyBob3N0Ow0KKyAgICB0
aGlzLmhvc3QgPSBob3N0Ow0KKyAgICB0aGlzLnVzZXJJbmZvID0gdXNlckluZm87DQogICAgIHRo
aXMucG9ydCA9IHBvcnQ7DQorICAgIHRoaXMuZmlsZSA9IHBhdGg7DQorICAgIHRoaXMuYXV0aG9y
aXR5ID0gYXV0aG9yaXR5Ow0KICAgICBpZiAocXVlcnkgPT0gbnVsbCkNCi0gICAgICB0aGlzLmZp
bGUgPSBwYXRoOw0KKyAgICAgIHRoaXMuZmlsZSA9IGZpbGU7DQogICAgIGVsc2UNCi0gICAgICB0
aGlzLmZpbGUgPSBwYXRoICsgIj8iICsgcXVlcnk7DQorICAgICAgdGhpcy5maWxlID0gZmlsZSAr
ICI/IiArIHF1ZXJ5Ow0KICAgICB0aGlzLnJlZiA9IHJlZjsNCiAgICAgaGFzaENvZGUgPSBoYXNo
Q29kZSgpOyAvLyBVc2VkIGZvciBzZXJpYWxpemF0aW9uLg0KICAgfQ0KSW5kZXg6IGphdmEvbmV0
L1VSTFN0cmVhbUhhbmRsZXIuamF2YQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290L2Ns
YXNzcGF0aC9jbGFzc3BhdGgvamF2YS9uZXQvVVJMU3RyZWFtSGFuZGxlci5qYXZhLHYNCnJldHJp
ZXZpbmcgcmV2aXNpb24gMS4yNg0KZGlmZiAtdSAtcjEuMjYgVVJMU3RyZWFtSGFuZGxlci5qYXZh
DQotLS0gamF2YS9uZXQvVVJMU3RyZWFtSGFuZGxlci5qYXZhCTggQXByIDIwMDQgMTc6MjU6MDIg
LTAwMDAJMS4yNg0KKysrIGphdmEvbmV0L1VSTFN0cmVhbUhhbmRsZXIuamF2YQkyMCBBcHIgMjAw
NCAxMzoxNjowMyAtMDAwMA0KQEAgLTEyNiw2ICsxMjYsMTMgQEANCiAgICAgaW50IHBvcnQgPSB1
cmwuZ2V0UG9ydCgpOw0KICAgICBTdHJpbmcgZmlsZSA9IHVybC5nZXRGaWxlKCk7DQogICAgIFN0
cmluZyByZWYgPSB1cmwuZ2V0UmVmKCk7DQorICAgIFN0cmluZyB1c2VySW5mbyA9IHVybC5nZXRV
c2VySW5mbygpOw0KKyAgICBTdHJpbmcgYXV0aG9yaXR5ID0gdXJsLmdldEF1dGhvcml0eSgpOw0K
KyAgICBTdHJpbmcgcXVlcnkgPSBudWxsOw0KKw0KKyAgICAvLyBPbiBXaW5kb3dzIHdlIG5lZWQg
dG8gY2hhbmdlIFwgdG8gLyBmb3IgZmlsZSBVUkxzDQorICAgIGlmICh1cmwuZ2V0UHJvdG9jb2wo
KS5lcXVhbHMoImZpbGUiKSkNCisJc3BlYyA9IHNwZWMucmVwbGFjZShGaWxlLnNlcGFyYXRvckNo
YXIsICcvJyk7DQogDQogICAgIGlmIChzcGVjLnJlZ2lvbk1hdGNoZXMoc3RhcnQsICIvLyIsIDAs
IDIpKQ0KICAgICAgIHsNCkBAIC0xNDEsMTQgKzE0OCwxNyBAQA0KIAllbHNlDQogCSAgaG9zdEVu
ZCA9IGVuZDsNCiANCi0JaG9zdCA9IHNwZWMuc3Vic3RyaW5nKHN0YXJ0LCBob3N0RW5kKTsNCisJ
YXV0aG9yaXR5ID0gaG9zdCA9IHNwZWMuc3Vic3RyaW5nKHN0YXJ0LCBob3N0RW5kKTsNCiANCiAJ
Ly8gV2UgZmlyc3QgbmVlZCBhIGdlbnVpbmUgaG9zdCBuYW1lICh3aXRoIHVzZXJpbmZvKS4NCiAJ
Ly8gU28gd2UgY2hlY2sgZm9yICdAJzogaWYgaXQncyBwcmVzZW50IGNoZWNrIHRoZSBwb3J0IGlu
IHRoZQ0KIAkvLyBzZWN0aW9uIGFmdGVyICdAJyBpbiB0aGUgb3RoZXIgY2FzZSBjaGVjayBpdCBp
biB0aGUgZnVsbCBzdHJpbmcuDQogCS8vIFAuUy46IFdlIGRvbid0IGNhcmUgaGF2aW5nICdAJyBh
dCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBzdHJpbmcuDQogCWlmICgoYXRfaG9zdCA9IGhvc3QuaW5k
ZXhPZignQCcpKSA+PSAwKQ0KLQkgIGdlbnVpbmVIb3N0ID0gaG9zdC5zdWJzdHJpbmcoYXRfaG9z
dCk7DQorCSAgew0KKwkgICAgZ2VudWluZUhvc3QgPSBob3N0LnN1YnN0cmluZyhhdF9ob3N0KTsN
CisJICAgIHVzZXJJbmZvID0gaG9zdC5zdWJzdHJpbmcoMCwgYXRfaG9zdCk7DQorCSAgfQ0KIAll
bHNlDQogCSAgZ2VudWluZUhvc3QgPSBob3N0Ow0KIA0KQEAgLTE5MywxOCArMjAzLDEwIEBADQog
ICAgIGVsc2UgaWYgKHN0YXJ0IDwgZW5kKQ0KICAgICAgIHsNCiAJLy8gQ29udGV4dCBpcyBhdmFp
bGFibGUsIGJ1dCBvbmx5IG92ZXJyaWRlIGl0IGlmIHRoZXJlIGlzIGEgbmV3IGZpbGUuDQotCWNo
YXIgc2VwQ2hhciA9ICcvJzsNCi0JaW50IGxhc3RTbGFzaCA9IGZpbGUubGFzdEluZGV4T2Yoc2Vw
Q2hhcik7DQotCWlmIChsYXN0U2xhc2ggPCAwICYmIEZpbGUuc2VwYXJhdG9yQ2hhciAhPSBzZXBD
aGFyDQotCSAgICAmJiB1cmwuZ2V0UHJvdG9jb2woKS5lcXVhbHMoImZpbGUiKSkNCi0JICB7DQot
CSAgICAvLyBPbiBXaW5kb3dzLCBldmVuICdcJyBpcyBhbGxvd2VkIGluIGEgImZpbGUiIFVSTC4N
Ci0JICAgIHNlcENoYXIgPSBGaWxlLnNlcGFyYXRvckNoYXI7DQotCSAgICBsYXN0U2xhc2ggPSBm
aWxlLmxhc3RJbmRleE9mKHNlcENoYXIpOw0KLQkgIH0NCisJaW50IGxhc3RTbGFzaCA9IGZpbGUu
bGFzdEluZGV4T2YoJy8nKTsNCiANCiAJZmlsZSA9DQotCSAgZmlsZS5zdWJzdHJpbmcoMCwgbGFz
dFNsYXNoKSArIHNlcENoYXIgKyBzcGVjLnN1YnN0cmluZyhzdGFydCwgZW5kKTsNCisJICBmaWxl
LnN1YnN0cmluZygwLCBsYXN0U2xhc2gpICsgJy8nICsgc3BlYy5zdWJzdHJpbmcoc3RhcnQsIGVu
ZCk7DQogDQogCWlmICh1cmwuZ2V0UHJvdG9jb2woKS5lcXVhbHMoImZpbGUiKSkNCiAJICB7DQpA
QCAtMjE0LDYgKzIxNiw3IEBADQogCSAgICAgIHsNCiAJCWJvb2xlYW4gZW5kc1dpdGhTbGFzaCA9
IGZpbGUuY2hhckF0KGZpbGUubGVuZ3RoKCkgLSAxKSA9PSAnLyc7DQogCQlmaWxlID0gbmV3IEZp
bGUoZmlsZSkuZ2V0Q2Fub25pY2FsUGF0aCgpOw0KKwkJZmlsZSA9IGZpbGUucmVwbGFjZShGaWxl
LnNlcGFyYXRvckNoYXIsICcvJyk7DQogCQlpZiAoZW5kc1dpdGhTbGFzaCAmJiBmaWxlLmNoYXJB
dChmaWxlLmxlbmd0aCgpIC0gMSkgIT0gJy8nKQ0KIAkJICBmaWxlICs9ICcvJzsNCiAJICAgICAg
fQ0KQEAgLTIzOCwxMCArMjQxLDIxIEBADQogCSAgfQ0KICAgICAgIH0NCiANCisgICAgLy8gV2Ug
Y2FyZSBhYm91dCB0aGUgcXVlcnkgdGFnIG9ubHkgaWYgdGhlcmUgaXMgbm8gcmVmZXJlbmNlIGF0
IGFsbC4NCisgICAgaWYgKHJlZiA9PSBudWxsKQ0KKyAgICAgIHsNCisJICBpbnQgcXVlcnlUYWcg
PSBmaWxlLmluZGV4T2YoJz8nKTsNCisJICBpZiAocXVlcnlUYWcgIT0gLTEpDQorCSAgICB7DQor
CSAgICAgIHF1ZXJ5ID0gZmlsZS5zdWJzdHJpbmcocXVlcnlUYWcgKyAxKTsNCisJICAgICAgZmls
ZSA9IGZpbGUuc3Vic3RyaW5nKDAsIHF1ZXJ5VGFnKTsNCisJICAgIH0NCisgICAgICB9DQorDQog
ICAgIC8vIFhYWCAtIENsYXNzcGF0aCB1c2VkIHRvIGNhbGwgUGxhdGZvcm1IZWxwZXIudG9DYW5v
bmljYWxGb3JtKCkgb24NCiAgICAgLy8gdGhlIGZpbGUgcGFydC4gSXQgc2VlbXMgbGlrZSBvdmVy
aGVhZCwgYnV0IHN1cHBvc2VkbHkgdGhlcmUgaXMgc29tZQ0KICAgICAvLyBiZW5lZml0IGluIHdp
bmRvd3MgYmFzZWQgc3lzdGVtcyAoaXQgYWxzbyBsb3dlcmNhc2VkIHRoZSBzdHJpbmcpLg0KLSAg
ICBzZXRVUkwodXJsLCB1cmwuZ2V0UHJvdG9jb2woKSwgaG9zdCwgcG9ydCwgZmlsZSwgcmVmKTsN
CisgICAgc2V0VVJMKHVybCwgdXJsLmdldFByb3RvY29sKCksIGhvc3QsIHBvcnQsIGF1dGhvcml0
eSwgdXNlckluZm8sIGZpbGUsIHF1ZXJ5LCByZWYpOw0KICAgfQ0KIA0KICAgLyoNCkBAIC00OTIs
NDIgKzUwNiwzMSBAQA0KICAgICBTdHJpbmcgZmlsZTsNCiAgICAgU3RyaW5nIHJlZjsNCiAgICAg
U3RyaW5nIHVzZXI7DQorICAgIFN0cmluZyBhdXRob3JpdHk7DQogICAgIGludCBwb3J0Ow0KIA0K
ICAgICBwcm90b2NvbCA9IHVybC5nZXRQcm90b2NvbCgpOw0KLQ0KLSAgICAvLyBKREsgMS4yIG9u
bGluZSBkb2MgaW5mZXJzIHRoYXQgaG9zdCBjb3VsZCBiZSBudWxsIGJlY2F1c2UgaXQNCi0gICAg
Ly8gZXhwbGljaXRseSBzdGF0ZXMgdGhhdCBmaWxlIGNhbm5vdCBiZSBudWxsLCBidXQgaXMgc2ls
ZW50IG9uIGhvc3QuDQotICAgIGhvc3QgPSB1cmwuZ2V0SG9zdCgpOw0KLSAgICBpZiAoaG9zdCA9
PSBudWxsKQ0KLSAgICAgIGhvc3QgPSAiIjsNCi0NCi0gICAgcG9ydCA9IHVybC5nZXRQb3J0KCk7
DQorICAgIGF1dGhvcml0eSA9IHVybC5nZXRBdXRob3JpdHkoKTsNCisgICAgaWYgKGF1dGhvcml0
eSA9PSBudWxsKQ0KKyAgICAgIGF1dGhvcml0eSA9ICIiOw0KKyAgICANCiAgICAgZmlsZSA9IHVy
bC5nZXRGaWxlKCk7DQogICAgIHJlZiA9IHVybC5nZXRSZWYoKTsNCi0gICAgdXNlciA9IHVybC5n
ZXRVc2VySW5mbygpOw0KIA0KICAgICAvLyBHdWVzcyBhIHJlYXNvbmFibGUgc2l6ZSBmb3IgdGhl
IHN0cmluZyBidWZmZXIgc28gd2UgaGF2ZSB0byByZXNpemUNCiAgICAgLy8gYXQgbW9zdCBvbmNl
Lg0KLSAgICBpbnQgc2l6ZSA9IHByb3RvY29sLmxlbmd0aCgpICsgaG9zdC5sZW5ndGgoKSArIGZp
bGUubGVuZ3RoKCkgKyAyNDsNCisgICAgaW50IHNpemUgPSBwcm90b2NvbC5sZW5ndGgoKSArIGF1
dGhvcml0eS5sZW5ndGgoKSArIGZpbGUubGVuZ3RoKCkgKyAyNDsNCiAgICAgU3RyaW5nQnVmZmVy
IHNiID0gbmV3IFN0cmluZ0J1ZmZlcihzaXplKTsNCiANCi0gICAgaWYgKHByb3RvY29sLmxlbmd0
aCgpICE9IDApDQorICAgIGlmIChwcm90b2NvbCAhPSBudWxsICYmIHByb3RvY29sLmxlbmd0aCgp
ID4gMCkNCiAgICAgICB7DQogCXNiLmFwcGVuZChwcm90b2NvbCk7DQogCXNiLmFwcGVuZCgiOiIp
Ow0KICAgICAgIH0NCi0NCi0gICAgaWYgKGhvc3QubGVuZ3RoKCkgIT0gMCkNCisgICAgDQorICAg
IGlmIChhdXRob3JpdHkubGVuZ3RoKCkgIT0gMCkNCiAgICAgICB7DQotCXNiLmFwcGVuZCgiLy8i
KTsNCi0JaWYgKHVzZXIgIT0gbnVsbCAmJiAhICIiLmVxdWFscyh1c2VyKSkNCi0JICBzYi5hcHBl
bmQodXNlcikuYXBwZW5kKCdAJyk7DQotCXNiLmFwcGVuZChob3N0KTsNCi0NCi0JLy8gQXBwZW5k
IHBvcnQgaWYgcG9ydCB3YXMgaW4gVVJMIHNwZWMuDQotCWlmIChwb3J0ID49IDApDQotCSAgc2Iu
YXBwZW5kKCc6JykuYXBwZW5kKHBvcnQpOw0KKwlzYi5hcHBlbmQoIi8vIikuYXBwZW5kKGF1dGhv
cml0eSk7DQogICAgICAgfQ0KIA0KICAgICBzYi5hcHBlbmQoZmlsZSk7DQo=

------_=_NextPart_001_01C426DB.DE06B0F0--



From MAILER-DAEMON Tue Apr 20 09:41:31 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFvVC-0004Lq-Ul
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 09:41:30 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFvV9-0004Jv-6d
	for classpath@gnu.org; Tue, 20 Apr 2004 09:41:27 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFvSP-0003Va-Bf
	for classpath@gnu.org; Tue, 20 Apr 2004 09:39:09 -0400
Received: from [212.6.122.105] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFvSO-0003Uu-8X
	for classpath@gnu.org; Tue, 20 Apr 2004 09:38:36 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-054.ewetel.net
	[80.228.94.54])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i3KDc2A8017539;
	Tue, 20 Apr 2004 15:38:03 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BFvS4-0001Ff-00; Tue, 20 Apr 2004 15:38:16 +0200
From: Michael Koch <konqueror@gmx.de>
To: Guilhem Lavaux <guilhem@kaffe.org>, classpath@gnu.org
Date: Tue, 20 Apr 2004 15:37:41 +0200
User-Agent: KMail/1.5.4
References: <1082445842.5634.66.camel@localhost>
In-Reply-To: <1082445842.5634.66.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404201537.41428.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: gnu.java.net.protocol.file.Handler update
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 13:41:28 -0000

Am Dienstag, 20. April 2004 09:24 schrieb Guilhem Lavaux:
> Hi,
>
> Apparently the special parseURL implementation in
> gnu.java.net.protocol.file.Handler is not required anymore and even
> broken according to mauve test gnu.testlet.java.net.URL.URLTest. If
> we replace it using GCJ implementation (attached) 39 failures are
> fixed and no regression happens. So I suggest to use it directly. I
> haven't yet tested the URL "file:/d|/test.txt" on windows but on
> Linux GNU Classpath and JDK gives the same result if we suppress this
> implementation...

I dont think its a good idea to just remove everything. I have to test 
this later.


Michael




From MAILER-DAEMON Tue Apr 20 10:10:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFveN-0006wq-Ab
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 09:50:59 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFve7-0006uo-Tt
	for classpath@gnu.org; Tue, 20 Apr 2004 09:50:43 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFvdZ-0006k0-S5
	for classpath@gnu.org; Tue, 20 Apr 2004 09:50:42 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFvMc-00023m-V5
	for classpath@gnu.org; Tue, 20 Apr 2004 09:32:39 -0400
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 20 Apr 2004 15:32:03 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADE4F@LEMBU.sumatrasoftware.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: java.net.URL authority/userInfo
Thread-Index: AcQmqH8AHUt7nhMDRuyJS4ah/f7tYQABhLSg
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Guilhem Lavaux" <guilhem@kaffe.org>,
	<classpath@gnu.org>
Cc: 
Subject: RE: java.net.URL authority/userInfo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 13:50:45 -0000

Guilhem Lavaux wrote:
> Here is a patch for URL.java and URLStreamHandler.java to implement
> support for authority and cleanup userInfo handling. I have updated a
> small testcase in mauve for authority and there does not seem=20
> to be any regression. Please review.

Looks good and this fixes a problem I had with Eclipse 3.0 (it crashed
because URL.getAuthority returned null). Thanks!

Regards,
Jeroen



From MAILER-DAEMON Tue Apr 20 10:26:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFwCJ-0001sn-Io
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 10:26:03 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFwAf-0001Lg-Sp
	for classpath@gnu.org; Tue, 20 Apr 2004 10:24:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFw8j-0008JE-VV
	for classpath@gnu.org; Tue, 20 Apr 2004 10:23:01 -0400
Received: from [217.8.192.20] (helo=interway.li)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFw6m-0007F5-LD
	for classpath@gnu.org; Tue, 20 Apr 2004 10:20:20 -0400
Received: from [217.8.199.57] (HELO [192.168.1.33])
	by interway.li (CommuniGate Pro SMTP 4.1.8)
	with ESMTP id 1840873; Tue, 20 Apr 2004 12:20:20 +0200
From: Sascha Brawer <brawer@dandelis.ch>
To: <discussion@fsfeurope.org>
Date: Tue, 20 Apr 2004 12:20:16 +0200
Message-Id: <20040420102016.6361@smtp.mail.ch.easynet.net>
In-Reply-To: <20040419193106.GA1561@Castrophe.AKFoerster.de>
References: <20040419193106.GA1561@Castrophe.AKFoerster.de>
X-Mailer: CTM PowerMail 3.1.1 carbon <http://www.ctmdev.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, GNU Classpath <classpath@gnu.org>
Subject: Re: alternative to java
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 14:25:59 -0000

Several people wrote to discussion@fsfeurope.org:

> [Java is a trap; we should avoid it; alternatives?]

Many of the developers who work on "escaping the Java trap" met
at this year's FOSDEM in Brussels. Mark Wielaard and I gave a talk,
describing the motivation and current state of GNU Classpath and the
various free VMs [1]. The slides are not very technical, but might
serve as an overview for newcomers. IMHO, the "motivation" section
might be particularly relevant to what has been said so far on
the <discussion@fsfeurope.org> mailing list.

There were also several other, more technical talks about the state
and some specifics of particular VMs, such as gcj or SableVM. For
an overview to all talks, please have a look at [2].

GNU Classpath [3] is really appreciating any help. So, if anyone
wants to help out, please contact <classpath@gnu.org>, or write directly
to Mark Wielaard <mark@klomp.org>, who maintains the project.

[1] http://www.dandelis.ch/people/brawer/articles/classpathFeb2004/
[2] http://www.gnu.org/software/classpath/events/fosdem04.html
[3] http://www.gnu.org/software/classpath/

Best regards,

-- Sascha

Sascha Brawer, brawer@dandelis.ch, http://www.dandelis.ch/people/brawer/ 





From MAILER-DAEMON Tue Apr 20 10:40:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFwQl-000886-1h
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 10:40:59 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFwQh-00087E-Dy
	for classpath@gnu.org; Tue, 20 Apr 2004 10:40:55 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFwQB-000833-G0
	for classpath@gnu.org; Tue, 20 Apr 2004 10:40:54 -0400
Received: from [213.228.0.44] (helo=postfix3-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFwQB-00082X-8v
	for classpath@gnu.org; Tue, 20 Apr 2004 10:40:23 -0400
Received: from kaffe.org (lns-vlq-7-82-65-220-9.adsl.proxad.net [82.65.220.9])
	by postfix3-1.free.fr (Postfix) with ESMTP
	id 23040C42D8; Tue, 20 Apr 2004 16:40:20 +0200 (CEST)
Message-ID: <40853651.3000506@kaffe.org>
Date: Tue, 20 Apr 2004 16:40:17 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>, classpath@gnu.org
References: <1082445328.5635.55.camel@localhost>
	<200404201536.52190.konqueror@gmx.de>
In-Reply-To: <200404201536.52190.konqueror@gmx.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: Http headers
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 14:40:56 -0000

Michael Koch wrote:

>Am Dienstag, 20. April 2004 09:15 schrieb Guilhem Lavaux:
>  
>
>>Hi,
>>
>>If you try the mauve test URLConnection/Http you may notice there is
>>failure due to an unknown header "server" which should be "Server".
>>Apparently to make the search throught header fields independent from
>>the case we have using toLowerCase for all header keys and values:
>>this is not right. I suggest we build keep the original value in the
>>array in HeaderFieldHelper so we are able to return the exact value
>>returned by the server.
>>    
>>
>
>Do we have a mauve testcase for this ? Different http server may act 
>differently. I'm not sure this is bug in our implementation or in 
>mauve. I have locally changed mauve to make it pass.
>
>
>  
>
If you put "server" in mauve it will fail using JDK, if you put "Server" 
in mauve it will fail using Classpath for the same URL. But it is sure 
it depends on the server.

Cheers,

Guilhem.



From MAILER-DAEMON Tue Apr 20 10:42:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFwRq-0008Qt-7u
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 10:42:06 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFwRh-0008Os-8T
	for classpath@gnu.org; Tue, 20 Apr 2004 10:41:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFwRX-0008MF-LR
	for classpath@gnu.org; Tue, 20 Apr 2004 10:41:53 -0400
Received: from [213.228.0.44] (helo=postfix3-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFwRW-0008Lr-Tf
	for classpath@gnu.org; Tue, 20 Apr 2004 10:41:47 -0400
Received: from kaffe.org (lns-vlq-7-82-65-220-9.adsl.proxad.net [82.65.220.9])
	by postfix3-1.free.fr (Postfix) with ESMTP
	id A2FE3C42C5; Tue, 20 Apr 2004 16:41:44 +0200 (CEST)
Message-ID: <408536A8.4000601@kaffe.org>
Date: Tue, 20 Apr 2004 16:41:44 +0200
From: Guilhem Lavaux <guilhem@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <1082445596.5640.61.camel@localhost>
	<200404201535.05943.konqueror@gmx.de>
In-Reply-To: <200404201535.05943.konqueror@gmx.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: java.net.URL authority/userInfo
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 14:41:58 -0000

Michael Koch wrote:

>Am Dienstag, 20. April 2004 09:19 schrieb Guilhem Lavaux:
>  
>
>>Hi,
>>
>>Here is a patch for URL.java and URLStreamHandler.java to implement
>>support for authority and cleanup userInfo handling. I have updated a
>>small testcase in mauve for authority and there does not seem to be
>>any regression. Please review.
>>    
>>
>
>I'm okay with except one little nitpick. Class java.net.URL is final, 
>this implicitely makes all its methods final too. Our policy is to not 
>write redundant modifiers. So should not add them. (I know they are in 
>libgcj's version of java.net.URL but they should be removed.)
>
>
>  
>

Ooops ! Ok I haven't noticed the final at the top of the file. I'll 
remove them.

Cheers,

Guilhem.



From MAILER-DAEMON Tue Apr 20 11:01:01 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFwk8-0000GP-Qc
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 11:01:00 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFwjR-000084-2Z
	for classpath@gnu.org; Tue, 20 Apr 2004 11:00:17 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFwit-0008V8-K3
	for classpath@gnu.org; Tue, 20 Apr 2004 11:00:14 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFwiL-0008QF-TO
	for classpath@gnu.org; Tue, 20 Apr 2004 10:59:10 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-054.ewetel.net
	[80.228.94.54])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i3KEwWnV000262;
	Tue, 20 Apr 2004 16:58:34 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BFwhy-0001PN-00; Tue, 20 Apr 2004 16:58:46 +0200
From: Michael Koch <konqueror@gmx.de>
To: Guilhem Lavaux <guilhem@kaffe.org>, classpath@gnu.org
Date: Tue, 20 Apr 2004 16:58:10 +0200
User-Agent: KMail/1.5.4
References: <1082445328.5635.55.camel@localhost>
	<200404201536.52190.konqueror@gmx.de> <40853651.3000506@kaffe.org>
In-Reply-To: <40853651.3000506@kaffe.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404201658.10730.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: Http headers
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 15:00:19 -0000

Am Dienstag, 20. April 2004 16:40 schrieb Guilhem Lavaux:
> Michael Koch wrote:
> >Am Dienstag, 20. April 2004 09:15 schrieb Guilhem Lavaux:
> >>Hi,
> >>
> >>If you try the mauve test URLConnection/Http you may notice there
> >> is failure due to an unknown header "server" which should be
> >> "Server". Apparently to make the search throught header fields
> >> independent from the case we have using toLowerCase for all header
> >> keys and values: this is not right. I suggest we build keep the
> >> original value in the array in HeaderFieldHelper so we are able to
> >> return the exact value returned by the server.
> >
> >Do we have a mauve testcase for this ? Different http server may act
> >differently. I'm not sure this is bug in our implementation or in
> >mauve. I have locally changed mauve to make it pass.
>
> If you put "server" in mauve it will fail using JDK, if you put
> "Server" in mauve it will fail using Classpath for the same URL. But
> it is sure it depends on the server.

That is why I uses toLowerCase() in my local mauve test. I will 
investigate this further.


Michael




From MAILER-DAEMON Tue Apr 20 12:27:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFy6A-0008FH-Dk
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 12:27:50 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFy67-0008E3-6f
	for classpath@gnu.org; Tue, 20 Apr 2004 12:27:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFy3T-0007Ki-NS
	for classpath@gnu.org; Tue, 20 Apr 2004 12:25:39 -0400
Received: from [213.228.0.62] (helo=postfix4-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFy3S-0007KJ-UZ
	for classpath@gnu.org; Tue, 20 Apr 2004 12:25:03 -0400
Received: from 192.168.1.247 (lns-vlq-7-82-65-220-9.adsl.proxad.net
	[82.65.220.9]) by postfix4-1.free.fr (Postfix) with ESMTP
	id DE398F928C; Tue, 20 Apr 2004 18:24:59 +0200 (CEST)
From: Guilhem Lavaux <guilhem@kaffe.org>
To: Jeroen Frijters <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADE50@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADE50@LEMBU.sumatrasoftware.com>
Content-Type: text/plain
Message-Id: <1082478271.21931.0.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4-8mdk 
Date: Tue, 20 Apr 2004 18:24:31 +0200
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: RE: gnu.java.net.protocol.file.Handler update
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 16:27:48 -0000

Hi,

Thanks Jeroen !
If noone is against I'm checking in this changes now.

Cheers,

Guilhem.

On Tue, 2004-04-20 at 15:32, Jeroen Frijters wrote:
> Guilhem Lavaux wrote:
> > Apparently the special parseURL implementation in
> > gnu.java.net.protocol.file.Handler is not required anymore and even
> > broken according to mauve test gnu.testlet.java.net.URL.URLTest. If we
> > replace it using GCJ implementation (attached) 39 failures 
> > are fixed and no regression happens. So I suggest to use it directly.
> > I haven't yet tested the URL "file:/d|/test.txt" on windows but on
> Linux 
> > GNU Classpath and JDK gives the same result if we suppress this
> > implementation...
> 
> I spent almost the entire day on it, but I finally have it working :-)
> 
> I hope I never have to see another URL ever again... <g>
> 
> BTW, using a pipe instead of a colon doesn't work on the Sun JDK, so I
> don't think we need to bother with that.
> 
> Attached is the patch I ended up with (this includes your patch). I
> think all the URL Mauve tests now pass on Windows and Eclipse 3.0 M8
> continues to run (this was an extremely good test case).
> 
> I'm pretty sure I didn't break non-Windows behavior, but please do take
> a look at the code.
> 
> Here's what I did:
> 
> File.toURL(): Use constructor that doesn't require parsing, to bypass
> problems that arise from the fact that absolute Windows paths do not
> start with a slash (Unix "/foo" should result in file:///foo, while on
> Windows "c:/foo" should result in file:///c:/foo).
> 
> URL: No additional changes.
> 
> URLStreamHandler.parseURL(): Added code to change File.separatorChar to
> / for "file" protocol. The Sun JDK does the same, URLs always use /, but
> when parsing they accept backslashes too.
> Removed code that deals with backslashes. Added code to change
> File.separatorChar to / after using File.getCanonicalPath to
> canonicalize the path (which had the unintended side effect of
> introducing the backslashes again).
> 
> Regards,
> Jeroen




From MAILER-DAEMON Tue Apr 20 13:01:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BFyYn-00027i-9s
	for mharc-classpath@gnu.org; Tue, 20 Apr 2004 12:57:25 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BFyXD-0000yH-Df
	for classpath@gnu.org; Tue, 20 Apr 2004 12:55:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BFyWe-0000h1-7b
	for classpath@gnu.org; Tue, 20 Apr 2004 12:55:12 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BFyUf-0008P3-9x
	for classpath@gnu.org; Tue, 20 Apr 2004 12:53:09 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BFyUV-0000cs-00; Tue, 20 Apr 2004 18:52:59 +0200
From: Mark Wielaard <mark@klomp.org>
To: Guilhem Lavaux <guilhem@kaffe.org>
In-Reply-To: <1082445842.5634.66.camel@localhost>
References: <1082445842.5634.66.camel@localhost>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-ttVlCO5IuqNojzRquBoQ"
Message-Id: <1082479981.1969.10.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Tue, 20 Apr 2004 18:53:01 +0200
Cc: classpath@gnu.org
Subject: Re: gnu.java.net.protocol.file.Handler update
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2004 16:57:14 -0000


--=-ttVlCO5IuqNojzRquBoQ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 2004-04-20 at 09:24, Guilhem Lavaux wrote:
> Apparently the special parseURL implementation in
> gnu.java.net.protocol.file.Handler is not required anymore and even
> broken according to mauve test gnu.testlet.java.net.URL.URLTest. If we
> replace it using GCJ implementation (attached) 39 failures are fixed and
> no regression happens. So I suggest to use it directly.

If we do use it directly, lets please clean it up first.

  protected URLConnection openConnection(URL url) throws IOException
  {
    // If a hostname is set, then we need to switch protocols to ftp
    // in order to transfer this from the remote host.
    String host =3D url.getHost();
    if ((host !=3D null) && (! host.equals("")))
      {
//        throw new IOException("ftp protocol handler not yet implemented."=
);
//        /*
        // Reset the protocol (and implicitly the handler) for this URL.
        // Then have the URL attempt the connection again, as it will
        // get the changed handler the next time around.
        setURL (url, "ftp", url.getHost(), url.getPort(), url.getFile(),
                url.getRef());
        // Until the ftp protocol handler is written, this will cause
        // a NullPointerException.
        return url.openConnection();
//      */
      }

    return new Connection(url);
  }

The // comments commenting out the /* */ comments really make this far to h=
ard to read

Lets replace it with:

  protected URLConnection openConnection(URL url) throws IOException
  {
    // If a hostname is set, then we need to switch protocols to ftp
    // in order to transfer this from the remote host.
    String host =3D url.getHost();
    if ((host !=3D null) && (! host.equals("")))
      {
        // Reset the protocol (and implicitly the handler) for this URL.
        // Then have the URL attempt the connection again, as it will
        // get the changed handler the next time around.
        setURL (url, "ftp", url.getHost(), url.getPort(), url.getFile(),
                url.getRef());

        // Until the ftp protocol handler is written, this will cause
        // a NullPointerException.
        return url.openConnection();
      }

    return new Connection(url);
  }

And we might want to do something nicer then throwing a
NullPointerException when the "ftp" protocol isn't found (as in standard
GNU Classpath).

Cheers,

Mark

--=-ttVlCO5IuqNojzRquBoQ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAhVVtxVhZCJWr9QwRAmc+AKChbz9kI8MKTEsSuVqqaA9yHV96nwCfbQ+V
j7/vh2+QLvEadi6fMe/C6kI=
=eOZO
-----END PGP SIGNATURE-----

--=-ttVlCO5IuqNojzRquBoQ--




From MAILER-DAEMON Wed Apr 21 16:27:16 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGOJQ-0005Ra-Js
	for mharc-classpath@gnu.org; Wed, 21 Apr 2004 16:27:16 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGOGF-0004Zb-OL
	for classpath@gnu.org; Wed, 21 Apr 2004 16:23:59 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGOFU-0004Cl-8V
	for classpath@gnu.org; Wed, 21 Apr 2004 16:23:43 -0400
Received: from [207.189.223.52] (helo=email3.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGOFT-0004Bw-Ga
	for classpath@gnu.org; Wed, 21 Apr 2004 16:23:11 -0400
Received: (qmail 3448 invoked from network); 21 Apr 2004 20:41:12 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email3.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <java@gcc.gnu.org>; 21 Apr 2004 20:41:12 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 108494F843F; Wed, 21 Apr 2004 14:11:56 -0600 (MDT)
To: GNU Classpath Project <classpath@gnu.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: All right,
	you degenerates!  I want this place evacuated in 20 seconds!
Date: 21 Apr 2004 14:11:55 -0600
Message-ID: <87n055rsz8.fsf@fleche.redhat.com>
Lines: 13
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: GCJ mailing list <java@gcc.gnu.org>
Subject: GCC Summit
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Apr 2004 20:27:15 -0000

The second GCC Summit is approaching, see the web page:

    http://www.gccsummit.org/2004/

It is being held in Ottawa, June 2-4.

Andrew and I are giving a paper on the new gcj binary compatibility
ABI; as we discussed at FOSDEM this might also serve as the basis for
the "pluggable JIT API".  Also, quite a few gcj developers are going
to be there.  If you're interested, show up... I'm sure it will be
stimulating.

Tom



From MAILER-DAEMON Thu Apr 22 05:59:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGazM-0000kx-Ag
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 05:59:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGazH-0000jo-6X
	for classpath@gnu.org; Thu, 22 Apr 2004 05:59:19 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGayl-0000dT-HL
	for classpath@gnu.org; Thu, 22 Apr 2004 05:59:18 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGayk-0000cZ-Ee
	for classpath@gnu.org; Thu, 22 Apr 2004 05:58:46 -0400
Date: Thu, 22 Apr 2004 11:58:33 +0200
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----_=_NextPart_001_01C42850.6483FC52"
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADE84@LEMBU.sumatrasoftware.com>
Content-class: urn:content-classes:message
X-MS-Has-Attach: yes
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-TNEF-Correlator: 
Thread-Topic: Class/VMClass change
Thread-Index: AcQoUF9s3SluYUrOSmmB/FentFa2nw==
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: <classpath@gnu.org>
Subject: Class/VMClass change
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 09:59:19 -0000

This is a multi-part message in MIME format.

------_=_NextPart_001_01C42850.6483FC52
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi,

Since nobody objected, I'm going to be committing the change to
Class/VMClass that removes the need for a VMClass instance.

Regards,
Jeroen

Change Log

2004-04-22  Jeroen Frijters  <jeroen@frijters.net>

	* java/lang/Class.java: Changed all calls to VMClass to static
class. (vmClass) Removed.
	(vmdata) Added. (Class) Changed argument type from VMClass to
Object.
	* vm/reference/java/lang/VMClass.java: Changed all instance
methods to static methods.
	* NEWS: Added entry to described Class/VMClass interface change.

------_=_NextPart_001_01C42850.6483FC52
Content-Type: application/octet-stream;
	name="class.patch"
Content-Transfer-Encoding: base64
Content-Description: class.patch
Content-Disposition: attachment;
	filename="class.patch"

SW5kZXg6IE5FV1MNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9jbGFzc3BhdGgvY2xh
c3NwYXRoL05FV1Msdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjM3DQpkaWZmIC11IC1yMS4zNyBO
RVdTDQotLS0gTkVXUwk4IEFwciAyMDA0IDA2OjQ3OjUzIC0wMDAwCTEuMzcNCisrKyBORVdTCTIy
IEFwciAyMDA0IDA5OjUzOjE2IC0wMDAwDQpAQCAtMiw2ICsyLDkgQEANCiANCiBWTSBJbnRlcmZh
Y2UgY2hhbmdlczoNCiANCisqIGphdmEubGFuZy5DbGFzcy9WTUNsYXNzIGludGVyZmFjZSB3YXMg
Y2hhbmdlZC4gVGhlIGludGVyZmFjZSBub3cgbm8NCitsb25nZXIgcmVxdWlyZXMgYW4gaW5zdGFu
Y2Ugb2YgVk1DbGFzcyBmb3IgZWFjaCBDbGFzcyBpbnN0YW5jZS4gSW5zdGVhZA0KK3RoZSBmaWVs
ZCB2bWRhdGEgaW4gQ2xhc3MgaXMgbm93IG9mIHR5cGUgT2JqZWN0Lg0KICogR05VIENsYXNzcGF0
aCBub3cgYXNzdW1lcyB0aGF0IEpOSSBjYWxscyBTZXRYRmllbGQgY2FuIG1vZGlmeSBmaW5hbA0K
IGZpZWxkcy4gVGhpcyB3YXMgcHJldmlvdXNseSB1c2VkIHNpbGVudGx5IGZvciBTeXN0ZW0uaW4v
b3V0L2VyciBhbmQgc2hvdWxkDQogYmUgY29uc2lkZXJlZCBhcyBhIGZlYXR1cmUgbm93LiANCklu
ZGV4OiBqYXZhL2xhbmcvQ2xhc3MuamF2YQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnNyb290
L2NsYXNzcGF0aC9jbGFzc3BhdGgvamF2YS9sYW5nL0NsYXNzLmphdmEsdg0KcmV0cmlldmluZyBy
ZXZpc2lvbiAxLjE4DQpkaWZmIC11IC1yMS4xOCBDbGFzcy5qYXZhDQotLS0gamF2YS9sYW5nL0Ns
YXNzLmphdmEJMTcgQXByIDIwMDQgMTc6MDg6MjIgLTAwMDAJMS4xOA0KKysrIGphdmEvbGFuZy9D
bGFzcy5qYXZhCTIyIEFwciAyMDA0IDA5OjUzOjMxIC0wMDAwDQpAQCAtMTA1LDcgKzEwNSw3IEBA
DQogICAgIHVua25vd25Qcm90ZWN0aW9uRG9tYWluID0gbmV3IFByb3RlY3Rpb25Eb21haW4obnVs
bCwgcGVybWlzc2lvbnMpOw0KICAgfQ0KIA0KLSAgdHJhbnNpZW50IGZpbmFsIFZNQ2xhc3Mgdm1D
bGFzczsNCisgIHRyYW5zaWVudCBmaW5hbCBPYmplY3Qgdm1kYXRhOw0KIA0KICAgLyoqIG5ld0lu
c3RhbmNlKCkgY2FjaGVzIHRoZSBkZWZhdWx0IGNvbnN0cnVjdG9yICovDQogICBwcml2YXRlIHRy
YW5zaWVudCBDb25zdHJ1Y3RvciBjb25zdHJ1Y3RvcjsNCkBAIC0xMTQsOSArMTE0LDkgQEANCiAg
ICAqIENsYXNzIGlzIG5vbi1pbnN0YW50aWFibGUgZnJvbSBKYXZhIGNvZGU7IG9ubHkgdGhlIFZN
IGNhbiBjcmVhdGUNCiAgICAqIGluc3RhbmNlcyBvZiB0aGlzIGNsYXNzLg0KICAgICovDQotICBD
bGFzcyhWTUNsYXNzIHZtQ2xhc3MpDQorICBDbGFzcyhPYmplY3Qgdm1kYXRhKQ0KICAgew0KLSAg
ICB0aGlzLnZtQ2xhc3MgPSB2bUNsYXNzOw0KKyAgICB0aGlzLnZtZGF0YSA9IHZtZGF0YTsNCiAg
IH0NCiANCiAgIC8qKg0KQEAgLTE5MCw3ICsxOTAsNyBAQA0KIAlpZiAoYyAhPSBudWxsKQ0KIAkg
IHsNCiAJICAgIGlmIChpbml0aWFsaXplKQ0KLQkgICAgICBjLnZtQ2xhc3MuaW5pdGlhbGl6ZSgp
Ow0KKwkgICAgICBWTUNsYXNzLmluaXRpYWxpemUoYyk7DQogCSAgICByZXR1cm4gYzsNCiAJICB9
DQogICAgICAgICB0aHJvdyBuZXcgQ2xhc3NOb3RGb3VuZEV4Y2VwdGlvbihuYW1lKTsNCkBAIC0y
MDAsNyArMjAwLDcgQEANCiAgICAgQ2xhc3MgYyA9IGNsYXNzbG9hZGVyLmxvYWRDbGFzcyhuYW1l
KTsNCiAgICAgY2xhc3Nsb2FkZXIucmVzb2x2ZUNsYXNzKGMpOw0KICAgICBpZiAoaW5pdGlhbGl6
ZSkNCi0gICAgICBjLnZtQ2xhc3MuaW5pdGlhbGl6ZSgpOw0KKyAgICAgIFZNQ2xhc3MuaW5pdGlh
bGl6ZShjKTsNCiAgICAgcmV0dXJuIGM7DQogICB9DQogICANCkBAIC0yNTYsNyArMjU2LDcgQEAN
CiAgICAgaWYgKG5hbWUuc3RhcnRzV2l0aCgiamF2YS4iKSB8fCBuYW1lLnN0YXJ0c1dpdGgoImdu
dS5qYXZhLiIpKQ0KICAgICAgIHJldHVybiBudWxsOw0KIA0KLSAgICBDbGFzc0xvYWRlciBsb2Fk
ZXIgPSB2bUNsYXNzLmdldENsYXNzTG9hZGVyKCk7DQorICAgIENsYXNzTG9hZGVyIGxvYWRlciA9
IFZNQ2xhc3MuZ2V0Q2xhc3NMb2FkZXIodGhpcyk7DQogICAgIC8vIENoZWNrIGlmIHdlIG1heSBn
ZXQgdGhlIGNsYXNzbG9hZGVyDQogICAgIFNlY3VyaXR5TWFuYWdlciBzbSA9IFN5c3RlbS5nZXRT
ZWN1cml0eU1hbmFnZXIoKTsNCiAgICAgaWYgKHNtICE9IG51bGwpDQpAQCAtMjgyLDcgKzI4Miw3
IEBADQogICAgKi8NCiAgIHB1YmxpYyBDbGFzcyBnZXRDb21wb25lbnRUeXBlKCkNCiAgIHsNCi0g
ICAgcmV0dXJuIHZtQ2xhc3MuZ2V0Q29tcG9uZW50VHlwZSAoKTsNCisgICAgcmV0dXJuIFZNQ2xh
c3MuZ2V0Q29tcG9uZW50VHlwZSAodGhpcyk7DQogICB9DQogDQogICAvKioNCkBAIC0zNzgsNyAr
Mzc4LDcgQEANCiANCiAgIENsYXNzW10gZ2V0RGVjbGFyZWRDbGFzc2VzIChib29sZWFuIHB1Ymxp
Y09ubHkpDQogICB7DQotICAgIHJldHVybiB2bUNsYXNzLmdldERlY2xhcmVkQ2xhc3NlcyAocHVi
bGljT25seSk7DQorICAgIHJldHVybiBWTUNsYXNzLmdldERlY2xhcmVkQ2xhc3NlcyAodGhpcywg
cHVibGljT25seSk7DQogICB9DQogDQogICAvKioNCkBAIC00MDEsNyArNDAxLDcgQEANCiANCiAg
IENvbnN0cnVjdG9yW10gZ2V0RGVjbGFyZWRDb25zdHJ1Y3RvcnMgKGJvb2xlYW4gcHVibGljT25s
eSkNCiAgIHsNCi0gICAgcmV0dXJuIHZtQ2xhc3MuZ2V0RGVjbGFyZWRDb25zdHJ1Y3RvcnMgKHB1
YmxpY09ubHkpOw0KKyAgICByZXR1cm4gVk1DbGFzcy5nZXREZWNsYXJlZENvbnN0cnVjdG9ycyAo
dGhpcywgcHVibGljT25seSk7DQogICB9DQogICANCiAgIC8qKg0KQEAgLTQ0OSw3ICs0NDksNyBA
QA0KIA0KICAgRmllbGRbXSBnZXREZWNsYXJlZEZpZWxkcyAoYm9vbGVhbiBwdWJsaWNPbmx5KQ0K
ICAgew0KLSAgICByZXR1cm4gdm1DbGFzcy5nZXREZWNsYXJlZEZpZWxkcyAocHVibGljT25seSk7
DQorICAgIHJldHVybiBWTUNsYXNzLmdldERlY2xhcmVkRmllbGRzICh0aGlzLCBwdWJsaWNPbmx5
KTsNCiAgIH0NCiANCiAgIC8qKg0KQEAgLTUwNyw3ICs1MDcsNyBAQA0KIA0KICAgTWV0aG9kW10g
Z2V0RGVjbGFyZWRNZXRob2RzIChib29sZWFuIHB1YmxpY09ubHkpDQogICB7DQotICAgIHJldHVy
biB2bUNsYXNzLmdldERlY2xhcmVkTWV0aG9kcyAocHVibGljT25seSk7DQorICAgIHJldHVybiBW
TUNsYXNzLmdldERlY2xhcmVkTWV0aG9kcyAodGhpcywgcHVibGljT25seSk7DQogICB9DQogIA0K
ICAgLyoqDQpAQCAtNTE5LDcgKzUxOSw3IEBADQogICAgKi8NCiAgIHB1YmxpYyBDbGFzcyBnZXRE
ZWNsYXJpbmdDbGFzcygpDQogICB7DQotICAgIHJldHVybiB2bUNsYXNzLmdldERlY2xhcmluZ0Ns
YXNzICgpOw0KKyAgICByZXR1cm4gVk1DbGFzcy5nZXREZWNsYXJpbmdDbGFzcyAodGhpcyk7DQog
ICB9DQogDQogICAvKioNCkBAIC02MDgsNyArNjA4LDcgQEANCiAgICAqLw0KICAgcHVibGljIENs
YXNzW10gZ2V0SW50ZXJmYWNlcygpDQogICB7DQotICAgIHJldHVybiB2bUNsYXNzLmdldEludGVy
ZmFjZXMgKCk7DQorICAgIHJldHVybiBWTUNsYXNzLmdldEludGVyZmFjZXMgKHRoaXMpOw0KICAg
fQ0KIA0KICAgcHJpdmF0ZSBzdGF0aWMgZmluYWwgY2xhc3MgTWV0aG9kS2V5DQpAQCAtODM3LDcg
KzgzNyw3IEBADQogICAgKi8NCiAgIHB1YmxpYyBpbnQgZ2V0TW9kaWZpZXJzKCkNCiAgIHsNCi0g
ICAgcmV0dXJuIHZtQ2xhc3MuZ2V0TW9kaWZpZXJzICgpOw0KKyAgICByZXR1cm4gVk1DbGFzcy5n
ZXRNb2RpZmllcnMgKHRoaXMpOw0KICAgfQ0KICAgDQogICAvKioNCkBAIC04NjIsNyArODYyLDcg
QEANCiAgICAqLw0KICAgcHVibGljIFN0cmluZyBnZXROYW1lKCkNCiAgIHsgDQotICAgIHJldHVy
biB2bUNsYXNzLmdldE5hbWUgKCk7DQorICAgIHJldHVybiBWTUNsYXNzLmdldE5hbWUgKHRoaXMp
Ow0KICAgfQ0KIA0KICAgLyoqDQpAQCAtOTY5LDcgKzk2OSw3IEBADQogICAgKi8NCiAgIHB1Ymxp
YyBDbGFzcyBnZXRTdXBlcmNsYXNzKCkNCiAgIHsNCi0gICAgcmV0dXJuIHZtQ2xhc3MuZ2V0U3Vw
ZXJjbGFzcyAoKTsNCisgICAgcmV0dXJuIFZNQ2xhc3MuZ2V0U3VwZXJjbGFzcyAodGhpcyk7DQog
ICB9DQogICANCiAgIC8qKg0KQEAgLTk4MCwxMSArOTgwLDcgQEANCiAgICAqLw0KICAgcHVibGlj
IGJvb2xlYW4gaXNBcnJheSgpDQogICB7DQotICAgIGludCByZXN1bHQgPSAtMTsNCi0gICAgaWYg
KChyZXN1bHQgPSB2bUNsYXNzLmlzQXJyYXkgKCkpIDwgMCkNCi0gICAgICByZXR1cm4gZ2V0TmFt
ZSgpLmNoYXJBdCgwKSA9PSAnWyc7DQotDQotICAgIHJldHVybiByZXN1bHQgPT0gMTsNCisgICAg
cmV0dXJuIFZNQ2xhc3MuaXNBcnJheSAodGhpcyk7DQogICB9DQogICANCiAgIC8qKg0KQEAgLTEw
MDMsNyArOTk5LDcgQEANCiAgICAqLw0KICAgcHVibGljIGJvb2xlYW4gaXNBc3NpZ25hYmxlRnJv
bShDbGFzcyBjKQ0KICAgew0KLSAgICByZXR1cm4gdm1DbGFzcy5pc0Fzc2lnbmFibGVGcm9tIChj
KTsNCisgICAgcmV0dXJuIFZNQ2xhc3MuaXNBc3NpZ25hYmxlRnJvbSAodGhpcywgYyk7DQogICB9
DQogIA0KICAgLyoqDQpAQCAtMTAxNiw3ICsxMDEyLDcgQEANCiAgICAqLw0KICAgcHVibGljIGJv
b2xlYW4gaXNJbnN0YW5jZShPYmplY3QgbykNCiAgIHsNCi0gICAgcmV0dXJuIHZtQ2xhc3MuaXNJ
bnN0YW5jZSAobyk7DQorICAgIHJldHVybiBWTUNsYXNzLmlzSW5zdGFuY2UgKHRoaXMsIG8pOw0K
ICAgfQ0KICAgDQogICAvKioNCkBAIC0xMDI3LDcgKzEwMjMsNyBAQA0KICAgICovDQogICBwdWJs
aWMgYm9vbGVhbiBpc0ludGVyZmFjZSgpDQogICB7DQotICAgIHJldHVybiB2bUNsYXNzLmlzSW50
ZXJmYWNlICgpOw0KKyAgICByZXR1cm4gVk1DbGFzcy5pc0ludGVyZmFjZSAodGhpcyk7DQogICB9
DQogICANCiAgIC8qKg0KQEAgLTEwNTEsNyArMTA0Nyw3IEBADQogICAgKi8NCiAgIHB1YmxpYyBi
b29sZWFuIGlzUHJpbWl0aXZlKCkNCiAgIHsNCi0gICAgcmV0dXJuIHZtQ2xhc3MuaXNQcmltaXRp
dmUgKCk7DQorICAgIHJldHVybiBWTUNsYXNzLmlzUHJpbWl0aXZlICh0aGlzKTsNCiAgIH0NCiAg
IA0KICAgLyoqDQpJbmRleDogdm0vcmVmZXJlbmNlL2phdmEvbGFuZy9WTUNsYXNzLmphdmENCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0NClJDUyBmaWxlOiAvY3Zzcm9vdC9jbGFzc3BhdGgvY2xhc3NwYXRoL3ZtL3JlZmVy
ZW5jZS9qYXZhL2xhbmcvVk1DbGFzcy5qYXZhLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS44DQpk
aWZmIC11IC1yMS44IFZNQ2xhc3MuamF2YQ0KLS0tIHZtL3JlZmVyZW5jZS9qYXZhL2xhbmcvVk1D
bGFzcy5qYXZhCTE3IEFwciAyMDAzIDEyOjMyOjI5IC0wMDAwCTEuOA0KKysrIHZtL3JlZmVyZW5j
ZS9qYXZhL2xhbmcvVk1DbGFzcy5qYXZhCTIyIEFwciAyMDA0IDA5OjUzOjQ4IC0wMDAwDQpAQCAt
MSw1ICsxLDUgQEANCiAvKiBWTUNsYXNzLmphdmEgLS0gVk0gU3BlY2lmaWMgQ2xhc3MgbWV0aG9k
cw0KLSAgIENvcHlyaWdodCAoQykgMjAwMyBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24NCisgICBD
b3B5cmlnaHQgKEMpIDIwMDMsIDIwMDQgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uDQogDQogVGhp
cyBmaWxlIGlzIHBhcnQgb2YgR05VIENsYXNzcGF0aC4NCiANCkBAIC0zNyw3ICszNyw2IEBADQog
DQogcGFja2FnZSBqYXZhLmxhbmc7DQogDQotaW1wb3J0IGdudS5jbGFzc3BhdGguUmF3RGF0YTsN
CiBpbXBvcnQgamF2YS5sYW5nLnJlZmxlY3QuQ29uc3RydWN0b3I7DQogaW1wb3J0IGphdmEubGFu
Zy5yZWZsZWN0LkZpZWxkOw0KIGltcG9ydCBqYXZhLmxhbmcucmVmbGVjdC5NZXRob2Q7DQpAQCAt
NjgsMTcgKzY3LDYgQEANCiAgIHByaXZhdGUgbmF0aXZlIHZvaWQgc3RlcDcoKTsNCiAgIHByaXZh
dGUgbmF0aXZlIHZvaWQgc3RlcDgoKTsNCiANCi0gIC8qKg0KLSAgICogUG9pbnRlciB0byBWTSBp
bnRlcm5hbCBjbGFzcyBzdHJ1Y3R1cmUuDQotICAgKi8NCi0NCi0gIHByaXZhdGUgZmluYWwgUmF3
RGF0YSB2bURhdGE7ICANCi0NCi0gIHByaXZhdGUgVk1DbGFzcyhSYXdEYXRhIHZtRGF0YSkgDQot
ICB7IA0KLSAgICB0aGlzLnZtRGF0YSA9IHZtRGF0YTsNCi0gIH0NCi0NCiAgIHByaXZhdGUgdm9p
ZCBpbml0aWFsaXplKGludCB0aHJlYWQpIHRocm93cyBJbnRlcnJ1cHRlZEV4Y2VwdGlvbg0KICAg
ew0KICAgICBFcnJvciBlcnJvcjsNCkBAIC0xNTYsMTEgKzE0NCwxMiBAQA0KICAgICogRGlzY292
ZXIgd2hldGhlciBhbiBPYmplY3QgaXMgYW4gaW5zdGFuY2Ugb2YgdGhpcyBDbGFzcy4gIFRoaW5r
IG9mIGl0DQogICAgKiBhcyBhbG1vc3QgbGlrZSA8Y29kZT5vIGluc3RhbmNlb2YgKHRoaXMgY2xh
c3MpPC9jb2RlPi4NCiAgICAqDQorICAgKiBAcGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0
aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHBhcmFtIG8gdGhlIE9iamVjdCB0byBjaGVjaw0KICAg
ICogQHJldHVybiB3aGV0aGVyIG8gaXMgYW4gaW5zdGFuY2Ugb2YgdGhpcyBjbGFzcw0KICAgICog
QHNpbmNlIDEuMQ0KICAgICovDQotICBuYXRpdmUgYm9vbGVhbiBpc0luc3RhbmNlKE9iamVjdCBv
KTsNCisgIHN0YXRpYyBuYXRpdmUgYm9vbGVhbiBpc0luc3RhbmNlKENsYXNzIGtsYXNzLCBPYmpl
Y3Qgbyk7DQogDQogICAvKioNCiAgICAqIERpc2NvdmVyIHdoZXRoZXIgYW4gaW5zdGFuY2Ugb2Yg
dGhlIENsYXNzIHBhcmFtZXRlciB3b3VsZCBiZSBhbg0KQEAgLTE3MCwyMSArMTU5LDIzIEBADQog
ICAgKiBjaGVja3Mgd2lkZW5pbmcgY29udmVyc2lvbnMgZm9yIG9iamVjdHMsIGl0IG11c3QgYmUg
ZXhhY3QgZm9yIHByaW1pdGl2ZQ0KICAgICogdHlwZXMuDQogICAgKg0KKyAgICogQHBhcmFtIGts
YXNzIHRoZSBDbGFzcyBvYmplY3QgdGhhdCdzIGNhbGxpbmcgdXMNCiAgICAqIEBwYXJhbSBjIHRo
ZSBjbGFzcyB0byBjaGVjaw0KICAgICogQHJldHVybiB3aGV0aGVyIGFuIGluc3RhbmNlIG9mIGMg
d291bGQgYmUgYW4gaW5zdGFuY2Ugb2YgdGhpcyBjbGFzcw0KICAgICogICAgICAgICBhcyB3ZWxs
DQogICAgKiBAdGhyb3dzIE51bGxQb2ludGVyRXhjZXB0aW9uIGlmIGMgaXMgbnVsbA0KICAgICog
QHNpbmNlIDEuMQ0KICAgICovDQotICBuYXRpdmUgYm9vbGVhbiBpc0Fzc2lnbmFibGVGcm9tKENs
YXNzIGMpOw0KKyAgc3RhdGljIG5hdGl2ZSBib29sZWFuIGlzQXNzaWduYWJsZUZyb20oQ2xhc3Mg
a2xhc3MsIENsYXNzIGMpOw0KIA0KICAgLyoqDQogICAgKiBDaGVjayB3aGV0aGVyIHRoaXMgY2xh
c3MgaXMgYW4gaW50ZXJmYWNlIG9yIG5vdC4gIEFycmF5IHR5cGVzIGFyZSBub3QNCiAgICAqIGlu
dGVyZmFjZXMuDQogICAgKg0KKyAgICogQHBhcmFtIGtsYXNzIHRoZSBDbGFzcyBvYmplY3QgdGhh
dCdzIGNhbGxpbmcgdXMNCiAgICAqIEByZXR1cm4gd2hldGhlciB0aGlzIGNsYXNzIGlzIGFuIGlu
dGVyZmFjZSBvciBub3QNCiAgICAqLw0KLSAgbmF0aXZlIGJvb2xlYW4gaXNJbnRlcmZhY2UoKTsN
CisgIHN0YXRpYyBuYXRpdmUgYm9vbGVhbiBpc0ludGVyZmFjZShDbGFzcyBrbGFzcyk7DQogDQog
ICAvKioNCiAgICAqIFJldHVybiB3aGV0aGVyIHRoaXMgY2xhc3MgaXMgYSBwcmltaXRpdmUgdHlw
ZS4gIEEgcHJpbWl0aXZlIHR5cGUgY2xhc3MNCkBAIC0xOTMsNiArMTg0LDcgQEANCiAgICAqIGNs
YXNzZXMgdGhyb3VnaCBqYXZhLmxhbmcuQm9vbGVhbi5UWVBFLCBqYXZhLmxhbmcuSW50ZWdlci5U
WVBFLCBldGMuLA0KICAgICogb3IgdGhyb3VnaCBib29sZWFuLmNsYXNzLCBpbnQuY2xhc3MsIGV0
Yy4NCiAgICAqDQorICAgKiBAcGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2Fs
bGluZyB1cw0KICAgICogQHJldHVybiB3aGV0aGVyIHRoaXMgY2xhc3MgaXMgYSBwcmltaXRpdmUg
dHlwZQ0KICAgICogQHNlZSBCb29sZWFuI1RZUEUNCiAgICAqIEBzZWUgQnl0ZSNUWVBFDQpAQCAt
MjA1LDcgKzE5Nyw3IEBADQogICAgKiBAc2VlIFZvaWQjVFlQRQ0KICAgICogQHNpbmNlIDEuMQ0K
ICAgICovDQotICBuYXRpdmUgYm9vbGVhbiBpc1ByaW1pdGl2ZSgpOw0KKyAgc3RhdGljIG5hdGl2
ZSBib29sZWFuIGlzUHJpbWl0aXZlKENsYXNzIGtsYXNzKTsNCiANCiAgIC8qKg0KICAgICogR2V0
IHRoZSBuYW1lIG9mIHRoaXMgY2xhc3MsIHNlcGFyYXRlZCBieSBkb3RzIGZvciBwYWNrYWdlIHNl
cGFyYXRvcnMuDQpAQCAtMjI0LDE4ICsyMTYsMjAgQEANCiAgICAqIGNsYXNzIG9yIGludGVyZmFj
ZSwgYWxvbmU6ICZsdDtkb3R0ZWQgbmFtZSZndDsNCiAgICAqIGNsYXNzIG9yIGludGVyZmFjZSwg
YXMgZWxlbWVudCB0eXBlOiBMJmx0O2RvdHRlZCBuYW1lJmd0OzsNCiAgICAqDQorICAgKiBAcGFy
YW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHJldHVy
biB0aGUgbmFtZSBvZiB0aGlzIGNsYXNzDQogICAgKi8NCi0gIG5hdGl2ZSBTdHJpbmcgZ2V0TmFt
ZSgpOw0KKyAgc3RhdGljIG5hdGl2ZSBTdHJpbmcgZ2V0TmFtZShDbGFzcyBrbGFzcyk7DQogDQog
ICAvKioNCiAgICAqIEdldCB0aGUgZGlyZWN0IHN1cGVyY2xhc3Mgb2YgdGhpcyBjbGFzcy4gIElm
IHRoaXMgaXMgYW4gaW50ZXJmYWNlLA0KICAgICogT2JqZWN0LCBhIHByaW1pdGl2ZSB0eXBlLCBv
ciB2b2lkLCBpdCB3aWxsIHJldHVybiBudWxsLiBJZiB0aGlzIGlzIGFuDQogICAgKiBhcnJheSB0
eXBlLCBpdCB3aWxsIHJldHVybiBPYmplY3QuDQogICAgKg0KKyAgICogQHBhcmFtIGtsYXNzIHRo
ZSBDbGFzcyBvYmplY3QgdGhhdCdzIGNhbGxpbmcgdXMNCiAgICAqIEByZXR1cm4gdGhlIGRpcmVj
dCBzdXBlcmNsYXNzIG9mIHRoaXMgY2xhc3MNCiAgICAqLw0KLSAgbmF0aXZlIENsYXNzIGdldFN1
cGVyY2xhc3MoKTsNCisgIHN0YXRpYyBuYXRpdmUgQ2xhc3MgZ2V0U3VwZXJjbGFzcyhDbGFzcyBr
bGFzcyk7DQogDQogICAvKioNCiAgICAqIEdldCB0aGUgaW50ZXJmYWNlcyB0aGlzIGNsYXNzIDxF
TT5kaXJlY3RseTwvRU0+IGltcGxlbWVudHMsIGluIHRoZQ0KQEAgLTI0Myw5ICsyMzcsMTAgQEAN
CiAgICAqIGZvciBPYmplY3QsIHByaW1pdGl2ZXMsIHZvaWQsIGFuZCBjbGFzc2VzIG9yIGludGVy
ZmFjZXMgd2l0aCBubyBkaXJlY3QNCiAgICAqIHN1cGVyaW50ZXJmYWNlLiBBcnJheSB0eXBlcyBy
ZXR1cm4gQ2xvbmVhYmxlIGFuZCBTZXJpYWxpemFibGUuDQogICAgKg0KKyAgICogQHBhcmFtIGts
YXNzIHRoZSBDbGFzcyBvYmplY3QgdGhhdCdzIGNhbGxpbmcgdXMNCiAgICAqIEByZXR1cm4gdGhl
IGludGVyZmFjZXMgdGhpcyBjbGFzcyBkaXJlY3RseSBpbXBsZW1lbnRzDQogICAgKi8NCi0gIG5h
dGl2ZSBDbGFzc1tdIGdldEludGVyZmFjZXMoKTsNCisgIHN0YXRpYyBuYXRpdmUgQ2xhc3NbXSBn
ZXRJbnRlcmZhY2VzKENsYXNzIGtsYXNzKTsNCiANCiAgIC8qKg0KICAgICogSWYgdGhpcyBpcyBh
biBhcnJheSwgZ2V0IHRoZSBDbGFzcyByZXByZXNlbnRpbmcgdGhlIHR5cGUgb2YgYXJyYXkuDQpA
QCAtMjUzLDExICsyNDgsMTIgQEANCiAgICAqIGNhbGxpbmcgZ2V0Q29tcG9uZW50VHlwZSBvbiB0
aGF0IHdvdWxkIGdpdmUgImphdmEubGFuZy5TdHJpbmciLiAgSWYNCiAgICAqIHRoaXMgaXMgbm90
IGFuIGFycmF5LCByZXR1cm5zIG51bGwuDQogICAgKg0KKyAgICogQHBhcmFtIGtsYXNzIHRoZSBD
bGFzcyBvYmplY3QgdGhhdCdzIGNhbGxpbmcgdXMNCiAgICAqIEByZXR1cm4gdGhlIGFycmF5IHR5
cGUgb2YgdGhpcyBjbGFzcywgb3IgbnVsbA0KICAgICogQHNlZSBBcnJheQ0KICAgICogQHNpbmNl
IDEuMQ0KICAgICovDQotICBuYXRpdmUgQ2xhc3MgZ2V0Q29tcG9uZW50VHlwZSgpOw0KKyAgc3Rh
dGljIG5hdGl2ZSBDbGFzcyBnZXRDb21wb25lbnRUeXBlKENsYXNzIGtsYXNzKTsNCiANCiAgIC8q
Kg0KICAgICogR2V0IHRoZSBtb2RpZmllcnMgb2YgdGhpcyBjbGFzcy4gIFRoZXNlIGNhbiBiZSBk
ZWNvZGVkIHVzaW5nIE1vZGlmaWVyLA0KQEAgLTI2Nyw1NiArMjYzLDYzIEBADQogICAgKiBtYXJr
ZWQgZmluYWwgYnV0IG5vdCBhbiBpbnRlcmZhY2UuIFByaW1pdGl2ZSB0eXBlcyBhbmQgdm9pZCBh
cmUgbWFya2VkDQogICAgKiBwdWJsaWMgYW5kIGZpbmFsLCBidXQgbm90IGFuIGludGVyZmFjZS4N
CiAgICAqDQorICAgKiBAcGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGlu
ZyB1cw0KICAgICogQHJldHVybiB0aGUgbW9kaWZpZXJzIG9mIHRoaXMgY2xhc3MNCiAgICAqIEBz
ZWUgTW9kaWZlcg0KICAgICogQHNpbmNlIDEuMQ0KICAgICovDQotICBuYXRpdmUgaW50IGdldE1v
ZGlmaWVycygpOw0KKyAgc3RhdGljIG5hdGl2ZSBpbnQgZ2V0TW9kaWZpZXJzKENsYXNzIGtsYXNz
KTsNCiANCiAgIC8qKg0KICAgICogSWYgdGhpcyBpcyBhIG5lc3RlZCBvciBpbm5lciBjbGFzcywg
cmV0dXJuIHRoZSBjbGFzcyB0aGF0IGRlY2xhcmVkIGl0Lg0KICAgICogSWYgbm90LCByZXR1cm4g
bnVsbC4NCiAgICAqDQorICAgKiBAcGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3Mg
Y2FsbGluZyB1cw0KICAgICogQHJldHVybiB0aGUgZGVjbGFyaW5nIGNsYXNzIG9mIHRoaXMgY2xh
c3MNCiAgICAqIEBzaW5jZSAxLjENCiAgICAqLw0KLSAgbmF0aXZlIENsYXNzIGdldERlY2xhcmlu
Z0NsYXNzKCk7DQorICBzdGF0aWMgbmF0aXZlIENsYXNzIGdldERlY2xhcmluZ0NsYXNzKENsYXNz
IGtsYXNzKTsNCiANCiAgIC8qKg0KICAgICogTGlrZSA8Y29kZT5nZXREZWNsYXJlZENsYXNzZXMo
KTwvY29kZT4gYnV0IHdpdGhvdXQgdGhlIHNlY3VyaXR5IGNoZWNrcy4NCiAgICAqDQorICAgKiBA
cGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHBh
cmFtIHB1bGljT25seSBPbmx5IHB1YmxpYyBjbGFzc2VzIHNob3VsZCBiZSByZXR1cm5lZA0KICAg
ICovDQotICBuYXRpdmUgQ2xhc3NbXSBnZXREZWNsYXJlZENsYXNzZXMoYm9vbGVhbiBwdWJsaWNP
bmx5KTsNCisgIHN0YXRpYyBuYXRpdmUgQ2xhc3NbXSBnZXREZWNsYXJlZENsYXNzZXMoQ2xhc3Mg
a2xhc3MsIGJvb2xlYW4gcHVibGljT25seSk7DQogDQogICAvKioNCiAgICAqIExpa2UgPGNvZGU+
Z2V0RGVjbGFyZWRGaWVsZHMoKTwvY29kZT4gYnV0IHdpdGhvdXQgdGhlIHNlY3VyaXR5IGNoZWNr
cy4NCiAgICAqDQorICAgKiBAcGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2Fs
bGluZyB1cw0KICAgICogQHBhcmFtIHB1bGljT25seSBPbmx5IHB1YmxpYyBmaWVsZHMgc2hvdWxk
IGJlIHJldHVybmVkDQogICAgKi8NCi0gIG5hdGl2ZSBGaWVsZFtdIGdldERlY2xhcmVkRmllbGRz
KGJvb2xlYW4gcHVibGljT25seSk7DQorICBzdGF0aWMgbmF0aXZlIEZpZWxkW10gZ2V0RGVjbGFy
ZWRGaWVsZHMoQ2xhc3Mga2xhc3MsIGJvb2xlYW4gcHVibGljT25seSk7DQogDQogICAvKioNCiAg
ICAqIExpa2UgPGNvZGU+Z2V0RGVjbGFyZWRNZXRob2RzKCk8L2NvZGU+IGJ1dCB3aXRob3V0IHRo
ZSBzZWN1cml0eSBjaGVja3MuDQogICAgKg0KKyAgICogQHBhcmFtIGtsYXNzIHRoZSBDbGFzcyBv
YmplY3QgdGhhdCdzIGNhbGxpbmcgdXMNCiAgICAqIEBwYXJhbSBwdWxpY09ubHkgT25seSBwdWJs
aWMgbWV0aG9kcyBzaG91bGQgYmUgcmV0dXJuZWQNCiAgICAqLw0KLSAgbmF0aXZlIE1ldGhvZFtd
IGdldERlY2xhcmVkTWV0aG9kcyhib29sZWFuIHB1YmxpY09ubHkpOw0KKyAgc3RhdGljIG5hdGl2
ZSBNZXRob2RbXSBnZXREZWNsYXJlZE1ldGhvZHMoQ2xhc3Mga2xhc3MsIGJvb2xlYW4gcHVibGlj
T25seSk7DQogDQogICAvKioNCiAgICAqIExpa2UgPGNvZGU+Z2V0RGVjbGFyZWRDb25zdHJ1Y3Rv
cnMoKTwvY29kZT4gYnV0IHdpdGhvdXQNCiAgICAqIHRoZSBzZWN1cml0eSBjaGVja3MuDQogICAg
Kg0KKyAgICogQHBhcmFtIGtsYXNzIHRoZSBDbGFzcyBvYmplY3QgdGhhdCdzIGNhbGxpbmcgdXMN
CiAgICAqIEBwYXJhbSBwdWxpY09ubHkgT25seSBwdWJsaWMgY29uc3RydWN0b3JzIHNob3VsZCBi
ZSByZXR1cm5lZA0KICAgICovDQotICBuYXRpdmUgQ29uc3RydWN0b3JbXSBnZXREZWNsYXJlZENv
bnN0cnVjdG9ycyhib29sZWFuIHB1YmxpY09ubHkpOw0KKyAgc3RhdGljIG5hdGl2ZSBDb25zdHJ1
Y3RvcltdIGdldERlY2xhcmVkQ29uc3RydWN0b3JzKENsYXNzIGtsYXNzLCBib29sZWFuIHB1Ymxp
Y09ubHkpOw0KIA0KICAgLyoqDQogICAgKiBSZXR1cm4gdGhlIGNsYXNzIGxvYWRlciBvZiB0aGlz
IGNsYXNzLg0KICAgICoNCisgICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0IHRoYXQn
cyBjYWxsaW5nIHVzDQogICAgKiBAcmV0dXJuIHRoZSBjbGFzcyBsb2FkZXINCiAgICAqLw0KLSAg
bmF0aXZlIENsYXNzTG9hZGVyIGdldENsYXNzTG9hZGVyKCk7DQorICBzdGF0aWMgbmF0aXZlIENs
YXNzTG9hZGVyIGdldENsYXNzTG9hZGVyKENsYXNzIGtsYXNzKTsNCiANCiAgIC8qKg0KICAgICog
Vk0gaW1wbGVtZW50b3JzIGFyZSBmcmVlIHRvIG1ha2UgdGhpcyBtZXRob2QgYSBub29wIGlmIA0K
QEAgLTMzNSwxOSArMzM4LDIxIEBADQogICAvKioNCiAgICAqIFJldHVybiB3aGV0aGVyIHRoaXMg
Y2xhc3MgaXMgYW4gYXJyYXkgdHlwZS4NCiAgICAqDQotICAgKiBAcmV0dXJuIDEgaWYgdGhpcyBj
bGFzcyBpcyBhbiBhcnJheSB0eXBlLCAwIG90aGVyd2lzZSwgLTEgaWYgdW5zdXBwb3J0ZWQNCisg
ICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0IHRoYXQncyBjYWxsaW5nIHVzDQorICAg
KiBAcmV0dXJuIHRydWUgaWYgdGhpcyBjbGFzcyBpcyBhbiBhcnJheSB0eXBlDQogICAgKiBvcGVy
YXRpb24NCiAgICAqLw0KLSAgbmF0aXZlIGludCBpc0FycmF5KCk7DQorICBzdGF0aWMgbmF0aXZl
IGJvb2xlYW4gaXNBcnJheShDbGFzcyBrbGFzcyk7DQogDQogICAvKioNCiAgICAqIFRoaXMgbWV0
aG9kIHNob3VsZCB0cmlnZ2VyIGNsYXNzIGluaXRpYWxpemF0aW9uIChpZiB0aGUNCiAgICAqIGNs
YXNzIGhhc24ndCBhbHJlYWR5IGJlZW4gaW5pdGlhbGl6ZWQpDQogICAgKiANCisgICAqIEBwYXJh
bSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0IHRoYXQncyBjYWxsaW5nIHVzDQogICAgKiBAdGhyb3dz
IEV4Y2VwdGlvbkluSW5pdGlhbGl6ZXJFcnJvciBpZiBhbiBleGNlcHRpb24NCiAgICAqICAgICAg
ICAgb2NjdXJzIGR1cmluZyBpbml0aWFsaXphdGlvbg0KICAgICovDQotICBuYXRpdmUgdm9pZCBp
bml0aWFsaXplKCk7DQorICBzdGF0aWMgbmF0aXZlIHZvaWQgaW5pdGlhbGl6ZShDbGFzcyBrbGFz
cyk7DQogDQogICAvKioNCiAgICAqIExvYWQgYW4gYXJyYXkgY2xhc3MuDQo=

------_=_NextPart_001_01C42850.6483FC52--



From MAILER-DAEMON Thu Apr 22 08:39:06 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGdSw-0002pO-I7
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 08:38:06 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGdSa-0002cI-5h
	for classpath@gnu.org; Thu, 22 Apr 2004 08:37:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGdRg-0002Gm-Rp
	for classpath@gnu.org; Thu, 22 Apr 2004 08:37:21 -0400
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGcr5-0003TI-G2
	for classpath@gnu.org; Thu, 22 Apr 2004 07:58:59 -0400
Received: (qmail 7100 invoked by uid 504); 22 Apr 2004 13:52:17 +0200
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 1.544291 secs); 22 Apr 2004 11:52:17 -0000
Received: from unknown (HELO oz.fapse.ulg.ac.be) ([139.165.77.198])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <classpathx-discuss@gnu.org>; 22 Apr 2004 13:52:15 +0200
Received: from arnaud by oz.fapse.ulg.ac.be with local (Exim 4.32)
	id 1BGckX-0005Wq-H5; Thu, 22 Apr 2004 13:52:13 +0200
To: classpathx-discuss <classpathx-discuss@gnu.org>
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
X-Face: >U]gI'=hKRtZE@~Svh"mU,aS"">yCT*dBkVAFl'!]!&k@R8fEr{-)Ql6{xhuXKb+!>}x;
	^2ck7Ytr'EABxt~)3q?AO}$:wwSva.$uNN9x.w4+uVmMMSB1~EbJgo|9E0yQXONuM'~c*20^
Mail-Followup-To: classpathx-discuss <classpathx-discuss@gnu.org>, ClassPath
	List <classpath@gnu.org>, Kaffe Mailing List <kaffe@kaffe.org>,
	sablevm-developer <sablevm-developer@lists.sourceforge.net>
Date: Thu, 22 Apr 2004 13:52:08 +0200
Message-ID: <87r7ugi61j.fsf@oz.fapse.ulg.ac.be>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
Cc: sablevm-developer <sablevm-developer@lists.sourceforge.net>,
	ClassPath List <classpath@gnu.org>, Kaffe Mailing List <kaffe@kaffe.org>
Subject: [GNUJAXP] Moving src to source!
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 12:37:52 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all!

I am very sorry and don't ask why I did move the sources of gnujaxp to
'src' directory (I don't know my self!)

So now, everything is back in place: sources are back in 'source'
directory.

2004-04-22  Arnaud Vandyck  <avdyk@ressource-toi.org>

	* source: sources directory has been moved to source directory,
	src has been deleted. Sorry for the inconvenience.

- -- 
Arnaud Vandyck

... but hey, this is Linux, isn't it meant to do infinite loops in 5
seconds?
		-- Jonathan Oxer in the apt-cacher ChangeLog
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAh7Ht4vzFZu62tMIRApzRAKCxDqRo0KRaCWvCtuQb5oEQ0Ty57wCeIfIy
x2Qnn9yTIdIUL5L+54Z7m2I=
=c7VD
-----END PGP SIGNATURE-----



From MAILER-DAEMON Thu Apr 22 09:38:05 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGeOu-0005mG-Ms
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 09:38:00 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGeOr-0005lH-83
	for classpath@gnu.org; Thu, 22 Apr 2004 09:37:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGeOK-0005Ze-Ih
	for classpath@gnu.org; Thu, 22 Apr 2004 09:37:55 -0400
Received: from [139.165.32.78] (helo=serv09.segi.ulg.ac.be)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGeOG-0005Z7-RU
	for classpath@gnu.org; Thu, 22 Apr 2004 09:37:21 -0400
Received: (qmail 1922 invoked by uid 504); 22 Apr 2004 15:37:17 +0200
Received: from arnaud.vandyck@ulg.ac.be by serv09.segi.ulg.ac.be by uid 501
	with qmail-scanner-1.16 
	(clamscan: 0.60. spamassassin: 2.55.  Clear:. 
	Processed in 1.790018 secs); 22 Apr 2004 13:37:17 -0000
Received: from unknown (HELO oz.fapse.ulg.ac.be) ([139.165.77.198])
	(envelope-sender <arnaud.vandyck@ulg.ac.be>)
	by serv09.segi.ulg.ac.be (qmail-ldap-1.03) with SMTP
	for <zander@javalobby.org>; 22 Apr 2004 15:37:15 +0200
Received: from arnaud by oz.fapse.ulg.ac.be with local (Exim 4.32)
	id 1BGeO8-0003kX-VG; Thu, 22 Apr 2004 15:37:12 +0200
To: Thomas Zander <zander@javalobby.org>
References: <87r7ugi61j.fsf@oz.fapse.ulg.ac.be>
	<200404221528.42684.zander@javalobby.org>
From: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
X-Face: >U]gI'=hKRtZE@~Svh"mU,aS"">yCT*dBkVAFl'!]!&k@R8fEr{-)Ql6{xhuXKb+!>}x;
	^2ck7Ytr'EABxt~)3q?AO}$:wwSva.$uNN9x.w4+uVmMMSB1~EbJgo|9E0yQXONuM'~c*20^
Mail-Followup-To: Thomas Zander <zander@javalobby.org>, classpath@gnu.org, 
	classpathx-discuss <classpathx-discuss@gnu.org>, sablevm-developer
	<sablevm-developer@lists.sourceforge.net>, Kaffe Mailing List
	<kaffe@kaffe.org>
Date: Thu, 22 Apr 2004 15:37:12 +0200
In-Reply-To: <200404221528.42684.zander@javalobby.org> (Thomas Zander's
	message of "Thu, 22 Apr 2004 15:28:40 +0200")
Message-ID: <871xmgi16f.fsf@oz.fapse.ulg.ac.be>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
Cc: sablevm-developer <sablevm-developer@lists.sourceforge.net>,
	classpathx-discuss <classpathx-discuss@gnu.org>,
	classpath@gnu.org, Kaffe Mailing List <kaffe@kaffe.org>
Subject: Re: [GNUJAXP] Moving src to source!
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 13:37:58 -0000

Thomas Zander <zander@javalobby.org> writes:

> Just FYI: the Java standard is to use 'src'.
> Using a source dir in Eclipse (I have been told) is pretty darn hard, it 
> expects 'src' instead.
> Mauve also has it as their 'standard expected dir'.

Maybe that's why I did want to change from source to src, but i was told
that classpathx standard was source...

Cheers,

-- 
Arnaud Vandyck

< sam> /.ing an issue is like asking an infinite number of monkeys for 
       advice
		-- in #debian-devel



From MAILER-DAEMON Thu Apr 22 10:19:45 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGf3I-00063F-Fo
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 10:19:44 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGf34-000613-54
	for classpath@gnu.org; Thu, 22 Apr 2004 10:19:30 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGf32-00060d-Bs
	for classpath@gnu.org; Thu, 22 Apr 2004 10:19:28 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGf31-00060J-Ud
	for classpath@gnu.org; Thu, 22 Apr 2004 10:19:28 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BGf2x-0000CQ-00
	for <classpath@gnu.org>; Thu, 22 Apr 2004 16:19:23 +0200
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-eGhzDj2KA3On8ChmB7qD"
Message-Id: <1082643565.27234.124.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Thu, 22 Apr 2004 16:19:25 +0200
Subject: 0.09 release target date is next Friday April 30
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 14:19:30 -0000


--=-eGhzDj2KA3On8ChmB7qD
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi all,

Just a little reminder that we want to release 0.09 next Friday.
So after this weekend please don't commit significant patches without
asking on the list first. We have seen quite some new code and changes
the last two months and we need that last week for testing, testing,
debugging and more testing.

Please go over the NEWS file and add anything you think is missing.
We also need to go over the bug and patch database on Savannah to see
what we can fix for the release. And please send a little ping to the
mailinglist if you have pending patches that you want to see reviewed
and go in before the release.

There has also been a lot of Mauve cleanup and I hope that we can
publish some known to PASS/FAIL list with 0.09.

Thanks,

Mark

--=-eGhzDj2KA3On8ChmB7qD
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAh9RtxVhZCJWr9QwRAnv5AKCkNmfYG3D1YAqLXFyV0VnSQmB7zgCeI1yQ
P6VaYevPKbIPkXg6WpANrCs=
=bJ8M
-----END PGP SIGNATURE-----

--=-eGhzDj2KA3On8ChmB7qD--




From MAILER-DAEMON Thu Apr 22 10:29:11 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGfA9-0008Jq-NC
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 10:26:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGeyU-0004nc-H9
	for classpath@gnu.org; Thu, 22 Apr 2004 10:14:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGex8-0004O1-Dg
	for classpath@gnu.org; Thu, 22 Apr 2004 10:13:53 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGeix-00017g-2S; Thu, 22 Apr 2004 09:58:43 -0400
Received: from [213.51.128.196] (helo=smtpq1.home.nl)
	by mx20.gnu.org with esmtp (Exim 4.30)
	id 1BGeGx-0001xz-2e; Thu, 22 Apr 2004 09:29:47 -0400
Received: from [213.51.128.134] (port=38750 helo=smtp3.home.nl)
	by smtpq1.home.nl with esmtp (Exim 4.30)
	id 1BGeGu-0000f1-T1; Thu, 22 Apr 2004 15:29:44 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:35101
	helo=dumas.thomas.planescape.com)
	by smtp3.home.nl with esmtp (Exim 4.30)
	id 1BGeGs-00029T-2F; Thu, 22 Apr 2004 15:29:42 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Thu, 22 Apr 2004 15:28:40 +0200
User-Agent: KMail/1.6.2
References: <87r7ugi61j.fsf@oz.fapse.ulg.ac.be>
In-Reply-To: <87r7ugi61j.fsf@oz.fapse.ulg.ac.be>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404221528.42684.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Cc: sablevm-developer <sablevm-developer@lists.sourceforge.net>,
	classpathx-discuss <classpathx-discuss@gnu.org>,
	Kaffe Mailing List <kaffe@kaffe.org>
Subject: Re: [GNUJAXP] Moving src to source!
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 14:26:44 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Just FYI: the Java standard is to use 'src'.
Using a source dir in Eclipse (I have been told) is pretty darn hard, it=20
expects 'src' instead.
Mauve also has it as their 'standard expected dir'.


On Thursday 22 April 2004 13:52, Arnaud Vandyck wrote:
> Hi all!
>
> I am very sorry and don't ask why I did move the sources of gnujaxp to
> 'src' directory (I don't know my self!)
>
> So now, everything is back in place: sources are back in 'source'
> directory.
>
> 2004-04-22  Arnaud Vandyck  <avdyk@ressource-toi.org>
>
> 	* source: sources directory has been moved to source directory,
> 	src has been deleted. Sorry for the inconvenience.

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAh8iICojCW6H2z/QRAtHsAKCOjk4iwQ9Q/b44RzGAvWw3CbFW3wCg2iwx
XN+YanJ/hK/nVVsjpkIbB+s=3D
=3DWfDy
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Thu Apr 22 11:03:55 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGfk3-0006aq-5x
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 11:03:55 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGfk0-0006Zi-06
	for classpath@gnu.org; Thu, 22 Apr 2004 11:03:52 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGfjR-0006O6-Q8
	for classpath@gnu.org; Thu, 22 Apr 2004 11:03:50 -0400
Received: from [213.51.128.197] (helo=smtpq2.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1BGfjR-0006Ng-12; Thu, 22 Apr 2004 11:03:17 -0400
Received: from [213.51.128.133] (port=38298 helo=smtp2.home.nl)
	by smtpq2.home.nl with esmtp (Exim 4.30)
	id 1BGfjQ-0003Su-Bg; Thu, 22 Apr 2004 17:03:16 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:35428
	helo=dumas.thomas.planescape.com)
	by smtp2.home.nl with esmtp (Exim 4.30)
	id 1BGfjP-0001cF-AJ; Thu, 22 Apr 2004 17:03:15 +0200
From: Thomas Zander <zander@javalobby.org>
To: Arnaud Vandyck <arnaud.vandyck@ulg.ac.be>
Date: Thu, 22 Apr 2004 17:02:14 +0200
User-Agent: KMail/1.6.2
References: <87r7ugi61j.fsf@oz.fapse.ulg.ac.be>
	<200404221528.42684.zander@javalobby.org>
	<871xmgi16f.fsf@oz.fapse.ulg.ac.be>
In-Reply-To: <871xmgi16f.fsf@oz.fapse.ulg.ac.be>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404221702.15737.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Cc: sablevm-developer <sablevm-developer@lists.sourceforge.net>,
	classpathx-discuss <classpathx-discuss@gnu.org>,
	classpath@gnu.org, Kaffe Mailing List <kaffe@kaffe.org>
Subject: Re: [GNUJAXP] Moving src to source!
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 15:03:53 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 22 April 2004 15:37, Arnaud Vandyck wrote:
> Thomas Zander <zander@javalobby.org> writes:
> > Just FYI: the Java standard is to use 'src'.
> > Using a source dir in Eclipse (I have been told) is pretty darn hard,
> > it expects 'src' instead.
> > Mauve also has it as their 'standard expected dir'.
>
> Maybe that's why I did want to change from source to src, but i was told
> that classpathx standard was source...

Ok, then you have to choose between the Java standard (i.e. what most open=
=20
source, Java-based projects) and the classpath standard :)

See the CVS repositories if you don't simply want to take my word for it:
http://jakarta.apache.org/site/cvsindex.html

IMOHO src makes more sense; but thats because I grew up with unix (where=20
this is also the standard), to me the odd one out is classpath.

Cheers!
=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAh952CojCW6H2z/QRAtOaAKCy42D0TE8SJSP07p01jk6HGa8yLQCdGZAP
gcpNWeQJL6iCzuG1nodUivA=3D
=3DFWlA
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Thu Apr 22 12:50:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGhOr-0006Ue-Bd
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 12:50:09 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGgld-00056e-9o
	for classpath@gnu.org; Thu, 22 Apr 2004 12:09:37 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGgIh-00077A-3V
	for classpath@gnu.org; Thu, 22 Apr 2004 11:40:14 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGgGw-0006dn-Dv
	for classpath@gnu.org; Thu, 22 Apr 2004 11:37:54 -0400
Received: (qmail 1127 invoked from network); 22 Apr 2004 15:40:43 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 22 Apr 2004 15:40:43 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id DAD7B4F853E; Thu, 22 Apr 2004 09:26:34 -0600 (MDT)
To: GNU Classpath Project <classpath@gnu.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Yow!  Those people look exactly like Donnie and Marie Osmond!!
Date: 22 Apr 2004 09:26:34 -0600
Message-ID: <87oepkqbit.fsf@fleche.redhat.com>
Lines: 56
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 16:50:07 -0000

Yesterday I spent a little time setting up Classpath as a project in
Eclipse.  After some tweaking, I was able to come up with the appended
patch.  This just adds a couple files that enable Classpath as an
Eclipse project.

If you try this out, you will have to make a "Configuration.java" by
hand.  I did this by copying Configuration.java.in and editing the
result to be valid Java source.  It is probably possible to teach
Eclipse to run autogen.sh and configure, but I haven't tried this.

I'd like to check this in but thought I'd first see if anybody has
strong objections to it.  mjw was down on the idea on irc, but I'm
hoping that was just lack of food :-).

Tom

Index: .classpath
===================================================================
RCS file: .classpath
diff -N .classpath
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ .classpath 22 Apr 2004 04:49:30 -0000
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+    <classpathentry
+        excluding="external/jaxp/source/|vm/reference/|compat/|test/|external/jaxp/tests/|testsuite/|**/Test.java|**/TestAWT.java|gnu/javax/swing/|**/SliderTest.java"
+        kind="src" path=""/>
+    <classpathentry kind="src" path="external/jaxp/source"/>
+    <classpathentry kind="src" path="vm/reference"/>
+    <classpathentry kind="output" path="bin"/>
+</classpath>
Index: .project
===================================================================
RCS file: .project
diff -N .project
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ .project 22 Apr 2004 04:49:30 -0000
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>classpath</name>
+	<comment></comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.jdt.core.javabuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.jdt.core.javanature</nature>
+	</natures>
+</projectDescription>



From MAILER-DAEMON Thu Apr 22 13:17:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGhpc-0004DN-1g
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 13:17:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGhpT-0004Bi-DR
	for classpath@gnu.org; Thu, 22 Apr 2004 13:17:39 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGhpR-0004BF-OZ
	for classpath@gnu.org; Thu, 22 Apr 2004 13:17:38 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGhpR-0004B0-9n
	for classpath@gnu.org; Thu, 22 Apr 2004 13:17:37 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BGhpL-0000mJ-00; Thu, 22 Apr 2004 19:17:31 +0200
From: Mark Wielaard <mark@klomp.org>
To: Archie Cobbs <archie@dellroad.org>
In-Reply-To: <200404221529.i3MFTGYb001077@arch20m.dellroad.org>
References: <200404221529.i3MFTGYb001077@arch20m.dellroad.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-UbNBFffQ+Bg+mG8FxTob"
Message-Id: <1082654253.27234.150.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Thu, 22 Apr 2004 19:17:33 +0200
Cc: classpath@gnu.org
Subject: Re: 0.09 release target date is next Friday April 30
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 17:17:44 -0000


--=-UbNBFffQ+Bg+mG8FxTob
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Archie,

On Thu, 2004-04-22 at 17:29, Archie Cobbs wrote:
> I'd like to request that my VMProcess patch be included:
>   http://mail.gnu.org/archive/html/commit-classpath/2004-03/msg00057.html
>=20
> No one had any comments, and moreover the patch adds functionality
> that is otherwise not implemented.
>=20
> If there are no objections I'll check it in later today or tomorrow.

I was just testing it because I want to see this in.
I'll send an updated patch in a short while.
I had some troubles with waitpid which was using an uninitialized pid_t
argument which I assume should actually be -1. And FileDescriptors are
now created differently. I'll let you know when I have it up and
running.

Cheers,

mark

--=-UbNBFffQ+Bg+mG8FxTob
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAh/4sxVhZCJWr9QwRAnSaAJsHKl6lh5FZJSuRwPmJWY+SJDt9eQCePgDv
ovfUwY/nN0SnwmgWLujTrp0=
=IYGN
-----END PGP SIGNATURE-----

--=-UbNBFffQ+Bg+mG8FxTob--




From MAILER-DAEMON Thu Apr 22 13:26:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGhyP-0006WK-Nt
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 13:26:53 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGhnF-0003hq-Tm
	for classpath@gnu.org; Thu, 22 Apr 2004 13:15:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGhmb-0003ZH-5k
	for classpath@gnu.org; Thu, 22 Apr 2004 13:15:12 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGhT6-0007dc-5J
	for classpath@gnu.org; Thu, 22 Apr 2004 12:54:32 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3MGsLKG032461;
	Thu, 22 Apr 2004 12:54:21 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3MGsJp01124; 
	Thu, 22 Apr 2004 12:54:19 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i3MGsJcU031560; Thu, 22 Apr 2004 12:54:19 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: java-patches@gcc.gnu.org
Content-Type: multipart/mixed; boundary="=-ZeG1pJODk3Hy68zUidh5"
Message-Id: <1082652858.4217.177.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Thu, 22 Apr 2004 12:54:19 -0400
Cc: classpath@gnu.org
Subject: [gui][PATCH] Implement AWT keyboard focus management
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 17:26:45 -0000


--=-ZeG1pJODk3Hy68zUidh5
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hello,

This patch implements the classes and methods required for proper AWT
keyboard focus management.  Minimal focus test cases work, but more
advanced cases fail currently.  I'm going to check this in on libgcj's
java-gui-branch and I'll fix the remaining problems/FIXMEs there.

Tom

2004-04-22  Thomas Fitzsimmons  <fitzsim@redhat.com>

	* gnu/java/awt/peer/gtk/GtkComponentPeer.java,
	jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c
	(handleEvent): Dispatch key press and key release events to
	backing widget.
	(requestFocus): Post a FOCUS_GAINED event to the event queue.
	(gtkWidgetRequestFocus): New method.
	(gtkWidgetDispatchKeyEvent): Likewise.
	* java/awt/Component.java (requestFocus, requestFocus(boolean),
	requestFocusInWindow, requestFocusInWindow(boolean),
	getFocusCycleRootAncestor, nextFocus, transferFocus,
	transferFocusBackward, transferFocusUpCycle, hasFocus,
	isFocusOwner): Implement and document focus-handling methods.
	(setFocusTraversalKeys): Inherit focus traversal keys when
	keystrokes argument is null.  Fix focus-handling documentation
	throughout class.
	* java/awt/Container.java (setFocusTraversalKeys,
	getFocusTraversalKeys, areFocusTraversalKeysSet,
	isFocusCycleRoot, setFocusTraversalPolicy,
	getFocusTraversalPolicy, isFocusTraversalPolicySet,
	setFocusCycleRoot, isFocusCycleRoot, transferFocusDownCycle):
	Implement and document focus-handling methods.
	(transferFocusBackward): Remove method.
	(readObject, writeObject): Implement and document serialization
	methods.
	* java/awt/ContainerOrderFocusTraversalPolicy.java: Implement
	and document.
	* java/awt/DefaultFocusTraversalPolicy.java: Implement and
	document.
	* java/awt/DefaultKeyboardFocusManager.java: Implement and
	partially document.
	* java/awt/EventDispatchThread.java (run): Set default keyboard
	focus manager.  Attempt to dispatch each event to the keyboard
	focus manager before normal dispatch.
	* java/awt/KeyboardFocusManager.java: Implement and partially
	document.
	* java/awt/Window.java (Window): Set focusCycleRoot to true.
	(show): Focus initial component when window is shown for the
	first time.
	* jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c
	(pre_event_handler): Replace complex key press and key release
	logic with simple callbacks into GtkComponentPeer.
	* jni/gtk-peer/gtkpeer.h: Fix FOCUS_GAINED/FOCUS_LOST reversal.



--=-ZeG1pJODk3Hy68zUidh5
Content-Disposition: attachment; filename=focus-handling.patch
Content-Type: text/x-patch; name=focus-handling.patch; charset=UTF-8
Content-Transfer-Encoding: 7bit

Index: gnu/java/awt/peer/gtk/GtkComponentPeer.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/awt/peer/gtk/GtkComponentPeer.java,v
retrieving revision 1.16.2.3
diff -u -r1.16.2.3 GtkComponentPeer.java
--- gnu/java/awt/peer/gtk/GtkComponentPeer.java	10 Mar 2004 15:48:01 -0000	1.16.2.3
+++ gnu/java/awt/peer/gtk/GtkComponentPeer.java	22 Apr 2004 16:01:10 -0000
@@ -54,12 +54,14 @@
 import java.awt.Image;
 import java.awt.Insets;
 import java.awt.ItemSelectable;
+import java.awt.KeyboardFocusManager;
 import java.awt.Point;
 import java.awt.Rectangle;
 import java.awt.Toolkit;
 import java.awt.Window;
 import java.awt.event.FocusEvent;
 import java.awt.event.ItemEvent;
+import java.awt.event.FocusEvent;
 import java.awt.event.KeyEvent;
 import java.awt.event.MouseEvent;
 import java.awt.event.PaintEvent;
@@ -91,6 +93,9 @@
   native void gtkWidgetSetCursor (int type);
   native void gtkWidgetSetBackground (int red, int green, int blue);
   native void gtkWidgetSetForeground (int red, int green, int blue);
+  native void gtkWidgetRequestFocus ();
+  native void gtkWidgetDispatchKeyEvent (int id, long when, int mods,
+                                         int keyCode, char keyChar, int keyLocation);
   native void gtkSetFont (String name, int style, int size);
   native void gtkWidgetQueueDrawArea(int x, int y, int width, int height);
   native void addExposeFilter();
@@ -222,6 +227,7 @@
   public void handleEvent (AWTEvent event)
   {
     int id = event.getID();
+    KeyEvent ke = null;
 
     switch (id)
       {
@@ -251,6 +257,16 @@
             }
         }
         break;
+      case KeyEvent.KEY_PRESSED:
+        ke = (KeyEvent) event;
+        gtkWidgetDispatchKeyEvent (ke.getID (), ke.getWhen (), ke.getModifiers (),
+                                   ke.getKeyCode (), ke.getKeyChar (), ke.getKeyLocation ());
+        break;
+      case KeyEvent.KEY_RELEASED:
+        ke = (KeyEvent) event;
+        gtkWidgetDispatchKeyEvent (ke.getID (), ke.getWhen (), ke.getModifiers (),
+                                   ke.getKeyCode (), ke.getKeyChar (), ke.getKeyLocation ());
+        break;
       }
   }
   
@@ -335,7 +351,12 @@
 				 new Rectangle (x, y, width, height)));
   }
 
-  native public void requestFocus ();
+  public void requestFocus ()
+  {
+    System.out.println ("In GtkComponentPeer.requestFocus");
+    gtkWidgetRequestFocus ();
+    postFocusEvent (FocusEvent.FOCUS_GAINED, false);
+  }
 
   public void reshape (int x, int y, int width, int height) 
   {
@@ -456,11 +477,12 @@
 			       int keyCode, char keyChar, int keyLocation)
   {
     q.postEvent (new KeyEvent (awtComponent, id, when, mods,
-			       keyCode, keyChar, keyLocation));
+    			       keyCode, keyChar, keyLocation));
   }
 
   protected void postFocusEvent (int id, boolean temporary)
   {
+    System.out.println ("GtkComponentPeer.postFocusEvent: " + awtComponent);
     q.postEvent (new FocusEvent (awtComponent, id, temporary));
   }
 
Index: java/awt/Component.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Component.java,v
retrieving revision 1.37.2.7
diff -u -r1.37.2.7 Component.java
--- java/awt/Component.java	2 Apr 2004 15:52:54 -0000	1.37.2.7
+++ java/awt/Component.java	22 Apr 2004 16:01:10 -0000
@@ -382,18 +382,18 @@
   boolean focusable = true;
 
   /**
-   * Tracks whether this component uses default focus traversal, or has a
-   * different policy.
+   * Tracks whether this component's {@link #isFocusTraversable}
+   * method has been overridden.
    *
-   * @see #isFocusTraversableOverridden()
    * @since 1.4
    */
   int isFocusTraversableOverridden;
 
   /**
-   * The focus traversal keys, if not inherited from the parent or default
-   * keyboard manager. These sets will contain only AWTKeyStrokes that
-   * represent press and release events to use as focus control.
+   * The focus traversal keys, if not inherited from the parent or
+   * default keyboard focus manager. These sets will contain only
+   * AWTKeyStrokes that represent press and release events to use as
+   * focus control.
    *
    * @see #getFocusTraversalKeys(int)
    * @see #setFocusTraversalKeys(int, Set)
@@ -556,6 +556,12 @@
   transient BufferStrategy bufferStrategy;
 
   /**
+   * true if requestFocus was called on this component when its
+   * top-level ancestor was not focusable.
+   */
+  private transient FocusEvent pendingFocusRequest = null;
+
+  /**
    * The system properties that affect image updating.
    */
   private static transient boolean incrementalDraw;
@@ -2962,6 +2968,7 @@
   {
     if (focusListener == null)
       return;
+
     switch (e.id)
       {
         case FocusEvent.FOCUS_GAINED:
@@ -3410,13 +3417,18 @@
   }
 
   /**
-   * Sets the focus traversal keys for a given type of focus events. Normally,
-   * the default values should match the operating system's native choices. To
-   * disable a given traversal, use <code>Collections.EMPTY_SET</code>. The
-   * event dispatcher will consume PRESSED, RELEASED, and TYPED events for the
-   * specified key, although focus can only transfer on PRESSED or RELEASED.
+   * Sets the focus traversal keys for one of the three focus
+   * traversal directions supported by Components: {@link
+   * #KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS}, {@link
+   * #KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS}, or {@link
+   * #KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS}. Normally, the
+   * default values should match the operating system's native
+   * choices. To disable a given traversal, use
+   * <code>Collections.EMPTY_SET</code>. The event dispatcher will
+   * consume PRESSED, RELEASED, and TYPED events for the specified
+   * key, although focus can only transfer on PRESSED or RELEASED.
    *
-   * <p>The defauts are:
+   * <p>The defaults are:
    * <table>
    *   <th><td>Identifier</td><td>Meaning</td><td>Default</td></th>
    *   <tr><td>KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS</td>
@@ -3429,10 +3441,13 @@
    *     <td>Go up a traversal cycle</td><td>None</td></tr>
    * </table>
    *
-   * <p>Specifying null allows inheritance from the parent, or from the current
-   * KeyboardFocusManager default set. If not null, the set must contain only
-   * AWTKeyStrokes that are not already focus keys and are not KEY_TYPED
-   * events.
+   * If keystrokes is null, this component's focus traversal key set
+   * is inherited from one of its ancestors.  If none of its ancestors
+   * has its own set of focus traversal keys, the focus traversal keys
+   * are set to the defaults retrieved from the current
+   * KeyboardFocusManager.  If not null, the set must contain only
+   * AWTKeyStrokes that are not already focus keys and are not
+   * KEY_TYPED events.
    *
    * @param id one of FORWARD_TRAVERSAL_KEYS, BACKWARD_TRAVERSAL_KEYS, or
    *        UP_CYCLE_TRAVERSAL_KEYS
@@ -3447,7 +3462,24 @@
   public void setFocusTraversalKeys(int id, Set keystrokes)
   {
     if (keystrokes == null)
-      throw new IllegalArgumentException();
+      {
+        Container parent = getParent ();
+
+        while (parent != null)
+          {
+            if (parent.areFocusTraversalKeysSet (id))
+              {
+                keystrokes = parent.getFocusTraversalKeys (id);
+                break;
+              }
+            parent = parent.getParent ();
+          }
+
+        if (keystrokes == null)
+          keystrokes = KeyboardFocusManager.getCurrentKeyboardFocusManager ().
+            getDefaultFocusTraversalKeys (id);
+      }
+
     Set sa;
     Set sb;
     String name;
@@ -3475,50 +3507,60 @@
         name = "upCycleFocusTraversalKeys";
         break;
       default:
-        throw new IllegalArgumentException();
+        throw new IllegalArgumentException ();
       }
-    int i = keystrokes.size();
-    Iterator iter = keystrokes.iterator();
+
+    int i = keystrokes.size ();
+    Iterator iter = keystrokes.iterator ();
+
     while (--i >= 0)
       {
-        Object o = iter.next();
-        if (! (o instanceof AWTKeyStroke)
-            || sa.contains(o) || sb.contains(o)
+        Object o = iter.next ();
+        if (!(o instanceof AWTKeyStroke)
+            || sa.contains (o) || sb.contains (o)
             || ((AWTKeyStroke) o).keyCode == KeyEvent.VK_UNDEFINED)
-          throw new IllegalArgumentException();
+          throw new IllegalArgumentException ();
       }
+
     if (focusTraversalKeys == null)
       focusTraversalKeys = new Set[3];
-    keystrokes = Collections.unmodifiableSet(new HashSet(keystrokes));
-    firePropertyChange(name, focusTraversalKeys[id], keystrokes);
+
+    keystrokes = Collections.unmodifiableSet (new HashSet (keystrokes));
+    firePropertyChange (name, focusTraversalKeys[id], keystrokes);
+
     focusTraversalKeys[id] = keystrokes;
   }
 
   /**
-   * Returns the set of keys for a given focus traversal action, as defined
-   * in <code>setFocusTraversalKeys</code>. If not set, this is inherited from
-   * the parent component, which may have gotten it from the
-   * KeyboardFocusManager.
+   * Returns the set of keys for a given focus traversal action, as
+   * defined in <code>setFocusTraversalKeys</code>.  If not set, this
+   * is inherited from the parent component, which may have gotten it
+   * from the KeyboardFocusManager.
    *
-   * @param id one of FORWARD_TRAVERSAL_KEYS, BACKWARD_TRAVERSAL_KEYS, or
-   *        UP_CYCLE_TRAVERSAL_KEYS
+   * @param id one of FORWARD_TRAVERSAL_KEYS, BACKWARD_TRAVERSAL_KEYS,
+   * or UP_CYCLE_TRAVERSAL_KEYS
    * @throws IllegalArgumentException if id is invalid
-   * @see #setFocusTraversalKeys(int, Set)
+   * @see #setFocusTraversalKeys (int, Set)
    * @see KeyboardFocusManager#FORWARD_TRAVERSAL_KEYS
    * @see KeyboardFocusManager#BACKWARD_TRAVERSAL_KEYS
    * @see KeyboardFocusManager#UP_CYCLE_TRAVERSAL_KEYS
    * @since 1.4
    */
-  public Set getFocusTraversalKeys(int id)
+  public Set getFocusTraversalKeys (int id)
   {
-    if (id < KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS
-        || id > KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS)
+    if (id != KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS &&
+        id != KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS &&
+        id != KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS)
       throw new IllegalArgumentException();
+
     Set s = null;
+
     if (focusTraversalKeys != null)
       s = focusTraversalKeys[id];
+
     if (s == null && parent != null)
-      s = parent.getFocusTraversalKeys(id);
+      s = parent.getFocusTraversalKeys (id);
+
     return s == null ? (KeyboardFocusManager.getCurrentKeyboardFocusManager()
                         .getDefaultFocusTraversalKeys(id)) : s;
   }
@@ -3527,269 +3569,405 @@
    * Tests whether the focus traversal keys for a given action are explicitly
    * set or inherited.
    *
-   * @param id one of FORWARD_TRAVERSAL_KEYS, BACKWARD_TRAVERSAL_KEYS, or
-   *        UP_CYCLE_TRAVERSAL_KEYS
+   * @param id one of FORWARD_TRAVERSAL_KEYS, BACKWARD_TRAVERSAL_KEYS,
+   * or UP_CYCLE_TRAVERSAL_KEYS
    * @return true if that set is explicitly specified
    * @throws IllegalArgumentException if id is invalid
-   * @see #getFocusTraversalKeys(int)
+   * @see #getFocusTraversalKeys (int)
    * @see KeyboardFocusManager#FORWARD_TRAVERSAL_KEYS
    * @see KeyboardFocusManager#BACKWARD_TRAVERSAL_KEYS
    * @see KeyboardFocusManager#UP_CYCLE_TRAVERSAL_KEYS
    * @since 1.4
    */
-  public boolean areFocusTraversalKeysSet(int id)
+  public boolean areFocusTraversalKeysSet (int id)
   {
-    if (id < KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS
-        || id > KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS)
-      throw new IllegalArgumentException();
+    if (id != KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS &&
+        id != KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS &&
+        id != KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS)
+      throw new IllegalArgumentException ();
+
     return focusTraversalKeys != null && focusTraversalKeys[id] != null;
   }
 
   /**
-   * Sets whether focus traversal keys are enabled, which consumes traversal
-   * keys and performs the focus event automatically.
+   * Enable or disable focus traversal keys on this Component.  If
+   * they are, then the keyboard focus manager consumes and acts on
+   * key press and release events that trigger focus traversal, and
+   * discards the corresponding key typed events.  If focus traversal
+   * keys are disabled, then all key events that would otherwise
+   * trigger focus traversal are sent to this Component.
    *
    * @param focusTraversalKeysEnabled the new value of the flag
-   * @see #getFocusTraversalKeysEnabled()
-   * @see #setFocusTraversalKeys(int, Set)
-   * @see #getFocusTraversalKeys(int)
+   * @see #getFocusTraversalKeysEnabled ()
+   * @see #setFocusTraversalKeys (int, Set)
+   * @see #getFocusTraversalKeys (int)
    * @since 1.4
    */
-  public void setFocusTraversalKeysEnabled(boolean focusTraversalKeysEnabled)
+  public void setFocusTraversalKeysEnabled (boolean focusTraversalKeysEnabled)
   {
-    firePropertyChange("focusTraversalKeysEnabled",
-                       this.focusTraversalKeysEnabled,
-                       focusTraversalKeysEnabled);
+    firePropertyChange ("focusTraversalKeysEnabled",
+			this.focusTraversalKeysEnabled,
+			focusTraversalKeysEnabled);
     this.focusTraversalKeysEnabled = focusTraversalKeysEnabled;
   }
 
   /**
-   * Tests whether focus traversal keys are enabled. If they are, then focus
-   * traversal keys are consumed and focus events performed automatically,
-   * without the component seeing the keystrokes.
-   *
-   * @return true if focus traversal is enabled
-   * @see #setFocusTraversalKeysEnabled(boolean)
-   * @see #setFocusTraversalKeys(int, Set)
-   * @see #getFocusTraversalKeys(int)
+   * Check whether or not focus traversal keys are enabled on this
+   * Component.  If they are, then the keyboard focus manager consumes
+   * and acts on key press and release events that trigger focus
+   * traversal, and discards the corresponding key typed events.  If
+   * focus traversal keys are disabled, then all key events that would
+   * otherwise trigger focus traversal are sent to this Component.
+   *
+   * @return true if focus traversal keys are enabled
+   * @see #setFocusTraversalKeysEnabled (boolean)
+   * @see #setFocusTraversalKeys (int, Set)
+   * @see #getFocusTraversalKeys (int)
    * @since 1.4
    */
-  public boolean getFocusTraversalKeysEnabled()
+  public boolean getFocusTraversalKeysEnabled ()
   {
     return focusTraversalKeysEnabled;
   }
 
   /**
-   * Requests that this component be given focus. A <code>FOCUS_GAINED</code>
-   * event will be fired if and only if this request is successful. To be
-   * successful, the component must be displayable, visible, and focusable,
-   * and the top-level Window must be able to receive focus. Thus, this
-   * request may fail, or be delayed until the window receives focus. It is
-   * recommended that <code>requestFocusInWindow</code> be used where
-   * possible to be more platform-independent.
+   * Request that this Component be given the keyboard input focus and
+   * that its top-level ancestor become the focused Window.
+   *
+   * For the request to be granted, the Component must be focusable,
+   * displayable and visible and the top-level Window to which it
+   * belongs must be focusable.  If the request is initially denied on
+   * the basis that the top-level Window is not focusable, the request
+   * will be remembered and granted when the Window does become
+   * focused.
+   *
+   * Never assume that this Component is the focus owner until it
+   * receives a FOCUS_GAINED event.
    *
-   * @see #requestFocusInWindow()
+   * The behaviour of this method is platform-dependent.
+   * {@link #requestFocusInWindow} should be used instead.
+   *
+   * @see #requestFocusInWindow ()
    * @see FocusEvent
-   * @see #addFocusListener(FocusListener)
-   * @see #isFocusable()
-   * @see #isDisplayable()
-   * @see KeyboardFocusManager#clearGlobalFocusOwner()
-   */
-  public void requestFocus()
-  {
-    // If there's no peer then this component can't get the focus. We
-    // treat it as a silent rejection of the request.
-    if (peer != null)
-      peer.requestFocus();
+   * @see #addFocusListener (FocusListener)
+   * @see #isFocusable ()
+   * @see #isDisplayable ()
+   * @see KeyboardFocusManager#clearGlobalFocusOwner ()
+   */
+  public void requestFocus ()
+  {
+    if (isDisplayable ()
+	&& isVisible ()
+	&& isFocusable ())
+      {
+	// FIXME: need to get the tree lock here.
+	// Find this Component's top-level ancestor.
+        Container parent = getParent ();
+
+        while (parent != null
+	       && !(parent instanceof Window))
+	  parent = parent.getParent ();
+
+	Window toplevel = (Window) parent;
+	if (toplevel.isFocusableWindow ())
+	  {
+	    if (peer != null)
+	      // This call will cause a FOCUS_GAINED event to be
+	      // posted to the system event queue if the native
+	      // windowing system grants the focus request.
+	      peer.requestFocus ();
+	    else
+	      {
+		// Either our peer hasn't been created yet or we're a
+		// lightweight component.  In either case we want to
+		// post a FOCUS_GAINED event.
+		EventQueue eq = Toolkit.getDefaultToolkit ().getSystemEventQueue ();
+		eq.postEvent (new FocusEvent(this, FocusEvent.FOCUS_GAINED));
+	      }
+	  }
+	else
+	  pendingFocusRequest = new FocusEvent(this, FocusEvent.FOCUS_GAINED);
+      }
   }
 
   /**
-   * Requests that this component be given focus. A <code>FOCUS_GAINED</code>
-   * event will be fired if and only if this request is successful. To be
-   * successful, the component must be displayable, visible, and focusable,
-   * and the top-level Window must be able to receive focus. Thus, this
-   * request may fail, or be delayed until the window receives focus. It is
-   * recommended that <code>requestFocusInWindow</code> be used where
-   * possible to be more platform-independent.
-   *
-   * <p>If the return value is false, the request is guaranteed to fail. If
-   * it is true, it will likely succeed unless the action is vetoed or
-   * something in the native windowing system intervenes. The temporary flag,
-   * and thus this method in general, is not designed for public use; rather
-   * it is a hook for lightweight components to notify their container in
-   * an attempt to reduce the amount of repainting necessary.
+   * Request that this Component be given the keyboard input focus and
+   * that its top-level ancestor become the focused Window.
+   *
+   * For the request to be granted, the Component must be focusable,
+   * displayable and visible and the top-level Window to which it
+   * belongs must be focusable.  If the request is initially denied on
+   * the basis that the top-level Window is not focusable, the request
+   * will be remembered and granted when the Window does become
+   * focused.
+   *
+   * Never assume that this Component is the focus owner until it
+   * receives a FOCUS_GAINED event.
+   *
+   * The behaviour of this method is platform-dependent.
+   * {@link #requestFocusInWindow} should be used instead.
+   *
+   * If the return value is false, the request is guaranteed to fail.
+   * If the return value is true, the request will succeed unless it
+   * is vetoed or something in the native windowing system intervenes,
+   * preventing this Component's top-level ancestor from becoming
+   * focused.  This method is meant to be called by derived
+   * lightweight Components that want to avoid unnecessary repainting
+   * when they know a given focus transfer need only be temporary.
    *
    * @param temporary true if the focus request is temporary
    * @return true if the request has a chance of success
-   * @see #requestFocusInWindow()
+   * @see #requestFocusInWindow ()
    * @see FocusEvent
-   * @see #addFocusListener(FocusListener)
-   * @see #isFocusable()
-   * @see #isDisplayable()
-   * @see KeyboardFocusManager#clearGlobalFocusOwner()
+   * @see #addFocusListener (FocusListener)
+   * @see #isFocusable ()
+   * @see #isDisplayable ()
+   * @see KeyboardFocusManager#clearGlobalFocusOwner ()
    * @since 1.4
    */
-  protected boolean requestFocus(boolean temporary)
+  protected boolean requestFocus (boolean temporary)
   {
-    // XXX Implement correctly.
-    requestFocus();
+    if (isDisplayable ()
+	&& isVisible ()
+	&& isFocusable ())
+      {
+	// FIXME: need to get the tree lock here.
+	// Find this Component's top-level ancestor.
+        Container parent = getParent ();
+
+        while (parent != null
+	       && !(parent instanceof Window))
+	  parent = parent.getParent ();
+
+	Window toplevel = (Window) parent;
+	if (toplevel.isFocusableWindow ())
+	  {
+	    if (peer != null)
+	      // This call will cause a FOCUS_GAINED event to be
+	      // posted to the system event queue if the native
+	      // windowing system grants the focus request.
+	      peer.requestFocus ();
+	    else
+	      {
+		// Either our peer hasn't been created yet or we're a
+		// lightweight component.  In either case we want to
+		// post a FOCUS_GAINED event.
+		EventQueue eq = Toolkit.getDefaultToolkit ().getSystemEventQueue ();
+		eq.postEvent (new FocusEvent(this, FocusEvent.FOCUS_GAINED, temporary));
+	      }
+	  }
+	else
+	  // FIXME: need to add a focus listener to our top-level
+	  // ancestor, so that we can post this event when it becomes
+	  // the focused window.
+	  pendingFocusRequest = new FocusEvent(this, FocusEvent.FOCUS_GAINED, temporary);
+      }
+    // Always return true.
     return true;
   }
 
   /**
-   * Requests that this component be given focus, if it resides in the
-   * top-level window which already has focus. A <code>FOCUS_GAINED</code>
-   * event will be fired if and only if this request is successful. To be
-   * successful, the component must be displayable, visible, and focusable,
-   * and the top-level Window must be focused.
-   *
-   * <p>If the return value is false, the request is guaranteed to fail. If
-   * it is true, it will likely succeed unless the action is vetoed or
-   * something in the native windowing system intervenes. The temporary flag,
-   * and thus this method in general, is not designed for public use; rather
-   * it is a hook for lightweight components to notify their container in
-   * an attempt to reduce the amount of repainting necessary.
+   * Request that this component be given the keyboard input focus, if
+   * its top-level ancestor is the currently focused Window.  A
+   * <code>FOCUS_GAINED</code> event will be fired if and only if this
+   * request is successful. To be successful, the component must be
+   * displayable, visible, and focusable, and its ancestor top-level
+   * Window must be focused.
+   *
+   * If the return value is false, the request is guaranteed to fail.
+   * If the return value is true, the request will succeed unless it
+   * is vetoed or something in the native windowing system intervenes,
+   * preventing this Component's top-level ancestor from becoming
+   * focused.
    *
    * @return true if the request has a chance of success
-   * @see #requestFocus()
+   * @see #requestFocus ()
    * @see FocusEvent
-   * @see #addFocusListener(FocusListener)
-   * @see #isFocusable()
-   * @see #isDisplayable()
-   * @see KeyboardFocusManager#clearGlobalFocusOwner()
+   * @see #addFocusListener (FocusListener)
+   * @see #isFocusable ()
+   * @see #isDisplayable ()
+   * @see KeyboardFocusManager#clearGlobalFocusOwner ()
    * @since 1.4
    */
-  public boolean requestFocusInWindow()
+  public boolean requestFocusInWindow ()
   {
-    // XXX Implement correctly.
-    requestFocus();
-    return true;
+    return requestFocusInWindow (false);
   }
 
   /**
-   * Requests that this component be given focus, if it resides in the
-   * top-level window which already has focus. A <code>FOCUS_GAINED</code>
-   * event will be fired if and only if this request is successful. To be
-   * successful, the component must be displayable, visible, and focusable,
-   * and the top-level Window must be focused.
-   *
-   * <p>If the return value is false, the request is guaranteed to fail. If
-   * it is true, it will likely succeed unless the action is vetoed or
-   * something in the native windowing system intervenes. The temporary flag,
-   * and thus this method in general, is not designed for public use; rather
-   * it is a hook for lightweight components to notify their container in
-   * an attempt to reduce the amount of repainting necessary.
+   * Request that this component be given the keyboard input focus, if
+   * its top-level ancestor is the currently focused Window.  A
+   * <code>FOCUS_GAINED</code> event will be fired if and only if this
+   * request is successful. To be successful, the component must be
+   * displayable, visible, and focusable, and its ancestor top-level
+   * Window must be focused.
+   *
+   * If the return value is false, the request is guaranteed to fail.
+   * If the return value is true, the request will succeed unless it
+   * is vetoed or something in the native windowing system intervenes,
+   * preventing this Component's top-level ancestor from becoming
+   * focused.  This method is meant to be called by derived
+   * lightweight Components that want to avoid unnecessary repainting
+   * when they know a given focus transfer need only be temporary.
    *
    * @param temporary true if the focus request is temporary
    * @return true if the request has a chance of success
-   * @see #requestFocus()
+   * @see #requestFocus ()
    * @see FocusEvent
-   * @see #addFocusListener(FocusListener)
-   * @see #isFocusable()
-   * @see #isDisplayable()
-   * @see KeyboardFocusManager#clearGlobalFocusOwner()
+   * @see #addFocusListener (FocusListener)
+   * @see #isFocusable ()
+   * @see #isDisplayable ()
+   * @see KeyboardFocusManager#clearGlobalFocusOwner ()
    * @since 1.4
    */
-  protected boolean requestFocusInWindow(boolean temporary)
+  protected boolean requestFocusInWindow (boolean temporary)
   {
-    // XXX Implement correctly.
-    requestFocus();
+    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+    Window focusedWindow = manager.getFocusedWindow ();
+
+    if (focusedWindow != null)
+      {
+	// FIXME: get tree lock here.
+	Container parent = getParent ();
+
+	while (parent != null
+	       && !(parent instanceof Window))
+	  parent = parent.getParent ();
+
+	Window toplevel = (Window) parent;
+
+	// Check if top-level ancestor is currently focused window.
+	if (focusedWindow == toplevel)
+	  {
+	    if (peer != null)
+	      // This call will cause a FOCUS_GAINED event to be
+	      // posted to the system event queue if the native
+	      // windowing system grants the focus request.
+	      peer.requestFocus ();
+	    else
+	      {
+		// Either our peer hasn't been created yet or we're a
+		// lightweight component.  In either case we want to
+		// post a FOCUS_GAINED event.
+		EventQueue eq = Toolkit.getDefaultToolkit ().getSystemEventQueue ();
+		eq.postEvent (new FocusEvent(this, FocusEvent.FOCUS_GAINED, temporary));
+	      }
+	  }
+	else
+	  return false;
+      }
+
     return true;
   }
 
   /**
-   * Transfers focus to the next component in the focus traversal order, as
-   * though this were the current focus owner.
+   * Transfers focus to the next component in the focus traversal
+   * order, as though this were the current focus owner.
    *
    * @see #requestFocus()
    * @since 1.1
    */
-  public void transferFocus()
+  public void transferFocus ()
   {
-    Component next;
-    if (parent == null)
-      next = findNextFocusComponent(null);
-    else
-      next = parent.findNextFocusComponent(this);
-    if (next != null && next != this)
-      next.requestFocus();
+    nextFocus ();
   }
 
   /**
-   * Returns the root container that owns the focus cycle where this component
-   * resides. A focus cycle root is in two cycles, one as the ancestor, and
-   * one as the focusable element; this call always returns the ancestor.
+   * Returns the root container that owns the focus cycle where this
+   * component resides. A focus cycle root is in two cycles, one as
+   * the ancestor, and one as the focusable element; this call always
+   * returns the ancestor.
    *
    * @return the ancestor container that owns the focus cycle
    * @since 1.4
    */
-  public Container getFocusCycleRootAncestor()
+  public Container getFocusCycleRootAncestor ()
   {
-    // XXX Implement.
-    throw new Error("not implemented");
+    if (this instanceof Window
+	&& ((Container) this).isFocusCycleRoot ())
+      return (Container) this;
+
+    Container parent = getParent ();
+
+    while (parent != null
+	   && !parent.isFocusCycleRoot ())
+      parent = parent.getParent ();
+
+    return parent;
   }
 
   /**
-   * Tests if the container is the ancestor of the focus cycle that this
-   * component belongs to.
+   * Tests if the container is the ancestor of the focus cycle that
+   * this component belongs to.
    *
    * @param c the container to test
    * @return true if c is the focus cycle root
    * @since 1.4
    */
-  public boolean isFocusCycleRoot(Container c)
+  public boolean isFocusCycleRoot (Container c)
   {
-    return c == getFocusCycleRootAncestor();
+    return c == getFocusCycleRootAncestor ();
   }
 
   /**
-   * AWT 1.0 focus event processor.
+   * AWT 1.0 focus event processor.  Transfers focus to the next
+   * component in the focus traversal order, as though this were the
+   * current focus owner.
    *
-   * @deprecated use {@link #transferFocus()} instead
+   * @deprecated use {@link #transferFocus ()} instead
    */
-  public void nextFocus()
+  public void nextFocus ()
   {
-    transferFocus();
+    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+    manager.focusNextComponent (this);
   }
 
   /**
-   * Transfers focus to the previous component in the focus traversal order, as
-   * though this were the current focus owner.
+   * Transfers focus to the previous component in the focus traversal
+   * order, as though this were the current focus owner.
    *
-   * @see #requestFocus()
+   * @see #requestFocus ()
    * @since 1.4
    */
-  public void transferFocusBackward()
+  public void transferFocusBackward ()
   {
-    // XXX Implement.
-    throw new Error("not implemented");
+    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+    manager.focusPreviousComponent (this);
   }
 
   /**
-   * Transfers focus to the focus cycle root of this component. However, if
-   * this is a Window, the default focus owner in the window in the current
-   * focus cycle is focused instead.
+   * Transfers focus to the focus cycle root of this component.
+   * However, if this is a Window, the default focus owner in the
+   * window in the current focus cycle is focused instead.
    *
-   * @see #requestFocus()
-   * @see #isFocusCycleRoot()
+   * @see #requestFocus ()
+   * @see #isFocusCycleRoot ()
    * @since 1.4
    */
-  public void transferFocusUpCycle()
+  public void transferFocusUpCycle ()
   {
-    // XXX Implement.
-    throw new Error("not implemented");
+    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+    manager.upFocusCycle (this);
   }
 
   /**
-   * Tests if this component is the focus owner. Use {@link #isFocusOwner()}
-   * instead.
+   * Tests if this component is the focus owner. Use {@link
+   * #isFocusOwner ()} instead.
    *
    * @return true if this component owns focus
    * @since 1.2
    */
-  public boolean hasFocus()
+  public boolean hasFocus ()
   {
-    return isFocusOwner();
+    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+    Component focusOwner = manager.getFocusOwner ();
+
+    return this == focusOwner;
   }
 
   /**
@@ -3800,8 +3978,7 @@
    */
   public boolean isFocusOwner()
   {
-    // XXX Implement.
-    throw new Error("not implemented");
+    return hasFocus ();
   }
 
   /**
@@ -4336,6 +4513,8 @@
    * making the request. This is overridden by Container; when called for an
    * ordinary component there is no child and so we always return null.
    *
+   * FIXME: is this still needed, in light of focus traversal policies?
+   *
    * @param child the component making the request
    * @return the next component to focus on
    */
@@ -4896,23 +5075,23 @@
      * Tests whether this component can accept focus.
      *
      * @return true if this is focus traversable
-     * @see #getAccessibleStateSet()
+     * @see #getAccessibleStateSet ()
      * @see AccessibleState#FOCUSABLE
      * @see AccessibleState#FOCUSED
      */
-    public boolean isFocusTraversable()
+    public boolean isFocusTraversable ()
     {
-      return Component.this.isFocusTraversable();
+      return Component.this.isFocusTraversable ();
     }
 
     /**
      * Requests focus for this component.
      *
-     * @see #isFocusTraversable()
+     * @see #isFocusTraversable ()
      */
-    public void requestFocus()
+    public void requestFocus ()
     {
-      Component.this.requestFocus();
+      Component.this.requestFocus ();
     }
 
     /**
Index: java/awt/Container.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Container.java,v
retrieving revision 1.34.2.6
diff -u -r1.34.2.6 Container.java
--- java/awt/Container.java	10 Mar 2004 21:43:01 -0000	1.34.2.6
+++ java/awt/Container.java	22 Apr 2004 16:01:10 -0000
@@ -46,10 +46,16 @@
 import java.awt.peer.LightweightPeer;
 import java.beans.PropertyChangeListener;
 import java.beans.PropertyChangeSupport;
+import java.io.ObjectInputStream;
+import java.io.IOException;
+import java.io.ObjectOutputStream;
 import java.io.PrintStream;
 import java.io.PrintWriter;
 import java.io.Serializable;
+import java.util.Collections;
 import java.util.EventListener;
+import java.util.Iterator;
+import java.util.HashSet;
 import java.util.Set;
 import javax.accessibility.Accessible;
 import javax.swing.SwingUtilities;
@@ -93,6 +99,21 @@
   transient ContainerListener containerListener;
   transient PropertyChangeSupport changeSupport; 
 
+  /** The focus traversal policy that determines how focus is
+      transferred between this Container and its children. */
+  private FocusTraversalPolicy focusTraversalPolicy;
+
+  /**
+   * The focus traversal keys, if not inherited from the parent or default
+   * keyboard manager. These sets will contain only AWTKeyStrokes that
+   * represent press and release events to use as focus control.
+   *
+   * @see #getFocusTraversalKeys(int)
+   * @see #setFocusTraversalKeys(int, Set)
+   * @since 1.4
+   */
+  transient Set[] focusTraversalKeys;
+
   /**
    * Default constructor for subclasses.
    */
@@ -1068,9 +1089,89 @@
       throw new IllegalArgumentException ();
 
     if (keystrokes == null)
-      throw new IllegalArgumentException ();
+      {
+        Container parent = getParent ();
+
+        while (parent != null)
+          {
+            if (parent.areFocusTraversalKeysSet (id))
+              {
+                keystrokes = parent.getFocusTraversalKeys (id);
+                break;
+              }
+            parent = parent.getParent ();
+          }
+
+        if (keystrokes == null)
+          keystrokes = KeyboardFocusManager.getCurrentKeyboardFocusManager ().
+            getDefaultFocusTraversalKeys (id);
+      }
+
+    Set sa;
+    Set sb;
+    Set sc;
+    String name;
+    switch (id)
+      {
+      case KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS:
+        sa = getFocusTraversalKeys
+          (KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS);
+        sb = getFocusTraversalKeys
+          (KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS);
+        sc = getFocusTraversalKeys
+          (KeyboardFocusManager.DOWN_CYCLE_TRAVERSAL_KEYS);
+        name = "forwardFocusTraversalKeys";
+        break;
+      case KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS:
+        sa = getFocusTraversalKeys
+          (KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS);
+        sb = getFocusTraversalKeys
+          (KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS);
+        sc = getFocusTraversalKeys
+          (KeyboardFocusManager.DOWN_CYCLE_TRAVERSAL_KEYS);
+        name = "backwardFocusTraversalKeys";
+        break;
+      case KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS:
+        sa = getFocusTraversalKeys
+          (KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS);
+        sb = getFocusTraversalKeys
+          (KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS);
+        sc = getFocusTraversalKeys
+          (KeyboardFocusManager.DOWN_CYCLE_TRAVERSAL_KEYS);
+        name = "upCycleFocusTraversalKeys";
+        break;
+      case KeyboardFocusManager.DOWN_CYCLE_TRAVERSAL_KEYS:
+        sa = getFocusTraversalKeys
+          (KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS);
+        sb = getFocusTraversalKeys
+          (KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS);
+        sc = getFocusTraversalKeys
+          (KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS);
+        name = "downCycleFocusTraversalKeys";
+        break;
+      default:
+        throw new IllegalArgumentException ();
+      }
+
+    int i = keystrokes.size ();
+    Iterator iter = keystrokes.iterator ();
+
+    while (--i >= 0)
+      {
+        Object o = iter.next ();
+        if (!(o instanceof AWTKeyStroke)
+            || sa.contains (o) || sb.contains (o) || sc.contains (o)
+            || ((AWTKeyStroke) o).keyCode == KeyEvent.VK_UNDEFINED)
+          throw new IllegalArgumentException ();
+      }
+
+    if (focusTraversalKeys == null)
+      focusTraversalKeys = new Set[3];
+
+    keystrokes = Collections.unmodifiableSet (new HashSet (keystrokes));
+    firePropertyChange (name, focusTraversalKeys[id], keystrokes);
 
-    throw new Error ("not implemented");
+    focusTraversalKeys[id] = keystrokes;
   }
   
   /**
@@ -1085,7 +1186,7 @@
    *
    * @since 1.4
    */
-  public Set getFocusTraversalKeys(int id)
+  public Set getFocusTraversalKeys (int id)
   {
     if (id != KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS &&
         id != KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS &&
@@ -1093,9 +1194,18 @@
         id != KeyboardFocusManager.DOWN_CYCLE_TRAVERSAL_KEYS)
       throw new IllegalArgumentException ();
 
-    return null;
+    Set s = null;
+
+    if (focusTraversalKeys != null)
+      s = focusTraversalKeys[id];
+
+    if (s == null && parent != null)
+      s = parent.getFocusTraversalKeys (id);
+
+    return s == null ? (KeyboardFocusManager.getCurrentKeyboardFocusManager()
+                        .getDefaultFocusTraversalKeys(id)) : s;
   }
-  
+
   /**
    * Returns whether the Set of focus traversal keys for the given focus
    * traversal operation has been explicitly defined for this Container.
@@ -1110,7 +1220,7 @@
    *
    * @since 1.4
    */
-  public boolean areFocusTraversalKeysSet(int id)
+  public boolean areFocusTraversalKeysSet (int id)
   {
     if (id != KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS &&
         id != KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS &&
@@ -1118,43 +1228,148 @@
         id != KeyboardFocusManager.DOWN_CYCLE_TRAVERSAL_KEYS)
       throw new IllegalArgumentException ();
 
-    return false;
+    return focusTraversalKeys != null && focusTraversalKeys[id] != null;
   }
-  
-  public boolean isFocusCycleRoot(Container c)
+
+  /**
+   * Check whether the given Container is the focus cycle root of this
+   * Container's focus traversal cycle.  If this Container is a focus
+   * cycle root itself, then it will be in two different focus cycles
+   * -- it's own, and that of its ancestor focus cycle root's.  In
+   * that case, if <code>c</code> is either of those containers, this
+   * method will return true.
+   *
+   * @param c the candidate Container
+   *
+   * @return true if c is the focus cycle root of the focus traversal
+   * cycle to which this Container belongs, false otherwise
+   *
+   * @since 1.4
+   */
+  public boolean isFocusCycleRoot (Container c)
   {
+    if (this == c
+        && isFocusCycleRoot ())
+      return true;
+
+    Container ancestor = getFocusCycleRootAncestor ();
+
+    if (c == ancestor)
+      return true;
+
     return false;
   }
-  
-  public void transferFocusBackward()
-  {
-  }
-  
-  public void setFocusTraversalPolicy(FocusTraversalPolicy policy)
+
+  /**
+   * If this Container is a focus cycle root, set the focus traversal
+   * policy that determines the focus traversal order for its
+   * children.  If non-null, this policy will be inherited by all
+   * inferior focus cycle roots.  If <code>policy</code> is null, this
+   * Container will inherit its policy from the closest ancestor focus
+   * cycle root that's had its policy set.
+   *
+   * @param policy the new focus traversal policy for this Container or null
+   *
+   * @since 1.4
+   */
+  public void setFocusTraversalPolicy (FocusTraversalPolicy policy)
   {
+    focusTraversalPolicy = policy;
   }
-  
-  public FocusTraversalPolicy getFocusTraversalPolicy()
+
+  /**
+   * Return the focus traversal policy that determines the focus
+   * traversal order for this Container's children.  This method
+   * returns null if this Container is not a focus cycle root.  If the
+   * focus traversal policy has not been set explicitly, then this
+   * method will return an ancestor focus cycle root's policy instead.
+   *
+   * @return this Container's focus traversal policy or null
+   *
+   * @since 1.4
+   */
+  public FocusTraversalPolicy getFocusTraversalPolicy ()
   {
-    return null;
+    if (!isFocusCycleRoot ())
+      return null;
+
+    if (focusTraversalPolicy == null)
+      {
+        Container ancestor = getFocusCycleRootAncestor ();
+
+	if (ancestor != this)
+	  return ancestor.getFocusTraversalPolicy ();
+	else
+	  {
+	    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+	    return manager.getDefaultFocusTraversalPolicy ();
+	  }
+      }
+    else
+      return focusTraversalPolicy;
   }
-  
-  public boolean isFocusTraversalPolicySet()
+
+  /**
+   * Check whether this Container's focus traversal policy has been
+   * explicitly set.  If it has not, then this Container will inherit
+   * its focus traversal policy from one of its ancestor focus cycle
+   * roots.
+   *
+   * @return true if focus traversal policy is set, false otherwise
+  */
+  public boolean isFocusTraversalPolicySet ()
   {
-    return false;
+    return focusTraversalPolicy == null;
   }
-  
-  public void setFocusCycleRoot(boolean focusCycleRoot)
+
+  /**
+   * Set whether or not this Container is the root of a focus
+   * traversal cycle.  This Container's focus traversal policy
+   * determines the order of focus traversal.  Some policies prevent
+   * the focus from being transferred between two traversal cycles
+   * until an up or down traversal operation is performed.  In that
+   * case, normal traversal (not up or down) is limited to this
+   * Container and all of this Container's descendents that are not
+   * descendents of inferior focus cycle roots.  In the default case
+   * however, ContainerOrderFocusTraversalPolicy is in effect, and it
+   * supports implicit down-cycle traversal operations.
+   *
+   * @return true if this is a focus cycle root, false otherwise
+   *
+   * @since 1.4
+   */
+  public void setFocusCycleRoot (boolean focusCycleRoot)
   {
+    this.focusCycleRoot = focusCycleRoot;
   }
-  
-  public boolean isFocusCycleRoot()
+
+  /**
+   * Check whether this Container is a focus cycle root.
+   *
+   * @return true if this is a focus cycle root, false otherwise
+   *
+   * @since 1.4
+   */
+  public boolean isFocusCycleRoot ()
   {
-    return false;
+    return focusCycleRoot;
   }
-  
-  public void transferFocusDownCycle()
+
+  /**
+   * Transfer focus down one focus traversal cycle.  If this Container
+   * is a focus cycle root, then its default component becomes the
+   * focus owner, and this Container becomes the current focus cycle
+   * root.  No traversal will occur if this Container is not a focus
+   * cycle root.
+   *
+   * @since 1.4
+   */
+  public void transferFocusDownCycle ()
   {
+    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+    manager.downFocusCycle (this);
   }
 
   /**
@@ -1369,6 +1584,61 @@
 	      }
           }
       }
+  }
+
+  /**
+   * Deserialize this Container:
+   * <ol>
+   * <li>Read from the stream the default serializable fields.</li>
+   * <li>Read a list of serializable ContainerListeners as optional
+   * data.  If the list is null, no listeners will be registered.</li>
+   * <li>Read this Container's FocusTraversalPolicy as optional data.
+   * If this is null, then this Container will use a
+   * DefaultFocusTraversalPolicy.</li>
+   * </ol>
+   *
+   * @param s the stream to read from
+   * @throws ClassNotFoundException if deserialization fails
+   * @throws IOException if the stream fails
+   */
+  private void readObject (ObjectInputStream s)
+    throws ClassNotFoundException, IOException
+  {
+    s.defaultReadObject ();
+    String key = (String) s.readObject ();
+    while (key != null)
+      {
+        Object object = s.readObject ();
+        if ("containerL".equals (key))
+          addContainerListener((ContainerListener) object);
+        // FIXME: under what key is the focus traversal policy stored?
+        else if ("focusTraversalPolicy".equals (key))
+          setFocusTraversalPolicy ((FocusTraversalPolicy) object);
+
+        key = (String) s.readObject();
+      }
+  }
+
+  /**
+   * Serialize this Container:
+   * <ol>
+   * <li>Write to the stream the default serializable fields.</li>
+   * <li>Write the list of serializable ContainerListeners as optional
+   * data.</li>
+   * <li>Write this Container's FocusTraversalPolicy as optional data.</li>
+   * </ol>
+   *
+   * @param s the stream to write to
+   * @throws IOException if the stream fails
+   */
+  private void writeObject (ObjectOutputStream s) throws IOException
+  {
+    s.defaultWriteObject ();
+    AWTEventMulticaster.save (s, "containerL", containerListener);
+    if (focusTraversalPolicy instanceof Serializable)
+      s.writeObject (focusTraversalPolicy);
+    else
+      s.writeObject (null);
   }
 
   // Nested classes.
Index: java/awt/ContainerOrderFocusTraversalPolicy.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/ContainerOrderFocusTraversalPolicy.java,v
retrieving revision 1.5
diff -u -r1.5 ContainerOrderFocusTraversalPolicy.java
--- java/awt/ContainerOrderFocusTraversalPolicy.java	24 Mar 2003 13:50:32 -0000	1.5
+++ java/awt/ContainerOrderFocusTraversalPolicy.java	22 Apr 2004 16:01:10 -0000
@@ -41,7 +41,23 @@
 import java.io.Serializable;
 
 /**
+ * ContainerOrderFocusTraversalPolicy defines a focus traversal order
+ * based on the order in which Components were packed in a Container.
+ * This policy performs a pre-order traversal of the Component
+ * hierarchy starting from a given focus cycle root.  Portions of the
+ * hierarchy that are not visible and displayable are skipped.
+ *
+ * By default, this policy transfers focus down-cycle implicitly.
+ * That is, if a forward traversal is requested on a focus cycle root
+ * and the focus cycle root has focusable children, the focus will
+ * automatically be transfered down to the lower focus cycle.
+ *
+ * The default implementation of accept accepts only Components that
+ * are visible, displayable, enabled and focusable.  Derived classes
+ * can override these acceptance criteria by overriding accept.
+ *
  * @author Michael Koch
+ * @author Thomas Fitzsimmons <fitzsim@redhat.com>
  * @since 1.4
  */
 public class ContainerOrderFocusTraversalPolicy extends FocusTraversalPolicy
@@ -52,12 +68,15 @@
    */
   static final long serialVersionUID = 486933713763926351L;
 
+  /**
+   * True if implicit down cycling is enabled.
+   */
   private boolean implicitDownCycleTraversal = true;
 
   /**
    * Creates the <code>ContainerOrderFocusTraversalPolicy</code> object.
    */
-  public ContainerOrderFocusTraversalPolicy()
+  public ContainerOrderFocusTraversalPolicy ()
   {
     // Nothing to do here
   }
@@ -66,37 +85,193 @@
    * Returns the Component that should receive the focus after current.
    * root must be a focus cycle root of current.
    *
+   * @param root a focus cycle root of current
+   * @param current a (possibly indirect) child of root, or root itself
+   *
+   * @return the next Component in the focus traversal order for root,
+   * or null if no acceptable Component exists.
+   *
    * @exception IllegalArgumentException If root is not a focus cycle
    * root of current, or if either root or current is null.
    */
-  public Component getComponentAfter(Container root, Component current)
+  public Component getComponentAfter (Container root, Component current)
   {
-    if (root == null
-        || current == null)
-      throw new IllegalArgumentException ();
-    
+    if (root == null)
+      throw new IllegalArgumentException ("focus cycle root is null");
+    if (current == null)
+      throw new IllegalArgumentException ("current component is null");
+
+    // FIXME: is this the right thing to do here? it move the context
+    // for traversal up one focus traversal cycle.
+    if ((Component) root == current)
+      root = current.getFocusCycleRootAncestor ();
+
+    Container ancestor = current.getFocusCycleRootAncestor ();
+    Container prevAncestor = ancestor;
+    while (ancestor != root)
+      {
+	ancestor = current.getFocusCycleRootAncestor ();
+	if (ancestor == prevAncestor)
+	  {
+	    // We've reached the top focus cycle root ancestor.  Check
+	    // if it is root.
+	    if (ancestor != root)
+	      throw new IllegalArgumentException ("the given container is not"
+						  + " a focus cycle root of the"
+						  + " current component");
+	    else
+	      break;
+	  }
+	prevAncestor = ancestor;
+      }
+
+    // FIXME: need locking on root.
+    Component[] components = root.getComponents ();
+    int componentIndex = 0;
+    int numComponents = root.getComponentCount ();
+
+    // Find component's index.
+    for (int i = 0; i < numComponents; i++)
+      {
+	if (components[i] == current)
+	  componentIndex = i;
+      }
+
+    // Search forward for the next acceptable component.
+    for (int i = componentIndex + 1; i < numComponents; i++)
+      {
+        if (components[i] instanceof Container)
+          {
+            Component result = getFirstComponent ((Container) components[i]);
+
+            if (result != null
+		&& implicitDownCycleTraversal)
+              return result;
+          }
+
+	if (accept (components[i]))
+	  return components[i];
+      }
+
+    for (int i = 0; i < componentIndex; i++)
+      {
+        if (components[i] instanceof Container)
+          {
+            Component result = getFirstComponent ((Container) components[i]);
+
+            if (result != null
+		&& implicitDownCycleTraversal)
+              return result;
+          }
+
+	// FIXME: see below.
+	if (accept (components[i]))
+	  return components[i];
+      }
+
+    // No acceptable component found.
     return null;
   }
 
   /**
-   * Returns the Component that should receive the focus before current.
-   * root must be a focus cycle root of current.
+   * Returns the Component that should receive the focus before
+   * <code>current</code>.  <code>root</code> must be a focus cycle
+   * root of current.
+   *
+   * @param root a focus cycle root of current
+   * @param current a (possibly indirect) child of root, or root itself
+   *
+   * @return the previous Component in the focus traversal order for
+   * root, or null if no acceptable Component exists.
    *
    * @exception IllegalArgumentException If root is not a focus cycle
    * root of current, or if either root or current is null.
    */
-  public Component getComponentBefore(Container root, Component current)
+  public Component getComponentBefore (Container root, Component current)
   {
-    if (root == null
-        || current == null)
-      throw new IllegalArgumentException ();
+    if (root == null)
+      throw new IllegalArgumentException ("focus cycle root is null");
+    if (current == null)
+      throw new IllegalArgumentException ("current component is null");
+
+    // FIXME: is this the right thing to do here? it move the context
+    // for traversal up one focus traversal cycle.
+    if ((Component) root == current)
+      root = current.getFocusCycleRootAncestor ();
+
+    Container ancestor = current.getFocusCycleRootAncestor ();
+    Container prevAncestor = ancestor;
+    while (ancestor != root)
+      {
+	ancestor = current.getFocusCycleRootAncestor ();
+	if (ancestor == prevAncestor)
+	  {
+	    // We've reached the top focus cycle root ancestor.  Check
+	    // if it is root.
+	    if (ancestor != root)
+	      throw new IllegalArgumentException ("the given container is not"
+						  + " a focus cycle root of the"
+						  + " current component");
+	    else
+	      break;
+	  }
+	prevAncestor = ancestor;
+      }
+
+    // FIXME: need locking on root.
+    Component[] components = root.getComponents ();
+    int componentIndex = 0;
+    int numComponents = root.getComponentCount ();
+
+    // Find component's index.
+    for (int i = 0; i < numComponents; i++)
+      {
+	if (components[i] == current)
+	  componentIndex = i;
+      }
 
+    // Search backward for the next acceptable component.
+    for (int i = componentIndex - 1; i >= 0; i--)
+      {
+        if (components[i] instanceof Container)
+          {
+            Component result = getLastComponent ((Container) components[i]);
+
+            if (result != null)
+              return result;
+          }
+
+	if (accept (components[i]))
+	  return components[i];
+      }
+
+    for (int i = numComponents - 1; i > componentIndex; i--)
+      {
+        if (components[i] instanceof Container)
+          {
+            Component result = getLastComponent ((Container) components[i]);
+
+            if (result != null)
+              return result;
+          }
+
+	// FIXME: see below.
+	if (accept (components[i]))
+	  return components[i];
+      }
+
+    // No acceptable component found.
     return null;
   }
 
   /**
    * Returns the first Component of root that should receive the focus.
    *
+   * @param root a focus cycle root
+   *
+   * @return the first Component in the focus traversal order for
+   * root, or null if no acceptable Component exists.
+   *
    * @exception IllegalArgumentException If root is null.
    */
   public Component getFirstComponent(Container root)
@@ -119,16 +294,17 @@
 	
         if (component instanceof Container)
           {
-            Component result = getLastComponent ((Container) component);
+            Component result = getFirstComponent ((Container) component);
 
             if (result != null)
               return result;
           }
-        else
-          {
-            if (accept (component))
-              return component;
-          }
+
+	// FIXME: can the container itself be focused?  if not, then
+	// this part needs to be in the else clause of the if
+	// statement above.
+	if (accept (component))
+	  return component;
       }
 
     return null;
@@ -137,9 +313,14 @@
   /**
    * Returns the last Component of root that should receive the focus.
    *
+   * @param root a focus cycle root
+   *
+   * @return the last Component in the focus traversal order for
+   * root, or null if no acceptable Component exists.
+   *
    * @exception IllegalArgumentException If root is null.
    */
-  public Component getLastComponent(Container root)
+  public Component getLastComponent (Container root)
   {
     if (root == null)
       throw new IllegalArgumentException ();
@@ -164,11 +345,10 @@
             if (result != null)
               return result;
           }
-        else
-          {
-            if (accept (component))
-              return component;
-          }
+
+	// FIXME: see above.
+	if (accept (component))
+	  return component;
       }
 
     return null;
@@ -177,28 +357,58 @@
   /**
    * Returns the default Component of root that should receive the focus.
    *
+   * @param root a focus cycle root
+   *
+   * @return the default Component in the focus traversal order for
+   * root, or null if no acceptable Component exists.
+   *
    * @exception IllegalArgumentException If root is null.
    */
-  public Component getDefaultComponent(Container root)
+  public Component getDefaultComponent (Container root)
   {
     return getFirstComponent (root);
   }
 
-  public void setImplicitDownCycleTraversal(boolean value)
+  /**
+   * Set whether or not implicit down cycling is enabled.  If it is,
+   * then initiating a forward focus traversal operation onto a focus
+   * cycle root, the focus will be implicitly transferred into the
+   * root container's focus cycle.
+   *
+   * @param value the setting for implicit down cycling
+   */
+  public void setImplicitDownCycleTraversal (boolean value)
   {
     implicitDownCycleTraversal = value;
   }
 
-  public boolean getImplicitDownCycleTraversal()
+  /**
+   * Check whether or not implicit down cycling is enabled.  If it is,
+   * then initiating a forward focus traversal operation onto a focus
+   * cycle root, the focus will be implicitly transferred into the
+   * root container's focus cycle.
+   *
+   * @return true if the focus will be transferred down-cycle
+   * implicitly
+   */
+  public boolean getImplicitDownCycleTraversal ()
   {
     return implicitDownCycleTraversal;
   }
 
-  protected boolean accept(Component current)
+  /**
+   * Check whether the given Component is an acceptable target for the
+   * keyboard input focus.
+   *
+   * @param current the Component to check
+   *
+   * @return true if current is acceptable, false otherwise
+   */
+  protected boolean accept (Component current)
   {
     return (current.visible
-            && current.isDisplayable()
+            && current.isDisplayable ()
             && current.enabled
             && current.focusable);
   }
-} // class ContainerOrderFocusTraversalPolicy
+}
Index: java/awt/DefaultFocusTraversalPolicy.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/DefaultFocusTraversalPolicy.java,v
retrieving revision 1.1
diff -u -r1.1 DefaultFocusTraversalPolicy.java
--- java/awt/DefaultFocusTraversalPolicy.java	9 Aug 2002 04:26:14 -0000	1.1
+++ java/awt/DefaultFocusTraversalPolicy.java	22 Apr 2004 16:01:10 -0000
@@ -39,17 +39,73 @@
 package java.awt;
 
 /**
- * STUB CLASS ONLY
+ * DefaultFocusTraversalPolicy is the default focus traversal policy
+ * used by Containers.
+ *
+ * This policy sharpens ContainerOrderFocusTraversalPolicy's
+ * acceptance criteria, to reject those Components that have
+ * unfocusable peers.  Despite this extra strictness, this policy will
+ * always accept a Component that has explicitly been set focusable by
+ * any means.
+ *
+ * This AWT implementation assumes that the peers of the following
+ * Components are not focusable: Canvas, Panel, Label, ScrollPane,
+ * Scrollbar, Window, and any lightweight Component.
+ *
+ * A Component's focusability is independent of the focusability of
+ * its peer.
+ *
+ * @author Thomas Fitzsimmons <fitzsim@redhat.com>
+ * @since 1.4
  */
 public class DefaultFocusTraversalPolicy
   extends ContainerOrderFocusTraversalPolicy
 {
-  public DefaultFocusTraversalPolicy()
+  /**
+   * Construct a default focus traversal policy.
+   */
+  public DefaultFocusTraversalPolicy ()
   {
   }
 
-  protected boolean accept(Component comp)
+  /**
+   * Check whether a given Component would be acceptable as a focus
+   * owner.  The Component must be displayable, visible and enabled to
+   * be acceptable.  If the Component's focus traversability has been
+   * overridden, by overriding Component.isFocusTraversable or
+   * Component.isFocusable, or by calling Component.setFocusable, then
+   * the Component will be accepted if it is focusable.  If the
+   * Component uses the default focus traversable behaviour, then
+   * <code>comp</code> will always be rejected if it is a Canvas,
+   * Panel, Label, ScrollPane, Scrollbar, Window or lightweight
+   * Component.
+   *
+   * @param comp the Component to check
+   *
+   * @return true if the Component is an acceptable target for
+   * keyboard input focus, false otherwise
+   */
+  protected boolean accept (Component comp)
   {
-    throw new Error("not implemented");
+    if (comp.visible
+	&& comp.isDisplayable ()
+	&& comp.enabled)
+      {
+	if (comp.isFocusTraversableOverridden != 0
+	    && comp.isFocusTraversable ())
+	  return true;
+	else
+	  {
+	    if (!(comp instanceof Canvas
+		  || comp instanceof Panel
+		  || comp instanceof Label
+		  || comp instanceof ScrollPane
+		  || comp instanceof Scrollbar
+		  || comp instanceof Window
+		  || comp.isLightweight ()))
+	      return true;
+	  }
+      }
+    return false;
   }
-} // class DefaultFocusTraversalPolicy
+}
Index: java/awt/DefaultKeyboardFocusManager.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/DefaultKeyboardFocusManager.java,v
retrieving revision 1.1
diff -u -r1.1 DefaultKeyboardFocusManager.java
--- java/awt/DefaultKeyboardFocusManager.java	9 Aug 2002 04:26:14 -0000	1.1
+++ java/awt/DefaultKeyboardFocusManager.java	22 Apr 2004 16:01:10 -0000
@@ -38,59 +38,434 @@
 
 package java.awt;
 
-import java.awt.event.KeyEvent;
+import java.util.*;
+import java.awt.event.*;
 
-/**
- * STUB CLASS ONLY
- */
+// FIXME: finish documentation
 public class DefaultKeyboardFocusManager extends KeyboardFocusManager
 {
-  public DefaultKeyboardFocusManager()
+  /**
+   * This class models a request to delay the dispatch of events that
+   * arrive after a certain time, until a certain component becomes
+   * the focus owner.
+   */
+  private class EventDelayRequest implements Comparable
+  {
+    /** A {@link java.util.List} of {@link java.awt.event.KeyEvent}s
+        that are being delayed, pending this request's {@link
+        Component} receiving the keyboard focus. */
+    private LinkedList enqueuedKeyEvents = new LinkedList ();
+
+    /** An event timestamp.  All events that arrive after this time
+        should be queued in the {@link #enqueuedKeyEvents} {@link
+        java.util.List}. */
+    public long timestamp;
+    /** When this {@link Component} becomes focused, all events
+        between this EventDelayRequest and the next one in will be
+        dispatched from {@link #enqueuedKeyEvents}. */
+    public Component focusedComp;
+
+    /**
+     * Construct a new EventDelayRequest.
+     *
+     * @param timestamp events that arrive after this time will be
+     * delayed
+     * @param focusedComp the Component that needs to receive focus
+     * before events are dispatched
+     */
+    public EventDelayRequest (long timestamp, Component focusedComp)
+    {
+      this.timestamp = timestamp;
+      this.focusedComp = focusedComp;
+    }
+
+    public int compareTo (Object o)
+    {
+      if (!(o instanceof EventDelayRequest))
+        throw new ClassCastException ();
+
+      EventDelayRequest request = (EventDelayRequest) o;
+
+      if (request.timestamp < timestamp)
+        return -1;
+      else if (request.timestamp == timestamp)
+        return 0;
+      else
+        return 1;
+    }
+
+    public boolean equals (Object o)
+    {
+      if (!(o instanceof EventDelayRequest) || o == null)
+        return false;
+
+      EventDelayRequest request = (EventDelayRequest) o;
+
+      return (request.timestamp == timestamp
+              && request.focusedComp == focusedComp);
+    }
+
+    public void enqueueEvent (KeyEvent e)
+    {
+      KeyEvent last = (KeyEvent) enqueuedKeyEvents.getLast ();
+      if (last != null && e.getWhen () < last.getWhen ())
+        throw new RuntimeException ("KeyEvents enqueued out-of-order");
+
+      if (e.getWhen () <= timestamp)
+        throw new RuntimeException ("KeyEvents enqueued before starting timestamp");
+
+      enqueuedKeyEvents.add (e);
+    }
+
+    public void dispatchEvents ()
+    {
+      int size = enqueuedKeyEvents.size ();
+      for (int i = 0; i < size; i++)
+        {
+          KeyEvent e = (KeyEvent) enqueuedKeyEvents.remove (0);
+          dispatchKeyEvent (e);
+        }
+    }
+
+    public void discardEvents ()
+    {
+      enqueuedKeyEvents.clear ();
+    }
+  }
+
+  /** The {@link java.util.SortedSet} of current {@link
+      #EventDelayRequest}s. */
+  private SortedSet delayRequests = new TreeSet ();
+
+  public DefaultKeyboardFocusManager ()
   {
   }
 
-  public boolean dispatchEvent(AWTEvent e)
+  public boolean dispatchEvent (AWTEvent e)
   {
-    throw new Error("not implemented");
+    if (e instanceof WindowEvent)
+      {
+        Window target = (Window) e.getSource ();
+
+        if (e.id == WindowEvent.WINDOW_ACTIVATED)
+          setGlobalActiveWindow (target);
+        else if (e.id == WindowEvent.WINDOW_GAINED_FOCUS)
+          setGlobalFocusedWindow (target);
+        else if (e.id != WindowEvent.WINDOW_LOST_FOCUS
+                 && e.id != WindowEvent.WINDOW_DEACTIVATED)
+          return false;
+
+        target.dispatchEvent (e);
+        return true;
+      }
+    else if (e instanceof FocusEvent)
+      {
+        Component target = (Component) e.getSource ();
+
+        if (e.id == FocusEvent.FOCUS_GAINED)
+          {
+            if (((FocusEvent) e).isTemporary ())
+              setGlobalFocusOwner (target);
+            else
+              {
+                System.out.println ("SETTING FOCUS TO: " + target);
+                setGlobalPermanentFocusOwner (target);
+              }
+          }
+
+        target.dispatchEvent (e);
+        return true;
+      }
+    else if (e instanceof KeyEvent)
+      {
+        // Loop through all registered KeyEventDispatchers, giving
+        // each a chance to handle this event.
+        Iterator i = keyEventDispatchers.iterator ();
+
+        while (i.hasNext ())
+          {
+            KeyEventDispatcher dispatcher = (KeyEventDispatcher) i.next ();
+            if (dispatcher.dispatchKeyEvent ((KeyEvent) e))
+              return true;
+          }
+
+        // processKeyEvent checks if this event represents a focus
+        // traversal key stroke.
+        Component focusOwner = getGlobalPermanentFocusOwner ();
+        processKeyEvent (focusOwner, (KeyEvent) e);
+
+        if (e.isConsumed ())
+          return true;
+
+        if (enqueueKeyEvent ((KeyEvent) e))
+          // This event was enqueued for dispatch at a later time.
+          return true;
+        else
+          // This event wasn't handled by any of the registered
+          // KeyEventDispatchers, and wasn't enqueued for dispatch
+          // later, so send it to the default dispatcher.
+          return dispatchKeyEvent ((KeyEvent) e);
+      }
+
+    return false;
   }
-  public boolean dispatchKeyEvent(KeyEvent e)
+
+  private boolean enqueueKeyEvent (KeyEvent e)
   {
-    throw new Error("not implemented");
+    Iterator i = delayRequests.iterator ();
+    boolean oneEnqueued = false;
+    while (i.hasNext ())
+      {
+        EventDelayRequest request = (EventDelayRequest) i.next ();
+        if (e.getWhen () > request.timestamp)
+          {
+            request.enqueueEvent (e);
+            oneEnqueued = true;
+          }
+      }
+    return oneEnqueued;
+  }
+
+  public boolean dispatchKeyEvent (KeyEvent e)
+  {
+    //    System.out.println ("DefaultKeyboardFocusManager.dispatchKeyEvent: " + e);
+
+    Component focusOwner = getGlobalPermanentFocusOwner ();
+
+    focusOwner.dispatchEvent (e);
+
+    // Loop through all registered KeyEventPostProcessors, giving
+    // each a chance to process this event.
+    Iterator i = keyEventPostProcessors.iterator ();
+
+    while (i.hasNext ())
+      {
+        KeyEventPostProcessor processor = (KeyEventPostProcessor) i.next ();
+        if (processor.postProcessKeyEvent ((KeyEvent) e))
+          return true;
+      }
+
+    // The event hasn't been consumed yet.  Check if it is an
+    // MenuShortcut.
+    if (postProcessKeyEvent (e))
+      return true;
+
+    // FIXME: how do we "pass the event to the peers for processing"?
+
+    // Always return true.
+    return true;
   }
-  public boolean postProcessKeyEvent(KeyEvent e)
+
+  public boolean postProcessKeyEvent (KeyEvent e)
   {
-    throw new Error("not implemented");
+    //    System.out.println ("DefaultKeyboardFocusManager.postProcessKeyEvent: " + e);
+
+    // Check if this event represents a menu shortcut.
+
+    // MenuShortcuts are activated by Ctrl- KeyEvents.
+    int modifiers = e.getModifiers ();
+    if ((modifiers & KeyEvent.CTRL_MASK) != 0
+        || (modifiers & KeyEvent.CTRL_DOWN_MASK) != 0)
+      {
+        Window focusedWindow = getGlobalFocusedWindow ();
+        if (focusedWindow instanceof Frame)
+          {
+            MenuBar menubar = ((Frame) focusedWindow).getMenuBar ();
+
+            if (menubar != null)
+              {
+                // If there's a menubar, loop through all menu items,
+                // checking whether each one has a shortcut, and if
+                // so, whether this key event should activate it.
+                int numMenus = menubar.getMenuCount ();
+
+                for (int i = 0; i < numMenus; i++)
+                  {
+                    Menu menu = menubar.getMenu (i);
+                    int numItems = menu.getItemCount ();
+
+                    for (int j = 0; j < numItems; j++)
+                      {
+                        MenuItem item = menu.getItem (j);
+                        MenuShortcut shortcut = item.getShortcut ();
+
+                        if (shortcut != null)
+                          {
+                            // Dispatch a new ActionEvent if this is a
+                            // Shift- KeyEvent and the shortcut requires
+                            // the Shift modifier, or if the shortcut
+                            // doesn't require the Shift modifier.
+                            if ((shortcut.usesShiftModifier ()
+                                 && ((modifiers & KeyEvent.SHIFT_MASK) != 0
+                                     || (modifiers & KeyEvent.SHIFT_DOWN_MASK) != 0)
+                                 || !shortcut.usesShiftModifier ())
+                                && shortcut.getKey () == e.getKeyCode ())
+                              {
+                                item.dispatchEvent (new ActionEvent (item,
+                                                                     ActionEvent.ACTION_PERFORMED,
+                                                                     item.getActionCommand (),
+                                                                     modifiers));
+                                // The event was dispatched.
+                                return true;
+                              }
+                          }
+                      }
+                  }
+              }
+          }
+      }
+    return false;
   }
-  public void processKeyEvent(Component comp, KeyEvent e)
+
+  public void processKeyEvent (Component comp, KeyEvent e)
   {
-    throw new Error("not implemented");
+    //    System.out.println ("DefaultKeyboardFocusManager.processKeyEvent: " + e);
+
+    AWTKeyStroke keystroke = AWTKeyStroke.getAWTKeyStrokeForEvent (e);
+
+    Set forwardKeystrokes = comp.getFocusTraversalKeys (KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS);
+    Set backwardKeystrokes = comp.getFocusTraversalKeys (KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS);
+    Set upKeystrokes = comp.getFocusTraversalKeys (KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS);
+    Set downKeystrokes = null;
+    if (comp instanceof Container)
+      downKeystrokes = comp.getFocusTraversalKeys (KeyboardFocusManager.DOWN_CYCLE_TRAVERSAL_KEYS);
+
+    if (forwardKeystrokes.contains (keystroke))
+      {
+        focusNextComponent (comp);
+        e.consume ();
+      }
+    else if (backwardKeystrokes.contains (keystroke))
+      {
+        focusPreviousComponent (comp);
+        e.consume ();
+      }
+    else if (upKeystrokes.contains (keystroke))
+      {
+        upFocusCycle (comp);
+        e.consume ();
+      }
+    else if (comp instanceof Container
+             && downKeystrokes.contains (keystroke))
+      {
+        downFocusCycle ((Container) comp);
+        e.consume ();
+      }
   }
-  protected void enqueueKeyEvents(long after, Component comp)
+
+  protected void enqueueKeyEvents (long after, Component untilFocused)
   {
-    throw new Error("not implemented");
+    System.out.println ("DefaultKeyboardFocusManager.enqueueKeyEvents: " + untilFocused);
+
+    delayRequests.add (new EventDelayRequest (after, untilFocused));
   }
-  protected void dequeueKeyEvents(long after, Component comp)
+
+  protected void dequeueKeyEvents (long after, Component untilFocused)
   {
-    throw new Error("not implemented");
+    System.out.println ("DefaultKeyboardFocusManager.dequeueKeyEvents: " + untilFocused);
+
+    // FIXME: need synchronization on delayRequests and enqueuedKeyEvents.
+
+    // Remove the KeyEvent with the oldest timestamp, which should be
+    // the first element in the SortedSet.
+    if (after < 0)
+      {
+        int size = delayRequests.size ();
+        if (size > 0)
+          delayRequests.remove (delayRequests.first ());
+      }
+    else
+      {
+        EventDelayRequest template = new EventDelayRequest (after, untilFocused);
+        if (delayRequests.contains (template))
+          {
+            EventDelayRequest actual = (EventDelayRequest) delayRequests.tailSet (template).first ();
+            delayRequests.remove (actual);
+            actual.dispatchEvents ();
+          }
+      }
   }
-  protected void discardKeyEvents(Component comp)
+
+  protected void discardKeyEvents (Component comp)
   {
-    throw new Error("not implemented");
+    System.out.println ("DefaultKeyboardFocusManager.discardKeyEvents: " + comp);
+
+    // FIXME: need synchronization on delayRequests and enqueuedKeyEvents.
+
+    Iterator i = delayRequests.iterator ();
+
+    while (i.hasNext ())
+      {
+        EventDelayRequest request = (EventDelayRequest) i.next ();
+
+        if (request.focusedComp == comp
+            || (comp instanceof Container
+                && ((Container) comp).isAncestorOf (request.focusedComp)))
+          request.discardEvents ();
+      }
   }
-  public void focusPreviousComponent(Component comp)
+
+  public void focusPreviousComponent (Component comp)
   {
-    throw new Error("not implemented");
+    System.out.println ("DefaultKeyboardFocusManager.focusPreviousComponent: " + comp);
+
+    Component focusComp = (comp == null) ? getGlobalFocusOwner () : comp;
+    Container focusCycleRoot = focusComp.getFocusCycleRootAncestor ();
+    FocusTraversalPolicy policy = focusCycleRoot.getFocusTraversalPolicy ();
+
+    Component previous = policy.getComponentBefore (focusCycleRoot, focusComp);
+    previous.requestFocus ();
   }
-  public void focusNextComponent(Component comp)
+
+  public void focusNextComponent (Component comp)
   {
-    throw new Error("not implemented");
+    System.out.println ("DefaultKeyboardFocusManager.focusNextComponent: " + comp);
+
+    Component focusComp = (comp == null) ? getGlobalFocusOwner () : comp;
+    Container focusCycleRoot = focusComp.getFocusCycleRootAncestor ();
+    FocusTraversalPolicy policy = focusCycleRoot.getFocusTraversalPolicy ();
+
+    Component next = policy.getComponentAfter (focusCycleRoot, focusComp);
+    System.out.println ("Got next component: " + next);
+    System.out.println ("Got focus comp: " + focusComp);
+    next.requestFocus ();
   }
-  public void upFocusCycle(Component comp)
+
+  public void upFocusCycle (Component comp)
   {
-    throw new Error("not implemented");
+    System.out.println ("DefaultKeyboardFocusManager.upFocusCycle: " + comp);
+
+    Component focusComp = (comp == null) ? getGlobalFocusOwner () : comp;
+    Container focusCycleRoot = focusComp.getFocusCycleRootAncestor ();
+
+    if (focusCycleRoot instanceof Window)
+      {
+        FocusTraversalPolicy policy = focusCycleRoot.getFocusTraversalPolicy ();
+        Component defaultComponent = policy.getDefaultComponent (focusCycleRoot);
+        defaultComponent.requestFocus ();
+      }
+    else
+      {
+        Container parentFocusCycleRoot = focusCycleRoot.getFocusCycleRootAncestor ();
+
+        focusCycleRoot.requestFocus ();
+        setGlobalCurrentFocusCycleRoot (parentFocusCycleRoot);
+      }
   }
-  public void downFocusCycle(Container cont)
+
+  public void downFocusCycle (Container cont)
   {
-    throw new Error("not implemented");
+    System.out.println ("DefaultKeyboardFocusManager.downFocusCycle: " + cont);
+
+    if (cont == null)
+      return;
+
+    if (cont.isFocusCycleRoot (cont))
+      {
+        FocusTraversalPolicy policy = cont.getFocusTraversalPolicy ();
+        Component defaultComponent = policy.getDefaultComponent (cont);
+        defaultComponent.requestFocus ();
+        setGlobalCurrentFocusCycleRoot (cont);
+      }
   }
 } // class DefaultKeyboardFocusManager
Index: java/awt/EventDispatchThread.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/EventDispatchThread.java,v
retrieving revision 1.5
diff -u -r1.5 EventDispatchThread.java
--- java/awt/EventDispatchThread.java	16 Jan 2004 16:15:49 -0000	1.5
+++ java/awt/EventDispatchThread.java	22 Apr 2004 16:01:10 -0000
@@ -57,6 +57,9 @@
 
   public void run()
   {
+    // Set the default KeyboardFocusManager.
+    KeyboardFocusManager.setCurrentKeyboardFocusManager (null);
+
     while (true)
       {
         try
@@ -67,7 +70,23 @@
 	      // We are interrupted when we should finish executing
 	      return;
 	    }
-	  queue.dispatchEvent(evt);
+
+          KeyboardFocusManager manager;
+          manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+          // Try to dispatch this event to the current keyboard focus
+          // manager.  It will dispatch all FocusEvents, all
+          // WindowEvents related to focus, and all KeyEvents,
+          // returning true.  Otherwise, it returns false and we
+          // dispatch the event normally.
+          if (!manager.dispatchEvent (evt))
+            {
+              queue.dispatchEvent(evt);
+            }
+          else
+            {
+              //              System.out.println ("Dispatched " + evt + " to DefaultKeyboardFocusManager");
+            }
 	}
 	catch (InterruptedException ie)
 	{
Index: java/awt/KeyboardFocusManager.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/KeyboardFocusManager.java,v
retrieving revision 1.2
diff -u -r1.2 KeyboardFocusManager.java
--- java/awt/KeyboardFocusManager.java	13 Feb 2003 07:02:12 -0000	1.2
+++ java/awt/KeyboardFocusManager.java	22 Apr 2004 16:01:10 -0000
@@ -39,34 +39,66 @@
 package java.awt;
 
 import java.awt.event.KeyEvent;
+import java.awt.event.FocusEvent;
 import java.beans.PropertyChangeListener;
 import java.beans.PropertyChangeSupport;
 import java.beans.PropertyVetoException;
 import java.beans.VetoableChangeListener;
 import java.beans.VetoableChangeSupport;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Map;
 import java.util.Set;
 
+// FIXME: finish documentation
+
 /**
  *
+ * FIXME: discuss applet contexts and thread groups and codebases
+ * being insulated.
+ *
+ * FIXME: discuss where default focus traversal key sets apply
+ * (inherited by child Components etc.)
+ *
  * @author Eric Blake <ebb9@email.byu.edu>
+ * @author Thomas Fitzsimmons <fitzsim@redhat.com>
  * @since 1.4
  * @status partially updated to 1.4, needs documentation.
  */
 public abstract class KeyboardFocusManager
   implements KeyEventDispatcher, KeyEventPostProcessor
 {
+  /** Identifies {@link AWTKeyStroke}s that move the focus forward in
+      the focus cycle. */
   public static final int FORWARD_TRAVERSAL_KEYS = 0;
+
+  /** Identifies {@link AWTKeyStroke}s that move the focus backward in
+      the focus cycle. */
   public static final int BACKWARD_TRAVERSAL_KEYS = 1;
+
+  /** Identifies {@link AWTKeyStroke}s that move the focus up to the
+      parent focus cycle root. */
   public static final int UP_CYCLE_TRAVERSAL_KEYS = 2;
+
+  /** Identifies {@link AWTKeyStroke}s that move the focus down to the
+      child focus cycle root. */
   public static final int DOWN_CYCLE_TRAVERSAL_KEYS = 3;
 
+  /** The set of {@link AWTKeyStroke}s that cause focus to be moved to
+      the next focusable Component in the focus cycle. */
   private static final Set DEFAULT_FORWARD_KEYS;
+
+  /** The set of {@link AWTKeyStroke}s that cause focus to be moved to
+      the previous focusable Component in the focus cycle. */
   private static final Set DEFAULT_BACKWARD_KEYS;
+
+  /** Populate the DEFAULT_FORWARD_KEYS and DEFAULT_BACKWARD_KEYS
+      {@link java.util.Set}s. */
   static
   {
     Set s = new HashSet();
@@ -83,232 +115,403 @@
     DEFAULT_BACKWARD_KEYS = Collections.unmodifiableSet(s);
   }
 
-  private static KeyboardFocusManager current
-    = new DefaultKeyboardFocusManager();
-
-  // XXX Not implemented correctly. I think a good implementation here may
-  // be to have permanentFocusOwner be null, and fall back to focusOwner,
-  // unless a temporary focus change is in effect.
-  private static Component focusOwner;
-  private static Component permanentFocusOwner;
-
-  private static Window focusedWindow;
-  private static Window activeWindow;
-  private static Container focusCycleRoot;
+  /** The global object {@link java.util.Map}s. */
 
+  /** For security reasons, {@link java.applet.Applet}s in different
+      codebases must be insulated from one another.  Since {@link
+      KeyboardFocusManager}s have the ability to return {@link
+      Component}s from a given {@link java.applet.Applet}, each
+      codebase must have an independent {@link KeyboardFocusManager}.
+      Since each codebase has its own {@link ThreadGroup} in which its
+      {@link Applet}s run, it makes sense to partition {@link
+      KeyboardFocusManager}s according to {@link
+      java.lang.ThreadGroup}.  Thus, currentKeyboardFocusManagers is a
+      {@link java.util.Map} keyed on {@link java.lang.ThreadGroup}. */
+  private static Map currentKeyboardFocusManagers = new HashMap ();
+
+  /** {@link java.applet.Applet}s in one codebase must not be allowed
+      to access {@link Component}s in {@link java.applet.Applet}s in
+      other codebases.  To enforce this restriction, we key the
+      following {@link java.util.Map}s on {@link java.lang.ThreadGroup}s (which
+      are per-codebase).  For example, if {@link
+      java.lang.ThreadGroup} A calls {@link #setGlobalFocusOwner},
+      passing {@link Component} C, currentFocusOwners[A] is assigned
+      C, and all other currentFocusOwners values are nullified.  Then
+      if {@link java.lang.ThreadGroup} A subsequently calls {@link
+      #getGlobalFocusOwner}, it will return currentFocusOwners[A],
+      that is, {@link Component} C.  If another {@link
+      java.lang.ThreadGroup} K calls {@link #getGlobalFocusOwner}, it
+      will return currentFocusOwners[K], that is, null.
+
+      Since this is a static field, we ensure that there is only one
+      focused {@link Component} per class loader. */
+  private static Map currentFocusOwners = new HashMap ();
+
+  /** A {@link java.util.Map} keyed on {@link java.lang.ThreadGroup}s
+      that stores the {@link Component} that owns the permanent
+      keyboard focus. @see currentFocusOwners */
+  private static Map currentPermanentFocusOwners = new HashMap ();
+
+  /** A {@link java.util.Map} keyed on {@link java.lang.ThreadGroup}s
+      that stores the focused {@link Window}. @see
+      currentFocusOwners */
+  private static Map currentFocusedWindows = new HashMap ();
+
+  /** A {@link java.util.Map} keyed on {@link java.lang.ThreadGroup}s
+      that stores the active {@link Window}. @see
+      currentFocusOwners */
+  private static Map currentActiveWindows = new HashMap ();
+
+  /** A {@link java.util.Map} keyed on {@link java.lang.ThreadGroup}s
+      that stores the focus cycle root {@link Container}. @see
+      currentFocusOwners */
+  private static Map currentFocusCycleRoots = new HashMap ();
+
+  /** The default {@link FocusTraveralPolicy} that focus-managing
+      {@link Container}s will use to define their initial focus
+      traversal policy. */
   private FocusTraversalPolicy defaultPolicy;
-  private Set[] defaultFocusKeys = new Set[] {
+
+  /** An array that stores the {@link #FORWARD_TRAVERSAL_KEYS}, {@link
+      #BACKWARD_TRAVERSAL_KEYS}, {@link #UP_CYCLE_TRAVERSAL_KEYS} and
+      {@link #DOWN_CYCLE_TRAVERSAL_KEYS} {@link AWTKeyStroke}s {@link
+      java.util.Set}s. */
+  private Set[] defaultFocusKeys = new Set[]
+  {
     DEFAULT_FORWARD_KEYS, DEFAULT_BACKWARD_KEYS,
     Collections.EMPTY_SET, Collections.EMPTY_SET
   };
 
-  private final PropertyChangeSupport propertyChangeSupport
-    = new PropertyChangeSupport(this);
-  private final VetoableChangeSupport vetoableChangeSupport
-    = new VetoableChangeSupport(this);
+  private final PropertyChangeSupport propertyChangeSupport = new PropertyChangeSupport (this);
+  private final VetoableChangeSupport vetoableChangeSupport = new VetoableChangeSupport (this);
+
+  /** A list of {@link KeyEventDispatcher}s that process {@link
+      KeyEvent}s before they are processed the default keyboard focus
+      manager. */
   private final ArrayList keyEventDispatchers = new ArrayList();
-  private final ArrayList keyEventPostProcessors = new ArrayList();
 
-
-  public KeyboardFocusManager()
-  {
-  }
+  /** A list of {@link KeyEventPostProcessor}s that process unconsumed
+      {@link KeyEvent}s. */
+  private final ArrayList keyEventPostProcessors = new ArrayList();
 
-  public static KeyboardFocusManager getCurrentKeyboardFocusManager()
+  /**
+   * Construct a KeyboardFocusManager.
+   */
+  public KeyboardFocusManager ()
   {
-    // XXX Need a way to divide this into contexts.
-    return current;
   }
 
-  public static void setCurrentKeyboardFocusManager(KeyboardFocusManager m)
+  /**
+   * Retrieve the keyboard focus manager associated with the {@link
+   * java.lang.ThreadGroup} to which the calling thread belongs.
+   *
+   * @return the keyboard focus manager associated with the current
+   * thread group
+   */
+  public static KeyboardFocusManager getCurrentKeyboardFocusManager ()
+  {
+    ThreadGroup currentGroup = Thread.currentThread ().getThreadGroup ();
+    return (KeyboardFocusManager) currentKeyboardFocusManagers.get (currentGroup);
+  }
+
+  /**
+   * Set the keyboard focus manager associated with the {@link
+   * java.lang.ThreadGroup} to which the calling thread belongs.
+   *
+   * @param m the keyboard focus manager for the current thread group
+   */
+  public static void setCurrentKeyboardFocusManager (KeyboardFocusManager m)
   {
-    SecurityManager sm = System.getSecurityManager();
+    SecurityManager sm = System.getSecurityManager ();
     if (sm != null)
-      sm.checkPermission(new AWTPermission("replaceKeyboardFocusManager"));
-    // XXX Need a way to divide this into contexts.
-    current = m == null ? new DefaultKeyboardFocusManager() : m;
-  }
+      sm.checkPermission (new AWTPermission ("replaceKeyboardFocusManager"));
 
-  public Component getFocusOwner()
-  {
-    // XXX Need an easy way to test if this thread is in the context of the
-    // global focus owner, to avoid creating the exception in the first place.
-    try
-      {
-        return getGlobalFocusOwner();
-      }
-    catch (SecurityException e)
-      {
-        return null;
-      }
-  }
-
-  protected Component getGlobalFocusOwner()
-  {
-    // XXX Need a way to test if this thread is in the context of the focus
-    // owner, and throw a SecurityException if that is the case.
-    // XXX Implement.
-    return focusOwner;
-  }
+    ThreadGroup currentGroup = Thread.currentThread ().getThreadGroup ();
+    KeyboardFocusManager manager;
 
-  protected void setGlobalFocusOwner(Component owner)
+    if (m == null)
+      manager = new DefaultKeyboardFocusManager ();
+    else
+      manager = m;
+
+    currentKeyboardFocusManagers.put (currentGroup, manager);
+  }
+
+  /**
+   * Retrieve the {@link Component} that has the keyboard focus, or
+   * null if the focus owner was not set by a thread in the current
+   * {@link java.lang.ThreadGroup}.
+   *
+   * @return the keyboard focus owner or null
+   */
+  public Component getFocusOwner ()
+  {
+    return (Component) getObject (currentFocusOwners);
+  }
+
+  /**
+   * Retrieve the {@link Component} that has the keyboard focus,
+   * regardless of whether or not it was set by a thread in the
+   * current {@link java.lang.ThreadGroup}.  If there is no temporary
+   * focus owner in effect then this method will return the same value
+   * as {@link #getGlobalPermanentFocusOwner}.
+   *
+   * @return the keyboard focus owner
+   * @throws SecurityException if this is not the keyboard focus
+   * manager associated with the current {@link java.lang.ThreadGroup}
+   */
+  protected Component getGlobalFocusOwner ()
+  {
+    // Check if there is a temporary focus owner.
+    Component focusOwner = (Component) getGlobalObject (currentFocusOwners);
+
+    return (focusOwner == null) ? getGlobalPermanentFocusOwner () : focusOwner;
+  }
+
+  /**
+   * Set the {@link Component} that will be returned by {@link
+   * #getFocusOwner} (when it is called from the current {@link
+   * java.lang.ThreadGroup}) and {@link #getGlobalFocusOwner}.  This
+   * method does not actually transfer the keyboard focus.
+   *
+   * @param owner the Component to return from getFocusOwner and
+   * getGlobalFocusOwner
+   *
+   * @see Component.requestFocus ()
+   * @see Component.requestFocusInWindow ()
+   */
+  protected void setGlobalFocusOwner (Component owner)
   {
-    // XXX Should this send focus events to the components involved?
     if (owner == null || owner.focusable)
-      {
-        firePropertyChange("focusOwner", focusOwner, owner);
-        try
-          {
-            fireVetoableChange("focusOwner", focusOwner, owner);
-            focusOwner = owner;
-          }
-        catch (PropertyVetoException e)
-          {
-          }
-      }
+      setGlobalObject (currentFocusOwners, owner, "focusOwner");
   }
 
-  public void clearGlobalFocusOwner()
+  /**
+   * Clear the global focus owner and deliver a FOCUS_LOST event to
+   * the previously-focused {@link Component}.  Until another {@link
+   * Component} becomes the keyboard focus owner, key events will be
+   * discarded by top-level windows.
+   */
+  public void clearGlobalFocusOwner ()
   {
-    // XXX Is this enough?
-    setGlobalFocusOwner(null);
-  }
-
-  public Component getPermanentFocusOwner()
-  {
-    // XXX Need an easy way to test if this thread is in the context of the
-    // global focus owner, to avoid creating the exception in the first place.
-    try
+    synchronized (currentFocusOwners)
       {
-        return getGlobalPermanentFocusOwner();
-      }
-    catch (SecurityException e)
-      {
-        return null;
-      }
-  }
+        Component focusOwner = getGlobalFocusOwner ();
+        Component permanentFocusOwner = getGlobalPermanentFocusOwner ();
 
-  protected Component getGlobalPermanentFocusOwner()
-  {
-    // XXX Need a way to test if this thread is in the context of the focus
-    // owner, and throw a SecurityException if that is the case.
-    // XXX Implement.
-    return permanentFocusOwner == null ? focusOwner : permanentFocusOwner;
-  }
+        setGlobalFocusOwner (null);
+        setGlobalPermanentFocusOwner (null);
 
-  protected void setGlobalPermanentFocusOwner(Component focusOwner)
-  {
-    // XXX Should this send focus events to the components involved?
-    if (focusOwner == null || focusOwner.focusable)
-      {
-        firePropertyChange("permanentFocusOwner", permanentFocusOwner,
-                           focusOwner);
-        try
+        // Inform the old focus owner that it has lost permanent
+        // focus.
+        if (focusOwner != null)
           {
-            fireVetoableChange("permanentFocusOwner", permanentFocusOwner,
-                               focusOwner);
-            permanentFocusOwner = focusOwner;
+            // We can't cache the event queue, because of
+            // bootstrapping issues.  We need to set the default
+            // KeyboardFocusManager in EventQueue before the event
+            // queue is started.
+            EventQueue q = Toolkit.getDefaultToolkit ().getSystemEventQueue ();
+            if (focusOwner != permanentFocusOwner)
+              q.postEvent (new FocusEvent (focusOwner, FocusEvent.FOCUS_LOST, true));
+            else
+              q.postEvent (new FocusEvent (focusOwner, FocusEvent.FOCUS_LOST, false));
           }
-        catch (PropertyVetoException e)
+
+        if (focusOwner != permanentFocusOwner)
           {
+            EventQueue q = Toolkit.getDefaultToolkit ().getSystemEventQueue ();
+            q.postEvent (new FocusEvent (permanentFocusOwner, FocusEvent.FOCUS_LOST, false));
           }
       }
   }
 
-  public Window getFocusedWindow()
+  /**
+   * Retrieve the {@link Component} that has the permanent keyboard
+   * focus, or null if the focus owner was not set by a thread in the
+   * current {@link java.lang.ThreadGroup}.
+   *
+   * @return the keyboard focus owner or null
+   */
+  public Component getPermanentFocusOwner ()
+  {
+    return (Component) getObject (currentPermanentFocusOwners);
+  }
+
+  /**
+   * Retrieve the {@link Component} that has the permanent keyboard
+   * focus, regardless of whether or not it was set by a thread in the
+   * current {@link java.lang.ThreadGroup}.
+   *
+   * @return the keyboard focus owner
+   * @throws SecurityException if this is not the keyboard focus
+   * manager associated with the current {@link java.lang.ThreadGroup}
+   */
+  protected Component getGlobalPermanentFocusOwner ()
+  {
+    return (Component) getGlobalObject (currentPermanentFocusOwners);
+  }
+
+  /**
+   * Set the {@link Component} that will be returned by {@link
+   * #getPermanentFocusOwner} (when it is called from the current
+   * {@link java.lang.ThreadGroup}) and {@link
+   * #getGlobalPermanentFocusOwner}.  This method does not actually
+   * transfer the keyboard focus.
+   *
+   * @param focusOwner the Component to return from
+   * getPermanentFocusOwner and getGlobalPermanentFocusOwner
+   *
+   * @see Component.requestFocus ()
+   * @see Component.requestFocusInWindow ()
+   */
+  protected void setGlobalPermanentFocusOwner (Component focusOwner)
   {
-    // XXX Need an easy way to test if this thread is in the context of the
-    // global focus owner, to avoid creating the exception in the first place.
-    try
-      {
-        return getGlobalFocusedWindow();
-      }
-    catch (SecurityException e)
-      {
-        return null;
-      }
-  }
-
-  protected Window getGlobalFocusedWindow()
-  {
-    // XXX Need a way to test if this thread is in the context of the focus
-    // owner, and throw a SecurityException if that is the case.
-    // XXX Implement.
-    return focusedWindow;
+    System.out.println ("in setGlobalFocusOwner: " + focusOwner);
+    if (focusOwner == null || focusOwner.focusable)
+      setGlobalObject (currentPermanentFocusOwners, focusOwner,
+		       "permanentFocusOwner");
   }
 
-  protected void setGlobalFocusedWindow(Window window)
+  /**
+   * Retrieve the {@link Window} that is or contains the keyboard
+   * focus owner, or null if the focused window was not set by a
+   * thread in the current {@link java.lang.ThreadGroup}.
+   *
+   * @return the focused window or null
+   */
+  public Window getFocusedWindow ()
+  {
+    return (Window) getObject (currentFocusedWindows);
+  }
+
+  /**
+   * Retrieve the {@link Window} that is or contains the focus owner,
+   * regardless of whether or not the {@link Window} was set focused
+   * by a thread in the current {@link java.lang.ThreadGroup}.
+   *
+   * @return the focused window
+   * @throws SecurityException if this is not the keyboard focus
+   * manager associated with the current {@link java.lang.ThreadGroup}
+   */
+  protected Window getGlobalFocusedWindow ()
+  {
+    return (Window) getGlobalObject (currentFocusedWindows);
+  }
+
+  /**
+   * Set the {@link Window} that will be returned by {@link
+   * #getFocusedWindow} (when it is called from the current {@link
+   * java.lang.ThreadGroup}) and {@link #getGlobalFocusedWindow}.
+   * This method does not actually cause <code>window</code> to become
+   * the focused {@link Window}.
+   *
+   * @param window the Window to return from getFocusedWindow and
+   * getGlobalFocusedWindow
+   */
+  protected void setGlobalFocusedWindow (Window window)
   {
-    // XXX Should this send focus events to the windows involved?
     if (window == null || window.focusable)
-      {
-        firePropertyChange("focusedWindow", focusedWindow, window);
-        try
-          {
-            fireVetoableChange("focusedWindow", focusedWindow, window);
-            focusedWindow = window;
-          }
-        catch (PropertyVetoException e)
-          {
-          }
-      }
+      setGlobalObject (currentFocusedWindows, window, "focusedWindow");
   }
 
+  /**
+   * Retrieve the active {@link Window}, or null if the active window
+   * was not set by a thread in the current {@link
+   * java.lang.ThreadGroup}.
+   *
+   * @return the active window or null
+   */
   public Window getActiveWindow()
   {
-    // XXX Need an easy way to test if this thread is in the context of the
-    // global focus owner, to avoid creating the exception in the first place.
-    try
-      {
-        return getGlobalActiveWindow();
-      }
-    catch (SecurityException e)
-      {
-        return null;
-      }
+    return (Window) getObject (currentActiveWindows);
   }
 
+  /**
+   * Retrieve the active {@link Window}, regardless of whether or not
+   * the {@link Window} was made active by a thread in the current
+   * {@link java.lang.ThreadGroup}.
+   *
+   * @return the active window
+   * @throws SecurityException if this is not the keyboard focus
+   * manager associated with the current {@link java.lang.ThreadGroup}
+   */
   protected Window getGlobalActiveWindow()
   {
-    // XXX Need a way to test if this thread is in the context of the focus
-    // owner, and throw a SecurityException if that is the case.
-    // XXX Implement.
-    return activeWindow;
+    return (Window) getGlobalObject (currentActiveWindows);
   }
 
+  /**
+   * Set the {@link Window} that will be returned by {@link
+   * #getActiveWindow} (when it is called from the current {@link
+   * java.lang.ThreadGroup}) and {@link #getGlobalActiveWindow}.  This
+   * method does not actually cause <code>window</code> to be made
+   * active.
+   *
+   * @param window the Window to return from getActiveWindow and
+   * getGlobalActiveWindow
+   */
   protected void setGlobalActiveWindow(Window window)
   {
-    // XXX Should this send focus events to the windows involved?
-    firePropertyChange("activeWindow", activeWindow, window);
-    try
-      {
-        fireVetoableChange("activeWindow", activeWindow, window);
-        activeWindow = window;
-      }
-    catch (PropertyVetoException e)
-      {
-      }
+    setGlobalObject (currentActiveWindows, window, "activeWindow");
   }
 
-  public FocusTraversalPolicy getDefaultFocusTraversalPolicy()
+  /**
+   * Retrieve the default {@link FocusTraversalPolicy}.
+   * Focus-managing {@link Container}s use the returned object to
+   * define their initial focus traversal policy.
+   *
+   * @return a non-null default FocusTraversalPolicy object
+   */
+  public FocusTraversalPolicy getDefaultFocusTraversalPolicy ()
   {
     if (defaultPolicy == null)
-      defaultPolicy = new DefaultFocusTraversalPolicy();
+      defaultPolicy = new DefaultFocusTraversalPolicy ();
     return defaultPolicy;
   }
 
-  public void setDefaultFocusTraversalPolicy(FocusTraversalPolicy policy)
+  /**
+   * Set the {@link FocusTraversalPolicy} returned by {@link
+   * #getDefaultFocusTraversalPolicy}.  Focus-managing {@link
+   * Container}s created after this call will use policy as their
+   * initial focus traversal policy.  Existing {@link Container}s'
+   * focus traversal policies will not be affected by calls to this
+   * method.
+   *
+   * @param policy the FocusTraversalPolicy that will be returned by
+   * subsequent calls to getDefaultFocusTraversalPolicy
+   * @throws IllegalArgumentException if policy is null
+   */
+  public void setDefaultFocusTraversalPolicy (FocusTraversalPolicy policy)
   {
     if (policy == null)
-      throw new IllegalArgumentException();
-    firePropertyChange("defaultFocusTraversalPolicy", defaultPolicy, policy);
+      throw new IllegalArgumentException ();
+    firePropertyChange ("defaultFocusTraversalPolicy", defaultPolicy, policy);
     defaultPolicy = policy;
   }
 
-  public void setDefaultFocusTraversalKeys(int id, Set keystrokes)
-  {
+  /**
+   * Set the default {@link java.util.Set} of focus traversal keys for
+   * one of the focus traversal directions.
+   *
+   * @param id focus traversal direction identifier
+   * @param keystrokes set of AWTKeyStrokes
+   *
+   * @see #FORWARD_TRAVERSAL_KEYS
+   * @see #BACKWARD_TRAVERSAL_KEYS
+   * @see #UP_CYCLE_TRAVERSAL_KEYS
+   * @see #DOWN_CYCLE_TRAVERSAL_KEYS
+   */
+  public void setDefaultFocusTraversalKeys (int id, Set keystrokes)
+  {
+    if (id != KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS &&
+        id != KeyboardFocusManager.BACKWARD_TRAVERSAL_KEYS &&
+        id != KeyboardFocusManager.UP_CYCLE_TRAVERSAL_KEYS &&
+        id != KeyboardFocusManager.DOWN_CYCLE_TRAVERSAL_KEYS)
+      throw new IllegalArgumentException ();
+
     if (keystrokes == null)
-      throw new IllegalArgumentException();
+      throw new IllegalArgumentException ();
+
     Set sa;
     Set sb;
     Set sc;
@@ -340,56 +543,82 @@
         type = "downCycleDefaultFocusTraversalKeys";
         break;
       default:
-        throw new IllegalArgumentException();
+        throw new IllegalArgumentException ();
       }
-    int i = keystrokes.size();
-    Iterator iter = keystrokes.iterator();
+    int i = keystrokes.size ();
+    Iterator iter = keystrokes.iterator ();
     while (--i >= 0)
       {
-        Object o = iter.next();
-        if (! (o instanceof AWTKeyStroke)
-            || sa.contains(o) || sb.contains(o) || sc.contains(o)
+        Object o = iter.next ();
+        if (!(o instanceof AWTKeyStroke)
+            || sa.contains (o) || sb.contains (o) || sc.contains (o)
             || ((AWTKeyStroke) o).keyCode == KeyEvent.VK_UNDEFINED)
-          throw new IllegalArgumentException();
+          throw new IllegalArgumentException ();
       }
-    keystrokes = Collections.unmodifiableSet(new HashSet(keystrokes));
-    firePropertyChange(type, defaultFocusKeys[id], keystrokes);
+    keystrokes = Collections.unmodifiableSet (new HashSet (keystrokes));
+    firePropertyChange (type, defaultFocusKeys[id], keystrokes);
     defaultFocusKeys[id] = keystrokes;
   }
 
-  public Set getDefaultFocusTraversalKeys(int id)
+  /**
+   * Retrieve the default {@link java.util.Set} of focus traversal
+   * keys for one of the focus traversal directions.
+   *
+   * @param id focus traversal direction identifier
+   *
+   * @return the default set of AWTKeyStrokes
+   *
+   * @see #FORWARD_TRAVERSAL_KEYS
+   * @see #BACKWARD_TRAVERSAL_KEYS
+   * @see #UP_CYCLE_TRAVERSAL_KEYS
+   * @see #DOWN_CYCLE_TRAVERSAL_KEYS
+   */
+  public Set getDefaultFocusTraversalKeys (int id)
   {
     if (id < FORWARD_TRAVERSAL_KEYS || id > DOWN_CYCLE_TRAVERSAL_KEYS)
-      throw new IllegalArgumentException();
+      throw new IllegalArgumentException ();
     return defaultFocusKeys[id];
   }
 
-  public Container getCurrentFocusCycleRoot()
-  {
-    // XXX Need an easy way to test if this thread is in the context of the
-    // global focus owner, to avoid creating the exception in the first place.
-    try
-      {
-        return getGlobalCurrentFocusCycleRoot();
-      }
-    catch (SecurityException e)
-      {
-        return null;
-      }
-  }
-
-  protected Container getGlobalCurrentFocusCycleRoot()
-  {
-    // XXX Need a way to test if this thread is in the context of the focus
-    // owner, and throw a SecurityException if that is the case.
-    // XXX Implement.
-    return focusCycleRoot;
-  }
-
-  public void setGlobalCurrentFocusCycleRoot(Container cycleRoot)
+  /**
+   * Retrieve the current focus cycle root, or null if the focus owner
+   * was not set by a thread in the current {@link
+   * java.lang.ThreadGroup}.
+   *
+   * @return the current focus cycle root or null
+   */
+  public Container getCurrentFocusCycleRoot ()
+  {
+    return (Container) getObject (currentFocusCycleRoots);
+  }
+
+  /**
+   * Retrieve the current focus cycle root, regardless of whether or
+   * not it was made set by a thread in the current {@link
+   * java.lang.ThreadGroup}.
+   *
+   * @return the current focus cycle root
+   * @throws SecurityException if this is not the keyboard focus
+   * manager associated with the current {@link java.lang.ThreadGroup}
+   */
+  protected Container getGlobalCurrentFocusCycleRoot ()
+  {
+    return (Container) getGlobalObject (currentFocusCycleRoots);
+  }
+
+  /**
+   * Set the {@link Container} that will be returned by {@link
+   * #getCurrentFocusCycleRoot} (when it is called from the current
+   * {@link java.lang.ThreadGroup}) and {@link
+   * #getGlobalCurrentFocusCycleRoot}.  This method does not actually
+   * make <code>cycleRoot</code> the current focus cycle root.
+   * 
+   * @param cycleRoot the focus cycle root to return from
+   * getCurrentFocusCycleRoot and getGlobalCurrentFocusCycleRoot
+   */
+  public void setGlobalCurrentFocusCycleRoot (Container cycleRoot)
   {
-    firePropertyChange("currentFocusCycleRoot", focusCycleRoot, cycleRoot);
-    focusCycleRoot = cycleRoot;
+    setGlobalObject (currentFocusCycleRoots, cycleRoot, "currentFocusCycleRoot");
   }
 
   public void addPropertyChangeListener(PropertyChangeListener l)
@@ -484,73 +713,196 @@
     keyEventDispatchers.remove(dispatcher);
   }
 
-  protected List getKeyEventDispatchers()
+  protected List getKeyEventDispatchers ()
   {
-    return (List) keyEventDispatchers.clone();
+    return (List) keyEventDispatchers.clone ();
   }
 
-  public void addKeyEventPostProcessor(KeyEventPostProcessor postProcessor)
+  public void addKeyEventPostProcessor (KeyEventPostProcessor postProcessor)
   {
     if (postProcessor != null)
-      keyEventPostProcessors.add(postProcessor);
+      keyEventPostProcessors.add (postProcessor);
   }
 
-  public void removeKeyEventPostProcessor(KeyEventPostProcessor postProcessor)
+  public void removeKeyEventPostProcessor (KeyEventPostProcessor postProcessor)
   {
-    keyEventPostProcessors.remove(postProcessor);
+    keyEventPostProcessors.remove (postProcessor);
   }
 
-  protected List getKeyEventPostProcessors()
+  protected List getKeyEventPostProcessors ()
   {
-    return (List) keyEventPostProcessors.clone();
+    return (List) keyEventPostProcessors.clone ();
   }
 
-  public abstract boolean dispatchEvent(AWTEvent e);
+  public abstract boolean dispatchEvent (AWTEvent e);
 
-  public final void redispatchEvent(Component target, AWTEvent e)
+  public final void redispatchEvent (Component target, AWTEvent e)
   {
-    throw new Error("not implemented");
+    e.setSource (target);
+    dispatchEvent (e);
   }
 
-  public abstract boolean dispatchKeyEvent(KeyEvent e);
+  public abstract boolean dispatchKeyEvent (KeyEvent e);
 
-  public abstract boolean postProcessKeyEvent(KeyEvent e);
+  public abstract boolean postProcessKeyEvent (KeyEvent e);
 
-  public abstract void processKeyEvent(Component focused, KeyEvent e);
+  public abstract void processKeyEvent (Component focused, KeyEvent e);
 
-  protected abstract void enqueueKeyEvents(long after, Component untilFocused);
+  protected abstract void enqueueKeyEvents (long after, Component untilFocused);
 
-  protected abstract void dequeueKeyEvents(long after, Component untilFocused);
+  protected abstract void dequeueKeyEvents (long after, Component untilFocused);
 
-  protected abstract void discardKeyEvents(Component comp);
+  protected abstract void discardKeyEvents (Component comp);
 
-  public abstract void focusNextComponent(Component comp);
+  public abstract void focusNextComponent (Component comp);
 
-  public abstract void focusPreviousComponent(Component comp);
+  public abstract void focusPreviousComponent (Component comp);
 
-  public abstract void upFocusCycle(Component comp);
+  public abstract void upFocusCycle (Component comp);
 
-  public abstract void downFocusCycle(Container cont);
+  public abstract void downFocusCycle (Container cont);
 
-  public final void focusNextComponent()
+  public final void focusNextComponent ()
   {
-    focusNextComponent(focusOwner);
+    focusNextComponent (null);
   }
 
-  public final void focusPreviousComponent()
+  public final void focusPreviousComponent ()
   {
-    focusPreviousComponent(focusOwner);
+    focusPreviousComponent (null);
   }
 
-  public final void upFocusCycle()
+  public final void upFocusCycle ()
   {
-    upFocusCycle(focusOwner);
+    upFocusCycle (null);
   }
 
-  public final void downFocusCycle()
+  public final void downFocusCycle ()
   {
+    Component focusOwner = getGlobalFocusOwner ();
     if (focusOwner instanceof Container
-        && ((Container) focusOwner).isFocusCycleRoot())
-      downFocusCycle((Container) focusOwner);
+        && ((Container) focusOwner).isFocusCycleRoot ())
+      downFocusCycle ((Container) focusOwner);
+  }
+
+  /**
+   * Retrieve an object from one of the global object {@link
+   * java.util.Map}s, if the object was set by the a thread in the
+   * current {@link java.lang.ThreadGroup}.  Otherwise, return null.
+   *
+   * @param globalMap one of the global object Maps
+   *
+   * @return a global object set by the current ThreadGroup, or null
+   *
+   * @see getFocusOwner
+   * @see getPermanentFocusOwner
+   * @see getFocusedWindow
+   * @see getActiveWindow
+   * @see getCurrentFocusCycleRoot
+   */
+  private Object getObject (Map globalMap)
+  {
+    ThreadGroup currentGroup = Thread.currentThread ().getThreadGroup ();
+    return globalMap.get (currentGroup);
+  }
+
+  /**
+   * Retrieve an object from one of the global object {@link
+   * java.util.Map}s, regardless of whether or not the object was set
+   * by a thread in the current {@link java.lang.ThreadGroup}.
+   *
+   * @param globalMap one of the global object Maps
+   *
+   * @return a global object set by the current ThreadGroup, or null
+   *
+   * @throws SecurityException if this is not the keyboard focus
+   * manager associated with the current {@link java.lang.ThreadGroup}
+   *
+   * @see getGlobalFocusOwner
+   * @see getGlobalPermanentFocusOwner
+   * @see getGlobalFocusedWindow
+   * @see getGlobalActiveWindow
+   * @see getGlobalCurrentFocusCycleRoot
+   */
+  private Object getGlobalObject (Map globalMap)
+  {
+    ThreadGroup currentGroup = Thread.currentThread ().getThreadGroup ();
+    KeyboardFocusManager managerForCallingThread
+      = (KeyboardFocusManager) currentKeyboardFocusManagers.get (currentGroup);
+
+    if (this != managerForCallingThread)
+      throw new SecurityException ("Attempted to retrieve an object from a "
+                                   + "keyboard focus manager that isn't "
+                                   + "associated with the current thread group.");
+
+    synchronized (globalMap)
+      {
+        Collection globalObjects = globalMap.values ();
+        Iterator i = globalObjects.iterator ();
+        Component globalObject;
+
+        while (i.hasNext ())
+          {
+            globalObject = (Component) i.next ();
+            if (globalObject != null)
+              return globalObject;
+          }
+      }
+
+    // No Object was found.
+    return null;
+  }
+
+  /**
+   * Set an object in one of the global object {@link java.util.Map}s,
+   * that will be returned by subsequent calls to getGlobalObject on
+   * the same {@link java.util.Map}.
+   *
+   * @param globalMap one of the global object Maps
+   * @param newObject the object to set
+   * @param property the property that will change
+   *
+   * @see setGlobalFocusOwner
+   * @see setGlobalPermanentFocusOwner
+   * @see setGlobalFocusedWindow
+   * @see setGlobalActiveWindow
+   * @see setGlobalCurrentFocusCycleRoot
+   */
+  private void setGlobalObject (Map globalMap,
+                                Object newObject,
+                                String property)
+  {
+    synchronized (globalMap)
+      {
+        // Save old object.
+        Object oldObject = getGlobalObject (globalMap);
+
+        // Nullify old object.
+        Collection threadGroups = globalMap.keySet ();
+        Iterator i = threadGroups.iterator ();
+        while (i.hasNext ())
+          {
+            ThreadGroup oldThreadGroup = (ThreadGroup) i.next ();
+            if (globalMap.get (oldThreadGroup) != null)
+              {
+                globalMap.put (oldThreadGroup, null);
+                // There should only be one object set at a time, so
+                // we can short circuit.
+                break;
+              }
+          }
+
+        ThreadGroup currentGroup = Thread.currentThread ().getThreadGroup ();
+        firePropertyChange (property, oldObject, newObject);
+        try
+          {
+            fireVetoableChange (property, oldObject, newObject);
+            // Set new object.
+            globalMap.put (currentGroup, newObject);
+          }
+        catch (PropertyVetoException e)
+          {
+          }
+      }
   }
-} // class KeyboardFocusManager
+}
Index: java/awt/Window.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/awt/Window.java,v
retrieving revision 1.32.12.2
diff -u -r1.32.12.2 Window.java
--- java/awt/Window.java	17 Feb 2004 21:26:32 -0000	1.32.12.2
+++ java/awt/Window.java	22 Apr 2004 16:01:10 -0000
@@ -83,6 +83,8 @@
   private transient GraphicsConfiguration graphicsConfiguration;
   private transient AccessibleContext accessibleContext;
 
+  private transient boolean shown;
+
   /** 
    * This (package access) constructor is used by subclasses that want
    * to build windows that do not have parents.  Eg. toplevel
@@ -92,6 +94,9 @@
   Window()
   {
     visible = false;
+    // Windows are the only Containers that default to being focus
+    // cycle roots.
+    focusCycleRoot = true;
     setLayout(new BorderLayout());
   }
 
@@ -242,6 +247,24 @@
     validate();
     super.show();
     toFront();
+
+    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+    manager.setGlobalFocusedWindow (this);
+
+    if (!shown)
+      {
+        FocusTraversalPolicy policy = getFocusTraversalPolicy ();
+        Component initialFocusOwner = null;
+
+        if (policy != null)
+          initialFocusOwner = policy.getInitialComponent (this);
+
+        if (initialFocusOwner != null)
+          initialFocusOwner.requestFocusInWindow (false);
+
+        System.out.println ("GOT INITIAL FOCUS OWNER: " + initialFocusOwner);
+        shown = true;
+      }
   }
 
   public void hide()
@@ -627,9 +650,16 @@
    * @return The component that has focus, or <code>null</code> if no
    * component has focus.
    */
-  public Component getFocusOwner()
+  public Component getFocusOwner ()
   {
-    // FIXME
+    KeyboardFocusManager manager = KeyboardFocusManager.getCurrentKeyboardFocusManager ();
+
+    Window activeWindow = manager.getActiveWindow ();
+
+    // The currently-focused Component belongs to the active Window.
+    if (activeWindow == this)
+      return manager.getFocusOwner ();
+
     return null;
   }
 
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c,v
retrieving revision 1.15.2.3
diff -u -r1.15.2.3 gnu_java_awt_peer_gtk_GtkComponentPeer.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c	26 Mar 2004 20:30:37 -0000	1.15.2.3
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c	22 Apr 2004 16:01:10 -0000
@@ -42,6 +42,12 @@
 
 static GtkWidget *find_fg_color_widget (GtkWidget *widget);
 static GtkWidget *find_bg_color_widget (GtkWidget *widget);
+static gboolean focus_in_cb (GtkWidget *widget,
+                             GdkEventFocus *event,
+                             jobject peer);
+static gboolean focus_out_cb (GtkWidget *widget,
+                              GdkEventFocus *event,
+                              jobject peer);
 
 JNIEXPORT void JNICALL Java_gnu_java_awt_peer_gtk_GtkGenericPeer_dispose
   (JNIEnv *env, jobject obj)
@@ -128,7 +134,7 @@
   gdk_threads_leave ();
 }
 
-JNIEXPORT void JNICALL Java_gnu_java_awt_peer_gtk_GtkComponentPeer_requestFocus
+JNIEXPORT void JNICALL Java_gnu_java_awt_peer_gtk_GtkComponentPeer_gtkWidgetRequestFocus
   (JNIEnv *env, jobject obj)
 {
   void *ptr;
@@ -136,7 +142,59 @@
   ptr = NSA_GET_PTR (env, obj);
   
   gdk_threads_enter ();
-  // gtk_widget_grab_focus (GTK_WIDGET (ptr));
+  gtk_widget_grab_focus (GTK_WIDGET (ptr));
+  gdk_threads_leave ();
+}
+
+/*
+ * Translate a Java KeyEvent object into a GdkEventKey event, then
+ * pass it to the GTK main loop for processing.
+ */
+JNIEXPORT void JNICALL
+Java_gnu_java_awt_peer_gtk_GtkComponentPeer_gtkWidgetDispatchKeyEvent
+  (JNIEnv *env, jobject obj, jint id, jlong when, jint mods,
+   jint keyCode, jchar keyChar, jint keyLocation)
+{
+  void *ptr;
+  GdkEvent *event = gdk_event_new (GDK_MOTION_NOTIFY);
+
+  ptr = NSA_GET_PTR (env, obj);
+
+  // FIXME: need to flesh this out.
+  // Translate
+  if (id == AWT_KEY_PRESSED)
+    event->type = GDK_KEY_PRESS;
+  else if (id == AWT_KEY_RELEASED)
+    event->type = GDK_KEY_RELEASE;
+  else
+    // Don't send AWT KEY_TYPED events to GTK.
+    return;
+
+  // FIXME: this won't work for TextAreas or Lists, which are packed
+  // in GtkScrolledWindows.
+  if (GTK_IS_BUTTON (ptr))
+    event->key.window = GTK_BUTTON (ptr)->event_window;
+  else
+    event->key.window = GTK_WIDGET (ptr)->window;
+
+  event->key.send_event = TRUE;
+
+  event->key.time = (guint32) when;
+  // Translate state
+  event->key.state = 0;
+  // Translate keyval
+  event->key.keyval = keyCode;
+  event->key.length = 1;
+  // Translate keyChar
+  event->key.string = g_strdup ("a");
+  event->key.hardware_keycode = 0;
+  event->key.group = 0;
+
+  gdk_threads_enter ();
+
+  g_printerr ("sending event\n");
+  gtk_main_do_event (event);
+
   gdk_threads_leave ();
 }
 
@@ -775,6 +833,12 @@
   g_signal_connect (GTK_OBJECT (ptr), "event", 
                     G_CALLBACK (pre_event_handler), *gref);
 
+  g_signal_connect (G_OBJECT (ptr), "focus-in-event",
+                    G_CALLBACK (focus_in_cb), *gref);
+
+  g_signal_connect (G_OBJECT (ptr), "focus-out-event",
+                    G_CALLBACK (focus_out_cb), *gref);
+
   gdk_threads_leave ();
 }
 
@@ -813,3 +877,26 @@
   return bg_color_widget;
 }
 
+static gboolean focus_in_cb (GtkWidget *widget,
+                             GdkEventFocus *event,
+                             jobject peer)
+{
+  g_printerr ("            focus in: %p\n", peer);
+  (*gdk_env)->CallVoidMethod (gdk_env, peer,
+                              postFocusEventID,
+                              AWT_FOCUS_GAINED,
+                              JNI_FALSE);
+  return FALSE;
+}
+
+static gboolean focus_out_cb (GtkWidget *widget,
+                              GdkEventFocus *event,
+                              jobject peer)
+{
+  g_printerr ("            focus out: %p\n", peer);
+  (*gdk_env)->CallVoidMethod (gdk_env, peer,
+                              postFocusEventID,
+                              AWT_FOCUS_LOST,
+                              JNI_FALSE);
+  return FALSE;
+}
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c,v
retrieving revision 1.19.2.1
diff -u -r1.19.2.1 gnu_java_awt_peer_gtk_GtkEvents.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c	5 Mar 2004 22:24:50 -0000	1.19.2.1
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c	22 Apr 2004 16:01:10 -0000
@@ -1055,104 +1055,54 @@
           }
       }
       break;
+
     case GDK_FOCUS_CHANGE:
       (*gdk_env)->CallVoidMethod (gdk_env, peer,
 				  postFocusEventID,
-				  (jint) (event->focus_change.in) ? 
+				  (jint) (event->focus_change.in) ?
 				  AWT_FOCUS_GAINED : AWT_FOCUS_LOST,
 				  JNI_FALSE);
       break;
     case GDK_KEY_PRESS:
-    case GDK_KEY_RELEASE:
-      {
-        GdkWindow *obj_window;
-        jobject *focus_obj_ptr = NULL;
-	int generates_key_typed = 0;
-
-        /* A widget with a grab will get key events */
-	if (!GTK_IS_WINDOW (widget))
-	  focus_obj_ptr = &peer;
-	else
-	  {
-            GtkWindow *window;
-
-            /* Check if we have an enabled focused widget in this window.
-	       If not don't handle the event. */
-	    window = GTK_WINDOW (widget);
-	    if (!window->focus_widget
-	        || !GTK_WIDGET_IS_SENSITIVE (window->focus_widget)
-	        || !window->focus_widget->window)
-	      return FALSE;
-	
-            /* TextArea peers are attached to the scrolled window
-               that contains the GtkTextView, not to the text view
-               itself.  Same for List. */
-            if (GTK_IS_TEXT_VIEW (window->focus_widget)
-                || GTK_IS_CLIST (window->focus_widget))
-              {
-                obj_window = gtk_widget_get_parent (window->focus_widget)->window;
-              }
-            else if (GTK_IS_BUTTON (window->focus_widget))
-	      /* GtkButton events go to the "event_window" and this is what
-	         we registered when the button was created. */
-              obj_window = GTK_BUTTON (window->focus_widget)->event_window;
-            else
-              obj_window = window->focus_widget->window;
-
-            gdk_property_get (obj_window,
-                              gdk_atom_intern ("_GNU_GTKAWT_ADDR", FALSE),
-                              gdk_atom_intern ("CARDINAL", FALSE),
-                              0,
-                              sizeof (jobject),
-                              FALSE,
-                              NULL,
-                              NULL,
-                              NULL,
-                              (guchar **)&focus_obj_ptr);
-
-            /* If the window has no jobject attached we can't send anything */
-	    if (!focus_obj_ptr)
-	      return FALSE;
-	      
-	    /* Should we generate an AWT_KEY_TYPED event? */
-	    generates_key_typed = generates_key_typed_event (event, window->focus_widget);
-	  }	
+        if (GTK_IS_WINDOW (widget))
+          {
+            g_print("got key event on widget %s\n", gtk_widget_get_name (widget));
 
-	if (event->type == GDK_KEY_PRESS)	
-	  {
-            (*gdk_env)->CallVoidMethod (gdk_env, *focus_obj_ptr,
-				        postKeyEventID,
-				        (jint) AWT_KEY_PRESSED,
-				        (jlong) event->key.time,
+            (*gdk_env)->CallVoidMethod (gdk_env, peer,
+                                        postKeyEventID,
+                                        (jint) AWT_KEY_PRESSED,
+                                        (jlong) event->key.time,
                                         keyevent_state_to_awt_mods (event),
                                         keysym_to_awt_keycode (event),
                                         keyevent_to_awt_keychar (event),
                                         keysym_to_awt_keylocation (event));
-
-            if (generates_key_typed)
-              {
-                (*gdk_env)->CallVoidMethod (gdk_env, *focus_obj_ptr,
-                                            postKeyEventID,
-                                            (jint) AWT_KEY_TYPED,
-                                            (jlong) event->key.time,
-                                            state_to_awt_mods (event->key.state),
-                                            VK_UNDEFINED,
-                                            keyevent_to_awt_keychar (event),
-                                            AWT_KEY_LOCATION_UNKNOWN);
-              }
+            return TRUE;
           }
-	else /* GDK_KEY_RELEASE */
-          {
-	    (*gdk_env)->CallVoidMethod (gdk_env, *focus_obj_ptr,
-				        postKeyEventID,
-				        (jint) AWT_KEY_RELEASED,
-				        (jlong) event->key.time,
-			                keyevent_state_to_awt_mods (event),
-			                keysym_to_awt_keycode (event),
+        else
+          return FALSE;
+        break;
+    case GDK_KEY_RELEASE:
+      if (GTK_IS_WINDOW (widget))
+        {
+            g_print("got key event on widget %s\n", gtk_widget_get_name (widget));
+
+            (*gdk_env)->CallVoidMethod (gdk_env, peer,
+                                        postKeyEventID,
+                                        (jint) AWT_KEY_RELEASED,
+                                        (jlong) event->key.time,
+                                        keyevent_state_to_awt_mods (event),
+                                        keysym_to_awt_keycode (event),
                                         keyevent_to_awt_keychar (event),
                                         keysym_to_awt_keylocation (event));
-	  }
-      }
+            return TRUE;
+        }
+      else
+        {
+          // We generated this event after Java processed the
+          // corresponding event on the window.
+          if (event->key.send_event)
+            return FALSE;
+        }
       break;
     default:
       break;
Index: jni/gtk-peer/gtkpeer.h
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gtkpeer.h,v
retrieving revision 1.12
diff -u -r1.12 gtkpeer.h
--- jni/gtk-peer/gtkpeer.h	23 Dec 2003 19:24:00 -0000	1.12
+++ jni/gtk-peer/gtkpeer.h	22 Apr 2004 16:01:10 -0000
@@ -361,8 +361,8 @@
 #define VK_ALT_GRAPH 65406
 #define VK_UNDEFINED 0
 
-#define AWT_FOCUS_LOST 1004
-#define AWT_FOCUS_GAINED 1005
+#define AWT_FOCUS_GAINED 1004
+#define AWT_FOCUS_LOST 1005
 
 #define AWT_WINDOW_OPENED 200
 #define AWT_WINDOW_CLOSING 201

--=-ZeG1pJODk3Hy68zUidh5--




From MAILER-DAEMON Thu Apr 22 14:25:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGikS-0001id-P6
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 14:16:32 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGijv-0001ZA-D0
	for classpath@gnu.org; Thu, 22 Apr 2004 14:15:59 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGhHA-0005Fg-BH
	for classpath@gnu.org; Thu, 22 Apr 2004 12:42:43 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BGgq3-0006dj-BK
	for classpath@gnu.org; Thu, 22 Apr 2004 12:14:11 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id 90cf4b4c_9471_11d8_9d29_00304811e8c8_21995;
	Thu, 22 Apr 2004 10:27:28 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i3MFTLeF001095; 
	Thu, 22 Apr 2004 10:29:21 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3MFTGYb001077;
	Thu, 22 Apr 2004 10:29:16 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404221529.i3MFTGYb001077@arch20m.dellroad.org>
In-Reply-To: <1082643565.27234.124.camel@elsschot.wildebeest.org>
To: Mark Wielaard <mark@klomp.org>
Date: Thu, 22 Apr 2004 10:29:16 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: classpath@gnu.org
Subject: Re: 0.09 release target date is next Friday April 30
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 18:16:20 -0000

Mark Wielaard wrote:
>                                  And please send a little ping to the
> mailinglist if you have pending patches that you want to see reviewed
> and go in before the release.

I'd like to request that my VMProcess patch be included:
  http://mail.gnu.org/archive/html/commit-classpath/2004-03/msg00057.html

No one had any comments, and moreover the patch adds functionality
that is otherwise not implemented.

If there are no objections I'll check it in later today or tomorrow.

Thanks,
-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Thu Apr 22 16:40:29 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGkzj-0002Mb-T4
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 16:40:27 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGkzf-0002JF-Mf
	for classpath@gnu.org; Thu, 22 Apr 2004 16:40:23 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGkw3-0000yJ-17
	for classpath@gnu.org; Thu, 22 Apr 2004 16:37:10 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGkns-00072f-VV
	for classpath@gnu.org; Thu, 22 Apr 2004 16:28:13 -0400
Received: from [213.51.128.198] (helo=smtpq3.home.nl)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BGkn3-0003or-1e
	for classpath@gnu.org; Thu, 22 Apr 2004 16:27:21 -0400
Received: from [213.51.128.133] (port=43804 helo=smtp2.home.nl)
	by smtpq3.home.nl with esmtp (Exim 4.30) id 1BGkmt-0003BC-5R
	for classpath@gnu.org; Thu, 22 Apr 2004 22:27:11 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:36330
	helo=dumas.thomas.planescape.com)
	by smtp2.home.nl with esmtp (Exim 4.30) id 1BGkmq-0005Ro-CG
	for classpath@gnu.org; Thu, 22 Apr 2004 22:27:08 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Thu, 22 Apr 2004 22:26:07 +0200
User-Agent: KMail/1.6.2
References: <87oepkqbit.fsf@fleche.redhat.com>
In-Reply-To: <87oepkqbit.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404222226.08375.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 20:40:25 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I personally don't use eclipse; but I've been told the new versions don't=20
support the old config files.
Next to that; should there not be an ant file (build.xml)? That makes=20
importing a breeze and is a lot more standard (i.e. not eclipse minded)

I surely have little to say in this project; but I don't like the idea. It=
=20
makes the project move further away from being usefull for the large=20
public by focussing on one solution that is usefull to only a fraction of=20
the public.

On Thursday 22 April 2004 17:26, Tom Tromey wrote:
> Yesterday I spent a little time setting up Classpath as a project in
> Eclipse.  After some tweaking, I was able to come up with the appended
> patch.  This just adds a couple files that enable Classpath as an
> Eclipse project.
>
> If you try this out, you will have to make a "Configuration.java" by
> hand.  I did this by copying Configuration.java.in and editing the
> result to be valid Java source.  It is probably possible to teach
> Eclipse to run autogen.sh and configure, but I haven't tried this.
>
> I'd like to check this in but thought I'd first see if anybody has
> strong objections to it.  mjw was down on the idea on irc, but I'm
> hoping that was just lack of food :-).
>
> Tom
>
> Index: .classpath
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: .classpath
> diff -N .classpath
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ .classpath 22 Apr 2004 04:49:30 -0000
> @@ -0,0 +1,9 @@
> +<?xml version=3D"1.0" encoding=3D"UTF-8"?>
> +<classpath>
> +    <classpathentry
> +      =20
> excluding=3D"external/jaxp/source/|vm/reference/|compat/|test/|external/ja
>xp/tests/|testsuite/|**/Test.java|**/TestAWT.java|gnu/javax/swing/|**/Sli
>derTest.java" +        kind=3D"src" path=3D""/>
> +    <classpathentry kind=3D"src" path=3D"external/jaxp/source"/>
> +    <classpathentry kind=3D"src" path=3D"vm/reference"/>
> +    <classpathentry kind=3D"output" path=3D"bin"/>
> +</classpath>
> Index: .project
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: .project
> diff -N .project
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ .project 22 Apr 2004 04:49:30 -0000
> @@ -0,0 +1,17 @@
> +<?xml version=3D"1.0" encoding=3D"UTF-8"?>
> +<projectDescription>
> +	<name>classpath</name>
> +	<comment></comment>
> +	<projects>
> +	</projects>
> +	<buildSpec>
> +		<buildCommand>
> +			<name>org.eclipse.jdt.core.javabuilder</name>
> +			<arguments>
> +			</arguments>
> +		</buildCommand>
> +	</buildSpec>
> +	<natures>
> +		<nature>org.eclipse.jdt.core.javanature</nature>
> +	</natures>
> +</projectDescription>
>
>
> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAiCpfCojCW6H2z/QRAutdAKDYvVk8k5OxQPcQFay9yUA0wFPoBgCgp2RW
QtsFwT6Gx+9xqyFYrxBr9SU=3D
=3D+ZfG
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Thu Apr 22 16:49:43 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGl8g-0004vw-Tf
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 16:49:42 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGl8d-0004uQ-1M
	for classpath@gnu.org; Thu, 22 Apr 2004 16:49:39 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGl7z-0004gw-UP
	for classpath@gnu.org; Thu, 22 Apr 2004 16:49:31 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGl5O-0003WF-KY
	for classpath@gnu.org; Thu, 22 Apr 2004 16:46:18 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BGkrD-0004TJ-4a
	for classpath@gnu.org; Thu, 22 Apr 2004 16:31:39 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-93-229.ewetel.net
	[80.228.93.229])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i3MKV1Mo028963;
	Thu, 22 Apr 2004 22:31:02 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BGkqz-0003lb-00; Thu, 22 Apr 2004 22:31:25 +0200
From: Michael Koch <konqueror@gmx.de>
To: Guilhem Lavaux <guilhem@kaffe.org>, classpath@gnu.org
Date: Thu, 22 Apr 2004 22:30:38 +0200
User-Agent: KMail/1.5.4
References: <1082445842.5634.66.camel@localhost>
	<200404201537.41428.konqueror@gmx.de>
In-Reply-To: <200404201537.41428.konqueror@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404222230.38664.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: gnu.java.net.protocol.file.Handler update
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 20:49:40 -0000

Am Dienstag, 20. April 2004 15:37 schrieb Michael Koch:
> Am Dienstag, 20. April 2004 09:24 schrieb Guilhem Lavaux:
> > Hi,
> >
> > Apparently the special parseURL implementation in
> > gnu.java.net.protocol.file.Handler is not required anymore and even
> > broken according to mauve test gnu.testlet.java.net.URL.URLTest. If
> > we replace it using GCJ implementation (attached) 39 failures are
> > fixed and no regression happens. So I suggest to use it directly. I
> > haven't yet tested the URL "file:/d|/test.txt" on windows but on
> > Linux GNU Classpath and JDK gives the same result if we suppress
> > this implementation...
>
> I dont think its a good idea to just remove everything. I have to
> test this later.

I test it with GNU classpath and jamvm and it seems to only solve 
problems and not create new ones, go ahead please and commit.


Michael




From MAILER-DAEMON Thu Apr 22 17:50:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGm5q-0001hn-BQ
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 17:50:50 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGm5n-0001hD-6K
	for classpath@gnu.org; Thu, 22 Apr 2004 17:50:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGm5F-0001ZM-Kn
	for classpath@gnu.org; Thu, 22 Apr 2004 17:50:44 -0400
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGm5E-0001XP-U6
	for classpath@gnu.org; Thu, 22 Apr 2004 17:50:13 -0400
Received: from localhost (localhost [127.0.0.1]) (uid 1000)
	by tangency.co.uk with local; Thu, 22 Apr 2004 22:44:01 +0100
Date: Thu, 22 Apr 2004 22:44:01 +0100
From: "S. Meslin-Weber" <twiun@adorphuye.com>
To: Thomas Zander <zander@javalobby.org>
Message-ID: <20040422214401.GA28277@tangency.co.uk>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<200404222226.08375.zander@javalobby.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <200404222226.08375.zander@javalobby.org>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Cc: classpath@gnu.org
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 21:50:47 -0000

Hi Thomas, Tom,

I personally do use eclipse, both with just project files and ant scripts.
I have found that both have problems.

I don't believe that Tom would suggest using these project files as the
sole means of building GNU Classpath, only as a means to start people off
using Eclipse for development. One of the complaints commonly voiced by
those wishing to join any OSS development project is the relatively high
setup cost; this would make entry easier.

With the possibility of starting to deal with the native code in GNU
Classpath in Eclipse and with the associated navigation, refactoring tools
and gdb makes Eclipse as a development tool - not sole build tool - a very
attractive proposition. I use Eclipse for developing Odonata[1] and am
very happy with it.

If somebody wishes to put forward an ANT build.xml for inclusion into
the GNU Classpath I would support them for the same reasons: they make
starting to participate in the project easier.

Thanks,

Stephane

[1] Odonata AWT peers, http://odonata.tangency.co.uk



From MAILER-DAEMON Thu Apr 22 18:47:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGmyc-0003Pl-TK
	for mharc-classpath@gnu.org; Thu, 22 Apr 2004 18:47:26 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGmyZ-0003On-4V
	for classpath@gnu.org; Thu, 22 Apr 2004 18:47:23 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGmy2-0003Eq-9u
	for classpath@gnu.org; Thu, 22 Apr 2004 18:47:22 -0400
Received: from [207.189.223.52] (helo=email3.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGmx4-0002qg-QP
	for classpath@gnu.org; Thu, 22 Apr 2004 18:45:50 -0400
Received: (qmail 29321 invoked from network); 22 Apr 2004 23:04:07 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email3.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <twiun@adorphuye.com>; 22 Apr 2004 23:04:07 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id EEB0A4F853E; Thu, 22 Apr 2004 16:34:21 -0600 (MDT)
To: "S. Meslin-Weber" <twiun@adorphuye.com>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<200404222226.08375.zander@javalobby.org>
	<20040422214401.GA28277@tangency.co.uk>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Let's send the Russians defective lifestyle accessories!
Date: 22 Apr 2004 16:33:52 -0600
In-Reply-To: <20040422214401.GA28277@tangency.co.uk>
Message-ID: <87n053prqn.fsf@fleche.redhat.com>
Lines: 17
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 22:47:23 -0000

>>>>> "Stephane" == S Meslin-Weber <twiun@adorphuye.com> writes:

Stephane> I don't believe that Tom would suggest using these project
Stephane> files as the sole means of building GNU Classpath, only as a
Stephane> means to start people off using Eclipse for development.

Yeah, sorry if that wasn't clear.

I'm not proposing we change the build system or anything like that,
just that we add these two files to make it a bit easier for folks who
want to use Eclipse.

It might also be nice to add a file like
"eclipse/gnu/classpath/Configuration.java", that is only used by
Eclipse builds, but I'm not sure and I'd prefer to hold off on this.

Tom



From MAILER-DAEMON Fri Apr 23 04:20:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGvqR-0001th-Pa
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 04:15:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGvqG-0001T2-1i
	for classpath@gnu.org; Fri, 23 Apr 2004 04:15:24 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGvpU-0008SC-5V
	for classpath@gnu.org; Fri, 23 Apr 2004 04:15:10 -0400
Received: from [213.228.0.44] (helo=postfix3-1.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGvp0-0007lr-EB
	for classpath@gnu.org; Fri, 23 Apr 2004 04:14:06 -0400
Received: from 192.168.1.247 (lns-p19-7-81-56-169-129.adsl.proxad.net
	[81.56.169.129]) by postfix3-1.free.fr (Postfix) with ESMTP
	id C339DC4146; Fri, 23 Apr 2004 10:14:04 +0200 (CEST)
From: Guilhem Lavaux <guilhem@kaffe.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404222230.38664.konqueror@gmx.de>
References: <1082445842.5634.66.camel@localhost>
	<200404201537.41428.konqueror@gmx.de>
	<200404222230.38664.konqueror@gmx.de>
Content-Type: text/plain
Message-Id: <1082708041.3299.17.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4-8mdk 
Date: Fri, 23 Apr 2004 10:14:01 +0200
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: gnu.java.net.protocol.file.Handler update
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 08:15:33 -0000

On Thu, 2004-04-22 at 22:30, Michael Koch wrote:
> Am Dienstag, 20. April 2004 15:37 schrieb Michael Koch:
> > Am Dienstag, 20. April 2004 09:24 schrieb Guilhem Lavaux:
> > > Hi,
> > >
> > > Apparently the special parseURL implementation in
> > > gnu.java.net.protocol.file.Handler is not required anymore and even
> > > broken according to mauve test gnu.testlet.java.net.URL.URLTest. If
> > > we replace it using GCJ implementation (attached) 39 failures are
> > > fixed and no regression happens. So I suggest to use it directly. I
> > > haven't yet tested the URL "file:/d|/test.txt" on windows but on
> > > Linux GNU Classpath and JDK gives the same result if we suppress
> > > this implementation...
> >
> > I dont think its a good idea to just remove everything. I have to
> > test this later.
> 
> I test it with GNU classpath and jamvm and it seems to only solve 
> problems and not create new ones, go ahead please and commit.
> 
> 

Thanks ! I have checked in the file. I have removed some of the comments
as they are not meaningful and just confuses us.

Cheers,
Guilhem.




From MAILER-DAEMON Fri Apr 23 04:33:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGw87-0001oD-3s
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 04:33:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGw84-0001nB-IP
	for classpath@gnu.org; Fri, 23 Apr 2004 04:33:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGw7Y-0001bn-MV
	for classpath@gnu.org; Fri, 23 Apr 2004 04:33:47 -0400
Received: from [195.18.123.2] (helo=kiev.dev.factotummedia.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGw7Y-0001bV-5Y
	for classpath@gnu.org; Fri, 23 Apr 2004 04:33:16 -0400
Received: from amavis by kiev.dev.factotummedia.nl with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BGw7X-0006BK-00
	for <classpath@gnu.org>; Fri, 23 Apr 2004 10:33:15 +0200
Received: from kiev.dev.factotummedia.nl ([127.0.0.1])
	by localhost (kiev [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
	id 23644-02 for <classpath@gnu.org>;
	Fri, 23 Apr 2004 10:33:15 +0200 (CEST)
Received: from pc-thomas.dev.factotummedia.nl ([192.168.3.104])
	by kiev.dev.factotummedia.nl with esmtp (Exim 3.35 #1 (Debian))
	id 1BGw7X-0006BD-00
	for <classpath@gnu.org>; Fri, 23 Apr 2004 10:33:15 +0200
From: Thomas <zander@javalobby.org>
To: classpath@gnu.org
Date: Fri, 23 Apr 2004 10:33:57 +0200
User-Agent: KMail/1.6.2
References: <87oepkqbit.fsf@fleche.redhat.com>
	<200404222226.08375.zander@javalobby.org>
	<20040422214401.GA28277@tangency.co.uk>
In-Reply-To: <20040422214401.GA28277@tangency.co.uk>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404231034.02980.zander@javalobby.org>
X-Virus-Scanned: by amavisd-new (Debian) at dev.factotummedia.nl
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 08:33:49 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 22 April 2004 23:44, S. Meslin-Weber wrote:
> Hi Thomas, Tom,
>
> I personally do use eclipse, both with just project files and ant scripts.
> I have found that both have problems.

As one collegue does use Eclipse (on Windows even) I write most ant files i=
n=20
such a way that they do work.
At least for us...

> I don't believe that Tom would suggest using these project files as the
> sole means of building GNU Classpath, only as a means to start people off
> using Eclipse for development. One of the complaints commonly voiced by
> those wishing to join any OSS development project is the relatively high
> setup cost; this would make entry easier.

I noticed that; but the point is more towards maintainance; someone needs t=
o=20
maintain the file. This in itself is not too much of a problem, but if you=
=20
account for the fact that we need a couple of other build-systems to reach=
=20
the goal of lowering setup cost, the one-base-covers-all aprouch of an ant=
=20
build file is a lot cheaper in the long run.
There is nothing worse then a badly maintained build file; even not having =
one=20
in the first place.

I never build classpath before; the challenge to get it compiling delayed i=
t=20
somewhat.  If someone can build an ant file that works (even just in concep=
t)=20
then I'm certainly willing to look at fixing any portability problems.

=2D --=20
Regards
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAiNT5CojCW6H2z/QRAnkDAJoDDdyV2xBUtusQyh3RYfl4XArtEwCfQzPa
VttT6//RNGWdeu6iUojr5Hk=3D
=3DPwAe
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Fri Apr 23 04:43:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGwHk-0004VI-Ax
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 04:43:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGwHh-0004V1-Ki
	for classpath@gnu.org; Fri, 23 Apr 2004 04:43:45 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGwHB-0004EK-7S
	for classpath@gnu.org; Fri, 23 Apr 2004 04:43:44 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGwHA-0004Dw-Fa
	for classpath@gnu.org; Fri, 23 Apr 2004 04:43:12 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-204.ewetel.net
	[80.228.95.204])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i3N8h6nV028365;
	Fri, 23 Apr 2004 10:43:08 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BGwHS-0000re-00; Fri, 23 Apr 2004 10:43:30 +0200
From: Michael Koch <konqueror@gmx.de>
To: Thomas <zander@javalobby.org>, classpath@gnu.org
Date: Fri, 23 Apr 2004 10:42:42 +0200
User-Agent: KMail/1.5.4
References: <87oepkqbit.fsf@fleche.redhat.com>
	<20040422214401.GA28277@tangency.co.uk>
	<200404231034.02980.zander@javalobby.org>
In-Reply-To: <200404231034.02980.zander@javalobby.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404231042.42869.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 08:43:46 -0000

Am Freitag, 23. April 2004 10:33 schrieb Thomas:
> On Thursday 22 April 2004 23:44, S. Meslin-Weber wrote:
> > Hi Thomas, Tom,
> >
> > I personally do use eclipse, both with just project files and ant
> > scripts. I have found that both have problems.
>
> As one collegue does use Eclipse (on Windows even) I write most ant
> files in such a way that they do work.
> At least for us...
>
> > I don't believe that Tom would suggest using these project files as
> > the sole means of building GNU Classpath, only as a means to start
> > people off using Eclipse for development. One of the complaints
> > commonly voiced by those wishing to join any OSS development
> > project is the relatively high setup cost; this would make entry
> > easier.
>
> I noticed that; but the point is more towards maintainance; someone
> needs to maintain the file. This in itself is not too much of a
> problem, but if you account for the fact that we need a couple of
> other build-systems to reach the goal of lowering setup cost, the
> one-base-covers-all aprouch of an ant build file is a lot cheaper in
> the long run.
> There is nothing worse then a badly maintained build file; even not
> having one in the first place.
>
> I never build classpath before; the challenge to get it compiling
> delayed it somewhat.  If someone can build an ant file that works
> (even just in concept) then I'm certainly willing to look at fixing
> any portability problems.

I'm not sure its possible at all to build whole Classpath with ant. Does 
ant handle building native libraries ? automake/autoconf/libtool does 
all we need in a portable manner. I dont understand why you bitch it.


Michael




From MAILER-DAEMON Fri Apr 23 04:53:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGwR6-00087f-Lq
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 04:53:28 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGwR2-00086l-6v
	for classpath@gnu.org; Fri, 23 Apr 2004 04:53:24 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGwQQ-00081K-De
	for classpath@gnu.org; Fri, 23 Apr 2004 04:53:17 -0400
Received: from [212.6.122.105] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGwQN-00080g-Lu
	for classpath@gnu.org; Fri, 23 Apr 2004 04:52:43 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-204.ewetel.net
	[80.228.95.204])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i3N8qXR7010346;
	Fri, 23 Apr 2004 10:52:34 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BGwQe-0000sB-00; Fri, 23 Apr 2004 10:53:00 +0200
From: Michael Koch <konqueror@gmx.de>
To: tromey@redhat.com, GNU Classpath Project <classpath@gnu.org>
Date: Fri, 23 Apr 2004 10:52:13 +0200
User-Agent: KMail/1.5.4
References: <87oepkqbit.fsf@fleche.redhat.com>
In-Reply-To: <87oepkqbit.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404231052.13157.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 08:53:25 -0000

Am Donnerstag, 22. April 2004 17:26 schrieb Tom Tromey:
> Yesterday I spent a little time setting up Classpath as a project in
> Eclipse.  After some tweaking, I was able to come up with the
> appended patch.  This just adds a couple files that enable Classpath
> as an Eclipse project.
>
> If you try this out, you will have to make a "Configuration.java" by
> hand.  I did this by copying Configuration.java.in and editing the
> result to be valid Java source.  It is probably possible to teach
> Eclipse to run autogen.sh and configure, but I haven't tried this.
>
> I'd like to check this in but thought I'd first see if anybody has
> strong objections to it.  mjw was down on the idea on irc, but I'm
> hoping that was just lack of food :-).

Are there some mroe instructions on how to use these files ?
I suppose I need to create a new project and then put these files into 
it and restart eclipse. Havent tried it yet.


Michael




From MAILER-DAEMON Fri Apr 23 05:03:46 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGwb3-0005hn-M5
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 05:03:45 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGwaz-0005g6-Tp
	for classpath@gnu.org; Fri, 23 Apr 2004 05:03:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGwaT-0005ae-24
	for classpath@gnu.org; Fri, 23 Apr 2004 05:03:40 -0400
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGwaS-0005Zq-Ly
	for classpath@gnu.org; Fri, 23 Apr 2004 05:03:08 -0400
Received: from localhost (localhost [127.0.0.1]) (uid 1000)
	by tangency.co.uk with local; Fri, 23 Apr 2004 09:57:01 +0100
Date: Fri, 23 Apr 2004 09:57:01 +0100
From: "S. Meslin-Weber" <twiun@adorphuye.com>
To: Michael Koch <konqueror@gmx.de>
Message-ID: <20040423085701.GC28277@tangency.co.uk>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<20040422214401.GA28277@tangency.co.uk>
	<200404231034.02980.zander@javalobby.org>
	<200404231042.42869.konqueror@gmx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <200404231042.42869.konqueror@gmx.de>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 09:03:42 -0000

Without getting heated about things, it may just be simpler to create a
'contrib' directory for files such as this - allowing those that use
them to maintain them but also showing they're not part of the
mainstream build path.

Cheers,

Stephane



From MAILER-DAEMON Fri Apr 23 05:07:47 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGwew-0000fx-Ot
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 05:07:46 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGweu-0000fE-1f
	for classpath@gnu.org; Fri, 23 Apr 2004 05:07:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGweN-0000Pp-Ab
	for classpath@gnu.org; Fri, 23 Apr 2004 05:07:43 -0400
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGwdc-0008Qd-5A
	for classpath@gnu.org; Fri, 23 Apr 2004 05:06:24 -0400
Received: from localhost (localhost [127.0.0.1]) (uid 1000)
	by tangency.co.uk with local; Fri, 23 Apr 2004 09:54:56 +0100
Date: Fri, 23 Apr 2004 09:54:56 +0100
From: "S. Meslin-Weber" <twiun@adorphuye.com>
To: Michael Koch <konqueror@gmx.de>
Message-ID: <20040423085455.GB28277@tangency.co.uk>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<200404231052.13157.konqueror@gmx.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <200404231052.13157.konqueror@gmx.de>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Cc: GNU Classpath Project <classpath@gnu.org>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 09:07:45 -0000

On Fri, Apr 23, 2004 at 10:52:13AM +0200, Michael Koch wrote:
> Are there some mroe instructions on how to use these files ?
> I suppose I need to create a new project and then put these files into 
> it and restart eclipse. Havent tried it yet.

Although you could do that, it would just be simpler to just check out
the Classpath from cvs using Eclipse - it would then pick up the project
files.

You can also checkout from cvs manually into a directory and use
Eclipe's import feature to import the project.

Cheers,

Steph



From MAILER-DAEMON Fri Apr 23 05:19:30 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGwqI-0003jS-9Z
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 05:19:30 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGwqF-0003iU-9u
	for classpath@gnu.org; Fri, 23 Apr 2004 05:19:27 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGwpi-0003WC-Dl
	for classpath@gnu.org; Fri, 23 Apr 2004 05:19:25 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BGwpi-0003W4-49
	for classpath@gnu.org; Fri, 23 Apr 2004 05:18:54 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BGwo4-0004Gh-EN
	for classpath@gnu.org; Fri, 23 Apr 2004 05:17:12 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BGwnr-0003Yo-00; Fri, 23 Apr 2004 11:16:59 +0200
From: Mark Wielaard <mark@klomp.org>
To: tromey@redhat.com
In-Reply-To: <87oepkqbit.fsf@fleche.redhat.com>
References: <87oepkqbit.fsf@fleche.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-dS6P8dL7uIGYhl7D1Vy7"
Message-Id: <1082711821.27234.238.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Fri, 23 Apr 2004 11:17:01 +0200
Cc: GNU Classpath Project <classpath@gnu.org>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 09:19:27 -0000


--=-dS6P8dL7uIGYhl7D1Vy7
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2004-04-22 at 17:26, Tom Tromey wrote:
> Yesterday I spent a little time setting up Classpath as a project in
> Eclipse.  After some tweaking, I was able to come up with the appended
> patch.  This just adds a couple files that enable Classpath as an
> Eclipse project.
>=20
> If you try this out, you will have to make a "Configuration.java" by
> hand.  I did this by copying Configuration.java.in and editing the
> result to be valid Java source.  It is probably possible to teach
> Eclipse to run autogen.sh and configure, but I haven't tried this.
>=20
> I'd like to check this in but thought I'd first see if anybody has
> strong objections to it.  mjw was down on the idea on irc, but I'm
> hoping that was just lack of food :-).

It was not just lack of food. But eating something did make me happier!

There are a couple of things that I am worried about:
- Having large and/or binary blobs in CVS for particular editors/IDEs.
  (This seems a non-issue now that I have seen the actual files.)
- Having multiple build systems were we have enough maintenance work
  with the current one. And I don't think Eclipse is powerful enough to
  support our build setup needs. Also Eclipse (or Ant, or whatever java
  based build system) does make bootstrapping GNU Classpath much harder.
  So it will never be a real solution for our build setup.
  (That said, I see this is mostly a simple editor/IDE helper file and
   not something that even tries to replace the current build system.)
- Pretending we support Eclipse which is arguably non-free since people
  are not testing, running and developing it with free runtimes.
  (You claim adding this might make this happen sooner. I do hope so.)

If you can show me some people that run Eclipse in a free environment
that are actually happy with using your setup files than I am all for
including them. But you must promise to maintain them. The only hard
part seem to come up with the list of "classpaths" and the "exclusion
list", which is done by hand in our normal build system also.

Cheers,

Mark

--=-dS6P8dL7uIGYhl7D1Vy7
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAiN8MxVhZCJWr9QwRAtkRAJ91pqDeS42xPWUGoI6mGkTF6+mgoQCgjQBy
QV+MVK57kNQvZUaFTzrZ0V0=
=2JIS
-----END PGP SIGNATURE-----

--=-dS6P8dL7uIGYhl7D1Vy7--




From MAILER-DAEMON Fri Apr 23 06:24:33 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGxrE-0002hP-Tv
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 06:24:32 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGxr5-0002gB-TG
	for classpath@gnu.org; Fri, 23 Apr 2004 06:24:23 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGxqX-0002Tl-SX
	for classpath@gnu.org; Fri, 23 Apr 2004 06:24:21 -0400
Received: from [213.228.0.169] (helo=postfix3-2.free.fr)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGxk7-0001Fd-2C
	for classpath@gnu.org; Fri, 23 Apr 2004 06:17:11 -0400
Received: from 192.168.1.247 (lns-p19-7-81-56-169-129.adsl.proxad.net
	[81.56.169.129])
	by postfix3-2.free.fr (Postfix) with ESMTP id CF35DC1F0
	for <classpath@gnu.org>; Fri, 23 Apr 2004 12:17:08 +0200 (CEST)
From: Guilhem Lavaux <guilhem@kaffe.org>
To: classpath@gnu.org
Content-Type: multipart/mixed; boundary="=-ge9MLShy1twQQzZ2LeQt"
Message-Id: <1082715425.3307.46.camel@localhost>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4-8mdk 
Date: Fri, 23 Apr 2004 12:17:05 +0200
Subject: gnu.java.net.protocol.file.Handler again (and java.net.URL)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 10:24:30 -0000


--=-ge9MLShy1twQQzZ2LeQt
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,

I was trying to support the platforms who are not supporting ftp
protocol when I have found that setURL has a different behaviour in the
JDK. If the given protocol does not exist it just ignores it and keep
the previous one. This gives us the possibility to call setURL without
any problems on all platforms now.

ChangeLog entry:
2004-04-23  Guilhem Lavaux <guilhem@kaffe.org>
 
        * gnu/java/net/protocol/file/Handler.java
        (parseURL): Added a comment on ftp implementation in GNU
Classpath.
 
        * java/net/URL.java
        (set): This method now matches the behaviour of the JDK.
 

Cheers,

Guilhem.

--=-ge9MLShy1twQQzZ2LeQt
Content-Disposition: attachment; filename=url_patch
Content-Type: text/x-patch; name=url_patch; charset=
Content-Transfer-Encoding: 7bit

Index: gnu/java/net/protocol/file/Handler.java
===================================================================
RCS file: /cvsroot/classpath/classpath/gnu/java/net/protocol/file/Handler.java,v
retrieving revision 1.15
diff -u -r1.15 Handler.java
--- gnu/java/net/protocol/file/Handler.java	23 Apr 2004 06:44:08 -0000	1.15
+++ gnu/java/net/protocol/file/Handler.java	23 Apr 2004 10:00:40 -0000
@@ -79,8 +79,11 @@
 	// Reset the protocol (and implicitly the handler) for this URL.
 	// Then have the URL attempt the connection again, as it will
 	// get the changed handler the next time around.
+	// N.B.: FTP protocol is not supported by default in GNU Classpath
+	// but it does not matter because setURL will keep the current protocol
+	// if "ftp" is not available.
 	setURL (url, "ftp", url.getHost(), url.getPort(), url.getFile(),
-		url.getRef());
+	        url.getRef());
 	return url.openConnection();
       }
 
Index: java/net/URL.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/net/URL.java,v
retrieving revision 1.27
diff -u -r1.27 URL.java
--- java/net/URL.java	20 Apr 2004 16:29:11 -0000	1.27
+++ java/net/URL.java	23 Apr 2004 10:00:41 -0000
@@ -121,7 +121,7 @@
 public final class URL implements Serializable
 {
   private static final String DEFAULT_SEARCH_PATH =
-    "gnu.java.net.protocol|sun.net.www.protocol";
+    "gnu.java.net.protocol|gnu.inet|sun.net.www.protocol";
 
   /**
    * The name of the protocol for this URL.
@@ -684,7 +684,8 @@
    * Sets the specified fields of the URL. This is not a public method so
    * that only URLStreamHandlers can modify URL fields. This might be called
    * by the <code>parseURL()</code> method in that class. URLs are otherwise
-   * constant.
+   * constant. If the given protocol does not exist, it will keep the previously
+   * set protocol.
    *
    * @param protocol The protocol name for this URL
    * @param host The hostname or IP address for this URL
@@ -695,12 +696,15 @@
   protected void set(String protocol, String host, int port, String file,
                      String ref)
   {
-    // TBD: Theoretically, a poorly written StreamHandler could pass an
-    // invalid protocol.  It will cause the handler to be set to null
-    // thus overriding a valid handler.  Callers of this method should
-    // be aware of this.
-    this.ph = getURLStreamHandler(protocol);
-    this.protocol = protocol.toLowerCase();
+    URLStreamHandler protocolHandler = getURLStreamHandler(protocol);
+    
+    // It is an hidden feature of the JDK. If the protocol does not exist,
+    // we keep the previously initialized protocol.
+    if (protocolHandler != null)
+      {
+        this.ph = protocolHandler;
+        this.protocol = protocol.toLowerCase();
+      }
     this.authority = "";
     this.port = port;
     this.host = host;
@@ -718,7 +722,8 @@
   /**
    * Sets the specified fields of the URL. This is not a public method so
    * that only URLStreamHandlers can modify URL fields. URLs are otherwise
-   * constant.
+   * constant. If the given protocol does not exist, it will keep the previously
+   * set protocol.
    *
    * @param protocol The protocol name for this URL.
    * @param host The hostname or IP address for this URL.
@@ -734,12 +739,15 @@
   protected void set(String protocol, String host, int port, String authority,
                      String userInfo, String path, String query, String ref)
   {
-    // TBD: Theoretically, a poorly written StreamHandler could pass an
-    // invalid protocol.  It will cause the handler to be set to null
-    // thus overriding a valid handler.  Callers of this method should
-    // be aware of this.
-    this.ph = getURLStreamHandler(protocol);
-    this.protocol = protocol.toLowerCase();
+    URLStreamHandler protocolHandler = getURLStreamHandler(protocol);
+    
+    // It is an hidden feature of the JDK. If the protocol does not exist,
+    // we keep the previously initialized protocol.
+    if (protocolHandler != null)
+      {
+        this.ph = protocolHandler;
+        this.protocol = protocol.toLowerCase();
+      }
     this.host = host;
     this.userInfo = userInfo;
     this.port = port;

--=-ge9MLShy1twQQzZ2LeQt--




From MAILER-DAEMON Fri Apr 23 06:59:44 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGyPH-0001Do-M9
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 06:59:43 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGyJv-0008Up-Uo
	for classpath@gnu.org; Fri, 23 Apr 2004 06:54:11 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGyHp-0007Zq-Fv
	for classpath@gnu.org; Fri, 23 Apr 2004 06:52:32 -0400
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGyHh-0007TV-M7
	for classpath@gnu.org; Fri, 23 Apr 2004 06:51:53 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-204.ewetel.net
	[80.228.95.204])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id i3NApKpc027055;
	Fri, 23 Apr 2004 12:51:21 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BGyHb-00019K-00; Fri, 23 Apr 2004 12:51:47 +0200
From: Michael Koch <konqueror@gmx.de>
To: Guilhem Lavaux <guilhem@kaffe.org>, classpath@gnu.org
Date: Fri, 23 Apr 2004 12:50:58 +0200
User-Agent: KMail/1.5.4
References: <1082715425.3307.46.camel@localhost>
In-Reply-To: <1082715425.3307.46.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404231250.59041.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: gnu.java.net.protocol.file.Handler again (and java.net.URL)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 10:59:40 -0000

Am Freitag, 23. April 2004 12:17 schrieb Guilhem Lavaux:
> Hi,
>
> I was trying to support the platforms who are not supporting ftp
> protocol when I have found that setURL has a different behaviour in
> the JDK. If the given protocol does not exist it just ignores it and
> keep the previous one. This gives us the possibility to call setURL
> without any problems on all platforms now.
>
> ChangeLog entry:
> 2004-04-23  Guilhem Lavaux <guilhem@kaffe.org>
>
>         * gnu/java/net/protocol/file/Handler.java
>         (parseURL): Added a comment on ftp implementation in GNU
> Classpath.
>
>         * java/net/URL.java
>         (set): This method now matches the behaviour of the JDK.

Okay.

We agreed some time ago to not support "sun.net.www.protocol".
Can you remove this totally from the search path ?


Michael




From MAILER-DAEMON Fri Apr 23 08:14:17 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BGzZQ-0006tP-W8
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 08:14:16 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BGzZJ-0006qX-F8
	for classpath@gnu.org; Fri, 23 Apr 2004 08:14:09 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BGzZD-0006lX-Vr
	for classpath@gnu.org; Fri, 23 Apr 2004 08:14:05 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BGzBc-0002hp-C8
	for classpath@gnu.org; Fri, 23 Apr 2004 07:49:40 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BGzBX-0003yr-00; Fri, 23 Apr 2004 13:49:35 +0200
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-VDqvckOtgtKmddavi4Tw"
Message-Id: <1082720977.27234.244.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Fri, 23 Apr 2004 13:49:37 +0200
Cc: Michael Koch <konqueror@gmx.de>
Subject: Using JamVM-1.1.3 with GNU Classpath CVS (pre-0.09)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 12:14:11 -0000


--=-VDqvckOtgtKmddavi4Tw
Content-Type: multipart/mixed; boundary="=-thoRkjyB/B/fI+sffBph"


--=-thoRkjyB/B/fI+sffBph
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

For those that want to test GNU Classpath CVS and use jamvm-1.1.3 you
will now need the following patch to get the new Class/VMClass setup
working.

Make sure you delete your old installation the lib/classes.tar in your
jamvm build dir.

If you want to test the new Process/VMProcess implementation you will
also need the attached VMRuntime patch.

Cheers,

Mark

--=-thoRkjyB/B/fI+sffBph
Content-Disposition: attachment; filename=jamvm-class.patch
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name=jamvm-class.patch; charset=ISO-8859-1

QmluYXJ5IGZpbGVzIGphbXZtLTEuMS4zL2xpYi9jbGFzc2VzLnRhciBhbmQgL2hvbWUvbWFyay9z
cmMvamFtdm0tMS4xLjMvbGliL2NsYXNzZXMudGFyIGRpZmZlcg0KZGlmZiAtdU5yIGphbXZtLTEu
MS4zL2xpYi9qYXZhL2lvL1ZNT2JqZWN0U3RyZWFtQ2xhc3MuamF2YSAvaG9tZS9tYXJrL3NyYy9q
YW12bS0xLjEuMy9saWIvamF2YS9pby9WTU9iamVjdFN0cmVhbUNsYXNzLmphdmENCi0tLSBqYW12
bS0xLjEuMy9saWIvamF2YS9pby9WTU9iamVjdFN0cmVhbUNsYXNzLmphdmEJMjAwNC0wNC0xMiAy
Mzo0NDo0OS4wMDAwMDAwMDAgKzAyMDANCisrKyAvaG9tZS9tYXJrL3NyYy9qYW12bS0xLjEuMy9s
aWIvamF2YS9pby9WTU9iamVjdFN0cmVhbUNsYXNzLmphdmEJMTk3MC0wMS0wMSAwMTowMDowMC4w
MDAwMDAwMDAgKzAxMDANCkBAIC0xLDI0ICswLDAgQEANCi0vKg0KLSAgVk1PYmplY3RTdHJlYW1D
bGFzcy5qYXZhIC0tIGphbXZtICh3b3JrYXJvdW5kcykgZm9yIChWTSlPYmplY3RTdHJlYW1DbGFz
cy4NCi0qLw0KLQ0KLXBhY2thZ2UgamF2YS5pbzsNCi0NCi1pbXBvcnQgamF2YS5sYW5nLnJlZmxl
Y3QuRmllbGQ7DQotDQotZmluYWwgY2xhc3MgVk1PYmplY3RTdHJlYW1DbGFzcw0KLXsNCi0gIHN0
YXRpYyBib29sZWFuIGhhc0NsYXNzSW5pdGlhbGl6ZXIgKENsYXNzIGNsYXp6KSB7DQotICAgIHJl
dHVybiBWTUNsYXNzLmhhc0NsYXNzSW5pdGlhbGl6ZXIoY2xhenopOw0KLSAgfQ0KLQ0KLSAgc3Rh
dGljIG5hdGl2ZSB2b2lkIHNldERvdWJsZU5hdGl2ZShGaWVsZCBmaWVsZCwgT2JqZWN0IG9iaiwg
ZG91YmxlIHZhbCk7DQotICBzdGF0aWMgbmF0aXZlIHZvaWQgc2V0RmxvYXROYXRpdmUoRmllbGQg
ZmllbGQsIE9iamVjdCBvYmosIGZsb2F0IHZhbCk7DQotICBzdGF0aWMgbmF0aXZlIHZvaWQgc2V0
TG9uZ05hdGl2ZShGaWVsZCBmaWVsZCwgT2JqZWN0IG9iaiwgbG9uZyB2YWwpOw0KLSAgc3RhdGlj
IG5hdGl2ZSB2b2lkIHNldEludE5hdGl2ZShGaWVsZCBmaWVsZCwgT2JqZWN0IG9iaiwgaW50IHZh
bCk7DQotICBzdGF0aWMgbmF0aXZlIHZvaWQgc2V0U2hvcnROYXRpdmUoRmllbGQgZmllbGQsIE9i
amVjdCBvYmosIHNob3J0IHZhbCk7DQotICBzdGF0aWMgbmF0aXZlIHZvaWQgc2V0Q2hhck5hdGl2
ZShGaWVsZCBmaWVsZCwgT2JqZWN0IG9iaiwgY2hhciB2YWwpOw0KLSAgc3RhdGljIG5hdGl2ZSB2
b2lkIHNldEJ5dGVOYXRpdmUoRmllbGQgZmllbGQsIE9iamVjdCBvYmosIGJ5dGUgdmFsKTsNCi0g
IHN0YXRpYyBuYXRpdmUgdm9pZCBzZXRCb29sZWFuTmF0aXZlKEZpZWxkIGZpZWxkLCBPYmplY3Qg
b2JqLCBib29sZWFuIHZhbCk7DQotICBzdGF0aWMgbmF0aXZlIHZvaWQgc2V0T2JqZWN0TmF0aXZl
KEZpZWxkIGZpZWxkLCBPYmplY3Qgb2JqLCBPYmplY3QgdmFsKTsNCi19DQpkaWZmIC11TnIgamFt
dm0tMS4xLjMvbGliL2phdmEvbGFuZy9WTUNsYXNzLmphdmEgL2hvbWUvbWFyay9zcmMvamFtdm0t
MS4xLjMvbGliL2phdmEvbGFuZy9WTUNsYXNzLmphdmENCi0tLSBqYW12bS0xLjEuMy9saWIvamF2
YS9sYW5nL1ZNQ2xhc3MuamF2YQkyMDA0LTAzLTI1IDA2OjUxOjQ1LjAwMDAwMDAwMCArMDEwMA0K
KysrIC9ob21lL21hcmsvc3JjL2phbXZtLTEuMS4zL2xpYi9qYXZhL2xhbmcvVk1DbGFzcy5qYXZh
CTIwMDQtMDQtMjMgMTM6MzY6NDMuMDAwMDAwMDAwICswMjAwDQpAQCAtNDYsOSArNDYsMTAgQEAN
CiANCiBpbXBvcnQgamF2YS5sYW5nLnJlZmxlY3QuKjsNCiANCi1wdWJsaWMgZmluYWwgY2xhc3Mg
Vk1DbGFzcyANCitmaW5hbCBjbGFzcyBWTUNsYXNzIA0KIHsNCi0gIHByaXZhdGUgQ2xhc3MgY2xh
eno7DQorDQorICAvLyBPbmx5IHN0YXRpYyBtZXRob2RzLiBDYW5ub3QgYmUgaW5zdGFudGlhdGVk
Lg0KICAgcHJpdmF0ZSBWTUNsYXNzKCkgDQogICB7IA0KICAgfQ0KQEAgLTU3LDExICs1OCwxMiBA
QA0KICAgICogRGlzY292ZXIgd2hldGhlciBhbiBPYmplY3QgaXMgYW4gaW5zdGFuY2Ugb2YgdGhp
cyBDbGFzcy4gIFRoaW5rIG9mIGl0DQogICAgKiBhcyBhbG1vc3QgbGlrZSA8Y29kZT5vIGluc3Rh
bmNlb2YgKHRoaXMgY2xhc3MpPC9jb2RlPi4NCiAgICAqDQorICAgKiBAcGFyYW0ga2xhc3MgdGhl
IENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHBhcmFtIG8gdGhlIE9iamVj
dCB0byBjaGVjaw0KICAgICogQHJldHVybiB3aGV0aGVyIG8gaXMgYW4gaW5zdGFuY2Ugb2YgdGhp
cyBjbGFzcw0KICAgICogQHNpbmNlIDEuMQ0KICAgICovDQotICBuYXRpdmUgYm9vbGVhbiBpc0lu
c3RhbmNlKE9iamVjdCBvKTsNCisgIHN0YXRpYyBuYXRpdmUgYm9vbGVhbiBpc0luc3RhbmNlKENs
YXNzIGtsYXp6LCBPYmplY3Qgbyk7DQogDQogICAvKioNCiAgICAqIERpc2NvdmVyIHdoZXRoZXIg
YW4gaW5zdGFuY2Ugb2YgdGhlIENsYXNzIHBhcmFtZXRlciB3b3VsZCBiZSBhbg0KQEAgLTcxLDIx
ICs3MywyMyBAQA0KICAgICogY2hlY2tzIHdpZGVuaW5nIGNvbnZlcnNpb25zIGZvciBvYmplY3Rz
LCBpdCBtdXN0IGJlIGV4YWN0IGZvciBwcmltaXRpdmUNCiAgICAqIHR5cGVzLg0KICAgICoNCisg
ICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0IHRoYXQncyBjYWxsaW5nIHVzDQogICAg
KiBAcGFyYW0gYyB0aGUgY2xhc3MgdG8gY2hlY2sNCiAgICAqIEByZXR1cm4gd2hldGhlciBhbiBp
bnN0YW5jZSBvZiBjIHdvdWxkIGJlIGFuIGluc3RhbmNlIG9mIHRoaXMgY2xhc3MNCiAgICAqICAg
ICAgICAgYXMgd2VsbA0KICAgICogQHRocm93cyBOdWxsUG9pbnRlckV4Y2VwdGlvbiBpZiBjIGlz
IG51bGwNCiAgICAqIEBzaW5jZSAxLjENCiAgICAqLw0KLSAgbmF0aXZlIGJvb2xlYW4gaXNBc3Np
Z25hYmxlRnJvbShDbGFzcyBjKTsNCisgIHN0YXRpYyBuYXRpdmUgYm9vbGVhbiBpc0Fzc2lnbmFi
bGVGcm9tKENsYXNzIGtsYXNzLCBDbGFzcyBjKTsNCiANCiAgIC8qKg0KICAgICogQ2hlY2sgd2hl
dGhlciB0aGlzIGNsYXNzIGlzIGFuIGludGVyZmFjZSBvciBub3QuICBBcnJheSB0eXBlcyBhcmUg
bm90DQogICAgKiBpbnRlcmZhY2VzLg0KICAgICoNCisgICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xh
c3Mgb2JqZWN0IHRoYXQncyBjYWxsaW5nIHVzDQogICAgKiBAcmV0dXJuIHdoZXRoZXIgdGhpcyBj
bGFzcyBpcyBhbiBpbnRlcmZhY2Ugb3Igbm90DQogICAgKi8NCi0gIG5hdGl2ZSBib29sZWFuIGlz
SW50ZXJmYWNlKCk7DQorICBzdGF0aWMgbmF0aXZlIGJvb2xlYW4gaXNJbnRlcmZhY2UoQ2xhc3Mg
a2xhc3MpOw0KIA0KICAgLyoqDQogICAgKiBSZXR1cm4gd2hldGhlciB0aGlzIGNsYXNzIGlzIGEg
cHJpbWl0aXZlIHR5cGUuICBBIHByaW1pdGl2ZSB0eXBlIGNsYXNzDQpAQCAtOTQsNiArOTgsNyBA
QA0KICAgICogY2xhc3NlcyB0aHJvdWdoIGphdmEubGFuZy5Cb29sZWFuLlRZUEUsIGphdmEubGFu
Zy5JbnRlZ2VyLlRZUEUsIGV0Yy4sDQogICAgKiBvciB0aHJvdWdoIGJvb2xlYW4uY2xhc3MsIGlu
dC5jbGFzcywgZXRjLg0KICAgICoNCisgICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0
IHRoYXQncyBjYWxsaW5nIHVzDQogICAgKiBAcmV0dXJuIHdoZXRoZXIgdGhpcyBjbGFzcyBpcyBh
IHByaW1pdGl2ZSB0eXBlDQogICAgKiBAc2VlIEJvb2xlYW4jVFlQRQ0KICAgICogQHNlZSBCeXRl
I1RZUEUNCkBAIC0xMDYsNyArMTExLDcgQEANCiAgICAqIEBzZWUgVm9pZCNUWVBFDQogICAgKiBA
c2luY2UgMS4xDQogICAgKi8NCi0gIG5hdGl2ZSBib29sZWFuIGlzUHJpbWl0aXZlKCk7DQorICBz
dGF0aWMgbmF0aXZlIGJvb2xlYW4gaXNQcmltaXRpdmUoQ2xhc3Mga2xhc3MpOw0KIA0KICAgLyoq
DQogICAgKiBHZXQgdGhlIG5hbWUgb2YgdGhpcyBjbGFzcywgc2VwYXJhdGVkIGJ5IGRvdHMgZm9y
IHBhY2thZ2Ugc2VwYXJhdG9ycy4NCkBAIC0xMjUsMTggKzEzMCwyMCBAQA0KICAgICogY2xhc3Mg
b3IgaW50ZXJmYWNlLCBhbG9uZTogJmx0O2RvdHRlZCBuYW1lJmd0Ow0KICAgICogY2xhc3Mgb3Ig
aW50ZXJmYWNlLCBhcyBlbGVtZW50IHR5cGU6IEwmbHQ7ZG90dGVkIG5hbWUmZ3Q7Ow0KICAgICoN
CisgICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0IHRoYXQncyBjYWxsaW5nIHVzDQog
ICAgKiBAcmV0dXJuIHRoZSBuYW1lIG9mIHRoaXMgY2xhc3MNCiAgICAqLw0KLSAgbmF0aXZlIFN0
cmluZyBnZXROYW1lKCk7DQorICBzdGF0aWMgbmF0aXZlIFN0cmluZyBnZXROYW1lKENsYXNzIGts
YXNzKTsNCiANCiAgIC8qKg0KICAgICogR2V0IHRoZSBkaXJlY3Qgc3VwZXJjbGFzcyBvZiB0aGlz
IGNsYXNzLiAgSWYgdGhpcyBpcyBhbiBpbnRlcmZhY2UsDQogICAgKiBPYmplY3QsIGEgcHJpbWl0
aXZlIHR5cGUsIG9yIHZvaWQsIGl0IHdpbGwgcmV0dXJuIG51bGwuIElmIHRoaXMgaXMgYW4NCiAg
ICAqIGFycmF5IHR5cGUsIGl0IHdpbGwgcmV0dXJuIE9iamVjdC4NCiAgICAqDQorICAgKiBAcGFy
YW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHJldHVy
biB0aGUgZGlyZWN0IHN1cGVyY2xhc3Mgb2YgdGhpcyBjbGFzcw0KICAgICovDQotICBuYXRpdmUg
Q2xhc3MgZ2V0U3VwZXJjbGFzcygpOw0KKyAgc3RhdGljIG5hdGl2ZSBDbGFzcyBnZXRTdXBlcmNs
YXNzKENsYXNzIGtsYXNzKTsNCiANCiAgIC8qKg0KICAgICogR2V0IHRoZSBpbnRlcmZhY2VzIHRo
aXMgY2xhc3MgPEVNPmRpcmVjdGx5PC9FTT4gaW1wbGVtZW50cywgaW4gdGhlDQpAQCAtMTQ0LDkg
KzE1MSwxMCBAQA0KICAgICogZm9yIE9iamVjdCwgcHJpbWl0aXZlcywgdm9pZCwgYW5kIGNsYXNz
ZXMgb3IgaW50ZXJmYWNlcyB3aXRoIG5vIGRpcmVjdA0KICAgICogc3VwZXJpbnRlcmZhY2UuIEFy
cmF5IHR5cGVzIHJldHVybiBDbG9uZWFibGUgYW5kIFNlcmlhbGl6YWJsZS4NCiAgICAqDQorICAg
KiBAcGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGluZyB1cw0KICAgICog
QHJldHVybiB0aGUgaW50ZXJmYWNlcyB0aGlzIGNsYXNzIGRpcmVjdGx5IGltcGxlbWVudHMNCiAg
ICAqLw0KLSAgbmF0aXZlIENsYXNzW10gZ2V0SW50ZXJmYWNlcygpOw0KKyAgc3RhdGljIG5hdGl2
ZSBDbGFzc1tdIGdldEludGVyZmFjZXMoQ2xhc3Mga2xhc3MpOw0KIA0KICAgLyoqDQogICAgKiBJ
ZiB0aGlzIGlzIGFuIGFycmF5LCBnZXQgdGhlIENsYXNzIHJlcHJlc2VudGluZyB0aGUgdHlwZSBv
ZiBhcnJheS4NCkBAIC0xNTQsMTEgKzE2MiwxMiBAQA0KICAgICogY2FsbGluZyBnZXRDb21wb25l
bnRUeXBlIG9uIHRoYXQgd291bGQgZ2l2ZSAiamF2YS5sYW5nLlN0cmluZyIuICBJZg0KICAgICog
dGhpcyBpcyBub3QgYW4gYXJyYXksIHJldHVybnMgbnVsbC4NCiAgICAqDQorICAgKiBAcGFyYW0g
a2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHJldHVybiB0
aGUgYXJyYXkgdHlwZSBvZiB0aGlzIGNsYXNzLCBvciBudWxsDQogICAgKiBAc2VlIEFycmF5DQog
ICAgKiBAc2luY2UgMS4xDQogICAgKi8NCi0gIG5hdGl2ZSBDbGFzcyBnZXRDb21wb25lbnRUeXBl
KCk7DQorICBzdGF0aWMgbmF0aXZlIENsYXNzIGdldENvbXBvbmVudFR5cGUoQ2xhc3Mga2xhc3Mp
Ow0KIA0KICAgLyoqDQogICAgKiBHZXQgdGhlIG1vZGlmaWVycyBvZiB0aGlzIGNsYXNzLiAgVGhl
c2UgY2FuIGJlIGRlY29kZWQgdXNpbmcgTW9kaWZpZXIsDQpAQCAtMTY4LDU2ICsxNzcsNjQgQEAN
CiAgICAqIG1hcmtlZCBmaW5hbCBidXQgbm90IGFuIGludGVyZmFjZS4gUHJpbWl0aXZlIHR5cGVz
IGFuZCB2b2lkIGFyZSBtYXJrZWQNCiAgICAqIHB1YmxpYyBhbmQgZmluYWwsIGJ1dCBub3QgYW4g
aW50ZXJmYWNlLg0KICAgICoNCisgICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0IHRo
YXQncyBjYWxsaW5nIHVzDQogICAgKiBAcmV0dXJuIHRoZSBtb2RpZmllcnMgb2YgdGhpcyBjbGFz
cw0KICAgICogQHNlZSBNb2RpZmVyDQogICAgKiBAc2luY2UgMS4xDQogICAgKi8NCi0gIG5hdGl2
ZSBpbnQgZ2V0TW9kaWZpZXJzKCk7DQorICBzdGF0aWMgbmF0aXZlIGludCBnZXRNb2RpZmllcnMo
Q2xhc3Mga2xhc3MpOw0KIA0KICAgLyoqDQogICAgKiBJZiB0aGlzIGlzIGEgbmVzdGVkIG9yIGlu
bmVyIGNsYXNzLCByZXR1cm4gdGhlIGNsYXNzIHRoYXQgZGVjbGFyZWQgaXQuDQogICAgKiBJZiBu
b3QsIHJldHVybiBudWxsLg0KICAgICoNCisgICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2Jq
ZWN0IHRoYXQncyBjYWxsaW5nIHVzDQogICAgKiBAcmV0dXJuIHRoZSBkZWNsYXJpbmcgY2xhc3Mg
b2YgdGhpcyBjbGFzcw0KICAgICogQHNpbmNlIDEuMQ0KICAgICovDQotICBuYXRpdmUgQ2xhc3Mg
Z2V0RGVjbGFyaW5nQ2xhc3MoKTsNCisgIHN0YXRpYyBuYXRpdmUgQ2xhc3MgZ2V0RGVjbGFyaW5n
Q2xhc3MoQ2xhc3Mga2xhc3MpOw0KIA0KICAgLyoqDQogICAgKiBMaWtlIDxjb2RlPmdldERlY2xh
cmVkQ2xhc3NlcygpPC9jb2RlPiBidXQgd2l0aG91dCB0aGUgc2VjdXJpdHkgY2hlY2tzLg0KICAg
ICoNCisgICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0IHRoYXQncyBjYWxsaW5nIHVz
DQogICAgKiBAcGFyYW0gcHVsaWNPbmx5IE9ubHkgcHVibGljIGNsYXNzZXMgc2hvdWxkIGJlIHJl
dHVybmVkDQogICAgKi8NCi0gIG5hdGl2ZSBDbGFzc1tdIGdldERlY2xhcmVkQ2xhc3Nlcyhib29s
ZWFuIHB1YmxpY09ubHkpOw0KKyAgc3RhdGljIG5hdGl2ZSBDbGFzc1tdIGdldERlY2xhcmVkQ2xh
c3NlcyhDbGFzcyBrbGFzcywgYm9vbGVhbiBwdWJsaWNPbmx5KTsNCiANCiAgIC8qKg0KICAgICog
TGlrZSA8Y29kZT5nZXREZWNsYXJlZEZpZWxkcygpPC9jb2RlPiBidXQgd2l0aG91dCB0aGUgc2Vj
dXJpdHkgY2hlY2tzLg0KICAgICoNCisgICAqIEBwYXJhbSBrbGFzcyB0aGUgQ2xhc3Mgb2JqZWN0
IHRoYXQncyBjYWxsaW5nIHVzDQogICAgKiBAcGFyYW0gcHVsaWNPbmx5IE9ubHkgcHVibGljIGZp
ZWxkcyBzaG91bGQgYmUgcmV0dXJuZWQNCiAgICAqLw0KLSAgbmF0aXZlIEZpZWxkW10gZ2V0RGVj
bGFyZWRGaWVsZHMoYm9vbGVhbiBwdWJsaWNPbmx5KTsNCisgIHN0YXRpYyBuYXRpdmUgRmllbGRb
XSBnZXREZWNsYXJlZEZpZWxkcyhDbGFzcyBrbGFzcywgYm9vbGVhbiBwdWJsaWNPbmx5KTsNCiAN
CiAgIC8qKg0KICAgICogTGlrZSA8Y29kZT5nZXREZWNsYXJlZE1ldGhvZHMoKTwvY29kZT4gYnV0
IHdpdGhvdXQgdGhlIHNlY3VyaXR5IGNoZWNrcy4NCiAgICAqDQorICAgKiBAcGFyYW0ga2xhc3Mg
dGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHBhcmFtIHB1bGljT25s
eSBPbmx5IHB1YmxpYyBtZXRob2RzIHNob3VsZCBiZSByZXR1cm5lZA0KICAgICovDQotICBuYXRp
dmUgTWV0aG9kW10gZ2V0RGVjbGFyZWRNZXRob2RzKGJvb2xlYW4gcHVibGljT25seSk7DQorICBz
dGF0aWMgbmF0aXZlIE1ldGhvZFtdIGdldERlY2xhcmVkTWV0aG9kcyhDbGFzcyBrbGFzcywgYm9v
bGVhbiBwdWJsaWNPbmx5KTsNCiANCiAgIC8qKg0KICAgICogTGlrZSA8Y29kZT5nZXREZWNsYXJl
ZENvbnN0cnVjdG9ycygpPC9jb2RlPiBidXQgd2l0aG91dA0KICAgICogdGhlIHNlY3VyaXR5IGNo
ZWNrcy4NCiAgICAqDQorICAgKiBAcGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3Mg
Y2FsbGluZyB1cw0KICAgICogQHBhcmFtIHB1bGljT25seSBPbmx5IHB1YmxpYyBjb25zdHJ1Y3Rv
cnMgc2hvdWxkIGJlIHJldHVybmVkDQogICAgKi8NCi0gIG5hdGl2ZSBDb25zdHJ1Y3RvcltdIGdl
dERlY2xhcmVkQ29uc3RydWN0b3JzKGJvb2xlYW4gcHVibGljT25seSk7DQorICBzdGF0aWMgbmF0
aXZlIENvbnN0cnVjdG9yW10gZ2V0RGVjbGFyZWRDb25zdHJ1Y3RvcnMoQ2xhc3Mga2xhc3MsDQor
CQkJCQkJICAgICAgYm9vbGVhbiBwdWJsaWNPbmx5KTsNCiANCiAgIC8qKg0KICAgICogUmV0dXJu
IHRoZSBjbGFzcyBsb2FkZXIgb2YgdGhpcyBjbGFzcy4NCiAgICAqDQorICAgKiBAcGFyYW0ga2xh
c3MgdGhlIENsYXNzIG9iamVjdCB0aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHJldHVybiB0aGUg
Y2xhc3MgbG9hZGVyDQogICAgKi8NCi0gIG5hdGl2ZSBDbGFzc0xvYWRlciBnZXRDbGFzc0xvYWRl
cigpOw0KKyAgc3RhdGljIG5hdGl2ZSBDbGFzc0xvYWRlciBnZXRDbGFzc0xvYWRlcihDbGFzcyBr
bGFzcyk7DQogDQogICAvKioNCiAgICAqIFZNIGltcGxlbWVudG9ycyBhcmUgZnJlZSB0byBtYWtl
IHRoaXMgbWV0aG9kIGEgbm9vcCBpZiANCkBAIC0yMzYsMTkgKzI1MywyMSBAQA0KICAgLyoqDQog
ICAgKiBSZXR1cm4gd2hldGhlciB0aGlzIGNsYXNzIGlzIGFuIGFycmF5IHR5cGUuDQogICAgKg0K
KyAgICogQHBhcmFtIGtsYXNzIHRoZSBDbGFzcyBvYmplY3QgdGhhdCdzIGNhbGxpbmcgdXMNCiAg
ICAqIEByZXR1cm4gMSBpZiB0aGlzIGNsYXNzIGlzIGFuIGFycmF5IHR5cGUsIDAgb3RoZXJ3aXNl
LCAtMSBpZiB1bnN1cHBvcnRlZA0KICAgICogb3BlcmF0aW9uDQogICAgKi8NCi0gIG5hdGl2ZSBp
bnQgaXNBcnJheSgpOw0KKyAgc3RhdGljIG5hdGl2ZSBib29sZWFuIGlzQXJyYXkoQ2xhc3Mga2xh
c3MpOw0KIA0KICAgLyoqDQogICAgKiBUaGlzIG1ldGhvZCBzaG91bGQgdHJpZ2dlciBjbGFzcyBp
bml0aWFsaXphdGlvbiAoaWYgdGhlDQogICAgKiBjbGFzcyBoYXNuJ3QgYWxyZWFkeSBiZWVuIGlu
aXRpYWxpemVkKQ0KICAgICogDQorICAgKiBAcGFyYW0ga2xhc3MgdGhlIENsYXNzIG9iamVjdCB0
aGF0J3MgY2FsbGluZyB1cw0KICAgICogQHRocm93cyBFeGNlcHRpb25JbkluaXRpYWxpemVyRXJy
b3IgaWYgYW4gZXhjZXB0aW9uDQogICAgKiAgICAgICAgIG9jY3VycyBkdXJpbmcgaW5pdGlhbGl6
YXRpb24NCiAgICAqLw0KLSAgbmF0aXZlIHZvaWQgaW5pdGlhbGl6ZSgpOw0KKyAgc3RhdGljIG5h
dGl2ZSB2b2lkIGluaXRpYWxpemUoQ2xhc3Mga2xhc3MpOw0KIA0KICAgLyoqDQogICAgKiBMb2Fk
IGFuIGFycmF5IGNsYXNzLg0KQEAgLTI2NCw2ICsyODMsNCBAQA0KICAgICogVGhyb3cgYSBjaGVj
a2VkIGV4Y2VwdGlvbiB3aXRob3V0IGRlY2xhcmluZyBpdC4NCiAgICAqLw0KICAgc3RhdGljIG5h
dGl2ZSB2b2lkIHRocm93RXhjZXB0aW9uKFRocm93YWJsZSB0KTsNCi0NCi0gIHB1YmxpYyBzdGF0
aWMgbmF0aXZlIGJvb2xlYW4gaGFzQ2xhc3NJbml0aWFsaXplcihDbGFzcyBjKTsNCiB9IC8vIGNs
YXNzIFZNQ2xhc3MNCmRpZmYgLXVOciBqYW12bS0xLjEuMy9zcmMvY2xhc3MuYyAvaG9tZS9tYXJr
L3NyYy9qYW12bS0xLjEuMy9zcmMvY2xhc3MuYw0KLS0tIGphbXZtLTEuMS4zL3NyYy9jbGFzcy5j
CTIwMDQtMDQtMTIgMDM6MTA6MTguMDAwMDAwMDAwICswMjAwDQorKysgL2hvbWUvbWFyay9zcmMv
amFtdm0tMS4xLjMvc3JjL2NsYXNzLmMJMjAwNC0wNC0yMyAxMTo1MjowMy4wMDAwMDAwMDAgKzAy
MDANCkBAIC00MywxMSArNDMsNiBAQA0KIENsYXNzICpqYXZhX2xhbmdfQ2xhc3MgPSBOVUxMOw0K
IENsYXNzICpqYXZhX2xhbmdfVk1DbGFzcyA9IE5VTEw7DQogDQotLyogRmllbGQgb2Zmc2V0cyBp
bnRvIENsYXNzIGFuZCBWTUNsYXNzIG9iamVjdHMgLSB1c2VkIHdoZW4NCi0gICBwcmVwYXJpbmcg
YSBuZXcgY2xhc3MuICovDQotc3RhdGljIGludCB2bUNsYXNzX29mZnNldDsNCi1pbnQgY2xhenpf
b2Zmc2V0OyAvKiBOb3Qgc3RhdGljIGFzIHJlZmVyZW5jZWQgYnkgbmF0aXZlLmMgKi8NCi0NCiAv
KiBNZXRob2QgdGFibGUgaW5kZXggb2YgQ2xhc3NMb2FkZXIubG9hZENsYXNzIC0gdXNlZCB3aGVu
DQogICAgcmVxdWVzdGluZyBhIEphdmEtbGV2ZWwgY2xhc3MgbG9hZGVyIHRvIGxvYWQgYSBjbGFz
cy4NCiAgICBDYWNoZWQgb24gZmlyc3QgdXNlLiAqLw0KQEAgLTk0LDMzICs4OSwxNSBAQA0KIA0K
IHN0YXRpYyB2b2lkIHByZXBhcmVDbGFzcyhDbGFzcyAqY2xhc3MpIHsNCiAgICAgQ2xhc3NCbG9j
ayAqY2IgPSBDTEFTU19DQihjbGFzcyk7DQotICAgIE9iamVjdCAqdm1DbGFzczsNCiANCiAgICAg
aWYoc3RyY21wKGNiLT5uYW1lLCJqYXZhL2xhbmcvQ2xhc3MiKSA9PSAwKQ0KICAgICAgICBjbGFz
cy0+Y2xhc3MgPSBjbGFzczsNCiAgICAgZWxzZSB7DQotICAgICAgIGlmKGphdmFfbGFuZ19DbGFz
cyA9PSBOVUxMKSB7DQotICAgICAgICAgIEZpZWxkQmxvY2sgKmZpZWxkOw0KKyAgICAgICBpZihq
YXZhX2xhbmdfQ2xhc3MgPT0gTlVMTCkNCiAgICAgICAgICAgamF2YV9sYW5nX0NsYXNzID0gZmlu
ZFN5c3RlbUNsYXNzMCgiamF2YS9sYW5nL0NsYXNzIik7DQotCSAgaWYoKGZpZWxkID0gZmluZEZp
ZWxkKGphdmFfbGFuZ19DbGFzcywgInZtQ2xhc3MiLCAiTGphdmEvbGFuZy9WTUNsYXNzOyIpKSA9
PSBOVUxMKQ0KLSAgICAgICAgICAgICAgZ290byBpbml0X2Vycm9yOw0KLQkgIHZtQ2xhc3Nfb2Zm
c2V0ID0gZmllbGQtPm9mZnNldDsNCi0gICAgICAgfQ0KICAgICAgICBjbGFzcy0+Y2xhc3MgPSBq
YXZhX2xhbmdfQ2xhc3M7DQogICAgIH0NCiANCi0gICAgaWYoamF2YV9sYW5nX1ZNQ2xhc3MgPT0g
TlVMTCkgew0KLSAgICAgICAgICBGaWVsZEJsb2NrICpmaWVsZDsNCi0gICAgICAgICAgamF2YV9s
YW5nX1ZNQ2xhc3MgPSBmaW5kU3lzdGVtQ2xhc3MwKCJqYXZhL2xhbmcvVk1DbGFzcyIpOw0KLQkg
IGlmKChmaWVsZCA9IGZpbmRGaWVsZChqYXZhX2xhbmdfVk1DbGFzcywgImNsYXp6IiwgIkxqYXZh
L2xhbmcvQ2xhc3M7IikpID09IE5VTEwpDQotICAgICAgICAgICAgICBnb3RvIGluaXRfZXJyb3I7
DQotCSAgY2xhenpfb2Zmc2V0ID0gZmllbGQtPm9mZnNldDsNCi0gICAgfQ0KLQ0KLSAgICB2bUNs
YXNzID0gYWxsb2NPYmplY3QoamF2YV9sYW5nX1ZNQ2xhc3MpOw0KLSAgICBJTlNUX0RBVEEodm1D
bGFzcylbY2xhenpfb2Zmc2V0XSA9ICh1NCkgY2xhc3M7DQotICAgIElOU1RfREFUQShjbGFzcylb
dm1DbGFzc19vZmZzZXRdID0gKHU0KSB2bUNsYXNzOw0KLQ0KICAgICByZXR1cm47DQogDQogaW5p
dF9lcnJvcjoNCmRpZmYgLXVOciBqYW12bS0xLjEuMy9zcmMvbmF0aXZlcy5jIC9ob21lL21hcmsv
c3JjL2phbXZtLTEuMS4zL3NyYy9uYXRpdmVzLmMNCi0tLSBqYW12bS0xLjEuMy9zcmMvbmF0aXZl
cy5jCTIwMDQtMDQtMTIgMDQ6MTQ6NTcuMDAwMDAwMDAwICswMjAwDQorKysgL2hvbWUvbWFyay9z
cmMvamFtdm0tMS4xLjMvc3JjL25hdGl2ZXMuYwkyMDA0LTA0LTIzIDEzOjM5OjI1LjAwMDAwMDAw
MCArMDIwMA0KQEAgLTI5Miw5ICsyOTIsNyBAQA0KIA0KIC8qIGphdmEubGFuZy5WTUNsYXNzICov
DQogDQotZXh0ZXJuIGludCBjbGF6el9vZmZzZXQ7DQotDQotI2RlZmluZSBHRVRfQ0xBU1Modm1D
bGFzcykgKENsYXNzKikoSU5TVF9EQVRBKChPYmplY3QqKXZtQ2xhc3MpW2NsYXp6X29mZnNldF0p
DQorI2RlZmluZSBHRVRfQ0xBU1Modm1DbGFzcykgKENsYXNzKil2bUNsYXNzDQogDQogdTQgKmlz
SW5zdGFuY2UoQ2xhc3MgKmNsYXNzLCBNZXRob2RCbG9jayAqbWIsIHU0ICpvc3RhY2spIHsNCiAg
ICAgQ2xhc3MgKmNsYXp6ID0gR0VUX0NMQVNTKG9zdGFja1swXSk7DQo=

--=-thoRkjyB/B/fI+sffBph
Content-Disposition: attachment; filename=jamvm-process.patch
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name=jamvm-process.patch; charset=ISO-8859-1

ZGlmZiAtdU5yIGphbXZtLTEuMS4zL2xpYi9qYXZhL2xhbmcvVk1SdW50aW1lLmphdmEgL2hvbWUv
bWFyay9zcmMvamFtdm0tMS4xLjMvbGliL2phdmEvbGFuZy9WTVJ1bnRpbWUuamF2YQ0KLS0tIGph
bXZtLTEuMS4zL2xpYi9qYXZhL2xhbmcvVk1SdW50aW1lLmphdmEJMjAwNC0wMy0yNCAwNDo0Mjo1
NC4wMDAwMDAwMDAgKzAxMDANCisrKyAvaG9tZS9tYXJrL3NyYy9qYW12bS0xLjEuMy9saWIvamF2
YS9sYW5nL1ZNUnVudGltZS5qYXZhCTIwMDQtMDQtMjIgMTg6MzM6NTQuMDAwMDAwMDAwICswMjAw
DQpAQCAtMzgsNiArMzgsNyBAQA0KIHBhY2thZ2UgamF2YS5sYW5nOw0KIA0KIGltcG9ydCBqYXZh
LmlvLkZpbGU7DQoraW1wb3J0IGphdmEuaW8uSU9FeGNlcHRpb247DQogaW1wb3J0IGphdmEudXRp
bC5Qcm9wZXJ0aWVzOw0KIA0KIC8qKg0KQEAgLTE3OCw4ICsxNzksMTAgQEANCiAgICAgICogQHJl
dHVybiB0aGUgbmV3bHkgY3JlYXRlZCBwcm9jZXNzDQogICAgICAqIEB0aHJvd3MgTnVsbFBvaW50
ZXJFeGNlcHRpb24gaWYgY21kIG9yIGVudiBoYXZlIG51bGwgZWxlbWVudHMNCiAgICAgICovDQot
ICAgIHN0YXRpYyBQcm9jZXNzIGV4ZWMoU3RyaW5nW10gY21kLCBTdHJpbmdbXSBlbnYsIEZpbGUg
ZGlyKSB7DQotICAgICAgICB0aHJvdyBuZXcgSW50ZXJuYWxFcnJvcigidW5pbXBsZW1lbnRlZCIp
Ow0KKyAgICBzdGF0aWMgUHJvY2VzcyBleGVjKFN0cmluZ1tdIGNtZCwgU3RyaW5nW10gZW52LCBG
aWxlIGRpcikNCisgICAgICB0aHJvd3MgSU9FeGNlcHRpb24NCisgICAgew0KKyAgICAgICAgcmV0
dXJuIFZNUHJvY2Vzcy5leGVjKGNtZCwgZW52LCBkaXIpOw0KICAgICB9DQogDQogICAgIC8qKg0K


--=-thoRkjyB/B/fI+sffBph--

--=-VDqvckOtgtKmddavi4Tw
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAiQLRxVhZCJWr9QwRAv8RAJwN8EPrhAENK0az3eOZ2sy5DpiiugCgmTlt
ku0bJcc3ty0qnKYDL7knRqE=
=Gwcf
-----END PGP SIGNATURE-----

--=-VDqvckOtgtKmddavi4Tw--




From MAILER-DAEMON Fri Apr 23 13:11:59 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH4Az-0006cT-Bd
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 13:09:21 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH461-0004dL-Ae
	for classpath@gnu.org; Fri, 23 Apr 2004 13:04:13 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH404-0001EY-5a
	for classpath@gnu.org; Fri, 23 Apr 2004 12:58:35 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BH403-0001Du-L8
	for classpath@gnu.org; Fri, 23 Apr 2004 12:58:03 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BH402-0001qx-00
	for <classpath@gnu.org>; Fri, 23 Apr 2004 18:58:02 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BH3zv-0001me-00; Fri, 23 Apr 2004 18:57:55 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i3NGvsLT010819;
	Fri, 23 Apr 2004 18:57:54 +0200 (MEST)
Message-ID: <40894B12.4010207@kaffe.org>
Date: Fri, 23 Apr 2004 18:57:54 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Patrik Reali <reali@acm.org>
References: <93607480.1081689891@[192.168.1.4]>
In-Reply-To: <93607480.1081689891@[192.168.1.4]>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: classpath@gnu.org
Subject: Re: Q: How do you keep your sources in synch?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 17:09:19 -0000

Patrik Reali wrote:
> Hi,
> 
> I'd like to add this topic to the FAQ, thus I'm looking for hard 
> evidence on this topic.
> 
> I was wondering, how the various VM deal with changes in the classpath 
> code (I assume you have a "customized" version of classpath). Are you 
> importing them by hand or rely on some automated tool?

By hand, currently. [1]

cheers,
dalibor topic

[1] One of things on my long list of things I'd do if I every really 
feel bored one day, is to write a java tool that scans Classpath's and 
Kaffe's CVS, finds differences, tries to track down the causing patch 
sets, apply them, and generate patch sets of the working ones along with 
the ChangeLogs. Trouble is, I'm rarely bored :)



From MAILER-DAEMON Fri Apr 23 13:55:25 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH4tZ-0002wn-6h
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 13:55:25 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH4tV-0002rI-Fu
	for classpath@gnu.org; Fri, 23 Apr 2004 13:55:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH4sw-0002KU-52
	for classpath@gnu.org; Fri, 23 Apr 2004 13:55:18 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BH4s9-0001kV-0A
	for classpath@gnu.org; Fri, 23 Apr 2004 13:53:57 -0400
Received: (qmail 29594 invoked from network); 23 Apr 2004 17:56:42 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <twiun@adorphuye.com>; 23 Apr 2004 17:56:42 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 5008F4F853E; Fri, 23 Apr 2004 11:42:24 -0600 (MDT)
To: "S. Meslin-Weber" <twiun@adorphuye.com>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<20040422214401.GA28277@tangency.co.uk>
	<200404231034.02980.zander@javalobby.org>
	<200404231042.42869.konqueror@gmx.de>
	<20040423085701.GC28277@tangency.co.uk>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I feel like a wet parking meter on Darvon!
Date: 23 Apr 2004 11:42:24 -0600
In-Reply-To: <20040423085701.GC28277@tangency.co.uk>
Message-ID: <87isfqpp4v.fsf@fleche.redhat.com>
Lines: 12
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: GNU Classpath <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 17:55:23 -0000

>>>>> "Stephane" == S Meslin-Weber <twiun@adorphuye.com> writes:

Stephane> Without getting heated about things, it may just be simpler
Stephane> to create a 'contrib' directory for files such as this -
Stephane> allowing those that use them to maintain them but also
Stephane> showing they're not part of the mainstream build path.

Unfortunately I'm not sure that is possible for the eclipse project
files.  I think eclipse really wants them in the top-most directory
of the project.

Tom



From MAILER-DAEMON Fri Apr 23 13:59:36 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH4xV-000748-Mw
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 13:59:29 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH4wx-0006JF-PD
	for classpath@gnu.org; Fri, 23 Apr 2004 13:58:55 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH4wC-0005Bk-Nn
	for classpath@gnu.org; Fri, 23 Apr 2004 13:58:39 -0400
Received: from [81.5.129.62] (helo=tangency.co.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BH4vW-0004XP-QW
	for classpath@gnu.org; Fri, 23 Apr 2004 13:57:26 -0400
Received: from localhost (localhost [127.0.0.1]) (uid 1000)
	by tangency.co.uk with local; Fri, 23 Apr 2004 18:51:17 +0100
Date: Fri, 23 Apr 2004 18:51:17 +0100
From: "S. Meslin-Weber" <twiun@adorphuye.com>
To: Tom Tromey <tromey@redhat.com>
Message-ID: <20040423175117.GF28277@tangency.co.uk>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<20040422214401.GA28277@tangency.co.uk>
	<200404231034.02980.zander@javalobby.org>
	<200404231042.42869.konqueror@gmx.de>
	<20040423085701.GC28277@tangency.co.uk>
	<87isfqpp4v.fsf@fleche.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
In-Reply-To: <87isfqpp4v.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.5.1+cvs20040105i
Cc: GNU Classpath <classpath@gnu.org>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 17:59:16 -0000

On Fri, Apr 23, 2004 at 11:42:24AM -0600, Tom Tromey wrote:
> Unfortunately I'm not sure that is possible for the eclipse project
> files.  I think eclipse really wants them in the top-most directory
> of the project.

That's a good point. I suppose people could manually move them around,
but that kind of defeats the whole idea of being able to pull straight
from CVS using Eclipse and into a project.

Stephane



From MAILER-DAEMON Fri Apr 23 14:11:15 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH58t-0001yW-3w
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 14:11:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH58q-0001xw-Jw
	for classpath@gnu.org; Fri, 23 Apr 2004 14:11:12 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH58K-0001qD-32
	for classpath@gnu.org; Fri, 23 Apr 2004 14:11:11 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BH58J-0001ps-J8
	for classpath@gnu.org; Fri, 23 Apr 2004 14:10:39 -0400
Received: (qmail 6867 invoked from network); 23 Apr 2004 18:13:34 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 23 Apr 2004 18:13:34 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id D455A4F853E; Fri, 23 Apr 2004 11:59:15 -0600 (MDT)
To: Mark Wielaard <mark@klomp.org>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<1082711821.27234.238.camel@elsschot.wildebeest.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Hello.  I know the divorce rate among unmarried Catholic
	Alaskan females!!
Date: 23 Apr 2004 11:59:15 -0600
In-Reply-To: <1082711821.27234.238.camel@elsschot.wildebeest.org>
Message-ID: <87ad12pocs.fsf@fleche.redhat.com>
Lines: 37
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: GNU Classpath Project <classpath@gnu.org>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 18:11:13 -0000

>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:

Mark> There are a couple of things that I am worried about:

Mark> - Having multiple build systems were we have enough maintenance
Mark>   work with the current one.

Yeah, make no mistake, if we encourage people to use IDEs, it will
eventually have some effect.  For instance, if we ever want to start
doing preprocessing, we'll run into conflicts.  (Personally I don't
see this as a big problem, since I'm not that keen on preprocessing,
but I know there are differences here already.)

On the other hand, some effects of IDEs are beneficial.  As we've
already seen, Eclipse has a good compiler which has already found real
Classpath bugs.

Mark> - Pretending we support Eclipse which is arguably non-free since people
Mark>   are not testing, running and developing it with free runtimes.
Mark>   (You claim adding this might make this happen sooner. I do hope so.)

I did all my work with Eclipse running on a free runtime.  And AFAIK
Eclipse 2.x works out of the box with many runtimes, including gcc 3.4
(just released).

Mark> If you can show me some people that run Eclipse in a free environment
Mark> that are actually happy with using your setup files than I am all for
Mark> including them. But you must promise to maintain them. The only hard
Mark> part seem to come up with the list of "classpaths" and the "exclusion
Mark> list", which is done by hand in our normal build system also.

Yeah, I'll do this.  There really isn't much to maintain.  I think the
worst case is if nobody uses these and they rot.  But if that happens,
then we know people aren't using Eclipse to hack Classpath, and the
solution is simple: cvs rm.

Tom



From MAILER-DAEMON Fri Apr 23 14:20:25 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH5Hl-0004PP-CX
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 14:20:25 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH5Hg-0004OA-IE
	for classpath@gnu.org; Fri, 23 Apr 2004 14:20:20 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH53b-0000oH-Uy
	for classpath@gnu.org; Fri, 23 Apr 2004 14:06:19 -0400
Received: from [207.189.223.52] (helo=email3.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BH4zP-0007om-DT
	for classpath@gnu.org; Fri, 23 Apr 2004 14:01:27 -0400
Received: (qmail 27310 invoked from network); 23 Apr 2004 18:20:04 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email3.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <konqueror@gmx.de>; 23 Apr 2004 18:20:04 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 61DF14F853E; Fri, 23 Apr 2004 11:50:02 -0600 (MDT)
To: Michael Koch <konqueror@gmx.de>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<200404231052.13157.konqueror@gmx.de>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Let's send the Russians defective lifestyle accessories!
Date: 23 Apr 2004 11:50:02 -0600
In-Reply-To: <200404231052.13157.konqueror@gmx.de>
Message-ID: <87ekqepos5.fsf@fleche.redhat.com>
Lines: 24
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: GNU Classpath Project <classpath@gnu.org>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 18:20:21 -0000

>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> Are there some mroe instructions on how to use these files ?
Michael> I suppose I need to create a new project and then put these
Michael> files into it and restart eclipse. Havent tried it yet.

I had to take a strange route to get it all to work.  I think the
simplest approach for now is:

* Check out a new classpath
* Add the files
* Start eclipse, go to File->Import, choose import existing project,
  and then import the classpath you just checked out

Next I recommend setting up the project.  Go to the project
preferences and add "FIXME" and "XXX" as Java Task Tags.  Also
configure the compiler settings to your liking.  At this point I also
configure the editor to be as gnu-ish as possible: 8 space tabs and
Emacs settings.

We really should be able to share the task tags, compiler settings,
and tab stuff.  I filed a couple Eclipse PRs for this.

Tom



From MAILER-DAEMON Fri Apr 23 16:18:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH75p-0000gG-KS
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 16:16:13 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH72i-0007rT-LI
	for classpath@gnu.org; Fri, 23 Apr 2004 16:13:00 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH6yP-0005BQ-2T
	for classpath@gnu.org; Fri, 23 Apr 2004 16:09:05 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BH6xw-0004nF-2Y
	for classpath@gnu.org; Fri, 23 Apr 2004 16:08:04 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-204.ewetel.net
	[80.228.95.204])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i3NK7wnV004163
	for <classpath@gnu.org>; Fri, 23 Apr 2004 22:07:58 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BH6yK-0002OK-00
	for <classpath@gnu.org>; Fri, 23 Apr 2004 22:08:28 +0200
From: Michael Koch <konqueror@gmx.de>
To: classpath@gnu.org
Date: Fri, 23 Apr 2004 22:07:36 +0200
User-Agent: KMail/1.5.4
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_IeXiAMMl1WCx0EJ"
Message-Id: <200404232207.37055.konqueror@gmx.de>
X-CheckCompat: OK
Subject: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 20:15:59 -0000


--Boundary-00=_IeXiAMMl1WCx0EJ
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi list,


I started to do some GNU classpath/VM separation work. I decided to 
split the native methods of java.io.File into its own VM class called 
java.io.VMFile. The refactoring worked really smooth and so I provide 
here the patch for discussion. I have one minor nitpick myself VMFile 
is located in java/io/ currently. Before commiting I will move it to 
vm/reference/java/io/.

Please review and comment.


Michael

--Boundary-00=_IeXiAMMl1WCx0EJ
Content-Type: text/x-diff;
  charset="us-ascii";
  name="vmfile.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="vmfile.diff"

Index: java/io/File.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/File.java,v
retrieving revision 1.42
diff -u -r1.42 File.java
--- java/io/File.java	20 Apr 2004 16:29:11 -0000	1.42
+++ java/io/File.java	23 Apr 2004 19:55:44 -0000
@@ -96,11 +96,6 @@
   
   static
   {
-    if (Configuration.INIT_LOAD_LIBRARY)
-      {
-        System.loadLibrary("javaio");
-      }
-    
     // FIXME: We support only caseSensitive filesystems currently.
     caseSensitive = true;
   }
@@ -111,30 +106,6 @@
    */
   private String path;
 
-  /*
-   * This native method does the actual check of whether or not a file
-   * is a plain file or not.  It also handles the existence check to
-   * eliminate the overhead of a call to exists()
-   */
-  private native boolean isFileInternal(String path);
-
-  /*
-   * This method does the actual check of whether or not a file is a
-   * directory or not.  It also handle the existence check to eliminate
-   * the overhead of a call to exists()
-   */
-  private native boolean isDirectoryInternal(String path);
-
-  /**
-   * This native method checks file permissions for reading
-   */
-  private synchronized native boolean canReadInternal(String path);
-
-  /**
-   * This native method checks file permissions for writing
-   */
-  private synchronized native boolean canWriteInternal(String path);
-
   /**
    * This method tests whether or not the current thread is allowed to
    * to read the file pointed to by this object.  This will be true if and
@@ -154,7 +125,7 @@
     if (!exists())
       return false;
 
-    return canReadInternal(path);
+    return VMFile.canRead(path);
   }
 
   /**
@@ -177,11 +148,11 @@
     checkWrite();
      
     // Test for existence.  This is required by the spec
-    if (!existsInternal(path))
+    if (! VMFile.exists(path))
       return false;
 
-    if (!isDirectoryInternal(path))
-      return canWriteInternal(path);
+    if (!VMFile.isDirectory(path))
+      return VMFile.canWrite(path);
     else
       try
         {
@@ -221,14 +192,8 @@
   public boolean createNewFile() throws IOException
   {
     checkWrite();
-    return createInternal(path);
+    return VMFile.create(path);
   }
- 
-  /*
-   * This native method handles the actual deleting of the file
-   */
-  private native boolean deleteInternal(String path);
-
   /**
    * This method deletes the file represented by this object.  If this file
    * is a directory, it must be empty in order for the delete to succeed.
@@ -245,7 +210,7 @@
     if (s != null)
       s.checkDelete(path);
     
-    return deleteInternal(path);
+    return VMFile.delete(path);
   }
 
   /**
@@ -276,11 +241,6 @@
       return path.equalsIgnoreCase(other.path);
   }
 
-  /*
-   * This native method does the actual checking of file existence.
-   */
-  private native boolean existsInternal(String path);
-
   /**
    * This method tests whether or not the file represented by the object
    * actually exists on the filesystem.
@@ -292,7 +252,7 @@
   public boolean exists()
   {
     checkRead();
-    return existsInternal(path);
+    return VMFile.exists(path);
   }
 
   /**
@@ -539,7 +499,7 @@
   public boolean isDirectory()
   {
     checkRead();
-    return isDirectoryInternal(path); 
+    return VMFile.isDirectory(path); 
   }
 
   /**
@@ -555,7 +515,7 @@
   public boolean isFile()
   {
     checkRead();
-    return isFileInternal(path);
+    return VMFile.isFile(path);
   }
 
   /**
@@ -575,13 +535,6 @@
     return getName().startsWith(".");
   }
 
-  /*
-   * This native method does the actual work of getting the last file
-   * modification time.  It also does the existence check to avoid the
-   * overhead of a call to exists()
-   */
-  private native long lastModifiedInternal(String path);
-
   /**
    * This method returns the last modification time of this file.  The
    * time value returned is an abstract value that should not be interpreted
@@ -598,15 +551,9 @@
   public long lastModified()
   {
     checkRead();
-    return lastModifiedInternal(path);
+    return VMFile.lastModified(path);
   }
 
-  /*
-   * This native method actually determines the length of the file and
-   * handles the existence check
-   */
-  private native long lengthInternal(String path);
-
   /**
    * This method returns the length of the file represented by this object,
    * or 0 if the specified file does not exist.
@@ -618,15 +565,9 @@
   public long length()
   {
     checkRead();
-    return lengthInternal(path);
+    return VMFile.length(path);
   }
 
-  /*
-   * This native function actually produces the list of file in this
-   * directory
-   */
-  private native String[] listInternal(String dirname);
-
   /**
    * This method returns a array of <code>String</code>'s representing the
    * list of files is then directory represented by this object.  If this
@@ -665,7 +606,7 @@
     if (! dir.exists() || ! dir.isDirectory())
       return null;
     
-    String files[] = listInternal(list_path);
+    String files[] = VMFile.list(list_path);
     
     // Check if an error occured in listInternal().
     if (files == null)
@@ -864,11 +805,6 @@
     return new URL("file", "", abspath.replace(separatorChar, '/'));
   }
 
-  /*
-   * This native method actually creates the directory
-   */
-  private native boolean mkdirInternal(String path);
-
   /**
    * This method creates a directory for the path represented by this object.
    *
@@ -880,7 +816,7 @@
   public boolean mkdir()
   {
     checkWrite();
-    return mkdirInternal(PlatformHelper.removeTailSeparator(path));
+    return VMFile.mkdir(PlatformHelper.removeTailSeparator(path));
   }
 
   /**
@@ -912,11 +848,6 @@
   }
 
   /**
-   * This method is used to create a temporary file
-   */
-  private static native boolean createInternal(String name) throws IOException;
-
-  /**
    * This method creates a temporary file in the specified directory.  If 
    * the directory name is null, then this method uses the system temporary 
    * directory. The files created are guaranteed not to currently exist and 
@@ -958,10 +889,10 @@
           throw new IOException("Cannot determine system temporary directory"); 
 	
         directory = new File(dirname);
-        if (!directory.existsInternal(directory.path))
+        if (! VMFile.exists(directory.path))
           throw new IOException("System temporary directory "
                                 + directory.getName() + " does not exist.");
-        if (!directory.isDirectoryInternal(directory.path))
+        if (! VMFile.isDirectory(directory.path))
           throw new IOException("System temporary directory "
                                 + directory.getName()
                                 + " is not really a directory.");
@@ -991,7 +922,7 @@
             String filename = prefix + System.currentTimeMillis() + suffix;
             file = new File(directory, filename);
           }
-        while (file.existsInternal(file.path));
+        while (VMFile.exists(file.path));
       }
     else
       {
@@ -1008,7 +939,7 @@
             String filename = prefix + java.lang.Integer.toHexString(n) + suffix;
             file = new File(directory, filename);
           }
-        while (file.existsInternal(file.path));
+        while (VMFile.exists(file.path));
       }
 
     // Verify that we are allowed to create this file
@@ -1018,15 +949,10 @@
 
     // Now create the file and return our file object
     // XXX - FIXME race condition.
-    createInternal(file.getAbsolutePath()); 
+    VMFile.create(file.getAbsolutePath()); 
     return file;
   }
 
-  /*
-   * This native method sets the permissions to make the file read only.
-   */
-  private native boolean setReadOnlyInternal(String path);
-
   /**
    * This method sets the file represented by this object to be read only.
    * A read only file or directory cannot be modified.  Please note that 
@@ -1047,10 +973,10 @@
     checkWrite();
 
     // Test for existence.
-    if (!existsInternal(path))
+    if (! VMFile.exists(path))
       return false;
 
-    return setReadOnlyInternal(path);
+    return VMFile.setReadOnly(path);
   }
 
   /**
@@ -1170,11 +1096,6 @@
     return compareTo((File) obj);
   }
 
-  /*
-   * This native method actually performs the rename.
-   */
-  private native boolean renameToInternal(String target, String dest);
-
   /**
    * This method renames the file represented by this object to the path
    * of the file represented by the argument <code>File</code>.
@@ -1192,14 +1113,9 @@
     checkWrite();
     dest.checkWrite();
     // Call our native rename method
-    return renameToInternal(path, dest.path);
+    return VMFile.renameTo(path, dest.path);
   }
 
-  /*
-   * This method does the actual setting of the modification time.
-   */
-  private native boolean setLastModifiedInternal(String path, long time);
- 
   /**
    * This method sets the modification time on the file to the specified
    * value.  This is specified as the number of seconds since midnight
@@ -1222,7 +1138,7 @@
       throw new IllegalArgumentException("Negative modification time: " + time);
 
     checkWrite();
-    return setLastModifiedInternal(path, time);
+    return VMFile.setLastModified(path, time);
   }
 
   private void checkWrite()
Index: java/io/VMFile.java
===================================================================
RCS file: java/io/VMFile.java
diff -N java/io/VMFile.java
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ java/io/VMFile.java	23 Apr 2004 19:55:44 -0000
@@ -0,0 +1,134 @@
+/* VMFile.java -- Class for methods natively accessing files
+   Copyright (C) 2004  Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+
+package java.io;
+
+import gnu.classpath.Configuration;
+
+
+/**
+ * @author Michael Koch (konqueror@gmx.de)
+ */
+final class VMFile
+{
+	static
+	{
+	  if (Configuration.INIT_LOAD_LIBRARY)
+		{
+		  System.loadLibrary("javaio");
+		}
+	}
+  
+  /*
+   * This native method does the actual work of getting the last file
+   * modification time.  It also does the existence check to avoid the
+   * overhead of a call to exists()
+   */
+  static native long lastModified(String path);
+
+  /*
+   * This native method sets the permissions to make the file read only.
+   */
+  static native boolean setReadOnly(String path);
+
+  /**
+   * This method is used to create a temporary file
+   */
+  static native boolean create(String name) throws IOException;
+
+  /*
+   * This native function actually produces the list of file in this
+   * directory
+   */
+  static native String[] list(String dirname);
+
+  /*
+   * This native method actually performs the rename.
+   */
+  static native boolean renameTo(String target, String dest);
+
+  /*
+   * This native method actually determines the length of the file and
+   * handles the existence check
+   */
+  static native long length(String path);
+
+  /*
+   * This native method does the actual checking of file existence.
+   */
+  static native boolean exists(String path);
+
+  /*
+   * This native method handles the actual deleting of the file
+   */
+  static native boolean delete(String path);
+
+  /*
+   * This method does the actual setting of the modification time.
+   */
+  static native boolean setLastModified(String path, long time);
+
+  /*
+   * This native method actually creates the directory
+   */
+  static native boolean mkdir(String path);
+
+  /*
+   * This native method does the actual check of whether or not a file
+   * is a plain file or not.  It also handles the existence check to
+   * eliminate the overhead of a call to exists()
+   */
+  static native boolean isFile(String path);
+
+  /**
+   * This native method checks file permissions for writing
+   */
+  static synchronized native boolean canWrite(String path);
+
+  /**
+   * This native method checks file permissions for reading
+   */
+  static synchronized native boolean canRead(String path);
+
+  /*
+   * This method does the actual check of whether or not a file is a
+   * directory or not.  It also handle the existence check to eliminate
+   * the overhead of a call to exists()
+   */
+  static native boolean isDirectory(String path);
+}
Index: native/jni/java-io/java_io_File.c
===================================================================
RCS file: native/jni/java-io/java_io_File.c
diff -N native/jni/java-io/java_io_File.c
--- native/jni/java-io/java_io_File.c	9 Apr 2004 14:04:50 -0000	1.13
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,702 +0,0 @@
-/* File.c - Native methods for java.io.File class
-   Copyright (C) 1998, 2004 Free Software Foundation, Inc.
-
-This file is part of GNU Classpath.
-
-GNU Classpath is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2, or (at your option)
-any later version.
- 
-GNU Classpath is distributed in the hope that it will be useful, but
-WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with GNU Classpath; see the file COPYING.  If not, write to the
-Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
-02111-1307 USA.
-
-Linking this library statically or dynamically with other modules is
-making a combined work based on this library.  Thus, the terms and
-conditions of the GNU General Public License cover the whole
-combination.
-
-As a special exception, the copyright holders of this library give you
-permission to link this library with independent modules to produce an
-executable, regardless of the license terms of these independent
-modules, and to copy and distribute the resulting executable under
-terms of your choice, provided that you also meet, for each linked
-independent module, the terms and conditions of the license of that
-module.  An independent module is a module which is not derived from
-or based on this library.  If you modify this library, you may extend
-this exception to your version of the library, but you are not
-obligated to do so.  If you do not wish to do so, delete this
-exception statement from your version. */
-
-/* do not move; needed here because of some macro definitions */
-#include <config.h>
-
-#include <stdio.h>
-#include <stdlib.h>
-
-#include <jni.h>
-#include <jcl.h>
-
-#include "target_native.h"
-#ifndef WITHOUT_FILESYSTEM
-  #include "target_native_file.h"
-#endif
-#include "target_native_math_int.h"
-
-#include "javaio.h"
-
-#include "java_io_File.h"
-
-/*************************************************************************/
-
-/*
- * Method to create an empty file.
- *
- * Class:     java_io_File
- * Method:    createInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_createInternal(JNIEnv *env, jclass clazz, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  filename = JCL_jstring_to_cstring(env, name);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_OPEN_CREATE(filename,fd,result);
-  if (result != TARGET_NATIVE_OK)
-    {
-      /* XXX ??? NYI */
-      if (errno != EEXIST)
-        JCL_ThrowException(env,
-                           "java/io/IOException",
-                           TARGET_NATIVE_LAST_ERROR_STRING());
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if we have read permission on a file.
- *
- * Class:     java_io_File
- * Method:    canReadInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_canReadInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  /* The lazy man's way out.  We actually do open the file for reading
-     briefly to verify it can be done */  
-  TARGET_NATIVE_FILE_OPEN_READ(filename,fd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method checks to see if we have write permission on a file.
- *
- * Class:     java_io_File
- * Method:    canWriteInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_canWriteInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  /* The lazy man's way out.  We actually do open the file for writing
-     briefly to verify it can be done */  
-  TARGET_NATIVE_FILE_OPEN_READWRITE(filename,fd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method makes a file read only.
- *
- * Class:     java_io_File
- * Method:    setReadOnlyInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_setReadOnlyInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_SET_MODE_READONLY(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file exists.
- *
- * Class:     java_io_File
- * Method:    existsInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_existsInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_EXISTS(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file is a "plain" file; that is, not
- * a directory, pipe, etc.
- *
- * Class:     java_io_File
- * Method:    isFileInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_isFileInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_IS_FILE(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file is a directory or not.
- *
- * Class:     java_io_File
- * Method:    isDirectoryInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_isDirectoryInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_IS_DIRECTORY(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns the length of the file.
- *
- * Class:     java_io_File
- * Method:    lengthInternal
- * Signature: (Ljava/lang/String;)J
- */
-
-JNIEXPORT jlong JNICALL
-Java_java_io_File_lengthInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        tmpfd;
-  jlong      length;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
- 
-  /* open file for reading, get size and close file */
-  TARGET_NATIVE_FILE_OPEN_READ(filename,tmpfd,result);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
-  TARGET_NATIVE_FILE_SIZE(tmpfd,length,result);  
-  if (result != TARGET_NATIVE_OK)
-    {
-      TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?length:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns the modification date of the file.
- *
- * Class:     java_io_File
- * Method:    lastModifiedInternal
- * Signature: (Ljava/lang/String;)J
- */
-
-JNIEXPORT jlong JNICALL
-Java_java_io_File_lastModifiedInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  jlong      mtime;
-  int        result;
- 
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
- 
-  TARGET_NATIVE_FILE_GET_LAST_MODIFIED(filename,mtime,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?mtime:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method sets the modification date of the file.
- *
- * Class:     java_io_File
- * Method:    setLastModifiedInternal
- * Signature: (Ljava/lang/String;J)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_setLastModifiedInternal(JNIEnv *env, jobject obj,
-                                          jstring name, jlong newtime)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_SET_LAST_MODIFIED(filename,newtime,result); 
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method deletes a file (actually a name for a file - additional
- * links could exist).
- *
- * Class:     java_io_File
- * Method:    deleteInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_deleteInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_DELETE(filename,result); 
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method creates a directory.
- *
- * Class:     java_io_File
- * Method:    mkdirInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_mkdirInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *pathname;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  pathname = (*env)->GetStringUTFChars(env, name, 0);
-  if (pathname == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_MAKE_DIR(pathname,result);
-  (*env)->ReleaseStringUTFChars(env, name, pathname);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method renames a (link to a) file.
- *
- * Class:     java_io_File
- * Method:    renameToInternal
- * Signature: (Ljava/lang/String;Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_renameToInternal(JNIEnv *env, jobject obj, jstring t, jstring d)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *old_filename, *new_filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  old_filename = (*env)->GetStringUTFChars(env, t, 0);
-  if (old_filename == NULL)
-    {
-      return(0);
-    }
-
-  new_filename = (*env)->GetStringUTFChars(env, d, 0);
-  if (new_filename == NULL)
-    {
-      (*env)->ReleaseStringUTFChars(env, t, old_filename);
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_RENAME(old_filename,new_filename,result);
-  (*env)->ReleaseStringUTFChars(env, d, new_filename);
-  (*env)->ReleaseStringUTFChars(env, t, old_filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns an array of String representing all the files
- * in a directory except "." and "..".
- *
- * Class:     java_io_File
- * Method:    listInternal
- * Signature: (Ljava/lang/String;)[Ljava/lang/String;
- */
-
-JNIEXPORT jobjectArray JNICALL
-Java_java_io_File_listInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const int REALLOC_SIZE = 10;
-
-  const char        *dirname;
-  int               result;
-  char              **filelist;
-  void              *handle;
-  const char        *filename;
-  unsigned long int filelist_count,max_filelist_count;
-  char              **tmp_filelist;
-  jclass            str_clazz;
-  jobjectArray      filearray;
-  unsigned long int i;
-  jstring           str;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  dirname = (*env)->GetStringUTFChars(env, name, 0);
-  if (dirname == NULL)
-    {
-      return(0);
-    }
-
-  /* open directory for reading */
-  TARGET_NATIVE_FILE_OPEN_DIR(dirname,handle,result);
-
-  (*env)->ReleaseStringUTFChars(env, name, dirname);
-
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-
-  /* allocate filelist */
-  filelist = (char **)JCL_malloc(env, sizeof(char *) * REALLOC_SIZE);
-  if (filelist==NULL)
-    {
-      TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
-      return(0);
-    }
-  filelist_count=0;
-  max_filelist_count=REALLOC_SIZE;
-
-  /* read the files from the directory */
-  TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
-  while (result == TARGET_NATIVE_OK)
-    {
-      if ((strcmp(filename, ".")!=0) && (strcmp(filename, "..")!=0))
-        {
-          /* allocate more memory if necessary */
-          if (filelist_count >= max_filelist_count)
-            {
-              tmp_filelist = (char**)JCL_realloc(env,
-                                                 filelist,
-                                                 (max_filelist_count + REALLOC_SIZE) * sizeof(char*));
-              if (tmp_filelist==NULL)
-                {
-                  for (i = 0; i < filelist_count; i++)
-                    {
-                      JCL_free(env,filelist[i]);
-                    }
-                  JCL_free(env,filelist);
-                  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
-                  return(0);
-                }
-              filelist           = tmp_filelist;
-              max_filelist_count += REALLOC_SIZE;
-            }
-
-            /* save entry in list (avoid strdup, because it is not ANSI C, thus difficult to port) */
-            filelist[filelist_count]=(char*)JCL_malloc(env,strlen(filename)+1);
-            assert(filelist[filelist_count]!=NULL);
-            strcpy(filelist[filelist_count],filename);
-            filelist_count++;
-          }
-
-      /* read next directory entry */
-      TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
-    }
-
-  /* close directory */
-  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result); 
-
-  /* put the list of files into a Java String array and return it */
-  str_clazz = (*env)->FindClass(env, "java/lang/String"); 
-  if (str_clazz==NULL)
-    {
-      for (i = 0; i < filelist_count; i++)
-        {
-          JCL_free(env,filelist[i]);
-        }
-      JCL_free(env,filelist);
-      return(0);
-    }
-  filearray = (*env)->NewObjectArray(env, filelist_count, str_clazz, 0);
-  if (filearray==NULL)
-    {
-      for (i = 0; i < filelist_count; i++)
-        {
-          JCL_free(env,filelist[i]);
-        }
-      JCL_free(env,filelist);
-      return(0);
-    }
-  for (i = 0; i < filelist_count; i++)
-    {
-      /* create new string */
-      str = (*env)->NewStringUTF(env, filelist[i]);
-      if (str==NULL) 
-        {
-          /* We don't clean up everything here, but if this failed,
-              something serious happened anyway */
-          for (i = 0; i < filelist_count; i++)
-            {
-              JCL_free(env,filelist[i]);
-            }
-          JCL_free(env,filelist);
-          return(0);
-        }
-
-      /* save into array */
-      (*env)->SetObjectArrayElement(env, filearray, i, str);
-
-      /* delete local reference */
-      (*env)->DeleteLocalRef(env, str);
-    }
-
-  /* free resources */
-  for (i = 0; i < filelist_count; i++)
-    {
-      JCL_free(env,filelist[i]);
-    }
-  JCL_free(env,filelist);
-
-  return(filearray);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
Index: native/jni/java-io/java_io_VMFile.c
===================================================================
RCS file: native/jni/java-io/java_io_VMFile.c
diff -N native/jni/java-io/java_io_VMFile.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ native/jni/java-io/java_io_VMFile.c	23 Apr 2004 19:55:44 -0000
@@ -0,0 +1,702 @@
+/* java_io_VMFile.c - Native methods for java.io.File class
+   Copyright (C) 1998, 2004 Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+/* do not move; needed here because of some macro definitions */
+#include <config.h>
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#include <jni.h>
+#include <jcl.h>
+
+#include "target_native.h"
+#ifndef WITHOUT_FILESYSTEM
+  #include "target_native_file.h"
+#endif
+#include "target_native_math_int.h"
+
+#include "javaio.h"
+
+#include "java_io_VMFile.h"
+
+/*************************************************************************/
+
+/*
+ * Method to create an empty file.
+ *
+ * Class:     java_io_VMFile
+ * Method:    create
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_create(JNIEnv *env, jclass clazz, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  filename = JCL_jstring_to_cstring(env, name);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_OPEN_CREATE(filename,fd,result);
+  if (result != TARGET_NATIVE_OK)
+    {
+      /* XXX ??? NYI */
+      if (errno != EEXIST)
+        JCL_ThrowException(env,
+                           "java/io/IOException",
+                           TARGET_NATIVE_LAST_ERROR_STRING());
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if we have read permission on a file.
+ *
+ * Class:     java_io_VMFile
+ * Method:    canRead
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_canRead(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  /* The lazy man's way out.  We actually do open the file for reading
+     briefly to verify it can be done */  
+  TARGET_NATIVE_FILE_OPEN_READ(filename,fd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if we have write permission on a file.
+ *
+ * Class:     java_io_VMFile
+ * Method:    canWrite
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_canWrite(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  /* The lazy man's way out.  We actually do open the file for writing
+     briefly to verify it can be done */  
+  TARGET_NATIVE_FILE_OPEN_READWRITE(filename,fd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method makes a file read only.
+ *
+ * Class:     java_io_VMFile
+ * Method:    setReadOnly
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_setReadOnly(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_SET_MODE_READONLY(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file exists.
+ *
+ * Class:     java_io_VMFile
+ * Method:    exists
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_exists(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_EXISTS(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file is a "plain" file; that is, not
+ * a directory, pipe, etc.
+ *
+ * Class:     java_io_VMFile
+ * Method:    isFile
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_isFile(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_IS_FILE(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file is a directory or not.
+ *
+ * Class:     java_io_VMFile
+ * Method:    isDirectory
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_isDirectory(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_IS_DIRECTORY(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns the length of the file.
+ *
+ * Class:     java_io_VMFile
+ * Method:    length
+ * Signature: (Ljava/lang/String;)J
+ */
+
+JNIEXPORT jlong JNICALL
+Java_java_io_VMFile_length(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        tmpfd;
+  jlong      length;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+ 
+  /* open file for reading, get size and close file */
+  TARGET_NATIVE_FILE_OPEN_READ(filename,tmpfd,result);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+  TARGET_NATIVE_FILE_SIZE(tmpfd,length,result);  
+  if (result != TARGET_NATIVE_OK)
+    {
+      TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?length:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns the modification date of the file.
+ *
+ * Class:     java_io_VMFile
+ * Method:    lastModified
+ * Signature: (Ljava/lang/String;)J
+ */
+
+JNIEXPORT jlong JNICALL
+Java_java_io_VMFile_lastModified(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  jlong      mtime;
+  int        result;
+ 
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+ 
+  TARGET_NATIVE_FILE_GET_LAST_MODIFIED(filename,mtime,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?mtime:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method sets the modification date of the file.
+ *
+ * Class:     java_io_VMFile
+ * Method:    setLastModified
+ * Signature: (Ljava/lang/String;J)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_setLastModified(JNIEnv *env, jobject obj,
+                                          jstring name, jlong newtime)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_SET_LAST_MODIFIED(filename,newtime,result); 
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method deletes a file (actually a name for a file - additional
+ * links could exist).
+ *
+ * Class:     java_io_VMFile
+ * Method:    delete
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_delete(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_DELETE(filename,result); 
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method creates a directory.
+ *
+ * Class:     java_io_VMFile
+ * Method:    mkdir
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_mkdir(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *pathname;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  pathname = (*env)->GetStringUTFChars(env, name, 0);
+  if (pathname == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_MAKE_DIR(pathname,result);
+  (*env)->ReleaseStringUTFChars(env, name, pathname);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method renames a (link to a) file.
+ *
+ * Class:     java_io_VMFile
+ * Method:    renameTo
+ * Signature: (Ljava/lang/String;Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_VMFile_renameTo(JNIEnv *env, jobject obj, jstring t, jstring d)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *old_filename, *new_filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  old_filename = (*env)->GetStringUTFChars(env, t, 0);
+  if (old_filename == NULL)
+    {
+      return(0);
+    }
+
+  new_filename = (*env)->GetStringUTFChars(env, d, 0);
+  if (new_filename == NULL)
+    {
+      (*env)->ReleaseStringUTFChars(env, t, old_filename);
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_RENAME(old_filename,new_filename,result);
+  (*env)->ReleaseStringUTFChars(env, d, new_filename);
+  (*env)->ReleaseStringUTFChars(env, t, old_filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns an array of String representing all the files
+ * in a directory except "." and "..".
+ *
+ * Class:     java_io_VMFile
+ * Method:    list
+ * Signature: (Ljava/lang/String;)[Ljava/lang/String;
+ */
+
+JNIEXPORT jobjectArray JNICALL
+Java_java_io_VMFile_list(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const int REALLOC_SIZE = 10;
+
+  const char        *dirname;
+  int               result;
+  char              **filelist;
+  void              *handle;
+  const char        *filename;
+  unsigned long int filelist_count,max_filelist_count;
+  char              **tmp_filelist;
+  jclass            str_clazz;
+  jobjectArray      filearray;
+  unsigned long int i;
+  jstring           str;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  dirname = (*env)->GetStringUTFChars(env, name, 0);
+  if (dirname == NULL)
+    {
+      return(0);
+    }
+
+  /* open directory for reading */
+  TARGET_NATIVE_FILE_OPEN_DIR(dirname,handle,result);
+
+  (*env)->ReleaseStringUTFChars(env, name, dirname);
+
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+
+  /* allocate filelist */
+  filelist = (char **)JCL_malloc(env, sizeof(char *) * REALLOC_SIZE);
+  if (filelist==NULL)
+    {
+      TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
+      return(0);
+    }
+  filelist_count=0;
+  max_filelist_count=REALLOC_SIZE;
+
+  /* read the files from the directory */
+  TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
+  while (result == TARGET_NATIVE_OK)
+    {
+      if ((strcmp(filename, ".")!=0) && (strcmp(filename, "..")!=0))
+        {
+          /* allocate more memory if necessary */
+          if (filelist_count >= max_filelist_count)
+            {
+              tmp_filelist = (char**)JCL_realloc(env,
+                                                 filelist,
+                                                 (max_filelist_count + REALLOC_SIZE) * sizeof(char*));
+              if (tmp_filelist==NULL)
+                {
+                  for (i = 0; i < filelist_count; i++)
+                    {
+                      JCL_free(env,filelist[i]);
+                    }
+                  JCL_free(env,filelist);
+                  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
+                  return(0);
+                }
+              filelist           = tmp_filelist;
+              max_filelist_count += REALLOC_SIZE;
+            }
+
+            /* save entry in list (avoid strdup, because it is not ANSI C, thus difficult to port) */
+            filelist[filelist_count]=(char*)JCL_malloc(env,strlen(filename)+1);
+            assert(filelist[filelist_count]!=NULL);
+            strcpy(filelist[filelist_count],filename);
+            filelist_count++;
+          }
+
+      /* read next directory entry */
+      TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
+    }
+
+  /* close directory */
+  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result); 
+
+  /* put the list of files into a Java String array and return it */
+  str_clazz = (*env)->FindClass(env, "java/lang/String"); 
+  if (str_clazz==NULL)
+    {
+      for (i = 0; i < filelist_count; i++)
+        {
+          JCL_free(env,filelist[i]);
+        }
+      JCL_free(env,filelist);
+      return(0);
+    }
+  filearray = (*env)->NewObjectArray(env, filelist_count, str_clazz, 0);
+  if (filearray==NULL)
+    {
+      for (i = 0; i < filelist_count; i++)
+        {
+          JCL_free(env,filelist[i]);
+        }
+      JCL_free(env,filelist);
+      return(0);
+    }
+  for (i = 0; i < filelist_count; i++)
+    {
+      /* create new string */
+      str = (*env)->NewStringUTF(env, filelist[i]);
+      if (str==NULL) 
+        {
+          /* We don't clean up everything here, but if this failed,
+              something serious happened anyway */
+          for (i = 0; i < filelist_count; i++)
+            {
+              JCL_free(env,filelist[i]);
+            }
+          JCL_free(env,filelist);
+          return(0);
+        }
+
+      /* save into array */
+      (*env)->SetObjectArrayElement(env, filearray, i, str);
+
+      /* delete local reference */
+      (*env)->DeleteLocalRef(env, str);
+    }
+
+  /* free resources */
+  for (i = 0; i < filelist_count; i++)
+    {
+      JCL_free(env,filelist[i]);
+    }
+  JCL_free(env,filelist);
+
+  return(filearray);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
Index: include/java_io_File.h
===================================================================
RCS file: include/java_io_File.h
diff -N include/java_io_File.h
--- include/java_io_File.h	30 Jul 2003 16:47:19 -0000	1.2
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,32 +0,0 @@
-/* DO NOT EDIT THIS FILE - it is machine generated */
-
-#ifndef __java_io_File__
-#define __java_io_File__
-
-#include <jni.h>
-
-#ifdef __cplusplus
-extern "C"
-{
-#endif
-
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_isFileInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_isDirectoryInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_canReadInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_canWriteInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_deleteInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_existsInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jlong JNICALL Java_java_io_File_lastModifiedInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jlong JNICALL Java_java_io_File_lengthInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jobjectArray JNICALL Java_java_io_File_listInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_mkdirInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_createInternal (JNIEnv *env, jclass, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_setReadOnlyInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_renameToInternal (JNIEnv *env, jobject, jstring, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_setLastModifiedInternal (JNIEnv *env, jobject, jstring, jlong);
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif /* __java_io_File__ */
Index: include/java_io_VMFile.h
===================================================================
RCS file: include/java_io_VMFile.h
diff -N include/java_io_VMFile.h
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ include/java_io_VMFile.h	23 Apr 2004 19:55:44 -0000
@@ -0,0 +1,32 @@
+/* DO NOT EDIT THIS FILE - it is machine generated */
+
+#ifndef __java_io_VMFile__
+#define __java_io_VMFile__
+
+#include <jni.h>
+
+#ifdef __cplusplus
+extern "C"
+{
+#endif
+
+extern JNIEXPORT jlong JNICALL Java_java_io_VMFile_lastModified (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_setReadOnly (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_create (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jobjectArray JNICALL Java_java_io_VMFile_list (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_renameTo (JNIEnv *env, jclass, jstring, jstring);
+extern JNIEXPORT jlong JNICALL Java_java_io_VMFile_length (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_exists (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_delete (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_setLastModified (JNIEnv *env, jclass, jstring, jlong);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_mkdir (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_isFile (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_canWrite (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_canRead (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_VMFile_isDirectory (JNIEnv *env, jclass, jstring);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* __java_io_VMFile__ */

--Boundary-00=_IeXiAMMl1WCx0EJ--




From MAILER-DAEMON Fri Apr 23 17:47:48 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH8Tt-0006PH-6M
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 17:45:09 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH8Ti-0006Kz-8K
	for classpath@gnu.org; Fri, 23 Apr 2004 17:44:58 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH8Sx-0005d3-Gc
	for classpath@gnu.org; Fri, 23 Apr 2004 17:44:44 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BH8OP-0002RP-5I
	for classpath@gnu.org; Fri, 23 Apr 2004 17:39:29 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i3NLUHFl003363;
	Fri, 23 Apr 2004 17:31:19 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004042317324116116 ; Fri, 23 Apr 2004 17:32:41 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i3NLSSwe024929; Fri, 23 Apr 2004 17:28:28 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.32)
	id 1BH8Dk-0007oX-Ks; Fri, 23 Apr 2004 17:28:28 -0400
Message-ID: <40898A76.4060309@uqam.ca>
Date: Fri, 23 Apr 2004 17:28:22 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040414 Debian/1.6-5
X-Accept-Language: en
MIME-Version: 1.0
To: Michael Koch <konqueror@gmx.de>
References: <200404232207.37055.konqueror@gmx.de>
In-Reply-To: <200404232207.37055.konqueror@gmx.de>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 21:45:07 -0000

This makes no sense whatsoever.  File is NOT VM-specific in any way.

VM*.java should be reserved for the VM interface only.

Etienne


Michael Koch wrote:
> Hi list,
> 
> 
> I started to do some GNU classpath/VM separation work. I decided to 
> split the native methods of java.io.File into its own VM class called 
> java.io.VMFile. The refactoring worked really smooth and so I provide 
> here the patch for discussion. I have one minor nitpick myself VMFile 
> is located in java/io/ currently. Before commiting I will move it to 
> vm/reference/java/io/.
> 
> Please review and comment.
> 
> 
> Michael
> 


-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Fri Apr 23 18:29:11 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH9AU-0000rA-Cp
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 18:29:10 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH980-0008MU-Bc
	for classpath@gnu.org; Fri, 23 Apr 2004 18:26:36 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH95m-0006o9-3q
	for classpath@gnu.org; Fri, 23 Apr 2004 18:24:49 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BH95b-0006iF-OB
	for classpath@gnu.org; Fri, 23 Apr 2004 18:24:07 -0400
Received: (qmail 3001 invoked from network); 23 Apr 2004 22:26:53 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <konqueror@gmx.de>; 23 Apr 2004 22:26:53 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 1131A4F853E; Fri, 23 Apr 2004 16:12:33 -0600 (MDT)
To: Michael Koch <konqueror@gmx.de>
References: <1082715425.3307.46.camel@localhost>
	<200404231250.59041.konqueror@gmx.de>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: PARDON me, am I speaking ENGLISH?
Date: 23 Apr 2004 16:12:32 -0600
In-Reply-To: <200404231250.59041.konqueror@gmx.de>
Message-ID: <87wu46mjhr.fsf@fleche.redhat.com>
Lines: 10
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: gnu.java.net.protocol.file.Handler again (and java.net.URL)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 22:29:03 -0000

>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> We agreed some time ago to not support "sun.net.www.protocol".
Michael> Can you remove this totally from the search path ?

I'd like it if we could also add the inetlib package by default:
`gnu.inet'.  That might not be possible right now since the classes in
the inetlib protocol handler packages don't have the expected names.

Tom



From MAILER-DAEMON Fri Apr 23 18:58:19 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BH9cP-0000KM-3Y
	for mharc-classpath@gnu.org; Fri, 23 Apr 2004 18:58:01 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BH9c8-0008Td-Bv
	for classpath@gnu.org; Fri, 23 Apr 2004 18:57:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BH9bQ-0007sn-Pe
	for classpath@gnu.org; Fri, 23 Apr 2004 18:57:32 -0400
Received: from [219.160.177.9] (helo=asao.gcd.org)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BH9bP-0007pI-S2
	for classpath@gnu.org; Fri, 23 Apr 2004 18:57:00 -0400
Received: (qmail 25703 invoked by uid 10); 24 Apr 2004 07:56:53 +0900
Received: (qmail 4380 invoked by uid 1000); 23 Apr 2004 22:56:38 -0000
Message-ID: <20040423225638.4378.qmail@maczuka.gcd.org>
From: Ito Kazumitsu <kaz@maczuka.gcd.org>
To: GNU Classpath <classpath@gnu.org>
In-reply-to: Your message of "Mon, 19 Apr 2004 06:39:22 JST"
References: <20040417004042.4153.qmail@maczuka.gcd.org>
	<200404171659.21214.konqueror@gmx.de>
	<20040418213923.2029.qmail@maczuka.gcd.org>
User-Agent: EMH/1.10.0 SEMI/1.13.7 (Awazu) FLIM/1.13.2 (Kasanui) Emacs/21.2
	(i386-unknown-freebsd4.7) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.13.7 - "Awazu")
Content-Type: text/plain; charset=US-ASCII
Date: Sat, 24 Apr 2004 07:56:37 +0900
Sender: kaz@maczuka.gcd.org
Subject: Re: Sockets remain unclosed
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2004 22:57:49 -0000

>>>>> "+" == Ito Kazumitsu <kaz@maczuka.gcd.org> writes:

+> But java.net.Socket creating redundant sockets is a real problem.
+> Let's look for a solution of this.

This problem could be solved by changing Kaffe's native library.
So nothing is to be done in GNU Classpath about this problem.



From MAILER-DAEMON Sat Apr 24 01:48:12 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHG1M-0005nI-Az
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 01:48:12 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHG1I-0005mw-ND
	for classpath@gnu.org; Sat, 24 Apr 2004 01:48:08 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHG0l-0005NM-SK
	for classpath@gnu.org; Sat, 24 Apr 2004 01:48:07 -0400
Received: from [62.131.71.108] (helo=server.intern.prangsma.net)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BHG0l-0005NC-Cs
	for classpath@gnu.org; Sat, 24 Apr 2004 01:47:35 -0400
Received: (qmail 19675 invoked from network); 24 Apr 2004 05:49:37 -0000
Received: from unknown (HELO lt1epr) (192.168.253.96)
	by 192.168.253.110 with SMTP; 24 Apr 2004 05:49:37 -0000
Message-ID: <003201c429bf$a36787a0$60fda8c0@lt1epr>
From: "Ewout Prangsma" <ewout@prangsma.net>
To: "Michael Koch" <konqueror@gmx.de>,
	<classpath@gnu.org>
References: <200404232207.37055.konqueror@gmx.de>
Date: Sat, 24 Apr 2004 07:47:32 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2800.1409
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Cc: 
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 05:48:09 -0000

Hi Michael,

I think it is really good news that natives are moved to VM specific
classes.

Great!

Ewout

----- Original Message ----- 
From: "Michael Koch" <konqueror@gmx.de>
To: <classpath@gnu.org>
Sent: Friday, April 23, 2004 10:07 PM
Subject: java.io.File and its native methods


> Hi list,
>
>
> I started to do some GNU classpath/VM separation work. I decided to
> split the native methods of java.io.File into its own VM class called
> java.io.VMFile. The refactoring worked really smooth and so I provide
> here the patch for discussion. I have one minor nitpick myself VMFile
> is located in java/io/ currently. Before commiting I will move it to
> vm/reference/java/io/.
>
> Please review and comment.
>
>
> Michael
>


----------------------------------------------------------------------------
----


> _______________________________________________
> Classpath mailing list
> Classpath@gnu.org
> http://mail.gnu.org/mailman/listinfo/classpath
>




From MAILER-DAEMON Sat Apr 24 03:03:45 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHHCS-00064q-MY
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 03:03:44 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHHCP-00063W-Ry
	for classpath@gnu.org; Sat, 24 Apr 2004 03:03:41 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHHBt-0005jF-Bg
	for classpath@gnu.org; Sat, 24 Apr 2004 03:03:40 -0400
Received: from [212.6.122.141] (helo=mail4.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHHBs-0005iR-RN
	for classpath@gnu.org; Sat, 24 Apr 2004 03:03:08 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-185.ewetel.net
	[80.228.95.185])
	by mail4.ewetel.de (8.12.1/8.12.9) with ESMTP id i3O72tB5027997;
	Sat, 24 Apr 2004 09:02:55 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHHCB-0000Pc-00; Sat, 24 Apr 2004 09:03:27 +0200
From: Michael Koch <konqueror@gmx.de>
To: tromey@redhat.com
Date: Sat, 24 Apr 2004 09:02:35 +0200
User-Agent: KMail/1.5.4
References: <1082715425.3307.46.camel@localhost>
	<200404231250.59041.konqueror@gmx.de>
	<87wu46mjhr.fsf@fleche.redhat.com>
In-Reply-To: <87wu46mjhr.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404240902.35449.konqueror@gmx.de>
X-CheckCompat: OK
Cc: classpath@gnu.org
Subject: Re: gnu.java.net.protocol.file.Handler again (and java.net.URL)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 07:03:42 -0000

Am Samstag, 24. April 2004 00:12 schrieb Tom Tromey:
> >>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
>
> Michael> We agreed some time ago to not support
> "sun.net.www.protocol". Michael> Can you remove this totally from the
> search path ?
>
> I'd like it if we could also add the inetlib package by default:
> `gnu.inet'.  That might not be possible right now since the classes
> in the inetlib protocol handler packages don't have the expected
> names.

Guilhem added "gnu.inet". That is why I suggested the remove 
"sun.net.www.protocol" at once with the other change.


Michael




From MAILER-DAEMON Sat Apr 24 03:07:52 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHHGS-0002UU-2m
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 03:07:52 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHHGM-0002KH-CR
	for classpath@gnu.org; Sat, 24 Apr 2004 03:07:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHHFn-0001GO-RK
	for classpath@gnu.org; Sat, 24 Apr 2004 03:07:43 -0400
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHHFh-0001CL-Fx
	for classpath@gnu.org; Sat, 24 Apr 2004 03:07:05 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-185.ewetel.net
	[80.228.95.185])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id i3O76Tpc002931;
	Sat, 24 Apr 2004 09:06:32 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHHFd-0000Pz-00; Sat, 24 Apr 2004 09:07:01 +0200
From: Michael Koch <konqueror@gmx.de>
To: Ito Kazumitsu <kaz@maczuka.gcd.org>, GNU Classpath <classpath@gnu.org>
Date: Sat, 24 Apr 2004 09:06:09 +0200
User-Agent: KMail/1.5.4
References: <20040417004042.4153.qmail@maczuka.gcd.org>
	<20040418213923.2029.qmail@maczuka.gcd.org>
	<20040423225638.4378.qmail@maczuka.gcd.org>
In-Reply-To: <20040423225638.4378.qmail@maczuka.gcd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Disposition: inline
Message-Id: <200404240906.09314.konqueror@gmx.de>
X-CheckCompat: OK
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mail1.ewetel.de id
	i3O76Tpc002931
Cc: 
Subject: Re: Sockets remain unclosed
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 07:07:47 -0000

Am Samstag, 24. April 2004 00:56 schrieb Ito Kazumitsu:
> >>>>> "+" =3D=3D Ito Kazumitsu <kaz@maczuka.gcd.org> writes:
>
> +> But java.net.Socket creating redundant sockets is a real problem.
> +> Let's look for a solution of this.
>
> This problem could be solved by changing Kaffe's native library.
> So nothing is to be done in GNU Classpath about this problem.

Sorry that I dont write a message to you. This bug is fixed by changing=20
java code. The problem was that Socket.getImpl() was called too much.
I wrote this little patch and Helmer Kr=E4mer said it works for him with=20
this change:

http://mail.gnu.org/archive/html/commit-classpath/2004-04/msg00176.html


Michael




From MAILER-DAEMON Sat Apr 24 03:09:16 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHHHn-0003Qy-Uw
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 03:09:15 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHHHj-0003Kt-0S
	for classpath@gnu.org; Sat, 24 Apr 2004 03:09:11 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHHH7-0002vg-Oy
	for classpath@gnu.org; Sat, 24 Apr 2004 03:09:05 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BHHH7-0002cu-7k
	for classpath@gnu.org; Sat, 24 Apr 2004 03:08:33 -0400
Received: from [212.6.122.126] (helo=mail3.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BHH4N-0007lr-4w
	for classpath@gnu.org; Sat, 24 Apr 2004 02:55:23 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-185.ewetel.net
	[80.228.95.185])
	by mail3.ewetel.de (8.12.1/8.12.9) with ESMTP id i3O6tCnV019983;
	Sat, 24 Apr 2004 08:55:13 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHH4i-0000Iz-00; Sat, 24 Apr 2004 08:55:44 +0200
From: Michael Koch <konqueror@gmx.de>
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Date: Sat, 24 Apr 2004 08:54:50 +0200
User-Agent: KMail/1.5.4
References: <200404232207.37055.konqueror@gmx.de> <40898A76.4060309@uqam.ca>
In-Reply-To: <40898A76.4060309@uqam.ca>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404240854.51443.konqueror@gmx.de>
X-CheckCompat: OK
Cc: classpath@gnu.org
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 07:09:11 -0000

Am Freitag, 23. April 2004 23:28 schrieb Etienne Gagnon:
> This makes no sense whatsoever.  File is NOT VM-specific in any way.
>
> VM*.java should be reserved for the VM interface only.

The idea is to get native methods out of normal classes to make it 
possible for some JVMs to use GNU classpath at all. This is the VM 
interface in my opinion because some VMs dont wanna use our native 
methods at all and currently they have to replace java.io.File. That 
would be really bad and they have to take a look at each change in 
java.io.File on each new release.


Michael 


> Etienne
>
> Michael Koch wrote:
> > Hi list,
> >
> >
> > I started to do some GNU classpath/VM separation work. I decided to
> > split the native methods of java.io.File into its own VM class
> > called java.io.VMFile. The refactoring worked really smooth and so
> > I provide here the patch for discussion. I have one minor nitpick
> > myself VMFile is located in java/io/ currently. Before commiting I
> > will move it to vm/reference/java/io/.
> >
> > Please review and comment.
> >
> >
> > Michael




From MAILER-DAEMON Sat Apr 24 03:13:56 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHHMK-0004Yr-G2
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 03:13:56 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHHI3-0003eE-Nb
	for classpath@gnu.org; Sat, 24 Apr 2004 03:09:31 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHHH6-0002vB-6j
	for classpath@gnu.org; Sat, 24 Apr 2004 03:09:03 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BHHH5-0002cu-OC
	for classpath@gnu.org; Sat, 24 Apr 2004 03:08:31 -0400
Received: from [212.6.122.141] (helo=mail4.ewetel.de)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BHH4r-0007pB-9M
	for classpath@gnu.org; Sat, 24 Apr 2004 02:55:53 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-185.ewetel.net
	[80.228.95.185])
	by mail4.ewetel.de (8.12.1/8.12.9) with ESMTP id i3O6tlB5023909;
	Sat, 24 Apr 2004 08:55:48 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHH5H-0000J5-00; Sat, 24 Apr 2004 08:56:19 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Ewout Prangsma" <ewout@prangsma.net>, <classpath@gnu.org>
Date: Sat, 24 Apr 2004 08:55:27 +0200
User-Agent: KMail/1.5.4
References: <200404232207.37055.konqueror@gmx.de>
	<003201c429bf$a36787a0$60fda8c0@lt1epr>
In-Reply-To: <003201c429bf$a36787a0$60fda8c0@lt1epr>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404240855.27949.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 07:13:45 -0000

Am Samstag, 24. April 2004 07:47 schrieb Ewout Prangsma:
> Hi Michael,
>
> I think it is really good news that natives are moved to VM specific
> classes.
>
> Great!

Thanks,


Michael




From MAILER-DAEMON Sat Apr 24 03:52:41 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHHxo-0006nX-5C
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 03:52:40 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHHxa-0006js-0k
	for classpath@gnu.org; Sat, 24 Apr 2004 03:52:26 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHHwz-0006BM-Hn
	for classpath@gnu.org; Sat, 24 Apr 2004 03:52:21 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHHwy-00066K-T4
	for classpath@gnu.org; Sat, 24 Apr 2004 03:51:49 -0400
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Sat, 24 Apr 2004 09:51:24 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADEB0@LEMBU.sumatrasoftware.com>
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: java.io.File and its native methods
Thread-Index: AcQpcF7L22KD1Q5vRkSAjIzOOQ+5PAAX0TjQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Michael Koch" <konqueror@gmx.de>,
	<classpath@gnu.org>
Cc: 
Subject: RE: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 07:52:28 -0000

Michael Koch wrote:
> I started to do some GNU classpath/VM separation work. I decided to=20
> split the native methods of java.io.File into its own VM class called=20
> java.io.VMFile. The refactoring worked really smooth and so I provide=20
> here the patch for discussion. I have one minor nitpick myself VMFile=20
> is located in java/io/ currently. Before commiting I will move it to=20
> vm/reference/java/io/.
>=20
> Please review and comment.

Thanks! Looks good. I would like to see three additional changes: 1)
Move the caseSenstive flag to VMFile, 2) Move listRoots to VMFile, 3)
Move isHidden to VMFile. The current implementations can be moved to
VMFile as is.

Regards,
Jeroen



From MAILER-DAEMON Sat Apr 24 04:09:42 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHIEG-0001WR-EP
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 04:09:40 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHIDy-0001BT-6v
	for classpath@gnu.org; Sat, 24 Apr 2004 04:09:22 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHIDP-0000OR-Vk
	for classpath@gnu.org; Sat, 24 Apr 2004 04:09:19 -0400
Received: from [199.232.41.8] (helo=mx20.gnu.org)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BHID9-0007sC-20
	for classpath@gnu.org; Sat, 24 Apr 2004 04:08:31 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by mx20.gnu.org with esmtp (Exim 4.30) id 1BHI3m-00060P-Ji
	for classpath@gnu.org; Sat, 24 Apr 2004 03:58:50 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BHI3T-0007UF-00; Sat, 24 Apr 2004 09:58:31 +0200
From: Mark Wielaard <mark@klomp.org>
To: Michael Koch <konqueror@gmx.de>
In-Reply-To: <200404240854.51443.konqueror@gmx.de>
References: <200404232207.37055.konqueror@gmx.de> <40898A76.4060309@uqam.ca>
	<200404240854.51443.konqueror@gmx.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-1DE1mhSp26GN0rbEfDBX"
Message-Id: <1082793513.27234.382.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Sat, 24 Apr 2004 09:58:33 +0200
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>, classpath@gnu.org
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 08:09:34 -0000


--=-1DE1mhSp26GN0rbEfDBX
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi Etienne,

On Sat, 2004-04-24 at 08:54, Michael Koch wrote:
> Am Freitag, 23. April 2004 23:28 schrieb Etienne Gagnon:
> > This makes no sense whatsoever.  File is NOT VM-specific in any way.
> >
> > VM*.java should be reserved for the VM interface only.
>=20
> The idea is to get native methods out of normal classes to make it=20
> possible for some JVMs to use GNU classpath at all. This is the VM=20
> interface in my opinion because some VMs dont wanna use our native=20
> methods at all and currently they have to replace java.io.File. That=20
> would be really bad and they have to take a look at each change in=20
> java.io.File on each new release.

I agree in general with Michael. Although I have not yet taken a close
look at the patch he suggests (sorry). Could you be more specific about
why you say that it makes no sense whatsoever? If you are talking about
naming then I agree that VMFile might not be the most appropriate, but
we haven't come up with something better. Anthony Green once suggested
PlatformFile(Descriptor), maybe that describes better what/why we want
the split here.

The reason GNU Classpath has different layers and interfaces is so we
can more easily switch underlying implementations, see how/where the
platform dependent parts are and give people the opportunity to create
different platform specific things or optimizations.

I know that you (or pure JNI based implementations) and gcj (or pure CNI
based implementations) don't really care about this. "native is native."
But that is not really true (even between native JNI and native CNI
there are different trade offs when or how many "native" methods to
create for what). When someone wants to do most things in (pure or
extended) java or say Oberon then marking all core methods native
doesn't really help. And it prevents people from choosing a different
optimization strategy from the core implementation. I agree that if this
becomes a maintenance nightmare we might want to reconsider. But in
general it just looks like good common sense engineering describing
implementation dependent or optimization points.

I have tried to describe some of the different GNU Classpath layers in a
short workshop that we did last year at Linux Kongress.
"Hacking on the VM Interface"
http://klomp.org/mark/classpath/slides/gnu_classpath_workshop.html

It would be a good idea to have more of this explicit in the VM
Integration Guide. (doc/integration.texi is unfortunately hopelessly
out of date.)

Cheers,

Mark

--=-1DE1mhSp26GN0rbEfDBX
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAih4oxVhZCJWr9QwRAqo4AJ4ubOT/o927NGduLFnQUjx2T7X2OwCfVsJ8
FlnWIBFENnOZ2OL5Y06e8g4=
=eT5K
-----END PGP SIGNATURE-----

--=-1DE1mhSp26GN0rbEfDBX--




From MAILER-DAEMON Sat Apr 24 05:45:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHJj5-0001xo-Gh
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 05:45:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHJin-0001sD-3N
	for classpath@gnu.org; Sat, 24 Apr 2004 05:45:17 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHJi4-0001cf-NG
	for classpath@gnu.org; Sat, 24 Apr 2004 05:45:05 -0400
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHJi3-0001bT-BN
	for classpath@gnu.org; Sat, 24 Apr 2004 05:44:31 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-185.ewetel.net
	[80.228.95.185])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id i3O9iMpc022616;
	Sat, 24 Apr 2004 11:44:23 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHJiR-0000gO-00; Sat, 24 Apr 2004 11:44:55 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Jeroen Frijters" <jeroen@sumatra.nl>, <classpath@gnu.org>
Date: Sat, 24 Apr 2004 11:44:02 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADEB0@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADEB0@LEMBU.sumatrasoftware.com>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_ibjiA81zD/PzYVl"
Message-Id: <200404241144.02800.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 09:45:20 -0000


--Boundary-00=_ibjiA81zD/PzYVl
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Am Samstag, 24. April 2004 09:51 schrieb Jeroen Frijters:
> Michael Koch wrote:
> > I started to do some GNU classpath/VM separation work. I decided to
> > split the native methods of java.io.File into its own VM class
> > called java.io.VMFile. The refactoring worked really smooth and so
> > I provide here the patch for discussion. I have one minor nitpick
> > myself VMFile is located in java/io/ currently. Before commiting I
> > will move it to vm/reference/java/io/.
> >
> > Please review and comment.
>
> Thanks! Looks good. I would like to see three additional changes: 1)
> Move the caseSenstive flag to VMFile, 2) Move listRoots to VMFile, 3)
> Move isHidden to VMFile. The current implementations can be moved to
> VMFile as is.

Here is an updated patch. It uses PlatformFile insteam of VMFile and 
moved add the things you request to it too.


Michael


2004-04-24  Michael Koch  <konqueror@gmx.de>

	* java/io/File.java: Moved all native methods to the new class
	PlatformFile and removed the "Internal" suffix.
	* java/io/PlatformFile.java: New file.
	* java/io/Makefile.am (EXTRA_DIST): Added PlatformFile.java.
	* native/jni/java-io/java_io_File.c: Moved all methods to
	java_io_PlatformFile.c and renamed them accordingly.
	* native/jni/java-io/java_io_PlatformFile.c: New file.
	* include/java_io_File.h: Removed.
	* include/java_io_PlatformFile.h: New file.


--Boundary-00=_ibjiA81zD/PzYVl
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="vmfile.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="vmfile.diff"

Index: java/io/File.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/File.java,v
retrieving revision 1.42
diff -u -r1.42 File.java
--- java/io/File.java	20 Apr 2004 16:29:11 -0000	1.42
+++ java/io/File.java	24 Apr 2004 09:41:47 -0000
@@ -41,7 +41,7 @@
 
 import java.net.MalformedURLException;
 import java.net.URL;
-import gnu.classpath.Configuration;
+
 import gnu.java.io.PlatformHelper;
 
 /* Written using "Java Class Libraries", 2nd edition, ISBN 0-201-31002-3
@@ -92,49 +92,12 @@
    */
   public static final char pathSeparatorChar = pathSeparator.charAt(0);
 
-  static boolean caseSensitive;
-  
-  static
-  {
-    if (Configuration.INIT_LOAD_LIBRARY)
-      {
-        System.loadLibrary("javaio");
-      }
-    
-    // FIXME: We support only caseSensitive filesystems currently.
-    caseSensitive = true;
-  }
-  
   /**
    * This is the path to the file set when the object is created.  It
    * may be an absolute or relative path name.
    */
   private String path;
 
-  /*
-   * This native method does the actual check of whether or not a file
-   * is a plain file or not.  It also handles the existence check to
-   * eliminate the overhead of a call to exists()
-   */
-  private native boolean isFileInternal(String path);
-
-  /*
-   * This method does the actual check of whether or not a file is a
-   * directory or not.  It also handle the existence check to eliminate
-   * the overhead of a call to exists()
-   */
-  private native boolean isDirectoryInternal(String path);
-
-  /**
-   * This native method checks file permissions for reading
-   */
-  private synchronized native boolean canReadInternal(String path);
-
-  /**
-   * This native method checks file permissions for writing
-   */
-  private synchronized native boolean canWriteInternal(String path);
-
   /**
    * This method tests whether or not the current thread is allowed to
    * to read the file pointed to by this object.  This will be true if and
@@ -154,7 +117,7 @@
     if (!exists())
       return false;
 
-    return canReadInternal(path);
+    return PlatformFile.canRead(path);
   }
 
   /**
@@ -177,11 +140,11 @@
     checkWrite();
      
     // Test for existence.  This is required by the spec
-    if (!existsInternal(path))
+    if (! PlatformFile.exists(path))
       return false;
 
-    if (!isDirectoryInternal(path))
-      return canWriteInternal(path);
+    if (!PlatformFile.isDirectory(path))
+      return PlatformFile.canWrite(path);
     else
       try
         {
@@ -221,14 +184,8 @@
   public boolean createNewFile() throws IOException
   {
     checkWrite();
-    return createInternal(path);
+    return PlatformFile.create(path);
   }
- 
-  /*
-   * This native method handles the actual deleting of the file
-   */
-  private native boolean deleteInternal(String path);
-
   /**
    * This method deletes the file represented by this object.  If this file
    * is a directory, it must be empty in order for the delete to succeed.
@@ -245,7 +202,7 @@
     if (s != null)
       s.checkDelete(path);
     
-    return deleteInternal(path);
+    return PlatformFile.delete(path);
   }
 
   /**
@@ -270,17 +227,12 @@
     
     File other = (File) obj;
 
-    if (caseSensitive)
+    if (PlatformFile.caseSensitive)
       return path.equals(other.path);
     else
       return path.equalsIgnoreCase(other.path);
   }
 
-  /*
-   * This native method does the actual checking of file existence.
-   */
-  private native boolean existsInternal(String path);
-
   /**
    * This method tests whether or not the file represented by the object
    * actually exists on the filesystem.
@@ -292,7 +244,7 @@
   public boolean exists()
   {
     checkRead();
-    return existsInternal(path);
+    return PlatformFile.exists(path);
   }
 
   /**
@@ -506,7 +458,7 @@
    */
   public int hashCode()
   {
-    if (caseSensitive)
+    if (PlatformFile.caseSensitive)
       return path.hashCode() ^ 1234321;
     else
       return path.toLowerCase().hashCode() ^ 1234321;
@@ -539,7 +491,7 @@
   public boolean isDirectory()
   {
     checkRead();
-    return isDirectoryInternal(path); 
+    return PlatformFile.isDirectory(path); 
   }
 
   /**
@@ -555,7 +507,7 @@
   public boolean isFile()
   {
     checkRead();
-    return isFileInternal(path);
+    return PlatformFile.isFile(path);
   }
 
   /**
@@ -571,17 +523,9 @@
    */
   public boolean isHidden()
   {
-    // FIXME: this only works on UNIX
-    return getName().startsWith(".");
+    return PlatformFile.isHidden(getName());
   }
 
-  /*
-   * This native method does the actual work of getting the last file
-   * modification time.  It also does the existence check to avoid the
-   * overhead of a call to exists()
-   */
-  private native long lastModifiedInternal(String path);
-
   /**
    * This method returns the last modification time of this file.  The
    * time value returned is an abstract value that should not be interpreted
@@ -598,15 +542,9 @@
   public long lastModified()
   {
     checkRead();
-    return lastModifiedInternal(path);
+    return PlatformFile.lastModified(path);
   }
 
-  /*
-   * This native method actually determines the length of the file and
-   * handles the existence check
-   */
-  private native long lengthInternal(String path);
-
   /**
    * This method returns the length of the file represented by this object,
    * or 0 if the specified file does not exist.
@@ -618,15 +556,9 @@
   public long length()
   {
     checkRead();
-    return lengthInternal(path);
+    return PlatformFile.length(path);
   }
 
-  /*
-   * This native function actually produces the list of file in this
-   * directory
-   */
-  private native String[] listInternal(String dirname);
-
   /**
    * This method returns a array of <code>String</code>'s representing the
    * list of files is then directory represented by this object.  If this
@@ -665,7 +597,7 @@
     if (! dir.exists() || ! dir.isDirectory())
       return null;
     
-    String files[] = listInternal(list_path);
+    String files[] = PlatformFile.list(list_path);
     
     // Check if an error occured in listInternal().
     if (files == null)
@@ -864,11 +796,6 @@
     return new URL("file", "", abspath.replace(separatorChar, '/'));
   }
 
-  /*
-   * This native method actually creates the directory
-   */
-  private native boolean mkdirInternal(String path);
-
   /**
    * This method creates a directory for the path represented by this object.
    *
@@ -880,7 +807,7 @@
   public boolean mkdir()
   {
     checkWrite();
-    return mkdirInternal(PlatformHelper.removeTailSeparator(path));
+    return PlatformFile.mkdir(PlatformHelper.removeTailSeparator(path));
   }
 
   /**
@@ -912,11 +839,6 @@
   }
 
   /**
-   * This method is used to create a temporary file
-   */
-  private static native boolean createInternal(String name) throws IOException;
-
-  /**
    * This method creates a temporary file in the specified directory.  If 
    * the directory name is null, then this method uses the system temporary 
    * directory. The files created are guaranteed not to currently exist and 
@@ -958,10 +880,10 @@
           throw new IOException("Cannot determine system temporary directory"); 
 	
         directory = new File(dirname);
-        if (!directory.existsInternal(directory.path))
+        if (! PlatformFile.exists(directory.path))
           throw new IOException("System temporary directory "
                                 + directory.getName() + " does not exist.");
-        if (!directory.isDirectoryInternal(directory.path))
+        if (! PlatformFile.isDirectory(directory.path))
           throw new IOException("System temporary directory "
                                 + directory.getName()
                                 + " is not really a directory.");
@@ -991,7 +913,7 @@
             String filename = prefix + System.currentTimeMillis() + suffix;
             file = new File(directory, filename);
           }
-        while (file.existsInternal(file.path));
+        while (PlatformFile.exists(file.path));
       }
     else
       {
@@ -1008,7 +930,7 @@
             String filename = prefix + java.lang.Integer.toHexString(n) + suffix;
             file = new File(directory, filename);
           }
-        while (file.existsInternal(file.path));
+        while (PlatformFile.exists(file.path));
       }
 
     // Verify that we are allowed to create this file
@@ -1018,15 +940,10 @@
 
     // Now create the file and return our file object
     // XXX - FIXME race condition.
-    createInternal(file.getAbsolutePath()); 
+    PlatformFile.create(file.getAbsolutePath()); 
     return file;
   }
 
-  /*
-   * This native method sets the permissions to make the file read only.
-   */
-  private native boolean setReadOnlyInternal(String path);
-
   /**
    * This method sets the file represented by this object to be read only.
    * A read only file or directory cannot be modified.  Please note that 
@@ -1047,10 +964,10 @@
     checkWrite();
 
     // Test for existence.
-    if (!existsInternal(path))
+    if (! PlatformFile.exists(path))
       return false;
 
-    return setReadOnlyInternal(path);
+    return PlatformFile.setReadOnly(path);
   }
 
   /**
@@ -1066,9 +983,7 @@
    */
   public static File[] listRoots()
   {
-    File[] roots = new File[1];
-    roots[0] = new File("/");
-    return roots;
+    return PlatformFile.listRoots();
   }
 
   /**
@@ -1138,7 +1053,7 @@
         return 0;
       }
     
-    if (caseSensitive)
+    if (PlatformFile.caseSensitive)
       return p1.compareTo(p2);
     else
       return p1.compareToIgnoreCase(p2);
@@ -1170,11 +1085,6 @@
     return compareTo((File) obj);
   }
 
-  /*
-   * This native method actually performs the rename.
-   */
-  private native boolean renameToInternal(String target, String dest);
-
   /**
    * This method renames the file represented by this object to the path
    * of the file represented by the argument <code>File</code>.
@@ -1192,14 +1102,9 @@
     checkWrite();
     dest.checkWrite();
     // Call our native rename method
-    return renameToInternal(path, dest.path);
+    return PlatformFile.renameTo(path, dest.path);
   }
 
-  /*
-   * This method does the actual setting of the modification time.
-   */
-  private native boolean setLastModifiedInternal(String path, long time);
- 
   /**
    * This method sets the modification time on the file to the specified
    * value.  This is specified as the number of seconds since midnight
@@ -1222,7 +1127,7 @@
       throw new IllegalArgumentException("Negative modification time: " + time);
 
     checkWrite();
-    return setLastModifiedInternal(path, time);
+    return PlatformFile.setLastModified(path, time);
   }
 
   private void checkWrite()
Index: java/io/PlatformFile.java
===================================================================
RCS file: java/io/PlatformFile.java
diff -N java/io/PlatformFile.java
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ java/io/PlatformFile.java	24 Apr 2004 09:41:47 -0000
@@ -0,0 +1,175 @@
+/* PlatformFile.java -- Class for methods natively accessing files
+   Copyright (C) 2004  Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+
+package java.io;
+
+import gnu.classpath.Configuration;
+
+
+
+/**
+ * @author Michael Koch (konqueror@gmx.de)
+ */
+class PlatformFile
+{
+	static boolean caseSensitive;
+	
+	static
+	{
+	  if (Configuration.INIT_LOAD_LIBRARY)
+		{
+		  System.loadLibrary("javaio");
+		}
+    
+		// FIXME: We support only caseSensitive filesystems currently.
+		caseSensitive = true;
+	}
+  
+  /*
+   * This native method does the actual work of getting the last file
+   * modification time.  It also does the existence check to avoid the
+   * overhead of a call to exists()
+   */
+  static native long lastModified(String path);
+
+  /*
+   * This native method sets the permissions to make the file read only.
+   */
+  static native boolean setReadOnly(String path);
+
+  /**
+   * This method is used to create a temporary file
+   */
+  static native boolean create(String name) throws IOException;
+
+  /*
+   * This native function actually produces the list of file in this
+   * directory
+   */
+  static native String[] list(String dirname);
+
+  /*
+   * This native method actually performs the rename.
+   */
+  static native boolean renameTo(String target, String dest);
+
+  /*
+   * This native method actually determines the length of the file and
+   * handles the existence check
+   */
+  static native long length(String path);
+
+  /*
+   * This native method does the actual checking of file existence.
+   */
+  static native boolean exists(String path);
+
+  /*
+   * This native method handles the actual deleting of the file
+   */
+  static native boolean delete(String path);
+
+  /*
+   * This method does the actual setting of the modification time.
+   */
+  static native boolean setLastModified(String path, long time);
+
+  /*
+   * This native method actually creates the directory
+   */
+  static native boolean mkdir(String path);
+
+  /*
+   * This native method does the actual check of whether or not a file
+   * is a plain file or not.  It also handles the existence check to
+   * eliminate the overhead of a call to exists()
+   */
+  static native boolean isFile(String path);
+
+  /**
+   * This native method checks file permissions for writing
+   */
+  static synchronized native boolean canWrite(String path);
+
+  /**
+   * This native method checks file permissions for reading
+   */
+  static synchronized native boolean canRead(String path);
+
+  /*
+   * This method does the actual check of whether or not a file is a
+   * directory or not.  It also handle the existence check to eliminate
+   * the overhead of a call to exists()
+   */
+  static native boolean isDirectory(String path);
+
+  /**
+   * This method returns an array of filesystem roots.  Some operating systems
+   * have volume oriented filesystem.  This method provides a mechanism for
+   * determining which volumes exist.  GNU systems use a single hierarchical
+   * filesystem, so will have only one "/" filesystem root.
+   *
+   * @return An array of <code>File</code> objects for each filesystem root
+   * available.
+   *
+   * @since 1.2
+   */
+  static File[] listRoots()
+  {
+	File[] roots = new File[1];
+	roots[0] = new File("/");
+	return roots;
+  }
+
+  /**
+   * This method tests whether or not this file represents a "hidden" file.
+   * On GNU systems, a file is hidden if its name begins with a "."
+   * character.  Files with these names are traditionally not shown with
+   * directory listing tools.
+   *
+   * @return <code>true</code> if the file is hidden, <code>false</code>
+   * otherwise.
+   *
+   * @since 1.2
+   */
+  static boolean isHidden(String filename)
+  {
+	// FIXME: this only works on UNIX
+	return filename.startsWith(".");
+  }
+}
Index: java/io/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/Makefile.am,v
retrieving revision 1.11
diff -u -r1.11 Makefile.am
--- java/io/Makefile.am	6 May 2002 21:10:52 -0000	1.11
+++ java/io/Makefile.am	24 Apr 2004 09:41:47 -0000
@@ -56,6 +56,7 @@
 PipedOutputStream.java \
 PipedReader.java \
 PipedWriter.java \
+PlatformFile.java \
 PrintStream.java \
 PrintWriter.java \
 PushbackInputStream.java \
Index: native/jni/java-io/java_io_File.c
===================================================================
RCS file: native/jni/java-io/java_io_File.c
diff -N native/jni/java-io/java_io_File.c
--- native/jni/java-io/java_io_File.c	9 Apr 2004 14:04:50 -0000	1.13
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,702 +0,0 @@
-/* File.c - Native methods for java.io.File class
-   Copyright (C) 1998, 2004 Free Software Foundation, Inc.
-
-This file is part of GNU Classpath.
-
-GNU Classpath is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2, or (at your option)
-any later version.
- 
-GNU Classpath is distributed in the hope that it will be useful, but
-WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with GNU Classpath; see the file COPYING.  If not, write to the
-Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
-02111-1307 USA.
-
-Linking this library statically or dynamically with other modules is
-making a combined work based on this library.  Thus, the terms and
-conditions of the GNU General Public License cover the whole
-combination.
-
-As a special exception, the copyright holders of this library give you
-permission to link this library with independent modules to produce an
-executable, regardless of the license terms of these independent
-modules, and to copy and distribute the resulting executable under
-terms of your choice, provided that you also meet, for each linked
-independent module, the terms and conditions of the license of that
-module.  An independent module is a module which is not derived from
-or based on this library.  If you modify this library, you may extend
-this exception to your version of the library, but you are not
-obligated to do so.  If you do not wish to do so, delete this
-exception statement from your version. */
-
-/* do not move; needed here because of some macro definitions */
-#include <config.h>
-
-#include <stdio.h>
-#include <stdlib.h>
-
-#include <jni.h>
-#include <jcl.h>
-
-#include "target_native.h"
-#ifndef WITHOUT_FILESYSTEM
-  #include "target_native_file.h"
-#endif
-#include "target_native_math_int.h"
-
-#include "javaio.h"
-
-#include "java_io_File.h"
-
-/*************************************************************************/
-
-/*
- * Method to create an empty file.
- *
- * Class:     java_io_File
- * Method:    createInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_createInternal(JNIEnv *env, jclass clazz, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  filename = JCL_jstring_to_cstring(env, name);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_OPEN_CREATE(filename,fd,result);
-  if (result != TARGET_NATIVE_OK)
-    {
-      /* XXX ??? NYI */
-      if (errno != EEXIST)
-        JCL_ThrowException(env,
-                           "java/io/IOException",
-                           TARGET_NATIVE_LAST_ERROR_STRING());
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if we have read permission on a file.
- *
- * Class:     java_io_File
- * Method:    canReadInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_canReadInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  /* The lazy man's way out.  We actually do open the file for reading
-     briefly to verify it can be done */  
-  TARGET_NATIVE_FILE_OPEN_READ(filename,fd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method checks to see if we have write permission on a file.
- *
- * Class:     java_io_File
- * Method:    canWriteInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_canWriteInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  /* The lazy man's way out.  We actually do open the file for writing
-     briefly to verify it can be done */  
-  TARGET_NATIVE_FILE_OPEN_READWRITE(filename,fd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method makes a file read only.
- *
- * Class:     java_io_File
- * Method:    setReadOnlyInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_setReadOnlyInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_SET_MODE_READONLY(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file exists.
- *
- * Class:     java_io_File
- * Method:    existsInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_existsInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_EXISTS(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file is a "plain" file; that is, not
- * a directory, pipe, etc.
- *
- * Class:     java_io_File
- * Method:    isFileInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_isFileInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_IS_FILE(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file is a directory or not.
- *
- * Class:     java_io_File
- * Method:    isDirectoryInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_isDirectoryInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_IS_DIRECTORY(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns the length of the file.
- *
- * Class:     java_io_File
- * Method:    lengthInternal
- * Signature: (Ljava/lang/String;)J
- */
-
-JNIEXPORT jlong JNICALL
-Java_java_io_File_lengthInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        tmpfd;
-  jlong      length;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
- 
-  /* open file for reading, get size and close file */
-  TARGET_NATIVE_FILE_OPEN_READ(filename,tmpfd,result);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
-  TARGET_NATIVE_FILE_SIZE(tmpfd,length,result);  
-  if (result != TARGET_NATIVE_OK)
-    {
-      TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?length:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns the modification date of the file.
- *
- * Class:     java_io_File
- * Method:    lastModifiedInternal
- * Signature: (Ljava/lang/String;)J
- */
-
-JNIEXPORT jlong JNICALL
-Java_java_io_File_lastModifiedInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  jlong      mtime;
-  int        result;
- 
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
- 
-  TARGET_NATIVE_FILE_GET_LAST_MODIFIED(filename,mtime,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?mtime:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method sets the modification date of the file.
- *
- * Class:     java_io_File
- * Method:    setLastModifiedInternal
- * Signature: (Ljava/lang/String;J)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_setLastModifiedInternal(JNIEnv *env, jobject obj,
-                                          jstring name, jlong newtime)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_SET_LAST_MODIFIED(filename,newtime,result); 
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method deletes a file (actually a name for a file - additional
- * links could exist).
- *
- * Class:     java_io_File
- * Method:    deleteInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_deleteInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_DELETE(filename,result); 
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method creates a directory.
- *
- * Class:     java_io_File
- * Method:    mkdirInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_mkdirInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *pathname;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  pathname = (*env)->GetStringUTFChars(env, name, 0);
-  if (pathname == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_MAKE_DIR(pathname,result);
-  (*env)->ReleaseStringUTFChars(env, name, pathname);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method renames a (link to a) file.
- *
- * Class:     java_io_File
- * Method:    renameToInternal
- * Signature: (Ljava/lang/String;Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_renameToInternal(JNIEnv *env, jobject obj, jstring t, jstring d)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *old_filename, *new_filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  old_filename = (*env)->GetStringUTFChars(env, t, 0);
-  if (old_filename == NULL)
-    {
-      return(0);
-    }
-
-  new_filename = (*env)->GetStringUTFChars(env, d, 0);
-  if (new_filename == NULL)
-    {
-      (*env)->ReleaseStringUTFChars(env, t, old_filename);
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_RENAME(old_filename,new_filename,result);
-  (*env)->ReleaseStringUTFChars(env, d, new_filename);
-  (*env)->ReleaseStringUTFChars(env, t, old_filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns an array of String representing all the files
- * in a directory except "." and "..".
- *
- * Class:     java_io_File
- * Method:    listInternal
- * Signature: (Ljava/lang/String;)[Ljava/lang/String;
- */
-
-JNIEXPORT jobjectArray JNICALL
-Java_java_io_File_listInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const int REALLOC_SIZE = 10;
-
-  const char        *dirname;
-  int               result;
-  char              **filelist;
-  void              *handle;
-  const char        *filename;
-  unsigned long int filelist_count,max_filelist_count;
-  char              **tmp_filelist;
-  jclass            str_clazz;
-  jobjectArray      filearray;
-  unsigned long int i;
-  jstring           str;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  dirname = (*env)->GetStringUTFChars(env, name, 0);
-  if (dirname == NULL)
-    {
-      return(0);
-    }
-
-  /* open directory for reading */
-  TARGET_NATIVE_FILE_OPEN_DIR(dirname,handle,result);
-
-  (*env)->ReleaseStringUTFChars(env, name, dirname);
-
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-
-  /* allocate filelist */
-  filelist = (char **)JCL_malloc(env, sizeof(char *) * REALLOC_SIZE);
-  if (filelist==NULL)
-    {
-      TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
-      return(0);
-    }
-  filelist_count=0;
-  max_filelist_count=REALLOC_SIZE;
-
-  /* read the files from the directory */
-  TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
-  while (result == TARGET_NATIVE_OK)
-    {
-      if ((strcmp(filename, ".")!=0) && (strcmp(filename, "..")!=0))
-        {
-          /* allocate more memory if necessary */
-          if (filelist_count >= max_filelist_count)
-            {
-              tmp_filelist = (char**)JCL_realloc(env,
-                                                 filelist,
-                                                 (max_filelist_count + REALLOC_SIZE) * sizeof(char*));
-              if (tmp_filelist==NULL)
-                {
-                  for (i = 0; i < filelist_count; i++)
-                    {
-                      JCL_free(env,filelist[i]);
-                    }
-                  JCL_free(env,filelist);
-                  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
-                  return(0);
-                }
-              filelist           = tmp_filelist;
-              max_filelist_count += REALLOC_SIZE;
-            }
-
-            /* save entry in list (avoid strdup, because it is not ANSI C, thus difficult to port) */
-            filelist[filelist_count]=(char*)JCL_malloc(env,strlen(filename)+1);
-            assert(filelist[filelist_count]!=NULL);
-            strcpy(filelist[filelist_count],filename);
-            filelist_count++;
-          }
-
-      /* read next directory entry */
-      TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
-    }
-
-  /* close directory */
-  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result); 
-
-  /* put the list of files into a Java String array and return it */
-  str_clazz = (*env)->FindClass(env, "java/lang/String"); 
-  if (str_clazz==NULL)
-    {
-      for (i = 0; i < filelist_count; i++)
-        {
-          JCL_free(env,filelist[i]);
-        }
-      JCL_free(env,filelist);
-      return(0);
-    }
-  filearray = (*env)->NewObjectArray(env, filelist_count, str_clazz, 0);
-  if (filearray==NULL)
-    {
-      for (i = 0; i < filelist_count; i++)
-        {
-          JCL_free(env,filelist[i]);
-        }
-      JCL_free(env,filelist);
-      return(0);
-    }
-  for (i = 0; i < filelist_count; i++)
-    {
-      /* create new string */
-      str = (*env)->NewStringUTF(env, filelist[i]);
-      if (str==NULL) 
-        {
-          /* We don't clean up everything here, but if this failed,
-              something serious happened anyway */
-          for (i = 0; i < filelist_count; i++)
-            {
-              JCL_free(env,filelist[i]);
-            }
-          JCL_free(env,filelist);
-          return(0);
-        }
-
-      /* save into array */
-      (*env)->SetObjectArrayElement(env, filearray, i, str);
-
-      /* delete local reference */
-      (*env)->DeleteLocalRef(env, str);
-    }
-
-  /* free resources */
-  for (i = 0; i < filelist_count; i++)
-    {
-      JCL_free(env,filelist[i]);
-    }
-  JCL_free(env,filelist);
-
-  return(filearray);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
Index: native/jni/java-io/java_io_PlatformFile.c
===================================================================
RCS file: native/jni/java-io/java_io_PlatformFile.c
diff -N native/jni/java-io/java_io_PlatformFile.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ native/jni/java-io/java_io_PlatformFile.c	24 Apr 2004 09:41:47 -0000
@@ -0,0 +1,702 @@
+/* java_io_PlatformFile.c - Native methods for java.io.File class
+   Copyright (C) 1998, 2004 Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+/* do not move; needed here because of some macro definitions */
+#include <config.h>
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#include <jni.h>
+#include <jcl.h>
+
+#include "target_native.h"
+#ifndef WITHOUT_FILESYSTEM
+  #include "target_native_file.h"
+#endif
+#include "target_native_math_int.h"
+
+#include "javaio.h"
+
+#include "java_io_PlatformFile.h"
+
+/*************************************************************************/
+
+/*
+ * Method to create an empty file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    create
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_create(JNIEnv *env, jclass clazz, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  filename = JCL_jstring_to_cstring(env, name);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_OPEN_CREATE(filename,fd,result);
+  if (result != TARGET_NATIVE_OK)
+    {
+      /* XXX ??? NYI */
+      if (errno != EEXIST)
+        JCL_ThrowException(env,
+                           "java/io/IOException",
+                           TARGET_NATIVE_LAST_ERROR_STRING());
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if we have read permission on a file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    canRead
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_canRead(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  /* The lazy man's way out.  We actually do open the file for reading
+     briefly to verify it can be done */  
+  TARGET_NATIVE_FILE_OPEN_READ(filename,fd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if we have write permission on a file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    canWrite
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_canWrite(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  /* The lazy man's way out.  We actually do open the file for writing
+     briefly to verify it can be done */  
+  TARGET_NATIVE_FILE_OPEN_READWRITE(filename,fd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method makes a file read only.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    setReadOnly
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_setReadOnly(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_SET_MODE_READONLY(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file exists.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    exists
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_exists(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_EXISTS(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file is a "plain" file; that is, not
+ * a directory, pipe, etc.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    isFile
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_isFile(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_IS_FILE(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file is a directory or not.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    isDirectory
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_isDirectory(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_IS_DIRECTORY(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns the length of the file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    length
+ * Signature: (Ljava/lang/String;)J
+ */
+
+JNIEXPORT jlong JNICALL
+Java_java_io_PlatformFile_length(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        tmpfd;
+  jlong      length;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+ 
+  /* open file for reading, get size and close file */
+  TARGET_NATIVE_FILE_OPEN_READ(filename,tmpfd,result);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+  TARGET_NATIVE_FILE_SIZE(tmpfd,length,result);  
+  if (result != TARGET_NATIVE_OK)
+    {
+      TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?length:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns the modification date of the file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    lastModified
+ * Signature: (Ljava/lang/String;)J
+ */
+
+JNIEXPORT jlong JNICALL
+Java_java_io_PlatformFile_lastModified(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  jlong      mtime;
+  int        result;
+ 
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+ 
+  TARGET_NATIVE_FILE_GET_LAST_MODIFIED(filename,mtime,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?mtime:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method sets the modification date of the file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    setLastModified
+ * Signature: (Ljava/lang/String;J)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_setLastModified(JNIEnv *env, jobject obj,
+                                          jstring name, jlong newtime)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_SET_LAST_MODIFIED(filename,newtime,result); 
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method deletes a file (actually a name for a file - additional
+ * links could exist).
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    delete
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_delete(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_DELETE(filename,result); 
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method creates a directory.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    mkdir
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_mkdir(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *pathname;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  pathname = (*env)->GetStringUTFChars(env, name, 0);
+  if (pathname == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_MAKE_DIR(pathname,result);
+  (*env)->ReleaseStringUTFChars(env, name, pathname);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method renames a (link to a) file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    renameTo
+ * Signature: (Ljava/lang/String;Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_renameTo(JNIEnv *env, jobject obj, jstring t, jstring d)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *old_filename, *new_filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  old_filename = (*env)->GetStringUTFChars(env, t, 0);
+  if (old_filename == NULL)
+    {
+      return(0);
+    }
+
+  new_filename = (*env)->GetStringUTFChars(env, d, 0);
+  if (new_filename == NULL)
+    {
+      (*env)->ReleaseStringUTFChars(env, t, old_filename);
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_RENAME(old_filename,new_filename,result);
+  (*env)->ReleaseStringUTFChars(env, d, new_filename);
+  (*env)->ReleaseStringUTFChars(env, t, old_filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns an array of String representing all the files
+ * in a directory except "." and "..".
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    list
+ * Signature: (Ljava/lang/String;)[Ljava/lang/String;
+ */
+
+JNIEXPORT jobjectArray JNICALL
+Java_java_io_PlatformFile_list(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const int REALLOC_SIZE = 10;
+
+  const char        *dirname;
+  int               result;
+  char              **filelist;
+  void              *handle;
+  const char        *filename;
+  unsigned long int filelist_count,max_filelist_count;
+  char              **tmp_filelist;
+  jclass            str_clazz;
+  jobjectArray      filearray;
+  unsigned long int i;
+  jstring           str;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  dirname = (*env)->GetStringUTFChars(env, name, 0);
+  if (dirname == NULL)
+    {
+      return(0);
+    }
+
+  /* open directory for reading */
+  TARGET_NATIVE_FILE_OPEN_DIR(dirname,handle,result);
+
+  (*env)->ReleaseStringUTFChars(env, name, dirname);
+
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+
+  /* allocate filelist */
+  filelist = (char **)JCL_malloc(env, sizeof(char *) * REALLOC_SIZE);
+  if (filelist==NULL)
+    {
+      TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
+      return(0);
+    }
+  filelist_count=0;
+  max_filelist_count=REALLOC_SIZE;
+
+  /* read the files from the directory */
+  TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
+  while (result == TARGET_NATIVE_OK)
+    {
+      if ((strcmp(filename, ".")!=0) && (strcmp(filename, "..")!=0))
+        {
+          /* allocate more memory if necessary */
+          if (filelist_count >= max_filelist_count)
+            {
+              tmp_filelist = (char**)JCL_realloc(env,
+                                                 filelist,
+                                                 (max_filelist_count + REALLOC_SIZE) * sizeof(char*));
+              if (tmp_filelist==NULL)
+                {
+                  for (i = 0; i < filelist_count; i++)
+                    {
+                      JCL_free(env,filelist[i]);
+                    }
+                  JCL_free(env,filelist);
+                  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
+                  return(0);
+                }
+              filelist           = tmp_filelist;
+              max_filelist_count += REALLOC_SIZE;
+            }
+
+            /* save entry in list (avoid strdup, because it is not ANSI C, thus difficult to port) */
+            filelist[filelist_count]=(char*)JCL_malloc(env,strlen(filename)+1);
+            assert(filelist[filelist_count]!=NULL);
+            strcpy(filelist[filelist_count],filename);
+            filelist_count++;
+          }
+
+      /* read next directory entry */
+      TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
+    }
+
+  /* close directory */
+  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result); 
+
+  /* put the list of files into a Java String array and return it */
+  str_clazz = (*env)->FindClass(env, "java/lang/String"); 
+  if (str_clazz==NULL)
+    {
+      for (i = 0; i < filelist_count; i++)
+        {
+          JCL_free(env,filelist[i]);
+        }
+      JCL_free(env,filelist);
+      return(0);
+    }
+  filearray = (*env)->NewObjectArray(env, filelist_count, str_clazz, 0);
+  if (filearray==NULL)
+    {
+      for (i = 0; i < filelist_count; i++)
+        {
+          JCL_free(env,filelist[i]);
+        }
+      JCL_free(env,filelist);
+      return(0);
+    }
+  for (i = 0; i < filelist_count; i++)
+    {
+      /* create new string */
+      str = (*env)->NewStringUTF(env, filelist[i]);
+      if (str==NULL) 
+        {
+          /* We don't clean up everything here, but if this failed,
+              something serious happened anyway */
+          for (i = 0; i < filelist_count; i++)
+            {
+              JCL_free(env,filelist[i]);
+            }
+          JCL_free(env,filelist);
+          return(0);
+        }
+
+      /* save into array */
+      (*env)->SetObjectArrayElement(env, filearray, i, str);
+
+      /* delete local reference */
+      (*env)->DeleteLocalRef(env, str);
+    }
+
+  /* free resources */
+  for (i = 0; i < filelist_count; i++)
+    {
+      JCL_free(env,filelist[i]);
+    }
+  JCL_free(env,filelist);
+
+  return(filearray);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
Index: include/java_io_File.h
===================================================================
RCS file: include/java_io_File.h
diff -N include/java_io_File.h
--- include/java_io_File.h	30 Jul 2003 16:47:19 -0000	1.2
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,32 +0,0 @@
-/* DO NOT EDIT THIS FILE - it is machine generated */
-
-#ifndef __java_io_File__
-#define __java_io_File__
-
-#include <jni.h>
-
-#ifdef __cplusplus
-extern "C"
-{
-#endif
-
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_isFileInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_isDirectoryInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_canReadInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_canWriteInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_deleteInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_existsInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jlong JNICALL Java_java_io_File_lastModifiedInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jlong JNICALL Java_java_io_File_lengthInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jobjectArray JNICALL Java_java_io_File_listInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_mkdirInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_createInternal (JNIEnv *env, jclass, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_setReadOnlyInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_renameToInternal (JNIEnv *env, jobject, jstring, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_setLastModifiedInternal (JNIEnv *env, jobject, jstring, jlong);
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif /* __java_io_File__ */
Index: include/java_io_PlatformFile.h
===================================================================
RCS file: include/java_io_PlatformFile.h
diff -N include/java_io_PlatformFile.h
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ include/java_io_PlatformFile.h	24 Apr 2004 09:41:47 -0000
@@ -0,0 +1,32 @@
+/* DO NOT EDIT THIS FILE - it is machine generated */
+
+#ifndef __java_io_PlatformFile__
+#define __java_io_PlatformFile__
+
+#include <jni.h>
+
+#ifdef __cplusplus
+extern "C"
+{
+#endif
+
+extern JNIEXPORT jlong JNICALL Java_java_io_PlatformFile_lastModified (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_setReadOnly (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_create (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jobjectArray JNICALL Java_java_io_PlatformFile_list (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_renameTo (JNIEnv *env, jclass, jstring, jstring);
+extern JNIEXPORT jlong JNICALL Java_java_io_PlatformFile_length (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_exists (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_delete (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_setLastModified (JNIEnv *env, jclass, jstring, jlong);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_mkdir (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_isFile (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_canWrite (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_canRead (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_isDirectory (JNIEnv *env, jclass, jstring);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* __java_io_PlatformFile__ */

--Boundary-00=_ibjiA81zD/PzYVl--




From MAILER-DAEMON Sat Apr 24 06:16:44 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHKDD-0002o5-3X
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 06:16:43 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHKCx-0002do-Fo
	for classpath@gnu.org; Sat, 24 Apr 2004 06:16:27 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHKCL-0002MY-Pt
	for classpath@gnu.org; Sat, 24 Apr 2004 06:16:21 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHKCK-0002Kg-K1
	for classpath@gnu.org; Sat, 24 Apr 2004 06:15:48 -0400
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Sat, 24 Apr 2004 12:15:39 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADEB1@LEMBU.sumatrasoftware.com>
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: java.io.File and its native methods
Thread-Index: AcQp4S6ByBcnbTwuS2encxIkuGZdEAAA1nHw
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Michael Koch" <konqueror@gmx.de>,
	<classpath@gnu.org>
Cc: 
Subject: RE: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 10:16:37 -0000

Michael Koch wrote:
> Here is an updated patch. It uses PlatformFile insteam of VMFile and=20
> moved add the things you request to it too.

Thanks. However, I think isHidden should pass the entire path instead of
just the name. Otherwise it still won't be possible to call a native
method that figures out if the file is hidden (for file systems where
there is an explicit hidden attribute, instead of the *nix naming
convention).

Regards,
Jeroen



From MAILER-DAEMON Sat Apr 24 06:31:03 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHKQm-00028u-4p
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 06:30:44 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHKPq-0001Vy-Do
	for classpath@gnu.org; Sat, 24 Apr 2004 06:29:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHKPB-00019p-1q
	for classpath@gnu.org; Sat, 24 Apr 2004 06:29:37 -0400
Received: from [212.6.122.105] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHKOS-0000ot-0W
	for classpath@gnu.org; Sat, 24 Apr 2004 06:28:20 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-185.ewetel.net
	[80.228.95.185])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i3OASHR7007771;
	Sat, 24 Apr 2004 12:28:18 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHKOw-0002yW-00; Sat, 24 Apr 2004 12:28:50 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Jeroen Frijters" <jeroen@sumatra.nl>, <classpath@gnu.org>
Date: Sat, 24 Apr 2004 12:27:57 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADEB1@LEMBU.sumatrasoftware.com>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADEB1@LEMBU.sumatrasoftware.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404241227.57625.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 10:30:40 -0000

Am Samstag, 24. April 2004 12:15 schrieb Jeroen Frijters:
> Michael Koch wrote:
> > Here is an updated patch. It uses PlatformFile insteam of VMFile
> > and moved add the things you request to it too.
>
> Thanks. However, I think isHidden should pass the entire path instead
> of just the name. Otherwise it still won't be possible to call a
> native method that figures out if the file is hidden (for file
> systems where there is an explicit hidden attribute, instead of the
> *nix naming convention).

Damn, you are right. I will fix this.


Michael




From MAILER-DAEMON Sat Apr 24 08:02:09 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHLln-0007zx-MU
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 07:56:31 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHLlf-0007lj-CQ
	for classpath@gnu.org; Sat, 24 Apr 2004 07:56:23 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHLio-0006UW-6B
	for classpath@gnu.org; Sat, 24 Apr 2004 07:53:57 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHLim-0006U9-VT
	for classpath@gnu.org; Sat, 24 Apr 2004 07:53:25 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BHLim-0005PM-00
	for <classpath@gnu.org>; Sat, 24 Apr 2004 13:53:24 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHLik-0005PC-00; Sat, 24 Apr 2004 13:53:22 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i3OBrKLT026772;
	Sat, 24 Apr 2004 13:53:21 +0200 (MEST)
Message-ID: <408A552F.2080809@kaffe.org>
Date: Sat, 24 Apr 2004 13:53:19 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <200404232207.37055.konqueror@gmx.de>
	<40898A76.4060309@uqam.ca>	<200404240854.51443.konqueror@gmx.de>
	<1082793513.27234.382.camel@elsschot.wildebeest.org>
In-Reply-To: <1082793513.27234.382.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: Etienne Gagnon <gagnon.etienne_m@uqam.ca>, classpath@gnu.org,
	Michael Koch <konqueror@gmx.de>
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 11:56:28 -0000

Hi Mark, hallo Michael, salut Etienne,

Mark Wielaard wrote:
> Hi Etienne,
> 
> On Sat, 2004-04-24 at 08:54, Michael Koch wrote:
> 
>>Am Freitag, 23. April 2004 23:28 schrieb Etienne Gagnon:
>>
>>>This makes no sense whatsoever.  File is NOT VM-specific in any way.
>>>
>>>VM*.java should be reserved for the VM interface only.
>>
>>The idea is to get native methods out of normal classes to make it 
>>possible for some JVMs to use GNU classpath at all. This is the VM 
>>interface in my opinion because some VMs dont wanna use our native 
>>methods at all and currently they have to replace java.io.File. That 
>>would be really bad and they have to take a look at each change in 
>>java.io.File on each new release.

s/possible/easier :)

If one is not using Classpath's native libs, then merging code back and 
forth is rather painful at times. Encapsulating the native layer in its 
own namespace is helpful in that respect at least, so I'm supportive of 
the idea. It also allows me to encapsulate Classpath-specific library 
names like "javanio" in their own class easily, so that I don't get 
pseudo-diffs because our native libraries names' differ from Classpath's.

I'm not sure what the precise naming semantics are, maybe it would make 
sense to have interface that must be implemented by a VM into VM* 
classes, and classes that can be implemented natively in a different 
fashion in their own Platform* or Native* namespace. I'd prefer Native* 
since it 'sounds right' when the distinction is made about native methods.

> The reason GNU Classpath has different layers and interfaces is so we
> can more easily switch underlying implementations, see how/where the
> platform dependent parts are and give people the opportunity to create
> different platform specific things or optimizations.

Yes, please! I'd like to have the same change for java.util.zip, for 
example, where some implementations use Classpath's pure java one, and 
others use zlib based ones. Ideally, it should be possible to ship both, 
and let the user/packager/deployer configure that at 
run-time/build-time. With Kaffe's primitive interpreter the pure java 
zip is no fun on slow platforms and lets class loading take awfully long:)

cheers,
dalibor topic



From MAILER-DAEMON Sat Apr 24 08:33:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHMEk-0003Af-Oc
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 08:26:26 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHM7A-0001Mo-SI
	for classpath@gnu.org; Sat, 24 Apr 2004 08:18:36 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHM1I-00008E-2c
	for classpath@gnu.org; Sat, 24 Apr 2004 08:13:03 -0400
Received: from [212.6.122.105] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHM0N-0008GX-5C
	for classpath@gnu.org; Sat, 24 Apr 2004 08:11:35 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-185.ewetel.net
	[80.228.95.185])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i3OCBSR7005234;
	Sat, 24 Apr 2004 14:11:28 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHM0n-0003Dc-00; Sat, 24 Apr 2004 14:12:01 +0200
From: Michael Koch <konqueror@gmx.de>
To: "Jeroen Frijters" <jeroen@sumatra.nl>, <classpath@gnu.org>
Date: Sat, 24 Apr 2004 14:11:07 +0200
User-Agent: KMail/1.5.4
References: <788B535AB1F9CB49BB9C229372B50ACC0ADEB1@LEMBU.sumatrasoftware.com>
	<200404241227.57625.konqueror@gmx.de>
In-Reply-To: <200404241227.57625.konqueror@gmx.de>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_blliA0V57HyLoz0"
Message-Id: <200404241411.07581.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 12:26:21 -0000


--Boundary-00=_blliA0V57HyLoz0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Am Samstag, 24. April 2004 12:27 schrieb Michael Koch:
> Am Samstag, 24. April 2004 12:15 schrieb Jeroen Frijters:
> > Michael Koch wrote:
> > > Here is an updated patch. It uses PlatformFile insteam of VMFile
> > > and moved add the things you request to it too.
> >
> > Thanks. However, I think isHidden should pass the entire path
> > instead of just the name. Otherwise it still won't be possible to
> > call a native method that figures out if the file is hidden (for
> > file systems where there is an explicit hidden attribute, instead
> > of the *nix naming convention).
>
> Damn, you are right. I will fix this.

Here is another update.


Michael


2004-04-24  Michael Koch  <konqueror@gmx.de>

	* java/io/File.java: Moved all native methods to the new class
	PlatformFile and removed the "Internal" suffix.
	* java/io/PlatformFile.java: New file.
	* java/io/Makefile.am (EXTRA_DIST): Added PlatformFile.java.
	* native/jni/java-io/java_io_File.c: Moved all methods to
	java_io_PlatformFile.c and renamed them accordingly.
	* native/jni/java-io/java_io_PlatformFile.c: New file.
	* include/java_io_File.h: Removed.
	* include/java_io_PlatformFile.h: New file.


--Boundary-00=_blliA0V57HyLoz0
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="vmfile.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="vmfile.diff"

Index: java/io/File.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/File.java,v
retrieving revision 1.42
diff -u -r1.42 File.java
--- java/io/File.java	20 Apr 2004 16:29:11 -0000	1.42
+++ java/io/File.java	24 Apr 2004 12:07:22 -0000
@@ -41,7 +41,7 @@
 
 import java.net.MalformedURLException;
 import java.net.URL;
-import gnu.classpath.Configuration;
+
 import gnu.java.io.PlatformHelper;
 
 /* Written using "Java Class Libraries", 2nd edition, ISBN 0-201-31002-3
@@ -92,49 +92,12 @@
    */
   public static final char pathSeparatorChar = pathSeparator.charAt(0);
 
-  static boolean caseSensitive;
-  
-  static
-  {
-    if (Configuration.INIT_LOAD_LIBRARY)
-      {
-        System.loadLibrary("javaio");
-      }
-    
-    // FIXME: We support only caseSensitive filesystems currently.
-    caseSensitive = true;
-  }
-  
   /**
    * This is the path to the file set when the object is created.  It
    * may be an absolute or relative path name.
    */
   private String path;
 
-  /*
-   * This native method does the actual check of whether or not a file
-   * is a plain file or not.  It also handles the existence check to
-   * eliminate the overhead of a call to exists()
-   */
-  private native boolean isFileInternal(String path);
-
-  /*
-   * This method does the actual check of whether or not a file is a
-   * directory or not.  It also handle the existence check to eliminate
-   * the overhead of a call to exists()
-   */
-  private native boolean isDirectoryInternal(String path);
-
-  /**
-   * This native method checks file permissions for reading
-   */
-  private synchronized native boolean canReadInternal(String path);
-
-  /**
-   * This native method checks file permissions for writing
-   */
-  private synchronized native boolean canWriteInternal(String path);
-
   /**
    * This method tests whether or not the current thread is allowed to
    * to read the file pointed to by this object.  This will be true if and
@@ -154,7 +117,7 @@
     if (!exists())
       return false;
 
-    return canReadInternal(path);
+    return PlatformFile.canRead(path);
   }
 
   /**
@@ -177,11 +140,11 @@
     checkWrite();
      
     // Test for existence.  This is required by the spec
-    if (!existsInternal(path))
+    if (! PlatformFile.exists(path))
       return false;
 
-    if (!isDirectoryInternal(path))
-      return canWriteInternal(path);
+    if (!PlatformFile.isDirectory(path))
+      return PlatformFile.canWrite(path);
     else
       try
         {
@@ -221,14 +184,8 @@
   public boolean createNewFile() throws IOException
   {
     checkWrite();
-    return createInternal(path);
+    return PlatformFile.create(path);
   }
- 
-  /*
-   * This native method handles the actual deleting of the file
-   */
-  private native boolean deleteInternal(String path);
-
   /**
    * This method deletes the file represented by this object.  If this file
    * is a directory, it must be empty in order for the delete to succeed.
@@ -245,7 +202,7 @@
     if (s != null)
       s.checkDelete(path);
     
-    return deleteInternal(path);
+    return PlatformFile.delete(path);
   }
 
   /**
@@ -270,17 +227,12 @@
     
     File other = (File) obj;
 
-    if (caseSensitive)
+    if (PlatformFile.caseSensitive)
       return path.equals(other.path);
     else
       return path.equalsIgnoreCase(other.path);
   }
 
-  /*
-   * This native method does the actual checking of file existence.
-   */
-  private native boolean existsInternal(String path);
-
   /**
    * This method tests whether or not the file represented by the object
    * actually exists on the filesystem.
@@ -292,7 +244,7 @@
   public boolean exists()
   {
     checkRead();
-    return existsInternal(path);
+    return PlatformFile.exists(path);
   }
 
   /**
@@ -439,14 +391,7 @@
    */
   public String getName()
   {
-    int pos = PlatformHelper.lastIndexOfSeparator(path);
-    if (pos == -1)
-      return path;
-
-    if (PlatformHelper.endWithSeparator(path))
-      return "";
-
-    return path.substring(pos + separator.length());
+  	return PlatformFile.getName(path);
   }
 
   /**
@@ -506,7 +451,7 @@
    */
   public int hashCode()
   {
-    if (caseSensitive)
+    if (PlatformFile.caseSensitive)
       return path.hashCode() ^ 1234321;
     else
       return path.toLowerCase().hashCode() ^ 1234321;
@@ -539,7 +484,7 @@
   public boolean isDirectory()
   {
     checkRead();
-    return isDirectoryInternal(path); 
+    return PlatformFile.isDirectory(path); 
   }
 
   /**
@@ -555,7 +500,7 @@
   public boolean isFile()
   {
     checkRead();
-    return isFileInternal(path);
+    return PlatformFile.isFile(path);
   }
 
   /**
@@ -571,17 +516,9 @@
    */
   public boolean isHidden()
   {
-    // FIXME: this only works on UNIX
-    return getName().startsWith(".");
+    return PlatformFile.isHidden(path);
   }
 
-  /*
-   * This native method does the actual work of getting the last file
-   * modification time.  It also does the existence check to avoid the
-   * overhead of a call to exists()
-   */
-  private native long lastModifiedInternal(String path);
-
   /**
    * This method returns the last modification time of this file.  The
    * time value returned is an abstract value that should not be interpreted
@@ -598,15 +535,9 @@
   public long lastModified()
   {
     checkRead();
-    return lastModifiedInternal(path);
+    return PlatformFile.lastModified(path);
   }
 
-  /*
-   * This native method actually determines the length of the file and
-   * handles the existence check
-   */
-  private native long lengthInternal(String path);
-
   /**
    * This method returns the length of the file represented by this object,
    * or 0 if the specified file does not exist.
@@ -618,15 +549,9 @@
   public long length()
   {
     checkRead();
-    return lengthInternal(path);
+    return PlatformFile.length(path);
   }
 
-  /*
-   * This native function actually produces the list of file in this
-   * directory
-   */
-  private native String[] listInternal(String dirname);
-
   /**
    * This method returns a array of <code>String</code>'s representing the
    * list of files is then directory represented by this object.  If this
@@ -665,7 +590,7 @@
     if (! dir.exists() || ! dir.isDirectory())
       return null;
     
-    String files[] = listInternal(list_path);
+    String files[] = PlatformFile.list(list_path);
     
     // Check if an error occured in listInternal().
     if (files == null)
@@ -864,11 +789,6 @@
     return new URL("file", "", abspath.replace(separatorChar, '/'));
   }
 
-  /*
-   * This native method actually creates the directory
-   */
-  private native boolean mkdirInternal(String path);
-
   /**
    * This method creates a directory for the path represented by this object.
    *
@@ -880,7 +800,7 @@
   public boolean mkdir()
   {
     checkWrite();
-    return mkdirInternal(PlatformHelper.removeTailSeparator(path));
+    return PlatformFile.mkdir(PlatformHelper.removeTailSeparator(path));
   }
 
   /**
@@ -912,11 +832,6 @@
   }
 
   /**
-   * This method is used to create a temporary file
-   */
-  private static native boolean createInternal(String name) throws IOException;
-
-  /**
    * This method creates a temporary file in the specified directory.  If 
    * the directory name is null, then this method uses the system temporary 
    * directory. The files created are guaranteed not to currently exist and 
@@ -958,10 +873,10 @@
           throw new IOException("Cannot determine system temporary directory"); 
 	
         directory = new File(dirname);
-        if (!directory.existsInternal(directory.path))
+        if (! PlatformFile.exists(directory.path))
           throw new IOException("System temporary directory "
                                 + directory.getName() + " does not exist.");
-        if (!directory.isDirectoryInternal(directory.path))
+        if (! PlatformFile.isDirectory(directory.path))
           throw new IOException("System temporary directory "
                                 + directory.getName()
                                 + " is not really a directory.");
@@ -991,7 +906,7 @@
             String filename = prefix + System.currentTimeMillis() + suffix;
             file = new File(directory, filename);
           }
-        while (file.existsInternal(file.path));
+        while (PlatformFile.exists(file.path));
       }
     else
       {
@@ -1008,7 +923,7 @@
             String filename = prefix + java.lang.Integer.toHexString(n) + suffix;
             file = new File(directory, filename);
           }
-        while (file.existsInternal(file.path));
+        while (PlatformFile.exists(file.path));
       }
 
     // Verify that we are allowed to create this file
@@ -1018,15 +933,10 @@
 
     // Now create the file and return our file object
     // XXX - FIXME race condition.
-    createInternal(file.getAbsolutePath()); 
+    PlatformFile.create(file.getAbsolutePath()); 
     return file;
   }
 
-  /*
-   * This native method sets the permissions to make the file read only.
-   */
-  private native boolean setReadOnlyInternal(String path);
-
   /**
    * This method sets the file represented by this object to be read only.
    * A read only file or directory cannot be modified.  Please note that 
@@ -1047,10 +957,10 @@
     checkWrite();
 
     // Test for existence.
-    if (!existsInternal(path))
+    if (! PlatformFile.exists(path))
       return false;
 
-    return setReadOnlyInternal(path);
+    return PlatformFile.setReadOnly(path);
   }
 
   /**
@@ -1066,9 +976,7 @@
    */
   public static File[] listRoots()
   {
-    File[] roots = new File[1];
-    roots[0] = new File("/");
-    return roots;
+    return PlatformFile.listRoots();
   }
 
   /**
@@ -1138,7 +1046,7 @@
         return 0;
       }
     
-    if (caseSensitive)
+    if (PlatformFile.caseSensitive)
       return p1.compareTo(p2);
     else
       return p1.compareToIgnoreCase(p2);
@@ -1170,11 +1078,6 @@
     return compareTo((File) obj);
   }
 
-  /*
-   * This native method actually performs the rename.
-   */
-  private native boolean renameToInternal(String target, String dest);
-
   /**
    * This method renames the file represented by this object to the path
    * of the file represented by the argument <code>File</code>.
@@ -1192,14 +1095,9 @@
     checkWrite();
     dest.checkWrite();
     // Call our native rename method
-    return renameToInternal(path, dest.path);
+    return PlatformFile.renameTo(path, dest.path);
   }
 
-  /*
-   * This method does the actual setting of the modification time.
-   */
-  private native boolean setLastModifiedInternal(String path, long time);
- 
   /**
    * This method sets the modification time on the file to the specified
    * value.  This is specified as the number of seconds since midnight
@@ -1222,7 +1120,7 @@
       throw new IllegalArgumentException("Negative modification time: " + time);
 
     checkWrite();
-    return setLastModifiedInternal(path, time);
+    return PlatformFile.setLastModified(path, time);
   }
 
   private void checkWrite()
Index: java/io/PlatformFile.java
===================================================================
RCS file: java/io/PlatformFile.java
diff -N java/io/PlatformFile.java
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ java/io/PlatformFile.java	24 Apr 2004 12:07:22 -0000
@@ -0,0 +1,194 @@
+/* PlatformFile.java -- Class for methods natively accessing files
+   Copyright (C) 2004  Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+
+package java.io;
+
+import gnu.classpath.Configuration;
+import gnu.java.io.PlatformHelper;
+
+
+/**
+ * @author Michael Koch (konqueror@gmx.de)
+ */
+class PlatformFile
+{
+	static boolean caseSensitive;
+	
+	static
+	{
+	  if (Configuration.INIT_LOAD_LIBRARY)
+		{
+		  System.loadLibrary("javaio");
+		}
+    
+		// FIXME: We support only caseSensitive filesystems currently.
+		caseSensitive = true;
+	}
+  
+  /*
+   * This native method does the actual work of getting the last file
+   * modification time.  It also does the existence check to avoid the
+   * overhead of a call to exists()
+   */
+  static native long lastModified(String path);
+
+  /*
+   * This native method sets the permissions to make the file read only.
+   */
+  static native boolean setReadOnly(String path);
+
+  /**
+   * This method is used to create a temporary file
+   */
+  static native boolean create(String name) throws IOException;
+
+  /*
+   * This native function actually produces the list of file in this
+   * directory
+   */
+  static native String[] list(String dirname);
+
+  /*
+   * This native method actually performs the rename.
+   */
+  static native boolean renameTo(String target, String dest);
+
+  /*
+   * This native method actually determines the length of the file and
+   * handles the existence check
+   */
+  static native long length(String path);
+
+  /*
+   * This native method does the actual checking of file existence.
+   */
+  static native boolean exists(String path);
+
+  /*
+   * This native method handles the actual deleting of the file
+   */
+  static native boolean delete(String path);
+
+  /*
+   * This method does the actual setting of the modification time.
+   */
+  static native boolean setLastModified(String path, long time);
+
+  /*
+   * This native method actually creates the directory
+   */
+  static native boolean mkdir(String path);
+
+  /*
+   * This native method does the actual check of whether or not a file
+   * is a plain file or not.  It also handles the existence check to
+   * eliminate the overhead of a call to exists()
+   */
+  static native boolean isFile(String path);
+
+  /**
+   * This native method checks file permissions for writing
+   */
+  static synchronized native boolean canWrite(String path);
+
+  /**
+   * This native method checks file permissions for reading
+   */
+  static synchronized native boolean canRead(String path);
+
+  /*
+   * This method does the actual check of whether or not a file is a
+   * directory or not.  It also handle the existence check to eliminate
+   * the overhead of a call to exists()
+   */
+  static native boolean isDirectory(String path);
+
+  /**
+   * This method returns an array of filesystem roots.  Some operating systems
+   * have volume oriented filesystem.  This method provides a mechanism for
+   * determining which volumes exist.  GNU systems use a single hierarchical
+   * filesystem, so will have only one "/" filesystem root.
+   *
+   * @return An array of <code>File</code> objects for each filesystem root
+   * available.
+   *
+   * @since 1.2
+   */
+  static File[] listRoots()
+  {
+	File[] roots = new File[1];
+	roots[0] = new File("/");
+	return roots;
+  }
+
+  /**
+   * This method tests whether or not this file represents a "hidden" file.
+   * On GNU systems, a file is hidden if its name begins with a "."
+   * character.  Files with these names are traditionally not shown with
+   * directory listing tools.
+   *
+   * @return <code>true</code> if the file is hidden, <code>false</code>
+   * otherwise.
+   *
+   * @since 1.2
+   */
+  static boolean isHidden(String path)
+  {
+	// FIXME: this only works on UNIX
+	return getName(path).startsWith(".");
+  }
+
+  /**
+   * This method returns the name of the file.  This is everything in the
+   * complete path of the file after the last instance of the separator
+   * string.
+   *
+   * @return The file name
+   */
+  static String getName(String path)
+  {
+	int pos = PlatformHelper.lastIndexOfSeparator(path);
+	if (pos == -1)
+	  return path;
+	
+	if (PlatformHelper.endWithSeparator(path))
+	  return "";
+	
+	return path.substring(pos + File.separator.length());
+  }
+}
Index: java/io/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/Makefile.am,v
retrieving revision 1.11
diff -u -r1.11 Makefile.am
--- java/io/Makefile.am	6 May 2002 21:10:52 -0000	1.11
+++ java/io/Makefile.am	24 Apr 2004 12:07:22 -0000
@@ -56,6 +56,7 @@
 PipedOutputStream.java \
 PipedReader.java \
 PipedWriter.java \
+PlatformFile.java \
 PrintStream.java \
 PrintWriter.java \
 PushbackInputStream.java \
Index: native/jni/java-io/java_io_File.c
===================================================================
RCS file: native/jni/java-io/java_io_File.c
diff -N native/jni/java-io/java_io_File.c
--- native/jni/java-io/java_io_File.c	9 Apr 2004 14:04:50 -0000	1.13
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,702 +0,0 @@
-/* File.c - Native methods for java.io.File class
-   Copyright (C) 1998, 2004 Free Software Foundation, Inc.
-
-This file is part of GNU Classpath.
-
-GNU Classpath is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2, or (at your option)
-any later version.
- 
-GNU Classpath is distributed in the hope that it will be useful, but
-WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with GNU Classpath; see the file COPYING.  If not, write to the
-Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
-02111-1307 USA.
-
-Linking this library statically or dynamically with other modules is
-making a combined work based on this library.  Thus, the terms and
-conditions of the GNU General Public License cover the whole
-combination.
-
-As a special exception, the copyright holders of this library give you
-permission to link this library with independent modules to produce an
-executable, regardless of the license terms of these independent
-modules, and to copy and distribute the resulting executable under
-terms of your choice, provided that you also meet, for each linked
-independent module, the terms and conditions of the license of that
-module.  An independent module is a module which is not derived from
-or based on this library.  If you modify this library, you may extend
-this exception to your version of the library, but you are not
-obligated to do so.  If you do not wish to do so, delete this
-exception statement from your version. */
-
-/* do not move; needed here because of some macro definitions */
-#include <config.h>
-
-#include <stdio.h>
-#include <stdlib.h>
-
-#include <jni.h>
-#include <jcl.h>
-
-#include "target_native.h"
-#ifndef WITHOUT_FILESYSTEM
-  #include "target_native_file.h"
-#endif
-#include "target_native_math_int.h"
-
-#include "javaio.h"
-
-#include "java_io_File.h"
-
-/*************************************************************************/
-
-/*
- * Method to create an empty file.
- *
- * Class:     java_io_File
- * Method:    createInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_createInternal(JNIEnv *env, jclass clazz, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  filename = JCL_jstring_to_cstring(env, name);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_OPEN_CREATE(filename,fd,result);
-  if (result != TARGET_NATIVE_OK)
-    {
-      /* XXX ??? NYI */
-      if (errno != EEXIST)
-        JCL_ThrowException(env,
-                           "java/io/IOException",
-                           TARGET_NATIVE_LAST_ERROR_STRING());
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if we have read permission on a file.
- *
- * Class:     java_io_File
- * Method:    canReadInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_canReadInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  /* The lazy man's way out.  We actually do open the file for reading
-     briefly to verify it can be done */  
-  TARGET_NATIVE_FILE_OPEN_READ(filename,fd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method checks to see if we have write permission on a file.
- *
- * Class:     java_io_File
- * Method:    canWriteInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_canWriteInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        fd;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  /* The lazy man's way out.  We actually do open the file for writing
-     briefly to verify it can be done */  
-  TARGET_NATIVE_FILE_OPEN_READWRITE(filename,fd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(fd,result);
-
-  return(1);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method makes a file read only.
- *
- * Class:     java_io_File
- * Method:    setReadOnlyInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_setReadOnlyInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_SET_MODE_READONLY(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}  
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file exists.
- *
- * Class:     java_io_File
- * Method:    existsInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_existsInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_EXISTS(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file is a "plain" file; that is, not
- * a directory, pipe, etc.
- *
- * Class:     java_io_File
- * Method:    isFileInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_isFileInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_IS_FILE(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method checks to see if a file is a directory or not.
- *
- * Class:     java_io_File
- * Method:    isDirectoryInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_isDirectoryInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
-
-  TARGET_NATIVE_FILE_IS_DIRECTORY(filename,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns the length of the file.
- *
- * Class:     java_io_File
- * Method:    lengthInternal
- * Signature: (Ljava/lang/String;)J
- */
-
-JNIEXPORT jlong JNICALL
-Java_java_io_File_lengthInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        tmpfd;
-  jlong      length;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
- 
-  /* open file for reading, get size and close file */
-  TARGET_NATIVE_FILE_OPEN_READ(filename,tmpfd,result);
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
-  TARGET_NATIVE_FILE_SIZE(tmpfd,length,result);  
-  if (result != TARGET_NATIVE_OK)
-    {
-      TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
-  TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?length:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns the modification date of the file.
- *
- * Class:     java_io_File
- * Method:    lastModifiedInternal
- * Signature: (Ljava/lang/String;)J
- */
-
-JNIEXPORT jlong JNICALL
-Java_java_io_File_lastModifiedInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  jlong      mtime;
-  int        result;
- 
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-    }
- 
-  TARGET_NATIVE_FILE_GET_LAST_MODIFIED(filename,mtime,result);
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?mtime:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method sets the modification date of the file.
- *
- * Class:     java_io_File
- * Method:    setLastModifiedInternal
- * Signature: (Ljava/lang/String;J)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_setLastModifiedInternal(JNIEnv *env, jobject obj,
-                                          jstring name, jlong newtime)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_SET_LAST_MODIFIED(filename,newtime,result); 
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method deletes a file (actually a name for a file - additional
- * links could exist).
- *
- * Class:     java_io_File
- * Method:    deleteInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_deleteInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  filename = (*env)->GetStringUTFChars(env, name, 0);
-  if (filename == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_DELETE(filename,result); 
-  (*env)->ReleaseStringUTFChars(env, name, filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method creates a directory.
- *
- * Class:     java_io_File
- * Method:    mkdirInternal
- * Signature: (Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_mkdirInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *pathname;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  pathname = (*env)->GetStringUTFChars(env, name, 0);
-  if (pathname == NULL)
-    {
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_MAKE_DIR(pathname,result);
-  (*env)->ReleaseStringUTFChars(env, name, pathname);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method renames a (link to a) file.
- *
- * Class:     java_io_File
- * Method:    renameToInternal
- * Signature: (Ljava/lang/String;Ljava/lang/String;)Z
- */
-
-JNIEXPORT jboolean JNICALL
-Java_java_io_File_renameToInternal(JNIEnv *env, jobject obj, jstring t, jstring d)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const char *old_filename, *new_filename;
-  int        result;
-  
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  old_filename = (*env)->GetStringUTFChars(env, t, 0);
-  if (old_filename == NULL)
-    {
-      return(0);
-    }
-
-  new_filename = (*env)->GetStringUTFChars(env, d, 0);
-  if (new_filename == NULL)
-    {
-      (*env)->ReleaseStringUTFChars(env, t, old_filename);
-      return(0);
-    }
- 
-  TARGET_NATIVE_FILE_RENAME(old_filename,new_filename,result);
-  (*env)->ReleaseStringUTFChars(env, d, new_filename);
-  (*env)->ReleaseStringUTFChars(env, t, old_filename);
-
-  return ((result == TARGET_NATIVE_OK)?1:0);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
-/*************************************************************************/
-
-/*
- * This method returns an array of String representing all the files
- * in a directory except "." and "..".
- *
- * Class:     java_io_File
- * Method:    listInternal
- * Signature: (Ljava/lang/String;)[Ljava/lang/String;
- */
-
-JNIEXPORT jobjectArray JNICALL
-Java_java_io_File_listInternal(JNIEnv *env, jobject obj, jstring name)
-{
-#ifndef WITHOUT_FILESYSTEM
-  const int REALLOC_SIZE = 10;
-
-  const char        *dirname;
-  int               result;
-  char              **filelist;
-  void              *handle;
-  const char        *filename;
-  unsigned long int filelist_count,max_filelist_count;
-  char              **tmp_filelist;
-  jclass            str_clazz;
-  jobjectArray      filearray;
-  unsigned long int i;
-  jstring           str;
-
-  /* Don't use the JCL convert function because it throws an exception
-     on failure */
-  dirname = (*env)->GetStringUTFChars(env, name, 0);
-  if (dirname == NULL)
-    {
-      return(0);
-    }
-
-  /* open directory for reading */
-  TARGET_NATIVE_FILE_OPEN_DIR(dirname,handle,result);
-
-  (*env)->ReleaseStringUTFChars(env, name, dirname);
-
-  if (result != TARGET_NATIVE_OK)
-    {
-      return(0);
-    }
-
-  /* allocate filelist */
-  filelist = (char **)JCL_malloc(env, sizeof(char *) * REALLOC_SIZE);
-  if (filelist==NULL)
-    {
-      TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
-      return(0);
-    }
-  filelist_count=0;
-  max_filelist_count=REALLOC_SIZE;
-
-  /* read the files from the directory */
-  TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
-  while (result == TARGET_NATIVE_OK)
-    {
-      if ((strcmp(filename, ".")!=0) && (strcmp(filename, "..")!=0))
-        {
-          /* allocate more memory if necessary */
-          if (filelist_count >= max_filelist_count)
-            {
-              tmp_filelist = (char**)JCL_realloc(env,
-                                                 filelist,
-                                                 (max_filelist_count + REALLOC_SIZE) * sizeof(char*));
-              if (tmp_filelist==NULL)
-                {
-                  for (i = 0; i < filelist_count; i++)
-                    {
-                      JCL_free(env,filelist[i]);
-                    }
-                  JCL_free(env,filelist);
-                  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
-                  return(0);
-                }
-              filelist           = tmp_filelist;
-              max_filelist_count += REALLOC_SIZE;
-            }
-
-            /* save entry in list (avoid strdup, because it is not ANSI C, thus difficult to port) */
-            filelist[filelist_count]=(char*)JCL_malloc(env,strlen(filename)+1);
-            assert(filelist[filelist_count]!=NULL);
-            strcpy(filelist[filelist_count],filename);
-            filelist_count++;
-          }
-
-      /* read next directory entry */
-      TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
-    }
-
-  /* close directory */
-  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result); 
-
-  /* put the list of files into a Java String array and return it */
-  str_clazz = (*env)->FindClass(env, "java/lang/String"); 
-  if (str_clazz==NULL)
-    {
-      for (i = 0; i < filelist_count; i++)
-        {
-          JCL_free(env,filelist[i]);
-        }
-      JCL_free(env,filelist);
-      return(0);
-    }
-  filearray = (*env)->NewObjectArray(env, filelist_count, str_clazz, 0);
-  if (filearray==NULL)
-    {
-      for (i = 0; i < filelist_count; i++)
-        {
-          JCL_free(env,filelist[i]);
-        }
-      JCL_free(env,filelist);
-      return(0);
-    }
-  for (i = 0; i < filelist_count; i++)
-    {
-      /* create new string */
-      str = (*env)->NewStringUTF(env, filelist[i]);
-      if (str==NULL) 
-        {
-          /* We don't clean up everything here, but if this failed,
-              something serious happened anyway */
-          for (i = 0; i < filelist_count; i++)
-            {
-              JCL_free(env,filelist[i]);
-            }
-          JCL_free(env,filelist);
-          return(0);
-        }
-
-      /* save into array */
-      (*env)->SetObjectArrayElement(env, filearray, i, str);
-
-      /* delete local reference */
-      (*env)->DeleteLocalRef(env, str);
-    }
-
-  /* free resources */
-  for (i = 0; i < filelist_count; i++)
-    {
-      JCL_free(env,filelist[i]);
-    }
-  JCL_free(env,filelist);
-
-  return(filearray);
-#else /* not WITHOUT_FILESYSTEM */
-  return(0);
-#endif /* not WITHOUT_FILESYSTEM */
-}
-
Index: native/jni/java-io/java_io_PlatformFile.c
===================================================================
RCS file: native/jni/java-io/java_io_PlatformFile.c
diff -N native/jni/java-io/java_io_PlatformFile.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ native/jni/java-io/java_io_PlatformFile.c	24 Apr 2004 12:07:22 -0000
@@ -0,0 +1,702 @@
+/* java_io_PlatformFile.c - Native methods for java.io.File class
+   Copyright (C) 1998, 2004 Free Software Foundation, Inc.
+
+This file is part of GNU Classpath.
+
+GNU Classpath is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+ 
+GNU Classpath is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GNU Classpath; see the file COPYING.  If not, write to the
+Free Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+02111-1307 USA.
+
+Linking this library statically or dynamically with other modules is
+making a combined work based on this library.  Thus, the terms and
+conditions of the GNU General Public License cover the whole
+combination.
+
+As a special exception, the copyright holders of this library give you
+permission to link this library with independent modules to produce an
+executable, regardless of the license terms of these independent
+modules, and to copy and distribute the resulting executable under
+terms of your choice, provided that you also meet, for each linked
+independent module, the terms and conditions of the license of that
+module.  An independent module is a module which is not derived from
+or based on this library.  If you modify this library, you may extend
+this exception to your version of the library, but you are not
+obligated to do so.  If you do not wish to do so, delete this
+exception statement from your version. */
+
+/* do not move; needed here because of some macro definitions */
+#include <config.h>
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#include <jni.h>
+#include <jcl.h>
+
+#include "target_native.h"
+#ifndef WITHOUT_FILESYSTEM
+  #include "target_native_file.h"
+#endif
+#include "target_native_math_int.h"
+
+#include "javaio.h"
+
+#include "java_io_PlatformFile.h"
+
+/*************************************************************************/
+
+/*
+ * Method to create an empty file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    create
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_create(JNIEnv *env, jclass clazz, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  filename = JCL_jstring_to_cstring(env, name);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_OPEN_CREATE(filename,fd,result);
+  if (result != TARGET_NATIVE_OK)
+    {
+      /* XXX ??? NYI */
+      if (errno != EEXIST)
+        JCL_ThrowException(env,
+                           "java/io/IOException",
+                           TARGET_NATIVE_LAST_ERROR_STRING());
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if we have read permission on a file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    canRead
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_canRead(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  /* The lazy man's way out.  We actually do open the file for reading
+     briefly to verify it can be done */  
+  TARGET_NATIVE_FILE_OPEN_READ(filename,fd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if we have write permission on a file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    canWrite
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_canWrite(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        fd;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  /* The lazy man's way out.  We actually do open the file for writing
+     briefly to verify it can be done */  
+  TARGET_NATIVE_FILE_OPEN_READWRITE(filename,fd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(fd,result);
+
+  return(1);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method makes a file read only.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    setReadOnly
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_setReadOnly(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_SET_MODE_READONLY(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}  
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file exists.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    exists
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_exists(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_EXISTS(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file is a "plain" file; that is, not
+ * a directory, pipe, etc.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    isFile
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_isFile(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_IS_FILE(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method checks to see if a file is a directory or not.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    isDirectory
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_isDirectory(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+
+  TARGET_NATIVE_FILE_IS_DIRECTORY(filename,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns the length of the file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    length
+ * Signature: (Ljava/lang/String;)J
+ */
+
+JNIEXPORT jlong JNICALL
+Java_java_io_PlatformFile_length(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        tmpfd;
+  jlong      length;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+ 
+  /* open file for reading, get size and close file */
+  TARGET_NATIVE_FILE_OPEN_READ(filename,tmpfd,result);
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+  TARGET_NATIVE_FILE_SIZE(tmpfd,length,result);  
+  if (result != TARGET_NATIVE_OK)
+    {
+      TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+  TARGET_NATIVE_FILE_CLOSE(tmpfd,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?length:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns the modification date of the file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    lastModified
+ * Signature: (Ljava/lang/String;)J
+ */
+
+JNIEXPORT jlong JNICALL
+Java_java_io_PlatformFile_lastModified(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  jlong      mtime;
+  int        result;
+ 
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+    }
+ 
+  TARGET_NATIVE_FILE_GET_LAST_MODIFIED(filename,mtime,result);
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?mtime:TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(TARGET_NATIVE_MATH_INT_INT64_CONST_0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method sets the modification date of the file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    setLastModified
+ * Signature: (Ljava/lang/String;J)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_setLastModified(JNIEnv *env, jobject obj,
+                                          jstring name, jlong newtime)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_SET_LAST_MODIFIED(filename,newtime,result); 
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method deletes a file (actually a name for a file - additional
+ * links could exist).
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    delete
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_delete(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  filename = (*env)->GetStringUTFChars(env, name, 0);
+  if (filename == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_DELETE(filename,result); 
+  (*env)->ReleaseStringUTFChars(env, name, filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method creates a directory.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    mkdir
+ * Signature: (Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_mkdir(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *pathname;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  pathname = (*env)->GetStringUTFChars(env, name, 0);
+  if (pathname == NULL)
+    {
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_MAKE_DIR(pathname,result);
+  (*env)->ReleaseStringUTFChars(env, name, pathname);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method renames a (link to a) file.
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    renameTo
+ * Signature: (Ljava/lang/String;Ljava/lang/String;)Z
+ */
+
+JNIEXPORT jboolean JNICALL
+Java_java_io_PlatformFile_renameTo(JNIEnv *env, jobject obj, jstring t, jstring d)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const char *old_filename, *new_filename;
+  int        result;
+  
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  old_filename = (*env)->GetStringUTFChars(env, t, 0);
+  if (old_filename == NULL)
+    {
+      return(0);
+    }
+
+  new_filename = (*env)->GetStringUTFChars(env, d, 0);
+  if (new_filename == NULL)
+    {
+      (*env)->ReleaseStringUTFChars(env, t, old_filename);
+      return(0);
+    }
+ 
+  TARGET_NATIVE_FILE_RENAME(old_filename,new_filename,result);
+  (*env)->ReleaseStringUTFChars(env, d, new_filename);
+  (*env)->ReleaseStringUTFChars(env, t, old_filename);
+
+  return ((result == TARGET_NATIVE_OK)?1:0);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
+/*************************************************************************/
+
+/*
+ * This method returns an array of String representing all the files
+ * in a directory except "." and "..".
+ *
+ * Class:     java_io_PlatformFile
+ * Method:    list
+ * Signature: (Ljava/lang/String;)[Ljava/lang/String;
+ */
+
+JNIEXPORT jobjectArray JNICALL
+Java_java_io_PlatformFile_list(JNIEnv *env, jobject obj, jstring name)
+{
+#ifndef WITHOUT_FILESYSTEM
+  const int REALLOC_SIZE = 10;
+
+  const char        *dirname;
+  int               result;
+  char              **filelist;
+  void              *handle;
+  const char        *filename;
+  unsigned long int filelist_count,max_filelist_count;
+  char              **tmp_filelist;
+  jclass            str_clazz;
+  jobjectArray      filearray;
+  unsigned long int i;
+  jstring           str;
+
+  /* Don't use the JCL convert function because it throws an exception
+     on failure */
+  dirname = (*env)->GetStringUTFChars(env, name, 0);
+  if (dirname == NULL)
+    {
+      return(0);
+    }
+
+  /* open directory for reading */
+  TARGET_NATIVE_FILE_OPEN_DIR(dirname,handle,result);
+
+  (*env)->ReleaseStringUTFChars(env, name, dirname);
+
+  if (result != TARGET_NATIVE_OK)
+    {
+      return(0);
+    }
+
+  /* allocate filelist */
+  filelist = (char **)JCL_malloc(env, sizeof(char *) * REALLOC_SIZE);
+  if (filelist==NULL)
+    {
+      TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
+      return(0);
+    }
+  filelist_count=0;
+  max_filelist_count=REALLOC_SIZE;
+
+  /* read the files from the directory */
+  TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
+  while (result == TARGET_NATIVE_OK)
+    {
+      if ((strcmp(filename, ".")!=0) && (strcmp(filename, "..")!=0))
+        {
+          /* allocate more memory if necessary */
+          if (filelist_count >= max_filelist_count)
+            {
+              tmp_filelist = (char**)JCL_realloc(env,
+                                                 filelist,
+                                                 (max_filelist_count + REALLOC_SIZE) * sizeof(char*));
+              if (tmp_filelist==NULL)
+                {
+                  for (i = 0; i < filelist_count; i++)
+                    {
+                      JCL_free(env,filelist[i]);
+                    }
+                  JCL_free(env,filelist);
+                  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result);
+                  return(0);
+                }
+              filelist           = tmp_filelist;
+              max_filelist_count += REALLOC_SIZE;
+            }
+
+            /* save entry in list (avoid strdup, because it is not ANSI C, thus difficult to port) */
+            filelist[filelist_count]=(char*)JCL_malloc(env,strlen(filename)+1);
+            assert(filelist[filelist_count]!=NULL);
+            strcpy(filelist[filelist_count],filename);
+            filelist_count++;
+          }
+
+      /* read next directory entry */
+      TARGET_NATIVE_FILE_READ_DIR(handle,filename,result);
+    }
+
+  /* close directory */
+  TARGET_NATIVE_FILE_CLOSE_DIR(handle,result); 
+
+  /* put the list of files into a Java String array and return it */
+  str_clazz = (*env)->FindClass(env, "java/lang/String"); 
+  if (str_clazz==NULL)
+    {
+      for (i = 0; i < filelist_count; i++)
+        {
+          JCL_free(env,filelist[i]);
+        }
+      JCL_free(env,filelist);
+      return(0);
+    }
+  filearray = (*env)->NewObjectArray(env, filelist_count, str_clazz, 0);
+  if (filearray==NULL)
+    {
+      for (i = 0; i < filelist_count; i++)
+        {
+          JCL_free(env,filelist[i]);
+        }
+      JCL_free(env,filelist);
+      return(0);
+    }
+  for (i = 0; i < filelist_count; i++)
+    {
+      /* create new string */
+      str = (*env)->NewStringUTF(env, filelist[i]);
+      if (str==NULL) 
+        {
+          /* We don't clean up everything here, but if this failed,
+              something serious happened anyway */
+          for (i = 0; i < filelist_count; i++)
+            {
+              JCL_free(env,filelist[i]);
+            }
+          JCL_free(env,filelist);
+          return(0);
+        }
+
+      /* save into array */
+      (*env)->SetObjectArrayElement(env, filearray, i, str);
+
+      /* delete local reference */
+      (*env)->DeleteLocalRef(env, str);
+    }
+
+  /* free resources */
+  for (i = 0; i < filelist_count; i++)
+    {
+      JCL_free(env,filelist[i]);
+    }
+  JCL_free(env,filelist);
+
+  return(filearray);
+#else /* not WITHOUT_FILESYSTEM */
+  return(0);
+#endif /* not WITHOUT_FILESYSTEM */
+}
+
Index: include/java_io_File.h
===================================================================
RCS file: include/java_io_File.h
diff -N include/java_io_File.h
--- include/java_io_File.h	30 Jul 2003 16:47:19 -0000	1.2
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,32 +0,0 @@
-/* DO NOT EDIT THIS FILE - it is machine generated */
-
-#ifndef __java_io_File__
-#define __java_io_File__
-
-#include <jni.h>
-
-#ifdef __cplusplus
-extern "C"
-{
-#endif
-
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_isFileInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_isDirectoryInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_canReadInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_canWriteInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_deleteInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_existsInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jlong JNICALL Java_java_io_File_lastModifiedInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jlong JNICALL Java_java_io_File_lengthInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jobjectArray JNICALL Java_java_io_File_listInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_mkdirInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_createInternal (JNIEnv *env, jclass, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_setReadOnlyInternal (JNIEnv *env, jobject, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_renameToInternal (JNIEnv *env, jobject, jstring, jstring);
-extern JNIEXPORT jboolean JNICALL Java_java_io_File_setLastModifiedInternal (JNIEnv *env, jobject, jstring, jlong);
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif /* __java_io_File__ */
Index: include/java_io_PlatformFile.h
===================================================================
RCS file: include/java_io_PlatformFile.h
diff -N include/java_io_PlatformFile.h
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ include/java_io_PlatformFile.h	24 Apr 2004 12:07:22 -0000
@@ -0,0 +1,32 @@
+/* DO NOT EDIT THIS FILE - it is machine generated */
+
+#ifndef __java_io_PlatformFile__
+#define __java_io_PlatformFile__
+
+#include <jni.h>
+
+#ifdef __cplusplus
+extern "C"
+{
+#endif
+
+extern JNIEXPORT jlong JNICALL Java_java_io_PlatformFile_lastModified (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_setReadOnly (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_create (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jobjectArray JNICALL Java_java_io_PlatformFile_list (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_renameTo (JNIEnv *env, jclass, jstring, jstring);
+extern JNIEXPORT jlong JNICALL Java_java_io_PlatformFile_length (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_exists (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_delete (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_setLastModified (JNIEnv *env, jclass, jstring, jlong);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_mkdir (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_isFile (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_canWrite (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_canRead (JNIEnv *env, jclass, jstring);
+extern JNIEXPORT jboolean JNICALL Java_java_io_PlatformFile_isDirectory (JNIEnv *env, jclass, jstring);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* __java_io_PlatformFile__ */

--Boundary-00=_blliA0V57HyLoz0--




From MAILER-DAEMON Sat Apr 24 08:48:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHMaR-0002MH-16
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 08:48:51 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHMaN-0002JO-9a
	for classpath@gnu.org; Sat, 24 Apr 2004 08:48:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHMZp-00021r-9J
	for classpath@gnu.org; Sat, 24 Apr 2004 08:48:45 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHMZo-00021l-UK
	for classpath@gnu.org; Sat, 24 Apr 2004 08:48:13 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i3OCjHF9006911;
	Sat, 24 Apr 2004 08:45:43 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004042408470617885 ; Sat, 24 Apr 2004 08:47:06 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i3OCg6we002105; Sat, 24 Apr 2004 08:42:06 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.32)
	id 1BHMTu-000207-GT; Sat, 24 Apr 2004 08:42:06 -0400
Message-ID: <408A6097.3080102@uqam.ca>
Date: Sat, 24 Apr 2004 08:41:59 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040414 Debian/1.6-5
X-Accept-Language: en
MIME-Version: 1.0
To: Dalibor Topic <robilad@kaffe.org>
References: <200404232207.37055.konqueror@gmx.de>
	<40898A76.4060309@uqam.ca>	<200404240854.51443.konqueror@gmx.de>
	<1082793513.27234.382.camel@elsschot.wildebeest.org>
	<408A552F.2080809@kaffe.org>
In-Reply-To: <408A552F.2080809@kaffe.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Mark Wielaard <mark@klomp.org>, classpath@gnu.org,
	Michael Koch <konqueror@gmx.de>
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 12:48:48 -0000

Dalibor Topic wrote:
> I'm not sure what the precise naming semantics are, maybe it would make 
> sense to have interface that must be implemented by a VM into VM* 
> classes, and classes that can be implemented natively in a different 
> fashion in their own Platform* or Native* namespace. I'd prefer Native* 
> since it 'sounds right' when the distinction is made about native methods.

Dalibor, you understood exactly what I meant: there is a difference between
a native interface and a VM interface.  VM* classes should be reserved for
such things that only a VM can implement (e.g. low-level primitive reflection
functionality).

To classpath maintainers: If you want to separate all native calls to Native*
classes, I don't care, but please do not mix the VM* interface and the
Native* interface.  They are semantically quite different things.  I am suprized
that this is not plain obvious to some of you.

Etienne

-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Sat Apr 24 11:18:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHOvh-00084S-BZ
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 11:18:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHOvd-0007xl-75
	for classpath@gnu.org; Sat, 24 Apr 2004 11:18:53 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHOsI-0006Fp-35
	for classpath@gnu.org; Sat, 24 Apr 2004 11:15:57 -0400
Received: from [212.74.117.6] (helo=dinopsis.arachsys.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHOsH-0006Ei-9r
	for classpath@gnu.org; Sat, 24 Apr 2004 11:15:25 -0400
Received: from dog by dinopsis.arachsys.net with local (Exim 3.35 #1)
	id 1BHOsA-0000Tg-00; Sat, 24 Apr 2004 16:15:18 +0100
Date: Sat, 24 Apr 2004 16:15:18 +0100
From: Chris Burdess <dog@bluezoo.org>
To: Tom Tromey <tromey@redhat.com>
Message-ID: <20040424151518.GA30792@bluezoo.org>
Mail-Followup-To: Tom Tromey <tromey@redhat.com>,
	Michael Koch <konqueror@gmx.de>, classpath@gnu.org
References: <1082715425.3307.46.camel@localhost>
	<200404231250.59041.konqueror@gmx.de>
	<87wu46mjhr.fsf@fleche.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wu46mjhr.fsf@fleche.redhat.com>
User-Agent: Mutt/1.3.28i
X-URL: http://www.bluezoo.org/
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: gnu.java.net.protocol.file.Handler again (and java.net.URL)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 15:18:54 -0000

Tom Tromey wrote:
> I'd like it if we could also add the inetlib package by default:
> `gnu.inet'.  That might not be possible right now since the classes in
> the inetlib protocol handler packages don't have the expected names.

Could you file a bug about that? and I'll correct it ASAP.

I also have generic mailbox and mailto URLConnection classes which use
GNU JavaMail; I can't put these in inetlib for dependency reasons, what
should I do with them?
-- 
Chris Burdess



From MAILER-DAEMON Sat Apr 24 11:37:42 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHPDp-0000HJ-KL
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 11:37:41 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHPDg-0000Ca-7q
	for classpath@gnu.org; Sat, 24 Apr 2004 11:37:32 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHPD9-00082C-8t
	for classpath@gnu.org; Sat, 24 Apr 2004 11:37:30 -0400
Received: from [209.225.28.226] (helo=mxsf26.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHPD8-0007zp-T2
	for classpath@gnu.org; Sat, 24 Apr 2004 11:36:58 -0400
Received: from InterJet.dellroad.org (public.cpe.mvllo.al.charter.com
	[24.196.20.72])
	by mxsf26.cluster1.charter.net (8.12.11/8.12.11) with ESMTP id
	i3OFU35H047849; Sat, 24 Apr 2004 11:30:04 -0400 (EDT)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id KAA14271;
	Sat, 24 Apr 2004 10:26:01 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i3OFQ1OR000875; 
	Sat, 24 Apr 2004 10:26:01 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3OFQ0ER000874;
	Sat, 24 Apr 2004 10:26:00 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404241526.i3OFQ0ER000874@arch20m.dellroad.org>
In-Reply-To: <408A6097.3080102@uqam.ca>
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Date: Sat, 24 Apr 2004 10:26:00 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: Mark Wielaard <mark@klomp.org>, classpath@gnu.org,
	Michael Koch <konqueror@gmx.de>
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 15:37:38 -0000

Etienne Gagnon wrote:
> > I'm not sure what the precise naming semantics are, maybe it would make 
> > sense to have interface that must be implemented by a VM into VM* 
> > classes, and classes that can be implemented natively in a different 
> > fashion in their own Platform* or Native* namespace. I'd prefer Native* 
> > since it 'sounds right' when the distinction is made about native methods.
> 
> Dalibor, you understood exactly what I meant: there is a difference between
> a native interface and a VM interface.  VM* classes should be reserved for
> such things that only a VM can implement (e.g. low-level primitive reflection
> functionality).
> 
> To classpath maintainers: If you want to separate all native calls to Native*
> classes, I don't care, but please do not mix the VM* interface and the
> Native* interface.  They are semantically quite different things.  I am
> suprized that this is not plain obvious to some of you.

Hmm.. I agree that some native routines are more "VM oriented" (or
whatever) than others, but I don't quite see an obvious criterion
for distinguishing between the two. E.g., opening a file descriptor
is a thing that "only a VM can implement" is it not? Moreover, all
VM operations must be implemented via native methods, so at the
least there is a confusion in the naming of things.

Can you describe more explicitly how you would distinguish between
"VM interfaces" and "native interfaces" (and perhaps suggest better
names)?

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Sat Apr 24 12:20:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHPtE-0003Ek-9f
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 12:20:28 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHPt8-0003Ak-0q
	for classpath@gnu.org; Sat, 24 Apr 2004 12:20:22 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHPsV-0002rj-03
	for classpath@gnu.org; Sat, 24 Apr 2004 12:20:14 -0400
Received: from [216.234.116.146] (helo=ops2.one-point.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHPsU-0002qE-DX
	for classpath@gnu.org; Sat, 24 Apr 2004 12:19:42 -0400
Received: from localhost (jsturm@localhost)
	by ops2.one-point.com (8.11.6/8.11.6) with ESMTP id i3OGJbl07504;
	Sat, 24 Apr 2004 12:19:37 -0400
Date: Sat, 24 Apr 2004 12:19:37 -0400 (EDT)
From: Jeff Sturm <jsturm@one-point.com>
To: Tom Tromey <tromey@redhat.com>
In-Reply-To: <87ekqepos5.fsf@fleche.redhat.com>
Message-ID: <Pine.LNX.4.44.0404241127510.5951-100000@ops2.one-point.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: GNU Classpath Project <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 16:20:24 -0000

On 23 Apr 2004, Tom Tromey wrote:
> We really should be able to share the task tags, compiler settings,
> and tab stuff.  I filed a couple Eclipse PRs for this.

That would sure be a useful enhancement to Eclipse.  Meanwhile, perhaps
you could export your preferences and add that to a contrib directory, so
others who want to try classpath with eclipse won't have to recreate all
the preferences.

FWIW I think this is a good idea, even though I don't hack classpath
often.  I don't think of Eclipse as a build system; it cannot replace
ant or make.  It's a pretty useful development tool though.

(What about Mauve?  Much of Eclipse's usefulness for us comes from
interactively running the test suite so we get a very quick
edit/compile/test/debug cycle.  But eclipse only knows about junit-style
tests, not the gnu.testlet classes in Mauve.)

Jeff




From MAILER-DAEMON Sat Apr 24 14:58:58 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHSMb-00011m-9D
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 14:58:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHSMN-0000py-NZ
	for classpath@gnu.org; Sat, 24 Apr 2004 14:58:43 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHSLp-0000KE-Sf
	for classpath@gnu.org; Sat, 24 Apr 2004 14:58:41 -0400
Received: from [62.177.154.238] (helo=lembu.sumatrasoftware.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHSLZ-0008CD-DV
	for classpath@gnu.org; Sat, 24 Apr 2004 14:57:53 -0400
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Sat, 24 Apr 2004 20:57:42 +0200
Message-ID: <788B535AB1F9CB49BB9C229372B50ACC0ADEB2@LEMBU.sumatrasoftware.com>
X-MimeOLE: Produced By Microsoft Exchange V6.5.6944.0
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: java.io.File and its native methods
Thread-Index: AcQp9cWuLXvDDEchR4eu75Lwe4Xr3gAN+piQ
From: "Jeroen Frijters" <jeroen@sumatra.nl>
To: "Michael Koch" <konqueror@gmx.de>,
	<classpath@gnu.org>
Cc: 
Subject: RE: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 18:58:52 -0000

Michael Koch wrote:
> Here is another update.

Many thanks! Looks great. As far as I'm concerned, please commit.

Regards,
Jeroen



From MAILER-DAEMON Sat Apr 24 16:19:05 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHTc9-0005CZ-I8
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 16:19:05 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHTc2-0005Az-J5
	for classpath@gnu.org; Sat, 24 Apr 2004 16:18:58 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHTYz-0004Cr-C2
	for classpath@gnu.org; Sat, 24 Apr 2004 16:16:20 -0400
Received: from [209.225.28.201] (helo=mxsf01.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHTYn-00045v-So
	for classpath@gnu.org; Sat, 24 Apr 2004 16:15:37 -0400
Received: from InterJet.dellroad.org (public.cpe.mvllo.al.charter.com
	[24.196.20.72])
	by mxsf01.cluster1.charter.net (8.12.11/8.12.11) with ESMTP id
	i3OKF2JF006158
	for <classpath@gnu.org>; Sat, 24 Apr 2004 16:15:02 -0400 (EDT)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id PAA18100
	for <classpath@gnu.org>; Sat, 24 Apr 2004 15:12:08 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i3OKC7OR001847
	for <classpath@gnu.org>; Sat, 24 Apr 2004 15:12:07 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3OKC7uW001846
	for classpath@gnu.org; Sat, 24 Apr 2004 15:12:07 -0500 (CDT)
	(envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404242012.i3OKC7uW001846@arch20m.dellroad.org>
To: classpath@gnu.org
Date: Sat, 24 Apr 2004 15:12:07 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Subject: VMFile confusion
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 20:18:59 -0000

My apologies for adding to the confusion with my question about Etienne's
compliant about adding a VMFile class. Now I understand what he was
saying and agree with him.

To summarize, there is a distinction between native code Classpath
must leave to the individual VM to implement vs. native code that
can be implemented in a shared library which is shared among all
the VMs. Traditionally Classpath has created VMFoo classes only for
native code of the former type.

So applying this logic, there should be no VMFile class because the
native methods of File.java are all implementable in a "normal"
Classpath-supplied shared library and are not VM-specific.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Sat Apr 24 16:40:47 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHTx9-0004m6-6Z
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 16:40:47 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHTx6-0004k5-6X
	for classpath@gnu.org; Sat, 24 Apr 2004 16:40:44 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHTwY-0004SS-CI
	for classpath@gnu.org; Sat, 24 Apr 2004 16:40:41 -0400
Received: from [212.6.122.105] (helo=mail0.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHTwY-0004S6-1W
	for classpath@gnu.org; Sat, 24 Apr 2004 16:40:10 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-185.ewetel.net
	[80.228.95.185])
	by mail0.ewetel.de (8.12.1/8.12.9) with ESMTP id i3OKe6R7017402;
	Sat, 24 Apr 2004 22:40:07 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHTx3-0004AN-00; Sat, 24 Apr 2004 22:40:41 +0200
From: Michael Koch <konqueror@gmx.de>
To: Archie Cobbs <archie@dellroad.org>, classpath@gnu.org
Date: Sat, 24 Apr 2004 22:39:45 +0200
User-Agent: KMail/1.5.4
References: <200404242012.i3OKC7uW001846@arch20m.dellroad.org>
In-Reply-To: <200404242012.i3OKC7uW001846@arch20m.dellroad.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404242239.45486.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: VMFile confusion
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 20:40:45 -0000

Am Samstag, 24. April 2004 22:12 schrieb Archie Cobbs:
> My apologies for adding to the confusion with my question about
> Etienne's compliant about adding a VMFile class. Now I understand
> what he was saying and agree with him.
>
> To summarize, there is a distinction between native code Classpath
> must leave to the individual VM to implement vs. native code that
> can be implemented in a shared library which is shared among all
> the VMs. Traditionally Classpath has created VMFoo classes only for
> native code of the former type.
>
> So applying this logic, there should be no VMFile class because the
> native methods of File.java are all implementable in a "normal"
> Classpath-supplied shared library and are not VM-specific.

I'm not bound to the VM* prefix, I dont really care about it. In updated 
versions of the patch I use Platform*. I just thought in the first run 
that it may be VM specific because each VM may implement it 
differently. E.g. in JNode it may be implemented in pure Java and so it 
is somehow VM dependent.


Michael 




From MAILER-DAEMON Sat Apr 24 19:13:51 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHWKG-00062v-DX
	for mharc-classpath@gnu.org; Sat, 24 Apr 2004 19:12:48 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHWK2-0005um-8S
	for classpath@gnu.org; Sat, 24 Apr 2004 19:12:34 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHWJT-0005Y4-KM
	for classpath@gnu.org; Sat, 24 Apr 2004 19:12:31 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHWJS-0005Xb-WD
	for classpath@gnu.org; Sat, 24 Apr 2004 19:11:59 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i3OMtPF3023622
	for <classpath@gnu.org>; Sat, 24 Apr 2004 18:55:32 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004042418565419339
	for <classpath@gnu.org>; Sat, 24 Apr 2004 18:56:54 -0400
Received: from gadek.homelinux.org (140.28.internet.uqam.ca [132.208.28.140])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i3OMpqAS018503
	for <classpath@gnu.org>; Sat, 24 Apr 2004 18:51:53 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from greg by gadek.homelinux.org with local (Exim 4.32)
	id 1BHW0E-0000J9-2Y
	for classpath@gnu.org; Sat, 24 Apr 2004 18:52:06 -0400
Date: Sat, 24 Apr 2004 18:52:05 -0400
From: "Grzegorz B. Prokopski" <gadek@debian.org>
To: classpath@gnu.org
Message-ID: <20040424225205.GA1160@gadek.homelinux.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
Sender: "Grzegorz B. Prokopski" <greg@gadek.homelinux.org>
Subject: AWT regression?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Apr 2004 23:12:36 -0000

Hi all,

We've just imported fresh GNU CP as of Fri Apr 23 and running SymbolTest
program, that previously worked nicely, as documented ex. at
http://www.sablevm.org/screenshots , now gives this:

$ ~/work/bin/java-sablevm SymbolTest 
(:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
  (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
(:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
  (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
(:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
  (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
 java.lang.NullPointerException
    at java.applet.Applet.getDimensions (Applet.java:469)
    at java.applet.Applet.preferredSize (Applet.java:486)
    at java.awt.Container.getPreferredSize (Container.java:576)
    at java.awt.BorderLayout.calcCompSize (BorderLayout.java:647)
    at java.awt.BorderLayout.calcSize (BorderLayout.java:692)
    at java.awt.BorderLayout.preferredLayoutSize (BorderLayout.java:454)
    at java.awt.Container.preferredSize (Container.java:589)
    at java.awt.Container.getPreferredSize (Container.java:576)
    at java.awt.Window.pack (Window.java:206)
    at SymbolTest.main (SymbolTest.java:100)
    at java.lang.VirtualMachine.invokeMain (VirtualMachine.java)
    at java.lang.VirtualMachine.main (VirtualMachine.java:88)

The non-graphical stuff works just fine, so I guess we're not the only
ones hit by this problem?

					GBP
-- 
Grzegorz B. Prokopski <gadek@debian.org>
Debian GNU/Linux      http://www.debian.org
SableVM - LGPLed JVM  http://www.sablevm.org
Why SableVM ?!?       http://devel.sablevm.org/wiki/WhySableVM



From MAILER-DAEMON Sun Apr 25 05:08:16 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHfcW-00054F-0p
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 05:08:16 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHfcT-00052u-ER
	for classpath@gnu.org; Sun, 25 Apr 2004 05:08:13 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHfbw-0004fV-NG
	for classpath@gnu.org; Sun, 25 Apr 2004 05:08:11 -0400
Received: from [213.51.128.196] (helo=smtpq1.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHfbw-0004eE-C2
	for classpath@gnu.org; Sun, 25 Apr 2004 05:07:40 -0400
Received: from [213.51.128.136] (port=45457 helo=smtp5.home.nl)
	by smtpq1.home.nl with esmtp (Exim 4.30) id 1BHfbv-0000aw-8n
	for classpath@gnu.org; Sun, 25 Apr 2004 11:07:39 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:34199
	helo=dumas.thomas.planescape.com)
	by smtp5.home.nl with esmtp (Exim 4.30) id 1BHfbt-00003T-Er
	for classpath@gnu.org; Sun, 25 Apr 2004 11:07:37 +0200
From: Thomas Zander <zander@javalobby.org>
To: classpath@gnu.org
Date: Sun, 25 Apr 2004 11:06:32 +0200
User-Agent: KMail/1.6.2
References: <200404242012.i3OKC7uW001846@arch20m.dellroad.org>
In-Reply-To: <200404242012.i3OKC7uW001846@arch20m.dellroad.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404251106.33118.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Subject: Re: VMFile confusion
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2004 09:08:13 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 24 April 2004 22:12, Archie Cobbs wrote:
> So applying this logic, there should be no VMFile class because the
> native methods of File.java are all implementable in a "normal"
> Classpath-supplied shared library and are not VM-specific.

Just curious; is there any platform dependent naming scheme?
The simples example being that these files will have to be re-implemented=20
under Windows if someone wants to port classpath?

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAi3+YCojCW6H2z/QRApT0AJwM95y4sG6CFkL8CiR5vxJzzlAANQCgyGGw
DQ5pDhYuIsxuI+lziTkLV4o=3D
=3DTFuv
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Sun Apr 25 05:36:57 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHg4H-0002tm-5J
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 05:36:57 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHg4A-0002fW-Bb
	for classpath@gnu.org; Sun, 25 Apr 2004 05:36:50 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHg3Z-0001ci-VG
	for classpath@gnu.org; Sun, 25 Apr 2004 05:36:45 -0400
Received: from [212.6.122.116] (helo=mail2.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHg3U-0001af-Pg
	for classpath@gnu.org; Sun, 25 Apr 2004 05:36:08 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-149.ewetel.net
	[80.228.95.149])
	by mail2.ewetel.de (8.12.1/8.12.9) with ESMTP id i3P9a4Mo004697;
	Sun, 25 Apr 2004 11:36:05 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHg41-0000ea-00; Sun, 25 Apr 2004 11:36:41 +0200
From: Michael Koch <konqueror@gmx.de>
To: Thomas Zander <zander@javalobby.org>, classpath@gnu.org
Date: Sun, 25 Apr 2004 11:35:43 +0200
User-Agent: KMail/1.5.4
References: <200404242012.i3OKC7uW001846@arch20m.dellroad.org>
	<200404251106.33118.zander@javalobby.org>
In-Reply-To: <200404251106.33118.zander@javalobby.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404251135.44028.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: VMFile confusion
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2004 09:36:53 -0000

Am Sonntag, 25. April 2004 11:06 schrieb Thomas Zander:
> On Saturday 24 April 2004 22:12, Archie Cobbs wrote:
> > So applying this logic, there should be no VMFile class because the
> > native methods of File.java are all implementable in a "normal"
> > Classpath-supplied shared library and are not VM-specific.
>
> Just curious; is there any platform dependent naming scheme?
> The simples example being that these files will have to be
> re-implemented under Windows if someone wants to port classpath?

The idea is to only use different native code choosed at configure time, 
so no change in java code is needed. libgcj does this successfully 
since a long time.


Michael




From MAILER-DAEMON Sun Apr 25 07:44:19 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHi3W-0004Ir-Jh
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 07:44:18 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHi1I-0002vA-8A
	for classpath@gnu.org; Sun, 25 Apr 2004 07:42:00 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHhzw-0001Ti-3a
	for classpath@gnu.org; Sun, 25 Apr 2004 07:41:08 -0400
Received: from [32.97.182.106] (helo=e6.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BHhzv-0001PJ-52
	for classpath@gnu.org; Sun, 25 Apr 2004 07:40:35 -0400
Received: from northrelay02.pok.ibm.com (northrelay02.pok.ibm.com
	[9.56.224.150])
	by e6.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id i3PBeXfQ692266
	for <classpath@gnu.org>; Sun, 25 Apr 2004 07:40:33 -0400
Received: from d01ml604.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by northrelay02.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id
	i3PBehII093058
	for <classpath@gnu.org>; Sun, 25 Apr 2004 07:40:44 -0400
In-Reply-To: <200404242012.i3OKC7uW001846@arch20m.dellroad.org>
To: classpath@gnu.org
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
X-MIMETrack: S/MIME Sign by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/25/2004 07:37:22 AM,
	Serialize by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/25/2004 07:37:22 AM,
	Serialize complete at 04/25/2004 07:37:22 AM,
	S/MIME Sign failed at 04/25/2004 07:37:22 AM: The cryptographic key was
	not found,
	Serialize by Router on D01ML604/01/M/IBM(Release 6.51HF141 | April 6,
	2004) at 04/25/2004 07:40:33,
	Serialize complete at 04/25/2004 07:40:33
Message-ID: <OF14B465F5.0554465E-ON85256E81.003EE563-85256E81.00402051@us.ibm.com>
Date: Sun, 25 Apr 2004 07:40:31 -0400
Content-Type: multipart/alternative;
	boundary="=_alternative 003FD8B385256E81_="
Subject: Re: VMFile confusion
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2004 11:44:15 -0000

This is a multipart message in MIME format.
--=_alternative 003FD8B385256E81_=
Content-Type: text/plain; charset="US-ASCII"

And if your VM is sufficiently weird enough (Jikes RVM with m-n 
threading), then you might actually want to do something different about 
files.  We used to have our own version of FileDescriptor and do 
non-blocking I/O with hooks back into our threading layer instead of using 
the default classpath implementation.  This got out of sync with classpath 
at some point and we don't use it currently, but something like it will 
come back eventually. 

On VMFoo vs. NativeFoo vs. PlatformFoo, I really don't care.  I only 
observe that one person's VMFoo is another person's native/platfrom so 
perhaps it makes sense to just pick one name (VM) and leave it.  I suspect 
you are unlikely to be able to "nicely" divide the classes along these 
lines so why waste any intellectual effort (and silly flame wars) arguing 
about whether something is a VMFoo vs a NativeFoo.

--dave
--=_alternative 003FD8B385256E81_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">And if your VM is sufficiently weird
enough (Jikes RVM with m-n threading), then you might actually want to
do something different about files. &nbsp;We used to have our own version
of FileDescriptor and do non-blocking I/O with hooks back into our threading
layer instead of using the default classpath implementation. &nbsp;This
got out of sync with classpath at some point and we don't use it currently,
but something like it will come back eventually. </font>
<br>
<br><font size=2 face="sans-serif">On VMFoo vs. NativeFoo vs. PlatformFoo,
I really don't care. &nbsp;I only observe that one person's VMFoo is another
person's native/platfrom so perhaps it makes sense to just pick one name
(VM) and leave it. &nbsp;I suspect you are unlikely to be able to &quot;nicely&quot;
divide the classes along these lines so why waste any intellectual effort
(and silly flame wars) arguing about whether something is a VMFoo vs a
NativeFoo.</font>
<br>
<br><font size=2 face="sans-serif">--dave</font>
--=_alternative 003FD8B385256E81_=--



From MAILER-DAEMON Sun Apr 25 08:07:19 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHiPN-0002bQ-HU
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 08:06:53 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHiOe-0002Gc-9C
	for classpath@gnu.org; Sun, 25 Apr 2004 08:06:08 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHiMX-0000qB-D1
	for classpath@gnu.org; Sun, 25 Apr 2004 08:03:57 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHiL1-0000JC-ED
	for classpath@gnu.org; Sun, 25 Apr 2004 08:02:23 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BHiKu-0003vy-00; Sun, 25 Apr 2004 14:02:16 +0200
From: Mark Wielaard <mark@klomp.org>
To: Jeroen Frijters <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADE84@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADE84@LEMBU.sumatrasoftware.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Au3GiE5N+n4HZboAOqOZ"
Message-Id: <1082894537.27234.1403.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Sun, 25 Apr 2004 14:02:18 +0200
Cc: classpath@gnu.org
Subject: Re: Class/VMClass change
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2004 12:06:51 -0000


--=-Au3GiE5N+n4HZboAOqOZ
Content-Type: multipart/mixed; boundary="=-CeeZKzcAP+rR5YIe7w4R"


--=-CeeZKzcAP+rR5YIe7w4R
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2004-04-22 at 11:58, Jeroen Frijters wrote:
> Since nobody objected, I'm going to be committing the change to
> Class/VMClass that removes the need for a VMClass instance.

Thanks. I played a bit with it by implementing the necessary support
into jamvm (not that hard at all and it looks like this new setup makes
most operations slightly more efficient). You forgot to remove a couple
of unused instance methods which assume some specific VM-specific Thread
representation (int).  I cleaned this up and also made the class
uninstantiable and package private.

2004-04-25  Mark Wielaard  <mark@klomp.org>

       * vm/reference/java/lang/VMClass.java: Make final and package local.
       Add private constructor.  Removed all instance fields and methods.

Cheers,

Mark

--=-CeeZKzcAP+rR5YIe7w4R
Content-Disposition: inline; filename=VMClass.patch
Content-Type: text/x-patch; name=VMClass.patch; charset=iso-8859-1
Content-Transfer-Encoding: base64

SW5kZXg6IHZtL3JlZmVyZW5jZS9qYXZhL2xhbmcvVk1DbGFzcy5qYXZhDQo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS
Q1MgZmlsZTogL2N2c3Jvb3QvY2xhc3NwYXRoL2NsYXNzcGF0aC92bS9yZWZlcmVuY2UvamF2YS9s
YW5nL1ZNQ2xhc3MuamF2YSx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOQ0KZGlmZiAtdSAtcjEu
OSBWTUNsYXNzLmphdmENCi0tLSB2bS9yZWZlcmVuY2UvamF2YS9sYW5nL1ZNQ2xhc3MuamF2YQky
MiBBcHIgMjAwNCAxNjoxODozNiAtMDAwMAkxLjkNCisrKyB2bS9yZWZlcmVuY2UvamF2YS9sYW5n
L1ZNQ2xhc3MuamF2YQkyNSBBcHIgMjAwNCAxMTo0ODozNSAtMDAwMA0KQEAgLTUzLDkxICs1Mywx
MiBAQA0KICAqIEBhdXRob3IgQXJjaGllIENvYmJzIDxhcmNoaWVAZGVsbHJvYWQub3JnPg0KICAq
IEBhdXRob3IgQy4gQnJpYW4gSm9uZXMgPGNiakBnbnUub3JnPg0KICAqLw0KLXB1YmxpYyBmaW5h
bCBjbGFzcyBWTUNsYXNzIA0KK2ZpbmFsIGNsYXNzIFZNQ2xhc3MgDQogew0KLSAgLyoNCi0gICAq
IENsYXNzIGluaXRpYWxpemF0aW9uIG1vc3RseS1pbi1KYXZhIGNvcGllZCBmcm9tIFNhYmxlVk0u
DQotICAgKiBUaGUgc3RlcHMgYmVsb3cgZm9sbG93IHRoZSBKVk0gc3BlYywgMm5kIGVkaXRpb24s
IHNlYy4gMi4xNy41Lg0KLSAgICovDQotICBwcml2YXRlIGludCBpbml0aWFsaXppbmdfdGhyZWFk
Ow0KLSAgcHJpdmF0ZSBib29sZWFuIGVycm9uZW91c19zdGF0ZTsNCiANCi0gIHByaXZhdGUgbmF0
aXZlIGJvb2xlYW4gaXNJbml0aWFsaXplZCgpOw0KLSAgcHJpdmF0ZSBuYXRpdmUgdm9pZCBzZXRJ
bml0aWFsaXplZCgpOw0KLSAgcHJpdmF0ZSBuYXRpdmUgdm9pZCBzdGVwNygpOw0KLSAgcHJpdmF0
ZSBuYXRpdmUgdm9pZCBzdGVwOCgpOw0KLQ0KLSAgcHJpdmF0ZSB2b2lkIGluaXRpYWxpemUoaW50
IHRocmVhZCkgdGhyb3dzIEludGVycnVwdGVkRXhjZXB0aW9uDQorICAvLyBPbmx5IHN0YXRpYyBt
ZXRob2RzLiBDYW5ub3QgYmUgaW5zdGFudGlhdGVkLg0KKyAgcHJpdmF0ZSBWTUNsYXNzKCkNCiAg
IHsNCi0gICAgRXJyb3IgZXJyb3I7DQotDQotICAgIC8qIDEgKi8NCi0gICAgc3luY2hyb25pemVk
ICh0aGlzKQ0KLSAgICB7DQotICAgICAgLyogMiAqLw0KLSAgICAgIHdoaWxlIChpbml0aWFsaXpp
bmdfdGhyZWFkICE9IDAgJiYgaW5pdGlhbGl6aW5nX3RocmVhZCAhPSB0aHJlYWQpDQotICAgICAg
ICB3YWl0KCk7DQotDQotICAgICAgLyogMyAqLw0KLSAgICAgIGlmIChpbml0aWFsaXppbmdfdGhy
ZWFkID09IHRocmVhZCkNCi0gICAgICAgIHJldHVybjsNCi0NCi0gICAgICAvKiA0ICovDQotICAg
ICAgaWYgKGlzSW5pdGlhbGl6ZWQoKSkNCi0gICAgICAgIHJldHVybjsNCi0NCi0gICAgICAvKiA1
ICovDQotICAgICAgaWYgKGVycm9uZW91c19zdGF0ZSkNCi0gICAgICAgIHRocm93IG5ldyBOb0Ns
YXNzRGVmRm91bmRFcnJvcigpOw0KLQ0KLSAgICAgIC8qIDYgKi8NCi0gICAgICBpbml0aWFsaXpp
bmdfdGhyZWFkID0gdGhyZWFkOw0KLSAgICB9DQotDQotICAgIC8qIDcgKi8NCi0gICAgdHJ5IHsN
Ci0gICAgICBzdGVwNygpOw0KLSAgICB9DQotICAgIGNhdGNoKEVycm9yIGUpIHsNCi0gICAgICBz
eW5jaHJvbml6ZWQodGhpcykgew0KLSAgICAgICAgZXJyb25lb3VzX3N0YXRlID0gdHJ1ZTsNCi0g
ICAgICAgIGluaXRpYWxpemluZ190aHJlYWQgPSAwOw0KLSAgICAgICAgbm90aWZ5QWxsKCk7DQot
ICAgICAgICB0aHJvdyBlOw0KLSAgICAgIH0NCi0gICAgfQ0KLQ0KLSAgICAvKiA4ICovDQotICAg
IHRyeSB7DQotICAgICAgc3RlcDgoKTsNCi0NCi0gICAgICAvKiA5ICovDQotICAgICAgc3luY2hy
b25pemVkKHRoaXMpIHsNCi0gICAgICAgIHNldEluaXRpYWxpemVkKCk7DQotICAgICAgICBpbml0
aWFsaXppbmdfdGhyZWFkID0gMDsNCi0gICAgICAgIG5vdGlmeUFsbCgpOw0KLSAgICAgICAgcmV0
dXJuOw0KLSAgICAgIH0NCi0gICAgfQ0KLQ0KLSAgICAvKiAxMCAqLw0KLSAgICBjYXRjaChFeGNl
cHRpb24gZSkgew0KLSAgICAgIHRyeSB7DQotICAgICAgICBlcnJvciA9IG5ldyBFeGNlcHRpb25J
bkluaXRpYWxpemVyRXJyb3IoZSk7DQotICAgICAgfSBjYXRjaCAoT3V0T2ZNZW1vcnlFcnJvciBl
Mikgew0KLSAgICAgICAgZXJyb3IgPSBlMjsNCi0gICAgICB9DQotICAgIH0gY2F0Y2goRXJyb3Ig
ZSkgew0KLSAgICAgIGVycm9yID0gZTsNCi0gICAgfQ0KLQ0KLSAgICAvKiAxMSAqLw0KLSAgICBz
eW5jaHJvbml6ZWQodGhpcykgew0KLSAgICAgIGVycm9uZW91c19zdGF0ZSA9IHRydWU7DQotICAg
ICAgaW5pdGlhbGl6aW5nX3RocmVhZCA9IDA7DQotICAgICAgbm90aWZ5QWxsKCk7DQotICAgICAg
dGhyb3cgZXJyb3I7DQotICAgIH0NCiAgIH0NCiANCiAgIC8qKg0K

--=-CeeZKzcAP+rR5YIe7w4R--

--=-Au3GiE5N+n4HZboAOqOZ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAi6jJxVhZCJWr9QwRAtWfAKCD+8miJ6pUNrDxcziGfNKq6JlpCQCfZNoe
74NjLimeDruroyNwLzzEk88=
=3sex
-----END PGP SIGNATURE-----

--=-Au3GiE5N+n4HZboAOqOZ--




From MAILER-DAEMON Sun Apr 25 10:26:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHkaN-00039c-E5
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 10:26:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHkaK-00036e-Dc
	for classpath@gnu.org; Sun, 25 Apr 2004 10:26:20 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHkZo-0002n6-5r
	for classpath@gnu.org; Sun, 25 Apr 2004 10:26:19 -0400
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHkZn-0002m7-M5
	for classpath@gnu.org; Sun, 25 Apr 2004 10:25:47 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-95-149.ewetel.net
	[80.228.95.149])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id i3PEP8pc015560;
	Sun, 25 Apr 2004 16:25:11 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BHkZm-0001GM-00; Sun, 25 Apr 2004 16:25:46 +0200
From: Michael Koch <konqueror@gmx.de>
To: David P Grove <groved@us.ibm.com>, classpath@gnu.org
Date: Sun, 25 Apr 2004 16:24:47 +0200
User-Agent: KMail/1.5.4
References: <OF14B465F5.0554465E-ON85256E81.003EE563-85256E81.00402051@us.ibm.com>
In-Reply-To: <OF14B465F5.0554465E-ON85256E81.003EE563-85256E81.00402051@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200404251624.47433.konqueror@gmx.de>
X-CheckCompat: OK
Cc: 
Subject: Re: VMFile confusion
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2004 14:26:21 -0000

Am Sonntag, 25. April 2004 13:40 schrieb David P Grove:
> And if your VM is sufficiently weird enough (Jikes RVM with m-n
> threading), then you might actually want to do something different
> about files.  We used to have our own version of FileDescriptor and
> do non-blocking I/O with hooks back into our threading layer instead
> of using the default classpath implementation.  This got out of sync
> with classpath at some point and we don't use it currently, but
> something like it will come back eventually.
>
> On VMFoo vs. NativeFoo vs. PlatformFoo, I really don't care.  I only
> observe that one person's VMFoo is another person's native/platfrom
> so perhaps it makes sense to just pick one name (VM) and leave it.  I
> suspect you are unlikely to be able to "nicely" divide the classes
> along these lines so why waste any intellectual effort (and silly
> flame wars) arguing about whether something is a VMFoo vs a
> NativeFoo.

That's the best mail I read about this so far. Thx.


Michael




From MAILER-DAEMON Sun Apr 25 14:51:05 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHoiX-00008B-FI
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 14:51:05 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHoiT-00006o-P3
	for classpath@gnu.org; Sun, 25 Apr 2004 14:51:01 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHohx-0008Q4-Ls
	for classpath@gnu.org; Sun, 25 Apr 2004 14:51:00 -0400
Received: from [209.225.28.229] (helo=mxsf29.cluster1.charter.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHohx-0008PY-Aq
	for classpath@gnu.org; Sun, 25 Apr 2004 14:50:29 -0400
Received: from InterJet.dellroad.org (public.cpe.mvllo.al.charter.com
	[24.196.20.72])
	by mxsf29.cluster1.charter.net (8.12.11/8.12.11) with ESMTP id
	i3PIj4RZ002829; Sun, 25 Apr 2004 14:45:05 -0400 (EDT)
Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.2.2.20])
	by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id NAA35977;
	Sun, 25 Apr 2004 13:42:40 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.6) with ESMTP id i3PIgeOR004981; 
	Sun, 25 Apr 2004 13:42:40 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3PIgeaq004980;
	Sun, 25 Apr 2004 13:42:40 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404251842.i3PIgeaq004980@arch20m.dellroad.org>
In-Reply-To: <OF14B465F5.0554465E-ON85256E81.003EE563-85256E81.00402051@us.ibm.com>
To: David P Grove <groved@us.ibm.com>
Date: Sun, 25 Apr 2004 13:42:40 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: classpath@gnu.org
Subject: Re: VMFile confusion
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2004 18:51:02 -0000

David P Grove wrote:
> On VMFoo vs. NativeFoo vs. PlatformFoo, I really don't care.  I only 
> observe that one person's VMFoo is another person's native/platfrom so 
> perhaps it makes sense to just pick one name (VM) and leave it.  I suspect 
> you are unlikely to be able to "nicely" divide the classes along these 
> lines so why waste any intellectual effort (and silly flame wars) arguing 
> about whether something is a VMFoo vs a NativeFoo.

This was exactly my thinking originally, and why I was inquring to
Etienne about what he really meant, i.e., what is his "dividing function",
because to me there really is no such thing.

However, after thinking about it I realized that he is right in a way.
While in the grand scheme of things there I agree is no one true clear 
division between "VM" methods and "native" methods, in practice, by virtue
of its implementation, Classpath has implicitly defined just such a dividing
line.

I.e., if Classpath supplies a native implementation of a method, then it's
a "native" method.. if not, then its a "VM" method... at least within the
context of Classpath itself.

So if we belive Classpath being self-consistent is a good goal,
then it does make some amount of sense that the naming scheme would
be consistent with the VM/native split that it implicitly defines.

NOW having said all this I should also say that it doesn't really matter
to me either :-) I'm more curious in the underlying issues that motivate
the discussion because they help me understand subtleties of VM design.

E.g., Classpath has implicitly defined this line.. is that the best line?
What line would you draw if you were starting over? (rhetorical questions,
please don't answer on the list :-)

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Sun Apr 25 18:03:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHrid-0001Xv-Na
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 18:03:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHriY-0001Sf-Vv
	for classpath@gnu.org; Sun, 25 Apr 2004 18:03:18 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHriW-0001RU-Hh
	for classpath@gnu.org; Sun, 25 Apr 2004 18:03:17 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHrgI-0000yQ-LN
	for classpath@gnu.org; Sun, 25 Apr 2004 18:00:58 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BHrfn-0005VX-00; Mon, 26 Apr 2004 00:00:27 +0200
From: Mark Wielaard <mark@klomp.org>
To: Jeroen Frijters <jeroen@sumatra.nl>
In-Reply-To: <788B535AB1F9CB49BB9C229372B50ACC0ADEB2@LEMBU.sumatrasoftware.com>
References: <788B535AB1F9CB49BB9C229372B50ACC0ADEB2@LEMBU.sumatrasoftware.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-bFGfWDm9da5JY0Y1DW5w"
Message-Id: <1082930429.27234.1467.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Mon, 26 Apr 2004 00:00:29 +0200
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: RE: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2004 22:03:21 -0000


--=-bFGfWDm9da5JY0Y1DW5w
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-04-24 at 20:57, Jeroen Frijters wrote:
> Michael Koch wrote:
> > Here is another update.
>=20
> Many thanks! Looks great. As far as I'm concerned, please commit.

I agree that this looks nice. It is good to see that every VM/Platform
specific method takes a path as argument. I had thought we might need an
VM/Platform specific instance of PlatformFile, but your patch makes
clear that all you need is a path to the file.

It might be nice to make that explicit for these two methods.
If the arguments are actually 'paths' you might want to rename them to
darpath, targetpath and destpath.

+  /*
+   * This native function actually produces the list of file in this
+   * directory
+   */
+  static native String[] list(String dirname);
+
+  /*
+   * This native method actually performs the rename.
+   */
+  static native boolean renameTo(String target, String dest);

Also please make PlatformFile final. And give it a private no argument
empty constructor to indicate that it is never expected to be
instantiated.

If there are no Mauve regressions then please commit.

Cheers,

Mark

--=-bFGfWDm9da5JY0Y1DW5w
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAjDT8xVhZCJWr9QwRAuZUAJwKvLKofQqA35OGToi5grRLCTV/YgCfZyse
NXIS4+DnRlzGViZ2ZTuFgDM=
=zdfZ
-----END PGP SIGNATURE-----

--=-bFGfWDm9da5JY0Y1DW5w--




From MAILER-DAEMON Sun Apr 25 18:22:28 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHs16-0005RC-Fq
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 18:22:28 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHs13-0005PK-RY
	for classpath@gnu.org; Sun, 25 Apr 2004 18:22:25 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHs12-0005Om-Cj
	for classpath@gnu.org; Sun, 25 Apr 2004 18:22:24 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHs0l-0005FG-J5
	for classpath@gnu.org; Sun, 25 Apr 2004 18:22:07 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BHs0V-0005an-00; Mon, 26 Apr 2004 00:21:51 +0200
From: Mark Wielaard <mark@klomp.org>
To: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
In-Reply-To: <408A6097.3080102@uqam.ca>
References: <200404232207.37055.konqueror@gmx.de> <40898A76.4060309@uqam.ca>
	<200404240854.51443.konqueror@gmx.de>
	<1082793513.27234.382.camel@elsschot.wildebeest.org>
	<408A552F.2080809@kaffe.org>  <408A6097.3080102@uqam.ca>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-chJzSfhQD/2sXzObpEMP"
Message-Id: <1082931713.27234.1487.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Mon, 26 Apr 2004 00:21:53 +0200
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Apr 2004 22:22:27 -0000


--=-chJzSfhQD/2sXzObpEMP
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Sat, 2004-04-24 at 14:41, Etienne Gagnon wrote:
> To classpath maintainers: If you want to separate all native calls to Nat=
ive*
> classes, I don't care, but please do not mix the VM* interface and the
> Native* interface.  They are semantically quite different things.  I am s=
uprized
> that this is not plain obvious to some of you.

As others have explained it is not so clear cut as you make it out. For
example some of our reference JNI methods expect that the VM JNI
interface allows that final fields can be set or whether a class has a
static class initializer. Something that is not specified by the JNI
spec. For other things we do provide reference implementations that are
helpful for runtimes but that are clearly not as efficient as when a VM
does it more directly. The VM* classes indicate that there is something
the runtime hacker might want to take a look at to make sure the
implementation is optimal/useful for their platform.

In the future it would help if you take a less aggressive tone when you
comment on someones patch. Starting your review with "This makes no
sense whatsoever" and then not giving any suggestion what you would like
to see changed or how isn't helpful. You could just have said "I suggest
we call this new class PlatformFile.java instead of VMFile.java because
...". Then nobody has to guess why you have an issue with a certain
patch.

I don't really mind if you want to submit a patch to rename those VM*
classes to Platform* classes when there is at least a reasonable default
reference implementation for all methods in either java or JNI/C/Posix.
Please do. It would certainly clean things up if done consistently
throughout the whole code base. But if nobody wants to do that then I
think having them all called VM* is better then some being called
Platform*, some Native* and some VM*.

Thanks,

Mark

--=-chJzSfhQD/2sXzObpEMP
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAjDoBxVhZCJWr9QwRAmaIAJ9d0WJApkwoWWbMnWNc/QHnFf5oeQCgiOD2
Bn7CBnterWVEaAqnG+zKnZw=
=CVjj
-----END PGP SIGNATURE-----

--=-chJzSfhQD/2sXzObpEMP--




From MAILER-DAEMON Sun Apr 25 21:48:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHvEN-00050u-8p
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 21:48:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHvEK-0004zA-AQ
	for classpath@gnu.org; Sun, 25 Apr 2004 21:48:20 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHvDn-0004tD-29
	for classpath@gnu.org; Sun, 25 Apr 2004 21:48:19 -0400
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BHvDm-0004n7-5z
	for classpath@gnu.org; Sun, 25 Apr 2004 21:47:46 -0400
Received: from dholmeslaptop (dholmes.dltech.com.au [203.222.72.2])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i3Q1i2Ej011107
	for <classpath@gnu.org>; Mon, 26 Apr 2004 11:44:04 +1000 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: <classpath@gnu.org>
Date: Mon, 26 Apr 2004 11:44:31 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCAEMCEBAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
In-Reply-To: <OF14B465F5.0554465E-ON85256E81.003EE563-85256E81.00402051@us.ibm.com>
X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Importance: Normal
Subject: RE: VMFile confusion
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2004 01:48:20 -0000

David P. Grove wrote:
> And if your VM is sufficiently weird enough (Jikes RVM with m-n
> threading), then you might actually want to do something
> different about files.  We used to have our own version of
> FileDescriptor and do non-blocking I/O with hooks back into our
> threading layer instead of using the default classpath
> implementation.

OVM does a similar "weird" thing. We have to redirect every "native" method
to some library-glue that knows how to handle it correctly. Some simple
things like getting a file length or checking existence of a file may be
redirected back to an actual native method, but all actual I/O goes into the
VM before emerging as some kind of native interaction.

I'm quite happy with VMxxx for these classes - and much prefer this to
PlatformXXX (because our VMxxx classes are NOT platform specific), and
NativeXXX is incorrect because it is not native for us. The fact that all
JNI-supporting VMs may be able to share the same native code doesn't mean
that the choice of being native in the first place in not VM-specific.

Making a method native is a choice - and that choice is up to the VM. Let
the VMxxx methods have a default native implementation, but lets keeps those
native declarations in the VMxxx file.

If every "native" method were actually defined in a VMxxx class we wouldn't
need our initial redirection of native methods to the library-glue code, we
would just write the right code in VMxxx.

David Holmes




From MAILER-DAEMON Sun Apr 25 22:33:10 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BHvv8-0005JV-U8
	for mharc-classpath@gnu.org; Sun, 25 Apr 2004 22:32:34 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BHvuf-0004sC-Hz
	for classpath@gnu.org; Sun, 25 Apr 2004 22:32:05 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BHvty-0003xV-VZ
	for classpath@gnu.org; Sun, 25 Apr 2004 22:31:54 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BHvte-0003Uv-L7
	for classpath@gnu.org; Sun, 25 Apr 2004 22:31:02 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i3Q2U1Et027127;
	Sun, 25 Apr 2004 22:30:01 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004042522312314461 ; Sun, 25 Apr 2004 22:31:23 -0400
Received: from perseval.info.uqam.ca (perseval.info.uqam.ca [132.208.137.96])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i3Q23cAS025979; Sun, 25 Apr 2004 22:03:38 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
Received: from localhost ([127.0.0.1] helo=uqam.ca)
	by perseval.info.uqam.ca with esmtp (Exim 4.32)
	id 1BHvT7-0007pN-Aq; Sun, 25 Apr 2004 22:03:37 -0400
Message-ID: <408C69D0.9060004@uqam.ca>
Date: Sun, 25 Apr 2004 21:45:52 -0400
From: Etienne Gagnon <gagnon.etienne_m@uqam.ca>
Organization: UQAM
User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US;
	rv:1.6) Gecko/20040414 Debian/1.6-5
X-Accept-Language: en
MIME-Version: 1.0
To: Mark Wielaard <mark@klomp.org>
References: <200404232207.37055.konqueror@gmx.de>
	<40898A76.4060309@uqam.ca>	<200404240854.51443.konqueror@gmx.de>	<1082793513.27234.382.camel@elsschot.wildebeest.org>	<408A552F.2080809@kaffe.org>
	<408A6097.3080102@uqam.ca>
	<1082931713.27234.1487.camel@elsschot.wildebeest.org>
In-Reply-To: <1082931713.27234.1487.camel@elsschot.wildebeest.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: java.io.File and its native methods
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2004 02:32:31 -0000

Mark Wielaard wrote:
> .... Starting your review with "This makes no
> sense whatsoever" and then not giving any suggestion what you would like
> to see changed or how isn't helpful.

This is false.  I did provide a clear indication of the solution.  I cite
the relevant part of my message:

---- Begin -----
This makes no sense whatsoever.  File is NOT VM-specific in any way.

VM*.java should be reserved for the VM interface only.
----- END -----

Up to recently[1], it was quite clear to Classpath developers that the
VM interface was made up mostly of those native calls that should be implemented
in the VM.  In this context, my message was quite clear, and self
explanatory about the solution: reserve VM*.java to the VM interface only.

Of course there is no "unique" definition for exactly what should
constitute the VM interface (e.g. where to draw the line), but
java.io.File does not seem, at first sight (nor at second sight), to be
part of the VM interface, specially that a JNI implemetation is provided
for all of its native methods.


OK.  I have better way to spend my time than defending against false
accusations.  You do whatever you choose.  At least, now you'll take your
design decisions knowing about the possible distinction that you could keep
between VM and native interface (which would probably help maintaining
documents such as the VM integration guide).  So, at least my intervention
will have achieved its goal of informing you of the deep departure, in the
initial patch, from the traditional semantics of VM interface.

[1] I didn't know that the semantics of "native interface" changed to "VM
interface" lately.  It must probably have happened just before I sent my
email [sic].  The VM integration guide[1] does not seem to assimilate the
whole native interface to the VM interface.

[2] See Section 3, more precisely.  I don't see Java.io.File, nor the like
     there.


-- 
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/



From MAILER-DAEMON Wed Apr 28 04:02:27 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIjvX-0002bL-G2
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 03:56:19 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIjvK-0002YT-Lw
	for classpath@gnu.org; Wed, 28 Apr 2004 03:56:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIjul-0002N6-R7
	for classpath@gnu.org; Wed, 28 Apr 2004 03:56:03 -0400
Received: from [212.6.122.106] (helo=mail1.ewetel.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BIjul-0002Mp-9s
	for classpath@gnu.org; Wed, 28 Apr 2004 03:55:31 -0400
Received: from majestix.konqueror.de (dynadsl-080-228-94-228.ewetel.net
	[80.228.94.228])
	by mail1.ewetel.de (8.12.1/8.12.9) with ESMTP id i3S7tTpc018911
	for <classpath@gnu.org>; Wed, 28 Apr 2004 09:55:29 +0200 (MEST)
Received: from obelix.konqueror.de ([192.168.1.4])
	by majestix.konqueror.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BIjvY-0000kI-00
	for <classpath@gnu.org>; Wed, 28 Apr 2004 09:56:20 +0200
From: Michael Koch <konqueror@gmx.de>
To: classpath@gnu.org
Date: Wed, 28 Apr 2004 09:55:10 +0200
User-Agent: KMail/1.5.4
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_eN2jAf9mKavN159"
Message-Id: <200404280955.10511.konqueror@gmx.de>
X-CheckCompat: OK
Subject: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 07:56:08 -0000


--Boundary-00=_eN2jAf9mKavN159
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi list,


I was worried about some compiler warnings when compiling the native 
part of the gtk peer. So I digged a little bit. In jni.h in GNU 
classpath GetStringUTFChars returns "const jbyte *". This gives 
compiler warnings when assigning the return value to a "const char *" 
variable. I found out that in jni.h from GCJ (3.3 and 3.5) and jni.h 
from Mozilla GetStringUTFChars returns "const char *" which is much 
more logical and seems to be the right thing. JNI 1.1 spec says it 
should return "const jbyte *". I search a little bit with google and 
jni.h in other open source projects use "const char *" too. Now I 
really wonder what we should do ? Should we leave it like it is and 
cast to "const char *" in all instances we use GetStringUTFChars in out 
own code or should we just apply the attached patch to change our 
jni.h.

What do you think ?


Michael


2004-04-28  Michael Koch  <konqueror@gmx.de>

	* include/jni.h.in (GetStringUTFChars):
	Made it return const char * instead of const jbyte *.


--Boundary-00=_eN2jAf9mKavN159
Content-Type: text/x-diff;
  charset="us-ascii";
  name="jni.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="jni.diff"

Index: include/jni.h.in
===================================================================
RCS file: /cvsroot/classpath/classpath/include/jni.h.in,v
retrieving revision 1.7
diff -u -r1.7 jni.h.in
--- include/jni.h.in	29 Mar 2004 07:07:26 -0000	1.7
+++ include/jni.h.in	28 Apr 2004 07:44:16 -0000
@@ -392,7 +392,7 @@
   void     (JNICALL *ReleaseStringChars)           (JNIEnv *, jstring, const jchar *);              /* 166 */
   jstring  (JNICALL *NewStringUTF)                 (JNIEnv *, const char *);                        /* 167 */
   jsize    (JNICALL *GetStringUTFLength)           (JNIEnv *, jstring);                             /* 168 */
-  const jbyte * (JNICALL *GetStringUTFChars)       (JNIEnv *, jstring, jboolean *);                 /* 169 */
+  const char * (JNICALL *GetStringUTFChars)       (JNIEnv *, jstring, jboolean *);                 /* 169 */
   void     (JNICALL *ReleaseStringUTFChars)        (JNIEnv *, jstring, const char *);               /* 170 */
   jsize    (JNICALL *GetArrayLength)               (JNIEnv *, jarray);                              /* 171 */
   jarray   (JNICALL *NewObjectArray)               (JNIEnv *, jsize, jclass, jobject);              /* 172 */

--Boundary-00=_eN2jAf9mKavN159--



From MAILER-DAEMON Wed Apr 28 11:24:18 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIouV-00058y-Fb
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 09:15:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIo3m-0004y7-6Z
	for classpath@gnu.org; Wed, 28 Apr 2004 08:21:06 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BInxo-00049T-M5
	for classpath@gnu.org; Wed, 28 Apr 2004 08:15:28 -0400
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BInon-00033D-D4
	for classpath@gnu.org; Wed, 28 Apr 2004 08:05:37 -0400
Received: from dholmeslaptop (233-130.ip.internex.net.au [210.9.233.130])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i3SC20WD019595;
	Wed, 28 Apr 2004 22:02:01 +1000 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "Michael Koch" <konqueror@gmx.de>, <classpath@gnu.org>
Date: Wed, 28 Apr 2004 22:02:30 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCGENMEBAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
In-Reply-To: <200404280955.10511.konqueror@gmx.de>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Importance: Normal
Cc: 
Subject: RE: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 13:15:33 -0000

> GetStringUTFChars returns "const char *" which is much
> more logical and seems to be the right thing. JNI 1.1 spec says it
> should return "const jbyte *". I search a little bit with google and
> jni.h in other open source projects use "const char *" too. Now I
> really wonder what we should do ? Should we leave it like it is and
> cast to "const char *" in all instances we use GetStringUTFChars in out
> own code or should we just apply the attached patch to change our
> jni.h.

Sun's own jni.h uses "const char*"

This may be a typo in the JNI 1.1 spec as the corresponding
ReleaseStringUTFChars takes a "const char*" too.

David Holmes




From MAILER-DAEMON Wed Apr 28 12:07:01 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIraO-0001Rz-Tq
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 12:07:00 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIraL-0001RX-Rr
	for classpath@gnu.org; Wed, 28 Apr 2004 12:06:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIrZl-0001KC-NH
	for classpath@gnu.org; Wed, 28 Apr 2004 12:06:52 -0400
Received: from [139.19.1.1] (helo=interferon.mpi-sb.mpg.de)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BIrWD-0000sP-L6
	for classpath@gnu.org; Wed, 28 Apr 2004 12:02:42 -0400
Received: from amavis by interferon.mpi-sb.mpg.de with scanned-ok (Exim 3.35
	#1 (Debian)) id 1BIrW5-00066Q-00
	for <classpath@gnu.org>; Wed, 28 Apr 2004 18:02:33 +0200
Received: from data ([139.19.90.238] helo=mpi-sb.mpg.de)
	by interferon.mpi-sb.mpg.de with esmtp (Exim 3.35 #1 (Debian))
	id 1BIrW3-00064w-00; Wed, 28 Apr 2004 18:02:31 +0200
Received: from kaffe.org (topic@mpiat2304 [139.19.20.93])
	by mpi-sb.mpg.de (8.12.9+Sun/8.12.9) with ESMTP id i3SG2TLT017339;
	Wed, 28 Apr 2004 18:02:31 +0200 (MEST)
Message-ID: <408FD595.1090607@kaffe.org>
Date: Wed, 28 Apr 2004 18:02:29 +0200
From: Dalibor Topic <robilad@kaffe.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040316
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: David Holmes <dholmes@dltech.com.au>
References: <NFBBKALFDCPFIDBNKAPCGENMEBAA.dholmes@dltech.com.au>
In-Reply-To: <NFBBKALFDCPFIDBNKAPCGENMEBAA.dholmes@dltech.com.au>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by AMaViS perl-11
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 16:06:59 -0000

David Holmes wrote:
>>GetStringUTFChars returns "const char *" which is much
>>more logical and seems to be the right thing. JNI 1.1 spec says it
>>should return "const jbyte *". I search a little bit with google and
>>jni.h in other open source projects use "const char *" too. Now I
>>really wonder what we should do ? Should we leave it like it is and
>>cast to "const char *" in all instances we use GetStringUTFChars in out
>>own code or should we just apply the attached patch to change our
>>jni.h.
> 
> 
> Sun's own jni.h uses "const char*"
> 
> This may be a typo in the JNI 1.1 spec as the corresponding
> ReleaseStringUTFChars takes a "const char*" too.

The Java Native Interface Programmer's Guide and Specification
uses jbyte* in $3.2.1 example 
http://java.sun.com/docs/books/jni/html/objtypes.html . The latest JNI 
docs from 1.4.2 also use jbyte :
http://java.sun.com/j2se/1.4.2/docs/guide/jni/spec/functions.html#wp17265
The JNI tutorial uses a const char * in its example here
http://java.sun.com/docs/books/tutorial/native1.1/implementing/string.html

Given that jbyte is signed 8 bits and a char can be signed or unsigned 
(and doesn't have to be 8 bits), I'm not quite sure what the 
implications of a change in the prototype are.

cheers,
dalibor topic



From MAILER-DAEMON Wed Apr 28 13:08:37 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIsQ3-0005ub-7H
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 13:00:23 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIsPn-0005pl-3A
	for classpath@gnu.org; Wed, 28 Apr 2004 13:00:07 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIsPB-0005cR-NJ
	for classpath@gnu.org; Wed, 28 Apr 2004 13:00:01 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BIsCZ-0002Q6-FD
	for classpath@gnu.org; Wed, 28 Apr 2004 12:46:27 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3SGkKKG015087;
	Wed, 28 Apr 2004 12:46:20 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3SGkIv00787; 
	Wed, 28 Apr 2004 12:46:18 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i3SGkGcU006147; Wed, 28 Apr 2004 12:46:16 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: "Grzegorz B. Prokopski" <gadek@debian.org>
In-Reply-To: <20040424225205.GA1160@gadek.homelinux.org>
References: <20040424225205.GA1160@gadek.homelinux.org>
Content-Type: multipart/mixed; boundary="=-5CSqAZa0w7wPx+kQ2GIT"
Message-Id: <1083170776.22187.155.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Wed, 28 Apr 2004 12:46:16 -0400
Cc: classpath list <classpath@gnu.org>
Subject: Re: AWT regression?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 17:00:09 -0000


--=-5CSqAZa0w7wPx+kQ2GIT
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Sat, 2004-04-24 at 18:52, Grzegorz B. Prokopski wrote:
> Hi all,
> 
> We've just imported fresh GNU CP as of Fri Apr 23 and running SymbolTest
> program, that previously worked nicely, as documented ex. at
> http://www.sablevm.org/screenshots , now gives this:
> 
> $ ~/work/bin/java-sablevm SymbolTest 
> (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
>   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
>   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
>   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
>  java.lang.NullPointerException
>     at java.applet.Applet.getDimensions (Applet.java:469)
>     at java.applet.Applet.preferredSize (Applet.java:486)
>     at java.awt.Container.getPreferredSize (Container.java:576)
>     at java.awt.BorderLayout.calcCompSize (BorderLayout.java:647)
>     at java.awt.BorderLayout.calcSize (BorderLayout.java:692)
>     at java.awt.BorderLayout.preferredLayoutSize (BorderLayout.java:454)
>     at java.awt.Container.preferredSize (Container.java:589)
>     at java.awt.Container.getPreferredSize (Container.java:576)
>     at java.awt.Window.pack (Window.java:206)
>     at SymbolTest.main (SymbolTest.java:100)
>     at java.lang.VirtualMachine.invokeMain (VirtualMachine.java)
>     at java.lang.VirtualMachine.main (VirtualMachine.java:88)
> 

I recently changed size reporting in Applet.java.  I made applets report
their preferred size as the width and height attributes given in the
applet tag.  However, the current code assumes that an applet stub is
present that can be queried for these attributes.  The NPE you're seeing
is likely caused by the stub not having been set.

The attached patch should fix the problem, though I haven't tested it. 
Can you try it out?

Thanks,
Tom


--=-5CSqAZa0w7wPx+kQ2GIT
Content-Disposition: attachment; filename=applet-stub-null.patch
Content-Type: text/x-patch; name=applet-stub-null.patch; charset=UTF-8
Content-Transfer-Encoding: 7bit

Index: java/applet/Applet.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/applet/Applet.java,v
retrieving revision 1.3.36.3
diff -u -r1.3.36.3 Applet.java
--- java/applet/Applet.java	16 Mar 2004 04:43:35 -0000	1.3.36.3
+++ java/applet/Applet.java	28 Apr 2004 16:35:36 -0000
@@ -483,7 +483,7 @@
    */
   public Dimension preferredSize()
   {
-    return getDimensions ();
+    return stub == null ? super.preferredSize () : getDimensions ();
   }
 
   /**
@@ -494,7 +494,7 @@
    */
   public Dimension minimumSize()
   {
-    return getDimensions ();
+    return stub == null ? super.minimumSize () : getDimensions ();
   }
 
   /**

--=-5CSqAZa0w7wPx+kQ2GIT--




From MAILER-DAEMON Wed Apr 28 13:40:23 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIsrp-000520-HN
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 13:29:05 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIsr4-0004mg-3X
	for classpath@gnu.org; Wed, 28 Apr 2004 13:28:18 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIsb6-0000RT-JN
	for classpath@gnu.org; Wed, 28 Apr 2004 13:12:19 -0400
Received: from [207.189.223.52] (helo=email3.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BIsYE-0007uB-9U
	for classpath@gnu.org; Wed, 28 Apr 2004 13:08:50 -0400
Received: (qmail 3841 invoked from network); 28 Apr 2004 17:29:01 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email3.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <konqueror@gmx.de>; 28 Apr 2004 17:29:01 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 79DFC4F8739; Wed, 28 Apr 2004 10:57:25 -0600 (MDT)
To: Michael Koch <konqueror@gmx.de>
References: <200404280955.10511.konqueror@gmx.de>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I hope something GOOD came in the mail today so I have
	a REASON to live!!
Date: 28 Apr 2004 10:57:25 -0600
In-Reply-To: <200404280955.10511.konqueror@gmx.de>
Message-ID: <87r7u8hwga.fsf@fleche.redhat.com>
Lines: 26
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org
Subject: Re: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 17:29:01 -0000

>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> I found out that in jni.h from GCJ (3.3 and 3.5) and jni.h 
Michael> from Mozilla GetStringUTFChars returns "const char *" which is much 
Michael> more logical and seems to be the right thing. JNI 1.1 spec says it 
Michael> should return "const jbyte *". I search a little bit with google and 
Michael> jni.h in other open source projects use "const char *" too.

IMO it should be `const char *'.  My reasons are that first, Sun does
this, so presumably most existing JNI source relies on this; second,
this makes more sense; and third, this is what the analogous
GetStringUTFRegion uses.

Note that your patch is insufficient.  You must also update the
GetStringUTFChars call in the C++ class later on in the file.

I think classpath and libgcj should completely share jni.h.  This
probably isn't too hard to get to, since the current classpath version
is a small fork from some earlier libgcj version.  We could put the
gcj-specific stuff into a `jni_md.h' that is gcj-specific if that
would make the task easier.

Also, why is the file `jni.h.in'?  I didn't see any configure
substitutions in it.

Tom



From MAILER-DAEMON Wed Apr 28 14:08:53 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BItM3-0007e1-P7
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 14:00:19 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BItLw-0007YD-J7
	for classpath@gnu.org; Wed, 28 Apr 2004 14:00:12 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BItJG-0006EY-Rk
	for classpath@gnu.org; Wed, 28 Apr 2004 13:57:59 -0400
Received: from [24.25.9.101] (helo=ms-smtp-02-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BItHU-0005Hf-HD
	for classpath@gnu.org; Wed, 28 Apr 2004 13:55:36 -0400
Received: from [10.0.0.2] (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-02-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	i3SHtMkF005901; Wed, 28 Apr 2004 13:55:23 -0400 (EDT)
From: "C. Brian Jones" <cbj@gnu.org>
To: tromey@redhat.com
In-Reply-To: <87r7u8hwga.fsf@fleche.redhat.com>
References: <200404280955.10511.konqueror@gmx.de>
	<87r7u8hwga.fsf@fleche.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-lUnE6dH4mu96MifS9TzM"
Message-Id: <1083174922.3175.90.camel@lyta.haphazard.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Wed, 28 Apr 2004 13:55:22 -0400
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: cbj@gnu.org
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 18:00:17 -0000


--=-lUnE6dH4mu96MifS9TzM
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 2004-04-28 at 12:57, Tom Tromey wrote:
> >>>>> "Michael" =3D=3D Michael Koch <konqueror@gmx.de> writes:
>=20
> Michael> I found out that in jni.h from GCJ (3.3 and 3.5) and jni.h=20
> Michael> from Mozilla GetStringUTFChars returns "const char *" which is m=
uch=20
> Michael> more logical and seems to be the right thing. JNI 1.1 spec says =
it=20
> Michael> should return "const jbyte *". I search a little bit with google=
 and=20
> Michael> jni.h in other open source projects use "const char *" too.
>=20
> IMO it should be `const char *'.  My reasons are that first, Sun does
> this, so presumably most existing JNI source relies on this; second,
> this makes more sense; and third, this is what the analogous
> GetStringUTFRegion uses.
>=20
> Note that your patch is insufficient.  You must also update the
> GetStringUTFChars call in the C++ class later on in the file.
>=20
> I think classpath and libgcj should completely share jni.h.  This
> probably isn't too hard to get to, since the current classpath version
> is a small fork from some earlier libgcj version.  We could put the
> gcj-specific stuff into a `jni_md.h' that is gcj-specific if that
> would make the task easier.
>=20
> Also, why is the file `jni.h.in'?  I didn't see any configure
> substitutions in it.

I think because jni_md.h is generated and to simplify the INCLUDES in
Makefile.am during build.

Brian

--=-lUnE6dH4mu96MifS9TzM
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQBAj/AKcEcmdY33uzYRAgs/AKCh7SW97ulYIoR04bshFVx+4g4XXgCgmEtv
Jyn0p+zgpZrLhaXxDiIpkOs=
=aHp0
-----END PGP SIGNATURE-----

--=-lUnE6dH4mu96MifS9TzM--




From MAILER-DAEMON Wed Apr 28 14:32:25 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BItr6-0008MB-Pw
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 14:32:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BItr3-0008L2-V1
	for classpath@gnu.org; Wed, 28 Apr 2004 14:32:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BItqX-0008Cy-J7
	for classpath@gnu.org; Wed, 28 Apr 2004 14:32:20 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BItpb-0007lq-LY
	for classpath@gnu.org; Wed, 28 Apr 2004 14:30:51 -0400
Received: (qmail 10103 invoked from network); 28 Apr 2004 18:34:02 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <konqueror@gmx.de>; 28 Apr 2004 18:34:02 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 710064F8739; Wed, 28 Apr 2004 12:19:29 -0600 (MDT)
To: cbj@gnu.org
References: <200404280955.10511.konqueror@gmx.de>
	<87r7u8hwga.fsf@fleche.redhat.com>
	<1083174922.3175.90.camel@lyta.haphazard.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I invented skydiving in 1989!
Date: 28 Apr 2004 12:19:29 -0600
In-Reply-To: <1083174922.3175.90.camel@lyta.haphazard.org>
Message-ID: <873c6ohsni.fsf@fleche.redhat.com>
Lines: 10
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 18:32:22 -0000

Tom> Also, why is the file `jni.h.in'?  I didn't see any configure
Tom> substitutions in it.

Brian> I think because jni_md.h is generated and to simplify the INCLUDES in
Brian> Makefile.am during build.

Ok, that makes sense.  I wonder if we can use AC_CONFIG_LINKS
instead, and give the file its real name.

Tom



From MAILER-DAEMON Wed Apr 28 14:52:35 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIuAS-0007Jw-EH
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 14:52:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIuAD-00075h-W1
	for classpath@gnu.org; Wed, 28 Apr 2004 14:52:10 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIuA7-0006vG-9R
	for classpath@gnu.org; Wed, 28 Apr 2004 14:52:06 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BIu9i-0006N6-Sk
	for classpath@gnu.org; Wed, 28 Apr 2004 14:51:39 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BIu9Q-0000Ar-00; Wed, 28 Apr 2004 20:51:20 +0200
From: Mark Wielaard <mark@klomp.org>
To: Dalibor Topic <robilad@kaffe.org>
In-Reply-To: <408FD595.1090607@kaffe.org>
References: <NFBBKALFDCPFIDBNKAPCGENMEBAA.dholmes@dltech.com.au>
	<408FD595.1090607@kaffe.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-vYMoMzd5ImHbm7gQkjKJ"
Message-Id: <1083178284.13734.16.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Wed, 28 Apr 2004 20:51:24 +0200
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 18:52:21 -0000


--=-vYMoMzd5ImHbm7gQkjKJ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2004-04-28 at 18:02, Dalibor Topic wrote:
> David Holmes wrote:
> >>GetStringUTFChars returns "const char *" which is much
> >>more logical and seems to be the right thing. JNI 1.1 spec says it
> >>should return "const jbyte *". I search a little bit with google and
> >>jni.h in other open source projects use "const char *" too. Now I
> >>really wonder what we should do ? Should we leave it like it is and
> >>cast to "const char *" in all instances we use GetStringUTFChars in out
> >>own code or should we just apply the attached patch to change our
> >>jni.h.
> >=20
> > Sun's own jni.h uses "const char*"

[Little intermezzo because I think this is important. Although in this
case it isn't such a big deal of course.]

Please don't refer to proprietary source code when working on GNU
Classpath! An outsider that looks at something that is indeed basically
a public interface and then tells us is not that harmful. And you didn't
do it with the intention to copy any implementation detail. But we
really don't want to refer to proprietary source code whenever we can
avoid it because it would put us in an awkward position if we are ever
in front of a judge about whether or not GNU Classpath was developed in
a clean room way. If there are many instances were people say "yes, of
course I studied that proprietary implementation first before writing
our version" that would make us look bad. And in this case there are
enough publicly available sources that looking at the proprietary
version can be avoided.

Summary: Working from publicly available documentation/books to make
something compatible -> good. Referring to proprietary implementation to
learn implementation details -> bad. See also the Hackers Guide:
http://www.gnu.org/software/classpath/docs/hacking.html#SEC2

Sorry for being so pedantic about this. I do not mean to scare people
that just looking at something is bad. It shouldn't, but in practice it
can work against us so please avoid it when possible. [... insert rant
about proprietary software developers trying to make sharing ideas and
software a crime ... mutter something about Caldera, SCO, Sun ...]

> > This may be a typo in the JNI 1.1 spec as the corresponding
> > ReleaseStringUTFChars takes a "const char*" too.

I was wondering earlier this week why the JNI method GetStringUTFChars()
returns const jbyte* while ReleaseStringUTFChars() takes a const char *.
That definitely indicates that either of these two is wrong.

The Java Native Interface Programmer's Guide and Specification
> uses jbyte* in $3.2.1 example=20
> http://java.sun.com/docs/books/jni/html/objtypes.html . The latest JNI=20
> docs from 1.4.2 also use jbyte :
> http://java.sun.com/j2se/1.4.2/docs/guide/jni/spec/functions.html#wp17265
> The JNI tutorial uses a const char * in its example here
> http://java.sun.com/docs/books/tutorial/native1.1/implementing/string.htm=
l

Found the following old discussion thread between Brian and Tom about it
from 2001:
http://mail.gnu.org/archive/html/classpath/2001-10/msg00119.html
Don't have a copy of the paper JNI book here to check what it says.

Strangely enough contrary to the 1.4 docs, the older 1.3 docs (1.2 isn't
publicly available anymore) say it is const char *:
http://java.sun.com/j2se/1.3/docs/guide/jni/spec/functions.doc.html#17265

Since we seem to agree that const char * is best and we found one more
or less "official" reference that confirms this I think we should change
the classpath jni.h to be similar to what libgcj has.

Tom said that you should also change the C++ declaration which should
indeed match the C prototype. But lets postpone completely merging jni.h
with libgcj till after 0.09 is released (Friday).

This will fix a whole bunch of warnings in the gtk+ peers.

Thanks,

Mark

--=-vYMoMzd5ImHbm7gQkjKJ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAj/0sxVhZCJWr9QwRAtXhAKCm8sG41hFU4gGvq4ldazoAmXWCPQCgjOIL
IFKX2rxZRUwIvV33Rx9I3XA=
=Ux19
-----END PGP SIGNATURE-----

--=-vYMoMzd5ImHbm7gQkjKJ--




From MAILER-DAEMON Wed Apr 28 15:41:56 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIuwK-0000u9-PB
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 15:41:52 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIuwG-0000rD-Au
	for classpath@gnu.org; Wed, 28 Apr 2004 15:41:48 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIuvd-0000IU-MB
	for classpath@gnu.org; Wed, 28 Apr 2004 15:41:41 -0400
Received: from [203.12.22.20] (helo=power.connexus.net.au)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BIuvc-0000Cq-HG
	for classpath@gnu.org; Wed, 28 Apr 2004 15:41:08 -0400
Received: from dholmeslaptop (233-130.ip.internex.net.au [210.9.233.130])
	by power.connexus.net.au (8.12.4/8.11.6) with SMTP id i3SJdGWD096019;
	Thu, 29 Apr 2004 05:39:18 +1000 (EST)
	(envelope-from dholmes@dltech.com.au)
XAntiVirus: This e-mail has been scanned for viruses via the Connexus Internet
	Service
From: "David Holmes" <dholmes@dltech.com.au>
To: "Mark Wielaard" <mark@klomp.org>
Date: Thu, 29 Apr 2004 05:39:47 +1000
Message-ID: <NFBBKALFDCPFIDBNKAPCKEOBEBAA.dholmes@dltech.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0)
In-Reply-To: <1083178284.13734.16.camel@elsschot.wildebeest.org>
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409
Importance: Normal
Cc: classpath@gnu.org
Subject: RE: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 19:41:50 -0000

> Please don't refer to proprietary source code when working on GNU
> Classpath!

I don't work on GNU Classpath. At most I comment on organisation (VMxxx for
example) and I report bugs. I have had too much involvement with the JDK and
other Sun VM implementations to ever be able to contribute to Classpath.

A declaration in a header file that is for application use is hardly
"proprietary source code". But I know where you're coming from.

Besides, how do you know my compiler didn't give me the information. ;-)

David Holmes





From MAILER-DAEMON Wed Apr 28 16:04:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIvGr-0001vC-W8
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 16:03:05 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIvFa-00016P-UR
	for classpath@gnu.org; Wed, 28 Apr 2004 16:01:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIvDz-0000LT-1x
	for classpath@gnu.org; Wed, 28 Apr 2004 16:00:38 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BIvCL-0008JK-TN
	for classpath@gnu.org; Wed, 28 Apr 2004 15:58:26 -0400
Received: (qmail 21777 invoked from network); 28 Apr 2004 20:01:33 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <dholmes@dltech.com.au>; 28 Apr 2004 20:01:33 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id E7DC44F8739; Wed, 28 Apr 2004 13:46:58 -0600 (MDT)
To: "David Holmes" <dholmes@dltech.com.au>
References: <NFBBKALFDCPFIDBNKAPCKEOBEBAA.dholmes@dltech.com.au>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Ask me the DIFFERENCE between PHIL SILVERS and ALEXANDER HAIG!!
Date: 28 Apr 2004 13:46:58 -0600
In-Reply-To: <NFBBKALFDCPFIDBNKAPCKEOBEBAA.dholmes@dltech.com.au>
Message-ID: <87brlbholp.fsf@fleche.redhat.com>
Lines: 9
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Mark Wielaard <mark@klomp.org>, classpath@gnu.org
Subject: Re: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 20:02:56 -0000

>>>>> "David" == David Holmes <dholmes@dltech.com.au> writes:

David> Besides, how do you know my compiler didn't give me the
David> information. ;-)

Yeah, IMO this is a case where reverse engineering is appropriate and
required for interoperability.  I don't think we have problems here.

Tom



From MAILER-DAEMON Wed Apr 28 16:05:25 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIvHq-0002Vo-4Q
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 16:04:06 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIvHb-0002Lk-Ee
	for classpath@gnu.org; Wed, 28 Apr 2004 16:03:51 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIvGf-0001ii-Cp
	for classpath@gnu.org; Wed, 28 Apr 2004 16:03:24 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BIvGQ-0001XL-JL
	for classpath@gnu.org; Wed, 28 Apr 2004 16:02:38 -0400
Received: (qmail 24163 invoked from network); 28 Apr 2004 20:05:54 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <konqueror@gmx.de>; 28 Apr 2004 20:05:54 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 628B04F8739; Wed, 28 Apr 2004 13:51:20 -0600 (MDT)
To: Jeff Sturm <jsturm@one-point.com>
References: <Pine.LNX.4.44.0404241127510.5951-100000@ops2.one-point.com>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Now, I think it would be GOOD to buy FIVE or SIX STUDEBAKERS
	and CRUISE for ARTIFICIAL FLAVORING!!
Date: 28 Apr 2004 13:51:20 -0600
In-Reply-To: <Pine.LNX.4.44.0404241127510.5951-100000@ops2.one-point.com>
Message-ID: <877jvzhoef.fsf@fleche.redhat.com>
Lines: 15
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: GNU Classpath Project <classpath@gnu.org>,
	Mauve News Group <mauve-discuss@sources.redhat.com>,
	Michael Koch <konqueror@gmx.de>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 20:04:01 -0000

Jeff> (What about Mauve?  Much of Eclipse's usefulness for us comes from
Jeff> interactively running the test suite so we get a very quick
Jeff> edit/compile/test/debug cycle.  But eclipse only knows about junit-style
Jeff> tests, not the gnu.testlet classes in Mauve.)

I think Graydon changed Mauve to use JUnit at one point, but it never
went in.  I think there was some confusion about some points I made.

It's time to revisit this (various folks pointed this out to me at the
recent RH meeting).  IMO anything that makes Mauve easier to hack is a
good thing.  My only real requirement is that we still be able to run
the gcj test suite; I don't think there is any substantial problem
here.

Tom



From MAILER-DAEMON Wed Apr 28 16:40:56 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIvr4-0000ly-LL
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 16:40:30 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIvqj-0000Yr-OD
	for classpath@gnu.org; Wed, 28 Apr 2004 16:40:09 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIvqG-00083Q-39
	for classpath@gnu.org; Wed, 28 Apr 2004 16:39:43 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BIvq6-00080g-VE
	for classpath@gnu.org; Wed, 28 Apr 2004 16:39:31 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BIvpn-0000Wj-00; Wed, 28 Apr 2004 22:39:11 +0200
From: Mark Wielaard <mark@klomp.org>
To: tromey@redhat.com
In-Reply-To: <87brlbholp.fsf@fleche.redhat.com>
References: <NFBBKALFDCPFIDBNKAPCKEOBEBAA.dholmes@dltech.com.au>
	<87brlbholp.fsf@fleche.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-6TETDbnO7KaLu/djb2ue"
Message-Id: <1083184754.13725.28.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Wed, 28 Apr 2004 22:39:15 +0200
Cc: classpath@gnu.org
Subject: Re: Patch: jni.h
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 20:40:27 -0000


--=-6TETDbnO7KaLu/djb2ue
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2004-04-28 at 21:46, Tom Tromey wrote:
> >>>>> "David" =3D=3D David Holmes <dholmes@dltech.com.au> writes:
>=20
> David> Besides, how do you know my compiler didn't give me the
> David> information. ;-)
>=20
> Yeah, IMO this is a case where reverse engineering is appropriate and
> required for interoperability.  I don't think we have problems here.

Yes, sorry David if gave the impression that your help isn't welcome or
that such a simple fact cannot be shared with the group. But I thought a
friendly reminder in general about the Requirements section from the
Hacker Guide wouldn't hurt. Before people might get the idea they could
help the project by picking up the sources of some proprietary
implementation and quoting significant sections from it on list whenever
we have a discussion about what the most appropriate way is to implement
something. (In general we want to have a better implementation than the
proprietary one anyway!)

Your presence on the list, insights, ideas and integration of GNU
Classpath with OVM are really appreciated!

Cheers,

Mark

--=-6TETDbnO7KaLu/djb2ue
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAkBZyxVhZCJWr9QwRArf2AKCInbjZ7Lyh62cIDw+tM5GBfrFAVQCgl9lp
eT4H9gf4BcqDCfdt5lD2Szw=
=9Nfw
-----END PGP SIGNATURE-----

--=-6TETDbnO7KaLu/djb2ue--




From MAILER-DAEMON Wed Apr 28 17:59:50 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIx5q-00057j-16
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 17:59:50 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIx5m-00054O-Ko
	for classpath@gnu.org; Wed, 28 Apr 2004 17:59:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIx2O-0003I7-Fn
	for classpath@gnu.org; Wed, 28 Apr 2004 17:56:47 -0400
Received: from [213.51.128.198] (helo=smtpq3.home.nl)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BIx2D-00039o-Jy
	for classpath@gnu.org; Wed, 28 Apr 2004 17:56:05 -0400
Received: from [213.51.128.135] (port=59464 helo=smtp4.home.nl)
	by smtpq3.home.nl with esmtp (Exim 4.30)
	id 1BIx28-00012s-G1; Wed, 28 Apr 2004 23:56:00 +0200
Received: from cc68231-a.ensch1.ov.home.nl ([212.120.112.227]:33867
	helo=dumas.thomas.planescape.com)
	by smtp4.home.nl with esmtp (Exim 4.30)
	id 1BIx2F-0000d5-Ao; Wed, 28 Apr 2004 23:56:07 +0200
From: Thomas Zander <zander@javalobby.org>
To: mauve-discuss@sources.redhat.com
Date: Wed, 28 Apr 2004 23:54:49 +0200
User-Agent: KMail/1.6.2
References: <Pine.LNX.4.44.0404241127510.5951-100000@ops2.one-point.com>
	<877jvzhoef.fsf@fleche.redhat.com>
In-Reply-To: <877jvzhoef.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200404282354.50797.zander@javalobby.org>
X-AtHome-MailScanner-Information: Please contact support@home.nl for more
	information
X-AtHome-MailScanner: Found to be clean
Cc: Jeff Sturm <jsturm@one-point.com>,
	GNU Classpath Project <classpath@gnu.org>, Michael Koch <konqueror@gmx.de>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 21:59:47 -0000

=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 28 April 2004 21:51, Tom Tromey wrote:
> Jeff> (What about Mauve?  Much of Eclipse's usefulness for us comes from
> Jeff> interactively running the test suite so we get a very quick
> Jeff> edit/compile/test/debug cycle.  But eclipse only knows about
> junit-style Jeff> tests, not the gnu.testlet classes in Mauve.)
>
> I think Graydon changed Mauve to use JUnit at one point, but it never
> went in.  I think there was some confusion about some points I made.
>
> It's time to revisit this (various folks pointed this out to me at the
> recent RH meeting).  IMO anything that makes Mauve easier to hack is a
> good thing.  My only real requirement is that we still be able to run
> the gcj test suite; I don't think there is any substantial problem
> here.

IIRC the biggest problem with using JUnit is that it depends of rather=20
advanced JVM features; like reflection.

Its technically possible to have a mauve test case extend a=20
mauve-base-class which can be changed on run-time (probably using a=20
singleton) to either use the very-simple-mauve test framework, or the=20
JUnit ones. Using a facade pattern in that baseclass.
Its still needed to call each test in one long test() method if you want to=
=20
use the mauve version, but other then that it would integrate with JUnit=20
quite nicely.

Naturally all tests will need to be refactored to do this..
=2D - extending a base class instead of implementing Testlet
=2D - using the assertTrue() style checking instead of the check() versions.

Thoughts?

=2D --=20
Thomas
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAkCgpCojCW6H2z/QRAp0LAKCxgcsGMzDHdMPDDVDTPUBNPCQjGgCgkU8j
qAf1uGZxFCYoTpSJreFpitY=3D
=3DnRwQ
=2D----END PGP SIGNATURE-----



From MAILER-DAEMON Wed Apr 28 18:41:32 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIxjO-0005TJ-QY
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 18:40:42 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIxj7-00053v-Lg
	for classpath@gnu.org; Wed, 28 Apr 2004 18:40:25 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIxiP-0004Ai-8e
	for classpath@gnu.org; Wed, 28 Apr 2004 18:40:13 -0400
Received: from [32.97.182.106] (helo=e6.ny.us.ibm.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BIxiH-0003wX-Tv
	for classpath@gnu.org; Wed, 28 Apr 2004 18:39:34 -0400
Received: from northrelay02.pok.ibm.com (northrelay02.pok.ibm.com
	[9.56.224.150])
	by e6.ny.us.ibm.com (8.12.10/8.12.2) with ESMTP id i3SMdRfQ651914;
	Wed, 28 Apr 2004 18:39:27 -0400
Received: from d01ml604.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by northrelay02.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id
	i3SMdbgs106258; Wed, 28 Apr 2004 18:39:41 -0400
In-Reply-To: <200404282354.50797.zander@javalobby.org>
To: Thomas Zander <zander@javalobby.org>
MIME-Version: 1.0
X-Mailer: Lotus Notes Release 6.0 September 26, 2002
From: David P Grove <groved@us.ibm.com>
X-MIMETrack: S/MIME Sign by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/28/2004 06:39:15 PM,
	Serialize by Notes Client on David P Grove/Watson/IBM(Release
	6.0|September 26, 2002) at 04/28/2004 06:39:15 PM,
	Serialize complete at 04/28/2004 06:39:15 PM,
	S/MIME Sign failed at 04/28/2004 06:39:15 PM: The cryptographic key was
	not found,
	Serialize by Router on D01ML604/01/M/IBM(Release 6.51HF141 | April 6,
	2004) at 04/28/2004 18:39:26,
	Serialize complete at 04/28/2004 18:39:26
Message-ID: <OFD30D19BA.CBC8235A-ON85256E84.007C2292-85256E84.007C73EC@us.ibm.com>
Date: Wed, 28 Apr 2004 18:39:34 -0400
Content-Type: multipart/alternative;
	boundary="=_alternative 007C719B85256E84_="
Cc: Jeff Sturm <jsturm@one-point.com>,
	GNU Classpath Project <classpath@gnu.org>,
	mauve-discuss@sources.redhat.com, Michael Koch <konqueror@gmx.de>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 22:40:37 -0000

This is a multipart message in MIME format.
--=_alternative 007C719B85256E84_=
Content-Type: text/plain; charset="US-ASCII"

> IIRC the biggest problem with using JUnit is that it depends of rather 
> advanced JVM features; like reflection.

Sorry if this is an ignorant question, but is this really an issue?  I'd 
always assumed (without actually checking) that most (all?) of the VMs 
being used by classpath developers implement reflection.  If this is the 
case, then maybe making reflection a pre-req for being able to run mauve 
wouldn't be an issue.  It's hard to run very much Java code these days 
without running into some use of reflection by the application.

--dave
--=_alternative 007C719B85256E84_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2><tt>&gt; IIRC the biggest problem with using JUnit is
that it depends of rather <br>
&gt; advanced JVM features; like reflection.<br>
</tt></font>
<br><font size=2><tt>Sorry if this is an ignorant question, but is this
really an issue? &nbsp;I'd always assumed (without actually checking) that
most (all?) of the VMs being used by classpath developers implement reflection.
&nbsp;If this is the case, then maybe making reflection a pre-req for being
able to run mauve wouldn't be an issue. &nbsp;It's hard to run very much
Java code these days without running into some use of reflection by the
application.</tt></font>
<br>
<br><font size=2><tt>--dave</tt></font>
--=_alternative 007C719B85256E84_=--



From MAILER-DAEMON Wed Apr 28 18:55:22 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BIxxa-0005cH-2s
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 18:55:22 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BIxxX-0005bs-P4
	for classpath@gnu.org; Wed, 28 Apr 2004 18:55:19 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BIxx1-0005V1-52
	for classpath@gnu.org; Wed, 28 Apr 2004 18:55:18 -0400
Received: from [207.203.42.3] (helo=STVAVAPPL1.BHMSTV)
	by monty-python.gnu.org with smtp (Exim 4.30) id 1BIxx0-0005Uv-Hw
	for classpath@gnu.org; Wed, 28 Apr 2004 18:54:46 -0400
Received: from unknown(10.104.180.64) by STVAVAPPL1.BHMSTV via csmap 
	id 44d1c162_9966_11d8_8efd_00304811e8c8_5599;
	Wed, 28 Apr 2004 17:49:12 -0500 (CDT)
Received: from arch20m.dellroad.org (localhost [127.0.0.1])
	by arch20m.dellroad.org (8.12.9p2/8.12.9) with ESMTP id i3SMoi5h003365; 
	Wed, 28 Apr 2004 17:50:45 -0500 (CDT)
	(envelope-from archie@arch20m.dellroad.org)
Received: (from archie@localhost)
	by arch20m.dellroad.org (8.12.9p2/8.12.9/Submit) id i3SMoiuV003364;
	Wed, 28 Apr 2004 17:50:44 -0500 (CDT) (envelope-from archie)
From: Archie Cobbs <archie@dellroad.org>
Message-Id: <200404282250.i3SMoiuV003364@arch20m.dellroad.org>
In-Reply-To: <OFD30D19BA.CBC8235A-ON85256E84.007C2292-85256E84.007C73EC@us.ibm.com>
To: David P Grove <groved@us.ibm.com>
Date: Wed, 28 Apr 2004 17:50:44 -0500 (CDT)
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: Jeff Sturm <jsturm@one-point.com>,
	GNU Classpath Project <classpath@gnu.org>,
	mauve-discuss@sources.redhat.com, Michael Koch <konqueror@gmx.de>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Apr 2004 22:55:20 -0000

David P Grove wrote:
> > IIRC the biggest problem with using JUnit is that it depends of rather 
> > advanced JVM features; like reflection.
> 
> Sorry if this is an ignorant question, but is this really an issue?  I'd 
> always assumed (without actually checking) that most (all?) of the VMs 
> being used by classpath developers implement reflection.  If this is the 
> case, then maybe making reflection a pre-req for being able to run mauve 
> wouldn't be an issue.  It's hard to run very much Java code these days 
> without running into some use of reflection by the application.

I inferred the problem to be that reflection is one of the things
we want to test, so we shouldn't be relying on it for the test itself.
Of course, if reflection doesn't work, then the test will probably
still fail :-) But it may make it harder to track down the real problem.

All in all, it's probably not a major deal... Perhaps there could be
a small set of basic reflection tests that didn't use JUnit too.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com



From MAILER-DAEMON Wed Apr 28 21:23:49 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJ0HF-0004GU-6H
	for mharc-classpath@gnu.org; Wed, 28 Apr 2004 21:23:49 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJ0HC-0004Ft-NC
	for classpath@gnu.org; Wed, 28 Apr 2004 21:23:46 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJ0Gg-0004Ah-QZ
	for classpath@gnu.org; Wed, 28 Apr 2004 21:23:45 -0400
Received: from [207.174.178.92] (helo=email2.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BJ0Bo-0003Ko-TJ
	for classpath@gnu.org; Wed, 28 Apr 2004 21:18:13 -0400
Received: (qmail 20361 invoked from network); 29 Apr 2004 01:21:30 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email2.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <dog@bluezoo.org>; 29 Apr 2004 01:21:30 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id 502C94F8739; Wed, 28 Apr 2004 19:06:54 -0600 (MDT)
To: Chris Burdess <dog@bluezoo.org>
References: <1082715425.3307.46.camel@localhost>
	<200404231250.59041.konqueror@gmx.de>
	<87wu46mjhr.fsf@fleche.redhat.com>
	<20040424151518.GA30792@bluezoo.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: I am having a pleasant time!!
Date: 28 Apr 2004 19:06:54 -0600
In-Reply-To: <20040424151518.GA30792@bluezoo.org>
Message-ID: <87k6zzegnl.fsf@fleche.redhat.com>
Lines: 17
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: classpath@gnu.org, Michael Koch <konqueror@gmx.de>
Subject: Re: gnu.java.net.protocol.file.Handler again (and java.net.URL)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2004 01:23:47 -0000

>>>>> "Chris" == Chris Burdess <dog@bluezoo.org> writes:

>> I'd like it if we could also add the inetlib package by default:
>> `gnu.inet'.  That might not be possible right now since the classes in
>> the inetlib protocol handler packages don't have the expected names.

Chris> Could you file a bug about that? and I'll correct it ASAP.

Done.

Chris> I also have generic mailbox and mailto URLConnection classes which use
Chris> GNU JavaMail; I can't put these in inetlib for dependency reasons, what
Chris> should I do with them?

Maybe these should go in the JavaMail package?

Tom



From MAILER-DAEMON Thu Apr 29 01:11:04 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJ3pA-0007mn-59
	for mharc-classpath@gnu.org; Thu, 29 Apr 2004 01:11:04 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJ3p6-0007lK-Oo
	for classpath@gnu.org; Thu, 29 Apr 2004 01:11:00 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJ3oa-0007UL-0F
	for classpath@gnu.org; Thu, 29 Apr 2004 01:10:59 -0400
Received: from [24.25.9.100] (helo=ms-smtp-01-eri0.southeast.rr.com)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJ3nF-0006tf-DT
	for classpath@gnu.org; Thu, 29 Apr 2004 01:09:05 -0400
Received: from [10.0.0.2] (rdu57-9-048.nc.rr.com [66.57.9.48])
	by ms-smtp-01-eri0.southeast.rr.com (8.12.10/8.12.7) with ESMTP id
	i3T58tSm001283; Thu, 29 Apr 2004 01:08:55 -0400 (EDT)
From: "C. Brian Jones" <cbj@gnu.org>
To: Archie Cobbs <archie@dellroad.org>
In-Reply-To: <200404282250.i3SMoiuV003364@arch20m.dellroad.org>
References: <200404282250.i3SMoiuV003364@arch20m.dellroad.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-+3s/sod4nXC34/JG2y0g"
Message-Id: <1083215334.3175.104.camel@lyta.haphazard.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-7) 
Date: Thu, 29 Apr 2004 01:08:55 -0400
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Cc: Jeff Sturm <jsturm@one-point.com>,
	GNU Classpath Project <classpath@gnu.org>,
	mauve-discuss@sources.redhat.com, Michael Koch <konqueror@gmx.de>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: cbj@gnu.org
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2004 05:11:01 -0000


--=-+3s/sod4nXC34/JG2y0g
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 2004-04-28 at 18:50, Archie Cobbs wrote:
> David P Grove wrote:
> > > IIRC the biggest problem with using JUnit is that it depends of rathe=
r=20
> > > advanced JVM features; like reflection.
> >=20
> > Sorry if this is an ignorant question, but is this really an issue?  I'=
d=20
> > always assumed (without actually checking) that most (all?) of the VMs=20
> > being used by classpath developers implement reflection.  If this is th=
e=20
> > case, then maybe making reflection a pre-req for being able to run mauv=
e=20
> > wouldn't be an issue.  It's hard to run very much Java code these days=20
> > without running into some use of reflection by the application.
>=20
> I inferred the problem to be that reflection is one of the things
> we want to test, so we shouldn't be relying on it for the test itself.
> Of course, if reflection doesn't work, then the test will probably
> still fail :-) But it may make it harder to track down the real problem.
>=20
> All in all, it's probably not a major deal... Perhaps there could be
> a small set of basic reflection tests that didn't use JUnit too.

Junit does not require reflection if used in a particular manner.  See
http://junit.sourceforge.net/doc/testinfected/testing.htm.  But it's
probably easier all around if reflection is allowed.

JUnit supports two ways of running single tests:=20
      * static
      * dynamic
In the static way you override the runTest method inherited from
TestCase and call the desired test case. A convenient way to do this is
with an anonymous inner class. Note that each test must be given a name,
so you can identify it if it fails.=20
TestCase test=3D new MoneyTest("simple add") {
    public void runTest() {
        testSimpleAdd();
    }
};

--=-+3s/sod4nXC34/JG2y0g
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQBAkI3mcEcmdY33uzYRAkHBAKCbmEB53Bp0RypoOeoE6jIkTpF70gCfQHpV
AwM5as0SZS6Za+5sw5ScZ+M=
=AIyP
-----END PGP SIGNATURE-----

--=-+3s/sod4nXC34/JG2y0g--




From MAILER-DAEMON Thu Apr 29 05:48:08 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJ89I-0007H2-FI
	for mharc-classpath@gnu.org; Thu, 29 Apr 2004 05:48:08 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJ899-0007C5-Dl
	for classpath@gnu.org; Thu, 29 Apr 2004 05:47:59 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJ891-00077U-Pz
	for classpath@gnu.org; Thu, 29 Apr 2004 05:47:54 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJ890-00076J-R7
	for classpath@gnu.org; Thu, 29 Apr 2004 05:47:51 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BJ88n-0002td-00; Thu, 29 Apr 2004 11:47:37 +0200
From: Mark Wielaard <mark@klomp.org>
To: tromey@redhat.com
In-Reply-To: <87ad12pocs.fsf@fleche.redhat.com>
References: <87oepkqbit.fsf@fleche.redhat.com>
	<1082711821.27234.238.camel@elsschot.wildebeest.org>
	<87ad12pocs.fsf@fleche.redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Au2NObb/FXplv5gaA3nR"
Message-Id: <1083232063.24008.79.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Thu, 29 Apr 2004 11:47:43 +0200
Cc: GNU Classpath Project <classpath@gnu.org>
Subject: Re: Eclipse and Classpath
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2004 09:48:02 -0000


--=-Au2NObb/FXplv5gaA3nR
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2004-04-23 at 19:59, Tom Tromey wrote:
> >>>>> "Mark" =3D=3D Mark Wielaard <mark@klomp.org> writes:
>=20
> Mark> There are a couple of things that I am worried about:
>=20
> Mark> - Having multiple build systems were we have enough maintenance
> Mark>   work with the current one.
>=20
> Yeah, make no mistake, if we encourage people to use IDEs, it will
> eventually have some effect.  For instance, if we ever want to start
> doing preprocessing, we'll run into conflicts.  (Personally I don't
> see this as a big problem, since I'm not that keen on preprocessing,
> but I know there are differences here already.)

Just see the Configuration.java[.in] file for the smallest example.
(Even though most things in that file should probably be provided
through the Runtime/System properties). The only thing that is really
essential in that file is probably the VERSION and DEBUG flags. If that
is really it then we might consider just keeping them up to date by hand
(kind of like we currently do with the jni header files).

> On the other hand, some effects of IDEs are beneficial.  As we've
> already seen, Eclipse has a good compiler which has already found real
> Classpath bugs.

Yeah, but we can also get that with ecj (the gcj native compiled Eclipse
Compiler from RHUG http://sources.redhat.com/rhug/) which is simple to
integrate with the current build system.

> Mark> - Pretending we support Eclipse which is arguably non-free since pe=
ople
> Mark>   are not testing, running and developing it with free runtimes.
> Mark>   (You claim adding this might make this happen sooner. I do hope s=
o.)
>=20
> I did all my work with Eclipse running on a free runtime.  And AFAIK
> Eclipse 2.x works out of the box with many runtimes, including gcc 3.4
> (just released).

OK I checked. Kaffe (1.1.4, debian pacakge) does run Eclipse 2.1.2, but
isn't stable enough for hacking on GNU Classpath. jamvm + 0.09-pre is
almost there it seems but doesn't startup completely (some strange crash
deep in GTK+ with 2.1.2, 3.0M8 just hangs half way during startup eating
up lots of CPU, dunno why). Jikes RVM prototype build bootstrapped from
kaffe seems to work, but does crash occasionally. The development build
crashes pretty quickly. Jeroen reports that IKVM.NET + Mono even runs
Eclipse 3.0M8 correctly, haven't tried that yet.

I reinstalled the native Eclipse from http://sources.redhat.com/eclipse/
and that does indeed work nicely with your project and classpath files.
gij 3.5 (CVS) does work, but needs some tweaking
(http://gcc.gnu.org/ml/java/2004-04/msg00246.html). gij 3.4 (from Debian
experimental) does indeed startup 2.1.2, but has troubles with the java
view (which is kind of essential if you want to use Eclipse for GNU
Classpath hacking):

!MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.ui=
.workbench".
!STACK 0
java.lang.VerifyError: verification failed at PC 22 in org.eclipse.jdt.ui.a=
ctions.FindReferencesAction:<init>((Lorg.eclipse.ui.IWorkbenchSite;)V): uni=
nitialized object in local variable
   at _Jv_BytecodeVerifier.verify_fail(byte, int) (/usr/lib/libgcj.so.5.0.0=
)

I guess it would work when disabling the verifier, but I was to lazy
(and out of diskspace) to try to recompile libgcj from source.

> Mark> If you can show me some people that run Eclipse in a free environme=
nt
> Mark> that are actually happy with using your setup files than I am all f=
or
> Mark> including them. But you must promise to maintain them. The only har=
d
> Mark> part seem to come up with the list of "classpaths" and the "exclusi=
on
> Mark> list", which is done by hand in our normal build system also.
>=20
> Yeah, I'll do this.  There really isn't much to maintain.  I think the
> worst case is if nobody uses these and they rot.  But if that happens,
> then we know people aren't using Eclipse to hack Classpath, and the
> solution is simple: cvs rm.

OK. Thanks.

Cheers,

Mark

--=-Au2NObb/FXplv5gaA3nR
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAkM8+xVhZCJWr9QwRAh93AJ0U3U4FI1GSpT159bpNqAMpLDeh6QCfcZcd
EQcNbegFB5xAz3QvAJehl6g=
=6MpJ
-----END PGP SIGNATURE-----

--=-Au2NObb/FXplv5gaA3nR--




From MAILER-DAEMON Thu Apr 29 13:28:35 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJFKt-0008UI-EK
	for mharc-classpath@gnu.org; Thu, 29 Apr 2004 13:28:35 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJFKq-0008T6-GX
	for classpath@gnu.org; Thu, 29 Apr 2004 13:28:32 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJFKI-0008IF-4t
	for classpath@gnu.org; Thu, 29 Apr 2004 13:28:29 -0400
Received: from [132.208.250.6] (helo=anis.telecom.uqam.ca)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJF8n-0005Xj-48
	for classpath@gnu.org; Thu, 29 Apr 2004 13:16:05 -0400
Received: from anis4.telecom.uqam.ca (anis4.telecom.uqam.ca [132.208.250.236])
	by sortant.uqam.ca (8.12.10/8.12.1) with SMTP id i3TH5Ds0013704;
	Thu, 29 Apr 2004 13:06:07 -0400 (EDT)
Received: from antivirus.uqam.ca ([132.208.250.6])
	by anis4.telecom.uqam.ca (SAVSMTP 3.1.1.32) with SMTP id
	M2004042913073106537 ; Thu, 29 Apr 2004 13:07:31 -0400
Received: from glue.info.uqam.ca (glue.info.uqam.ca [132.208.135.95])
	by intrant.uqam.ca (8.12.10/8.12.2/uqam-filtres) with ESMTP id
	i3TH2pYT005552; Thu, 29 Apr 2004 13:02:51 -0400 (EDT)
X-Spam-Filter: Filtre-Uqam re:  abuse@uqam.ca
From: "Grzegorz B. Prokopski" <gadek@debian.org>
To: Thomas Fitzsimmons <fitzsim@redhat.com>
In-Reply-To: <1083170776.22187.155.camel@tortoise.toronto.redhat.com>
References: <20040424225205.GA1160@gadek.homelinux.org>
	<1083170776.22187.155.camel@tortoise.toronto.redhat.com>
Content-Type: text/plain
Message-Id: <1083246167.19969.2.camel@glue>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Thu, 29 Apr 2004 09:42:47 -0400
Content-Transfer-Encoding: 7bit
Cc: classpath list <classpath@gnu.org>
Subject: Re: AWT regression?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2004 17:28:33 -0000

On Wed, 2004-04-28 at 12:46, Thomas Fitzsimmons wrote:
> On Sat, 2004-04-24 at 18:52, Grzegorz B. Prokopski wrote:
> > Hi all,
> > 
> > We've just imported fresh GNU CP as of Fri Apr 23 and running SymbolTest
> > program, that previously worked nicely, as documented ex. at
> > http://www.sablevm.org/screenshots , now gives this:
> > 
> > $ ~/work/bin/java-sablevm SymbolTest 
> > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> >  java.lang.NullPointerException
> >     at java.applet.Applet.getDimensions (Applet.java:469)
> >     at java.applet.Applet.preferredSize (Applet.java:486)
> >     at java.awt.Container.getPreferredSize (Container.java:576)
> >     at java.awt.BorderLayout.calcCompSize (BorderLayout.java:647)
> >     at java.awt.BorderLayout.calcSize (BorderLayout.java:692)
> >     at java.awt.BorderLayout.preferredLayoutSize (BorderLayout.java:454)
> >     at java.awt.Container.preferredSize (Container.java:589)
> >     at java.awt.Container.getPreferredSize (Container.java:576)
> >     at java.awt.Window.pack (Window.java:206)
> >     at SymbolTest.main (SymbolTest.java:100)
> >     at java.lang.VirtualMachine.invokeMain (VirtualMachine.java)
> >     at java.lang.VirtualMachine.main (VirtualMachine.java:88)
> > 
> 
> I recently changed size reporting in Applet.java.  I made applets report
> their preferred size as the width and height attributes given in the
> applet tag.  However, the current code assumes that an applet stub is
> present that can be queried for these attributes.  The NPE you're seeing
> is likely caused by the stub not having been set.
> 
> The attached patch should fix the problem, though I haven't tested it. 
> Can you try it out?

Hi Thomas,

I got a report (had no time to do it myself :-( ) that your patch
actually fixed the problem.  I guess it should go into GNU CP CVS ASAP
and 0.09 release too.

Thanks for the help,

			Grzegorz B. Prokopski





From MAILER-DAEMON Thu Apr 29 13:47:25 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJFd6-0004P3-W1
	for mharc-classpath@gnu.org; Thu, 29 Apr 2004 13:47:24 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJFd3-0004NT-7T
	for classpath@gnu.org; Thu, 29 Apr 2004 13:47:21 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJFL3-000054-Jh
	for classpath@gnu.org; Thu, 29 Apr 2004 13:29:18 -0400
Received: from [207.189.223.52] (helo=email3.peakpeak.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BJElc-0000ro-0U
	for classpath@gnu.org; Thu, 29 Apr 2004 12:52:08 -0400
Received: (qmail 24127 invoked from network); 29 Apr 2004 17:12:44 -0000
Received: from 203-214-189-207.dyn.peakpeak.com (HELO fleche.redhat.com)
	([207.189.214.203]) (envelope-sender <tromey@redhat.com>)
	by email3.peakpeak.com (qmail-ldap-1.03) with SMTP
	for <classpath@gnu.org>; 29 Apr 2004 17:12:44 -0000
Received: by fleche.redhat.com (Postfix, from userid 1000)
	id E8CCF4F82AF; Thu, 29 Apr 2004 10:40:43 -0600 (MDT)
To: GNU Classpath Project <classpath@gnu.org>
From: Tom Tromey <tromey@redhat.com>
X-Attribution: Tom
X-Zippy: Will the third world war keep ``Bosom Buddies'' off the air?
Date: 29 Apr 2004 10:40:42 -0600
Message-ID: <87oepad9f9.fsf@fleche.redhat.com>
Lines: 29
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Eclipse Instructions
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
Reply-To: tromey@redhat.com
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2004 17:47:22 -0000

I've checked in the two Eclipse support files, so you can now use
Eclipse to check out and build GNU Classpath.  This still isn't
entirely straightforward, so I'm sending this message to explain how
to do it.

* Check out Classpath from Eclipse just as you would check out any
  project.  This is the easy part :-)

* Edit gnu/classpath/Configuration.java.in, turn it into a valid Java
  source file (in particular you must edit the DEBUG and
  INIT_LOAD_LIBRARY fields; I set them both to `true').
  Now save this file as gnu/classpath/Configuration.java;
  this will cause a rebuild.

* Go to the project preferences and then "Java Task Tags" page.
  Select "use project settings", and then add the tags "FIXME", "FIX ME",
  and "XXX".

* Go to the Java Compiler page and select "use project settings".
  Set "Usage of deprecated API" to "ignore"; all of "unused
  paramters", "unused local variables", and "unused private types,
  methods or fields" to "warning".

* Go to Preferences, choose Java->Editor, then set the tab width to 8

Of course you can set other preferences; these are the ones I
consider indispensible when hacking on Classpath.

Tom



From MAILER-DAEMON Thu Apr 29 13:56:08 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJFlX-0006BL-HW
	for mharc-classpath@gnu.org; Thu, 29 Apr 2004 13:56:07 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJFlT-00069R-G9
	for classpath@gnu.org; Thu, 29 Apr 2004 13:56:03 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJFks-0005xu-9A
	for classpath@gnu.org; Thu, 29 Apr 2004 13:55:57 -0400
Received: from [66.187.233.31] (helo=mx1.redhat.com)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.30) id 1BJFg9-0005GL-5V
	for classpath@gnu.org; Thu, 29 Apr 2004 13:50:33 -0400
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com
	[172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3THoOKG009106;
	Thu, 29 Apr 2004 13:50:24 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com
	[172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3THoOv04352; 
	Thu, 29 Apr 2004 13:50:24 -0400
Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com
	[172.16.14.92])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id
	i3THoNcU022691; Thu, 29 Apr 2004 13:50:23 -0400
From: Thomas Fitzsimmons <fitzsim@redhat.com>
To: "Grzegorz B. Prokopski" <gadek@debian.org>
In-Reply-To: <1083246167.19969.2.camel@glue>
References: <20040424225205.GA1160@gadek.homelinux.org>
	<1083170776.22187.155.camel@tortoise.toronto.redhat.com>
	<1083246167.19969.2.camel@glue>
Content-Type: text/plain
Message-Id: <1083261023.22124.15.camel@tortoise.toronto.redhat.com>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) 
Date: Thu, 29 Apr 2004 13:50:23 -0400
Content-Transfer-Encoding: 7bit
Cc: classpath list <classpath@gnu.org>
Subject: Re: AWT regression?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2004 17:56:05 -0000

On Thu, 2004-04-29 at 09:42, Grzegorz B. Prokopski wrote:
> On Wed, 2004-04-28 at 12:46, Thomas Fitzsimmons wrote:
> > On Sat, 2004-04-24 at 18:52, Grzegorz B. Prokopski wrote:
> > > Hi all,
> > > 
> > > We've just imported fresh GNU CP as of Fri Apr 23 and running SymbolTest
> > > program, that previously worked nicely, as documented ex. at
> > > http://www.sablevm.org/screenshots , now gives this:
> > > 
> > > $ ~/work/bin/java-sablevm SymbolTest 
> > > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> > >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> > > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> > >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> > > (:19347): Gtk-CRITICAL **: file gtkwidget.c: line 4248
> > >   (gtk_widget_modify_fg): assertion `GTK_IS_WIDGET (widget)' failed
> > >  java.lang.NullPointerException
> > >     at java.applet.Applet.getDimensions (Applet.java:469)
> > >     at java.applet.Applet.preferredSize (Applet.java:486)
> > >     at java.awt.Container.getPreferredSize (Container.java:576)
> > >     at java.awt.BorderLayout.calcCompSize (BorderLayout.java:647)
> > >     at java.awt.BorderLayout.calcSize (BorderLayout.java:692)
> > >     at java.awt.BorderLayout.preferredLayoutSize (BorderLayout.java:454)
> > >     at java.awt.Container.preferredSize (Container.java:589)
> > >     at java.awt.Container.getPreferredSize (Container.java:576)
> > >     at java.awt.Window.pack (Window.java:206)
> > >     at SymbolTest.main (SymbolTest.java:100)
> > >     at java.lang.VirtualMachine.invokeMain (VirtualMachine.java)
> > >     at java.lang.VirtualMachine.main (VirtualMachine.java:88)
> > > 
> > 
> > I recently changed size reporting in Applet.java.  I made applets report
> > their preferred size as the width and height attributes given in the
> > applet tag.  However, the current code assumes that an applet stub is
> > present that can be queried for these attributes.  The NPE you're seeing
> > is likely caused by the stub not having been set.
> > 
> > The attached patch should fix the problem, though I haven't tested it. 
> > Can you try it out?
> 
> Hi Thomas,
> 
> I got a report (had no time to do it myself :-( ) that your patch
> actually fixed the problem.  I guess it should go into GNU CP CVS ASAP
> and 0.09 release too.
> 

OK, patch checked in.  I think the fix will make it into 0.09.  Thanks
for the report,

Tom





From MAILER-DAEMON Fri Apr 30 05:49:47 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJUeQ-0004R3-8b
	for mharc-classpath@gnu.org; Fri, 30 Apr 2004 05:49:46 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJQer-0008I6-Jx
	for classpath@gnu.org; Fri, 30 Apr 2004 01:33:57 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJQeI-00086V-OQ
	for classpath@gnu.org; Fri, 30 Apr 2004 01:33:53 -0400
Received: from [209.226.175.25] (helo=tomts5-srv.bellnexxia.net)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJQeI-00085r-7E
	for classpath@gnu.org; Fri, 30 Apr 2004 01:33:22 -0400
Received: from mail.mcgill.ca ([65.92.214.246]) by tomts5-srv.bellnexxia.net
	(InterMail vM.5.01.06.05 201-253-122-130-105-20030824) with ESMTP
	id <20040430053312.VJAN26398.tomts5-srv.bellnexxia.net@mail.mcgill.ca>; 
	Fri, 30 Apr 2004 01:33:12 -0400
Message-ID: <4091E57B.5040407@mail.mcgill.ca>
Date: Fri, 30 Apr 2004 01:34:51 -0400
From: Chris Pickett <chris.pickett@mail.mcgill.ca>
User-Agent: Mozilla Thunderbird 0.5 (X11/20040424)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Chris Pickett <chris.pickett@mail.mcgill.ca>
References: <4091C5F4.7080904@mail.mcgill.ca> <4091D2C6.4020608@uqam.ca>
	<4091DFBA.4080405@mail.mcgill.ca>
In-Reply-To: <4091DFBA.4080405@mail.mcgill.ca>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Fri, 30 Apr 2004 05:49:38 -0400
Cc: sablevm-developer@lists.sourceforge.net,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>, classpath@gnu.org
Subject: Re: [Sablevm-developer] sablevm-classpath broken in staging?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2004 05:33:58 -0000

Chris Pickett wrote:
> I couldn't find "ifnotplaintext" in google, and I couldn't find it in 
> `info texinfo` using 'i ifnotplaintext' either.
> 
> Tomorrow I'll try installing the latest texinfo (4.7) and see if that 
> fixes things.

I checked in Google again and ifnotplaintext turned up a link to texinfo 
4.2.  My apologies (I used exactly the same textbox entry, so I really 
don't know what happened).

So I guess Classpath should now mark texinfo-4.2 as a dependency.

For Classpath people:  when trying to build sablevm-classpath with 
recent changes, makeinfo was telling me it didn't understand 
@ifnotplaintext, and my texinfo version was 4.1.

Cheers,
Chris



From MAILER-DAEMON Fri Apr 30 08:54:20 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJXX2-0000zN-3d
	for mharc-classpath@gnu.org; Fri, 30 Apr 2004 08:54:20 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJXWv-0000xv-Ga
	for classpath@gnu.org; Fri, 30 Apr 2004 08:54:13 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJXWt-0000xl-L1
	for classpath@gnu.org; Fri, 30 Apr 2004 08:54:12 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJWtS-0003BJ-3h
	for classpath@gnu.org; Fri, 30 Apr 2004 08:13:26 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BJWt1-0007cu-00; Fri, 30 Apr 2004 14:12:59 +0200
From: Mark Wielaard <mark@klomp.org>
To: Chris Pickett <chris.pickett@mail.mcgill.ca>
In-Reply-To: <4091E57B.5040407@mail.mcgill.ca>
References: <4091C5F4.7080904@mail.mcgill.ca> <4091D2C6.4020608@uqam.ca>
	<4091DFBA.4080405@mail.mcgill.ca>  <4091E57B.5040407@mail.mcgill.ca>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-NL/NqN7iL7+V19yUD89d"
Message-Id: <1083327183.19520.2.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Fri, 30 Apr 2004 14:13:03 +0200
Cc: sablevm-developer@lists.sourceforge.net,
	Etienne Gagnon <gagnon.etienne_m@uqam.ca>, classpath@gnu.org
Subject: Re: [Sablevm-developer] sablevm-classpath broken in staging?
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2004 12:54:14 -0000


--=-NL/NqN7iL7+V19yUD89d
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, 2004-04-30 at 07:34, Chris Pickett wrote:
> Chris Pickett wrote:
> > I couldn't find "ifnotplaintext" in google, and I couldn't find it in=20
> > `info texinfo` using 'i ifnotplaintext' either.
> >=20
> > Tomorrow I'll try installing the latest texinfo (4.7) and see if that=20
> > fixes things.
>=20
> I checked in Google again and ifnotplaintext turned up a link to texinfo=20
> 4.2.  My apologies (I used exactly the same textbox entry, so I really=20
> don't know what happened).
>=20
> So I guess Classpath should now mark texinfo-4.2 as a dependency.

Yes, thanks for noticing.
I add a little thing to the Hacker Guide and the INSTALL document
mentioning texinfo and the minimal version needed. Texinfo 4.2 was
release in April 2002 so I think we can safely recommend that version
(we are now at version 4.7).

Cheers,

Mark

--=-NL/NqN7iL7+V19yUD89d
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAkkLPxVhZCJWr9QwRAnBxAJ9MP37QtlgRbG7lDOTwIgQEJhiRlQCdGaJc
5vC3kvCVlOEBM8BAgd2OZCc=
=KaI2
-----END PGP SIGNATURE-----

--=-NL/NqN7iL7+V19yUD89d--




From MAILER-DAEMON Fri Apr 30 14:14:33 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJcWu-00008A-3t
	for mharc-classpath@gnu.org; Fri, 30 Apr 2004 14:14:32 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJcWo-0008UQ-Ey
	for classpath@gnu.org; Fri, 30 Apr 2004 14:14:26 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJcWg-0008OA-5P
	for classpath@gnu.org; Fri, 30 Apr 2004 14:14:19 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJcSD-0006nG-9K
	for classpath@gnu.org; Fri, 30 Apr 2004 14:09:41 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BJcRe-0000LK-00; Fri, 30 Apr 2004 20:09:06 +0200
From: Mark Wielaard <mark@klomp.org>
To: Steven Augart <augart@watson.ibm.com>
In-Reply-To: <406171CF.3030304@watson.ibm.com>
References: <NFBBKALFDCPFIDBNKAPCGEHGDPAA.dholmes@dltech.com.au>
	<406171CF.3030304@watson.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-xZX7zpdVSdtnKuAYdQXJ"
Message-Id: <1083348550.19520.35.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Fri, 30 Apr 2004 20:09:10 +0200
Cc: classpath@gnu.org
Subject: Re: user.timezone property
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2004 18:14:27 -0000


--=-xZX7zpdVSdtnKuAYdQXJ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2004-03-24 at 12:32, Steven Augart wrote:
> David Holmes wrote:
> [...]
> > I fill in user.timezone during insertSystemProperties at the same time =
as
> > all the other dynamic properties that have to be obtained from the OS: =
file
> > encoding, user name, os name, current dir etc etc.
>=20
> Jikes RVM sets those in "runrvm", a shell script that calls the actual=20
> C executable.
>=20
> [....]
> > The native code with classpath seems to have a bug in it though because=
 it
> > ignores tzname[1] when it is different to tzname[0] rather than when it=
 is
> > the same.
>=20
> Yes, I see it too. I should get the rest of my night's sleep and then=20
> think about a test case to manifest the problem.

Most probably to late for 0.09. But did anybody look more into this
and/or make a test case? (BTW, please but such things in the savannah
bug database also.)

> [....]
> > My feeling is that user.timezone is not a property that is filled in fo=
r use
> > by application code, but rather for one part of the VM to communicate
> > indirectly with another part.=20
>=20
> This makes sense, yes.  Now I know why I want to set it; my test=20
> program that calls TimeZone.getDefault().getDisplayName() always=20
> prints "Greenwich Mean Time" if I don't.

Hmmmm. We probably should provide a convenience native function to set
it when the runtime doesn't set it. That is actually what the
getDefaultTimeZoneId() should do, but from the above I assume it is
broken.

Sorry for not picking this up earlier.

Cheers,

Mark

--=-xZX7zpdVSdtnKuAYdQXJ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAkpZGxVhZCJWr9QwRAkiuAJ9EoZsGVu6KMyWBNyu9Z7IMSdQzCgCfTe6F
39YtTBcMl6B84tLpTn8ggCo=
=SLXL
-----END PGP SIGNATURE-----

--=-xZX7zpdVSdtnKuAYdQXJ--




From MAILER-DAEMON Fri Apr 30 18:13:24 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJgFo-0002v1-Gz
	for mharc-classpath@gnu.org; Fri, 30 Apr 2004 18:13:08 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJgFM-0002Mv-6d
	for classpath@gnu.org; Fri, 30 Apr 2004 18:12:40 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJgFG-0002Cd-B8
	for classpath@gnu.org; Fri, 30 Apr 2004 18:12:37 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJgBX-0000vh-M5
	for classpath@gnu.org; Fri, 30 Apr 2004 18:08:43 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BJgBF-00012J-00; Sat, 01 May 2004 00:08:25 +0200
From: Mark Wielaard <mark@klomp.org>
To: Ingo =?ISO-8859-1?Q?Pr=F6tel?= <proetel@aicas.com>
In-Reply-To: <4074EE81.8010400@aicas.com>
References: <40742D2A.7040206@aicas.com> <87y8p7v6cq.fsf@fleche.redhat.com>
	<4074EE81.8010400@aicas.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-TEOeSXiD83RgQ28JiDsy"
Message-Id: <1083362909.19534.88.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Sat, 01 May 2004 00:08:29 +0200
Cc: tromey@redhat.com, Classpath Discussion Mailing List <classpath@gnu.org>
Subject: Re: Patch: remove C++ keywords
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Apr 2004 22:12:56 -0000


--=-TEOeSXiD83RgQ28JiDsy
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, 2004-04-08 at 08:17, Ingo Pr=F6tel wrote:
> Tom Tromey wrote:
> >>>>>>"Ingo" =3D=3D Ingo Pr=F6tel <proetel@aicas.com> writes:
> >=20
> >=20
> > Ingo> I would like to suggest removing all C++ keywords as names in
> > Ingo> the native implementations of GNU Classpath. We have a customer
> > Ingo> who insists on using C++ because of the more thorough code
> > Ingo> inspection.  To be able to compile with such a compiler we need
> > Ingo> to change all names that are C++ keywords.
> >=20
> > I think this idea is fine.  It doesn't bother me anyway... though I'd
> > suggest waiting for a response from folks who hack on the JNI code
> > more than me :-)
> >=20
> I guess I will wait a week or so. (Going on a long Easter weekend anyway =
;-)

I saw this patch didn't go in yet. But it seems people like it.
Since lots of native code changed since then I didn't want to import it
now just before the release. But please commit next week after the
release has been made and rechecking the patch still applies cleanly.

> > My only comment or criticism is that, in the absence of regular
> > checking for this, we'll just see more code like it checked in.
> > That's been the experience with non-C89 constructs, I don't see why
> > this would be any different.  It's just too hard to remember to write
> > in some language subset without compiler-assisted checking.
> >=20
> > We could declare all the JNI code to actually be C++, of course.  But
> > then we'd see real C++ usage slip in.
> No we should stay within C. But compiling was C++ code once in a while
> does give a little code review.

I would like to see the suggestion of Eric Blake implemented:

> To avoid regressions, would we want to use a common header file to
> #define the C++ keywords into something that will generate a
> compile-time error when compiling under C?  That is
>=20
> #define this do not use C++ keywords, JNI must compile in C and C++

Otherwise it will be a pain to keep this feature up to date.

Cheers,

Mark

--=-TEOeSXiD83RgQ28JiDsy
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAks5cxVhZCJWr9QwRAvPSAJ0eF7dQsrzbf76Gut631s+GCHqUSwCdGkSP
qcyDfCJhq6zJJctpR5iVu0w=
=Ubue
-----END PGP SIGNATURE-----

--=-TEOeSXiD83RgQ28JiDsy--




From MAILER-DAEMON Fri Apr 30 20:51:54 2004
Received: from list by monty-python.gnu.org with archive (Exim 4.30)
	id 1BJijS-0001Gj-3Q
	for mharc-classpath@gnu.org; Fri, 30 Apr 2004 20:51:54 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1BJijL-0001Dh-Uj
	for classpath@gnu.org; Fri, 30 Apr 2004 20:51:47 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1BJijH-00019u-2v
	for classpath@gnu.org; Fri, 30 Apr 2004 20:51:44 -0400
Received: from [82.161.94.186] (helo=nescio.wildebeest.org)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJijA-00017T-BW
	for classpath@gnu.org; Fri, 30 Apr 2004 20:51:36 -0400
Received: from elsschot.wildebeest.org ([192.168.1.26] ident=mark)
	by nescio.wildebeest.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BJij2-0001Tk-00
	for <classpath@gnu.org>; Sat, 01 May 2004 02:51:28 +0200
From: Mark Wielaard <mark@klomp.org>
To: classpath@gnu.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Pc1+1seYGsNnH+9syl3r"
Message-Id: <1083372691.19532.136.camel@elsschot.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.6 
Date: Sat, 01 May 2004 02:51:31 +0200
Subject: GNU Classpath 0.09 release (not yet, but pre1 available)
X-BeenThere: classpath@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: Discussion of the implemenation of the core Java class libraries
	<classpath.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/classpath>
List-Post: <mailto:classpath@gnu.org>
List-Help: <mailto:classpath-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/classpath>,
	<mailto:classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 01 May 2004 00:51:49 -0000


--=-Pc1+1seYGsNnH+9syl3r
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Hi all,

We did a lot (much thanks to Michael Koch for working together the last
two days on irc going over all the outstanding issues) and we are almost
there. People following the commit-classpath list have seen that we did
a lot of code and documentation cleanups. There are also more Mauve test
cases and most outstanding bugs and patches (either on the list or on
savannah) have been looked at (but only the non-controversial/safe once
have been applied - lots to do for 0.10 and beyond!).

If you want to help test please take a look at the pre-release at
http://www.klomp.org/mark/classpath/classpath-0.09-pre1.tar.gz
(Warning, this includes the FileChannel.truncate() patch currently being
discussed on commit-classpath.)
When using JamVM you want to apply the patches posted at
http://mail.gnu.org/archive/html/classpath/2004-04/msg00312.html

Before we release I want to have done the following:

- FileChannel.truncate() bug fix (see commit-classpath, already in above
  pre-release).
- Check whether to reimport new GNU JAXP (probably a version before the
  libxmlj integration since that is to big a change)
- Check (VM)Process (PATH) environment passing.
- Make "official" mauve-results list.
- Recheck visual test engine.
- Recheck API documentation generation (either with native gjdoc or the
  one now included in kaffe CVS)
- Add text/explanation about runtime VM classes from workshop paper
  (and recent mailinglist discussion) to Integration Guide.
- Create Release Announcements
  - Add everything new to NEWS file (please contribute!)
  - Mailinglist announcement/Savannah news entry.
  - Update Free Software Directory entry.

Hopefully this will all be done tomorrow since I will take a little
vacation after the release. But there isn't anything super important
that is currently missing. So I expect a real release tomorrow whatever
we happen to finish.

Cheers,

Mark

--=-Pc1+1seYGsNnH+9syl3r
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBAkvSTxVhZCJWr9QwRApOBAKCOmphkMQHtzmkx/yv/1ek3F3chJgCgg6IR
6trkusK/ryIUjZnDDeis17g=
=+JS/
-----END PGP SIGNATURE-----

--=-Pc1+1seYGsNnH+9syl3r--




