From MAILER-DAEMON Sun Oct 30 03:36:44 2011
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1RKPwi-0002aH-Dh
	for mharc-commit-classpath@gnu.org; Sun, 30 Oct 2011 03:36:44 -0400
Received: from eggs.gnu.org ([140.186.70.92]:33867)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <penberg@cs.helsinki.fi>) id 1RKPwf-0002a8-Mo
	for commit-classpath@gnu.org; Sun, 30 Oct 2011 03:36:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <penberg@cs.helsinki.fi>) id 1RKPwe-0007RD-Eh
	for commit-classpath@gnu.org; Sun, 30 Oct 2011 03:36:41 -0400
Received: from vcs.savannah.gnu.org ([140.186.70.72]:58280)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <penberg@cs.helsinki.fi>) id 1RKPwe-0007R9-DB
	for commit-classpath@gnu.org; Sun, 30 Oct 2011 03:36:40 -0400
Received: from penberg by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <penberg@cs.helsinki.fi>) id 1RKPwd-0007PR-QR
	for commit-classpath@gnu.org; Sun, 30 Oct 2011 07:36:39 +0000
Date: Sun, 30 Oct 2011 07:36:39 +0000
Message-Id: <E1RKPwd-0007PR-QR@vcs.savannah.gnu.org>
To: commit-classpath@gnu.org
From: Pekka Enberg <penberg@cs.helsinki.fi>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 140.186.70.72
Subject: [commit-cp] classpath ChangeLog java/util/HashMap.java
X-BeenThere: commit-classpath@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: classpath-patches@gnu.org
List-Id: "Automatic administrative message \(CVS, bugs,
	regressions\)." <commit-classpath.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-classpath>,
	<mailto:commit-classpath-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/commit-classpath>
List-Post: <mailto:commit-classpath@gnu.org>
List-Help: <mailto:commit-classpath-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-classpath>,
	<mailto:commit-classpath-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Oct 2011 07:36:43 -0000

CVSROOT:	/sources/classpath
Module name:	classpath
Changes by:	Pekka Enberg <penberg>	11/10/30 07:36:39

Modified files:
	.              : ChangeLog 
	java/util      : HashMap.java 

Log message:
	Stefan Ring reports that commit f154af6 ("Fix HashMap.put() to check for
	hashCode equality before equals()") breaks running the CACAO test suite.  The
	breakage looks like this:
	
	  LD_LIBRARY_PATH=../../../src/cacao/.libs ../../../src/cacao/cacao -Xbootclasspath:../../../src/classes/classes:/home/sr/classpathcvs/share/classpath/glibj.zip -classpath /usr/share/java/junit4.jar:. org.junit.runner.JUnitCore All
	  JUnit version 4.5
	  .E
	  Time: 0.003
	  There was 1 failure:
	  1) initializationError(All)
	  java.lang.NullPointerException
	     at java.util.HashMap.put(HashMap.java:348)
	     at java.util.HashSet.add(HashSet.java:151)
	     at org.junit.runners.model.RunnerBuilder.addParent(RunnerBuilder.java:64)
	     at org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:81)
	     at org.junit.runners.Suite.<init>(Suite.java:88)
	     at org.junit.runners.Suite.<init>(Suite.java:54)
	     at java.lang.reflect.VMConstructor.construct(Native Method)
	     at java.lang.reflect.Constructor.newInstance(Constructor.java:318)
	     at org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:35)
	     at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:24)
	     at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:57)
	     at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:29)
	     at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:57)
	     at org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:93)
	     at org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:84)
	     at org.junit.runners.Suite.<init>(Suite.java:66)
	     at org.junit.runner.Request.classes(Request.java:68)
	     at org.junit.runner.JUnitCore.run(JUnitCore.java:107)
	     at org.junit.runner.JUnitCore.runMain(JUnitCore.java:88)
	     at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:54)
	     at org.junit.runner.JUnitCore.main(JUnitCore.java:46)
	
	  FAILURES!!!
	  Tests run: 1,  Failures: 1
	
	Looking at the code, it's obviously broken for HashMap.put() with a null key.
	
	2011-10-24  Pekka Enberg  <penberg@kernel.org>
	
	        * java/util/HashMap.java:
	        (put): Fix NullPointerException for null keys.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpath&r1=1.9832&r2=1.9833
http://cvs.savannah.gnu.org/viewcvs/classpath/java/util/HashMap.java?cvsroot=classpath&r1=1.37&r2=1.38


