From MAILER-DAEMON Sat Feb 01 18:18:59 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1iy22V-0007ZL-0H
	for mharc-commit-inetutils@gnu.org; Sat, 01 Feb 2020 18:18:59 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:51428)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <gnu@gisladisker.se>) id 1iy22R-0007ZF-N5
 for commit-inetutils@gnu.org; Sat, 01 Feb 2020 18:18:57 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:59343)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <gnu@gisladisker.se>) id 1iy22R-00014X-F4
 for commit-inetutils@gnu.org; Sat, 01 Feb 2020 18:18:55 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 117592)
 id 58DFB20DE3; Sat,  1 Feb 2020 18:18:55 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-71-g416326d
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 0fac847c6de53bf925c3778ea1ad65e76d0e5480
X-Git-Newrev: 416326d0ac272a438c90fb145b4ff5c59d70c4de
Message-Id: <20200201231855.58DFB20DE3@vcs0.savannah.gnu.org>
Date: Sat,  1 Feb 2020 18:18:54 -0500 (EST)
From: gnu@gisladisker.se (Mats Erik Andersson)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Feb 2020 23:18:57 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  416326d0ac272a438c90fb145b4ff5c59d70c4de (commit)
      from  0fac847c6de53bf925c3778ea1ad65e76d0e5480 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=416326d0ac272a438c90fb145b4ff5c59d70c4de


commit 416326d0ac272a438c90fb145b4ff5c59d70c4de
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Sun Feb 2 00:17:38 2020 +0100

    tests: Less system logging.

diff --git a/ChangeLog b/ChangeLog
index 59b1950..3cc3c69 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2020-02-01  Mats Erik Andersson  <gnu@gisladisker.se>
+
+	tests: Less system logging.
+
+	* tests/ftp-localhost.sh (LOGGING): New variable.  Let the server
+	program do system logging only if LOGGING has been defined.
+	* tests/tftp.sh (LOGGING): Likewise.  Add a test case where a
+	non-existing file is requested.  Check that the number of tries
+	and of successes agree in order to suppress the final text.
+
+	* README: Add some remarks on our testing abilities.
+
 2020-01-31  Mats Erik Andersson  <gnu@gisladisker.se>
 
 	whois: IP delegation update.
diff --git a/README b/README
index 3194198..b340722 100644
--- a/README
+++ b/README
@@ -22,6 +22,31 @@ if you explicitly specify whether to build a program, that will
 override the values specified by --disable-clients or
 --disable-servers.
 
+Some words on testing are in order.  The three tests `ftp-localhost',
+`ping', and `traceroute', all need to be run by root.  Several tests
+will depend on infrastructure files in `/etc/', but most tests will
+complain about their obvious needs.  Anyway, these dependencies are
+important whenever chrooted builds are conducted.
+
+At the time of running a test, the shell variables TEST_IPV4 and
+TEST_IPV6 are influential.  Regard them as taking one of three values:
+`yes', `no', or `auto'.  When assigned the value `auto', a small check
+at runtime will determine if the corresponding address family is available,
+and accordingly include it during test.  The values `yes', and `no',
+include or exclude the corresponding address family unconditionally.
+
+During configuration time, TEST_IPV# is essentially set to `auto',
+except that `-enable-ipv#' assigns `yes', and `--disable-ipv#' assigns
+`no' unconditionally.  Note however, that `--disable-ipv6' retains
+its property of removing all support for IPv6 in every executable,
+while `--disable-ipv4' only affects the testing target `check' and scripts.
+
+During chrooted tests, the runtime check for either family can be
+fooled, so setting `TEST_IPV6=yes' might be necessary.  On the other
+hand, chrooting similar to a FreeBSD jail, normally changes the address
+of `localhost', so similar environments will need counteractions like
+`TARGET=10.0.6.1'.
+
 The GNU whois client reads a whois-servers file to figure out which
 whois server to use.  It won't always pick the best server;
 whois.internic.net seems to know something about nic.ddn.mil, but the
diff --git a/tests/ftp-localhost.sh b/tests/ftp-localhost.sh
index 8f6d5de..a31f220 100755
--- a/tests/ftp-localhost.sh
+++ b/tests/ftp-localhost.sh
@@ -33,6 +33,14 @@
 #
 #    OpenBSD uses /etc/services directly, not via /etc/nsswitch.conf.
 
+# Influential shell variables:
+#
+#   TARGET	IPv4 address for tests.  Defaults to 127.0.0.1.
+#   TARGET6	IPv6 address for tests.  Defaults to ::1.
+#   TARGET46	IPv4-mapped-IPv6 address.  Defaults to ::ffff:127.0.0.1.
+#   VERBOSE	Whenever defined, test runs in verbose mode.
+#   LOGGING	When defined, let `ftpd' do system logging.
+#
 # FIXME: Better test coverage!
 #
 # Implemented: anonymous-only in inetd-mode.
@@ -261,14 +269,14 @@ fi
     }
 
 test "$TEST_IPV4" = "no" ||
-    cat <<EOT > "$TMPDIR/inetd.conf"
-$PORT stream tcp4 nowait $USER $PWD/$FTPD ftpd -A -l
-EOT
+    cat <<-EOT > "$TMPDIR/inetd.conf"
+	$PORT stream tcp4 nowait $USER $PWD/$FTPD ftpd -A ${LOGGING+"-l"}
+	EOT
 
 test "$TEST_IPV6" = "no" ||
-    cat <<EOT >> "$TMPDIR/inetd.conf"
-$PORT stream tcp6 nowait $USER $PWD/$FTPD ftpd -A -l
-EOT
+    cat <<-EOT >> "$TMPDIR/inetd.conf"
+	$PORT stream tcp6 nowait $USER $PWD/$FTPD ftpd -A ${LOGGING+"-l"}
+	EOT
 
 : > "$TMPDIR/.netrc" 2>/dev/null ||
     {
diff --git a/tests/tftp.sh b/tests/tftp.sh
index d7d016c..47c123d 100755
--- a/tests/tftp.sh
+++ b/tests/tftp.sh
@@ -46,9 +46,12 @@
 #
 # The values of TARGET and TARGET6 replace the loopback addresses
 # 127.0.0.1 and ::1, whenever the variables are set.  However,
-# Setting the variable ADDRESSES to a list of addresses takes
+# setting the variable ADDRESSES to a list of addresses takes
 # precedence over all other choices.  The particular value "sense"
 # tries to find all local addresses, then go ahead with these.
+#
+# Whenever set, VERBOSE and LOGGING, this test is performed in verbose
+# mode, and lets `tftpd' do system logging, respectively.
 
 . ./tools.sh
 
@@ -211,12 +214,12 @@ write_conf () {
 
     test "$TEST_IPV4" = "no" ||
 	cat >> "$INETD_CONF" <<-EOF
-	$PORT dgram ${PROTO}4 wait $USER $TFTPD   tftpd -l $TMPDIR/tftp-test
+	$PORT dgram ${PROTO}4 wait $USER $TFTPD   tftpd ${LOGGING+"-l"} $TMPDIR/tftp-test
 	EOF
 
     test "$TEST_IPV6" = "no" ||
 	cat >> "$INETD_CONF" <<-EOF
-	$PORT dgram ${PROTO}6 wait $USER $TFTPD   tftpd -l $TMPDIR/tftp-test
+	$PORT dgram ${PROTO}6 wait $USER $TFTPD   tftpd ${LOGGING+"-l"} $TMPDIR/tftp-test
 	EOF
 }
 
@@ -356,7 +359,7 @@ $silence echo "Looking into '`echo $ADDRESSES | tr "\n" ' '`'."
 for addr in $ADDRESSES; do
     $silence echo "trying address '$addr'..." >&2
 
-    for name in $FILELIST; do
+    for name in $FILELIST missing-file; do
 	test -n "$name" || continue
 	EFFORTS=`expr $EFFORTS + 1`
 	rm -f "$name"
@@ -365,8 +368,15 @@ for addr in $ADDRESSES; do
 get $name" | \
 	eval "$TFTP" ${VERBOSE:+-v} "$addr" $PORT $bucket
 
-	cmp "$TMPDIR/tftp-test/$name" "$name" 2>/dev/null
-	result=$?
+	if test "$name" != "missing-file"; then
+	   cmp "$TMPDIR/tftp-test/$name" "$name" 2>/dev/null
+	   result=$?
+	else
+	   # No data should have arrived, but traditionally an empty
+	   # file was created.
+	   result=0
+	   test ! -s "$name" || result=1
+	fi
 
 	if [ "$result" -ne 0 ]; then
 	    # Failure.
@@ -435,12 +445,12 @@ if $do_secure_setting; then
 
     test "$TEST_IPV4" = "no" ||
 	cat >> "$INETD_CONF" <<-EOF
-	$PORT dgram ${PROTO}4 wait $USER $TFTPD   tftpd -l -s $TMPDIR /tftp-test
+	$PORT dgram ${PROTO}4 wait $USER $TFTPD   tftpd ${LOGGING+"-l"} -s $TMPDIR /tftp-test
 	EOF
 
     test "$TEST_IPV6" = "no" ||
 	cat >> "$INETD_CONF" <<-EOF
-	$PORT dgram ${PROTO}6 wait $USER $TFTPD   tftpd -l -s $TMPDIR /tftp-test
+	$PORT dgram ${PROTO}6 wait $USER $TFTPD   tftpd ${LOGGING+"-l"} -s $TMPDIR /tftp-test
 	EOF
 
     # Let inetd reload configuration.
@@ -492,7 +502,7 @@ fi
 
 # Minimal clean up. Main work in posttesting().
 $silence echo
-test $RESULT -eq 0 && $silence false \
+test $RESULT -eq 0 && test $SUCCESSES -eq $EFFORTS && $silence false \
     || echo Test had $SUCCESSES successes out of $EFFORTS cases.
 
 exit $RESULT

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog              | 12 ++++++++++++
 README                 | 25 +++++++++++++++++++++++++
 tests/ftp-localhost.sh | 20 ++++++++++++++------
 tests/tftp.sh          | 28 +++++++++++++++++++---------
 4 files changed, 70 insertions(+), 15 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Mon Feb 03 13:52:28 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1iygpg-0002gw-1t
	for mharc-commit-inetutils@gnu.org; Mon, 03 Feb 2020 13:52:28 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:41588)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <gnu@gisladisker.se>) id 1iygpc-0002cb-29
 for commit-inetutils@gnu.org; Mon, 03 Feb 2020 13:52:25 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:47013)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <gnu@gisladisker.se>) id 1iygpb-0003Wp-NJ
 for commit-inetutils@gnu.org; Mon, 03 Feb 2020 13:52:23 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 117592)
 id 8D66620A10; Mon,  3 Feb 2020 13:52:23 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-73-g60d0f2e
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 416326d0ac272a438c90fb145b4ff5c59d70c4de
X-Git-Newrev: 60d0f2ec4eb0f14765d40a58ab0e556ef6de58cb
Message-Id: <20200203185223.8D66620A10@vcs0.savannah.gnu.org>
Date: Mon,  3 Feb 2020 13:52:22 -0500 (EST)
From: gnu@gisladisker.se (Mats Erik Andersson)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Feb 2020 18:52:26 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  60d0f2ec4eb0f14765d40a58ab0e556ef6de58cb (commit)
       via  5164b075a5825154efdda66511f030de3fa3623a (commit)
      from  416326d0ac272a438c90fb145b4ff5c59d70c4de (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=60d0f2ec4eb0f14765d40a58ab0e556ef6de58cb


commit 60d0f2ec4eb0f14765d40a58ab0e556ef6de58cb
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Mon Feb 3 19:51:05 2020 +0100

    whois: AUDA services Australia.

diff --git a/ChangeLog b/ChangeLog
index dae57cd..3b625d8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2020-02-03  Mats Erik Andersson  <gnu@gisladisker.se>
 
+	whois: AUDA services Australia.
+	Update server name.  Forwarded from Adam King:
+	https://lists.gnu.org/archive/html/bug-inetutils/2018-07/msg00001.html
+
+	* whois/tld_serv_list (.au): Update server, now at AUDA.
+
+2020-02-03  Mats Erik Andersson  <gnu@gisladisker.se>
+
 	Better portability for BSD install.
 	Install hooks for programs that require root ownership, were written
 	with GNU install in mind.  Reported and suggested by Bill Cole:
diff --git a/whois/tld_serv_list b/whois/tld_serv_list
index 79ca3c7..1f82419 100644
--- a/whois/tld_serv_list
+++ b/whois/tld_serv_list
@@ -56,7 +56,7 @@
 .as	whois.nic.as
 .at	whois.ripe.net
 .net.au	whois.connect.com.au
-.au	whois.aunic.net
+.au	whois.auda.org.au
 #.aw			# NIC? www.setarnet.aw
 #.az	NONE		# NIC? http://www.az/ www.domain.az
 .ba	NONE		# http://www.utic.net.ba

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=5164b075a5825154efdda66511f030de3fa3623a


commit 5164b075a5825154efdda66511f030de3fa3623a
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Mon Feb 3 19:12:28 2020 +0100

    Better portability for BSD install.
    
    Reordering arguments in install hooks improves portability, and the
    inclusion of exit codes helps post analysis.  Reported by Bill Cole.

diff --git a/ChangeLog b/ChangeLog
index 3cc3c69..dae57cd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2020-02-03  Mats Erik Andersson  <gnu@gisladisker.se>
+
+	Better portability for BSD install.
+	Install hooks for programs that require root ownership, were written
+	with GNU install in mind.  Reported and suggested by Bill Cole:
+	https://lists.gnu.org/archive/html/bug-inetutils/2018-07/msg00005.html
+
+	* ping/Makefile.am (install-ping-hook): Place program switches
+	to INSTALL_PROGRAM before file argument, thus helping BSD install.
+	Rewrite failure comment, and add exit error code.
+	* src/Makefile.am (install-traceroute-hook, install-rsh-hook)
+	(install-rlogin-hook, install-rcp-hook): Likewise.
+
 2020-02-01  Mats Erik Andersson  <gnu@gisladisker.se>
 
 	tests: Less system logging.
diff --git a/ping/Makefile.am b/ping/Makefile.am
index c2a1771..39890d4 100644
--- a/ping/Makefile.am
+++ b/ping/Makefile.am
@@ -39,10 +39,10 @@ SUIDMODE = -o root -m 4755
 
 install-ping-hook:
 	-@for x in $(bin_PROGRAMS); do \
-	$(INSTALL_PROGRAM) $$x $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) $(DESTDIR)$(bindir)/`echo $$x|sed '$(transform)'` ; \
-	if test $$? -ne 0; then \
-	  echo "WARNING: insufficient access; not installing $$x"; \
-	  echo "NOTE: To install $$x run 'make install' as root"; \
+	$(INSTALL_PROGRAM) $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) $$x $(DESTDIR)$(bindir)/`echo $$x|sed '$(transform)'` ; OUTCOME=$$?; \
+	if test $$OUTCOME -ne 0; then \
+	  echo "WARNING: Failed to install $$x (exit code $$OUTCOME)"; \
+	  echo "NOTE: This program often needs to be owned by root."; \
 	fi \
 	done
 
diff --git a/src/Makefile.am b/src/Makefile.am
index 962dae4..4e0e1d0 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -119,29 +119,29 @@ SUIDMODE = -o root -m 4755
 install-exec-hook: $(traceroute_INSTALL_HOOK) $(rsh_INSTALL_HOOK) $(rlogin_INSTALL_HOOK) $(rcp_INSTALL_HOOK)
 
 install-traceroute-hook:
-	-@$(INSTALL_PROGRAM) traceroute $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) $(DESTDIR)$(bindir)/`echo traceroute|sed '$(transform)'` ; \
-	if test $$? -ne 0; then \
-	  echo "WARNING: insufficient access; not installing traceroute"; \
-	  echo "NOTE: To install traceroute run 'make install' as root"; \
+	-@$(INSTALL_PROGRAM) $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) traceroute $(DESTDIR)$(bindir)/`echo traceroute|sed '$(transform)'` ; OUTCOME=$$?; \
+	if test $$OUTCOME -ne 0; then \
+	  echo "WARNING: Failed to install traceroute (exit code $$OUTCOME)"; \
+	  echo "NOTE: This program often needs to be owned by root."; \
 	fi
 
 install-rsh-hook:
-	-@$(INSTALL_PROGRAM) rsh $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) $(DESTDIR)$(bindir)/`echo rsh|sed '$(transform)'` ; \
-	if test $$? -ne 0; then \
-	  echo "WARNING: insufficient access; not installing rsh"; \
-	  echo "NOTE: To install rsh run 'make install' as root"; \
+	-@$(INSTALL_PROGRAM) $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) rsh $(DESTDIR)$(bindir)/`echo rsh|sed '$(transform)'` ; OUTCOME=$$?; \
+	if test $$OUTCOME -ne 0; then \
+	  echo "WARNING: Failed to install rsh (exit code $$OUTCOME)"; \
+	  echo "NOTE: This program often needs to be owned by root."; \
 	fi
 
 install-rlogin-hook:
-	-@$(INSTALL_PROGRAM) rlogin $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) $(DESTDIR)$(bindir)/`echo rlogin|sed '$(transform)'` ; \
-	if test $$? -ne 0; then \
-	  echo "WARNING: insufficient access; not installing rlogin"; \
-	  echo "NOTE: To install rlogin run 'make install' as root"; \
+	-@$(INSTALL_PROGRAM) $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) rlogin $(DESTDIR)$(bindir)/`echo rlogin|sed '$(transform)'` ; OUTCOME=$$?; \
+	if test $$OUTCOME -ne 0; then \
+	  echo "WARNING: Failed to install rlogin (exit code $$OUTCOME)"; \
+	  echo "NOTE: This program often needs to be owned by root."; \
 	fi
 
 install-rcp-hook:
-	-@$(INSTALL_PROGRAM) rcp $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) $(DESTDIR)$(bindir)/`echo rcp|sed '$(transform)'` ; \
-	if test $$? -ne 0; then \
-	  echo "WARNING: insufficient access; not installing rcp"; \
-	  echo "NOTE: To install rcp run 'make install' as root"; \
+	-@$(INSTALL_PROGRAM) $(SUIDMODE) $(AM_INSTALL_PROGRAM_FLAGS) rcp $(DESTDIR)$(bindir)/`echo rcp|sed '$(transform)'` ; OUTCOME=$$?; \
+	if test $$OUTCOME -ne 0; then \
+	  echo "WARNING: Failed to install rcp (exit code $$OUTCOME)"; \
+	  echo "NOTE: This program often needs to be owned by root."; \
 	fi

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog           | 21 +++++++++++++++++++++
 ping/Makefile.am    |  8 ++++----
 src/Makefile.am     | 32 ++++++++++++++++----------------
 whois/tld_serv_list |  2 +-
 4 files changed, 42 insertions(+), 21 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Tue Feb 04 08:41:09 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1iyyRx-0000eo-O7
	for mharc-commit-inetutils@gnu.org; Tue, 04 Feb 2020 08:41:09 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:39740)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <gnu@gisladisker.se>) id 1iyyRu-0000eh-7d
 for commit-inetutils@gnu.org; Tue, 04 Feb 2020 08:41:07 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:41780)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <gnu@gisladisker.se>) id 1iyyRt-0005N4-R0
 for commit-inetutils@gnu.org; Tue, 04 Feb 2020 08:41:05 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 117592)
 id AF0A220B80; Tue,  4 Feb 2020 08:41:05 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-74-gda919de
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 60d0f2ec4eb0f14765d40a58ab0e556ef6de58cb
X-Git-Newrev: da919de3f4d778c250550f68fdf03b4540e8aa28
Message-Id: <20200204134105.AF0A220B80@vcs0.savannah.gnu.org>
Date: Tue,  4 Feb 2020 08:41:05 -0500 (EST)
From: gnu@gisladisker.se (Mats Erik Andersson)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2020 13:41:07 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  da919de3f4d778c250550f68fdf03b4540e8aa28 (commit)
      from  60d0f2ec4eb0f14765d40a58ab0e556ef6de58cb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=da919de3f4d778c250550f68fdf03b4540e8aa28


commit da919de3f4d778c250550f68fdf03b4540e8aa28
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Tue Feb 4 11:47:34 2020 +0100

    Buffer overflow in tftp and tftpd.
    
    Recent Gnu libc and Gcc inject checks for buffer size into strcpy().
    These interfere with declarations in <arpa/tftp.h>.  Issue was reported
    independently by Mike Gilbert and Ricardo Ribalda Delgado.

diff --git a/ChangeLog b/ChangeLog
index 3b625d8..9640887 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,20 @@
+2020-02-04  Mats Erik Andersson  <gnu@gisladisker.se>
+
+	Buffer overflow in tftp and tftpd.
+	Recent versions of Gnu libc and Gcc are injecting buffer checks
+	into strcpy().  Both executables, tftp and tftpd, are effectively
+	copying into a formally declared `char th_msg[1]', ignorant of
+	the underlying buffer being of size PKTSIZE.
+	Problem was reported by Mike Gilbert and Ricardo Ribalda Delgado:
+	https://lists.gnu.org/archive/html/bug-inetutils/2017-12/msg00001.html
+	https://lists.gnu.org/archive/html/bug-inetutils/2019-07/msg00002.html
+
+	* src/tftp.c (nak): Replace strcpy() by memcpy(), after the
+	needed calculation of string length.
+	* src/tftpd.c (nak): Likewise.
+
+	* tests/tftp.sh: New compound test with multiple requests.
+
 2020-02-03  Mats Erik Andersson  <gnu@gisladisker.se>
 
 	whois: AUDA services Australia.
diff --git a/src/tftp.c b/src/tftp.c
index d9a0f9e..e44dd58 100644
--- a/src/tftp.c
+++ b/src/tftp.c
@@ -1294,8 +1294,8 @@ nak (int error)
       pe->e_msg = strerror (error - 100);
       tp->th_code = EUNDEF;
     }
-  strcpy (tp->th_msg, pe->e_msg);
   length = strlen (pe->e_msg) + 4;
+  memcpy (tp->th_msg, pe->e_msg, length - 3);
   if (trace)
     tpacket ("sent", tp, length);
   if (sendto (f, ackbuf, length, 0, (struct sockaddr *) &peeraddr,
diff --git a/src/tftpd.c b/src/tftpd.c
index ba51f24..0e485d4 100644
--- a/src/tftpd.c
+++ b/src/tftpd.c
@@ -862,8 +862,8 @@ nak (int error)
       pe->e_msg = strerror (error - 100);
       tp->th_code = EUNDEF;	/* set 'undef' errorcode */
     }
-  strcpy (tp->th_msg, pe->e_msg);
   length = strlen (pe->e_msg);
+  memcpy (tp->th_msg, pe->e_msg, length);
   tp->th_msg[length] = '\0';
   length += 5;
   if (sendto (peer, buf, length, 0, (struct sockaddr *) &from, fromlen) != length)
diff --git a/tests/tftp.sh b/tests/tftp.sh
index 47c123d..d4d58b9 100755
--- a/tests/tftp.sh
+++ b/tests/tftp.sh
@@ -386,7 +386,42 @@ get $name" | \
 	    SUCCESSES=`expr $SUCCESSES + 1`
 	    test -z "$VERBOSE" || echo "Successful comparison for $addr/$name." >&2
 	fi
-   done
+    done
+
+    # Do a compound test with multiple requests.
+    # Issue one request for locally renamed file.
+    rm -f file-small _file-small_ missing-file
+    EFFORTS=`expr $EFFORTS + 1`
+
+    cat <<-EOT |
+	binary
+	get file-small
+	get missing-file
+	get file-small _file-small_
+	quit
+	EOT
+    eval $TFTP ${VERBOSE:+-v} "$addr" $PORT $bucket
+
+    if cmp "$TMPDIR/tftp-test/file-small" file-small 2>/dev/null \
+	&& test ! -s missing-file \
+	&& cmp "$TMPDIR/tftp-test/file-small" _file-small_ 2>/dev/null
+    then
+	SUCCESSES=`expr $SUCCESSES + 1`
+	test -z "$VERBOSE" || echo "Successful compound test." >&2
+    else
+	echo "Failure during compound test." >&2
+
+	# Investigate probable causes.
+	test -s _file-small_ ||
+	    echo "Third get request failed after file known to be missing." >&2
+	{ test ! -f missing-file || test -s missing-file ; } &&
+	    echo "The missing file did not appear as empty." >&1
+	test -s file-small ||
+	    echo "Not even the first request succeeded." >&2
+	RESULT=1
+    fi
+
+    rm -f file-small _file-small_ missing-file
 done
 
 # Test the ability of inetd to reload configuration:

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog     | 17 +++++++++++++++++
 src/tftp.c    |  2 +-
 src/tftpd.c   |  2 +-
 tests/tftp.sh | 37 ++++++++++++++++++++++++++++++++++++-
 4 files changed, 55 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Wed Feb 05 11:03:38 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1izN9O-0006XI-Dx
	for mharc-commit-inetutils@gnu.org; Wed, 05 Feb 2020 11:03:38 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:46728)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ivandarioarroyo@gmail.com>) id 1izN9I-0006MJ-Ni
 for commit-inetutils@gnu.org; Wed, 05 Feb 2020 11:03:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ivandarioarroyo@gmail.com>) id 1izN9H-0001aw-IS
 for commit-inetutils@gnu.org; Wed, 05 Feb 2020 11:03:32 -0500
Received: from mail-vs1-xe2b.google.com ([2607:f8b0:4864:20::e2b]:33172)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <ivandarioarroyo@gmail.com>)
 id 1izN9H-0001Y1-Ew
 for commit-inetutils@gnu.org; Wed, 05 Feb 2020 11:03:31 -0500
Received: by mail-vs1-xe2b.google.com with SMTP id n27so1675511vsa.0
 for <commit-inetutils@gnu.org>; Wed, 05 Feb 2020 08:03:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:message-id:subject:mime-version
 :content-transfer-encoding;
 bh=Sx+OL+SmuIzk7vHGMnN1acWaYSCO2+G/Jd3vN8sdqUU=;
 b=Ez2E2cqXZ+HDNFwAU/5IchWZqk2DWxiuTc7WHtZz9/9rYExBggZn89alvrF8ESloOo
 zdkyVwS02Grr68WjL69aH4L4wgAqP9ZWqCJEjhbitrKMIesep7RVcNC5Jn90P6sPmHHf
 TGdalRHeeZHooW4V+Lv2ekkmEVErbFaXa+9EEo3TouCllTV09RfBjJJmzwI7ATdVkXeX
 mf9uLm0dWaq6rFSvgy5Hj2ykAcm92HSPVu/O09KDXtBQiOkY6vP/EeaBj1/3G9SwHNNM
 nUYJ2/KbdoHr6sPnD1h6lFOcUOrZCYAEQtJWSSHGEqeXSA9uWl1OTYjiamp80Fw92JhI
 lMPA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:message-id:subject:mime-version
 :content-transfer-encoding;
 bh=Sx+OL+SmuIzk7vHGMnN1acWaYSCO2+G/Jd3vN8sdqUU=;
 b=FPQ9F2wRfRNJzz64VR1foUyWPjGP3b5mweYvtIuhSy7qPivoAmukyWHTK3kWeCO06b
 HQLJKCV30V4ClMIZBhVvxzqnfeBQpEllB4oKhHHKFWAtwpknG6sJcqSAnOs6GQgmynX4
 eXV0pFz2RwI/6XeGYokLJuOlNfEry/AQMVmrv7hn+GP6edx8DV9RW0ZFpKFY8j2RpexZ
 s3KUZbTe6WSaeq8bik7FwbrkizYS0cjauK9jE7cx/fSIBoAQAKsiacLWOK9VFy8dSOkQ
 B70ReHFACtVkX674MvB81e3ans3rZivRXZe57bWx7fIGSei/i8q1icug/03mB43y+zFM
 le/w==
X-Gm-Message-State: APjAAAVTetanjkCveBBhiF1jk+QbHBtwyx9z9wt1cHeqR+KBtj2P3PEN
 22Z5Scmvks7i6FUd/4QjEfqR6ak5Jdc=
X-Google-Smtp-Source: APXvYqzwAoiAiTVmpkwyLeK5A6ixxrSKTIpOpTxw7rFDYL9kddSdg8BLltVSO+4DTvTBBLjJMN8Nvw==
X-Received: by 2002:a67:d007:: with SMTP id r7mr20723284vsi.93.1580918609587; 
 Wed, 05 Feb 2020 08:03:29 -0800 (PST)
Received: from PAS-OTI-IAWS.uaegrtd.local ([190.121.158.158])
 by smtp.gmail.com with ESMTPSA id z15sm66179vsz.27.2020.02.05.08.03.28
 for <commit-inetutils@gnu.org>
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 05 Feb 2020 08:03:29 -0800 (PST)
Date: Wed, 5 Feb 2020 11:01:10 -0500 (COT)
From: ivandarioarroyo@gmail.com
To: commit-inetutils@gnu.org
Message-ID: <553871028.9.1580918470352@PAS-OTI-IAWS.uaegrtd.local>
Subject: Important request, participation in software development study
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
 recognized.
X-Received-From: 2607:f8b0:4864:20::e2b
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Feb 2020 16:03:37 -0000

Dear Engineers,

When I write this message, I think I am writing to the best software developers in the world, or to those who are in the process of being one. I write to ask you a favor. I am a UMA PhD student and I study the use of formal and non-formal models in the software industry.

According to 9 investigations, UML is not being used as it should, but the developers use their own models, designed by them or by their companies. However, these investigations have not included professionals like you, so I want to ask you to help me by answering this survey:

If you have a Google account:
https://docs.google.com/forms/d/e/1FAIpQLSdG4bhNWfU3vzSKwG-0j8NuGW47_xmSY1ftF33gaNAZsU25kA/viewform

Reply without logging in:
https://docs.google.com/forms/d/e/1FAIpQLSeNm99cxIyT65-5qR6ZCZoDNeFONTf_ODWbXaSxUskkxbWu4g/viewform

I also ask you to send this survey to other developers that you know and respect.

Please help me, I promise that your contributions will be recognized in the publications that are possible, therefore, as an optional field I have included the name and email. My biggest goal is to unify all non-formal models to create a modeling language that is the heritage of the industry, built by all of us. If you want to know more, you can write to me at ivan.arroyo@uma.es, ivandarioarroyo@gmail.com or arcouml@gmail.com
!!THANKS


From MAILER-DAEMON Sat Feb 08 20:21:28 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j0bHs-0003SM-5I
	for mharc-commit-inetutils@gnu.org; Sat, 08 Feb 2020 20:21:28 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:50384)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <gnu@gisladisker.se>) id 1j0bHo-0003S8-7e
 for commit-inetutils@gnu.org; Sat, 08 Feb 2020 20:21:25 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:35152)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <gnu@gisladisker.se>) id 1j0bHn-00051M-Qf
 for commit-inetutils@gnu.org; Sat, 08 Feb 2020 20:21:23 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 117592)
 id A8CC621049; Sat,  8 Feb 2020 20:21:23 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-75-ga1d8a1f
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: da919de3f4d778c250550f68fdf03b4540e8aa28
X-Git-Newrev: a1d8a1f87d62e5d00c29008f41d350dc2deceaaf
Message-Id: <20200209012123.A8CC621049@vcs0.savannah.gnu.org>
Date: Sat,  8 Feb 2020 20:21:23 -0500 (EST)
From: gnu@gisladisker.se (Mats Erik Andersson)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Feb 2020 01:21:26 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  a1d8a1f87d62e5d00c29008f41d350dc2deceaaf (commit)
      from  da919de3f4d778c250550f68fdf03b4540e8aa28 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=a1d8a1f87d62e5d00c29008f41d350dc2deceaaf


commit a1d8a1f87d62e5d00c29008f41d350dc2deceaaf
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Sun Feb 9 02:17:01 2020 +0100

    test-snprintf: New test program.
    
    We want to make testers aware that snprintf() is not behaving identically
    on all platforms.  In fact, glibc offers the least robust implementation.
    An observation leading to this test was reported by Zhixiong Chi.

diff --git a/ChangeLog b/ChangeLog
index 9640887..014a250 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2020-02-09  Mats Erik Andersson  <gnu@gisladisker.se>
+
+	test-snprintf: New test program.
+
+	An implementation dependent feature of snprintf() is tested.
+	The BSD unices and OpenSolaris relatives are known to be more
+	forgiving, than is Linux/glibc and kfreebsd/glibc.  The issue
+	was brought to our attention by Zhixiong Chi in:
+	https://lists.gnu.org/archive/html/bug-inetutils/2019-05/msg00002.html
+
+	* tests/test-snprintf.c: New file.
+	* tests/Makefile.am (check_PROGRAMS, TESTS): Add `test-snprintf'.
+	* tests/.gitignore: Likewise.
+
 2020-02-04  Mats Erik Andersson  <gnu@gisladisker.se>
 
 	Buffer overflow in tftp and tftpd.
diff --git a/tests/.gitignore b/tests/.gitignore
index fca2178..cb5d798 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -5,6 +5,7 @@ ls
 readutmp
 runtime-ipv6
 tcpget
+test-snprintf
 tools.sh
 waitdaemon
 *.log
diff --git a/tests/Makefile.am b/tests/Makefile.am
index ab2d2dc..34e68a1 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -23,7 +23,7 @@ LDADD = $(iu_LIBRARIES)
 noinst_PROGRAMS = identify
 identify_LDADD = $(top_builddir)/lib/libgnu.a $(LIBUTIL)
 
-check_PROGRAMS = localhost readutmp runtime-ipv6 waitdaemon
+check_PROGRAMS = localhost readutmp runtime-ipv6 test-snprintf waitdaemon
 
 dist_check_SCRIPTS = utmp.sh
 
@@ -86,7 +86,7 @@ if ENABLE_ifconfig
 dist_check_SCRIPTS += ifconfig.sh
 endif
 
-TESTS = localhost waitdaemon $(dist_check_SCRIPTS)
+TESTS = localhost test-snprintf waitdaemon $(dist_check_SCRIPTS)
 
 TESTS_ENVIRONMENT = EXEEXT=$(EXEEXT)
 
diff --git a/tests/test-snprintf.c b/tests/test-snprintf.c
new file mode 100644
index 0000000..317683f
--- /dev/null
+++ b/tests/test-snprintf.c
@@ -0,0 +1,78 @@
+/* test-snprintf - Check whether snprintf allows doubly used strings.
+  Copyright (C) 2020 Free Software Foundation, Inc.
+
+  This file is part of GNU Inetutils.
+
+  GNU Inetutils is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or (at
+  your option) any later version.
+
+  GNU Inetutils is distributed in the hope that it will be useful, but
+  WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+  General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program.  If not, see `http://www.gnu.org/licenses/'. */
+
+/* Written by Mats Erik Andersson.  */
+
+/*
+ * It is not in violation of POSIX, but implementations of snprintf()
+ * differ in their ability to handle a situation where the target string
+ * to be produced by snprintf() is at the same time providing data, which
+ * are to be passed through the format string, and to be part of the new
+ * resulting string.  The different BSD unices, as well as OpenSolaris,
+ * are known to correctly handle this, whereas glibc is known to fail.
+ *
+ * This test issues a warning that non-portable behaviour is possible,
+ * should the program detect a discrepancy on this system.  If the
+ * program detects the macro PACKAGE to have value "inetutils", then
+ * get attention with the exit value 77, to fit with our testing
+ * frame work.
+ *
+ * When the environment variable VERBOSE is defined, an encouraging
+ * message is issued also in the presence of an enhanced implementation
+ * of snprintf().
+ */
+
+#ifdef HAVE_CONFIG_H
+# include <config.h>
+#endif
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#define MESSAGE		"try a fool"
+#define WRONG_MESSAGE	"fool"
+
+int
+main (void)
+{
+  int err = 0;
+  char msg[sizeof (MESSAGE)] = "try a ";
+
+  snprintf (msg, sizeof (msg), "%s%s", msg, WRONG_MESSAGE);
+
+  if (!strcmp (msg, WRONG_MESSAGE))
+    {
+      printf ("Warning! This implementation of snprintf() is not able\n"
+	      "to handle string variables that appear as target and at the\n"
+	      "same time as source. This might be a portability issue!\n");
+#ifdef PACKAGE
+      if (!strcmp (PACKAGE, "inetutils"))
+	err = 77;
+#endif
+    }
+  else if (getenv ("VERBOSE"))
+    {
+      printf ("The present implementation of snprintf() allows the same\n"
+	      "string to act as target as well as source.  Good news!\n");
+    }
+
+  /* Always return successfully, as we are only producing a reminder,
+     rather than a show stopper.  */
+  return err;
+}

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog             | 14 +++++++++
 tests/.gitignore      |  1 +
 tests/Makefile.am     |  4 +--
 tests/test-snprintf.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 95 insertions(+), 2 deletions(-)
 create mode 100644 tests/test-snprintf.c


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Mon Feb 10 09:51:44 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j1APY-0000Rq-Hh
	for mharc-commit-inetutils@gnu.org; Mon, 10 Feb 2020 09:51:44 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:60557)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <gnu@gisladisker.se>) id 1j1APV-0000RY-I9
 for commit-inetutils@gnu.org; Mon, 10 Feb 2020 09:51:42 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:55243)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <gnu@gisladisker.se>) id 1j1APV-0002DJ-8y
 for commit-inetutils@gnu.org; Mon, 10 Feb 2020 09:51:41 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 117592)
 id 2D94220A1C; Mon, 10 Feb 2020 09:51:41 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-76-g34fd840
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: a1d8a1f87d62e5d00c29008f41d350dc2deceaaf
X-Git-Newrev: 34fd840302a885da9ef29c83c9800be651ff075e
Message-Id: <20200210145141.2D94220A1C@vcs0.savannah.gnu.org>
Date: Mon, 10 Feb 2020 09:51:40 -0500 (EST)
From: gnu@gisladisker.se (Mats Erik Andersson)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Feb 2020 14:51:43 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  34fd840302a885da9ef29c83c9800be651ff075e (commit)
      from  a1d8a1f87d62e5d00c29008f41d350dc2deceaaf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=34fd840302a885da9ef29c83c9800be651ff075e


commit 34fd840302a885da9ef29c83c9800be651ff075e
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Mon Feb 10 15:48:28 2020 +0100

    Code simplification for program runtime-ipv6.

diff --git a/ChangeLog b/ChangeLog
index 014a250..98e30ed 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2020-02-10  Mats Erik Andersson  <gnu@gisladisker.se>
+
+	Simplify coding of test program `runtime-ipv6', by using
+	standard getopt() library function, thus making the code
+	self sufficient.
+
+	* tests/runtime-ipv6.c: Migrate away from argp_parse() to
+	standard getopt().  Let environment variable VERBOSE contribute
+	a short message in case the program tests successfully.
+	Also use AI_NUMERICSERV for completeness.
+
 2020-02-09  Mats Erik Andersson  <gnu@gisladisker.se>
 
 	test-snprintf: New test program.
diff --git a/tests/runtime-ipv6.c b/tests/runtime-ipv6.c
index 2f4e128..7f0cbc5 100644
--- a/tests/runtime-ipv6.c
+++ b/tests/runtime-ipv6.c
@@ -28,9 +28,14 @@
  *
  * Return value is 0 (zero) when successful, otherwise -1.
  * On failure a message is printed to stderr: `IPv# disabled in system'.
+ *
+ * By defining the shell environment variable VERBOSE, a short affirmative
+ * message is printed also in case of successful testing.
  */
 
-#include <config.h>
+#ifdef HAVE_CONFIG_H
+# include <config.h>
+#endif
 
 #include <stdio.h>
 #include <unistd.h>
@@ -42,11 +47,6 @@
 #include <sys/socket.h>
 #include <netdb.h>
 
-#include <argp.h>
-#include <progname.h>
-#include <unused-parameter.h>
-#include "libinetutils.h"
-
 #define RESOLVE_OK            0
 #define RESOLVE_FAIL         -1
 
@@ -55,60 +55,40 @@ int tested_family = AF_INET6;
 char *tested_family_name = "IPv6";
 char *tested_localhost = "::1";
 
-const char doc[] = "Detect presence of address family";
-
-const char *program_authors[] = { "Mats Erik Andersson", NULL };
-
-static struct argp_option argp_options[] = {
-#define GRP 1
-  {"ipv4", '4', NULL, 0, "test for IPv4", GRP },
-  {"ipv6", '6', NULL, 0, "test for IPv6 (default)", GRP },
-#undef GRP
-  {NULL, 0, NULL, 0, NULL, 0}
-};
-
-static error_t
-parse_opt (int key, char *arg, struct argp_state *state _GL_UNUSED_PARAMETER)
-{
-  switch (key)
-    {
-    case '4':
-      tested_family = AF_INET;
-      tested_family_name = "IPv4";
-      tested_localhost = "127.0.0.1";
-      break;
-
-    case '6':
-      tested_family = AF_INET6;
-      tested_family_name = "IPv6";
-      tested_localhost = "::1";
-      break;
-
-    default:
-      return ARGP_ERR_UNKNOWN;
-    }
-
-  return 0;
-}
-
-static struct argp argp =
-  {argp_options, parse_opt, NULL, doc, NULL, NULL, NULL};
-
 int
 main (int argc, char *argv[])
 {
-  int err;
-  struct sockaddr_storage ss;
+  int err, ch;
   struct addrinfo hints, *aiptr;
 
-  set_program_name (argv[0]);
-  iu_argp_init ("runtime-ipv6", program_authors);
-  argp_parse (&argp, argc, argv, 0, NULL, NULL);
+  while ((ch = getopt (argc, argv, "46")) != -1)
+    {
+      switch (ch)
+	{
+	case '4':
+	  tested_family = AF_INET;
+	  tested_family_name = "IPv4";
+	  tested_localhost = "127.0.0.1";
+	  break;
+
+	case '6':
+	  tested_family = AF_INET6;
+	  tested_family_name = "IPv6";
+	  tested_localhost = "::1";
+	  break;
+
+	default:
+	  fprintf (stderr, "Usage: %s [-4 | -6]\n"
+		   "Determines presence of selected INET address family.\n",
+		   argv[0]);
+	  return EXIT_FAILURE;
+	}
+    }
 
   memset (&hints, 0, sizeof (hints));
   hints.ai_family = tested_family;
   hints.ai_socktype = SOCK_DGRAM;
-  hints.ai_flags = AI_NUMERICHOST;
+  hints.ai_flags = AI_NUMERICHOST | AI_NUMERICSERV;
 #ifdef AI_ADDRCONFIG
   hints.ai_flags |= AI_ADDRCONFIG;
 #endif
@@ -135,6 +115,9 @@ main (int argc, char *argv[])
 
       return RESOLVE_FAIL;
     }
+  else if (getenv ("VERBOSE"))
+    printf ("Detection of %s address %s was successful.\n",
+	    tested_family_name, tested_localhost);
 
   return RESOLVE_OK;
 }

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog            | 11 +++++++
 tests/runtime-ipv6.c | 85 +++++++++++++++++++++-------------------------------
 2 files changed, 45 insertions(+), 51 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Thu Feb 20 11:05:07 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j4oK3-00068T-5g
	for mharc-commit-inetutils@gnu.org; Thu, 20 Feb 2020 11:05:07 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:54001)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <gnu@gisladisker.se>) id 1j4oJz-00061J-0Y
 for commit-inetutils@gnu.org; Thu, 20 Feb 2020 11:05:04 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:54197)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <gnu@gisladisker.se>) id 1j4oJy-000324-JB
 for commit-inetutils@gnu.org; Thu, 20 Feb 2020 11:05:02 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 117592)
 id 7D49F20A22; Thu, 20 Feb 2020 11:05:02 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-78-gc1f1854
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 34fd840302a885da9ef29c83c9800be651ff075e
X-Git-Newrev: c1f18548f754bf09865fa17af119e5f90d931094
Message-Id: <20200220160502.7D49F20A22@vcs0.savannah.gnu.org>
Date: Thu, 20 Feb 2020 11:05:01 -0500 (EST)
From: gnu@gisladisker.se (Mats Erik Andersson)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Feb 2020 16:05:04 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  c1f18548f754bf09865fa17af119e5f90d931094 (commit)
       via  470d0b804843bba7068a8677499aadab905ca7f4 (commit)
      from  34fd840302a885da9ef29c83c9800be651ff075e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=c1f18548f754bf09865fa17af119e5f90d931094


commit c1f18548f754bf09865fa17af119e5f90d931094
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Thu Feb 20 16:41:12 2020 +0100

    rexecd, rshd: Avoid false failure message.

diff --git a/ChangeLog b/ChangeLog
index 02ea169..7358295 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2020-02-20  Mats Erik Andersson  <gnu@gisladisker.se>
 
+	rexecd, rshd: Avoid false failure message.
+
+	* src/rexecd.c (doit) [HAVE_SETLOGIN]: Only call setsid() in case
+	the session leader is different from the present process.
+	* src/rshd.c (doit) [HAVE_SETLOGIN]: Likewise.
+
+2020-02-20  Mats Erik Andersson  <gnu@gisladisker.se>
+
 	rcp: Recursive reception was broken.
 
 	The commit 67b49c54 broke the use case of locally receiving
diff --git a/src/rexecd.c b/src/rexecd.c
index ad23703..714b7eb 100644
--- a/src/rexecd.c
+++ b/src/rexecd.c
@@ -556,8 +556,9 @@ doit (int f, struct sockaddr *fromp, socklen_t fromlen)
 
 #ifdef HAVE_SETLOGIN
       /* Not sufficient to call setpgid() on BSD systems.  */
-      if (setsid () < 0)
-	syslog (LOG_ERR, "setsid() failed: %m");
+      if (getsid ((pid_t) 0) != getpid ())
+	if (setsid () < 0)
+	  syslog (LOG_ERR, "setsid() failed: %m");
 #elif defined HAVE_SETPGID /* !HAVE_SETLOGIN */
       setpgid (0, getpid ());
 #endif
diff --git a/src/rshd.c b/src/rshd.c
index 11322d3..b67d888 100644
--- a/src/rshd.c
+++ b/src/rshd.c
@@ -1833,8 +1833,9 @@ doit (int sockfd, struct sockaddr *fromp, socklen_t fromlen)
    */
 #ifdef HAVE_SETLOGIN
   /* Not sufficient to call setpgid() on BSD systems.  */
-  if (setsid () < 0)
-    syslog (LOG_ERR, "setsid() failed: %m");
+  if (getsid ((pid_t) 0) != getpid ())
+    if (setsid () < 0)
+      syslog (LOG_ERR, "setsid() failed: %m");
 
   if (setlogin (pwd->pw_name) < 0)
     syslog (LOG_ERR, "setlogin() failed: %m");

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=470d0b804843bba7068a8677499aadab905ca7f4


commit 470d0b804843bba7068a8677499aadab905ca7f4
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Thu Feb 20 16:11:04 2020 +0100

    rcp: Recursive reception was broken.
    
    Revert code to a previous and functional stage.  The source was broken
    in a well defined commit.  Reported by Zhixiong Chi.

diff --git a/ChangeLog b/ChangeLog
index 98e30ed..02ea169 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,18 @@
+2020-02-20  Mats Erik Andersson  <gnu@gisladisker.se>
+
+	rcp: Recursive reception was broken.
+
+	The commit 67b49c54 broke the use case of locally receiving
+	multiple files for a recursive copying action.  This was found
+	and established by Zhixiong Chi.  Now revert the relevant part
+	of the old commit, as the suggested patch is nearly a verbatim
+	change back.  The differences await further analysis.
+	Original report is contained in:
+	https://lists.gnu.org/archive/html/bug-inetutils/2019-12/msg00000.html
+
+	* src/rcp.c (sink) [targisdir]: Revert to the legacy, and functional,
+	implementation of string allocation.
+
 2020-02-10  Mats Erik Andersson  <gnu@gisladisker.se>
 
 	Simplify coding of test program `runtime-ipv6', by using
diff --git a/src/rcp.c b/src/rcp.c
index 415e3f0..503027e 100644
--- a/src/rcp.c
+++ b/src/rcp.c
@@ -993,18 +993,10 @@ sink (int argc, char *argv[])
 	  need = strlen (targ) + strlen (cp) + 250;
 	  if (need > cursize)
 	    {
-	      free (namebuf);
-	      namebuf = malloc (need);
-	      if (namebuf)
-		cursize = need;
-	      else
-		{
-		  run_err ("%s", strerror (errno));
-		  cursize = 0;
-		  continue;
-		}
+	      if (!(namebuf = malloc (need)))
+		run_err ("%s", strerror (errno));
 	    }
-	  snprintf (namebuf, cursize, "%s%s%s", targ, *targ ? "/" : "", cp);
+	  snprintf (namebuf, need, "%s%s%s", targ, *targ ? "/" : "", cp);
 	  np = namebuf;
 	}
       else

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog    | 23 +++++++++++++++++++++++
 src/rcp.c    | 14 +++-----------
 src/rexecd.c |  5 +++--
 src/rshd.c   |  5 +++--
 4 files changed, 32 insertions(+), 15 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Fri Feb 21 11:50:47 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j5BVn-0004Ep-4Z
	for mharc-commit-inetutils@gnu.org; Fri, 21 Feb 2020 11:50:47 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:59366)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <gnu@gisladisker.se>) id 1j5BVj-00047s-VE
 for commit-inetutils@gnu.org; Fri, 21 Feb 2020 11:50:45 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:34311)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <gnu@gisladisker.se>) id 1j5BVj-0005Gd-J3
 for commit-inetutils@gnu.org; Fri, 21 Feb 2020 11:50:43 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 117592)
 id 742122111A; Fri, 21 Feb 2020 11:50:43 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-79-ga9d1edf
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: c1f18548f754bf09865fa17af119e5f90d931094
X-Git-Newrev: a9d1edfd4701b590a9519498ef5514492520be76
Message-Id: <20200221165043.742122111A@vcs0.savannah.gnu.org>
Date: Fri, 21 Feb 2020 11:50:43 -0500 (EST)
From: gnu@gisladisker.se (Mats Erik Andersson)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2020 16:50:46 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  a9d1edfd4701b590a9519498ef5514492520be76 (commit)
      from  c1f18548f754bf09865fa17af119e5f90d931094 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=a9d1edfd4701b590a9519498ef5514492520be76


commit a9d1edfd4701b590a9519498ef5514492520be76
Author: Mats Erik Andersson <gnu@gisladisker.se>
Date:   Fri Feb 21 17:47:49 2020 +0100

    Various compiler warnings.

diff --git a/ChangeLog b/ChangeLog
index 7358295..287f5ce 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,22 @@
+2020-02-21  Mats Erik Andersson  <gnu@gisladisker.se>
+
+	Various compiler warnings, getting closer to `-Werror'.
+
+	* libls/print.c (printlong): The functions major() and minor() have
+	no portable value type, so cast as `int'.
+
+	* ping/ping.c (decode_type): Initialize HOSTNAME to NULL.
+
+	* src/hostname.c (parse_opt, main) <SET_NAME_ACTION>: The prototype
+	of sethostname() is not portable, so cast as `void *'.  Do this
+	also on both members in a conditional clause.
+	* src/logger.c (parse_level): Cast PRIORITYNAMES and FACILITYNAMES
+	as `CODE *', since BSD-systems assign these a constant type.
+	* src/syslogd.c (textpri, cfline): Likewise.
+	* src/rcp.c (source, rsource): Type length of `stat.st_mode' is not
+	portable, so cast as `int'.
+	* src/traceroute.c (trace_write): Make loop variable I unsigned.
+
 2020-02-20  Mats Erik Andersson  <gnu@gisladisker.se>
 
 	rexecd, rshd: Avoid false failure message.
diff --git a/libls/print.c b/libls/print.c
index d277051..aad5704 100644
--- a/libls/print.c
+++ b/libls/print.c
@@ -137,7 +137,7 @@ printlong (DISPLAY *dp)
       if (f_flags)
 	printf ("%-*s ", dp->s_flags, np->flags);
       if (S_ISCHR (sp->st_mode) || S_ISBLK (sp->st_mode))
-	printf ("%3d, %3d ", major (sp->st_rdev), minor (sp->st_rdev));
+	printf ("%3d, %3d ", (int) major (sp->st_rdev), (int) minor (sp->st_rdev));
       else if (dp->bcfile)
 	printf ("%*s%*llu ",
 		8 - dp->s_size, "", dp->s_size, (long long) sp->st_size);
diff --git a/ping/ping.c b/ping/ping.c
index f98f87e..c8b67a1 100644
--- a/ping/ping.c
+++ b/ping/ping.c
@@ -333,7 +333,7 @@ main (int argc, char **argv)
 
 int (*decode_type (const char *arg)) (char *hostname)
 {
-  int (*ping_type) (char *hostname);
+  int (*ping_type) (char *hostname) = NULL;
 
   if (strcasecmp (arg, "echo") == 0)
     ping_type = ping_echo;
diff --git a/src/hostname.c b/src/hostname.c
index e0c24db..bf432fd 100644
--- a/src/hostname.c
+++ b/src/hostname.c
@@ -90,7 +90,7 @@ parse_opt (int key, char *arg, struct argp_state *state)
       break;
 
     case 'F':
-      set_name_action = sethostname;
+      set_name_action = (void *) sethostname;
       args->hostname_file = arg;
       break;
 
@@ -115,7 +115,7 @@ parse_opt (int key, char *arg, struct argp_state *state)
       break;
 
     case ARGP_KEY_ARG:
-      set_name_action = sethostname;
+      set_name_action = (void *) sethostname;
       args->hostname_new = strdup (arg);
       if (args->hostname_new == NULL)
         error (EXIT_FAILURE, errno, "strdup");
@@ -159,7 +159,7 @@ main (int argc, char *argv[])
 
   if (get_name_action == xgetdomainname || get_name_action == xgethostname)
     get_name (&args);
-  else if (set_name_action == sethostname)
+  else if ((void *) set_name_action == (void *) sethostname)
     set_name (&args);
 
   return 0;
diff --git a/src/logger.c b/src/logger.c
index cce6b3a..dcc4f8d 100644
--- a/src/logger.c
+++ b/src/logger.c
@@ -114,9 +114,9 @@ parse_level (char *str)
   if (p)
     *p++ = 0;
 
-  fac = decode (str, facilitynames, "facility");
+  fac = decode (str, (CODE *) facilitynames, "facility");
   if (p)
-    prio = decode (p, prioritynames, "priority");
+    prio = decode (p, (CODE *) prioritynames, "priority");
 
   return MAKE_PRI (fac, prio);
 }
diff --git a/src/rcp.c b/src/rcp.c
index 503027e..4cfdeaf 100644
--- a/src/rcp.c
+++ b/src/rcp.c
@@ -744,7 +744,7 @@ source (int argc, char *argv[])
 	}
 #define RCP_MODEMASK	(S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO)
       snprintf (buf, sizeof buf, "C%04o %jd %s\n",
-		stb.st_mode & RCP_MODEMASK, (intmax_t) stb.st_size, last);
+		(int) stb.st_mode & RCP_MODEMASK, (intmax_t) stb.st_size, last);
       write (rem, buf, strlen (buf));
       if (response () < 0)
 	goto next;
@@ -829,7 +829,7 @@ rsource (char *name, struct stat *statp)
       return;
     }
 
-  sprintf (buf, "D%04o %d %s\n", statp->st_mode & RCP_MODEMASK, 0, last);
+  sprintf (buf, "D%04o %d %s\n", (int) statp->st_mode & RCP_MODEMASK, 0, last);
   write (rem, buf, strlen (buf));
   free (buf);
 
diff --git a/src/syslogd.c b/src/syslogd.c
index e7ab9d8..cb27d95 100644
--- a/src/syslogd.c
+++ b/src/syslogd.c
@@ -1155,9 +1155,9 @@ textpri (int pri)
   static char res[20];
   CODE *c_pri, *c_fac;
 
-  for (c_fac = facilitynames; c_fac->c_name
+  for (c_fac = (CODE *) facilitynames; c_fac->c_name
        && !(c_fac->c_val == LOG_FAC (pri) << 3); c_fac++);
-  for (c_pri = prioritynames; c_pri->c_name
+  for (c_pri = (CODE *) prioritynames; c_pri->c_name
        && !(c_pri->c_val == LOG_PRI (pri)); c_pri++);
 
   snprintf (res, sizeof (res), "%s.%s", c_fac->c_name, c_pri->c_name);
@@ -2258,7 +2258,7 @@ cfline (const char *line, struct filed *f)
 	}
       else
 	{
-	  pri = decode (bp, prioritynames);
+	  pri = decode (bp, (CODE *) prioritynames);
 	  if (pri < 0 || (pri > LOG_PRIMASK && pri != INTERNAL_NOPRI))
 	    {
 	      snprintf (ebuf, sizeof (ebuf),
@@ -2304,7 +2304,7 @@ cfline (const char *line, struct filed *f)
 	      }
 	  else
 	    {
-	      i = decode (buf, facilitynames);
+	      i = decode (buf, (CODE *) facilitynames);
 
 	      if (i < 0 || i > (LOG_NFACILITIES << 3))
 		{
diff --git a/src/traceroute.c b/src/traceroute.c
index 7d59f00..8d52bf2 100644
--- a/src/traceroute.c
+++ b/src/traceroute.c
@@ -701,7 +701,7 @@ trace_write (trace_t * t)
     case TRACE_ICMP:
       {
 	icmphdr_t hdr;
-	int i;
+	unsigned int i;
 
 	/* Deposit deterministic values throughout the header!  */
 	for (i = 0; i < sizeof (hdr); ++i)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog        | 19 +++++++++++++++++++
 libls/print.c    |  2 +-
 ping/ping.c      |  2 +-
 src/hostname.c   |  6 +++---
 src/logger.c     |  4 ++--
 src/rcp.c        |  4 ++--
 src/syslogd.c    |  8 ++++----
 src/traceroute.c |  2 +-
 8 files changed, 33 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:40 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8ACy-00016R-Qg
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:40 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:33804)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j869l-0007qN-4h
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:44:06 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36423)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j869k-0003ud-Ra
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:44:04 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id B831921167; Sat, 29 Feb 2020 12:44:04 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-88-g9e0cd09
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: a09e3d7c7d5a5f472e95a49cc990f82006545b6e
X-Git-Newrev: 9e0cd093ffb666302c8f4f2231692f882bf3daf2
Message-Id: <20200229174404.B831921167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 12:44:04 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 17:44:06 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  9e0cd093ffb666302c8f4f2231692f882bf3daf2 (commit)
      from  a09e3d7c7d5a5f472e95a49cc990f82006545b6e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=9e0cd093ffb666302c8f4f2231692f882bf3daf2


commit 9e0cd093ffb666302c8f4f2231692f882bf3daf2
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 18:43:59 2020 +0100

    whois: Silence -Wimplicit-fallthrough

diff --git a/whois/whois.c b/whois/whois.c
index 785209f..e04edc6 100644
--- a/whois/whois.c
+++ b/whois/whois.c
@@ -264,6 +264,7 @@ main (int argc, char *argv[])
 	case 1:
 	  puts (_("This TLD has no whois server, but you can access the "
 		  "whois database at"));
+	  /* FALLTHROUGH */
 	case 2:
 	  puts (server + 1);
 	  exit (EXIT_SUCCESS);

-----------------------------------------------------------------------

Summary of changes:
 whois/whois.c | 1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:41 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8ACy-00016V-W6
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:41 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:35363)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86Qq-0001ea-NJ
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:01:45 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36728)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86Qq-0003MU-GZ
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:01:44 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 712D521167; Sat, 29 Feb 2020 13:01:44 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-91-g0c63e14
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 961fcfa007a8fb1ee66454e0fe23f674e96756f5
X-Git-Newrev: 0c63e144a55e5d81695bc5b881696d9210e9df42
Message-Id: <20200229180144.712D521167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 13:01:44 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 18:01:45 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  0c63e144a55e5d81695bc5b881696d9210e9df42 (commit)
      from  961fcfa007a8fb1ee66454e0fe23f674e96756f5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=0c63e144a55e5d81695bc5b881696d9210e9df42


commit 0c63e144a55e5d81695bc5b881696d9210e9df42
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:01:40 2020 +0100

    ftp: Fix strncpy misuse (leading to buffer overflow)

diff --git a/ftp/ftp.c b/ftp/ftp.c
index 7fe99ab..061eccb 100644
--- a/ftp/ftp.c
+++ b/ftp/ftp.c
@@ -171,9 +171,10 @@ hookup (char *host, int port)
     }
 
   if (res->ai_canonname)
-    strncpy (hostnamebuf, res->ai_canonname, sizeof (hostnamebuf));
+    strncpy (hostnamebuf, res->ai_canonname, sizeof (hostnamebuf) - 1);
   else
-    strncpy (hostnamebuf, rhost, sizeof (hostnamebuf));
+    strncpy (hostnamebuf, rhost, sizeof (hostnamebuf) - 1);
+  hostnamebuf[sizeof (hostnamebuf) - 1] = 0;
 
   hostname = hostnamebuf;
   free (rhost);

-----------------------------------------------------------------------

Summary of changes:
 ftp/ftp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:41 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8ACz-00016n-5N
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:41 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:36356)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86dJ-0002ym-Qk
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:14:38 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36944)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86dJ-000198-Mq
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:14:37 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id A232C21167; Sat, 29 Feb 2020 13:14:37 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-95-ge99cdac
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 1e72ad648966437eab5738144d76189bb04ea38f
X-Git-Newrev: e99cdac15e5a3458a5b94fd6f4732acf835f3cd8
Message-Id: <20200229181437.A232C21167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 13:14:37 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 18:14:38 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  e99cdac15e5a3458a5b94fd6f4732acf835f3cd8 (commit)
      from  1e72ad648966437eab5738144d76189bb04ea38f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=e99cdac15e5a3458a5b94fd6f4732acf835f3cd8


commit e99cdac15e5a3458a5b94fd6f4732acf835f3cd8
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:14:32 2020 +0100

    ftp/domacro.c: Silence -Wimplicit-fallthrough

diff --git a/ftp/domacro.c b/ftp/domacro.c
index 0ffe002..ef0e8d2 100644
--- a/ftp/domacro.c
+++ b/ftp/domacro.c
@@ -215,6 +215,7 @@ domacro (int argc, char *argv[])
 		   * use of '$' was detected.  Present input is the
 		   * dollar sign.
 		   */
+		  /* FALLTHROUGH */
 		default:
 		  *cp2++ = *cp1;	/* Copy present character.  */
 		  break;

-----------------------------------------------------------------------

Summary of changes:
 ftp/domacro.c | 1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:41 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8ACz-000176-BW
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:41 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:38792)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j8742-0001aJ-9W
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:42:15 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:37823)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j8741-000463-WF
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:42:14 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id EE78F21167; Sat, 29 Feb 2020 13:42:13 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-99-g908bfc8
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 22243e6f8e3f2a95709f1a9e9e0a1660dd4cf745
X-Git-Newrev: 908bfc85edc5d5a8484e8e5f130aa879b6994dee
Message-Id: <20200229184213.EE78F21167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 13:42:13 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 18:42:15 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  908bfc85edc5d5a8484e8e5f130aa879b6994dee (commit)
      from  22243e6f8e3f2a95709f1a9e9e0a1660dd4cf745 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=908bfc85edc5d5a8484e8e5f130aa879b6994dee


commit 908bfc85edc5d5a8484e8e5f130aa879b6994dee
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:42:00 2020 +0100

    telnet/commands.c: Use strdup instead malloc+strcpy

diff --git a/telnet/commands.c b/telnet/commands.c
index a0e1566..d935108 100644
--- a/telnet/commands.c
+++ b/telnet/commands.c
@@ -2583,10 +2583,8 @@ tn (int argc, char *argv[])
     }
 
   free (hostname);
-  hostname = malloc (strlen (hostp) + 1);
-  if (hostname)
-    strcpy (hostname, hostp);
-  else
+  hostname = strdup (hostp);
+  if (!hostname)
     {
       printf ("Can't allocate memory to copy hostname\n");
       return 0;

-----------------------------------------------------------------------

Summary of changes:
 telnet/commands.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:41 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8ACz-00017O-Gt
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:41 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:39266)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j8792-00026B-FC
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:47:25 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:37915)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j8792-0007bn-8l
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:47:24 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 2592A21167; Sat, 29 Feb 2020 13:47:24 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-100-g2343dc2
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 908bfc85edc5d5a8484e8e5f130aa879b6994dee
X-Git-Newrev: 2343dc2e3547bb4c724c486bdad9c4ba7468053f
Message-Id: <20200229184724.2592A21167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 13:47:23 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 18:47:25 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  2343dc2e3547bb4c724c486bdad9c4ba7468053f (commit)
      from  908bfc85edc5d5a8484e8e5f130aa879b6994dee (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=2343dc2e3547bb4c724c486bdad9c4ba7468053f


commit 2343dc2e3547bb4c724c486bdad9c4ba7468053f
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:47:19 2020 +0100

    uucpd: Fix 2x heap buffer overflow

diff --git a/src/uucpd.c b/src/uucpd.c
index 407bab1..5674004 100644
--- a/src/uucpd.c
+++ b/src/uucpd.c
@@ -95,8 +95,8 @@ void doit (struct sockaddr *sap, socklen_t salen);
 char *uucico_location = PATH_UUCICO;
 int mypid;
 
-char Username[64];
-char Logname[64];
+char Username[72];
+char Logname[72];
 char *nenv[] = {
   Username,
   Logname,
@@ -249,8 +249,8 @@ doit (struct sockaddr *sap, socklen_t salen)
     }
 
   alarm (0);
-  sprintf (Username, "USER=%s", user);
-  sprintf (Logname, "LOGNAME=%s", user);
+  snprintf (Username, sizeof (Username), "USER=%s", user);
+  snprintf (Logname, sizeof (Logname), "LOGNAME=%s", user);
   dologin (pw, sap, salen);
   setgid (pw->pw_gid);
 #ifdef HAVE_INITGROUPS

-----------------------------------------------------------------------

Summary of changes:
 src/uucpd.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:42 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD0-00018W-Bl
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:33237)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j863b-0007Hx-QW
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:37:45 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36357)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j863b-0000d5-K5
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:37:43 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 7C67C21167; Sat, 29 Feb 2020 12:37:43 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-86-g4747b63
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: a9d1edfd4701b590a9519498ef5514492520be76
X-Git-Newrev: 4747b63d70d4c4102839282ba4437233fb18af08
Message-Id: <20200229173743.7C67C21167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 12:37:42 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 17:37:45 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  4747b63d70d4c4102839282ba4437233fb18af08 (commit)
       via  d2f3c2e365865917fb9b7ff4d1ceafc33a31bca7 (commit)
       via  5d06b6ebea090f9d6b2517d028a5f0b7fe64ff3a (commit)
       via  46def330241ae6b80590e869ce255c615942d73f (commit)
       via  4114b424a8025a447deb65f57a5b15ea5a523c76 (commit)
       via  14291eccccbf0f10b234bcab8ca5eefe7ebbebc7 (commit)
       via  861ee754da65e1e7a2a6168eb90e9c5f0a53a9d5 (commit)
      from  a9d1edfd4701b590a9519498ef5514492520be76 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=4747b63d70d4c4102839282ba4437233fb18af08


commit 4747b63d70d4c4102839282ba4437233fb18af08
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Mon Feb 17 21:40:22 2020 +0100

    ping6: Fix memleak in ping_set_dest

diff --git a/ping/ping6.c b/ping/ping6.c
index 1ae5e44..2d14a4e 100644
--- a/ping/ping6.c
+++ b/ping/ping6.c
@@ -997,7 +997,7 @@ ping_recv (PING * p)
 }
 
 static int
-ping_set_dest (PING * ping, char *host)
+ping_set_dest (PING * ping, const char *host)
 {
   int err;
   struct addrinfo *result, hints;
@@ -1007,8 +1007,9 @@ ping_set_dest (PING * ping, char *host)
   err = idna_to_ascii_lz (host, &rhost, 0);
   if (err)
     return 1;
+  host = rhost;
 #else /* !HAVE_IDN */
-  rhost = host;
+  rhost = NULL;
 #endif
 
   memset (&hints, 0, sizeof (hints));
@@ -1021,19 +1022,22 @@ ping_set_dest (PING * ping, char *host)
   hints.ai_flags |= AI_CANONIDN;
 #endif
 
-  err = getaddrinfo (rhost, NULL, &hints, &result);
+  err = getaddrinfo (host, NULL, &hints, &result);
   if (err)
-    return 1;
+    {
+      free (rhost);
+      return 1;
+    }
 
   memcpy (&ping->ping_dest.ping_sockaddr6, result->ai_addr, result->ai_addrlen);
 
   if (result->ai_canonname)
     ping->ping_hostname = strdup (result->ai_canonname);
   else
-    ping->ping_hostname = strdup (rhost);
-
 #if HAVE_IDN
-  free (rhost);
+    ping->ping_hostname = host;
+#else
+  ping->ping_hostname = strdup (host);
 #endif
   freeaddrinfo (result);
 
diff --git a/ping/ping6.h b/ping/ping6.h
index c0606f8..9eb0c92 100644
--- a/ping/ping6.h
+++ b/ping/ping6.h
@@ -23,7 +23,7 @@
 #define USE_IPV6 1
 
 static PING *ping_init (int type, int ident);
-static int ping_set_dest (PING * ping, char *host);
+static int ping_set_dest (PING * ping, const char *host);
 static int ping_recv (PING * p);
 static int ping_xmit (PING * p);
 

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=d2f3c2e365865917fb9b7ff4d1ceafc33a31bca7


commit d2f3c2e365865917fb9b7ff4d1ceafc33a31bca7
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Mon Feb 17 21:39:20 2020 +0100

    ping: Fix memleak in ping_set_packetsize

diff --git a/ping/libping.c b/ping/libping.c
index 00d0652..d771d34 100644
--- a/ping/libping.c
+++ b/ping/libping.c
@@ -286,19 +286,20 @@ ping_set_packetsize (PING * ping, size_t size)
 }
 
 int
-ping_set_dest (PING * ping, char *host)
+ping_set_dest (PING * ping, const char *host)
 {
 #if HAVE_DECL_GETADDRINFO
   int rc;
   struct addrinfo hints, *res;
-  char *p;
+  char *rhost;
 
 # ifdef HAVE_IDN
-  rc = idna_to_ascii_lz (host, &p, 0);	/* P is allocated.  */
+  rc = idna_to_ascii_lz (host, &rhost, 0);	/* P is allocated.  */
   if (rc)
     return 1;
-# else /* !HAVE_IDN */
-  p = host;
+  host = rhost;
+#else
+  rhost = NULL;
 # endif
 
   memset (&hints, 0, sizeof (hints));
@@ -311,20 +312,24 @@ ping_set_dest (PING * ping, char *host)
   hints.ai_flags |= AI_CANONIDN;
 # endif
 
-  rc = getaddrinfo (p, NULL, &hints, &res);
+  rc = getaddrinfo (host, NULL, &hints, &res);
 
   if (rc)
-    return 1;
+    {
+      free (rhost);
+      return 1;
+    }
 
   memcpy (&ping->ping_dest.ping_sockaddr, res->ai_addr, res->ai_addrlen);
   if (res->ai_canonname)
     ping->ping_hostname = strdup (res->ai_canonname);
   else
-    ping->ping_hostname = strdup (p);
-
 # ifdef HAVE_IDN
-  free (p);
+    ping->ping_hostname = host;
+#else
+    ping->ping_hostname = strdup (host);
 # endif
+
   freeaddrinfo (res);
 
   return 0;
@@ -341,14 +346,14 @@ ping_set_dest (PING * ping, char *host)
     {
       struct hostent *hp;
 # ifdef HAVE_IDN
-      char *p;
+      char *rhost;
       int rc;
 
-      rc = idna_to_ascii_lz (host, &p, 0);
+      rc = idna_to_ascii_lz (host, &rhost, 0);
       if (rc)
 	return 1;
-      hp = gethostbyname (p);
-      free (p);
+      hp = gethostbyname (rhost);
+      free (rhost);
 # else /* !HAVE_IDN */
       hp = gethostbyname (host);
 # endif
diff --git a/ping/ping.h b/ping/ping.h
index c6aafab..03b0c74 100644
--- a/ping/ping.h
+++ b/ping/ping.h
@@ -24,7 +24,7 @@ PING *ping_init (int type, int ident);
 void ping_reset (PING * p);
 void ping_set_type (PING * p, int type);
 void ping_set_packetsize (PING * ping, size_t size);
-int ping_set_dest (PING * ping, char *host);
+int ping_set_dest (PING * ping, const char *host);
 int ping_set_pattern (PING * p, int len, unsigned char * pat);
 void ping_set_event_handler (PING * ping, ping_efp fp, void *closure);
 int ping_recv (PING * p);

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=5d06b6ebea090f9d6b2517d028a5f0b7fe64ff3a


commit 5d06b6ebea090f9d6b2517d028a5f0b7fe64ff3a
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sun Feb 16 20:16:31 2020 +0100

    libls: Remove unused variable kflag

diff --git a/libls/ls.c b/libls/ls.c
index 1af03be..3ca13de 100644
--- a/libls/ls.c
+++ b/libls/ls.c
@@ -119,7 +119,6 @@ ls_main (int argc, char **argv)
   static char dot[] = ".", *dotav[] = { dot, NULL };
   struct winsize win;
   int ch, fts_options;
-  int kflag = 0;
   char *p;
 
   /*
@@ -227,7 +226,6 @@ ls_main (int argc, char **argv)
 	  break;
 	case 'k':
 	  blocksize = 1024;
-	  kflag = 1;
 	  break;
 	case 'o':
 	  f_flags = 1;

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=46def330241ae6b80590e869ce255c615942d73f


commit 46def330241ae6b80590e869ce255c615942d73f
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sun Feb 16 19:54:30 2020 +0100

    ftpd: Fix multiple definition of 'errcatch' (gcc 10)

diff --git a/ftpd/extern.h b/ftpd/extern.h
index 50e16ed..3e2200f 100644
--- a/ftpd/extern.h
+++ b/ftpd/extern.h
@@ -88,7 +88,7 @@ extern void user (const char *);
 extern char *sgetsave (const char *);
 
 /* Exported from ftpd.c.  */
-jmp_buf errcatch;
+extern jmp_buf errcatch;
 extern struct sockaddr_storage data_dest;
 extern socklen_t data_dest_len;
 extern struct sockaddr_storage his_addr;
diff --git a/ftpd/ftpd.c b/ftpd/ftpd.c
index 08ff522..7af1dc5 100644
--- a/ftpd/ftpd.c
+++ b/ftpd/ftpd.c
@@ -144,6 +144,8 @@ char portstr[8];		/* Numeric port as string.  */
 /* Requester credentials.  */
 struct credentials cred;
 
+jmp_buf errcatch;
+
 static struct sockaddr_storage ctrl_addr;	/* Control address.  */
 static socklen_t ctrl_addrlen;
 static struct sockaddr_storage data_source;	/* Port address.  */

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=4114b424a8025a447deb65f57a5b15ea5a523c76


commit 4114b424a8025a447deb65f57a5b15ea5a523c76
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sun Feb 16 19:42:05 2020 +0100

    telnetd: Fix multiple definition of 'not42' (gcc 10)

diff --git a/telnetd/utility.c b/telnetd/utility.c
index 42f624e..fe40e3b 100644
--- a/telnetd/utility.c
+++ b/telnetd/utility.c
@@ -63,7 +63,7 @@ static int ncc;
 static char ptyibuf[BUFSIZ], *ptyip;
 static int pcc;
 
-int not42;
+extern int not42;
 
 static int
 readstream (int p, char *ibuf, int bufsize)

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=14291eccccbf0f10b234bcab8ca5eefe7ebbebc7


commit 14291eccccbf0f10b234bcab8ca5eefe7ebbebc7
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sun Feb 16 19:38:07 2020 +0100

    rcp: Remove unused variable

diff --git a/src/rcp.c b/src/rcp.c
index 4cfdeaf..33f33ee 100644
--- a/src/rcp.c
+++ b/src/rcp.c
@@ -566,7 +566,7 @@ toremote (char *targ, int argc, char *argv[])
 void
 tolocal (int argc, char *argv[])
 {
-  int i, len, tos;
+  int i, tos;
   char *bp, *host, *src, *suser, *vect[1];
 #if defined IP_TOS && defined IPPROTO_IP && defined IPTOS_THROUGHPUT
   struct sockaddr_storage ss;
@@ -578,8 +578,6 @@ tolocal (int argc, char *argv[])
       src = colon (argv[i]);
       if (!src)
 	{			/* Local to local. */
-	  len = strlen (PATH_CP) + strlen (argv[i]) +
-		strlen (target) + 20;
 	  if (asprintf (&bp, "exec %s%s%s %s %s",
 			PATH_CP,
 			iamrecursive ? " -R" : "",

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=861ee754da65e1e7a2a6168eb90e9c5f0a53a9d5


commit 861ee754da65e1e7a2a6168eb90e9c5f0a53a9d5
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sun Feb 16 19:15:45 2020 +0100

    telnet: Fix silent truncation (off-by-one check)
    
    If the DISPLAY variable had exactly 44 bytes, the SE
    byte (end sub negotiation) was silently truncated.

diff --git a/telnet/telnet.c b/telnet/telnet.c
index 297ae0e..d5d13c1 100644
--- a/telnet/telnet.c
+++ b/telnet/telnet.c
@@ -1010,7 +1010,7 @@ suboption (void)
 	   * protocol must remain unsevered.  Check that DP fits in
 	   * full within TEMP.  Otherwise report buffer error.
 	   */
-	  if (strlen (dp) > sizeof (temp) - 4 - 2)
+	  if (strlen ((char *) dp) >= sizeof (temp) - 4 - 2)
 	    {
 	      printf ("lm_will: not enough room in buffer\n");
 	      break;

-----------------------------------------------------------------------

Summary of changes:
 ftpd/extern.h     |  2 +-
 ftpd/ftpd.c       |  2 ++
 libls/ls.c        |  2 --
 ping/libping.c    | 33 +++++++++++++++++++--------------
 ping/ping.h       |  2 +-
 ping/ping6.c      | 18 +++++++++++-------
 ping/ping6.h      |  2 +-
 src/rcp.c         |  4 +---
 telnet/telnet.c   |  2 +-
 telnetd/utility.c |  2 +-
 10 files changed, 38 insertions(+), 31 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:42 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD0-00018d-I7
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:37645)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86sc-0005RM-Lm
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:30:27 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:37237)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86sc-00006l-Er
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:30:26 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 5CC1321167; Sat, 29 Feb 2020 13:30:26 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-98-g22243e6
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 83079af172bddc3f43aae38c309eba372d88d537
X-Git-Newrev: 22243e6f8e3f2a95709f1a9e9e0a1660dd4cf745
Message-Id: <20200229183026.5CC1321167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 13:30:25 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 18:30:28 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  22243e6f8e3f2a95709f1a9e9e0a1660dd4cf745 (commit)
      from  83079af172bddc3f43aae38c309eba372d88d537 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=22243e6f8e3f2a95709f1a9e9e0a1660dd4cf745


commit 22243e6f8e3f2a95709f1a9e9e0a1660dd4cf745
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:30:20 2020 +0100

    telnet: Fix -Wsign-compare in suboption

diff --git a/telnet/telnet.c b/telnet/telnet.c
index d5d13c1..7746f7d 100644
--- a/telnet/telnet.c
+++ b/telnet/telnet.c
@@ -860,7 +860,7 @@ suboption (void)
 	  name = gettermname ();
 	  len = strlen (name) + 4 + 2;
 
-	  if ((len < NETROOM ()) && (len <= sizeof (temp)))
+	  if ((len < NETROOM ()) && (len <= (int) sizeof (temp)))
 	    {
 	      snprintf ((char *) temp, sizeof (temp), "%c%c%c%c%s%c%c",
 			IAC, SB, TELOPT_TTYPE, TELQUAL_IS,

-----------------------------------------------------------------------

Summary of changes:
 telnet/telnet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:42 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD0-000192-Nl
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:42 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:33463)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j866Z-0007Zj-4C
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:40:48 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36397)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j866Z-0002LW-0n
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:40:47 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id E6EFD21167; Sat, 29 Feb 2020 12:40:46 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-87-ga09e3d7
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 4747b63d70d4c4102839282ba4437233fb18af08
X-Git-Newrev: a09e3d7c7d5a5f472e95a49cc990f82006545b6e
Message-Id: <20200229174046.E6EFD21167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 12:40:46 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 17:40:48 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  a09e3d7c7d5a5f472e95a49cc990f82006545b6e (commit)
      from  4747b63d70d4c4102839282ba4437233fb18af08 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=a09e3d7c7d5a5f472e95a49cc990f82006545b6e


commit a09e3d7c7d5a5f472e95a49cc990f82006545b6e
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 18:40:41 2020 +0100

    ping, ping6: Silence -Wimplicit-fallthrough

diff --git a/ping/ping.c b/ping/ping.c
index c8b67a1..e4c7d30 100644
--- a/ping/ping.c
+++ b/ping/ping.c
@@ -253,6 +253,7 @@ parse_opt (int key, char *arg, struct argp_state *state)
     case ARGP_KEY_NO_ARGS:
       argp_error (state, "missing host operand");
 
+      /* FALLTHROUGH */
     default:
       return ARGP_ERR_UNKNOWN;
     }
diff --git a/ping/ping6.c b/ping/ping6.c
index 2d14a4e..5de44c0 100644
--- a/ping/ping6.c
+++ b/ping/ping6.c
@@ -214,6 +214,7 @@ parse_opt (int key, char *arg, struct argp_state *state)
     case ARGP_KEY_NO_ARGS:
       argp_error (state, "missing host operand");
 
+      /* FALLTHROUGH */
     default:
       return ARGP_ERR_UNKNOWN;
     }

-----------------------------------------------------------------------

Summary of changes:
 ping/ping.c  | 1 +
 ping/ping6.c | 1 +
 2 files changed, 2 insertions(+)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:44 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD2-0001AL-50
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:44 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:34065)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86CQ-0008A2-F2
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:46:51 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36521)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86CQ-0005Xx-Bl
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:46:50 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 46F3421167; Sat, 29 Feb 2020 12:46:50 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-89-g0d3cbd6
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 9e0cd093ffb666302c8f4f2231692f882bf3daf2
X-Git-Newrev: 0d3cbd6cdb7bd33a668dc45694c06c4512eceae0
Message-Id: <20200229174650.46F3421167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 12:46:49 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 17:46:51 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  0d3cbd6cdb7bd33a668dc45694c06c4512eceae0 (commit)
      from  9e0cd093ffb666302c8f4f2231692f882bf3daf2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=0d3cbd6cdb7bd33a668dc45694c06c4512eceae0


commit 0d3cbd6cdb7bd33a668dc45694c06c4512eceae0
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 18:46:45 2020 +0100

    talk: Fix uninitialized variable 'nready'

diff --git a/talk/ctl_transact.c b/talk/ctl_transact.c
index 6e539ad..2f0d351 100644
--- a/talk/ctl_transact.c
+++ b/talk/ctl_transact.c
@@ -68,7 +68,7 @@
 int
 ctl_transact (struct in_addr target, CTL_MSG msg, int type, CTL_RESPONSE * rp)
 {
-  int nready, cc;
+  int nready = 0, cc;
   fd_set read_mask, ctl_mask;
   struct timeval wait;
 

-----------------------------------------------------------------------

Summary of changes:
 talk/ctl_transact.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:44 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD2-0001Ad-AI
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:44 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:34998)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86N5-0001GD-Rh
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:57:52 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36657)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86N5-00023u-Lm
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 12:57:51 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 903EE21167; Sat, 29 Feb 2020 12:57:51 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-90-g961fcfa
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 0d3cbd6cdb7bd33a668dc45694c06c4512eceae0
X-Git-Newrev: 961fcfa007a8fb1ee66454e0fe23f674e96756f5
Message-Id: <20200229175751.903EE21167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 12:57:51 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 17:57:53 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  961fcfa007a8fb1ee66454e0fe23f674e96756f5 (commit)
      from  0d3cbd6cdb7bd33a668dc45694c06c4512eceae0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=961fcfa007a8fb1ee66454e0fe23f674e96756f5


commit 961fcfa007a8fb1ee66454e0fe23f674e96756f5
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 18:57:47 2020 +0100

    ftp: Fix 2x misuse of strncpy (read buffer overflow)

diff --git a/ftp/ftp.c b/ftp/ftp.c
index 0dd19b3..7fe99ab 100644
--- a/ftp/ftp.c
+++ b/ftp/ftp.c
@@ -1725,10 +1725,10 @@ pswitch (int flag)
   ip->ntflg = ntflag;
   ntflag = op->ntflg;
   strncpy (ip->nti, ntin, sizeof (ntin) - 1);
-  (ip->nti)[strlen (ip->nti)] = '\0';
+  (ip->nti)[sizeof (ntin) - 1] = '\0';
   strcpy (ntin, op->nti);
   strncpy (ip->nto, ntout, sizeof (ntout) - 1);
-  (ip->nto)[strlen (ip->nto)] = '\0';
+  (ip->nto)[sizeof (ntout) - 1] = '\0';
   strcpy (ntout, op->nto);
   ip->mapflg = mapflag;
   mapflag = op->mapflg;

-----------------------------------------------------------------------

Summary of changes:
 ftp/ftp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:44 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD2-0001Av-Gh
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:44 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:35560)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86UO-0001wI-0J
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:05:24 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36830)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86UN-0004pp-QC
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:05:23 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id B8D4721167; Sat, 29 Feb 2020 13:05:23 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-92-g424fb86
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 0c63e144a55e5d81695bc5b881696d9210e9df42
X-Git-Newrev: 424fb865988b81a5a864228982de78c2ef426206
Message-Id: <20200229180523.B8D4721167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 13:05:23 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 18:05:25 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  424fb865988b81a5a864228982de78c2ef426206 (commit)
      from  0c63e144a55e5d81695bc5b881696d9210e9df42 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=424fb865988b81a5a864228982de78c2ef426206


commit 424fb865988b81a5a864228982de78c2ef426206
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:05:18 2020 +0100

    ftp/cmds.c: Fix return value of remglob

diff --git a/ftp/cmds.c b/ftp/cmds.c
index 9e734a7..0045963 100644
--- a/ftp/cmds.c
+++ b/ftp/cmds.c
@@ -1035,7 +1035,7 @@ remglob (char **argv, int doswitch)
 	args = argv;
       if ((cp = *++args) == NULL)
 	args = NULL;
-      return cp ? 0 : strdup (cp);
+      return cp ? strdup (cp) : NULL;
     }
   if (ftemp == NULL)
     {

-----------------------------------------------------------------------

Summary of changes:
 ftp/cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:44 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD2-0001BG-MW
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:44 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:36209)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86c8-0002ty-Gl
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:13:25 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:36936)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86c8-0000RP-BD
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:13:24 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 3C31A21167; Sat, 29 Feb 2020 13:13:24 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-94-g1e72ad6
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 424fb865988b81a5a864228982de78c2ef426206
X-Git-Newrev: 1e72ad648966437eab5738144d76189bb04ea38f
Message-Id: <20200229181324.3C31A21167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 13:13:23 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 18:13:25 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  1e72ad648966437eab5738144d76189bb04ea38f (commit)
       via  79c8b8f1b045917f8ac76404ee3f8e4c207c8015 (commit)
      from  424fb865988b81a5a864228982de78c2ef426206 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=1e72ad648966437eab5738144d76189bb04ea38f


commit 1e72ad648966437eab5738144d76189bb04ea38f
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:13:19 2020 +0100

    ftp/cmds.c: Silence -Wimplicit-fallthrough

diff --git a/ftp/cmds.c b/ftp/cmds.c
index 6491424..283e5b8 100644
--- a/ftp/cmds.c
+++ b/ftp/cmds.c
@@ -2400,6 +2400,7 @@ domap (char *name)
 	      break;
 	    }
 	  /* Fall through, as '$' must be used verbatim.  */
+	  /* FALLTHROUGH */
 	default:
 	  if (*cp2 != *cp1)
 	    {

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=79c8b8f1b045917f8ac76404ee3f8e4c207c8015


commit 79c8b8f1b045917f8ac76404ee3f8e4c207c8015
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:11:04 2020 +0100

    ftp/cmds.c: Fix multipliers for M(ega) and G(iga)

diff --git a/ftp/cmds.c b/ftp/cmds.c
index 0045963..6491424 100644
--- a/ftp/cmds.c
+++ b/ftp/cmds.c
@@ -1240,10 +1240,12 @@ sethash (int argc _GL_UNUSED_PARAMETER, char **argv)
 	{
 	case 'g':
 	case 'G':
-	  hashbytes *= 1024;	/* Cascaded multiplication!  */
+	  hashbytes *= 1024 * 1024 * 1024;	/* Cascaded multiplication!  */
+	  break;
 	case 'm':
 	case 'M':
-	  hashbytes *= 1024;
+	  hashbytes *= 1024 * 1024;
+	  break;
 	case 'k':
 	case 'K':
 	  hashbytes *= 1024;

-----------------------------------------------------------------------

Summary of changes:
 ftp/cmds.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:45 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD2-0001Ba-Sj
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:44 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:36943)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86hx-0003cc-LB
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:19:26 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:37014)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j86hx-0004mu-EK
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 13:19:25 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 533E521167; Sat, 29 Feb 2020 13:19:25 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-97-g83079af
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: e99cdac15e5a3458a5b94fd6f4732acf835f3cd8
X-Git-Newrev: 83079af172bddc3f43aae38c309eba372d88d537
Message-Id: <20200229181925.533E521167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 13:19:24 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 18:19:26 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  83079af172bddc3f43aae38c309eba372d88d537 (commit)
       via  b09d8a358b83a3bccc614686b4d15ccb6a4d3408 (commit)
      from  e99cdac15e5a3458a5b94fd6f4732acf835f3cd8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=83079af172bddc3f43aae38c309eba372d88d537


commit 83079af172bddc3f43aae38c309eba372d88d537
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:19:20 2020 +0100

    telnetd/state.c: Silence -Wimplicit-fallthrough

diff --git a/telnetd/state.c b/telnetd/state.c
index 2e18798..288ebd4 100644
--- a/telnetd/state.c
+++ b/telnetd/state.c
@@ -634,6 +634,7 @@ willoption (int option)
 	      slctab[SLC_XON].defset.flag |= SLC_DEFAULT;
 	      slctab[SLC_XOFF].defset.flag &= ~SLC_LEVELBITS;
 	      slctab[SLC_XOFF].defset.flag |= SLC_DEFAULT;
+	      /* FALLTHROUGH */
 	    case TELOPT_TTYPE:
 	    case TELOPT_SGA:
 	    case TELOPT_NAWS:

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=b09d8a358b83a3bccc614686b4d15ccb6a4d3408


commit b09d8a358b83a3bccc614686b4d15ccb6a4d3408
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 19:18:58 2020 +0100

    telnetd: Silence unused warning for getterminaltype

diff --git a/telnetd/utility.c b/telnetd/utility.c
index fe40e3b..e9fa017 100644
--- a/telnetd/utility.c
+++ b/telnetd/utility.c
@@ -733,6 +733,7 @@ getterminaltype (char *uname, size_t len)
     }
 #else /* !AUTHENTICATION */
   (void) uname;	/* Silence warning.  */
+  (void) len;	/* Silence warning.  */
 #endif
 
 #ifdef	ENCRYPTION

-----------------------------------------------------------------------

Summary of changes:
 telnetd/state.c   | 1 +
 telnetd/utility.c | 1 +
 2 files changed, 2 insertions(+)


hooks/post-receive
-- 
GNU Inetutils 


From MAILER-DAEMON Sat Feb 29 17:03:45 2020
Received: from list by lists.gnu.org with archive (Exim 4.90_1)
	id 1j8AD3-0001Bs-3p
	for mharc-commit-inetutils@gnu.org; Sat, 29 Feb 2020 17:03:45 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:41416)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j87VK-00078L-7p
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 14:10:27 -0500
Received: from vcs0.savannah.gnu.org ([209.51.188.201]:38292)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <tim.ruehsen@gmx.de>) id 1j87VK-0008V8-45
 for commit-inetutils@gnu.org; Sat, 29 Feb 2020 14:10:26 -0500
Received: by vcs0.savannah.gnu.org (Postfix, from userid 124176)
 id 02E3021167; Sat, 29 Feb 2020 14:10:25 -0500 (EST)
To: commit-inetutils@gnu.org
Subject: [SCM] GNU Inetutils  branch, master,
 updated. inetutils-1_9_4-101-g393f4c6
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 2343dc2e3547bb4c724c486bdad9c4ba7468053f
X-Git-Newrev: 393f4c6c3e3761ceed843cb3990169a5ef2f89d1
Message-Id: <20200229191026.02E3021167@vcs0.savannah.gnu.org>
Date: Sat, 29 Feb 2020 14:10:25 -0500 (EST)
From: tim.ruehsen@gmx.de (Tim Ruehsen)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Mailman-Approved-At: Sat, 29 Feb 2020 17:03:39 -0500
X-BeenThere: commit-inetutils@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: CVS commit notices for the GNU Internet utilities
 <commit-inetutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/commit-inetutils>
List-Post: <mailto:commit-inetutils@gnu.org>
List-Help: <mailto:commit-inetutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/commit-inetutils>,
 <mailto:commit-inetutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Feb 2020 19:10:27 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  393f4c6c3e3761ceed843cb3990169a5ef2f89d1 (commit)
      from  2343dc2e3547bb4c724c486bdad9c4ba7468053f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=393f4c6c3e3761ceed843cb3990169a5ef2f89d1


commit 393f4c6c3e3761ceed843cb3990169a5ef2f89d1
Author: Tim Rühsen <tim.ruehsen@gmx.de>
Date:   Sat Feb 29 20:10:21 2020 +0100

    uucpd: Fix buffer overflows

diff --git a/src/uucpd.c b/src/uucpd.c
index 5674004..edebb20 100644
--- a/src/uucpd.c
+++ b/src/uucpd.c
@@ -310,13 +310,15 @@ dologout (void)
     }
 }
 
+# define SCPYN(a, b)	strncpy(a, b, sizeof (a) - 1); (a)[sizeof (a) - 1] = 0
+
 /*
  * Record login in wtmp file.
  */
 void
 dologin (struct passwd *pw, struct sockaddr *sap, socklen_t salen)
 {
-  char line[32];
+  char line[NI_MAXHOST]; /* remote is copied here later on */
 #if defined PATH_LASTLOG && defined HAVE_STRUCT_LASTLOG
   int f;
 #endif
@@ -353,7 +355,7 @@ dologin (struct passwd *pw, struct sockaddr *sap, socklen_t salen)
 
   if (hp)
     {
-      strncpy (remotehost, hp->h_name, sizeof (remotehost));
+      SCPYN (remotehost, hp->h_name);
       endhostent ();
     }
   else
@@ -378,9 +380,9 @@ dologin (struct passwd *pw, struct sockaddr *sap, socklen_t salen)
 
     ut.ut_type = USER_PROCESS;
     ut.ut_pid = getpid();
-    strncpy (ut.ut_line, line, sizeof (ut.ut_line));
-    strncpy (ut.ut_user, pw->pw_name, sizeof (ut.ut_user));
-    strncpy (ut.ut_host, remotehost, sizeof (ut.ut_host));
+    SCPYN (ut.ut_line, line);
+    SCPYN (ut.ut_user, pw->pw_name);
+    SCPYN (ut.ut_host, remotehost);
 # ifdef HAVE_STRUCT_UTMPX_UT_SYSLEN
     if (strlen (remotehost) < sizeof (ut.ut_host))
       ut.ut_syslen = strlen (remotehost) + 1;
@@ -398,7 +400,6 @@ dologin (struct passwd *pw, struct sockaddr *sap, socklen_t salen)
 #endif /* HAVE_PUTUTXLINE && !HAVE_LOGWTMPX && !HAVE_LOGWTMP */
 
 #if defined PATH_LASTLOG && defined HAVE_STRUCT_LASTLOG
-# define SCPYN(a, b)	strncpy(a, b, sizeof (a))
   f = open (PATH_LASTLOG, O_RDWR);
   if (f >= 0)
     {
@@ -408,7 +409,7 @@ dologin (struct passwd *pw, struct sockaddr *sap, socklen_t salen)
       time (&t);
       ll.ll_time = t;
       lseek (f, (long) pw->pw_uid * sizeof (struct lastlog), 0);
-      strcpy (line, remotehost);
+      SCPYN (line, remotehost);
       SCPYN (ll.ll_line, line);
       SCPYN (ll.ll_host, remotehost);
       write (f, (char *) &ll, sizeof (ll));

-----------------------------------------------------------------------

Summary of changes:
 src/uucpd.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
GNU Inetutils 


