From MAILER-DAEMON Mon Apr 02 17:46:00 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SEp4a-00034h-9p
	for mharc-coreutils@gnu.org; Mon, 02 Apr 2012 17:46:00 -0400
Received: from eggs.gnu.org ([208.118.235.92]:38108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <s.hintermann@ganesh-consulting.ch>)
	id 1SEoq7-00055E-Nq
	for coreutils@gnu.org; Mon, 02 Apr 2012 17:31:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <s.hintermann@ganesh-consulting.ch>)
	id 1SEoq5-0007IX-VZ
	for coreutils@gnu.org; Mon, 02 Apr 2012 17:31:03 -0400
Received: from mail3.copperfasten.ch ([193.34.136.60]:57405
	helo=mail1.copperfasten.ch) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <s.hintermann@ganesh-consulting.ch>)
	id 1SEoq5-0007I4-Oq
	for coreutils@gnu.org; Mon, 02 Apr 2012 17:31:01 -0400
Received: from mail1.copperfasten.ch (localhost [127.0.0.1])
	by mail1.copperfasten.ch (Postfix) with ESMTP id 9AC1162200B
	for <coreutils@gnu.org>; Mon,  2 Apr 2012 23:25:52 +0200 (CEST)
X-Virus-Scanned: by SpamTitan at mail1.copperfasten.ch
Received: from kerio1.ganesh-hosting.ch (kerio1.ganesh-hosting.ch
	[193.34.136.69])
	by mail1.copperfasten.ch (Postfix) with ESMTP id 9C00C621FE4
	for <coreutils@gnu.org>; Mon,  2 Apr 2012 23:25:50 +0200 (CEST)
X-Footer: Z2FuZXNoLWNvbnN1bHRpbmcuY2g=
Received: from [10.0.9.11] ([81.13.164.100])
	(authenticated user simon@ganesh-consulting.ch)
	by kerio1.ganesh-hosting.ch (Kerio Connect 7.3.2)
	for coreutils@gnu.org; Mon, 2 Apr 2012 23:30:53 +0200
Message-ID: <4F7A1A8D.5040909@ganesh-consulting.ch>
Date: Mon, 02 Apr 2012 23:30:53 +0200
From: Simon Hintermann <s.hintermann@ganesh-consulting.ch>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120310 Thunderbird/11.0
MIME-Version: 1.0
To: coreutils@gnu.org
Subject: scp sparse dd file
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 193.34.136.60
X-Mailman-Approved-At: Mon, 02 Apr 2012 17:45:58 -0400
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2012 21:31:04 -0000

Hello all,

I have a tricky one (so do I think)...

My virtual machines are raw-based files, created with a "dd if=/dev/zero 
of=.. bs=1M count=0 seek=120000", for example.

As I want to have native I/O performances on my servers, I do not use 
any NAS or SAN, so when I want to migrate my VMs: scp and/or rsync.

Now is there any way to be able to copy a sparse dd file that uses only 
10MB out of 120GB without transferring the whole 120GB over to another 
server (keeping the sparse capability, of course...)?

Thank you for your expertise!

Greetings,

Simon




From MAILER-DAEMON Mon Apr 02 18:33:39 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SEpoh-0000bs-If
	for mharc-coreutils@gnu.org; Mon, 02 Apr 2012 18:33:39 -0400
Received: from eggs.gnu.org ([208.118.235.92]:55923)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SEpof-0000bi-Nr
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:33:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SEpod-0004sJ-CH
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:33:37 -0400
Received: from mail2.vodafone.ie ([213.233.128.44]:23730)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SEpod-0004s3-6B
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:33:35 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AqcBAAsoek9tTD6l/2dsb2JhbAANOLR7hhQBAQEEMgE4DhALDQEKCRYPCQMCAQIBRQYKAwEHAQHDCJBuBJtzjQU
Received: from unknown (HELO [192.168.1.79]) ([109.76.62.165])
	by mail2.vodafone.ie with ESMTP; 02 Apr 2012 23:33:32 +0100
Message-ID: <4F7A293B.8090105@draigBrady.com>
Date: Mon, 02 Apr 2012 23:33:31 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Simon Hintermann <s.hintermann@ganesh-consulting.ch>
Subject: Re: scp sparse dd file
References: <4F7A1A8D.5040909@ganesh-consulting.ch>
In-Reply-To: <4F7A1A8D.5040909@ganesh-consulting.ch>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.44
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2012 22:33:39 -0000

On 04/02/2012 10:30 PM, Simon Hintermann wrote:
> Hello all,
> 
> I have a tricky one (so do I think)...
> 
> My virtual machines are raw-based files, created with a "dd if=/dev/zero of=.. bs=1M count=0 seek=120000", for example.
> 
> As I want to have native I/O performances on my servers, I do not use any NAS or SAN, so when I want to migrate my VMs: scp and/or rsync.
> 
> Now is there any way to be able to copy a sparse dd file that uses only 10MB out of 120GB without transferring the whole 120GB over to another server (keeping the sparse capability, of course...)?
> 
> Thank you for your expertise!

Since cp --version 8.11, sparse files are read efficiently,
from file systems that support the fiemap system call (most modern ones).
cp has traditionally supported efficient writing of sparse files
through the use of seek() rather than write().

cheers,
Pádraig.


From MAILER-DAEMON Mon Apr 02 19:14:23 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SEqS7-0006bq-Am
	for mharc-coreutils@gnu.org; Mon, 02 Apr 2012 19:14:23 -0400
Received: from eggs.gnu.org ([208.118.235.92]:60363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cryptographrix@gmail.com>) id 1SEpM8-0008K5-Qe
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:04:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cryptographrix@gmail.com>) id 1SEpM6-0006Az-M8
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:04:08 -0400
Received: from mail-iy0-f169.google.com ([209.85.210.169]:40003)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cryptographrix@gmail.com>) id 1SEpM6-0006AO-Ev
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:04:06 -0400
Received: by iajr24 with SMTP id r24so5906550iaj.0
	for <coreutils@gnu.org>; Mon, 02 Apr 2012 15:04:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type;
	bh=HqgCGuVQegjHPT/DwY0dmcNU8NiaEoj9onWMC191kfU=;
	b=CcfxZ65A99AmMO2AXlHfVemv738rE5Jh/JC7QQ7bH2gjDUeig8ieKZGwQkSWQzW0Jr
	51UR1M/T2Fe9SMuiwMW8j9T+Ziz6tWoLCA+K7dUVt3S1eWTHF2LlAxtqd1i7mvt6ftUD
	D1CzQ8JQejG0z+OsyaJe/El/Z+6DN63b9E0r2tGZ0jCPb30ZhC6SId5XrJ3s8SsTVJuw
	VUyfVWCVXBTJeyrSBLoXLQ6lQbhanCWFT7mT4xtYJ5CVI9E2atrZw3HRPzyl57fK63Z5
	twyDK3SRPSPXVj/rPJuj0toJdjT/4JGOO1D/AednB3Uc/3askaUwuivuEhQgttz/203l
	blrw==
Received: by 10.50.187.225 with SMTP id fv1mr6938842igc.28.1333404243238; Mon,
	02 Apr 2012 15:04:03 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.42.241.197 with HTTP; Mon, 2 Apr 2012 15:03:42 -0700 (PDT)
In-Reply-To: <4F7A1A8D.5040909@ganesh-consulting.ch>
References: <4F7A1A8D.5040909@ganesh-consulting.ch>
From: Cryptographrix <cryptographrix@gmail.com>
Date: Mon, 2 Apr 2012 18:03:42 -0400
Message-ID: <CAPPYGuyr4_OF=qu9erWqhTAsWawd5gXPvBaRkta4x4n4SGhFPw@mail.gmail.com>
Subject: Re: scp sparse dd file
To: Simon Hintermann <s.hintermann@ganesh-consulting.ch>
Content-Type: multipart/alternative; boundary=14dae9340fe1429d6f04bcb95e4c
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.210.169
X-Mailman-Approved-At: Mon, 02 Apr 2012 19:14:21 -0400
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2012 22:04:10 -0000

--14dae9340fe1429d6f04bcb95e4c
Content-Type: text/plain; charset=ISO-8859-1

On the destination server:
dd if=/dev/zero of=<file> bs=1M count=0 seek=120000
mkfs.<filesystem_type> <file>
mkdir -p /mnt/local
mount -t loop <file> /mnt/local/

On the source:
mkdir -p /mnt/local/
mount -t loop <local_raw_file> /mnt/local/
cd /mnt/local
rsync -avr . user@remoteServer:/mnt/local/

on both servers:
sync;sync;sync;sync;
umount /mnt/local



On Mon, Apr 2, 2012 at 5:30 PM, Simon Hintermann <
s.hintermann@ganesh-consulting.ch> wrote:

> Hello all,
>
> I have a tricky one (so do I think)...
>
> My virtual machines are raw-based files, created with a "dd if=/dev/zero
> of=.. bs=1M count=0 seek=120000", for example.
>
> As I want to have native I/O performances on my servers, I do not use any
> NAS or SAN, so when I want to migrate my VMs: scp and/or rsync.
>
> Now is there any way to be able to copy a sparse dd file that uses only
> 10MB out of 120GB without transferring the whole 120GB over to another
> server (keeping the sparse capability, of course...)?
>
> Thank you for your expertise!
>
> Greetings,
>
> Simon
>
>
>
>

--14dae9340fe1429d6f04bcb95e4c
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On the destination server:<br>dd if=3D/dev/zero of=3D&lt;file&gt; bs=3D1M c=
ount=3D0 seek=3D120000<br>mkfs.&lt;filesystem_type&gt; &lt;file&gt;<br>mkdi=
r -p /mnt/local<div>mount -t loop &lt;file&gt; /mnt/local/</div><div><br></=
div><div>

On the source:</div><div>mkdir -p /mnt/local/</div><div>mount -t loop &lt;l=
ocal_raw_file&gt; /mnt/local/</div><div>cd /mnt/local</div><div>rsync -avr =
. user@remoteServer:/mnt/local/</div><div><br></div><div>on both servers:</=
div>

<div>sync;sync;sync;sync;</div><div>umount /mnt/local</div><div><br></div><=
div><br></div><div><br><div class=3D"gmail_quote">On Mon, Apr 2, 2012 at 5:=
30 PM, Simon Hintermann <span dir=3D"ltr">&lt;<a href=3D"mailto:s.hinterman=
n@ganesh-consulting.ch">s.hintermann@ganesh-consulting.ch</a>&gt;</span> wr=
ote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">Hello all,<br>
<br>
I have a tricky one (so do I think)...<br>
<br>
My virtual machines are raw-based files, created with a &quot;dd if=3D/dev/=
zero of=3D.. bs=3D1M count=3D0 seek=3D120000&quot;, for example.<br>
<br>
As I want to have native I/O performances on my servers, I do not use any N=
AS or SAN, so when I want to migrate my VMs: scp and/or rsync.<br>
<br>
Now is there any way to be able to copy a sparse dd file that uses only 10M=
B out of 120GB without transferring the whole 120GB over to another server =
(keeping the sparse capability, of course...)?<br>
<br>
Thank you for your expertise!<br>
<br>
Greetings,<br>
<br>
Simon<br>
<br>
<br>
<br>
</blockquote></div><br></div>

--14dae9340fe1429d6f04bcb95e4c--


From MAILER-DAEMON Mon Apr 02 19:14:23 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SEqS7-0006c3-CM
	for mharc-coreutils@gnu.org; Mon, 02 Apr 2012 19:14:23 -0400
Received: from eggs.gnu.org ([208.118.235.92]:60452)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SEpMP-0008LY-OO
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:04:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SEpMM-0006DI-MF
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:04:25 -0400
Received: from plane.gmane.org ([80.91.229.3]:58050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SEpMM-0006D5-FR
	for coreutils@gnu.org; Mon, 02 Apr 2012 18:04:22 -0400
Received: from public by plane.gmane.org with local (Exim 4.69)
	(envelope-from <public@plane.gmane.org>) id 1SEpMJ-0000MG-Gn
	for coreutils@gnu.org; Tue, 03 Apr 2012 00:04:19 +0200
Received: from mail-out.m-online.net ([212.18.0.9])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <whitebox@nefkom.net>)
	id 1SEpMC-0000GJ-Jd; Tue, 03 Apr 2012 00:04:12 +0200
Received: from frontend1.mail.m-online.net (unknown [192.168.8.180])
	by mail-out.m-online.net (Postfix) with ESMTP id 3VM6sS1cV5z4Kh2G;
	Tue,  3 Apr 2012 00:04:12 +0200 (CEST)
Received: from igel.home (ppp-93-104-152-142.dynamic.mnet-online.de
	[93.104.152.142])
	by mail.mnet-online.de (Postfix) with ESMTPA id 3VM6sS0VCsz4KK2H;
	Tue,  3 Apr 2012 00:04:12 +0200 (CEST)
Received: by igel.home (Postfix, from userid 501)
	id B4CCDCA2A9; Tue,  3 Apr 2012 00:04:11 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Simon Hintermann
	<public-s.hintermann-hSVQ78NZBj4yzzc7d281thZJsoRkLGN9@plane.gmane.org>
Subject: Re: scp sparse dd file
References: <4F7A1A8D.5040909@ganesh-consulting.ch>
X-Yow: ...I think I'm having an overnight sensation right now!!
Date: Tue, 03 Apr 2012 00:04:11 +0200
In-Reply-To: <4F7A1A8D.5040909@ganesh-consulting.ch> (Simon Hintermann's
	message of "Mon, 02 Apr 2012 23:30:53 +0200")
Message-ID: <m2sjgloko4.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 80.91.229.3
X-Mailman-Approved-At: Mon, 02 Apr 2012 19:14:21 -0400
Cc: public-coreutils-mXXj517/zsQ@plane.gmane.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2012 22:04:26 -0000



Simon Hintermann
<s.hintermann-hSVQ78NZBj4yzzc7d281thZJsoRkLGN9@public.gmane.org> writes:

> Now is there any way to be able to copy a sparse dd file that uses only
> 10MB out of 120GB without transferring the whole 120GB over to another
> server (keeping the sparse capability, of course...)?

rsync --sparse.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



From MAILER-DAEMON Tue Apr 03 13:50:37 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SF7sL-0005TH-Ks
	for mharc-coreutils@gnu.org; Tue, 03 Apr 2012 13:50:37 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SF7sJ-0005St-M8
	for coreutils@gnu.org; Tue, 03 Apr 2012 13:50:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SF7sH-00075l-Vk
	for coreutils@gnu.org; Tue, 03 Apr 2012 13:50:35 -0400
Received: from mx.meyering.net ([88.168.87.75]:43822)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SF7sH-00075X-Jt
	for coreutils@gnu.org; Tue, 03 Apr 2012 13:50:33 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 3ECC16008A
	for <coreutils@gnu.org>; Tue,  3 Apr 2012 19:50:30 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] tests: avoid spurious misc/expr failure on AIX 6.1
Date: Tue, 03 Apr 2012 19:50:30 +0200
Message-ID: <87obr81z89.fsf@rho.meyering.net>
Lines: 32
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 17:50:37 -0000

FYI,

>From 0f35329876580f07daa30534ce924237f1357539 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 2 Apr 2012 22:32:57 +0200
Subject: [PATCH] tests: avoid spurious misc/expr failure on AIX 6.1

* tests/misc/expr: Avoid spurious failure on AIX 6.1 due to
differing regexp diagnostic.  Reported by Michael Felt.
---
 tests/misc/expr |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tests/misc/expr b/tests/misc/expr
index fb81ce7..781cf38 100755
--- a/tests/misc/expr
+++ b/tests/misc/expr
@@ -140,7 +140,11 @@ my @Tests =
      ['bre48', '_ : "a\\{1,x"',
       {ERR => "$prog: Unmatched \\{\n"}, {EXIT => 2}],
      ['bre49', '_ : "a\\{32768\\}"',
-      {ERR => "$prog: Invalid content of \\{\\}\n"}, {EXIT => 2}],
+      {ERR => "$prog: Invalid content of \\{\\}\n"}, {EXIT => 2},
+      # Map AIX-6's different diagnostic to the one we expect:
+      {ERR_SUBST =>
+       's,Regular expression too big,Invalid content of \\\\{\\\\},'},
+      ],
      ['bre50', '_ : "a\\{1,0\\}"',
       {ERR => "$prog: Invalid content of \\{\\}\n"}, {EXIT => 2}],
      ['bre51', '"acabc" : ".*ab\\{0,0\\}c"', {OUT => '2'}],
--
1.7.9.3


From MAILER-DAEMON Tue Apr 03 13:51:21 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SF7t3-0005dE-Q6
	for mharc-coreutils@gnu.org; Tue, 03 Apr 2012 13:51:21 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40861)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SF7sx-0005c3-6w
	for coreutils@gnu.org; Tue, 03 Apr 2012 13:51:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SF7sp-0007AC-Gh
	for coreutils@gnu.org; Tue, 03 Apr 2012 13:51:14 -0400
Received: from mx.meyering.net ([88.168.87.75]:43825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SF7sp-00079u-8G
	for coreutils@gnu.org; Tue, 03 Apr 2012 13:51:07 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id BBD766008A
	for <coreutils@gnu.org>; Tue,  3 Apr 2012 19:51:05 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] doc: identify/refer to source of each fixed bug in log
Date: Tue, 03 Apr 2012 19:51:05 +0200
Message-ID: <87iphg1z7a.fsf@rho.meyering.net>
Lines: 40
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 17:51:21 -0000

Just codifying existing practice...

>From 5e1f5c5739766f054e773e296570ec410377ec25 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Tue, 3 Apr 2012 16:14:32 +0200
Subject: [PATCH] doc: identify/refer to source of each fixed bug in log
 and in NEWS

* HACKING (Commit log requirements): Describe our policy: when you
fix a bug, put the "git describe" string of the bug-introducing commit
in your commit log and put the "fixed-in-release version number"
in the NEWS blurb.
---
 HACKING |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/HACKING b/HACKING
index b05fd54..f8d3a9b 100644
--- a/HACKING
+++ b/HACKING
@@ -232,6 +232,17 @@ Try to make the summary line fit one of the following forms:
   build: change-description
   maint: change-description

+If your commit fixes a bug, try to find the commit that introduced that
+bug.  If you do that, add a note in your new commit log saying something
+like "Introduced by commit v8.12-103-g54cbe6e." and add something like
+[bug introduced in coreutils-8.13] in the corresponding NEWS blurb.
+Assuming you found the bug in commit 54cbe6e6, "git describe 54cbe6e6"
+will print the longer tag-relative string that you'll need.
+Note that we used to use an 8-byte SHA1 prefix like "54cbe6e6", because
+that was automatically rendered as a clickable link by "gitk", but with
+git-1.7.10, the more descriptive version-containing "git describe" format
+that we now require is also highlighted.
+

 Curly braces: use judiciously
 =============================
--
1.7.9.3


From MAILER-DAEMON Tue Apr 03 16:18:27 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFABP-0008KM-5j
	for mharc-coreutils@gnu.org; Tue, 03 Apr 2012 16:18:27 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFABM-0008K8-GY
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:18:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFABK-0004fi-S9
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:18:24 -0400
Received: from mx.meyering.net ([88.168.87.75]:44223)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFABK-0004em-Ki
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:18:22 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 47A0B60081
	for <coreutils@gnu.org>; Tue,  3 Apr 2012 22:18:20 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] tests: fix quoting bug in misc/nohup
Date: Tue, 03 Apr 2012 22:18:20 +0200
Message-ID: <87d37o1sdv.fsf@rho.meyering.net>
Lines: 30
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 20:18:25 -0000

I posted this last month, but somehow never pushed it...

>From 64cf1033cc47fe40bcebbecd069db486794fecea Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Sun, 18 Mar 2012 02:33:53 +0100
Subject: [PATCH] tests: fix quoting bug in misc/nohup

* tests/misc/nohup: Fix invalid quoting.
---
 tests/misc/nohup |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/misc/nohup b/tests/misc/nohup
index c6082ac..cef8ee8 100755
--- a/tests/misc/nohup
+++ b/tests/misc/nohup
@@ -50,9 +50,9 @@ rm -f nohup.out err exp
 # change depending on whether stderr is redirected.
 nohup sh -c 'echo stdout; echo stderr 1>&2' >out || fail=1
 if test -t 2; then
-  test "'cat out|tr '\n' -`" = stdout-stderr- || fail=1
+  test "$(cat out|tr '\n' -)" = stdout-stderr- || fail=1
 else
-  test "'cat out|tr '\n' -`" = stdout- || fail=1
+  test "$(cat out|tr '\n' -)" = stdout- || fail=1
 fi
 # It must *not* exist.
 test -f nohup.out && fail=1
--
1.7.9.3


From MAILER-DAEMON Tue Apr 03 16:25:47 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFAIV-00023W-KD
	for mharc-coreutils@gnu.org; Tue, 03 Apr 2012 16:25:47 -0400
Received: from eggs.gnu.org ([208.118.235.92]:52467)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIT-00023L-Uc
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIS-0007Hq-Cu
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:45 -0400
Received: from mx.meyering.net ([88.168.87.75]:44249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIS-0007HT-2u
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:44 -0400
Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id 7A517603A6; Tue,  3 Apr 2012 22:25:42 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH 1/4] tests: convert one `...` expression manually
Date: Tue,  3 Apr 2012 22:25:33 +0200
Message-Id: <1333484736-8289-2-git-send-email-jim@meyering.net>
X-Mailer: git-send-email 1.7.9.5
In-Reply-To: <1333484736-8289-1-git-send-email-jim@meyering.net>
References: <1333484736-8289-1-git-send-email-jim@meyering.net>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 20:25:47 -0000

From: Jim Meyering <meyering@redhat.com>

* tests/ls/stat-vs-dirent: Manually convert `(...)` to $(...),
to avoid automatically producing an invalid result.
---
 tests/ls/stat-vs-dirent |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/ls/stat-vs-dirent b/tests/ls/stat-vs-dirent
index 7b49a1f..60d9622 100755
--- a/tests/ls/stat-vs-dirent
+++ b/tests/ls/stat-vs-dirent
@@ -52,7 +52,7 @@ while :; do
     fi
   fi

-  t=`(cd "$t/.."; pwd)`
+  t=$(cd "$t/.."; pwd)
   dev_ino=`stat --format=%d-%i "$t"`
   test $dev_ino = $root_dev_ino && break
 done
-- 
1.7.9.3



From MAILER-DAEMON Tue Apr 03 16:25:49 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFAIX-00026e-Nc
	for mharc-coreutils@gnu.org; Tue, 03 Apr 2012 16:25:49 -0400
Received: from eggs.gnu.org ([208.118.235.92]:52489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIV-00023M-4j
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIS-0007Hw-IQ
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:46 -0400
Received: from mx.meyering.net ([88.168.87.75]:44251)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIS-0007HX-8g
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:44 -0400
Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id 6897D6045B; Tue,  3 Apr 2012 22:25:42 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: stop using backticks in tests/
Date: Tue,  3 Apr 2012 22:25:32 +0200
Message-Id: <1333484736-8289-1-git-send-email-jim@meyering.net>
X-Mailer: git-send-email 1.7.9.5
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 20:25:48 -0000

IMHO, bourne shell backticks `...` have been anachronistic for some time,
and we've arranged with gnulib's init.sh so that all of coreutils' tests
can safely use $(...) instead.   That has covered most new tests.
This series removes/replaces all legacy `...` uses.

There are a few remaining in init.sh and check.mk, and
one in the stdbuf test, but that's it.
I'll add a syntax-check to keep it that way.

[PATCH 1/4] tests: convert one `...` expression manually
[PATCH 2/4] tests: convert nearly all `...` expressions to $(...)
[PATCH 3/4] tests: use perl's qx!...! rather than `...`
[PATCH 4/4] tests: remove nearly all remaining backticks


From MAILER-DAEMON Tue Apr 03 16:25:50 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFAIY-00027c-Ps
	for mharc-coreutils@gnu.org; Tue, 03 Apr 2012 16:25:50 -0400
Received: from eggs.gnu.org ([208.118.235.92]:52496)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIV-00023U-OE
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIT-0007IF-4H
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:47 -0400
Received: from mx.meyering.net ([88.168.87.75]:44250)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIS-0007HU-Ft
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:45 -0400
Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id C23C160561; Tue,  3 Apr 2012 22:25:42 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH 3/4] tests: use perl's qx!...! rather than `...`
Date: Tue,  3 Apr 2012 22:25:35 +0200
Message-Id: <1333484736-8289-4-git-send-email-jim@meyering.net>
X-Mailer: git-send-email 1.7.9.5
In-Reply-To: <1333484736-8289-1-git-send-email-jim@meyering.net>
References: <1333484736-8289-1-git-send-email-jim@meyering.net>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 20:25:50 -0000

From: Jim Meyering <meyering@redhat.com>

* tests/misc/expr: As above.
* tests/misc/ls-misc: Likewise.
* tests/misc/pwd-long: Likewise.
* tests/misc/uniq: Likewise.

tests: convert nearly all `...` expressions to $(...)
Exempt init.sh because it runs before we're assured to have a
shell that groks $(...).  Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run.  Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...).  Do that by running this command:

git grep -l '`.*`' tests \
  | grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
  | xargs perl -pi -e 's/`(.*?)`/\$($1)/g'

One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
-    expected_perms=$(eval 'echo \$expected_'$dest)
+    expected_perms=$(eval 'echo $expected_'$dest)
---
 tests/misc/expr     |    2 +-
 tests/misc/ls-misc  |    2 +-
 tests/misc/pwd-long |    6 +-----
 tests/misc/uniq     |    2 +-
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/tests/misc/expr b/tests/misc/expr
index 781cf38..c298d4c 100755
--- a/tests/misc/expr
+++ b/tests/misc/expr
@@ -175,7 +175,7 @@ my @Tests =
     );

 # If using big numbers fails, remove all /^bignum-/ tests
-`expr $big_prod '*' $big_prod '*' $big_prod`
+qx!expr $big_prod '*' $big_prod '*' $big_prod!
   or @Tests = grep {$_->[0] !~ /^bignum-/} @Tests;

 # Append a newline to end of each expected 'OUT' string.
diff --git a/tests/misc/ls-misc b/tests/misc/ls-misc
index 14e1176..71647f9 100755
--- a/tests/misc/ls-misc
+++ b/tests/misc/ls-misc
@@ -331,7 +331,7 @@ $fail
   and exit 1;

 # Be careful to use the just-build dircolors.
-my $env = `$ENV{abs_top_builddir}/src/dircolors -b`;
+my $env = qx/dircolors -b/;
 $env =~ s/^LS_COLORS=\'//;
 $env =~ s/\';.*//sm;
 $ENV{LS_COLORS} = $env;
diff --git a/tests/misc/pwd-long b/tests/misc/pwd-long
index a030a18..033c0e3 100755
--- a/tests/misc/pwd-long
+++ b/tests/misc/pwd-long
@@ -93,11 +93,7 @@ $build_src_dir =~ m!^([-+.:/\w]+)$!
     . "$build_src_dir\n";
 $build_src_dir = $1;

-my $pwd_binary = "$build_src_dir/pwd";
-
--x $pwd_binary
-  or die "$ME: $pwd_binary is not an executable file\n";
-chomp (my $actual = `$pwd_binary`);
+chomp (my $actual = qx!env pwd!);

 # Convert the absolute name from pwd into a $CWD-relative name.
 # This is necessary in order to avoid a spurious failure when run
diff --git a/tests/misc/uniq b/tests/misc/uniq
index f7211a3..91028a9 100755
--- a/tests/misc/uniq
+++ b/tests/misc/uniq
@@ -86,7 +86,7 @@ my $locale = $ENV{LOCALE_FR};
   and CuSkip::skip "$prog: skipping this test -- no appropriate locale\n";

 # See if isblank returns true for nbsp.
-my $x = `env printf '\xa0'| LC_ALL=$locale tr '[:blank:]' x`;
+my $x = qx!env printf '\xa0'| LC_ALL=$locale tr '[:blank:]' x!;
 # If so, expect just one line of output in the schar test.
 # Otherwise, expect two.
 my $in = " y z\n\xa0 y z\n";
-- 
1.7.9.3



From MAILER-DAEMON Tue Apr 03 16:25:51 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFAIZ-0002BU-Ty
	for mharc-coreutils@gnu.org; Tue, 03 Apr 2012 16:25:51 -0400
Received: from eggs.gnu.org ([208.118.235.92]:52494)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIV-00023T-HZ
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIS-0007I8-U2
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:47 -0400
Received: from mx.meyering.net ([88.168.87.75]:44252)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIS-0007Hd-Ek
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:44 -0400
Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id D9A7060571; Tue,  3 Apr 2012 22:25:42 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH 4/4] tests: remove nearly all remaining backticks
Date: Tue,  3 Apr 2012 22:25:36 +0200
Message-Id: <1333484736-8289-5-git-send-email-jim@meyering.net>
X-Mailer: git-send-email 1.7.9.5
In-Reply-To: <1333484736-8289-1-git-send-email-jim@meyering.net>
References: <1333484736-8289-1-git-send-email-jim@meyering.net>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 20:25:51 -0000

From: Jim Meyering <meyering@redhat.com>

* tests/rm/isatty: Remove now-unneeded "# `" line.
* tests/misc/ls-time: Likewise.
* tests/misc/date-sec: Remove stray "`" in comment.
* tests/du/long-sloop: Likewise.
* tests/mv/part-symlink: Replace multi-line `...` by $(...).
* tests/mv/sticky-to-xpart: Likewise.
* tests/rm/fail-2eperm: Likewise.
* tests/ls/nameless-uid: Likewise.
* tests/cp/perm: Likewise.
* tests/cp/preserve-gid: Likewise.
* tests/cp/same-file: Likewise.
---
 tests/cp/perm            |    8 ++++----
 tests/cp/preserve-gid    |   12 ++++++------
 tests/cp/same-file       |    6 +++---
 tests/du/long-sloop      |    4 ++--
 tests/ls/nameless-uid    |    4 ++--
 tests/misc/date-sec      |    2 +-
 tests/misc/ls-time       |    1 -
 tests/mv/part-symlink    |   12 ++++++------
 tests/mv/sticky-to-xpart |    4 ++--
 tests/rm/fail-2eperm     |    4 ++--
 tests/rm/isatty          |    1 -
 11 files changed, 28 insertions(+), 30 deletions(-)

diff --git a/tests/cp/perm b/tests/cp/perm
index eb3925d..a93df71 100755
--- a/tests/cp/perm
+++ b/tests/cp/perm
@@ -55,13 +55,13 @@ for u in 31 37 2; do
                 ;;
               cp:*:no)
                 test $u = 37 &&
-                  expected_perms=`
+                  expected_perms=$(
                     echo $expected_perms | sed 's/.....$/-----/'
-                  `
+                  )
                 test $u = 31 &&
-                  expected_perms=`
+                  expected_perms=$(
                     echo $expected_perms | sed 's/..\(..\).$/--\1-/'
-                  `
+                  )
                 ;;
             esac
             test _$actual_perms = _$expected_perms || exit 1
diff --git a/tests/cp/preserve-gid b/tests/cp/preserve-gid
index 6f371c3..746c57a 100755
--- a/tests/cp/preserve-gid
+++ b/tests/cp/preserve-gid
@@ -52,24 +52,24 @@ t0() {
   fi
 }

-nameless_uid=`$PERL -le '
+nameless_uid=$($PERL -le '
   foreach my $i (1000..16*1024-1)
     {
       getpwuid $i or (print $i), exit
     }
-'`
-nameless_gid1=`$PERL -le '
+')
+nameless_gid1=$($PERL -le '
   foreach my $i (1000..16*1024)
     {
       getgrgid $i or (print $i), exit
     }
-'`
-nameless_gid2=`$PERL -le '
+')
+nameless_gid2=$($PERL -le '
   foreach my $i ('"$nameless_gid1"'+1..16*1024)
     {
       getgrgid $i or (print $i), exit
     }
-'`
+')

 if test -z "$nameless_uid" \
     || test -z "$nameless_gid1" \
diff --git a/tests/cp/same-file b/tests/cp/same-file
index dbd4d01..2ca7bf6 100755
--- a/tests/cp/same-file
+++ b/tests/cp/same-file
@@ -102,10 +102,10 @@ for args in 'foo symlink' 'symlink foo' 'foo foo' 'sl1 sl2' 'foo hardlink'; do
           ' _err
         fi
         # Strip off all but the file names.
-        ls=`ls -gG --ignore=_err . \
-            | sed \
+        ls=$(ls -gG --ignore=_err . \
+             | sed \
                 -e '/^total /d' \
-                -e 's/^[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *//'`
+                -e 's/^[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *//')
         echo "($ls)"
         # Make sure the original is unchanged and that
         # the destination is a copy.
diff --git a/tests/du/long-sloop b/tests/du/long-sloop
index f9e70ad..48e2e30 100755
--- a/tests/du/long-sloop
+++ b/tests/du/long-sloop
@@ -50,8 +50,8 @@ echo foo > $i
 # The following also serves to record in 'err' the string
 # corresponding to strerror (ELOOP).  This is necessary because while
 # Linux/libc gives 'Too many levels of symbolic links', Solaris
-# renders it as `Number of symbolic links encountered during path
-# name traversal exceeds MAXSYMLINKS'.
+# renders it as "Number of symbolic links encountered during path
+# name traversal exceeds MAXSYMLINKS".

 cat $file > /dev/null 2> err &&
     skip_ 'Your system appears to be able to handle more than $n symlinks
diff --git a/tests/ls/nameless-uid b/tests/ls/nameless-uid
index 1c8c471..5b45b09 100755
--- a/tests/ls/nameless-uid
+++ b/tests/ls/nameless-uid
@@ -22,9 +22,9 @@ print_ver_ ls
 require_root_
 require_perl_

-nameless_uid=`$PERL -e '
+nameless_uid=$($PERL -e '
   foreach my $i (1000..16*1024) { getpwuid $i or (print "$i\n"), exit }
-'`
+')

 if test x$nameless_uid = x; then
   skip_ "couldn't find a nameless UID"
diff --git a/tests/misc/date-sec b/tests/misc/date-sec
index df77fe7..a46b479 100755
--- a/tests/misc/date-sec
+++ b/tests/misc/date-sec
@@ -1,6 +1,6 @@
 #!/bin/sh
 # Ensure that a command like
-# `date --date="21:04 +0100" +%S' always prints '00'.
+# date --date="21:04 +0100" +%S' always prints '00'.
 # Before coreutils-5.2.1, it would print the seconds from the current time.

 # Copyright (C) 2004-2012 Free Software Foundation, Inc.
diff --git a/tests/misc/ls-time b/tests/misc/ls-time
index 7bc3c64..7d1f205 100755
--- a/tests/misc/ls-time
+++ b/tests/misc/ls-time
@@ -70,7 +70,6 @@ tests in this file will not be run.
 In the output below, the date of last modification for 'a' should
 have been $t3.
 EOF
-  #`
   ls --full -l a
   framework_failure_
   ;;
diff --git a/tests/mv/part-symlink b/tests/mv/part-symlink
index 2e7cf1b..e57de3c 100755
--- a/tests/mv/part-symlink
+++ b/tests/mv/part-symlink
@@ -96,18 +96,18 @@ for copy in cp mv; do
             }
           # Strip off all but the file names.
           # Remove any site-dependent part of each file name.
-          ls=`ls -gG --ignore=.err . \
-              | sed \
+          ls=$(ls -gG --ignore=.err . \
+               | sed \
                   -e '/^total /d' \
                   -e "s,$other_partition_tmpdir/,," \
                   -e "s,$pwd_tmp/,," \
-                  -e 's/^[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *//'`
-          ls2=`cd "$other_partition_tmpdir" && ls -gG --ignore=.err . \
-              | sed \
+                  -e 's/^[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *//')
+          ls2=$(cd "$other_partition_tmpdir" && ls -gG --ignore=.err . \
+                | sed \
                   -e '/^total /d' \
                   -e "s,$other_partition_tmpdir/,," \
                   -e "s,$pwd_tmp/,," \
-                  -e 's/^[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *//'`
+                  -e 's/^[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *[^ ]*  *//')
           echo " ("$ls") ("$ls2")"

           # If the command failed, then it must not have changed the files.
diff --git a/tests/mv/sticky-to-xpart b/tests/mv/sticky-to-xpart
index 954cb8f..6df6502 100755
--- a/tests/mv/sticky-to-xpart
+++ b/tests/mv/sticky-to-xpart
@@ -41,10 +41,10 @@ chmod go+x . || framework_failure_


 # Ensure that $NON_ROOT_USERNAME can access the required version of mv.
-version=`
+version=$(
   setuidgid $NON_ROOT_USERNAME env PATH="$PATH" mv --version |
   sed -n '1s/.* //p'
-`
+)
 case $version in
   $PACKAGE_VERSION) ;;
   *) skip_ "cannot access just-built mv as user $NON_ROOT_USERNAME";;
diff --git a/tests/rm/fail-2eperm b/tests/rm/fail-2eperm
index 9162892..fa2f432 100755
--- a/tests/rm/fail-2eperm
+++ b/tests/rm/fail-2eperm
@@ -31,10 +31,10 @@ touch a/b || framework_failure_

 # Try to ensure that $NON_ROOT_USERNAME can access
 # the required version of rm.
-rm_version=`
+rm_version=$(
   setuidgid $NON_ROOT_USERNAME env PATH="$PATH" rm --version |
   sed -n '1s/.* //p'
-`
+)
 case $rm_version in
   $PACKAGE_VERSION) ;;
   *) skip_ "cannot access just-built rm as user $NON_ROOT_USERNAME";;
diff --git a/tests/rm/isatty b/tests/rm/isatty
index b1e558b..f28653c 100755
--- a/tests/rm/isatty
+++ b/tests/rm/isatty
@@ -44,7 +44,6 @@ kill $pid > /dev/null 2>&1
 cat > exp <<\EOF
 rm: remove write-protected regular empty file 'f'? x
 EOF
-#`

 # Append an 'x' and a newline.
 echo x >> out
-- 
1.7.9.3



From MAILER-DAEMON Tue Apr 03 16:28:36 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFALE-00031e-LQ
	for mharc-coreutils@gnu.org; Tue, 03 Apr 2012 16:28:36 -0400
Received: from eggs.gnu.org ([208.118.235.92]:52689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIo-0002kj-Bs
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:26:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIW-0007JQ-P1
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:26:05 -0400
Received: from mx.meyering.net ([88.168.87.75]:44253)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <meyering@mx.meyering.net>) id 1SFAIT-0007Hh-5t
	for coreutils@gnu.org; Tue, 03 Apr 2012 16:25:48 -0400
Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id A453B60557; Tue,  3 Apr 2012 22:25:42 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH 2/4] tests: convert nearly all `...` expressions to $(...)
Date: Tue,  3 Apr 2012 22:25:34 +0200
Message-Id: <1333484736-8289-3-git-send-email-jim@meyering.net>
X-Mailer: git-send-email 1.7.9.5
In-Reply-To: <1333484736-8289-1-git-send-email-jim@meyering.net>
References: <1333484736-8289-1-git-send-email-jim@meyering.net>
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-Mailman-Approved-At: Tue, 03 Apr 2012 16:28:35 -0400
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2012 20:26:15 -0000

From: Jim Meyering <meyering@redhat.com>

Exempt init.sh because it runs before we're assured to have a
shell that groks $(...).  Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run.  Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...).  Do that by running this command:

git grep -l '`.*`' tests \
  | grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
  | xargs perl -pi -e 's/`(.*?)`/\$($1)/g'

One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
-    expected_perms=$(eval 'echo \$expected_'$dest)
+    expected_perms=$(eval 'echo $expected_'$dest)

Also, transform one file that was needlessly excluded above:
(it uses perl, but is mostly bourne shell)

  perl -pi -e 's/`(.*?)`/\$($1)/g' tests/du/long-from-unreadable
---
 tests/chgrp/basic             |   48 +++++++++++++--------------
 tests/chgrp/default-no-deref  |    4 +--
 tests/chgrp/deref             |   18 +++++------
 tests/chgrp/posix-H           |    4 +--
 tests/chgrp/recurse           |   10 +++---
 tests/chmod/c-option          |    2 +-
 tests/chmod/equal-x           |    2 +-
 tests/chmod/equals            |    6 ++--
 tests/chmod/setgid            |    4 +--
 tests/chmod/usage             |    6 ++--
 tests/chown/basic             |   12 +++----
 tests/chown/deref             |    2 +-
 tests/chown/preserve-root     |    8 ++---
 tests/chown/separator         |    8 ++---
 tests/cp/acl                  |   10 +++---
 tests/cp/cp-a-selinux         |    2 +-
 tests/cp/cp-mv-backup         |    2 +-
 tests/cp/cp-mv-enotsup-xattr  |    2 +-
 tests/cp/cp-parents           |   10 +++---
 tests/cp/fail-perm            |    2 +-
 tests/cp/fiemap-empty         |    2 +-
 tests/cp/file-perm-race       |    2 +-
 tests/cp/link-preserve        |   26 +++++++--------
 tests/cp/link-symlink         |    4 +--
 tests/cp/no-deref-link1       |    2 +-
 tests/cp/no-deref-link2       |    2 +-
 tests/cp/no-deref-link3       |    2 +-
 tests/cp/parent-perm-race     |    2 +-
 tests/cp/perm                 |    4 +--
 tests/cp/preserve-gid         |    2 +-
 tests/cp/preserve-link        |    2 +-
 tests/cp/r-vs-symlink         |    2 +-
 tests/cp/same-file            |    2 +-
 tests/cp/sparse               |    4 +--
 tests/cp/special-bits         |   12 +++----
 tests/cp/symlink-slash        |    2 +-
 tests/dd/bytes                |    6 ++--
 tests/dd/misc                 |    6 ++--
 tests/dd/not-rewound          |    2 +-
 tests/dd/skip-seek2           |    4 +--
 tests/du/2g                   |    4 +--
 tests/du/8gb                  |    2 +-
 tests/du/basic                |   26 +++++++--------
 tests/du/deref                |    6 ++--
 tests/du/inaccessible-cwd     |    2 +-
 tests/du/long-from-unreadable |    6 ++--
 tests/du/long-sloop           |    6 ++--
 tests/du/slink                |    2 +-
 tests/install/basic-1         |    4 +--
 tests/install/trap            |    2 +-
 tests/ln/hard-to-sym          |   10 +++---
 tests/ln/misc                 |    2 +-
 tests/ln/sf-1                 |    2 +-
 tests/ls/inode                |   12 +++----
 tests/ls/nameless-uid         |    2 +-
 tests/ls/stat-dtype           |    2 +-
 tests/ls/stat-vs-dirent       |   12 +++----
 tests/ls/symlink-slash        |    2 +-
 tests/misc/close-stdout       |    4 +--
 tests/misc/date-sec           |    6 ++--
 tests/misc/df                 |    2 +-
 tests/misc/env                |   18 +++++------
 tests/misc/head-c             |    2 +-
 tests/misc/ls-time            |   12 +++----
 tests/misc/mknod              |    6 ++--
 tests/misc/nice               |   14 ++++----
 tests/misc/nohup              |    2 +-
 tests/misc/od-multiple-t      |   10 +++---
 tests/misc/runcon-no-reorder  |    2 +-
 tests/misc/selinux            |   10 +++---
 tests/misc/shuf               |    2 +-
 tests/misc/sort-compress      |    2 +-
 tests/misc/sort-merge-fdlimit |    2 +-
 tests/misc/sort-rand          |    2 +-
 tests/misc/stat-fmt           |    6 ++--
 tests/misc/stty               |   12 +++----
 tests/misc/stty-invalid       |    6 ++--
 tests/misc/stty-row-col       |   10 +++---
 tests/misc/tee                |    4 +--
 tests/misc/timeout            |    2 +-
 tests/mkdir/p-1               |    2 +-
 tests/mkdir/p-2               |    2 +-
 tests/mkdir/p-3               |    4 +--
 tests/mkdir/parents           |   12 +++----
 tests/mkdir/perm              |    2 +-
 tests/mkdir/special-1         |    4 +--
 tests/mv/acl                  |   12 +++----
 tests/mv/atomic               |    2 +-
 tests/mv/atomic2              |    2 +-
 tests/mv/childproof           |    8 ++---
 tests/mv/force                |    2 +-
 tests/mv/hard-2               |   12 +++----
 tests/mv/hard-3               |    6 ++--
 tests/mv/hard-link-1          |    4 +--
 tests/mv/i-2                  |    2 +-
 tests/mv/i-3                  |    4 +--
 tests/mv/i-4                  |    2 +-
 tests/mv/i-link-no            |    2 +-
 tests/mv/leak-fd              |    6 ++--
 tests/mv/part-hardlink        |    4 +--
 tests/mv/part-symlink         |   12 +++----
 tests/mv/partition-perm       |    2 +-
 tests/mv/to-symlink           |    2 +-
 tests/mv/update               |   10 +++---
 tests/other-fs-tmpdir         |    4 +--
 tests/readlink/can-e          |   40 +++++++++++------------
 tests/readlink/can-f          |   72 ++++++++++++++++++++---------------------
 tests/readlink/can-m          |   64 ++++++++++++++++++------------------
 tests/readlink/rl-1           |   10 +++---
 tests/rm/hash                 |    2 +-
 tests/rm/inaccessible         |    2 +-
 tests/rm/ir-1                 |    2 +-
 tests/rm/read-only            |    2 +-
 tests/rm/readdir-bug          |    4 +--
 tests/rm/unread3              |    2 +-
 tests/rmdir/ignore            |    2 +-
 tests/tail-2/assert           |    2 +-
 tests/tail-2/assert-2         |    2 +-
 tests/touch/dangling-symlink  |    2 +-
 tests/touch/empty-file        |    6 ++--
 tests/touch/no-dereference    |    4 +--
 tests/touch/no-rights         |    4 +--
 tests/touch/trailing-slash    |    6 ++--
 123 files changed, 422 insertions(+), 422 deletions(-)

diff --git a/tests/chgrp/basic b/tests/chgrp/basic
index 9c384ba..8ce2f2d 100755
--- a/tests/chgrp/basic
+++ b/tests/chgrp/basic
@@ -33,53 +33,53 @@ chgrp -R $g1 d || fail=1

 d_files='d d/f3'

-chgrp $g1 f || fail=1  ; test `stat --p=%g f` = $g1 || fail=1
-chgrp $g2 f || fail=1  ; test `stat --p=%g f` = $g2 || fail=1
-chgrp $g2 f || fail=1  ; test `stat --p=%g f` = $g2 || fail=1
-chgrp '' f  || fail=1  ; test `stat --p=%g f` = $g2 || fail=1
-chgrp $g1 f || fail=1  ; test `stat --p=%g f` = $g1 || fail=1
-chgrp $g1 f || fail=1  ; test `stat --p=%g f` = $g1 || fail=1
-chgrp --reference=f2 f ; test `stat --p=%g f` = $g2 || fail=1
-
-chgrp -R $g2 d ||fail=1; test `stat --p=%g: $d_files` = "$g2:$g2:" || fail=1
-chgrp -R $g1 d ||fail=1; test `stat --p=%g: $d_files` = "$g1:$g1:" || fail=1
-chgrp -R $g2 d ||fail=1; test `stat --p=%g: $d_files` = "$g2:$g2:" || fail=1
-chgrp -R $g1 d ||fail=1; test `stat --p=%g: $d_files` = "$g1:$g1:" || fail=1
-chgrp $g2 d    ||fail=1; test `stat --p=%g: $d_files` = "$g2:$g1:" || fail=1
+chgrp $g1 f || fail=1  ; test $(stat --p=%g f) = $g1 || fail=1
+chgrp $g2 f || fail=1  ; test $(stat --p=%g f) = $g2 || fail=1
+chgrp $g2 f || fail=1  ; test $(stat --p=%g f) = $g2 || fail=1
+chgrp '' f  || fail=1  ; test $(stat --p=%g f) = $g2 || fail=1
+chgrp $g1 f || fail=1  ; test $(stat --p=%g f) = $g1 || fail=1
+chgrp $g1 f || fail=1  ; test $(stat --p=%g f) = $g1 || fail=1
+chgrp --reference=f2 f ; test $(stat --p=%g f) = $g2 || fail=1
+
+chgrp -R $g2 d ||fail=1; test $(stat --p=%g: $d_files) = "$g2:$g2:" || fail=1
+chgrp -R $g1 d ||fail=1; test $(stat --p=%g: $d_files) = "$g1:$g1:" || fail=1
+chgrp -R $g2 d ||fail=1; test $(stat --p=%g: $d_files) = "$g2:$g2:" || fail=1
+chgrp -R $g1 d ||fail=1; test $(stat --p=%g: $d_files) = "$g1:$g1:" || fail=1
+chgrp $g2 d    ||fail=1; test $(stat --p=%g: $d_files) = "$g2:$g1:" || fail=1

 rm -f f
 touch f
 ln -s f symlink
 chgrp $g1 f
-test `stat --printf=%g f` = $g1 || fail=1
+test $(stat --printf=%g f) = $g1 || fail=1

 # This should not change the group of f.
 chgrp -h $g2 symlink
-test `stat --printf=%g f` = $g1 || fail=1
+test $(stat --printf=%g f) = $g1 || fail=1

 # Don't fail if chgrp failed to set the group of a symlink.
 # Some systems don't support that.
-test `stat --printf=%g symlink` = $g2 ||
+test $(stat --printf=%g symlink) = $g2 ||
   echo 'info: failed to set group of symlink' 1>&2

-chown --from=:$g1 :$g2 f; test `stat --printf=%g f` = $g2 || fail=1
+chown --from=:$g1 :$g2 f; test $(stat --printf=%g f) = $g2 || fail=1

 # This *should* change the group of f.
 # Though note that the diagnostic is misleading in that
 # it says the 'group of 'symlink'' has been changed.
-chgrp $g1 symlink; test `stat --printf=%g f` = $g1 || fail=1
-chown --from=:$g1 :$g2 f; test `stat --printf=%g f` = $g2 || fail=1
+chgrp $g1 symlink; test $(stat --printf=%g f) = $g1 || fail=1
+chown --from=:$g1 :$g2 f; test $(stat --printf=%g f) = $g2 || fail=1

 # If -R is specified without -H or L, -h is assumed.
-chgrp -h $g1 f symlink; test `stat --printf=%g symlink` = $g1 || fail=1
+chgrp -h $g1 f symlink; test $(stat --printf=%g symlink) = $g1 || fail=1
 chgrp -R $g2 symlink
-chown --from=:$g1 :$g2 f; test `stat --printf=%g f` = $g2 || fail=1
+chown --from=:$g1 :$g2 f; test $(stat --printf=%g f) = $g2 || fail=1

 # Make sure we can change the group of inaccessible files.
 chmod a-r f
-chown --from=:$g2 :$g1 f; test `stat --printf=%g f` = $g1 || fail=1
+chown --from=:$g2 :$g1 f; test $(stat --printf=%g f) = $g1 || fail=1
 chmod 0 f
-chown --from=:$g1 :$g2 f; test `stat --printf=%g f` = $g2 || fail=1
+chown --from=:$g1 :$g2 f; test $(stat --printf=%g f) = $g2 || fail=1

 # chown() must not be optimized away even when
 # the file's owner and group already have the desired value.
@@ -96,7 +96,7 @@ chgrp $g1 f
 # ctime is more recent.  This is not a big deal;
 # this test works fine when the files are on a local file system (/tmp).
 chgrp '' f
-test "`ls -C -c -t f g`" = 'f  g' || \
+test "$(ls -C -c -t f g)" = 'f  g' || \
   {
     case $host_triplet in
       *openbsd*) echo ignoring known OpenBSD-specific chgrp failure 1>&2 ;;
diff --git a/tests/chgrp/default-no-deref b/tests/chgrp/default-no-deref
index d655307..5d140a8 100755
--- a/tests/chgrp/default-no-deref
+++ b/tests/chgrp/default-no-deref
@@ -26,8 +26,8 @@ g2=$2
 mkdir d && touch f && ln -s ../f d/s || framework_failure_


-g_init=`stat --printf=%g f`
+g_init=$(stat --printf=%g f)
 chgrp -R $g2 d || fail=1
-test `stat --printf=%g f` = $g_init || fail=1
+test $(stat --printf=%g f) = $g_init || fail=1

 Exit $fail
diff --git a/tests/chgrp/deref b/tests/chgrp/deref
index 18946b1..4c186ee 100755
--- a/tests/chgrp/deref
+++ b/tests/chgrp/deref
@@ -28,7 +28,7 @@ touch f
 ln -s f symlink

 chgrp -h $g2 symlink 2> /dev/null
-set _ `ls -ln symlink`
+set _ $(ls -ln symlink)
 g=$5
 test "$g" = $g2 ||
   skip_ "your system doesn't support changing the owner or group" \
@@ -36,25 +36,25 @@ test "$g" = $g2 ||


 chgrp $g1 f
-set _ `ls -ln f`; g=$5; test "$g" = $g1 || fail=1
+set _ $(ls -ln f); g=$5; test "$g" = $g1 || fail=1

 chgrp -h $g2 symlink || fail=1
-set _ `ls -ln f`; g=$5; test "$g" = $g1 || fail=1
-set _ `ls -ln symlink`; g=$5; test "$g" = $g2 || fail=1
+set _ $(ls -ln f); g=$5; test "$g" = $g1 || fail=1
+set _ $(ls -ln symlink); g=$5; test "$g" = $g2 || fail=1

 # This should not change the group of f.
 chgrp -h $g2 symlink || fail=1
-set _ `ls -ln f`; g=$5; test "$g" = $g1 || fail=1
-set _ `ls -ln symlink`; g=$5; test "$g" = $g2 || fail=1
+set _ $(ls -ln f); g=$5; test "$g" = $g1 || fail=1
+set _ $(ls -ln symlink); g=$5; test "$g" = $g2 || fail=1

 chgrp $g2 f
-set _ `ls -ln f`; g=$5; test "$g" = $g2 || fail=1
+set _ $(ls -ln f); g=$5; test "$g" = $g2 || fail=1

 # This *should* change the group of f.
 # Though note that the diagnostic you'd get with -c is misleading in that
 # it says the 'group of 'symlink'' has been changed.
 chgrp --dereference $g1 symlink
-set _ `ls -ln f`; g=$5; test "$g" = $g1 || fail=1
-set _ `ls -ln symlink`; g=$5; test "$g" = $g2 || fail=1
+set _ $(ls -ln f); g=$5; test "$g" = $g1 || fail=1
+set _ $(ls -ln symlink); g=$5; test "$g" = $g2 || fail=1

 Exit $fail
diff --git a/tests/chgrp/posix-H b/tests/chgrp/posix-H
index a6474f5..3965f1f 100755
--- a/tests/chgrp/posix-H
+++ b/tests/chgrp/posix-H
@@ -46,7 +46,7 @@ for i in $changed; do
   # Filter out symlinks (entries that end in 's'), since it's not
   # possible to change their group/owner information on some systems.
   case $i in *s) continue;; esac
-  set _ `ls -dgn $i`; shift
+  set _ $(ls -dgn $i); shift
   group=$3
   test $group = $g2 || fail=1
 done
@@ -62,7 +62,7 @@ for i in $not_changed; do
   # Filter out symlinks (entries that end in 's'), since it's not
   # possible to change their group/owner information on some systems.
   case $i in *s) continue;; esac
-  set _ `ls -dgn $i`; shift
+  set _ $(ls -dgn $i); shift
   group=$3
   test $group = $g1 || fail=1
 done
diff --git a/tests/chgrp/recurse b/tests/chgrp/recurse
index 9f9587b..95a910f 100755
--- a/tests/chgrp/recurse
+++ b/tests/chgrp/recurse
@@ -32,22 +32,22 @@ ln -s ../e d/s
 chgrp -R $g1 e/ee || fail=1
 # This should not should change the group of e/ee
 chgrp -R $g2 d
-set _ `ls -ln e/ee`; g=$5; test "$g" = $g1 || fail=1
+set _ $(ls -ln e/ee); g=$5; test "$g" = $g1 || fail=1
 # This must change the group of e/ee, since -L makes
 # chgrp traverse the symlink from d/s into e.
 chgrp -L -R $g2 d
-set _ `ls -ln e/ee`; g=$5; test "$g" = $g2 || fail=1
+set _ $(ls -ln e/ee); g=$5; test "$g" = $g2 || fail=1

 # This must *not* change the group of e/ee
 chgrp -H -R $g1 d
-set _ `ls -ln e/ee`; g=$5; test "$g" = $g2 || fail=1
+set _ $(ls -ln e/ee); g=$5; test "$g" = $g2 || fail=1

 ln -s d link

 # This shouldn't change the group of e/ee either.
 chgrp -H -R $g1 link || fail=1
-set _ `ls -ln e/ee`; g=$5; test "$g" = $g2 || fail=1
+set _ $(ls -ln e/ee); g=$5; test "$g" = $g2 || fail=1
 # But it *should* change d/dd.
-set _ `ls -ln d/dd`; g=$5; test "$g" = $g1 || fail=1
+set _ $(ls -ln d/dd); g=$5; test "$g" = $g1 || fail=1

 Exit $fail
diff --git a/tests/chmod/c-option b/tests/chmod/c-option
index 9235b52..0fc8391 100755
--- a/tests/chmod/c-option
+++ b/tests/chmod/c-option
@@ -32,7 +32,7 @@ chmod -c g=rwx $file > out || fail=1
 chmod -c g=rwx $file > empty || fail=1

 test -s empty && fail=1
-case "`cat out`" in
+case "$(cat out)" in
   "mode of 'f' changed from 0744 "?rwxr--r--?" to 0774 "?rwxrwxr--?) ;;
   *) cat out; fail=1 ;;
 esac
diff --git a/tests/chmod/equal-x b/tests/chmod/equal-x
index d2998d1..e2cac34 100755
--- a/tests/chmod/equal-x
+++ b/tests/chmod/equal-x
@@ -25,7 +25,7 @@ touch $file || framework_failure_
 umask 005
 for mode in =x =xX =Xx =x,=X =X,=x; do
   chmod a=r,$mode $file || fail=1
-  case "`ls -l $file`" in
+  case "$(ls -l $file)" in
     ---x--x---*) ;;
     *) fail=1; echo "after 'chmod $mode $file':"; ls -l $file ;;
   esac
diff --git a/tests/chmod/equals b/tests/chmod/equals
index 54c39ae..fd92055 100755
--- a/tests/chmod/equals
+++ b/tests/chmod/equals
@@ -32,15 +32,15 @@ for src in u g o; do
   for dest in u g o; do
     test $dest = $src && continue
     chmod a=,$src=rwx,$dest=$src,$src= f || fail=1
-    actual_perms=`ls -l f|cut -b-10`
-    expected_perms=`eval 'echo \$expected_'$dest`
+    actual_perms=$(ls -l f|cut -b-10)
+    expected_perms=$(eval 'echo $expected_'$dest)
     test "$actual_perms" = "$expected_perms" || fail=1
   done
 done

 umask 027
 chmod a=,u=rwx,=u f || fail=1
-actual_perms=`ls -l f|cut -b-10`
+actual_perms=$(ls -l f|cut -b-10)
 test "$actual_perms" = "-rwxr-x---" || fail=1

 Exit $fail
diff --git a/tests/chmod/setgid b/tests/chmod/setgid
index 081c36e..7fc6db2 100755
--- a/tests/chmod/setgid
+++ b/tests/chmod/setgid
@@ -31,7 +31,7 @@ chmod g+s d 2> /dev/null && env -- test -g d ||
     # to which you belong.  When that happens, the above chmod fails.  So
     # here, upon failure, we try to set the group, then rerun the chmod command.

-    id_g=`id -g` &&
+    id_g=$(id -g) &&
     test -n "$id_g" &&
     chgrp "$id_g" d &&
     chmod g+s d || framework_failure_
@@ -52,7 +52,7 @@ do
        expected_mode=drwxr-xr-x ;;
     *) expected_mode=drwxr-sr-x ;;
   esac
-  ls_output=`ls -ld d`
+  ls_output=$(ls -ld d)
   case $ls_output in
     $expected_mode*) ;;
     *) fail=1 ;;
diff --git a/tests/chmod/usage b/tests/chmod/usage
index 3a4d1b8..9dd65f7 100755
--- a/tests/chmod/usage
+++ b/tests/chmod/usage
@@ -54,15 +54,15 @@ cases='
   ug,+x f    :
 '

-all_files=`echo "$cases" | sed 's/.*://'|sort -u`
+all_files=$(echo "$cases" | sed 's/.*://'|sort -u)

 old_IFS=$IFS
 IFS='
 '
 for case in $cases; do
   IFS=$old_IFS
-  args=`expr "$case" : ' *\(.*[^ ]\) *:'`
-  files=`expr "$case" : '.*: *\(.*\)'`
+  args=$(expr "$case" : ' *\(.*[^ ]\) *:')
+  files=$(expr "$case" : '.*: *\(.*\)')

   case $files in
   '')
diff --git a/tests/chown/basic b/tests/chown/basic
index 98145da..7c8951c 100755
--- a/tests/chown/basic
+++ b/tests/chown/basic
@@ -25,12 +25,12 @@ touch f || framework_failure_
 chown -R --preserve-root 0:1 f

 # Make sure the owner and group are 0 and 1 respectively.
-set _ `ls -n f`; shift; test "$3:$4" = 0:1 || fail=1
+set _ $(ls -n f); shift; test "$3:$4" = 0:1 || fail=1

 # Make sure the correct diagnostic is output
 # Note we output a name even though an id was specified.
 chown -v --from=42 43 f > out || fail=1
-printf "ownership of 'f' retained as `id -nu`\n" > exp
+printf "ownership of 'f' retained as $(id -nu)\n" > exp
 compare exp out || fail=1

 # Ensure diagnostics work for non existent files.
@@ -41,19 +41,19 @@ compare exp out || fail=1
 chown --from=0:1 2:010 f || fail=1

 # And now they should be 2 and 10 respectively.
-set _ `ls -n f`; shift; test "$3:$4" = 2:10 || fail=1
+set _ $(ls -n f); shift; test "$3:$4" = 2:10 || fail=1

 ln -s f slink
 # Applying chown to a symlink with --no-dereference
 # should change only the link.
 chown --no-dereference 0:1 slink || fail=1
 # owner/group on the symlink should be set
-set _ `ls -n slink`; shift; test "$3:$4" = 0:1 || fail=1
+set _ $(ls -n slink); shift; test "$3:$4" = 0:1 || fail=1
 # owner/group on the referent should remain unchanged
-set _ `ls -n f`;     shift; test "$3:$4" = 2:10 || fail=1
+set _ $(ls -n f);     shift; test "$3:$4" = 2:10 || fail=1

 chown --no-dereference --from=0:1 2:010 slink || fail=1
 # owner/group on the symlink should be changed
-set _ `ls -n slink`; shift; test "$3:$4" = 2:10 || fail=1
+set _ $(ls -n slink); shift; test "$3:$4" = 2:10 || fail=1

 Exit $fail
diff --git a/tests/chown/deref b/tests/chown/deref
index 9ba2806..d42a054 100755
--- a/tests/chown/deref
+++ b/tests/chown/deref
@@ -23,7 +23,7 @@ print_ver_ chown
 ln -s no-such dangle || framework_failure_


-set _ `ls -ldo dangle`; shift; user=$3
+set _ $(ls -ldo dangle); shift; user=$3

 # With 5.2.1 and earlier, this command would mistakenly succeed.
 chown --dereference $user dangle 2> out1 && fail=1
diff --git a/tests/chown/preserve-root b/tests/chown/preserve-root
index a9145b7..ffad222 100755
--- a/tests/chown/preserve-root
+++ b/tests/chown/preserve-root
@@ -38,13 +38,13 @@ chmod -R --preserve-root u+r / >> out 2>&1 && fail=1
 # since the symlink in question is not a command line argument.
 # Contrary to the above commands, these two should succeed.
 echo '==== test -RHh' >> out
-chown -RHh --preserve-root `id -u` d >> out 2>&1 || fail=1
-chgrp -RHh --preserve-root `id -g` d >> out 2>&1 || fail=1
+chown -RHh --preserve-root $(id -u) d >> out 2>&1 || fail=1
+chgrp -RHh --preserve-root $(id -g) d >> out 2>&1 || fail=1

 # These must fail.
 echo '==== test -RLh' >> out
-chown -RLh --preserve-root `id -u` d >> out 2>&1 && fail=1
-chgrp -RLh --preserve-root `id -g` d >> out 2>&1 && fail=1
+chown -RLh --preserve-root $(id -u) d >> out 2>&1 && fail=1
+chgrp -RLh --preserve-root $(id -g) d >> out 2>&1 && fail=1

 cat <<\EOF > exp || fail=1
 chown: it is dangerous to operate recursively on '/'
diff --git a/tests/chown/separator b/tests/chown/separator
index 6295fd7..d4264a8 100755
--- a/tests/chown/separator
+++ b/tests/chown/separator
@@ -19,16 +19,16 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ chown

-id_u=`id -u` || framework_failure_
+id_u=$(id -u) || framework_failure_
 test -n "$id_u" || framework_failure_

-id_un=`id -un` || framework_failure_
+id_un=$(id -un) || framework_failure_
 test -n "$id_un" || framework_failure_

-id_g=`id -g` || framework_failure_
+id_g=$(id -g) || framework_failure_
 test -n "$id_g" || framework_failure_

-id_gn=`id -gn` || framework_failure_
+id_gn=$(id -gn) || framework_failure_
 test -n "$id_gn" || framework_failure_

 # FreeBSD 6.x's getgrnam fails to look up a group name containing
diff --git a/tests/cp/acl b/tests/cp/acl
index 94b7af6..26a7f42 100755
--- a/tests/cp/acl
+++ b/tests/cp/acl
@@ -31,22 +31,22 @@ touch a/file || framework_failure_

 # Ensure that setfacl and getfacl work on this file system.
 skip=no
-acl1=`cd a && getfacl file` || skip=yes
+acl1=$(cd a && getfacl file) || skip=yes
 setfacl -m user:bin:rw- a/file 2> /dev/null || skip=yes
 test $skip = yes &&
   skip_ "'.' is not on a suitable file system for this test"

 # copy a file without preserving permissions
 cp a/file b/ || fail=1
-acl2=`cd b && getfacl file` || framework_failure_
+acl2=$(cd b && getfacl file) || framework_failure_
 test "$acl1" = "$acl2" || fail=1

 # Update with acl set above
-acl1=`cd a && getfacl file` || framework_failure_
+acl1=$(cd a && getfacl file) || framework_failure_

 # copy a file, preserving permissions
 cp -p a/file b/ || fail=1
-acl2=`cd b && getfacl file` || framework_failure_
+acl2=$(cd b && getfacl file) || framework_failure_
 test "$acl1" = "$acl2" || fail=1

 # copy a file, preserving permissions, with --attributes-only
@@ -54,7 +54,7 @@ echo > a/file || framework_failure_ # add some data
 test -s a/file || framework_failure_
 cp -p --attributes-only a/file b/ || fail=1
 test -s b/file && fail=1
-acl2=`cd b && getfacl file` || framework_failure_
+acl2=$(cd b && getfacl file) || framework_failure_
 test "$acl1" = "$acl2" || fail=1

 Exit $fail
diff --git a/tests/cp/cp-a-selinux b/tests/cp/cp-a-selinux
index 1175817..b852984 100755
--- a/tests/cp/cp-a-selinux
+++ b/tests/cp/cp-a-selinux
@@ -24,7 +24,7 @@ print_ver_ cp
 require_root_
 require_selinux_

-cwd=`pwd`
+cwd=$(pwd)
 cleanup_() { cd /; umount "$cwd/mnt"; }

 # This context is special: it works even when mcstransd isn't running.
diff --git a/tests/cp/cp-mv-backup b/tests/cp/cp-mv-backup
index 3e6b6ff..030f722 100755
--- a/tests/cp/cp-mv-backup
+++ b/tests/cp/cp-mv-backup
@@ -35,7 +35,7 @@ for prog in cp mv; do
     for opt in none off  numbered t  existing nil  simple never; do
       touch $initial_files
         $prog --backup=$opt x y || fail=1
-      echo $initial_files $opt: `ls [xy]*`; rm -f x y y~ y.~?~
+      echo $initial_files $opt: $(ls [xy]*); rm -f x y y~ y.~?~
     done
   done
 done
diff --git a/tests/cp/cp-mv-enotsup-xattr b/tests/cp/cp-mv-enotsup-xattr
index 76ede2e..66e54cf 100755
--- a/tests/cp/cp-mv-enotsup-xattr
+++ b/tests/cp/cp-mv-enotsup-xattr
@@ -23,7 +23,7 @@ print_ver_ cp mv

 require_root_

-cwd=`pwd`
+cwd=$(pwd)
 cleanup_() { cd /; umount "$cwd/noxattr"; umount "$cwd/xattr"; }

 skip=0
diff --git a/tests/cp/cp-parents b/tests/cp/cp-parents
index 85fccd6..b325c72 100755
--- a/tests/cp/cp-parents
+++ b/tests/cp/cp-parents
@@ -49,10 +49,10 @@ test -d d/f && fail=1
 chmod go=w d/a || framework_failure_
 cp -a --parents d/a/b/c e || fail=1
 cp -a --parents sym/b/c g || fail=1
-p=`ls -ld e/d|cut -b-10`; case $p in drwxr-xr-x);; *) fail=1;; esac
-p=`ls -ld e/d/a|cut -b-10`; case $p in drwx-w--w-);; *) fail=1;; esac
-p=`ls -ld g/sym|cut -b-10`; case $p in drwx-w--w-);; *) fail=1;; esac
-p=`ls -ld e/d/a/b/c|cut -b-10`; case $p in drwxr-xr-x);; *) fail=1;; esac
-p=`ls -ld g/sym/b/c|cut -b-10`; case $p in drwxr-xr-x);; *) fail=1;; esac
+p=$(ls -ld e/d|cut -b-10); case $p in drwxr-xr-x);; *) fail=1;; esac
+p=$(ls -ld e/d/a|cut -b-10); case $p in drwx-w--w-);; *) fail=1;; esac
+p=$(ls -ld g/sym|cut -b-10); case $p in drwx-w--w-);; *) fail=1;; esac
+p=$(ls -ld e/d/a/b/c|cut -b-10); case $p in drwxr-xr-x);; *) fail=1;; esac
+p=$(ls -ld g/sym/b/c|cut -b-10); case $p in drwxr-xr-x);; *) fail=1;; esac

 Exit $fail
diff --git a/tests/cp/fail-perm b/tests/cp/fail-perm
index 3835f6b..2c37d6f 100755
--- a/tests/cp/fail-perm
+++ b/tests/cp/fail-perm
@@ -31,7 +31,7 @@ cp -pR D DD > /dev/null 2>&1 && fail=1

 # Permissions on DD must be 'dr-x------'

-mode=`ls -ld DD|cut -b-10`
+mode=$(ls -ld DD|cut -b-10)
 test "$mode" = dr-x------ || fail=1

 chmod 0 D
diff --git a/tests/cp/fiemap-empty b/tests/cp/fiemap-empty
index efa4b66..4ba4ee3 100755
--- a/tests/cp/fiemap-empty
+++ b/tests/cp/fiemap-empty
@@ -29,7 +29,7 @@ fiemap_capable_ fiemap_chk ||
   skip_ 'this file system lacks FIEMAP support'
 rm fiemap_chk

-# TODO: rather than requiring `fallocate`, possible add
+# TODO: rather than requiring $(fallocate), possible add
 # this functionality to truncate --alloc
 fallocate --help >/dev/null || skip_ 'The fallocate utility is required'
 fallocate -l 1 -n falloc.test ||
diff --git a/tests/cp/file-perm-race b/tests/cp/file-perm-race
index 46db6f9..fbc9a86 100755
--- a/tests/cp/file-perm-race
+++ b/tests/cp/file-perm-race
@@ -46,7 +46,7 @@ cp_pid=$!
   echo foo
 ) >fifo

-case `cat ls.out` in
+case $(cat ls.out) in
 -???------*) ;;
 *) fail=1;;
 esac
diff --git a/tests/cp/link-preserve b/tests/cp/link-preserve
index 785c9e4..9ca1705 100755
--- a/tests/cp/link-preserve
+++ b/tests/cp/link-preserve
@@ -28,8 +28,8 @@ test -f c/a || framework_failure_
 test -f c/b || framework_failure_


-a_inode=`ls -i c/a|sed 's,c/.*,,'`
-b_inode=`ls -i c/b|sed 's,c/.*,,'`
+a_inode=$(ls -i c/a|sed 's,c/.*,,')
+b_inode=$(ls -i c/b|sed 's,c/.*,,')
 test "$a_inode" = "$b_inode" || fail=1
 # --------------------------------------

@@ -38,8 +38,8 @@ touch a
 ln -s a b
 mkdir c
 cp --preserve=links -R -H a b c
-a_inode=`ls -i c/a|sed 's,c/.*,,'`
-b_inode=`ls -i c/b|sed 's,c/.*,,'`
+a_inode=$(ls -i c/a|sed 's,c/.*,,')
+b_inode=$(ls -i c/b|sed 's,c/.*,,')
 test "$a_inode" = "$b_inode" || fail=1
 # --------------------------------------

@@ -47,24 +47,24 @@ test "$a_inode" = "$b_inode" || fail=1
 # and translates to hard-linked a and b in the destination dir.
 rm -rf a b c d; mkdir d; (cd d; touch a; ln -s a b)
 cp --preserve=links -R -L d c
-a_inode=`ls -i c/a|sed 's,c/.*,,'`
-b_inode=`ls -i c/b|sed 's,c/.*,,'`
+a_inode=$(ls -i c/a|sed 's,c/.*,,')
+b_inode=$(ls -i c/b|sed 's,c/.*,,')
 test "$a_inode" = "$b_inode" || fail=1
 # --------------------------------------

 # Same as above, but starting with a/b hard linked.
 rm -rf a b c d; mkdir d; (cd d; touch a; ln a b)
 cp --preserve=links -R -L d c
-a_inode=`ls -i c/a|sed 's,c/.*,,'`
-b_inode=`ls -i c/b|sed 's,c/.*,,'`
+a_inode=$(ls -i c/a|sed 's,c/.*,,')
+b_inode=$(ls -i c/b|sed 's,c/.*,,')
 test "$a_inode" = "$b_inode" || fail=1
 # --------------------------------------

 # Ensure that --no-preserve=links works.
 rm -rf a b c d; mkdir d; (cd d; touch a; ln a b)
 cp -dR --no-preserve=links d c
-a_inode=`ls -i c/a|sed 's,c/.*,,'`
-b_inode=`ls -i c/b|sed 's,c/.*,,'`
+a_inode=$(ls -i c/a|sed 's,c/.*,,')
+b_inode=$(ls -i c/b|sed 's,c/.*,,')
 test "$a_inode" = "$b_inode" && fail=1
 # --------------------------------------

@@ -73,8 +73,8 @@ rm -rf a b c d
 touch a; ln a b
 mkdir c
 cp -d a b c
-a_inode=`ls -i c/a|sed 's,c/.*,,'`
-b_inode=`ls -i c/b|sed 's,c/.*,,'`
+a_inode=$(ls -i c/a|sed 's,c/.*,,')
+b_inode=$(ls -i c/b|sed 's,c/.*,,')
 test "$a_inode" = "$b_inode" || fail=1
 # --------------------------------------

@@ -83,7 +83,7 @@ rm -rf a b c d
 touch a; chmod 731 a
 umask 077
 cp -a --no-preserve=mode a b
-mode=`ls -l b|cut -b-10`
+mode=$(ls -l b|cut -b-10)
 test "$mode" = "-rwx------" || fail=1
 umask 022
 # --------------------------------------
diff --git a/tests/cp/link-symlink b/tests/cp/link-symlink
index 97fbf4b..57bc9c7 100755
--- a/tests/cp/link-symlink
+++ b/tests/cp/link-symlink
@@ -25,7 +25,7 @@ touch file
 ln -s file link || framework_failure_
 touch -m -h -d 2011-01-01 link ||
   skip_ "Your system doesn't support updating symlink timestamps"
-case `stat --format=%y link` in
+case $(stat --format=%y link) in
   2011-01-01*) ;;
   *) skip_ "Your system doesn't support updating symlink timestamps" ;;
 esac
@@ -33,7 +33,7 @@ esac
 # link.cp is probably a hardlink, but may also be a symlink
 # In either case the timestamp should match the original.
 cp -al link link.cp
-case `stat --format=%y link.cp` in
+case $(stat --format=%y link.cp) in
   2011-01-01*) ;;
   *) fail=1 ;;
 esac
diff --git a/tests/cp/no-deref-link1 b/tests/cp/no-deref-link1
index 8600b8e..c2a5657 100755
--- a/tests/cp/no-deref-link1
+++ b/tests/cp/no-deref-link1
@@ -34,6 +34,6 @@ cp -d a/foo b 2>/dev/null
 # Fail this test if the exit status is not 1
 test $? = 1 || fail=1

-test "`cat a/foo`" = $msg || fail=1
+test "$(cat a/foo)" = $msg || fail=1

 Exit $fail
diff --git a/tests/cp/no-deref-link2 b/tests/cp/no-deref-link2
index 96d444f..5840299 100755
--- a/tests/cp/no-deref-link2
+++ b/tests/cp/no-deref-link2
@@ -34,6 +34,6 @@ cp -d a b 2>/dev/null
 # Fail this test if the exit status is not 1
 test $? = 1 || fail=1

-test "`cat a`" = $msg || fail=1
+test "$(cat a)" = $msg || fail=1

 Exit $fail
diff --git a/tests/cp/no-deref-link3 b/tests/cp/no-deref-link3
index 629f2ae..5f63f26 100755
--- a/tests/cp/no-deref-link3
+++ b/tests/cp/no-deref-link3
@@ -31,6 +31,6 @@ cp -d a b 2>/dev/null
 # Fail this test if the exit status is not 1
 test $? = 1 || fail=1

-test "`cat a`" = $msg || fail=1
+test "$(cat a)" = $msg || fail=1

 Exit $fail
diff --git a/tests/cp/parent-perm-race b/tests/cp/parent-perm-race
index 4eb79bb..41486fc 100755
--- a/tests/cp/parent-perm-race
+++ b/tests/cp/parent-perm-race
@@ -48,7 +48,7 @@ do
     echo foo
   ) >$attr/fifo

-  ls_output=`cat d/$attr.ls` || fail=1
+  ls_output=$(cat d/$attr.ls) || fail=1
   case $attr,$ls_output in
   ownership,d???--[-S]--[-S]* | \
   mode,d????-??-?* | \
diff --git a/tests/cp/perm b/tests/cp/perm
index 2e6126d..eb3925d 100755
--- a/tests/cp/perm
+++ b/tests/cp/perm
@@ -49,8 +49,8 @@ for u in 31 37 2; do

             case "$cmd:$force:$existing_dest" in
               cp:*:yes)
-                _g_perm=`echo rwx|sed 's/[^'$g_perm']/-/g'`
-                _o_perm=`echo rwx|sed 's/[^'$o_perm']/-/g'`
+                _g_perm=$(echo rwx|sed 's/[^'$g_perm']/-/g')
+                _o_perm=$(echo rwx|sed 's/[^'$o_perm']/-/g')
                 expected_perms=-rw-$_g_perm$_o_perm
                 ;;
               cp:*:no)
diff --git a/tests/cp/preserve-gid b/tests/cp/preserve-gid
index 355db4d..6f371c3 100755
--- a/tests/cp/preserve-gid
+++ b/tests/cp/preserve-gid
@@ -39,7 +39,7 @@ t0() {
   g=$1; shift
   rm -f b || exit 1
   "$@" "$f" b || exit 1
-  s=`stat -c '%u %g' b`
+  s=$(stat -c '%u %g' b)
   if test "x$s" != "x$u $g"; then
     # Allow the actual group to match that of the parent directory
     # (it was set to 0 above).
diff --git a/tests/cp/preserve-link b/tests/cp/preserve-link
index df1d8c5..5f069af 100755
--- a/tests/cp/preserve-link
+++ b/tests/cp/preserve-link
@@ -68,7 +68,7 @@ create_target_tree()

 # Note we repeat this, creating either one of
 # two hard linked files from source in the dest, so as to
-# test both paths in `cp` for creating the hard links.
+# test both paths in $(cp) for creating the hard links.
 # The path taken by cp is dependent on which cp encounters
 # first in the source, which is non deterministic currently
 # (I'm guessing that results are sorted by inode and
diff --git a/tests/cp/r-vs-symlink b/tests/cp/r-vs-symlink
index 15616ff..e96c584 100755
--- a/tests/cp/r-vs-symlink
+++ b/tests/cp/r-vs-symlink
@@ -32,7 +32,7 @@ ln -s no-such-file no-file || framework_failure_
 cp -r no-file junk 2>/dev/null || fail=1

 cp -r slink bar 2>/dev/null || fail=1
-set x `ls -l bar`; shift; mode=$1
+set x $(ls -l bar); shift; mode=$1
 case $mode in
   l*) ;;
   *) fail=1;;
diff --git a/tests/cp/same-file b/tests/cp/same-file
index d5abfe8..dbd4d01 100755
--- a/tests/cp/same-file
+++ b/tests/cp/same-file
@@ -111,7 +111,7 @@ for args in 'foo symlink' 'symlink foo' 'foo foo' 'sl1 sl2' 'foo hardlink'; do
         # the destination is a copy.
         for f in $args; do
           if test -f $f; then
-            case "`cat $f`" in
+            case "$(cat $f)" in
               "$contents") ;;
               *) echo cp FAILED;;
             esac
diff --git a/tests/cp/sparse b/tests/cp/sparse
index f1633ae..a552028 100755
--- a/tests/cp/sparse
+++ b/tests/cp/sparse
@@ -24,14 +24,14 @@ require_sparse_support_
 # It has to be at least 128K in order to be sparse on some systems.
 # Make its size one larger than 128K, in order to tickle the
 # bug in coreutils-6.0.
-size=`expr 128 \* 1024 + 1`
+size=$(expr 128 \* 1024 + 1)
 dd bs=1 seek=$size of=sparse < /dev/null 2> /dev/null || framework_failure_


 cp --sparse=always sparse copy || fail=1

 # Ensure that the copy has the same block count as the original.
-test `stat --printf %b copy` -le `stat --printf %b sparse` || fail=1
+test $(stat --printf %b copy) -le $(stat --printf %b sparse) || fail=1

 # Ensure that --sparse={always,never} with --reflink fail.
 cp --sparse=always --reflink sparse copy && fail=1
diff --git a/tests/cp/special-bits b/tests/cp/special-bits
index 4079510..4a00891 100755
--- a/tests/cp/special-bits
+++ b/tests/cp/special-bits
@@ -33,18 +33,18 @@ chmod u=rwx,g=rx,o=rx . || framework_failure_


 cp -p a a2 || fail=1
-set _ `ls -l a`; shift; p1=$1
-set _ `ls -l a2`; shift; p2=$1
+set _ $(ls -l a); shift; p1=$1
+set _ $(ls -l a2); shift; p2=$1
 test $p1 = $p2 || fail=1

 cp -p b b2 || fail=1
-set _ `ls -l b`; shift; p1=$1
-set _ `ls -l b2`; shift; p2=$1
+set _ $(ls -l b); shift; p1=$1
+set _ $(ls -l b2); shift; p2=$1
 test $p1 = $p2 || fail=1

 setuidgid $NON_ROOT_USERNAME env PATH="$PATH" cp -p c c2 || fail=1
-set _ `ls -l c`; shift; p1=$1
-set _ `ls -l c2`; shift; p2=$1
+set _ $(ls -l c); shift; p1=$1
+set _ $(ls -l c2); shift; p2=$1
 test $p1 = $p2 && fail=1

 Exit $fail
diff --git a/tests/cp/symlink-slash b/tests/cp/symlink-slash
index 0b32b95..95c9cfa 100755
--- a/tests/cp/symlink-slash
+++ b/tests/cp/symlink-slash
@@ -24,7 +24,7 @@ mkdir dir || framework_failure_
 ln -s dir symlink || framework_failure_

 cp -dR symlink/ s || fail=1
-set `ls -l s`
+set $(ls -l s)

 # Prior to fileutils-4.0q, the following would have output ...'s -> dir'
 # because the trailing slash was removed unconditionally (now you have to
diff --git a/tests/dd/bytes b/tests/dd/bytes
index 15755aa..2d40f06 100755
--- a/tests/dd/bytes
+++ b/tests/dd/bytes
@@ -21,7 +21,7 @@ print_ver_ dd
 # count_bytes
 echo 0123456789abcdefghijklm > in || framework_failure_
 dd count=14 conv=swab iflag=count_bytes < in > out 2> /dev/null || fail=1
-case `cat out` in
+case $(cat out) in
  1032547698badc) ;;
  *) fail=1 ;;
 esac
@@ -29,7 +29,7 @@ esac
 # skip_bytes
 echo 0123456789abcdefghijklm > in || framework_failure_
 dd skip=10 iflag=skip_bytes < in > out 2> /dev/null || fail=1
-case `cat out` in
+case $(cat out) in
  abcdefghijklm) ;;
  *) fail=1 ;;
 esac
@@ -37,7 +37,7 @@ esac
 # skip records and bytes from pipe
 echo 0123456789abcdefghijklm |
  dd skip=10 bs=2 iflag=skip_bytes > out 2> /dev/null || fail=1
-case `cat out` in
+case $(cat out) in
  abcdefghijklm) ;;
  *) fail=1 ;;
 esac
diff --git a/tests/dd/misc b/tests/dd/misc
index aad04dc..52a5b20 100755
--- a/tests/dd/misc
+++ b/tests/dd/misc
@@ -57,10 +57,10 @@ if dd iflag=directory if=. count=0 2> /dev/null; then
   dd iflag=directory count=0 <$tmp_in 2> /dev/null && fail=1
 fi

-old_ls=`ls -u --full-time $tmp_in`
+old_ls=$(ls -u --full-time $tmp_in)
 sleep 1
 if dd iflag=noatime if=$tmp_in of=$tmp_out 2> /dev/null; then
-  new_ls=`ls -u --full-time $tmp_in`
+  new_ls=$(ls -u --full-time $tmp_in)
   if test "x$old_ls" != "x$new_ls"; then
     cat >&2 <<EOF
 =================================================================
@@ -80,7 +80,7 @@ if dd oflag=nolinks if=$tmp_in of=$tmp_out 2> /dev/null; then
   dd oflag=nolinks < $tmp_in > $tmp_out 2>&1 || fail=1
 fi

-outbytes=`echo x | dd bs=3 ibs=10 obs=10 conv=sync 2>/dev/null | wc -c`
+outbytes=$(echo x | dd bs=3 ibs=10 obs=10 conv=sync 2>/dev/null | wc -c)
 test "$outbytes" -eq 3 || fail=1

 # A delay is required to trigger a failure.
diff --git a/tests/dd/not-rewound b/tests/dd/not-rewound
index 284dd4a..5364f90 100755
--- a/tests/dd/not-rewound
+++ b/tests/dd/not-rewound
@@ -23,7 +23,7 @@ print_ver_ dd

 echo abcde > in
 (dd skip=1 count=1 bs=1; dd skip=1 bs=1) < in > out 2> /dev/null || fail=1
-case `cat out` in
+case $(cat out) in
   bde) ;;
   *) fail=1 ;;
 esac
diff --git a/tests/dd/skip-seek2 b/tests/dd/skip-seek2
index e1d3edb..7f5e056 100755
--- a/tests/dd/skip-seek2
+++ b/tests/dd/skip-seek2
@@ -23,14 +23,14 @@ print_ver_ dd

 echo LA:3456789abcdef > in || fail=1
 (dd bs=1 skip=3 count=0 && dd bs=5) < in > out 2> /dev/null || fail=1
-case `cat out` in
+case $(cat out) in
   3456789abcdef) ;;
   *) fail=1 ;;
 esac

 echo LA:3456789abcdef > in || fail=1
 (dd bs=1 skip=3 count=0 && dd bs=5 count=2) < in > out 2> /dev/null || fail=1
-case `cat out` in
+case $(cat out) in
   3456789abc) ;;
   *) fail=1 ;;
 esac
diff --git a/tests/du/2g b/tests/du/2g
index a901ddb..96cf62d 100755
--- a/tests/du/2g
+++ b/tests/du/2g
@@ -30,7 +30,7 @@ very_expensive_

 # This technique relies on the fact that the 'Available' kilobyte
 # count is the number just before the one with a trailing '%'.
-free_kb=`df -kP .|tail -1|sed 's/ [0-9][0-9]*%.*//;s/ *$//;s/.* //'`
+free_kb=$(df -kP .|tail -1|sed 's/ [0-9][0-9]*%.*//;s/ *$//;s/.* //')
 case "$free_kb" in
   [0-9]*) ;;
   *) skip_ "invalid size from df: $free_kb";;
@@ -47,7 +47,7 @@ test $min_kb -lt $free_kb ||
 big=big
 rm -f $big
 test -t 1 || printf 'creating a 2GB file...\n'
-for i in `seq 100`; do
+for i in $(seq 100); do
   # Note: 2147483648 == 2^31. Print floor(2^31/100) per iteration.
   printf %21474836s x >> $big || fail=1
   # On the final iteration, append the remaining 48 bytes.
diff --git a/tests/du/8gb b/tests/du/8gb
index 2028d90..556423e 100755
--- a/tests/du/8gb
+++ b/tests/du/8gb
@@ -32,7 +32,7 @@ fi
 # the 'dd' command above mistakenly creates a file of length '0', yet
 # doesn't fail.  The root of that failure is that the ftruncate call
 # returns zero but doesn't do its job.  Detect this failure.
-set x `ls -gG big`
+set x $(ls -gG big)
 size=$4
 if test "$size" = 0; then
   skip_ "cannot create a file large enough for this test
diff --git a/tests/du/basic b/tests/du/basic
index bb0980e..d8acf64 100755
--- a/tests/du/basic
+++ b/tests/du/basic
@@ -29,7 +29,7 @@ printf %4096s x > d/1
 cp d/1 d/sub/2


-B=`stat --format=%B a/b/F`
+B=$(stat --format=%B a/b/F)

 du --block-size=$B -a a > out || fail=1
 echo === >> out
@@ -37,11 +37,11 @@ du --block-size=$B -a -S a >> out || fail=1
 echo === >> out
 du --block-size=$B -s a >> out || fail=1

-f=`stat --format=%b a/b/F`
-b=`stat --format=%b a/b`
-a=`stat --format=%b a`
-bf=`expr $b + $f`
-tot=`expr $bf + $a`
+f=$(stat --format=%b a/b/F)
+b=$(stat --format=%b a/b)
+a=$(stat --format=%b a)
+bf=$(expr $b + $f)
+tot=$(expr $bf + $a)

 cat <<EOF | sed 's/ *#.*//' > exp
 $f	a/b/F
@@ -65,13 +65,13 @@ if is_local_dir_ .; then
   echo === >> out
   du --block-size=$B -S d | sort -r -k2,2 >> out || fail=1

-  t2=`stat --format=%b d/sub/2`
-  ts=`stat --format=%b d/sub`
-  t1=`stat --format=%b d/1`
-  td=`stat --format=%b d`
-  tot=`expr $t1 + $t2 + $ts + $td`
-  d1=`expr $td + $t1`
-  s2=`expr $ts + $t2`
+  t2=$(stat --format=%b d/sub/2)
+  ts=$(stat --format=%b d/sub)
+  t1=$(stat --format=%b d/1)
+  td=$(stat --format=%b d)
+  tot=$(expr $t1 + $t2 + $ts + $td)
+  d1=$(expr $td + $t1)
+  s2=$(expr $ts + $t2)

   cat <<EOF | sed 's/ *#.*//' > exp
 $t2	d/sub/2
diff --git a/tests/du/deref b/tests/du/deref
index bf2ead4..90b7650 100755
--- a/tests/du/deref
+++ b/tests/du/deref
@@ -39,9 +39,9 @@ du -L dangle > /dev/null 2>&1 && fail=1
 # du -L used to mess up, either by counting the symlink's disk space itself
 # (-L should follow symlinks, not count their space)
 # or (briefly in July 2010) by omitting the entry for "a".
-du_L_output=`du -L a` || fail=1
-du_lL_output=`du -lL a` || fail=1
-du_x_output=`du --exclude=dotdot a` || fail=1
+du_L_output=$(du -L a) || fail=1
+du_lL_output=$(du -lL a) || fail=1
+du_x_output=$(du --exclude=dotdot a) || fail=1
 test "X$du_L_output" = "X$du_x_output" || fail=1
 test "X$du_lL_output" = "X$du_x_output" || fail=1

diff --git a/tests/du/inaccessible-cwd b/tests/du/inaccessible-cwd
index 39e6258..bfc8cf9 100755
--- a/tests/du/inaccessible-cwd
+++ b/tests/du/inaccessible-cwd
@@ -29,7 +29,7 @@ require_openat_support_

 skip_if_root_

-cwd=`pwd`
+cwd=$(pwd)
 mkdir -p no-x a/b || framework_failure_
 cd no-x || framework_failure_
 chmod 0 . || framework_failure_
diff --git a/tests/du/long-from-unreadable b/tests/du/long-from-unreadable
index 10864e0..7fc129c 100755
--- a/tests/du/long-from-unreadable
+++ b/tests/du/long-from-unreadable
@@ -36,11 +36,11 @@ if test ! -d $proc_file; then
   skip_ 'This test would fail, since your system lacks /proc support.'
 fi

-dir=`printf '%200s\n' ' '|tr ' ' x`
+dir=$(printf '%200s\n' ' '|tr ' ' x)

 # Construct a hierarchy containing a relative file with a name
 # longer than PATH_MAX.
-# for i in `seq 52`; do
+# for i in $(seq 52); do
 #   mkdir $dir || framework_failure_
 #   cd $dir || framework_failure_
 # done
@@ -51,7 +51,7 @@ dir=`printf '%200s\n' ' '|tr ' ' x`
 #     cannot access parent directories:
 # (all on one line).

-cwd=`pwd`
+cwd=$(pwd)
 # Use perl instead:
 : ${PERL=perl}
 $PERL \
diff --git a/tests/du/long-sloop b/tests/du/long-sloop
index 78926d3..f9e70ad 100755
--- a/tests/du/long-sloop
+++ b/tests/du/long-sloop
@@ -29,11 +29,11 @@ print_ver_ du
 # in a single directory.
 n=400

-dir_list=`seq $n`
+dir_list=$(seq $n)
 mkdir $dir_list || framework_failure_
 file=1
 i_minus_1=0
-for i in $dir_list `expr $n + 1`; do
+for i in $dir_list $(expr $n + 1); do
   case $i_minus_1 in
   0) ;;
   *)
@@ -56,7 +56,7 @@ echo foo > $i
 cat $file > /dev/null 2> err &&
     skip_ 'Your system appears to be able to handle more than $n symlinks
 in file name resolution'
-too_many=`sed 's/.*: //' err`
+too_many=$(sed 's/.*: //' err)


 # With coreutils-5.93 there was no failure.
diff --git a/tests/du/slink b/tests/du/slink
index 1f84291..674e6a2 100755
--- a/tests/du/slink
+++ b/tests/du/slink
@@ -32,7 +32,7 @@ fi

 symlink_name_lengths='1 15 16 31 32 59 60 63 64 127 128 255 256 511 512 1024'
 for len in $symlink_name_lengths; do
-  name=`seq 1 $len|tr -c x y |head -c$len`
+  name=$(seq 1 $len|tr -c x y |head -c$len)
   # Record the names of symlinks that are successfully created.
   ln -fs $name $len > /dev/null 2>&1 \
     && symlinks="$symlinks $len"
diff --git a/tests/install/basic-1 b/tests/install/basic-1
index 722a947..aa80fcf 100755
--- a/tests/install/basic-1
+++ b/tests/install/basic-1
@@ -57,7 +57,7 @@ ginstall -s -c -m 555 $dd $dir || fail=1
 test -f $dd || fail=1

 # Make sure that the destination file has the requested permissions.
-mode=`ls -l $dir/$dd|cut -b-10`
+mode=$(ls -l $dir/$dd|cut -b-10)
 test "$mode" = -r-xr-xr-x || fail=1

 # These failed in coreutils CVS from 2004-06-25 to 2004-08-11.
@@ -72,7 +72,7 @@ test -d newdir3 || fail=1
 # This fails because mkdir-p.c's make_dir_parents fails to return to its
 # initial working directory ($iwd) after creating the first argument, and
 # hence cannot do anything meaningful with the following relative-named dirs.
-iwd=`pwd`
+iwd=$(pwd)
 mkdir sub || fail=1
 (cd sub &&
  chmod 0 . &&
diff --git a/tests/install/trap b/tests/install/trap
index 79cea5f..e3ccf54 100755
--- a/tests/install/trap
+++ b/tests/install/trap
@@ -24,7 +24,7 @@ print_ver_ ginstall
 # Use a subshell and an exec to work around a bug in FreeBSD 5.0 /bin/sh.
 (
   # ash doesn't support "trap '' CHLD"; it knows only signal numbers.
-  sig=`"$abs_top_builddir/src/kill" -l CHLD 2>/dev/null` && trap '' $sig
+  sig=$("$abs_top_builddir/src/kill" -l CHLD 2>/dev/null) && trap '' $sig

   # Before 2004-04-21, install would infloop, in the 'while (wait...' loop:
   exec ginstall -s "$abs_top_builddir/src/ginstall$EXEEXT" .
diff --git a/tests/ln/hard-to-sym b/tests/ln/hard-to-sym
index 044b10c..358b930 100755
--- a/tests/ln/hard-to-sym
+++ b/tests/ln/hard-to-sym
@@ -30,7 +30,7 @@ ln -s -L -P symlink2 symlink3 || fail=1
 # ===================================================
 # ensure that -L follows symlinks, and overrides -P
 ln -P -L symlink3 hard-to-a || fail=1
-ls=`ls -lG hard-to-a`x
+ls=$(ls -lG hard-to-a)x
 case "$ls" in
   *'hard-to-ax') ;;
   *'hard-to-a -> '*x) fail=1 ;;
@@ -40,7 +40,7 @@ esac
 # ===================================================
 # ensure that -P links (or at least duplicates) symlinks, and overrides -L
 ln -L -P symlink3 hard-to-3 || fail=1
-ls=`ls -lG hard-to-3`x
+ls=$(ls -lG hard-to-3)x
 case "$ls" in
   *'hard-to-3 -> symlink2x') ;;
   *'hard-to-3x') fail=1 ;;
@@ -52,7 +52,7 @@ esac
 # Create a hard link to a dangling symlink.
 ln -s /no-such-dir || framework_failure_
 ln -L no-such-dir hard-to-dangle 2>err && fail=1
-case `cat err` in
+case $(cat err) in
   *" accessing 'no-such-dir'":*) ;;
   *) fail=1 ;;
 esac
@@ -63,12 +63,12 @@ ln -P no-such-dir hard-to-dangle || fail=1
 mkdir d || framework_failure_
 ln -s d link-to-dir || framework_failure_
 ln -L link-to-dir hard-to-dir-link 2>err && fail=1
-case `cat err` in
+case $(cat err) in
   *": 'link-to-dir': hard link not allowed for directory"*) ;;
   *) fail=1 ;;
 esac
 ln -P link-to-dir/ hard-to-dir-link 2>err && fail=1
-case `cat err` in
+case $(cat err) in
   *": 'link-to-dir/': hard link not allowed for directory"*) ;;
   *) fail=1 ;;
 esac
diff --git a/tests/ln/misc b/tests/ln/misc
index 09baa26..4da0eda 100755
--- a/tests/ln/misc
+++ b/tests/ln/misc
@@ -91,7 +91,7 @@ rm -rf $d $f $ld || framework_failure_
 touch $f || framework_failure_
 mkdir $d || framework_failure_
 ln -s $d $ld
-af=`pwd`/$f
+af=$(pwd)/$f
 ln --no-dereference -fs "$af" $ld || fail=1
 test -f $ld || fail=1
 rm -rf $d $f $ld
diff --git a/tests/ln/sf-1 b/tests/ln/sf-1
index e7b680b..824c224 100755
--- a/tests/ln/sf-1
+++ b/tests/ln/sf-1
@@ -23,7 +23,7 @@ echo foo > a || framework_failure_
 ln -s . b || framework_failure_

 ln -sf a b > err 2>&1 && fail=1
-case `cat err` in
+case $(cat err) in
   *'are the same file') ;;
   *) fail=1 ;;
 esac
diff --git a/tests/ls/inode b/tests/ls/inode
index b5c881e..8bf5ba1 100755
--- a/tests/ls/inode
+++ b/tests/ls/inode
@@ -25,17 +25,17 @@ ln -s f slink || framework_failure_

 # When listed explicitly:

-set x `ls -Ci f slink`; shift
+set x $(ls -Ci f slink); shift
 test $# = 4 || fail=1
 # The inode numbers should differ.
 test "$1" != "$3" || fail=1

-set x `ls -CLi f slink`; shift
+set x $(ls -CLi f slink); shift
 test $# = 4 || fail=1
 # With -L, they must be the same.
 test "$1" = "$3" || fail=1

-set x `ls -CHi f slink`; shift
+set x $(ls -CHi f slink); shift
 test $# = 4 || fail=1
 # With -H, they must be the same, too, from the command line.
 # Note that POSIX says -H must make ls dereference only
@@ -47,17 +47,17 @@ test "$1" = "$3" || fail=1

 # When listed from a directory:

-set x `ls -Ci`; shift
+set x $(ls -Ci); shift
 test $# = 4 || fail=1
 # The inode numbers should differ.
 test "$1" != "$3" || fail=1

-set x `ls -CLi`; shift
+set x $(ls -CLi); shift
 test $# = 4 || fail=1
 # With -L, they must be the same.
 test "$1" = "$3" || fail=1

-set x `ls -CHi`; shift
+set x $(ls -CHi); shift
 test $# = 4 || fail=1
 # With -H, they must be different from inside a directory.
 test "$1" != "$3" || fail=1
diff --git a/tests/ls/nameless-uid b/tests/ls/nameless-uid
index 6cd1868..1c8c471 100755
--- a/tests/ls/nameless-uid
+++ b/tests/ls/nameless-uid
@@ -34,7 +34,7 @@ touch f || framework_failure_
 chown $nameless_uid f || framework_failure_


-set -- `ls -o f` || fail=1
+set -- $(ls -o f) || fail=1
 test $3 = $nameless_uid || fail=1

 Exit $fail
diff --git a/tests/ls/stat-dtype b/tests/ls/stat-dtype
index 733ce38..b84d5d5 100755
--- a/tests/ls/stat-dtype
+++ b/tests/ls/stat-dtype
@@ -29,7 +29,7 @@ print_ver_ ls
 # but if ls's d_type code is buggy then "ls -p" might be buggy too.
 mkdir -p c/d || framework_failure_
 chmod a-x c || framework_failure_
-if test "X`ls -p c 2>&1`" != Xd/; then
+if test "X$(ls -p c 2>&1)" != Xd/; then
   skip_ "'.' is not on a suitable file system for this test"
 fi

diff --git a/tests/ls/stat-vs-dirent b/tests/ls/stat-vs-dirent
index 60d9622..1dd6e66 100755
--- a/tests/ls/stat-vs-dirent
+++ b/tests/ls/stat-vs-dirent
@@ -20,20 +20,20 @@
 print_ver_ ls


-root_dev_ino=`stat --format=%d-%i /`
-t=`pwd`
+root_dev_ino=$(stat --format=%d-%i /)
+t=$(pwd)
 while :; do
   ls -i1 "$t" > tmp
   if test $? = 0; then
     # Extract the inode number from the first line of output from ls -i1.
     # This value comes from dirent.d_ino, on systems with d_ino support.
-    d_ino=`sed -n '1s/^ *\([0-9][0-9]*\) .*/\1/p;q' tmp`
+    d_ino=$(sed -n '1s/^ *\([0-9][0-9]*\) .*/\1/p;q' tmp)

     # Extract the name of the corresponding directory entry.
-    file=`sed -n '1s/^ *[0-9][0-9]*  *//p;q' tmp`
+    file=$(sed -n '1s/^ *[0-9][0-9]*  *//p;q' tmp)

     # Get its inode number (stat.st_ino) via stat(1)'s call to lstat.
-    st_ino=`stat --format=%i "$t/$file"`
+    st_ino=$(stat --format=%i "$t/$file")

     # Make sure that they are the same.
     # We know from experience that there may be mismatches on some
@@ -53,7 +53,7 @@ while :; do
   fi

   t=$(cd "$t/.."; pwd)
-  dev_ino=`stat --format=%d-%i "$t"`
+  dev_ino=$(stat --format=%d-%i "$t")
   test $dev_ino = $root_dev_ino && break
 done

diff --git a/tests/ls/symlink-slash b/tests/ls/symlink-slash
index 4bbf6f7..28c7d32 100755
--- a/tests/ls/symlink-slash
+++ b/tests/ls/symlink-slash
@@ -22,7 +22,7 @@ print_ver_ ls
 mkdir dir || framework_failure_
 ln -s dir symlink || framework_failure_

-set `ls -l symlink/`
+set $(ls -l symlink/)

 # Prior to fileutils-4.0k, the following would have output '... symlink -> dir'.
 test "$*" = 'total 0' && : || fail=1
diff --git a/tests/misc/close-stdout b/tests/misc/close-stdout
index 8af84c2..8584dfe 100755
--- a/tests/misc/close-stdout
+++ b/tests/misc/close-stdout
@@ -49,7 +49,7 @@ if "$p/src/test" -w /dev/stdout >/dev/null &&
   rm -Rf tmpfile-?????? || fail=1
   mktemp tmpfile-XXXXXX >&- 2>/dev/null && fail=1
   mktemp tmpfile-XXXXXX -q >&- 2>/dev/null && fail=1
-  case `echo tmpfile-??????` in 'tmpfile-??????') ;; *) fail=1 ;; esac
+  case $(echo tmpfile-??????) in 'tmpfile-??????') ;; *) fail=1 ;; esac
 fi

 # Likewise for /dev/full, if /dev/full works.
@@ -59,7 +59,7 @@ if test -w /dev/full && test -c /dev/full; then
   rm -Rf tmpdir-?????? || fail=1
   mktemp -d tmpdir-XXXXXX >/dev/full 2>/dev/null && fail=1
   mktemp -d -q tmpdir-XXXXXX >/dev/full 2>/dev/null && fail=1
-  case `echo tmpfile-??????` in 'tmpfile-??????') ;; *) fail=1 ;; esac
+  case $(echo tmpfile-??????) in 'tmpfile-??????') ;; *) fail=1 ;; esac
 fi

 Exit $fail
diff --git a/tests/misc/date-sec b/tests/misc/date-sec
index 817e924..df77fe7 100755
--- a/tests/misc/date-sec
+++ b/tests/misc/date-sec
@@ -24,13 +24,13 @@ print_ver_ date


 # It would be easier simply to sleep for two seconds between two runs
-# of `date --date="21:04 +0100" +%S` and ensure that both outputs
+# of $(date --date="21:04 +0100" +%S) and ensure that both outputs
 # are '00', but I prefer not to sleep unconditionally.  'make check'
 # takes long enough as it is.

 n=0
 # See if the current number of seconds is '00' or just before.
-s=`date +%S`
+s=$(date +%S)
 case "$s" in
   58) n=3;;
   59) n=2;;
@@ -40,7 +40,7 @@ esac
 # If necessary, wait for the system clock to pass the minute mark.
 test $n = 0 || sleep $n

-s=`date --date="21:04 +0100" +%S`
+s=$(date --date="21:04 +0100" +%S)
 case "$s" in
   00) ;;
   *) fail=1;;
diff --git a/tests/misc/df b/tests/misc/df
index fe5be3f..4fc626e 100755
--- a/tests/misc/df
+++ b/tests/misc/df
@@ -19,7 +19,7 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ df

-case `df .` in
+case $(df .) in
 *'
 '*) ;;
 *) fail=1;;
diff --git a/tests/misc/env b/tests/misc/env
index ec9f0af..6f8c064 100755
--- a/tests/misc/env
+++ b/tests/misc/env
@@ -95,8 +95,8 @@ echo pass
 EOF
 chmod +x unlikely_name/also_unlikely || framework_failure_
 env also_unlikely && fail=1
-test x`PATH=$PATH:unlikely_name env also_unlikely` = xpass || fail=1
-test x`env PATH="$PATH":unlikely_name also_unlikely` = xpass || fail=1
+test x$(PATH=$PATH:unlikely_name env also_unlikely) = xpass || fail=1
+test x$(env PATH="$PATH":unlikely_name also_unlikely) = xpass || fail=1

 # Explicitly put . on the PATH for the rest of this test.
 PATH=$PATH:
@@ -108,15 +108,15 @@ export PATH
 # Avoid the issue by using an executable rather than a script.
 # Test -u, rather than -i, to minimize PATH problems.
 ln -s "$abs_top_builddir/src/echo" ./-u || framework_failure_
-case `env -u echo echo good` in
+case $(env -u echo echo good) in
   good) ;;
   *) fail=1 ;;
 esac
-case `env -u echo -- echo good` in
+case $(env -u echo -- echo good) in
   good) ;;
   *) fail=1 ;;
 esac
-case `env -- -u pass` in
+case $(env -- -u pass) in
   pass) ;;
   *) fail=1 ;;
 esac
@@ -125,7 +125,7 @@ esac
 env a=b -- true
 test $? = 127 || fail=1
 ln -s "$abs_top_builddir/src/echo" ./-- || framework_failure_
-case `env a=b -- true || echo fail` in
+case $(env a=b -- true || echo fail) in
   true) ;;
   *) fail=1 ;;
 esac
@@ -136,9 +136,9 @@ cat <<EOF >./c=d || framework_failure_
 echo pass
 EOF
 chmod +x c=d || framework_failure_
-test "x`env c=d echo fail`" = xfail || fail=1
-test "x`env -- c=d echo fail`" = xfail || fail=1
-test "x`env ./c=d echo fail`" = xfail || fail=1
+test "x$(env c=d echo fail)" = xfail || fail=1
+test "x$(env -- c=d echo fail)" = xfail || fail=1
+test "x$(env ./c=d echo fail)" = xfail || fail=1
 test "x$(env sh -c 'exec "$@"' sh c=d echo fail)" = xpass || fail=1
 test "x$(sh -c '\c=d echo fail')" = xpass && #dash 0.5.4 fails so check first
   { test "x$(env sh -c '\c=d echo fail')" = xpass || fail=1; }
diff --git a/tests/misc/head-c b/tests/misc/head-c
index 8a768a4..32f86d2 100755
--- a/tests/misc/head-c
+++ b/tests/misc/head-c
@@ -22,7 +22,7 @@ print_ver_ head
 echo abc > in || framework_failure_

 (head -c1; head -c1) < in > out || fail=1
-case "`cat out`" in
+case "$(cat out)" in
   ab) ;;
   *) fail=1 ;;
 esac
diff --git a/tests/misc/ls-time b/tests/misc/ls-time
index a998294..7bc3c64 100755
--- a/tests/misc/ls-time
+++ b/tests/misc/ls-time
@@ -47,7 +47,7 @@ touch -a -d "$u1" a || framework_failure_


 # A has ctime more recent than C.
-set `ls -c a c`
+set $(ls -c a c)
 test "$*" = 'a c' || fail=1

 # Sleep so long in an attempt to avoid spurious failures
@@ -58,7 +58,7 @@ sleep 2
 ln c d || framework_failure_

 # Before we go any further, verify that touch's -m option works.
-set -- `ls --full -l a`
+set -- $(ls --full -l a)
 case "$*" in
   *" $t3:00.000000000 +0000 a") ;;
   *)
@@ -77,7 +77,7 @@ EOF
 esac

 # Ensure that touch's -a option works.
-set -- `ls --full -lu a`
+set -- $(ls --full -lu a)
 case "$*" in
   *" $u1:00.000000000 +0000 a") ;;
   *)
@@ -94,16 +94,16 @@ EOF
   ;;
 esac

-set `ls -ut a b c`
+set $(ls -ut a b c)
 test "$*" = 'c b a' && : || fail=1
 test $fail = 1 && ls -l --full-time --time=access a b c

-set `ls -t a b c`
+set $(ls -t a b c)
 test "$*" = 'a b c' && : || fail=1
 test $fail = 1 && ls -l --full-time a b c

 # Now, C should have ctime more recent than A.
-set `ls -ct a c`
+set $(ls -ct a c)
 if test "$*" = 'c a'; then
   : ok
 else
diff --git a/tests/misc/mknod b/tests/misc/mknod
index 09334b8..b9e33ad 100755
--- a/tests/misc/mknod
+++ b/tests/misc/mknod
@@ -25,15 +25,15 @@ mkfifo_or_skip_ fifo
 umask 777

 mknod  -m 734 f1 p || fail=1
-mode=`ls -dgo f1|cut -b-10`
+mode=$(ls -dgo f1|cut -b-10)
 test $mode = prwx-wxr-- || fail=1

 mkfifo -m 734 f2   || fail=1
-mode=`ls -dgo f2|cut -b-10`
+mode=$(ls -dgo f2|cut -b-10)
 test $mode = prwx-wxr-- || fail=1

 mkdir -m 734 f3   || fail=1
-mode=`ls -dgo f3|cut -b-10`
+mode=$(ls -dgo f3|cut -b-10)
 test $mode = drwx-wxr-- || test $mode = drwx-wsr-- || fail=1

 Exit $fail
diff --git a/tests/misc/nice b/tests/misc/nice
index cbc135f..ac8ea04 100755
--- a/tests/misc/nice
+++ b/tests/misc/nice
@@ -45,7 +45,7 @@ NA LAST NA
 set $tests

 # Require that this test be run at 'nice' level 0.
-niceness=`nice`
+niceness=$(nice)
 if test "$niceness" = 0; then
     : ok
 else
@@ -58,19 +58,19 @@ while :; do
   expected_result=$3
   test $args = empty && args=''
   test x$args = xLAST && break
-  args=`echo x$args|tr : ' '|sed 's/^x//'`
+  args=$(echo x$args|tr : ' '|sed 's/^x//')
   if test "$VERBOSE" = yes; then
-    #echo "testing \`nice $args nice\` = $expected_result ..."
+    #echo "testing \$(nice $args nice\) = $expected_result ..."
     echo "test $test_name... " | tr -d '\n'
   fi
-  test x`nice $args nice 2> /dev/null` = x$expected_result \
+  test x$(nice $args nice 2> /dev/null) = x$expected_result \
     && ok=ok || ok=FAIL fail=1
   test "$VERBOSE" = yes && echo $ok
   shift; shift; shift
 done

 # Test negative niceness - command must be run whether or not change happens.
-if test x`nice -n -1 nice 2> /dev/null` = x0 ; then
+if test x$(nice -n -1 nice 2> /dev/null) = x0 ; then
   # unprivileged user - warn about failure to change
   nice -n -1 true 2> err || fail=1
   test -s err || fail=1
@@ -87,8 +87,8 @@ else
   # superuser - change succeeds
   nice -n -1 nice 2> err || fail=1
   test -s err && fail=1
-  test x`nice -n -1 nice` = x-1 || fail=1
-  test x`nice --1 nice` = x-1 || fail=1
+  test x$(nice -n -1 nice) = x-1 || fail=1
+  test x$(nice --1 nice) = x-1 || fail=1
 fi

 Exit $fail
diff --git a/tests/misc/nohup b/tests/misc/nohup
index cef8ee8..76f676d 100755
--- a/tests/misc/nohup
+++ b/tests/misc/nohup
@@ -25,7 +25,7 @@ nohup sh -c 'echo stdout; echo stderr 1>&2' 2>err || fail=1
 # Be careful.  The results of the above nohup command
 # change depending on whether stdin and stdout are redirected.
 if test -t 1; then
-  test "`cat nohup.out`" = stdout || fail=1
+  test "$(cat nohup.out)" = stdout || fail=1
   if test -t 0; then
     echo 'nohup: ignoring input and appending output to 'nohup.out'\'
   else
diff --git a/tests/misc/od-multiple-t b/tests/misc/od-multiple-t
index 1f607bc..049273c 100755
--- a/tests/misc/od-multiple-t
+++ b/tests/misc/od-multiple-t
@@ -23,17 +23,17 @@ print_ver_ od
 # Choose 48 bytes for the input, as that is lcm for 1, 2, 4, 8, 12, 16;
 # we don't anticipate any other native object size on modern hardware.
 seq 19 > in || framework_failure_
-test `wc -c < in` -eq 48 || framework_failure_
+test $(wc -c < in) -eq 48 || framework_failure_


 list='a c dC dS dI dL oC oS oI oL uC uS uI uL xC xS xI xL fF fD fL'
 for format1 in $list; do
   for format2 in $list; do
     od -An -t${format1}z -t${format2}z in > out-raw || fail=1
-    linewidth=`head -n1 out-raw | wc -c`
-    linecount=`wc -l < out-raw`
-    echo $format1 $format2 `wc -c < out-raw` >> out
-    echo $format1 $format2 `expr $linewidth '*' $linecount` >> exp
+    linewidth=$(head -n1 out-raw | wc -c)
+    linecount=$(wc -l < out-raw)
+    echo $format1 $format2 $(wc -c < out-raw) >> out
+    echo $format1 $format2 $(expr $linewidth '*' $linecount) >> exp
   done
 done

diff --git a/tests/misc/runcon-no-reorder b/tests/misc/runcon-no-reorder
index 6f282d9..351896e 100755
--- a/tests/misc/runcon-no-reorder
+++ b/tests/misc/runcon-no-reorder
@@ -33,7 +33,7 @@ runcon $(id -Z) true -j 2> out && : > exp
 # it chcon fails with this: "runcon: invalid context: \
 # root:system_r:unconfined_t:s0-s0:c0.c1023: No such file or directory"
 # That diagnostic is ok, too, so map it to the more common one.
-case `cat out` in
+case $(cat out) in
   'runcon: invalid context: '*) echo "$diag" > out;;
 esac

diff --git a/tests/misc/selinux b/tests/misc/selinux
index 810996c..12ae15f 100755
--- a/tests/misc/selinux
+++ b/tests/misc/selinux
@@ -37,23 +37,23 @@ chcon $ctx f d p ||

 # inspect that context with both ls -Z and stat.
 for i in d f p; do
-  c=`ls -dogZ $i|cut -d' ' -f3`; test x$c = x$ctx || fail=1
-  c=`stat --printf %C $i`; test x$c = x$ctx || fail=1
+  c=$(ls -dogZ $i|cut -d' ' -f3); test x$c = x$ctx || fail=1
+  c=$(stat --printf %C $i); test x$c = x$ctx || fail=1
 done

 # ensure that ls -l output includes the ".".
-c=`ls -l f|cut -c11`; test "$c" = . || fail=1
+c=$(ls -l f|cut -c11); test "$c" = . || fail=1

 # Copy each to a new directory and ensure that context is preserved.
 cp -r --preserve=all d f p s1 || fail=1
 for i in d f p; do
-  c=`stat --printf %C s1/$i`; test x$c = x$ctx || fail=1
+  c=$(stat --printf %C s1/$i); test x$c = x$ctx || fail=1
 done

 # Now, move each to a new directory and ensure that context is preserved.
 mv d f p s2 || fail=1
 for i in d f p; do
-  c=`stat --printf %C s2/$i`; test x$c = x$ctx || fail=1
+  c=$(stat --printf %C s2/$i); test x$c = x$ctx || fail=1
 done

 Exit $fail
diff --git a/tests/misc/shuf b/tests/misc/shuf
index 8fdbdd9..243c049 100755
--- a/tests/misc/shuf
+++ b/tests/misc/shuf
@@ -40,7 +40,7 @@ sort -n out > out1
 compare in out1 || { fail=1; echo "not a permutation" 1>&2; }

 # Exercise shuf's -e option.
-t=`shuf -e a b c d e | sort | fmt`
+t=$(shuf -e a b c d e | sort | fmt)
 test "$t" = 'a b c d e' || { fail=1; echo "not a permutation" 1>&2; }

 # Before coreutils-6.3, this would infloop.
diff --git a/tests/misc/sort-compress b/tests/misc/sort-compress
index 9a4b9f6..00dcf06 100755
--- a/tests/misc/sort-compress
+++ b/tests/misc/sort-compress
@@ -39,7 +39,7 @@ chmod +x gzip
 # Use a subshell and an exec to work around a bug in FreeBSD 5.0 /bin/sh.
 (
   # ash doesn't support "trap '' CHLD"; it knows only signal numbers.
-  sig=`"$abs_top_builddir/src/kill" -l CHLD 2>/dev/null` && trap '' $sig
+  sig=$("$abs_top_builddir/src/kill" -l CHLD 2>/dev/null) && trap '' $sig

   # This should force the use of child processes for "compression"
   PATH=.:$PATH exec sort -S 1k --compress-program=gzip in > /dev/null
diff --git a/tests/misc/sort-merge-fdlimit b/tests/misc/sort-merge-fdlimit
index d206494..7ce109c 100755
--- a/tests/misc/sort-merge-fdlimit
+++ b/tests/misc/sort-merge-fdlimit
@@ -24,7 +24,7 @@ require_ulimit_
 mkdir in err || framework_failure_


-for i in `seq 17`; do
+for i in $(seq 17); do
   echo $i >in/$i
 done
 seq 17 >some-data
diff --git a/tests/misc/sort-rand b/tests/misc/sort-rand
index c9fce0a..79730e9 100755
--- a/tests/misc/sort-rand
+++ b/tests/misc/sort-rand
@@ -35,7 +35,7 @@ compare in out1 || { fail=1; echo "not a permutation" 1>&2; }

 # If locale is available then use it to find a random non-C locale.
 if (locale --version) > /dev/null 2>&1; then
-  locale=`locale -a | sort --random-sort | awk '/^.._/{print;exit}'`
+  locale=$(locale -a | sort --random-sort | awk '/^.._/{print;exit}')
   LC_ALL=$locale sort --random-sort in > out1 || fail=1
   LC_ALL=$locale sort --random-sort in > out2 || fail=1

diff --git a/tests/misc/stat-fmt b/tests/misc/stat-fmt
index af42815..8952a7a 100755
--- a/tests/misc/stat-fmt
+++ b/tests/misc/stat-fmt
@@ -21,9 +21,9 @@ print_ver_ stat



-for i in `seq 50`; do
-  fmt=`printf "%${i}s" %`
-  out=`stat --form="$fmt" .`
+for i in $(seq 50); do
+  fmt=$(printf "%${i}s" %)
+  out=$(stat --form="$fmt" .)
   test "$out" = "$fmt" || fail=1
 done

diff --git a/tests/misc/stty b/tests/misc/stty
index 650231f..fe4a4c8 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -40,7 +40,7 @@ REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1

 saved_state=.saved-state
 stty --save > $saved_state || fail=1
-stty `cat $saved_state` || fail=1
+stty $(cat $saved_state) || fail=1

 # This would segfault prior to sh-utils-2.0j.
 stty erase - || fail=1
@@ -54,7 +54,7 @@ stty -raw -a 2>/dev/null && fail=1
 # Don't depend on terminal width.  Put each option on its own line,
 # remove all non-boolean ones, then remove any leading hyphens.
 sed_del='/^speed/d;/^rows/d;/^columns/d;/ = /d'
-options=`stty -a | tr -s ';' '\n' | sed "s/^ //;$sed_del;s/-//g"`
+options=$(stty -a | tr -s ';' '\n' | sed "s/^ //;$sed_del;s/-//g")

 # Take them one at a time, with and without the leading '-'.
 for opt in $options; do
@@ -70,7 +70,7 @@ for opt in $options; do

   # Likewise, 'stty -cread' would fail, so skip that, too.
   test $opt = cread && continue
-  rev=`eval echo "\\\$REV_$opt"`
+  rev=$(eval echo "\\\$REV_$opt")
   if test -n "$rev"; then
     stty -$opt || { fail=1; echo -$opt; }
   fi
@@ -84,8 +84,8 @@ if test -n "$RUN_LONG_TESTS"; then

       stty $opt1 $opt2 || fail=1

-      rev1=`eval echo "\\\$REV_$opt1"`
-      rev2=`eval echo "\\\$REV_$opt2"`
+      rev1=$(eval echo "\\\$REV_$opt1")
+      rev2=$(eval echo "\\\$REV_$opt2")
       if test -n "$rev1"; then
         stty -$opt1 $opt2 || fail=1
       fi
@@ -99,6 +99,6 @@ if test -n "$RUN_LONG_TESTS"; then
   done
 fi

-stty `cat $saved_state`
+stty $(cat $saved_state)

 Exit $fail
diff --git a/tests/misc/stty-invalid b/tests/misc/stty-invalid
index 2be9843..3b035ec 100755
--- a/tests/misc/stty-invalid
+++ b/tests/misc/stty-invalid
@@ -22,7 +22,7 @@ require_controlling_input_terminal_
 trap '' TTOU # Ignore SIGTTOU


-saved_state=`stty -g` || fail=1
+saved_state=$(stty -g) || fail=1
 stty $saved_state || fail=1

 # Before coreutils-6.9.90, if stty were given an argument with 35 colons
@@ -34,8 +34,8 @@ stty $saved_state || fail=1
 # For each of the following, with coreutils-6.9 and earlier,
 # stty would fail to diagnose the error on at least Solaris 10.
 hex_2_64=10000000000000000
-stty `echo $saved_state |sed 's/^[^:]*:/'$hex_2_64:/`     2>/dev/null && fail=1
-stty `echo $saved_state |sed 's/:[0-9a-f]*$/:'$hex_2_64/` 2>/dev/null && fail=1
+stty $(echo $saved_state |sed 's/^[^:]*:/'$hex_2_64:/)     2>/dev/null && fail=1
+stty $(echo $saved_state |sed 's/:[0-9a-f]*$/:'$hex_2_64/) 2>/dev/null && fail=1

 # Just in case either of the above mistakenly succeeds (and changes
 # the state of our tty), try to restore the initial state.
diff --git a/tests/misc/stty-row-col b/tests/misc/stty-row-col
index bcbc7bc..d7151d5 100755
--- a/tests/misc/stty-row-col
+++ b/tests/misc/stty-row-col
@@ -51,7 +51,7 @@ NA LAST NA
 '
 set $tests

-saved_size=`stty size` && test -n "$saved_size" \
+saved_size=$(stty size) && test -n "$saved_size" \
   || skip_ "can't get window size"

 # Linux virtual consoles issue an error if you
@@ -66,16 +66,16 @@ fi
 while :; do
   test_name=$1
   args=$2
-  expected_result="`echo $3|tr _ ' '`"
+  expected_result="$(echo $3|tr _ ' ')"
   test "$args" = empty && args=''
   test "x$args" = xLAST && break
-  args=`echo x$args|tr _ ' '|sed 's/^x//'`
+  args=$(echo x$args|tr _ ' '|sed 's/^x//')
   if test "$VERBOSE" = yes; then
-    # echo "testing \`stty $args; stty size\` = $expected_result ..."
+    # echo "testing \$(stty $args; stty size\) = $expected_result ..."
     echo "test $test_name... " | tr -d '\n'
   fi
   stty $args || exit 1
-  test x"`stty size 2> /dev/null`" = "x$expected_result" \
+  test x"$(stty size 2> /dev/null)" = "x$expected_result" \
     && ok=ok || ok=FAIL fail=1
   test "$VERBOSE" = yes && echo $ok
   shift; shift; shift
diff --git a/tests/misc/tee b/tests/misc/tee
index 8607c61..4c17316 100755
--- a/tests/misc/tee
+++ b/tests/misc/tee
@@ -20,10 +20,10 @@
 print_ver_ tee

 echo line >sample || framework_failure_
-nums=`seq 9` || framework_failure_
+nums=$(seq 9) || framework_failure_

 for n in 0 $nums; do
-        files=`seq $n`
+        files=$(seq $n)
         rm -f $files
         tee $files <sample >out || fail=1
         for f in out $files; do
diff --git a/tests/misc/timeout b/tests/misc/timeout
index d69e2f2..5f4e9ec 100755
--- a/tests/misc/timeout
+++ b/tests/misc/timeout
@@ -46,7 +46,7 @@ test $? = 124 && fail=1
 # Use a subshell and an exec to work around a bug in FreeBSD 5.0 /bin/sh.
 (
   # ash doesn't support "trap '' CHLD"; it knows only signal numbers.
-  sig=`"$abs_top_builddir/src/kill" -l CHLD 2>/dev/null` && trap '' $sig
+  sig=$("$abs_top_builddir/src/kill" -l CHLD 2>/dev/null) && trap '' $sig

   exec timeout 10 true
 ) || fail=1
diff --git a/tests/mkdir/p-1 b/tests/mkdir/p-1
index a2c4145..cd8e676 100755
--- a/tests/mkdir/p-1
+++ b/tests/mkdir/p-1
@@ -19,7 +19,7 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ mkdir

-mkdir --parents "`pwd`/t" || fail=1
+mkdir --parents "$(pwd)/t" || fail=1
 test -d t || fail=1

 Exit $fail
diff --git a/tests/mkdir/p-2 b/tests/mkdir/p-2
index 7d1d095..d0c487e 100755
--- a/tests/mkdir/p-2
+++ b/tests/mkdir/p-2
@@ -19,7 +19,7 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ mkdir

-mkdir --parents "`pwd`/t/u" || fail=1
+mkdir --parents "$(pwd)/t/u" || fail=1
 test -d t/u || fail=1

 Exit $fail
diff --git a/tests/mkdir/p-3 b/tests/mkdir/p-3
index 90cbd99..7031b2e 100755
--- a/tests/mkdir/p-3
+++ b/tests/mkdir/p-3
@@ -26,7 +26,7 @@ mkdir no-access || framework_failure_
 mkdir no-acce2s || framework_failure_
 mkdir -p no-acce3s/d || framework_failure_

-p=`pwd`
+p=$(pwd)
 (cd no-access && chmod 0 . && mkdir -p "$p/a/b" u/v) 2> /dev/null && fail=1
 test -d "$p/a/b" || fail=1

@@ -44,7 +44,7 @@ if is_local_dir_ .; then
   test -d "$p/b/c" || fail=1
 fi

-b=`ls "$p/a" | tr -d '\n'`
+b=$(ls "$p/a" | tr -d '\n')
 # With coreutils-5.3.0, this would fail with $b=bu.
 test "x$b" = xb || fail=1

diff --git a/tests/mkdir/parents b/tests/mkdir/parents
index c9bf37b..0543e67 100755
--- a/tests/mkdir/parents
+++ b/tests/mkdir/parents
@@ -31,21 +31,21 @@ mkdir e-dir > /dev/null 2>&1 && fail=1
 # Create an existing directory.
 umask 077
 mode_str=drwxr-x-wx
-mode_arg=`rwx_to_mode_ $mode_str`
+mode_arg=$(rwx_to_mode_ $mode_str)
 mkdir -m $mode_arg a || fail=1

 # this 'mkdir -p ...' shouldn't change perms of existing dir 'a'.
 d_mode_str=drwx-w--wx
-d_mode_arg=`rwx_to_mode_ $d_mode_str`
+d_mode_arg=$(rwx_to_mode_ $d_mode_str)
 mkdir -p -m $d_mode_arg a/b/c/d

 # Make sure the permissions of 'a' haven't been changed.
-p=`ls -ld a|cut -b-10`; case $p in $mode_str);; *) fail=1;; esac
+p=$(ls -ld a|cut -b-10); case $p in $mode_str);; *) fail=1;; esac
 # 'b's and 'c's should reflect the umask
-p=`ls -ld a/b|cut -b-10`; case $p in drwx------);; *) fail=1;; esac
-p=`ls -ld a/b/c|cut -b-10`; case $p in drwx------);; *) fail=1;; esac
+p=$(ls -ld a/b|cut -b-10); case $p in drwx------);; *) fail=1;; esac
+p=$(ls -ld a/b/c|cut -b-10); case $p in drwx------);; *) fail=1;; esac

 # 'd's perms are determined by the -m argument.
-p=`ls -ld a/b/c/d|cut -b-10`; case $p in $d_mode_str);; *) fail=1;; esac
+p=$(ls -ld a/b/c/d|cut -b-10); case $p in $d_mode_str);; *) fail=1;; esac

 Exit $fail
diff --git a/tests/mkdir/perm b/tests/mkdir/perm
index cabae6c..f9b207f 100755
--- a/tests/mkdir/perm
+++ b/tests/mkdir/perm
@@ -38,7 +38,7 @@ tests='
     027  :   -m =+X   : drwxr-x--- : d--x--x--- :
     -    :   -        : last       : last       :
     '
-colon_tests=`echo $tests | sed 's/^ *//; s/ *: */:/g'`
+colon_tests=$(echo $tests | sed 's/^ *//; s/ *: */:/g')

 for p in empty -p; do
   test _$p = _empty && p=
diff --git a/tests/mkdir/special-1 b/tests/mkdir/special-1
index fbf3f1f..d478930 100755
--- a/tests/mkdir/special-1
+++ b/tests/mkdir/special-1
@@ -26,7 +26,7 @@ tmp=t
 mkdir -m$set_mode_string $tmp || fail=1

 test -d $tmp || fail=1
-mode=`ls -ld $tmp|cut -b-10`
+mode=$(ls -ld $tmp|cut -b-10)
 case "$mode" in
   $output_mode_string) ;;
   *) fail=1 ;;
@@ -42,7 +42,7 @@ mkdir -m$set_mode_string $tmp2 2> /dev/null && fail=1
 mkdir --parents -m$set_mode_string $tmp2 || fail=1

 test -d $tmp2 || fail=1
-mode=`ls -ld $tmp2|cut -b-10`
+mode=$(ls -ld $tmp2|cut -b-10)
 case "$mode" in
   $output_mode_string) ;;
   *) fail=1 ;;
diff --git a/tests/mv/acl b/tests/mv/acl
index 382752a..2354ed9 100755
--- a/tests/mv/acl
+++ b/tests/mv/acl
@@ -38,30 +38,30 @@ skip_partition=none
 setfacl -m user:bin:rw- file 2> /dev/null || skip_partition=.
 # And on the destination file system.
 setfacl -m user:bin:rw- $t1 || skip_partition=$other_partition_tmpdir
-acl1=`getfacl file` || skip_partition=.
+acl1=$(getfacl file) || skip_partition=.

 test $skip_partition != none &&
   skip_ "'$skip_partition' is not on a suitable file system for this test"

 # move the access acl of a file
 mv file "$other_partition_tmpdir" || fail=1
-acl2=`cd "$other_partition_tmpdir" && getfacl file` || framework_failure_
+acl2=$(cd "$other_partition_tmpdir" && getfacl file) || framework_failure_
 test "$acl1" = "$acl2" || fail=1

 # move the access acl of a directory
 mkdir dir || framework_failure_
 setfacl -m user:bin:rw- dir || framework_failure_
-acl1=`getfacl dir` || framework_failure_
+acl1=$(getfacl dir) || framework_failure_
 mv dir "$other_partition_tmpdir" || fail=1
-acl2=`cd "$other_partition_tmpdir" && getfacl dir` || framework_failure_
+acl2=$(cd "$other_partition_tmpdir" && getfacl dir) || framework_failure_
 test "$acl1" = "$acl2" || fail=1

 # move the default acl of a directory
 mkdir dir2 || framework_failure_
 setfacl -d -m user:bin:rw- dir2 || framework_failure_
-acl1=`getfacl dir2` || framework_failure_
+acl1=$(getfacl dir2) || framework_failure_
 mv dir2 "$other_partition_tmpdir" || fail=1
-acl2=`cd "$other_partition_tmpdir" && getfacl dir2` || framework_failure_
+acl2=$(cd "$other_partition_tmpdir" && getfacl dir2) || framework_failure_
 test "$acl1" = "$acl2" || fail=1

 Exit $fail
diff --git a/tests/mv/atomic b/tests/mv/atomic
index c2b38c6..e5391c3 100755
--- a/tests/mv/atomic
+++ b/tests/mv/atomic
@@ -41,6 +41,6 @@ $EGREP 'unlink.*"s1"' out && fail=1
 ls -dl s1 > /dev/null 2>&1 && fail=1

 # Ensure that the destination, s2, contains the link from s1.
-test "`readlink s2`" = t1 || fail=1
+test "$(readlink s2)" = t1 || fail=1

 Exit $fail
diff --git a/tests/mv/atomic2 b/tests/mv/atomic2
index e329dba..d9c55e2 100755
--- a/tests/mv/atomic2
+++ b/tests/mv/atomic2
@@ -39,7 +39,7 @@ $EGREP 'unlink.*"b"' out && fail=1
 ls -dl a > /dev/null 2>&1 && fail=1

 # Ensure that the destination, "b", has link count 1.
-n_links=`stat --printf=%h b` || fail=1
+n_links=$(stat --printf=%h b) || fail=1
 test "$n_links" = 1 || fail=1

 Exit $fail
diff --git a/tests/mv/childproof b/tests/mv/childproof
index 04774d2..efe7225 100755
--- a/tests/mv/childproof
+++ b/tests/mv/childproof
@@ -32,7 +32,7 @@ cp a/f b/f c 2> /dev/null && fail=1
 test -f a/f || fail=1
 test -f b/f || fail=1
 test -f c/f || fail=1
-test "`cat c/f`" = a || fail=1
+test "$(cat c/f)" = a || fail=1
 rm -f c/f

 # With --backup=numbered, it should succeed
@@ -47,7 +47,7 @@ mv a/f b/f c 2> /dev/null && fail=1
 test -f a/f && fail=1
 test -f b/f || fail=1
 test -f c/f || fail=1
-test "`cat c/f`" = a || fail=1
+test "$(cat c/f)" = a || fail=1

 # Make sure mv still works when moving hard links.
 # This is where the same_file test is necessary, and why
@@ -76,8 +76,8 @@ echo a > a/f || fail=1
 echo b > b/f || fail=1
 ln -f a/f b/f c 2> /dev/null && fail=1
 # a/f and c/f must be linked
-test `stat --format %i a/f` = `stat --format %i c/f` || fail=1
+test $(stat --format %i a/f) = $(stat --format %i c/f) || fail=1
 # b/f and c/f must not be linked
-test `stat --format %i b/f` = `stat --format %i c/f` && fail=1
+test $(stat --format %i b/f) = $(stat --format %i c/f) && fail=1

 Exit $fail
diff --git a/tests/mv/force b/tests/mv/force
index 79ff9e9..6bed83b 100755
--- a/tests/mv/force
+++ b/tests/mv/force
@@ -33,7 +33,7 @@ mv: '$ff' and '$ff' are the same file
 EOF

 compare exp out || fail=1
-test `cat $ff` = force-contents || fail=1
+test $(cat $ff) = force-contents || fail=1

 # This should succeed, even though the source and destination
 # device and inodes are the same.
diff --git a/tests/mv/hard-2 b/tests/mv/hard-2
index c1d25af..e0fc174 100755
--- a/tests/mv/hard-2
+++ b/tests/mv/hard-2
@@ -43,9 +43,9 @@ test -f b || fail=1
 test -f c || fail=1

 # The three i-node numbers must be the same.
-ia=`ls -i a|sed 's/ a//'`
-ib=`ls -i b|sed 's/ b//'`
-ic=`ls -i c|sed 's/ c//'`
+ia=$(ls -i a|sed 's/ a//')
+ib=$(ls -i b|sed 's/ b//')
+ic=$(ls -i c|sed 's/ c//')
 test $ia = $ib || fail=1
 test $ia = $ic || fail=1

@@ -68,9 +68,9 @@ test -f b || fail=1
 test -f c || fail=1

 # The three i-node numbers must be the same.
-ia=`ls -i a|sed 's/ a//'`
-ib=`ls -i b|sed 's/ b//'`
-ic=`ls -i c|sed 's/ c//'`
+ia=$(ls -i a|sed 's/ a//')
+ib=$(ls -i b|sed 's/ b//')
+ic=$(ls -i c|sed 's/ c//')
 test $ia = $ib || fail=1
 test $ia = $ic || fail=1

diff --git a/tests/mv/hard-3 b/tests/mv/hard-3
index 9dd8ad5..a62167a 100755
--- a/tests/mv/hard-3
+++ b/tests/mv/hard-3
@@ -58,12 +58,12 @@ test -f x/b || fail=1
 test -f c || fail=1

 # The i-node numbers of a and c must be the same.
-ia=`ls -i a` || fail=1; set x $ia; ia=$2
-ic=`ls -i c` || fail=1; set x $ic; ic=$2
+ia=$(ls -i a) || fail=1; set x $ia; ia=$2
+ic=$(ls -i c) || fail=1; set x $ic; ic=$2
 test "$ia" = "$ic" || fail=1

 # The i-node number of x/b must be different.
-ib=`ls -i x/b` || fail=1; set x $ib; ib=$2
+ib=$(ls -i x/b) || fail=1; set x $ib; ib=$2
 test "$ia" = "$ib" && fail=1

 Exit $fail
diff --git a/tests/mv/hard-link-1 b/tests/mv/hard-link-1
index eccd8bc..78a555a 100755
--- a/tests/mv/hard-link-1
+++ b/tests/mv/hard-link-1
@@ -34,8 +34,8 @@ mv $dir "$other_partition_tmpdir" || fail=1
 ls -1i "$other_partition_tmpdir/$dir" > out || fail=1

 # Make sure the inode numbers are the same.
-a=`sed -n 's/ a$//p' out`
-b=`sed -n 's/ b$//p' out`
+a=$(sed -n 's/ a$//p' out)
+b=$(sed -n 's/ b$//p' out)
 test "$a" = "$b" || fail=1

 Exit $fail
diff --git a/tests/mv/i-2 b/tests/mv/i-2
index 84ccfe5..f248019 100755
--- a/tests/mv/i-2
+++ b/tests/mv/i-2
@@ -35,7 +35,7 @@ mv -fi c d < y >/dev/null 2>&1 || fail=1
 cp -if e f < y > out 2>&1 || fail=1

 # Make sure out contains the prompt.
-case "`cat out`" in
+case "$(cat out)" in
   "cp: try to overwrite 'f', overriding mode 0000 (---------)?"*) ;;
   *) fail=1 ;;
 esac
diff --git a/tests/mv/i-3 b/tests/mv/i-3
index 262b5ba..3912842 100755
--- a/tests/mv/i-3
+++ b/tests/mv/i-3
@@ -45,7 +45,7 @@ mv f g < $tty > out 2>&1 & pid=$!
 check_overwrite_prompt()
 {
   local delay="$1"
-  case "`cat out`" in
+  case "$(cat out)" in
     "mv: try to overwrite 'g', overriding mode 0000"*) ;;
     *) sleep $delay; return 1;;
   esac
@@ -61,7 +61,7 @@ test -f i || fail=1
 test -f h && fail=1

 # Make sure there was no prompt.
-case "`cat out`" in
+case "$(cat out)" in
   '') ;;
   *) fail=1 ;;
 esac
diff --git a/tests/mv/i-4 b/tests/mv/i-4
index bcf3fdd..8ef6ca7 100755
--- a/tests/mv/i-4
+++ b/tests/mv/i-4
@@ -27,7 +27,7 @@ echo y > y || framework_failure_
 mv -i a b < y >/dev/null 2>&1 || fail=1

 # Make sure out contains the prompt.
-case "`cat b`" in
+case "$(cat b)" in
   a) ;;
   *) fail=1 ;;
 esac
diff --git a/tests/mv/i-link-no b/tests/mv/i-link-no
index a37a1ff..4615eaa 100755
--- a/tests/mv/i-link-no
+++ b/tests/mv/i-link-no
@@ -35,7 +35,7 @@ touch exp_err
 compare exp out || fail=1
 compare exp_err err || fail=1

-case "`cat b/foo`" in
+case "$(cat b/foo)" in
   foo) ;;
   *) fail=1;;
 esac
diff --git a/tests/mv/leak-fd b/tests/mv/leak-fd
index 532bdb0..d349a3f 100755
--- a/tests/mv/leak-fd
+++ b/tests/mv/leak-fd
@@ -32,16 +32,16 @@ b="0 1 2 3 4 5 6 7 8 9
 a b c d e f g h i j k l m n o p q r s t u v w x y z
 _A _B _C _D _E _F _G _H _I _J _K _L _M _N _O _P _Q _R _S _T _U _V _W _X _Y _Z"

-for i in `echo $b`; do
+for i in $(echo $b); do
   echo $i
   for j in $b; do
     echo $i$j
   done
 done > .dirs
-mkdir `cat .dirs` || framework_failure_
+mkdir $(cat .dirs) || framework_failure_
 sed 's,$,/f,' .dirs | xargs touch

-last_file=`tail -n1 .dirs`/f
+last_file=$(tail -n1 .dirs)/f
 test -f $last_file || framework_failure_


diff --git a/tests/mv/part-hardlink b/tests/mv/part-hardlink
index ac71bdf..af773a2 100755
--- a/tests/mv/part-hardlink
+++ b/tests/mv/part-hardlink
@@ -35,9 +35,9 @@ mv f g "$other_partition_tmpdir" || fail=1
 mv a b "$other_partition_tmpdir" || fail=1

 cd "$other_partition_tmpdir"
-set `ls -Ci f g`
+set $(ls -Ci f g)
 test $1 = $3 || fail=1
-set `ls -Ci a/1 b/1`
+set $(ls -Ci a/1 b/1)
 test $1 = $3 || fail=1

 Exit $fail
diff --git a/tests/mv/part-symlink b/tests/mv/part-symlink
index 30cb440..2e7cf1b 100755
--- a/tests/mv/part-symlink
+++ b/tests/mv/part-symlink
@@ -27,7 +27,7 @@ cleanup_() { rm -rf "$other_partition_tmpdir"; }
 # mv: preserving permissions for 'rem_sl': Operation not supported
 require_local_dir_

-pwd_tmp=`pwd`
+pwd_tmp=$(pwd)

 # Unset CDPATH.  Otherwise, output from the 'cd dir' command
 # can make this test fail.
@@ -68,15 +68,15 @@ for copy in cp mv; do
       rm -f "$other_partition_tmpdir"/* || fail=1
       mkdir dir || fail=1
       cd dir || fail=1
-      case "$args" in *loc_reg*) reg_abs="`pwd`/$loc_reg" ;; esac
+      case "$args" in *loc_reg*) reg_abs="$(pwd)/$loc_reg" ;; esac
       case "$args" in *rem_reg*) reg_abs=$rem_reg ;; esac
       case "$args" in *loc_sl*) slink=$loc_sl ;; esac
       case "$args" in *rem_sl*) slink=$rem_sl ;; esac

       echo $contents > "$reg_abs" || fail=1
       ln -nsf "$reg_abs" $slink || fail=1
-      actual_args=`echo $args|sed 's,^,$,;s/ / $/'`
-      actual_args=`eval echo $actual_args`
+      actual_args=$(echo $args|sed 's,^,$,;s/ / $/')
+      actual_args=$(eval echo $actual_args)

       (
         (
@@ -115,7 +115,7 @@ for copy in cp mv; do
             for f in $actual_args; do
               test -f $f ||
                 { echo " $copy FAILED but removed $f"; continue; }
-              case "`cat $f`" in
+              case "$(cat $f)" in
                 "$contents") ;;
                 *) echo " $copy FAILED but modified $f";;
               esac
@@ -130,7 +130,7 @@ for copy in cp mv; do
                 if test $copy_status != 0; then
                   test
                 fi
-                case "`cat $f`" in
+                case "$(cat $f)" in
                   "$contents") ;;
                   *) echo " $copy FAILED";;
                 esac
diff --git a/tests/mv/partition-perm b/tests/mv/partition-perm
index 65ae5d0..bbda9da 100755
--- a/tests/mv/partition-perm
+++ b/tests/mv/partition-perm
@@ -31,7 +31,7 @@ test -f file && fail=1
 test -f "$other_partition_tmpdir/file" || fail=1

 # This would have failed with the mv from fileutils-4.0i.
-mode=`ls -l "$other_partition_tmpdir/file" | cut -b-10`
+mode=$(ls -l "$other_partition_tmpdir/file" | cut -b-10)
 test "$mode" = "-rwxrwxrwx" || fail=1

 Exit $fail
diff --git a/tests/mv/to-symlink b/tests/mv/to-symlink
index 2a064b6..c203d7a 100755
--- a/tests/mv/to-symlink
+++ b/tests/mv/to-symlink
@@ -38,6 +38,6 @@ mv $file $rem_symlink || fail=1
 test -f $file && fail=1

 # Make sure $rem_file is unmodified.
-test `cat $rem_file` = remote || fail=1
+test $(cat $rem_file) = remote || fail=1

 Exit $fail
diff --git a/tests/mv/update b/tests/mv/update
index d002a18..f0beb40 100755
--- a/tests/mv/update
+++ b/tests/mv/update
@@ -31,15 +31,15 @@ for interactive in '' -i; do
     # mistakenly elicit a prompt.
     $cp_or_mv $interactive --update old new < /dev/null > out 2>&1 || fail=1
     test -s out && fail=1
-    case "`cat new`" in new) ;; *) fail=1 ;; esac
-    case "`cat old`" in old) ;; *) fail=1 ;; esac
+    case "$(cat new)" in new) ;; *) fail=1 ;; esac
+    case "$(cat old)" in old) ;; *) fail=1 ;; esac
   done
 done

 # This will actually perform the rename.
 mv --update new old || fail=1
 test -f new && fail=1
-case "`cat old`" in new) ;; *) fail=1 ;; esac
+case "$(cat old)" in new) ;; *) fail=1 ;; esac

 # Restore initial conditions.
 echo old > old || fail=1
@@ -48,7 +48,7 @@ echo new > new || fail=1

 # This will actually perform the copy.
 cp --update new old || fail=1
-case "`cat old`" in new) ;; *) fail=1 ;; esac
-case "`cat new`" in new) ;; *) fail=1 ;; esac
+case "$(cat old)" in new) ;; *) fail=1 ;; esac
+case "$(cat new)" in new) ;; *) fail=1 ;; esac

 Exit $fail
diff --git a/tests/other-fs-tmpdir b/tests/other-fs-tmpdir
index d3d3a55..4bdfe6f 100644
--- a/tests/other-fs-tmpdir
+++ b/tests/other-fs-tmpdir
@@ -24,13 +24,13 @@ test "${CANDIDATE_TMP_DIRS+set}" = set \

 other_partition_tmpdir=

-dot_mount_point=`stat -c %d .`
+dot_mount_point=$(stat -c %d .)
 for d in $CANDIDATE_TMP_DIRS; do

   # Skip nonexistent directories.
   test -d "$d" || continue

-  d_mount_point=`stat -L -c %d "$d"`
+  d_mount_point=$(stat -L -c %d "$d")

   # Same partition?  Skip it.
   test "x$d_mount_point" = "x$dot_mount_point" && continue
diff --git a/tests/readlink/can-e b/tests/readlink/can-e
index 5dc7389..32b75c5 100755
--- a/tests/readlink/can-e
+++ b/tests/readlink/can-e
@@ -19,7 +19,7 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ readlink

-pwd=`pwd`
+pwd=$(pwd)
 my_pwd=$("$abs_top_builddir/src/pwd")
 tmp=d

@@ -38,7 +38,7 @@ cd "$pwd/$tmp/removed" || framework_failure_

 # Skip this test if the system doesn't let you remove the working directory.
 if rmdir ../removed 2>/dev/null; then
-  v=`readlink -e .` && fail=1
+  v=$(readlink -e .) && fail=1
   test -z "$v" || fail=1
 fi

@@ -46,58 +46,58 @@ cd "$pwd/$tmp" || fail=1

 for p in "" "$pwd/$tmp/"; do

-  v=`readlink -e "${p}regfile"` || fail=1
+  v=$(readlink -e "${p}regfile") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile" || fail=1

-  v=`readlink -e "${p}./regfile/"` && fail=1
+  v=$(readlink -e "${p}./regfile/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}subdir"` || fail=1
+  v=$(readlink -e "${p}subdir") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -e "${p}./subdir/"` || fail=1
+  v=$(readlink -e "${p}./subdir/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -e "${p}missing"` && fail=1
+  v=$(readlink -e "${p}missing") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}./missing/"` && fail=1
+  v=$(readlink -e "${p}./missing/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}link1"` || fail=1
+  v=$(readlink -e "${p}link1") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile" || fail=1

-  v=`readlink -e "${p}./link1/"` && fail=1
+  v=$(readlink -e "${p}./link1/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}link1/more"` && fail=1
+  v=$(readlink -e "${p}link1/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}link2"` || fail=1
+  v=$(readlink -e "${p}link2") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -e "${p}./link2/"` || fail=1
+  v=$(readlink -e "${p}./link2/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -e "${p}link2/more"` && fail=1
+  v=$(readlink -e "${p}link2/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}link3"` && fail=1
+  v=$(readlink -e "${p}link3") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}./link3/"` && fail=1
+  v=$(readlink -e "${p}./link3/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}link3/more"` && fail=1
+  v=$(readlink -e "${p}link3/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}link4"` && fail=1
+  v=$(readlink -e "${p}link4") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}./link4/"` && fail=1
+  v=$(readlink -e "${p}./link4/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -e "${p}link4/more"` && fail=1
+  v=$(readlink -e "${p}link4/more") && fail=1
   test -z "$v" || fail=1
 done

diff --git a/tests/readlink/can-f b/tests/readlink/can-f
index aff8c80..3f29601 100755
--- a/tests/readlink/can-f
+++ b/tests/readlink/can-f
@@ -19,7 +19,7 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ readlink

-pwd=`pwd`
+pwd=$(pwd)
 my_pwd=$("$abs_top_builddir/src/pwd")
 tmp=d

@@ -39,7 +39,7 @@ cd "$pwd/$tmp/removed" || framework_failure_

 # Skip this test if the system doesn't let you remove the working directory.
 if rmdir ../removed 2>/dev/null; then
-  v=`readlink -e .` && fail=1
+  v=$(readlink -e .) && fail=1
   test -z "$v" || fail=1
 fi

@@ -47,106 +47,106 @@ cd "$pwd/$tmp" || fail=1

 for p in "" "$pwd/$tmp/"; do

-  v=`readlink -f "${p}regfile"` || fail=1
+  v=$(readlink -f "${p}regfile") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile" || fail=1

-  v=`readlink -f "${p}./regfile/"` && fail=1
+  v=$(readlink -f "${p}./regfile/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}regfile/more"` && fail=1
+  v=$(readlink -f "${p}regfile/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}./regfile/more/"` && fail=1
+  v=$(readlink -f "${p}./regfile/more/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}subdir"` || fail=1
+  v=$(readlink -f "${p}subdir") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -f "${p}./subdir/"` || fail=1
+  v=$(readlink -f "${p}./subdir/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -f "${p}subdir/more"` || fail=1
+  v=$(readlink -f "${p}subdir/more") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more" || fail=1

-  v=`readlink -f "${p}./subdir/more/"` || fail=1
+  v=$(readlink -f "${p}./subdir/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more" || fail=1

-  v=`readlink -f "${p}missing"` || fail=1
+  v=$(readlink -f "${p}missing") || fail=1
   test "$v" = "$my_pwd/$tmp/missing" || fail=1

-  v=`readlink -f "${p}./missing/"` || fail=1
+  v=$(readlink -f "${p}./missing/") || fail=1
   test "$v" = "$my_pwd/$tmp/missing" || fail=1

-  v=`readlink -f "${p}missing/more"` && fail=1
+  v=$(readlink -f "${p}missing/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}./missing/more/"` && fail=1
+  v=$(readlink -f "${p}./missing/more/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}link1"` || fail=1
+  v=$(readlink -f "${p}link1") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile" || fail=1

-  v=`readlink -f "${p}./link1/"` && fail=1
+  v=$(readlink -f "${p}./link1/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}link1/more"` && fail=1
+  v=$(readlink -f "${p}link1/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}./link1/more/"` && fail=1
+  v=$(readlink -f "${p}./link1/more/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}link2"` || fail=1
+  v=$(readlink -f "${p}link2") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -f "${p}./link2/"` || fail=1
+  v=$(readlink -f "${p}./link2/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -f "${p}link2/more"` || fail=1
+  v=$(readlink -f "${p}link2/more") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more" || fail=1

-  v=`readlink -f "${p}./link2/more/"` || fail=1
+  v=$(readlink -f "${p}./link2/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more" || fail=1

-  v=`readlink -f "${p}link2/more/more2"` && fail=1
+  v=$(readlink -f "${p}link2/more/more2") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}./link2/more/more2/"` && fail=1
+  v=$(readlink -f "${p}./link2/more/more2/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}link3"` || fail=1
+  v=$(readlink -f "${p}link3") || fail=1
   test "$v" = "$my_pwd/$tmp/missing" || fail=1

-  v=`readlink -f "${p}./link3/"` || fail=1
+  v=$(readlink -f "${p}./link3/") || fail=1
   test "$v" = "$my_pwd/$tmp/missing" || fail=1

-  v=`readlink -f "${p}link3/more"` && fail=1
+  v=$(readlink -f "${p}link3/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}./link3/more/"` && fail=1
+  v=$(readlink -f "${p}./link3/more/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}link4"` || fail=1
+  v=$(readlink -f "${p}link4") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/missing" || fail=1

-  v=`readlink -f "${p}./link4/"` || fail=1
+  v=$(readlink -f "${p}./link4/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/missing" || fail=1

-  v=`readlink -f "${p}link4/more"` && fail=1
+  v=$(readlink -f "${p}link4/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}./link4/more"` && fail=1
+  v=$(readlink -f "${p}./link4/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}link5"` && fail=1
+  v=$(readlink -f "${p}link5") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}./link5/"` && fail=1
+  v=$(readlink -f "${p}./link5/") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}link5/more"` && fail=1
+  v=$(readlink -f "${p}link5/more") && fail=1
   test -z "$v" || fail=1

-  v=`readlink -f "${p}./link5/more"` && fail=1
+  v=$(readlink -f "${p}./link5/more") && fail=1
   test -z "$v" || fail=1
 done

diff --git a/tests/readlink/can-m b/tests/readlink/can-m
index d3e0b7c..09a96f5 100755
--- a/tests/readlink/can-m
+++ b/tests/readlink/can-m
@@ -19,7 +19,7 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ readlink

-pwd=`pwd`
+pwd=$(pwd)
 my_pwd=$("$abs_top_builddir/src/pwd")
 tmp=d

@@ -38,7 +38,7 @@ cd "$pwd/$tmp/removed" || framework_failure_

 # Skip this test if the system doesn't let you remove the working directory.
 if rmdir ../removed 2>/dev/null; then
-  v=`readlink -e .` && fail=1
+  v=$(readlink -e .) && fail=1
   test -z "$v" || fail=1
 fi

@@ -46,94 +46,94 @@ cd "$pwd/$tmp" || fail=1

 for p in "" "$pwd/$tmp/"; do

-  v=`readlink -m "${p}regfile"` || fail=1
+  v=$(readlink -m "${p}regfile") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile" || fail=1

-  v=`readlink -m "${p}./regfile/"` || fail=1
+  v=$(readlink -m "${p}./regfile/") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile" || fail=1

-  v=`readlink -m "${p}regfile/more"` || fail=1
+  v=$(readlink -m "${p}regfile/more") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile/more" || fail=1

-  v=`readlink -m "${p}./regfile/more/"` || fail=1
+  v=$(readlink -m "${p}./regfile/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile/more" || fail=1

-  v=`readlink -m "${p}subdir"` || fail=1
+  v=$(readlink -m "${p}subdir") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -m "${p}./subdir/"` || fail=1
+  v=$(readlink -m "${p}./subdir/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -m "${p}subdir/more"` || fail=1
+  v=$(readlink -m "${p}subdir/more") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more" || fail=1

-  v=`readlink -m "${p}./subdir/more/"` || fail=1
+  v=$(readlink -m "${p}./subdir/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more" || fail=1

-  v=`readlink -m "${p}missing"` || fail=1
+  v=$(readlink -m "${p}missing") || fail=1
   test "$v" = "$my_pwd/$tmp/missing" || fail=1

-  v=`readlink -m "${p}./missing/"` || fail=1
+  v=$(readlink -m "${p}./missing/") || fail=1
   test "$v" = "$my_pwd/$tmp/missing" || fail=1

-  v=`readlink -m "${p}missing/more"` || fail=1
+  v=$(readlink -m "${p}missing/more") || fail=1
   test "$v" = "$my_pwd/$tmp/missing/more" || fail=1

-  v=`readlink -m "${p}./missing/more/"` || fail=1
+  v=$(readlink -m "${p}./missing/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/missing/more" || fail=1

-  v=`readlink -m "${p}link1"` || fail=1
+  v=$(readlink -m "${p}link1") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile" || fail=1

-  v=`readlink -m "${p}./link1/"` || fail=1
+  v=$(readlink -m "${p}./link1/") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile" || fail=1

-  v=`readlink -m "${p}link1/more"` || fail=1
+  v=$(readlink -m "${p}link1/more") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile/more" || fail=1

-  v=`readlink -m "${p}./link1/more/"` || fail=1
+  v=$(readlink -m "${p}./link1/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/regfile/more" || fail=1

-  v=`readlink -m "${p}link2"` || fail=1
+  v=$(readlink -m "${p}link2") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -m "${p}./link2/"` || fail=1
+  v=$(readlink -m "${p}./link2/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir" || fail=1

-  v=`readlink -m "${p}link2/more"` || fail=1
+  v=$(readlink -m "${p}link2/more") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more" || fail=1

-  v=`readlink -m "${p}./link2/more/"` || fail=1
+  v=$(readlink -m "${p}./link2/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more" || fail=1

-  v=`readlink -m "${p}link2/more/more2"` || fail=1
+  v=$(readlink -m "${p}link2/more/more2") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more/more2" || fail=1

-  v=`readlink -m "${p}./link2/more/more2/"` || fail=1
+  v=$(readlink -m "${p}./link2/more/more2/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/more/more2" || fail=1

-  v=`readlink -m "${p}link3"` || fail=1
+  v=$(readlink -m "${p}link3") || fail=1
   test "$v" = "$my_pwd/$tmp/missing" || fail=1

-  v=`readlink -m "${p}./link3/"` || fail=1
+  v=$(readlink -m "${p}./link3/") || fail=1
   test "$v" = "$my_pwd/$tmp/missing" || fail=1

-  v=`readlink -m "${p}link3/more"` || fail=1
+  v=$(readlink -m "${p}link3/more") || fail=1
   test "$v" = "$my_pwd/$tmp/missing/more" || fail=1

-  v=`readlink -m "${p}./link3/more/"` || fail=1
+  v=$(readlink -m "${p}./link3/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/missing/more" || fail=1

-  v=`readlink -m "${p}link4"` || fail=1
+  v=$(readlink -m "${p}link4") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/missing" || fail=1

-  v=`readlink -m "${p}./link4/"` || fail=1
+  v=$(readlink -m "${p}./link4/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/missing" || fail=1

-  v=`readlink -m "${p}link4/more"` || fail=1
+  v=$(readlink -m "${p}link4/more") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/missing/more" || fail=1

-  v=`readlink -m "${p}./link4/more/"` || fail=1
+  v=$(readlink -m "${p}./link4/more/") || fail=1
   test "$v" = "$my_pwd/$tmp/subdir/missing/more" || fail=1

 done
diff --git a/tests/readlink/rl-1 b/tests/readlink/rl-1
index 7f2ddc2..511a989 100755
--- a/tests/readlink/rl-1
+++ b/tests/readlink/rl-1
@@ -25,19 +25,19 @@ ln -s regfile link1 || framework_failure_
 ln -s missing link2 || framework_failure_


-v=`readlink link1` || fail=1
+v=$(readlink link1) || fail=1
 test "$v" = regfile || fail=1

-v=`readlink link2` || fail=1
+v=$(readlink link2) || fail=1
 test "$v" = missing || fail=1

-v=`readlink subdir` && fail=1
+v=$(readlink subdir) && fail=1
 test -z "$v" || fail=1

-v=`readlink regfile` && fail=1
+v=$(readlink regfile) && fail=1
 test -z "$v" || fail=1

-v=`readlink missing` && fail=1
+v=$(readlink missing) && fail=1
 test -z "$v" || fail=1

 Exit $fail
diff --git a/tests/rm/hash b/tests/rm/hash
index dc443e1..344325e 100755
--- a/tests/rm/hash
+++ b/tests/rm/hash
@@ -24,7 +24,7 @@ expensive_

 # Create a hierarchy with 3*26 leaf directories, each at depth 153.
 echo "$0: creating 78 trees, each of depth 153; this will take a while..." >&2
-y=`seq 1 150|tr -sc '\n' y|tr '\n' /`
+y=$(seq 1 150|tr -sc '\n' y|tr '\n' /)
 for i in 1 2 3; do
   for j in a b c d e f g h i j k l m n o p q r s t u v w x y z; do
     mkdir -p t/$i/$j/$y || framework_failure_
diff --git a/tests/rm/inaccessible b/tests/rm/inaccessible
index e9e1788..2f04581 100755
--- a/tests/rm/inaccessible
+++ b/tests/rm/inaccessible
@@ -25,7 +25,7 @@ print_ver_ rm
 require_openat_support_
 skip_if_root_

-p=`pwd`
+p=$(pwd)
 mkdir abs1 abs2 no-access || framework_failure_


diff --git a/tests/rm/ir-1 b/tests/rm/ir-1
index ac29590..01b33bc 100755
--- a/tests/rm/ir-1
+++ b/tests/rm/ir-1
@@ -48,7 +48,7 @@ rm --verbose -i -r $t < in > /dev/null 2>&1 || fail=1
 test -d $t || fail=1

 # There should be only one directory left.
-case `echo $t/*` in
+case $(echo $t/*) in
   $t/[abc]) ;;
   *) fail=1 ;;
 esac
diff --git a/tests/rm/read-only b/tests/rm/read-only
index e530dce..018648b 100755
--- a/tests/rm/read-only
+++ b/tests/rm/read-only
@@ -20,7 +20,7 @@
 print_ver_ rm
 require_root_

-cwd=`pwd`
+cwd=$(pwd)
 cleanup_() { cd /; umount "$cwd/mnt"; }

 skip=0
diff --git a/tests/rm/readdir-bug b/tests/rm/readdir-bug
index 939ce98..711e1bc 100755
--- a/tests/rm/readdir-bug
+++ b/tests/rm/readdir-bug
@@ -26,8 +26,8 @@ print_ver_ rm
 # http://lists.gnu.org/archive/html/bug-coreutils/2006-09/msg00326.html
 mkdir b || framework_failure_
 cd b || framework_failure_
-for i in `seq 1 250`; do
-  touch `printf %040d $i` || framework_failure_
+for i in $(seq 1 250); do
+  touch $(printf %040d $i) || framework_failure_
 done
 cd .. || framework_failure_

diff --git a/tests/rm/unread3 b/tests/rm/unread3
index 336c05a..4b8bbc2 100755
--- a/tests/rm/unread3
+++ b/tests/rm/unread3
@@ -23,7 +23,7 @@ skip_if_root_
 mkdir -p a/1 b c d/2 e/3 || framework_failure_


-t=`pwd`
+t=$(pwd)
 cd c
 chmod u=x,go= .

diff --git a/tests/rmdir/ignore b/tests/rmdir/ignore
index dd02819..92463b8 100755
--- a/tests/rmdir/ignore
+++ b/tests/rmdir/ignore
@@ -19,7 +19,7 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ rmdir

-cwd=`pwd`
+cwd=$(pwd)
 mkdir -p "$cwd/a/b/c" "$cwd/a/x" || framework_failure_

 rmdir -p --ignore-fail-on-non-empty "$cwd/a/b/c" || fail=1
diff --git a/tests/tail-2/assert b/tests/tail-2/assert
index 37b9afb..043e259 100755
--- a/tests/tail-2/assert
+++ b/tests/tail-2/assert
@@ -51,7 +51,7 @@ mv f foo
 # echo waiting....
 wait

-case "`cat err`" in
+case "$(cat err)" in
   *$ok) ;;
   *) fail=1;;
 esac
diff --git a/tests/tail-2/assert-2 b/tests/tail-2/assert-2
index e6c95f8..d94d3d8 100755
--- a/tests/tail-2/assert-2
+++ b/tests/tail-2/assert-2
@@ -39,7 +39,7 @@ mv f foo
 # echo waiting....
 wait

-case "`cat err`" in
+case "$(cat err)" in
   *$ok) ;;
   *) fail=1;;
 esac
diff --git a/tests/touch/dangling-symlink b/tests/touch/dangling-symlink
index 576a302..1eb2ed3 100755
--- a/tests/touch/dangling-symlink
+++ b/tests/touch/dangling-symlink
@@ -32,7 +32,7 @@ rm -f touch-target t-symlink
 if test $fail = 1; then
   case $host_triplet in
     *linux-gnu*)
-      case "`uname -r`" in
+      case "$(uname -r)" in
         2.3.9[0-9]*)
           skip_ \
 '****************************************************
diff --git a/tests/touch/empty-file b/tests/touch/empty-file
index cd679c4..a150bd5 100755
--- a/tests/touch/empty-file
+++ b/tests/touch/empty-file
@@ -48,7 +48,7 @@ echo sleeping for $SLEEP_SECONDS seconds...
 sleep $SLEEP_SECONDS
 for d in $TOUCH_DIR_LIST; do
   touch $d/a || fail=1
-  set x `ls -t $d/a $d/b`
+  set x $(ls -t $d/a $d/b)
   test "$*" = "x $d/a $d/b" || fail=1
 done

@@ -56,11 +56,11 @@ echo sleeping for $SLEEP_SECONDS seconds...
 sleep $SLEEP_SECONDS
 for d in $TOUCH_DIR_LIST; do
   touch $d/b
-  set x `ls -t $d/a $d/b`
+  set x $(ls -t $d/a $d/b)
   test "$*" = "x $d/b $d/a" || fail=1

   if touch - 1< $d/c 2> /dev/null; then
-    set x `ls -t $d/a $d/c`
+    set x $(ls -t $d/a $d/c)
     test "$*" = "x $d/c $d/a" || fail=1
   fi

diff --git a/tests/touch/no-dereference b/tests/touch/no-dereference
index 6f03142..aee9a5c 100755
--- a/tests/touch/no-dereference
+++ b/tests/touch/no-dereference
@@ -58,11 +58,11 @@ esac

 # Change the mtime of a symlink.
 touch -m -h -d 2009-10-10 link || fail=1
-case `stat --format=%y link` in
+case $(stat --format=%y link) in
   2009-10-10*) ;;
   *) fail=1 ;;
 esac
-case `stat --format=%y file` in
+case $(stat --format=%y file) in
   2009-10-10*) fail=1;;
 esac

diff --git a/tests/touch/no-rights b/tests/touch/no-rights
index 25364e2..abebc52 100755
--- a/tests/touch/no-rights
+++ b/tests/touch/no-rights
@@ -24,14 +24,14 @@ print_ver_ touch
 touch -d '2000-01-01 00:00' t1 || framework_failure_
 touch -d '2000-01-02 00:00' t2 || framework_failure_

-set x `ls -t t1 t2`
+set x $(ls -t t1 t2)
 test "$*" = "x t2 t1" || framework_failure_


 chmod 0 t1
 touch -d '2000-01-03 00:00' -c t1 || fail=1

-set x `ls -t t1 t2`
+set x $(ls -t t1 t2)
 test "$*" = "x t1 t2" || fail=1

 # Also test the combination of --no-create and -a.
diff --git a/tests/touch/trailing-slash b/tests/touch/trailing-slash
index f9c32fd..f09695c 100755
--- a/tests/touch/trailing-slash
+++ b/tests/touch/trailing-slash
@@ -51,14 +51,14 @@ test -f nowhere && fail=1
 # symlinks and directories under Cygwin 1.5).
 touch -d 2009-10-10 -h link2/ || fail=1
 touch -h -r link2/ file || fail=1
-case `stat --format=%y dir` in
+case $(stat --format=%y dir) in
   2009-10-10*) ;;
   *) fail=1 ;;
 esac
-case `stat --format=%y link2` in
+case $(stat --format=%y link2) in
   2009-10-10*) fail=1 ;;
 esac
-case `stat --format=%y file` in
+case $(stat --format=%y file) in
   2009-10-10*) ;;
   *) fail=1 ;;
 esac
-- 
1.7.9.3



From MAILER-DAEMON Wed Apr 04 08:33:46 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFPPG-0003zv-3G
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 08:33:46 -0400
Received: from eggs.gnu.org ([208.118.235.92]:50736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPP9-0003yf-7H
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:33:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPP2-0006U7-Mk
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:33:38 -0400
Received: from mx.meyering.net ([88.168.87.75]:46699)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPP2-0006Tr-Dz
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:33:32 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id AB3D76008A
	for <coreutils@gnu.org>; Wed,  4 Apr 2012 14:33:29 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] tests: correct reversed args to "compare"
Date: Wed, 04 Apr 2012 14:33:29 +0200
Message-ID: <87limby8va.fsf@rho.meyering.net>
Lines: 67
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 12:33:45 -0000

I noticed the underlying problem with maint.mk when my new
backtick-prohibiting rule failed to detect the three offenders.
Once I fixed the problem by updating to newer gnulib with fixed
maint.mk, I found that "make syntax-check" failed with this:

    tests/misc/sort-discrim:36:compare out exp || fail=1
    tests/misc/sort-discrim:86:  compare out exp || fail=1
    maint.mk: reversed compare arguments
    make[3]: *** [sc_prohibit_reversed_compare_failure] Error 1


>From 89779e84970841708596223d6c85a7b58cb65878 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 4 Apr 2012 14:29:44 +0200
Subject: [PATCH 1/2] tests: correct reversed args to "compare"

* tests/misc/sort-discrim: Correct reversed args to "compare".
This nit was masked by a bug in maint.mk that effectively disabled
many of the syntax-check rules.
---
 tests/misc/sort-discrim |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/misc/sort-discrim b/tests/misc/sort-discrim
index 14ae6cc..fced204 100755
--- a/tests/misc/sort-discrim
+++ b/tests/misc/sort-discrim
@@ -33,7 +33,7 @@ getlimits_
 long_prefix='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
 seq -f "$long_prefix%5.0f" 10000 > exp || fail=1
 sort -R exp | LC_ALL=C sort > out || fail=1
-compare out exp || fail=1
+compare exp out || fail=1


 # Test numeric sorting.
@@ -83,7 +83,7 @@ max_frac160=$(expr $INTMAX_MAX / 16 % 10) &&

 for opts in -n -h; do
   sort -R exp | LC_ALL=C sort $opts > out || fail=1
-  compare out exp || fail=1
+  compare exp out || fail=1
 done

 Exit $fail
--
1.7.9.3


>From 9cf086f31804c0fb1460e99080a12fb455659206 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 4 Apr 2012 14:05:44 +0200
Subject: [PATCH 2/2] build: update gnulib submodule to latest

---
 gnulib |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnulib b/gnulib
index 880a2f6..d4cecf1 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 880a2f6db9e37ef84347a47b15f88bef741c03da
+Subproject commit d4cecf1ee37f6b611ef092c9c7fa3761d02ce2c3
--
1.7.9.3


From MAILER-DAEMON Wed Apr 04 08:34:25 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFPPt-00045b-7h
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 08:34:25 -0400
Received: from eggs.gnu.org ([208.118.235.92]:50868)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPPn-00044g-0s
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:34:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPPe-0006Z6-DU
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:34:18 -0400
Received: from mx.meyering.net ([88.168.87.75]:46706)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPPe-0006Yi-5m
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:34:10 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id C2A296008A
	for <coreutils@gnu.org>; Wed,  4 Apr 2012 14:34:08 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] tests: new syntax-check rule to prohibit use of `...` in
Date: Wed, 04 Apr 2012 14:34:08 +0200
Message-ID: <87fwcjy8u7.fsf@rho.meyering.net>
Lines: 39
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 12:34:23 -0000

FYI, here's the new syntax-check rule:

>From e82602833d5c79f07198b61f2f42240b3edf2ba0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 4 Apr 2012 12:34:22 +0200
Subject: [PATCH] tests: new syntax-check rule to prohibit use of `...` in
 tests/

* cfg.mk (sc_prohibit_test_backticks): New rule.  Exempt 3 files.
---
 cfg.mk |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index ef7118a..c3ddb42 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -303,6 +303,12 @@ sc_prohibit_framework_failure:
 	halt='use framework_failure_ instead'				\
 	  $(_sc_search_regexp)

+# Prohibit the use of `...` in tests/.  Use $(...) instead.
+sc_prohibit_test_backticks:
+	@prohibit='`' in_vc_files='^tests/'				\
+	halt='use $$(...), not `...` in tests/'				\
+	  $(_sc_search_regexp)
+
 # Exempt the contents of any usage function from the following.
 _continued_string_col_1 = \
 s/^usage .*?\n}//ms;/\\\n\w/ and print ("$$ARGV\n"),$$e=1;END{$$e||=0;exit $$e}
@@ -447,3 +453,6 @@ exclude_file_name_regexp--sc_prohibit_stat_st_blocks = \

 exclude_file_name_regexp--sc_prohibit_continued_string_alpha_in_column_1 = \
   ^src/(system\.h|od\.c|printf\.c)$$
+
+exclude_file_name_regexp--sc_prohibit_test_backticks = \
+  ^tests/(init\.sh|check\.mk|misc/stdbuf)$$
--
1.7.9.3


From MAILER-DAEMON Wed Apr 04 08:36:42 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFPS6-00056Z-Up
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 08:36:42 -0400
Received: from eggs.gnu.org ([208.118.235.92]:51374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPS1-00052n-8z
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:36:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPRy-0007Mi-Ph
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:36:36 -0400
Received: from mx.meyering.net ([88.168.87.75]:46715)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFPRy-0007MX-Hb
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:36:34 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 8EE116008A
	for <coreutils@gnu.org>; Wed,  4 Apr 2012 14:36:32 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: amendments to backtick-removing series
Date: Wed, 04 Apr 2012 14:36:32 +0200
Message-ID: <87d37ny8q7.fsf@rho.meyering.net>
Lines: 99
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 12:36:41 -0000

init.cfg need not be exempted, since its functions are
invoked only after init.sh has re-exec'd a usable shell, so
I've converted it, too.

Testing on Solaris 10 exposed problems with quoting
where $( ... "\\\...) behaves differently from ` ..."\\\...`.
That was the impetus for the following change, below.

diff --git a/tests/init.cfg b/tests/init.cfg
index 17713d9..7bcd512 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -235,9 +235,9 @@ rwx_to_mode_()
   s='s/S/@/;s/s/x@/;s/@/s/'
   t='s/T/@/;s/t/x@/;s/@/t/'

-  u=`echo $rwx|sed 's/^.\(...\).*/,u=\1/;s/-//g;s/^,u=$//;'$s`
-  g=`echo $rwx|sed 's/^....\(...\).*/,g=\1/;s/-//g;s/^,g=$//;'$s`
-  o=`echo $rwx|sed 's/^.......\(...\).*/,o=\1/;s/-//g;s/^,o=$//;'$s';'$t`
+  u=$(echo $rwx|sed 's/^.\(...\).*/,u=\1/;s/-//g;s/^,u=$//;'$s)
+  g=$(echo $rwx|sed 's/^....\(...\).*/,g=\1/;s/-//g;s/^,g=$//;'$s)
+  o=$(echo $rwx|sed 's/^.......\(...\).*/,o=\1/;s/-//g;s/^,o=$//;'$s';'$t)
   echo "=$u$g$o"
 }

@@ -259,7 +259,7 @@ require_selinux_()

   # Independent of whether SELinux is enabled system-wide,
   # the current file system may lack SELinux support.
-  case `ls -Zd .` in
+  case $(ls -Zd .) in
     '? .'|'unlabeled .')
       skip_ "this system (or maybe just" \
         "the current file system) lacks SELinux support"
@@ -316,7 +316,7 @@ require_membership_in_two_groups_()
 {
   test $# = 0 || framework_failure_

-  groups=${COREUTILS_GROUPS-`(id -G || /usr/xpg4/bin/id -G) 2>/dev/null`}
+  groups=${COREUTILS_GROUPS-$( (id -G || /usr/xpg4/bin/id -G) 2>/dev/null)}
   case "$groups" in
     *' '*) ;;
     *) skip_ 'requires membership in two groups
@@ -389,7 +389,7 @@ require_sparse_support_()
   # NTFS requires 128K before a hole appears in a sparse file.
   t=sparse.$$
   dd bs=1 seek=128K of=$t < /dev/null 2> /dev/null
-  set x `du -sk $t`
+  set x $(du -sk $t)
   kb_size=$2
   rm -f $t
   if test $kb_size -ge 128; then
@@ -447,7 +447,7 @@ working_umask_or_skip_()
   umask 022
   touch file1 file2
   chmod 644 file2
-  perms=`ls -l file1 file2 | sed 's/ .*//' | uniq`
+  perms=$(ls -l file1 file2 | sed 's/ .*//' | uniq)
   rm -f file1 file2

   case $perms in
@@ -463,7 +463,7 @@ working_umask_or_skip_()
 # an initial delay of .1 second and call it at most 6 times
 # with a max delay of 3.2s (doubled each time), or a total of 6.3s
 # Note ensure you do _not_ quote the parameter to GNU sleep in
-# your function, as it may contain separate values that `sleep`
+# your function, as it may contain separate values that sleep
 # needs to accumulate.
 retry_delay_()
 {
--
1.7.9.3



diff --git a/tests/misc/stty b/tests/misc/stty
index fe4a4c8..97020e8 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -70,7 +70,7 @@ for opt in $options; do

   # Likewise, 'stty -cread' would fail, so skip that, too.
   test $opt = cread && continue
-  rev=$(eval echo "\\\$REV_$opt")
+  rev=$(eval echo "\$REV_$opt")
   if test -n "$rev"; then
     stty -$opt || { fail=1; echo -$opt; }
   fi
@@ -84,8 +84,8 @@ if test -n "$RUN_LONG_TESTS"; then

       stty $opt1 $opt2 || fail=1

-      rev1=$(eval echo "\\\$REV_$opt1")
-      rev2=$(eval echo "\\\$REV_$opt2")
+      rev1=$(eval echo "\$REV_$opt1")
+      rev2=$(eval echo "\$REV_$opt2")
       if test -n "$rev1"; then
         stty -$opt1 $opt2 || fail=1
       fi


From MAILER-DAEMON Wed Apr 04 08:42:35 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFPXm-0006kk-V1
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 08:42:34 -0400
Received: from eggs.gnu.org ([208.118.235.92]:51176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1SFPXg-0006ig-9f
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:42:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1SFPXa-0000wR-2e
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:42:27 -0400
Received: from mail-out.m-online.net ([212.18.0.9]:39870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1SFPXZ-0000vb-Sf
	for coreutils@gnu.org; Wed, 04 Apr 2012 08:42:21 -0400
Received: from frontend1.mail.m-online.net (unknown [192.168.8.180])
	by mail-out.m-online.net (Postfix) with ESMTP id 3VN6J82qj8z4Kh1p;
	Wed,  4 Apr 2012 14:42:16 +0200 (CEST)
Received: from igel.home (ppp-88-217-110-82.dynamic.mnet-online.de
	[88.217.110.82])
	by mail.mnet-online.de (Postfix) with ESMTPA id 3VN6J76ySDz4KK6T;
	Wed,  4 Apr 2012 14:42:15 +0200 (CEST)
Received: by igel.home (Postfix, from userid 501)
	id 791F0CA2A0; Wed,  4 Apr 2012 14:42:14 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org>
Subject: Re: amendments to backtick-removing series
References: <87d37ny8q7.fsf@rho.meyering.net>
X-Yow: WHO sees a BEACH BUNNY sobbing on a SHAG RUG?!
Date: Wed, 04 Apr 2012 14:42:14 +0200
In-Reply-To: <87d37ny8q7.fsf@rho.meyering.net> (Jim Meyering's message of
	"Wed, 04 Apr 2012 14:36:32 +0200")
Message-ID: <m2iphfvfbt.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Received-From: 212.18.0.9
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 12:42:34 -0000

Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org> writes:

> diff --git a/tests/misc/stty b/tests/misc/stty
> index fe4a4c8..97020e8 100755
> --- a/tests/misc/stty
> +++ b/tests/misc/stty
> @@ -70,7 +70,7 @@ for opt in $options; do
>
>    # Likewise, 'stty -cread' would fail, so skip that, too.
>    test $opt = cread && continue
> -  rev=$(eval echo "\\\$REV_$opt")
> +  rev=$(eval echo "\$REV_$opt")
     eval rev=\$REV_$opt

> @@ -84,8 +84,8 @@ if test -n "$RUN_LONG_TESTS"; then
>
>        stty $opt1 $opt2 || fail=1
>
> -      rev1=$(eval echo "\\\$REV_$opt1")
> -      rev2=$(eval echo "\\\$REV_$opt2")
> +      rev1=$(eval echo "\$REV_$opt1")
> +      rev2=$(eval echo "\$REV_$opt2")
         eval rev1=\$REV_$opt1
         eval rev2=\$REV_$opt2

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


From MAILER-DAEMON Wed Apr 04 09:31:14 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFQIs-0000cU-C3
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 09:31:14 -0400
Received: from eggs.gnu.org ([208.118.235.92]:38829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFQIh-0000aG-CT
	for coreutils@gnu.org; Wed, 04 Apr 2012 09:31:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFQIa-00065s-O7
	for coreutils@gnu.org; Wed, 04 Apr 2012 09:31:02 -0400
Received: from mx.meyering.net ([88.168.87.75]:46870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFQIa-00065a-GG
	for coreutils@gnu.org; Wed, 04 Apr 2012 09:30:56 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 506B560056;
	Wed,  4 Apr 2012 15:30:53 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: amendments to backtick-removing series
In-Reply-To: <m2iphfvfbt.fsf@igel.home> (Andreas Schwab's message of "Wed, 04
	Apr 2012 14:42:14 +0200")
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
Date: Wed, 04 Apr 2012 15:30:53 +0200
Message-ID: <874nszy67m.fsf@rho.meyering.net>
Lines: 65
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org,
	Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 13:31:12 -0000

Andreas Schwab wrote:
> Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org> writes:
>
>> diff --git a/tests/misc/stty b/tests/misc/stty
>> index fe4a4c8..97020e8 100755
>> --- a/tests/misc/stty
>> +++ b/tests/misc/stty
>> @@ -70,7 +70,7 @@ for opt in $options; do
>>
>>    # Likewise, 'stty -cread' would fail, so skip that, too.
>>    test $opt = cread && continue
>> -  rev=$(eval echo "\\\$REV_$opt")
>> +  rev=$(eval echo "\$REV_$opt")
>      eval rev=\$REV_$opt
>
>> @@ -84,8 +84,8 @@ if test -n "$RUN_LONG_TESTS"; then
>>
>>        stty $opt1 $opt2 || fail=1
>>
>> -      rev1=$(eval echo "\\\$REV_$opt1")
>> -      rev2=$(eval echo "\\\$REV_$opt2")
>> +      rev1=$(eval echo "\$REV_$opt1")
>> +      rev2=$(eval echo "\$REV_$opt2")
>          eval rev1=\$REV_$opt1
>          eval rev2=\$REV_$opt2

Thanks.  I've converted that to a git commit for you:

>From d6f3240af33e81cc294aace9d969ff465e016614 Mon Sep 17 00:00:00 2001
From: Andreas Schwab <schwab@linux-m68k.org>
Date: Wed, 4 Apr 2012 15:06:17 +0200
Subject: [PATCH] tests: avoid unnecessary subshells in misc/stty

* tests/misc/stty: Don't waste a subshell to perform this:
eval rev=\$REV_$opt.  Fix rev1,rev2 assignments similarly.
---
 tests/misc/stty |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/misc/stty b/tests/misc/stty
index 97020e8..fa66a1a 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -70,7 +70,7 @@ for opt in $options; do

   # Likewise, 'stty -cread' would fail, so skip that, too.
   test $opt = cread && continue
-  rev=$(eval echo "\$REV_$opt")
+  eval \$REV_$opt
   if test -n "$rev"; then
     stty -$opt || { fail=1; echo -$opt; }
   fi
@@ -84,8 +84,8 @@ if test -n "$RUN_LONG_TESTS"; then

       stty $opt1 $opt2 || fail=1

-      rev1=$(eval echo "\$REV_$opt1")
-      rev2=$(eval echo "\$REV_$opt2")
+      eval \$REV_$opt1
+      eval \$REV_$opt2
       if test -n "$rev1"; then
         stty -$opt1 $opt2 || fail=1
       fi
--
1.7.9.3


From MAILER-DAEMON Wed Apr 04 10:07:43 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFQsB-0001ZQ-Lm
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 10:07:43 -0400
Received: from eggs.gnu.org ([208.118.235.92]:51014)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1SFQs5-0001Xe-3p
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:07:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1SFQrv-00080t-BF
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:07:34 -0400
Received: from mail-out.m-online.net ([212.18.0.10]:32781)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <whitebox@nefkom.net>) id 1SFQrv-0007zW-5H
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:07:27 -0400
Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net
	[192.168.8.180])
	by mail-out.m-online.net (Postfix) with ESMTP id 3VN8BJ6qnQz3hhYJ;
	Wed,  4 Apr 2012 16:07:20 +0200 (CEST)
Received: from igel.home (ppp-88-217-110-82.dynamic.mnet-online.de
	[88.217.110.82])
	by mail.mnet-online.de (Postfix) with ESMTPA id 3VN8BJ4wqPz4KKJL;
	Wed,  4 Apr 2012 16:07:20 +0200 (CEST)
Received: by igel.home (Postfix, from userid 501)
	id 60877CA2A0; Wed,  4 Apr 2012 16:07:20 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jim Meyering <jim@meyering.net>
Subject: Re: amendments to backtick-removing series
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net>
X-Yow: Concentrate on th'cute, li'l CARTOON GUYS!
	Remember the SERIAL NUMBERS!!  Follow the WHIPPLE AVE EXIT!!
	Have a FREE PEPSI!!  Turn LEFT at th'HOLIDAY INN!!
	JOIN the CREDIT WORLD!!  MAKE me an OFFER!!!
Date: Wed, 04 Apr 2012 16:07:20 +0200
In-Reply-To: <874nszy67m.fsf@rho.meyering.net> (Jim Meyering's message of
	"Wed, 04 Apr 2012 15:30:53 +0200")
Message-ID: <m27gxvvbdz.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Received-From: 212.18.0.10
Cc: coreutils@gnu.org,
	Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 14:07:42 -0000

Jim Meyering <jim@meyering.net> writes:

> diff --git a/tests/misc/stty b/tests/misc/stty
> index 97020e8..fa66a1a 100755
> --- a/tests/misc/stty
> +++ b/tests/misc/stty
> @@ -70,7 +70,7 @@ for opt in $options; do
>
>    # Likewise, 'stty -cread' would fail, so skip that, too.
>    test $opt = cread && continue
> -  rev=$(eval echo "\$REV_$opt")
> +  eval \$REV_$opt

That's not what I wrote.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


From MAILER-DAEMON Wed Apr 04 10:13:31 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFQxn-0003hJ-FJ
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 10:13:31 -0400
Received: from eggs.gnu.org ([208.118.235.92]:44860)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFQxe-0003eo-OA
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:13:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFQxX-0000nw-7X
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:13:22 -0400
Received: from mx.meyering.net ([88.168.87.75]:46985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFQxX-0000nL-0i
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:13:15 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id D24DB6008A;
	Wed,  4 Apr 2012 16:13:08 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: amendments to backtick-removing series
In-Reply-To: <m27gxvvbdz.fsf@igel.home> (Andreas Schwab's message of "Wed, 04
	Apr 2012 16:07:20 +0200")
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
Date: Wed, 04 Apr 2012 16:13:08 +0200
Message-ID: <87sjgjwpor.fsf@rho.meyering.net>
Lines: 57
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org,
	Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 14:13:29 -0000

Andreas Schwab wrote:

> Jim Meyering <jim@meyering.net> writes:
>
>> diff --git a/tests/misc/stty b/tests/misc/stty
>> index 97020e8..fa66a1a 100755
>> --- a/tests/misc/stty
>> +++ b/tests/misc/stty
>> @@ -70,7 +70,7 @@ for opt in $options; do
>>
>>    # Likewise, 'stty -cread' would fail, so skip that, too.
>>    test $opt = cread && continue
>> -  rev=$(eval echo "\$REV_$opt")
>> +  eval \$REV_$opt
>
> That's not what I wrote.

Indeed not.
Send a patch next time, and I'll be less likely to botch it.

>From 7e0ef7c035a4ef331dfd5019465ad00171a7b800 Mon Sep 17 00:00:00 2001
From: Andreas Schwab <schwab@linux-m68k.org>
Date: Wed, 4 Apr 2012 15:06:17 +0200
Subject: [PATCH] tests: avoid unnecessary subshells in misc/stty

* tests/misc/stty: Don't waste a subshell to perform this:
eval rev=\$REV_$opt.  Fix rev1,rev2 assignments similarly.
---
 tests/misc/stty |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/misc/stty b/tests/misc/stty
index 97020e8..1b082c2 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -70,7 +70,7 @@ for opt in $options; do

   # Likewise, 'stty -cread' would fail, so skip that, too.
   test $opt = cread && continue
-  rev=$(eval echo "\$REV_$opt")
+  eval rev=\$REV_$opt
   if test -n "$rev"; then
     stty -$opt || { fail=1; echo -$opt; }
   fi
@@ -84,8 +84,8 @@ if test -n "$RUN_LONG_TESTS"; then

       stty $opt1 $opt2 || fail=1

-      rev1=$(eval echo "\$REV_$opt1")
-      rev2=$(eval echo "\$REV_$opt2")
+      eval rev1=\$REV_$opt1
+      eval rev2=\$REV_$opt2
       if test -n "$rev1"; then
         stty -$opt1 $opt2 || fail=1
       fi
--
1.7.9.3


From MAILER-DAEMON Wed Apr 04 10:48:30 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFRVe-0006Dc-PN
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 10:48:30 -0400
Received: from eggs.gnu.org ([208.118.235.92]:47117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFRVX-0006DU-Na
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:48:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFRVR-0000pn-62
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:48:23 -0400
Received: from moutng.kundenserver.de ([212.227.17.9]:55841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFRVQ-0000pG-T5
	for coreutils@gnu.org; Wed, 04 Apr 2012 10:48:17 -0400
Received: from [192.168.2.108] (p4FF74883.dip.t-dialin.net [79.247.72.131])
	by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis)
	id 0M6fZs-1SRadq072y-00wWFF; Wed, 04 Apr 2012 16:48:11 +0200
Message-ID: <4F7C5F28.3080605@bernhard-voelker.de>
Date: Wed, 04 Apr 2012 16:48:08 +0200
From: Bernhard Voelker <mail@bernhard-voelker.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: amendments to backtick-removing series
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
In-Reply-To: <87sjgjwpor.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Provags-ID: V02:K0:nNH9x60gNdmvuk3lBmC06xyHuwVX+dcvobTvZ2v0xd9
	ycoqPivmdzhq8cGZP2o09f2QppWcJY6PyqurIpS7k+fgbAyKGJ
	bo6yRk6S2lLGK77STd8z6CcaReMLrz93OJonzOFFMOQE3RW3p6
	wwGVS8AWnKgSxHznqZFRaSXVMXPdg6UOj1gGqg8MNCg9bPHzPM
	k58W3RaPb1FMImlkF/zYIM6ZastAG++EtEyVD55UwOM1TlpjLW
	7DxT4Ci2DArZtRbJdDgLHfW2LKJhUunLIa1B5pWAIJ2oyY0ka+
	nLceOPK1IvGQhqKticANstwI0YBA6Rpl0gc4Xr1UWQdekanzDd
	WyvEzbGghGz6kTfZe4xeIzelunzPGcpWv90Og9dUv
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 212.227.17.9
Cc: Andreas Schwab <schwab@linux-m68k.org>, coreutils@gnu.org,
	Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 14:48:29 -0000

On 04/04/2012 04:13 PM, Jim Meyering wrote:
> Andreas Schwab wrote:
> 
>> Jim Meyering <jim@meyering.net> writes:
>>
>>> diff --git a/tests/misc/stty b/tests/misc/stty
>>> index 97020e8..fa66a1a 100755
>>> --- a/tests/misc/stty
>>> +++ b/tests/misc/stty
>>> @@ -70,7 +70,7 @@ for opt in $options; do
>>>
>>>    # Likewise, 'stty -cread' would fail, so skip that, too.
>>>    test $opt = cread && continue
>>> -  rev=$(eval echo "\$REV_$opt")
>>> +  eval \$REV_$opt
>>
>> That's not what I wrote.
> 
> Indeed not.
> Send a patch next time, and I'll be less likely to botch it.

I think this code hasn't been run for a very long time,
because RUN_LONG_TESTS is not set anywhere.

  if test -n "$RUN_LONG_TESTS"; then
    # Take them in pairs.

So shouldn't this ~20sec part of the test be moved into
a very_expensive_ guard?

And if that part runs, then the test fails (at least here)
because of parenb and cread options.

Do they have to be excluded?

diff --git a/tests/misc/stty b/tests/misc/stty
index 650231f..ef3403a 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -79,8 +79,10 @@ done
 if test -n "$RUN_LONG_TESTS"; then
   # Take them in pairs.
   for opt1 in $options; do
+    case $opt1 in parenb|cread) continue;; esac
     echo .|tr -d '\n'
     for opt2 in $options; do
+      case $opt2 in parenb|cread) continue;; esac

       stty $opt1 $opt2 || fail=1

Have a nice day,
Berny


From MAILER-DAEMON Wed Apr 04 11:30:03 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFS9r-0005fV-6U
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 11:30:03 -0400
Received: from eggs.gnu.org ([208.118.235.92]:54285)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFS9h-0005UM-2i
	for coreutils@gnu.org; Wed, 04 Apr 2012 11:30:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFS9V-0004ke-SX
	for coreutils@gnu.org; Wed, 04 Apr 2012 11:29:48 -0400
Received: from mx.meyering.net ([88.168.87.75]:47236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFS9V-0004j0-Iv
	for coreutils@gnu.org; Wed, 04 Apr 2012 11:29:41 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 7B63860062;
	Wed,  4 Apr 2012 17:29:39 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Subject: Re: amendments to backtick-removing series
In-Reply-To: <4F7C5F28.3080605@bernhard-voelker.de> (Bernhard Voelker's
	message of "Wed, 04 Apr 2012 16:48:08 +0200")
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
Date: Wed, 04 Apr 2012 17:29:39 +0200
Message-ID: <87mx6rwm58.fsf@rho.meyering.net>
Lines: 59
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: Andreas Schwab <schwab@linux-m68k.org>, coreutils@gnu.org,
	Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 15:30:01 -0000

Bernhard Voelker wrote:
> On 04/04/2012 04:13 PM, Jim Meyering wrote:
>> Andreas Schwab wrote:
>>
>>> Jim Meyering <jim@meyering.net> writes:
>>>
>>>> diff --git a/tests/misc/stty b/tests/misc/stty
>>>> index 97020e8..fa66a1a 100755
>>>> --- a/tests/misc/stty
>>>> +++ b/tests/misc/stty
>>>> @@ -70,7 +70,7 @@ for opt in $options; do
>>>>
>>>>    # Likewise, 'stty -cread' would fail, so skip that, too.
>>>>    test $opt = cread && continue
>>>> -  rev=$(eval echo "\$REV_$opt")
>>>> +  eval \$REV_$opt
>>>
>>> That's not what I wrote.
>>
>> Indeed not.
>> Send a patch next time, and I'll be less likely to botch it.
>
> I think this code hasn't been run for a very long time,
> because RUN_LONG_TESTS is not set anywhere.
>
>   if test -n "$RUN_LONG_TESTS"; then
>     # Take them in pairs.
>
> So shouldn't this ~20sec part of the test be moved into
> a very_expensive_ guard?

Good idea.
Wow.  That code hasn't been touch since the last millennium ;-)

> And if that part runs, then the test fails (at least here)
> because of parenb and cread options.
>
> Do they have to be excluded?

That makes sense, since parenb and cread are already exempted in
the preceding one-at-a-time on/off tests.

> diff --git a/tests/misc/stty b/tests/misc/stty
> index 650231f..ef3403a 100755
> --- a/tests/misc/stty
> +++ b/tests/misc/stty
> @@ -79,8 +79,10 @@ done
>  if test -n "$RUN_LONG_TESTS"; then
>    # Take them in pairs.
>    for opt1 in $options; do
> +    case $opt1 in parenb|cread) continue;; esac
>      echo .|tr -d '\n'
>      for opt2 in $options; do
> +      case $opt2 in parenb|cread) continue;; esac
>
>        stty $opt1 $opt2 || fail=1
>
> Have a nice day,
> Berny


From MAILER-DAEMON Wed Apr 04 11:50:33 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFSTh-0007BO-1h
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 11:50:33 -0400
Received: from eggs.gnu.org ([208.118.235.92]:34553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFSTY-00071m-I3
	for coreutils@gnu.org; Wed, 04 Apr 2012 11:50:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFSTO-0001n4-Dq
	for coreutils@gnu.org; Wed, 04 Apr 2012 11:50:24 -0400
Received: from mx.meyering.net ([88.168.87.75]:47313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFSTO-0001mf-0T
	for coreutils@gnu.org; Wed, 04 Apr 2012 11:50:14 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id A56136009F
	for <coreutils@gnu.org>; Wed,  4 Apr 2012 17:50:10 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] id,groups: use gidtostr/uidtostr to avoid casts
Date: Wed, 04 Apr 2012 17:50:10 +0200
Message-ID: <87hawzwl71.fsf@rho.meyering.net>
Lines: 137
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 15:50:31 -0000

I wrote this months ago, and like the minimalist (avoiding unnecessary
printf) and more type-safe aspects.  The code-duplication is not ideal,
but the duplicated code is small and fragile, and not generally useful
enough to put in system.h -- too easy to use it from a context where
it would fail.  We could always give it a few more buffer entries, like
human.c does, so two invocations in the same statement won't misbehave.

Opinions?


>From 2c27745185c547e6953f0cb5c25903c2c7503678 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Sun, 1 Jan 2012 22:31:41 +0100
Subject: [PATCH] id,groups: use gidtostr/uidtostr to avoid casts

* src/id.c (gidtostr, uidtostr): Define macros.
(gidtostr_ptr, uidtostr_ptr): Define safer functions.
Use gidtostr and uidtostr to print GID and UID without
need/risk of casts.
* src/group-list.c: Likewise.
---
 src/group-list.c |   16 ++++++++++++----
 src/id.c         |   38 +++++++++++++++++++++++++++++---------
 2 files changed, 41 insertions(+), 13 deletions(-)

diff --git a/src/group-list.c b/src/group-list.c
index cf49911..786fec4 100644
--- a/src/group-list.c
+++ b/src/group-list.c
@@ -86,6 +86,16 @@ print_group_list (const char *username,
   return ok;
 }

+/* Convert a gid_t to string.  Do not use this function directly.
+   Instead, use it via the gidtostr macro.
+   Beware that it returns a pointer to static storage.  */
+static char *
+gidtostr_ptr (gid_t const *gid)
+{
+  static char buf[INT_BUFSIZE_BOUND (gid_t)];
+  return umaxtostr (*gid, buf);
+}
+#define gidtostr(g) gidtostr_ptr (&(g))

 /* Print the name or value of group ID GID. */
 extern bool
@@ -105,9 +115,7 @@ print_group (gid_t gid, bool use_name)
         }
     }

-  if (grp == NULL)
-    printf ("%lu", (unsigned long int) gid);
-  else
-    printf ("%s", grp->gr_name);
+  char *s = grp ? grp->gr_name : gidtostr (gid);
+  fputs (s, stdout);
   return ok;
 }
diff --git a/src/id.c b/src/id.c
index c600e63..a28903a 100644
--- a/src/id.c
+++ b/src/id.c
@@ -265,6 +265,28 @@ main (int argc, char **argv)
   exit (ok ? EXIT_SUCCESS : EXIT_FAILURE);
 }

+/* Convert a gid_t to string.  Do not use this function directly.
+   Instead, use it via the gidtostr macro.
+   Beware that it returns a pointer to static storage.  */
+static char *
+gidtostr_ptr (gid_t const *gid)
+{
+  static char buf[INT_BUFSIZE_BOUND (gid_t)];
+  return umaxtostr (*gid, buf);
+}
+#define gidtostr(g) gidtostr_ptr (&(g))
+
+/* Convert a uid_t to string.  Do not use this function directly.
+   Instead, use it via the uidtostr macro.
+   Beware that it returns a pointer to static storage.  */
+static char *
+uidtostr_ptr (uid_t const *uid)
+{
+  static char buf[INT_BUFSIZE_BOUND (uid_t)];
+  return umaxtostr (*uid, buf);
+}
+#define uidtostr(u) uidtostr_ptr (&(u))
+
 /* Print the name or value of user ID UID. */

 static void
@@ -277,16 +299,14 @@ print_user (uid_t uid)
       pwd = getpwuid (uid);
       if (pwd == NULL)
         {
-          error (0, 0, _("cannot find name for user ID %lu"),
-                 (unsigned long int) uid);
+          error (0, 0, _("cannot find name for user ID %s"),
+                 uidtostr (uid));
           ok = false;
         }
     }

-  if (pwd == NULL)
-    printf ("%lu", (unsigned long int) uid);
-  else
-    printf ("%s", pwd->pw_name);
+  char *s = pwd ? pwd->pw_name : uidtostr (uid);
+  fputs (s, stdout);
 }

 /* Print all of the info about the user's user and group IDs. */
@@ -297,19 +317,19 @@ print_full_info (const char *username)
   struct passwd *pwd;
   struct group *grp;

-  printf (_("uid=%lu"), (unsigned long int) ruid);
+  printf (_("uid=%s"), uidtostr (ruid));
   pwd = getpwuid (ruid);
   if (pwd)
     printf ("(%s)", pwd->pw_name);

-  printf (_(" gid=%lu"), (unsigned long int) rgid);
+  printf (_(" gid=%s"), gidtostr (rgid));
   grp = getgrgid (rgid);
   if (grp)
     printf ("(%s)", grp->gr_name);

   if (euid != ruid)
     {
-      printf (_(" euid=%lu"), (unsigned long int) euid);
+      printf (_(" euid=%s"), uidtostr (euid));
       pwd = getpwuid (euid);
       if (pwd)
         printf ("(%s)", pwd->pw_name);
--
1.7.9.3


From MAILER-DAEMON Wed Apr 04 13:01:46 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFTac-000883-23
	for mharc-coreutils@gnu.org; Wed, 04 Apr 2012 13:01:46 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45920)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cindya1@us.ibm.com>) id 1SFTGV-0002Qb-Kn
	for coreutils@gnu.org; Wed, 04 Apr 2012 12:41:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cindya1@us.ibm.com>) id 1SFTGK-0006fL-Ok
	for coreutils@gnu.org; Wed, 04 Apr 2012 12:40:58 -0400
Received: from e33.co.us.ibm.com ([32.97.110.151]:57409)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cindya1@us.ibm.com>) id 1SFTGK-0006aH-Dz
	for coreutils@gnu.org; Wed, 04 Apr 2012 12:40:48 -0400
Received: from /spool/local
	by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <coreutils@gnu.org> from <cindya1@us.ibm.com>;
	Wed, 4 Apr 2012 10:40:25 -0600
Received: from d01dlp03.pok.ibm.com (9.56.224.17)
	by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway:
	Authorized Use Only! Violators will be prosecuted; 
	Wed, 4 Apr 2012 10:39:22 -0600
Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id E22CBC90067
	for <coreutils@gnu.org>; Wed,  4 Apr 2012 12:39:20 -0400 (EDT)
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q34GdLcL259708
	for <coreutils@gnu.org>; Wed, 4 Apr 2012 12:39:21 -0400
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q34GdL5b002697
	for <coreutils@gnu.org>; Wed, 4 Apr 2012 13:39:21 -0300
Received: from d01ml076.pok.ibm.com (d01ml076.pok.ibm.com [9.63.8.33])
	by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id
	q34GdLGd002692
	for <coreutils@gnu.org>; Wed, 4 Apr 2012 13:39:21 -0300
To: coreutils@gnu.org
MIME-Version: 1.0
Subject: paste utility usage in Windows
X-KeepSent: F2AEFD80:2BEDF081-852579D6:005B2B98;
 type=4; name=$KeepSent
X-Mailer: Lotus Notes Release 8.0.2FP1 SHF149 July 17, 2009
Message-ID: <OFF2AEFD80.2BEDF081-ON852579D6.005B2B98-862579D6.005B86DE@us.ibm.com>
From: Cindy Armstrong <cindya1@us.ibm.com>
Date: Wed, 4 Apr 2012 12:39:18 -0400
X-MIMETrack: S/MIME Sign by Notes Client on Cindy Armstrong/Austin/IBM(Release
	8.0.2FP1 SHF149|July 17, 2009) at 04/04/2012 11:39:43 AM,
	Serialize by Notes Client on Cindy Armstrong/Austin/IBM(Release
	8.0.2FP1 SHF149|July 17, 2009) at 04/04/2012 11:39:43 AM,
	Serialize complete at 04/04/2012 11:39:43 AM,
	Itemize by Notes Client on Cindy Armstrong/Austin/IBM(Release 8.0.2FP1
	SHF149|July 17, 2009) at 04/04/2012 11:39:43 AM,
	S/MIME Sign complete at 04/04/2012 11:39:43 AM,
	Serialize by Router on D01ML076/01/M/IBM(Release 8.5.3 ZX853HP5|January
	12, 2012) at 04/04/2012 12:39:20,
	Serialize complete at 04/04/2012 12:39:20
Content-Type: multipart/signed; protocol="application/x-pkcs7-signature";
	micalg=sha1; boundary=-------z7699_boundary_sign
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 12040416-2398-0000-0000-00000594B95F
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 32.97.110.151
X-Mailman-Approved-At: Wed, 04 Apr 2012 13:01:45 -0400
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2012 16:41:06 -0000

This is an S/MIME signed message.

---------z7699_boundary_sign
Content-Type: multipart/alternative; boundary="=_alternative 005B86DC862579D6_="

This is a multipart message in MIME format.
--=_alternative 005B86DC862579D6_=
Content-Type: text/plain; charset="US-ASCII"

Hello, I'm trying to use the paste utility in Windows XP. I have 
successfully implemented gawk and grep from this toolset in a Windows 
environment, but paste continues to be difficult.

> paste file1 file2   just sends the contents of file2 to standard out; I 
see nothing of file1. 
> join file1 file2 sends NOTHING to standard out. 

I actually have several files that I am trying to paste, and this works 
fine in a Unix environment, but I can't seem to make it work in Windows. 
Any suggestions? Am I using something incorrectly?

Thanks,

Cindy Armstrong

1C-009/045
dept  LXMS
512-286-5157
fax 512-973-4224

".....I'm proud to be an American, where at least I know I'm free!"
          - Lee Greenwood, "God Bless the USA"
--=_alternative 005B86DC862579D6_=
Content-Type: text/html; charset="US-ASCII"


<br><font size=2 face="sans-serif">Hello, I'm trying to use the paste utility
in Windows XP. I have successfully implemented gawk and grep from this
toolset in a Windows environment, but paste continues to be difficult.</font>
<br>
<br><font size=2 face="sans-serif">&gt; paste file1 file2 &nbsp; just sends
the contents of file2 to standard out; I see nothing of file1. &nbsp;</font>
<br><font size=2 face="sans-serif">&gt; join file1 file2 sends NOTHING
to standard out. </font>
<br>
<br><font size=2 face="sans-serif">I actually have several files that I
am trying to paste, and this works fine in a Unix environment, but I can't
seem to make it work in Windows. Any suggestions? Am I using something
incorrectly?</font>
<br>
<br><font size=2 face="sans-serif">Thanks,</font>
<br>
<br><font size=2 face="sans-serif">Cindy Armstrong</font>
<br><font size=2 face="sans-serif"><br>
1C-009/045<br>
dept &nbsp;LXMS<br>
512-286-5157<br>
fax 512-973-4224<br>
<br>
&quot;.....I'm proud to be an American, where at least I know I'm free!&quot;<br>
 &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;- Lee Greenwood, &quot;God Bless the
USA&quot;</font>
--=_alternative 005B86DC862579D6_=--

---------z7699_boundary_sign
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIAGCSqGSIb3DQEHAqCAMIIkwAIBATELMAkGBSsOAwIaBQAwCwYJKoZIhvcNAQcBoIIhBjCCBBkw
ggMBAhBhcMtJjF+YRSnnsKbZUFt6MA0GCSqGSIb3DQEBBQUAMIHKMQswCQYDVQQGEwJVUzEXMBUG
A1UEChMOVmVyaVNpZ24sIEluYy4xHzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5ldHdvcmsxOjA4
BgNVBAsTMShjKSAxOTk5IFZlcmlTaWduLCBJbmMuIC0gRm9yIGF1dGhvcml6ZWQgdXNlIG9ubHkx
RTBDBgNVBAMTPFZlcmlTaWduIENsYXNzIDIgUHVibGljIFByaW1hcnkgQ2VydGlmaWNhdGlvbiBB
dXRob3JpdHkgLSBHMzAeFw05OTEwMDEwMDAwMDBaFw0zNjA3MTYyMzU5NTlaMIHKMQswCQYDVQQG
EwJVUzEXMBUGA1UEChMOVmVyaVNpZ24sIEluYy4xHzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5l
dHdvcmsxOjA4BgNVBAsTMShjKSAxOTk5IFZlcmlTaWduLCBJbmMuIC0gRm9yIGF1dGhvcml6ZWQg
dXNlIG9ubHkxRTBDBgNVBAMTPFZlcmlTaWduIENsYXNzIDIgUHVibGljIFByaW1hcnkgQ2VydGlm
aWNhdGlvbiBBdXRob3JpdHkgLSBHMzCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAK8K
DcLVLNtnuS3llCfdpb7gsE2Ps2FWPNZ8w/TNPobLooji4dikacW14r/BpkdQXkY5i9WWurVvFL8Q
zicTngVHmzF6E9gf2dMCN4utLEfwjoEGpw0wDOv3PA8gHdxyRu6lAshbw8lWaUzFGMGRewvVEwCb
vO/DSD5GYCCFKtWQts2LoMwy3bf9QFWyUBxWrsyNd03HIE2nMXbvaJKKkB4IgVayrWmjUtDLHMQj
PR+Z/kzoFmOOxgiO9jH20vrldt21HJKjSc3NAc1ozalpuqPrHQ2cpCCmwaDF0UZMF23SrGY/lozg
hNQ2/yJZxfkRYKhfBH3yGvYlQmEPxEq4PokCAwEAATANBgkqhkiG9w0BAQUFAAOCAQEANCYVPMCN
TUNJHb3pIZLXZpy33sW40ORdX3YiwCb5hDo6+Yy1++xg8ejOBLDI3acDjzDzmN+k5qQx39McC0bc
ciA/ru4FPKQzPws5rHB4c0uZK98wwlSwqDtVof4WKM1CvXRugNsnRKfORF3UG5CYDR5ClLEALATQ
dKMCBSJjY82DtfvBbWJraXX9XXBBufW/fN++wTJzIiGLWIF7FZF6uuNkSLB/+zYl2pXQ8SQUF90Y
gGtGIzlU9Y5iCQQdlJCmm+Yl4kJFqriQrb4Ij6kLQhiUz3I54bFD4CjPt+dabBNrSbP/4xh8iYsz
Xawz16f52jpVyVgQ+arvWrbPS0vfKjCCBBkwggMBAhBhcMtJjF+YRSnnsKbZUFt6MA0GCSqGSIb3
DQEBBQUAMIHKMQswCQYDVQQGEwJVUzEXMBUGA1UEChMOVmVyaVNpZ24sIEluYy4xHzAdBgNVBAsT
FlZlcmlTaWduIFRydXN0IE5ldHdvcmsxOjA4BgNVBAsTMShjKSAxOTk5IFZlcmlTaWduLCBJbmMu
IC0gRm9yIGF1dGhvcml6ZWQgdXNlIG9ubHkxRTBDBgNVBAMTPFZlcmlTaWduIENsYXNzIDIgUHVi
bGljIFByaW1hcnkgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkgLSBHMzAeFw05OTEwMDEwMDAwMDBa
Fw0zNjA3MTYyMzU5NTlaMIHKMQswCQYDVQQGEwJVUzEXMBUGA1UEChMOVmVyaVNpZ24sIEluYy4x
HzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5ldHdvcmsxOjA4BgNVBAsTMShjKSAxOTk5IFZlcmlT
aWduLCBJbmMuIC0gRm9yIGF1dGhvcml6ZWQgdXNlIG9ubHkxRTBDBgNVBAMTPFZlcmlTaWduIENs
YXNzIDIgUHVibGljIFByaW1hcnkgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkgLSBHMzCCASIwDQYJ
KoZIhvcNAQEBBQADggEPADCCAQoCggEBAK8KDcLVLNtnuS3llCfdpb7gsE2Ps2FWPNZ8w/TNPobL
ooji4dikacW14r/BpkdQXkY5i9WWurVvFL8QzicTngVHmzF6E9gf2dMCN4utLEfwjoEGpw0wDOv3
PA8gHdxyRu6lAshbw8lWaUzFGMGRewvVEwCbvO/DSD5GYCCFKtWQts2LoMwy3bf9QFWyUBxWrsyN
d03HIE2nMXbvaJKKkB4IgVayrWmjUtDLHMQjPR+Z/kzoFmOOxgiO9jH20vrldt21HJKjSc3NAc1o
zalpuqPrHQ2cpCCmwaDF0UZMF23SrGY/lozghNQ2/yJZxfkRYKhfBH3yGvYlQmEPxEq4PokCAwEA
ATANBgkqhkiG9w0BAQUFAAOCAQEANCYVPMCNTUNJHb3pIZLXZpy33sW40ORdX3YiwCb5hDo6+Yy1
++xg8ejOBLDI3acDjzDzmN+k5qQx39McC0bcciA/ru4FPKQzPws5rHB4c0uZK98wwlSwqDtVof4W
KM1CvXRugNsnRKfORF3UG5CYDR5ClLEALATQdKMCBSJjY82DtfvBbWJraXX9XXBBufW/fN++wTJz
IiGLWIF7FZF6uuNkSLB/+zYl2pXQ8SQUF90YgGtGIzlU9Y5iCQQdlJCmm+Yl4kJFqriQrb4Ij6kL
QhiUz3I54bFD4CjPt+dabBNrSbP/4xh8iYszXawz16f52jpVyVgQ+arvWrbPS0vfKjCCBfIwggTa
oAMCAQICEA5s8UJ/nb/zUFWbjldKsuEwDQYJKoZIhvcNAQEFBQAwggEBMQswCQYDVQQGEwJVUzE0
MDIGA1UEChMrSW50ZXJuYXRpb25hbCBCdXNpbmVzcyBNYWNoaW5lcyBDb3Jwb3JhdGlvbjEfMB0G
A1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazE7MDkGA1UECxMyVGVybXMgb2YgdXNlIGF0IGh0
dHBzOi8vd3d3LnZlcmlzaWduLmNvbS9ycGEgKGMpMDkxNTAzBgNVBAsTLENsYXNzIDIgTWFuYWdl
ZCBQS0kgSW5kaXZpZHVhbCBTdWJzY3JpYmVyIENBMScwJQYDVQQDEx5JQk0gQ2VydGlmaWNhdGlv
biBBdXRob3JpdHkgRzIwHhcNMTIwMTI3MDAwMDAwWhcNMTMwMTI2MjM1OTU5WjCBjTEuMCwGA1UE
ChQlSW50ZXJuYXRpb25hbCBCdXNpbmVzcyBNYWNoaW5lcyBDb3JwLjEdMBsGA1UEAwwUQ3ludGhp
YSBKLiBBcm1zdHJvbmcxGTAXBgoJkiaJk/IsZAEBFAk2MTQyODg4OTcxITAfBgkqhkiG9w0BCQEW
EmNpbmR5YTFAdXMuaWJtLmNvbTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAvCfJh1XtS//y
aUm0bSbVZYp7KxkAHGK9lSoeBInV9rC5YRiFProhtzO5FL44Iz2no7uNcaa7HFZbBIrr0NFy4H/f
ZOqGKotpZzKRbc5/aQrmcf3dhkbR/qQ2Ied0RtLHi7qmFlqa2b/aj6a5GytpSwOj/wyKt8YNfN3e
tiUuVJUCAwEAAaOCAlkwggJVMAkGA1UdEwQCMAAwCwYDVR0PBAQDAgWgMG0GA1UdHwRmMGQwYqBg
oF6GXGh0dHA6Ly9vbnNpdGVjcmwudmVyaXNpZ24uY29tL0ludGVybmF0aW9uYWxCdXNpbmVzc01h
Y2hpbmVzQ29ycENvcnBvcmF0ZUNJTy9MYXRlc3RDUkwtRzIuY3JsMIIBKQYDVR0gBIIBIDCCARww
ggEYBgtghkgBhvhFAQcXAjCCAQcwKwYIKwYBBQUHAgEWH2h0dHBzOi8vd3d3LnZlcmlzaWduLmNv
bS9ycGEta3IwgdcGCCsGAQUFBwICMIHKGoHHTm90aWNlIFRleHQ9Tk9USUNFOiBQcml2YXRlIGtl
eSBtYXkgYmUgcmVjb3ZlcmVkIGJ5IFZlcmlTaWduJ3MgY3VzdG9tZXIgd2hvIG1heSBiZSBhYmxl
IHRvIGRlY3J5cHQgbWVzc2FnZXMgeW91IHNlbmQgdG8gY2VydGlmaWNhdGUgaG9sZGVyLiAgVXNl
IGlzIHN1YmplY3QgdG8gdGVybXMgYXQgaHR0cHM6Ly93d3cudmVyaXNpZ24uY29tL3JwYS1rcjAf
BgNVHSMEGDAWgBQStiTe/Xu48JFXiG3ZjfKYOgJb5DAdBgNVHQ4EFgQUlBpaYpAiPEMTG9RzNv08
CvcilIwwLQYDVR0RBCYwJKAiBgorBgEEAYI3FAIDoBQMEmNpbmR5YTFAdXMuaWJtLmNvbTAdBgNV
HSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwEQYJYIZIAYb4QgEBBAQDAgWgMA0GCSqGSIb3DQEB
BQUAA4IBAQCZq8NI19oJzmvEvpBQTVzsEubl3TVplsUD+2qW9lwi9+0/b24yUyxDW/puDUimZf9E
jImc3l1QHEeB7m0d3rwJRGUwqhJe4IVDEoUhciOOoujYNUlW4vm6XDoGCI08A2kaNnQKbm9Ruzoa
xXh9Hl6zmxiAELygRKrrZw6kJBzrnnzJWhtnwVUTVB3wN09xPFweWC1qZkod0KdALC82rzH1sOD9
tuULEkpblllKnr5Wv5eJMhgnU3BrO/bIP5Trg8sgU/97r6W28U3OSKFgxZ7NLbxB4P/wYKQguzXY
QXSLmOVXgvvX2CZptZcOKEAY42KQ/P9xhCcF691XukbS5r0aMIIF8jCCBNqgAwIBAgIQDmzxQn+d
v/NQVZuOV0qy4TANBgkqhkiG9w0BAQUFADCCAQExCzAJBgNVBAYTAlVTMTQwMgYDVQQKEytJbnRl
cm5hdGlvbmFsIEJ1c2luZXNzIE1hY2hpbmVzIENvcnBvcmF0aW9uMR8wHQYDVQQLExZWZXJpU2ln
biBUcnVzdCBOZXR3b3JrMTswOQYDVQQLEzJUZXJtcyBvZiB1c2UgYXQgaHR0cHM6Ly93d3cudmVy
aXNpZ24uY29tL3JwYSAoYykwOTE1MDMGA1UECxMsQ2xhc3MgMiBNYW5hZ2VkIFBLSSBJbmRpdmlk
dWFsIFN1YnNjcmliZXIgQ0ExJzAlBgNVBAMTHklCTSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eSBH
MjAeFw0xMjAxMjcwMDAwMDBaFw0xMzAxMjYyMzU5NTlaMIGNMS4wLAYDVQQKFCVJbnRlcm5hdGlv
bmFsIEJ1c2luZXNzIE1hY2hpbmVzIENvcnAuMR0wGwYDVQQDDBRDeW50aGlhIEouIEFybXN0cm9u
ZzEZMBcGCgmSJomT8ixkAQEUCTYxNDI4ODg5NzEhMB8GCSqGSIb3DQEJARYSY2luZHlhMUB1cy5p
Ym0uY29tMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC8J8mHVe1L//JpSbRtJtVlinsrGQAc
Yr2VKh4EidX2sLlhGIU+uiG3M7kUvjgjPaeju41xprscVlsEiuvQ0XLgf99k6oYqi2lnMpFtzn9p
CuZx/d2GRtH+pDYh53RG0seLuqYWWprZv9qPprkbK2lLA6P/DIq3xg183d62JS5UlQIDAQABo4IC
WTCCAlUwCQYDVR0TBAIwADALBgNVHQ8EBAMCBaAwbQYDVR0fBGYwZDBioGCgXoZcaHR0cDovL29u
c2l0ZWNybC52ZXJpc2lnbi5jb20vSW50ZXJuYXRpb25hbEJ1c2luZXNzTWFjaGluZXNDb3JwQ29y
cG9yYXRlQ0lPL0xhdGVzdENSTC1HMi5jcmwwggEpBgNVHSAEggEgMIIBHDCCARgGC2CGSAGG+EUB
BxcCMIIBBzArBggrBgEFBQcCARYfaHR0cHM6Ly93d3cudmVyaXNpZ24uY29tL3JwYS1rcjCB1wYI
KwYBBQUHAgIwgcoagcdOb3RpY2UgVGV4dD1OT1RJQ0U6IFByaXZhdGUga2V5IG1heSBiZSByZWNv
dmVyZWQgYnkgVmVyaVNpZ24ncyBjdXN0b21lciB3aG8gbWF5IGJlIGFibGUgdG8gZGVjcnlwdCBt
ZXNzYWdlcyB5b3Ugc2VuZCB0byBjZXJ0aWZpY2F0ZSBob2xkZXIuICBVc2UgaXMgc3ViamVjdCB0
byB0ZXJtcyBhdCBodHRwczovL3d3dy52ZXJpc2lnbi5jb20vcnBhLWtyMB8GA1UdIwQYMBaAFBK2
JN79e7jwkVeIbdmN8pg6AlvkMB0GA1UdDgQWBBSUGlpikCI8QxMb1HM2/TwK9yKUjDAtBgNVHREE
JjAkoCIGCisGAQQBgjcUAgOgFAwSY2luZHlhMUB1cy5pYm0uY29tMB0GA1UdJQQWMBQGCCsGAQUF
BwMCBggrBgEFBQcDBDARBglghkgBhvhCAQEEBAMCBaAwDQYJKoZIhvcNAQEFBQADggEBAJmrw0jX
2gnOa8S+kFBNXOwS5uXdNWmWxQP7apb2XCL37T9vbjJTLENb+m4NSKZl/0SMiZzeXVAcR4HubR3e
vAlEZTCqEl7ghUMShSFyI46i6Ng1SVbi+bpcOgYIjTwDaRo2dApub1G7OhrFeH0eXrObGIAQvKBE
qutnDqQkHOuefMlaG2fBVRNUHfA3T3E8XB5YLWpmSh3Qp0AsLzavMfWw4P225QsSSluWWUqevla/
l4kyGCdTcGs79sg/lOuDyyBT/3uvpbbxTc5IoWDFns0tvEHg//BgpCC7NdhBdIuY5VeC+9fYJmm1
lw4oQBjjYpD8/3GEJwXr3Ve6RtLmvRowggZsMIIFVKADAgECAhAqcJVeaorfQTPWlWSisK8vMA0G
CSqGSIb3DQEBBQUAMIHKMQswCQYDVQQGEwJVUzEXMBUGA1UEChMOVmVyaVNpZ24sIEluYy4xHzAd
BgNVBAsTFlZlcmlTaWduIFRydXN0IE5ldHdvcmsxOjA4BgNVBAsTMShjKSAxOTk5IFZlcmlTaWdu
LCBJbmMuIC0gRm9yIGF1dGhvcml6ZWQgdXNlIG9ubHkxRTBDBgNVBAMTPFZlcmlTaWduIENsYXNz
IDIgUHVibGljIFByaW1hcnkgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkgLSBHMzAeFw0wOTA3MDcw
MDAwMDBaFw0xNDA3MDYyMzU5NTlaMIIBATELMAkGA1UEBhMCVVMxNDAyBgNVBAoTK0ludGVybmF0
aW9uYWwgQnVzaW5lc3MgTWFjaGluZXMgQ29ycG9yYXRpb24xHzAdBgNVBAsTFlZlcmlTaWduIFRy
dXN0IE5ldHdvcmsxOzA5BgNVBAsTMlRlcm1zIG9mIHVzZSBhdCBodHRwczovL3d3dy52ZXJpc2ln
bi5jb20vcnBhIChjKTA5MTUwMwYDVQQLEyxDbGFzcyAyIE1hbmFnZWQgUEtJIEluZGl2aWR1YWwg
U3Vic2NyaWJlciBDQTEnMCUGA1UEAxMeSUJNIENlcnRpZmljYXRpb24gQXV0aG9yaXR5IEcyMIIB
IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAuwWAyyWBXK7sbB/cMTNjWQed+HXGsv37Gzwh
B/eMShINOgFpaF8JKvxqO+aHD0Zzf0J0sHkk3Zf9lqZjCHLDY35RLmZxaQJDkPWYS3CAijNndaF2
iblDw1GyC/9CpQdK02EJ2GiTgtAN+hJfrXCU27+B4zNn7FTgT1UPZDf9RGh5stkW/pkYRq2A3WAu
x7/f/ZC/kX1hIzLW0InOCq60VLtPBPrx4810oT3ioKuQfmUfZOY0G9VCf7oe6A4fJLmOIBJPLzhl
7vO+yrn0XoKxfVMGcMPWglx5tXGhWUkFPTbk5JilQZkLD2136aM/W0TugsmnPXNYJ5Nj1rgCzWTG
SwIDAQABo4ICEjCCAg4wEgYDVR0TAQH/BAgwBgEB/wIBADBwBgNVHSAEaTBnMGUGC2CGSAGG+EUB
BxcCMFYwKAYIKwYBBQUHAgEWHGh0dHBzOi8vd3d3LnZlcmlzaWduLmNvbS9jcHMwKgYIKwYBBQUH
AgIwHhocaHR0cHM6Ly93d3cudmVyaXNpZ24uY29tL3JwYTA0BgNVHR8ELTArMCmgJ6AlhiNodHRw
Oi8vY3JsLnZlcmlzaWduLmNvbS9wY2EyLWczLmNybDAOBgNVHQ8BAf8EBAMCAQYwLgYDVR0RBCcw
JaQjMCExHzAdBgNVBAMTFlByaXZhdGVMYWJlbDQtMjA0OC0xMzAwHQYDVR0OBBYEFBK2JN79e7jw
kVeIbdmN8pg6AlvkMIHwBgNVHSMEgegwgeWhgdCkgc0wgcoxCzAJBgNVBAYTAlVTMRcwFQYDVQQK
Ew5WZXJpU2lnbiwgSW5jLjEfMB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazE6MDgGA1UE
CxMxKGMpIDE5OTkgVmVyaVNpZ24sIEluYy4gLSBGb3IgYXV0aG9yaXplZCB1c2Ugb25seTFFMEMG
A1UEAxM8VmVyaVNpZ24gQ2xhc3MgMiBQdWJsaWMgUHJpbWFyeSBDZXJ0aWZpY2F0aW9uIEF1dGhv
cml0eSAtIEczghBhcMtJjF+YRSnnsKbZUFt6MA0GCSqGSIb3DQEBBQUAA4IBAQA2JW8QGLS+vldT
sIUciM712mgg2NRjpbWYnfKEt6Z3t8+NVWOkAoDpZgZRXwaopB7QB9YpzjvnYeBQGpUfn8YQNeLJ
XyGQ1juyOHsY7RTC5uXmrx1BddwGgyjM5qiDj1lN3XQfGP8CzEhdTxSIy/dhm5ZFzemd7GEpnOQe
Dnw6SB4eKoM9JYzUGtsj8+GdmV61PV6RfM9PeDBBfAIABmigYu0PZetRHJf+p5+YxrJ8qk2tdlLm
51m+ij6iDFsdXvXljRnlU/OuV/GvGo514lrMu657v3wJNmyjxwg+aEa1n/WS/Jp7BLAa5frJkRj4
fVrJPzikYGP2Z2hy3tMn9b/XMIIGbDCCBVSgAwIBAgIQKnCVXmqK30Ez1pVkorCvLzANBgkqhkiG
9w0BAQUFADCByjELMAkGA1UEBhMCVVMxFzAVBgNVBAoTDlZlcmlTaWduLCBJbmMuMR8wHQYDVQQL
ExZWZXJpU2lnbiBUcnVzdCBOZXR3b3JrMTowOAYDVQQLEzEoYykgMTk5OSBWZXJpU2lnbiwgSW5j
LiAtIEZvciBhdXRob3JpemVkIHVzZSBvbmx5MUUwQwYDVQQDEzxWZXJpU2lnbiBDbGFzcyAyIFB1
YmxpYyBQcmltYXJ5IENlcnRpZmljYXRpb24gQXV0aG9yaXR5IC0gRzMwHhcNMDkwNzA3MDAwMDAw
WhcNMTQwNzA2MjM1OTU5WjCCAQExCzAJBgNVBAYTAlVTMTQwMgYDVQQKEytJbnRlcm5hdGlvbmFs
IEJ1c2luZXNzIE1hY2hpbmVzIENvcnBvcmF0aW9uMR8wHQYDVQQLExZWZXJpU2lnbiBUcnVzdCBO
ZXR3b3JrMTswOQYDVQQLEzJUZXJtcyBvZiB1c2UgYXQgaHR0cHM6Ly93d3cudmVyaXNpZ24uY29t
L3JwYSAoYykwOTE1MDMGA1UECxMsQ2xhc3MgMiBNYW5hZ2VkIFBLSSBJbmRpdmlkdWFsIFN1YnNj
cmliZXIgQ0ExJzAlBgNVBAMTHklCTSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0eSBHMjCCASIwDQYJ
KoZIhvcNAQEBBQADggEPADCCAQoCggEBALsFgMslgVyu7Gwf3DEzY1kHnfh1xrL9+xs8IQf3jEoS
DToBaWhfCSr8ajvmhw9Gc39CdLB5JN2X/ZamYwhyw2N+US5mcWkCQ5D1mEtwgIozZ3Whdom5Q8NR
sgv/QqUHStNhCdhok4LQDfoSX61wlNu/geMzZ+xU4E9VD2Q3/URoebLZFv6ZGEatgN1gLse/3/2Q
v5F9YSMy1tCJzgqutFS7TwT68ePNdKE94qCrkH5lH2TmNBvVQn+6HugOHyS5jiASTy84Ze7zvsq5
9F6CsX1TBnDD1oJcebVxoVlJBT025OSYpUGZCw9td+mjP1tE7oLJpz1zWCeTY9a4As1kxksCAwEA
AaOCAhIwggIOMBIGA1UdEwEB/wQIMAYBAf8CAQAwcAYDVR0gBGkwZzBlBgtghkgBhvhFAQcXAjBW
MCgGCCsGAQUFBwIBFhxodHRwczovL3d3dy52ZXJpc2lnbi5jb20vY3BzMCoGCCsGAQUFBwICMB4a
HGh0dHBzOi8vd3d3LnZlcmlzaWduLmNvbS9ycGEwNAYDVR0fBC0wKzApoCegJYYjaHR0cDovL2Ny
bC52ZXJpc2lnbi5jb20vcGNhMi1nMy5jcmwwDgYDVR0PAQH/BAQDAgEGMC4GA1UdEQQnMCWkIzAh
MR8wHQYDVQQDExZQcml2YXRlTGFiZWw0LTIwNDgtMTMwMB0GA1UdDgQWBBQStiTe/Xu48JFXiG3Z
jfKYOgJb5DCB8AYDVR0jBIHoMIHloYHQpIHNMIHKMQswCQYDVQQGEwJVUzEXMBUGA1UEChMOVmVy
aVNpZ24sIEluYy4xHzAdBgNVBAsTFlZlcmlTaWduIFRydXN0IE5ldHdvcmsxOjA4BgNVBAsTMShj
KSAxOTk5IFZlcmlTaWduLCBJbmMuIC0gRm9yIGF1dGhvcml6ZWQgdXNlIG9ubHkxRTBDBgNVBAMT
PFZlcmlTaWduIENsYXNzIDIgUHVibGljIFByaW1hcnkgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkg
LSBHM4IQYXDLSYxfmEUp57Cm2VBbejANBgkqhkiG9w0BAQUFAAOCAQEANiVvEBi0vr5XU7CFHIjO
9dpoINjUY6W1mJ3yhLemd7fPjVVjpAKA6WYGUV8GqKQe0AfWKc4752HgUBqVH5/GEDXiyV8hkNY7
sjh7GO0Uwubl5q8dQXXcBoMozOaog49ZTd10Hxj/AsxIXU8UiMv3YZuWRc3pnexhKZzkHg58Okge
HiqDPSWM1BrbI/PhnZletT1ekXzPT3gwQXwCAAZooGLtD2XrURyX/qefmMayfKpNrXZS5udZvoo+
ogxbHV715Y0Z5VPzrlfxrxqOdeJazLuue798CTZso8cIPmhGtZ/1kvyaewSwGuX6yZEY+H1ayT84
pGBj9mdoct7TJ/W/1zGCA5UwggORAgEBMIIBFzCCAQExCzAJBgNVBAYTAlVTMTQwMgYDVQQKEytJ
bnRlcm5hdGlvbmFsIEJ1c2luZXNzIE1hY2hpbmVzIENvcnBvcmF0aW9uMR8wHQYDVQQLExZWZXJp
U2lnbiBUcnVzdCBOZXR3b3JrMTswOQYDVQQLEzJUZXJtcyBvZiB1c2UgYXQgaHR0cHM6Ly93d3cu
dmVyaXNpZ24uY29tL3JwYSAoYykwOTE1MDMGA1UECxMsQ2xhc3MgMiBNYW5hZ2VkIFBLSSBJbmRp
dmlkdWFsIFN1YnNjcmliZXIgQ0ExJzAlBgNVBAMTHklCTSBDZXJ0aWZpY2F0aW9uIEF1dGhvcml0
eSBHMgIQDmzxQn+dv/NQVZuOV0qy4TAJBgUrDgMCGgUAoIIB0jAYBgkqhkiG9w0BCQMxCwYJKoZI
hvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xMjA0MDQxNjM5NDNaMCMGCSqGSIb3DQEJBDEWBBQZhpRv
nxNAHpgt01k/c0y2zDRI7DBDBgkqhkiG9w0BCQ8xNjA0MAcGBSsOAwIdMA4GCCqGSIb3DQMCAgIA
gDAKBggqhkiG9w0DBzANBggqhkiG9w0DAgIBKDCCASwGCyqGSIb3DQEJEAILMYIBG6CCARcwggEB
MQswCQYDVQQGEwJVUzE0MDIGA1UEChMrSW50ZXJuYXRpb25hbCBCdXNpbmVzcyBNYWNoaW5lcyBD
b3Jwb3JhdGlvbjEfMB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazE7MDkGA1UECxMyVGVy
bXMgb2YgdXNlIGF0IGh0dHBzOi8vd3d3LnZlcmlzaWduLmNvbS9ycGEgKGMpMDkxNTAzBgNVBAsT
LENsYXNzIDIgTWFuYWdlZCBQS0kgSW5kaXZpZHVhbCBTdWJzY3JpYmVyIENBMScwJQYDVQQDEx5J
Qk0gQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkgRzICEA5s8UJ/nb/zUFWbjldKsuEwDQYJKoZIhvcN
AQEBBQAEgYCPoxye4fBLjAn3+8/aj+391DzY3NglH8gTxwdjGy47tRH2EP3wXIgmjBQN9K0lMdcK
0IrH7iQn6zLYdwgQ8YjKSKD2jtdy69z2yT+bo42TjA0eOO+dy+tCOLfjY81lBQA17Q9NLaD6OqmZ
oQ+CZUmWNgV17n4crCHHImia+w9zCAAAAAA=

---------z7699_boundary_sign--



From MAILER-DAEMON Thu Apr 05 03:02:50 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFgiY-0004iu-JR
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 03:02:50 -0400
Received: from eggs.gnu.org ([208.118.235.92]:36348)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFgiS-0004hT-FT
	for coreutils@gnu.org; Thu, 05 Apr 2012 03:02:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFgiP-0000Sp-MF
	for coreutils@gnu.org; Thu, 05 Apr 2012 03:02:44 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:61850)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFgiP-0000Sl-CO
	for coreutils@gnu.org; Thu, 05 Apr 2012 03:02:41 -0400
Received: from [192.168.2.108] (p4FF74D6B.dip.t-dialin.net [79.247.77.107])
	by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis)
	id 0MDJ7o-1RzFmp2Peu-00H3ed; Thu, 05 Apr 2012 09:02:36 +0200
Message-ID: <4F7D438A.7050609@bernhard-voelker.de>
Date: Thu, 05 Apr 2012 09:02:34 +0200
From: Bernhard Voelker <mail@bernhard-voelker.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: [PATCH] refactor expensive code in misc/stty [was: amendments to
	backtick-removing series]
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
	<87mx6rwm58.fsf@rho.meyering.net>
In-Reply-To: <87mx6rwm58.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Provags-ID: V02:K0:81Psi/iwqZs5RATYzBWngrdpqIrR1KrZicW8OlnJ5dR
	V9DKxCTi6OAj8bmVXfBpFdzYn8pkdo79kNA3whuhPW+NQYegWF
	nYas6ZbHtyCeuIpZ/FSZ/8rI51xQMMORRb7DHMiCu3++l/NHBt
	15WQpV4qQQTLrye6l77ZWJ5ygZnoYrxE5vdk1M6uJml3G98dXm
	TGwE1kTLvl+nKWypfU917/GIOl9qvfRORlzH6w5VulLgXMpgkx
	cO1d3ys6fhVof9z6/Dm8aulu9B5i61lhjdFlTn5C1YVOnOVgvO
	3J8Tql4tdK12DSuCi2w1I6/dzaLoSRHv3p+m7a4d/Mb+0o9DnV
	fKJZrAG0QSFaZnqAiVSbdCp/NKYcl6DMcliI78xO6
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 212.227.126.186
Cc: Andreas Schwab <schwab@linux-m68k.org>, coreutils@gnu.org,
	Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 07:02:49 -0000



On 04/04/2012 05:29 PM, Jim Meyering wrote:
> Bernhard Voelker wrote:
>> I think this code hasn't been run for a very long time,
>> because RUN_LONG_TESTS is not set anywhere.
>>
>>   if test -n "$RUN_LONG_TESTS"; then
>>     # Take them in pairs.
>>
>> So shouldn't this ~20sec part of the test be moved into
>> a very_expensive_ guard?
> 
> Good idea.
> Wow.  That code hasn't been touch since the last millennium ;-)
> 
>> And if that part runs, then the test fails (at least here)
>> because of parenb and cread options.
>>
>> Do they have to be excluded?
> 
> That makes sense, since parenb and cread are already exempted in
> the preceding one-at-a-time on/off tests.

Besides factoring out the expensive code, I found out
that "iutf8" was missing in the option list.

* [PATCH 1/2] tests: add iutf8 option to misc/stty
* [PATCH 2/2] tests: factor out expensive "pairs" code of misc/stty

I'm not happy that the REV_* list is doubled now,
but I'm optimistic that with the "See also:" comment
we're quite safe that both places will be updated next
time.

Have a nice day,
Berny



>From f71ed9ae1a9699e000a98c26dae4db96a628d657 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Thu, 5 Apr 2012 08:01:43 +0200
Subject: [PATCH 1/2] tests: add iutf8 option to misc/stty

* tests/misc/stty: Add iutf8 to the list of REV_* options.
That option has been implemented in commit v5.2.1-193-g733e79e.
---
 tests/misc/stty |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/misc/stty b/tests/misc/stty
index 1b082c2..cfc70c1 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -29,13 +29,13 @@ REV_parenb=1 REV_parodd=1 REV_hupcl=1 REV_hup=1 REV_cstopb=1 REV_cread=1
 REV_clocal=1 REV_crtscts=1 REV_ignbrk=1 REV_brkint=1 REV_ignpar=1
 REV_parmrk=1 REV_inpck=1 REV_istrip=1 REV_inlcr=1 REV_igncr=1 REV_icrnl=1
 REV_ixon=1 REV_ixoff=1 REV_tandem=1 REV_iuclc=1 REV_ixany=1 REV_imaxbel=1
-REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1 REV_onlret=1
-REV_ofill=1 REV_ofdel=1 REV_isig=1 REV_icanon=1 REV_iexten=1 REV_echo=1
-REV_echoe=1 REV_crterase=1 REV_echok=1 REV_echonl=1 REV_noflsh=1
-REV_xcase=1 REV_tostop=1 REV_echoprt=1 REV_prterase=1 REV_echoctl=1
-REV_ctlecho=1 REV_echoke=1 REV_crtkill=1 REV_evenp=1 REV_parity=1
-REV_oddp=1 REV_nl=1 REV_cooked=1 REV_raw=1 REV_pass8=1 REV_litout=1
-REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1
+REV_iutf8=1 REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1
+REV_onlret=1 REV_ofill=1 REV_ofdel=1 REV_isig=1 REV_icanon=1 REV_iexten=1
+REV_echo=1 REV_echoe=1 REV_crterase=1 REV_echok=1 REV_echonl=1
+REV_noflsh=1 REV_xcase=1 REV_tostop=1 REV_echoprt=1 REV_prterase=1
+REV_echoctl=1 REV_ctlecho=1 REV_echoke=1 REV_crtkill=1 REV_evenp=1
+REV_parity=1 REV_oddp=1 REV_nl=1 REV_cooked=1 REV_raw=1 REV_pass8=1
+REV_litout=1 REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1


 saved_state=.saved-state
-- 
1.7.7


>From 7f557d6788e2d096269f24effbc18bbd67597a1f Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Thu, 5 Apr 2012 08:38:32 +0200
Subject: [PATCH 2/2] tests: factor out expensive "pairs" code of misc/stty

* tests/Makefile.am: Add misc/stty-pairs.
* tests/misc/stty: Factor out expensive "pairs" code into new test.
* tests/misc/stty-pairs: Added new test. Code added from misc/stty.
Mark this as an expensive test. Skip 'parenb' and 'cread' options,
as these tests are known to fail.
---
 tests/Makefile.am     |    1 +
 tests/misc/stty       |   24 +--------------
 tests/misc/stty-pairs |   77 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 79 insertions(+), 23 deletions(-)
 create mode 100755 tests/misc/stty-pairs

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 011051a..86afbc2 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -274,6 +274,7 @@ TESTS =                                             \
   misc/stdbuf                                  \
   misc/stty                                    \
   misc/stty-invalid                            \
+  misc/stty-pairs                              \
   misc/stty-row-col                            \
   misc/su-fail                                 \
   misc/sum                                     \
diff --git a/tests/misc/stty b/tests/misc/stty
index cfc70c1..40e6ce6 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -25,6 +25,7 @@ trap '' TTOU # Ignore SIGTTOU

 # The following list of reversible options was generated with
 # grep -w REV stty.c|sed -n '/^  {"/{s//REV_/;s/".*/=1/;p;}'|fmt
+# See also: tests/misc/stty-pairs.
 REV_parenb=1 REV_parodd=1 REV_hupcl=1 REV_hup=1 REV_cstopb=1 REV_cread=1
 REV_clocal=1 REV_crtscts=1 REV_ignbrk=1 REV_brkint=1 REV_ignpar=1
 REV_parmrk=1 REV_inpck=1 REV_istrip=1 REV_inlcr=1 REV_igncr=1 REV_icrnl=1
@@ -76,29 +77,6 @@ for opt in $options; do
   fi
 done

-if test -n "$RUN_LONG_TESTS"; then
-  # Take them in pairs.
-  for opt1 in $options; do
-    echo .|tr -d '\n'
-    for opt2 in $options; do
-
-      stty $opt1 $opt2 || fail=1
-
-      eval rev1=\$REV_$opt1
-      eval rev2=\$REV_$opt2
-      if test -n "$rev1"; then
-        stty -$opt1 $opt2 || fail=1
-      fi
-      if test -n "$rev2"; then
-        stty $opt1 -$opt2 || fail=1
-      fi
-      if test "$rev1$rev2" = 11; then
-        stty -$opt1 -$opt2 || fail=1
-      fi
-    done
-  done
-fi
-
 stty $(cat $saved_state)

 Exit $fail
diff --git a/tests/misc/stty-pairs b/tests/misc/stty-pairs
new file mode 100755
index 0000000..7efc95b
--- /dev/null
+++ b/tests/misc/stty-pairs
@@ -0,0 +1,77 @@
+#!/bin/sh
+# Make sure stty can parse most of its options - in pairs [expensive].
+
+# Copyright (C) 1998-2012 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../src
+print_ver_ stty
+
+expensive_
+
+# Make sure there's a tty on stdin.
+require_controlling_input_terminal_
+trap '' TTOU # Ignore SIGTTOU
+
+# The following list of reversible options was generated with
+# grep -w REV stty.c|sed -n '/^  {"/{s//REV_/;s/".*/=1/;p;}'|fmt
+# See also: tests/misc/stty.
+REV_parenb=1 REV_parodd=1 REV_hupcl=1 REV_hup=1 REV_cstopb=1 REV_cread=1
+REV_clocal=1 REV_crtscts=1 REV_ignbrk=1 REV_brkint=1 REV_ignpar=1
+REV_parmrk=1 REV_inpck=1 REV_istrip=1 REV_inlcr=1 REV_igncr=1 REV_icrnl=1
+REV_ixon=1 REV_ixoff=1 REV_tandem=1 REV_iuclc=1 REV_ixany=1 REV_imaxbel=1
+REV_iutf8=1 REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1
+REV_onlret=1 REV_ofill=1 REV_ofdel=1 REV_isig=1 REV_icanon=1 REV_iexten=1
+REV_echo=1 REV_echoe=1 REV_crterase=1 REV_echok=1 REV_echonl=1
+REV_noflsh=1 REV_xcase=1 REV_tostop=1 REV_echoprt=1 REV_prterase=1
+REV_echoctl=1 REV_ctlecho=1 REV_echoke=1 REV_crtkill=1 REV_evenp=1
+REV_parity=1 REV_oddp=1 REV_nl=1 REV_cooked=1 REV_raw=1 REV_pass8=1
+REV_litout=1 REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1
+
+
+saved_state=.saved-state
+stty --save > $saved_state || fail=1
+stty $(cat $saved_state) || fail=1
+
+# Build a list of all boolean options stty accepts on this system.
+# Don't depend on terminal width.  Put each option on its own line,
+# remove all non-boolean ones, remove 'parenb' and 'cread' explicitly,
+# then remove any leading hyphens.
+sed_del='/^speed/d;/^rows/d;/^columns/d;/ = /d;s/parenb//;s/cread//'
+options=$(stty -a | tr -s ';' '\n' | sed "s/^ //;$sed_del;s/-//g")
+
+# Take them in pairs, with and without the leading '-'.
+for opt1 in $options; do
+  for opt2 in $options; do
+
+    stty $opt1 $opt2 || fail=1
+
+    eval rev1=\$REV_$opt1
+    eval rev2=\$REV_$opt2
+    if test -n "$rev1"; then
+      stty -$opt1 $opt2 || fail=1
+    fi
+    if test -n "$rev2"; then
+      stty $opt1 -$opt2 || fail=1
+    fi
+    if test "$rev1$rev2" = 11; then
+      stty -$opt1 -$opt2 || fail=1
+    fi
+  done
+done
+
+stty $(cat $saved_state)
+
+Exit $fail
-- 
1.7.7


From MAILER-DAEMON Thu Apr 05 04:01:48 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFhdc-0002Nb-HI
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 04:01:48 -0400
Received: from eggs.gnu.org ([208.118.235.92]:36202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFhdU-0002MG-KZ
	for coreutils@gnu.org; Thu, 05 Apr 2012 04:01:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFhdN-0005Fm-Vk
	for coreutils@gnu.org; Thu, 05 Apr 2012 04:01:40 -0400
Received: from mx.meyering.net ([88.168.87.75]:49900)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFhdN-0005Fe-Jz
	for coreutils@gnu.org; Thu, 05 Apr 2012 04:01:33 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 024B560077;
	Thu,  5 Apr 2012 10:01:29 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Subject: Re: [PATCH] refactor expensive code in misc/stty [was: amendments to
	backtick-removing series]
In-Reply-To: <4F7D438A.7050609@bernhard-voelker.de> (Bernhard Voelker's
	message of "Thu, 05 Apr 2012 09:02:34 +0200")
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
	<87mx6rwm58.fsf@rho.meyering.net>
	<4F7D438A.7050609@bernhard-voelker.de>
Date: Thu, 05 Apr 2012 10:01:29 +0200
Message-ID: <87ty0ytxnq.fsf@rho.meyering.net>
Lines: 91
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: Andreas Schwab <schwab@linux-m68k.org>, coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 08:01:46 -0000

Bernhard Voelker wrote:
> On 04/04/2012 05:29 PM, Jim Meyering wrote:
>> Bernhard Voelker wrote:
>>> I think this code hasn't been run for a very long time,
>>> because RUN_LONG_TESTS is not set anywhere.
>>>
>>>   if test -n "$RUN_LONG_TESTS"; then
>>>     # Take them in pairs.
>>>
>>> So shouldn't this ~20sec part of the test be moved into
>>> a very_expensive_ guard?
>>
>> Good idea.
>> Wow.  That code hasn't been touch since the last millennium ;-)
>>
>>> And if that part runs, then the test fails (at least here)
>>> because of parenb and cread options.
>>>
>>> Do they have to be excluded?
>>
>> That makes sense, since parenb and cread are already exempted in
>> the preceding one-at-a-time on/off tests.
>
> Besides factoring out the expensive code, I found out
> that "iutf8" was missing in the option list.
>
> * [PATCH 1/2] tests: add iutf8 option to misc/stty
> * [PATCH 2/2] tests: factor out expensive "pairs" code of misc/stty
>
> I'm not happy that the REV_* list is doubled now,
> but I'm optimistic that with the "See also:" comment
> we're quite safe that both places will be updated next
> time.
...
> Subject: [PATCH 1/2] tests: add iutf8 option to misc/stty
>
> * tests/misc/stty: Add iutf8 to the list of REV_* options.
> That option has been implemented in commit v5.2.1-193-g733e79e.
> ---
>  tests/misc/stty |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tests/misc/stty b/tests/misc/stty
> index 1b082c2..cfc70c1 100755
> --- a/tests/misc/stty
> +++ b/tests/misc/stty
> @@ -29,13 +29,13 @@ REV_parenb=1 REV_parodd=1 REV_hupcl=1 REV_hup=1 REV_cstopb=1 REV_cread=1
>  REV_clocal=1 REV_crtscts=1 REV_ignbrk=1 REV_brkint=1 REV_ignpar=1
>  REV_parmrk=1 REV_inpck=1 REV_istrip=1 REV_inlcr=1 REV_igncr=1 REV_icrnl=1
>  REV_ixon=1 REV_ixoff=1 REV_tandem=1 REV_iuclc=1 REV_ixany=1 REV_imaxbel=1
> -REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1 REV_onlret=1
> -REV_ofill=1 REV_ofdel=1 REV_isig=1 REV_icanon=1 REV_iexten=1 REV_echo=1
> -REV_echoe=1 REV_crterase=1 REV_echok=1 REV_echonl=1 REV_noflsh=1
> -REV_xcase=1 REV_tostop=1 REV_echoprt=1 REV_prterase=1 REV_echoctl=1
> -REV_ctlecho=1 REV_echoke=1 REV_crtkill=1 REV_evenp=1 REV_parity=1
> -REV_oddp=1 REV_nl=1 REV_cooked=1 REV_raw=1 REV_pass8=1 REV_litout=1
> -REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1
> +REV_iutf8=1 REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1
...

So iutf8 was added to stty.c (by me, 8 years ago), but not here,
so never exposed to these tests.  Good catch.

What do you think about eval'ing the output of the command
just above, instead.  Then this won't happen again.

  r=$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print "REV_$1=1"' \
        $abs_top_srcdir/stty.c)
  # Ensure that there are at least 62, i.e., so that reformatting
  # the source does not make this test a no-op.
  test 62 -lt $(echo "$r"|wc -l) || framework_failure_
  eval "$r"

Or better, a function in init.cfg,

stty_reversible_settings()
{
  local r
  r=$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
      $abs_top_srcdir/src/stty.c)
  # Ensure that there are at least 62, i.e., so we're alerted if
  # reformatting the source empties the list.
  test 62 -lt $(echo "$r"|wc -l) || framework_failure_
  echo "$r"
}

Then, you could add this one-liner in each of those two files,
in place of the hard-coded list of REV_... variable settings:

  # Set REV_$S=1 for each reversible stty setting, $S.
  eval $(stty_reversible_settings |sed 's/^/REV_/;s/$/=1/')


From MAILER-DAEMON Thu Apr 05 06:19:02 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFjmQ-0003vw-Pc
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 06:19:02 -0400
Received: from eggs.gnu.org ([208.118.235.92]:44274)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFjmI-0003tC-PL
	for coreutils@gnu.org; Thu, 05 Apr 2012 06:19:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFjmB-00054n-Ns
	for coreutils@gnu.org; Thu, 05 Apr 2012 06:18:54 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:49274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SFjmB-00054f-EV
	for coreutils@gnu.org; Thu, 05 Apr 2012 06:18:47 -0400
Received: from [192.168.2.108] (p4FF74D6B.dip.t-dialin.net [79.247.77.107])
	by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis)
	id 0MDJ3g-1RzCQZ0GjM-00GepE; Thu, 05 Apr 2012 12:18:35 +0200
Message-ID: <4F7D717A.4060700@bernhard-voelker.de>
Date: Thu, 05 Apr 2012 12:18:34 +0200
From: Bernhard Voelker <mail@bernhard-voelker.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH] refactor expensive code in misc/stty [was: amendments
	to backtick-removing series]
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
	<87mx6rwm58.fsf@rho.meyering.net>
	<4F7D438A.7050609@bernhard-voelker.de>
	<87ty0ytxnq.fsf@rho.meyering.net>
In-Reply-To: <87ty0ytxnq.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Provags-ID: V02:K0:yyTd3kdtXecINhMiLBobeu1ofNuP/xOUI66Tliw0k2p
	HRS70QXpsVTnjoedjHFujbuBd4lrLVKP9DxLgce8rGnqz7l5xz
	idMILwEaTHUC+jvTreuhWxnOlzjFMjSfeNJzCOYlUQ6abYpHOj
	ozJ2OjGzCQ2ZOv39MoJ0IOnA4E1r7XmbXu7XI2Ho0cogEovGAJ
	olcE26HDkWteLuCvZxrBy9i9riB1FRjq8pEwQDqG7wrQ00wi29
	psyh1YUPlu9VB/HjpuiTy4lOdV+fkS/OyrJAA90p5VRxDLqE2l
	xhthSaWTflmFr5CYLCq9qWeUW5y2CLRDHuGMnPJNHkr9npA1Dz
	ye86r+r0QfoT0E/Voq1RD2ku/UBNwJ0J0kYt6D7mY
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 212.227.126.186
Cc: Andreas Schwab <schwab@linux-m68k.org>, coreutils@gnu.org,
	Sami Kerola <kerolasa@iki.fi>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 10:19:01 -0000

CC'ing Sami as he sent another note privately.

On 04/05/2012 10:01 AM, Jim Meyering wrote:

> So iutf8 was added to stty.c (by me, 8 years ago), but not here,
> so never exposed to these tests.  Good catch.

Thanks.

> What do you think about eval'ing the output of the command
> just above, instead.  Then this won't happen again.

I thought about that (but read on) ...


> Or better, a function in init.cfg,
> 
> stty_reversible_settings()
> {
>   local r
>   r=$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
>       $abs_top_srcdir/src/stty.c)
>   # Ensure that there are at least 62, i.e., so we're alerted if
>   # reformatting the source empties the list.
>   test 62 -lt $(echo "$r"|wc -l) || framework_failure_
>   echo "$r"
> }

a) s/lt/le/ ;-)

> 
> Then, you could add this one-liner in each of those two files,
> in place of the hard-coded list of REV_... variable settings:
> 
>   # Set REV_$S=1 for each reversible stty setting, $S.
>   eval $(stty_reversible_settings |sed 's/^/REV_/;s/$/=1/')
> 

b) framework_failure_ in a subshell doesn't work.
c) I don't like eval too much, it's harder to read.

What about the following?

P.S. I could've even overloaded the function in init.cfg
to get the list when no arg is given, and otherwise test if
the arg is in the internal list, but I think this is safer.

Have a nice day,
Berny


>From b8e5e7e9f25d21284daffeca65634840dfb1d0c1 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Thu, 5 Apr 2012 12:05:46 +0200
Subject: [PATCH] tests: factor out expensive "pairs" code of misc/stty

* tests/Makefile.am: Add misc/stty-pairs.
* tests/init.cfg (stty_reversible_settings): Add new function to get
the list of reversible options from stty.c.
* tests/init.cfg (stty_reversible_matches): Add new function to test
wether a given option is in the list of reversible options.
* tests/misc/stty: Factor out expensive "pairs" code into new test.
Use new stty_reversible_settings and stty_reversible_matches instead
of evaluating static REV_* variables.
* tests/misc/stty-pairs: Added new test. Code added from misc/stty.
Mark this as an expensive test. Skip 'parenb' and 'cread' options,
as these tests are known to fail. Like in misc/stty, also use
new stty_reversible_settings and stty_reversible_matches.
---
 tests/Makefile.am     |    1 +
 tests/init.cfg        |   27 +++++++++++++++++++++
 tests/misc/stty       |   42 ++------------------------------
 tests/misc/stty-pairs |   63 +++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 94 insertions(+), 39 deletions(-)
 create mode 100755 tests/misc/stty-pairs

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 011051a..86afbc2 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -274,6 +274,7 @@ TESTS =                                             \
   misc/stdbuf                                  \
   misc/stty                                    \
   misc/stty-invalid                            \
+  misc/stty-pairs                              \
   misc/stty-row-col                            \
   misc/su-fail                                 \
   misc/sum                                     \
diff --git a/tests/init.cfg b/tests/init.cfg
index 7bcd512..08645d1 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -241,6 +241,33 @@ rwx_to_mode_()
   echo "=$u$g$o"
 }

+# Return the reversible settings from stty.c.
+# Fill the variable REV which is needed by stty_reversible_matches.
+stty_reversible_settings()
+{
+  # Pad start with one blank for the first option
+  # to match in stty_reversible_matches.
+  REV=" "$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
+      $abs_top_srcdir/src/stty.c | tr '\n' ' ')
+  # Ensure that there are at least 62, i.e., so we're alerted if
+  # reformatting the source empties the list.
+  test 62 -le $(echo "$REV"|wc -w)  \
+    || framework_failure_ "too few reversible settings"
+}
+
+# Test if $1 is among the reversible stty options ($REV).
+stty_reversible_matches()
+{
+  case "$REV" in
+    "")
+      framework_failure_ "stty_reversible_settings() not called?";;
+    *" $1 "*)
+      return 0;;
+    *)
+      return 1;;
+  esac
+}
+
 skip_if_()
 {
   case $1 in
diff --git a/tests/misc/stty b/tests/misc/stty
index cfc70c1..578105d 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -23,20 +23,8 @@ print_ver_ stty
 require_controlling_input_terminal_
 trap '' TTOU # Ignore SIGTTOU

-# The following list of reversible options was generated with
-# grep -w REV stty.c|sed -n '/^  {"/{s//REV_/;s/".*/=1/;p;}'|fmt
-REV_parenb=1 REV_parodd=1 REV_hupcl=1 REV_hup=1 REV_cstopb=1 REV_cread=1
-REV_clocal=1 REV_crtscts=1 REV_ignbrk=1 REV_brkint=1 REV_ignpar=1
-REV_parmrk=1 REV_inpck=1 REV_istrip=1 REV_inlcr=1 REV_igncr=1 REV_icrnl=1
-REV_ixon=1 REV_ixoff=1 REV_tandem=1 REV_iuclc=1 REV_ixany=1 REV_imaxbel=1
-REV_iutf8=1 REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1
-REV_onlret=1 REV_ofill=1 REV_ofdel=1 REV_isig=1 REV_icanon=1 REV_iexten=1
-REV_echo=1 REV_echoe=1 REV_crterase=1 REV_echok=1 REV_echonl=1
-REV_noflsh=1 REV_xcase=1 REV_tostop=1 REV_echoprt=1 REV_prterase=1
-REV_echoctl=1 REV_ctlecho=1 REV_echoke=1 REV_crtkill=1 REV_evenp=1
-REV_parity=1 REV_oddp=1 REV_nl=1 REV_cooked=1 REV_raw=1 REV_pass8=1
-REV_litout=1 REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1
-
+# Get the reversible settings from stty.c.
+stty_reversible_settings

 saved_state=.saved-state
 stty --save > $saved_state || fail=1
@@ -70,35 +58,11 @@ for opt in $options; do

   # Likewise, 'stty -cread' would fail, so skip that, too.
   test $opt = cread && continue
-  eval rev=\$REV_$opt
-  if test -n "$rev"; then
+  if $(stty_reversible_matches "$opt") ; then
     stty -$opt || { fail=1; echo -$opt; }
   fi
 done

-if test -n "$RUN_LONG_TESTS"; then
-  # Take them in pairs.
-  for opt1 in $options; do
-    echo .|tr -d '\n'
-    for opt2 in $options; do
-
-      stty $opt1 $opt2 || fail=1
-
-      eval rev1=\$REV_$opt1
-      eval rev2=\$REV_$opt2
-      if test -n "$rev1"; then
-        stty -$opt1 $opt2 || fail=1
-      fi
-      if test -n "$rev2"; then
-        stty $opt1 -$opt2 || fail=1
-      fi
-      if test "$rev1$rev2" = 11; then
-        stty -$opt1 -$opt2 || fail=1
-      fi
-    done
-  done
-fi
-
 stty $(cat $saved_state)

 Exit $fail
diff --git a/tests/misc/stty-pairs b/tests/misc/stty-pairs
new file mode 100755
index 0000000..76808d4
--- /dev/null
+++ b/tests/misc/stty-pairs
@@ -0,0 +1,63 @@
+#!/bin/sh
+# Make sure stty can parse most of its options - in pairs [expensive].
+
+# Copyright (C) 1998-2012 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../src
+print_ver_ stty
+
+expensive_
+
+# Make sure there's a tty on stdin.
+require_controlling_input_terminal_
+trap '' TTOU # Ignore SIGTTOU
+
+# Get the reversible settings from stty.c.
+stty_reversible_settings
+
+saved_state=.saved-state
+stty --save > $saved_state || fail=1
+stty $(cat $saved_state) || fail=1
+
+# Build a list of all boolean options stty accepts on this system.
+# Don't depend on terminal width.  Put each option on its own line,
+# remove all non-boolean ones, remove 'parenb' and 'cread' explicitly,
+# then remove any leading hyphens.
+sed_del='/^speed/d;/^rows/d;/^columns/d;/ = /d;s/parenb//;s/cread//'
+options=$(stty -a | tr -s ';' '\n' | sed "s/^ //;$sed_del;s/-//g")
+
+# Take them in pairs, with and without the leading '-'.
+for opt1 in $options; do
+  for opt2 in $options; do
+
+    stty $opt1 $opt2 || fail=1
+
+    if $(stty_reversible_matches "$opt1") ; then
+      stty -$opt1 $opt2 || fail=1
+    fi
+    if $(stty_reversible_matches "$opt2"); then
+      stty $opt1 -$opt2 || fail=1
+    fi
+    if $(stty_reversible_matches "$opt1") \
+    && $(stty_reversible_matches "$opt2"); then
+      stty -$opt1 -$opt2 || fail=1
+    fi
+  done
+done
+
+stty $(cat $saved_state)
+
+Exit $fail
-- 
1.7.7



From MAILER-DAEMON Thu Apr 05 12:27:35 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFpX5-0008Et-6K
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 12:27:35 -0400
Received: from eggs.gnu.org ([208.118.235.92]:42463)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFoZe-0003JF-3l
	for coreutils@gnu.org; Thu, 05 Apr 2012 11:26:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFoZX-0001Cp-8D
	for coreutils@gnu.org; Thu, 05 Apr 2012 11:26:09 -0400
Received: from dorabella.servers.suso.com ([66.244.94.134]:37380)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFoZX-0001Aw-32
	for coreutils@gnu.org; Thu, 05 Apr 2012 11:26:03 -0400
Received: by dorabella.servers.suso.com (Postfix, from userid 1009)
	id 5B3701B13C; Thu,  5 Apr 2012 14:49:22 +0000 (GMT)
Date: Thu, 5 Apr 2012 14:49:22 +0000
From: Mark Krenz <mark@slugbug.org>
To: coreutils@gnu.org
Subject: cut enhancement: -C as short option for --complement
Message-ID: <20120405144922.GI28540@dorabella.servers.suso.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Received-From: 66.244.94.134
X-Mailman-Approved-At: Thu, 05 Apr 2012 12:27:34 -0400
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 15:26:16 -0000


  Hello, I use the cut command a fair amount from the command line and
having to type out the full option to complement can get tedious. I
would like to suggest having -C be the short option for --complement. It
seems like C might be a good choice for the option letter, although I'm
unsure if people might start thinking that -C would be the option that
takes the arguments for fields to exclude.

I made a quick patch against the latest source that seems to work ok and
have included it below. Comments?

diff --git a/src/cut.c b/src/cut.c
index fed9616..6d9cdc1 100644
--- a/src/cut.c
+++ b/src/cut.c
@@ -162,7 +162,6 @@ static Hash_table *range_start_ht;
 enum
 {
   OUTPUT_DELIMITER_OPTION = CHAR_MAX + 1,
-  COMPLEMENT_OPTION
 };
 
 static struct option const longopts[] =
@@ -173,7 +172,7 @@ static struct option const longopts[] =
   {"delimiter", required_argument, NULL, 'd'},
   {"only-delimited", no_argument, NULL, 's'},
   {"output-delimiter", required_argument, NULL, OUTPUT_DELIMITER_OPTION},
-  {"complement", no_argument, NULL, COMPLEMENT_OPTION},
+  {"complement", no_argument, NULL, 'C'},
   {GETOPT_HELP_OPTION_DECL},
   {GETOPT_VERSION_OPTION_DECL},
   {NULL, 0, NULL, 0}
@@ -209,7 +208,7 @@ Mandatory arguments to long options are mandatory for short options too.\n\
   -n                      (ignored)\n\
 "), stdout);
       fputs (_("\
-      --complement        complement the set of selected bytes, characters\n\
+  -C, --complement        complement the set of selected bytes, characters\n\
                             or fields\n\
 "), stdout);
       fputs (_("\
@@ -778,7 +777,7 @@ main (int argc, char **argv)
   delim = '\0';
   have_read_stdin = false;
 
-  while ((optc = getopt_long (argc, argv, "b:c:d:f:ns", longopts, NULL)) != -1)
+  while ((optc = getopt_long (argc, argv, "b:c:d:f:nCs", longopts, NULL)) != -1)
     {
       switch (optc)
         {
@@ -824,7 +823,7 @@ main (int argc, char **argv)
           suppress_non_delimited = true;
           break;
 
-        case COMPLEMENT_OPTION:
+        case 'C':
           complement = true;
           break;
 



-- 
Mark Krenz
mark@slugbug.org
 
Sent from Mutt using Linux


From MAILER-DAEMON Thu Apr 05 16:38:42 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFtS6-0006Fe-MT
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 16:38:42 -0400
Received: from eggs.gnu.org ([208.118.235.92]:35537)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFtS4-0006FC-H5
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:38:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFtS2-0003u9-Cy
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:38:40 -0400
Received: from dorabella.servers.suso.com ([66.244.94.134]:45949)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFtS2-0003sG-8T
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:38:38 -0400
Received: by dorabella.servers.suso.com (Postfix, from userid 1009)
	id 6B5911B1B0; Thu,  5 Apr 2012 20:38:15 +0000 (GMT)
Date: Thu, 5 Apr 2012 20:38:15 +0000
From: Mark Krenz <mark@slugbug.org>
To: coreutils@gnu.org
Subject: Re: cut enhancement: -C as short option for --complement
Message-ID: <20120405203815.GO28540@dorabella.servers.suso.com>
References: <20120405144922.GI28540@dorabella.servers.suso.com>
	<87ty0yqf7c.fsf@rho.meyering.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ty0yqf7c.fsf@rho.meyering.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Received-From: 66.244.94.134
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 20:38:42 -0000

On Thu, Apr 05, 2012 at 05:08:23PM GMT, Jim Meyering [jim@meyering.net] said the following:
> 
> Did you know that --co is an acceptable abbreviation for --complement?

  Actually I didn't know you can do this with programs that use getopts.
Do you happen to know where is this documented?

  I also feel like relying on this behavior can be a bad thing.
Eventually another option may come along and all the people who are used
to typing --co will suddenly need to use another character or two. Then
eventually you might as well just type in the whole option anyways.

> We try to avoid adding new short-named options unless there is a
> very compelling reason.

  I understand this stance and agree with it in many cases due to the
overpolluted option namespaces you see in some programs. However it
seems harmless enough in the case of the cut command, which has only a
few options and also already has the complement functionality, but
simply has no short option for it.

 Lots of programs have modes where they do the reverse of what they
normally do by default (grep -v for instance). I would think that a
short option for reversing cuts default operation would be a welcome
addition for many people. So I think that's a pretty compelling reason
to add a short option for it and save even more typing.


-- 
Mark Krenz
mark@slugbug.org
 
Sent from Mutt using Linux


From MAILER-DAEMON Thu Apr 05 16:45:58 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFtZ8-0007LW-DT
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 16:45:58 -0400
Received: from eggs.gnu.org ([208.118.235.92]:50311)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFtZ1-0007Ki-CC
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:45:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFtYw-0005aq-Bc
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:45:50 -0400
Received: from mx.meyering.net ([88.168.87.75]:52077)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFtYv-0005aZ-Rz
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:45:46 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 45ADF603E6;
	Thu,  5 Apr 2012 22:45:42 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Subject: Re: [PATCH] refactor expensive code in misc/stty [was: amendments to
	backtick-removing series]
In-Reply-To: <4F7D717A.4060700@bernhard-voelker.de> (Bernhard Voelker's
	message of "Thu, 05 Apr 2012 12:18:34 +0200")
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
	<87mx6rwm58.fsf@rho.meyering.net>
	<4F7D438A.7050609@bernhard-voelker.de>
	<87ty0ytxnq.fsf@rho.meyering.net>
	<4F7D717A.4060700@bernhard-voelker.de>
Date: Thu, 05 Apr 2012 22:45:42 +0200
Message-ID: <8762ddrjpl.fsf@rho.meyering.net>
Lines: 93
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: Andreas Schwab <schwab@linux-m68k.org>, coreutils@gnu.org,
	Sami Kerola <kerolasa@iki.fi>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 20:45:57 -0000

Bernhard Voelker wrote:
> CC'ing Sami as he sent another note privately.
>
> On 04/05/2012 10:01 AM, Jim Meyering wrote:
>
>> So iutf8 was added to stty.c (by me, 8 years ago), but not here,
>> so never exposed to these tests.  Good catch.
>
> Thanks.
>
>> What do you think about eval'ing the output of the command
>> just above, instead.  Then this won't happen again.
>
> I thought about that (but read on) ...
>
>
>> Or better, a function in init.cfg,
>>
>> stty_reversible_settings()
>> {
>>   local r
>>   r=$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
>>       $abs_top_srcdir/src/stty.c)
>>   # Ensure that there are at least 62, i.e., so we're alerted if
>>   # reformatting the source empties the list.
>>   test 62 -lt $(echo "$r"|wc -l) || framework_failure_
>>   echo "$r"
>> }
>
> a) s/lt/le/ ;-)

Yes, definitely.  Initially I had 60 there, but changed it
to match 62 (current total) at the last minute.
Moral: don't make last-minute changes.

>> Then, you could add this one-liner in each of those two files,
>> in place of the hard-coded list of REV_... variable settings:
>>
>>   # Set REV_$S=1 for each reversible stty setting, $S.
>>   eval $(stty_reversible_settings |sed 's/^/REV_/;s/$/=1/')
>>
>
> b) framework_failure_ in a subshell doesn't work.
> c) I don't like eval too much, it's harder to read.
>
> What about the following?

It's already an expensive test, but even so, adding four $(...) subshell
invocations in an inner loop that is run ~2-3000 times seems like it
would have non-negligible cost, especially on systems where subshells
are relatively expensive.

I guess I prefer the original eval-using code,
if you can find a way to make it work.

One caveat: I realized that the code on HEAD
is slightly vulnerable to unwarranted failure
because we use some $REV_... variables without
first ensuring they're set.  So if certain ones
happen to be set in the environment, they'll cause
this test to fail.

One way to avoid that is to initialize $REV_...=0
for each valid setting.

BTW, your patch below was corrupted because something
along the way converted non-leading TABs to spaces.

> P.S. I could've even overloaded the function in init.cfg
> to get the list when no arg is given, and otherwise test if
> the arg is in the internal list, but I think this is safer.
>
> Have a nice day,
> Berny
>
>
>>From b8e5e7e9f25d21284daffeca65634840dfb1d0c1 Mon Sep 17 00:00:00 2001
> From: Bernhard Voelker <mail@bernhard-voelker.de>
> Date: Thu, 5 Apr 2012 12:05:46 +0200
> Subject: [PATCH] tests: factor out expensive "pairs" code of misc/stty
>
> * tests/Makefile.am: Add misc/stty-pairs.
> * tests/init.cfg (stty_reversible_settings): Add new function to get
> the list of reversible options from stty.c.
> * tests/init.cfg (stty_reversible_matches): Add new function to test
> wether a given option is in the list of reversible options.
> * tests/misc/stty: Factor out expensive "pairs" code into new test.
> Use new stty_reversible_settings and stty_reversible_matches instead
> of evaluating static REV_* variables.
> * tests/misc/stty-pairs: Added new test. Code added from misc/stty.
> Mark this as an expensive test. Skip 'parenb' and 'cread' options,
> as these tests are known to fail. Like in misc/stty, also use
> new stty_reversible_settings and stty_reversible_matches.


From MAILER-DAEMON Thu Apr 05 16:54:54 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFthm-0000pv-5S
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 16:54:54 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45325)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFthe-0000of-L5
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:54:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFthT-0007TH-IG
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:54:45 -0400
Received: from mx.meyering.net ([88.168.87.75]:52101)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFthT-0007NL-9E
	for coreutils@gnu.org; Thu, 05 Apr 2012 16:54:35 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id A0756602C1;
	Thu,  5 Apr 2012 22:54:31 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Mark Krenz <mark@slugbug.org>
Subject: Re: cut enhancement: -C as short option for --complement
In-Reply-To: <20120405203815.GO28540@dorabella.servers.suso.com> (Mark Krenz's
	message of "Thu, 5 Apr 2012 20:38:15 +0000")
References: <20120405144922.GI28540@dorabella.servers.suso.com>
	<87ty0yqf7c.fsf@rho.meyering.net>
	<20120405203815.GO28540@dorabella.servers.suso.com>
Date: Thu, 05 Apr 2012 22:54:31 +0200
Message-ID: <87zkapq4qg.fsf@rho.meyering.net>
Lines: 58
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 20:54:52 -0000

Mark Krenz wrote:
> On Thu, Apr 05, 2012 at 05:08:23PM GMT, Jim Meyering
> [jim@meyering.net] said the following:
>>
>> Did you know that --co is an acceptable abbreviation for --complement?
>
>   Actually I didn't know you can do this with programs that use getopts.
> Do you happen to know where is this documented?

Sure.  "man 3 getopt_long"

   getopt_long() and getopt_long_only()
       The getopt_long() function works like  getopt()  except  that  it  also
       accepts long options, started with two dashes.  (If the program accepts
       only long options, then optstring  should  be  specified  as  an  empty
       string  (""),  not  NULL.)  Long option names may be abbreviated if the
       abbreviation is unique or is an exact match for some defined option.

>   I also feel like relying on this behavior can be a bad thing.

It is a good thing ;-)

> Eventually another option may come along and all the people who are used

If we were adding options frequently and/or blindly,
you might have a point, but we're well aware of the issues
and add new options infrequently.  When we do, we take care
not to impinge on existing abbreviations.

> to typing --co will suddenly need to use another character or two. Then
> eventually you might as well just type in the whole option anyways.

With a decent shell, you can type cut --co<TAB>, and it will type
the rest, completing that to "--complement".  If some day we add
another long-named option whose name starts with --co, when you hit
TAB, your shell will display the two remaining choices and you'll
have to type at least one more letter to select the one you want.

If you're using a script, just type out the full name, both for
readability and for future-portability.

>> We try to avoid adding new short-named options unless there is a
>> very compelling reason.
>
>   I understand this stance and agree with it in many cases due to the
> overpolluted option namespaces you see in some programs. However it
> seems harmless enough in the case of the cut command, which has only a
> few options and also already has the complement functionality, but
> simply has no short option for it.
>
>  Lots of programs have modes where they do the reverse of what they
> normally do by default (grep -v for instance). I would think that a
> short option for reversing cuts default operation would be a welcome
> addition for many people. So I think that's a pretty compelling reason
> to add a short option for it and save even more typing.

If we were to accept this sort of argument, ls would
have run out of option letters a couple of decades ago.  Sorry.


From MAILER-DAEMON Thu Apr 05 17:11:03 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFtxP-0003hJ-GP
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 17:11:03 -0400
Received: from eggs.gnu.org ([208.118.235.92]:60834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFtxN-0003gj-8K
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:11:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFtxH-00037r-4w
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:10:58 -0400
Received: from dorabella.servers.suso.com ([66.244.94.134]:52842)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFtxH-00036P-0R
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:10:55 -0400
Received: by dorabella.servers.suso.com (Postfix, from userid 1009)
	id 4BE5F1B1B0; Thu,  5 Apr 2012 21:10:29 +0000 (GMT)
Date: Thu, 5 Apr 2012 21:10:29 +0000
From: Mark Krenz <mark@slugbug.org>
To: Jim Meyering <jim@meyering.net>
Subject: Re: cut enhancement: -C as short option for --complement
Message-ID: <20120405211028.GP28540@dorabella.servers.suso.com>
References: <20120405144922.GI28540@dorabella.servers.suso.com>
	<87ty0yqf7c.fsf@rho.meyering.net>
	<20120405203815.GO28540@dorabella.servers.suso.com>
	<87zkapq4qg.fsf@rho.meyering.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87zkapq4qg.fsf@rho.meyering.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Received-From: 66.244.94.134
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 21:11:02 -0000

On Thu, Apr 05, 2012 at 08:54:31PM GMT, Jim Meyering [jim@meyering.net] said the following:
> > Eventually another option may come along and all the people who are used
> 
> If we were adding options frequently and/or blindly,
> you might have a point, but we're well aware of the issues
> and add new options infrequently.  When we do, we take care
> not to impinge on existing abbreviations.

  Thank you for the good job you have been doing in filtering out the
bad requests. I feel that most GNU commands are consise and not
littered with useless options.

  If you don't like the suggestion of using -C for the short option,
then would you suggest another letter that would be better?



-- 
Mark Krenz
mark@slugbug.org
 
Sent from Mutt using GNU/Linux


From MAILER-DAEMON Thu Apr 05 17:15:25 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFu1d-0004UI-5k
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 17:15:25 -0400
Received: from eggs.gnu.org ([208.118.235.92]:41915)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SFu1W-0004RA-Ok
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:15:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SFu1T-0004Dj-Q7
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:15:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26418)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SFu1T-0004DW-Hh
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:15:15 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q35LFDmc012092
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Thu, 5 Apr 2012 17:15:13 -0400
Received: from [10.3.113.144] (ovpn-113-144.phx2.redhat.com [10.3.113.144])
	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q35LFDvr016303; Thu, 5 Apr 2012 17:15:13 -0400
Message-ID: <4F7E0B60.4070903@redhat.com>
Date: Thu, 05 Apr 2012 15:15:12 -0600
From: Eric Blake <eblake@redhat.com>
Organization: Red Hat
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: Mark Krenz <mark@slugbug.org>
Subject: Re: cut enhancement: -C as short option for --complement
References: <20120405144922.GI28540@dorabella.servers.suso.com>
	<87ty0yqf7c.fsf@rho.meyering.net>
	<20120405203815.GO28540@dorabella.servers.suso.com>
	<87zkapq4qg.fsf@rho.meyering.net>
	<20120405211028.GP28540@dorabella.servers.suso.com>
In-Reply-To: <20120405211028.GP28540@dorabella.servers.suso.com>
X-Enigmail-Version: 1.4
OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enigB071A93FD125F94AE4E2B8F6"
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 21:15:24 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigB071A93FD125F94AE4E2B8F6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 04/05/2012 03:10 PM, Mark Krenz wrote:
> On Thu, Apr 05, 2012 at 08:54:31PM GMT, Jim Meyering [jim@meyering.net]=
 said the following:
>>> Eventually another option may come along and all the people who are u=
sed
>>
>> If we were adding options frequently and/or blindly,
>> you might have a point, but we're well aware of the issues
>> and add new options infrequently.  When we do, we take care
>> not to impinge on existing abbreviations.
>=20
>   Thank you for the good job you have been doing in filtering out the
> bad requests. I feel that most GNU commands are consise and not
> littered with useless options.
>=20
>   If you don't like the suggestion of using -C for the short option,
> then would you suggest another letter that would be better?

The _easiest_ way to justify a short option letter is by reference to
another implementation that has the same semantics, and use that letter.
 Another road to this would be proposing the feature for inclusion into
POSIX, and picking a letter as part of your proposal (since POSIX will
only standardize on short names, not --complement); if the feature is
deemed useful enough to standardize, you've managed to pick a short lette=
r.

In other words, it's not the choice of -C that we're worried about, it's
the fact that you're even proposing a short option in the first place
without providing compelling evidence that it is widely used or picked
up by other implementations.

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enigB071A93FD125F94AE4E2B8F6
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPfgtgAAoJEKeha0olJ0Nqw3YIAIUo1tX6BobRxRN38GKmNyNJ
HmUea0UngIR2j6xEF2XETaWiGF0wQ6Mdp6f8pZwM3B0falIrgqg/FMPe/HS2SdGH
dXvUnAfJZPiuITbNhuGVPirrUZqI1YeTf8W9gPk6TpdtW3Oqj0MsR3wLqeyV17c6
orKyybgp5J3b/MHBm4fGLU2SP8p9VXXyw/mSPq6aETwz8GJnsvm+X9rBhZm5kVbV
uaU7DXZYfNWmhCXKGwFCn4ZaAJFSTC/l4wMNKUQQa2ieOqzEQvqdvQyGQfiUntDZ
3nvveMcRhKePRwLMYd+oB6QDxtS9ICJIQXLo72khuBj6gIllPnZFONSoNbSWARk=
=7GZV
-----END PGP SIGNATURE-----

--------------enigB071A93FD125F94AE4E2B8F6--


From MAILER-DAEMON Thu Apr 05 17:30:31 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFuGF-0007Mz-3r
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 17:30:31 -0400
Received: from eggs.gnu.org ([208.118.235.92]:49654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFuG9-0007M8-6X
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:30:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFuG6-0007pV-QH
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:30:24 -0400
Received: from dorabella.servers.suso.com ([66.244.94.134]:40144)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFuG6-0007fW-Ll
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:30:22 -0400
Received: by dorabella.servers.suso.com (Postfix, from userid 1009)
	id EF5AA1B1B2; Thu,  5 Apr 2012 21:29:58 +0000 (GMT)
Date: Thu, 5 Apr 2012 21:29:57 +0000
From: Mark Krenz <mark@slugbug.org>
To: Eric Blake <eblake@redhat.com>
Subject: Re: cut enhancement: -C as short option for --complement
Message-ID: <20120405212956.GQ28540@dorabella.servers.suso.com>
References: <20120405144922.GI28540@dorabella.servers.suso.com>
	<87ty0yqf7c.fsf@rho.meyering.net>
	<20120405203815.GO28540@dorabella.servers.suso.com>
	<87zkapq4qg.fsf@rho.meyering.net>
	<20120405211028.GP28540@dorabella.servers.suso.com>
	<4F7E0B60.4070903@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F7E0B60.4070903@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Received-From: 66.244.94.134
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 21:30:30 -0000

On Thu, Apr 05, 2012 at 09:15:12PM GMT, Eric Blake [eblake@redhat.com] said the following:
> 
> The _easiest_ way to justify a short option letter is by reference to
> another implementation that has the same semantics, and use that letter.
>  Another road to this would be proposing the feature for inclusion into
> POSIX, and picking a letter as part of your proposal (since POSIX will
> only standardize on short names, not --complement); if the feature is
> deemed useful enough to standardize, you've managed to pick a short letter.
> 
> In other words, it's not the choice of -C that we're worried about, it's
> the fact that you're even proposing a short option in the first place
> without providing compelling evidence that it is widely used or picked
> up by other implementations.

 Ok, thanks for explaining this. I think I understand now. You're
worried that by choosing an option not in POSIX that it would be in
conflict with any future choice made in POSIX. That makes sense.

 Do you have any insight on submitting changes to the POSIX standards?

-- 
Mark Krenz
mark@slugbug.org
 
Sent from Mutt using Linux


From MAILER-DAEMON Thu Apr 05 17:48:31 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFuXf-00043n-1s
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 17:48:31 -0400
Received: from eggs.gnu.org ([208.118.235.92]:50961)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SFuXc-00042Y-5I
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:48:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SFuXW-0003I2-Gf
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:48:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47207)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SFuXW-0003HZ-8W
	for coreutils@gnu.org; Thu, 05 Apr 2012 17:48:22 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q35LmH9V020569
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Thu, 5 Apr 2012 17:48:17 -0400
Received: from [10.3.113.144] (ovpn-113-144.phx2.redhat.com [10.3.113.144])
	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q35LmGDg027443; Thu, 5 Apr 2012 17:48:16 -0400
Message-ID: <4F7E131F.4040809@redhat.com>
Date: Thu, 05 Apr 2012 15:48:15 -0600
From: Eric Blake <eblake@redhat.com>
Organization: Red Hat
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: Mark Krenz <mark@slugbug.org>
Subject: Re: cut enhancement: -C as short option for --complement
References: <20120405144922.GI28540@dorabella.servers.suso.com>
	<87ty0yqf7c.fsf@rho.meyering.net>
	<20120405203815.GO28540@dorabella.servers.suso.com>
	<87zkapq4qg.fsf@rho.meyering.net>
	<20120405211028.GP28540@dorabella.servers.suso.com>
	<4F7E0B60.4070903@redhat.com>
	<20120405212956.GQ28540@dorabella.servers.suso.com>
In-Reply-To: <20120405212956.GQ28540@dorabella.servers.suso.com>
X-Enigmail-Version: 1.4
OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enigECE56ECF885F3521D8836F4B"
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Apr 2012 21:48:29 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigECE56ECF885F3521D8836F4B
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 04/05/2012 03:29 PM, Mark Krenz wrote:
> On Thu, Apr 05, 2012 at 09:15:12PM GMT, Eric Blake [eblake@redhat.com] =
said the following:
>>
>> The _easiest_ way to justify a short option letter is by reference to
>> another implementation that has the same semantics, and use that lette=
r.
>>  Another road to this would be proposing the feature for inclusion int=
o
>> POSIX, and picking a letter as part of your proposal (since POSIX will=

>> only standardize on short names, not --complement); if the feature is
>> deemed useful enough to standardize, you've managed to pick a short le=
tter.
>>
>> In other words, it's not the choice of -C that we're worried about, it=
's
>> the fact that you're even proposing a short option in the first place
>> without providing compelling evidence that it is widely used or picked=

>> up by other implementations.
>=20
>  Ok, thanks for explaining this. I think I understand now. You're
> worried that by choosing an option not in POSIX that it would be in
> conflict with any future choice made in POSIX. That makes sense.

You got it!  Since long options are explicitly guaranteed to never
conflict with POSIX, we have a strong tendency to favor only a long
option until proven that a short option makes sense.

>=20
>  Do you have any insight on submitting changes to the POSIX standards?
>=20

http://austingroupbugs.net/main_page.php will let anyone submit a
feature proposal, although it probably helps to look at existing reports
to get a good idea of what it might take to make a successful feature
addition.

Here's a recent attempt by someone to standardize 'sed -i' for in-place
editing, along with some feedback that in that particular case, the
POSIX folks would be a bit happier inventing a new option 'sed -I' that
doesn't suffer from minor compatibility differences between existing -i
implementations: http://austingroupbugs.net/view.php?id=3D530

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enigECE56ECF885F3521D8836F4B
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPfhMgAAoJEKeha0olJ0NqekkIAIDoaRx926SVPYPxwHGzGs3O
2fjhuUcIlVDKamjPqTdW6L79CfrRL3fbt4Zq2fmZ6z6DvH4WR1EFIj6pWCs++ifa
GskoP0WlXdRJ5sPpNErzqsvVGcyzPCHlcslKHGnxnv7oSgg9Kb/Q67d/dDvrwXmZ
FNnXv5sMXJHsuHVicv9F44EggDUaGBTT1v/CL9BDF9nbHjB2Hc7D+EKiw9iP07Se
HtHFXttjGcnktNb2DiJhPV63Yu3i2lTnHo5Oos3KtYGdM8YAiSoM9nEWS3IBUJ/g
eBPQ3Diu6TvHFmJQzqE+RDMpywXlobb/7Q4LJVhRyLPCH9p5LBBt/kXCLqjaxkM=
=p9ID
-----END PGP SIGNATURE-----

--------------enigECE56ECF885F3521D8836F4B--


From MAILER-DAEMON Thu Apr 05 20:09:46 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFwkM-0000RX-Py
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 20:09:46 -0400
Received: from eggs.gnu.org ([208.118.235.92]:34839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFwkF-0000Oj-Fu
	for coreutils@gnu.org; Thu, 05 Apr 2012 20:09:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFwk8-00040d-Fs
	for coreutils@gnu.org; Thu, 05 Apr 2012 20:09:38 -0400
Received: from dorabella.servers.suso.com ([66.244.94.134]:36931)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark@dorabella.servers.suso.com>) id 1SFwk8-0003nr-AO
	for coreutils@gnu.org; Thu, 05 Apr 2012 20:09:32 -0400
Received: by dorabella.servers.suso.com (Postfix, from userid 1009)
	id 61E971B1C5; Fri,  6 Apr 2012 00:09:08 +0000 (GMT)
Date: Fri, 6 Apr 2012 00:09:08 +0000
From: Mark Krenz <mark@slugbug.org>
To: Eric Blake <eblake@redhat.com>
Subject: Re: cut enhancement: -C as short option for --complement
Message-ID: <20120406000908.GR28540@dorabella.servers.suso.com>
References: <20120405144922.GI28540@dorabella.servers.suso.com>
	<87ty0yqf7c.fsf@rho.meyering.net>
	<20120405203815.GO28540@dorabella.servers.suso.com>
	<87zkapq4qg.fsf@rho.meyering.net>
	<20120405211028.GP28540@dorabella.servers.suso.com>
	<4F7E0B60.4070903@redhat.com>
	<20120405212956.GQ28540@dorabella.servers.suso.com>
	<4F7E131F.4040809@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F7E131F.4040809@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older,
	4)
X-Received-From: 66.244.94.134
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2012 00:09:44 -0000

On Thu, Apr 05, 2012 at 09:48:15PM GMT, Eric Blake [eblake@redhat.com] said the following:
> 
> http://austingroupbugs.net/main_page.php will let anyone submit a
> feature proposal, although it probably helps to look at existing reports
> to get a good idea of what it might take to make a successful feature
> addition.
> 
> Here's a recent attempt by someone to standardize 'sed -i' for in-place
> editing, along with some feedback that in that particular case, the
> POSIX folks would be a bit happier inventing a new option 'sed -I' that
> doesn't suffer from minor compatibility differences between existing -i
> implementations: http://austingroupbugs.net/view.php?id=530
> 

  Ok great. With any luck, I'll be back in a few years to suggest -C
again. ;-)


-- 
Mark Krenz
mark@slugbug.org
 
Sent from Mutt using Linux


From MAILER-DAEMON Thu Apr 05 20:13:33 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SFwo1-0001FV-5a
	for mharc-coreutils@gnu.org; Thu, 05 Apr 2012 20:13:33 -0400
Received: from eggs.gnu.org ([208.118.235.92]:35414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SFwnw-0001Ec-HL
	for coreutils@gnu.org; Thu, 05 Apr 2012 20:13:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SFwnr-0004q1-2v
	for coreutils@gnu.org; Thu, 05 Apr 2012 20:13:28 -0400
Received: from mail-ob0-f169.google.com ([209.85.214.169]:39181)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>)
	id 1SFwnq-0004pW-My; Thu, 05 Apr 2012 20:13:22 -0400
Received: by obbta14 with SMTP id ta14so3026389obb.0
	for <multiple recipients>; Thu, 05 Apr 2012 17:13:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=sender:message-id:date:from:reply-to:organization:user-agent
	:mime-version:to:cc:subject:references:in-reply-to:content-type
	:content-transfer-encoding;
	bh=2jnZxD1VgkYOiBBfckulFIEHLZRiFFG4vOkb6Y1Qnk0=;
	b=mUE3Ga8NKR/n0MQXKXHh8NtUE8hVFmM+dAWq2MGl5Nd3UESEQQNTQd0hhD4620obMQ
	q2zvib+Xa+d+r7ntt3yADr049VTe11ZeUMQTGV7S9IGsnizHYYFJkdxazK2zPGDrWu+W
	ujErHg+V2YVtu+6bnBl9rn9khiteDyaLn5XWXIL0zHtTsVTdtPrtvRfgpZewVX7gJJHr
	TkSl/nkUZgyYAllqiQOmYK+MF3dv9f2MAHCiT6221+nCpydTooMLyp1FWVcHdOd4la2f
	c/kioL2i28fhJEMbJ0//DVCmqlyEQngKGwWAtkj1mPpen8nLQ5BIpYqKJh2CTE374d1b
	3qKA==
Received: by 10.60.22.138 with SMTP id d10mr6515438oef.69.1333671197514;
	Thu, 05 Apr 2012 17:13:17 -0700 (PDT)
Received: from [192.168.10.2] (adsl-75-2-130-180.dsl.pltn13.sbcglobal.net.
	[75.2.130.180])
	by mx.google.com with ESMTPS id xh3sm5713255obb.13.2012.04.05.17.13.15
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 05 Apr 2012 17:13:16 -0700 (PDT)
Sender: Bruce Korb <bruce.korb@gmail.com>
Message-ID: <4F7E351A.40909@gnu.org>
Date: Thu, 05 Apr 2012 17:13:14 -0700
From: Bruce Korb <bkorb@gnu.org>
Organization: FSF
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: coreutils@gnu.org
Subject: Re: [PATCH] fmt: optionalize line width goal
References: <4F68A271.6030101@gnu.org>
In-Reply-To: <4F68A271.6030101@gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.214.169
Cc: bkorb@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: bkorb@gnu.org
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2012 00:13:32 -0000

NEWS - check
tests/fmt/g-option - check (I also moved two other fmt tests)
doc/coreutils.texi - check
Oh, and src/fmt.c, too.

BSD's implementation allows a goal specification and has a different
default goal width computation anyway.  This change adds a "-g" option
and allows the first two numeric operands to represent the goal width
and actual line width.

* src/fmt.c (main): implement the new option
(check_for_goals): new function to implement the operands
Based on BSD's and Plan-9's fmt programs.
---
  NEWS                     |    4 +++
  THANKS.in                |    3 ++
  doc/coreutils.texi       |   12 ++++++--
  src/fmt.c                |   39 ++++++++++++++++++++++++---
  tests/Makefile.am        |    5 ++-
  tests/fmt/base           |   64 ++++++++++++++++++++++++++++++++++++++++++++++
  tests/fmt/g-option       |   58 +++++++++++++++++++++++++++++++++++++++++
  tests/fmt/long-line      |   61 +++++++++++++++++++++++++++++++++++++++++++
  tests/misc/fmt           |   64 ----------------------------------------------
  tests/misc/fmt-long-line |   61 -------------------------------------------
  10 files changed, 236 insertions(+), 135 deletions(-)
  create mode 100755 tests/fmt/base
  create mode 100755 tests/fmt/g-option
  create mode 100755 tests/fmt/long-line
  delete mode 100755 tests/misc/fmt
  delete mode 100755 tests/misc/fmt-long-line

diff --git a/NEWS b/NEWS
index c8d2bbc..0442ca8 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,10 @@ GNU coreutils NEWS                                    -*- outline -*-

  * Noteworthy changes in release ?.? (????-??-??) [?]

+** New features
+
+  fmt now supports the -g option for specifying the "goal" width.
+

  * Noteworthy changes in release 8.16 (2012-03-26) [stable]

diff --git a/THANKS.in b/THANKS.in
index d23f7b3..9a525c4 100644
--- a/THANKS.in
+++ b/THANKS.in
@@ -11,6 +11,8 @@ note to the bug-report mailing list (as seen at end of e.g., cp --help).
  ## is used to generate the THANKS file.  Note that numerous people listed
  ## here would have been listed as commit authors if we had been using git
  ## for version control when they contributed.
+##
+## Well, not completely true.  It misses sometimes.

  ???                                 kytek@cybercomm.net
  A Costa                             agcosta@gis.net
@@ -97,6 +99,7 @@ Brian M. Carlson                    sandals@crustytoothpaste.ath.cx
  Brian Silverman                     bsilverman@conceptxdesign.com
  Brian Youmans                       3diff@gnu.org
  Britton Leo Kerin                   fsblk@aurora.uaf.edu
+Bruce Korb                          bkorb@gnu.org
  Bruce Robertson                     brucer@theodolite.dyndns.org
  Carl Johnson                        carlj@cjlinux.home.org
  Carl Lowenstein                     cdl@mpl.UCSD.EDU
diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index 510abb9..bcc054a 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -2203,9 +2203,15 @@ between sentences to two spaces.
  @opindex -@var{width}
  @opindex -w
  @opindex --width
-Fill output lines up to @var{width} characters (default 75).  @command{fmt}
-initially tries to make lines about 7% shorter than this, to give it
-room to balance line lengths.
+Fill output lines up to @var{width} characters (default 75 or @var{goal} plus 10,
+if @var{goal} is provided).
+
+@itemx -g @var{goal}
+@itemx --goal=@var{goal}
+@opindex -g
+@opindex --goal
+@command{fmt} initially tries to make lines @var{goal} characters wide.
+By default, this is 7% shorter than @var{width}.

  @item -p @var{prefix}
  @itemx --prefix=@var{prefix}
diff --git a/src/fmt.c b/src/fmt.c
index 89d13a6..fc2a7b5 100644
--- a/src/fmt.c
+++ b/src/fmt.c
@@ -68,7 +68,7 @@ typedef long int COST;
  #define SQR(n)		((n) * (n))
  #define EQUIV(n)	SQR ((COST) (n))

-/* Cost of a filled line n chars longer or shorter than best_width.  */
+/* Cost of a filled line n chars longer or shorter than goal_width.  */
  #define SHORT_COST(n)	EQUIV ((n) * 10)

  /* Cost of the difference between adjacent filled lines.  */
@@ -201,7 +201,7 @@ static int prefix_lead_space;
  static int prefix_length;

  /* The preferred width of text lines, set to LEEWAY % less than max_width.  */
-static int best_width;
+static int goal_width;

  /* Dynamic variables.  */

@@ -286,6 +286,7 @@ Mandatory arguments to long options are mandatory for short options too.\n\
    -t, --tagged-paragraph    indentation of first line different from second\n\
    -u, --uniform-spacing     one space between words, two after sentences\n\
    -w, --width=WIDTH         maximum line width (default of 75 columns)\n\
+  -g, --goal=WIDTH          goal width (default of 93% of width)\n\
  "), stdout);
        fputs (HELP_OPTION_DESCRIPTION, stdout);
        fputs (VERSION_OPTION_DESCRIPTION, stdout);
@@ -308,6 +309,7 @@ static struct option const long_options[] =
    {"tagged-paragraph", no_argument, NULL, 't'},
    {"uniform-spacing", no_argument, NULL, 'u'},
    {"width", required_argument, NULL, 'w'},
+  {"goal", required_argument, NULL, 'g'},
    {GETOPT_HELP_OPTION_DECL},
    {GETOPT_VERSION_OPTION_DECL},
    {NULL, 0, NULL, 0},
@@ -319,6 +321,7 @@ main (int argc, char **argv)
    int optchar;
    bool ok = true;
    char const *max_width_option = NULL;
+  char const *goal_width_option = NULL;

    initialize_main (&argc, &argv);
    set_program_name (argv[0]);
@@ -344,7 +347,7 @@ main (int argc, char **argv)
        argc--;
      }

-  while ((optchar = getopt_long (argc, argv, "0123456789cstuw:p:",
+  while ((optchar = getopt_long (argc, argv, "0123456789cstuw:p:g:",
                                   long_options, NULL))
           != -1)
      switch (optchar)
@@ -376,6 +379,10 @@ main (int argc, char **argv)
          max_width_option = optarg;
          break;

+      case 'g':
+        goal_width_option = optarg;
+        break;
+
        case 'p':
          set_prefix (optarg);
          break;
@@ -398,7 +405,22 @@ main (int argc, char **argv)
        max_width = tmp;
      }

-  best_width = max_width * (2 * (100 - LEEWAY) + 1) / 200;
+  if (goal_width_option)
+    {
+      /* Limit goal_width to max_width.  */
+      unsigned long int tmp;
+      if (! (xstrtoul (goal_width_option, NULL, 10, &tmp, "") == LONGINT_OK
+             && tmp <= max_width))
+        error (EXIT_FAILURE, 0, _("invalid width: %s"),
+               quote (goal_width_option));
+      goal_width = tmp;
+      if (max_width_option == NULL)
+        max_width = goal_width + 10;
+    }
+  else
+    {
+      goal_width = max_width * (2 * (100 - LEEWAY) + 1) / 200;
+    }

    if (optind == argc)
      fmt (stdin);
@@ -924,7 +946,7 @@ line_cost (WORD *next, int len)

    if (next == word_limit)
      return 0;
-  n = best_width - len;
+  n = goal_width - len;
    cost = SHORT_COST (n);
    if (next->next_break != word_limit)
      {
@@ -1010,3 +1032,10 @@ put_space (int space)
        out_column++;
      }
  }
+/*
+ * Local Variables:
+ * mode: C
+ * c-file-style: "gnu"
+ * indent-tabs-mode: nil
+ * End:
+ * end of fmt.c */
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 011051a..47c29bf 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -140,6 +140,9 @@ TESTS =						\
    chgrp/no-x					\
    chgrp/posix-H					\
    chgrp/recurse					\
+  fmt/base					\
+  fmt/long-line					\
+  fmt/g-option					\
    misc/env					\
    misc/ptx					\
    misc/test					\
@@ -188,8 +191,6 @@ TESTS =						\
    misc/expr					\
    misc/factor					\
    misc/false-status				\
-  misc/fmt					\
-  misc/fmt-long-line				\
    misc/fold					\
    misc/groups-dash				\
    misc/groups-version				\
diff --git a/tests/fmt/base b/tests/fmt/base
new file mode 100755
index 0000000..e94d613
--- /dev/null
+++ b/tests/fmt/base
@@ -0,0 +1,64 @@
+#!/usr/bin/perl
+# Basic tests for "fmt".
+
+# Copyright (C) 2001-2012 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+use strict;
+
+(my $program_name = $0) =~ s|.*/||;
+
+my @Tests =
+    (
+     ['8-bit-pfx', qw (-p 'Ă§'),
+      {IN=> "Ă§a\nĂ§b\n"},
+      {OUT=>"Ă§a b\n"}],
+     ['wide-1', '-w 32768',
+      {ERR => "fmt: invalid width: '32768'\n"}, {EXIT => 1}],
+     ['wide-2', '-w 2147483647',
+      {ERR => "fmt: invalid width: '2147483647'\n"}, {EXIT => 1}],
+     ['bad-suffix', '-72x',	{IN=> ''},
+      {ERR => "fmt: invalid width: '72x'\n"}, {EXIT => 1}],
+     ['no-file', 'no-such-file',
+      {ERR => "fmt: cannot open 'no-such-file' for reading:"
+       . " No such file or directory\n"}, {EXIT => 1}],
+     ['obs-1', '-c -72',
+      {ERR => "fmt: invalid option -- 7; -WIDTH is recognized only when it"
+       . " is the first\noption; use -w N instead\n"
+       . "Try 'fmt --help' for more information.\n" }, {EXIT => 1}],
+
+     # With --prefix=P, do not remove leading space on lines without the prefix.
+     ['pfx-1', qw (-p '>'),
+      {IN=>  " 1\n  2\n\t3\n\t\t4\n> quoted\n> text\n"},
+      {OUT=> " 1\n  2\n\t3\n\t\t4\n> quoted text\n"}],
+
+     # Don't remove prefix from a prefix-only line.
+     ['pfx-only', qw (-p '>'),
+      {IN=>  ">\n"},
+      {OUT=> ">\n"}],
+
+     # With a multi-byte prefix, say, "foo", don't empty a line that
+     # starts with a strict prefix (e.g. "fo") of that prefix.
+     # With fmt from coreutils-6.7, it would mistakenly output an empty line.
+     ['pfx-of-pfx', qw (-p 'foo'),
+      {IN=>  "fo\n"},
+      {OUT=> "fo\n"}],
+);
+
+my $save_temps = $ENV{DEBUG};
+my $verbose = $ENV{VERBOSE};
+my $prog = 'fmt';
+my $fail = run_tests ($program_name, $prog, \@Tests, $save_temps, $verbose);
+exit $fail;
diff --git a/tests/fmt/g-option b/tests/fmt/g-option
new file mode 100644
index 0000000..e9a9a33
--- /dev/null
+++ b/tests/fmt/g-option
@@ -0,0 +1,58 @@
+#!/bin/sh
+# Exercise the fmt -g option.
+
+# Copyright (C) 2012 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../src
+print_ver_ fmt
+
+fmt -g 60 -w 72 <<\_EOF_ > base
+
+@command{fmt} prefers breaking lines at the end of a sentence, and tries to
+avoid line breaks after the first word of a sentence or before the last word
+of a sentence.  A @dfn{sentence break} is defined as either the end of a
+paragraph or a word ending in any of @samp{.?!}, followed by two spaces or end
+of line, ignoring any intervening parentheses or quotes.  Like @TeX{},
+@command{fmt} reads entire ``paragraphs'' before choosing line breaks; the
+algorithm is a variant of that given by
+Donald E. Knuth and Michael F. Plass
+in ``Breaking Paragraphs Into Lines'',
+@cite{Software---Practice & Experience}
+@b{11}, 11 (November 1981), 1119--1184.
+_EOF_
+
+fmt -g 60 -w 72 base > out
+
+cat <<\_EOF_ > exp
+
+@command{fmt} prefers breaking lines at the end of a sentence,
+and tries to avoid line breaks after the first word of a sentence
+or before the last word of a sentence.  A @dfn{sentence break}
+is defined as either the end of a paragraph or a word ending
+in any of @samp{.?!}, followed by two spaces or end of line,
+ignoring any intervening parentheses or quotes.  Like @TeX{},
+@command{fmt} reads entire ``paragraphs'' before choosing line
+breaks; the algorithm is a variant of that given by Donald
+E. Knuth and Michael F. Plass in ``Breaking Paragraphs Into
+Lines'', @cite{Software---Practice & Experience} @b{11}, 11
+(November 1981), 1119--1184.
+_EOF_
+
+touch exp
+
+compare exp out || fail=1
+
+Exit $fail
diff --git a/tests/fmt/long-line b/tests/fmt/long-line
new file mode 100755
index 0000000..04674e2
--- /dev/null
+++ b/tests/fmt/long-line
@@ -0,0 +1,61 @@
+#!/bin/sh
+# make sure fmt -s works even on long lines
+
+# Copyright (C) 2002-2012 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../src
+print_ver_ fmt
+
+printf '%2030s\n' ' '|sed 's/../ y/g' > in || framework_failure_
+
+cat <<\EOF > exp || framework_failure_
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+ y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
+EOF
+
+
+fmt -s in > out || fail=1
+
+compare exp out || fail=1
+
+Exit $fail
diff --git a/tests/misc/fmt b/tests/misc/fmt
deleted file mode 100755
index e94d613..0000000
--- a/tests/misc/fmt
+++ /dev/null
@@ -1,64 +0,0 @@
-#!/usr/bin/perl
-# Basic tests for "fmt".
-
-# Copyright (C) 2001-2012 Free Software Foundation, Inc.
-
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-use strict;
-
-(my $program_name = $0) =~ s|.*/||;
-
-my @Tests =
-    (
-     ['8-bit-pfx', qw (-p 'Ă§'),
-      {IN=> "Ă§a\nĂ§b\n"},
-      {OUT=>"Ă§a b\n"}],
-     ['wide-1', '-w 32768',
-      {ERR => "fmt: invalid width: '32768'\n"}, {EXIT => 1}],
-     ['wide-2', '-w 2147483647',
-      {ERR => "fmt: invalid width: '2147483647'\n"}, {EXIT => 1}],
-     ['bad-suffix', '-72x',	{IN=> ''},
-      {ERR => "fmt: invalid width: '72x'\n"}, {EXIT => 1}],
-     ['no-file', 'no-such-file',
-      {ERR => "fmt: cannot open 'no-such-file' for reading:"
-       . " No such file or directory\n"}, {EXIT => 1}],
-     ['obs-1', '-c -72',
-      {ERR => "fmt: invalid option -- 7; -WIDTH is recognized only when it"
-       . " is the first\noption; use -w N instead\n"
-       . "Try 'fmt --help' for more information.\n" }, {EXIT => 1}],
-
-     # With --prefix=P, do not remove leading space on lines without the prefix.
-     ['pfx-1', qw (-p '>'),
-      {IN=>  " 1\n  2\n\t3\n\t\t4\n> quoted\n> text\n"},
-      {OUT=> " 1\n  2\n\t3\n\t\t4\n> quoted text\n"}],
-
-     # Don't remove prefix from a prefix-only line.
-     ['pfx-only', qw (-p '>'),
-      {IN=>  ">\n"},
-      {OUT=> ">\n"}],
-
-     # With a multi-byte prefix, say, "foo", don't empty a line that
-     # starts with a strict prefix (e.g. "fo") of that prefix.
-     # With fmt from coreutils-6.7, it would mistakenly output an empty line.
-     ['pfx-of-pfx', qw (-p 'foo'),
-      {IN=>  "fo\n"},
-      {OUT=> "fo\n"}],
-);
-
-my $save_temps = $ENV{DEBUG};
-my $verbose = $ENV{VERBOSE};
-my $prog = 'fmt';
-my $fail = run_tests ($program_name, $prog, \@Tests, $save_temps, $verbose);
-exit $fail;
diff --git a/tests/misc/fmt-long-line b/tests/misc/fmt-long-line
deleted file mode 100755
index 04674e2..0000000
--- a/tests/misc/fmt-long-line
+++ /dev/null
@@ -1,61 +0,0 @@
-#!/bin/sh
-# make sure fmt -s works even on long lines
-
-# Copyright (C) 2002-2012 Free Software Foundation, Inc.
-
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-. "${srcdir=.}/init.sh"; path_prepend_ ../src
-print_ver_ fmt
-
-printf '%2030s\n' ' '|sed 's/../ y/g' > in || framework_failure_
-
-cat <<\EOF > exp || framework_failure_
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
- y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y y
-EOF
-
-
-fmt -s in > out || fail=1
-
-compare exp out || fail=1
-
-Exit $fail
-- 
1.7.7


From MAILER-DAEMON Fri Apr 06 06:25:54 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SG6Mc-0001xK-C4
	for mharc-coreutils@gnu.org; Fri, 06 Apr 2012 06:25:54 -0400
Received: from eggs.gnu.org ([208.118.235.92]:46694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFqAr-0005Ey-FC
	for coreutils@gnu.org; Thu, 05 Apr 2012 13:08:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFqAk-0003BZ-8B
	for coreutils@gnu.org; Thu, 05 Apr 2012 13:08:39 -0400
Received: from mx.meyering.net ([88.168.87.75]:51423)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SFqAj-0003As-Vo
	for coreutils@gnu.org; Thu, 05 Apr 2012 13:08:34 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 12E52602C1;
	Thu,  5 Apr 2012 19:08:24 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Mark Krenz <mark@slugbug.org>
Subject: Re: cut enhancement: -C as short option for --complement
In-Reply-To: <20120405144922.GI28540@dorabella.servers.suso.com> (Mark Krenz's
	message of "Thu, 5 Apr 2012 14:49:22 +0000")
References: <20120405144922.GI28540@dorabella.servers.suso.com>
Date: Thu, 05 Apr 2012 19:08:23 +0200
Message-ID: <87ty0yqf7c.fsf@rho.meyering.net>
Lines: 18
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Apr 2012 10:25:53 -0000

Mark Krenz wrote:
>   Hello, I use the cut command a fair amount from the command line and
> having to type out the full option to complement can get tedious. I
> would like to suggest having -C be the short option for --complement. It
> seems like C might be a good choice for the option letter, although I'm
> unsure if people might start thinking that -C would be the option that
> takes the arguments for fields to exclude.
>
> I made a quick patch against the latest source that seems to work ok and
> have included it below. Comments?

Did you know that --co is an acceptable abbreviation for --complement?
Normally --c would work, but that is ambiguous due to the presence
of the --characters=LIST option, so you have to add the "o" to come
up with a unique option prefix.

We try to avoid adding new short-named options unless there is a
very compelling reason.


From MAILER-DAEMON Tue Apr 10 05:14:32 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SHX9k-0006Sc-6R
	for mharc-coreutils@gnu.org; Tue, 10 Apr 2012 05:14:32 -0400
Received: from eggs.gnu.org ([208.118.235.92]:44301)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SHX9c-0006ST-Nq
	for coreutils@gnu.org; Tue, 10 Apr 2012 05:14:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SHX9V-00064K-Nq
	for coreutils@gnu.org; Tue, 10 Apr 2012 05:14:24 -0400
Received: from moutng.kundenserver.de ([212.227.126.187]:60962)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SHX9V-0005zx-Cw
	for coreutils@gnu.org; Tue, 10 Apr 2012 05:14:17 -0400
Received: from [192.168.2.108] (p4FF76144.dip.t-dialin.net [79.247.97.68])
	by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis)
	id 0MLfvf-1SGi4U0wTL-000hXL; Tue, 10 Apr 2012 11:14:14 +0200
Message-ID: <4F83F9E3.3090800@bernhard-voelker.de>
Date: Tue, 10 Apr 2012 11:14:11 +0200
From: Bernhard Voelker <mail@bernhard-voelker.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH] refactor expensive code in misc/stty [was: amendments
	to backtick-removing series]
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
	<87mx6rwm58.fsf@rho.meyering.net>
	<4F7D438A.7050609@bernhard-voelker.de>
	<87ty0ytxnq.fsf@rho.meyering.net>
	<4F7D717A.4060700@bernhard-voelker.de>
	<8762ddrjpl.fsf@rho.meyering.net>
In-Reply-To: <8762ddrjpl.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Provags-ID: V02:K0:qPtAtcKddtbLPZl5FstOcbaEG94yJ4QAyJ94jwSiy9H
	J/VvINlt9Nl5DBFNyQVbyyB5ZTqbuptwluahNqMTwoL1ihJMVU
	OVi3hyHuntwHFWUfcR2r6kinXmYvDG9Rw88QkTR6fD6uY+s6XG
	nuFoczC4OQ427AGER4AFliyv15/VfGuvdrOOwHqgYlYfVXAF/x
	81jOazmJnBF5K02ecOX5Fe9wbgRxmfQxiRE13uTWEhyji9UzL2
	pHdtSZJKAbJGzT3THsDHr+U2WGJW+CxCwZQVSRZngULOVqmiZp
	RWjow22+Z1QE1988Gvg30mRaqv0Ey2HhMvsGuFGDNVCH71lrE5
	Lxjl5EeQ+sgZljYvy0S2hI8XGOYr0lHIRKjZu1ZLR
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 212.227.126.187
Cc: Andreas Schwab <schwab@linux-m68k.org>, coreutils@gnu.org,
	Sami Kerola <kerolasa@iki.fi>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2012 09:14:31 -0000

On 04/05/2012 10:45 PM, Jim Meyering wrote:
> Bernhard Voelker wrote:
>> What about the following?
> 
> It's already an expensive test, but even so, adding four $(...) subshell
> invocations in an inner loop that is run ~2-3000 times seems like it
> would have non-negligible cost, especially on systems where subshells
> are relatively expensive.
> 
> I guess I prefer the original eval-using code,
> if you can find a way to make it work.

ah yes, the subshells are silly. I just removed them.
The time for this test is now down from 13s with the
original master version to 8 seconds.

I kept sticking to replace the eval-using code because - as
the variable store is now used from 2 test files - I liked
the idea that the "how the REVs are stored" is encapsulated
centrally in the 2 new shell functions in init.cfg.

> BTW, your patch below was corrupted because something
> along the way converted non-leading TABs to spaces.

Argh, it wasn't Thunderbird this time. I copied the patch from
an xterm, and during this, the TABs in Makefile.am have been
replaced (see also [1]). xclip is doing better.

Have a nice day,
Berny

[1] http://kernel.org/doc/Documentation/email-clients.txt


>From f71ed9ae1a9699e000a98c26dae4db96a628d657 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Thu, 5 Apr 2012 08:01:43 +0200
Subject: [PATCH 1/2] tests: add iutf8 option to misc/stty

* tests/misc/stty: Add iutf8 to the list of REV_* options.
That option has been implemented in commit v5.2.1-193-g733e79e.
---
 tests/misc/stty |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/tests/misc/stty b/tests/misc/stty
index 1b082c2..cfc70c1 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -29,13 +29,13 @@ REV_parenb=1 REV_parodd=1 REV_hupcl=1 REV_hup=1 REV_cstopb=1 REV_cread=1
 REV_clocal=1 REV_crtscts=1 REV_ignbrk=1 REV_brkint=1 REV_ignpar=1
 REV_parmrk=1 REV_inpck=1 REV_istrip=1 REV_inlcr=1 REV_igncr=1 REV_icrnl=1
 REV_ixon=1 REV_ixoff=1 REV_tandem=1 REV_iuclc=1 REV_ixany=1 REV_imaxbel=1
-REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1 REV_onlret=1
-REV_ofill=1 REV_ofdel=1 REV_isig=1 REV_icanon=1 REV_iexten=1 REV_echo=1
-REV_echoe=1 REV_crterase=1 REV_echok=1 REV_echonl=1 REV_noflsh=1
-REV_xcase=1 REV_tostop=1 REV_echoprt=1 REV_prterase=1 REV_echoctl=1
-REV_ctlecho=1 REV_echoke=1 REV_crtkill=1 REV_evenp=1 REV_parity=1
-REV_oddp=1 REV_nl=1 REV_cooked=1 REV_raw=1 REV_pass8=1 REV_litout=1
-REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1
+REV_iutf8=1 REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1
+REV_onlret=1 REV_ofill=1 REV_ofdel=1 REV_isig=1 REV_icanon=1 REV_iexten=1
+REV_echo=1 REV_echoe=1 REV_crterase=1 REV_echok=1 REV_echonl=1
+REV_noflsh=1 REV_xcase=1 REV_tostop=1 REV_echoprt=1 REV_prterase=1
+REV_echoctl=1 REV_ctlecho=1 REV_echoke=1 REV_crtkill=1 REV_evenp=1
+REV_parity=1 REV_oddp=1 REV_nl=1 REV_cooked=1 REV_raw=1 REV_pass8=1
+REV_litout=1 REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1


 saved_state=.saved-state
-- 
1.7.7


>From 300b08919fca2c2e65122d76f9ed45b5317845b5 Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail@bernhard-voelker.de>
Date: Tue, 10 Apr 2012 10:10:50 +0200
Subject: [PATCH 2/2] tests: factor out expensive "pairs" code of misc/stty

* tests/Makefile.am: Add misc/stty-pairs.
* tests/init.cfg (stty_reversible_settings): Add new function to get
the list of reversible options from stty.c.
* tests/init.cfg (stty_reversible_matches): Add new function to test
wether a given option is in the list of reversible options.
* tests/misc/stty: Factor out expensive "pairs" code into new test.
Use new stty_reversible_settings and stty_reversible_matches instead
of evaluating static REV_* variables.
* tests/misc/stty-pairs: Added new test. Code added from misc/stty.
Mark this as an expensive test. Skip 'parenb' and 'cread' options,
as these tests are known to fail. Like in misc/stty, also use
new stty_reversible_settings and stty_reversible_matches.
---
 tests/Makefile.am     |    1 +
 tests/init.cfg        |   27 +++++++++++++++++++++
 tests/misc/stty       |   42 ++------------------------------
 tests/misc/stty-pairs |   63 +++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 94 insertions(+), 39 deletions(-)
 create mode 100755 tests/misc/stty-pairs

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 011051a..86afbc2 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -274,6 +274,7 @@ TESTS =						\
   misc/stdbuf					\
   misc/stty					\
   misc/stty-invalid				\
+  misc/stty-pairs				\
   misc/stty-row-col				\
   misc/su-fail					\
   misc/sum					\
diff --git a/tests/init.cfg b/tests/init.cfg
index 7bcd512..08645d1 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -241,6 +241,33 @@ rwx_to_mode_()
   echo "=$u$g$o"
 }

+# Return the reversible settings from stty.c.
+# Fill the variable REV which is needed by stty_reversible_matches.
+stty_reversible_settings()
+{
+  # Pad start with one blank for the first option
+  # to match in stty_reversible_matches.
+  REV=" "$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
+      $abs_top_srcdir/src/stty.c | tr '\n' ' ')
+  # Ensure that there are at least 62, i.e., so we're alerted if
+  # reformatting the source empties the list.
+  test 62 -le $(echo "$REV"|wc -w)  \
+    || framework_failure_ "too few reversible settings"
+}
+
+# Test if $1 is among the reversible stty options ($REV).
+stty_reversible_matches()
+{
+  case "$REV" in
+    "")
+      framework_failure_ "stty_reversible_settings() not called?";;
+    *" $1 "*)
+      return 0;;
+    *)
+      return 1;;
+  esac
+}
+
 skip_if_()
 {
   case $1 in
diff --git a/tests/misc/stty b/tests/misc/stty
index cfc70c1..10aaa0a 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -23,20 +23,8 @@ print_ver_ stty
 require_controlling_input_terminal_
 trap '' TTOU # Ignore SIGTTOU

-# The following list of reversible options was generated with
-# grep -w REV stty.c|sed -n '/^  {"/{s//REV_/;s/".*/=1/;p;}'|fmt
-REV_parenb=1 REV_parodd=1 REV_hupcl=1 REV_hup=1 REV_cstopb=1 REV_cread=1
-REV_clocal=1 REV_crtscts=1 REV_ignbrk=1 REV_brkint=1 REV_ignpar=1
-REV_parmrk=1 REV_inpck=1 REV_istrip=1 REV_inlcr=1 REV_igncr=1 REV_icrnl=1
-REV_ixon=1 REV_ixoff=1 REV_tandem=1 REV_iuclc=1 REV_ixany=1 REV_imaxbel=1
-REV_iutf8=1 REV_opost=1 REV_olcuc=1 REV_ocrnl=1 REV_onlcr=1 REV_onocr=1
-REV_onlret=1 REV_ofill=1 REV_ofdel=1 REV_isig=1 REV_icanon=1 REV_iexten=1
-REV_echo=1 REV_echoe=1 REV_crterase=1 REV_echok=1 REV_echonl=1
-REV_noflsh=1 REV_xcase=1 REV_tostop=1 REV_echoprt=1 REV_prterase=1
-REV_echoctl=1 REV_ctlecho=1 REV_echoke=1 REV_crtkill=1 REV_evenp=1
-REV_parity=1 REV_oddp=1 REV_nl=1 REV_cooked=1 REV_raw=1 REV_pass8=1
-REV_litout=1 REV_cbreak=1 REV_decctlq=1 REV_tabs=1 REV_lcase=1 REV_LCASE=1
-
+# Get the reversible settings from stty.c.
+stty_reversible_settings

 saved_state=.saved-state
 stty --save > $saved_state || fail=1
@@ -70,35 +58,11 @@ for opt in $options; do

   # Likewise, 'stty -cread' would fail, so skip that, too.
   test $opt = cread && continue
-  eval rev=\$REV_$opt
-  if test -n "$rev"; then
+  if stty_reversible_matches "$opt" ; then
     stty -$opt || { fail=1; echo -$opt; }
   fi
 done

-if test -n "$RUN_LONG_TESTS"; then
-  # Take them in pairs.
-  for opt1 in $options; do
-    echo .|tr -d '\n'
-    for opt2 in $options; do
-
-      stty $opt1 $opt2 || fail=1
-
-      eval rev1=\$REV_$opt1
-      eval rev2=\$REV_$opt2
-      if test -n "$rev1"; then
-        stty -$opt1 $opt2 || fail=1
-      fi
-      if test -n "$rev2"; then
-        stty $opt1 -$opt2 || fail=1
-      fi
-      if test "$rev1$rev2" = 11; then
-        stty -$opt1 -$opt2 || fail=1
-      fi
-    done
-  done
-fi
-
 stty $(cat $saved_state)

 Exit $fail
diff --git a/tests/misc/stty-pairs b/tests/misc/stty-pairs
new file mode 100755
index 0000000..81ee46b
--- /dev/null
+++ b/tests/misc/stty-pairs
@@ -0,0 +1,63 @@
+#!/bin/sh
+# Make sure stty can parse most of its options - in pairs [expensive].
+
+# Copyright (C) 1998-2012 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../src
+print_ver_ stty
+
+expensive_
+
+# Make sure there's a tty on stdin.
+require_controlling_input_terminal_
+trap '' TTOU # Ignore SIGTTOU
+
+# Get the reversible settings from stty.c.
+stty_reversible_settings
+
+saved_state=.saved-state
+stty --save > $saved_state || fail=1
+stty $(cat $saved_state) || fail=1
+
+# Build a list of all boolean options stty accepts on this system.
+# Don't depend on terminal width.  Put each option on its own line,
+# remove all non-boolean ones, remove 'parenb' and 'cread' explicitly,
+# then remove any leading hyphens.
+sed_del='/^speed/d;/^rows/d;/^columns/d;/ = /d;s/parenb//;s/cread//'
+options=$(stty -a | tr -s ';' '\n' | sed "s/^ //;$sed_del;s/-//g")
+
+# Take them in pairs, with and without the leading '-'.
+for opt1 in $options; do
+  for opt2 in $options; do
+
+    stty $opt1 $opt2 || fail=1
+
+    if stty_reversible_matches "$opt1" ; then
+      stty -$opt1 $opt2 || fail=1
+    fi
+    if stty_reversible_matches "$opt2" ; then
+      stty $opt1 -$opt2 || fail=1
+    fi
+    if stty_reversible_matches "$opt1" \
+    && stty_reversible_matches "$opt2" ; then
+      stty -$opt1 -$opt2 || fail=1
+    fi
+  done
+done
+
+stty $(cat $saved_state)
+
+Exit $fail
-- 
1.7.7





From MAILER-DAEMON Fri Apr 13 13:04:27 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SIjv9-0002fM-Jd
	for mharc-coreutils@gnu.org; Fri, 13 Apr 2012 13:04:27 -0400
Received: from eggs.gnu.org ([208.118.235.92]:39427)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SIjv6-0002en-MA
	for coreutils@gnu.org; Fri, 13 Apr 2012 13:04:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SIjv4-000482-0X
	for coreutils@gnu.org; Fri, 13 Apr 2012 13:04:24 -0400
Received: from mx.meyering.net ([88.168.87.75]:53500)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>)
	id 1SIjux-00046P-NT; Fri, 13 Apr 2012 13:04:16 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id E0F2A60064;
	Fri, 13 Apr 2012 19:04:13 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: bkorb@gnu.org
Subject: Re: [PATCH] fmt: optionalize line width goal
In-Reply-To: <4F7E351A.40909@gnu.org> (Bruce Korb's message of "Thu, 05 Apr
	2012 17:13:14 -0700")
References: <4F68A271.6030101@gnu.org> <4F7E351A.40909@gnu.org>
Date: Fri, 13 Apr 2012 19:04:13 +0200
Message-ID: <87d37bmulu.fsf@rho.meyering.net>
Lines: 330
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Apr 2012 17:04:27 -0000

Bruce Korb wrote:
> NEWS - check
> tests/fmt/g-option - check (I also moved two other fmt tests)
> doc/coreutils.texi - check
> Oh, and src/fmt.c, too.
>
> BSD's implementation allows a goal specification and has a different
> default goal width computation anyway.  This change adds a "-g" option
> and allows the first two numeric operands to represent the goal width
> and actual line width.
>
> * src/fmt.c (main): implement the new option
> (check_for_goals): new function to implement the operands
> Based on BSD's and Plan-9's fmt programs.
> ---
>  NEWS                     |    4 +++
>  THANKS.in                |    3 ++
>  doc/coreutils.texi       |   12 ++++++--
>  src/fmt.c                |   39 ++++++++++++++++++++++++---
>  tests/Makefile.am        |    5 ++-
>  tests/fmt/base           |   64 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/fmt/g-option       |   58 +++++++++++++++++++++++++++++++++++++++++
>  tests/fmt/long-line      |   61 +++++++++++++++++++++++++++++++++++++++++++
>  tests/misc/fmt           |   64 ----------------------------------------------
>  tests/misc/fmt-long-line |   61 -------------------------------------------
>  10 files changed, 236 insertions(+), 135 deletions(-)
>  create mode 100755 tests/fmt/base
>  create mode 100755 tests/fmt/g-option
>  create mode 100755 tests/fmt/long-line
>  delete mode 100755 tests/misc/fmt
>  delete mode 100755 tests/misc/fmt-long-line
>
> diff --git a/NEWS b/NEWS
> index c8d2bbc..0442ca8 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -2,6 +2,10 @@ GNU coreutils NEWS                                    -*- outline -*-
>
>  * Noteworthy changes in release ?.? (????-??-??) [?]
>
> +** New features
> +
> +  fmt now supports the -g option for specifying the "goal" width.
> +
>
>  * Noteworthy changes in release 8.16 (2012-03-26) [stable]
>
> diff --git a/THANKS.in b/THANKS.in
> index d23f7b3..9a525c4 100644
> --- a/THANKS.in
> +++ b/THANKS.in
> @@ -11,6 +11,8 @@ note to the bug-report mailing list (as seen at end of e.g., cp --help).
>  ## is used to generate the THANKS file.  Note that numerous people listed
>  ## here would have been listed as commit authors if we had been using git
>  ## for version control when they contributed.
> +##
> +## Well, not completely true.  It misses sometimes.

Thanks, Bruce.
I had to make a few changes:
  - no need to change THANKS.in;  Your name does appear in the generated THANKS.
      If you find that something doesn't work, please describe the problem.
  - I've cleaned up the commit log
  - renamed new test file from g-option to goal-option
  - fixed a few "make syntax-check" failures
  - adjusted NEWS
  - removed stray touch from a test script

Here's the new version.
I'll wait for an ACK from you before I push it.

>From 0092d5d88bb620885b88aa8b49b079b04066583f Mon Sep 17 00:00:00 2001
From: Bruce Korb <bkorb@gnu.org>
Date: Thu, 5 Apr 2012 17:13:14 -0700
Subject: [PATCH] fmt: accept new --goal=WIDTH (-g) option

Accept -g for BSD/Plan9 compatibility.
* NEWS (New features): Mention it.
* tests/fmt/goal-option: New test.
* tests/fmt/long-line: Rename from tests/fmt-long-line.
* tests/fmt/base: Rename from tests/misc/fmt.
* doc/coreutils.texi: Document it.
* src/fmt.c (main): Accept the new option
(check_for_goals): new function to implement the operands
Based on BSD's and Plan-9's fmt programs.
---
 NEWS                                        |    4 ++
 doc/coreutils.texi                          |   12 ++++--
 src/fmt.c                                   |   32 ++++++++++++---
 tests/Makefile.am                           |    5 ++-
 tests/{misc/fmt => fmt/base}                |    0
 tests/fmt/goal-option                       |   56 +++++++++++++++++++++++++++
 tests/{misc/fmt-long-line => fmt/long-line} |    0
 7 files changed, 99 insertions(+), 10 deletions(-)
 rename tests/{misc/fmt => fmt/base} (100%)
 create mode 100755 tests/fmt/goal-option
 rename tests/{misc/fmt-long-line => fmt/long-line} (100%)

diff --git a/NEWS b/NEWS
index 42df465..ef4e508 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,10 @@ GNU coreutils NEWS                                    -*- outline -*-

 * Noteworthy changes in release ?.? (????-??-??) [?]

+** New features
+
+  fmt now accepts the --goal=WIDTH (-g) option.
+
 ** Changes in behavior

   cp --attributes-only no longer truncates any existing destination file,
diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index 1fbf051..a7e69d1 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -2203,9 +2203,15 @@ fmt invocation
 @opindex -@var{width}
 @opindex -w
 @opindex --width
-Fill output lines up to @var{width} characters (default 75).  @command{fmt}
-initially tries to make lines about 7% shorter than this, to give it
-room to balance line lengths.
+Fill output lines up to @var{width} characters (default 75 or @var{goal}
+plus 10, if @var{goal} is provided).
+
+@itemx -g @var{goal}
+@itemx --goal=@var{goal}
+@opindex -g
+@opindex --goal
+@command{fmt} initially tries to make lines @var{goal} characters wide.
+By default, this is 7% shorter than @var{width}.

 @item -p @var{prefix}
 @itemx --prefix=@var{prefix}
diff --git a/src/fmt.c b/src/fmt.c
index 89d13a6..308b645 100644
--- a/src/fmt.c
+++ b/src/fmt.c
@@ -68,7 +68,7 @@ typedef long int COST;
 #define SQR(n)		((n) * (n))
 #define EQUIV(n)	SQR ((COST) (n))

-/* Cost of a filled line n chars longer or shorter than best_width.  */
+/* Cost of a filled line n chars longer or shorter than goal_width.  */
 #define SHORT_COST(n)	EQUIV ((n) * 10)

 /* Cost of the difference between adjacent filled lines.  */
@@ -201,7 +201,7 @@ static int prefix_lead_space;
 static int prefix_length;

 /* The preferred width of text lines, set to LEEWAY % less than max_width.  */
-static int best_width;
+static int goal_width;

 /* Dynamic variables.  */

@@ -286,6 +286,7 @@ Mandatory arguments to long options are mandatory for short options too.\n\
   -t, --tagged-paragraph    indentation of first line different from second\n\
   -u, --uniform-spacing     one space between words, two after sentences\n\
   -w, --width=WIDTH         maximum line width (default of 75 columns)\n\
+  -g, --goal=WIDTH          goal width (default of 93% of width)\n\
 "), stdout);
       fputs (HELP_OPTION_DESCRIPTION, stdout);
       fputs (VERSION_OPTION_DESCRIPTION, stdout);
@@ -308,6 +309,7 @@ static struct option const long_options[] =
   {"tagged-paragraph", no_argument, NULL, 't'},
   {"uniform-spacing", no_argument, NULL, 'u'},
   {"width", required_argument, NULL, 'w'},
+  {"goal", required_argument, NULL, 'g'},
   {GETOPT_HELP_OPTION_DECL},
   {GETOPT_VERSION_OPTION_DECL},
   {NULL, 0, NULL, 0},
@@ -319,6 +321,7 @@ main (int argc, char **argv)
   int optchar;
   bool ok = true;
   char const *max_width_option = NULL;
+  char const *goal_width_option = NULL;

   initialize_main (&argc, &argv);
   set_program_name (argv[0]);
@@ -344,7 +347,7 @@ main (int argc, char **argv)
       argc--;
     }

-  while ((optchar = getopt_long (argc, argv, "0123456789cstuw:p:",
+  while ((optchar = getopt_long (argc, argv, "0123456789cstuw:p:g:",
                                  long_options, NULL))
          != -1)
     switch (optchar)
@@ -376,6 +379,10 @@ main (int argc, char **argv)
         max_width_option = optarg;
         break;

+      case 'g':
+        goal_width_option = optarg;
+        break;
+
       case 'p':
         set_prefix (optarg);
         break;
@@ -398,7 +405,22 @@ main (int argc, char **argv)
       max_width = tmp;
     }

-  best_width = max_width * (2 * (100 - LEEWAY) + 1) / 200;
+  if (goal_width_option)
+    {
+      /* Limit goal_width to max_width.  */
+      unsigned long int tmp;
+      if (! (xstrtoul (goal_width_option, NULL, 10, &tmp, "") == LONGINT_OK
+             && tmp <= max_width))
+        error (EXIT_FAILURE, 0, _("invalid width: %s"),
+               quote (goal_width_option));
+      goal_width = tmp;
+      if (max_width_option == NULL)
+        max_width = goal_width + 10;
+    }
+  else
+    {
+      goal_width = max_width * (2 * (100 - LEEWAY) + 1) / 200;
+    }

   if (optind == argc)
     fmt (stdin);
@@ -924,7 +946,7 @@ line_cost (WORD *next, int len)

   if (next == word_limit)
     return 0;
-  n = best_width - len;
+  n = goal_width - len;
   cost = SHORT_COST (n);
   if (next->next_break != word_limit)
     {
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 4d73a92..6d4f18e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -140,6 +140,9 @@ TESTS =						\
   chgrp/no-x					\
   chgrp/posix-H					\
   chgrp/recurse					\
+  fmt/base					\
+  fmt/long-line					\
+  fmt/goal-option				\
   misc/env					\
   misc/ptx					\
   misc/test					\
@@ -188,8 +191,6 @@ TESTS =						\
   misc/expr					\
   misc/factor					\
   misc/false-status				\
-  misc/fmt					\
-  misc/fmt-long-line				\
   misc/fold					\
   misc/groups-dash				\
   misc/groups-version				\
diff --git a/tests/misc/fmt b/tests/fmt/base
similarity index 100%
rename from tests/misc/fmt
rename to tests/fmt/base
diff --git a/tests/fmt/goal-option b/tests/fmt/goal-option
new file mode 100755
index 0000000..2efb8c5
--- /dev/null
+++ b/tests/fmt/goal-option
@@ -0,0 +1,56 @@
+#!/bin/sh
+# Exercise the fmt -g option.
+
+# Copyright (C) 2012 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../src
+print_ver_ fmt
+
+cat <<\_EOF_ > base || fail=1
+
+@command{fmt} prefers breaking lines at the end of a sentence, and tries to
+avoid line breaks after the first word of a sentence or before the last word
+of a sentence.  A @dfn{sentence break} is defined as either the end of a
+paragraph or a word ending in any of @samp{.?!}, followed by two spaces or end
+of line, ignoring any intervening parentheses or quotes.  Like @TeX{},
+@command{fmt} reads entire ''paragraphs'' before choosing line breaks; the
+algorithm is a variant of that given by
+Donald E. Knuth and Michael F. Plass
+in ''Breaking Paragraphs Into Lines'',
+@cite{Software---Practice & Experience}
+@b{11}, 11 (November 1981), 1119--1184.
+_EOF_
+
+fmt -g 60 -w 72 base > out || fail=1
+
+cat <<\_EOF_ > exp
+
+@command{fmt} prefers breaking lines at the end of a sentence,
+and tries to avoid line breaks after the first word of a sentence
+or before the last word of a sentence.  A @dfn{sentence break}
+is defined as either the end of a paragraph or a word ending
+in any of @samp{.?!}, followed by two spaces or end of line,
+ignoring any intervening parentheses or quotes.  Like @TeX{},
+@command{fmt} reads entire ''paragraphs'' before choosing line
+breaks; the algorithm is a variant of that given by Donald
+E. Knuth and Michael F. Plass in ''Breaking Paragraphs Into
+Lines'', @cite{Software---Practice & Experience} @b{11}, 11
+(November 1981), 1119--1184.
+_EOF_
+
+compare exp out || fail=1
+
+Exit $fail
diff --git a/tests/misc/fmt-long-line b/tests/fmt/long-line
similarity index 100%
rename from tests/misc/fmt-long-line
rename to tests/fmt/long-line
-- 
1.7.10.130.g36e6c


From MAILER-DAEMON Fri Apr 13 15:48:15 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SImTf-0008J2-PS
	for mharc-coreutils@gnu.org; Fri, 13 Apr 2012 15:48:15 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48241)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SImTc-0008IZ-Tr
	for coreutils@gnu.org; Fri, 13 Apr 2012 15:48:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SImTb-0002go-Cd
	for coreutils@gnu.org; Fri, 13 Apr 2012 15:48:12 -0400
Received: from fencepost.gnu.org ([208.118.235.10]:49733)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SImTb-0002gf-9a
	for coreutils@gnu.org; Fri, 13 Apr 2012 15:48:11 -0400
Received: from adsl-75-2-129-142.dsl.pltn13.sbcglobal.net
	([75.2.129.142]:41155 helo=[192.168.10.2])
	by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <bkorb@gnu.org>)
	id 1SImTa-0003PL-6L; Fri, 13 Apr 2012 15:48:10 -0400
Message-ID: <4F8882F7.90507@gnu.org>
Date: Fri, 13 Apr 2012 12:48:07 -0700
From: Bruce Korb <bkorb@gnu.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH] fmt: optionalize line width goal
References: <4F68A271.6030101@gnu.org> <4F7E351A.40909@gnu.org>
	<87d37bmulu.fsf@rho.meyering.net>
In-Reply-To: <87d37bmulu.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 208.118.235.10
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Apr 2012 19:48:14 -0000

On 04/13/12 10:04, Jim Meyering wrote:
> Thanks, Bruce.

Hi Jim,

You're welcome.

> I had to make a few changes:
>    - no need to change THANKS.in;  Your name does appear in the generated THANKS.
>        If you find that something doesn't work, please describe the problem.

Bizarre.  I built the thing and my name wasn't in the THANKS file.
Thanks for checking it out.

> Here's the new version.
> I'll wait for an ACK from you before I push it.

 From my point of view, there's never a need.  If I have an issue, I'll complain.
I don't have any issue with it.  Thank you!  Cheers - Bruce


From MAILER-DAEMON Sat Apr 14 04:12:17 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SIy5h-00008v-Jn
	for mharc-coreutils@gnu.org; Sat, 14 Apr 2012 04:12:17 -0400
Received: from eggs.gnu.org ([208.118.235.92]:49242)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SIy5f-00008p-Bc
	for coreutils@gnu.org; Sat, 14 Apr 2012 04:12:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SIy5d-0006wm-Pp
	for coreutils@gnu.org; Sat, 14 Apr 2012 04:12:14 -0400
Received: from mx.meyering.net ([88.168.87.75]:55758)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>)
	id 1SIy5a-0006w7-Ow; Sat, 14 Apr 2012 04:12:10 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 8EE826004B;
	Sat, 14 Apr 2012 10:12:08 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bruce Korb <bkorb@gnu.org>
Subject: Re: [PATCH] fmt: optionalize line width goal
In-Reply-To: <4F8882F7.90507@gnu.org> (Bruce Korb's message of "Fri, 13 Apr
	2012 12:48:07 -0700")
References: <4F68A271.6030101@gnu.org> <4F7E351A.40909@gnu.org>
	<87d37bmulu.fsf@rho.meyering.net> <4F8882F7.90507@gnu.org>
Date: Sat, 14 Apr 2012 10:12:08 +0200
Message-ID: <87ty0mlokn.fsf@rho.meyering.net>
Lines: 11
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2012 08:12:16 -0000

Bruce Korb wrote:
>> Here's the new version.
>> I'll wait for an ACK from you before I push it.
>
> From my point of view, there's never a need.  If I have an issue, I'll complain.
> I don't have any issue with it.  Thank you!  Cheers - Bruce

The scenario I hope to avoid is one in which I introduce an error,
which would make it look like it's your error.  And since our policy
makes master non-rewindable, once it's pushed, there's no way to change
an offending commit.


From MAILER-DAEMON Sat Apr 14 04:12:50 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SIy6E-0000CI-OU
	for mharc-coreutils@gnu.org; Sat, 14 Apr 2012 04:12:50 -0400
Received: from eggs.gnu.org ([208.118.235.92]:49334)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SIy6C-0000CB-92
	for coreutils@gnu.org; Sat, 14 Apr 2012 04:12:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SIy6A-00072k-K5
	for coreutils@gnu.org; Sat, 14 Apr 2012 04:12:47 -0400
Received: from mx.meyering.net ([88.168.87.75]:55761)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SIy6A-00072L-9V
	for coreutils@gnu.org; Sat, 14 Apr 2012 04:12:46 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id E5D6B603E4
	for <coreutils@gnu.org>; Sat, 14 Apr 2012 10:12:43 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] doc: remove a little direntry redundancy
Date: Sat, 14 Apr 2012 10:12:43 +0200
Message-ID: <87obqulojo.fsf@rho.meyering.net>
Lines: 27
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2012 08:12:49 -0000

FYI, from Karl:

>From 4c13a6d743b1c77f4bd87d3de890d9128dc206a2 Mon Sep 17 00:00:00 2001
From: Karl Berry <karl@freefriends.org>
Date: Sat, 14 Apr 2012 10:06:32 +0200
Subject: [PATCH] doc: remove a little direntry redundancy

* doc/coreutils.texi (Basics direntry): Remove 3rd "Common options."
---
 doc/coreutils.texi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index a7e69d1..682536a 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -23,7 +23,7 @@
 @dircategory Basics
 @direntry
 * Coreutils: (coreutils).       Core GNU (file, text, shell) utilities.
-* Common options: (coreutils)Common options.      Common options.
+* Common options: (coreutils)Common options.
 * File permissions: (coreutils)File permissions.  Access modes.
 * Date input formats: (coreutils)Date input formats.
 @end direntry
--
1.7.10.130.g36e6c


From MAILER-DAEMON Sat Apr 14 12:59:45 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJ6K9-00015d-P6
	for mharc-coreutils@gnu.org; Sat, 14 Apr 2012 12:59:45 -0400
Received: from eggs.gnu.org ([208.118.235.92]:43925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SJ6JW-00014F-KL
	for coreutils@gnu.org; Sat, 14 Apr 2012 12:59:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SJ6Ir-0005U2-OA
	for coreutils@gnu.org; Sat, 14 Apr 2012 12:59:06 -0400
Received: from fencepost.gnu.org ([208.118.235.10]:39291)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bkorb@gnu.org>) id 1SJ6Ir-0005Tw-Kk
	for coreutils@gnu.org; Sat, 14 Apr 2012 12:58:25 -0400
Received: from adsl-75-2-129-142.dsl.pltn13.sbcglobal.net
	([75.2.129.142]:53729 helo=[192.168.10.2])
	by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <bkorb@gnu.org>)
	id 1SJ6Iq-0007WJ-Ld; Sat, 14 Apr 2012 12:58:24 -0400
Message-ID: <4F89ACAE.5060105@gnu.org>
Date: Sat, 14 Apr 2012 09:58:22 -0700
From: Bruce Korb <bkorb@gnu.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH] fmt: optionalize line width goal
References: <4F68A271.6030101@gnu.org> <4F7E351A.40909@gnu.org>
	<87d37bmulu.fsf@rho.meyering.net> <4F8882F7.90507@gnu.org>
	<87ty0mlokn.fsf@rho.meyering.net>
In-Reply-To: <87ty0mlokn.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 208.118.235.10
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2012 16:59:43 -0000

On 04/14/12 01:12, Jim Meyering wrote:
>
> The scenario I hope to avoid is one in which I introduce an error,
> which would make it look like it's your error.

Ah.  It's an "I've made some changes, so please review for errors" thing.
OK.  "looking like it's my error" isn't an issue, but caution is.  Thanks.

Now a curiosity question:  How did you get git to do this:

  tests/{misc/fmt => fmt/base}                |    0
  tests/fmt/goal-option                       |   56 +++++++++++++++++++++++++++
  tests/{misc/fmt-long-line => fmt/long-line} |    0

When I did it, it showed all lines in tests/misc/fmt deleted and
all lines in tests/fmt/base added, though elsewhere it did say
the file moved.  I did use "git mv" to move it, too.  Not critical,
just bizarre.  :)

Cheers - Bruce


From MAILER-DAEMON Sat Apr 14 13:13:02 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJ6X0-00040X-58
	for mharc-coreutils@gnu.org; Sat, 14 Apr 2012 13:13:02 -0400
Received: from eggs.gnu.org ([208.118.235.92]:37663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJ6Wx-000404-Nr
	for coreutils@gnu.org; Sat, 14 Apr 2012 13:13:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJ6Ww-0001Fn-6B
	for coreutils@gnu.org; Sat, 14 Apr 2012 13:12:59 -0400
Received: from mx.meyering.net ([88.168.87.75]:56983)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>)
	id 1SJ6Wt-0001FU-Kp; Sat, 14 Apr 2012 13:12:55 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 1CA956004B;
	Sat, 14 Apr 2012 19:12:53 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bruce Korb <bkorb@gnu.org>
Subject: Re: [PATCH] fmt: optionalize line width goal
In-Reply-To: <4F89ACAE.5060105@gnu.org> (Bruce Korb's message of "Sat, 14 Apr
	2012 09:58:22 -0700")
References: <4F68A271.6030101@gnu.org> <4F7E351A.40909@gnu.org>
	<87d37bmulu.fsf@rho.meyering.net> <4F8882F7.90507@gnu.org>
	<87ty0mlokn.fsf@rho.meyering.net> <4F89ACAE.5060105@gnu.org>
Date: Sat, 14 Apr 2012 19:12:53 +0200
Message-ID: <873986jkyy.fsf@rho.meyering.net>
Lines: 18
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2012 17:13:01 -0000

Bruce Korb wrote:
...
> Now a curiosity question:  How did you get git to do this:
>
>  tests/{misc/fmt => fmt/base}                |    0
>  tests/fmt/goal-option                       |   56 +++++++++++++++++++++++++++
>  tests/{misc/fmt-long-line => fmt/long-line} |    0

I ran this command:

    git config --global diff.renames true

which put these lines in ~/.gitconfig:

[diff]
        renames = true

diff.renames is documented in git-config(1).


From MAILER-DAEMON Sun Apr 15 15:26:59 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJV6B-0007k5-C3
	for mharc-coreutils@gnu.org; Sun, 15 Apr 2012 15:26:59 -0400
Received: from eggs.gnu.org ([208.118.235.92]:39738)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJV67-0007ja-6A
	for coreutils@gnu.org; Sun, 15 Apr 2012 15:26:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJV63-0008Fr-UA
	for coreutils@gnu.org; Sun, 15 Apr 2012 15:26:54 -0400
Received: from mail-pz0-f52.google.com ([209.85.210.52]:63619)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJV63-0008Fk-EE
	for coreutils@gnu.org; Sun, 15 Apr 2012 15:26:51 -0400
Received: by dake40 with SMTP id e40so5541857dak.39
	for <coreutils@gnu.org>; Sun, 15 Apr 2012 12:26:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:subject
	:content-type; bh=IrsmDtHHm8GGepSSvxQ6wxohDqxGncyBd3Z8Uc0xkeI=;
	b=vaQwzKDrHAUZwugkdLattlzj/GFqopf+ZlSQrjFIpEtlEGZKgEw0MAdiIjqrzwFd4D
	wLEaeQnSAAXY24V+8GLgTliYfdFD8XQtmzTCOE5zL0XUxVh3XmvDyxxcnTCapcgkJJSc
	7QZZ+oNJ4XBZ7nEmrSmlgIjnoYUHmuyBmA3jLPj9tJf6ByvAgVRPz8i80f4jdVYIz4h7
	hZjVdgp/w2Roi9nZ5vjsbENLfeVqeYCKZwTXWXPrgKzdY3YhvSZEl8+k84bhOFNXfO3s
	PBMD9xuzgkt8P58VDak5Iv3mLcHGl7u0WjV9TfOMvwoTy8O4EacXnZM0jDgkAKBpzHnl
	LE9A==
Received: by 10.68.130.40 with SMTP id ob8mr22401471pbb.84.1334518008514;
	Sun, 15 Apr 2012 12:26:48 -0700 (PDT)
Received: from [192.168.10.2] (adsl-75-2-129-142.dsl.pltn13.sbcglobal.net.
	[75.2.129.142])
	by mx.google.com with ESMTPS id q1sm15426930pbp.62.2012.04.15.12.26.46
	(version=TLSv1/SSLv3 cipher=OTHER);
	Sun, 15 Apr 2012 12:26:47 -0700 (PDT)
Message-ID: <4F8B20F5.3000707@gmail.com>
Date: Sun, 15 Apr 2012 12:26:45 -0700
From: Bruce Korb <bruce.korb@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: coreutils@gnu.org
Subject: Another patch, for discussion tho
Content-Type: multipart/mixed; boundary="------------030604050908070504010702"
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.210.52
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Apr 2012 19:26:57 -0000

This is a multi-part message in MIME format.
--------------030604050908070504010702
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Attached are several files, one the patch, another a derived file based on
a file that is part of the patch, and the last is the tool used to derive
the header from the mapping file.

I've had this toy kicking around for a decade or so.  If it were
part of some project, it might be libiberty or maybe gnulib or
maybe coreutils.  Uncertain what to do with it, I've kept it
basically hidden.  The idea is to specify character classes for
a particular program or group of programs and emit the classification
table.  Zack did it for GCC.  There are some ad-hoc methods in the
core utils, including fmt.  I chose fmt as the example because it
was especially trivial and would still demonstrate it.

So it's all attached for your amusement.  Probably needs a better name.

These are the four classes needed by fmt.c:

open        "(['\"" <<<<=== backtick removed, per recent discussions
close       ")]'\""
period      ".?!"
punct       "\x21-\x7E" -"a-zA-Z0-9"

Cheers - Bruce

char-mapper/
char-mapper/cm-opt.c
char-mapper/map-text.c
char-mapper/mk-str2enum.sh
char-mapper/char-mapper.c
char-mapper/map-text.def
char-mapper/mk-opt-table.sh
char-mapper/char-mapper.h
char-mapper/Makefile
char-mapper/test.sh
char-mapper/map-text.h
char-mapper/build-html.sh
char-mapper/cm-opt.h
char-mapper/MakeRules

--------------030604050908070504010702
Content-Type: text/x-patch;
 name="0001-fmt-use-generated-char-classifications.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-fmt-use-generated-char-classifications.patch"

>From 62fd69a3d3a547cc3579484571b2abcb2fcd668a Mon Sep 17 00:00:00 2001
From: Bruce Korb <bkorb@gnu.org>
Date: Sun, 15 Apr 2012 12:08:53 -0700
Subject: [PATCH] fmt: use generated char classifications

* lib/fmt-class.map: file describing the character classes used by fmt.
* lib/fmt.c: use fmt-class.h in preference to roll-your-own
* src/Makefile.am: add rule to derive fmt-class.h from fmt-class.map
---
 .gitignore        |    1 +
 src/.gitignore    |    1 +
 src/Makefile.am   |   45 +++++++++++++++++++++++----------------------
 src/fmt-class.map |   31 +++++++++++++++++++++++++++++++
 src/fmt.c         |   17 +++++------------
 5 files changed, 61 insertions(+), 34 deletions(-)
 create mode 100644 src/fmt-class.map

diff --git a/.gitignore b/.gitignore
index 383361b..f5e35dc 100644
--- a/.gitignore
+++ b/.gitignore
@@ -75,6 +75,7 @@
 /lib/ref-del.sed
 /lib/selinux
 /lib/signal.h
+/lib/spawn.h
 /lib/stamp-h1
 /lib/stdalign.h
 /lib/stdio.h
diff --git a/src/.gitignore b/src/.gitignore
index 9c4c9b7..0e5e47f 100644
--- a/src/.gitignore
+++ b/src/.gitignore
@@ -114,3 +114,4 @@ wheel.h
 who
 whoami
 yes
+fmt-class.h
diff --git a/src/Makefile.am b/src/Makefile.am
index 06ab615..8e59801 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -468,30 +468,27 @@ ginstall_SOURCES = install.c prog-fprintf.c $(copy_sources)
 # This is for the '[' program.  Automake transliterates '[' to '_'.
 __SOURCES = lbracket.c
 
-cp_SOURCES = cp.c $(copy_sources)
-dir_SOURCES = ls.c ls-dir.c
-vdir_SOURCES = ls.c ls-vdir.c
-id_SOURCES = id.c group-list.c
-groups_SOURCES = groups.c group-list.c
-ls_SOURCES = ls.c ls-ls.c
-ln_SOURCES = ln.c relpath.c relpath.h
-chown_SOURCES = chown.c chown-core.c
-chgrp_SOURCES = chgrp.c chown-core.c
-kill_SOURCES = kill.c operand2sig.c
+arch_SOURCES 	= uname.c uname-arch.c
+chgrp_SOURCES 	= chgrp.c chown-core.c
+chown_SOURCES 	= chown.c chown-core.c
+cp_SOURCES 	= cp.c $(copy_sources)
+df_SOURCES 	= df.c find-mount-point.c
+dir_SOURCES 	= ls.c ls-dir.c
+fmt_SOURCES 	= fmt.c fmt-class.h
+groups_SOURCES 	= groups.c group-list.c
+id_SOURCES 	= id.c group-list.c
+kill_SOURCES 	= kill.c operand2sig.c
+ln_SOURCES 	= ln.c relpath.c relpath.h
+ls_SOURCES 	= ls.c ls-ls.c
+mkdir_SOURCES 	= mkdir.c prog-fprintf.c
+mv_SOURCES 	= mv.c remove.c $(copy_sources)
 realpath_SOURCES = realpath.c relpath.c relpath.h
+rm_SOURCES 	= rm.c remove.c
+rmdir_SOURCES 	= rmdir.c prog-fprintf.c
+stat_SOURCES 	= stat.c find-mount-point.c
 timeout_SOURCES = timeout.c operand2sig.c
-
-mv_SOURCES = mv.c remove.c $(copy_sources)
-rm_SOURCES = rm.c remove.c
-
-mkdir_SOURCES = mkdir.c prog-fprintf.c
-rmdir_SOURCES = rmdir.c prog-fprintf.c
-
-df_SOURCES = df.c find-mount-point.c
-stat_SOURCES = stat.c find-mount-point.c
-
-uname_SOURCES = uname.c uname-uname.c
-arch_SOURCES = uname.c uname-arch.c
+uname_SOURCES 	= uname.c uname-uname.c
+vdir_SOURCES 	= ls.c ls-vdir.c
 
 md5sum_CPPFLAGS = -DHASH_ALGO_MD5=1 $(AM_CPPFLAGS)
 sha1sum_SOURCES = md5sum.c
@@ -526,6 +523,10 @@ dircolors.h: dcgen dircolors.hin
 	$(AM_V_at)chmod a-w $@-t
 	$(AM_V_at)mv $@-t $@
 
+BUILT_SOURCES += fmt-class.h
+fmt-class.h : fmt-class.map
+	char-mapper fmt-class.map
+
 wheel_size = 5
 
 BUILT_SOURCES += wheel-size.h
diff --git a/src/fmt-class.map b/src/fmt-class.map
new file mode 100644
index 0000000..2aee676
--- /dev/null
+++ b/src/fmt-class.map
@@ -0,0 +1,31 @@
+
+%guard
+%file           fmt-class.h
+%backup
+
+%comment
+  This file contains the character classifications used by fmt
+  for identifying quoted strings and sentence terminators.
+  The table is static scope, so %guard is empty.
+
+  This is part of GNU fmt -- a simple text formatter.
+  Copyright (C) 1994-2012 Free Software Foundation, Inc.
+
+  This program is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  This program is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+%
+
+open        "(['\""
+close       ")]'\""
+period      ".?!"
+punct       "\x21-\x7E" -"a-zA-Z0-9"
diff --git a/src/fmt.c b/src/fmt.c
index 308b645..e0bbc22 100644
--- a/src/fmt.c
+++ b/src/fmt.c
@@ -113,12 +113,7 @@ typedef long int COST;
 
 #define MAXWORDS	1000
 #define MAXCHARS	5000
-
-/* Extra ctype(3)-style macros.  */
-
-#define isopen(c)	(strchr ("(['`\"", c) != NULL)
-#define isclose(c)	(strchr (")]'\"", c) != NULL)
-#define isperiod(c)	(strchr (".?!", c) != NULL)
+#include "fmt-class.h"
 
 /* Size of a tab stop, for expansion on input and re-introduction on
    output.  */
@@ -773,13 +768,11 @@ check_punctuation (WORD *w)
 {
   char const *start = w->text;
   char const *finish = start + (w->length - 1);
-  unsigned char fin = *finish;
 
-  w->paren = isopen (*start);
-  w->punct = !! ispunct (fin);
-  while (start < finish && isclose (*finish))
-    finish--;
-  w->period = isperiod (*finish);
+  w->paren  = IS_OPEN_CHAR   (*start);
+  w->punct  = IS_PUNCT_CHAR  (*finish);
+  finish    = SPN_CLOSE_BACK (start, start + w->length);
+  w->period = (finish > start) && IS_PERIOD_CHAR (finish[-1]);
 }
 
 /* Flush part of the paragraph to make room.  This function is called on
-- 
1.7.7


--------------030604050908070504010702
Content-Type: text/x-chdr;
 name="fmt-class.h"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="fmt-class.h"

/*
 *  4 bit character mapping generated 04/15/12 12:02:15
 *
 *  This file contains the character classifications used by fmt
 *  for identifying quoted strings and sentence terminators.
 *  The table is static scope, so %guard is empty.
 *
 *  This is part of GNU fmt -- a simple text formatter.
 *  Copyright (C) 1994-2012 Free Software Foundation, Inc.
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation, either version 3 of the License, or
 *  (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
#ifndef FMT_CLASS_H_GUARD
#define FMT_CLASS_H_GUARD 1

#ifdef HAVE_CONFIG_H
# if defined(HAVE_INTTYPES_H)
#   include <inttypes.h>

# elif defined(HAVE_STDINT_H)
#   include <stdint.h>

#   elif !defined(HAVE_UINT8_T)
        typedef unsigned char   uint8_t;
# endif /* HAVE_*INT*_H header */

#else /* not HAVE_CONFIG_H -- */
# include <inttypes.h>
#endif /* HAVE_CONFIG_H */

#if 0 /* mapping specification source (from fmt-class.map) */
// 
// %guard
// %file           fmt-class.h
// %backup
// 
// %comment -- see above
// %
// 
// open        "(['\""
// close       ")]'\""
// period      ".?!"
// punct       "\x21-\x7E" -"a-zA-Z0-9"
//
#endif /* 0 -- mapping spec. source */


typedef uint8_t fmt_class_mask_t;

#define  IS_OPEN_CHAR( _c)     is_fmt_class_char((char)( _c), 0x01)
#define SPN_OPEN_CHARS(_s)    spn_fmt_class_chars((char *)_s, 0x01)
#define BRK_OPEN_CHARS(_s)    brk_fmt_class_chars((char *)_s, 0x01)
#define SPN_OPEN_BACK(s,e)    spn_fmt_class_back((char *)s, (char *)e, 0x01)
#define BRK_OPEN_BACK(s,e)    brk_fmt_class_back((char *)s, (char *)e, 0x01)
#define  IS_CLOSE_CHAR( _c)    is_fmt_class_char((char)( _c), 0x02)
#define SPN_CLOSE_CHARS(_s)   spn_fmt_class_chars((char *)_s, 0x02)
#define BRK_CLOSE_CHARS(_s)   brk_fmt_class_chars((char *)_s, 0x02)
#define SPN_CLOSE_BACK(s,e)   spn_fmt_class_back((char *)s, (char *)e, 0x02)
#define BRK_CLOSE_BACK(s,e)   brk_fmt_class_back((char *)s, (char *)e, 0x02)
#define  IS_PERIOD_CHAR( _c)   is_fmt_class_char((char)( _c), 0x04)
#define SPN_PERIOD_CHARS(_s)  spn_fmt_class_chars((char *)_s, 0x04)
#define BRK_PERIOD_CHARS(_s)  brk_fmt_class_chars((char *)_s, 0x04)
#define SPN_PERIOD_BACK(s,e)  spn_fmt_class_back((char *)s, (char *)e, 0x04)
#define BRK_PERIOD_BACK(s,e)  brk_fmt_class_back((char *)s, (char *)e, 0x04)
#define  IS_PUNCT_CHAR( _c)    is_fmt_class_char((char)( _c), 0x08)
#define SPN_PUNCT_CHARS(_s)   spn_fmt_class_chars((char *)_s, 0x08)
#define BRK_PUNCT_CHARS(_s)   brk_fmt_class_chars((char *)_s, 0x08)
#define SPN_PUNCT_BACK(s,e)   spn_fmt_class_back((char *)s, (char *)e, 0x08)
#define BRK_PUNCT_BACK(s,e)   brk_fmt_class_back((char *)s, (char *)e, 0x08)

static fmt_class_mask_t const fmt_class_table[128] = {
  /*NUL*/ 0x00, /*x01*/ 0x00, /*x02*/ 0x00, /*x03*/ 0x00,
  /*x04*/ 0x00, /*x05*/ 0x00, /*x06*/ 0x00, /*BEL*/ 0x00,
  /* BS*/ 0x00, /* HT*/ 0x00, /* NL*/ 0x00, /* VT*/ 0x00,
  /* FF*/ 0x00, /* CR*/ 0x00, /*x0E*/ 0x00, /*x0F*/ 0x00,
  /*x10*/ 0x00, /*x11*/ 0x00, /*x12*/ 0x00, /*x13*/ 0x00,
  /*x14*/ 0x00, /*x15*/ 0x00, /*x16*/ 0x00, /*x17*/ 0x00,
  /*x18*/ 0x00, /*x19*/ 0x00, /*x1A*/ 0x00, /*ESC*/ 0x00,
  /*x1C*/ 0x00, /*x1D*/ 0x00, /*x1E*/ 0x00, /*x1F*/ 0x00,
  /*   */ 0x00, /* ! */ 0x0C, /* " */ 0x0B, /* # */ 0x08,
  /* $ */ 0x08, /* % */ 0x08, /* & */ 0x08, /* ' */ 0x0B,
  /* ( */ 0x09, /* ) */ 0x0A, /* * */ 0x08, /* + */ 0x08,
  /* , */ 0x08, /* - */ 0x08, /* . */ 0x0C, /* / */ 0x08,
  /* 0 */ 0x00, /* 1 */ 0x00, /* 2 */ 0x00, /* 3 */ 0x00,
  /* 4 */ 0x00, /* 5 */ 0x00, /* 6 */ 0x00, /* 7 */ 0x00,
  /* 8 */ 0x00, /* 9 */ 0x00, /* : */ 0x08, /* ; */ 0x08,
  /* < */ 0x08, /* = */ 0x08, /* > */ 0x08, /* ? */ 0x0C,
  /* @ */ 0x08, /* A */ 0x00, /* B */ 0x00, /* C */ 0x00,
  /* D */ 0x00, /* E */ 0x00, /* F */ 0x00, /* G */ 0x00,
  /* H */ 0x00, /* I */ 0x00, /* J */ 0x00, /* K */ 0x00,
  /* L */ 0x00, /* M */ 0x00, /* N */ 0x00, /* O */ 0x00,
  /* P */ 0x00, /* Q */ 0x00, /* R */ 0x00, /* S */ 0x00,
  /* T */ 0x00, /* U */ 0x00, /* V */ 0x00, /* W */ 0x00,
  /* X */ 0x00, /* Y */ 0x00, /* Z */ 0x00, /* [ */ 0x09,
  /* \ */ 0x08, /* ] */ 0x0A, /* ^ */ 0x08, /* _ */ 0x08,
  /* ` */ 0x08, /* a */ 0x00, /* b */ 0x00, /* c */ 0x00,
  /* d */ 0x00, /* e */ 0x00, /* f */ 0x00, /* g */ 0x00,
  /* h */ 0x00, /* i */ 0x00, /* j */ 0x00, /* k */ 0x00,
  /* l */ 0x00, /* m */ 0x00, /* n */ 0x00, /* o */ 0x00,
  /* p */ 0x00, /* q */ 0x00, /* r */ 0x00, /* s */ 0x00,
  /* t */ 0x00, /* u */ 0x00, /* v */ 0x00, /* w */ 0x00,
  /* x */ 0x00, /* y */ 0x00, /* z */ 0x00, /* { */ 0x08,
  /* | */ 0x08, /* } */ 0x08, /* ~ */ 0x08, /*x7F*/ 0x00
};
static inline int
is_fmt_class_char(char ch, fmt_class_mask_t mask)
{
    unsigned int ix = (unsigned char)ch;
    return ((ix < 128) && ((fmt_class_table[ix] & mask) != 0));
}

static inline char *
spn_fmt_class_chars(char * p, fmt_class_mask_t mask)
{
    while ((*p != '\0') && is_fmt_class_char(*p, mask))  p++;
    return p;
}

static inline char *
brk_fmt_class_chars(char * p, fmt_class_mask_t mask)
{
    while ((*p != '\0') && (! is_fmt_class_char(*p, mask)))  p++;
    return p;
}

static inline char *
spn_fmt_class_back(char * s, char * e, fmt_class_mask_t mask)
{
    if (s == e) e += strlen(e);
    while ((e > s) && is_fmt_class_char(e[-1], mask))  e--;
    return e;
}

static inline char *
brk_fmt_class_back(char * s, char * e, fmt_class_mask_t mask)
{
    if (s == e) e += strlen(e);
    while ((e > s) && (! is_fmt_class_char(e[-1], mask)))  e--;
    return e;
}
#endif /* FMT_CLASS_H_GUARD */

--------------030604050908070504010702
Content-Type: application/x-xz-compressed-tar;
 name="char-mapper.txz"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="char-mapper.txz"

/Td6WFoAAATm1rRGAgAhARYAAAB0L+Wj4Wf/SyxdADGaCEhDEiGgnOJPbJGeuoScH+nj3Huo
Fyqx+bSOt9jUDp0pUiURm2dn988Bx3TUxz1iNPCxtd3i4HGczga4kFIpochv6qWohcSXlNPa
3iB2V5zU6mCSqNtVsTKOKa6LlUeGubqnop4n9jK0ZEUZlFDe4OauO3Nyo8lXtOPznMnhyT4m
f/hWjR94d8Kr5a4TdMhRZhdWzNXtL7xGwkwzYHI6JH5Qwupegbhb/5WDp4nIKCfIvcAYakcW
pzjl91uOYJ9tVa8LDjReQyIQEuvyz5aYXv8esSpvk/8gVe6Wylgv8ke9lvQ0lWvrSnYOT0xv
B+fElNYQw1BqLnN5fZiAqDPobWegbzUfrHS4hB2iiprK6zEW41W3+DdCozG1wEDi2eAfGR0p
psuCV9arvMDCzA4DrfpCAnih46Xblw0k8mblVaSHf6kIf2pa+/IXR6U/r5a8uumXeX/bRAZw
JP44LKMtSda5hChJUlCuiW0OaQ5lIzLT5N6oAogYAQ9awhlCsmEf48ecaIhpoSkpuQQz7E+/
peS+T5jLVeABTTLiKhNxPOHJ5tyZtdKIWzgEuozSo/1Ff/dlv2NbW+wNzc4fv37xFMqQEER1
oOQBnfpc2/zeAi6a3bo1ZTlJTgMdx1bufzME7wh5Z40v7rMljeXSHbks9P92Ubaffr//Bala
Pk6ly5lEumcB8wZn2+iF2pZYFI0TIXffgkMmGRloVmFGgQWG5bnEhW845wkJfgQ/c9bLpD2N
jy3N3MeS/ND1LgSmcC8u3QUAg8SbJw4TemAdgQ4Jvf5c8NczFO2UQYR4eS8tSRW8QBUh10Jx
3Ge62vfwNEMQnkUryqen7wP9nPC0ClEYcP362VGUz8ubmThijv+mdKc6WnNxbuUJB2jxwTFo
fiP9oWDN8RVRbnLLfyXhJQbZg+LMpxcZnl3Ct9/DQE6ewMRPpYMss+RH9NVOqetn+dRfcC/4
W8evtmtXQ86KeExD2RgxEak6kop3xzcO5Ryukhl7ytKB7co1yhmHUnwkZ5yZBGDCyB7hWpOu
x1WNkhcxmKO1v1NEMxwq6lN99bNAwqdbBuciJojmWh4jyCVEYNvryFMu7+apvaiPn38Cixq9
/5Kp7L94w2YcNn3HHg1dPACDat36EfCaDXudMiPRVyghz2cODCKajkq8qa5qZCV7cTdYrIvl
xw1wzmjTiiugajTYMBys9eLdkSFN41xwJLqGAsn6Pr8B8pNVWztcQUn/6elFf3TozaX8yG2X
+RHuM+kiaMuUCWTotb6trBSDsJ0DQ9cTqxdxO5nQwIdMjvLZUXS4TwFnTXuc+52A51O58UzT
pes5pcxpRjArUol3ciE5m3wLc3M8d1l+/kZJSGuFE3w06uJU7K9CJhtfwdl3nnSnT19e0txx
LdDFiTOGcwOQiPfbDYbnsNelGFTUOVjz91jdo8LHfFJKNGCYjgD4EUcYYO9EhYXtwzkJFK9v
ZythKOcJkksScU9a3Nx/TLHPzv59Zkp08E4bzkxRMjTaPsDugerJDlinr6cwynpk0E/poqAj
s4SvUdth0nfuasTlpJD5WQmjvaWBLOIi62mhcrBzYbMHI/oJKb6EzelDAr+bU/I5Nng3PwCV
4+AmKNqc8CjMxVd+U4Zw6hyGGyxTGBPYPS5F1h1TM/XTc/Ofzzo5vXBVshl2S0theuzhs1Ad
+POME2SHXrhNBY0dUEJ+Ve5iEtBv1aYilYyspB8s8kdBV6jAI5OhOn8SDZdWpomwI645KvIk
ozU9v9tGgXZ2hPnoRik25DtYun6Li5HYBQgYPSeNtESab2ke7Mnyjd9OPsG5jwamg9Vmdd/y
76AsI7CzWf4b2WIt7NAc54KqGz4WvaLGQts6THiRaFWL/Xc2nsNTUQaP70yQ0aDrKZnAKmr4
sMRlBwsw1vlYMAdmhT3HzjYKtRiZRqtI3LI1S/L4sluDQeYqEcNoaEVGzNz7+C1jBU2ix4xU
asS/CewrjYgznKqnW4g8PioPCMlfEIFz5URgC+n8DGumiSbQooGHBMrw0s9aj1DRpgPZe2yK
pNWrgLjdeBJ5mNH1pLnz8dzrhRnCF6eWtP026I9T0pxIH1WnvIeFt32ah5KgCmdKQDxY//+/
pQxDTPsy7hrVEbobuGmcJurf1xUzoFydzWMRNsZF6TBnZ1rirncnnhIi2dyvdQp/+SGKK7RA
qPiGVf2qcQaQkPq/S9L62uixKsAsCYgB4VSEeJ/Q6RiMzM70C2E70DV07Ef3YrFMHR2sU0HW
G+lOr1hPv5cHBQ8ZcJqfo+XMZBKb/L05rq9D0ACTwfylWLxXysM9q9PbcxXp8SCTV1RjywNv
5t64YkCMtwesMMjG3pnTYFAsKojY7vMTJPKVNOlaUhBlt8gFtEpfU0y3SkYA3nrnwZCjow0g
t9ccHoXioQh0pbnUIjbySKe9bty65LERxiXMvg5/rLRatlu4TRlwDrjSjtmvBQjP6p1Y7qk8
rJI9vx5eS81BYOTfLAmoqWUAImHr0cCccb9/l2s2bDQ0BdFf+hm/aPOwe2k+caxQvxyatlS6
hFjaB0OodN/C0p3e9Af4NqQ4QWFcwtK3FYe0g/UHyLYQU8LG0uPJRbjXot+P4vJWBjrnyOUD
acuP16/43rnNYMr2Fu6azegLDv8L886GS9Fbkpob31GOdKm/2MXAMLLBiV/iYJfTAkWQvRTR
libPw+9BBWdzXUCDeXFjDNLoVjMC8V5KJwdOKV7urUbEKt3SwZ5z+WD1T7Gs7QUJNyklmmRR
jA/0JiZouVNyrTUv9Yl4a57piaM6uX5/Mb/VYquDKJhKZeiXN9B9/VRkIxguFCH/c9NYEtah
D/PGUbwqQrKWaAONVVl5vLvNruxWz95XCpI13fosuQSWNrWarbZX2Z4QgWGj34cl99aaNzku
82hh/t6hJovRZlSHbIrhqfijGk0MkIPNSpM0BZIVnu/lOXtzT2GY/3i9A9o2oCfoEgqmQwN0
lbdnLfWzHUXY9jmWamOIXuHZqjv0+cHtRkifhiUrJ5KLHrrWb+ZdGvX6CUMM57cm/WJarYmC
1HzE0e4RZKZM83UQ4A6DBreU9GpKty2xFPPAr/uK6SpIx+gYHBS3sCvHdS/tDO0UO7Pg9FT5
PaJfpvUFk6rKmtoib5hUCLqNzfnfNel6jj4viZudPYCWjk018eBPQnetwXylJDIMZF8jo9c3
5Gg/CjG6KpvKcfYKcCu/ip5iqcflPNQFBtC6L+WYBMMGh+y86bLTwhnrO8qpetxPRgLqHkMv
2eCmZuAaqgyzJILmuekhpRmqG0BfxRE2obmoHvw9yS5Km43HO1CK39WZrZua28mGRejWT1Sh
wTFZ0HwtOrdnJ2En0fvIaJAYLNWfNzlqP5FxcWmoC83stJVdKTSkOD5cAJNTxLQrHjZAUAnP
rZsysnnYlia2TJsWCDYulKhZJdjMJu9IlHUfg1stD5k65UFtRHFwn8OLIscltzO6i4YJ0VDf
Ab2ei6FWnJe8WhMujb4KFO71VHprbPfUsn9U7AG45Z+BJHFxzoBlbMZd2JlyuiWtNCgOS73a
H/dqZEQ73pLIA9hE0silgKNXqXfeG3nHWcO8yYE7ch/b/b4LsF4jSyPl+mWyg+mSaG8qaVj8
flo2VjH4oAch1IcK1DkkEHHX6+yI7RKQ8mH+MeEhTEE81dqoBRrYVRos62G2tFQjLY2gIBnu
/DVO1uZOF9FeFiY5EvTzT/2nxUuMXtZoJLdsYrPu8hA7t72cJzUqMk5LZ7k++tflAibcX1R+
Hlcuv1dYsrT9NXpvRxV/A6nNXl08Pmnnvs+p0SZGX/NGwhsRXI1YhpjtqRbjARBBBwskmKyf
+eSBF+hUBmDbs5c2NlfAEQuZyiOBCTG5LhSHxYrS+xRT/L/OOO/TBk5tVDbPoLTVquf5iLXR
D5V3pAFyOO9vHaUdcxQ3NH8k+2rmcOpsuXzA18SRu6L9BII8eoWLo20RntiIGJPO0gzCiEJD
Y0LthvMd8wqDfgY0uANACCvr3xrY9s1jt4yDOOLVIN2qYfFfTAKqWrirusHGxyKhS5poFeP9
FvjHY1Qi629bP+qCUhaGdVV3HVTMV3TNwb3R0/S1H25Y12eNQsLhkleiQev/Ho/SoD83b0DJ
077tOnPEXD1IGa8Ed2v/XEooqncVU3p+hG+vJglGB9+AJepILXnyEjr7GTyzQjBILT/RHhw2
vYGfvBVi/x19lFVuprAbF9uK1WW5Uwy4wUMwl247NJF1hVjQyE+YZcTzWOsQIXMrVSu4YJ0A
vWxjjW4INOC3R5TkuIcqzUgRBybIDCGaVcFCCLMpFREmA/UdTALw++YJzVa4rwRgFLW0kHcd
W45FhCZ8fmlGxx/s9wrfIuTCyMuiE029aRl6pZ54RE26MbJ3C2jsiWu+3Ywca6lW+rnWgJwH
kw251amIXw+6/3j9MOI6zrw4AcI/4L7Ic/iwyKizYTvUF/wEQcowQEgcxGCc9iENgHRbiTgR
C3jSOEornOWdeV9yQ6OoHaxulxp3p+ibPofAgzHLmIxTiHwxZSGuGbZX+Eu9LUIZ1PAzcVtc
bsXowBgg7gdrlwQ9OI+YnQxCW23/TOrQ7BOVO8MRaBUkWUdn1edx+uAVjHlLpCmX9QCLKAXp
h46D/Bile6x8u1kcStFH/tofyXVNFYbwERY6Ab3I7pgVvYbIF/7U9W3zrBtjCRbUsdAMF8Y8
bI/tBXNPr53VzCQtAwz8MXX2kb/BgVTn6QAyGMjBgsRuzVvb4bRLCsNmvTMh97aGvOzPJh5K
+LsXYAN5y+AInVxRGrGhJYZuUJ8ozw4qQgT0iu7+63NbxHLv1UyFnVg95k6m84YEwlZ+4QTe
eg8z73gzST15/TASI7TEJihGrQn/JwcJGBRBCjetvEfVh6U26QVxVT1F3Lps5ojoLL9iGf0y
w8nJhMdiEbhk1cZz0SOI8ZtqeCtpocMtao8S95x7pegsXavvtBl2rP6OY+EzR60hTCIsAxHk
/0i2o6Z1+4E1fbwHCX1PBYZ0ZW0V90agO7xw/BtFXMl9GwwfHaLmRL+h3ZDro2uhFRwtA+BU
Ogv21ewu2R1DuPM8xos11Ovh1BS9Ngp0RHyBoupDWFIQg0QwwJtYglDf7/zf/qko2nbF0pVo
IzFDR9pnHpMo9ukLuS0U/ARVtuxiHh+NETrmFjPu+x7YXDm+X29Y9xG8tuKsYcXy1dZoxA18
xBRcpBmK7Fat5eZ6w5OABGTj4aImZRik414LCaH4SiYgObRRPXmtcWu13Fo1rFOONhxDz+Tr
zYRttlddSt1wJTam/pT+u+HWGFvguzGMy4IqTmBhmMaZ/sR2wu4WTG/L7sUgpLODdn9lX06T
l7W9LNQJtyOF0fOFs4uTq9L1iv7nJXZrUbvUBtKlG9oLBl3TVKnozLiF8qNYA66kkwS73OS5
r5v4V8AMKHCdg8+p87A++IJpZ0nYSBiIOx9iWTPcxH7FhNhcKzFS4+XNDQXJ41EJ/kDNVOIc
6fjxpoNABhcFJTne5ECsDsh1smJouDfhYary2N6jkXmUq0MAcUkC9pRFvOnOn17zTKSbE5Sj
hr+OYaKCkzQZfi4Oc4lS2mZp3pTWnJaNRVklgS3ptx4F6cuL3XIB5kBv7W6c4ZDPVXCfMGrS
wRtRuJVZquhleUrAIrtsuwMSWhGzz8kMcpyavOkVCUVWb0KpGw7KdV3DmBM6/2WSHoFDdwHR
Lo1m/1fwr0FawdKg7bxwLEDCdwFFSz4YvQXvatHQwtmTazwjZwsYr5hfAXGpVI+v3Q2GoBwY
jnVQrr18t5LufooXoXWoHds+ocM6GYIk3T3umTpCcHoI9w73fW/TrFSFAruVGf2J3qBS2RQ1
R7N150SL6s/NNYGQMAjc+tEFa2+fAtB4G39EshEHmCJdAJw4/CSShdp5G7WnG8M4QqiuC89s
TfeFweCofzWaIq/bO3BGNF9yuevUbXdP3QF+Pv0r+Mc5jQ981cqiLZPTHXxU+GBeAoLa0mYv
Gq82XanEsorrXSQ2ilbeb1ELET4bB1+Aub6aiZ3iBjRyJ5kpo5++9cvXVQclXE0dyAPDXXIl
q0CB4l9k5NGuvMECECoxlLB0vAU0U8fB717dFJWnQHJZcH5lAfeRP/doUhUazIilWs3VCAlL
K+0uh4tSPKr9maptG2ZndzqSMqarea+drNJ6CVSIxXQ10QzpW+9/3/xxWyEKYq3aKxwu63LO
Zzf1waZD27ZY/tXQUrNm3rgBeNo3W1eb1doViFX6dk1KDY7vmvClQR+xxfIe/TxXmMrwaMDR
BULZQc59zFPxXFfMiU7ZVal1nvSOw+XVME4+0F2/OR2Xa47L2tdRxobrnDIW2dpkP3QhM4VL
T1Fk8037cU14F/wEvtSsp7n0zbA6vO8mUGD+iEB/ibFdhyUPBxNFTwLxQRV+dqNiP3Uo5nhF
o6KwZx3qWbONOh40KKGRFG42zhyAUkcvMDO4kFL/sUFaC9K4Ixuvzm/LozxMEaLa0LRy0+rE
ZNMyj9QOT7djK50XMavmCcsweehhCUvoaXYr+hjQoYJE8jepgweVYufyUyi4SHPLtjMe9vCK
SXLG6+7qxiWRABES8aYCYqyKlG4a/H5jJb2X/AGGGZf+zbrr3NSanbeTpIwDTv2mxYVgcU/u
4Zi0A8CAbu04j55/li6LfG3DnWIvmVuBJT3iYIyPw4G0jsGcQbQUWG5WxF+9M0i5f7P1FtII
NIKtBkF2KQK37aKwoNRY9qwu44hVt63EHOB6YKHBWhnvpaSE5J2DR4l6bBPC2N2JlJAUrO6/
ACYn8DCr2jAbZKnbGndNYfDLe3v0gER81sTQLhiEfRhxjw8Lr7PDTyvhlvwOMgB97XXp4wP0
yjjzzvHvqqGwddYNqLizstwF/jXK5tD3WVCin+i2BI8Joc6WQGM/33xhSAvrS4vEJEZEpKJR
fd6A1wumEsRQwWn2d5bcvOmhNdtVC6MUsv131+n9Zqlw43zD60dcevXij3TbmuVy6LcMagUO
9JDtZFrTgedu4FVNjOZEc1oeAOU4ji96uOKjApmM0zQsBFtM5UNtEmFdjHzaRrF7tUi36Nec
62gekRygB/AOK2D2jcqCubF6E9IMdaqB/eFtiX8ei/7wTBm5sIxP/bxQ/Fpabe6a/+q2BGDV
E68OHpmia1X4kxXReSsk1I/StFXJ/7hwl8+3DqaGsNjx30y3xZCTZCfPLcxOir49w5C/1B5e
AnMOg0qXVynJtA9ySiRJRtdv3Uu+yJeBvBFWSh0L4GBlCbeVNYbbGtwdHG5w00a+SbTHM2UQ
e6GdBJgi2rzBhXLm0G+cwbY1uzq5KcyHkm5ncPXjYWSxu5femujqta37YnT8zyULbB9tAQIb
CnVISSoEQWHXbfRyDyzPLZjBJMUCrv8GZcbkx2WDeoDVUveEmrVt9mRSk3JOnGuq7x9sWJzr
Pzym9/cl/TLnX0FE+j/28rTD1iqR7Ut2hdLrJkGRmnfatdfMEg7w8YpO32L1VkMbUiIGLu1r
l5ZHSV4KufbMAUAvIQBGgEfmkb7LtTm9K6hOiK0vEWDpCTBq6DPAy038aGQfb0MHteorFxbD
wXxFM04HqpIJHGYbLK7qmIPE0S2f4MY1UQBtAUQkCZfQHZgsIcZZQ/ZmuJQgXfjIfVQkRev3
aDof6glfdF2ppKGEBqNpEByn53tCH/DMD6x0tzfVPnlGYNu4N9fAn/zOMFn+uxF0HvA9RUVI
a+sMVliitjKEbKa3oifhUuuLm9RELcYmMAY4bSqnxA4QViLluUxGuimi19c7BpjWy3hsC/g7
BoGeQ8QiNnUXA2BbSU5zOtzfyC8RTqdDOJx4dWh//xYZVxgNglA0JHLUHZixabq0CmYv8yDn
LxD1l0UQ7SuJgM0wLOJ/v8kiZWYhOGqNilGEVOYC6+K3AAlta+GxfrVvvfM1CBUnE9xgfgGN
06P1uA+q7c0w8JN2M+TJFZvgR72JldWehoIUASfhizIQH+ERnfdbaYJAVW/74y5SaZToa0Hw
DAdcZp6a3U3ydCba/JNCk5VuQyOQKEmBpn2iaYFSsAEZlwMv9twRgSA5htVx8NuQkFVXoGW8
wzpoxeZU0DEZnIoR6ZuX7ei1g9YsLFRHKNLckEeRZW1wj/O8HxSn+egAXfhs4bahtegldQE3
X4VLsDLXttb0IJKjkylYZ/hsVXV6o6W67ATBtCzXOsZOZn1HMj+WdSrcbIPdpshKRNhP753s
Cn9+Fp6BaQWCWf7Oxrzgxb3t1IG/jUkes+ucvetNYSZxsYd9/hrv0Nch8eyYb9hCuubWN3eS
jswA70xXUBF8YPmA3ssHGeCMnkiLX3RP33d0OrzdksAlKo+6yLpBgCgaFmpsrLLuXISRKmGT
qdN4bqIVAJ7redojVBX+aYqpugGDiJS7PsiUEQ9rbv4kh8Ag6pLvPquLEBncxcmeK65yhmWK
zRSFfV2dOR1KzJjHb1JMkbtVX/lSZ5GkgQSsZGfufusgYUybrvTpnNhQuhZD7rqYoy4nouRx
ntjiGVU+6XvYuiUg0BOqV7OX5bO9MQkb4XIUgp09kP6tXZpJc+VDreE+G5H76WLkHIyRIsir
ptZAyIUBm1Yf2IvC7iwPFnw4crrhr8iVkrnc1WdteoXG5XGttgxY+SUW7kapa/8WBZJzJUqL
R3DEtESONsspSYO4Vc4VwqVrS7nLGk2X+Jxx4rmHHaAlN0a1/OQMzpPKuSxTJE98obl4T5+/
YPYQXaUKwg8YB4ERvEyMEQNHEO30Vd8lX4xYj7nj3RfrxsyE/nXhXelzbY8oYNGsrTMWhsfB
93SeCJ1/qASpt8GSHEV8vyBNqR0ZEJqOKh9TRurS9tk656Q+FFWS623t2lL3c+vX7pAMDQGa
JaltaqnVGpFHTyaUImxV+aLeqrf01+H7fcm1AWS3TbJNmi7+Ygl4zbMD+e+VBZSblXCZTxie
leudHJEpABqxf/0EAdv8s4oQgDbogc6OEOerpA5Zwpa+uYHlwZML2e0yQeNj6tARvZtVw40t
0vSDt4b9FOe5swbRiqtVjd+1ckiGwETZuEl+PCwa2rWiHoEJD/+oPJWCeOlPDoyu4tNqwk7f
3Elw43bu7Q8cPlVkbdiRDnIQhV1tDxC9lr02EHgnF+l/fKPR6gD1hSNCAlmB0XIg38vcWYaX
H1J66uEX2YbciXwBvn5JGPGNomwSEA2CxNctk6X75d0UELvjcj6ykhf0xdCefBtidkVewYta
j9Wxc6voHsNwk7ArtmNp3wZzonmUqoXYsr9PyaZXrlOZl7U7AJ0C9eUyQ7+Sv7Qk53z60xnj
Me82dJYmNgtX7iv2Jfo9geyP4xKdav9SUwxTrKza9wWJwIw7giU61Bv/Rm8VbIWsJ9z3D2Q6
0Afa0Q/KSzQUYaqM0QYpJvvjvOlhhF3tXh287d1dHtWnJ2m5XipMLQ+ThkUAn/JSrLEPum3I
Xp0oiDXEyvio5gv8Q8MThK07vv13sfvGUK9MYLgUj4B+GmOypMB97eCDMZks1dm6nKet1b2B
MrTE6E85N5Fp3rw3LJ6ra4iSQO8npoCL96k+kGkaXOEYgoEivr67OJuB0UnusAhYxq6/CdKU
gml5pzcDtdWQJgTEPa9mIKKSyFfPM7z5fnK7Hr9ucBlpQvKCZCo2QcSsrnfVvxrkimtbNliZ
+whZppQJvEwMidjZTfDRiKk9b5FukZSD7dkvQuQVldL6z1Gqdg95Qi8UjP3EGCfBdvlTvCyB
ZCUtlpnKmygpFpDxv+A/CU2UtL9VDu4p5bfnH0pu38ptySGy5YheO+g4KFRkX4Xdl89Tb7FA
/9mtl4XbEid9Z8hB8Gy5mYeBG0iB5RAoEwBy7TsyWZ0xfpUR1O2twH31Dhtqix25jeeq64mL
jHXLV+zv4yjYenQoDp10gfnantWaZuYgVR90XJe8KCNfkAMedv8NANBRnWR4jZNFZ1ZhE35s
9Ta2ImBEg49WDEhh1yYQM79SJLs77DkOrugV7vJoGU5I0afEE6+Acycoco+eSEfYEi6rdUT6
0/xOALyvD8GVfbSR7iknSTIRFY59CyEEyF1EhAvwCn2r5Zg655w+r/BvwZBE6h4vYK953d1n
IS9WeVpi44zC6GUUWeTCQjMdYdQEqNAhp71VOv5bbFgi1X4dHoAXgLJQC/DJP2ABTsp/qDfh
XZN+GTEsKx9qh2Po+SerK0LSnamAd5AakUIzULFs9jjyZ2JUwjn5m54rdJB/wsNFXkDBxWa7
yTn/aA/SZt7gtZFrMx0w4+inoeWFQySZS+VWx2Gy2C2Yulcx4yOirsWoqnpMiPXhgGgfkZZx
8ZpHUDZ8GHlsq8mdhSNzasDSPnqmJwNV1oMw84mJ9nCQ78AeOVG0p8yk/TydWNTo/JAVKcOT
wk6NpbMre4vDUezAGchVoZ3qoiIBe55OIzv/RzGvezJCtzNGlQwH9LD2u9KHS4VtH2LGExqi
KN+KLqaAuqNysdbg7GpNeNk84op7wqmMhJOoTt8h3LX7uQzVF/ra8JIRBWQHuyi9Lb5orkhO
hbCLKr+iU6BbKIHXgh6aYvb/qKG/0sglfGd75rwnP/3LWN1U8YiRwf2/XMDhJmg6sHHyBag2
8DcLiSBrnvMhcK/KegXXmCW5LmgUsd7GnYCx/D/LRO9abFngKRB0DLzGLtMRdJYUIBN9GJ2P
rpTlFUVz0awhgrFlUkBB1kfkWt2rj+yMxQmPqn2SOPN2kCDFtIdvvI0Gayjv4KOnA8maSeGY
0HfRICoG0CjF+OvxthrvpQVrmHkEqX7Ezji+tFwd33MnJQ9yMP/rzYJ487wZZV0FgB/qkm96
qlmUCJKZWvMQW36Z3iQbbRiXxCnww5nGDZ6ZVpGyCFFeYRIY9maKnj9C92GGgaY1GtV1SF/I
ikXQQqUgiKFaI8yXG3qBSJuXiJMB++wQA+zLEGovjUz7ecA3bpBryzWXwl7mf2914WVhAGq5
1KOI3DGLmZkhHRecrcj0kr3EOmokiNf20tvs8d/y+x9hraYgj70+R2GGL1UmlMMH2eqhxSLh
jrboxGzG0+JbLbyswg9nbcpjYaIohO9guGqrTAFLOa1KDN11fOQXsg/gz6U+Ifjw1lSC9Yfx
xHAqm6mKFhxcPnToRdo8nl5xTjtXrbb7zfdSIQP1lYvR7dur98nO4u3wL8bnDigg3u5KiM/g
XYe50+zB5h+Kzk80ZqAldahuEG83A9u+zmCn8lEw2L3NR6cZE7kJvReDYuUnpLFh4jSFg2VU
jJ/2Jtocy8qqBt4YTrQH2ZoOrH0pFEi5NzSev1Y0eqGuolzyQD35E2gIVVTZXWU4qOlReaVh
Pez027W8LidIwP5gpEfo6aG5HDa6orW7DwpGWV+Q0V35oQ/6HaeyZ0hkJO8HLBynwnR/l3Xa
psIGm3e1380E6ADNZOFKC3ABmgj1kEBcdeVaFStDHa/6K/4dm4NetgSz6iq7u64iO58El1O6
v7OpmtdGXI/9Uk/Hq3wF2xyPo04rQGE8xj57PeW++Smw0KvIarbD59psNrJAwpWcl7TRHdy/
pK4iIn7xjPROS3lzjb3ZQ4PvDNiUPxwz2P/VnTdZ90iuTnVU/UWnnO9iMfMA6ePrhkH7Aj9u
7JthzaOG8Y45LAtHFDu1kNdogz4A+JcIv7O+64VxpZe6PI3u7B0897ntHYr3XdljwZT+n3sw
VsjkgQyFJb26MtVA/ipBfDrwjNrpKgmb4ISrE1RtdrO/mip1eDkBPPhAJXRrSySfFWddzfXH
E91ZBhgUssFNcko+aHN4efHzhR3MIiHm3QWpVmTx1apjxjrw0XFuF1V610FlHF7SsUveNjFH
/tUxTV1u0S1EOMHNl8wH9c1NJHYgQ1RoWISPWGkxCR8FRGJvrmBeoqdQ1+RtdaUYzfTH3yh7
sj2x5R9I/S9mwI8bl+Mnpm3FgKajRtvlNflYd/CHwHmuFOV6GUEu0nHBuuxCTzitFkbBMlOq
Dogjky6Hi9Hvla4GGxmvnEBsS3fcyuYPYMwRwre1bKm4XtCrD3StN/MhOjiWw6R5RbIfnx4A
vahDCo8847gjz1bBRR7sM1w/QfDkAeI9PKZpk2U6BPXRUbTMvy82qBDzDICQcZRtdaLAbALv
CJ8Ut2CPX0wXh3106aXrVmGaoqq44ap9ghi+r4PhM5TyqvcBo21cxaLR0KP4jdiWgg0lA1rJ
Mz/6XZx2Z3ugi4AOPDpFqCHuhKcDYHLRSwXKRRYG0ldaBs7Gky+AX2hhrpZIaCDl2J25k1r3
CiPP9Hk/wlEmwUzewhhv9cBnGN3AYmA7pO5/gnbZkSwg5DVcnCBAFxTkz7gCaqWjYsETnQ2t
SEjtkoRNbOiKZEznwCAALUhspFWHbN/dd6dtKX7qWVk3fsXieKSlAwTyR43vIolWWaglQrsS
VJMAtY4eQF3YxAH9b/ecQ5/YU85qkmEv/THEDcmQYP5WVxN16nUL1mF27+XR1FgT7F5hKans
7SoDZs4dRVqDHXiP8BjMGmZ+Nb8VATELxpiS1MOPnTGU9KRBdfjDC9epzdslsEn3YdUaHuoj
UzkWXQY4tysFuQEx6w9I0Gu3WH13zNHlrrniN09SbMriWOvAKZ/i4y3nkU1yBpPFh1XPcZV7
yioEgK8GIsHOcF8HIsrE+3gE5y9rcNTplhtMqxMlQUP6PfEbBrpSYHZbk0H28buVdUm5ngUr
AtNgH3GIvqoa3cLGoTxqYLuy+D4/nFmYmcx2FuxU1eU1EghOoYtH0MqZWPFG/tSlgTg1UnqT
/azf3r4r6fjd+u5ek9Pimt+SW1GNvoEyH55kZUvWPtrdhKQcr4+aKCfLcVW+eGWPlqQBkMj8
vT8CvFVpNXK6fhnAGakBXy71o+E0KcYj1/gOoGN0drDHvIiMTuYSmAhfLA3kmEEe/J4Do521
t/CEYR7iDh2zmQ179RhEc8L6ZxZLU2dM1DYU26auuODkW1F7O5SKTXZUeu3k0tvlpja1I/K5
gjEWIsAGD5Wdxk6/DKWDKXOAIoNASkJF5AKqe1680yK4DBYZj9j86yJZKKnxXQDHfd4QswUh
wz3S9nb5Y8deQkrYbW6rreVvh9kfkDMPmprLk8XkNpqzDQ/KU1TRSIPOyODpnA6cYIjXuolD
Pkau7A8dsgtTKmb9KuQFOshyxf69iw5LsOStkxmFIPdHaRdwBa10uLSgMwhs+ZGF96Q/c3VC
Oji7sElO3n15vpby9J44dmebmNcpZtRlYO0reTc+/fJZ7zSFc0yFX+NKjV36WHoycHt9MYZk
lVl6e6sOD6AG2jU36f/3A/JiJkUrx6MGPOgJD1Sb4hso4uFWN1cCedQzaZng76bN1ZF5nlat
zA+Lq6/CD650X0iNRb19ZCrO+j60MdgoqSMtuQoJ1PG6XxJQ5XfzdZ3JPPX5jn9TmMVj/qTZ
FRIVN0gp3WsgSgJK2xZ8F2je51e5CUJxipyP0WSQtyCzuR51Ie8n7lIOeOxWj0r36Iegg6lP
dpuDECMSkff7tym1f3MKXh2jt87FMafNghJvgJz+9Ym9rWNrtN4nUcuzTPQLvpQih6mMkkG7
b2idl9iJDt8v9dYSaKupq0BFUwhZieHoNIT1xhrqreCXYActIBuUj4btyhOz5lK9ML6cvbUS
g0tq5qnba6LwU2LoNb/lSsji5smwEwr0dU/a5dqh+kA6Vtl+u/z8JTvPFtsyvmfiZchDdFv9
1KmztSnj6+ESEex5OzjevHtbs0YkaLI3hoBVxZ/YCHgV9zBWqc2VopL3t+E6WnGSMnq7zDZJ
4sJrGrleYb5LithO7pgFyItpS5opDzaJooG7abCiUPoBNIYfZCafAOZA6wbFgaYy/ZqWEAqN
sESoffnj3DjFVs2RcsBseAHY1lzoE5VLLc/MozxWlNiypPe+4gyK/bhnUnP8mRp+AaWhhuZR
70toQkBaDD/KIbjr3+gqQe8Z42SvFAc+JcxJmIzAYwVU4X9Bd5VFQ1ClZOmqSg2trHWQAyEf
WAEW2/8aXIdonC5hXBPojPtGDxbgMvCQ5L440xgYqUXKOzgIgvEu4/EdseZ2MQTIL+NXiPbc
0169aixx7tMVrwXIGJ9oVS1Lf9pwJwzle9LLiR+5FIJ11tiZ68jvSrVYfvTcOn7uGOS94Dfb
YW9w7l3cjRG2ONSCZR35mKmjKJiJJ0scsJms84GUz0VkxDAu99dDOGQMqkYEDV/F78S0WrWJ
XTZ1qiNM8z88SJt65qrZJEW5tlQyt6WioE/K9jXHKKPc0Nj9kWP3Y45bI/y6pTwlc9WJtlqi
pKL5fcRFKa9uRUfpymADYYvQ/PL77WZXP9DfDX0r4UNeJYZ//NSqTI0LGTDjy9AKAlSaDNi0
YpECK1XKFnVvFTgxoy3utJYjNWQmme1hTFf/v6GtfSbrRr0RUok2i8f9Gv9DfN9WUaLNtxVi
8QUOwWStNsavlYF4usylR4B+niv+OOA18RqXTVq8R67qo+lZa92BqDWNpfVG7Mv9riKJZrL1
JIN6826/Q6jK/kNZAOZEjrrcoV9iOnLDtC/xBOKUxkqD5qD3a0I/QRwZh6ugC4VFM+k6IQtn
w+gg98GjiUZsChNiHGapVOUrl1gSwCIomwj/qStyFurudfVXkTp77yBJPfQR4AzkmDZNr9TS
5GshJHZ1pLZdC6+3QUjq+xHXiEJJ5MGAWGVVJflLd31ICS2igrb2nx3vMxhG6yceuIUdD+cC
MivX6X5MxpIM9/qqp32vVaPdKOjOqxq/RZLNpmAzLVoj8xdZzBMuFHqIAqkD4si7AaQ/zrpL
8st7AgsV0mfQUeREWU5gXuITLJL0db7icA8CdaUAX4fdoa2b5QfBKCLMOcJDFhIUztGxCccc
aWEknr5Cnjaus7xL9weNX+/daBs9X3TTUCy3+fnPfWcySlAwTH6f8jA4VrcHhz55onxi0zzl
wTELv6wPN/Urh8aEdF1iev5Irql3Uac+BTpkV8/kmyzVlo5ozzh0CcBTFSnYtguiqxRQMZTC
YYf8TvfMRkCTiD9bC65jVKFpW4FMS2BA/4ewZNuJCIjWiCiQQyJBzDv54gF9yAdjWcBNn+Jq
bvkY1EAySfta5tTkjHx1HLxI1Befn2kNUsvdN76eVQtncoDBs8XkZ8SHWYsdJnX5NHzlhTGV
TtANvyd28kgre899yCg7/01afAI+4qQFrPrt3Z1YDoPc56hkKwfJBQ4uLOuEpQF+5iyTpdKe
99YmTFPgUncFj5hjMDPhYv7cqmiHqaElWoOHGiOGfplcPU1TqmWBdHpNoa2WTun94sDnbPky
BSE9a37TJirIOkvD//GwAD0yuX1vl1/m3tGLpdjCNiPwNzEvV//DEsQ19uUd+q/dzrRpvFQS
2T8WzLRrp7mhxytB0IeN1ccU2TGlW1rGZhYdnqZD6osk8hzEW8LenInarGFRYwGXpnTxdvie
phMnonQoigww45T+ao/Kvae0iKhY1Zn8yOfXmIqB7V98bYX/Slp/YU9c3xOBlY8WCgR8gaA3
2F5bvKIko+bMPi3hduvFJ5LsXedWpK9Bq5RstWdTkETe6XOrUaIvasg38/AArJ3+sU6InF4F
fFhz8sfKwtkAIqQwPGPTVaufTMCK5n/fBHhxCKGxsJqFeO8bv2XnmjSICwrofOD/hysN+paJ
UpOhpduAqFjLRK31573fIuHKgqhbgO+q4VZm5OiXeDaUjQoeTrYX5wJfK3qJSXC9MIxmtozt
6dK/+5GkY1dm3aHZc8nIsBY2RTBN15ON1DOPnXt2ho003sOQs5jLYt/kLnON7HK9UTjvrxBv
+Bk98PkCnM7l0qzCzYo9gpi+5QEqTXx2OiC5R5UOLKBhSyWpxXzge0BP/VvlgDo+MwbWmCON
aRlEDBG1yostQ/rWXQTSyVhn6+kCYy+smeZJLiozcYYvEeXSawn5elWAz9OZWu3orT6N+jHs
2HSs3CedkWq4tKyjiuZJcTGXHaGefUcIRYvErFKV/VLenz4nrnD4Eg/YmSp19NGPgqgeV2mT
jwrUOPp6gRP7p7BgO2hHhbkbZPZBDiVxmd3x9GAVBw5y9ChMPnkikrHR1EWwURnS1k6SSWSp
Vq6/WK5OHcJB2LCH8Pquj7DsttDVstumB0lEKyFnV3cdaQ3PmYz3L7YIQ95G7Z3F/DLc4Frn
kjtr5FdNkLxmcfF4IGDOEsMu79/7HzxnOsZeZKJTMZYXDaZhCIHvYtJ7kV9dHLsoHQtCnAu2
lI+429FVztoMYm11YZUY11bzd8AdN68yGZFAA+l3LnG0dfEUuWZ5VaGVY51so4T8sE4qQQaG
e6i7Or7dozpc+XSOict5+3Bh1DMS3j22wLA9fMbl+ssD48nD+pAWMRfpgFohrVjqVzgbgipy
qiGHeluXfB/5JDIrZoSaaGP/DQWjJ8yHIAPYLN+m6xomUH/7wumWl1ALMrZgaGcgkQHM/k4g
wOulIDm+nIfmXzCtJaz7LuyTCfVNeGpU6lKJK9hQl4evL4g29UObpm10WbHL2n5hLuHuryYR
L7o6HZM3QejcT+VfS/C6JG3NAuv+/+Ra9eV3vT22okoZA/4aZESyDx04zuQVHSNYUUtjEJQq
pZOxASzxcKQHzDWP/Z94xU/BHf8v5LIhWy4V/XS8wY7lS5KAuT8E3ZYd2+/G0op8Oz+SLQNI
GeyYiu600BOcBFOW35F02DRsto4Wq6+Gd1vQ3olVaqg5J+esRhJQXFhncjKYdXwy780ypXc6
uM8G/sQYjfGlqI6UDdguslla2JCMUIT13/7BtZd2qKVmd24bJBbk8x5fQZp297k8hezJU4Qc
DitN67IMXkASkkhk520zBjbd6rUx+d6dLwdHiLUa8kPoI6gQK38KdoILgH/E/P21Y1MQTnXf
xj9tqZpzBToM/9w6RfwL+iCZPBuj9hez7QwdDTMgbgFd3kVZ5S0XP7N2fUXVgx/dByf8AaoG
fEtM5VLv1OI1sIKEA9LZBr5ANIWlJXMHfpFhmPtw7qtoKiY8Sj9NiwbEOjlTGI2cRihPDmb9
RlC7T0ujhMIVzyS3iz4fsxYOxOrgVRc+xQNpEr9WrUS3xoWBQYEgHJkflSzcIOjWg1QdmD+R
wD3Zt57qok694VVKWlwuqDWg/g98mrM2fbv7UWAxs4ez2tNSoUrb7rzpYEUACgJZ0w0ywu9V
Pgkr9xwd0INM4jldYUTGuUiDWI6Z1xurVFoCYtaAePerENf+EfliS+e0omDKrd/zwyzlvvNP
bnQ2sorzatGoTW9EHp/3xZLPl14O5Ic65A12igWaGKN3+r7V8C9n47/LyMOtb0hc0dJdNX7h
bc8i6ZRcRjNZKNDagxFKrd4IleISfqA1zo3fOQKN+JH2K52WDk6FIJM2cbkvUZ1vN1m5GBxF
y839LeYOFjclysAZ+k8ntA3Q0JxX+sNpat2wJT8ktN/I83BdRh3n1xEMDTiPX1xXDI3BgDY5
4eEfb03PDqBi/cJvbgfFcbdTnlmGis6jmw0Ax8b9WACERYCIhA7R1yzhIwA2TMJZz+24s+u9
SLmqXxEt8kyGIAwHmY8iJBJ8lhw0ramt140viEK2rsXB4iuj0UDQwprVkETUYwsz+IfVuAQi
UqN6WNXEDxa+DZw+IolyZjiL1yXcnbZ4hnWYrcXAQfZP1BnrRxobms0SkQU4G7mXkkjA4Hn3
TXqFmDDZKKQ7R1iXnWDCbMCr4q8cFXY7nbmhGNtQf7HfmGvoAUXyVnvHYU1NJ9/95fPGKnD3
NieEXxlmQh3cPehrwxGGJKORXtPgargGUpNZTxdNE7EqqkcUJvqySv9XfblR0BRtGZdINvbm
/Bm7FBYanMAd6VCfs6/NTp5udIGrM69gVJpfZhJEFlokgFu+nxf4gpGR4GwlEeLLcYUsHzMl
NXBKaZBV3Ekaq6uNOgjyykfLg+bE1V7U5EbBoM3gOBGdHq9yYh7Y2zewHlFnpwnBW7G4d9nt
uDrqngVWLGQoqlzb9ksUKUSZ7QRJCKN60pTbVPKrMhAyMMWdURF08MESPgUFN0FZ82Hg2KY2
vxEi3qqG4BphHT0QvnXZRsg9ypFdCeiKiH1F8vJwuKl8UztWF8MRpCl3Pn9yrgNOesy93BXc
RGEVtCIgfKPJd8RzYRPTm83IvxJelS0+9MhBbIYz2X6G+9M/HHshQrOPN/rTDKAn1zh7Hc30
GuhrKzE6Gp9QRBTH8NU1LzSX+Sv5bYyDW5J7iuPhDWzAfN+IXoxBD7b5MniaGGIlofFSDnoP
heXQ72FfdUS9n1ugGUl7gfqEQazZqjdKE1868aPidxs6l8mX6uiFk+D+rIh6axPc4bRH5aij
mPT0r30GxDJuWjUIs57AaYqFOSFC5rkqUWYcyP8BHYqSl1Q0XsfAX9beQTH40yTMdWpywFMY
S/VqW3PaiuCZXjgVvqJcSMiaPf5WBImNUjKm765s0V2Lu8jzO6a7y6KZClA2aPVyHzQDzpEA
LnOkBPq092vNxV+RSogZd+RH8of1yxko7P4hP9EjOXfNCaLi5r+B77yd6I/NhY+TEkCZJdif
Vl2DEbr1SkfwkqJ/mWVGNvEDepUvgyZ0EFccPS6+ZOds2kCzosDcVDI0qiLtFL+LfoSL299z
fzMNMHCVPFlHhb/PN7jYMQ2Awx9SnXYIYKHcsdhlVqlMdkgE2qFnYsWlIK0+B8Ii8sCEp1oF
/GAfbHiTqsCFvj4D6UyEgPeTM01byQ4FWh8Z3bPw7/RD9MNjWXnhTPTk0rHTMRaZJd5KqpzL
Oz5krUsa/gD5JCzGz/Op88KAW/h3WyJ+GCM+hRW5Yb3r1YZMnFVq/MnRLHjHQgc8i1Q1s2P8
2j4TywnrvOZ7+c//XjKKlEHJatu9nISQrw7QkBxaBM7HQerk3plxVbUZmYsSEMiE+TjYqncm
mN157rLFH5O1D8QaB7c2F7hxG9Rvg4Sm5968ntwtIrTr9HewlbayzIxl8TkQFEft6lvdQDH7
OXA1gIFQSjVAwyQBWnOniCKPasCW4JHmX5LZ0yw3IU6Fu198prBgIJyUPOfaTnovR0yCbmI0
mLXEWyBWwS9DZHAvRDSYYnBj+Vi3JRab/P8o0fsMqp/+3vbLqCeBicZkGJxLO9hRuRFxhjZD
aBVj6gYNDiHuY7kpPNhPpSWSaNoiGENFhRjDS0WImUdiwZRNzfQ18G+jQTtDNMimF4DfsojG
uj/ZJiGeMSadFHQha/bjqXDZVtpe9AVGWrNVJ9oyUGod3Skunx1VKel0ndsC4FRd+DhGVspP
ieU75kWqQt7Us+FJzNiJyp2c6W57Ea4bpjAgwwnSWcoJi4DNmviPCQHJts5Qy0n0UDQEQRDa
AcRdza7cDS9i0EhGvnGZeOiveh2UGWHOQZnnKJzN2lm69utvFJg64RjS7/L3vBBuuMXkMSKg
3u7her316zGceYILJ5UIkDqngQgQmohcwnzWhPi9Oar9H5fEYn6UZM+58Z3NophVpxKLNvkC
r+YsEErGBn0GPZefn12ApXhyT0+i98rj4FuSWol6XqZtQlV4xfDracUxaV/xNa7vuMm6pHpa
FW/Lhj/dvr3rQ1Ugc2VYFiEnebKRJ3N/GS9jzxSjtYnyusqW/K5HPXls6iUJX2JwxnM0vYD8
aAB/i7R536qizYV2A9DNL6qIfrjUmjV49iwha9xnXF6ZN9mB1Bmrdnvrs1+1cG7qmokyl+oA
Ickivmd35wOkrcDtWN+RA0K29FwR75IbVmNLFmyMFL33AgscRwXPvjIhxKUrnr+OiMqvbiwM
vhNXo3ac6TxXVPUoKRF5KuahkCwdaMCvOwYm6mSXdMu9yesjNhzszS/K9p8IVa/Q1l16jUir
F4cqgc/CGkhuW6UtwY/ahOiZQ2Wfh+bDbNBi/lB9LVoAkp6pxVYCvj0i9aSiDmhjvd6XCD4y
sjUxpKu3sSziidajVSP9e8gN+5rZjCXYuAM0zLtL6b2W0rj8M9O4wcuADP6uy7XAMGF28M/x
aoXS3xGwUXOK4sWPVQVHVLgmDR49cuzpwYxkTOJX+ttaPmCgz8DAca+hYYCqc/MTNEw7N19P
11I5JATBj2aEi7h4SnySPgnAzubNSeZsJEgQNxueTp6Hew2P+jo+3H/IMgcWkFLEA3+9boyx
Fz6Ixrb/vjMc7pjDsQapASaeIkP/oM4oCVRc8o4vgaj4K4l/F5qyxL00nryA4VKEAwhIZ9LV
dEvRQoD0/dTN9YZLBZ/G+LupKNzXr+8R/2fSgN7B2R428RyG3ygTyHCdWy5MGwtlTUeyFIFi
ZZxBoXFL+/Bd5IorlkrmBd/h8sJsx1cVxr/zHUsy0SIKAeZqAqEcwrcwvkRBhhO3GtuValhc
TQXT90lsnHNI8cNzC/J8RBcR/GMDj/GMNHPWVU+9s7zHyR5fEqYkElCxzRo9Yg/EUW1P/Bs7
kJXseb3Be27G71gAA6flOi863xfGlATdZtMactbAl63eV9XY4/K64+s6ztVK9O0NA19tuGEJ
QDwS4jKr2afVfkivddW8dkfpkhHUS0XnUcQJnKdeedYUcPAkbYIaKM93L99h5wNDihaUCX7g
zrQL5+Ehf4XVqa8e7Rw/3iD9FseBYIOJD1mvZZbmm6zHfQHmGEKpNnUtCfyArnbydtmtBW7/
uCmUptP0Bjyw4pJinW7lT5CgqP3wt+NuiT8xRuw7UJocGDAc08ApUf8JiS6+RkE0Utx9Eiih
kSRwOrCG8HgmA6PBR4DA9wIQMPKFfBih5zLssXuJwvNdKcmkTdNxubpjHCz2k+eGYNeaFZlf
a7FsZkAXuMvpnlufOtZPsCX+k9U9B5T5HaXzJ4HKv8ntvC2EFYrLLx9DC4WpAe+V87s+Xi/r
uQ8i/psQz/IAxS7sQJMTA4S6zXdHkxNZkqTeNJVCM2Rl9c+FjAJF7Jj2ED68KiC3DenSNr6M
QEAjUMQm1bUDa49ZklTDR2cU6WLAelUrNqmTHCW1ZWcZFx5+Vjdi/ZayfkhujE9KM6DEXr5G
AZnWx+UwT9Mkn1SXALK1RDhyLabfAdpRZoEWZZMa8Ynb9xZAvT0hN5ZgBRvOXVf6jS2qr0yN
gW5tJ2eDHGan5Lq7hhxT9MY68z8+So3b8i32+6i0AXMsW6+v3qcHbnNQQRMgzOrhhP9zDY7C
JgM4GQhgyNnYN8T5en2LBXXHbWvvHX6ksYs80zl0Id+E1+n6xj8z80IzyrZWeoL8uocB92RT
7WcvndMs8CB7dVm75PvFUp/i7Yj9idkiGkSjPAhiVGxgv6IUS+h9kAjjKtjkkMgZHwsyrU8m
Z7Jc7exAKyv8mniOjpVu2xOlLvig1VAliYl45zhfOIQg0uePyl5pU/mTBK/MrY7Rc88u2P7C
5MtFp0BHIloJh+nt6r7cnarNl6xiFcWv/P4TWirouCeQNac6OdeSDSNO6YjK/mc0CgAEoBd8
DhaB5lrGygwUFlQZxLU2xKV0HfLj0YwCBqCPIY4isv+XU1kLexIUK4NKC2d27rNQBfho1zLj
/LXV1jgmax7rV6VZI+U9r13q+lUyfi5sx/OwJe1+RGw7509bT7Wyhwq7ZLB6Vus/mxex5gc+
QMAjK5WheRfuuKrOJ68WwU0NA5H0C3YOTvwPB5D/Gyv8x5g55/c0bbvgQaE5aN+CJgS6BMEb
42SboRNurcvlXMxyWNIXMeSn5Du7BSC59i6GGfUoyTPo0BvKueVrepB8SdmtwCYk+tHMq9bz
KxAMARlu4S6hsal+lAq4goBV5LW1ikPoo2MPcCRbVF8d9R9Sap/snsjgeTthNlGNvmKrpLTe
S78zQ/o0ow/ItfF0/Z7VaaLL0VxCHyS47vjOpz/LoQEgm7gFVCb/fomEtm7rxnl1td8P8YpF
3khQuP/tbxomKGfCzsltpXJjVUGgvx+/Wm0GfJWjN4kQY3oExXNvQ/yXhacM8iTlnEZKunk0
ze64RKmUy42JWyWActRg7czxhOKsJk5/UmtQJIO6pdY17Fd5AqQpC1CGxP9dZ42YAEYC2vrg
/S0+ObHpAcRXaS/YYfng186gmTlHmEKojoRPq3xytwRu3e21xLwzjgj0VPpsSra6/K58sDKp
ZSLp2TL6UVL1+Pqo3iQ64kGjj2oNQdK63lNMNfQZ8zMQ7AIf0flufM6Wi8VxJHsGEqkNIJSX
NXXVTcW7XoiyykR1+Zn3JYOhkTtFIzZVyMTtGM3iaJBBwN2GvlnU5S5OU23zCFLTbI7l0V4t
KUaHhKpyZZ1rsF1UfxaiP4ZntZGfdkiPQ+HxZ8uj1zhOhPuImjOfYF5cDVvFSttq5+JrxmqP
xI0l+mVuqrS2bbZVngBktPjaWquQ8wTnyn8z09pG1atPDM6PQqZ9GTcEtPoQ9V/47knbp1e7
ardtbB1tntWcNLiX9Ls4vmf2LP9wg0KFawDLgymmTTDVOd/fIhET5qoFrnlv9B4XMFa3TyJU
Q2sjDAnT/1UJ1kqG9DVa1WTawP5GS9PR2+lonu/LrjOi4EyVizeLD8yJPsWzdGybOh3BWe7I
F4N0mu0gmCp5aZccb/HjfE+htv+2TlxB1qkR7E7FDF6U4Y3c+/ULmV6ooY4mj66N61BbpF9v
Qs+V4S6pwL2nms9+LtCRFP/FkGi3dWBNPGIdcT/VgmpoNlHo7eU/ZfQuBrJqGlH5ueM7Ccha
NTbkwwHqpuH2LhphqWF/WtX70r4L9MmRgqlkupe0Xjx3mRtQ+6RfAaZn7TythtLkeXFpsY2P
kuHNkB3wO2udBVG4Xg4fgBUTJvuA/GjnjZdJOXcGxxz7l8Plj4/3ub53DEBfLVHaEZBONxIa
J+VVGe9VBgeztYPPkNAEb7O14YAqNvR9T4Ye1U5D+9SFpvFTCYOpg2krK4rJr4bXm5E6e1t7
kXKXOfu/0kWpma3+QbjijtlhyXwLvzM2se6ue/N6+bri07RrAh/tVh1YZohwFHxUEi/4C/uX
r/jGrnQUDx13/Hon5szCAGfpQQ7L5sJH3qZGB8BQMPW6+KA7d3b4cWnUigtQ70E8FDQzPNeT
FNzAiBflq7Q9nSaEhaWgDTzYX9G6lRAYYyPRelTxbB6EWTl2/ywoEln2/QjIXIRtpQMpvstc
khVaOJjV4SD449deAbSEp9HWXipDyXzJYhDlpxQRXWnJdTYp6bVqRatYxd+s4/xfxzDdBG72
cHxbMWrk9WP4H1aQGrG9MRSzwtJbFRKjhbYdPOurNkrJQxQGu4JP1sUBcu3lvCPbFYPLhw0u
huk+4KueGCp6WySL3/JQUPBpf7VVSVghIkipmfydjht/7m5zvUi7q7u0Cnsj0P1IDMTT1xIw
1AWuOJ2IxQ9IKM7tZd4ugnlSO9i319JuRBON1tajJOtXuvzq1r4rv4oIp61NKltuDVIHBxl8
QV27PSh9dnVXqXzShpHPF03tsj0IYifmy8+bq46cYRXHlQEfLwWdbxlKne/njbRef/6fLr5e
sPqNse1kM8b1RLvnVdjERJl7AP7MXmGR572sCLdB7ICnWmxkk3q8TfE8Mg/1neTC59UPd4xU
u8rvuSEoQiHUkmB0SlRqiZSF8av5pow18N+3itLUZddZE4/ZnK//nksdhyn9Llj51cQ7XZTi
R1XcHAog5I4wZActwdiZngdNanUWrz9uZGGFY0MOlK31EJGiJo6kQAUrkUXgBlzD7LochlSI
DVuXAEmF3i8d+xrg/siDG+oqaVTAWwiNecRs7pLzyqXinc+iazSfBwVT6+/ILaCU264pNEBS
V1irCJW6Ek5r4mlXejyG0b12l932rKEmtbww75dnskE1QRc40J5+muEVkMEAZ8gUQIGsnKoR
6PUZu2/QC5OWR+Vs6i9lnQaXlGBQx946E0cz4EJw0TZh9YlJKYvJMnivO6VSjEDvAgtkoAWY
K8/rVOTmnwU8t/RB/yhLX/CMmEi7bs5XQloJBv2X6i1bT5ikDGaLFg76iB/03A2FY5EPMBxN
50d26ILVbuaLCTIg3X6ROB/oWxCtj+WzpyY8Iqfpd4PwwDSiSfJ/8dY7tndSbuRGvF3pL9Nb
Mukd4bhhByNfthnvDJCzMwGxDJqWuO7X2dYGYsW+Jhe8xr7mGwQgUvtDOJ0k5XtXX3P/FUc3
mnAhSMvR7QSKpbf7qqx0Vv65OHV4mYK80dUEYDprUnZMQWbrFbsoetgS5rYGcBDBQqDa0i7h
H63irVR7dztzH2mc8iraQ4pUy/MudJFDcF43kbVTnFjXNyADBKQgwyY5NpuZ6MPRTodAmEaA
DifZ47nEw21MlGjBHI0nbkDd8MfDVKhYMSvAaduqiECgdWHLBTefvt7bGjrGFB4Q2V4NIJkS
5fR7a9CvC+kUb3xHoZ2JqKIxqWfyP+pc5754U8YVE6fqsaHvmWso4qYhQThLaibAUJtScQzC
j617ytYsm0OjByCg7umk1aySAWLOYHKpdYJhdVElwY9A261KXNktbQWjPaL4JsOvc2DMWpnZ
goyPGF1ZsgJUQbjHbT378LUJJ0IIuN0Enf6PI//NmGnhdU4N+bRSzm/3FZoxOpJwm9ujnvb/
eAz2m0BJS7Tjy4JTpPU7NyZ3EWnt7czOYjIJ73Nlebk9ivWcSfbH8mW8tixkM175OPtQIkYG
D/tpk1LrEo/r0a6LPqZ6jSjVdAkOq/acKJdMblplWMulliwuswo/WPZV9oNqQZ4h5MEfOLHu
WLSGmURDyp4LelzEKSRxmI3d4pMtClfb+LV3IDFXJQtnityii/yB5C15fyVZB5HngaO6kMIS
yafsweK+hnQK4lB3xX7Fcb5lsix0P2f6k3HhV2jJoTWw9IUY1Rf/zsEL1dH4ZMksSdOyzocn
c+hxUbqO9Ggge8zRfp0ZY2pzMY635XV0FlLa/2gW9h8M7EJHxP0ECmKbczf6h6n3Hw50TGvt
9Vxf0B5563NWF7h64fwGtWJBiNNgnS9o6JBFZHR64M6mBrGQrhWKFu+Cn/EGQHXwLfhyzNdV
OgVyIgFrCoHyS1wIy7RvndJLiJx4N7T0u2/FiHkqoWCZSBWtfwCjO57zoNFnpmaVgiDft8fj
8eOa/gDC6DKDfWgiOWlUc58EknSJqOCOTjHqFuf6caEIjxPqxRDdsnug0YWHfKfIQ+PNl5WX
gpu2yQrCIRe9FSzTaJYZZlukiFWNG7UQx2U+O/TUXgGqfEi415+jahRt4FMXR9uRSbjCdm9t
c2TYPhXdy1dmnnPMrBsrOpY+gaqzj7bkJ4OfkWtNvWsuTjfMKju6z/5btyaUCqxHDIcccgrY
zRrJC/n58gg+NXhYO8jrvs4b2lO5uNRy0RZ8qppmGkegHvL7sxoT1vegcES4qjjTxuBqQJFP
1yWUO7z+ihZNJsSmTm6fKx/9EwdSv5dKH4yy6ue1lIcJJ9WfFMt33DEtI4/S6+U6qiUcz3uY
PezW8bI6cjdZGH8Hl761Lscmvgv5YSDrW5B2PL2FxaKjAORxISE+Nwb59uaqwfz9K4Zisrpo
FakDfqabS8Tb2Hv6qcQHh1XlQY8p3kjEPDfSoLHOJyz4gB02/mNizHWMzkxcS1DA8f8dMGj9
DpFNwtCqFhsLKR2nvbOPenp1W/lQRqP29HFyyQsL/VIDu4EBTfku3VufYZ805eJUT2BRXoIk
dDxvJsaFr3or/TuKWMcsNDy5t+n6ReCkfUNBKa1hJAxg7LM8PM+qAgJSzA4POpgJ2GUAAO3D
57zJNXuUAAHIlgGA0AXB13PIscRn+wIAAAAABFla
--------------030604050908070504010702--


From MAILER-DAEMON Mon Apr 16 11:46:00 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJo7s-0007Q4-Iv
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 11:46:00 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48982)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJo7i-0007Ir-FZ
	for coreutils@gnu.org; Mon, 16 Apr 2012 11:45:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJo7Y-0008Gj-RW
	for coreutils@gnu.org; Mon, 16 Apr 2012 11:45:49 -0400
Received: from mx.meyering.net ([88.168.87.75]:35702)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJo7Y-0008GU-Jg
	for coreutils@gnu.org; Mon, 16 Apr 2012 11:45:40 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 823A06015E
	for <coreutils@gnu.org>; Mon, 16 Apr 2012 17:45:38 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] maint: replace a use of strcpy in chmod.c with memcpy
Date: Mon, 16 Apr 2012 17:45:38 +0200
Message-ID: <87lilvbrz1.fsf@rho.meyering.net>
Lines: 44
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 15:45:55 -0000

This is on the edge...
I generally prefer to use memcpy when the length is already computed,
so I propose to do that here.  However, this is certainly not
performance sensitive, and the strcpy invocation is slightly simpler
and hence a little more readable.  Opinions?

>From 31f19d681f91347f0f4b9d4ed148b6aed996bf7e Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 16 Apr 2012 15:12:02 +0200
Subject: [PATCH] maint: replace a use of strcpy in chmod.c with memcpy

* src/chmod.c (main): Use memcpy rather than strcpy,
since we already have the length handy.
---
 src/chmod.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/chmod.c b/src/chmod.c
index aa4ac77..a54078c 100644
--- a/src/chmod.c
+++ b/src/chmod.c
@@ -466,19 +466,19 @@ main (int argc, char **argv)
             size_t arg_len = strlen (arg);
             size_t mode_comma_len = mode_len + !!mode_len;
             size_t new_mode_len = mode_comma_len + arg_len;
             if (mode_alloc <= new_mode_len)
               {
                 mode_alloc = new_mode_len + 1;
                 mode = X2REALLOC (mode, &mode_alloc);
               }
             mode[mode_len] = ',';
-            strcpy (mode + mode_comma_len, arg);
+            memcpy (mode + mode_comma_len, arg, arg_len + 1);
             mode_len = new_mode_len;

             diagnose_surprises = true;
           }
           break;
         case NO_PRESERVE_ROOT:
           preserve_root = false;
           break;
         case PRESERVE_ROOT:
--
1.7.10.169.g146fe


From MAILER-DAEMON Mon Apr 16 12:23:20 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJoi0-0001LN-M9
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 12:23:20 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJohv-0001JC-IB
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:23:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJohq-0004ZY-Su
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:23:15 -0400
Received: from mail-pb0-f41.google.com ([209.85.160.41]:49189)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJohq-0004XV-HZ
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:23:10 -0400
Received: by pbcup15 with SMTP id up15so6807195pbc.0
	for <coreutils@gnu.org>; Mon, 16 Apr 2012 09:23:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:subject
	:content-type:content-transfer-encoding;
	bh=UhG3lkXtEUlfby6lX8nBWn3kNzrA+BzgfeslXtl54zc=;
	b=kLNcbw1flX/M+F744qBQLbb08pAD16li1VW0zOSpkaK12xTvnKqn6UBjQ3WY7MckU0
	QXkMzbq7PiJ90rPrgdGV7I7w4pMTIq5FrWH37ACANU5pcI8SB1tZRUsSO7Ac6exXhal7
	AVekv1y2IXb0Oy78RZYcj7lKbl4PEO/vYx7N0YrXQiyHKBiFr/MMxGos8i4x/XUkI0qt
	bgRYY2mRtsQhk1ZqovajNePjIZfyoFrPWmyRguNuzR6zy80zMeMAHIk5zcyNt1FTRPZt
	4Kf4Vi+btmBJ/fN015ITUz2HqhoMUB0WdLV9aGDPocCb1xyoW0QQBK1pkNrDWoY3O4pD
	HjQg==
Received: by 10.68.195.233 with SMTP id ih9mr28618329pbc.128.1334593388246;
	Mon, 16 Apr 2012 09:23:08 -0700 (PDT)
Received: from [192.168.10.2] (adsl-75-2-129-142.dsl.pltn13.sbcglobal.net.
	[75.2.129.142])
	by mx.google.com with ESMTPS id os5sm2780236pbc.4.2012.04.16.09.23.07
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 16 Apr 2012 09:23:07 -0700 (PDT)
Message-ID: <4F8C4769.2000807@gmail.com>
Date: Mon, 16 Apr 2012 09:23:05 -0700
From: Bruce Korb <bruce.korb@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: coreutils@gnu.org, Jim Meyering <jim@meyering.net>
Subject: RE: [PATCH] maint: replace a use of strcpy in chmod.c with memcpy
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.160.41
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 16:23:19 -0000

> This is on the edge...
> I generally prefer to use memcpy when the length is already computed,
> so I propose to do that here.  However, this is certainly not
> performance sensitive, and the strcpy invocation is slightly simpler
> and hence a little more readable.  Opinions?

The "slightly" is sufficiently slight that I'd consider it sub-marginal.
Thus I'd give the marginal weight of static analysis tools that object
to "strcpy" more weight than this and apply the patch.  :-)


From MAILER-DAEMON Mon Apr 16 12:26:47 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJolL-0003J3-36
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 12:26:47 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJolH-0003Hh-Ve
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:26:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJolG-0005ui-Au
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:26:43 -0400
Received: from mx.meyering.net ([88.168.87.75]:35857)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJolG-0005uY-1t
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:26:42 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 0B14960064;
	Mon, 16 Apr 2012 18:26:40 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bruce Korb <bruce.korb@gmail.com>
Subject: Re: [PATCH] maint: replace a use of strcpy in chmod.c with memcpy
In-Reply-To: <4F8C4769.2000807@gmail.com> (Bruce Korb's message of "Mon, 16
	Apr 2012 09:23:05 -0700")
References: <4F8C4769.2000807@gmail.com>
Date: Mon, 16 Apr 2012 18:26:39 +0200
Message-ID: <87zkababi8.fsf@rho.meyering.net>
Lines: 13
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 16:26:45 -0000

Bruce Korb wrote:
>> This is on the edge...
>> I generally prefer to use memcpy when the length is already computed,
>> so I propose to do that here.  However, this is certainly not
>> performance sensitive, and the strcpy invocation is slightly simpler
>> and hence a little more readable.  Opinions?
>
> The "slightly" is sufficiently slight that I'd consider it sub-marginal.
> Thus I'd give the marginal weight of static analysis tools that object
> to "strcpy" more weight than this and apply the patch.  :-)

Good point about static analysis tools.
Glad I'm not alone.


From MAILER-DAEMON Mon Apr 16 12:28:01 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJomW-0004Tv-Sx
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 12:28:00 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57237)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJomM-0003ue-O1
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:27:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJomK-00066C-NI
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:27:50 -0400
Received: from mx.meyering.net ([88.168.87.75]:35861)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJomK-000664-CY
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:27:48 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id E5D4460064;
	Mon, 16 Apr 2012 18:27:46 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bruce Korb <bruce.korb@gmail.com>
Subject: Re: Another patch, for discussion tho
In-Reply-To: <4F8B20F5.3000707@gmail.com> (Bruce Korb's message of "Sun, 15
	Apr 2012 12:26:45 -0700")
References: <4F8B20F5.3000707@gmail.com>
Date: Mon, 16 Apr 2012 18:27:46 +0200
Message-ID: <87ty0jabgd.fsf@rho.meyering.net>
Lines: 18
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 16:27:55 -0000

Bruce Korb wrote:
> Attached are several files, one the patch, another a derived file based on
> a file that is part of the patch, and the last is the tool used to derive
> the header from the mapping file.
>
> I've had this toy kicking around for a decade or so.  If it were
> part of some project, it might be libiberty or maybe gnulib or
> maybe coreutils.  Uncertain what to do with it, I've kept it
> basically hidden.  The idea is to specify character classes for
> a particular program or group of programs and emit the classification
> table.  Zack did it for GCC.  There are some ad-hoc methods in the
> core utils, including fmt.  I chose fmt as the example because it
> was especially trivial and would still demonstrate it.
>
> So it's all attached for your amusement.  Probably needs a better name.

I suppose the motivation is performance?
If so, have you measured the improvement?


From MAILER-DAEMON Mon Apr 16 12:54:42 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJpCM-0006C0-Jx
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 12:54:42 -0400
Received: from eggs.gnu.org ([208.118.235.92]:33674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJpCH-0006Aw-18
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:54:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJpCE-0007eM-Sm
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:54:36 -0400
Received: from mail-pz0-f52.google.com ([209.85.210.52]:63606)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJpCE-0007d9-Jz
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:54:34 -0400
Received: by dake40 with SMTP id e40so6573543dak.39
	for <coreutils@gnu.org>; Mon, 16 Apr 2012 09:54:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=YhIf4UbcDoteaRDy3HrIaXnNhB+wKeFwvl9kJk0LnTc=;
	b=MkHSzTqDpqodIPivUntOXUd5voF2eV+ThCW9Osyas/Fn4qLgGo4p4zhowiAv/QsIXW
	2bw0y75jOA89VwtYmtxyq6X9LGok/RsV3zJK+Tsr/5JTWN3UU45l+QO3iItUcXZlnFfG
	ToEVH3lx+12GPU+6MEVKXk8PrdvZsrCQsOvQPORp7CxsFT91QaaiehuwY/V70IXZFwNp
	kcYio4pJ6Fx30kCRyfqL7kmDXxN9/zihfNDtLKoQmcaQCG8pNp78ZQVPLXsUTh6v1dPh
	A6daTw+UFjATQvkI4XJV2wzkarkanOgafmiql1AdMbrZ6IpMRSsRgzfnAMJPWaLhRslW
	OisQ==
Received: by 10.68.241.193 with SMTP id wk1mr1788380pbc.131.1334595272579;
	Mon, 16 Apr 2012 09:54:32 -0700 (PDT)
Received: from [192.168.10.2] (adsl-75-2-129-142.dsl.pltn13.sbcglobal.net.
	[75.2.129.142])
	by mx.google.com with ESMTPS id uf3sm18152090pbc.67.2012.04.16.09.54.31
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 16 Apr 2012 09:54:32 -0700 (PDT)
Message-ID: <4F8C4EC6.1050004@gmail.com>
Date: Mon, 16 Apr 2012 09:54:30 -0700
From: Bruce Korb <bruce.korb@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: Another patch, for discussion tho
References: <4F8B20F5.3000707@gmail.com> <87ty0jabgd.fsf@rho.meyering.net>
In-Reply-To: <87ty0jabgd.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.210.52
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 16:54:41 -0000

On 04/16/12 09:27, Jim Meyering wrote:
> Bruce Korb wrote:
>> Attached are several files, one the patch, another a derived file based on
>> a file that is part of the patch, and the last is the tool used to derive
>> the header from the mapping file.
>
> I suppose the motivation is performance?
> If so, have you measured the improvement?

Actually, no, it is not for performance.  I found it wearisome to write:

    if (isalnum(x) || (x == '_') || (x == '.......

all over the place.  I saw what Zack W. was doing in CPP and decided there
had to be a way to specify the classifications, spit out a table and
not fret over it any more.  (I did a first incantation a decade ago.)

So, if there is a performance improvement, it would be amusing to know what
it might be.  I haven't measured tho.  If ctype.h completely satisfies your
need, I'm sure there is little to no improvement (other than for
strspn and strpbrk -- there is no reverse spanning or breaking).


From MAILER-DAEMON Mon Apr 16 12:56:29 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJpE5-0006gv-NP
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 12:56:29 -0400
Received: from eggs.gnu.org ([208.118.235.92]:34027)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SJpDz-0006ee-Mw
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:56:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SJpDv-000075-S1
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:56:23 -0400
Received: from mail1.vodafone.ie ([213.233.128.43]:49748)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SJpDv-00006o-M1
	for coreutils@gnu.org; Mon, 16 Apr 2012 12:56:19 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApMBAPVOjE9tTFzs/2dsb2JhbAANNrAFhjABAQEEMgFGEAsNCwkWDwkDAgECAUUGDQEHAQG9TpFJBJwBjQk
Received: from unknown (HELO [192.168.1.79]) ([109.76.92.236])
	by mail1.vodafone.ie with ESMTP; 16 Apr 2012 17:56:02 +0100
Message-ID: <4F8C4F08.7040301@draigBrady.com>
Date: Mon, 16 Apr 2012 17:55:36 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH] maint: replace a use of strcpy in chmod.c with memcpy
References: <87lilvbrz1.fsf@rho.meyering.net>
In-Reply-To: <87lilvbrz1.fsf@rho.meyering.net>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.43
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 16:56:28 -0000

On 04/16/2012 04:45 PM, Jim Meyering wrote:
> This is on the edge...
> I generally prefer to use memcpy when the length is already computed,
> so I propose to do that here.  However, this is certainly not
> performance sensitive, and the strcpy invocation is slightly simpler
> and hence a little more readable.  Opinions?

Yep please apply.

When I see code like this I waste time looking
at it to see why the more efficient path wasn't chosen.
Of if I'm really busy assume the more efficient path
can't be used and perpetuate the inefficiency.

cheers,
Pádraig.


From MAILER-DAEMON Mon Apr 16 13:58:18 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJqBt-0000Sl-W0
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 13:58:17 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57316)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJqBn-0000Rp-IU
	for coreutils@gnu.org; Mon, 16 Apr 2012 13:58:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJqBl-0006B9-E8
	for coreutils@gnu.org; Mon, 16 Apr 2012 13:58:11 -0400
Received: from mail-pz0-f52.google.com ([209.85.210.52]:46506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJqBl-00069j-1U
	for coreutils@gnu.org; Mon, 16 Apr 2012 13:58:09 -0400
Received: by dake40 with SMTP id e40so6645998dak.39
	for <coreutils@gnu.org>; Mon, 16 Apr 2012 10:58:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=sender:message-id:date:from:reply-to:organization:user-agent
	:mime-version:to:cc:subject:references:in-reply-to:content-type;
	bh=JTeoF02V6MnybsKq4e76q0ASenfrbIyj8NIro9Sycu4=;
	b=Pb0eoXVtLv6Jt2sl94h3lhXwrXXHVKW4FUS+xz4zXmckLKDyczgcsF9OnhAdG2wqe2
	bO5D/691bXrhj4gF7HDLGiexizUFzvv8HJFUCe4ccivsO5IPdd8Du6eDZhM+Bcv6iEsc
	HwIPLSN4XeyqFbfmQbPZhFs1oZ6Zh15C+rUGcy2+0Oa/b4DqBlGDkQkE2EHp8BlWk68Z
	zz0EtZf3acqt0NKZ4KCtCY5yKwnC0CTIhsUzl8M8R0h8YUBCQ4EONTriS5U8d+ELa7hk
	39fSL/4RnFKBfq68zhRpNS/MOmO4GTqgTRHtfW+ZwGS7YxKoHTReIp6spBrHVRuQAdAU
	T+7w==
Received: by 10.68.138.201 with SMTP id qs9mr521662pbb.138.1334599086745;
	Mon, 16 Apr 2012 10:58:06 -0700 (PDT)
Received: from [192.168.10.2] (adsl-75-2-129-142.dsl.pltn13.sbcglobal.net.
	[75.2.129.142])
	by mx.google.com with ESMTPS id v1sm18283898pbk.10.2012.04.16.10.58.05
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 16 Apr 2012 10:58:05 -0700 (PDT)
Sender: Bruce Korb <bruce.korb@gmail.com>
Message-ID: <4F8C5DAC.1070405@gnu.org>
Date: Mon, 16 Apr 2012 10:58:04 -0700
From: Bruce Korb <bkorb@gnu.org>
Organization: FSF
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Bruce Korb <bruce.korb@gmail.com>
Subject: Re: Another patch, for discussion tho
References: <4F8B20F5.3000707@gmail.com> <87ty0jabgd.fsf@rho.meyering.net>
	<4F8C4EC6.1050004@gmail.com>
In-Reply-To: <4F8C4EC6.1050004@gmail.com>
Content-Type: multipart/mixed; boundary="------------010201070502040102040600"
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.210.52
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: bkorb@gnu.org
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 17:58:16 -0000

This is a multi-part message in MIME format.
--------------010201070502040102040600
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 04/16/12 09:54, Bruce Korb wrote:
>> I suppose the motivation is performance?
>> If so, have you measured the improvement?
>
> Actually, no, it is not for performance. I found it wearisome to write:

But curiosity got the better of me:

$ ./timer
strpbrk    startup time:     0.000 run time:       31.081
macros     startup time:     0.000 run time:       19.882

--------------010201070502040102040600
Content-Type: text/x-csrc;
 name="timer.c"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="timer.c"


#define _GNU_SOURCE 1
#include <sys/mman.h>
#include <sys/stat.h>
#include <sys/time.h>
#include <sys/types.h>

#include <ctype.h>
#include <fcntl.h>
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

#include "timer-map.h"

#define START_CT 1000
#define FULL_CT  (1000 * 1000 * 1000)

typedef struct {
    struct timeval start, middle, end;
} race_times_t;

volatile char extern_ch;
char const * text = NULL;

void
print_timings(race_times_t * pb, race_times_t * mac);

void
use_strpbrk(int ct)
{
    while (ct-- > 0) {
        char * p = strpbrk(text, "#~");
        extern_ch = *p;
    }
}

void
use_macros(int ct)
{
    while (ct-- > 0) {
        char * p = SPN_HASH_CHARS(text);
        extern_ch = *p;
    }
}

void
map_file(char const * fname)
{
    struct stat sb;
    int sres = stat(fname, &sb);
    int fd   = open(fname, O_RDONLY);
    void * map = mmap(NULL, sb.st_size+1, PROT_READ, MAP_SHARED, fd, 0);
    if ((sres < 0) || (fd < 0) || (map == MAP_FAILED))
        exit(1);
    text = map;
}

int
main(int argc, char ** argv)
{
    race_times_t for_strpbrk;
    race_times_t for_macros;

    {
        char const * fn = argv[1] ? argv[1] : __FILE__;
        map_file(fn);
    }

    gettimeofday(&for_strpbrk.start, NULL);
    use_strpbrk(START_CT);
    gettimeofday(&for_strpbrk.middle, NULL);
    use_strpbrk(FULL_CT);
    gettimeofday(&for_strpbrk.end, NULL);

    for_macros.start = for_strpbrk.end;
    use_macros(START_CT);
    gettimeofday(&for_macros.middle, NULL);
    use_macros(FULL_CT);
    gettimeofday(&for_macros.end, NULL);

    print_timings(&for_strpbrk, &for_macros);
    return 0;
}

int
delta(struct timeval * s, struct timeval * e)
{
    if (s->tv_sec == e->tv_sec)
        return (500 + e->tv_usec - s->tv_usec) / 1000;
    int msec = (500 + (1000000 - s->tv_usec) + e->tv_usec) / 1000;
    return msec + ((e->tv_sec - s->tv_sec) - 1) * 1000;
}

void
fmtnum(char * buf, int msec)
{
    int len = sprintf(buf, "%04u", msec);
    char * p = buf + len - 3;
    memmove(p+1, p, 4);
    *p = '.';
}

void
print_timings(race_times_t * pb, race_times_t * mac)
{
    static char const fmt[] =
        "%-10s startup time: %9s run time: %12s\n";

    int delta1 = delta(&pb->start,  &pb->middle);
    int delta2 = delta(&pb->middle, &pb->end);
    char buf1[32], buf2[32];
    fmtnum(buf1, delta1);
    fmtnum(buf2, delta2);
    printf(fmt, "strpbrk", buf1, buf2);

    delta1 = delta(&mac->start,  &mac->middle);
    delta2 = delta(&mac->middle, &mac->end);
    fmtnum(buf1, delta1);
    fmtnum(buf2, delta2);
    printf(fmt, "macros", buf1, buf2);
}

--------------010201070502040102040600
Content-Type: text/x-chdr;
 name="timer-map.h"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="timer-map.h"

/*
 *  1 bit character mapping generated 04/16/12 10:12:44
 *
 *  char-mapper Character Classifications
 */
#ifndef TIMER_MAP_H_GUARD
#define TIMER_MAP_H_GUARD 1

#ifdef HAVE_CONFIG_H
# if defined(HAVE_INTTYPES_H)
#   include <inttypes.h>

# elif defined(HAVE_STDINT_H)
#   include <stdint.h>

#   elif !defined(HAVE_UINT8_T)
        typedef unsigned char   uint8_t;
# endif /* HAVE_*INT*_H header */

#else /* not HAVE_CONFIG_H -- */
# include <inttypes.h>
#endif /* HAVE_CONFIG_H */

#if 0 /* mapping specification source (from timer-map.map) */
// 
// %guard
// %file           timer-map.h
// %backup
// 
// hash   "#~"
//
#endif /* 0 -- mapping spec. source */


typedef uint8_t timer_map_mask_t;

#define  IS_HASH_CHAR( _c)   is_timer_map_char((char)( _c), 0x01)
#define SPN_HASH_CHARS(_s)  spn_timer_map_chars((char *)_s, 0x01)
#define BRK_HASH_CHARS(_s)  brk_timer_map_chars((char *)_s, 0x01)
#define SPN_HASH_BACK(s,e)  spn_timer_map_back((char *)s, (char *)e, 0x01)
#define BRK_HASH_BACK(s,e)  brk_timer_map_back((char *)s, (char *)e, 0x01)

static timer_map_mask_t const timer_map_table[128] = {
  /*NUL*/ 0x00, /*x01*/ 0x00, /*x02*/ 0x00, /*x03*/ 0x00,
  /*x04*/ 0x00, /*x05*/ 0x00, /*x06*/ 0x00, /*BEL*/ 0x00,
  /* BS*/ 0x00, /* HT*/ 0x00, /* NL*/ 0x00, /* VT*/ 0x00,
  /* FF*/ 0x00, /* CR*/ 0x00, /*x0E*/ 0x00, /*x0F*/ 0x00,
  /*x10*/ 0x00, /*x11*/ 0x00, /*x12*/ 0x00, /*x13*/ 0x00,
  /*x14*/ 0x00, /*x15*/ 0x00, /*x16*/ 0x00, /*x17*/ 0x00,
  /*x18*/ 0x00, /*x19*/ 0x00, /*x1A*/ 0x00, /*ESC*/ 0x00,
  /*x1C*/ 0x00, /*x1D*/ 0x00, /*x1E*/ 0x00, /*x1F*/ 0x00,
  /*   */ 0x00, /* ! */ 0x00, /* " */ 0x00, /* # */ 0x01,
  /* $ */ 0x00, /* % */ 0x00, /* & */ 0x00, /* ' */ 0x00,
  /* ( */ 0x00, /* ) */ 0x00, /* * */ 0x00, /* + */ 0x00,
  /* , */ 0x00, /* - */ 0x00, /* . */ 0x00, /* / */ 0x00,
  /* 0 */ 0x00, /* 1 */ 0x00, /* 2 */ 0x00, /* 3 */ 0x00,
  /* 4 */ 0x00, /* 5 */ 0x00, /* 6 */ 0x00, /* 7 */ 0x00,
  /* 8 */ 0x00, /* 9 */ 0x00, /* : */ 0x00, /* ; */ 0x00,
  /* < */ 0x00, /* = */ 0x00, /* > */ 0x00, /* ? */ 0x00,
  /* @ */ 0x00, /* A */ 0x00, /* B */ 0x00, /* C */ 0x00,
  /* D */ 0x00, /* E */ 0x00, /* F */ 0x00, /* G */ 0x00,
  /* H */ 0x00, /* I */ 0x00, /* J */ 0x00, /* K */ 0x00,
  /* L */ 0x00, /* M */ 0x00, /* N */ 0x00, /* O */ 0x00,
  /* P */ 0x00, /* Q */ 0x00, /* R */ 0x00, /* S */ 0x00,
  /* T */ 0x00, /* U */ 0x00, /* V */ 0x00, /* W */ 0x00,
  /* X */ 0x00, /* Y */ 0x00, /* Z */ 0x00, /* [ */ 0x00,
  /* \ */ 0x00, /* ] */ 0x00, /* ^ */ 0x00, /* _ */ 0x00,
  /* ` */ 0x00, /* a */ 0x00, /* b */ 0x00, /* c */ 0x00,
  /* d */ 0x00, /* e */ 0x00, /* f */ 0x00, /* g */ 0x00,
  /* h */ 0x00, /* i */ 0x00, /* j */ 0x00, /* k */ 0x00,
  /* l */ 0x00, /* m */ 0x00, /* n */ 0x00, /* o */ 0x00,
  /* p */ 0x00, /* q */ 0x00, /* r */ 0x00, /* s */ 0x00,
  /* t */ 0x00, /* u */ 0x00, /* v */ 0x00, /* w */ 0x00,
  /* x */ 0x00, /* y */ 0x00, /* z */ 0x00, /* { */ 0x00,
  /* | */ 0x00, /* } */ 0x00, /* ~ */ 0x01, /*x7F*/ 0x00
};
static inline int
is_timer_map_char(char ch, timer_map_mask_t mask)
{
    unsigned int ix = (unsigned char)ch;
    return ((ix < 128) && ((timer_map_table[ix] & mask) != 0));
}

static inline char *
spn_timer_map_chars(char * p, timer_map_mask_t mask)
{
    while ((*p != '\0') && is_timer_map_char(*p, mask))  p++;
    return p;
}

static inline char *
brk_timer_map_chars(char * p, timer_map_mask_t mask)
{
    while ((*p != '\0') && (! is_timer_map_char(*p, mask)))  p++;
    return p;
}

static inline char *
spn_timer_map_back(char * s, char * e, timer_map_mask_t mask)
{
    if (s == e) e += strlen(e);
    while ((e > s) && is_timer_map_char(e[-1], mask))  e--;
    return e;
}

static inline char *
brk_timer_map_back(char * s, char * e, timer_map_mask_t mask)
{
    if (s == e) e += strlen(e);
    while ((e > s) && (! is_timer_map_char(e[-1], mask)))  e--;
    return e;
}
#endif /* TIMER_MAP_H_GUARD */

--------------010201070502040102040600--


From MAILER-DAEMON Mon Apr 16 14:00:23 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJqDv-0000sV-L5
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 14:00:23 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJqDY-0000i3-5n
	for coreutils@gnu.org; Mon, 16 Apr 2012 14:00:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SJqDW-0006ez-9C
	for coreutils@gnu.org; Mon, 16 Apr 2012 13:59:59 -0400
Received: from mail-pz0-f52.google.com ([209.85.210.52]:60998)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>)
	id 1SJqDT-0006eD-69; Mon, 16 Apr 2012 13:59:55 -0400
Received: by dake40 with SMTP id e40so6647940dak.39
	for <multiple recipients>; Mon, 16 Apr 2012 10:59:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=6XDtHAG1w3HXO8glfT/kgaUpWvXYbsI3amhDoLBdDj8=;
	b=Fbgky9YPN5+sxn89ylyJ3P8i2SR8Ozd46ts84j+USVJY1+oluHBqCrbVj+ZCWawmK/
	WG70or7+7LDIpc4nsVMhI6Qrycoz9Et4t81qVHmdQWKGWS8FyP3pms4PNEvyHEBdmsIl
	Q2jv79tShEDDQTSI0R+Y8FXmNi57ZgOi8AaanuRtlHQ5Nvj40N6GmyXlY5Fb9GbpKkAQ
	zSOLlhAqBGp0mnfryAMzKMkF+BPFTaiu88P+3OjZGQE0PL5Vh9U3odilLzWEuqSoVSc4
	u2P+7SAaY5VdgZRC+K3WklrG5AUBb4LIx0fnmAyRigZ25QyRmSr/BXHeoh1cxTcT9kO2
	qrcg==
Received: by 10.68.201.166 with SMTP id kb6mr7143814pbc.158.1334599192444;
	Mon, 16 Apr 2012 10:59:52 -0700 (PDT)
Received: from [192.168.10.2] (adsl-75-2-129-142.dsl.pltn13.sbcglobal.net.
	[75.2.129.142])
	by mx.google.com with ESMTPS id or6sm18282764pbc.43.2012.04.16.10.59.51
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 16 Apr 2012 10:59:51 -0700 (PDT)
Message-ID: <4F8C5E16.10705@gmail.com>
Date: Mon, 16 Apr 2012 10:59:50 -0700
From: Bruce Korb <bruce.korb@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: bkorb@gnu.org
Subject: Re: Another patch, for discussion tho
References: <4F8B20F5.3000707@gmail.com> <87ty0jabgd.fsf@rho.meyering.net>
	<4F8C4EC6.1050004@gmail.com> <4F8C5DAC.1070405@gnu.org>
In-Reply-To: <4F8C5DAC.1070405@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.210.52
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 18:00:01 -0000

On 04/16/12 10:58, Bruce Korb wrote:
> On 04/16/12 09:54, Bruce Korb wrote:
>>> I suppose the motivation is performance?
>>> If so, have you measured the improvement?
>>
>> Actually, no, it is not for performance. I found it wearisome to write:
>
> But curiosity got the better of me:
>
> $ ./timer
> strpbrk startup time: 0.000 run time: 31.081
> macros startup time: 0.000 run time: 19.882

Optimized makes a bigger % difference:

$ gcc -O4 -g -o timer timer.c
$ ./timer
strpbrk    startup time:     0.000 run time:        5.581
macros     startup time:     0.000 run time:        2.439


From MAILER-DAEMON Mon Apr 16 17:02:18 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJt3y-0004Aj-Lo
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 17:02:18 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJt3w-0004Ab-Dp
	for coreutils@gnu.org; Mon, 16 Apr 2012 17:02:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJt3t-0005Zh-Nf
	for coreutils@gnu.org; Mon, 16 Apr 2012 17:02:15 -0400
Received: from mx.meyering.net ([88.168.87.75]:36620)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SJt3t-0005ZJ-11
	for coreutils@gnu.org; Mon, 16 Apr 2012 17:02:13 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id BEC4D60064
	for <coreutils@gnu.org>; Mon, 16 Apr 2012 23:02:09 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] doc: use @xref{... only at start of a sentence
Date: Mon, 16 Apr 2012 23:02:09 +0200
Message-ID: <878vhv8k6m.fsf@rho.meyering.net>
Lines: 87
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 21:02:17 -0000

Trying a new syntax-check suggested by Akim Demaille (under development),
here are fixes for the things it catches in coreutils.texi:

>From a2a1e031b4b75a6e805426a7920df809f60a2890 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 16 Apr 2012 20:26:41 +0200
Subject: [PATCH] doc: use @xref{... only at start of a sentence

* doc/coreutils.texi: Correct many misuses of @xref.
---
 doc/coreutils.texi |   16 +++++++++-------
 doc/perm.texi      |    4 ++--
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index 682536a..4861925 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -2366,7 +2366,7 @@ pr invocation
 @cindex time formats
 @cindex formatting times
 Format header dates using @var{format}, using the same conventions as
-for the command @samp{date +@var{format}}; @xref{date invocation}.
+for the command @samp{date +@var{format}}.  @xref{date invocation}.
 Except for directives, which start with
 @samp{%}, characters in @var{format} are printed unchanged.  You can use
 this option to specify an arbitrary string in place of the header date,
@@ -4910,7 +4910,7 @@ ptx invocation
 limitations and changing several of the program's default option values.
 When @option{-G} is not specified, @sc{gnu} extensions are always enabled.
 @sc{gnu} extensions to @command{ptx} are documented wherever appropriate in this
-document.  For the full list, see @xref{Compatibility in ptx}.
+document.  @xref{Compatibility in ptx} for the full list.

 Individual options are explained in the following sections.

@@ -5047,8 +5047,9 @@ Input processing in ptx

 On each input line, the leading sequence of non-white space characters will be
 taken to be a reference that has the purpose of identifying this input
-line in the resulting permuted index.  For more information about reference
-production, see @xref{Output formatting in ptx}.
+line in the resulting permuted index.
+@xref{Output formatting in ptx}
+for more information about reference production.
 Using this option changes the default value for option @option{-S}.

 Using this option, the program does not try very hard to remove
@@ -16000,7 +16001,7 @@ timeout invocation
 @opindex --signal
 Send this @var{signal} to @var{command} on timeout, rather than the
 default @samp{TERM} signal. @var{signal} may be a name like @samp{HUP}
-or a number. Also see @xref{Signal specifications}.
+or a number. @xref{Signal specifications}.
 @end table

 @cindex time units
@@ -16108,8 +16109,9 @@ kill invocation
 signal.  A signal name can be given in canonical form or prefixed by
 @samp{SIG}.  The case of the letters is ignored, except for the
 @option{-@var{signal}} option which must use upper case to avoid
-ambiguity with lower case option letters.  For a list of supported
-signal names and numbers see @xref{Signal specifications}.
+ambiguity with lower case option letters.
+@xref{Signal specifications} for a list of supported
+signal names and numbers.

 @node Delaying
 @chapter Delaying
diff --git a/doc/perm.texi b/doc/perm.texi
index 95de46a..6c466f2 100644
--- a/doc/perm.texi
+++ b/doc/perm.texi
@@ -503,9 +503,9 @@ Numeric Modes
 mode, but it is limited in that normally it cannot take into account the
 previous file mode bits; it can only set them absolutely.
 The set-user-ID and set-group-ID bits of directories are an exception
-to this general limitation; @xref{Directory Setuid and Setgid}.
+to this general limitation.  @xref{Directory Setuid and Setgid}.
 Also, operator numeric modes can take previous file mode bits into
-account; @xref{Operator Numeric Modes}.
+account.  @xref{Operator Numeric Modes}.

 The permissions granted to the user,
 to other users in the file's group,
--
1.7.10.169.g146fe


From MAILER-DAEMON Mon Apr 16 18:04:05 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SJu1l-0006td-Kt
	for mharc-coreutils@gnu.org; Mon, 16 Apr 2012 18:04:05 -0400
Received: from eggs.gnu.org ([208.118.235.92]:47995)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SJtCH-0004oK-5Q
	for coreutils@gnu.org; Mon, 16 Apr 2012 17:10:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SJtCF-0000EW-E1
	for coreutils@gnu.org; Mon, 16 Apr 2012 17:10:52 -0400
Received: from plane.gmane.org ([80.91.229.3]:43795)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SJtCF-0000ED-7G
	for coreutils@gnu.org; Mon, 16 Apr 2012 17:10:51 -0400
Received: from public by plane.gmane.org with local (Exim 4.69)
	(envelope-from <public@plane.gmane.org>) id 1SJtCB-0007aS-9Q
	for coreutils@gnu.org; Mon, 16 Apr 2012 23:10:47 +0200
Received: from mail-out.m-online.net ([212.18.0.9])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <whitebox@nefkom.net>)
	id 1SJtC5-0007X2-HN; Mon, 16 Apr 2012 23:10:41 +0200
Received: from frontend1.mail.m-online.net (unknown [192.168.8.180])
	by mail-out.m-online.net (Postfix) with ESMTP id 3VWj1F196Hz4Kh2M;
	Mon, 16 Apr 2012 23:10:41 +0200 (CEST)
Received: from igel.home (ppp-93-104-132-43.dynamic.mnet-online.de
	[93.104.132.43])
	by mail.mnet-online.de (Postfix) with ESMTPA id 3VWj1D75Q1z4KK2G;
	Mon, 16 Apr 2012 23:10:40 +0200 (CEST)
Received: by igel.home (Postfix, from userid 501)
	id 96D0BCA2A0; Mon, 16 Apr 2012 23:10:40 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jim Meyering <public-jim-Oxw1nKZkIVjk1uMJSBkQmQ@plane.gmane.org>
Subject: Re: [PATCH] doc: use @xref{... only at start of a sentence
References: <878vhv8k6m.fsf@rho.meyering.net>
X-Yow: There's a little picture of ED MCMAHON doing BAD THINGS to JOAN RIVERS
	in a $200,000 MALIBU BEACH HOUSE!!
Date: Mon, 16 Apr 2012 23:10:40 +0200
In-Reply-To: <878vhv8k6m.fsf@rho.meyering.net> (Jim Meyering's message of
	"Mon, 16 Apr 2012 23:02:09 +0200")
Message-ID: <m2k41fz8kv.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 80.91.229.3
X-Mailman-Approved-At: Mon, 16 Apr 2012 18:04:03 -0400
Cc: public-coreutils-mXXj517/zsQ@plane.gmane.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 21:10:54 -0000



Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org> writes:

> @@ -4910,7 +4910,7 @@ ptx invocation
>  limitations and changing several of the program's default option values.
>  When @option{-G} is not specified, @sc{gnu} extensions are always enabled.
>  @sc{gnu} extensions to @command{ptx} are documented wherever appropriate in this
> -document.  For the full list, see @xref{Compatibility in ptx}.
> +document.  @xref{Compatibility in ptx} for the full list.

@xref must be followed by a period or comma.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



From MAILER-DAEMON Tue Apr 17 03:26:02 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SK2na-0007nM-Oi
	for mharc-coreutils@gnu.org; Tue, 17 Apr 2012 03:26:02 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40250)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SK2nV-0007mo-Ce
	for coreutils@gnu.org; Tue, 17 Apr 2012 03:26:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SK2nO-0007yE-0l
	for coreutils@gnu.org; Tue, 17 Apr 2012 03:25:56 -0400
Received: from mx.meyering.net ([88.168.87.75]:38194)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SK2nN-0007y7-NX
	for coreutils@gnu.org; Tue, 17 Apr 2012 03:25:49 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 1DA3660056;
	Tue, 17 Apr 2012 09:25:48 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH] doc: use @xref{... only at start of a sentence
In-Reply-To: <m2k41fz8kv.fsf@igel.home> (Andreas Schwab's message of "Mon, 16
	Apr 2012 23:10:40 +0200")
References: <878vhv8k6m.fsf@rho.meyering.net> <m2k41fz8kv.fsf@igel.home>
Date: Tue, 17 Apr 2012 09:25:48 +0200
Message-ID: <87sjg27rb7.fsf@rho.meyering.net>
Lines: 22
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2012 07:26:02 -0000

Andreas Schwab wrote:
> Jim Meyering <jim-Oxw1nKZkIVjk1uMJSBkQmQ@public.gmane.org> writes:
>
>> @@ -4910,7 +4910,7 @@ ptx invocation
>>  limitations and changing several of the program's default option values.
>>  When @option{-G} is not specified, @sc{gnu} extensions are always enabled.
>>  @sc{gnu} extensions to @command{ptx} are documented wherever
>> appropriate in this
>> -document.  For the full list, see @xref{Compatibility in ptx}.
>> +document.  @xref{Compatibility in ptx} for the full list.
>
> @xref must be followed by a period or comma.

Thanks.  makeinfo even warns about that one:

  make[2]: Entering directory `/h/j/w/co/cu/doc'
    MAKEINFO coreutils.info
  coreutils.texi:4913: warning: `.' or `,' must follow @xref, not `f'.
  coreutils.texi:5051: warning: `.' or `,' must follow @xref, not `f'.
  coreutils.texi:16113: warning: `.' or `,' must follow @xref, not `f'.

I've added those three commas.


From MAILER-DAEMON Tue Apr 17 19:47:14 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKI78-0001aP-LW
	for mharc-coreutils@gnu.org; Tue, 17 Apr 2012 19:47:14 -0400
Received: from eggs.gnu.org ([208.118.235.92]:52132)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SKI72-0001Zv-Uh
	for coreutils@gnu.org; Tue, 17 Apr 2012 19:47:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SKI6y-0006KR-3b
	for coreutils@gnu.org; Tue, 17 Apr 2012 19:47:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41258)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SKI6x-0006KK-QM
	for coreutils@gnu.org; Tue, 17 Apr 2012 19:47:04 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3HNl0sG021298
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Tue, 17 Apr 2012 19:47:01 -0400
Received: from pb-n5110.redhat.com (ovpn-116-70.ams2.redhat.com [10.36.116.70])
	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id q3HNkxaO015116; Tue, 17 Apr 2012 19:46:59 -0400
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P@draigBrady.com>
To: coreutils@gnu.org
Subject: [PATCH] maint: fix common spelling errors in comments
Date: Wed, 18 Apr 2012 00:46:44 +0100
Message-Id: <1334706404-31518-1-git-send-email-P@draigBrady.com>
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
Cc: Kevin Lyda <kevin@ie.suberic.net>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Apr 2012 23:47:13 -0000

From: Kevin Lyda <kevin@ie.suberic.net>

These were identified using: https://github.com/lyda/misspell-check

* src/cat.c: Correct a single spelling error.
* src/comm.c: Likewise.
* src/expr.c Likewise.
* src/pr.c Likewise.
* src/tac.c Likewise.
* src/test.c Likewise.
---
 src/cat.c  |    4 ++--
 src/comm.c |    2 +-
 src/expr.c |    2 +-
 src/pr.c   |    2 +-
 src/tac.c  |    2 +-
 src/test.c |    2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/cat.c b/src/cat.c
index 41a1b41..9e901e0 100644
--- a/src/cat.c
+++ b/src/cat.c
@@ -751,8 +751,8 @@ main (int argc, char **argv)
              A line number requires seldom more than LINE_COUNTER_BUF_LEN
              positions.
 
-             Align the output buffer to a page size boundary, for efficency on
-             some paging implementations, so add PAGE_SIZE - 1 bytes to the
+             Align the output buffer to a page size boundary, for efficiency
+             on some paging implementations, so add PAGE_SIZE - 1 bytes to the
              request to make room for the alignment.  */
 
           outbuf = xmalloc (outsize - 1 + insize * 4 + LINE_COUNTER_BUF_LEN
diff --git a/src/comm.c b/src/comm.c
index 04422d6..748147a 100644
--- a/src/comm.c
+++ b/src/comm.c
@@ -193,7 +193,7 @@ writeline (struct linebuffer const *line, FILE *stream, int class)
 
    A message is printed at most once per input file.
 
-   This funtion was copied (nearly) verbatim from 'src/join.c'. */
+   This function was copied (nearly) verbatim from 'src/join.c'. */
 
 static void
 check_order (struct linebuffer const *prev,
diff --git a/src/expr.c b/src/expr.c
index 5368010..700e4af 100644
--- a/src/expr.c
+++ b/src/expr.c
@@ -18,7 +18,7 @@
    Modified for arbitrary-precision calculation by James Youngman.
 
    This program evaluates expressions.  Each token (operator, operand,
-   parenthesis) of the expression must be a seperate argument.  The
+   parenthesis) of the expression must be a separate argument.  The
    parser used is a reasonably general one, though any incarnation of
    it is language-specific.  It is especially nice for expressions.
 
diff --git a/src/pr.c b/src/pr.c
index f1e310f..9c21e11 100644
--- a/src/pr.c
+++ b/src/pr.c
@@ -1413,7 +1413,7 @@ init_funcs (void)
   else
     {
       /* When numbering lines of parallel files, we enlarge the
-         first column to accomodate the number.  Looks better than
+         first column to accommodate the number.  Looks better than
          the Sys V approach. */
       if (parallel_files && numbered_lines)
         h_next = h + chars_per_column + number_width;
diff --git a/src/tac.c b/src/tac.c
index b50382d..94451be 100644
--- a/src/tac.c
+++ b/src/tac.c
@@ -339,7 +339,7 @@ tac_seekable (int input_fd, const char *file)
              The source and destination regions probably overlap.  */
           memmove (G_buffer + read_size, G_buffer, saved_record_size);
           past_end = G_buffer + read_size + saved_record_size;
-          /* For non-regexp searches, avoid unneccessary scanning. */
+          /* For non-regexp searches, avoid unnecessary scanning. */
           if (sentinel_length)
             match_start = G_buffer + read_size;
           else
diff --git a/src/test.c b/src/test.c
index 2d562d9..7c7489e 100644
--- a/src/test.c
+++ b/src/test.c
@@ -94,7 +94,7 @@ test_syntax_error (char const *format, char const *arg)
 }
 
 /* Increment our position in the argument list.  Check that we're not
-   past the end of the argument list.  This check is supressed if the
+   past the end of the argument list.  This check is suppressed if the
    argument is false.  */
 
 static void
-- 
1.7.6.4



From MAILER-DAEMON Wed Apr 18 02:04:52 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKO0a-0007sV-ID
	for mharc-coreutils@gnu.org; Wed, 18 Apr 2012 02:04:52 -0400
Received: from eggs.gnu.org ([208.118.235.92]:47720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKO0U-0007s4-Ve
	for coreutils@gnu.org; Wed, 18 Apr 2012 02:04:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKO0Q-0006lN-7G
	for coreutils@gnu.org; Wed, 18 Apr 2012 02:04:46 -0400
Received: from mx.meyering.net ([88.168.87.75]:41853)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKO0P-0006l0-V5
	for coreutils@gnu.org; Wed, 18 Apr 2012 02:04:42 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 38F65601A2;
	Wed, 18 Apr 2012 08:04:38 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: =?iso-8859-1?Q?P=E1draig?= Brady <P@draigBrady.com>
Subject: Re: [PATCH] maint: fix common spelling errors in comments
In-Reply-To: <1334706404-31518-1-git-send-email-P@draigBrady.com>
	(=?iso-8859-1?Q?=22P=E1draig?=
	Brady"'s message of "Wed, 18 Apr 2012 00:46:44 +0100")
References: <1334706404-31518-1-git-send-email-P@draigBrady.com>
Date: Wed, 18 Apr 2012 08:04:38 +0200
Message-ID: <87ty0h379l.fsf@rho.meyering.net>
Lines: 61
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: Kevin Lyda <kevin@ie.suberic.net>, coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Apr 2012 06:04:51 -0000

P=E1draig Brady wrote:
> From: Kevin Lyda <kevin@ie.suberic.net>
>
> These were identified using: https://github.com/lyda/misspell-check
>
> * src/cat.c: Correct a single spelling error.
> * src/comm.c: Likewise.
> * src/expr.c Likewise.
> * src/pr.c Likewise.
> * src/tac.c Likewise.
> * src/test.c Likewise.
> ---
>  src/cat.c  |    4 ++--
>  src/comm.c |    2 +-
>  src/expr.c |    2 +-
>  src/pr.c   |    2 +-
>  src/tac.c  |    2 +-
>  src/test.c |    2 +-
>  6 files changed, 7 insertions(+), 7 deletions(-)

Nice.  But don't stop with just the .c files.
Run it on all version-controlled files:

    git ls-files|misspellings -f -

Offenders below,
all of which are legit except the "dum" in doc/coreutils,
which is a host name in "uname" output -- even that is worth
changing, to avoid future reports.

ChangeLog-2005[1209]: todays -> "today's"
ChangeLog-2007[3265]: postive -> "positive"
NEWS[883]: preceeding -> "preceding"
NEWS[1104]: noticable -> "noticeable"
NEWS[3350]: thru -> "through"
doc/coreutils.texi[14894]: dum -> "dumb"
lib/ChangeLog-2007[2732]: whther -> "whether"
man/help2man[257]: seperated -> "separated"
old/fileutils/ChangeLog-1997[2545]: accomodate -> "accommodate"
old/fileutils/NEWS[11]: thru -> "through"
old/sh-utils/ChangeLog.0[272]: enviroment -> "environment"
old/sh-utils/ChangeLog.0[1365]: accomodate -> "accommodate"
old/textutils/ChangeLog[4872]: accomodate -> "accommodate"
old/textutils/ChangeLog[5206]: accomodate -> "accommodate"
old/textutils/ChangeLog[5248]: accomodate -> "accommodate"
old/textutils/ChangeLog[8700]: unneccessary -> "unnecessary"
src/cat.c[754]: efficency -> "efficiency"
src/comm.c[196]: funtion -> "function"
src/expr.c[21]: seperate -> "separate"
src/pr.c[1416]: accomodate -> "accommodate"
src/tac.c[342]: unneccessary -> "unnecessary"
src/test.c[97]: supressed -> "suppressed"
tests/misc/comm[37]: supress -> "suppress"
tests/misc/comm[40]: supress -> "suppress"
tests/misc/comm[43]: supress -> "suppress"
tests/misc/comm[46]: supress -> "suppress"
tests/misc/comm[49]: supress -> "suppress"
tests/misc/comm[52]: supress -> "suppress"
tests/misc/comm[55]: supress -> "suppress"
tests/misc/uniq[165]: seperated -> "separated"
tests/mv/dir2dir[28]: interrim -> "interim"


From MAILER-DAEMON Thu Apr 19 07:10:33 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKpFx-00013G-8P
	for mharc-coreutils@gnu.org; Thu, 19 Apr 2012 07:10:33 -0400
Received: from eggs.gnu.org ([208.118.235.92]:38528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKpFp-000112-K9
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:10:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKpFf-0001x2-Pu
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:10:25 -0400
Received: from mx.meyering.net ([88.168.87.75]:46536)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKpFf-0001ws-Ik
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:10:15 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 1DA2D60081
	for <coreutils@gnu.org>; Thu, 19 Apr 2012 13:10:14 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] doc: tweak README-hacking
Date: Thu, 19 Apr 2012 13:10:14 +0200
Message-ID: <87bomoq8o9.fsf@rho.meyering.net>
Lines: 30
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2012 11:10:31 -0000

FYI,

>From f70d876e031af120d909194ca1c749f3e2a306d6 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 18 Apr 2012 20:16:39 +0200
Subject: [PATCH] doc: tweak README-hacking

* README-hacking: Don't say "...on your hard drive".
That is unnecessary, and now, borderline anachronistic.
---
 README-hacking |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README-hacking b/README-hacking
index c7eae09..83556d3 100644
--- a/README-hacking
+++ b/README-hacking
@@ -29,8 +29,8 @@ You can get a copy of the source repository like this:
         $ cd coreutils

 As an optional step, if you already have a copy of the gnulib git
-repository on your hard drive, then you can use it as a reference to
-reduce download time and disk space requirements:
+repository, then you can use it as a reference to reduce download
+time and disk space requirements:

         $ export GNULIB_SRCDIR=/path/to/gnulib

--
1.7.10.208.gb4267


From MAILER-DAEMON Thu Apr 19 07:15:49 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKpL3-0001ZR-P4
	for mharc-coreutils@gnu.org; Thu, 19 Apr 2012 07:15:49 -0400
Received: from eggs.gnu.org ([208.118.235.92]:45414)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKpKv-0001WE-Rl
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:15:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKpKl-0003cK-MD
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:15:41 -0400
Received: from mx.meyering.net ([88.168.87.75]:46553)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKpKl-0003bx-AT
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:15:31 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 043596007F
	for <coreutils@gnu.org>; Thu, 19 Apr 2012 13:15:29 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: crusade against strncpy/strcpy ;-)
Date: Thu, 19 Apr 2012 13:15:29 +0200
Message-ID: <8762cwq8fi.fsf@rho.meyering.net>
Lines: 158
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2012 11:15:48 -0000

strncpy is particularly bad, but even strcpy is best avoided.
There are still a few uses remaining, and these remove a few from ls.c
and tac.c.  As an added bonus, one part of ls.c no longer hard-codes "/"
as file name component separator (though note that my motivation for that
change was to avoid rolling my own, rather than to support an alternate
separator).

>From 280aa28c4dc82f394d423bfceaac29b5b48c3cd2 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 18 Apr 2012 13:36:11 +0200
Subject: [PATCH 1/3] maint: modernize/clean-up a small function in ls.c

* src/ls.c (make_link_name): Adjust comment style to refer to VARIABLE
names, not 'variable'.
Move each of two declarations "down" to first use.
Compare pointer to NULL, not to 0.
Don't reuse local, "linkbuf" for a different purpose.
---
 src/ls.c |   25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/src/ls.c b/src/ls.c
index f1dfb1e..db58192 100644
--- a/src/ls.c
+++ b/src/ls.c
@@ -3193,17 +3193,14 @@ get_link_name (char const *filename, struct fileinfo *f, bool command_line_arg)
                   filename);
 }

-/* If 'linkname' is a relative name and 'name' contains one or more
-   leading directories, return 'linkname' with those directories
-   prepended; otherwise, return a copy of 'linkname'.
-   If 'linkname' is zero, return zero.  */
+/* If LINKNAME is a relative name and NAME contains one or more
+   leading directories, return LINKNAME with those directories
+   prepended; otherwise, return a copy of LINKNAME.
+   If LINKNAME is NULL, return NULL.  */

 static char *
 make_link_name (char const *name, char const *linkname)
 {
-  char *linkbuf;
-  size_t bufsiz;
-
   if (!linkname)
     return NULL;

@@ -3212,15 +3209,15 @@ make_link_name (char const *name, char const *linkname)

   /* The link is to a relative name.  Prepend any leading directory
      in 'name' to the link name.  */
-  linkbuf = strrchr (name, '/');
-  if (linkbuf == 0)
+  char const *linkbuf = strrchr (name, '/');
+  if (linkbuf == NULL)
     return xstrdup (linkname);

-  bufsiz = linkbuf - name + 1;
-  linkbuf = xmalloc (bufsiz + strlen (linkname) + 1);
-  strncpy (linkbuf, name, bufsiz);
-  strcpy (linkbuf + bufsiz, linkname);
-  return linkbuf;
+  size_t bufsiz = linkbuf - name + 1;
+  char *p = xmalloc (bufsiz + strlen (linkname) + 1);
+  strncpy (p, name, bufsiz);
+  strcpy (p + bufsiz, linkname);
+  return p;
 }

 /* Return true if the last component of NAME is '.' or '..'
--
1.7.10.208.gb4267


>From bcb9078e380d81be62e8df00c45afc2f57392dc2 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Wed, 18 Apr 2012 14:49:22 +0200
Subject: [PATCH 2/3] maint: ls: use stpncpy/stpcpy, not strncpy/strcpy

* src/ls.c (gobble_file): Move a decl "down".
(make_link_name): Do not hard-code '/'.  Use IS_ABSOLUTE_FILE_NAME
and dir_len instead.
Use stpcpy/stpncpy in place of strncpy/strcpy.
---
 src/ls.c |   15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/ls.c b/src/ls.c
index db58192..800f813 100644
--- a/src/ls.c
+++ b/src/ls.c
@@ -3037,11 +3037,10 @@ gobble_file (char const *name, enum filetype type, ino_t inode,
       if (S_ISLNK (f->stat.st_mode)
           && (format == long_format || check_symlink_color))
         {
-          char *linkname;
           struct stat linkstats;

           get_link_name (absolute_name, f, command_line_arg);
-          linkname = make_link_name (absolute_name, f->linkname);
+          char *linkname = make_link_name (absolute_name, f->linkname);

           /* Avoid following symbolic links when possible, ie, when
              they won't be traced and when no indicator is needed.  */
@@ -3204,19 +3203,17 @@ make_link_name (char const *name, char const *linkname)
   if (!linkname)
     return NULL;

-  if (*linkname == '/')
+  if (IS_ABSOLUTE_FILE_NAME (linkname))
     return xstrdup (linkname);

   /* The link is to a relative name.  Prepend any leading directory
      in 'name' to the link name.  */
-  char const *linkbuf = strrchr (name, '/');
-  if (linkbuf == NULL)
+  size_t prefix_len = dir_len (name);
+  if (prefix_len == 0)
     return xstrdup (linkname);

-  size_t bufsiz = linkbuf - name + 1;
-  char *p = xmalloc (bufsiz + strlen (linkname) + 1);
-  strncpy (p, name, bufsiz);
-  strcpy (p + bufsiz, linkname);
+  char *p = xmalloc (prefix_len + 1 + strlen (linkname) + 1);
+  stpcpy (stpncpy (p, name, prefix_len + 1), linkname);
   return p;
 }

--
1.7.10.208.gb4267


>From 219b894de4c366496ffdf3591389de074bfdb2b9 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Thu, 19 Apr 2012 11:32:04 +0200
Subject: [PATCH 3/3] maint: tac: use memcpy, not strcpy

* src/tac.c (main): Use memcpy, not strcpy, since we know the length.
---
 src/tac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tac.c b/src/tac.c
index b50382d..2bf8ad2 100644
--- a/src/tac.c
+++ b/src/tac.c
@@ -664,7 +664,7 @@ main (int argc, char **argv)
   G_buffer = xmalloc (G_buffer_size);
   if (sentinel_length)
     {
-      strcpy (G_buffer, separator);
+      memcpy (G_buffer, separator, sentinel_length + 1);
       G_buffer += sentinel_length;
     }
   else
--
1.7.10.208.gb4267


From MAILER-DAEMON Thu Apr 19 07:49:34 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKpri-0003Hk-AN
	for mharc-coreutils@gnu.org; Thu, 19 Apr 2012 07:49:34 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SKprW-0003E7-Mh
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:49:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SKprR-0006mX-V8
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:49:22 -0400
Received: from mail3.vodafone.ie ([213.233.128.45]:15433)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SKprR-0006mI-OQ
	for coreutils@gnu.org; Thu, 19 Apr 2012 07:49:17 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApMBAKD6j09tTHvx/2dsb2JhbAANNrRQAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBwEBBYgRulSQPQScBY0N
Received: from unknown (HELO [192.168.1.79]) ([109.76.123.241])
	by mail3.vodafone.ie with ESMTP; 19 Apr 2012 12:49:15 +0100
Message-ID: <4F8FFBBA.8010901@draigBrady.com>
Date: Thu, 19 Apr 2012 12:49:14 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: crusade against strncpy/strcpy ;-)
References: <8762cwq8fi.fsf@rho.meyering.net>
In-Reply-To: <8762cwq8fi.fsf@rho.meyering.net>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.45
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2012 11:49:32 -0000

On 04/19/2012 12:15 PM, Jim Meyering wrote:
> strncpy is particularly bad, but even strcpy is best avoided.

Yep, strncpy may not NUL terminate,
so using it is awkward as detailed here:
http://www.pixelbeat.org/programming/gcc/string_buffers.html

stpcpy/stpncpy are appropriate here as the buffer is just
the right size, so you don't waste cycles filling with NULs etc.

Often it's simpler/faster to fall back to memcpy for C string buffers
as I did in buffer_or_output() here:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=b1428e31

patch looks good.

cheers,
Pádraig.


From MAILER-DAEMON Thu Apr 19 08:27:05 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKqS1-0000PA-TV
	for mharc-coreutils@gnu.org; Thu, 19 Apr 2012 08:27:05 -0400
Received: from eggs.gnu.org ([208.118.235.92]:43860)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKqRv-0000Ni-4d
	for coreutils@gnu.org; Thu, 19 Apr 2012 08:27:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKqRq-00041S-8e
	for coreutils@gnu.org; Thu, 19 Apr 2012 08:26:58 -0400
Received: from mx.meyering.net ([88.168.87.75]:46743)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKqRq-00040z-2a
	for coreutils@gnu.org; Thu, 19 Apr 2012 08:26:54 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 43B886009D;
	Thu, 19 Apr 2012 14:26:52 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: =?iso-8859-1?Q?P=E1draig?= Brady <P@draigBrady.com>
Subject: Re: crusade against strncpy/strcpy ;-)
In-Reply-To: <4F8FFBBA.8010901@draigBrady.com> (=?iso-8859-1?Q?=22P=E1drai?=
	=?iso-8859-1?Q?g?= Brady"'s message of
	"Thu, 19 Apr 2012 12:49:14 +0100")
References: <8762cwq8fi.fsf@rho.meyering.net> <4F8FFBBA.8010901@draigBrady.com>
Date: Thu, 19 Apr 2012 14:26:52 +0200
Message-ID: <87aa27q54j.fsf@rho.meyering.net>
Lines: 19
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2012 12:27:05 -0000

P=E1draig Brady wrote:
> On 04/19/2012 12:15 PM, Jim Meyering wrote:
>> strncpy is particularly bad, but even strcpy is best avoided.
>
> Yep, strncpy may not NUL terminate,
> so using it is awkward as detailed here:
> http://www.pixelbeat.org/programming/gcc/string_buffers.html
>
> stpcpy/stpncpy are appropriate here as the buffer is just
> the right size, so you don't waste cycles filling with NULs etc.
>
> Often it's simpler/faster to fall back to memcpy for C string buffers
> as I did in buffer_or_output() here:
> http://git.sv.gnu.org/gitweb/?p=3Dcoreutils.git;a=3Dcommitdiff;h=3Db1428e=
31
>
> patch looks good.

Pushed.
Thanks for the review.


From MAILER-DAEMON Thu Apr 19 11:59:14 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKtlK-0004SB-5y
	for mharc-coreutils@gnu.org; Thu, 19 Apr 2012 11:59:14 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40028)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKtl8-0004ML-FE
	for coreutils@gnu.org; Thu, 19 Apr 2012 11:59:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKtl3-0004Li-G2
	for coreutils@gnu.org; Thu, 19 Apr 2012 11:59:02 -0400
Received: from mx.meyering.net ([88.168.87.75]:47392)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKtl3-0004LY-5C
	for coreutils@gnu.org; Thu, 19 Apr 2012 11:58:57 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id E6CF260244;
	Thu, 19 Apr 2012 17:58:54 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Subject: Re: [PATCH] refactor expensive code in misc/stty [was: amendments to
	backtick-removing series]
In-Reply-To: <4F83F9E3.3090800@bernhard-voelker.de> (Bernhard Voelker's
	message of "Tue, 10 Apr 2012 11:14:11 +0200")
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
	<87mx6rwm58.fsf@rho.meyering.net>
	<4F7D438A.7050609@bernhard-voelker.de>
	<87ty0ytxnq.fsf@rho.meyering.net>
	<4F7D717A.4060700@bernhard-voelker.de>
	<8762ddrjpl.fsf@rho.meyering.net>
	<4F83F9E3.3090800@bernhard-voelker.de>
Date: Thu, 19 Apr 2012 17:58:54 +0200
Message-ID: <87wr5bn269.fsf@rho.meyering.net>
Lines: 147
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2012 15:59:12 -0000

Bernhard Voelker wrote:

> On 04/05/2012 10:45 PM, Jim Meyering wrote:
>> Bernhard Voelker wrote:
>>> What about the following?
>>
>> It's already an expensive test, but even so, adding four $(...) subshell
>> invocations in an inner loop that is run ~2-3000 times seems like it
>> would have non-negligible cost, especially on systems where subshells
>> are relatively expensive.
>>
>> I guess I prefer the original eval-using code,
>> if you can find a way to make it work.
>
> ah yes, the subshells are silly. I just removed them.
> The time for this test is now down from 13s with the
> original master version to 8 seconds.
>
> I kept sticking to replace the eval-using code because - as
> the variable store is now used from 2 test files - I liked
> the idea that the "how the REVs are stored" is encapsulated
> centrally in the 2 new shell functions in init.cfg.
>
>> BTW, your patch below was corrupted because something
>> along the way converted non-leading TABs to spaces.
>
> Argh, it wasn't Thunderbird this time. I copied the patch from
> an xterm, and during this, the TABs in Makefile.am have been
> replaced (see also [1]). xclip is doing better.

>>From f71ed9ae1a9699e000a98c26dae4db96a628d657 Mon Sep 17 00:00:00 2001
> From: Bernhard Voelker <mail@bernhard-voelker.de>
> Date: Thu, 5 Apr 2012 08:01:43 +0200
> Subject: [PATCH 1/2] tests: add iutf8 option to misc/stty
...

Oops.  This slipped off my radar.
Sorry about that.

The comment below wasn't quite right and I'd rather not
use REV as a global variable.  Too short.
Similarly, I've renamed the function names slightly
and added a trailing underscore to each.  The trailing
underscore is probably not absolutely necessary (and we haven't
been very consistent about that), but it's a good practice.

Here are proposed incremental changes:

diff --git a/tests/init.cfg b/tests/init.cfg
index 08645d1..2e43c16 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -241,26 +241,26 @@ rwx_to_mode_()
   echo "=$u$g$o"
 }

-# Return the reversible settings from stty.c.
-# Fill the variable REV which is needed by stty_reversible_matches.
-stty_reversible_settings()
-{
-  # Pad start with one blank for the first option
-  # to match in stty_reversible_matches.
-  REV=" "$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
-      $abs_top_srcdir/src/stty.c | tr '\n' ' ')
+# Set the global variable stty_reversible_ to a space-separated list of the
+# reversible settings from stty.c.  stty_reversible_ also starts and ends
+# with a space.
+stty_reversible_init_()
+{
+  # Pad start with one space for the first option to match in query function.
+  stty_reversible_=' '$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
+    $abs_top_srcdir/src/stty.c | tr '\n' ' ')
   # Ensure that there are at least 62, i.e., so we're alerted if
   # reformatting the source empties the list.
-  test 62 -le $(echo "$REV"|wc -w)  \
+  test 62 -le $(echo "$stty_reversible_"|wc -w)  \
     || framework_failure_ "too few reversible settings"
 }

-# Test if $1 is among the reversible stty options ($REV).
-stty_reversible_matches()
+# Test whether $1 is one of stty's reversible options.
+stty_reversible_query_()
 {
-  case "$REV" in
-    "")
-      framework_failure_ "stty_reversible_settings() not called?";;
+  case $stty_reversible_ in
+    '')
+      framework_failure_ "stty_reversible_init_() not called?";;
     *" $1 "*)
       return 0;;
     *)
diff --git a/tests/misc/stty b/tests/misc/stty
index 10aaa0a..ae65656 100755
--- a/tests/misc/stty
+++ b/tests/misc/stty
@@ -24,7 +24,7 @@ require_controlling_input_terminal_
 trap '' TTOU # Ignore SIGTTOU

 # Get the reversible settings from stty.c.
-stty_reversible_settings
+stty_reversible_init_

 saved_state=.saved-state
 stty --save > $saved_state || fail=1
@@ -58,7 +58,7 @@ for opt in $options; do

   # Likewise, 'stty -cread' would fail, so skip that, too.
   test $opt = cread && continue
-  if stty_reversible_matches "$opt" ; then
+  if stty_reversible_query_ "$opt" ; then
     stty -$opt || { fail=1; echo -$opt; }
   fi
 done
diff --git a/tests/misc/stty-pairs b/tests/misc/stty-pairs
index 81ee46b..e59da04 100755
--- a/tests/misc/stty-pairs
+++ b/tests/misc/stty-pairs
@@ -26,7 +26,7 @@ require_controlling_input_terminal_
 trap '' TTOU # Ignore SIGTTOU

 # Get the reversible settings from stty.c.
-stty_reversible_settings
+stty_reversible_init_

 saved_state=.saved-state
 stty --save > $saved_state || fail=1
@@ -45,14 +45,14 @@ for opt1 in $options; do

     stty $opt1 $opt2 || fail=1

-    if stty_reversible_matches "$opt1" ; then
+    if stty_reversible_query_ "$opt1" ; then
       stty -$opt1 $opt2 || fail=1
     fi
-    if stty_reversible_matches "$opt2" ; then
+    if stty_reversible_query_ "$opt2" ; then
       stty $opt1 -$opt2 || fail=1
     fi
-    if stty_reversible_matches "$opt1" \
-    && stty_reversible_matches "$opt2" ; then
+    if stty_reversible_query_ "$opt1" \
+        && stty_reversible_query_ "$opt2" ; then
       stty -$opt1 -$opt2 || fail=1
     fi
   done


From MAILER-DAEMON Thu Apr 19 13:03:58 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKuly-0004Ko-Q5
	for mharc-coreutils@gnu.org; Thu, 19 Apr 2012 13:03:58 -0400
Received: from eggs.gnu.org ([208.118.235.92]:42604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SKulo-0004JT-7D
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:03:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SKule-00048b-5v
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:03:47 -0400
Received: from moutng.kundenserver.de ([212.227.17.8]:49576)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SKuld-00047C-Sp
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:03:38 -0400
Received: from [192.168.2.108] (p4FF75669.dip.t-dialin.net [79.247.86.105])
	by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis)
	id 0MbF3n-1SfTl10jdb-00Kiar; Thu, 19 Apr 2012 19:03:32 +0200
Message-ID: <4F904563.9090906@bernhard-voelker.de>
Date: Thu, 19 Apr 2012 19:03:31 +0200
From: Bernhard Voelker <mail@bernhard-voelker.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120328 Thunderbird/11.0.1
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH] refactor expensive code in misc/stty [was: amendments
	to backtick-removing series]
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
	<87mx6rwm58.fsf@rho.meyering.net>
	<4F7D438A.7050609@bernhard-voelker.de>
	<87ty0ytxnq.fsf@rho.meyering.net>
	<4F7D717A.4060700@bernhard-voelker.de>
	<8762ddrjpl.fsf@rho.meyering.net>
	<4F83F9E3.3090800@bernhard-voelker.de>
	<87wr5bn269.fsf@rho.meyering.net>
In-Reply-To: <87wr5bn269.fsf@rho.meyering.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Provags-ID: V02:K0:xXAWSiHmtRkHuV1Z5ZO/Tg+clmly6xFmn2npjB9BfpG
	Cdq1Gg3X8B0Eu43hpHKl+MgdRZOb5zkKO1CX7hqTC6RZT3nkeZ
	bRSa5NqRCQzGtDrce/zG1Jwtu8CULy7lY0j1sgwvJr+lJEYM4m
	kFrhNripNg85xv/5v+2Voep2wqVrrHPg5gf8iqvWV9WByoci64
	jhq3ga3OimZj4+o2NAZdlaK9fHtUPDAlWiwRwB1r9jyOIJbsrE
	ZPQp/FyR78NOrXzuxfZrHfcw/Q+hzJ9Px8rnsSg6Vm9nzyU9va
	AKanaI3JJ6vOmgjyjX5eEgqJSZ551LdYP7D+klckhzYgVb3Pee
	IayE8j9D97MbygVmW3oZj11+KkijpDIWMN+pSczbY
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 212.227.17.8
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2012 17:03:56 -0000


On 04/19/2012 05:58 PM, Jim Meyering wrote:
>> >From f71ed9ae1a9699e000a98c26dae4db96a628d657 Mon Sep 17 00:00:00 2001
>> > From: Bernhard Voelker <mail@bernhard-voelker.de>
>> > Date: Thu, 5 Apr 2012 08:01:43 +0200
>> > Subject: [PATCH 1/2] tests: add iutf8 option to misc/stty
> ...
> 
> Oops.  This slipped off my radar.
> Sorry about that.

no worries - I'm glad you liked my idea to use a shell's
case statement in a reverse way ... for the reverse options ;-)


> The comment below wasn't quite right and I'd rather not
> use REV as a global variable.  Too short.
> Similarly, I've renamed the function names slightly
> and added a trailing underscore to each.  The trailing
> underscore is probably not absolutely necessary (and we haven't
> been very consistent about that), but it's a good practice.

thank you, good idea.

> Here are proposed incremental changes:
> 
> diff --git a/tests/init.cfg b/tests/init.cfg
> index 08645d1..2e43c16 100644
> --- a/tests/init.cfg
> +++ b/tests/init.cfg
> @@ -241,26 +241,26 @@ rwx_to_mode_()
>    echo "=$u$g$o"
>  }
> 
> -# Return the reversible settings from stty.c.
> -# Fill the variable REV which is needed by stty_reversible_matches.
> -stty_reversible_settings()
> -{
> -  # Pad start with one blank for the first option
> -  # to match in stty_reversible_matches.
> -  REV=" "$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
> -      $abs_top_srcdir/src/stty.c | tr '\n' ' ')
> +# Set the global variable stty_reversible_ to a space-separated list of the
> +# reversible settings from stty.c.  stty_reversible_ also starts and ends
> +# with a space.
> +stty_reversible_init_()
> +{
> +  # Pad start with one space for the first option to match in query function.
> +  stty_reversible_=' '$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
> +    $abs_top_srcdir/src/stty.c | tr '\n' ' ')
>    # Ensure that there are at least 62, i.e., so we're alerted if
>    # reformatting the source empties the list.
> -  test 62 -le $(echo "$REV"|wc -w)  \
> +  test 62 -le $(echo "$stty_reversible_"|wc -w)  \
>      || framework_failure_ "too few reversible settings"
>  }
> 
> -# Test if $1 is among the reversible stty options ($REV).
> -stty_reversible_matches()
> +# Test whether $1 is one of stty's reversible options.
> +stty_reversible_query_()
>  {
> -  case "$REV" in
> -    "")
> -      framework_failure_ "stty_reversible_settings() not called?";;
> +  case $stty_reversible_ in
> +    '')
> +      framework_failure_ "stty_reversible_init_() not called?";;
>      *" $1 "*)
>        return 0;;
>      *)

You removed the double quotes around the case variable.
For whatever it is good for, I'd have a better feeling if they were
there ... imagine something goes wrong during the perl processing.
Maybe that's only my paranoia ;-)

Apart from that, it looks good.

Have a nice day,
Berny



From MAILER-DAEMON Thu Apr 19 13:33:38 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKvEf-0004x1-Uy
	for mharc-coreutils@gnu.org; Thu, 19 Apr 2012 13:33:37 -0400
Received: from eggs.gnu.org ([208.118.235.92]:36646)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKvEa-0004v6-AH
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:33:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKvEY-00066j-IU
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:33:31 -0400
Received: from mx.meyering.net ([88.168.87.75]:47651)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKvEY-00064y-A8
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:33:30 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 8814C600B8;
	Thu, 19 Apr 2012 19:33:28 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Subject: Re: [PATCH] refactor expensive code in misc/stty [was: amendments to
	backtick-removing series]
In-Reply-To: <4F904563.9090906@bernhard-voelker.de> (Bernhard Voelker's
	message of "Thu, 19 Apr 2012 19:03:31 +0200")
References: <87d37ny8q7.fsf@rho.meyering.net> <m2iphfvfbt.fsf@igel.home>
	<874nszy67m.fsf@rho.meyering.net> <m27gxvvbdz.fsf@igel.home>
	<87sjgjwpor.fsf@rho.meyering.net>
	<4F7C5F28.3080605@bernhard-voelker.de>
	<87mx6rwm58.fsf@rho.meyering.net>
	<4F7D438A.7050609@bernhard-voelker.de>
	<87ty0ytxnq.fsf@rho.meyering.net>
	<4F7D717A.4060700@bernhard-voelker.de>
	<8762ddrjpl.fsf@rho.meyering.net>
	<4F83F9E3.3090800@bernhard-voelker.de>
	<87wr5bn269.fsf@rho.meyering.net>
	<4F904563.9090906@bernhard-voelker.de>
Date: Thu, 19 Apr 2012 19:33:28 +0200
Message-ID: <87lilrmxsn.fsf@rho.meyering.net>
Lines: 35
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2012 17:33:36 -0000

Bernhard Voelker wrote:
...
>> -  case "$REV" in
>> -    "")
>> -      framework_failure_ "stty_reversible_settings() not called?";;
>> +  case $stty_reversible_ in
>> +    '')
>> +      framework_failure_ "stty_reversible_init_() not called?";;
>>      *" $1 "*)
>>        return 0;;
>>      *)
>
> You removed the double quotes around the case variable.

Yes.  That was deliberate.
There is no need for double quotes there,
and in fact I consistently avoid them when the "case"
argument is a simple variable reference, since
they serve no purpose in that context.

Hmm... speaking of consistency,
git grep 'case "\$[a-z]*"' prints 16 lines.
Though that doesn't count things like case $(...),
which don't need double quotes, either.

Contrast that with the 124 matches for this:
  git grep 'case \$'

> For whatever it is good for, I'd have a better feeling if they were
> there ... imagine something goes wrong during the perl processing.
> Maybe that's only my paranoia ;-)
>
> Apart from that, it looks good.

Pushed.


From MAILER-DAEMON Thu Apr 19 13:42:54 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SKvNe-0000R6-MZ
	for mharc-coreutils@gnu.org; Thu, 19 Apr 2012 13:42:54 -0400
Received: from eggs.gnu.org ([208.118.235.92]:41500)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKvNb-0000Pu-QY
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:42:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKvNY-0000le-CH
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:42:51 -0400
Received: from mx.meyering.net ([88.168.87.75]:47690)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SKvNY-0000jh-5a
	for coreutils@gnu.org; Thu, 19 Apr 2012 13:42:48 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 70A5160081
	for <coreutils@gnu.org>; Thu, 19 Apr 2012 19:42:45 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH] doc: fix a grammar nit
Date: Thu, 19 Apr 2012 19:42:45 +0200
Message-ID: <87fwbzmxd6.fsf@rho.meyering.net>
Lines: 27
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2012 17:42:53 -0000

FYI,

>From 6539e15620a863266b7babfa5f6f02f1bb66762e Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 16 Mar 2012 08:31:28 +0100
Subject: [PATCH] doc: fix a grammar nit

* doc/coreutils.texi (split invocation): s/are/is/ in "P or Q are".
---
 doc/coreutils.texi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index 416f0ba..4fb52cb 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -3097,7 +3097,7 @@ split invocation
 Use suffixes of length @var{length}.  If a @var{length} of 0 is specified,
 this is the same as if (any previous) @option{-a} was not specified, and
 thus enables the default behavior, which starts the suffix length at 2,
-and unless @option{-n} or @option{--numeric-suffixes=@var{from}} are
+and unless @option{-n} or @option{--numeric-suffixes=@var{from}} is
 specified, will auto increase the length by 2 as required.

 @item -d
--
1.7.10.208.gb4267


From MAILER-DAEMON Fri Apr 20 12:55:38 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SLH7S-000290-Os
	for mharc-coreutils@gnu.org; Fri, 20 Apr 2012 12:55:38 -0400
Received: from eggs.gnu.org ([208.118.235.92]:41750)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bob@proulx.com>) id 1SLH7P-00028I-Jg
	for coreutils@gnu.org; Fri, 20 Apr 2012 12:55:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bob@proulx.com>) id 1SLH7N-0007xw-Fs
	for coreutils@gnu.org; Fri, 20 Apr 2012 12:55:35 -0400
Received: from joseki.proulx.com ([216.17.153.58]:34527)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bob@proulx.com>) id 1SLH7M-0007x3-Sf
	for coreutils@gnu.org; Fri, 20 Apr 2012 12:55:33 -0400
Received: from hysteria.proulx.com (hysteria.proulx.com [192.168.230.119])
	by joseki.proulx.com (Postfix) with ESMTP id 19210211D6
	for <coreutils@gnu.org>; Fri, 20 Apr 2012 10:55:30 -0600 (MDT)
Received: by hysteria.proulx.com (Postfix, from userid 1000)
	id D41F12DC40; Fri, 20 Apr 2012 10:55:29 -0600 (MDT)
Date: Fri, 20 Apr 2012 10:55:29 -0600
From: smlacc1 leador <smlacc1@gmail.com>
To: coreutils@gnu.org
Subject: problem with test suite on coreutils 8.16
Message-ID: <20120420165529.GA2203@hysteria.proulx.com>
Mail-Followup-To: coreutils@gnu.org
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ew6BAiZeqk4r7MaW"
Content-Disposition: inline
User-Agent: Mutt/1.5.21 (2010-09-15)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2)
X-Received-From: 216.17.153.58
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2012 16:55:36 -0000


--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

Im having a problem building coreutils 8.16 on an arm processor.  It
fails "make  RUN_EXPENSIVE_TESTS=yes check" on cp/parent-perm-race.
Is this an expected fail on arm?

The test-suite.log is attached.

Thanks.

--ew6BAiZeqk4r7MaW
Content-Type: application/octet-stream
Content-Disposition: attachment; filename="test-suite.log.gz"
Content-Transfer-Encoding: base64

H4sICMKUkU8CA3Rlc3Qtc3VpdGUubG9nAOxda3PiuLb9fP0rdObMLebcjgmvhIS6OXXTCUlI
k8cA6SRdp4pyjAB3jE37kUB+/d2yjbGNTJCx05DS1FQHy1trS9qyrLUkwdERy38CQuj8+g7J
uoFtS1FNdJAv7teQhU3L3CX/iqatWDiv6gPhiA1a+Cfq3HSOmzVUqVbh4va43a4hVCkcwkX7
W+MWLvbJjYez4wZYFeCj+wkVSaprT1LrrdZNi3wU8nkoqmZhzTJrNVTr4bE1rKGSILh4lqSo
YmlX0XRL6U9FQ5KxsKSAX74gRVMsRVK78muve7Rr6bpq7hrj0ZOtqL3dr3eN5umu3zYiaRun
UUyStQ/Ojgrw6YvTXD3F6I4N3FcmXSdtbCia1UcDi9iO+5PukfPxCxo9W3g07nXR6u4ARQxW
Kv8A/zlgsmRi9Oc/oR7OZc8rCFtVSAVGY1WyMClkjKer44dup9Wot7tHlYDrmcdZCdxUH89L
/oJszcQW6lzdnjZaborbDkjsIdFC4jiV5ugxVHw3ivLr7uwsWLNZlYg1KWYK0F8QPGJib6Cn
A2YZqI1Et7thY2Qe5XrG60R0/kMl8qjto+OxgUoFVKzUKgfres0FmsdxGGqiAjpC7vOA5WEq
NUQGtmyDuHA8dBm7dhwuktMIJhqoXTJ8dM1hV1O7RzmBNA9qnLWPcui/3Iu+biBTGZDHABUh
ImVUhP/33EaaQGSK6Asqlg6ILX6RVJSzDGmMcv/J5eoTxYJbh+QzKrot797078A4uYqP0js+
ygXHR2nRB9yBwXUVH+X3fBQdH2WKjyIkr9ZW7zmpuE6KFC9wC9JXc7P3npuy62aP4qacc7Hc
VAOP9BfctUbjLnky0FiyhuQlMcYajP/5/K5pyIL39BRR7h/QcXwzp6/7Jt4zN7vhPneM/XgG
xvJ8ut6lJ7M7LxRDRrfYoexO0WEy0LlYGajGavikaDX3H9s03A+mf0k+kaIZmLyg8ATDA6yM
zC5irlf9oV5/6LgVckcqJ3wA17cEf1D0wwq9Szcsp+qCNz/ovmBoETJtmdlPsQnDKPwLCaou
Q/dTBLfTKqTH5v78nxyB0l6cXEgUAcFUdE1wLv8KTeb+5czmhBN9PDWUwdBCf538C94FxRI6
MzBGbb1vvUoGRme6rfUkC1B2UEOT80JTkTG8r9H5bfOl/KXmTBHhM/J8wTMD5SHvdwP979Cy
xrXd3YFm53VjsKu6WWHUHKv5oTVS/50XOkMF3hQm6hOvpue1hqa6jYh7J9nSkTyUtAFGktaD
1uwppmUoT7aFkWIRCAyWgHF9g+6PW63j687jDslkDTE0LJkROq9AxbJwDz1NoXSveUG4N0iC
RhJuJVtFLRuCv4NOpRelh64k+RvW3hQMtZY01JQ0GaOONFV1Y0cgpbhURugKTzFEapCHVofq
T6HDwNNrKvBYz0IGY4ETYzdo5rMCT3uO2CLftoagPtKT6path/tQGMttFwcC/oYz7EA7QcXJ
DUpOaA8dGbZGLCRt+ipNd6DJSMJIesbQkFh+Rq+KNXSap3V33f1ebz126w+39et243u926m3
O20BepFi6NqINN6LZCjEDSLTNGhXqEweoXp+kN8RgCWQDheHc0T67NyxIEDnsKH3EN/mELq8
bAOkZAwAWe87yZY+VvELViEGzzBlVrHjZI5BevVU9FuDvEwRdBoNGjb4Kq45rT2GtiGtWEO8
0dNudHeggzmNO8p5pCb33+Z/tByPxUfGgrf1R7X1bFw/hBdxiXf63zsAmdAExV/wwZlgV6tO
koW+YGdCNUuafwpMueGq2zWtIyddVrGk2U5iTWCcORP74UjvIbGF7C/AsNdnj8gYIdHopwA0
q7ongRmjXZgOlUWYDPWFrRe9/Kpkq3hR3GyY3EUpIavWNYeQ356H6Qldi7hJVS4aUsYSV9hl
hvoWpfXXF7cWQNmVrUUILmtxWYvLWlzWWlvWMkbsohaZFvmSFlxwQSuZoNVSwLkBSXnUtiRV
HUka17Q2VtPyX8KcT/5eQYsH4oMCwRt6E6QsHgWuY63BFZOJWAsoEQVLHg6M8e6TZCqysO36
lVOLbLWriIsN060ipWPVrNzsnfrefnp6VRgzqVYVRWHUqQ4Tu8tQo4q09vr6VAiQXZsKZ+e6
FNeluC7Fdam1dSlngsEuTTnZAuqUe80FqliBKiJKIZr8ZOBftmLg7giPnqCqQ2UMg3zXetW7
A0O3x2ZXCL/YkJt8VCwUKrOO8cefbuIfbtfwxCoPGeb2PjQJKEB7GILlExjf1hpKltNKT1Bc
LyeZ9Y8gwOSmhnQNu/l3BGgqQmM0qApSekCnxPP/IAy8BfKQeSY0CwStT0KNftrgBvICK2n0
HQ/wPKjqVCDhCHoC/zDDB+N5QXdIk2seRZoXmjAk4eSmVb/rNJrt7nnr5u627ZAKqCZ4MFCQ
IXmBM8eSjEUTjyVDInFTIegCuHU8IU0aQSNAoTXbabMoh4p6OyIjM5Alw4Sx0dBHzkAd5FIB
jct5mUd5Jg/ShgRpuSy2EbFDPHKLkeOR+U2RCYYlFJN3JDcesM0dBD+DRhfkzMn0uRDC4u4y
0l9ETGZ+AvVQ5fx+jZzVNJWeM9mDQozGu/l3bi+5/yIZjg3UQoS/+cPzh4H+bXX7r9NOr4BX
t3+7H54Ze6vbD160Xo/B/vb0XO38Wt2+cGO3zxqr27/aUtOur26vPFSUA52hPS/Mn6cM7Vl4
at489hjKc3N+83bxvj1LnzG1x+r54+r2o9dm/StDHavqpF8Yrm5/YL9Nygwxsob73x9/rm7f
/r532bhd3f7vVuFx8rC6/WXp0txnqG/z/nR6xdAH1De92VRWty+39+97bYZnpPTQfCuubq/9
0ut3DPY/nop7LwxjlPHzRakz9M+TQm9waTHEq34gPzP0h6cGntQZxoTe+PtEYbC/vDkuNhna
R6pOi9Pj1e0b3y8eHw5Xt69M9LepyVD+9vTpb4bx4Vw+u5Hk1e2v28bL7RlD+xyftTs/GMbY
kxPbemIo/0nn8ivDOw53CjeTFfoDwxBef/36fM/Q5OWmajZaq9t/e6t/ezBWt+/Uy4cFieE1
+PB2MmF4BE/vX3uTc4YhYa/140Vb3R46zOszwytFN3+Yd98ZpgnDc3vvgqHLGMpbh+ERPL8/
fpEZuqRx8vPH/eXq9kOrcHDJMO2aDi9fVYb+c9dvmQ2GV+KBcV/9+vfq9mOz9Ni4Wt3+199X
w4s+Q/9s9X5WCwzlfz2RWaZUj8VJVZ9G7G21p+Us1FeAr0qI7MBAmg6s9VVzpWjglALhlpI2
ne3Z6Ouqqr8SFz1gz7KlGwo2a8AWiTffLXKWLOCDkM/nTX3H5ekkl89mI981I5lAKi1h+79f
xq1ItnsVoj42bLNCtHisuxW8/N/aX+vpbVeIgCbdr7AAk/GGhZk/8Ws9wx0L0RZff8tCGJF9
z0IkP9+0wDct8E0LfNMC/44Y/h0x/DzNR52ncV/CfFP77z1Mw6PwEVHgrfzbj9HwEPAzNIn4
YbIF+jAE9fSM10tETRd7MCnqC8u/qXmrhKpo3bKVrOK9bZh4FV9QVhlrAWm/0S+kJ2jFwieV
tpYAsolce4U0PGcod8VHZn3hKw6bXQKLReJiGBfDuBjGxTB+goef4OEneLbuBE/0vc4P82zl
YZ5NCyM/jEAJIg/S9h7x4bHjp30+SE2ModrJdMU4sBiFkSorbp2W+AEC4marhmtKhST7+d1A
T1MfDGImFwXDKJkrgTN3mcp/odZOQ/MLACYR+oLZubrH1T2u7nF1j6t7XN3j6t4Wqntc0tte
SY/LDJuq4/HIbJl4xwPGFbssFbs5Z04q0wUQqNqcposTYcuVOVKHbIW5sIcN0+XChWOV5Zzc
B8+P7fRUuRBkUlEuApKxJjfzJmYoyYVben1FLojHLsiFcnM9jutxXI/jehzX47gex/W4rdPj
yLucy3FbKcdtQui4hEAJHA/MdolxPF5ci8tQiwvQ5WRSXBCAqsSNdVOZiBef4OvhvJpkK8kt
ONkwVW6hfKzC3Azg6tyU0tPmoqhBZS2pVLdQ0iwUuqCTDEW6hbqsr9NFINmluigAV+u4WsfV
Oq7WcbWOq3Vcrds6tc57nXPBbisFuw2JHpcaKLHjsdk62Y6HjCt32Sp3YfacTLyLYFD1OwPL
tmHiT6DfeTXJVr9bcLJh+t1C+Vj1uxnAqzU4SE+/i6Kmod8tlDQL/S7oJEP9bqEu6+t3EUh2
/S4KwPU7rt9x/Y7rd1y/4/od1++2Tr/zXudcv9tK/W5DoscFB0rseGy2Tr/jIeP6Xbb6XZg9
J9PvIhgR/W6kmPKuiX+Jqq4NxJ5uP6lY+DS/gRGpWLaqXqyzDVP3YsvJqvJFgQ7vLq7SU/vi
0JMqffF4GZ+vpTnOUAWMjcr6amAMNLsqGAfE1UGuDnJ1kKuDa6uDMMCwa4OQKaAMkiuuC8bq
gneqochDdAqPHhgSFXCALVWBHETuC1wJ3jN/cnHc6sJU6Ki0t+de3Jw1b+7hch+1/ZvFUtW7
cu/CqDG727g+EueXd85tSDhEdyHouyj2Ravj3CyXqvtV99K9SxIOvPsEPHDtoZOUQ9S4dgFK
xUq1clDer1SdJM/FLPHAtSNAkTQPzE+FEs8gK6XDyuF+tXS456a5mH7qPmreXJ9HnTtpC95d
y4h7J5Hi34cNFiCAGyhBu/GjHjV10hYtfdNAYdsB20DBPNtIcd3UxfJ2Glf17kIQvNQF7Jl1
BNxLpkXjtEsJx2mXEo9zmu053fbWtw0U+jZgGyicZxspspu6WOKbszMP+bBUKperpUJ5/2Cv
Uq3uHRSq3l3XxeL9g1lu4iv+tud00cB5HgiliXPv3Y73P8sfVwDv/pIS3AWKUDyoVParlUqh
Wq4WDvf2ivvFPd/AG0QWTfbRWdNtg2K+WN2rHFawWD5wE8lYka8USgelMv4Ciadfm45lKV8q
7RWqxLLgpRL/+eohjBLEFFKbdOMm1ZqMk8Gxy7/2Ry+SEhoc5wn++Biw8YbIecp8lCRpd1Fn
dxRvoeHSTwmMmHMrf9D0k4LjpjN1Xxg6Z6nRJ8C3Dj8Cs+SFZ8Ap/uIw6idHn0ZygzKY+sm0
8tCGVD+dXiLKwDpPp5WJMrz6yVR7yiA7T6fVgjrUzm9Q60EdcAM3aH7ow27gTkwMFwfUeTqt
Bc5jcpzH5qANxPN0Wl2ow/H8BrUmSwfluUHsuBjAiBkZ5xbxY6P3wCwZoAMWS8vyzjAdMFle
mvcG66BN/HhNrGhDtp8eGbVJOnUs9m/QRuNmbJa4EdwlGcF+BVSGcJWBLCPRtHpHMJU/PESi
jIjikZcF90+tXNurIWwYulED9vyGHRXeMKQpyvV1PUcm58CeYOJtDPB8QTywdGBrJtI1dQr/
IHNqWnhkuj9lPVCVJ9mZ9xNXyNVY0D+OvE+B5dyIDhNdyUjJ2fJFyY8oQ/Y+3lkq+piG/gxL
HnRpMNnSRwwWbQlEMuShsN2LHaQK2a5whD1s2LJGuHCsaxlO7sfp/U16CxghyKSrFhEQxqWK
YlJvGa5PhFt6/UWJIB77SkQoN19+4MsPfPmBLz+svfzgzCaY1x9IrsAChHO5uAKxt7gAUeAb
k10338C9in5Iz8FdyST2lh8Th0cdaXooBn/8+X9/+EzlD/Snm2Vs6ANDgneftyfZechyBKeG
NN1CjlVOiCT4PtyQL/SB8M7mHvK8/AXBDYD6FM1Fp+4wi8+7nHElgGTO8g4fSlSrz0BvAvON
ZJwmCEAjMkpPlHXNgkdI+Aw7uObVyZba0PxsGMGhFZGV5gQw7i5bt+mRHQpwUspDhWIkPqX1
fGZIf2gRWJ8ELaKyUyEKBidEnBBxQsQJ0dqESOmx0yFyssEnQ3DBN2PFcqFjQ9PVHmrpTxB5
0/ESoUdBQmRiVdFsMmFDA3hSyeqEk9A3/8yhXZh9y7t9RcXe6kNk7clNhSLIzyZq15skIzLt
MQl8gLbMXybUtY73UJYTmLXA18gcJTU+IUmzfFtNbxbmEMlIziIM9dgKtJf4hDUosWQ8iwZ0
e3205PDKdh5hoVUy44Msy11u2nGW5aVlPtRChbstfD1O8WjLUh9pfK3NO7VYhUKVU3OZ5WGX
5fVM4cjLMgcJDr4sheN0i9MtTrc43Vr/+Etgsspw/oWABQ7AkEtOumJJ15XyjNGFhA0Lq46P
W8lWUX0wgBRCt6BuU+gN8GiaCjyzs3jAg+4EMLQaRGyRb1tDUFjpSXUd93AfgC230g4E/A1n
2IFGgFqRG5ScUFmdbCwjFpI2fZWmO96p/vmZeXePGal76+66+73eeuzWH27r1+3G93q3U293
2kLwWP+LZCjEjcNQoNGgMtFD+3E4ZF0sdFgfIm+b2P2agCH0OdkGSLLr0SJbIkmypY9V/AKt
fAXZCDV1nMwxSJedin5rBL+whvrCjbIy3vppt/47Wz55UD4+KLzRP7zR39sUzCPyO8amT7FL
egmPTLhXehlirPom6yNgH6YpkpmW8Ol0t1D1PkB0i/G3iYpbTFETyW1hrF8nF+WUtTa6g7XE
tThIxo0K5XR8Zy2xxUQoJX2Nip5QXKNjcWWNK2tcWePKGlfWuLLG+VN6ylrobcup6wbIajwi
H62p8RbfKEGNh4OraWkRxzWkNCpcrI5mjhUNppDPovRkm1j4fDvYwhX8ACktzuEmamlxZU0k
pkXATi46VspqWoyHteS0WExGPa2SkvOsBbW4KKWkqNHhE0pqMWBcU+OaGtfUuKbGNTWuqXEW
lZ6mFn7dcga7AaIaD8mHq2q8yTdLVuPx4LraJDX2uIawRseLV9YsScWiNYTpbk8c4c95PjRa
yY/Q12JdbqTCFlvaZBpbFG7/yUz7fGisj/V0tnjUD1HaaO4z19pio5WW2hbjIKneFgfHFTeu
uHHFjStuXHHjihvnVykqbpEXLme3m6C58aD8BtWNN/qm6W48Ilx5S6i80XnkOtpbDCJVfbMk
S9QkTTexrGs9U1iqueV3qZlqSFU0jIqHtcD0tQYTztGIzKjI14P3yVxyyzS7SC0zlutivW2a
UhdbUGaRLoo0uXs7T1Gfi4NPLM3FA2atytE8ZynIxUYmBS0uBjuBDBeHxBU4rsBxBY4rcMkU
uM6Po7vOSSC984Pk0W3yuz89lCseVgtioQj/o+JBrVKulcv5Qqlc2duvHsCj/yy47xexb6uq
aCkjPPsG50VrXzpyvnGYzHxnXzvc02EWTSZO3jcOw98n0R3nEMFEMPiNxmZAIlmYky1+p3Eu
oYt3dIAVPCdxDGQ3I+T3GF1mFfoktIX+3k3IWGLAqGTFFgkHELZ/O4BbkYwZRdTJphGJaPmY
+YMHoJxPhinShghqYrawgJM1SQg4zJIbRFs9BUoQhkzABCIAnABwAsAJACcA6y/B2wkW4O3g
8rvNF99X/nVQyu+BOgFY+9dATTv0W6Chy5R/CdR7FaX8Y6DJUJPkeo8bJazep+A9oVlGQroT
xqCxHEuSnd/VUTQ79jsGtozvBKuULemhe9ow5kMvJCv9CaFI/XIrPQ5EhU5KhGLAMmZDC14z
pET0SKzPi2i47OSIisIZEmdInCFxhrQ2Q4LRhZ0iQaYARyJXnCTFkqRLaYqaGJ48yY77zVCn
+SfQ+JM5YTm7aza7t8etTqPTuLnuurMXZ1Leg4mehnsB0hJ8RUSn9ivhLGcva8Kvlf0dPrN2
zT8DsaHMEJKxGxoQleJYUxHrfepCjndv9iussqGMrRm/NNEtNtScCY09xjI8OJL8LMGT9++j
Yr5YDLmwNeWXsABOUr0wK9rAdeFOkUUILJLGwF+hh8AA4Y5gOIQ5kSzLELacizmVyJaERVxs
GPuKlI6VdrnZfxk/HtLjW2HMpEQripIxw5q7y5BaRVp7fU4VAmQnU+HsnEVxFsVZFGdRa7Mo
eYxGL2igaGTvvspOqCD/nE/BBadTsXSqoxtPP3UI1LkhaSpUeCfKqHYc15fKCF3hKYYgDfIx
zQ4xmzc7XPBmX37O9lYynrGxRoPPnpBAs89SeNuzLLO621lhKHNm/GQ8IyMI+S5sbLzgI2ea
g0RtbiGPazDmaYT9zqxc5z1wSqydAps7BAjK6iz8OYfOdNtCLpy3O3IuUfjRWmYekCmc9ChL
XxlkuUaxDnbyvFF1wlMT0ijUVisSwWl2MikihBDRIOTxriSHt5FuGYmH4mdL4UMONozAh8rG
St9J5urt6X565D2ImJS6hzEYifteQmcZ0vZQK69P2gNw7JQ9mJkTdk7YOWHnhH1twk7YOrb6
MLaQyRX5y07aOXv8aPboRWze6pBamyXX0LUO02egRc7ZLsgPfR/Llm5M43b60vHMVfBm+1zB
kMywF4v2/+2dW3PbtrbH3/Up+NCZnJljWrbcNE1mPHPS1End2qm37aSXOTMaWqJkblOkhhc7
2p9+L1ASCYIAKYCATbHroY0lEf+FBZAEfgu3nJKKfUHyUbDt1cTxjbVDipMy42VokBCp56Q2
2uppG0Zx2znchyHcopOjhktU+ioswTdxAs+VTR5SO3Im7qA/W/NWnTNLVnX2OgZadVmV5S6O
1tXlyaU+DKsxoEpltZKGIU1g2yCz1dVQe4QTq8sTXY0WAh4CHgIeAp6GEVkche3gKOwWmxbu
4g7cvwdC8oJx8hSO51GYLuPxoNwUWuuvT4+Pjr7PFwt+t/5ys0SwvMAvtgppUr0gvdEYJFWk
SO6dJCu5OyipTUqyq+ECKp38GFhh4K7THwyg+Mg2jQGZeehNAVvsT/9vuR6UWZR1eqGooCKz
nfKsf6dgBtIeWtb5LLMAj4bvrwakimhLYB+wAy4uMnpAqiHYbAFZZJqMEw0+/H599uX2/OJm
/On69y9XNxnpgJtgIbLoHSA3lRkvoXW1Y3fpRA6pSx9uhAGYzSxZgbOAQoBMB2lWZuwekay1
U/KSTmO4El6TUbjI3tn0XpEUxFYbecGiQ6yxl66x+ohB9yrSwmqsViNWUxeqia6jUgU1RMCw
9vbkXdmHYKOQv9Vij2K5aihy5rkLZ2m7i2WyGvQh/Eg7ZDbwyLfUsZAjP5OywcaSyg9noyt9
YUautGqAUSBmOLRYsWowqMivifbhRJ6ufCCRq4IhRAwhYggRQ4gYQuxnCHET78sPUiHVEIRP
VOiJbhZYjOIlq49/yKnJXN3AhLJu9AFNOC26GpTwhIQ4AjfqbNAfGCHuPAuLlA11E0XKeVQk
kUzk8+Xqg3YQKSm35BBG63kwJDdqnkLKtaANQmhZZQYpiSCCIIIggiCCIIL0E0HWq2/Xb/7x
5J4cGbP94CxJv3xc/nG5Su6zKeHrP2QezU3zstEty05npGMEnp5YFBhln++d2HoALgis2A+f
rI/nZ5fvr6yYrAAGH6qsRJovljF2FNqJnpT126XfjbBaON8j5qJ6MK2Qi9bJievj+/OLjLiW
8HQHyS4z0feMvVjHzAKY2FrHKEycUVkUqyi9jl9H+nhMKK8KZTWChsmMa9kgnolrpj2jibTl
QU2ohLSGtIa0hrSGtNbvOedZRWT3LnzpxdRn67B4ek/J2zhDK3tdc+S3dOHED9bREWGIxQMk
saC/7VpABpuZeNO8Ez7/3zj7RCo729EH6rt8caYx82bhOIzGa2gjFwzJV2w+1heWfp8sx0tv
enr8/dujt5WNnzJLwAG2PYF7JtvMFwqWHGe6bv7idV6mm0NO/ak1HZJvtkftzMIweyE5yeaH
Qz+7h+NxmCbLNFn3VCI7juxv8NL1Z3H2X7XHsk5d8CEpioPvcp31w/bkZC/btSNSBZb/Vldq
lYuKojv+vlJ0RWXWll+5zvNCpDOblyTZdGujTyZVZrd3TJ6/OPP2FZXs1TvrYxpMyCOcbVHt
QcfcJXMdyRbY2wrJr+bWim3frPuPdbVSGNytarKCylDqeEu5xxXIPab/4CDu8QsTrqDrp4a5
IrFNARSDi+SKwV4jLThgGGNLFrqGrqXMSeMqSf1DeDLXiKi0pDKWlkVMo+jWmkn8LJW0BuSk
9BQwk06NaIloiWiJaKlng2mkS9xXGncGA29X8EzCCzL24M25fSjgdZs9RqVTX8m1Vn4tNW0S
LE/dmZP6yaDYaQr+LSc4gGIBP8kPnJTgfkgWzJErnGD15KwONsvaikVj2bq2rDSuv3wefz27
/mt89ufV2eeb869n49uzm9ubAb2u7dGJvGycl/RkoRjBGXbVmkiHnH9bWq0G90Iau+t1cvfw
VpkA2iVONAflcJZ9nYTAmI+uDyX+4JJNzjIjhQa5hVd2Xhr06m5SqeyQKRa27sKuH1rHOjBf
B1jGpsu4YYoGVsBzvGj6MI2FAm/FwB4lwCwVmKbD0Xywv5G80dxsHI/W71gUj86abAwP0t7e
nZzoi+BRgqrxu5KE4ejdxpbB2B1dwu0jd4WafNyOSotRO4zaYdQOo3ato3bTVD5kN02p2BF8
wNhRq5DdFfTprbP53I2SgwGGkzoaThrNkfFeNpiENWC6BrCEXzSQhMWPYSQpDlQLIhXJqyGk
O2+eeIvqkqc9CyZt3DAbUaoY6VhYqZI/2djSViC4DP7UF2BiVVWjTFUdw6Em2qDBeFOl1NsH
nRhJ+cgTK4DhJww/YfgJw09q4afNp4sP4/cXF6dkETb15+bH279Pv9x+IGmLv+AtFKSL07ej
0cnJm9HRyQ8/vv7+zZvXPx69yTc8gNbo/zi/W7MU8ugWYZLsvLx4FUP7uj1zHO5Nsg4CerFg
xyKvOytOnMUypoIAm/cg202XVavnXC1GNIg00IqmsuhDh7zcPKr1yhmNatecuG3Da8R+uoci
tuEtmwVGg3ndSXn72X0Xumq2Q7+D2Y518XfIsWynXyz51/s//tKHAc12VMFgF2VJVPhBaxYM
wsMOtdceJxqNyANGsyQiByIHIgciB454/wNGvDeb0NkL+MsDhPBmK8u+H2xvsOH69+z4c+i2
p0Ac5CSdaXF1QXobqa3K0pk8OOB9toA9AAzxfXdKEZ6wIWI5Z1fdetbTbE6rXAP/aS+pPpBg
Uz9GjQ0bVRla9KbkPWH/x41CO/Wm8aAXVFhyySwJCkx1jP4EuZQlvrLMl+jpXB/l8bVVyU6k
ZpjmqmYNEpygNtpTG1dYntT4MkhnSGdIZ0hnrenMm8rTGTkJNKcz+IB0JqSz91EQ+lPrOryD
mo8zKwyd0dvRgTukKwcdF6Crbb1ceEH6DWoGiqOgrGyYZ3MwKxQN/Db8JY1osCq1Gywi1CSv
5yc1VZVUDTSk6l4foIfXJVADHa5SFW6CcL3t3bdksP9YUzhjlml4djoGNLwsytIMpbG4fjzW
hzIcYZo8VJmGl18TEMPYMUgwPI/a40tVVZ5dOBoILgguCC4ILggufQKX2PUJpZDe8ByeVOvV
5otZ/N0ra7iMwsmQzFNbT1OjVk8mxNXN5DXfmTzE1s3ZmnfidEkqngKaojFhu/s7qdRzTSvx
FokbKKelz32AnUofQo10qjIs5qyHxoabf+0P9uYeHvRrrl/FP7MUVGOuYzBUk1NZJqpKvb37
5uhDI7G+KhXVKRoe7eGbNshLNbXTHpuE4vL0JJZCiEKIQohCiGoNUfPNO0YepbYpaaDafINU
JaSqF0aoSotigKR02Giv0cBVegqiD3gl6mSoUZZQjYEtUCRA5iwH+z+W5CzNjyPRNjo4hkRn
T2X8CNIvfz3/qnfsiBJtM1ZUkjGMQpQ9w+NFdInrGSsqFNXGiaj0iDeIN4g3iDet8caP5cGG
tBQ50sAHpBkhzVx7oB8BzxxaN6Tbt3CCxoGihJyPOIZ6Xs7dhD2kc/2rZX+lJ7ptvwUEmkfO
ghkRcpbVyV+cFM2jPzsJ7XjhDqM6O+a7LyM4eeuuPnpTSFRhIgbYeLCdiT/Y+/GZ3BWzVMEx
0zGw4ORQli0Kibsb51EfXlR1VQmDp2QYMiiTtvNokDM4pd8eNSqi8rRRlUDgQOBA4EDgQODo
H3C4yQxe9eN1x5n8SXY5SGM3eveOdGUPB4dD8u4/nMzm0JX0Ahce+9G77cXvoCYWC2KDrCmZ
kUIu2GQrOA2hssnvT2H0QBacEIcmaUQOhaf3Z6PQJW+DWApQ0ayHG42mtEk1AJLW0ukDQrFd
FjWKqqhwQCpxEps8zPYk9MNo0JNJb4xbhtFKZKxrgCXKpzRmMUKzX/0PGmFLoK6MXEI90+DF
MWwSv0S1ogHC+NIKKCYQQiBDIEMgQyBDIOvtCBB59bcc/2FaDw0DQfKKsimayEfBpV4ADrcj
oIg5fK062IlXC8JG8aA/63yqzj0X9VTtdRZ8qllVZ59c6zx4/GQCfyoG2hMQR/LZIKhk+1k4
qFpDOlGIVW9DQxUtBCIEIgQiBCIEIgSiXYBo24BoZSIJUYVEO5ORlG/9giOmX9CWj1g5BpEW
D/ASHdZsg7BvSPQcGx50fZuD1psb5Cu7Hn77USPmMKrKbFPRMQ00lEGTFMOWugZ0KUsq8Aoj
gJCCkIKQgpDSGlKyjgf8f+bNQvgnCBX2eltrFNyy/ozoIrM3Ab9cs1qhCzb7Aku2fckG4bRU
sOQzlmub3TTcAEp64gXzbF/1uZusv3Crsz5/fPuO+p0/7zN7BUFLd2qdbXULMM+KJLsC/k1j
d5b6Vhj4K+vJS+7z7SOgyvO05Cwt95Dmd/5mFG2UG9het0HNgk0xAf3l1Yt4QalfrhgkKGuw
kYHHIbvYbs9iAcYX2HV5aV2rRXUk8U9/f7nXx/60oir3lzUMM//WmEHeL5Vye9an5OQ5n06M
jI+Mj4yPjN+e8R9JdztbzbNZ1aPA+I80Lj0iK4lZ6dJ7cK0rJ3pwI84Bwbwzgbm7Pm6X0OWl
Dt++236dnQ8cp5P79RIsSA/3vjtJwmgl0Iv5evEuelvU26zuq2aNQ2abNHF+NXF8Y40GMc7S
MwmReuZqo62etoGk2jncB2gqOjlqwESl58BSEi68yZ5vdrh2wjA1MTa6Bk5M9qTZaZ1+/vXv
mUZ8KosqExQrYxqiCnsmOYopcQ0oVVJUoKlyegQqBCoEKgQqDUCFANUpgGIneKYBmWzXcorn
uvXQMK1zZ6EdL2wCjN3z3QuaoBt5RaAoSYiYYjQ47QNVjJ4DK0Yd54pRW7AYHT68JkPSesmi
UG2HFrTOs7DF2qBxuKBKXRdd5JKqeFEIIF8gXyBfIF8gXyBf7MwXI22AMdqZMEZ6EGP0D2OM
bUvfBjJyjSplePbJPk/zguwbPt+WNtC1E23pvEmfYQuJ/xj9/LfGU2spReVzaksapk+m3Rgz
eRYtXcoaTp8t5BTOm6USIzUgNSA1IDUgNfSVGiZhkESh75O1MV6wTJNxQiwFTjabKklWlp1v
FQKdj6PS8pcg3NKENxtHYZiQNKk3HXvwNETeo+e7c3earbmBHNkp/LpYjeGC0+Ojo1F+k62/
K91kBFnWb51X1u3t+edB1i9yFi6VnfX6jdOsvn+6+Zl8HWazxKy5dZ/dVet+9RF8Jp+gqzGc
uo9D0gvL3i3weEwJK1n2rPQLcfs0+2IJ75TcZTuySl9uMKpISaqQrBMius6d79JH7tonLJDU
p2s4XVdOTurypjNzZT3pxfG4eZ9I8UDcIj3DVgmAkD0aOnHsRok9GvRhz8GtM4YHcypWujaa
U8mg9HDOVuHn+e+uxvEcVlZ5QKcqJMlib9pYNDmkUyl5DWM6jKbCoA6rgHyGfIZ8hnzWms9I
N0Se0EgqitGyj0hpQkq7clLfuk6h8jmQdu4E1oUTTFzr1ln5YXQw4GEbuL+CGwae3tiDx5qi
sayO15W2ARNyrZVf+84Cf0ifPMvb1J1BZpJBaY18OcEBlBM4Tn7gpITyCK0oDcgVTrB6clYH
UGTki4UDLDq5dycP64X2pHiuv3wefz27/mt89ufV2eeb869n49uzm9sbss7Hi8JgQQrv0Yk8
YibDAyhXcObQss4O54cHg4GV3XAinVNyzxaGBwO4OVK4e4jt+B5u+UkKkk40B+Vwln2dhEvf
fXR9qIMHlywsyowUGuSuXtl5aQzowbFNM8xyEBa47gJvGFrEeniWesByfo5ybhrWxkp4ppdO
LyYFlElRcVYAI8KErqAH/xQM75y4uqRx70JWmRdm41WMiY4Fq5jcyUaq1snn39wrfWGqsqZq
jIpVMRygKswZjE4xpd0+NFUSlI9LlZNjUAqDUhiUwqBU66DU5H4eLeWjUlkyKiy1/oxxqV03
0KydL6B9lH8TrFqkUMd3bgYbTmwRM1TEJWtgWPIRJKmPGeyutOuVDdwmk/U+kAfdF1DDjpIC
yxzL4WRpO3bNaRR7xx60Q2YRhG+pYyTCz6QskJRUnj59/EMfl3ClVfFEIGaYUipWDcIKvyba
MwtPVx5duCpIMEgwSDBIMO0JRgVfSuyC4FIDLrdhdPfvECrnU+QEPjgsOfn5ZWCGbnK0MI20
oGSCBsJR8KcPoMPpOajxDk+oij3QuMRu9Ojac2/aC+yhHTKLPXxLHcMefiZlsaekkvznzYM+
7OFKq2KPQMww9lSsGsQefk20xx6erjz2cFUQexB7EHsQexB7EHv0Yw/d5GjBHmlByQQN2KPg
Tx+wh9NzUMMenlAVe+KlOwGese88yHofsId2yPAR5FxLXTuHnJtJ6cPIaZWTX26PNJ5IzpNW
PpacL2YYeypWTR5Qzq0JDaeUc3QVjirnqSD2IPYg9iD2IPYg9ujHHrrJ0YI90oKSCZoOW5b3
pxeHKVd7DoonKnOEuJPcFo+2G4RJnC7tb06SRHz62dspb6x7xme+iQ12bwKcOK8K8+AqYtef
Lk+0TocTWmgxK65G0/zkOK5xs3PkxLWkZaqcSF5pxpxQDFEKUQpRClFKA0opbRmKNGWcpnCn
1hfaqfXFJiuyrb2uOYtKumrpmmcwKjrZk4mMgg6d8nxGkR4HdJ2lc+f5XrIa9ABrc2cM0yzH
TtcglpNFaXYtNP76/exnjchaFVYmVZ6UaUAt2zTJpZwa0ICjFVUFCq1qIHwifCJ8Iny2hk8/
lidP0nrkCAQfEIGECHTtgX4E3HNo3SSO7y+cIDPF0FAH2CdvY/Qgj5yc1OVNgCPrSS+4hu0i
KOJMRYY3S9GJYteeee7CWQ5O+zFPkXLJ9ERFrqnOzVTk5lJ+qiIt83j847HOuYo8bfXJinw1
47MVWbNGpytya0PHfEWOsMqERZ4Mkg6SDpIOkg7OWOz3jEVQz47he0fskPM5yD+W7VqvyLbX
hFIgQfyqOPkuaybGk3uylmb7gXRffegXlX5crpL7MMj/kHmY1zr2RrcsO52RrhWUzYl1WFDW
JI0iUlhk/20rXsXQC7PuHdKKx+ls5k088uPH87PL91dWnC7JvVqaQEk1gSy+KEo3zbDUbVG3
YuMcTf1F1o9JnNXelOosTo4Sw4XT6ZCUvB277oO9dOLEnrqPg/5M4qw6ZxgTa+x1jRVrsioN
jFUt/+5E5wo3sQFldKyTNM2PfNsmIbKmhjSQpFBdASfFWsiUyJTIlMiUrZlyOpVnyumUYkr4
8D/Ik9IHCBKbN0nqQKX8Bl2XDqx8qzQ2eta/qckqJWviLFUPewFTor6EIlEJ5RisAk4lo8bD
zb/2BzurqR6tjit7ZhaqRLY6BlSibMrCFKNz+Vu61AdSAnFViBLKGQYojl2D8CSqkfbgxFeW
hyaBDgITAhMCEwJTa2Cab14w8ti0TUnB0/YbHJXb9birlwelcgOjBZIUJKWTNMCRkld9ACNu
f0ENivhSDBCBHK6iwlVUO8xf/bx4mhlZRbUV1rCKqpB6vlVUxObzrKLKa0DrKqqNaqtVVFsN
xBrEGsQaxBpcRYWrqHAVFa6iqnQRWq+i2shUKSZwFq7vxrGd9uSIK9ohsyzDt9QxmuFnUpZn
SirOh4s3+oiGK63KNAIxw1RTsWqQa/g10Z5seLrybMNVQbpBukG6QbpBukG60UI3dCujhW+k
BSUTNDCOgj99oBxOZ0GNc3hCDOksvHgynNxP4CWw7yM1xAnDgzRlE10bnynnTnpoJkv+9mP4
pHFUpqSpPCDDqJgei8nNmRyGKZe2hhEYWlBh8KWUHMkEyQTJBMmk/Z4OWc9CflsHkoze2SH7
jIgiRpQ0jl3ftz6ED5DtDu7cTSpQz5DLzkq7Xtk00CKR9V6MsVA9AcXhFVqBzxukwGx4T03h
1ga8iGtXzOwfibDumcYSsb3OMYo4q/LAUtGKr71/6aQXoQF1lKmRNM41XNtGIUdcQzqIR6Su
gj9CLWQhZCFkIWQhDSxE9zZlYIikK9FQ9gXikBiHQp8oX04+RXBDdgF/2OZFEwspySola6Qk
RQ/7gUyC3oMqP4nkeDAF3O8F6bfB/m/htnbE8L5trJGubdbG5k96h7aNwNfl26nGbdkYVeW9
2Co6pjdgowya3HWNLXUNW62VJRX2V2MEEGQQZBBkEGT0DOqQrbehDVg8WnHiJDjE04EhHtwg
vTOHEOPsShOzK/G452c+7plX4OR1TxV59hELvabQQd/1oVjjBzfuwEaYayrQs/ulhNbu1zbt
cynlQC82tyyBnOKOlmUNXiApgaKbwMNlh0+BO7XvVnYId3lUPzS/j4EmgaNmA0+NRjsWiGrM
r2xgSiT4w7XObS+brKgGrpp1DQey6jJgMLDVWGvtA10NJuQDX02CGAjDQBgGwjAQ1joQtn3R
yEe/tikpkMq/QpiqOXNgGjne3Popcqarl2cpQUOjha3aaKunbWCvdg73gcXq+xZqbNagybLa
A7yNh0/wUJAjD2146t3IhnfiNAz81Q6wtm+0JvDULK01Gu0YrTXmV5bWRII/ja58fbTWZEWV
1pp1DdNaXQYM0lpjrbWntQYT8rTWJIi0hrSGtIa01prWso6TPKplyegxxuwzQtr+HGkgaGG0
YFobbfW0DZjWzuE+YFp9p0IN0xo0WUx7HMaJN3lY2Ulof1s6kfhUuH2bp112y/B8bZGxrs3b
FuVTev42I3T5692fGudxC9SV53ML9UzP6+YYNjm/W1QrGuZ586UV5nsLhBCgEKAQoBCg2gPU
owI94fRMc9MzX3gmYbm90TOjUEFTPk3TDEMlx3ox05DbhVCcccjXYjApWgwJvtgjlzwcgx7g
EeWOWTTiGuoYFnHzKItEtEg0/deFPhziKauiEF/LMAaxRg0iELcW2uMPR1YefXgiiD2IPYg9
iD2tsQe6JdLYQ3pMOfbAB8Semjl9qW9dp1DtHOrhLA48GHQPhaj2RwsGyerJXd+AP/LO9AF9
ql0INezh6FSRJwjtuffo2umyB0dkF84YPlaOY6drh8pxsih9pBylMZ//pPFAuaowzSfKR8tx
8mvkMLmyHZNHyXE80nCQXEVV4Ri5qgZiDmIOYg5iDmIOYo7x8+Xy5kfP6XJyclKXN50sJ+tJ
L86VY3sPiqfKVWSqgBMGrj2DO9KOVzF0qPsy9Y1xyyzvCI11DHqE+ZQlH1bo+9ndL/rwR6Su
yj1iPcNjPjzDBmlIWCvtkUggLc9FIiGEI4QjhCOEI4QjhCPTcMS0QVoISUVTPg3LSn1gHX6P
QA14BFpV6iFLgmzBNgx7Rjq5K2YZh2OmY3TDyaEs1xQS3z7fO/qIpqqryjI8JcMUUzZpkF84
pd+eXCqi8sxSlUBaQVpBWkFaQVpBWjFNK3nro4VT5NRkrm4Yx5F1ow9ow3Yc1KCmosLgTJLN
Yxs6S9K22LV7y+0Z2lAumYUbrqGO4Q03j7KAQ4vMj59u9SEOT1kVcvhahjGHNWoQdLi10B51
OLLysMMTQdxB3EHcQdxpvw039B8UtuCGVPT22+QjQo8a9Jw7gXXhBBPXunVWfhh1kXioJkgL
88jqyV3fwD3yzvSBfKq9CDX24eiw9BOmk/thED7JHYa0dyt3np71DKQ6e51byfOk7eQjjpb7
8fxC58oeoQH1VT01koaZSWDb6IofcQ3pWPkjUldZASTUQp5CnkKeQp5qz1Ok86MAVCQZTVTZ
Z0SqnZDqfRSE/tS6Du/gY3yQsdNvwE1TKIEBdzO4a/jfyroB/fsurAx6MnEIkqKsUrLGFUNP
/9xTj4S9DtUVRCK5HMP+C7uDaNmU4wMA

--ew6BAiZeqk4r7MaW--


From MAILER-DAEMON Sat Apr 21 13:14:43 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SLdtT-0000fI-IB
	for mharc-coreutils@gnu.org; Sat, 21 Apr 2012 13:14:43 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57372)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SLdtR-0000ea-M5
	for coreutils@gnu.org; Sat, 21 Apr 2012 13:14:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SLdtP-0003Qe-Tr
	for coreutils@gnu.org; Sat, 21 Apr 2012 13:14:41 -0400
Received: from mail-pb0-f41.google.com ([209.85.160.41]:59534)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SLdtP-0003Ns-LU
	for coreutils@gnu.org; Sat, 21 Apr 2012 13:14:39 -0400
Received: by pbcup15 with SMTP id up15so2317549pbc.0
	for <coreutils@gnu.org>; Sat, 21 Apr 2012 10:14:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=sender:message-id:date:from:reply-to:organization:user-agent
	:mime-version:to:cc:subject:references:in-reply-to:content-type
	:content-transfer-encoding;
	bh=rELODH51dUEZauDkljfHIFbPaOdm1zLsxB7oiI8YTco=;
	b=xo6IRtIN1W9iPr/T9+e2f1q9xNSqEH7PjjhyrEN8nxi9esxa0SA0yydoQD277xX+cu
	kZWXE1k9qDb5Ppo/dVJqnH4Kkokvq4g7QM2jocQjYTj1Y52HC6J8SYHkD19LgsjDuPty
	Lps2MK/aCfoUXO9wGQ1R6+VQydltdqMT7bnbrAkycZSDL5vyh5Bh8wuRVCRCaQInfjoO
	7G6KeD6HJJ4dM6DpZPuRxxsQlKCr2IygVLiDZLHTyW7fTYyzdItqDjg829XETw8PX3xV
	5Eh9tqjSDs6Il0oEcsWq8jK1LZjG/2o6AUE3gN8Lk/7ksiIT+OvtzvijHASWAN2PAb0h
	8BQw==
Received: by 10.68.138.232 with SMTP id qt8mr22115276pbb.114.1335028476975;
	Sat, 21 Apr 2012 10:14:36 -0700 (PDT)
Received: from [192.168.10.2] (adsl-75-2-129-142.dsl.pltn13.sbcglobal.net.
	[75.2.129.142])
	by mx.google.com with ESMTPS id q1sm8916542pbp.62.2012.04.21.10.14.32
	(version=TLSv1/SSLv3 cipher=OTHER);
	Sat, 21 Apr 2012 10:14:34 -0700 (PDT)
Sender: Bruce Korb <bruce.korb@gmail.com>
Message-ID: <4F92EAF7.3030605@gnu.org>
Date: Sat, 21 Apr 2012 10:14:31 -0700
From: Bruce Korb <bkorb@gnu.org>
Organization: FSF
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120328 Thunderbird/11.0.1
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: Another patch, for discussion tho
References: <4F8B20F5.3000707@gmail.com> <87ty0jabgd.fsf@rho.meyering.net>
	<4F8C4EC6.1050004@gmail.com> <4F8C5DAC.1070405@gnu.org>
	<4F8C5E16.10705@gmail.com>
In-Reply-To: <4F8C5E16.10705@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.160.41
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: bkorb@gnu.org
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Apr 2012 17:14:43 -0000


So after futzing with timing a bit, I figured out the following:

1. These pre-computed tables _can_ out perform "strpbrk".  But
    only if the skipped over character count is approximately in
    the range of a dozen or two.  After that, single instruction
    testing and hand crafted assembly code beat it out. (These
    generated tables require a load, mask and test instead of
    just a load and test.)

2. The setup for a single character strpbrk break-on string is
    *MUCH* larger than the setup cost for a two-or-more character
    string.  Likely, someone is trying to optimize the setup and
    the setup is efficient enough that this optimization pessimizes.

3. It was never about efficiency of execution anyway.  It is quite
    unlikely that time-critical code is going to be scanning over
    strings anyway.  If they must, then use strpbrk/strcspn.
    Maybe for really critical scanning code, variants of those
    could split the interface into setup_strpbrk and run_strpbrk.

    I suppose, in retrospect, I could do the same thing and
    achieve the same efficiency.  "SETUP_whatever_SCAN()"
    populates an array of bytes that merely need to be tested
    for "true" and "false" instead of masking.  Entirely doable,
    but not today.

This whole thing _is_ about efficiency -- but efficiency of
expression, and also flexibility.  (Change the characters
in a classification and the main code now accepts the new
character set without alteration.  E.g. add '$' to the set
of name characters for "C" and now you are VMS compatible.)

So where would the right place be for a beast like this?


From MAILER-DAEMON Mon Apr 23 05:21:10 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SMFSI-00030E-DO
	for mharc-coreutils@gnu.org; Mon, 23 Apr 2012 05:21:10 -0400
Received: from eggs.gnu.org ([208.118.235.92]:53211)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMFSF-000303-V9
	for coreutils@gnu.org; Mon, 23 Apr 2012 05:21:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMFSE-0000WM-6x
	for coreutils@gnu.org; Mon, 23 Apr 2012 05:21:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8876)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMFSD-0000W4-V3
	for coreutils@gnu.org; Mon, 23 Apr 2012 05:21:06 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3N9L1Z0003413
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Mon, 23 Apr 2012 05:21:01 -0400
Received: from pb-n5110.redhat.com (ovpn-116-70.ams2.redhat.com [10.36.116.70])
	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id q3N9L0Rx008586; Mon, 23 Apr 2012 05:21:00 -0400
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <P@draigBrady.com>
To: coreutils@gnu.org
Subject: [PATCH] maint: avoid reading lots of data from /dev/urandom
Date: Mon, 23 Apr 2012 10:20:58 +0100
Message-Id: <1335172858-25284-1-git-send-email-P@draigBrady.com>
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Apr 2012 09:21:09 -0000

On Solaris 10 at least you need to use dd iflag=fullblock
to avoid short reads.  Also it's relatively slow when
you just want non NUL data as opposed to pseudo random data.

* cp/fiemap-empty: Convert /dev/zero rather than using /dev/urandom.
* dd/sparse: Likewise.
---
 tests/cp/fiemap-empty |    2 +-
 tests/dd/sparse       |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/cp/fiemap-empty b/tests/cp/fiemap-empty
index 4ba4ee3..81926f3 100755
--- a/tests/cp/fiemap-empty
+++ b/tests/cp/fiemap-empty
@@ -64,7 +64,7 @@ rm empty.big cp.test
 # Note until we support fallocate, we will not maintain
 # the file allocation.  FIXME: amend this test when fallocate is supported.
 fallocate -l 10MiB -n unwritten.withdata || framework_failure_
-dd count=10 if=/dev/urandom conv=notrunc iflag=fullblock of=unwritten.withdata
+dd count=10 if=/dev/zero | tr '\0' '1' | dd conv=notrunc of=unwritten.withdata
 cp unwritten.withdata cp.test || fail=1
 test $(stat -c %s unwritten.withdata) = $(stat -c %s cp.test) || fail=1
 cmp unwritten.withdata cp.test || fail=1
diff --git a/tests/dd/sparse b/tests/dd/sparse
index 35ddda9..f132924 100755
--- a/tests/dd/sparse
+++ b/tests/dd/sparse
@@ -45,8 +45,8 @@ cmp file.in file.out || fail=1
 # Setup for block size tests: create a 3MiB file with a 1MiB
 # stretch of NUL bytes in the middle.
 rm -f file.in
-dd if=/dev/urandom of=file.in bs=1M count=3 iflag=fullblock || fail=1
-dd if=/dev/zero    of=file.in bs=1M count=1 seek=1 conv=notrunc || fail=1
+dd if=/dev/zero bs=1M count=3 | tr '\0' '1' | dd of=file.in || fail=1
+dd if=/dev/zero of=file.in bs=1M count=1 seek=1 conv=notrunc || fail=1
 
 kb_alloc() { du -k "$1"|cut -f1; }
 
-- 
1.7.6.4



From MAILER-DAEMON Tue Apr 24 06:49:03 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SMdIt-0005m4-4i
	for mharc-coreutils@gnu.org; Tue, 24 Apr 2012 06:49:03 -0400
Received: from eggs.gnu.org ([208.118.235.92]:39463)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SMdIq-0005lR-I8
	for coreutils@gnu.org; Tue, 24 Apr 2012 06:49:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SMdIo-0002JM-QL
	for coreutils@gnu.org; Tue, 24 Apr 2012 06:49:00 -0400
Received: from mx.meyering.net ([88.168.87.75]:37195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SMdIo-0002JF-JN
	for coreutils@gnu.org; Tue, 24 Apr 2012 06:48:58 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id BDCC26014E;
	Tue, 24 Apr 2012 12:48:56 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: =?iso-8859-1?Q?P=E1draig?= Brady <P@draigBrady.com>
Subject: Re: [PATCH] maint: avoid reading lots of data from /dev/urandom
In-Reply-To: <1335172858-25284-1-git-send-email-P@draigBrady.com>
	(=?iso-8859-1?Q?=22P=E1draig?=
	Brady"'s message of "Mon, 23 Apr 2012 10:20:58 +0100")
References: <1335172858-25284-1-git-send-email-P@draigBrady.com>
Date: Tue, 24 Apr 2012 12:48:56 +0200
Message-ID: <87zka19zhj.fsf@rho.meyering.net>
Lines: 45
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2012 10:49:02 -0000

P=E1draig Brady wrote:
> On Solaris 10 at least you need to use dd iflag=3Dfullblock
> to avoid short reads.  Also it's relatively slow when
> you just want non NUL data as opposed to pseudo random data.
>
> * cp/fiemap-empty: Convert /dev/zero rather than using /dev/urandom.
> * dd/sparse: Likewise.

Thanks.  Do either of these avoid an actual failure?

With those changes, the affected files are then very compressible.
With some file system types/options, won't they occupy far fewer
blocks than before?

>  tests/cp/fiemap-empty |    2 +-
>  tests/dd/sparse       |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/cp/fiemap-empty b/tests/cp/fiemap-empty
> index 4ba4ee3..81926f3 100755
> --- a/tests/cp/fiemap-empty
> +++ b/tests/cp/fiemap-empty
> @@ -64,7 +64,7 @@ rm empty.big cp.test
>  # Note until we support fallocate, we will not maintain
>  # the file allocation.  FIXME: amend this test when fallocate is support=
ed.
>  fallocate -l 10MiB -n unwritten.withdata || framework_failure_
> -dd count=3D10 if=3D/dev/urandom conv=3Dnotrunc iflag=3Dfullblock of=3Dun=
written.withdata
> +dd count=3D10 if=3D/dev/zero | tr '\0' '1' | dd conv=3Dnotrunc of=3Dunwr=
itten.withdata
>  cp unwritten.withdata cp.test || fail=3D1
>  test $(stat -c %s unwritten.withdata) =3D $(stat -c %s cp.test) || fail=
=3D1
>  cmp unwritten.withdata cp.test || fail=3D1
> diff --git a/tests/dd/sparse b/tests/dd/sparse
> index 35ddda9..f132924 100755
> --- a/tests/dd/sparse
> +++ b/tests/dd/sparse
> @@ -45,8 +45,8 @@ cmp file.in file.out || fail=3D1
>  # Setup for block size tests: create a 3MiB file with a 1MiB
>  # stretch of NUL bytes in the middle.
>  rm -f file.in
> -dd if=3D/dev/urandom of=3Dfile.in bs=3D1M count=3D3 iflag=3Dfullblock ||=
 fail=3D1
> -dd if=3D/dev/zero    of=3Dfile.in bs=3D1M count=3D1 seek=3D1 conv=3Dnotr=
unc || fail=3D1
> +dd if=3D/dev/zero bs=3D1M count=3D3 | tr '\0' '1' | dd of=3Dfile.in || f=
ail=3D1
> +dd if=3D/dev/zero of=3Dfile.in bs=3D1M count=3D1 seek=3D1 conv=3Dnotrunc=
 || fail=3D1
>
>  kb_alloc() { du -k "$1"|cut -f1; }


From MAILER-DAEMON Tue Apr 24 07:15:46 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SMdik-000866-Ur
	for mharc-coreutils@gnu.org; Tue, 24 Apr 2012 07:15:46 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56546)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMdif-00085x-MO
	for coreutils@gnu.org; Tue, 24 Apr 2012 07:15:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMdiZ-0004X8-Ci
	for coreutils@gnu.org; Tue, 24 Apr 2012 07:15:41 -0400
Received: from mail3.vodafone.ie ([213.233.128.45]:31598)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMdiZ-0004WR-6e
	for coreutils@gnu.org; Tue, 24 Apr 2012 07:15:35 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApMBACuKlk9tTDkF/2dsb2JhbAANN65JhjABAQEDATIBRgULCw0LCSUPAkYGDQEHAQGIBrsAkU4EnBCNEg
Received: from unknown (HELO [192.168.1.79]) ([109.76.57.5])
	by mail3.vodafone.ie with ESMTP; 24 Apr 2012 12:15:32 +0100
Message-ID: <4F968B54.204@draigBrady.com>
Date: Tue, 24 Apr 2012 12:15:32 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH] maint: avoid reading lots of data from /dev/urandom
References: <1335172858-25284-1-git-send-email-P@draigBrady.com>
	<87zka19zhj.fsf@rho.meyering.net>
In-Reply-To: <87zka19zhj.fsf@rho.meyering.net>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.45
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2012 11:15:46 -0000

On 04/24/2012 11:48 AM, Jim Meyering wrote:
> Pádraig Brady wrote:
>> On Solaris 10 at least you need to use dd iflag=fullblock
>> to avoid short reads.  Also it's relatively slow when
>> you just want non NUL data as opposed to pseudo random data.
>>
>> * cp/fiemap-empty: Convert /dev/zero rather than using /dev/urandom.
>> * dd/sparse: Likewise.
> 
> Thanks.  Do either of these avoid an actual failure?

no

> With those changes, the affected files are then very compressible.
> With some file system types/options, won't they occupy far fewer
> blocks than before?

Good point.
The dd/sparse one could then fail the alloc check.
The fiemap-empty change is only 5120 bytes too.

OK I'll drop this.

cheers,
Pádraig.


From MAILER-DAEMON Tue Apr 24 07:53:50 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SMeJa-0002QQ-BP
	for mharc-coreutils@gnu.org; Tue, 24 Apr 2012 07:53:50 -0400
Received: from eggs.gnu.org ([208.118.235.92]:33464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SMeJX-0002QJ-HO
	for coreutils@gnu.org; Tue, 24 Apr 2012 07:53:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SMeJS-0001Zh-Ts
	for coreutils@gnu.org; Tue, 24 Apr 2012 07:53:47 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:62076)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@bernhard-voelker.de>) id 1SMeJS-0001ZM-JH
	for coreutils@gnu.org; Tue, 24 Apr 2012 07:53:42 -0400
Received: from [192.168.2.108] (p4FF753C6.dip.t-dialin.net [79.247.83.198])
	by mrelayeu.kundenserver.de (node=mrbap3) with ESMTP (Nemesis)
	id 0LalbM-1RyMBs1gOu-00kVn8; Tue, 24 Apr 2012 13:53:37 +0200
Message-ID: <4F96943F.9030606@bernhard-voelker.de>
Date: Tue, 24 Apr 2012 13:53:35 +0200
From: Bernhard Voelker <mail@bernhard-voelker.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120328 Thunderbird/11.0.1
MIME-Version: 1.0
To: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
Subject: Re: [PATCH] maint: avoid reading lots of data from /dev/urandom
References: <1335172858-25284-1-git-send-email-P@draigBrady.com>
	<87zka19zhj.fsf@rho.meyering.net> <4F968B54.204@draigBrady.com>
In-Reply-To: <4F968B54.204@draigBrady.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-Provags-ID: V02:K0:YzFbWIT+ei8F/qBZs95GaJqnlVVmvufH/ydUa+yt2DD
	mC4D3S83cqIECJGIVdwBPkgR+lC/s5W5t5gCxHpzrYAFhpLcgL
	Rjm9kcUv+QhKFYJA+1x41NaOWVcUiNX9jdWw8OQiXjIvrXuStk
	W4zZEO3Z0fc0EbYHqINTq96/kJRu9DP8WUWgwUV1O/aqMbq3Km
	ZO+NsyloBXjasrVXkbzYtKrWC0bcltNtCXOOLrkGoJsCRqTANq
	YmjIQsMbNdlIXlErnma6jhT/z7SzJ2JYU9JG9+BXmTEC3rl+Sk
	gVPhwDrJCZO7rd/Te4f0CUT8qqx9GnnhG7AEPjFNYNQ27e70rB
	D2bDlaB7CgRSPqGdhuk7EorzCILuB4m6jhS06Ljj/
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 212.227.126.186
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2012 11:53:48 -0000



On 04/24/2012 01:15 PM, Pádraig Brady wrote:
>> With those changes, the affected files are then very compressible.
>> > With some file system types/options, won't they occupy far fewer
>> > blocks than before?
> Good point.
> The dd/sparse one could then fail the alloc check.
> The fiemap-empty change is only 5120 bytes too.

Wouldn't

-dd count=10 if=/dev/urandom conv=notrunc iflag=fullblock of=unwritten.withdata
+dd count=10 if=/dev/zero | sed 's/\(.\)./\1 /g' | dd conv=notrunc of=unwritten.withdata

defeat the compression logic?

Have a nice day,
Berny


From MAILER-DAEMON Tue Apr 24 08:15:31 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SMeeZ-0007wH-SB
	for mharc-coreutils@gnu.org; Tue, 24 Apr 2012 08:15:31 -0400
Received: from eggs.gnu.org ([208.118.235.92]:33580)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMeeW-0007w0-T4
	for coreutils@gnu.org; Tue, 24 Apr 2012 08:15:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMeeV-0002r0-52
	for coreutils@gnu.org; Tue, 24 Apr 2012 08:15:28 -0400
Received: from mail2.vodafone.ie ([213.233.128.44]:36097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SMeeU-0002qO-VE
	for coreutils@gnu.org; Tue, 24 Apr 2012 08:15:27 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApMBAGOYlk9tTDkF/2dsb2JhbAANN65JhjABAQEEMgFGEAsNAQoJFg8JAwIBAgFFBg0BBwEBwx2RTgScEI0S
Received: from unknown (HELO [192.168.1.79]) ([109.76.57.5])
	by mail2.vodafone.ie with ESMTP; 24 Apr 2012 13:15:24 +0100
Message-ID: <4F96995C.8000804@draigBrady.com>
Date: Tue, 24 Apr 2012 13:15:24 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Bernhard Voelker <mail@bernhard-voelker.de>
Subject: Re: [PATCH] maint: avoid reading lots of data from /dev/urandom
References: <1335172858-25284-1-git-send-email-P@draigBrady.com>
	<87zka19zhj.fsf@rho.meyering.net> <4F968B54.204@draigBrady.com>
	<4F96943F.9030606@bernhard-voelker.de>
In-Reply-To: <4F96943F.9030606@bernhard-voelker.de>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.44
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2012 12:15:30 -0000

On 04/24/2012 12:53 PM, Bernhard Voelker wrote:
> 
> 
> On 04/24/2012 01:15 PM, Pádraig Brady wrote:
>>> With those changes, the affected files are then very compressible.
>>>> With some file system types/options, won't they occupy far fewer
>>>> blocks than before?
>> Good point.
>> The dd/sparse one could then fail the alloc check.
>> The fiemap-empty change is only 5120 bytes too.
> 
> Wouldn't
> 
> -dd count=10 if=/dev/urandom conv=notrunc iflag=fullblock of=unwritten.withdata
> +dd count=10 if=/dev/zero | sed 's/\(.\)./\1 /g' | dd conv=notrunc of=unwritten.withdata
> 
> defeat the compression logic?

You'd have to be approaching random to avoid compression.

$ dd count=10 if=/dev/zero | tr '\0' 1 | gzip -c | wc -c
41

$ dd count=10 if=/dev/zero | sed 's/\(.\)./\1 /g' | gzip -c | wc -c
41

cheers,
Pádraig.


From MAILER-DAEMON Tue Apr 24 12:36:44 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SMijM-0005H0-70
	for mharc-coreutils@gnu.org; Tue, 24 Apr 2012 12:36:44 -0400
Received: from eggs.gnu.org ([208.118.235.92]:36801)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SMijJ-00056d-16
	for coreutils@gnu.org; Tue, 24 Apr 2012 12:36:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SMijH-00034P-4H
	for coreutils@gnu.org; Tue, 24 Apr 2012 12:36:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8287)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>)
	id 1SMij4-000303-Cy; Tue, 24 Apr 2012 12:36:26 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OGaAao015839
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Tue, 24 Apr 2012 12:36:10 -0400
Received: from [10.3.113.98] (ovpn-113-98.phx2.redhat.com [10.3.113.98])
	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
	id q3OGa98D019857; Tue, 24 Apr 2012 12:36:09 -0400
Message-ID: <4F96D679.8000506@redhat.com>
Date: Tue, 24 Apr 2012 10:36:09 -0600
From: Eric Blake <eblake@redhat.com>
Organization: Red Hat
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: Bug#582083: patch for grep --color to non-tty output
References: <alpine.DEB.2.00.1102040206590.13823@gamow.rather.puzzling.org>
	<alpine.DEB.2.00.1204241308580.26926@dirac.rather.puzzling.org>
	<20120424035040.GA6002@debian.org>
	<8762cpbeg7.fsf@rho.meyering.net>
	<alpine.DEB.2.00.1204242103260.23687@dirac.rather.puzzling.org>
	<87ehrd879c.fsf@rho.meyering.net>
In-Reply-To: <87ehrd879c.fsf@rho.meyering.net>
X-Enigmail-Version: 1.4.1
OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enigAD53CF0D65957E75890765F2"
X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
Cc: Coreutils <coreutils@gnu.org>, 582083@bugs.debian.org, bug-grep@gnu.org,
	Tim Connors <tim.w.connors@gmail.com>,
	=?ISO-8859-1?Q?An=EDbal_Monsalve_Salazar?= <anibal@debian.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2012 16:36:42 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigAD53CF0D65957E75890765F2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

[adding coreutils]

On 04/24/2012 09:43 AM, Jim Meyering wrote:

>>> Thanks for the report of the documentation bug and the patch, but the=
 patch
>>> (changing the meaning of --color from --color=3Dauto to --color=3Dalw=
ays)
>>> would break existing usage.
>>>
>>> Currently, people can use --color in an always-on alias/function
>>> or set the GREP_OPTIONS=3D--color envvar and get colorized output,
>>> yet not have those ANSI terminal highlighting bytes interfere
>>> with output that is not to a tty.
>>>
>>> If we were to make your proposed change, they'd find those
>>> color codes in unexpected (and undesirable) places.
>>
>> Easy to fix!  Fix the bug in their login scripts!
>=20
> If it were only in dot-file alias/function definitions,
> it'd be an easier call.  Are there uses of grep --color
> in other contexts?  Probably.

And probably harder to track down and ultimately fix, but not impossible.=


>>> PS.  True, it is undesirable to have grep's --color(with no value)
>>> default to "auto", when in ls it defaults to "always", but changing
>>> grep's default now would be too disruptive.  We'd have to warn that
>>> the default is going to change for a year or two before making the
>>> actual change, and even then, some users would be impacted.
>=20
> If you know me, you know that the above is just this humble
> maintainer's opinion.  If enough people chime in saying that they
> think making grep --color align with ls --color behavior is important,
> and that they think the risk to existing users is low enough,
> I'll be happy to reconsider.

Personally, I think ls has it wrong - I _like_ --color defaulting to
--color=3Dauto, and think ls has it wrong.  Thankfully, you can always us=
e
--color=3Dmode to say what you mean, so if you are aware of the
inconsistent defaults of --color in isolation, you just avoid that
construct.

In other words, this is all boiling down to a bikeshed painting contest.
 I _do_ value consistency, and I would welcome a change that first
documents our intention to make a change to a default (whether that
change is to grep, to ls, to the GNU Coding Standards, or somewhere else
is still up for debate....), and only after another year or two go ahead
with the change.  But I'm not happy with forcing a change in bikeshed
behavior with no warning.

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enigAD53CF0D65957E75890765F2
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPltZ5AAoJEKeha0olJ0Nq1VwH/2QB6aXUDq1OmcrcojVQEq0s
98gyKaHdyAb41N3ZHSsWtxDn0LUVX4TjyUS0d1KW/zKcLBlMHPfXWxxufZitFQe3
NnOV7oVE9rReHUmpiR0+Kc36J3kSNnWl2kimVy9WxjQ+by4myTMXHvOKYNPSSv7G
Elu/Rji08A5sPHegamD/ok7A0t18XmkKWmzsauNn0zsL9xdIo9U5tz0h+cg+6TDQ
aFEQTkxk9CdhoDjqschafvwfkVeKB9Gd5rNBizgBR4uhiXv+jlD7lrirGvG11d0R
UYwFj1ggq92/IhaAmNrTbkqC+n95NDW7b8jqRLG2MuWl+oW2PSCjfOjAwg0MptA=
=/Tsv
-----END PGP SIGNATURE-----

--------------enigAD53CF0D65957E75890765F2--


From MAILER-DAEMON Wed Apr 25 20:45:33 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNCpx-0003Ap-JR
	for mharc-coreutils@gnu.org; Wed, 25 Apr 2012 20:45:33 -0400
Received: from eggs.gnu.org ([208.118.235.92]:41109)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quinton.dunning@gmail.com>) id 1SNCjo-0002tb-8V
	for coreutils@gnu.org; Wed, 25 Apr 2012 20:39:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quinton.dunning@gmail.com>) id 1SNCjm-0005pb-HB
	for coreutils@gnu.org; Wed, 25 Apr 2012 20:39:11 -0400
Received: from mail-ob0-f169.google.com ([209.85.214.169]:52839)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quinton.dunning@gmail.com>) id 1SNCjm-0005pF-9v
	for coreutils@gnu.org; Wed, 25 Apr 2012 20:39:10 -0400
Received: by obbeh20 with SMTP id eh20so943940obb.0
	for <coreutils@gnu.org>; Wed, 25 Apr 2012 17:39:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:subject
	:content-type:content-transfer-encoding;
	bh=EyaJqopYATAedBV9ODvBbMaPLPISPaml2Uw9E3qsiUo=;
	b=FjpKIcYpN16IWwEIkcifuqLdb5ofdCIEyvuCYDFNiqNoXQb1X2CAs8HGJd8XVN8hCl
	+3IOO4LKy6xjDlypwubP4ABlDeV4dYq0vzh+V2YMOHs5S6jWdJy0df2U74R9pWF5/gdt
	NhvVuRCnHb9rGMaRrNbMkbP5mdiqBKqaHbYuBCioTN+Fq5PnO9TGTKCz0/lDUh/63Dmk
	Ie9NCZgWFm66d+pEpEFPvMxse5AN7NJSslmg4zuAx/ZNV9oUEpxoJS3FH6AOm/uA2jr0
	4cafxGQgrR8dCArq9mi2a2d4n1uBGMtQGdfX4+iLXciZJRvTYuz7Z/hq0tlj6F1+Gg0y
	gFgA==
Received: by 10.182.52.105 with SMTP id s9mr5807059obo.48.1335400747552;
	Wed, 25 Apr 2012 17:39:07 -0700 (PDT)
Received: from [192.168.0.4]
	(CPE00222d6e1190-CM00222d6e118d.cpe.net.cable.rogers.com.
	[99.239.97.64])
	by mx.google.com with ESMTPS id il8sm1673147obc.18.2012.04.25.17.39.05
	(version=SSLv3 cipher=OTHER); Wed, 25 Apr 2012 17:39:07 -0700 (PDT)
Message-ID: <4F989945.7080007@gmail.com>
Date: Wed, 25 Apr 2012 20:39:33 -0400
From: Quinton Dunning <quinton.dunning@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:11.0) Gecko/20120406 Thunderbird/11.0.1
MIME-Version: 1.0
To: coreutils@gnu.org
Subject: Split command wait - Request
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.214.169
X-Mailman-Approved-At: Wed, 25 Apr 2012 20:45:32 -0400
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Apr 2012 00:39:13 -0000

To whom it may concern,

Sometimes when I execute the split command I want to use removable media 
and take a file part over to another machine. To do this, the split 
command would have to have a switch that would pause and wait for a 
keystroke before writing the next file.

I am not experienced with much programming at all and was thinking this 
would be a fantastic feature to add to split for anyone who can patch it in.

Thank You,
Quinton Dunning


From MAILER-DAEMON Thu Apr 26 07:24:48 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNMoa-0002op-CH
	for mharc-coreutils@gnu.org; Thu, 26 Apr 2012 07:24:48 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56278)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNMoS-0002o6-Tr
	for coreutils@gnu.org; Thu, 26 Apr 2012 07:24:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNMoK-0004pr-Dm
	for coreutils@gnu.org; Thu, 26 Apr 2012 07:24:40 -0400
Received: from mail2.vodafone.ie ([213.233.128.44]:48517)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNMoK-0004l8-7b
	for coreutils@gnu.org; Thu, 26 Apr 2012 07:24:32 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AqQBAOwvmU9tTjHh/2dsb2JhbAANN64thi4BAQEEMgFGEAsNCwkWDwkDAgECAUUGDQEHAQHDKJBlBJwTjRM
Received: from unknown (HELO [192.168.1.79]) ([109.78.49.225])
	by mail2.vodafone.ie with ESMTP; 26 Apr 2012 12:24:29 +0100
Message-ID: <4F99306C.1050905@draigBrady.com>
Date: Thu, 26 Apr 2012 12:24:28 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Quinton Dunning <quinton.dunning@gmail.com>
Subject: Re: Split command wait - Request
References: <4F989945.7080007@gmail.com>
In-Reply-To: <4F989945.7080007@gmail.com>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.44
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Apr 2012 11:24:46 -0000

On 04/26/2012 01:39 AM, Quinton Dunning wrote:
> To whom it may concern,
> 
> Sometimes when I execute the split command I want to use removable media and take a file part over to another machine. To do this, the split command would have to have a switch that would pause and wait for a keystroke before writing the next file.
> 
> I am not experienced with much programming at all and was thinking this would be a fantastic feature to add to split for anyone who can patch it in.

I sort of like this, but split would need two options to support it I think.

  --target-directory # so split wouldn't have to run in the mounted dir
  --confirm-create   # wait for confirmation before creating a file

I suppose you could do this with a script like the following.
But that only works when we know the size of the input.

size=$(stat --format %s "$file")
media_size=$((2*1024**3))
chunks=$(($size/$media_size + 1))
chunk=1
while true; do
  read -p "Press return to create ..."
  (cd $dest &&
   split -n $chunk/$chunks > $file.$chunk)
  test $chunk = $chunks && break
  chunk=$(($chunk+1))
done

cheers,
Pádraig.


From MAILER-DAEMON Fri Apr 27 03:24:21 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNfXR-0005Zk-Ix
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 03:24:21 -0400
Received: from eggs.gnu.org ([208.118.235.92]:35738)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aristidesfl@gmail.com>) id 1SNbHy-0005wG-C5
	for coreutils@gnu.org; Thu, 26 Apr 2012 22:52:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aristidesfl@gmail.com>) id 1SNbHw-0006EW-NN
	for coreutils@gnu.org; Thu, 26 Apr 2012 22:52:05 -0400
Received: from mail-we0-f169.google.com ([74.125.82.169]:61857)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aristidesfl@gmail.com>) id 1SNbHw-0006EN-Dg
	for coreutils@gnu.org; Thu, 26 Apr 2012 22:52:04 -0400
Received: by werj55 with SMTP id j55so192439wer.0
	for <coreutils@gnu.org>; Thu, 26 Apr 2012 19:52:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=date:from:to:subject:message-id:user-agent:mime-version
	:content-type; bh=bevejPQ+DjuucR8YrGvGAMuqGe3VtSWguDHyhag8lnQ=;
	b=anTrY6lE7af3bPPKY1EwsdLOJySNCx4JjGZZxb0fFCcoLtgJhQ6/fzDgmwoW8BinwY
	zSDneCeMWYuC21n7oMOyYN3+Zly0OsNm50cAs14UVok20D/aYpyggFiwpMVoIr8M9VQu
	E+lelAmvQKbmlnF/jwhMfrHQ8EJ3BZVjzBTQSHSH/zVm9zbEBHwAtobSADjiyiVUwTZ2
	XFGcclHb0MQ05TojCZ0QWHXnqkKNjgj/FqzG7Kuzs334ipum4r6WfH8nCLy7uW7C55P4
	A9gzgoEjKFUVC0hdwBoJZLqxLiHF6nPQOzsEj40Fvp7bc4YqYCE3e1lT9+fOgnXkxt+T
	9+MA==
Received: by 10.180.97.4 with SMTP id dw4mr1537808wib.18.1335495121399;
	Thu, 26 Apr 2012 19:52:01 -0700 (PDT)
Received: from unknown.home (a89-153-142-45.cpe.netcabo.pt. [89.153.142.45])
	by mx.google.com with ESMTPS id gd4sm2298353wib.6.2012.04.26.19.51.59
	(version=SSLv3 cipher=OTHER); Thu, 26 Apr 2012 19:52:00 -0700 (PDT)
Date: Fri, 27 Apr 2012 03:51:53 +0100 (WEST)
From: aristidesfl <aristidesfl@gmail.com>
To: coreutils@gnu.org
Subject: Group results according the indicators appended by -F/--classify
	(ls --sort=class)
Message-ID: <alpine.OSX.2.00.1204270351280.99041@unknown.home>
User-Agent: Alpine 2.00 (OSX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 74.125.82.169
X-Mailman-Approved-At: Fri, 27 Apr 2012 03:24:20 -0400
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 02:52:07 -0000

>From the man entry:
```
-F, --classify
               append indicator (one of */=>@|) to entries
```

Would be useful for readability purposes to be able group entries 
according the indicators appended by -F/--classify.
A WORD called class could be added to "--sort" for this purpose.

In addition to that, it would be useful to have an option which forced the extra entries printed by -a/-A, to be displayed after the rest of the normal entries, independently of sorting options.


Cheers,
aristidesfl


From MAILER-DAEMON Fri Apr 27 08:33:42 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNkMo-0004xo-Le
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 08:33:42 -0400
Received: from eggs.gnu.org ([208.118.235.92]:58269)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <henrikki.almusa@helsinki.fi>) id 1SNjj8-0003kO-L0
	for coreutils@gnu.org; Fri, 27 Apr 2012 07:52:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <henrikki.almusa@helsinki.fi>) id 1SNjj2-0002Ak-IZ
	for coreutils@gnu.org; Fri, 27 Apr 2012 07:52:42 -0400
Received: from smtp-rs1-vallila2.fe.helsinki.fi ([128.214.173.75]:53485)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <henrikki.almusa@helsinki.fi>) id 1SNjj2-0002AL-8X
	for coreutils@gnu.org; Fri, 27 Apr 2012 07:52:36 -0400
Received: from [172.16.16.27] (mylly.genome.helsinki.fi [128.214.64.36])
	by smtp-rs1.it.helsinki.fi (8.14.4/8.14.4) with ESMTP id q3RBqR37029909
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256
	verify=NOT) for <coreutils@gnu.org>; Fri, 27 Apr 2012 14:52:28 +0300
Message-ID: <4F9A887A.30305@helsinki.fi>
Date: Fri, 27 Apr 2012 14:52:26 +0300
From: Henrikki Almusa <henrikki.almusa@helsinki.fi>
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: coreutils@gnu.org
Subject: mkdir -pm bug?
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 128.214.173.75
X-Mailman-Approved-At: Fri, 27 Apr 2012 08:33:40 -0400
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 11:52:48 -0000

Hi,

I have a situation where I want to create with a script a directory path 
based on input. The mkdir -p allows this nicely. However since I want to 
enforce certain permissions on it I thought that I can use mkdir 
-pm<mode> to create this. However it seems that when using both options, 
the parent directories created won't get the --mode given, but instead 
use the default mask. Is this intentional as I would think it as bug?

$ mkdir -pm0700 baz/bar
$ ls -lhd baz/ baz/bar
drwxrwxr-x 3 [user] [group] 4.0K 2012-04-27 14:47 baz/
drwx------ 2 [user] [group] 4.0K 2012-04-27 14:47 baz/bar
$ mkdir --version
mkdir (GNU coreutils) 8.5
Copyright (C) 2010 Free Software Foundation, Inc.

Regards,
-- 
Henrikki Almusa


From MAILER-DAEMON Fri Apr 27 09:09:35 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNkvX-0001zH-3h
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 09:09:35 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48377)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNkvR-0001z3-TI
	for coreutils@gnu.org; Fri, 27 Apr 2012 09:09:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNkvM-0007D4-Jz
	for coreutils@gnu.org; Fri, 27 Apr 2012 09:09:29 -0400
Received: from mail2.vodafone.ie ([213.233.128.44]:38966)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNkvM-000783-D7
	for coreutils@gnu.org; Fri, 27 Apr 2012 09:09:24 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApMBAJiZmk9tTnli/2dsb2JhbAANN7R6AQEBBAECLwFGEAsNCwkWDwkDAgECARYvBg0BBwEBiBS9CpFDBJNOg0CFBY0T
Received: from unknown (HELO [192.168.1.79]) ([109.78.121.98])
	by mail2.vodafone.ie with ESMTP; 27 Apr 2012 14:09:21 +0100
Message-ID: <4F9A9A81.9030601@draigBrady.com>
Date: Fri, 27 Apr 2012 14:09:21 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Henrikki Almusa <henrikki.almusa@helsinki.fi>
Subject: Re: mkdir -pm bug?
References: <4F9A887A.30305@helsinki.fi>
In-Reply-To: <4F9A887A.30305@helsinki.fi>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.44
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 13:09:34 -0000

On 04/27/2012 12:52 PM, Henrikki Almusa wrote:
> Hi,
> 
> I have a situation where I want to create with a script a directory path based on input. The mkdir -p allows this nicely. However since I want to enforce certain permissions on it I thought that I can use mkdir -pm<mode> to create this. However it seems that when using both options, the parent directories created won't get the --mode given, but instead use the default mask. Is this intentional as I would think it as bug?
> 
> $ mkdir -pm0700 baz/bar
> $ ls -lhd baz/ baz/bar
> drwxrwxr-x 3 [user] [group] 4.0K 2012-04-27 14:47 baz/
> drwx------ 2 [user] [group] 4.0K 2012-04-27 14:47 baz/bar
> $ mkdir --version
> mkdir (GNU coreutils) 8.5
> Copyright (C) 2010 Free Software Foundation, Inc.

This was discussed previously:

http://lists.gnu.org/archive/html/bug-coreutils/2011-05/msg00071.html

cheers,
Pádraig.


From MAILER-DAEMON Fri Apr 27 10:32:51 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNmE7-0000ve-Sn
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 10:32:51 -0400
Received: from eggs.gnu.org ([208.118.235.92]:39151)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNmE5-0000ue-20
	for coreutils@gnu.org; Fri, 27 Apr 2012 10:32:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNmE3-00036K-Bn
	for coreutils@gnu.org; Fri, 27 Apr 2012 10:32:48 -0400
Received: from mail-pb0-f41.google.com ([209.85.160.41]:61547)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNmE3-000365-34
	for coreutils@gnu.org; Fri, 27 Apr 2012 10:32:47 -0400
Received: by pbcup15 with SMTP id up15so1093634pbc.0
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 07:32:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:subject
	:content-type:content-transfer-encoding;
	bh=pleFJ/VdA5q1tsZeZjgUAYi7h/imr7y138Bvk1t0Wo0=;
	b=YU5W7ZPowBylXQe5wwfwVTrN6yD3SXs84Qg5+4qkMXItYmTPBtYUPG2Yu9HJAelgN9
	T/yZ+eIDDiGESOYz2SoIXMjt0p2gmntJLjBRq3mGEc2OBCP18BSUYIAktfIoEjUsxn4F
	89bryYtBFU0soq+xqvpgTz8Ne5pOzwMGIfrckOftxiH61DJ/MSiFc+denxNA+vKtHlQZ
	71KuyLCYkAYJ6uCQcNvTZ7Ww8hzS2yNbFwQhpvQBzzCYtn5HbqBusQitLG5YWqFHpttd
	9BWUM8bUWMV5ExNRXOM+lhtQcRTaYlNjxxytNe2syiOUK5UqLIQ9jXG2WtSXtpp8VSfc
	t1wQ==
Received: by 10.68.221.227 with SMTP id qh3mr17281529pbc.43.1335537164208;
	Fri, 27 Apr 2012 07:32:44 -0700 (PDT)
Received: from [192.168.10.2] ([75.0.182.39])
	by mx.google.com with ESMTPS id ux5sm6657622pbc.4.2012.04.27.07.32.42
	(version=TLSv1/SSLv3 cipher=OTHER);
	Fri, 27 Apr 2012 07:32:43 -0700 (PDT)
Message-ID: <4F9AAE09.1010904@gmail.com>
Date: Fri, 27 Apr 2012 07:32:41 -0700
From: Bruce Korb <bruce.korb@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120328 Thunderbird/11.0.1
MIME-Version: 1.0
To: coreutils@gnu.org
Subject: Another rfe:  "cp" this time
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.160.41
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 14:32:50 -0000

Our corporate infrastructure only allows CIFS shares.  No FTP access.
No scp access.  Nope.  Gotta be CIFS.  One of these is on the other
side of the pond.  The pipe is fairly fat, but very, very long.
Sometimes, like yesterday, after 8 hours of copying, I was only
80% complete and I had to shut down and go home, other times, the
operation has been interrupted.  So I am proposing two options
for "cp":  --resume and --parallel
I'll let you guess what --resume does, --parallel would open the
source file several times and have multiple threads reading and
writing different parts of the file.

I can either add this to cp, or roll my own toy.  What say you?

Thanks - Bruce

P.S. The other weekend, I played with the character classifier
thingy.  The performance results are going to surprise you:
it's data dependent.  If the sought character in strpbrk/strcspn
is right at the start, not having to do the setup is a win.
After about 64 bytes, the assembly code always wins.  In between,
it depends on the number of characters in the character class,
but the crossover was always in the 10 - 64 byte range.
The one outlier is the 1 byte character class wherein strpbrk
takes several hundred times longer than when it is a 2 byte class.


From MAILER-DAEMON Fri Apr 27 11:36:05 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNnDJ-000347-Fc
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 11:36:05 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57335)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNnDE-00033v-0r
	for coreutils@gnu.org; Fri, 27 Apr 2012 11:36:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNnD9-0001p5-80
	for coreutils@gnu.org; Fri, 27 Apr 2012 11:35:59 -0400
Received: from mail2.vodafone.ie ([213.233.128.44]:38010)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNnD9-0001ov-1k
	for coreutils@gnu.org; Fri, 27 Apr 2012 11:35:55 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApkBAA28mk9tTnli/2dsb2JhbAANN648hj4BAQEEMgFGEAsNCwkWDwkDAgECAUUGDQEHAQHEcpFDBJwTjRM
Received: from unknown (HELO [192.168.1.79]) ([109.78.121.98])
	by mail2.vodafone.ie with ESMTP; 27 Apr 2012 16:35:53 +0100
Message-ID: <4F9ABCD8.1070009@draigBrady.com>
Date: Fri, 27 Apr 2012 16:35:52 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Bruce Korb <bruce.korb@gmail.com>
Subject: Re: Another rfe:  "cp" this time
References: <4F9AAE09.1010904@gmail.com>
In-Reply-To: <4F9AAE09.1010904@gmail.com>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.44
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 15:36:04 -0000

On 04/27/2012 03:32 PM, Bruce Korb wrote:
> Our corporate infrastructure only allows CIFS shares.  No FTP access.
> No scp access.  Nope.  Gotta be CIFS.  One of these is on the other
> side of the pond.  The pipe is fairly fat, but very, very long.
> Sometimes, like yesterday, after 8 hours of copying, I was only
> 80% complete and I had to shut down and go home, other times, the
> operation has been interrupted.  So I am proposing two options
> for "cp":  --resume and --parallel
> I'll let you guess what --resume does, --parallel would open the
> source file several times and have multiple threads reading and
> writing different parts of the file.
> 
> I can either add this to cp, or roll my own toy.  What say you?

Yes, cp is bad for high latency links as it has a
32KiB buffer which it serially reads to and writes from.

Ideally you would have a process on each side of the link,
streaming to each other like:

  ssh -C remote tar -c . | tar -xp

Your suggestion of parallelizing the reads on the local
host might help, especially when the processing of each
block takes time. I.E. it would be more beneficial for
gzip than for cp. You could get much the equivalent parallelization
for cp by using tar to continuously read and buffer like:

  tar -c /cifs/ | (cd dest && tar -xp)

This would be better for the local system,
as you would have a single process writing to
the dest, rather than multiple writers competing
for that resource.

Note the latency/throughput of the above, is dictated by
the pipe buffer in the kernel which is 1M on my system
(/proc/sys/fs/pipe-max-size).

You might get more control over the that,
as well as some feedback by putting something
like `pv` between the two tars.

cheers,
Pádraig.


From MAILER-DAEMON Fri Apr 27 12:55:48 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNoSS-000285-3n
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 12:55:48 -0400
Received: from eggs.gnu.org ([208.118.235.92]:46185)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNoSP-00027M-7X
	for coreutils@gnu.org; Fri, 27 Apr 2012 12:55:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNoSN-00026d-7H
	for coreutils@gnu.org; Fri, 27 Apr 2012 12:55:44 -0400
Received: from mx.meyering.net ([88.168.87.75]:49925)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNoSM-00026G-Su
	for coreutils@gnu.org; Fri, 27 Apr 2012 12:55:43 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 0828A6038C
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 18:55:40 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: FYI, more id.c changes
Date: Fri, 27 Apr 2012 18:55:40 +0200
Message-ID: <874ns5ru5v.fsf@rho.meyering.net>
Lines: 84
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 16:55:46 -0000

While investigating today's bug, I noticed that a plain old "id -G"
would call getcon unnecessarily.  It's not going to print a context
string, so it obviously doesn't need to call getcon.

While addressing that, factoring and cleaning up, I noticed this:

    Old behavior: nonsensical diagnostic, since with -Z,
    you don't get the default format:

        $ id -Z -n
        id: cannot print only names or real IDs in default format

    New: -n is ignored with --context (-Z)

        $ src/id -Z -n
        unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023


Considering it's at least two separate issues, I will separate this
into two (or more) patches, with at least one more test:

diff --git a/src/id.c b/src/id.c
index c600e63..c0548bb 100644
--- a/src/id.c
+++ b/src/id.c
@@ -163,30 +163,38 @@ main (int argc, char **argv)
         }
     }

-  if (1 < argc - optind)
+  size_t n_ids = argc - optind;
+  if (1 < n_ids)
     {
       error (0, 0, _("extra operand %s"), quote (argv[optind + 1]));
       usage (EXIT_FAILURE);
     }

-  if (argc - optind == 1 && just_context)
+  if (n_ids && just_context)
     error (EXIT_FAILURE, 0,
            _("cannot print security context when user specified"));

-  /* If we are on a selinux-enabled kernel and no user is specified,
-     get our context. Otherwise, leave the context variable alone -
-     it has been initialized known invalid value and will be not
-     displayed in print_full_info() */
-  if (selinux_enabled && argc == optind)
+  if (just_user + just_group + just_group_list + just_context > 1)
+    error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
+
+  bool default_format = (just_user + just_group + just_group_list
+                         + just_context == 0);
+
+  /* If we are on a selinux-enabled kernel, no user is specified, and
+     either --context is specified or none of (-u,-g,-G) is specified,
+     and we're not in POSIXLY_CORRECT mode, get our context.  Otherwise,
+     leave the context variable alone - it has been initialized to an
+     invalid value that will be not displayed in print_full_info().  */
+  if (selinux_enabled
+      && n_ids == 0
+      && (just_context ||
+          (default_format && ! getenv ("POSIXLY_CORRECT"))))
     {
-      if (getcon (&context) && just_context)
+      if (getcon (&context))
         error (EXIT_FAILURE, 0, _("can't get process context"));
     }

-  if (just_user + just_group + just_group_list + just_context > 1)
-    error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
-
-  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
+  if (default_format && (use_real || use_name))
     error (EXIT_FAILURE, 0,
            _("cannot print only names or real IDs in default format"));

@@ -360,6 +368,6 @@ print_full_info (const char *username)

   /* POSIX mandates the precise output format, and that it not include
      any context=... part, so skip that if POSIXLY_CORRECT is set.  */
-  if (context != NULL && ! getenv ("POSIXLY_CORRECT"))
+  if (context)
     printf (_(" context=%s"), context);
 }


From MAILER-DAEMON Fri Apr 27 13:16:13 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNomD-0000Bn-EX
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 13:16:13 -0400
Received: from eggs.gnu.org ([208.118.235.92]:52857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNom9-0008RY-Un
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:16:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNom7-0003rv-Uy
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:16:09 -0400
Received: from mail-lb0-f169.google.com ([209.85.217.169]:49117)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNom7-0003pU-LS
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:16:07 -0400
Received: by lbjn8 with SMTP id n8so330629lbj.0
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 10:16:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	bh=qi+5f5Uc/CqH5Ne5uRxcwx1YWAIYiuUb8+ghfoztv4w=;
	b=p+fXrUgioCmviQ7IDkHCcZ7PKL1fdQUZxd0027fQrUgGO3TINzM9e/Ehs4113X1j88
	v/4WjouWrV/A15C/Gy+fboijvUyt9IbtKb8P73kNRTeEGKjVVgwy+sXjlRGWC8YTYOOl
	J0vh8L8NhmDAQ+M6sbYqMIflUj/Nsfu7SIV/C1zYRW+/HSfDyO93tYYXFM2fPPcIu1am
	XqAyFiLfpdVPOABIf+GRRu1TBLYH+5aikbfe4INhxe1cVUpFqO9AbyF8B5649XH52E5G
	xmoADTNhHPeETup9x59mUIvgGhTMDzmxD+dkLPnR6TSclYsbQXaDvJcQVqgdMKQ6LW1U
	tC8Q==
Received: by 10.152.103.134 with SMTP id fw6mr2419667lab.20.1335546965323;
	Fri, 27 Apr 2012 10:16:05 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.112.20.164 with HTTP; Fri, 27 Apr 2012 10:15:45 -0700 (PDT)
In-Reply-To: <4F9ABCD8.1070009@draigBrady.com>
References: <4F9AAE09.1010904@gmail.com> <4F9ABCD8.1070009@draigBrady.com>
From: Bruce Korb <bruce.korb@gmail.com>
Date: Fri, 27 Apr 2012 10:15:45 -0700
Message-ID: <CAKRnqN+130RH8gMzAkANK2sC81fBa-8ow8MDWTFaY85KMDTcLQ@mail.gmail.com>
Subject: Re: Another rfe: "cp" this time
To: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigbrady.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.217.169
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 17:16:12 -0000

Thank you for the suggestions.  I did finish my particular task with rsync,
but I'd still like something that finishes in less than 10 hours.  It is lo=
nger
than my work day.   Please note:  my only access is with a CIFS mount.
*NO* shell access.  Thus, anything depending upon remote commands
doesn't work.  This is not the only Windows-centric shop I've seen.

2012/4/27 P=E1draig Brady <P@draigbrady.com>:
>> I can either add this to cp, or roll my own toy. =A0What say you?
>
> Yes, cp is bad for high latency links as it has a
> 32KiB buffer which it serially reads to and writes from.

The throughput is going to be dependent upon how much data CIFS
sends without an ACK.  e.g. 1500 bytes would mean 20 round trips
to fill the 30KB buffer.

> Ideally you would have a process on each side of the link,

Won't work.  :(


From MAILER-DAEMON Fri Apr 27 13:23:09 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNosv-0003sI-GT
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 13:23:09 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48337)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNost-0003rM-72
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:23:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNosr-0007en-Dc
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:23:06 -0400
Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:63745)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNosr-0007eH-3c
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:23:05 -0400
Received: by lagz14 with SMTP id z14so809642lag.0
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 10:23:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	bh=6VIianN1Y514eFWiFteuFmHFOycmoFwe2RdqAjEUKbo=;
	b=PQj0w0uLTmakKvz5L37d1ENRRHioEv1xcELNmo/qP3FLPO+ZjqwY7QsbKA/qZh3m3t
	uI3d8S+Ncu1UpF1+kalWKM1+xxiN5AXbspBfFfQfjFdJt34Nm9H5ouG6VRdkiNpB7bDp
	3omK+jYAvf2E0ObJ8zN+wBk8q0uGUbSpVFSZM5kUK4Wz5jPtKH026eeZl9PZfs1Qvb0N
	f7dGJ/vecbOhSL7FpMsokjhc3pGvkb6L3AhyCJV/KmmDT0KJAYzcG0H0GhCaZB69fD6A
	tNDaJ3E/rKUxmmv5HtYqDAbW8dbBCUiT70p4u7X6ZLHFSb3Zfsd4WZ8fRNUwPouNdgBj
	pLrA==
Received: by 10.112.82.230 with SMTP id l6mr5456720lby.60.1335547382859; Fri,
	27 Apr 2012 10:23:02 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.112.20.164 with HTTP; Fri, 27 Apr 2012 10:22:42 -0700 (PDT)
In-Reply-To: <4F9ABCD8.1070009@draigBrady.com>
References: <4F9AAE09.1010904@gmail.com> <4F9ABCD8.1070009@draigBrady.com>
From: Bruce Korb <bruce.korb@gmail.com>
Date: Fri, 27 Apr 2012 10:22:42 -0700
Message-ID: <CAKRnqNLHiHaB3yfexb-Q8RcpXTHLKY6=XyAuEHof3QgDCeVU5w@mail.gmail.com>
Subject: Re: Another rfe: "cp" this time
To: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigbrady.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.215.41
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 17:23:08 -0000

Oh, just to be clear:

2012/4/27 P=E1draig Brady <P@draigbrady.com>:
> Your suggestion of parallelizing the reads on the local
> host might help, especially when the processing of each
> block takes time. I.E. it would be more beneficial for
> gzip than for cp. You could get much the equivalent parallelization
> for cp by using tar to continuously read and buffer like:
>
> =A0tar -c /cifs/ | (cd dest && tar -xp)
>
> This would be better for the local system,
> as you would have a single process writing to
> the dest, rather than multiple writers competing
> for that resource.
>
> Note the latency/throughput of the above, is dictated by
> the pipe buffer in the kernel which is 1M on my system
> (/proc/sys/fs/pipe-max-size).

The source is one .iso file.  Local fs contention is not an issue, since
I am sure whatever throughput I manage to attain, it won't approach
the capacity of a local disk drive.  Finally, if the resulting file winds u=
p
with a scattered allocation, I can always clean that up with a local
copy.  Copying a 4GB file locally takes no time at all -- by comparison.
My goal is to try to fill the pipe with CIFS data.


From MAILER-DAEMON Fri Apr 27 13:36:08 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNp5U-0000se-4D
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 13:36:08 -0400
Received: from eggs.gnu.org ([208.118.235.92]:44106)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SNmvp-0005Si-R0
	for coreutils@gnu.org; Fri, 27 Apr 2012 11:18:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SNmvk-0002tV-W3
	for coreutils@gnu.org; Fri, 27 Apr 2012 11:18:01 -0400
Received: from plane.gmane.org ([80.91.229.3]:35002)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SNmvk-0002tN-Pa
	for coreutils@gnu.org; Fri, 27 Apr 2012 11:17:56 -0400
Received: from public by plane.gmane.org with local (Exim 4.69)
	(envelope-from <public@plane.gmane.org>) id 1SNmvc-0005Dy-O1
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:17:48 +0200
Received: from mail-out.m-online.net ([212.18.0.10])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <whitebox@nefkom.net>)
	id 1SNmvV-00051r-Lr; Fri, 27 Apr 2012 17:17:41 +0200
Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net
	[192.168.8.180])
	by mail-out.m-online.net (Postfix) with ESMTP id 3VfJfn6GWFz3hhdt;
	Fri, 27 Apr 2012 17:17:37 +0200 (CEST)
Received: from igel.home (ppp-88-217-110-47.dynamic.mnet-online.de
	[88.217.110.47])
	by mail.mnet-online.de (Postfix) with ESMTPA id 3VfJfp0fKxz4KK2Q;
	Fri, 27 Apr 2012 17:17:38 +0200 (CEST)
Received: by igel.home (Postfix, from userid 501)
	id 03474CA2AA; Fri, 27 Apr 2012 17:17:36 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Bruce Korb <public-bruce.korb-Re5JQEeQqe8AvxtiuMwx3w@plane.gmane.org>
Subject: Re: Another rfe:  "cp" this time
References: <4F9AAE09.1010904@gmail.com>
X-Yow: YOU!!  Give me the CUTEST, PINKEST, most charming little
	VICTORIAN DOLLHOUSE you can find!!  An make it SNAPPY!!
Date: Fri, 27 Apr 2012 17:17:36 +0200
In-Reply-To: <4F9AAE09.1010904@gmail.com> (Bruce Korb's message of "Fri, 27
	Apr 2012 07:32:41 -0700")
Message-ID: <m2ehr9qk4v.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 80.91.229.3
X-Mailman-Approved-At: Fri, 27 Apr 2012 13:36:06 -0400
Cc: public-coreutils-mXXj517/zsQ@plane.gmane.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 15:18:03 -0000



Bruce Korb <bruce.korb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> I can either add this to cp, or roll my own toy.  What say you?

Use rsync --partial --append.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



From MAILER-DAEMON Fri Apr 27 13:47:39 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNpGd-0004Gy-LK
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 13:47:39 -0400
Received: from eggs.gnu.org ([208.118.235.92]:39915)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNpGa-00047G-J5
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:47:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNpGX-0005Iv-HQ
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:47:36 -0400
Received: from mail2.vodafone.ie ([213.233.128.44]:22159)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNpGX-0005IG-B1
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:47:33 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApMBAIXamk9tTnli/2dsb2JhbAANN7UFAQEBAwEyAUYFCwsNCwkWDwkDAgECAUUGDQEFAgEBiAS8H5FDBJwTjRM
Received: from unknown (HELO [192.168.1.79]) ([109.78.121.98])
	by mail2.vodafone.ie with ESMTP; 27 Apr 2012 18:47:31 +0100
Message-ID: <4F9ADBB2.9080808@draigBrady.com>
Date: Fri, 27 Apr 2012 18:47:30 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Bruce Korb <bruce.korb@gmail.com>
Subject: Re: Another rfe: "cp" this time
References: <4F9AAE09.1010904@gmail.com> <4F9ABCD8.1070009@draigBrady.com>
	<CAKRnqN+130RH8gMzAkANK2sC81fBa-8ow8MDWTFaY85KMDTcLQ@mail.gmail.com>
In-Reply-To: <CAKRnqN+130RH8gMzAkANK2sC81fBa-8ow8MDWTFaY85KMDTcLQ@mail.gmail.com>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.44
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 17:47:38 -0000

On 04/27/2012 06:15 PM, Bruce Korb wrote:
> Thank you for the suggestions.  I did finish my particular task with rsync,
> but I'd still like something that finishes in less than 10 hours.

Just to be clear, you started with cp, went home, resumed with rsync.
So rsync is not faster here, as there is no remote rsync server.

> It is longer
> than my work day.   Please note:  my only access is with a CIFS mount.
> *NO* shell access.  Thus, anything depending upon remote commands
> doesn't work.  This is not the only Windows-centric shop I've seen.

Sure, I was just comparing all options.

> 2012/4/27 Pádraig Brady <P@draigbrady.com>:
>>> I can either add this to cp, or roll my own toy.  What say you?
>>
>> Yes, cp is bad for high latency links as it has a
>> 32KiB buffer which it serially reads to and writes from.
> 
> The throughput is going to be dependent upon how much data CIFS
> sends without an ACK.  e.g. 1500 bytes would mean 20 round trips
> to fill the 30KB buffer.

If it is 1 large file you could optimize a bit like:

  dd bs=10MB if=/cifs/file of=/local/file

However as you say, if the cifs protocol is not
efficiently streaming over the high latency link
then there's not much we can do.

Note you could test your multiple readers idea simply like:

 (
   dd bs=32KiB skip=0000 seek=0000 count=1000 conv=notrunc &
   dd bs=32KiB skip=1000 seek=1000 count=1000 conv=notrunc &
   dd bs=32KiB skip=2000 seek=2000 count=1000 conv=notrunc
 ) > /local/file < /cifs/file

A simple wrapper could be used to start the correct number of dd processes.

cheers,
Pádraig.


From MAILER-DAEMON Fri Apr 27 13:48:27 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNpHP-0004Lh-PW
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 13:48:27 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40202)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pengyu.ut@gmail.com>) id 1SNpHN-0004LE-BW
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:48:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pengyu.ut@gmail.com>) id 1SNpHL-0005Wd-3U
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:48:24 -0400
Received: from mail-ob0-f169.google.com ([209.85.214.169]:59407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pengyu.ut@gmail.com>) id 1SNpHK-0005Vp-Sk
	for coreutils@gnu.org; Fri, 27 Apr 2012 13:48:23 -0400
Received: by obbeh20 with SMTP id eh20so1619114obb.0
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 10:48:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:date:message-id:subject:from:to:content-type;
	bh=f5rCfO3JoC3eBas9iKjbWoh9zQID4kSZR5QNt0lZPag=;
	b=ztPWgE7hCwukJNdx8ZB4LZN55tyiHRIw8fzvx49HocgnP6gTdcuAKBEKfCajFpkuvH
	EAVPESnGbbcCNS4XrT7lsf6NURjjDKlTHwSYV6LzbRy7F4t16+YL4tPgaBFpMBB/l7O4
	l3DvKqMt4DceeWKuCdNE9YQcdieXFu92D3HGoNmiM08s71zevLJwJnz6QUY3s0EXnIaw
	sQXra+GrCc8AWD8hzEdC22ox3iirNbYUCWHWDCXMZnid7J/EpufUoOJ1XRAvcQ2h8dWh
	XUlyvaK9nBCgO4wYU3vTEPV0IH/i+qk95GZnHW6QEyaSDxqSpy5BdioAYFHAPjnX18Bs
	dblw==
MIME-Version: 1.0
Received: by 10.182.112.41 with SMTP id in9mr15761915obb.40.1335548900139;
	Fri, 27 Apr 2012 10:48:20 -0700 (PDT)
Received: by 10.182.177.5 with HTTP; Fri, 27 Apr 2012 10:48:20 -0700 (PDT)
Date: Fri, 27 Apr 2012 12:48:20 -0500
Message-ID: <CABrM6wnQcJ6s1BuQB60kcH_PMJ4=6-Sz1hsSmn0NQrVoRVsmhQ@mail.gmail.com>
Subject: using tee with mkfifo
From: Peng Yu <pengyu.ut@gmail.com>
To: Coreutils <coreutils@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.214.169
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 17:48:26 -0000

Hi,

The following code hangs there for ever. I don't understand what is
going on. Basically, I tee stdin to two named pipes and cat both
pipes. Could anybody let me know what I am wrong? Thanks!

mkfifo a.suffix b.suffix
echo Hello World | tee a.suffix > b.suffix &
cat a.suffix b.suffix

-- 
Regards,
Peng


From MAILER-DAEMON Fri Apr 27 14:02:50 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNpVK-00086K-60
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 14:02:50 -0400
Received: from eggs.gnu.org ([208.118.235.92]:43434)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNpVG-0007t0-1R
	for coreutils@gnu.org; Fri, 27 Apr 2012 14:02:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNpVD-0004yO-SM
	for coreutils@gnu.org; Fri, 27 Apr 2012 14:02:45 -0400
Received: from mail-lpp01m010-f41.google.com ([209.85.215.41]:61420)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNpVD-0004xG-Iu
	for coreutils@gnu.org; Fri, 27 Apr 2012 14:02:43 -0400
Received: by lagz14 with SMTP id z14so839770lag.0
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 11:02:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	bh=isWsNmXDUH42WTj8Fjd2bVnFdxoD3IQ0N0AEu1cGTvQ=;
	b=Uz+XFKj+DD6XJyCPmnkVPfwBlFwNq2263Ji6NrMmvvMHzlBDT2s8T/pBVnAC4vI0oU
	JCvLrEi8VwHCKm43jBnOT0TDrr6dxQ9UMx5hPFd9gLyLrEgQUVgXz89cBhaBIZ39AIxF
	9k7+YCHQNTuAfetd3O0eeHrFIUUvE25fk2Y2yWNRYDBjTfyR3FqTXxmWv3C/dAaOSaiC
	fkGOwkuvj0SCsR7dvYakpkG5QUJJgiMFfE0V+jqNdz+HAsRR/Kexh1b9GuYLiQ16ZPHv
	/ZmVKQBBx6EORYO5z5REWInGD9JBrIjchaFZt4JStU3heYKAKvgyPO2slhi90wiWgPcb
	y/TA==
Received: by 10.152.124.76 with SMTP id mg12mr5294928lab.6.1335549761162; Fri,
	27 Apr 2012 11:02:41 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.112.20.164 with HTTP; Fri, 27 Apr 2012 11:02:20 -0700 (PDT)
In-Reply-To: <4F9ADBB2.9080808@draigBrady.com>
References: <4F9AAE09.1010904@gmail.com> <4F9ABCD8.1070009@draigBrady.com>
	<CAKRnqN+130RH8gMzAkANK2sC81fBa-8ow8MDWTFaY85KMDTcLQ@mail.gmail.com>
	<4F9ADBB2.9080808@draigBrady.com>
From: Bruce Korb <bruce.korb@gmail.com>
Date: Fri, 27 Apr 2012 11:02:20 -0700
Message-ID: <CAKRnqNJs9zB9i96RiDMNdvuh+R7-b8iEd6uwcu2PpAUnacfNAg@mail.gmail.com>
Subject: Re: Another rfe: "cp" this time
To: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigbrady.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.215.41
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 18:02:48 -0000

Hi,

2012/4/27 P=E1draig Brady <P@draigbrady.com>:
> Just to be clear, you started with cp, went home, resumed with rsync.
> So rsync is not faster here, as there is no remote rsync server.

Exactly.  rsync has a "resume" and that is faster than starting over. :-D

> Note you could test your multiple readers idea simply like:
>
> =A0(
> =A0 dd bs=3D32KiB skip=3D0000 seek=3D0000 count=3D1000 conv=3Dnotrunc &
> =A0 dd bs=3D32KiB skip=3D1000 seek=3D1000 count=3D1000 conv=3Dnotrunc &
> =A0 dd bs=3D32KiB skip=3D2000 seek=3D2000 count=3D1000 conv=3Dnotrunc
     wait
> =A0) > /local/file < /cifs/file
>
> A simple wrapper could be used to start the correct number of dd processe=
s.

Hadn't thought about using multiple dd processes.  (The last "dd" needs to
lose that count option tho.)  Somehow "dd" didn't jump out as the obvious
way to copy files across a high latency link.  :)  Thanks.

That kills the priority for this for me,  but I still think --parallel
is useful.
Multiple concurrent dd processes managed by yourself seems like a
cumbersome way to go.  Cheers - Bruce


From MAILER-DAEMON Fri Apr 27 14:19:02 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNpl0-0004ky-K9
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 14:19:02 -0400
Received: from eggs.gnu.org ([208.118.235.92]:33535)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aristidesfl@gmail.com>) id 1SNpky-0004ko-Nj
	for coreutils@gnu.org; Fri, 27 Apr 2012 14:19:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aristidesfl@gmail.com>) id 1SNpkt-0005gP-Bl
	for coreutils@gnu.org; Fri, 27 Apr 2012 14:19:00 -0400
Received: from mail-wg0-f49.google.com ([74.125.82.49]:47881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aristidesfl@gmail.com>) id 1SNpkt-0005fS-2T
	for coreutils@gnu.org; Fri, 27 Apr 2012 14:18:55 -0400
Received: by wgbds1 with SMTP id ds1so717922wgb.30
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 11:18:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=date:from:to:subject:message-id:user-agent:mime-version
	:content-type; bh=zyp7UKaxMm/bP0wf3QKWAEVQbaAbx0Ku8BH+6iY/3TE=;
	b=Cv8RTptF7vwbyG3sEJ9PxjRpNKBHVP8M0/6AzbrrbWfTGX0CFenrjX/p+WG7O9b9DE
	zvsHtpSAeQxYeSaHZdaAKrCUpmfExCeUoZfbIbyRr2t9OoHkE/zpfFi0l14gFb2YszmZ
	bxA6lcItUM+ZktpeXi3oa2AkEp+40iAeT+cPvDX6qQxxmIe7P+3og+mQZoqpuIF+dkY5
	YZbcTOD0eGTNqCpLQSTK4vxyR+APeFyWaNKtLcS/oKRCgjGSTYONv0dgvVUSbf//Ylfp
	+AnL9dCHuAFzq3o45WzKhSvpWP9Yk7UY+atiJSMKaA+Z6PVV/0W5liroInlT4ULytCg7
	PBAw==
Received: by 10.216.139.79 with SMTP id b57mr7027689wej.37.1335550733131;
	Fri, 27 Apr 2012 11:18:53 -0700 (PDT)
Received: from unknown.home (a89-153-142-45.cpe.netcabo.pt. [89.153.142.45])
	by mx.google.com with ESMTPS id fn2sm10047175wib.0.2012.04.27.11.18.51
	(version=SSLv3 cipher=OTHER); Fri, 27 Apr 2012 11:18:52 -0700 (PDT)
Date: Fri, 27 Apr 2012 19:18:49 +0100 (WEST)
From: user <aristidesfl@gmail.com>
To: coreutils@gnu.org
Subject: Enhacement Request: ls --sort=class (group entries according to the
	indicators appended by -F/--classify)
Message-ID: <alpine.OSX.2.00.1204271915580.5178@unknown.home>
User-Agent: Alpine 2.00 (OSX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 74.125.82.49
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 18:19:02 -0000


>From the man entry:
```
-F, --classify
               append indicator (one of */=>@|) to entries
```

Would be useful, for readability purposes, to be able sort entries 
according the indicators appended by -F/--classify.
A WORD called class could be added to "--sort" for this purpose.

In addition to that, it would be useful to have an option which forced the 
extra entries printed by -a/-A, to be displayed after the rest of the 
normal entries, and be sorted separately from them.


Cheers,
aristidesfl


From MAILER-DAEMON Fri Apr 27 15:32:11 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNqtn-0001hD-LV
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 15:32:11 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56432)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNqtl-0001ga-7n
	for coreutils@gnu.org; Fri, 27 Apr 2012 15:32:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNqtj-0003xF-Dk
	for coreutils@gnu.org; Fri, 27 Apr 2012 15:32:08 -0400
Received: from mail-pb0-f41.google.com ([209.85.160.41]:63878)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNqtj-0003vD-4q
	for coreutils@gnu.org; Fri, 27 Apr 2012 15:32:07 -0400
Received: by pbcup15 with SMTP id up15so1392137pbc.0
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 12:32:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:subject
	:content-type:content-transfer-encoding;
	bh=K/b20S8gibvOspN+7Wle9zMG3z48VSk/tBVjhTphBtk=;
	b=RqrqmbsRVdd1a6DvaDJFflNSTXBoPAdMwvRj2mj6+RR1M10DXQzvL9tJN1qDH3NnMA
	0bjOe///+MAExxNA3afK/zfJ7qVlC92lX7zl5A3/0T3vuIK2D3UWOkKGzpSkQ0itoRdT
	CXDiRdEZfCAQy2MvLkr14F6jg3Y4T+Jf/+SJl6TYfzOHMRTkp0byYpqEc9/C2zs2vfqJ
	GBkpBqJ6XGlVOror8P1sdU0zlrVz7pcThI803E0SG+YBwHlsizzIgoEZ2onP9UjOiN+S
	G4MDOc6f8ze+3XRQp/v+ow5DphkJp9D1JCaJaGNo71PiotecuqmwHA+a3EZMJtU/Co3g
	p/8w==
Received: by 10.68.135.99 with SMTP id pr3mr24876891pbb.95.1335555125194;
	Fri, 27 Apr 2012 12:32:05 -0700 (PDT)
Received: from [192.168.10.2] ([75.0.182.39])
	by mx.google.com with ESMTPS id w10sm7297613pbk.30.2012.04.27.12.32.03
	(version=TLSv1/SSLv3 cipher=OTHER);
	Fri, 27 Apr 2012 12:32:04 -0700 (PDT)
Message-ID: <4F9AF431.5070603@gmail.com>
Date: Fri, 27 Apr 2012 12:32:01 -0700
From: Bruce Korb <bruce.korb@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120328 Thunderbird/11.0.1
MIME-Version: 1.0
To: coreutils@gnu.org
Subject: CIFS is no fun
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.160.41
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 19:32:10 -0000

As of the last writing, I hadn't actually started the rsync
because I just knew it would work.  "rsync --append" apparently
doesn't seek to the point where the last one left off.  I just
took a peek at it and, despite being busy pushing data over the
wire, there was no actual progress.  The file size was not
changing.  Thus, I think it was reading its way to the point
where it left off.  Not useful.

So, next, I tried the "dd" thingy.  The "dd" that started at
the beginning worked fine.  The others copied no data and
exited immediately.

So I tried my "pcopy" program.  Success.  After just a few minutes:

> $ ls -l
> total 106724
> -rw------- 1 bkorb dev 42827776 Apr 27 12:26 iso-0
> -rw------- 1 bkorb dev  9551872 Apr 27 12:26 iso-1
> -rw------- 1 bkorb dev  9551872 Apr 27 12:26 iso-2
> -rw------- 1 bkorb dev  9551872 Apr 27 12:26 iso-3
> -rw------- 1 bkorb dev  9420800 Apr 27 12:25 iso-4
> -rw------- 1 bkorb dev  9420800 Apr 27 12:25 iso-5
> -rw------- 1 bkorb dev  9420800 Apr 27 12:25 iso-6
> -rw------- 1 bkorb dev  9420800 Apr 27 12:25 iso-7
> -rw------- 1 bkorb dev    90112 Apr 27 12:20 iso-8

The data rate is huge (8x speedup) compared to single thread.
(I set the destination to separate files instead of
offsets within the same file.)



From MAILER-DAEMON Fri Apr 27 15:57:46 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNrIY-0003tI-DG
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 15:57:46 -0400
Received: from eggs.gnu.org ([208.118.235.92]:58192)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNrIV-0003rH-69
	for coreutils@gnu.org; Fri, 27 Apr 2012 15:57:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNrIT-0001lu-7O
	for coreutils@gnu.org; Fri, 27 Apr 2012 15:57:42 -0400
Received: from mail2.vodafone.ie ([213.233.128.44]:11150)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SNrIT-0001lV-1e
	for coreutils@gnu.org; Fri, 27 Apr 2012 15:57:41 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApMBADr5mk9tTnli/2dsb2JhbAANN7UUAQEBAwEyAUYFCwsNCwkWDwkDAgECAUUGDQEFAgEBiAS7YJEdBJcOhQWNEw
Received: from unknown (HELO [192.168.1.79]) ([109.78.121.98])
	by mail2.vodafone.ie with ESMTP; 27 Apr 2012 20:57:39 +0100
Message-ID: <4F9AFA32.3040301@draigBrady.com>
Date: Fri, 27 Apr 2012 20:57:38 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Bruce Korb <bruce.korb@gmail.com>
Subject: Re: Another rfe: "cp" this time
References: <4F9AAE09.1010904@gmail.com> <4F9ABCD8.1070009@draigBrady.com>
	<CAKRnqN+130RH8gMzAkANK2sC81fBa-8ow8MDWTFaY85KMDTcLQ@mail.gmail.com>
	<4F9ADBB2.9080808@draigBrady.com>
In-Reply-To: <4F9ADBB2.9080808@draigBrady.com>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 213.233.128.44
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 19:57:44 -0000

On 04/27/2012 06:47 PM, Pádraig Brady wrote:
> On 04/27/2012 06:15 PM, Bruce Korb wrote:
>> Thank you for the suggestions.  I did finish my particular task with rsync,
>> but I'd still like something that finishes in less than 10 hours.
> 
> Just to be clear, you started with cp, went home, resumed with rsync.
> So rsync is not faster here, as there is no remote rsync server.
> 
>> It is longer
>> than my work day.   Please note:  my only access is with a CIFS mount.
>> *NO* shell access.  Thus, anything depending upon remote commands
>> doesn't work.  This is not the only Windows-centric shop I've seen.
> 
> Sure, I was just comparing all options.
> 
>> 2012/4/27 Pádraig Brady <P@draigbrady.com>:
>>>> I can either add this to cp, or roll my own toy.  What say you?
>>>
>>> Yes, cp is bad for high latency links as it has a
>>> 32KiB buffer which it serially reads to and writes from.
>>
>> The throughput is going to be dependent upon how much data CIFS
>> sends without an ACK.  e.g. 1500 bytes would mean 20 round trips
>> to fill the 30KB buffer.
> 
> If it is 1 large file you could optimize a bit like:
> 
>   dd bs=10MB if=/cifs/file of=/local/file
> 
> However as you say, if the cifs protocol is not
> efficiently streaming over the high latency link
> then there's not much we can do.
> 
> Note you could test your multiple readers idea simply like:
> 
>  (
>    dd bs=32KiB skip=0000 seek=0000 count=1000 conv=notrunc &
>    dd bs=32KiB skip=1000 seek=1000 count=1000 conv=notrunc &
>    dd bs=32KiB skip=2000 seek=2000 count=1000 conv=notrunc
>  ) > /local/file < /cifs/file
> 
> A simple wrapper could be used to start the correct number of dd processes.
> 

Actually each dd process would have to maintain the file offsets
independently something like:

> file.out
(
 dd if=file.in of=file.out bs=32KiB skip=000 seek=000 count=100 conv=notrunc &
 dd if=file.in of=file.out bs=32KiB skip=100 seek=100 count=100 conv=notrunc &
 dd if=file.in of=file.out bs=32KiB skip=200 seek=200           conv=notrunc
 wait
)

Could you link to pcopy for reference?

cheers,
Pádraig.


From MAILER-DAEMON Fri Apr 27 16:55:54 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNsCo-0002wk-UC
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 16:55:54 -0400
Received: from eggs.gnu.org ([208.118.235.92]:38292)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsCl-0002wN-Lq
	for coreutils@gnu.org; Fri, 27 Apr 2012 16:55:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsCj-0007t5-G0
	for coreutils@gnu.org; Fri, 27 Apr 2012 16:55:51 -0400
Received: from mx.meyering.net ([88.168.87.75]:50583)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsCj-0007sY-49
	for coreutils@gnu.org; Fri, 27 Apr 2012 16:55:49 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 489AD608BB
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 22:55:45 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: Re: FYI, more id.c changes
In-Reply-To: <874ns5ru5v.fsf@rho.meyering.net> (Jim Meyering's message of
	"Fri, 27 Apr 2012 18:55:40 +0200")
References: <874ns5ru5v.fsf@rho.meyering.net>
Date: Fri, 27 Apr 2012 22:55:45 +0200
Message-ID: <87haw4q4ha.fsf@rho.meyering.net>
Lines: 184
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 20:55:53 -0000

Jim Meyering wrote:
> While investigating today's bug, I noticed that a plain old "id -G"
> would call getcon unnecessarily.  It's not going to print a context
> string, so it obviously doesn't need to call getcon.
>
> While addressing that, factoring and cleaning up, I noticed this:
>
>     Old behavior: nonsensical diagnostic, since with -Z,
>     you don't get the default format:
>
>         $ id -Z -n
>         id: cannot print only names or real IDs in default format
>
>     New: -n is ignored with --context (-Z)
>
>         $ src/id -Z -n
>         unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
>
> Considering it's at least two separate issues, I will separate this
> into two (or more) patches, with at least one more test:

Just as well that I separated them.
In doing so, I found an additional "argc - optind" to factor out.
I haven't added a test for the second or third patches -- out of time,
and they don't seem worth it.  However, if someone else would like to,
you're welcome.

>From a6719d9f7252bbd85eaab840a61dfc93d57b05c5 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 27 Apr 2012 20:44:58 +0200
Subject: [PATCH 1/3] maint: id: minor factorization

* src/id.c (main): Factor out uses of "argc - optind".
Move option-consistency checks to precede the potential getcon call.
---
 src/id.c |   23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/id.c b/src/id.c
index c600e63..e1b51e7 100644
--- a/src/id.c
+++ b/src/id.c
@@ -163,34 +163,35 @@ main (int argc, char **argv)
         }
     }

-  if (1 < argc - optind)
+  size_t n_ids = argc - optind;
+  if (1 < n_ids)
     {
       error (0, 0, _("extra operand %s"), quote (argv[optind + 1]));
       usage (EXIT_FAILURE);
     }

-  if (argc - optind == 1 && just_context)
+  if (n_ids && just_context)
     error (EXIT_FAILURE, 0,
            _("cannot print security context when user specified"));

+  if (just_user + just_group + just_group_list + just_context > 1)
+    error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
+
+  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
+    error (EXIT_FAILURE, 0,
+           _("cannot print only names or real IDs in default format"));
+
   /* If we are on a selinux-enabled kernel and no user is specified,
      get our context. Otherwise, leave the context variable alone -
      it has been initialized known invalid value and will be not
      displayed in print_full_info() */
-  if (selinux_enabled && argc == optind)
+  if (selinux_enabled && n_ids == 0)
     {
       if (getcon (&context) && just_context)
         error (EXIT_FAILURE, 0, _("can't get process context"));
     }

-  if (just_user + just_group + just_group_list + just_context > 1)
-    error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
-
-  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
-    error (EXIT_FAILURE, 0,
-           _("cannot print only names or real IDs in default format"));
-
-  if (argc - optind == 1)
+  if (n_ids == 1)
     {
       struct passwd *pwd = getpwnam (argv[optind]);
       if (pwd == NULL)
--
1.7.10.365.g7cacb


>From fbbb4e0e351f528dc662064b413bcd76c44767fc Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 27 Apr 2012 21:24:03 +0200
Subject: [PATCH 2/3] id: don't call getcon unnecessarily

* src/id.c (main): Invocations like "id" and "id -G" would call getcon
to determine the current security context even though that result would
not be used.  Similarly, when POSIXLY_CORRECT is set.  Rearrange
conditionals and hoist the POSIXLY_CORRECT test so that we call
getcon only when necessary.
---
 src/id.c |   21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/id.c b/src/id.c
index e1b51e7..058622c 100644
--- a/src/id.c
+++ b/src/id.c
@@ -177,16 +177,23 @@ main (int argc, char **argv)
   if (just_user + just_group + just_group_list + just_context > 1)
     error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));

-  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
+  if (default_format && (use_real || use_name))
     error (EXIT_FAILURE, 0,
            _("cannot print only names or real IDs in default format"));

-  /* If we are on a selinux-enabled kernel and no user is specified,
-     get our context. Otherwise, leave the context variable alone -
-     it has been initialized known invalid value and will be not
-     displayed in print_full_info() */
-  if (selinux_enabled && n_ids == 0)
+  bool default_format = (just_user + just_group + just_group_list == 0);
+
+  /* If we are on a selinux-enabled kernel, no user is specified, and
+     either --context is specified or none of (-u,-g,-G) is specified,
+     and we're not in POSIXLY_CORRECT mode, get our context.  Otherwise,
+     leave the context variable alone - it has been initialized to an
+     invalid value that will be not displayed in print_full_info().  */
+  if (selinux_enabled
+      && n_ids == 0
+      && (just_context ||
+          (default_format && ! getenv ("POSIXLY_CORRECT"))))
     {
+      /* Report failure only if --context (-Z) was explicitly requested.  */
       if (getcon (&context) && just_context)
         error (EXIT_FAILURE, 0, _("can't get process context"));
     }
@@ -361,6 +368,6 @@ print_full_info (const char *username)

   /* POSIX mandates the precise output format, and that it not include
      any context=... part, so skip that if POSIXLY_CORRECT is set.  */
-  if (context != NULL && ! getenv ("POSIXLY_CORRECT"))
+  if (context)
     printf (_(" context=%s"), context);
 }
--
1.7.10.365.g7cacb


>From 25464d7db89f873a1cb91932174033ab2a282505 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 27 Apr 2012 21:30:52 +0200
Subject: [PATCH 3/3] id: -Zn/-Zr: avoid an invalid diagnostic

* src/id.c (main): Using -Z with -r or -n would fail with "id: cannot
print only names or real IDs in default format", in spite of that "-Z",
which specifies a non-default format.  Now, it succeeds and ignores
the -n or -r option.  The error was that the test for default_format
was not updated when I added the new --context (-Z) option in
commit v6.9-33-g5320d0f.
---
 src/id.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/id.c b/src/id.c
index 058622c..f70f64f 100644
--- a/src/id.c
+++ b/src/id.c
@@ -181,7 +181,8 @@ main (int argc, char **argv)
     error (EXIT_FAILURE, 0,
            _("cannot print only names or real IDs in default format"));

-  bool default_format = (just_user + just_group + just_group_list == 0);
+  bool default_format = (just_user + just_group + just_group_list
+                         + just_context == 0);

   /* If we are on a selinux-enabled kernel, no user is specified, and
      either --context is specified or none of (-u,-g,-G) is specified,
--
1.7.10.365.g7cacb


From MAILER-DAEMON Fri Apr 27 17:00:19 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNsH5-0003tW-1L
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 17:00:19 -0400
Received: from eggs.gnu.org ([208.118.235.92]:48389)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsH2-0003t7-1l
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:00:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsGz-0001k3-5L
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:00:15 -0400
Received: from mx.meyering.net ([88.168.87.75]:50597)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsGy-0001jI-Pt
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:00:13 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 62EFF600D9
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 23:00:11 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: Re: FYI, more id.c changes
In-Reply-To: <87haw4q4ha.fsf@rho.meyering.net> (Jim Meyering's message of
	"Fri, 27 Apr 2012 22:55:45 +0200")
References: <874ns5ru5v.fsf@rho.meyering.net> <87haw4q4ha.fsf@rho.meyering.net>
Date: Fri, 27 Apr 2012 23:00:11 +0200
Message-ID: <87bomcq49w.fsf@rho.meyering.net>
Lines: 133
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 21:00:18 -0000

Jim Meyering wrote:

> Jim Meyering wrote:
>> While investigating today's bug, I noticed that a plain old "id -G"
>> would call getcon unnecessarily.  It's not going to print a context
>> string, so it obviously doesn't need to call getcon.
>>
>> While addressing that, factoring and cleaning up, I noticed this:
>>
>>     Old behavior: nonsensical diagnostic, since with -Z,
>>     you don't get the default format:
>>
>>         $ id -Z -n
>>         id: cannot print only names or real IDs in default format
>>
>>     New: -n is ignored with --context (-Z)
>>
>>         $ src/id -Z -n
>>         unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
>>
>> Considering it's at least two separate issues, I will separate this
>> into two (or more) patches, with at least one more test:
>
> Just as well that I separated them.
> In doing so, I found an additional "argc - optind" to factor out.
> I haven't added a test for the second or third patches -- out of time,
> and they don't seem worth it.  However, if someone else would like to,
> you're welcome.
>
>>From a6719d9f7252bbd85eaab840a61dfc93d57b05c5 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering@redhat.com>
> Date: Fri, 27 Apr 2012 20:44:58 +0200
> Subject: [PATCH 1/3] maint: id: minor factorization
>
> * src/id.c (main): Factor out uses of "argc - optind".
> Move option-consistency checks to precede the potential getcon call.
> ---
>  src/id.c |   23 ++++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/src/id.c b/src/id.c
> index c600e63..e1b51e7 100644
> --- a/src/id.c
> +++ b/src/id.c
> @@ -163,34 +163,35 @@ main (int argc, char **argv)
>          }
>      }
>
> -  if (1 < argc - optind)
> +  size_t n_ids = argc - optind;
> +  if (1 < n_ids)
>      {
>        error (0, 0, _("extra operand %s"), quote (argv[optind + 1]));
>        usage (EXIT_FAILURE);
>      }
>
> -  if (argc - optind == 1 && just_context)
> +  if (n_ids && just_context)
>      error (EXIT_FAILURE, 0,
>             _("cannot print security context when user specified"));
>
> +  if (just_user + just_group + just_group_list + just_context > 1)
> +    error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
> +
> +  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
> +    error (EXIT_FAILURE, 0,
> +           _("cannot print only names or real IDs in default format"));
> +
>    /* If we are on a selinux-enabled kernel and no user is specified,
>       get our context. Otherwise, leave the context variable alone -
>       it has been initialized known invalid value and will be not
>       displayed in print_full_info() */
> -  if (selinux_enabled && argc == optind)
> +  if (selinux_enabled && n_ids == 0)
>      {
>        if (getcon (&context) && just_context)
>          error (EXIT_FAILURE, 0, _("can't get process context"));
>      }
>
> -  if (just_user + just_group + just_group_list + just_context > 1)
> -    error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
> -
> -  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
> -    error (EXIT_FAILURE, 0,
> -           _("cannot print only names or real IDs in default format"));
> -
> -  if (argc - optind == 1)
> +  if (n_ids == 1)
>      {
>        struct passwd *pwd = getpwnam (argv[optind]);
>        if (pwd == NULL)
> --
> 1.7.10.365.g7cacb
>
>
>>From fbbb4e0e351f528dc662064b413bcd76c44767fc Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering@redhat.com>
> Date: Fri, 27 Apr 2012 21:24:03 +0200
> Subject: [PATCH 2/3] id: don't call getcon unnecessarily
>
> * src/id.c (main): Invocations like "id" and "id -G" would call getcon
> to determine the current security context even though that result would
> not be used.  Similarly, when POSIXLY_CORRECT is set.  Rearrange
> conditionals and hoist the POSIXLY_CORRECT test so that we call
> getcon only when necessary.
> ---
>  src/id.c |   21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/src/id.c b/src/id.c
> index e1b51e7..058622c 100644
> --- a/src/id.c
> +++ b/src/id.c
> @@ -177,16 +177,23 @@ main (int argc, char **argv)
>    if (just_user + just_group + just_group_list + just_context > 1)
>      error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
>
> -  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
> +  if (default_format && (use_real || use_name))
>      error (EXIT_FAILURE, 0,
>             _("cannot print only names or real IDs in default format"));
>
> -  /* If we are on a selinux-enabled kernel and no user is specified,
> -     get our context. Otherwise, leave the context variable alone -
> -     it has been initialized known invalid value and will be not
> -     displayed in print_full_info() */
> -  if (selinux_enabled && n_ids == 0)
> +  bool default_format = (just_user + just_group + just_group_list == 0);

Well, don't waste time looking at those.
In a last-minute rebase, I didn't notice that while
resolving a conflict I moved the declaration of default_format
to be after the first use.  Oops.  Adjusting...


From MAILER-DAEMON Fri Apr 27 17:03:33 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNsKD-0004PT-JW
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 17:03:33 -0400
Received: from eggs.gnu.org ([208.118.235.92]:50276)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsK9-0004OZ-GC
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:03:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsK6-0003Gq-1X
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:03:29 -0400
Received: from mx.meyering.net ([88.168.87.75]:50606)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SNsK5-0003GJ-MN
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:03:25 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 3AEF0600D9
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 23:03:24 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: Re: FYI, more id.c changes
In-Reply-To: <87bomcq49w.fsf@rho.meyering.net> (Jim Meyering's message of
	"Fri, 27 Apr 2012 23:00:11 +0200")
References: <874ns5ru5v.fsf@rho.meyering.net>
	<87haw4q4ha.fsf@rho.meyering.net> <87bomcq49w.fsf@rho.meyering.net>
Date: Fri, 27 Apr 2012 23:03:24 +0200
Message-ID: <871un8q44j.fsf@rho.meyering.net>
Lines: 172
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 21:03:32 -0000

Jim Meyering wrote:
>> Just as well that I separated them.
>> In doing so, I found an additional "argc - optind" to factor out.
>> I haven't added a test for the second or third patches -- out of time,
>> and they don't seem worth it.  However, if someone else would like to,
>> you're welcome.
>>
>>>From a6719d9f7252bbd85eaab840a61dfc93d57b05c5 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <meyering@redhat.com>
>> Date: Fri, 27 Apr 2012 20:44:58 +0200
>> Subject: [PATCH 1/3] maint: id: minor factorization

Here's the respin:
1/3 is the same, but the other two now actually compile.

>From a6719d9f7252bbd85eaab840a61dfc93d57b05c5 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 27 Apr 2012 20:44:58 +0200
Subject: [PATCH 1/3] maint: id: minor factorization

* src/id.c (main): Factor out uses of "argc - optind".
Move option-consistency checks to precede the potential getcon call.
---
 src/id.c |   23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/id.c b/src/id.c
index c600e63..e1b51e7 100644
--- a/src/id.c
+++ b/src/id.c
@@ -163,34 +163,35 @@ main (int argc, char **argv)
         }
     }

-  if (1 < argc - optind)
+  size_t n_ids = argc - optind;
+  if (1 < n_ids)
     {
       error (0, 0, _("extra operand %s"), quote (argv[optind + 1]));
       usage (EXIT_FAILURE);
     }

-  if (argc - optind == 1 && just_context)
+  if (n_ids && just_context)
     error (EXIT_FAILURE, 0,
            _("cannot print security context when user specified"));

+  if (just_user + just_group + just_group_list + just_context > 1)
+    error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
+
+  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
+    error (EXIT_FAILURE, 0,
+           _("cannot print only names or real IDs in default format"));
+
   /* If we are on a selinux-enabled kernel and no user is specified,
      get our context. Otherwise, leave the context variable alone -
      it has been initialized known invalid value and will be not
      displayed in print_full_info() */
-  if (selinux_enabled && argc == optind)
+  if (selinux_enabled && n_ids == 0)
     {
       if (getcon (&context) && just_context)
         error (EXIT_FAILURE, 0, _("can't get process context"));
     }

-  if (just_user + just_group + just_group_list + just_context > 1)
-    error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));
-
-  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
-    error (EXIT_FAILURE, 0,
-           _("cannot print only names or real IDs in default format"));
-
-  if (argc - optind == 1)
+  if (n_ids == 1)
     {
       struct passwd *pwd = getpwnam (argv[optind]);
       if (pwd == NULL)
--
1.7.10.365.g7cacb


>From c8b8279d2bd9ed1005ebbcca018446d3a245b97c Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 27 Apr 2012 21:24:03 +0200
Subject: [PATCH 2/3] id: don't call getcon unnecessarily

* src/id.c (main): Invocations like "id" and "id -G" would call getcon
to determine the current security context even though that result would
not be used.  Similarly, when POSIXLY_CORRECT is set.  Rearrange
conditionals and hoist the POSIXLY_CORRECT test so that we call
getcon only when necessary.
---
 src/id.c |   21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/id.c b/src/id.c
index e1b51e7..da81422 100644
--- a/src/id.c
+++ b/src/id.c
@@ -177,16 +177,23 @@ main (int argc, char **argv)
   if (just_user + just_group + just_group_list + just_context > 1)
     error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));

-  if (just_user + just_group + just_group_list == 0 && (use_real || use_name))
+  bool default_format = (just_user + just_group + just_group_list == 0);
+
+  if (default_format && (use_real || use_name))
     error (EXIT_FAILURE, 0,
            _("cannot print only names or real IDs in default format"));

-  /* If we are on a selinux-enabled kernel and no user is specified,
-     get our context. Otherwise, leave the context variable alone -
-     it has been initialized known invalid value and will be not
-     displayed in print_full_info() */
-  if (selinux_enabled && n_ids == 0)
+  /* If we are on a selinux-enabled kernel, no user is specified, and
+     either --context is specified or none of (-u,-g,-G) is specified,
+     and we're not in POSIXLY_CORRECT mode, get our context.  Otherwise,
+     leave the context variable alone - it has been initialized to an
+     invalid value that will be not displayed in print_full_info().  */
+  if (selinux_enabled
+      && n_ids == 0
+      && (just_context ||
+          (default_format && ! getenv ("POSIXLY_CORRECT"))))
     {
+      /* Report failure only if --context (-Z) was explicitly requested.  */
       if (getcon (&context) && just_context)
         error (EXIT_FAILURE, 0, _("can't get process context"));
     }
@@ -361,6 +368,6 @@ print_full_info (const char *username)

   /* POSIX mandates the precise output format, and that it not include
      any context=... part, so skip that if POSIXLY_CORRECT is set.  */
-  if (context != NULL && ! getenv ("POSIXLY_CORRECT"))
+  if (context)
     printf (_(" context=%s"), context);
 }
--
1.7.10.365.g7cacb


>From c83f723267dff03e954ba77454d51a691dfba1c0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 27 Apr 2012 21:30:52 +0200
Subject: [PATCH 3/3] id: -Zn/-Zr: avoid an invalid diagnostic

* src/id.c (main): Using -Z with -r or -n would fail with "id: cannot
print only names or real IDs in default format", in spite of that "-Z",
which specifies a non-default format.  Now, it succeeds and ignores
the -n or -r option.  The error was that the test for default_format
was not updated when I added the new --context (-Z) option in
commit v6.9-33-g5320d0f.
---
 src/id.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/id.c b/src/id.c
index da81422..158715e 100644
--- a/src/id.c
+++ b/src/id.c
@@ -177,7 +177,8 @@ main (int argc, char **argv)
   if (just_user + just_group + just_group_list + just_context > 1)
     error (EXIT_FAILURE, 0, _("cannot print \"only\" of more than one choice"));

-  bool default_format = (just_user + just_group + just_group_list == 0);
+  bool default_format = (just_user + just_group + just_group_list
+                         + just_context == 0);

   if (default_format && (use_real || use_name))
     error (EXIT_FAILURE, 0,
--
1.7.10.365.g7cacb


From MAILER-DAEMON Fri Apr 27 17:27:51 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNshj-00048X-T2
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 17:27:51 -0400
Received: from eggs.gnu.org ([208.118.235.92]:39073)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNshh-00048P-BO
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:27:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNshf-0002fY-EH
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:27:48 -0400
Received: from mail-pz0-f51.google.com ([209.85.210.51]:36787)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNshf-0002es-27
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:27:47 -0400
Received: by dadz8 with SMTP id z8so1354774dad.38
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 14:27:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type;
	bh=V5zqWvSFLg1Q+5SN0HKxbP/NnYrsEyJ0Zn334l0zfwk=;
	b=rtHCLWjsA1oc8JWZp6lwIaa+Zu8QYgi7peEgA/EvhJaKozeNs5w8pqIc+yYknQfFqa
	Os7g3VvO6Ac2KI2lN03vr2KzJueGFpYQT5l1Sza5lM71OzWpT7WpTA4usb4vdbHMr0aG
	uCE/AOAM5dFJLpEeRF9EXLsB91T3psd4OWybbjsw33PKyNXKzZUZCxgAn6Ke9kUBpKxL
	L/56bL0JjgNwXM/88zsBqXWj4d3KhilAWRWSLaJ7SjmMKfNmHtl51rqDutkVpJzgi6Qo
	0IwXT9oowD1N8cOEEzaFTF8s1zytf7AHURLDR73tKLJ72aWKPQQuymINaKDB7cVUF7cT
	jnSQ==
Received: by 10.68.204.39 with SMTP id kv7mr19557297pbc.155.1335562064626;
	Fri, 27 Apr 2012 14:27:44 -0700 (PDT)
Received: from [192.168.10.2] ([75.0.182.39])
	by mx.google.com with ESMTPS id pn5sm7522123pbb.71.2012.04.27.14.27.42
	(version=TLSv1/SSLv3 cipher=OTHER);
	Fri, 27 Apr 2012 14:27:43 -0700 (PDT)
Message-ID: <4F9B0F4D.8070902@gmail.com>
Date: Fri, 27 Apr 2012 14:27:41 -0700
From: Bruce Korb <bruce.korb@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120328 Thunderbird/11.0.1
MIME-Version: 1.0
To: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
Subject: Re: Another rfe: "cp" this time
References: <4F9AAE09.1010904@gmail.com> <4F9ABCD8.1070009@draigBrady.com>
	<CAKRnqN+130RH8gMzAkANK2sC81fBa-8ow8MDWTFaY85KMDTcLQ@mail.gmail.com>
	<4F9ADBB2.9080808@draigBrady.com> <4F9AFA32.3040301@draigBrady.com>
In-Reply-To: <4F9AFA32.3040301@draigBrady.com>
Content-Type: multipart/mixed; boundary="------------020901060201060503070406"
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.210.51
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 21:27:50 -0000

This is a multi-part message in MIME format.
--------------020901060201060503070406
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

On 04/27/12 12:57, Pádraig Brady wrote:
>> Note you could test your multiple readers idea simply like:
>>
>>   (
>>     dd bs=32KiB skip=0000 seek=0000 count=1000 conv=notrunc&
>>     dd bs=32KiB skip=1000 seek=1000 count=1000 conv=notrunc&
>>     dd bs=32KiB skip=2000 seek=2000 count=1000 conv=notrunc
>>   )>  /local/file<  /cifs/file
>>
>> A simple wrapper could be used to start the correct number of dd processes.
>>
>
> Actually each dd process would have to maintain the file offsets
> independently something like:
>
>> file.out
> (
>   dd if=file.in of=file.out bs=32KiB skip=000 seek=000 count=100 conv=notrunc&
>   dd if=file.in of=file.out bs=32KiB skip=100 seek=100 count=100 conv=notrunc&
>   dd if=file.in of=file.out bs=32KiB skip=200 seek=200           conv=notrunc
>   wait
> )

Well, I tried a non-zero skip by itself and it just died, copying nothing.
So I kicked off the pcopy and, though it is still cranking along,
it won't be 10 hours to finish:

$ ls -gol /mnt/goflex/priv
total 2145624
-rw------- 1 379535360 Apr 27 13:15 iso-0 <<== done
-rw------- 1 259637248 Apr 27 14:23 iso-1
-rw------- 1 259637248 Apr 27 14:23 iso-2
-rw------- 1 259637248 Apr 27 14:23 iso-3
-rw------- 1 259637248 Apr 27 14:23 iso-4
-rw------- 1 259637248 Apr 27 14:23 iso-5
-rw------- 1 259637248 Apr 27 14:23 iso-6
-rw------- 1 259637248 Apr 27 14:23 iso-7
-rw------- 1     90112 Apr 27 12:20 iso-8 <<== done

It is 2/3 done now and 2 hours in.

> Could you link to pcopy for reference?

Link?  no.  Copy?  yes.  But it is a long way from being ready for prime time.
And I think it belongs in "cp". :)

--------------020901060201060503070406
Content-Type: application/x-xz;
 name="pcopy-0.1.tar.xz"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="pcopy-0.1.tar.xz"

/Td6WFoAAATm1rRGAgAhARYAAAB0L+Wj4Mf/K0ldADgYykUQgOR+MEYq1MjlzBDsCXo7g9ob
dI+Xx/EQssC5ea7QV3AUrs4s4Luws/aLJtdSM6Tp5kGLETPgPLgmVcZJmu7ljn2ptBstCYGC
fHgIA/ADNq2DT4rm94yxGtqB5czf99IAiw7X/GO7kfB25m2dCvSpVjgfmijbFG2vhoRgeGae
fYTeh4u72r6CZhXp/XfYjryewHWZszMMkFJhrprahN1jOF7GdSpQPPx5BgroDA2Uh34zKWUi
+2nmVf19/9nrdO8CXfGcB8F3Twj1zSyj2TE+4tFHcSd6uvY2laamb76vAc5AYGhHiBJSii7Z
q7XQMk38/wSWfxkHNbab79tgQ5fUk65WCwrDLqxS3LowbM3GFMJ0K4p4YRw/I8e8z+j0lZsK
bsSXZbNMpyx5YVzc0CIee7hH2DsHDglccGnsphtrlJJpGzwFdGJbLpJKSbvCAc1rKjTw8CNH
5d4NAgEoaNnsheV46F2UtiBf5OMRs4C7ug00iYwe99i8ZRdE4GEy27w/AN/bTB/akNAN/ldH
b1ne7AIWJBcTcZKrprvBopkNAtqCaHCPB9OzelwhEV2LJwhhdm4dBnP3FWzK7+qQqDy7NB6c
qs3RvIHgmav/1/+02zGwV7oIxwGoqnRgiDFC2uNuqfZcfOxvAGAuxBDUjOZAYGjveq0aEod6
dz3d0q2ShIBaXqJCg2qb6lB+lCOUSto1+ktarLOy5d00tSeYreiUhXJWbXTl1UGoxf6crDjt
xUsW3U7Sy3N85K4VAyrPLDLCNTADRbIXuw6wN5XGCG45MZ1mdryFIRV9oYYkPfQ1w3MFlXKM
yyghvc8nXwOdmRGzdrHP0KztbgdR5sAlpkgkD5blTIuZLO/gBQtgagdklfyx3Ufnabvw9yAo
s5BNl8B2ckNYX1455u0L8zYujYPUjjGcMQbymgDSceUpsin9L6xvlW0MIvpVxIbBGiLP0hUY
WGBGpqNc3hIMGUAygyTbkIiFvdHUBDPrPN/PjieNpTzz2P5hyXAgOGbSN2q+Zp9AOoFivFOW
dGsor+LGnv71HPJ7x/wn5/Uz6ZdeyhAYdb2SuJ33kqt8ZDSbnwwZGB26wRjzziYvUHGP0EDe
OYkWhbIMtpkjSMTWbW2pjxgyhtJDDSxi95F0+7Cr6n+KIPsw7zbDnFrKTuXPW76bjpKYN6Fx
kMmUV7pN3WZHqfE1tXkcqS+7I/Oz9C6Na83w7SZT7C7j7nrVh794BvL9ifJKVaQqOqse7xeE
tpxgSBxJNjw5GAk3F1/eMKXmPIv8rTURTC1uPRh8F0IKhrYMInmULWJRVmEqRp3BltILeiPY
lkKtrwxFxwaSjG5+cjFLB6CAlyPy7OWNZsE+brw7mXz62YnmlWXpjKB87tIeFN48Tz68yBUm
MXIeSbZbssW/TZWaNvK/t6TxI8xE2InhBNAvm3dytZxBS7hDgadEWmMqsprSL0hR+Q8bi9f+
pLLqYIUW5POrjBdNhQzFZqIvVGs4A3gZEclkbTst2X9snNKoeyIo9r9peK6JhMNen0NQZ9Oq
ytRjYUKXsmPcQahStDik3pp5K0rvGE21ce+MvCvVQM6ouaIb/z/15wKkC2w7FAdz/dfBe4X2
cqTgffrgDklDUZVke5R5XcCclZohvYDRCFnKOAsSDCbd9IRZOfeyPAaAstOqHm6w4zs4VrYE
gSzsprso2NeLTzEs6olW2fmELvfFW8jt/gHtkauLU3FR9HpooKnIAllNGlknuHf5UR/rbSkl
lX94gWMHQDKDfgRtDTZ0Yp/0R1xmrpbcCG4JQXaU/Xl2X/XSKNK9hW8CY8xVpKVcjZiE3276
7Gyj5q9pIVZNgNB2BZxKaYKgiUadh220C9U3wgVzGrEEealBNv285V5U77KnxnEgN6bcJDeK
CiJjyZSCqMgmbYQd70kMSg9x7Q3LqcAwjbkKDkIeyQoQYn+PN96QMAqNKZoDgnbzuLlkMD7b
dQ3GbGEByd2Xs1O+IOGEGy/YPxCX5fTgzBf8SAc7vPEPT+DO6s+IC/YdEKN0NRNktnYaW7O2
SS5lZEQC4PQ8zTXuCpWf7s6UJp3cfTOPkNkuxiru3Dkd2Br1qLleasTC9Lx+bqcA6vy3hEKo
qb7/tOlmDrPI5lnNCzcoR9PgxnZwmiY47DTFWawuidkvEeVkWx5UCiArhIqvRVB8d1YidjT9
dGbkDjJ6yXQDdGGXusIGsDvbxaiR/CTvvS+k3w0KkdnddWXAR7PX8GWS3y5vpP1QYMAXaZl7
4Sn6frNki+AphCzWiHHSIxEz5V17wiyxX58V2nEPt9xVzTyorHedEjS9spSPerG10FZV8NLc
4tXzIN9IfNWqTHR3Fk7EnBuMMEXTb7L7EeU8v306jxcbUE5s0g/5ag27I6bbMbc+7KFqOyuD
s21SB/r07j9Gde8Aadn2z5BVq9czFvhucLqY9L/NI/duBl3s/m3smKllqIGNB98LD3vWnzYq
/r3b7lNmDCbeKnk/Rx8bCxN2BO/VHPL08+VG+C/eCU9MNTpL3yj4FlQfUQk/1g+XWmgw8nAQ
ZRnEha1u3LhvfuP0N+eWy4sGj5ft72iOCs+beHvSXktBfyOaUtaux8PbI2uLVEbveYWJML/E
4t6yuPZvlZ2pYUMPrZB8UzaVa5GpnNHztrgtEvkId43FndhHJnUNcaADjaKo4V/MEeVLrPw0
0ytuzGL6nJtLiQqwBxDlU5uel18hGQSPJQFSICIH1NPJjrzb+/L0M9k079Co6+RaVX4CPYeQ
m9qvTNny4Qfzjr2o6YjXCgcywnnHewt8fXu+TIrsKHbA3DcYfbHQ8dnpyZYTZjY/lg+t21sh
/R2bSdsu0DD8ORgrDdKij4ePGL3mkLfCbzOOfRFSj6dtENVc8Bv4a43NjyzyURbUVepI4v1M
6HfcvPrJnIbXPvXeQ/p4Kx/0PzSSqxPmuTbYrYkfamEFZHOFs8vMkFhy9ff5lGvH5MRapnSU
BAdamnijpYy87zLtajIs1U0lbJQaj8NdtvTgyxtWe81BCzSJJPkTWFrrlLweiy7IxeMC4/hW
050Uxdtj1WvUd4yADK7vNW2r1Z9Wsp+DgdCT0ifJFUgE43rPZGhL75jCQuLb6TdWdMVMwB5g
n/F+OLiHv/XdacjR2OB5anNZe1UVKKAonVIy6EvuMAimHZRSbpNQNOxZqI9CY39Pvka3bxwm
YODu7nWm4JlTGE2Z3JIrEDJH3ZXsnQa8jRPeYMsQda0Kbox2XUdIGUFzaJZ6Blo2jXG/RdCS
VUWgP1maAE6dFIdZtQy9LNeqeYEWMpYqhzrnj/ZDzSO9/uMraqx0s/BPrAzBNpLGkyyKgvyE
A/GNVXXNqEMwB5cjbRY2s6kY/V69XXhiXrZ7aLMjdUthnJtw/1FwGvIncVOj7ihs5WHzHmaZ
4WP/UW9jrxO/oS0xdQHOofo5CU0Mh49lfVWDFhOVPxE5yvfwvTRAiNs62h5ASDsxtdncF19A
ZvucRdGG7h8Rk2ExuD0UQ6C5JkKlwBwoRdEARo6RKVGFQ9cO7efL9EBT2ZMkRZqsa822Fynp
ChQ2TCIx36H067gESrc98GUMCWfsfQ0KA7+3dEz9B6LJNupUyWXdc6jo0yfMEAQkq66yHA3n
Pr3RZ1o9FXsobMh/GWge+eZPu7Q3ga6EyFk6+JQKWp8VCp+6R7s5uSEKgcMS7jT/n5bCPxb5
+GPURnbOqBpDnogPlL/VZgV8RsfW4H9PrfVndl3NYfU4wAbDWqGixm6NNbAwu+Itcy4BpgrW
e5jBTcoCeT+LySDSxCrJ+UNkTb9vPZ3af9CRFxN6g5ZJFj6ezoLbl9D3ND6cHLkfKzJf/Pzg
Q9B2h1LcbgF2xOZV2GK5MjWJaMeesuuUSL4cyYYuPYs2giTHIyCy5jr11BuoWOBBGzUStl/b
6ILTEg3ygNfYvaJXl64CLsuu3s8nnyHvDWPYJNWtORRQ4ZQ6QSUrOZ0d9G5TeKkzsbz1tzb8
xYNqVu4TgD0jQdEpagRc9GDqjvfkHfuHtvE8GfJKEtP+pyzGByY5BQfYO3PTvbVbPUXF3zmM
9P0Ihg5oiJ+Vu7BFRYqOhJQzU+z7XWmmYe32rQHF1Tw3OZvCaRzbrcxU8Y8ngexYmXV/yDbp
ItsKwJaxLITF7d+aPDNvbGTB+/MUX45GH+i/i01ufCi1Rrzyqm4ZkGV7Z9Astem5dPeJI2M6
9jYQ7xfdkA6DZZrouYl7bvLSO2egPf9v50UUUrARtcrAaXJgdj2nIWnoF/nbSlbMFyFf0y9l
cE2j24giSjUTCYGQwYzOk+HXQ3E4M6jEFox4GduxpWz5sz/zNHbK89VKvOv2glc7eGy+AN6e
oxul5/8OO8USmd3wXgVWK2z4BGvQ8JT6gnUTHb//ZelOPmQgvbDvafv8J2x4Q4lYsBlBT8bn
z+pyGEuXm0XSH1ApARVU7NNNPUjbBaNKNg4gaouPc0jkoLS7uBDh+U7E08hRStl2CdO8bvBq
q88qZhZyCixTK3TJHs3AWvgWO27acpMZc12YNb1/VFN4Q3xAWfWea4Mh8V9yXmQLjA6x1bVD
vvoY8+5bRVr/PmghWVeBd2WiWkqw7u7+2ObCN54lVtqPX0QdP3bHs8dwrDzT9zZWuVlRKUL8
ydPtrjPjCRy+lDCILMWFDFHINs70+xQgY8Hp326XhLbLn0CMxhRbbkV5L0Jabb6ps6rYVlpc
8CKduyq+lYzLDsXR953bUFRYmumYinAFrreo4eYdand8ei+xBB6yc+CtPkbI+kdd9VXAP20D
+WTf1iPLvcNu7vUfHnuxerq0vthUdHhfhmop2ITmb35jm/vkhri37u+tKOkgC7F3MoS9BuFl
1hPw14cKws7r7ypmmWEwUXFjyUwSejwU/FWMjFC0Tc7bPwV0x20ExuBIxqO5QtJZyPqqImab
0H8GxRybvvfOckP93xkjwpXFc8OE75A0QZ7HYZNinBoAx6PZ2MkzpXJMi6rWK21yCld0dURE
mS2ws5ACJCS7aQyd27iiSpztBsibJeWdAbmttMt8rbOzq/slvDDf8YKu3PMrj1C6nyVgN6yC
M782H2NFuyL5afGgkD8jcJtYP4H+RjPUtZuxPiVL3Qn2AQ0Ht6zQl0hZTDkXlGrya/5EZaKO
yISUcJ0FBN4splVI516GhZb15wCrkPDBBQ0u8k3qMGUBGWItWuGDSB4cHaGAsive2k0+y7HK
y2soF/vTBe1Wu3TWaMsviQ06620vUr6w6pps13KRubpUkSDzWUykcWcVPEy7gjhHeNIHc7Ef
+dy+VP8ozrEMnFHYeTt8EpZEZRYQ09dJKmwt0MAqZYIVu7W7z0tqeX9uAArodmcDJgw0MKae
NZ3AvfmU5QmQV0H05xLS+jHzZisHCy1h93ydWTH3j0C9Q8WjA8RtNAgtzuNB2IEUq2enihcx
MA2cjyVpqLVLXoqY5bdd4FM5nXYYe5bVVXAzsNtG4R87YvwD18r6Y7uG+FcsczZPuMlfjAF3
MLfY7aYVk20iKPW/o8k8RSBRH7GvIDMdUOYBZCods7iFlvoPpJDlB2q4X6KjtNxj8H8emZin
upQDGNW9+Nv/XDpiqBqXb+4RXPpzkC0yvHAnG7QqBwiX80E2pj79cz6zD3w1JDDnVZDb8/Rz
TUlNBolqniH9HA2zILZgIlKdL1yrThuisV52zJZqfno0TLfX8NGB1oB61uC94uDBfUE56bw1
kcR3z0riXnGY1EHuzPn0s1Q2Da895JJdmzQuXQzNJrgYq5xQC1DuqU7gOJewf3bwUMbSNArR
txIibNZMe4h3V8w77J4vBsA+MPPkpoRqZ7/e8KTPSp2DJCK8toRBxRPVkdnQvSRcOn/GzIhb
eEThR4HK8cpy3hB+0DF3D8Xinsa2OYLQQRj6E9q0cOz9MEczFjWIdJ7Tw8b43VjGc1kMDwFq
FEQ/ZbdzA0f3EPfLKDjNfHfzQxwttpfLDJ6fz5+bI20liTxFAdyo/yae6bzvqzoGwM8QaqFR
xw0zmgBpKiV/yV+SWyaCkSuUKYipTUkevJtP5/3fec+CVXkauVo3fIuhhEp9L191CGnVY3Xr
FBQ6xtR8XSUBUp0Ortlfx18I5AEZpo1C/o3FudY/EMAAyUy+LtSDRJ9qVhdCvkIuPSDsvub6
j3rIUyKkAQfcpAW0AAaFd6Y6eDIFmOAg3B5g4tXNRyokB2YTLBfqF2wwxSpxdpWtufpXmEyy
VK7EXFbpeOpmdIES8r/hNd6KmTYBLxUTu4UvvmJI9/7y8/vxHuOc7sAdm7TviA9UijKGO3Di
2NiHmTscXHZJH9+cXftgGt1UcuTxv5+yL3majcCUJku8Le5JTcP5IWrgv7CuM1SKDlTNKnZD
z7N55qWw0D5DJmChOlwMmHjbRpMRrEHPsbMF1oC6N3j/ylrlZno56WH8jXTJJAe8qmuoGr7y
E0pO1VrZz7D6s+FbOHfdXTKw5YB+1azl5pOj7coTZsGjyt8e6U7p26usdJGoRw2H+lGiwreJ
8SmDSVcMFZvdEoyejvg8o9/+mycz9YGI70Q3VA0gUnRzvjHvIP9a6rZoPe8DkYQsv1GEV+qh
Yv8r0L9nG+kdiVQUPqXDb7UirDE8U/U2rJCKYYl1RE5oRRbIWdtAhH9XIH/LQM9DY95j63xY
eL7BA512kVonmd/E28GntTtv6KUE7dJqvlN9vG9ysYGShLoyXoZa9GNi7tTGgnVE1iKRaACv
qZ6lfwsKgPyOb2cY/FFSUBIJ3r0w97/Ljmv3YVb1rcxy1bHRVDiEnAbJsEYPjNUSVAEQP0NK
d7PLQAE+yAgdavhrIa9Qz74aPaiyO/5H5xq5T/lSjOwd9+LNSekxGBBd3uN2ECewCa+BEUaw
ZfnxfRU6HJSKIv4YWwkeiMFq9XknqBc2I5J92bj0DUz8N+PAoQdH8bdRJ0tSKBbviYy7gZ3X
z07ZPgyEkg8Whtyps4lBHeAPmYPX64SiSjFNvMAKNRb7eA2hxRJKgvv3tuAFhAkunuhuhZ+1
U6lkAc00MEwGe0Rbvvwy+VKD6tmiiX69CmsGG9GWeu3jlQfbsXO6LA9DqWUEKt+1J2Km0mPN
188IQv43qxIppC3ojtz0RORm7Sav/S1Am1DU9KogzWhGR7IdNOpPcnEs96E0jyPZzn4DtEqX
zI7cZk5y0nuwX4E18EAVd4xH+KAjEexWsD6eA6HhavAMslHocrKyXzsdajikfR0crm/n8G8s
zZgLBDV+4Ia/LaqwAEPHjmSatpZNrhc4+kvTBTSzjJYjj9ax82AFQIA5P7jwoFOPFwLMQOlp
czQZ8vX8gqpzoKZ0Z1e4mEXyExIkKX5jsLIBBwcaGVSWeZP+edoV0rapNrJTc1/afOvv1hMf
vEVBxS0fE5yuxWrgd4Igyf/LYfyemezb4PRaG2IV/pi+yscKcb8kvKRf9yJhEsW0ahScdbgh
d4nAdj7xnO7INBYteGkVN58Xd5R/xMAwdZ9xwb28CkAN7fX54v0Cpxi4MVpbVq2XdCc6mODG
izpLxBbXjrtZOCQPJA7qG93S4X3EUwhZlNlzIvm7Y3oNxQnXsM5o7UTh8b+avrCHj3eJxz4C
HOUjUo5TVofI0yQwIUNpsJcykT2mLn/q635aCa+P8Eluul938goucWg4npZUW6ccoDbrjo+A
sYOOa0Mafq7oZxJHshSmleVgD20xw+CDlBc341bueBNpyioU61TzzceMlfcnj+gmPEiyP+t1
Y53XwlM/IJ40+2Gi9Tr3ss8s2zdPUjJvRt8y0nymJP/YpFpk6Yrn6QgbHC1jmoqGbG0L2la5
o09tTB1tec5PsTpXIaFN79WEca+B4RPhS1rZySFQ/QWM2XUo2ixujjumAYheHV8VxXtkedr2
M07ivJ/v0XbksDBpj5mSIYSc3H5pDiGKZIB8kJ1jHYPhtKVFVx1dv20AUah7SPnRsJnDNvWQ
AlnL/t1ACZAN1an4/c0VehyWPejTjWIQOSftogLfzztc4uvXz8TAhTo/H/KLRhLAIS3Wb9dt
vuBV95oPKwgsm0JS8vAfyz3YzmRgWnxIusxrohPGfsnAoM8SvW/NxSOZjl+EGpUOHrFRvI9r
WucdbdXa+yaLaDWMv/NB/5Kmapc20X/1ekkzAFNjk51+fGzetPKPrF8EWWKzD+gLvUJaG8Bd
sIr+fC4n5xB81ydnimWwU5nzx8qOoc5C9ioNXq6tLl9Vson2S/zrk4Vo4SgkcGbsuhn2r1kb
PKtqPWktTM3lOV4G2UkNlRV2jht5+q/5klWyTyUMCBkbQ72HhJvIqILU2qI53qjdTtWS5uaP
azcIAfp3MYtuyUHJ4GV8IouJ78c0T7T4Folmmyl7xLB0VwIu4Y5AT4ihOg0wS2XJVTdbQR8d
HBhsG/tzlSl/+mBqm6OhaFypH81cLLBayNMsvnoe9lhgh0MCSJIcZ21umebcCeiEuWObFxWQ
vZ8uEH8/npjXxHto/mGv3jwyty/2ftp47ESoawR4iUFnyWF0ElB+DFM5a22cNzVogZi/JVAr
8IDzWYVh7OWcAxR+TgdRBEwcww+f9/QSByAkho2A0bJBvxuPBDmItiG0H9rUafj3vbFePAyr
mJuNrPutq0jX47wFoOoLngmD/Mshb3oC9k+fMpenmjNCWb6BGmIFcG8ShuN5ZzyDexyUODA8
TTO30OrwvbW/tt+oQvK1XgeHyJGt4m7npMZpK9wnpDjBUJ+vNI2ydmjEvzOMyaROIkoo0Pz5
ioVvr42jrmmmF3Whf0NKQ6jYBsRvQ2r/rVxCZYQf1evTB6CgyAHD1nNUcvNxyuQEj6ZGQpgl
dCneYadzbu9wulT6Rwh+Q+k02xD4NInGpJCJoRV5Qt2TwTznfCIUn84pbrqdNValxSVLmtf/
7VRZLZxqbGRiZYTnBE0V0wf9b0BPuUyn6viBc5YOkbKoHARIaM5XKuVA1BKlPQGVvGHZf+TZ
uL7PhK2jHtg7wbz869sg/I6r8bcM1CwtTy1cMBfm7hguj24YDWBUI9j5hGk87rlBbd0dTEp2
1+0PYx3/EkBJ/66+npdTdtCbcZWczNejO/y/EUEjr5yJrVvvSduYDG/XMlcy5YQm7g8ZpjFD
fKOAhvcxEcePjR82qWmaAxnMOvmetBtF7GK+ry4eNPSwt6sAtrXarm0ofJqZtDX7i187B24y
hCTtLNKlt5iqZZMuQzovgKuhXuoH4dT0HOpKUsaeWLoEUyaN1h6YqGbKg0yMV/+3XwvIqKss
Os88iudNsUVmX7Cc0Sff88ZQROsIG/qwt+/YGX0/ir1z8nLsGUoYD3MwJoRIkjV/IWqWvV1w
BFEMxqPgytENOjn5C3o7t0hOLRZUpASSVxgZTFdCUP3QxpO1JlBKXKgcBg9BR5NtCz5aEwv0
bUjuQxl17dHI98EUsoLpSYfLrZQmSixYRKiKdhOXq/ZgW8h4gnGiv12vzzY5t8IjTUedLABB
M82mA0qB1ozA0TbyThnl5ym7Uc1RNa1ju5Uj3Fz0Ka4PRjza+5vb2PAkIwun6WI7lQ3rYdKE
RdZ7+4yD8fxAyY3aD2U9iON4Ni2QnowuCUVifhelv9OqjO21ZPzFcTX108eUjKLq9niYWoPL
AlACvn9bP3gLxCsjf33N30zJ3iaWOme+1K69C9TH2+x5ZrK0/pJV2zNIORlHqQ4YldaLZ3x4
oM8nDTl28wCLIfe18H150ugH19FETBsfCgeWdjpkbdhlJ4q+Ia+L//V7drBgS+ZFhWS69R33
YBvx75ZgVREmgT9yy5Y/f/nFA7KYux+NUn4cPL32TUwL4V3rl02a/W060i8kk527/aIbPUTC
zv9xuKB430VeINsPMAD5hDETfV7Q+dBRfzX7vZh3ywbNeouVDezMgWAQ86xNWIkncg1/ujir
IY6cIIpeS8fg9/phPa/cJ/5DtU7PLLpicc2sl1lwmnJI2HaSlsZcPBHG3JVPW6HzZR+yeg06
rhzXj+7a2U2PLkVpOaSjpB6oObxz2+iYQAJhbJxybF9zezQxjblU1EGuJl7WERK/bTCf+fiw
R+1XZxM7Jqcll2WH8EXCe3DV5pOlMiS77RiaCcsxZZje/SxxnABR2F9umkyR8tq9qUs8cS2g
EITsWDX55nC0lTTBKQCPlnDNZ5zzdSxRPiuu2vqNVthnTkspDsHfyNIf0Z/sngcGk2GVnkSV
FO/uItDOqDiJGYzGq4Ttm0RLJMXqwncXcHfopdhCZYLsHs5dZkzbPFJqKTQ1bNsYHtMF48M1
uiJ4oZBy9OKMWyHoFd8/t7I0IkrOEWYopNETQJu5RKAO+1YhY8d0aeS6a+DEr+xmqtWpT1Za
Lk8QOSNwEKKbWoGoVUAqHXbqOo7o+dmcY5lO5ySAVNmSgM4G3y0PqzFiwdxVlxbzKlhrk5xs
fuiDaOZkYEjh1FX8KBF0acXNT0e78cDVqydpH3DgCijFZ8vAz3hmpU80GPT1TvYOmh8aqMTk
5AwEtwx+zvZbod37hNQg3hGjJxkF/jk59PzH/isc2GHb70H015E6aq/vgz5at5CABRtJ63bD
W+Tk8H29/FC72m1LhiqC0wKSlMzvVWYK5J3mJIglNpffp0logkpqPU4WxlK+0eHAciOzIHUy
rpxNhh6VW87PoR4+JOm9GviukKr0UVwhY3x7oZl2gaMi9MvZNy5kUX8s1DlbOHVnD4WkPXsm
k/PqnvGseMKhHSpkO8E90PbhNd5pC5QxT5uo4+M3Pd8t9HIYBktBrFF79DQZRFzQ8u3NBIkK
JWD8bBcpLMEinPR1qutIRy9+t5U+QRLDfxkZKZvvZA76f2sb7dluP7VCU/Hbs0L3016ZSfaf
DTxx88SYFt5IjowKquRwTMRqL4mEi4C9npb3OmLBufGpG/44ohTQr6/GT9g027Qfoi4NopQy
aatYO8G/YDBqNyT7j3K3YpP43bGyefoezZmpi131BolcFFNtXkIywBXeov1ucUSrLUZWLiKH
ouRQrKZs8BdQc868jc4VWese4mSre4GShTbbkZoHNXUm6n/R7IerIeqkkRfzY2lJbSUefy4u
9AShOeP0bK+XTLzThv1nkSnaBdlgu+GAvkwdRK0Fa62hjxjB5YKxVYw2RU9iOjWZIa9wafst
1gKxynEmyTiU4VLb+zdtx3fxqEnNMiEWPmTF38gL6Ob7hhz0cWWHVvr4crllwNg5Mj1LYFlh
Bo5567pH/DrXgLOaf0kZezaMKCGxdrD9K9a4teQgzsPmDdVMtMK21NihZSzGESmYTtcPviDP
0TkHtgBmKajGk0ytSWwUs4FYW+yVJ7xCVVS1XtaSlqZkhmgbuLqyeuSKjafMlBcVCCEX415l
RLUjrZM7Mz8ls7+E7MwdrsrhXM9HvWQxLQOYxT63+jKDzh5uiM4Q37L+X1q7YEtgaq31/EMy
cdodKWM/0uJaecyx7EiFnq0e4+T8ica63AnJf+O2tx4S0BRT1VOlLcBIU0NcY8Sx+U/+sQbX
ipUgYnKbRrE9inHQ1w6LbKgn5UUY9Y58LlX/pxaxpT4ooXSm8LCH5N0czlfW+ELedcKh+WWP
mJhRw+7MrPGBd8xAU0f1W567jAEV6xUXrPrWiKVEwdXsKIaLo5P5dIGhya1Dwms4/DTzliS3
Mh88UX2oaOhzgfHaIiUPPwz4kHnUJFi8RxDs2hILDCh91kuM69Z3F8pKjg1QUVR8QhmAtvBn
it/+a9mfZMwE3rkGkOsbpcvenX1ln7YKg42IF2wWhf3b28CY5PdSB1+COK1YAMwt2XcO/b34
/LW+covjB24lqfjx5pI1XVvfyAFTqE8suJvgxKEUepv0UbDeIw2xjHeerwnBDotc5hjfqDvW
TXQQeDPwGCi9F8LTMeQX/Rgu28B0VXkymlQQ4lT1sCJD++H5S2szXt0oB+2o/4Cf7UJBIWaF
iTtvaaBh4RKdy/HDWMMtH/Jphv5aOdEZsW1b6lDeKy1plYD4ECiX04Yjq+TL+DcFkx4kc3FR
gMeVbgmB+BW1IOzDLlXsIqSvH+KM6Hb/JT46mnFpqQkH7skil+ynUQEkhcPYVebOInHyBTVs
OO6bGGTR4TQgky6687sDadZOprxBaE2h/qlLVK8hdt05izxCsreQODrur5JvpYeJ6Ut9UT21
gk5fC1GWXPl0Pdnxa4xGXPnTUlryVADJSeDGBfbTFx+xPADojX3Vp/wXJftceykVUK70YF+M
QIOfk6Qpn4jv0tSfFqz+Vd+2pr27GcEzzHiIiOJQ1TJAOXxLFIy9VqWKycYlKIZleXen/4nV
S33rUtr3ZXj/xtsv+bye1AAJ+NQA0TXmgsxrhYve7zT+smY+KHJNsqVVlipd22LtMrewuoIE
eW+wseaQiLXKlCiG1uK/uqA3Q49rUAwSw56lk2+NzvwpodCQRNqN0olVUo0bmZqe5W2Zm4S1
vrOCQ21TB00yivkBp+ck1EewW9k8ERpUxKssgyv46AijE0fjWDBRHwT+GCHLWDTE/TyU8o3j
5iQ3hQhUh659HB8uOhS5ViciVuITA4MF8Gh5mlQ2HXWtB/Y4vtDnPKmkI3ABmZtUpvZG2LqG
kMN56dLt0LstKC4WWfv8I0PcgLUpemPNLXImXi2OefJSJdZ2VS44IISzDlxmaHmrPHty5fed
WYcoXOn1N5FF032mcteyXTLE59VKITVH5BZDDr5n/WmcNlHC4E6pLpoeRitupLQuLNMn4fK8
P5os9W0sHmDa8s70+dJpwda9dd141U6vmmxNDOq4TUU9kCzZW5bMfFxo0dEyQcMtmxZBMDOo
RMhn1E/qtZNKfTXZHS9gVF8OUZqvwyjZbAphqg/Vbz+P4gO2pbGgQES07C1KbzL1RemDyKb7
YCrQ46WIBLPI/lUdJJv577SChY1ueBo6NnZh+ZPhdktRtPAI1mAlzZNVHos91V2OZMWtqZCJ
0k7DaQcOFkNKiUV6cVLDydGXDDv5LyzfEB9/HmXATGtgVDJr5igxoPLqYX//X6wsNrgvVSRD
7oqsvhYS0LWbwCaKeGAFrJi4dHTGjTsnNNBOjdyePmdPl+/cHij+SumbwwNLCC6gAUY0vHti
BDebc3naABw2lkBkBP2BTtZp8YjdzHpdLB6uJ2GeihxCXZqH5k0pAhJsOs1q9Hhrjk605iqo
wM75hv7mWy+t9jHrb2wmkWvzLzqW1znqcCyag6IbmFiv3LcikrulMhupO9tqBA4vWMiJLdZQ
cFN01kKjUCGtc0oMkxQEwO0bUPZ0GP6+2MTEQ+1DMV/F/WunpWbh/QPUm+LEsaQv+k2jT9KY
3VgoFBPLWSoHtYitiahZ5VoaSSetugNLnGcGBUbs50mU3mco2B2k+ZJhILdaEIGVd/s7Sd6l
QalW75iVSPa+CeYXwUPZJnaT77Uu++n9VSMjF4lDjpNRs+Tuy8JUqO7P8cVz9gTARg++N3oe
Zo2LTXf8hwvtGcKckh5CFcb6z8pgs/S9DhjaDvrj7briAREFOQ7fXonkZt+MpEBPe2gO6BzG
CfGREd9ZQAOoWdEquxRmOwjIUu0+31NAveLepDZa3MuLM/6SppQiqn3CParQtAeSfuZebiyO
bsFAVT4i19FDdyL2BzAVCVPNMImtbca10YcFXG9HveCiMeHRFgH7waItPzhFV/gzHIWp3Rsj
aF5LnJRhHrJ3eGulAd/60kbuJT2zB0DYvGqK5JOY0EQViEJGa6wQ1kqqwMNsb2Gu5wTD90MD
2KeOhwoAKGQNc5iWhUyvjc3gchb6UvmTOXeLq6KVKkfpa33wKtIVi5cC/+QWG6mUwyG+njsk
64HazTr+QJ14RCxnE8DjU90PFYdjWB6bRrGG2ww6WRQL0fkBzK52KzoWgzJ2WvMke4sWuUqv
TIJZRYdJZPeqRYWIo3oqCTYqXm85M7rW4r5fEhUXBDwjb9HvrdPuf/fUHBv+gB3gIRt36a0i
HCjxR9HFMKwMEJ85TD4ffm69xRGxOBJSR0q6giMM6LkdU1pnE2/7logQ5D9SP+QKV9iMQVTB
xpdEdZM07q/hZucBnCtZSwkbtjkZ0pYOQM111V+3n3iCqg4zN5PybkgaQkBPwMWptKOrsR5d
Ugrx/ALsjE5qHMe8Aj+SDo67FxOe93QKF1/KH+zlxUotiTtg8sb4V+CgaAtOw5u4ox+76Ooa
Bijen5kd3sVTEL+bzm3VY/Y/s1w6cn7WZTL8G1xOua5AQamDv9LYVS6P9NYjC1ukpgIxKu/s
7QvmkPWx5U3utyBb9kx1Mb/sraz/B9336ySaowhnTJTcoWADQvNoli5NvBvo5ztMbrdJAxAR
sjC07w+CMADUMA8xf2u6OLuAVuhnNmVQZRRvUwbecKO8YzGg2OtBm1ljbMl+DE0NrQequ36k
inPXZoVf5ft0Fm5jriG2YwymGhGDjuVLGK4W3HUGjWmTAVtB8VrcKWP/GzNasulgTW6Hfa7u
DUATWauKVwtesxMsq1MDZPj9FHBe76gwCljCHFF71a5ed8BUaxRbi9usyOiCDgkXU2d1QuqT
nEj73xVollSX6aFGqfcntsABtDaw8fQIcVky9inP6yz46/vuddmriVUBwaOv19bVE40eT7Op
T8DLX3AzM+DsGBtnOxlLA8CpduJMK1PP9rYAaLrbuWFcm4Qdw6kMj2EqSyvm0+ljj6oV09Na
1gzmqQE592/ayIGDUfgbFvKZyeMUYcuwlW1RjPg8mJFCWJiv6hKK2C3K5J/uVnHDRQmVMO96
XSOqWAdnCn8NyNAvX/ArxMP5WagFTdwGkAbKrN9N55PbSb/ZJ3gxQ4QAAAAAACUEdo/9Tj+C
AAHlVoCQAwCPOegJscRn+wIAAAAABFla
--------------020901060201060503070406--


From MAILER-DAEMON Fri Apr 27 17:39:06 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNssc-0007A7-DJ
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 17:39:06 -0400
Received: from eggs.gnu.org ([208.118.235.92]:42280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pengyu.ut@gmail.com>) id 1SNssa-00079y-1o
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:39:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pengyu.ut@gmail.com>) id 1SNssX-0008H1-Q1
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:39:03 -0400
Received: from mail-ob0-f169.google.com ([209.85.214.169]:59867)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pengyu.ut@gmail.com>) id 1SNssX-0008GJ-IO
	for coreutils@gnu.org; Fri, 27 Apr 2012 17:39:01 -0400
Received: by obbeh20 with SMTP id eh20so1904018obb.0
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 14:38:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type:content-transfer-encoding;
	bh=pRAcwE8wE23CZ81I8FLkQQcWZJPZdr+AedcqNgcOuVM=;
	b=oSeWL8hphMnbB/DQ/O/auvdlCYZFJZvcA2LKSTSkimExOUr+ArjuGEWCmeVp11aEMI
	K98+AbdVo6fzSul+vvhzu2dPlEI3AV0HOG+/N13sX03CMCDl+exRxWPzfU7oUpTGlziW
	gUbbMcFCz6V3a+NbJNfbAiODo+lMcgS620wDSy7ZQw9AVetOIUWN1teQ4y9fLgkfxVJB
	QH3LVk+yfBP4SUB5e0Q+TKQOGokv5T9sMGODlrDpF242J1Ir05tH5DIdR50kYzMjQJgR
	sHWA62mHmRsWSRVCgrGqRoazyr0Uybv5mo0JbPUjs4D/G9VEsEGl5TMQ3CGpPTK2vqba
	WTgw==
MIME-Version: 1.0
Received: by 10.60.13.37 with SMTP id e5mr16923789oec.70.1335562739686; Fri,
	27 Apr 2012 14:38:59 -0700 (PDT)
Received: by 10.182.177.5 with HTTP; Fri, 27 Apr 2012 14:38:59 -0700 (PDT)
In-Reply-To: <m2aa1wrjh1.fsf@igel.home>
References: <CABrM6wnQcJ6s1BuQB60kcH_PMJ4=6-Sz1hsSmn0NQrVoRVsmhQ@mail.gmail.com>
	<m2aa1wrjh1.fsf@igel.home>
Date: Fri, 27 Apr 2012 16:38:59 -0500
Message-ID: <CABrM6wkTKcKcAMW66ZumgGoFC-BRyLYcSysme=yWSuKfQagWjQ@mail.gmail.com>
Subject: Re: using tee with mkfifo
From: Peng Yu <pengyu.ut@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.214.169
Cc: Coreutils <coreutils@gnu.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 21:39:05 -0000

On Fri, Apr 27, 2012 at 3:46 PM, Andreas Schwab <schwab@linux-m68k.org> wro=
te:
>
>
> Peng Yu <pengyu.ut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:
>
>> Hi,
>>
>> The following code hangs there for ever. I don't understand what is
>> going on. Basically, I tee stdin to two named pipes and cat both
>> pipes. Could anybody let me know what I am wrong? Thanks!
>>
>> mkfifo a.suffix b.suffix
>> echo Hello World | tee a.suffix > b.suffix &
>
> Here the shell waits for a reader for b.suffix (tee hasn't even been
> started yet).
>
>> cat a.suffix b.suffix
>
> Here cat is waiting for a writer for a.suffix (b.suffix hasn't even been
> considered yet).

So I'll have to use. I think that this will not print the stdin one
after another, rather it will print interleaved stdin. Is there a way
to print stdin one after another without using an external file?

cat a.suffix &
cat b.suffix &

> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint =3D 58CA 54C7 6D53 942B 1756 =A001D3 44D5 214B 8276 4=
ED5
> "And now for something completely different."
>



--=20
Regards,
Peng


From MAILER-DAEMON Fri Apr 27 18:02:05 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNtEr-0002vH-IK
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 18:02:05 -0400
Received: from eggs.gnu.org ([208.118.235.92]:59355)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SNs3x-0001OY-Fa
	for coreutils@gnu.org; Fri, 27 Apr 2012 16:46:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SNs3v-0003Qh-Ld
	for coreutils@gnu.org; Fri, 27 Apr 2012 16:46:45 -0400
Received: from plane.gmane.org ([80.91.229.3]:57887)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <public@plane.gmane.org>) id 1SNs3v-0003Q5-F2
	for coreutils@gnu.org; Fri, 27 Apr 2012 16:46:43 -0400
Received: from public by plane.gmane.org with local (Exim 4.69)
	(envelope-from <public@plane.gmane.org>) id 1SNs3s-0003zb-UW
	for coreutils@gnu.org; Fri, 27 Apr 2012 22:46:40 +0200
Received: from mail-out.m-online.net ([212.18.0.9])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <whitebox@nefkom.net>)
	id 1SNs3n-0003vH-VQ; Fri, 27 Apr 2012 22:46:36 +0200
Received: from frontend1.mail.m-online.net (unknown [192.168.8.180])
	by mail-out.m-online.net (Postfix) with ESMTP id 3VfRyM5083z4KMhy;
	Fri, 27 Apr 2012 22:46:35 +0200 (CEST)
Received: from igel.home (ppp-88-217-110-47.dynamic.mnet-online.de
	[88.217.110.47])
	by mail.mnet-online.de (Postfix) with ESMTPA id 3VfRyM3ty9z4KK5n;
	Fri, 27 Apr 2012 22:46:35 +0200 (CEST)
Received: by igel.home (Postfix, from userid 501)
	id A14ADCA2AA; Fri, 27 Apr 2012 22:46:34 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Peng Yu <public-pengyu.ut-Re5JQEeQqe8AvxtiuMwx3w@plane.gmane.org>
Subject: Re: using tee with mkfifo
References: <CABrM6wnQcJ6s1BuQB60kcH_PMJ4=6-Sz1hsSmn0NQrVoRVsmhQ@mail.gmail.com>
X-Yow: I'm also pre-POURED pre-MEDITATED and pre-RAPHAELITE!!
Date: Fri, 27 Apr 2012 22:46:34 +0200
In-Reply-To: <CABrM6wnQcJ6s1BuQB60kcH_PMJ4=6-Sz1hsSmn0NQrVoRVsmhQ@mail.gmail.com>
	(Peng Yu's message of "Fri, 27 Apr 2012 12:48:20 -0500")
Message-ID: <m2aa1wrjh1.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 80.91.229.3
X-Mailman-Approved-At: Fri, 27 Apr 2012 18:02:04 -0400
Cc: Coreutils <public-coreutils-mXXj517/zsQ@plane.gmane.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 20:46:47 -0000



Peng Yu <pengyu.ut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> Hi,
>
> The following code hangs there for ever. I don't understand what is
> going on. Basically, I tee stdin to two named pipes and cat both
> pipes. Could anybody let me know what I am wrong? Thanks!
>
> mkfifo a.suffix b.suffix
> echo Hello World | tee a.suffix > b.suffix &

Here the shell waits for a reader for b.suffix (tee hasn't even been
started yet).

> cat a.suffix b.suffix

Here cat is waiting for a writer for a.suffix (b.suffix hasn't even been
considered yet).

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



From MAILER-DAEMON Fri Apr 27 22:01:07 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SNwyB-0000dG-Hn
	for mharc-coreutils@gnu.org; Fri, 27 Apr 2012 22:01:07 -0400
Received: from eggs.gnu.org ([208.118.235.92]:43013)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNwy9-0000dA-3i
	for coreutils@gnu.org; Fri, 27 Apr 2012 22:01:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNwy7-000880-Ju
	for coreutils@gnu.org; Fri, 27 Apr 2012 22:01:04 -0400
Received: from mail-pb0-f41.google.com ([209.85.160.41]:39116)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SNwy7-00086z-8T
	for coreutils@gnu.org; Fri, 27 Apr 2012 22:01:03 -0400
Received: by pbcup15 with SMTP id up15so1647869pbc.0
	for <coreutils@gnu.org>; Fri, 27 Apr 2012 19:01:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=sender:message-id:date:from:reply-to:organization:user-agent
	:mime-version:to:cc:subject:references:in-reply-to:content-type;
	bh=1OLwvUDx6rqO0ww1oJnfEhQXq7a2dWiSE29JeRXb93Y=;
	b=A8vOLLv3Kb3vdQ2kkV/kjw67O4E+s8IKSoUSlj9xnawAJBDQjnn3t+lcnKx3KbBlPl
	j333smxp7edJG4t1uzwKBTOi3sjkx/8AYOivxtN0tCjFcQLV/o8N7x4S1YOo3DbjHKDh
	Eo2weIOBuXbOVTj7d0abvxUV+s3P2Bkm9vpTT2/+OALBRHTWU0gmM0f1FM4I4CPjBMoL
	vjQddruOrgRe2O56DAWZ6Oy4LrRBG+EYhsLqbjHCDKi+KMgrnWmoZ1oE7YS0nrKbfWts
	AY3+6hSUrKoADJJSMl4S8caUuqEVI5Fi1YTmGqhwPy7GFMSzqpi9OXl7hH/uBEvLKKUS
	phHA==
Received: by 10.68.204.133 with SMTP id ky5mr3976531pbc.119.1335578461288;
	Fri, 27 Apr 2012 19:01:01 -0700 (PDT)
Received: from [192.168.10.2] ([75.0.182.39])
	by mx.google.com with ESMTPS id rt4sm7356547pbc.3.2012.04.27.19.00.58
	(version=TLSv1/SSLv3 cipher=OTHER);
	Fri, 27 Apr 2012 19:00:59 -0700 (PDT)
Sender: Bruce Korb <bruce.korb@gmail.com>
Message-ID: <4F9B4F59.5070801@gnu.org>
Date: Fri, 27 Apr 2012 19:00:57 -0700
From: Bruce Korb <bkorb@gnu.org>
Organization: FSF
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120328 Thunderbird/11.0.1
MIME-Version: 1.0
To: Bruce Korb <bruce.korb@gmail.com>
Subject: Re: Another rfe: "cp" this time
References: <4F9AAE09.1010904@gmail.com> <4F9ABCD8.1070009@draigBrady.com>
	<CAKRnqN+130RH8gMzAkANK2sC81fBa-8ow8MDWTFaY85KMDTcLQ@mail.gmail.com>
	<4F9ADBB2.9080808@draigBrady.com>
	<4F9AFA32.3040301@draigBrady.com> <4F9B0F4D.8070902@gmail.com>
In-Reply-To: <4F9B0F4D.8070902@gmail.com>
Content-Type: multipart/mixed; boundary="------------070308020401020607010902"
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.160.41
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: bkorb@gnu.org
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Apr 2012 02:01:06 -0000

This is a multi-part message in MIME format.
--------------070308020401020607010902
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 04/27/12 14:27, Bruce Korb wrote:
> Link? no. Copy? yes. But it is a long way from being ready for prime time.
> And I think it belongs in "cp". :)

Not only not ready for prime time, but I hadn't tested it because
the my test file was using the pipe.  "This will work better.", but
it still isn't really a polished product.

--------------070308020401020607010902
Content-Type: application/x-xz;
 name="pcopy-0.2.tar.xz"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="pcopy-0.2.tar.xz"

/Td6WFoAAATm1rRGAgAhARYAAAB0L+Wj4Mf/LIBdADgYykUQgOR+MEdcjT78LK8AOgk7MHO4
ahme7F3L6Drm85eYSZAH3IhMimuYH5WnU4c5Y3DBBMBDxn9cwgNzVDoByFkhJnW5y7atmsbj
piXd419TQQzAV3wH9l1hHKq9ZEmdA0xFaHCgIHzBqt6v6n/7uXAJPmnX9YERjdEuLk3awPQ4
5/WV6Da7A2yrEvAywoU/PQeeCpUjIY83zSHCHMhICe13cZD0upYuQcno5NB9Fuan4s6HNmpm
kjkFsDCGi8FfFC2B0UeqsuBZuiPXWss4NttABqyZey6b/ACxloUxFFme47vvXrsx8SF3DYr1
J+dV/Anz+CewBB2NkbnppB4T68eEO2vb7/3zE+nth5zwf+NKWnDW55UZehjwKCgrJAjGvGHn
oaMfStAYWWzV5gtHkLeQNaSEKPqw9hS1l6QmzHVVEwf+tbYyQWwMiq87hOfXOiiRDCUArtX/
5kbyZzVRXwoAadqIFErp6mQ/VUVJAYM+Ly+CjLckmU4SVCUBdJ88c8DWoUipJVMtFvoBsXvE
vgGBByWfqKCvnxSqSKxBLAPoH8lPs6ndibYBueZyutr9ChmwIoZ/m4maqHt4TrBmX1xxUXoH
+rfp1vadymPN3MKB5i4i3Qh/Y5TQGklpLDufkwZK+wkdeJxzDoX/VSUXgfYll2dQK7P0h2Qa
qhPsPqEdzyXa+MyXbum1VVlHiVi+49+qE/DORtWxscg3EqPbT9suPKiDDSEzZklc3F54//g/
c6qP/Hw3UCBK2kpjw4T/r39ahsGbv3qRAN6qfWi3nCCXbTX0hADlbPdY6kZIzNcoTTjTdNQh
v8WslpOqUyXzJ2OdzEJl4ToohUWGpPukanyA+JU4sy3dLdwl6lzV6AJqkFERrkuCZTWFBr2D
nenUzbZArqTwPbRytfMNrzXC5fJvWNakFk9bXiuhmoRK2UGx3B4ZuVzj38yrnstA7wfj/p5D
xpn332PlcXE/yV+IyRG2z7McDizFxpNh+zo9X0munEVf6pS5FB6Z3JFOJB5kMpK9dRs/tIFZ
AkrnEF7g4+/JbT1yoDPcbMGsPR3bWlj88t4NLfGIc8Id3ejs+HvU+sLPAOfHVKBbXWeHIqU5
rTVbnCorIl0sqVyHTD+aa+1GO+VKna+wdixbs5bS+OiyQzQ7mAz2WZh8vifKsk3D3fsDWS4L
6tVfbf5mlyhaPwVjeSIkbrXy75wg6mBtGB1A7CqCYwLME+2xTJkZx+JwWEFUbCrDKsi0/5Uc
4RZk7P4A5awWk1w7SGCrColT6BKmF0SiZGh997G8O1MGJLzREpBAM+g8h44O6WeubryS4+hW
poZiT1wE+FP98G8CyUWmc4lHF0P+1kgIUzcnY+/exFoxxR8dUu9YU/eJUIXraoHzz9I5zjWu
qE8UvX3VovXytQB3yuab1q94go/VJNI3dfTC6AdZMdLmvdDhglp8S2awoyXnq7P9TBwnVDrK
uD4A+wqbvN2AiP+lbYAzVtPF1Q4ZlOjrbVOGeenEEo3Hw4C/RepJN+IrXMxbvnXmXK2sF/fK
Q4IuMBRgI6NBpPKOgwnQ6twreEEOwIdZkHEgopiLcigkCX+KpsBbrbss+lLeFUm5sasm/BUX
JjjV69t3w7kBa4TvuRbwOfToqaOe9m4mvaptsYfGqlJZFhIoXUsJNeYfGziZ/pjZngjwlVjW
qwcYg/EbprqZBKfnXVKFECCM7NIsYWIYdvF6OzPl+ilqsn3EKQi5ul+4Jvn0DU5VzPa1AVfF
ST0xKjdZTY+JiZ8sHNO6Gqbgl7D8SSEmEpKrD7AIvgjDsg8DTND8L2bGi2lLSGLyf1H9a2ej
mRxzJrwX0GpMYqdf9gT4fx7ri2mzjGYO/PbGMqz938v4ANecQmyImQ7We5gU3oRmi+tiBsYS
3JKUTBG0e1vjFid5KVrCsQq9D372aZZYOeY5wb0rgYpGRDr3IV0kKE0p7BnRCaVIrXSAh2En
X9ze3boewXE5RtJUPSTwRMINR20zt9DBIbdduUb3isQp0R8RpT3XVVNEgKPsq/fXLavE5FCa
8q3eDmKFESTc9hcvqpbsHY7nwFLdCrIBlpGTFG4kK0EW9b588sG03DehVxGbFAXNOn0gTI4O
U+kfJRVjr2Mt8OdCQawooay7WcO1ytPh5idZOdqX/Icq9yK3PgY9K8qy/M10ekPnlUrowKCL
GPWXrtcagH7FGFs+UznDCTGRCRKdAhmnMCqLp29cP1WwLAtKtAaa0arG+rB8IFFBwT5RigIW
kOSyxq81wjrwmk/3HsXlyc77MYP7iawh3RsiDyAbOcA4n2ff+AjM2kdcQnqwM7jV018ZMsVn
4RBixb5bkvBTuhVJDVSejsGSC3DvmLY7PFLoylGgFw26/5xqBTBPtyIEwwvRDxTrMaHPgtuf
5sQGWeeiwkeXbIewBqPm1TdQ+uqr7xQzILXnjfn6lG8fEwy55Ju1OIIh2iid6Z5iVUsobCeS
pPMpIyrH3zq9/F3GWdN8oSvxhj5EXyYQBeYTpZb0+o3GrzoyztTZgjpUhkrHgwFlCW4nmjVe
6kS0bT8pRhGIQO+ytv3Z2OgM2glN3BIE7e3vaM2blNgPwKF4Do+l2i4zFLhdsCENmiY8XW/r
/CFMoHBx5ygyQtb4bx387DHpFDcjRvb7RZLlpD5n6InMV9GgLDFz+CfNwEH++A3vJqQTeYdg
imqZvw+2LdOW7y7ODwq7wq9q4HbuT9PT/hF2SPSXiNmmYGD0Yu8RipEyOWxu6yvH9URpxIc1
uGkaaWbSiScJ4Iz4Au+MTKj1wTc0No3uHb0Tja6zNOoUF6yNKamyhvMzpw2aD/XsLZ7EbgIa
DSjvo0fiX3Vr1B6yTGk2gdviRalI9tUh9Hagg5OGn2Vq0N0XnuiDZpYPAN1R38+LtFcqPRqd
qQZ8Yd/aKzXcuUAClFnjyWM2qJWxfzJQsXSekS8uESmM3B9+h5tLoeOQVtisS2rDkQmUI6XC
K5leMgdrc3Oou4IWJlON0LC9QinqWeURl0tAICZknyjPBlPoE3NLEaQ0ysXSx3jUIbRzan8B
jw2VqKNTNotWjXzw5tVrS67p05Y/Jna3hqNDghEY7dqIZ1XyXVVxF7fI1Q+Hf/HdX/cxb/I8
TwcSLuSSF6ZrJ2mNVjtu+rtnn4LewLgu4RGAfuBidC35S/h2BireKSGduGG8Emp+RnQafHuy
O8yLczFrYRYhLTknmp0IdxROp5kZQUFZC7Byo0nAMfl2WWZhyG4yYtwu054LGKlDmufPdlu5
66SNu+HTfMotmxVtuWbXzTnDyB31cuK2EA3I5Z0TMNmyOGTBAmbkPJfpeP3HdBi/5OGO55xg
MWPusfZLke2oXf44AY6XJIxzZTv469iNJED9JFBvRo602uJgxhASoRHE8xTHvkUbsf4iJdfe
9dd0QKXmUGPMwpyXD8KC0eCqAA5H3v62EGfM8uflRZJSokssWqVrD67RG7vZhVtvkYHFC+gV
9unPR82uA8OvSukI78z3wGffMC8YxKm/6R+G+Qpru51RzEBIkt0yxzMctsnLLxelaeJAstir
ZAguDaChHn2x0T1LPoBMCjDY/SUWMqeJOQUuxGJjkqA+ccOPb/9XmweAstdtezlUmAqQ2ZLD
s/76Jq/s+Un/syIdhptZ1jh8AMIE6boSet5oLW0x/iwRmbbS7XxF32pVwrcojQ2dWd6sUyn2
zNkCN5i2jd0wzTCYXBw3KwyNLiXJWHD/uRgPrTpA/KTh36/W8FNtqLK+HOW6y2i3htNLmVnt
IJpbnYFpy8Fm4fPsUkuZPzgA2fUvBcBaq/EiXeGxZBRmlR7MxdClYHNxK5UfSCYHwgpHeAWc
ouTW5+0HGSQvOSK6/lq/tt8dZblpo8dvI0jKGQ7PxNLOjx2EVAtcJqrdPhjLBZOip3GuUWxE
bNgrsMKb1B45OgTR6p1eAKWdvO91//YqFIx8iBsj8OfsA28uJrb9tENsWfRJy4M6f66itAb2
MFXl4A2rZhoC5J29TeVWiDdjRfgMArKAiB3sO/C2WoRtI13ilFlkRHsejlIjdVuv+7iy80dv
aBiWxuDVhwGKsNirgHf/lnl1KISEjnz45flohZUhL9oo+BezWJQYOZ/u7WcJ9/3o+zQHaFEy
U/9osKAtq+RXCd7MzB6ylQMXEw/hLS3OX7q21tyQrmos92mLlgTLZ7pC/Lzqp7ElLu47rYBe
DY8r1rRGmfwJckz/gP007ECmd7m43aGVBEDBt7YBdUF1HsjauqC1CV819/+dV79V93bCm6tc
HNbtnU2Gq36jLnZDT5PhjvAflH7EYEHGe8+x9YqbKeiieIPkpoEkNr6flthyogCxNj500MuO
whX7bOjI12CUWtVQmJiT/FBZChm6uJ8g7nINFEvqHCW7AuBndGZOQfTWNwE+hROAV2BZdvrm
H2P6YGSD+2G/YOKtV63jdVfMQQqWDulEA1OsOO6gMM6k8Mu3PQFymcJJTE7YeiWKP/MnPcK9
Vnw+HXRmt03s/8nBfmQJcoF8hrkKS2LOJOs2LDSnnt0aV9Zj0HgBslhHfA6UoR5uL5xpoFzS
RPiDbNTLJ8Y1NP2rRjnyWjKQXsXC28ABqMQJPGz6FfCe85+rHK5USgM1BFnuGH1NTQ1CrnXo
peQLvcviCFkQ1d9FdlN6Gtx24nsX1opTHhAAXC4YYSMh4Kkk1GxR/MMEFwolCw4s8sNuhvgg
OmlSjnDww+ZM0UZfv52Opx9KZZ/zD2/mgj3HOExM1aCPatygI1zcmAjEHoM9HakHJJrpyh6o
L8FO6kwu850TbyD+t53ACmn9NGnlcF2Yw9XgVR11hJHuq7IqNrHURnv7MlhB/UqBptB1p9Jk
zOY5+MRn3EnHxgajX+5dQVkc0oREqkEEYLXpF3TWG9EwbzrUYqLBb2MJ+h1w9cvBAdO15e8Y
PfCCbYmqN7NaX7yBZ1RPm/cErf2IlHMVHeQFY4cpsBAux9Pzn8K9/72oWLQacQSX7Z/W8vIN
emvFVedcI6FkI5pp5RghJz5ISm4rcd5ack6ybdU8eMZTJnysItoJWIUmr6hVanOXSVjh0dWE
I0K2Z0xZpJTh/SZWH8GmpeqyIZzuLd/Sy1d/ST9lkdyVcnWpQVHv9s3QTxMmCQ56sG7VWqps
PpRx5KlhfWf5qv22smU32SmulSzODB9bwbKWA8EyLa3MdCVYc0lRWNIQDkGu3PgOpykQba2F
jGjctF4KseCUkd1bIxzsT6sC0HewSbPiqP35YmhyUz3ZBYhhWjNK8V/6frUh5NtXi7OI8NQt
5iNMss2mKhd6xtMAaQqXoP4QYMxVeGL9tf0UtzsM1B1GBnAlxbkh90a8U3Eyp5zT9yl3objX
MEl2DYMYHRUh54aC7bYtGsNs6tquwurUpuWs8AhT6uuSGeRdcPn9y/FQQmurIZftc9HbUvCW
FKN9aYfa6wO2tRsA3dwxR1xr7zpRcYF7Tb/3CRTTsSvpAuMxAolEK/mYIL5JbnQx/4omaGpc
dQ1Fxw2eTyXGxTBfNKgfJ8II0cgvsTZG4kGBMc49miuz4jbGoDUtHE6WoRSpBEGOSLrNoFH4
WqjG//pWQt3mr1kQYO7lekgVwd9nW8Nvo8xKxJWIi3UCcIFzGEDebtuI0ZlV8zlegcqbSEkf
Ww/JZ4jGCeKkW94araudQbd8NwRbXlbeThFSPMYN++TLvIDXCkd2C24u1IIwupSz7WpZmuZe
3cLNAAXpKaqOUS0yOi2FkPUjuQ1PL/F7bUVk2g2lqkWsO4ocwNqiW1DZXYFYoL9VybINUcXq
/K8TZhsaQCLaiA6rCC4ByWj1mzZrUG9f2Bfh5XeFyzmAlTmZLXIFxl/6AuOOebLB9g1xZvIL
lWeAfJEZLI4rbAY/SgEaPEsQTxIjXBeMlZOSYbFDnvDMAd+RJuRhW0N6y5gWc/HMSOPD44Uj
6dwP3mJCRIc++tDHb1a+fc+JjGYQMlM45+Enpq50Mf1sZWPsiVu2PdZQaU5tnHPN2xE2P7op
CDuUqcuIVvlUqgbqxuUBNDhre0hYglSFXHtfQlY7mBr30HpjslYetbsAF22VxrM4ytmJPXuR
2ph1B7MKU7DbRs93sr3L0RJsxXTyKPvzPX8bZIEE3momfS5LsAw/lVgX/Gth0SF/xXEucD3g
CEh2oPi6pt6L+8EoYl69dwuYD+dDBb8NEr4uHVwgDyDidL+QRk8WCbuAJVvIsvF/MYhnwZ/i
6mmXu4nHXAUH6EyQJ3vDf8gJDg4eVuF+ZYzl9GdXIKozbjH149ZZaf2IFDZp/yB0wE1GQh3H
x9xQoy57n7LMPjSjnIgAq6wh7UpO1IjBE0pfkfc2iUFkunQwjoD0u6Vp8yRW6f/OxkMnV3eR
BXO2xLbufkC4bfu7XYck8GQnnDmxw+4N184IdGcfFcdQQNHDSR1gjm1XNrmA4/qzjfqrOWMo
7uifiqxb0le7C+G3xJYPsc45E5q5vuJEzeGOt9XhvKkX5ad6+4S6GW4feB0N9kp50rFOnAJw
OD0ycBEyKRs00cFfwMSsMwd7mFjW62uA9+4Ci2IUm7/uKI2X32715pGEvOhdUfFpaFThEkfg
aPPMFer3LIBjmzKTArfMebqD8kO0C8yhvwwbk6np1Y2Law5v4LvxzdG3fULN9/Vg68WOUDEf
hAnvk/lIG3zLqM6X4rX6FwjCV3vi9v1Lt3is0hLPZMbZJrTZH9WB7CyzkzxW7xhzL32I5ihm
E3Y+Q5v4+rFoY20ieZ+Pohb9mv9MW/9B/3d9Dm7fdAkE3p2vkg+ezSLdnxZzcd7QDZ0hP0+K
ZzCEC+CasrgOJBz5usGtzTtPgbXxF4UtKbO4F5epLPUr1ZkFshaXmE0ooTJeKpkWfAtfhFbm
hl0WNtVFhe29ILa2+xP2jJxnd36EOpGYuKByfPQMdkcf8ez1Qk3g8NhYFwCrzKE28fBwJwtM
q2AAZVJxiZB4Sb4N+1ybwUb4HPa1r+wAUy2RJjKOqGaVBf57fBOjjCw54ju2Hq7WbGpFuU5K
qXKyCAkpSzoXa8KFTrUTFq0KRZR+C716tfU3Lu2o8hx9MVAOlJHmWfug+w9D9gMlYxJ54eS+
EAshC7qFX4lFke8UKIu8ridIPPJNn+7WBp3E7Lx4UpEgNk65ZT5b8N222M9eejFcxOipioLm
9a+87PZgvjob9HzOtZ+HvM60RFSwjNdmKSFJiv2to0rOWOHtPnrCiykahLXjT0JHILfEKCRz
+7L5WQbpdf/diH1PfwFUt/HUXrG1rbZKWPw5+lii7i34p+5b26j5OqdgYLyI5Gb/qtbSKcpE
g5UoSkFmfuoLYyWxXN4Kx6Ylaf6254PJhQ+GYKlhoLWzwxQYt/jndXPJlO3R/NpQQikUol2V
GbGi7CCDt+53JzQ2VGaAxZH9XptaQ4opu2j6x0CkmRGvmGCIBsKuMu1IFrviszGQyy6Sjs8C
geqF6I4odZ+alAnFKxnigzybNuDc7cY7XD21vRzq5ydhuiwzUOwTOWDMWhpgwKcf8iiZA+dF
9zdQa/4XlLON1focgqfFX5gzOLjT4s8QqGGbQMI2Urzr5byOWO7d0poDHAPRvSRN7qD9po4u
atUomRAiA8F3uMszj+8JQwugROIcG3eKg8EvAhNPSfrNSekSUlChvHaiND0QbL1qlYS/JsQj
WqIl9UcgYAnNPQRahN+6WgrYzSvN06JW1SquOYc7yB49IFdyKunC9w6AvCiPGrNyROa/Gg/f
qboJmJHyHQYEO+H74QAuQZIUgd0hNvBjCg5r9I/C9a1Npxio0lhKYjt93nzsbO+GF/Ak1hz1
9motBSjtbByhO+8nGdt/n6nV9TocO35YUrdqSJcBFPAicUvCAAgTchhoNl1NvMAJmgxIY/RW
+0ZULDA3Ch2vcgrtaDekAh4iXx2oyGPSi51ZJcvv/RZM9Cz4JZtGztRRB5Xc5tWPVp7jkwU9
dwgFw/KM7WmS2omal1sLazkUsnW9oWwRaKn0wxGaGoLEncRa72iadJXXp+sNQDZ8ApFnzz8M
YiLAM2kh9qwreAj2VEGFmomkG57A9PEObzG30HuGOKhYkiES+mtowJSFDg906E96VfFG5FSR
8zgvJcP+dksYOk7nOjNUyf5J2uOaHqdm1ASJ76YNOXHJIUQjcKSMkZhNwkA5cAZoZPYXqALS
q4E7A4zHo3wBMqbepRrmAEA8nkPcqnKR528zkmEXkwqbnMZ3w8lcGwR2UH9nMizd4uOswS3Z
JtNd1ZsTtl9cnGCVaKLQ+4oE5mGyuEUSkubF5PbKvtdhwJjGCXb1I3qu+8hZ1frlMUTQwy3/
YIfq1a0cDDEi7oxxcxH8Go+kPL+uMaYOy30ZXuIMkDNoYEVnwQ8SbatqSvhVfG38hveg/v3h
wd2eepDa69VdnRfnJGStqpfKIIkf13OfwGsIOYdmpAxCGSngSG/utUITKKMuSPgMXucVEp+T
F4gweCsqgs7PvNjiwBsEOHGE3u0F99YjSFD0kiDi9yTMu1/tI7F/MEvDlzUrI1ufVBQW5AUs
qkj3N6PhAAA/vsT7APeGqH9lFT3vSwg+QwMYnLr2MSixpJ17Of1gAFSQHX0Z/1Ym83BAzW4r
lfKhdbUaRggkI/oQM8BG7fnJvhB4IHN+M5Xy5lOXtEvIV2OSzCbjbEvVh8Dab6/tAfoiC/z2
gwvAnCjUXcHtIAgy5UseM5onZsKZwGjoXYTj4kViaOI6pXXa94dlleTBQ/gtPPiKQUusQmWU
wzH6EF5BagY0MehAcSmdVqO59FbEk/gDDoJWX88whYb650tBEJMFT7fyr0oLtEIWcy5Ixiqj
QWthLaSZtSM25Zh0rbAAkwkUo5Bf63L07b5fN1dvvq/ufoFmIL1TWxwGlTZljQjrX+v36ru6
aHprWRNVC/SCk4q7dFDUGGxjGQ9HTYY/tov7Qsk6sCHJjY3esF8EFVvSMViAy4aqe0VwqepP
VRLjlpjkwnnYcjZJ7Qj+JrDWK4WVOj4hmVOI08PxRi4akG7zaySyxaZj3x2WgsKKG0DKYBWe
r2QhnWRowBDgEqJzKJ1+4QYbBbz5TvWqKW4aTOXqgl9SfOjhCzVKAkbaMrqUJKfCVxjdIL2R
HDoj+4utspDz63eK/xBQRg9YzBAh5CcSg+jU8dGym/gPb8OLjO/SqvAk/hpToqCKKE80zchC
nxkIupz0vuE9UsHx2A4ZZHtC3Xta6EqieTouYfvu5ba1Gac21n0b+sf72SoLRtgPdrE/JgqA
uNxIm6OQzdYA62n9I4NcDSnUxNCAv+UGHp/+qGyn/dn29XmSA3MNWOU+CFvK5Rf5UhOI2SKD
fFRoivBJNAe2PsP6MjKTyvSoj5YwqDnu7RhNW3ODdtbXBt1TJHWtvY49WUfmIyVbbPXred9z
xhsp0GLtbksfdjO/s5Jbd5Me7HCuNw1Z5LGOv1S1dQ1d0XBVn0BWAjAtwt/MEjcloe/XzYnm
PuytgCiv5q6hy522sF5p3Du3jNxxfdPrKkQlpLzYtnUdBPm/iV9AsaGnPZokJU0E7mJBFyjr
OOM8xlrkiCPZxgUBfOm4dGuC2Bph4GFAkmTzKYpm97HklY1dBJ/f1C+cNzdXLEnCBkCItNbI
msLnm1e9jCk8p4Tynkif5vOaGd5cVhY8IZhUxoWjRTow599XGUNXjgTO3UU7R5IQoKvtZpWI
Bdbp8x69fPx8uXQvwRevoK9T8WQzwbNOYMLOhZGH7/YWP5z9RQpdsr7Zpf5ac83bsl5mBFtM
voA9PzRQMfNGlvjw3gh+IoHJeZzSZ9DlhRgs6a+AzJWrkUWNz3YTDKo+0RD0C3I/NXXhqkIf
4FxWnkKpqn0hG02o4o4bLe1g/ydW2KNB3gXPcEfR8953VADErP0lRDr/Fb4esHTqBvZea59d
7HWoo4ydIRbigMbj0QAzkGjX82SpiFlbm5Wc8793oHXpSUGdv+GUByZYLC3hG5VPlvtZqyg2
hqph1cZokZyUuW4j2BC3ctzo/j1u+JFkqDiArAZ5ER9ngz6mPUGqwPDDVRdZrEUm1dSTLYyk
ANpkLNIb3Oao5dBtPExmgI2cxAAWQZihpVANE51F1cyV1cDm/WgkgkBrpJ0yopA0ezspgXYV
X3ke92IuobncB0isGv1iIs7GCUC1Mzix67InGZVsdyGy9P2XpAG50hyVp4BREUXuRsy/X9iw
cGN1xF2vK5n2VwNmownVDdTKYBf+Ng27+hRVP95MJWc29fm9vC7lNYogBcugYlXEHEZtd/Lp
TtIsNmSGeG48zTaO5chiru/FaTMU5uJwPfb/UhFPMET9kAl6mNFhy5e28JjPccasbpwI6BuW
35Y4rpe11WVgO5L902HoLjGwvW+0Yoqkdlf2O471hmaZdtpKLH29m6P/5f9ix/Q8cfloRfyu
Ex2Nkil4yks7YFj1ysYAanNMlP4INDTmjFPgOUNbU7/8Abz2hi0AYrYyHjPqMDxB0IhbPFAg
BMxWkcZG0ldHwMLRiaJv6VTvv9ri1IUERJneAxHz/EyeRAIvv+riU1wCmYeJdmXXUCnyPRye
c6piy5ix+dkCsqBp5JlOk06L5CWpIPZ2VMgp4vi7jo4JxFcYVHby4q4+JjkFiigacvRUkn89
y8aEgtRwnVb1ZbcOqhWGQO7pjzzjmDIlMU0G0fG5TzzoLSoNqSOxCu328WcH4HGJo4Q6kFEd
2Br75Q6cm6jz2Mqr1RlagKAZMYlThoYrtE05zkpwlLnTyOQNLmMMD0CtayamgNK66jsnfBL1
ANbxur5dQG2ZVENzmrlLcaaKxU3XkMi6lSbmA8fR9rG8S4tJH7FIyVwAFcfSCi85Nrqok3xU
Xw1EOdOBF8d7ZjD7t3Yo4qt2APOuR0/CRnUm6IoCsTaX1rWGpGRuKQatCneC7PvWKOUXj/hc
JDy+6ePiaVOZEBcQEJMqE91PyDwefF+sOmwmgq5mhALDm2I9sHOqf0c4H+Nv14GvXfzsnqsU
adCFMw50fE2GDuVim87jZWByUlFdExiPcYOR30cdN+J0jGwcp/FjE5/uL0UlA6DY1RTXVVmF
FJl13YVohbha3/0EXFwOIMay3j86u/Jru9uUje3lIN29OEpEVe2AFHfoOt8hfAH/AClJPEQp
4yfp3ftirbB4Zgr94eE4tNFUJ59jXOIrfRQo7990S82oE1uYp90zd2SN3HiAC3WDPaLI0FeF
XdPD+n/oXepoZJYo2GVR0UGPl4iVKINlVcwicKPxfHlMbKiRfeGRglXTcwk7yr3NJAat0w8w
vZxm+W94BJ99UTX+W+8WelDsEqHb5tOiMYVs+laCr/ota4ZvXMRZG4XYrfVUAV1HDyxnuvJR
PgrqU6e4e9D8j8AK7zP8u8B6gIaYjxlsF3JMgTPQ0IWCNLeSBbm6obZy+LpMNaISzd/0SDDZ
ej3awmTydVZfHn695PKLW6Szty8qsYpKWbSAtfGMJVSpGoc69c0hktBZ9hJ/pp3WtCDf9wN/
YTryTkqD9hIDZWKpCs6p4PkKAIiMsBJo1AT2+7oyCAsRdUOmbSP/QZagSxGJdmHaU0PZ54Gn
ll44/2LPj+A3j+8/RGNFEv462LL3kmRak4TuW+510U0v8VPP7au++hkVifAHFmLNogcTRTte
oBfz3NzfqzbN5vD6Fow13M+e1CrLLl8OSQcfuKy7wKF7KXMvN66itnCsSEbx+mzoQDyceFJ2
PLZrFVdD4VlLScrs+hNxLAVRGRFMn2bjL0/FRGK0c7yT/ASKAmNDDWVl7LopIkVWOE9ogL4z
814njyZWtNIx+1D5KFGSY7pUGLv2gKzwmkU5z778ltAGWJrc1wE08fvnq4FpqalQO/SF5+7h
8pjLibQHslGKsQRCe3C9HzURNKFHhO2q3atx13ujjCZg7W4idiTZzme3zjgoH1DSKD93QIfS
9inSx39Mm9CxA5+sYUxW7HmFVfGz1DJQegHGjB7IjHlv4l05HkV4FceLLhlLILiHy7G8ilMT
wKcGoI3EihsOmTWQl8xFr06mGzE5oIhHE2QtFMeIiDVAEjAF08dp9CiDZM5LWeuBdGHeYmwm
KEEcxko7VIBZk/TirX7irCLR/+3h/v9a1bOFaC6Q9JXMlO6wjio5S4p5WsZdYsZBc9ENgHnK
9Q/8xNc8gQaMEJeBLGzEkJYoaD3h7K8ikbRJJS3lBIlaa5cchdDrwQi4KzaoXbIeo2IyuQiT
8RcY1kx4SYc2iCNC59I3/m2W8AemNWenEHv7ztHrTxzKfIEapRyCGq/FhUWD2aDYbd1YQ7pe
EPe5j8v2kxm1NTmDBV4whOWXUXa4nWIMwzY/cNq394vW4qKAVYTfFC1F7ZfRioD+5KLOdCNe
mQNjqXUj/Xi1xIrO4u0QHwD/qbuZiMdwX1BRH+lRoEervbZ/TFbMfGSLxcwtmPBxKiqe52s/
UCSBfBzx5xOX0BtGDLNUu0TLLW+hLbxxloolmi5ybyT/15vxn3MeYop1IqtGodSWwMijVhqr
0Vj8avbpPg/0Be/xPw2z/RULrAyiPUEECassIXLgiV86s7MbagKsvIhzWkDJ8R2G30TIN2ZP
ISqg8hFgjLy6osVrW19YqCtyzJ6D3VBwN7TNCGVCLqSr4/JxEl+PhsE8sDccBJXKv4t/lVnC
8kNpIpnVJtudZTwluoov34L8Kb/yQL0hpTZi0tzT+g3FBaePTJg74VF4J4g+WDj/aaIT2nti
n0QyHr4F+kXGbXAMqvIE22vu/CX2zSegEPsAWpa2j2IExDPAZZt33x/p9pnzWfUPq5D1YQNy
DcloD4lCooro+y/fNUATlvdHaxGrupicJVjRA0hOr+4aVSZ+3vSp8sFIj2CmtCyjO7ZYYIGM
S2UwhB7fQXIDOE0T9hd35yAsiB3DOvFUW4jSBtsrtNY0tCoQhmV0/9Nu34QfG+/0H7Edx70y
oh4wkxIZA4ef3ykVlOZXC8dW991kIPMUlpG0pABILqljVJYi+Ak3ZDDYrJfsgOracTjs1JhV
5lpqDINJhpeY2GM/8DWswMQZbva2KV8LkajhzbqbeK7IAwCr/hReXwqcg1kkJ6jNUDrrNxNb
hWZBvQXDf1eyanOKf26QQzAT/Yd5tzEbWDSTX1ZpeNg9YFwpt14ivmnIDh4nElHO4bERgNIo
6TTKevSGj2oS2ihIsGInr8BlHfqk9hUK4AU2DiR4I0C2OchbVsyIMn9a0fQt79KTEObOJMg2
OUOm+yfjeOFm+iMOQQCXQGzqUNICYCjd/K+TYG7GpBx4chCr+LXFTg08Mnj8gshZEbGZh1WT
g1ZRvbFCrS14J2bbISdyw41KlARBSMrRgoBbsURaOMwUAKJB7goqPn5iWUQlSceNRfc0S2M/
UYce2t4NIHsmhOaILYquAzPAwg1JXkEjJv89m0apsxjpCD79mZQOIxXH7NPy/Q8/G//smyi2
LdgfsPuxkRBfmVEmazr+6E3g1UbxcJC7li7wjUx1QxT1GP9mfsEi8fgNigTkyKnPsMzL9PuB
F44EDeK2xc0p+oJh7WbVStP9TUzB3buYh5eNRg5nFWTuGxDZFQbIY48O77gy+ZrmL5yOLArN
CjthEoLfteFbV/dnit96P+OFUo+oY2gQluHX8NIVoJDh8GG68s1YgCfjF7MbX+5fjiqMTSpo
e8zlG+ggbTg0q0eyFC8IF+8iz+Td2y9wktEP9dKGfpMIC6Qo+UozbJWnyxJ+2hGsLArpeiz/
IZFDAkuSV9ChXSd6KveSCwDwlA9Ycdv6lJJJMowBnoxKBOKINTxsWuOWgGeV1B1S3k0NViTM
EfymtJ9iAku8KlTPZWK7ru2/NSc1X7wZ1/RG7UyzADeSKJSivnxVElK2HePsec1ExHJhEftE
RgohP7myBHEWiI0t/be96CC1XlM4DCLQdrQe21mMTfbPwRiw3vXbcqaZsHhd7ktmCzRdGORF
bnhjDymwqZXsC8zWMKd1TdKR2iO0H+b+KxtFL+ohb1HdmIy0fX7zh4rx8lLKB/6HoW9f7Xs+
skoHkNbSz5qopYGSyzmSaoIjd+Vcaw1qCbNF/XSkBZPTq5kFj8qGNGzF0y8x/SbAzgmjKSs8
SDosefpFkTiFxY08QRRagZmYWBs1o+R1UnqfowF0FUFtvDbXaSOThbe3v2n/nqxZl0lRrusv
mpPl1h5zXllK7V7W0nRIDr5FZZo9S7iqy11i+YAFuHjupgXXKdhj+xrb+szNWO405faCG5yr
yhBW74j0F8h5fTi5Z2IAg75wHuCWz07HE5/UDoHeVml+nIQmWaVuI6t160PoVrRHlxK5hdKe
dU5tmB55tLOkoUH2uhBhcBCUjTUpi6kTMTUig7xcRLTtXRzWwbZTdew0VvRDBF+/FopBhwKp
yLRmiC4nB+r/v/q2jD3jql0GoqqjxTPEJp81HgqpEX+vL6H3hjg0itstf4g+N4/M4nVPnc3B
pHC5MWF/EHPL0SPWUVB5Hj2PmDFb391zR/4Q+sNbK8rGqS0vOSaZFsWxlpRhnyCUjO0r8S0H
iFhKw/RYWtJ8/ULvw1Jf5oBM9rGNoWRDbaeu+wye+moUcJbHZQqidDEiMhA6F1qsw9qQKXHk
LwWVwBK69+1O47ce9x3D/lUXBMJU3RmskvW9YbBf5ujON1aLpvPTu/x2/Mt1jfX5kvDQcuL7
1pX5v892a9N+Tf9Alj1SqilUoAoGH3G65O+CbtWrWP+uK9+LoWprd0M1Y702VvKvD32LWM2S
AKnorIXhTnsnSvO9OknsJcZ+6Ues24yOR+vzaXaVUHcUZf4ITqhF59xGKrFfI0NQX8VY88Am
yN5a31sVVNbJimBFykKiI6OTRi0cvgBmbJRR7h/JqHEjF4gHtwFADZh7aeQBkJjAVuFkAef0
bLNThuCfEnsrb6TWZK/q5kOJr89l4NK0cHqiFwZji384+V/e62+Y1uNBh4RALF9UDCGXRqjv
aJDIlAmzih7T1b8fXc91LcLR9DrHvlFexLakoaF13YDfLlW/VLq+BRzrSIZiO+yn68LiOjPe
/EbiYTH9767kKMywBWuQmnuF1av+g01jszMIezqiKs+3lRbfmitdPloFy7uzXF/TE63n9i6p
JwAHoSMb4lGCL/oj7GBQWo7Tsb9UN1NeDtClbe767F45mUCq3A70CYm+6ilkKDAFDi9iEFrN
OYiEtW4uf1eR5o6RKr02kd9JctPJ/J1DQnLrE+EAOM81ibHa4hMAAZxZgJADAFfylaexxGf7
AgAAAAAEWVo=
--------------070308020401020607010902--


From MAILER-DAEMON Mon Apr 30 02:16:46 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOjug-0000pE-PU
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 02:16:46 -0400
Received: from eggs.gnu.org ([208.118.235.92]:50508)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOjud-0000o6-JU
	for coreutils@gnu.org; Mon, 30 Apr 2012 02:16:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOjub-0001pl-Jl
	for coreutils@gnu.org; Mon, 30 Apr 2012 02:16:43 -0400
Received: from mx.meyering.net ([88.168.87.75]:58963)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOjub-0001oh-B8
	for coreutils@gnu.org; Mon, 30 Apr 2012 02:16:41 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id D6F24600A7;
	Mon, 30 Apr 2012 08:16:38 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: =?iso-8859-1?Q?P=E1draig?= Brady <P@draigBrady.com>
Subject: Re: [PATCH] cat, cp, mv, install,
	split: Set the minimum IO block size used, to 64KiB
In-Reply-To: <4E280BBB.5080201@draigBrady.com> (=?iso-8859-1?Q?=22P=E1drai?=
	=?iso-8859-1?Q?g?= Brady"'s message of
	"Thu, 21 Jul 2011 12:21:31 +0100")
References: <4E280BBB.5080201@draigBrady.com>
Date: Mon, 30 Apr 2012 08:16:38 +0200
Message-ID: <87mx5t2189.fsf@rho.meyering.net>
Lines: 56
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: Coreutils <coreutils@gnu.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 06:16:45 -0000

P=E1draig Brady wrote:
> I'm a little wary of this being too aggressive,
> but it does give a noticeable (13%) boost on my new laptop.
> Here are the numbers from dd bs=3D$blksize if=3D/dev/zero of=3D/dev/null
>
>    blksize  system-1   system-2
>    ----------------------------
>       1024  734 MB/s   1.7 GB/s
>       2048  1.3 GB/s   3.0 GB/s
>       4096  2.4 GB/s   5.1 GB/s
>       8192  3.5 GB/s   7.3 GB/s
>      16384  3.9 GB/s   9.4 GB/s
>      32768  5.2 GB/s   9.9 GB/s
>      65536  5.3 GB/s  11.2 GB/s
>     131072  5.5 GB/s  11.8 GB/s
>     262144  5.7 GB/s  11.6 GB/s
>     524288  5.7 GB/s  11.4 GB/s
>    1048576  5.8 GB/s  11.4 GB/s

I think it's time to apply your patch:

    http://lists.gnu.org/archive/html/coreutils/2011-07/msg00059.html

Here are numbers from a 3.2GHz i7-970 with 1333MHz DDR3:

   1024=3D2.6 GB/s
   2048=3D4.4 GB/s
   4096=3D6.5 GB/s
   8192=3D8.5 GB/s
  16384=3D10.1 GB/s
  32768=3D11.1 GB/s
  65536=3D12.0 GB/s
 131072=3D12.3 GB/s
 262144=3D12.5 GB/s
 524288=3D12.5 GB/s
1048576=3D12.6 GB/s

One minor suggestion: change s/1/2/ in "-sINT 1" here.

  +     timeout --foreground -sINT 1 \
  +       dd bs=3D$bs if=3D/dev/zero of=3D/dev/null 2>&1 |
  +        sed -n 's/.* \([0-9.]* [GM]B\/s\)/\1/p'

In this comment:

   for i in $(seq 0 10); do
     bs=3D$((1024*2**$i))
     printf "%7s=3D" $bs
     timeout --foreground -sINT 2 \
       dd bs=3D$bs if=3D/dev/zero of=3D/dev/null 2>&1 |
         sed -n 's/.* \([0-9.]* [GM]B\/s\)/\1/p'
   done

That makes the numbers more reproducible.
Otherwise, for large block sizes, I'm guessing that the
interrupted transfer can make too large a difference.


From MAILER-DAEMON Mon Apr 30 06:18:52 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOngy-0005ST-Qf
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 06:18:52 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SOngw-0005SD-N2
	for coreutils@gnu.org; Mon, 30 Apr 2012 06:18:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SOngu-0002p2-V9
	for coreutils@gnu.org; Mon, 30 Apr 2012 06:18:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41756)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SOngu-0002os-NC
	for coreutils@gnu.org; Mon, 30 Apr 2012 06:18:48 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3UAIkXi015236
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Mon, 30 Apr 2012 06:18:46 -0400
Received: from [10.36.116.46] (ovpn-116-46.ams2.redhat.com [10.36.116.46])
	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q3UAIiAS014549
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
	Mon, 30 Apr 2012 06:18:45 -0400
Message-ID: <4F9E6703.9080802@draigBrady.com>
Date: Mon, 30 Apr 2012 11:18:43 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH] cat, cp, mv, install, split: Set the minimum IO block
	size used, to 64KiB
References: <4E280BBB.5080201@draigBrady.com> <87mx5t2189.fsf@rho.meyering.net>
In-Reply-To: <87mx5t2189.fsf@rho.meyering.net>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	q3UAIkXi015236
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
Cc: Coreutils <coreutils@gnu.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 10:18:52 -0000

On 04/30/2012 07:16 AM, Jim Meyering wrote:
> I think it's time to apply your patch:
>=20
>     http://lists.gnu.org/archive/html/coreutils/2011-07/msg00059.html
>=20
> Here are numbers from a 3.2GHz i7-970 with 1333MHz DDR3:
>=20
>    1024=3D2.6 GB/s
>    2048=3D4.4 GB/s
>    4096=3D6.5 GB/s
>    8192=3D8.5 GB/s
>   16384=3D10.1 GB/s
>   32768=3D11.1 GB/s
>   65536=3D12.0 GB/s
>  131072=3D12.3 GB/s
>  262144=3D12.5 GB/s
>  524288=3D12.5 GB/s
> 1048576=3D12.6 GB/s
>=20
> One minor suggestion: change s/1/2/ in "-sINT 1" here.
>=20
>   +     timeout --foreground -sINT 1 \
>   +       dd bs=3D$bs if=3D/dev/zero of=3D/dev/null 2>&1 |
>   +        sed -n 's/.* \([0-9.]* [GM]B\/s\)/\1/p'
>=20
> In this comment:
>=20
>    for i in $(seq 0 10); do
>      bs=3D$((1024*2**$i))
>      printf "%7s=3D" $bs
>      timeout --foreground -sINT 2 \
>        dd bs=3D$bs if=3D/dev/zero of=3D/dev/null 2>&1 |
>          sed -n 's/.* \([0-9.]* [GM]B\/s\)/\1/p'
>    done
>=20
> That makes the numbers more reproducible.
> Otherwise, for large block sizes, I'm guessing that the
> interrupted transfer can make too large a difference.
>=20

Ok it's safe enough I think.
Pushed.

thanks!
P=E1draig.


From MAILER-DAEMON Mon Apr 30 09:03:30 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOqGI-0007BF-Rj
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 09:03:30 -0400
Received: from eggs.gnu.org ([208.118.235.92]:43591)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOqGC-0007Ar-T0
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:03:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOqG6-0004pm-UP
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:03:24 -0400
Received: from mx.meyering.net ([88.168.87.75]:60060)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOqG6-0004pN-Nx
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:03:18 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 7192060140;
	Mon, 30 Apr 2012 15:03:16 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: =?iso-8859-1?Q?P=E1draig?= Brady <P@draigBrady.com>
Subject: Re: [PATCH] cat, cp, mv, install,
	split: Set the minimum IO block size used, to 64KiB
In-Reply-To: <4F9E6703.9080802@draigBrady.com> (=?iso-8859-1?Q?=22P=E1drai?=
	=?iso-8859-1?Q?g?= Brady"'s message of
	"Mon, 30 Apr 2012 11:18:43 +0100")
References: <4E280BBB.5080201@draigBrady.com>
	<87mx5t2189.fsf@rho.meyering.net> <4F9E6703.9080802@draigBrady.com>
Date: Mon, 30 Apr 2012 15:03:16 +0200
Message-ID: <87ehr5z817.fsf@rho.meyering.net>
Lines: 9
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: Coreutils <coreutils@gnu.org>
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 13:03:29 -0000

P=E1draig Brady wrote:
> On 04/30/2012 07:16 AM, Jim Meyering wrote:
>> I think it's time to apply your patch:
>>
>>     http://lists.gnu.org/archive/html/coreutils/2011-07/msg00059.html
...
> Ok it's safe enough I think.

Thanks.


From MAILER-DAEMON Mon Apr 30 09:08:34 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOqLC-000874-3M
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 09:08:34 -0400
Received: from eggs.gnu.org ([208.118.235.92]:56205)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOqL5-00086s-Tf
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:08:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOqL0-0006rk-0v
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:08:27 -0400
Received: from mx.meyering.net ([88.168.87.75]:60083)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOqKz-0006rR-FR
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:08:21 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id B4F6E6014E
	for <coreutils@gnu.org>; Mon, 30 Apr 2012 15:08:19 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: coreutils@gnu.org
Subject: [PATCH 3/3] maint: prohibit an operator at end of line
Date: Mon, 30 Apr 2012 15:08:19 +0200
Message-ID: <878vhdz7ss.fsf@rho.meyering.net>
Lines: 374
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 13:08:33 -0000

Here's a new syntax-check rule (patch 3/3).
1 and 2 fix violations so that the new check passes.

For now, this is only in coreutils (grep had only two violations),
but given the long list of violations in gnulib's lib/ directory,
it may not be generally appealing enough to be added to gnulib's maint.mk:

    $ git grep -lE '(. [-/+]|&&|\|\|)$' lib
    lib/acosl.c
    lib/c-strcasecmp.c
    lib/c-strncasecmp.c
    lib/file-has-acl.c
    lib/fnmatch_loop.c
    lib/fts.c
    lib/getaddrinfo.c
    lib/getcwd.c
    lib/gl_anyavltree_list2.h
    lib/gl_anyrbtree_list2.h
    lib/gl_avltree_oset.c
    lib/gl_rbtree_oset.c
    lib/idpriv.h
    lib/inet_ntop.c
    lib/inet_pton.c
    lib/mbscasecmp.c
    lib/mbsncasecmp.c
    lib/mktime.c
    lib/mountlist.c
    lib/poll.c
    lib/putenv.c
    lib/ref-add.sin
    lib/ref-del.sin
    lib/regcomp.c
    lib/regexec.c
    lib/select.c
    lib/sigpipe-die.c
    lib/sigpipe-die.h
    lib/sigprocmask.c
    lib/sincosl.c
    lib/strcasecmp.c
    lib/strncasecmp.c
    lib/strptime.c
    lib/strsignal.c
    lib/tanl.c


>From a08fcbb6a08b45cb33eeb42b41cb2c3d3818f756 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Sun, 1 Jan 2012 01:46:34 +0100
Subject: [PATCH 1/3] maint: with split lines, don't leave an operator at end
 of line

Locate most offenders using this command:
  git grep -E '(. [-/+]|&&|\|\|)$' src
* src/copy.c (copy_reg): Split an expression before a binary operator,
not after it.
* src/cut.c (set_fields): Likewise.
* src/id.c (main): Likewise.
* src/install.c (setdefaultfilecon): Likewise.
* src/join.c (ignore_case): Likewise.
* src/pr.c (cols_ready_to_print, init_parameters, print_page): Likewise.
* src/stty.c (set_window_size): Likewise.
* src/wc.c (SUPPORT_OLD_MBRTOWC): Likewise.
* src/who.c (scan_entries): Likewise.
* src/test.c (binary_operator): Join a split line.
---
 src/copy.c    |    4 ++--
 src/cut.c     |    4 ++--
 src/id.c      |    4 ++--
 src/install.c |    4 ++--
 src/join.c    |    2 +-
 src/pr.c      |   22 +++++++++++-----------
 src/stty.c    |    4 ++--
 src/test.c    |    4 ++--
 src/wc.c      |    2 +-
 src/who.c     |    6 +++---
 10 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/src/copy.c b/src/copy.c
index 414fbe0..26bbcf2 100644
--- a/src/copy.c
+++ b/src/copy.c
@@ -1055,8 +1055,8 @@ copy_reg (char const *src_name, char const *dst_name,
                           make_holes, src_name, dst_name,
                           UINTMAX_MAX, &n_read,
                           &wrote_hole_at_eof)
-           || (wrote_hole_at_eof &&
-               ftruncate (dest_desc, n_read) < 0))
+           || (wrote_hole_at_eof
+               && ftruncate (dest_desc, n_read) < 0))
         {
           error (0, errno, _("failed to extend %s"), quote (dst_name));
           return_val = false;
diff --git a/src/cut.c b/src/cut.c
index fed9616..87380ac 100644
--- a/src/cut.c
+++ b/src/cut.c
@@ -372,8 +372,8 @@ set_fields (const char *fieldstr)
           initial = (lhs_specified ? value : 1);
           value = 0;
         }
-      else if (*fieldstr == ',' ||
-               isblank (to_uchar (*fieldstr)) || *fieldstr == '\0')
+      else if (*fieldstr == ','
+               || isblank (to_uchar (*fieldstr)) || *fieldstr == '\0')
         {
           in_digits = false;
           /* Ending the string, or this field/byte sublist. */
diff --git a/src/id.c b/src/id.c
index 158715e..41ae024 100644
--- a/src/id.c
+++ b/src/id.c
@@ -191,8 +191,8 @@ main (int argc, char **argv)
      invalid value that will be not displayed in print_full_info().  */
   if (selinux_enabled
       && n_ids == 0
-      && (just_context ||
-          (default_format && ! getenv ("POSIXLY_CORRECT"))))
+      && (just_context
+          || (default_format && ! getenv ("POSIXLY_CORRECT"))))
     {
       /* Report failure only if --context (-Z) was explicitly requested.  */
       if (getcon (&context) && just_context)
diff --git a/src/install.c b/src/install.c
index 5468d26..854436a 100644
--- a/src/install.c
+++ b/src/install.c
@@ -359,8 +359,8 @@ setdefaultfilecon (char const *file)

   /* If there's an error determining the context, or it has none,
      return to allow default context */
-  if ((matchpathcon (file, st.st_mode, &scontext) != 0) ||
-      STREQ (scontext, "<<none>>"))
+  if ((matchpathcon (file, st.st_mode, &scontext) != 0)
+      || STREQ (scontext, "<<none>>"))
     {
       if (scontext != NULL)
         freecon (scontext);
diff --git a/src/join.c b/src/join.c
index b92c1f8..e39ed87 100644
--- a/src/join.c
+++ b/src/join.c
@@ -173,7 +173,7 @@ static struct line uni_blank;
 /* If nonzero, ignore case when comparing join fields.  */
 static bool ignore_case;

-/* If nonzero, treat the first line of each file as column headers -
+/* If nonzero, treat the first line of each file as column headers --
    join them without checking for ordering */
 static bool join_header_lines;

diff --git a/src/pr.c b/src/pr.c
index f1e310f..2ea586d 100644
--- a/src/pr.c
+++ b/src/pr.c
@@ -781,9 +781,9 @@ cols_ready_to_print (void)

   n = 0;
   for (q = column_vector, i = 0; i < columns; ++q, ++i)
-    if (q->status == OPEN ||
-        q->status == FF_FOUND ||	/* With -b: To print a header only */
-        (storing_columns && q->lines_stored > 0 && q->lines_to_print > 0))
+    if (q->status == OPEN
+        || q->status == FF_FOUND	/* With -b: To print a header only */
+        || (storing_columns && q->lines_stored > 0 && q->lines_to_print > 0))
       ++n;
   return n;
 }
@@ -1275,13 +1275,13 @@ init_parameters (int number_of_files)

       /* To allow input tab-expansion (-e sensitive) use:
          if (number_separator == input_tab_char)
-           number_width = chars_per_number +
-             TAB_WIDTH (chars_per_input_tab, chars_per_number);   */
+           number_width = chars_per_number
+             + TAB_WIDTH (chars_per_input_tab, chars_per_number);   */

       /* Estimate chars_per_text without any margin and keep it constant. */
       if (number_separator == '\t')
-        number_width = chars_per_number +
-          TAB_WIDTH (chars_per_default_tab, chars_per_number);
+        number_width = (chars_per_number
+                        + TAB_WIDTH (chars_per_default_tab, chars_per_number));
       else
         number_width = chars_per_number + 1;

@@ -1297,8 +1297,8 @@ init_parameters (int number_of_files)
         power_10 = 10 * power_10;
     }

-  chars_per_column = (chars_per_line - chars_used_by_number -
-                     (columns - 1) * col_sep_length) / columns;
+  chars_per_column = (chars_per_line - chars_used_by_number
+                      - (columns - 1) * col_sep_length) / columns;

   if (chars_per_column < 1)
     error (EXIT_FAILURE, 0, _("page width too narrow"));
@@ -1836,8 +1836,8 @@ print_page (void)
                 {
                   if (empty_line)
                     align_empty_cols = true;
-                  else if (p->status == CLOSED ||
-                           (p->status == ON_HOLD && FF_only))
+                  else if (p->status == CLOSED
+                           || (p->status == ON_HOLD && FF_only))
                     align_column (p);
                 }
             }
diff --git a/src/stty.c b/src/stty.c
index 8e36593..eb07f85 100644
--- a/src/stty.c
+++ b/src/stty.c
@@ -1344,8 +1344,8 @@ set_window_size (int rows, int cols, char const *device_name)
      it's almost certainly a "struct winsize" instead.

      At any rate, the bug manifests itself when ws_row == 0; the symptom is
-     that ws_row is set to ws_col, and ws_col is set to (ws_xpixel<<16) +
-     ws_ypixel.  Since GNU stty sets rows and columns separately, this bug
+     that ws_row is set to ws_col, and ws_col is set to (ws_xpixel<<16)
+     + ws_ypixel.  Since GNU stty sets rows and columns separately, this bug
      caused "stty rows 0 cols 0" to set rows to cols and cols to 0, while
      "stty cols 0 rows 0" would do the right thing.  On a little-endian
      machine like the sun386i, the problem is the same, but for ws_col == 0.
diff --git a/src/test.c b/src/test.c
index 2d562d9..31a6420 100644
--- a/src/test.c
+++ b/src/test.c
@@ -367,8 +367,8 @@ binary_operator (bool l_is_l)
       test_syntax_error (_("unknown binary operator"), argv[op]);
     }

-  if (argv[op][0] == '=' && (!argv[op][1] ||
-       ((argv[op][1] == '=') && !argv[op][2])))
+  if (argv[op][0] == '='
+      && (!argv[op][1] || ((argv[op][1] == '=') && !argv[op][2])))
     {
       bool value = STREQ (argv[pos], argv[pos + 2]);
       pos += 3;
diff --git a/src/wc.c b/src/wc.c
index 1b8a7a4..5017377 100644
--- a/src/wc.c
+++ b/src/wc.c
@@ -292,7 +292,7 @@ wc (int fd, char const *file_x, struct fstatus *fstatus)
       /* Back-up the state before each multibyte character conversion and
          move the last incomplete character of the buffer to the front
          of the buffer.  This is needed because we don't know whether
-         the 'mbrtowc' function updates the state when it returns -2, -
+         the 'mbrtowc' function updates the state when it returns -2, --
          this is the ISO C 99 and glibc-2.2 behaviour - or not - amended
          ANSI C, glibc-2.1 and Solaris 5.7 behaviour.  We don't have an
          autoconf test for this, yet.  */
diff --git a/src/who.c b/src/who.c
index 84c68d7..c875b1d 100644
--- a/src/who.c
+++ b/src/who.c
@@ -590,9 +590,9 @@ scan_entries (size_t n, const STRUCT_UTMP *utmp_buf)

   while (n--)
     {
-      if (!my_line_only ||
-          strncmp (ttyname_b, utmp_buf->ut_line,
-                   sizeof (utmp_buf->ut_line)) == 0)
+      if (!my_line_only
+          || strncmp (ttyname_b, utmp_buf->ut_line,
+                      sizeof (utmp_buf->ut_line)) == 0)
         {
           if (need_users && IS_USER_PROCESS (utmp_buf))
             print_user (utmp_buf, boottime);
--
1.7.10.405.g10d433


>From 3ebe2d6866d3688627fce3edd72463073770940e Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 30 Apr 2012 10:55:18 +0200
Subject: [PATCH 2/3] maint: adjust wording in comments to avoid FP match on
 /\+$/

* src/ls.c: Also, "sortkey" is not a word: s/sortkey/sort key/.
---
 src/ls.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/ls.c b/src/ls.c
index 800f813..c54d80f 100644
--- a/src/ls.c
+++ b/src/ls.c
@@ -3443,13 +3443,13 @@ static int rev_xstrcoll_df_version (V a, V b)
 { DIRFIRST_CHECK (a, b); return cmp_version (b, a); }


-/* We have 2^3 different variants for each sortkey function
+/* We have 2^3 different variants for each sort-key function
    (for 3 independent sort modes).
    The function pointers stored in this array must be dereferenced as:

     sort_variants[sort_key][use_strcmp][reverse][dirs_first]

-   Note that the order in which sortkeys are listed in the function pointer
+   Note that the order in which sort keys are listed in the function pointer
    array below is defined by the order of the elements in the time_type and
    sort_type enums!  */

@@ -3493,14 +3493,14 @@ static qsortFunc const sort_functions[][2][2][2] =
     LIST_SORTFUNCTION_VARIANTS (atime)
   };

-/* The number of sortkeys is calculated as
-     the number of elements in the sort_type enum (i.e. sort_numtypes) +
+/* The number of sort keys is calculated as the sum of
+     the number of elements in the sort_type enum (i.e. sort_numtypes)
      the number of elements in the time_type enum (i.e. time_numtypes) - 1
    This is because when sort_type==sort_time, we have up to
-   time_numtypes possible sortkeys.
+   time_numtypes possible sort keys.

    This line verifies at compile-time that the array of sort functions has been
-   initialized for all possible sortkeys. */
+   initialized for all possible sort keys. */
 verify (ARRAY_CARDINALITY (sort_functions)
         == sort_numtypes + time_numtypes - 1 );

--
1.7.10.405.g10d433


>From ff5e5d0dd9b056b8920b62a96bb3eed1cec3bd50 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 30 Apr 2012 10:37:14 +0200
Subject: [PATCH 3/3] maint: prohibit an operator at end of line

Many coding standards, including GNU's, advocate that when
splitting a line near a binary operator, one should put the
operator at the beginning of the continued line, rather than
at the end of the preceding one.  This is for readability:
such operators are relatively important to readability, and
they are more apparent at the beginning of a line than
at the varying-column end of line,
* cfg.mk (sc_prohibit_operator_at_end_of_line): New rule.
Exempt test.c.
---
 cfg.mk |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/cfg.mk b/cfg.mk
index c3ddb42..1dfbb7d 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -200,6 +200,16 @@ sc_no_exec_perl_coreutils:
 	      exit 1; } || :;						\
 	fi

+# With split lines, don't leave an operator at end of line.
+# Instead, put it on the following line, where it is more apparent.
+# Don't bother checking for "*" at end of line, since it provokes
+# far too many false positives, matching constructs like "TYPE *".
+sc_prohibit_operator_at_end_of_line:
+	@prohibit='. (&&|\|\||[-/+])$$'					\
+	in_vc_files='\.[chly]$$'					\
+	halt='found operator at end of line'				\
+	  $(_sc_search_regexp)
+
 # Don't use "readlink" or "readlinkat" directly
 sc_prohibit_readlink:
 	@prohibit='\<readlink(at)? \('					\
@@ -456,3 +466,7 @@ exclude_file_name_regexp--sc_prohibit_continued_string_alpha_in_column_1 = \

 exclude_file_name_regexp--sc_prohibit_test_backticks = \
   ^tests/(init\.sh|check\.mk|misc/stdbuf)$$
+
+# Exempt test.c, since it's nominally shared, and relatively static.
+exclude_file_name_regexp--sc_prohibit_operator_at_end_of_line = \
+  ^src/test\.c$$
--
1.7.10.405.g10d433


From MAILER-DAEMON Mon Apr 30 09:10:56 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOqNU-0008MQ-TZ
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 09:10:56 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40476)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kas@fi.muni.cz>) id 1SOpZY-00064D-Vx
	for coreutils@gnu.org; Mon, 30 Apr 2012 08:19:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kas@fi.muni.cz>) id 1SOpZX-0006e9-4w
	for coreutils@gnu.org; Mon, 30 Apr 2012 08:19:20 -0400
Received: from minas.ics.muni.cz ([147.251.4.40]:54894)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kas@fi.muni.cz>) id 1SOpZW-0006ac-Qc
	for coreutils@gnu.org; Mon, 30 Apr 2012 08:19:19 -0400
Received: from anxur.fi.muni.cz (anxur.fi.muni.cz [147.251.48.3])
	by minas.ics.muni.cz (8.13.8/8.13.8/SuSE Linux 0.8) with ESMTP id
	q3UCJFhS014454
	for <coreutils@gnu.org>; Mon, 30 Apr 2012 14:19:16 +0200
Received: by anxur.fi.muni.cz (Postfix, from userid 11561)
	id 640D46271D; Mon, 30 Apr 2012 14:19:15 +0200 (CEST)
Date: Mon, 30 Apr 2012 14:19:15 +0200
From: Jan Kasprzak <kas@fi.muni.cz>
To: coreutils@gnu.org
Subject: flock(1) exit code (enhancement request)
Message-ID: <20120430121915.GG1744@fi.muni.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-12-10)
X-Muni-Spam-TestIP: 147.251.48.3
X-Muni-Envelope-From: kas@fi.muni.cz
X-Muni-Virus-Test: Clean
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0
	(minas.ics.muni.cz [147.251.4.35]);
	Mon, 30 Apr 2012 14:19:16 +0200 (CEST)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 147.251.4.40
X-Mailman-Approved-At: Mon, 30 Apr 2012 09:10:55 -0400
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 12:19:25 -0000

	Hello, coreutils developers!

I use flock(1) from coreutils in my scripts, and with --wait or --nonblock
I would like to be able to distinguish between the "conflicting lock exists"
and "-c <command> exited with code 1" states.

	Of course, I can always wrap the -c argument with something like
bash -c "<original_cmd_and_args> || exit 2" with yet another level of
quoting, but I think it is really ugly.

	This problem can be solved for example by mapping the exit code 1
of the -c command to something else. I.e. to add something like

	-m <number>
	--map-exit-code-1-to <number>

where the exit code of flock(1) would be <number>, iff the -c <command> exits
with code 1.

	What do you think about it? If you agree with the above syntax,
I can of course post a patch to flock(1).

	Thanks,

-Yenya

-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/    Journal: http://www.fi.muni.cz/~kas/blog/ |
Please don't top post and in particular don't attach entire digests to your
mail or we'll all soon be using bittorrent to read the list.     --Alan Cox


From MAILER-DAEMON Mon Apr 30 09:27:57 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOqdx-0002Ek-Sr
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 09:27:57 -0400
Received: from eggs.gnu.org ([208.118.235.92]:34324)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SOqdq-0002EH-Du
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:27:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SOqdk-0005v7-1g
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:27:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43646)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <P@draigBrady.com>) id 1SOqdj-0005uU-QR
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:27:43 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3UDRabp021200
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Mon, 30 Apr 2012 09:27:36 -0400
Received: from [10.36.116.46] (ovpn-116-46.ams2.redhat.com [10.36.116.46])
	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q3UDRUox018319
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
	Mon, 30 Apr 2012 09:27:34 -0400
Message-ID: <4F9E9340.8090705@draigBrady.com>
Date: Mon, 30 Apr 2012 14:27:28 +0100
From: =?ISO-8859-1?Q?P=E1draig_Brady?= <P@draigBrady.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: kas@fi.muni.cz
Subject: Re: flock(1) exit code (enhancement request)
References: <20120430121915.GG1744@fi.muni.cz>
In-Reply-To: <20120430121915.GG1744@fi.muni.cz>
X-Enigmail-Version: 1.3.2
Content-Type: text/plain; charset=ISO-8859-1
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id
	q3UDRabp021200
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 13:27:56 -0000

On 04/30/2012 01:19 PM, Jan Kasprzak wrote:
> 	Hello, coreutils developers!
>=20
> I use flock(1) from coreutils in my scripts

flock is from util-linux@vger.kernel.org

cheers,
P=E1draig


From MAILER-DAEMON Mon Apr 30 09:33:37 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOqjR-00041p-8Z
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 09:33:37 -0400
Received: from eggs.gnu.org ([208.118.235.92]:55012)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kas@fi.muni.cz>) id 1SOqjO-00041d-Ku
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:33:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kas@fi.muni.cz>) id 1SOqjJ-0007z5-7n
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:33:34 -0400
Received: from minas.ics.muni.cz ([147.251.4.40]:56513)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kas@fi.muni.cz>) id 1SOqjI-0007yG-TH
	for coreutils@gnu.org; Mon, 30 Apr 2012 09:33:29 -0400
Received: from anxur.fi.muni.cz (anxur.fi.muni.cz [147.251.48.3])
	by minas.ics.muni.cz (8.13.8/8.13.8/SuSE Linux 0.8) with ESMTP id
	q3UDXOD9002283; Mon, 30 Apr 2012 15:33:25 +0200
Received: by anxur.fi.muni.cz (Postfix, from userid 11561)
	id E15326273F; Mon, 30 Apr 2012 15:33:24 +0200 (CEST)
Date: Mon, 30 Apr 2012 15:33:24 +0200
From: Jan Kasprzak <kas@fi.muni.cz>
To: =?iso-8859-1?Q?P=E1draig?= Brady <P@draigBrady.com>
Subject: Re: flock(1) exit code (enhancement request)
Message-ID: <20120430133324.GI1744@fi.muni.cz>
References: <20120430121915.GG1744@fi.muni.cz>
	<4F9E9340.8090705@draigBrady.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <4F9E9340.8090705@draigBrady.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
X-Muni-Spam-TestIP: 147.251.48.3
X-Muni-Envelope-From: kas@fi.muni.cz
X-Muni-Virus-Test: Clean
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0
	(minas.ics.muni.cz [147.251.4.35]);
	Mon, 30 Apr 2012 15:33:26 +0200 (CEST)
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by minas.ics.muni.cz id
	q3UDXOD9002283
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 147.251.4.40
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 13:33:36 -0000

P=E1draig Brady wrote:
: On 04/30/2012 01:19 PM, Jan Kasprzak wrote:
: > 	Hello, coreutils developers!
: >=20
: > I use flock(1) from coreutils in my scripts
:=20
: flock is from util-linux@vger.kernel.org

	My fault, sorry for the noise.

-Y.

--=20
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}=
> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5=
E |
| http://www.fi.muni.cz/~kas/    Journal: http://www.fi.muni.cz/~kas/blog=
/ |
Please don't top post and in particular don't attach entire digests to yo=
ur
mail or we'll all soon be using bittorrent to read the list.     --Alan C=
ox


From MAILER-DAEMON Mon Apr 30 10:25:01 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOrXB-0002h3-OG
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 10:25:01 -0400
Received: from eggs.gnu.org ([208.118.235.92]:40021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SOrX9-0002fX-E0
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:25:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SOrX6-00033K-91
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:24:58 -0400
Received: from mail-pz0-f51.google.com ([209.85.210.51]:56522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bruce.korb@gmail.com>) id 1SOrX6-00031g-01
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:24:56 -0400
Received: by dadz8 with SMTP id z8so3555380dad.38
	for <coreutils@gnu.org>; Mon, 30 Apr 2012 07:24:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:subject:references
	:in-reply-to:content-type:content-transfer-encoding;
	bh=gEqW9DLHzkYulrhfOl+8umtz+QpBd50afHo5QIqCQ1k=;
	b=FHr5vmBh9iN7nYSVxtNeTGaRiotPNKIvGXKiASr/lUJZqFdIS37zmgV8iIXXd498u9
	rQeYffbi3Qdkf7BH3zkN9718x+BCXm65ZPIfa1HR8pJSe7K35duJ66B+DJM2tOcwT20q
	4At6n9dDzffLN8iDnvmzCageiHblGoyRXeiZ9ythVEu405q5kVIHbGsIkvYjdZxQuSua
	J5Pr0qq7wwghyxEo7vN3BOKSQxvkVuo8RF4r5d5yiH/YEL1tGTBZk662RKZflBHCg9h6
	/NtleY3kyJN8S3eHsa021Btb8EVIetyKx1fcvZejr0xagdkfbE0NPS7tFNjfRmdaMhP5
	4PbQ==
Received: by 10.68.195.163 with SMTP id if3mr48503366pbc.127.1335795893192;
	Mon, 30 Apr 2012 07:24:53 -0700 (PDT)
Received: from [192.168.10.2] ([75.0.182.39])
	by mx.google.com with ESMTPS id vq9sm5515243pbc.18.2012.04.30.07.24.51
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 30 Apr 2012 07:24:52 -0700 (PDT)
Message-ID: <4F9EA0B2.1050202@gmail.com>
Date: Mon, 30 Apr 2012 07:24:50 -0700
From: Bruce Korb <bruce.korb@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120328 Thunderbird/11.0.1
MIME-Version: 1.0
To: coreutils@gnu.org, =?ISO-8859-1?Q?P=E1draig_Brady?=
 <P@draigBrady.com>
Subject: Re: Another rfe: "cp" this time
References: <4F9AAE09.1010904@gmail.com> <4F9ABCD8.1070009@draigBrady.com>
	<CAKRnqN+130RH8gMzAkANK2sC81fBa-8ow8MDWTFaY85KMDTcLQ@mail.gmail.com>
	<4F9ADBB2.9080808@draigBrady.com>
	<4F9AFA32.3040301@draigBrady.com> <4F9B0F4D.8070902@gmail.com>
	<4F9B4F59.5070801@gnu.org>
In-Reply-To: <4F9B4F59.5070801@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.85.210.51
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 14:25:00 -0000

On 04/27/12 19:00, Bruce Korb wrote:
>> Link? no. Copy? yes. But it is a long way from...
>
> Not only not ready for prime time, but

Link? Yes.

I needed another file, so I finished the basic work.
Reflecting on the special config needs tho (throttling,
user entertainment [progress info], etc.) maybe not
a candidate for incorporation into "cp", yielding
yet another utility?  The shell wrapper around "dd"
ought to have worked, but it did not.  All the dd's
with a non-zero "seek" option quit without transferring
any data at all.  The "rsync" solution decided that
since the source file was local, it would read through
the entire file.  Apparently it is not network mount
aware.  Anyway, with a reasonably recent "libopts"
installation, you can clone this, unroll the .tar
file and build:

git://github.com/brkorb/pcopy.git

(Do not generate the option sources as I added the
generation of "die()" functions for my own amusement.)


From MAILER-DAEMON Mon Apr 30 10:25:37 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOrXl-000328-Sq
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 10:25:37 -0400
Received: from eggs.gnu.org ([208.118.235.92]:41097)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SOrXj-00030t-Ou
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:25:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SOrXd-0003aZ-VG
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:25:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48472)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SOrXd-0003YY-Ll
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:25:29 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3UEPRIu007425
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Mon, 30 Apr 2012 10:25:27 -0400
Received: from [10.3.112.57] (ovpn-112-57.phx2.redhat.com [10.3.112.57])
	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q3UEPQdS012965; Mon, 30 Apr 2012 10:25:26 -0400
Message-ID: <4F9EA0D6.1040800@redhat.com>
Date: Mon, 30 Apr 2012 08:25:26 -0600
From: Eric Blake <eblake@redhat.com>
Organization: Red Hat
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: Jim Meyering <jim@meyering.net>
Subject: Re: [PATCH 3/3] maint: prohibit an operator at end of line
References: <878vhdz7ss.fsf@rho.meyering.net>
In-Reply-To: <878vhdz7ss.fsf@rho.meyering.net>
X-Enigmail-Version: 1.4.1
OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enig5305E443A1D5BB6841B9B63D"
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 14:25:37 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig5305E443A1D5BB6841B9B63D
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 04/30/2012 07:08 AM, Jim Meyering wrote:
> Here's a new syntax-check rule (patch 3/3).
> 1 and 2 fix violations so that the new check passes.
>=20
> For now, this is only in coreutils (grep had only two violations),
> but given the long list of violations in gnulib's lib/ directory,
> it may not be generally appealing enough to be added to gnulib's maint.=
mk:
>=20
>     $ git grep -lE '(. [-/+]|&&|\|\|)$' lib

Is it worth adding some more operators, such as *, ^, &, and |?

(. [-/+*^]|&&?|\|\|?)$

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enig5305E443A1D5BB6841B9B63D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPnqDWAAoJEKeha0olJ0NqRUIH/RBio1a7VH02961C2JZ9NIG6
UrVwuPE+NPsxyAzoAFTxjFWiliZvN12zlaL/Ggb5A6my+Dm+05phzmAwJca8DYYL
c+B2uKzIucGE7geYdwwqMY4Nu9XwFiF8WRqxiGUL927sTDoLya7pDg7lhH207yZt
9qfMSJq10Y1HLcjzwHwk99BxPzGgN/o0+UEPTiC1CUMxQtNkLEp9oV0SiEND6wP/
Uo1MfZs3E9IwP/dZMiKOa9qVz2EyW7OE3lH8BVJNvlYA6HBE7/5YAZJQHM9X+Jmz
8dR4JAkLwO9O779ZT6pcUFOX3hVgwQ1Fj//AYpEqcoJoJBNdGOjaLSWiGKzMHzQ=
=DPbU
-----END PGP SIGNATURE-----

--------------enig5305E443A1D5BB6841B9B63D--


From MAILER-DAEMON Mon Apr 30 10:30:04 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOrc4-0004qg-Qg
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 10:30:04 -0400
Received: from eggs.gnu.org ([208.118.235.92]:59676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SOrby-0004p6-PO
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:30:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SOrbw-00061N-Us
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:29:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3081)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1SOrbw-00060C-NP
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:29:56 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3UETsO1029464
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Mon, 30 Apr 2012 10:29:54 -0400
Received: from [10.3.112.57] (ovpn-112-57.phx2.redhat.com [10.3.112.57])
	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q3UETrdH014616; Mon, 30 Apr 2012 10:29:53 -0400
Message-ID: <4F9EA1E0.2010805@redhat.com>
Date: Mon, 30 Apr 2012 08:29:52 -0600
From: Eric Blake <eblake@redhat.com>
Organization: Red Hat
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
Subject: Re: [PATCH 3/3] maint: prohibit an operator at end of line
References: <878vhdz7ss.fsf@rho.meyering.net> <4F9EA0D6.1040800@redhat.com>
In-Reply-To: <4F9EA0D6.1040800@redhat.com>
X-Enigmail-Version: 1.4.1
OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enig6B3F321F37F2C9A65FFA06FF"
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 209.132.183.28
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 14:30:04 -0000

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig6B3F321F37F2C9A65FFA06FF
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 04/30/2012 08:25 AM, Eric Blake wrote:
> On 04/30/2012 07:08 AM, Jim Meyering wrote:
>> Here's a new syntax-check rule (patch 3/3).
>> 1 and 2 fix violations so that the new check passes.
>>
>> For now, this is only in coreutils (grep had only two violations),
>> but given the long list of violations in gnulib's lib/ directory,
>> it may not be generally appealing enough to be added to gnulib's maint=
=2Emk:
>>
>>     $ git grep -lE '(. [-/+]|&&|\|\|)$' lib
>=20
> Is it worth adding some more operators, such as *, ^, &, and |?
>=20
> (. [-/+*^]|&&?|\|\|?)$

Also <<, >>, =3D=3D, !=3D, and for that matter, all of the op=3D operator=
s:

(. [-/+*^=3D!<>]=3D?|&&?|\|\|?|<<=3D?|>>=3D?)$

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enig6B3F321F37F2C9A65FFA06FF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBCAAGBQJPnqHhAAoJEKeha0olJ0NqKy8H/2dquK0TRpqQ4/YnjkHNbyVt
L3sYTiW5mnS2lxgZlLRry2uAoTwaZwea6bht9qmXIQhV8pXvpeCik9y4JFqgGsAt
/HxwdMWyFvYlQ/m48I15jI9WlxIRp5qD7meZcsCTZsfc+dxEtfL1MBJ8+CtDRZfb
dMuXTu8LlKseceW7SDkqVVJELyjry3ozY6unSBL1L6mmBlvEkaCCASdFtV6/HHNg
++snEDCWEO2Br58T+IonWlsQQ1QB69joP2piiC4nW69bySFJh5AI/PPDAkqkIorC
vfnERcPrGtz9QdNfIZJOzcXbKv8k0PD2ZE99Ti5Ld6HqxnhoAohHlvvc+SDHiRs=
=QIKw
-----END PGP SIGNATURE-----

--------------enig6B3F321F37F2C9A65FFA06FF--


From MAILER-DAEMON Mon Apr 30 10:51:53 2012
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1SOrxB-00053h-TJ
	for mharc-coreutils@gnu.org; Mon, 30 Apr 2012 10:51:53 -0400
Received: from eggs.gnu.org ([208.118.235.92]:47007)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOrx9-00053Z-RR
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:51:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOrx8-0005Ia-9k
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:51:51 -0400
Received: from mx.meyering.net ([88.168.87.75]:60377)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1SOrx8-0005IR-2r
	for coreutils@gnu.org; Mon, 30 Apr 2012 10:51:50 -0400
Received: from rho.meyering.net (localhost.localdomain [127.0.0.1])
	by rho.meyering.net (Acme Bit-Twister) with ESMTP id 92D2C600BA;
	Mon, 30 Apr 2012 16:51:47 +0200 (CEST)
From: Jim Meyering <jim@meyering.net>
To: Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH 3/3] maint: prohibit an operator at end of line
In-Reply-To: <4F9EA0D6.1040800@redhat.com> (Eric Blake's message of "Mon, 30
	Apr 2012 08:25:26 -0600")
References: <878vhdz7ss.fsf@rho.meyering.net> <4F9EA0D6.1040800@redhat.com>
Date: Mon, 30 Apr 2012 16:51:47 +0200
Message-ID: <87bom9xofw.fsf@rho.meyering.net>
Lines: 21
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 88.168.87.75
Cc: coreutils@gnu.org
X-BeenThere: coreutils@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: GNU coreutils General Discussion <coreutils.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/coreutils>
List-Post: <mailto:coreutils@gnu.org>
List-Help: <mailto:coreutils-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/coreutils>,
	<mailto:coreutils-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Apr 2012 14:51:53 -0000

Eric Blake wrote:
> On 04/30/2012 07:08 AM, Jim Meyering wrote:
>> Here's a new syntax-check rule (patch 3/3).
>> 1 and 2 fix violations so that the new check passes.
>>
>> For now, this is only in coreutils (grep had only two violations),
>> but given the long list of violations in gnulib's lib/ directory,
>> it may not be generally appealing enough to be added to gnulib's maint.mk:
>>
>>     $ git grep -lE '(. [-/+]|&&|\|\|)$' lib
>
> Is it worth adding some more operators, such as *, ^, &, and |?
>
> (. [-/+*^]|&&?|\|\|?)$

I mentioned why "*" is excluded in the cfg.mk comment (too many false
positives for "TYPE *"), and get the feeling that the cost/benefit ratio
is too high for the others, since they are so much less common.

For example, the commenting style in fmt.c provokes many false positives
for "|".


