From MAILER-DAEMON Sun Jan 03 23:49:44 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aFx5U-0003YQ-J5
	for mharc-gnash-commit@gnu.org; Sun, 03 Jan 2016 23:49:44 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35208)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aFx5R-0003XC-K9
	for gnash-commit@gnu.org; Sun, 03 Jan 2016 23:49:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aFx5O-0005pQ-Dn
	for gnash-commit@gnu.org; Sun, 03 Jan 2016 23:49:41 -0500
Received: from [2001:4830:134:6::a] (port=36341 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aFx5O-0005pM-AB
	for gnash-commit@gnu.org; Sun, 03 Jan 2016 23:49:38 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aFx5H-0001IP-Fa; Mon, 04 Jan 2016 04:49:31 +0000
Date: Mon, 04 Jan 2016 04:49:31 +0000
To: Sandro Santilli <strk@keybit.net>,
	Pablo =?UTF-8?B?Um9kcsOtZ3Vleg==?= <ousia@wanadoo.es>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 40459
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.162.134 (Savane authenticated user nachanon)
Message-Id: <20160104-114931.sv82809.29525@savannah.gnu.org>
References: <20131103-193715.sv48476.83317@savannah.gnu.org>
	<20131103-200639.sv27281.15469@savannah.gnu.org>
	<20131103-200922.sv27281.35657@savannah.gnu.org>
	<20131103-202500.sv48476.99223@savannah.gnu.org>
	<20131103-202721.sv48476.5685@savannah.gnu.org>
	<20131103-222102.sv48476.2276@savannah.gnu.org>
	<20131103-224157.sv27281.28784@savannah.gnu.org>
	<20131103-224619.sv27281.55912@savannah.gnu.org>
	<20131103-231725.sv27281.53780@savannah.gnu.org>
	<20131103-231734.sv27281.3633@savannah.gnu.org>
	<20131104-213414.sv48476.14762@savannah.gnu.org>
	<20131105-182436.sv27281.29297@savannah.gnu.org>
	<20131105-193500.sv27281.85572@savannah.gnu.org>
	<20131105-193702.sv27281.45982@savannah.gnu.org>
	<20131105-221446.sv48476.3945@savannah.gnu.org>
	<20131106-201401.sv27281.84536@savannah.gnu.org>
	<20131106-205553.sv48476.82028@savannah.gnu.org>
	<20131119-213407.sv48476.93978@savannah.gnu.org>
In-Reply-To: <20131119-213407.sv48476.93978@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] =?utf-8?q?=5Bbug_=2340459=5D_master-21901-77966b2_?=
	=?utf-8?q?doesn=E2=80=99t_show_downloaded_bytes?=
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2016 04:49:42 -0000

Follow-up Comment #17, bug #40459 (project gnash):

This issue is still consistenly reproducible on current git version of Gnash
when download simulator is in use.

I have made test SWF files (using libming's MakeSWF), one loader that tries
to download another Flash file from a custom download simulation server
which introduces brief pause on specific positions in the stream:

My loaded SWF in this case is 37288 bytes long. Server output lines begin
with `htcheckpoint:`, loader SWF's output lines begin with `testloader:`.

Following is a trace log from Flash Player (interleaved with server output):

testloader: starting download
htcheckpoint: request received, pausing 2000 ms
htcheckpoint: sent 0 byte(s), pausing 2000 ms
testloader: download started
htcheckpoint: sent 1 byte(s), pausing 2000 ms
Warning: Not a known player download type,
http://localhost:8085/testpattern.swf
testloader: downloading: 0/0
htcheckpoint: sent 1621 byte(s), pausing 2000 ms
testloader: downloading: 1621/37288
htcheckpoint: sent 9322 byte(s), pausing 2000 ms
testloader: downloading: 5717/37288
testloader: downloading: 9322/37288
htcheckpoint: sent 18644 byte(s), pausing 2000 ms
testloader: downloading: 17514/37288
testloader: downloading: 18644/37288
htcheckpoint: sent 27966 byte(s), pausing 2000 ms
testloader: downloading: 26836/37288
testloader: downloading: 27966/37288
htcheckpoint: sent 37287 byte(s), pausing 2000 ms
testloader: downloading: 32062/37288
testloader: downloading: 36158/37288
testloader: downloading: 37287/37288
htcheckpoint: sent 37288 byte(s), pausing 2000 ms
testloader: downloading: 37288/37288
testloader: download completed: status 200
testloader: started action


Following is a trace log from Gnash (interleaved with server output):

126 TRACE: testloader: starting download
htcheckpoint: request received, pausing 2000 ms
htcheckpoint: sent 0 byte(s), pausing 2000 ms
htcheckpoint: sent 1 byte(s), pausing 2000 ms
htcheckpoint: sent 1621 byte(s), pausing 2000 ms
6146 TRACE: testloader: download started
6147 TRACE: testloader: downloading: 20/37288
6147 TRACE: testloader: download completed: status 0
6147 TRACE: testloader: started action
htcheckpoint: sent 9322 byte(s), pausing 2000 ms
htcheckpoint: sent 18644 byte(s), pausing 2000 ms
htcheckpoint: sent 27966 byte(s), pausing 2000 ms
htcheckpoint: sent 37287 byte(s), pausing 2000 ms
htcheckpoint: sent 37288 byte(s), pausing 2000 ms


You'd see that on Gnash...
* `OnLoadStart()` was called when first frame is completed rather than when
HTTP response was received.
* `OnLoadProgress()` was only called only one time when first frame is
completed, rather than every time a block of data is received. Reported number
of bytes downloaded was also inaccurate (20 instead of 1621).
* `OnLoadComplete()` was called even when the download was not yet completed.
HTTP response code reported to the callback was also incorrect (0 instead of
200).

Test SWFs, source code, download simulator script, and full debug logs
are attached as `movieloader-progresscheck.zip`.

Gnash: 0.8.11dev (git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386

P.S. The download simulation server runs on TCP port 8085 by default;
this it can be changed by adding `-p PORTNUMBER` option to server's
command line. URL in loader SWF must be adjusted accordingly if the port
is changed.


(file #35912)
    _______________________________________________________

Additional Item Attachment:

File name: movieloader-progresscheck.zip  Size:25 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40459>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 06 12:24:47 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aGrpH-0005Id-HA
	for mharc-gnash-commit@gnu.org; Wed, 06 Jan 2016 12:24:47 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50850)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGrpE-0005I6-RC
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:24:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGrpB-0000fK-KK
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:24:44 -0500
Received: from [2001:4830:134:6::a] (port=54218 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGrpB-0000fG-GA
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:24:41 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aGroy-0003fi-5q; Wed, 06 Jan 2016 17:24:28 +0000
Date: Wed, 06 Jan 2016 17:24:28 +0000
To: Rob Savoye <rob@welcomehome.org>, Sandro Santilli <strk@keybit.net>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 32411
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.168.46 (Savane authenticated user nachanon)
Message-Id: <20160107-002427.sv82809.28725@savannah.gnu.org>
References: <20110210-101655.sv27281.26203@savannah.gnu.org>
	<20110305-163550.sv48477.58410@savannah.gnu.org>
	<20110305-083806.sv178.96135@savannah.gnu.org>
	<20110305-173739.sv48477.39395@savannah.gnu.org>
	<20110305-094138.sv178.98630@savannah.gnu.org>
	<20110305-174352.sv60230.66725@savannah.gnu.org>
	<20110305-095311.sv178.37635@savannah.gnu.org>
	<20110305-180604.sv48477.39870@savannah.gnu.org>
	<20110305-101517.sv178.56093@savannah.gnu.org>
	<20110305-183009.sv48477.87700@savannah.gnu.org>
	<20110305-103540.sv178.87326@savannah.gnu.org>
	<20110305-213931.sv27281.8825@savannah.gnu.org>
In-Reply-To: <20110305-213931.sv27281.8825@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #32411] ExternalInterface XML parser fails with
	nested tags
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2016 17:24:46 -0000

Follow-up Comment #12, bug #32411 (project gnash):

This is a follow up from bug #37223 comment 4
<https://savannah.gnu.org/bugs/?37223#comment4>.

I have created dummy SWF files to minimally demonstrate the need for this
functionality. One of SWF file receives an Object argument from JavaScript,
another one tries to pass Object return value to JavaScript.

The Object passed is just a simple Object created from `new Object()`
statement (from both language), then assigned a member named `a` with string
value "Hello", and assigned a member named `b` with string value "World".

*Object-Typed Function Argument Case*

This is an image result from `js2flash-objarg.html` under browser with Flash
Player:
http://i.imgur.com/cfDCgOi.png

Flash Player's trace output from the run:

Warning: Reference to undeclared variable, 'JS2FlashObjectArg'
callee: starting
callee: adding ExternalInterface callback
callee: finished initializing
callee: entering ExternalInterface callback
callee: ExternalInterface callback succeeded, expected object with member
[a=Hello, b=World] got object with [a=Hello, b=World]
callee: ExternalInterface callback finished


You'll see that Flash Player passed an ExternalInterface callback's Object
argument and its members correctly.

This is an image result from `js2flash-objarg.html` under browser with Gnash:
http://i.imgur.com/rNCDxOu.png

Gnash's console output shows:

76 SECURITY: Extensions disabled
76 ACTIONSCRIPT ERROR: reference to non-existent variable 'JS2FlashObjectArg'
76 TRACE: callee: starting
77 TRACE: callee: adding ExternalInterface callback
77 TRACE: callee: finished initializing
2939 TRACE: callee: entering ExternalInterface callback
2939 ACTIONSCRIPT ERROR: getMember called against a value that does not cast
to an as_object: [undefined]
2939 ACTIONSCRIPT ERROR: getMember called against a value that does not cast
to an as_object: [undefined]
2939 TRACE: callee: ExternalInterface called incorrectly, expected object with
member [a=Hello, b=World] got undefined with [a=undefined, b=undefined]
2939 TRACE: callee: ExternalInterface callback finished


Apart from hairline stroke issue (bug #45731), you'll see from console output
that Gnash passed an Object-typed ExternalInterface callback argument *as
`undefined`*.

According to Gnash's container-player communication log, the problem started
from libgnashplugin sending an empty `<object>` tag to player, which is
incorrect since this object is supposed to have two member.

Gnash: 0.8.11dev (git 15d61a8 26-Dec-2015) NPAPI
Flash Player: 11.2.202.491 NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32411>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 06 12:29:59 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aGruJ-00074c-CE
	for mharc-gnash-commit@gnu.org; Wed, 06 Jan 2016 12:29:59 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGruH-00073d-MK
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:29:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGruE-0001xA-Fl
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:29:57 -0500
Received: from [2001:4830:134:6::a] (port=54575 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGruE-0001x6-Cc
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:29:54 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aGru1-0003mD-RE; Wed, 06 Jan 2016 17:29:41 +0000
Date: Wed, 06 Jan 2016 17:29:41 +0000
To: Rob Savoye <rob@welcomehome.org>, Sandro Santilli <strk@keybit.net>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 32411
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.168.46 (Savane authenticated user nachanon)
Message-Id: <20160107-002941.sv82809.31437@savannah.gnu.org>
References: <20110210-101655.sv27281.26203@savannah.gnu.org>
	<20110305-163550.sv48477.58410@savannah.gnu.org>
	<20110305-083806.sv178.96135@savannah.gnu.org>
	<20110305-173739.sv48477.39395@savannah.gnu.org>
	<20110305-094138.sv178.98630@savannah.gnu.org>
	<20110305-174352.sv60230.66725@savannah.gnu.org>
	<20110305-095311.sv178.37635@savannah.gnu.org>
	<20110305-180604.sv48477.39870@savannah.gnu.org>
	<20110305-101517.sv178.56093@savannah.gnu.org>
	<20110305-183009.sv48477.87700@savannah.gnu.org>
	<20110305-103540.sv178.87326@savannah.gnu.org>
	<20110305-213931.sv27281.8825@savannah.gnu.org>
	<20160107-002427.sv82809.28725@savannah.gnu.org>
In-Reply-To: <20160107-002427.sv82809.28725@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #32411] ExternalInterface XML parser fails with
	nested tags
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2016 17:29:58 -0000

Follow-up Comment #13, bug #32411 (project gnash):

*Object-Typed Function Return Value Case*

This is an image result from `js2flash-objret.html` under browser with Flash
Player:
http://i.imgur.com/KjPAvCU.png

Flash Player's trace output from the run:

Warning: Reference to undeclared variable, 'JS2FlashObjectRet'
callee: starting
callee: adding ExternalInterface callback
callee: finished initializing
callee: entering ExternalInterface callback
callee: ExternalInterface callback succeeded
callee: ExternalInterface callback returning


You'll see that Flash Player passed ExternalInterface callback's Object return
value and its members correctly.

This is an image result from `js2flash-objret.html` under browser with Gnash:
http://i.imgur.com/6nTqrHV.png

Gnash's console output shows:

108 SECURITY: Extensions disabled
109 ACTIONSCRIPT ERROR: reference to non-existent variable
'JS2FlashObjectRet'
109 TRACE: callee: starting
109 TRACE: callee: adding ExternalInterface callback
109 TRACE: callee: finished initializing
2952 TRACE: callee: entering ExternalInterface callback
2952 TRACE: callee: ExternalInterface callback succeeded
2952 TRACE: callee: ExternalInterface callback returning


You'll see from screenshot that Gnash *did not pass Object-typed return
value*
from ExternalInterface callback correctly, and XULRunner _crashed_ afterward.

According to Gnash's container-player communication log, Gnash (player) seems
to marshall the object properly, but libgnashplugin somehow choked on it.

Test SWFs, source code, build script, HTML container, screenshots, debug
logs,
container-player communication dump and detailed GDB backtrace of xulrunner's
`plugin-container` are attached as `js2flash-obj.zip`.

Gnash: 0.8.11dev (git 15d61a8 26-Dec-2015) NPAPI
Flash Player: 11.2.202.491 NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy


(file #35935)
    _______________________________________________________

Additional Item Attachment:

File name: js2flash-obj.zip               Size:24 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32411>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 06 12:32:53 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aGrx7-0007Lt-6d
	for mharc-gnash-commit@gnu.org; Wed, 06 Jan 2016 12:32:53 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGrx5-0007LV-8o
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:32:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGrx2-0002Z7-49
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:32:51 -0500
Received: from [2001:4830:134:6::a] (port=54764 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aGrx2-0002Z3-0j
	for gnash-commit@gnu.org; Wed, 06 Jan 2016 12:32:48 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aGrws-0003sJ-Cf; Wed, 06 Jan 2016 17:32:38 +0000
Date: Wed, 06 Jan 2016 17:32:38 +0000
To: Rob Savoye <rob@welcomehome.org>, Sandro Santilli <strk@keybit.net>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 32411
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.168.46 (Savane authenticated user nachanon)
Message-Id: <20160107-003238.sv82809.48271@savannah.gnu.org>
References: <20110210-101655.sv27281.26203@savannah.gnu.org>
	<20110305-163550.sv48477.58410@savannah.gnu.org>
	<20110305-083806.sv178.96135@savannah.gnu.org>
	<20110305-173739.sv48477.39395@savannah.gnu.org>
	<20110305-094138.sv178.98630@savannah.gnu.org>
	<20110305-174352.sv60230.66725@savannah.gnu.org>
	<20110305-095311.sv178.37635@savannah.gnu.org>
	<20110305-180604.sv48477.39870@savannah.gnu.org>
	<20110305-101517.sv178.56093@savannah.gnu.org>
	<20110305-183009.sv48477.87700@savannah.gnu.org>
	<20110305-103540.sv178.87326@savannah.gnu.org>
	<20110305-213931.sv27281.8825@savannah.gnu.org>
	<20160107-002427.sv82809.28725@savannah.gnu.org>
	<20160107-002941.sv82809.31437@savannah.gnu.org>
In-Reply-To: <20160107-002941.sv82809.31437@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #32411] ExternalInterface XML parser fails with
	nested tags
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2016 17:32:52 -0000

Follow-up Comment #14, bug #32411 (project gnash):

>From test results and communication logs, it looks like that nested XML tags
parsing is needed on both side to support Object-typed (and Array-typed)
argument and return value in ExternalInterface like Adobe Flash Player do.

Note: There might be some corner cases on how to deal with looped or
duplicated Object references, but it would take some more testing to see
how Adobe Flash manages (or discards) it.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32411>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 09 04:27:13 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aHpnl-0002UG-3w
	for mharc-gnash-commit@gnu.org; Sat, 09 Jan 2016 04:27:13 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35002)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aHpnh-0002Tj-JI
	for gnash-commit@gnu.org; Sat, 09 Jan 2016 04:27:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aHpne-0003A9-D4
	for gnash-commit@gnu.org; Sat, 09 Jan 2016 04:27:09 -0500
Received: from [2001:4830:134:6::a] (port=42714 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aHpne-0003A1-9k
	for gnash-commit@gnu.org; Sat, 09 Jan 2016 04:27:06 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aHpnd-0001J0-9o; Sat, 09 Jan 2016 09:27:05 +0000
Date: Sat, 09 Jan 2016 09:27:05 +0000
To: nietzsche@lysator.liu.se, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: anonymous <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46148
User-Agent: Mozilla/5.0 (X11;
	Linux x86_64) AppleWebKit/537.21 (KHTML, like Gecko)
	QupZilla/1.8.9 Safari/537.21
X-Apparently-From: 95.221.229.175
Message-Id: <20160109-092705.sv0.97550@savannah.gnu.org>
References: <20151008-001427.sv0.53436@savannah.gnu.org>
In-Reply-To: <20151008-001427.sv0.53436@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46148] Build failure building head (boost-1.59)
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Jan 2016 09:27:11 -0000

Follow-up Comment #1, bug #46148 (project gnash):

Same here.
For reference, adjacent_tokens_only() is new in boost 1.59, and its value is
completely irrelevant since accumulator_type doesn't even accept tokens, but
it still has to be defined hereafter lest accumulator_type be abstract.
I'm attaching a quick patch, for anyone who wants to compile in the meanwhile.

(file #35952)
    _______________________________________________________

Additional Item Attachment:

File name: custom2.patch                  Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46148>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 10 00:00:34 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aI87G-0003aN-M3
	for mharc-gnash-commit@gnu.org; Sun, 10 Jan 2016 00:00:34 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI87E-0003a2-CU
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:00:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI879-00007y-Cp
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:00:32 -0500
Received: from [2001:4830:134:6::a] (port=51590 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI879-00007u-9x
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:00:27 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aI878-0000ul-VX; Sun, 10 Jan 2016 05:00:26 +0000
Date: Sun, 10 Jan 2016 05:00:26 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46865
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.161.27 (Savane authenticated user nachanon)
Message-Id: <20160110-120025.sv82809.82949@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46865] Gnash rejects `levelNumber` parameter
	in `MovieClipLoader.loadClip(URL, levelNumber)`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2016 05:00:33 -0000

URL:
  <http://savannah.gnu.org/bugs/?46865>

                 Summary: Gnash rejects `levelNumber` parameter in
`MovieClipLoader.loadClip(URL,levelNumber)`
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sun 10 Jan 2016 12:00:25 PM ICT
                Category: core
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I have created a test Flash file which tries to display an external SWF file,
by loading it to `_level1` using `MovieClipLoader.loadClip(URL,levelNumber)`:

var loader:MovieClipLoader;

trace("loader: starting");
loader = new MovieClipLoader();
if(!loader.loadClip("testanimation.swf", 1)) {
	trace("loader: failed to start animation loading");
}
-verbatim+

It works as expected under Flash Player, but failed under Gnash;
`MovieClipLoader.loadClip()` rejected `levelNumber` argument,
and returned `false`.

Gnash: 0.8.11dev (git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386.

Note: If I replaced the `levelNumber` argument with a `MovieClip` instance,
it would work without problem under both Gnash and Flash Player.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46865>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 10 00:03:23 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aI89z-0003lh-8b
	for mharc-gnash-commit@gnu.org; Sun, 10 Jan 2016 00:03:23 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57405)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI89x-0003lC-5J
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:03:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI89s-0000oH-6a
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:03:21 -0500
Received: from [2001:4830:134:6::a] (port=51805 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI89s-0000oB-3E
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:03:16 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aI89r-0000vK-Ul; Sun, 10 Jan 2016 05:03:15 +0000
Date: Sun, 10 Jan 2016 05:03:15 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46865
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.161.27 (Savane authenticated user nachanon)
Message-Id: <20160110-120315.sv82809.94846@savannah.gnu.org>
References: <20160110-120025.sv82809.82949@savannah.gnu.org>
In-Reply-To: <20160110-120025.sv82809.82949@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46865] Gnash rejects `levelNumber` parameter
	in `MovieClipLoader.loadClip(URL, levelNumber)`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2016 05:03:22 -0000

Follow-up Comment #1, bug #46865 (project gnash):

Markup on previous post was messed up a bit, here is the original post:

I have created a test Flash file which tries to display an external SWF file,
by loading it to `_level1` using `MovieClipLoader.loadClip(URL,levelNumber)`:

var loader:MovieClipLoader;

trace("loader: starting");
loader = new MovieClipLoader();
if(!loader.loadClip("testanimation.swf", 1)) {
	trace("loader: failed to start animation loading");
}


It works as expected under Flash Player, but failed under Gnash;
`MovieClipLoader.loadClip()` rejected `levelNumber` argument,
and returned `false`.

Gnash: 0.8.11dev (git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386.

Note: If I replaced the `levelNumber` argument with a `MovieClip` instance,
it would work without problem under both Gnash and Flash Player.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46865>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 10 00:10:45 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aI8H7-0004ng-Be
	for mharc-gnash-commit@gnu.org; Sun, 10 Jan 2016 00:10:45 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8H5-0004nV-8I
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:10:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8H0-00031C-Lk
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:10:43 -0500
Received: from [2001:4830:134:6::a] (port=52354 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8H0-00030z-Ig
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:10:38 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aI8H0-000194-63; Sun, 10 Jan 2016 05:10:38 +0000
Date: Sun, 10 Jan 2016 05:10:38 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46865
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.161.27 (Savane authenticated user nachanon)
Message-Id: <20160110-121038.sv82809.67396@savannah.gnu.org>
References: <20160110-120025.sv82809.82949@savannah.gnu.org>
	<20160110-120315.sv82809.94846@savannah.gnu.org>
In-Reply-To: <20160110-120315.sv82809.94846@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46865] Gnash rejects `levelNumber` parameter
	in `MovieClipLoader.loadClip(URL, levelNumber)`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2016 05:10:44 -0000

Follow-up Comment #2, bug #46865 (project gnash):

This is a video result from Adobe Flash Player:
http://www.mediafire.com/?4jfu111z8azfcvk

You'll see that the animation (which is loaded from external SWF) plays.

This is a video result from Gnash:
http://www.mediafire.com/?uj7a5i7w909irk4

You'll see that the external SWF animation does not load.

Gnash's console output shows:

119 TRACE: loader: starting
120 ACTIONSCRIPT ERROR: Could not find target 1 (evaluated from [number:1])
120 TRACE: loader: failed to start animation loading


Test SWF, full source code, build scripts, screencasts, and logs (verbosity 2
with action error log) are attached.

Gnash: 0.8.11dev (git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386

(file #35960)
    _______________________________________________________

Additional Item Attachment:

File name: loaderlevelno.zip              Size:26 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46865>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 10 00:12:07 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aI8IR-00053z-TZ
	for mharc-gnash-commit@gnu.org; Sun, 10 Jan 2016 00:12:07 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8IQ-00053r-Ez
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:12:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8IL-0003ZK-GZ
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:12:06 -0500
Received: from [2001:4830:134:6::a] (port=52442 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8IL-0003ZG-D6
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:12:01 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aI8IL-00019Q-Ab; Sun, 10 Jan 2016 05:12:01 +0000
Date: Sun, 10 Jan 2016 05:12:01 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46865
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.161.27 (Savane authenticated user nachanon)
Message-Id: <20160110-121201.sv82809.10096@savannah.gnu.org>
References: <20160110-120025.sv82809.82949@savannah.gnu.org>
	<20160110-120315.sv82809.94846@savannah.gnu.org>
	<20160110-121038.sv82809.67396@savannah.gnu.org>
In-Reply-To: <20160110-121038.sv82809.67396@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46865] Gnash rejects `levelNumber` parameter
	in `MovieClipLoader.loadClip(URL, levelNumber)`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2016 05:12:07 -0000

Additional Item Attachment, bug #46865 (project gnash):

File name: loaderlevelno_fp11.2.202.491.ogv Size:132 KB
File name: loaderlevelno_fp11.2.202.491.log Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46865>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 10 00:13:16 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aI8JY-00059M-7U
	for mharc-gnash-commit@gnu.org; Sun, 10 Jan 2016 00:13:16 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8JW-00059E-1c
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:13:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8JS-0003l1-1C
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:13:13 -0500
Received: from [2001:4830:134:6::a] (port=52526 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aI8JR-0003kx-Ts
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 00:13:09 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aI8JR-00019W-Rp; Sun, 10 Jan 2016 05:13:09 +0000
Date: Sun, 10 Jan 2016 05:13:09 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46865
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.161.27 (Savane authenticated user nachanon)
Message-Id: <20160110-121309.sv82809.99822@savannah.gnu.org>
References: <20160110-120025.sv82809.82949@savannah.gnu.org>
	<20160110-120315.sv82809.94846@savannah.gnu.org>
	<20160110-121038.sv82809.67396@savannah.gnu.org>
	<20160110-121201.sv82809.10096@savannah.gnu.org>
In-Reply-To: <20160110-121201.sv82809.10096@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46865] Gnash rejects `levelNumber` parameter
	in `MovieClipLoader.loadClip(URL, levelNumber)`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2016 05:13:15 -0000

Additional Item Attachment, bug #46865 (project gnash):

File name: loaderlevelno_gnash0.8.11dev-15d61a8.ogv Size:25 KB
File name: loaderlevelno_gnash0.8.11dev-15d61a8.log Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46865>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 10 11:10:40 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIIZk-0002dP-12
	for mharc-gnash-commit@gnu.org; Sun, 10 Jan 2016 11:10:40 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36041)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIIZi-0002dG-He
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 11:10:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIIZe-0003Ax-HP
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 11:10:38 -0500
Received: from [2001:4830:134:6::a] (port=44190 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIIZe-0003At-Du
	for gnash-commit@gnu.org; Sun, 10 Jan 2016 11:10:34 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIIZA-0006pi-49; Sun, 10 Jan 2016 16:10:04 +0000
Date: Sun, 10 Jan 2016 16:10:04 +0000
To: -Deleted Account- <idontexist@nowhere.net>, Hapi <c_hapi@hotmail.com>,
	Hapi2 <phcamille@hotmail.com>, Julie <julie.wonder14@gmail.com>,
	Sandro Santilli <strk@keybit.net>,
	Maximiliano =?UTF-8?B?Q2FzdGHDscOzbg==?= Araneda <maximi89@gmail.com>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Bjorn Nostvold <bjorn.nostvold@gmail.com>,
	Bella <belladoxie@live.com>, maikl <belichenko_@ukr.net>,
	Bernie Innocenti <bernie@codewiz.org>,
	OPlucgk <ckw85348@piloq.com>, Marco <info@altamiraweb.es>,
	Nadav Kavalerchik <nadavkav@gmail.com>,
	Rodrigo Carvalho <rcsilva83@gmail.com>,
	Samuel =?UTF-8?B?TGlkw6lu?= Borell <samuel@kodafritt.se>,
	gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Julie <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 23435
User-Agent: Mozilla/5.0 (Macintosh;
	Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko)
	Chrome/47.0.2526.106 Safari/537.36
X-Apparently-From: 82.237.4.5 (Savane authenticated user julie)
Message-Id: <20160110-161003.sv102292.38827@savannah.gnu.org>
References: <20080530-052120.sv67576.63840@savannah.gnu.org>
	<20080601-030947.sv48477.56832@savannah.gnu.org>
	<20081010-112113.sv60230.36937@savannah.gnu.org>
	<20091209-212849.sv76464.42086@savannah.gnu.org>
	<20100920-093940.sv80137.6254@savannah.gnu.org>
	<20100924-173759.sv0.44627@savannah.gnu.org>
	<20101210-075423.sv60230.89429@savannah.gnu.org>
	<20101211-015541.sv43424.9979@savannah.gnu.org>
	<20101214-010135.sv43424.59275@savannah.gnu.org>
	<20110527-164309.sv9396.48077@savannah.gnu.org>
	<20110527-165022.sv9396.70570@savannah.gnu.org>
	<20110802-093645.sv27281.99084@savannah.gnu.org>
	<20110930-141601.sv85203.45504@savannah.gnu.org>
	<20111015-205448.sv0.19968@savannah.gnu.org>
	<20111015-205733.sv0.11828@savannah.gnu.org>
	<20111015-205823.sv0.15327@savannah.gnu.org>
	<20111015-205903.sv0.98852@savannah.gnu.org>
	<20111015-210021.sv0.88277@savannah.gnu.org>
	<20111015-210045.sv0.6915@savannah.gnu.org>
	<20111015-211855.sv0.44857@savannah.gnu.org>
	<20111015-211932.sv0.96743@savannah.gnu.org>
	<20111015-211945.sv0.3058@savannah.gnu.org>
	<20111015-212020.sv0.11466@savannah.gnu.org>
	<20111015-212032.sv0.37673@savannah.gnu.org>
	<20111015-212041.sv0.36781@savannah.gnu.org>
	<20111015-212054.sv0.56603@savannah.gnu.org>
	<20111015-212116.sv0.82630@savannah.gnu.org>
	<20111015-212128.sv0.5535@savannah.gnu.org>
	<20111015-212134.sv0.55135@savannah.gnu.org>
	<20111015-212139.sv0.21120@savannah.gnu.org>
	<20111015-212144.sv0.95581@savannah.gnu.org>
	<20111015-212204.sv0.95483@savannah.gnu.org>
	<20111015-212208.sv0.55917@savannah.gnu.org>
	<20111015-212213.sv0.83052@savannah.gnu.org>
	<20111015-212233.sv0.17909@savannah.gnu.org>
	<20111215-032001.sv86502.52580@savannah.gnu.org>
	<20120128-122636.sv86913.30138@savannah.gnu.org>
	<20130519-135802.sv90703.54900@savannah.gnu.org>
	<20130731-204517.sv92054.99015@savannah.gnu.org>
	<20131126-231824.sv93117.29607@savannah.gnu.org>
	<20150714-055243.sv100337.82085@savannah.gnu.org>
	<20150727-201122.sv100516.51572@savannah.gnu.org>
	<20150811-060338.sv100700.16246@savannah.gnu.org>
	<20150901-162252.sv100492.64065@savannah.gnu.org>
	<20150927-172817.sv101208.14240@savannah.gnu.org>
	<20150927-172952.sv101208.35076@savannah.gnu.org>
	<20150927-174325.sv101208.54147@savannah.gnu.org>
	<20150927-174804.sv101208.68924@savannah.gnu.org>
	<20150927-180604.sv101208.40469@savannah.gnu.org>
	<20150928-052013.sv101208.14222@savannah.gnu.org>
	<20150930-062616.sv101232.5956@savannah.gnu.org>
	<20151130-133030.sv97829.39785@savannah.gnu.org>
In-Reply-To: <20151130-133030.sv97829.39785@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #23435] Flash content rendered above menus in
	Firefox
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2016 16:10:39 -0000

Follow-up Comment #50, bug #23435 (project gnash):

Same case here for the header of this nutrition site
[url=http://www.authentico.fr/] [/url] 

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?23435>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 11 02:36:47 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIX1z-0007cc-Sb
	for mharc-gnash-commit@gnu.org; Mon, 11 Jan 2016 02:36:47 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIX1x-0007cS-Fw
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 02:36:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIX1u-0002QK-96
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 02:36:45 -0500
Received: from [2001:4830:134:6::a] (port=49157 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIX1u-0002QG-5f
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 02:36:42 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIX1s-0001ge-0I; Mon, 11 Jan 2016 07:36:40 +0000
Date: Mon, 11 Jan 2016 07:36:40 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46719
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.187 (Savane authenticated user nachanon)
Message-Id: <20160111-143639.sv82809.2407@savannah.gnu.org>
References: <20151219-233341.sv82809.54489@savannah.gnu.org>
	<20151226-155028.sv27281.39399@savannah.gnu.org>
In-Reply-To: <20151226-155028.sv27281.39399@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46719] Gnash's `GetVariable()` returns
	incorrect value of undefined variable under SWF5
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jan 2016 07:36:46 -0000

Follow-up Comment #2, bug #46719 (project gnash):

I have created a new test which checks `GetVariable()` on undefined
(unassigned) and nonexistent variable within SWF version 5-8 under Flash
Player:

* Under SWF 5-6, `undefined` value translates to an empty string.
* Under SWF 7-8, `undefined` value translates to a string "undefined".

This is consistent to Adobe's documentation regarding `undefined` value
<http://help.adobe.com/en_US/AS2LCR/Flash_10.0/00000549.html>
and Gnash's `as_value::to_string()` documentation
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/as_value.h?id=15d61a804138737764689338c491c41f2cf59acf#n228>,
and also means that
current automated test must also be corrected so that expected value from
undefined/unassigned variable SWF6 is the same as SWF5.


variable-v5:
variable-v5's string_variable: type=string, value=Hello!
variable-v5's unassigned_variable: type=string, value=
variable-v5's nonexistent_variable: type=object, value=null
variable-v6:
variable-v6's string_variable: type=string, value=Hello!
variable-v6's unassigned_variable: type=string, value=
variable-v6's nonexistent_variable: type=object, value=null
variable-v7:
variable-v7's string_variable: type=string, value=Hello!
variable-v7's unassigned_variable: type=string, value=undefined
variable-v7's nonexistent_variable: type=object, value=null
variable-v8:
variable-v8's string_variable: type=string, value=Hello!
variable-v8's unassigned_variable: type=string, value=undefined
variable-v8's nonexistent_variable: type=object, value=null


Test SWF, source code, build script, HTML container, text output
and screenshot are attached as `getvariable-allver.zip` for reference.

Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

(file #35985)
    _______________________________________________________

Additional Item Attachment:

File name: getvariable-allver.zip         Size:6 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46719>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 11 09:20:32 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIdKi-0003Vx-Ez
	for mharc-gnash-commit@gnu.org; Mon, 11 Jan 2016 09:20:32 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIdKa-0003Ec-8N
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 09:20:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIdKV-0002lw-8y
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 09:20:24 -0500
Received: from [2001:4830:134:6::a] (port=50930 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIdKV-0002ls-5a
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 09:20:19 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIdKT-0001wm-Th; Mon, 11 Jan 2016 14:20:18 +0000
Date: Mon, 11 Jan 2016 14:20:17 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46719
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.187 (Savane authenticated user nachanon)
Message-Id: <20160111-212017.sv82809.40512@savannah.gnu.org>
References: <20151219-233341.sv82809.54489@savannah.gnu.org>
	<20151226-155028.sv27281.39399@savannah.gnu.org>
	<20160111-143639.sv82809.2407@savannah.gnu.org>
In-Reply-To: <20160111-143639.sv82809.2407@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46719] Gnash's `GetVariable()` returns
	incorrect value of undefined variable under SWF5
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jan 2016 14:20:30 -0000

Follow-up Comment #3, bug #46719 (project gnash):

I have also done some more test regarding behavior of `GetVariable()` when
fetching variable from sub-MovieClip loaded from a different SWF file
which _uses a different SWF version_ (e.g. one loaded via `loadMovieNum()`).

Result is Flash Player acts on *root movie's SWF version*, not the version
of SWF that is loaded as the sub-MovieClip. That is when root movie is SWF7
and sub-movie is SWF5, `GetVariable()` will use SWF7 behavior. When root
movie
is SWF5 and sub-movie is SWF7, `GetVariable()` will use SWF5 behavior.

Test file, text output, and screenshot from Flash Player are attached
as `getvariable-extmovie.zip` for reference.

Note: This test code does not work on current Gnash due to path notation
part of bug #42395, which caused `GetVariable()` to fail on sub-MovieClip.

Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #35990)
    _______________________________________________________

Additional Item Attachment:

File name: getvariable-extmovie.zip       Size:9 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46719>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 11 10:00:37 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIdxV-0003ab-CD
	for mharc-gnash-commit@gnu.org; Mon, 11 Jan 2016 10:00:37 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35790)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIdxS-0003Ws-S9
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:00:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIdxN-0004hp-S5
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:00:34 -0500
Received: from [2001:4830:134:6::a] (port=53895 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIdxN-0004hi-OR
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:00:29 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIdxN-0002pi-AD; Mon, 11 Jan 2016 15:00:29 +0000
Date: Mon, 11 Jan 2016 15:00:29 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8851
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.187 (Savane authenticated user nachanon)
Message-Id: <20160111-220028.sv82809.94412@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8851] Patch to make `GetVariable()` plugin
	function use SWF version-specific string conversion
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jan 2016 15:00:36 -0000

URL:
  <http://savannah.gnu.org/patch/?8851>

                 Summary: Patch to make `GetVariable()` plugin function use
SWF version-specific string conversion
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Mon 11 Jan 2016 10:00:28 PM ICT
                Category: core
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Currently, Gnash's implementation of `GetVariable()` plugin interface uses
variable-to-string conversion function
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=15d61a804138737764689338c491c41f2cf59acf#n1605>
that is based on SWF7 convention
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/as_value.h?id=15d61a804138737764689338c491c41f2cf59acf#n236>
which causes discrepancy when the variable in question has `undefined` value
and root SWF is _version *6* or below_
<https://savannah.gnu.org/bugs/?46719#comment2> (it gives a string "undefined"
instead of
the expected empty string).

This patch makes it use a correct string conversion convention according to
root movie's SWF version, and adjusts the relevant automated test
accordingly;
fixing bug #46719, unblocking automated check of bug #45840 under SWF5.

See the attached `0001_getvariable-use-correct-string-conversion.patch`. 

Gnash: 0.8.11dev (patched against git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 11 Jan 2016 10:00:28 PM ICT  Name:
0001_getvariable-use-correct-string-conversion.patch  Size: 3kB   By: nachanon
Patch to make `GetVariable()` plugin function use SWF version-specific string
conversion
<http://savannah.gnu.org/patch/download.php?file_id=35991>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8851>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 11 10:04:32 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIe1I-0001s8-H3
	for mharc-gnash-commit@gnu.org; Mon, 11 Jan 2016 10:04:32 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37065)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIe1F-0001l8-OI
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:04:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIe1A-0005SB-Pz
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:04:29 -0500
Received: from [2001:4830:134:6::a] (port=54217 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIe1A-0005S2-GV
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:04:24 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIe1A-0002qW-0N; Mon, 11 Jan 2016 15:04:24 +0000
Date: Mon, 11 Jan 2016 15:04:24 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46719
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.187 (Savane authenticated user nachanon)
Message-Id: <20160111-220423.sv82809.81446@savannah.gnu.org>
References: <20151219-233341.sv82809.54489@savannah.gnu.org>
	<20151226-155028.sv27281.39399@savannah.gnu.org>
	<20160111-143639.sv82809.2407@savannah.gnu.org>
	<20160111-212017.sv82809.40512@savannah.gnu.org>
In-Reply-To: <20160111-212017.sv82809.40512@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46719] Gnash's `GetVariable()` returns
	incorrect value of undefined variable under SWF5
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jan 2016 15:04:31 -0000

Follow-up Comment #4, bug #46719 (project gnash):

Patch included, see patch #8851.

`getvariable-allver.html` output _before_ applying the patch:

variable-v5:
variable-v5's string_variable: type=string, value=Hello!
variable-v5's unassigned_variable: type=string, value=undefined
variable-v5's nonexistent_variable: type=object, value=null
variable-v6:
variable-v6's string_variable: type=string, value=Hello!
variable-v6's unassigned_variable: type=string, value=undefined
variable-v6's nonexistent_variable: type=object, value=null
variable-v7:
variable-v7's string_variable: type=string, value=Hello!
variable-v7's unassigned_variable: type=string, value=undefined
variable-v7's nonexistent_variable: type=object, value=null
variable-v8:
variable-v8's string_variable: type=string, value=Hello!
variable-v8's unassigned_variable: type=string, value=undefined
variable-v8's nonexistent_variable: type=object, value=null


You'd see that under SWF5 and SWF6, `undefined` value of
`unassigned_variable`
are translated to string "undefined", which is incorrect.

`getvariable-allver.html` output _after_ applied the patch:

variable-v5:
variable-v5's string_variable: type=string, value=Hello!
variable-v5's unassigned_variable: type=string, value=
variable-v5's nonexistent_variable: type=object, value=null
variable-v6:
variable-v6's string_variable: type=string, value=Hello!
variable-v6's unassigned_variable: type=string, value=
variable-v6's nonexistent_variable: type=object, value=null
variable-v7:
variable-v7's string_variable: type=string, value=Hello!
variable-v7's unassigned_variable: type=string, value=undefined
variable-v7's nonexistent_variable: type=object, value=null
variable-v8:
variable-v8's string_variable: type=string, value=Hello!
variable-v8's unassigned_variable: type=string, value=undefined
variable-v8's nonexistent_variable: type=object, value=null


You'd see that output from patched Gnash is identical to output from Flash
Player <https://savannah.gnu.org/bugs/?46719#comment2>.

Gnash: 0.8.11dev (patched against git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46719>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 11 10:14:07 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIeAZ-0001yq-CL
	for mharc-gnash-commit@gnu.org; Mon, 11 Jan 2016 10:14:07 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIeAW-0001tw-Fu
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:14:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIeAS-0008Uq-EE
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:14:04 -0500
Received: from [2001:4830:134:6::a] (port=54891 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIeAS-0008Um-BJ
	for gnash-commit@gnu.org; Mon, 11 Jan 2016 10:14:00 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIeAR-00033c-B9; Mon, 11 Jan 2016 15:13:59 +0000
Date: Mon, 11 Jan 2016 15:13:59 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 45840
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.187 (Savane authenticated user nachanon)
Message-Id: <20160111-221359.sv82809.54718@savannah.gnu.org>
References: <20150828-200922.sv82809.40825@savannah.gnu.org>
	<20150828-182911.sv27281.65830@savannah.gnu.org>
	<20150828-182937.sv27281.64584@savannah.gnu.org>
	<20150828-194112.sv27281.95645@savannah.gnu.org>
	<20150924-225054.sv82809.59235@savannah.gnu.org>
	<20150924-225233.sv82809.86358@savannah.gnu.org>
	<20151219-123248.sv82809.20495@savannah.gnu.org>
	<20151220-000936.sv82809.42495@savannah.gnu.org>
In-Reply-To: <20151220-000936.sv82809.42495@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #45840] Gnash ignores bare `var` declaration in
	timeline ActionScript
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jan 2016 15:14:05 -0000

Follow-up Comment #7, bug #45840 (project gnash):

See patch #8851, which fixes testability of this bug under SWF5.

Note (for the record): There is no need to test this under SWF4,
as `var` statement is available only in Flash 5 and later versions.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45840>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Jan 12 07:23:47 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIxzH-00042u-7I
	for mharc-gnash-commit@gnu.org; Tue, 12 Jan 2016 07:23:47 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57358)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIxzE-00041g-4N
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:23:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIxzA-0006YO-Rx
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:23:44 -0500
Received: from [2001:4830:134:6::a] (port=35999 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIxzA-0006YK-Oc
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:23:40 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIxzA-00052b-Jc; Tue, 12 Jan 2016 12:23:40 +0000
Date: Tue, 12 Jan 2016 12:23:40 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46878
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.162.101 (Savane authenticated user nachanon)
Message-Id: <20160112-192339.sv82809.34407@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46878] Gnash refused to call zero-parameter
	JavaScript function via ExternalInterface.call()
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 12:23:45 -0000

URL:
  <http://savannah.gnu.org/bugs/?46878>

                 Summary: Gnash refused to call zero-parameter JavaScript
function via ExternalInterface.call()
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Tue 12 Jan 2016 07:23:39 PM ICT
                Category: core
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

While I was testing around bug #46131 (ExternalInterface.call return issue),
I found that if Flash file tried to call a simple _zero-argument_
JavaScript function via Flash 8-style ExternalInterface using a code like
this:


flash.external.ExternalInterface.call("js_function");


Under browser with Flash Player, a JavaScript function named "js_function"
would be called and its return value would be passed back to ActionScript
as `ExternalInterface.call()`'s return value.

But under browser with Gnash plugin, the JavaScript function was _not
called_,
and `ExternalInterface.call()` returned `undefined` value.

According to Gnash's container-player communication log in this case,
the player never send "<invoke>" command to the container, thus
the JavaScript function was never called.

Note: This issue is specific to _zero argument_ function call.
Calling JavaScript function with one or more argument (even the target
function doesn't accept it) will get the target function called properly.

Gnash: 0.8.11dev (git 15d61a8 26-Dec-2015) NPAPI
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46878>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Jan 12 07:28:09 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIy3V-0005Z7-9j
	for mharc-gnash-commit@gnu.org; Tue, 12 Jan 2016 07:28:09 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58238)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIy3S-0005XQ-8X
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:28:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIy3P-0007UR-0W
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:28:06 -0500
Received: from [2001:4830:134:6::a] (port=36335 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIy3O-0007UK-Tc
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:28:02 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIy3N-00058u-5y; Tue, 12 Jan 2016 12:28:01 +0000
Date: Tue, 12 Jan 2016 12:28:01 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8851
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160112-132801.sv27281.10753@savannah.gnu.org>
References: <20160111-220028.sv82809.94412@savannah.gnu.org>
In-Reply-To: <20160111-220028.sv82809.94412@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8851] Patch to make `GetVariable()` plugin
	function use SWF version-specific string conversion
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 12:28:07 -0000

Update of patch #8851 (project gnash):

                  Status:                    None => In Progress            
             Assigned to:                    None => strk                   


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8851>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Jan 12 07:33:23 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIy8Z-0004Hi-08
	for mharc-gnash-commit@gnu.org; Tue, 12 Jan 2016 07:33:23 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59695)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIy8W-0004Do-3T
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:33:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIy8S-0000Yy-Us
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:33:20 -0500
Received: from [2001:4830:134:6::a] (port=36826 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIy8S-0000Ys-Qa
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:33:16 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIy8S-0005FS-Fk; Tue, 12 Jan 2016 12:33:16 +0000
Date: Tue, 12 Jan 2016 12:33:16 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46878
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.162.101 (Savane authenticated user nachanon)
Message-Id: <20160112-193316.sv82809.67150@savannah.gnu.org>
References: <20160112-192339.sv82809.34407@savannah.gnu.org>
In-Reply-To: <20160112-192339.sv82809.34407@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46878] Gnash refused to call zero-parameter
	JavaScript function via ExternalInterface.call()
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 12:33:21 -0000

Follow-up Comment #1, bug #46878 (project gnash):

I have created a simple Flash file (Flash 8) using libming's `makeswf`
with a HTML container to demonstrate the issue, attached as
`flash2js-zeroarg.zip`. JavaScript function `js_function()` prints a line
"js_function callback is called." to HTML page and returns a string "Hello!".

Text output from running `flash2js-zeroarg.html` under browser with Flash
Player:

js_function callback is called.


Player's trace output from the run:

flash2js-zeroarg: js_function returned: Hello!


You'd see that the JavaScript function was called, and return value was
passed
back to ActionScript properly.

Text output from running `flash2js-zeroarg.html` under browser with Gnash:




Gnash's console output from the run:

74 TRACE: flash2js-zeroarg: js_function returned: undefined


You'd see that the JavaScript function was not called (no output on HTML
page),
and `undefined` value was returned to ActionScript.

Text output, screenshots, full debug/trace output (verbosity 2 + action
error),
and Gnash's player-container communication logs are also attached in
`flash2js-zeroarg.zip`.

Gnash: 0.8.11dev (git 15d61a8 26-Dec-2015) NPAPI
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #35999)
    _______________________________________________________

Additional Item Attachment:

File name: flash2js-zeroarg.zip           Size:5 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46878>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Jan 12 07:58:45 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIyX7-0004Ao-3C
	for mharc-gnash-commit@gnu.org; Tue, 12 Jan 2016 07:58:45 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43867)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aIyX4-00047d-4L
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:58:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aIyWz-000124-W7
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:58:42 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:44989)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aIyWz-000120-TE
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:58:37 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1aIyWr-00060e-TN
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 12:58:35 +0000
Date: Tue, 12 Jan 2016 12:58:30 +0000
Message-Id: <E1aIyWr-00060e-TN@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 15d61a804138737764689338c491c41f2cf59acf
X-Git-Newrev: 6671ff0f7c0c9d35d4432001a64f2c132f70158f
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2247-g6671ff0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 12:58:43 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  6671ff0f7c0c9d35d4432001a64f2c132f70158f (commit)
      from  15d61a804138737764689338c491c41f2cf59acf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=6671ff0f7c0c9d35d4432001a64f2c132f70158f


commit 6671ff0f7c0c9d35d4432001a64f2c132f70158f
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Tue Jan 12 13:27:28 2016 +0100

    Use SWF version-dependent string conversion in GetVariable() host interface.

diff --git a/libcore/movie_root.cpp b/libcore/movie_root.cpp
index 3c643e9..c9ce412 100644
--- a/libcore/movie_root.cpp
+++ b/libcore/movie_root.cpp
@@ -1602,7 +1602,7 @@ movie_root::processInvoke(ExternalInterface::invoke_t *invoke)
             // If the variable exists, GetVariable returns a string
             // representation of its value. Variable with undefined
             // or null value counts as exist too.
-            ss << ExternalInterface::toXML(val.to_string());
+            ss << ExternalInterface::toXML(val.to_string(_vm.getSWFVersion()));
             ss << std::endl;
         } else {
             // If the variable does not exist, GetVariable sends null value
diff --git a/testsuite/misc-ming.all/extgetvariable_testrunner.sh b/testsuite/misc-ming.all/extgetvariable_testrunner.sh
index 956d274..2380f2b 100644
--- a/testsuite/misc-ming.all/extgetvariable_testrunner.sh
+++ b/testsuite/misc-ming.all/extgetvariable_testrunner.sh
@@ -247,11 +247,11 @@ echo '<invoke name="GetVariable" returntype="xml"><arguments><string>unassigned_
 
 # Read for return value statement
 read_timeout LINE \$READTIMEOUT <&3
-if [ "${swfversion}" -gt 5 ]
+if [ "${swfversion}" -gt 6 ]
 then
 	check_equals "\$LINE" '<string>undefined</string>' "Gnash should return a correct value from GetVariable call on unassigned variable"
 else
-	xcheck_equals "\$LINE" '<string></string>' "Gnash should return a correct value from GetVariable call on unassigned variable"
+	check_equals "\$LINE" '<string></string>' "Gnash should return a correct value from GetVariable call on unassigned variable"
 fi
 
 # Call string-returning GetVariable() on variable with undefined value
@@ -259,11 +259,11 @@ echo '<invoke name="GetVariable" returntype="xml"><arguments><string>undefined_v
 
 # Read for return value statement
 read_timeout LINE \$READTIMEOUT <&3
-if [ "${swfversion}" -gt 5 ]
+if [ "${swfversion}" -gt 6 ]
 then
 	check_equals "\$LINE" '<string>undefined</string>' "Gnash should return a correct value from GetVariable call on variable with undefined value"
 else
-	xcheck_equals "\$LINE" '<string></string>' "Gnash should return a correct value from GetVariable call on variable with undefined value"
+	check_equals "\$LINE" '<string></string>' "Gnash should return a correct value from GetVariable call on variable with undefined value"
 fi
 
 # Call string-returning GetVariable() on non-existent variable

-----------------------------------------------------------------------

Summary of changes:
 libcore/movie_root.cpp                             |    2 +-
 .../misc-ming.all/extgetvariable_testrunner.sh     |    8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Tue Jan 12 07:59:15 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aIyXb-0004tL-M6
	for mharc-gnash-commit@gnu.org; Tue, 12 Jan 2016 07:59:15 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIyXZ-0004qZ-8W
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:59:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIyXV-00016H-9d
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:59:13 -0500
Received: from [2001:4830:134:6::a] (port=39278 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aIyXV-00016D-5x
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 07:59:09 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aIyXS-0005mV-KS; Tue, 12 Jan 2016 12:59:06 +0000
Date: Tue, 12 Jan 2016 12:59:06 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8851
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160112-135906.sv27281.10284@savannah.gnu.org>
References: <20160111-220028.sv82809.94412@savannah.gnu.org>
	<20160112-132801.sv27281.10753@savannah.gnu.org>
In-Reply-To: <20160112-132801.sv27281.10753@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8851] Patch to make `GetVariable()` plugin
	function use SWF version-specific string conversion
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 12:59:14 -0000

Update of patch #8851 (project gnash):

                  Status:             In Progress => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #1:

Pushed as commit 6671ff0f7c0c9d35d4432001a64f2c132f70158f

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8851>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Jan 12 11:30:58 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJ1qT-0003zu-W3
	for mharc-gnash-commit@gnu.org; Tue, 12 Jan 2016 11:30:57 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52790)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ1qO-0003yr-Gw
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:30:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ1qJ-0005ZJ-Db
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:30:52 -0500
Received: from [2001:4830:134:6::a] (port=59615 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ1qJ-0005ZC-Aa
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:30:47 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJ1qI-00020E-WF; Tue, 12 Jan 2016 16:30:47 +0000
Date: Tue, 12 Jan 2016 16:30:46 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46878
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.167.154 (Savane authenticated user nachanon)
Message-Id: <20160112-233046.sv82809.7263@savannah.gnu.org>
References: <20160112-192339.sv82809.34407@savannah.gnu.org>
	<20160112-193316.sv82809.67150@savannah.gnu.org>
In-Reply-To: <20160112-193316.sv82809.67150@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46878] Gnash refused to call zero-parameter
	JavaScript function via ExternalInterface.call()
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 16:30:56 -0000

Follow-up Comment #2, bug #46878 (project gnash):

This seems to be caused by an incorrect argument number check
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/flash/external/ExternalInterface_as.cpp?id=6671ff0f7c0c9d35d4432001a64f2c132f70158f#n289>
in Gnash's
`ExternalInterface.call()` implementation, as it rejects call with 1 argument
which is supposed to be allowed since the only required argument in
`ExternalInterface.call()` is the first one (target JavaScript function
name).


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46878>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Jan 12 11:38:12 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJ1xU-0000HG-Kl
	for mharc-gnash-commit@gnu.org; Tue, 12 Jan 2016 11:38:12 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55734)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ1xS-0000GK-12
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:38:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ1xO-0007yj-S7
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:38:09 -0500
Received: from [2001:4830:134:6::a] (port=60128 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ1xO-0007yf-Ok
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:38:06 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJ1xO-00026z-GP; Tue, 12 Jan 2016 16:38:06 +0000
Date: Tue, 12 Jan 2016 16:38:06 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8853
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.167.154 (Savane authenticated user nachanon)
Message-Id: <20160112-233805.sv82809.71845@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8853] Patch to allow calling zero-argument
	JavaScript function via `ExternalInterface.call()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 16:38:11 -0000

URL:
  <http://savannah.gnu.org/patch/?8853>

                 Summary: Patch to allow calling zero-argument JavaScript
function via `ExternalInterface.call()`
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Tue 12 Jan 2016 11:38:05 PM ICT
                Category: core
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Current Gnash's `ExternalInterface.call()` does not allow calling JavaScript
function with no argument. If one tries to do it, the method will just
return `undefined` and JavaScript call will not be made
<https://savannah.gnu.org/bugs/?46878#comment1>.

This is caused by an incorrect argument check
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/flash/external/ExternalInterface_as.cpp?id=6671ff0f7c0c9d35d4432001a64f2c132f70158f#n289>
in `ExternalInterface.call()`
implementation which mistakenly rejects its invocation when number of
argument
is less than 2. (It should reject only when number of argument is *less than
1*
which would be when the required `functionName` argument was not given)

Patch 1 of 2:
See the attached `0001_allow-single-argument-externalinterface-call.patch`.

This patch corrects the comparison used in argument check, allowing
zero-argument JavaScript function call to be made; fixing bug #46878.

Automated test will follow.

Gnash: 0.8.11dev (patched against git 6671ff0 12-Jan-2016)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 12 Jan 2016 11:38:05 PM ICT  Name:
0001_allow-single-argument-externalinterface-call.patch  Size: 763B   By:
nachanon
Patch for allowing single-argument `ExternalInterface.call()` invocation
<http://savannah.gnu.org/patch/download.php?file_id=36002>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8853>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Jan 12 11:43:00 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJ227-0002TM-UW
	for mharc-gnash-commit@gnu.org; Tue, 12 Jan 2016 11:42:59 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ226-0002S4-4e
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:42:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ222-0000ds-UQ
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:42:58 -0500
Received: from [2001:4830:134:6::a] (port=60478 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJ222-0000dn-RL
	for gnash-commit@gnu.org; Tue, 12 Jan 2016 11:42:54 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJ222-0002Dc-FR; Tue, 12 Jan 2016 16:42:54 +0000
Date: Tue, 12 Jan 2016 16:42:54 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46878
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.167.154 (Savane authenticated user nachanon)
Message-Id: <20160112-234254.sv82809.60405@savannah.gnu.org>
References: <20160112-192339.sv82809.34407@savannah.gnu.org>
	<20160112-193316.sv82809.67150@savannah.gnu.org>
	<20160112-233046.sv82809.7263@savannah.gnu.org>
In-Reply-To: <20160112-233046.sv82809.7263@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46878] Gnash refused to call zero-parameter
	JavaScript function via ExternalInterface.call()
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jan 2016 16:42:59 -0000

Follow-up Comment #3, bug #46878 (project gnash):

Patch included, see patch #8853.

After applied the patch, this is text output from `flash2js-zeroarg.html`
under browser with Gnash:

js_function callback is called.


Gnash's console output from the run:

79 TRACE: flash2js-zeroarg: js_function returned: Hello!


You'd see that the JavaScript function is now called, and return value is
correctly passed back to ActionScript.

Gnash: 0.8.11dev (patched against git 6671ff0 12-Jan-2016)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46878>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 13 10:51:33 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJNht-0002d0-QI
	for mharc-gnash-commit@gnu.org; Wed, 13 Jan 2016 10:51:33 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJNhr-0002Yd-Hm
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:51:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJNho-00046k-A4
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:51:31 -0500
Received: from [2001:4830:134:6::a] (port=41001 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJNho-00046X-7u
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:51:28 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJNhm-0007ZN-26; Wed, 13 Jan 2016 15:51:26 +0000
Date: Wed, 13 Jan 2016 15:51:26 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8853
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160113-165125.sv27281.17247@savannah.gnu.org>
References: <20160112-233805.sv82809.71845@savannah.gnu.org>
In-Reply-To: <20160112-233805.sv82809.71845@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8853] Patch to allow calling zero-argument
	JavaScript function via `ExternalInterface.call()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jan 2016 15:51:32 -0000

Follow-up Comment #1, patch #8853 (project gnash):

No test coming with the patch ?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8853>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 13 10:52:46 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJNj4-0005He-IW
	for mharc-gnash-commit@gnu.org; Wed, 13 Jan 2016 10:52:46 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aJNj1-0005Ao-F9
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:52:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aJNj0-0004J7-Ex
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:52:43 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:60905)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aJNj0-0004J3-B6
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:52:42 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1aJNiz-00014e-9G
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 15:52:41 +0000
Date: Wed, 13 Jan 2016 15:52:41 +0000
Message-Id: <E1aJNiz-00014e-9G@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 6671ff0f7c0c9d35d4432001a64f2c132f70158f
X-Git-Newrev: e8b111c3ca89eb23624d5c994fc4dff9b787d161
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2248-ge8b111c
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jan 2016 15:52:44 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  e8b111c3ca89eb23624d5c994fc4dff9b787d161 (commit)
      from  6671ff0f7c0c9d35d4432001a64f2c132f70158f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161


commit e8b111c3ca89eb23624d5c994fc4dff9b787d161
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Wed Jan 13 16:50:36 2016 +0100

    Allow single-argument ExternalInterface.call() invocation.

diff --git a/libcore/asobj/flash/external/ExternalInterface_as.cpp b/libcore/asobj/flash/external/ExternalInterface_as.cpp
index 04c12bf..56274bc 100644
--- a/libcore/asobj/flash/external/ExternalInterface_as.cpp
+++ b/libcore/asobj/flash/external/ExternalInterface_as.cpp
@@ -286,7 +286,7 @@ externalinterface_call(const fn_call& fn)
         return val;
     }
 
-    if (fn.nargs > 1) {
+    if (fn.nargs >= 1) {
         const as_value& methodName_as = fn.arg(0);
         const std::string methodName = methodName_as.to_string();
         const std::vector<as_value>& args = fn.getArgs();

-----------------------------------------------------------------------

Summary of changes:
 .../asobj/flash/external/ExternalInterface_as.cpp  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Wed Jan 13 10:53:33 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJNjp-0006xb-31
	for mharc-gnash-commit@gnu.org; Wed, 13 Jan 2016 10:53:33 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41009)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJNjn-0006uD-GS
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:53:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJNjk-0004QI-60
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:53:31 -0500
Received: from [2001:4830:134:6::a] (port=41124 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJNjk-0004QE-26
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 10:53:28 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJNjj-0007Zo-3s; Wed, 13 Jan 2016 15:53:27 +0000
Date: Wed, 13 Jan 2016 15:53:27 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8853
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160113-165326.sv27281.77644@savannah.gnu.org>
References: <20160112-233805.sv82809.71845@savannah.gnu.org>
	<20160113-165125.sv27281.17247@savannah.gnu.org>
In-Reply-To: <20160113-165125.sv27281.17247@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8853] Patch to allow calling zero-argument
	JavaScript function via `ExternalInterface.call()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jan 2016 15:53:32 -0000

Update of patch #8853 (project gnash):

                  Status:                    None => Ready For Test         
             Assigned to:                    None => strk                   

    _______________________________________________________

Follow-up Comment #2:

Ah, "will follow", ok :)


This one is pushed with commit e8b111c3ca89eb23624d5c994fc4dff9b787d161

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8853>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 13 11:51:31 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJOdv-0006xe-IR
	for mharc-gnash-commit@gnu.org; Wed, 13 Jan 2016 11:51:31 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36642)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJOdt-0006xT-FP
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 11:51:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJOdq-0006Iy-Pf
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 11:51:29 -0500
Received: from [2001:4830:134:6::a] (port=45204 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJOdq-0006Iu-MU
	for gnash-commit@gnu.org; Wed, 13 Jan 2016 11:51:26 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJOdp-0000OR-4M; Wed, 13 Jan 2016 16:51:25 +0000
Date: Wed, 13 Jan 2016 16:51:25 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 27981
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.161.163 (Savane authenticated user nachanon)
Message-Id: <20160113-235124.sv82809.66256@savannah.gnu.org>
References: <20091109-183522.sv27281.26941@savannah.gnu.org>
	<20091109-200032.sv27281.89640@savannah.gnu.org>
	<20151213-191920.sv82809.51610@savannah.gnu.org>
In-Reply-To: <20151213-191920.sv82809.51610@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #27981] fscommand:quit ineffective if in first
	frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jan 2016 16:51:30 -0000

Follow-up Comment #3, bug #27981 (project gnash):

I have made a variant of test files (using makeswf and MTASC) which do
`fscommand("quit")` in _second frame_ rather than first frame, as a
comparison.

See the attached `secondframeexit.zip`.


(file #36015)
    _______________________________________________________

Additional Item Attachment:

File name: secondframeexit.zip            Size:6 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27981>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 14 07:53:06 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJhOk-00044O-Gv
	for mharc-gnash-commit@gnu.org; Thu, 14 Jan 2016 07:53:06 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45707)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJhOh-00043E-J2
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 07:53:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJhOe-0003wv-CD
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 07:53:03 -0500
Received: from [2001:4830:134:6::a] (port=58683 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJhOe-0003wr-90
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 07:53:00 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJhOc-0001Hw-VG; Thu, 14 Jan 2016 12:52:59 +0000
Date: Thu, 14 Jan 2016 12:52:58 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 27981
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.158 (Savane authenticated user nachanon)
Message-Id: <20160114-195258.sv82809.11501@savannah.gnu.org>
References: <20091109-183522.sv27281.26941@savannah.gnu.org>
	<20091109-200032.sv27281.89640@savannah.gnu.org>
	<20151213-191920.sv82809.51610@savannah.gnu.org>
	<20160113-235124.sv82809.66256@savannah.gnu.org>
In-Reply-To: <20160113-235124.sv82809.66256@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #27981] fscommand:quit ineffective if in first
	frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 12:53:04 -0000

Follow-up Comment #4, bug #27981 (project gnash):

First assertion error message seems to be caused by calling `gtk_main_quit()`
before the GUI code enters `gtk_main()`. I have created a dummy patch
which prints DEBUG message when `gtk-gnash` enter/terminate/exit main GTK
loop,
see the attached `show-gtk-main-loop-level.patch`.

After applied the patch, I tested using `gtk-gnash -vv singleframeexit.swf`:

81 DEBUG: gnash::GtkAggGlue::GtkAggGlue() enter
81 DEBUG: gnash::GtkAggGlue::GtkAggGlue() returning
81 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) enter
81 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) returning
112 DEBUG: gnash_canvas_size_allocate 257 1
112 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*) enter
112 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*)
returning
112 DEBUG: virtual gnash::Renderer* gnash::GtkAggGlue::createRenderHandler()
enter
113 DEBUG: Framebuffer pixel format is BGRA32 (little-endian host)
113 DEBUG: virtual gnash::Renderer* gnash::GtkAggGlue::createRenderHandler()
returning
113 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
enter
113 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
returning
113 DEBUG: /home/window/Desktop/firstframeexit/ appended to local sandboxes
113 DEBUG: /home/window/Desktop/firstframeexit/singleframeexit.swf appended to
local sandboxes
114 SECURITY: Checking security of URL
'file:///home/window/Desktop/firstframeexit/singleframeexit.swf'
114 SECURITY: Load of file
/home/window/Desktop/firstframeexit/singleframeexit.swf granted (under local
sandbox /home/window/Desktop/firstframeexit/)
114 DEBUG: Movie
file:///home/window/Desktop/firstframeexit/singleframeexit.swf (SWF7) added to
library
139 SECURITY: Extensions disabled
139 DEBUG: Advance interval timer set to 10 ms (~ 100 FPS)
139 DEBUG: Loading native class MovieClip
140 TRACE: This is first frame start.
142 DEBUG: GtkGui: terminating GTK main loop level 0

(gtk-gnash:20173): Gtk-CRITICAL **: IA__gtk_main_quit: assertion `main_loops
!= NULL' failed
142 TRACE: This is first frame end.
142 DEBUG: void gnash::Gui::resize_view(int, int) enter
142 DEBUG: void gnash::Gui::resize_view(int, int) returning

(gtk-gnash:20173): Gdk-CRITICAL **: gdk_window_invalidate_rect_full: assertion
`GDK_IS_WINDOW (window)' failed

(gtk-gnash:20173): Gdk-CRITICAL **: IA__gdk_window_process_updates: assertion
`GDK_IS_WINDOW (window)' failed
151 DEBUG: GtkGui: starting GTK main loop


>From debug output, you'd see that Gnash tried to terminate main GTK loop
before
the main loop is run, so it failed. When the GTK main loop is run afterward,
there were nothing else to stop it, so Gnash simply froze instead of exiting.

Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36027)
    _______________________________________________________

Additional Item Attachment:

File name: show-gtk-main-loop-level.patch Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27981>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 14 09:54:28 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJjIC-0004OJ-8n
	for mharc-gnash-commit@gnu.org; Thu, 14 Jan 2016 09:54:28 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJjI9-0004NC-LA
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 09:54:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJjI6-0006Z1-Du
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 09:54:25 -0500
Received: from [2001:4830:134:6::a] (port=44545 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJjI6-0006Yw-9w
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 09:54:22 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJjI6-0003zR-3U; Thu, 14 Jan 2016 14:54:22 +0000
Date: Thu, 14 Jan 2016 14:54:22 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46308
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.158 (Savane authenticated user nachanon)
Message-Id: <20160114-215421.sv82809.63359@savannah.gnu.org>
References: <20151028-184753.sv82809.50454@savannah.gnu.org>
	<20151028-191604.sv82809.63152@savannah.gnu.org>
	<20151213-192853.sv82809.85975@savannah.gnu.org>
In-Reply-To: <20151213-192853.sv82809.85975@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46308] `gtk-gnash --once` freezes when used on
	single-frame SWF
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 14:54:26 -0000

Follow-up Comment #3, bug #46308 (project gnash):

With diagnostic patch from bug #27981 (`show-gtk-main-loop-level.patch`
file #36027), debug output shows that the freeze of this bug is also caused
by gtk-gnash trying to exit main GTK loop before `gtk_main()` was run;
the same root cause as bug #27981 minus window-related assertion warnings.

`gtk-gnash -vv --once singleframe.swf`:

69 DEBUG: gnash::GtkAggGlue::GtkAggGlue() enter
69 DEBUG: gnash::GtkAggGlue::GtkAggGlue() returning
69 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) enter
69 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) returning
101 DEBUG: gnash_canvas_size_allocate 261 1
101 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*) enter
101 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*)
returning
101 DEBUG: virtual gnash::Renderer* gnash::GtkAggGlue::createRenderHandler()
enter
102 DEBUG: Framebuffer pixel format is BGRA32 (little-endian host)
102 DEBUG: virtual gnash::Renderer* gnash::GtkAggGlue::createRenderHandler()
returning
102 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
enter
102 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
returning
102 DEBUG: /home/window/Desktop/singleframe/ appended to local sandboxes
102 DEBUG: /home/window/Desktop/singleframe/singleframe.swf appended to local
sandboxes
103 SECURITY: Checking security of URL
'file:///home/window/Desktop/singleframe/singleframe.swf'
103 SECURITY: Load of file /home/window/Desktop/singleframe/singleframe.swf
granted (under local sandbox /home/window/Desktop/singleframe/)
103 DEBUG: Movie file:///home/window/Desktop/singleframe/singleframe.swf
(SWF7) added to library
112 SECURITY: Extensions disabled
112 DEBUG: Advance interval timer set to 10 ms (~ 100 FPS)
112 DEBUG: Loading native class MovieClip
112 DEBUG: void gnash::Gui::resize_view(int, int) enter
112 DEBUG: void gnash::Gui::resize_view(int, int) returning
115 DEBUG: GtkGui: terminating GTK main loop level 0

(gtk-gnash:26451): Gtk-CRITICAL **: IA__gtk_main_quit: assertion `main_loops
!= NULL' failed
115 DEBUG: GtkGui: starting GTK main loop


Thus, when the real `gtk_main()` is run, nothing stops it.

Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46308>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 14 10:40:58 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJk1C-0008Kb-4d
	for mharc-gnash-commit@gnu.org; Thu, 14 Jan 2016 10:40:58 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJk19-0008K7-MV
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 10:40:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJk16-0008Gq-Dw
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 10:40:55 -0500
Received: from [2001:4830:134:6::a] (port=50353 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJk16-0008Gi-AV
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 10:40:52 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJk15-00052y-9o; Thu, 14 Jan 2016 15:40:51 +0000
Date: Thu, 14 Jan 2016 15:40:51 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 27981
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.158 (Savane authenticated user nachanon)
Message-Id: <20160114-224051.sv82809.2473@savannah.gnu.org>
References: <20091109-183522.sv27281.26941@savannah.gnu.org>
	<20091109-200032.sv27281.89640@savannah.gnu.org>
	<20151213-191920.sv82809.51610@savannah.gnu.org>
	<20160113-235124.sv82809.66256@savannah.gnu.org>
	<20160114-195258.sv82809.11501@savannah.gnu.org>
In-Reply-To: <20160114-195258.sv82809.11501@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #27981] fscommand:quit ineffective if in first
	frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 15:40:56 -0000

Follow-up Comment #5, bug #27981 (project gnash):

Compare an contrast, using Gnash with the same diagnostic patch, but running
SWF that issues `fscommand("quit")` in _second frame_:

`gtk-gnash -vv secondframeexit.swf`:

66 DEBUG: gnash::GtkAggGlue::GtkAggGlue() enter
66 DEBUG: gnash::GtkAggGlue::GtkAggGlue() returning
66 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) enter
66 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) returning
91 DEBUG: gnash_canvas_size_allocate 261 1
91 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*) enter
91 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*)
returning
91 DEBUG: virtual gnash::Renderer* gnash::GtkAggGlue::createRenderHandler()
enter
92 DEBUG: Framebuffer pixel format is BGRA32 (little-endian host)
92 DEBUG: virtual gnash::Renderer* gnash::GtkAggGlue::createRenderHandler()
returning
92 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
enter
92 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
returning
92 DEBUG: /home/window/Desktop/secondframeexit/ appended to local sandboxes
92 DEBUG: /home/window/Desktop/secondframeexit/secondframeexit.swf appended to
local sandboxes
93 SECURITY: Checking security of URL
'file:///home/window/Desktop/secondframeexit/secondframeexit.swf'
93 SECURITY: Load of file
/home/window/Desktop/secondframeexit/secondframeexit.swf granted (under local
sandbox /home/window/Desktop/secondframeexit/)
93 DEBUG: Movie
file:///home/window/Desktop/secondframeexit/secondframeexit.swf (SWF7) added
to library
107 SECURITY: Extensions disabled
107 DEBUG: Advance interval timer set to 10 ms (~ 100 FPS)
107 DEBUG: Loading native class MovieClip
108 TRACE: This is first frame.
108 DEBUG: void gnash::Gui::resize_view(int, int) enter
108 DEBUG: void gnash::Gui::resize_view(int, int) returning
109 DEBUG: GtkGui: starting GTK main loop
113 DEBUG: gnash_canvas_size_allocate 320 240
113 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
enter
113 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
returning
113 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
enter
113 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
returning
113 DEBUG: void gnash::Gui::resize_view(int, int) enter
114 DEBUG: void gnash::Gui::resize_view(int, int) returning
199 TRACE: This is second frame start.
200 DEBUG: GtkGui: terminating GTK main loop level 1
200 TRACE: This is second frame end.
200 DEBUG: GtkGui: GTK main loop ended
200 DEBUG: Main loop ended, cleaning up
201 DEBUG: ~Player - _movieDef refcount: 2 (1 will be dropped now)
201 DEBUG: ~Gui - _movieDef refcount: 1


You'd see that in this case, `gtk_main_quit()` is run while `gtk_main()`
was running, thus no problem on terminating the main loop.

Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27981>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 14 10:54:15 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJkE3-0005kX-L2
	for mharc-gnash-commit@gnu.org; Thu, 14 Jan 2016 10:54:15 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57584)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJkE1-0005i4-E1
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 10:54:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJkDw-0003or-B1
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 10:54:13 -0500
Received: from [2001:4830:134:6::a] (port=51179 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJkDw-0003ok-7N
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 10:54:08 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJkDv-0005Gk-Vl; Thu, 14 Jan 2016 15:54:08 +0000
Date: Thu, 14 Jan 2016 15:54:07 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8858
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.158 (Savane authenticated user nachanon)
Message-Id: <20160114-225406.sv82809.63680@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8858] Patch to avoid freeze when SWF caused
	gtk-gnash to exit on first frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 15:54:15 -0000

URL:
  <http://savannah.gnu.org/patch/?8858>

                 Summary: Patch to avoid freeze when SWF caused gtk-gnash to
exit on first frame
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Thu 14 Jan 2016 10:54:06 PM ICT
                Category: gui
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Patch 1 of 2:
See the attached `0001_avoid-gtk-main-if-first-frame-exit.patch`.

Current Gnash's GTK GUI implementation have a problem when the rendering
of SWF finished _in first frame_ (whether this is due to `fscommand("quit")`
code or using `--once` option with single-frame SWF), it will result in Gnash
freezing instead of exiting normally
<https://savannah.gnu.org/bugs/?27981#comment2>.

This is caused by gtk-gnash's `GtkGui::quitUI()` which tried to call
`gtk_main_quit()` before the `gtk_main()` loop was entered in `GtkGui::run()`
<https://savannah.gnu.org/bugs/?27981#comment4>.
So when the GTK main loop was run, it didn't stop.

The patch addressed this by:
* Making `GtkGui:quitUI()` call `gtk_main_quit()` only when GTK main loop is
running.
* Making `GtkGui:quitUI()` set an `_exiting` flag in `GtkGui`.
* Making `GtkGui::run()` skip calling `gtk_main()` if `_exiting` flag in
`GtkGui` is set.

This fixes bug #46308 and freezing part of bug #27981;
window-related assertion warnings part of bug #27981 still remains.

Might need a review since I'm not sure if there is a nicer way to do this.

Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 14 Jan 2016 10:54:06 PM ICT  Name:
0001_avoid-gtk-main-if-first-frame-exit.patch  Size: 1kB   By: nachanon
Patch to make `GtkGui::run()` avoid entering `gtk_main() if an exit was
pending
<http://savannah.gnu.org/patch/download.php?file_id=36033>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8858>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 14 11:01:25 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJkKz-00082h-Kw
	for mharc-gnash-commit@gnu.org; Thu, 14 Jan 2016 11:01:25 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59218)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJkKs-00080j-P3
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 11:01:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJkKo-0005kM-M7
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 11:01:18 -0500
Received: from [2001:4830:134:6::a] (port=51741 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJkKo-0005k7-Ig
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 11:01:14 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJkKn-0005T1-Av; Thu, 14 Jan 2016 16:01:13 +0000
Date: Thu, 14 Jan 2016 16:01:13 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 27981
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.158 (Savane authenticated user nachanon)
Message-Id: <20160114-230113.sv82809.55977@savannah.gnu.org>
References: <20091109-183522.sv27281.26941@savannah.gnu.org>
	<20091109-200032.sv27281.89640@savannah.gnu.org>
	<20151213-191920.sv82809.51610@savannah.gnu.org>
	<20160113-235124.sv82809.66256@savannah.gnu.org>
	<20160114-195258.sv82809.11501@savannah.gnu.org>
	<20160114-224051.sv82809.2473@savannah.gnu.org>
In-Reply-To: <20160114-224051.sv82809.2473@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #27981] fscommand:quit ineffective if in first
	frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 16:01:24 -0000

Follow-up Comment #6, bug #27981 (project gnash):

Patch included, see patch #8858.

This patch make sure that `GtkGui::quitUI()` calls `gtk_main_quit()` only
when `gtk_main()` is running. It also adds an `_exiting` flag inside
`GtkGui`,
which once set via `GtkGui::quitUI()`, will instruct `GtkGui::run()`
to avoid entering `gtk_main()` when it was not already entered;
eliminating the freeze, though it does not fix other window-related assertion
warnings.

Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27981>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 14 11:37:08 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aJktY-0008Fm-8p
	for mharc-gnash-commit@gnu.org; Thu, 14 Jan 2016 11:37:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41589)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJktW-0008DL-D4
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 11:37:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJktR-0007hh-Dd
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 11:37:06 -0500
Received: from [2001:4830:134:6::a] (port=54436 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aJktR-0007hc-AK
	for gnash-commit@gnu.org; Thu, 14 Jan 2016 11:37:01 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aJktR-0006Da-0y; Thu, 14 Jan 2016 16:37:01 +0000
Date: Thu, 14 Jan 2016 16:37:01 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46308
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.158 (Savane authenticated user nachanon)
Message-Id: <20160114-233700.sv82809.91489@savannah.gnu.org>
References: <20151028-184753.sv82809.50454@savannah.gnu.org>
	<20151028-191604.sv82809.63152@savannah.gnu.org>
	<20151213-192853.sv82809.85975@savannah.gnu.org>
	<20160114-215421.sv82809.63359@savannah.gnu.org>
In-Reply-To: <20160114-215421.sv82809.63359@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46308] `gtk-gnash --once` freezes when used on
	single-frame SWF
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jan 2016 16:37:07 -0000

Follow-up Comment #4, bug #46308 (project gnash):

See patch #8858, which also fix this issue.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46308>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 15 04:49:01 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aK109-0002x9-LA
	for mharc-gnash-commit@gnu.org; Fri, 15 Jan 2016 04:49:01 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK106-0002wQ-Vn
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 04:49:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK102-0002ya-UG
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 04:48:58 -0500
Received: from [2001:4830:134:6::a] (port=54857 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK102-0002yV-Pu
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 04:48:54 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aK100-0004uD-CJ; Fri, 15 Jan 2016 09:48:52 +0000
Date: Fri, 15 Jan 2016 09:48:52 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 27981
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.164.100 (Savane authenticated user nachanon)
Message-Id: <20160115-164852.sv82809.69938@savannah.gnu.org>
References: <20091109-183522.sv27281.26941@savannah.gnu.org>
	<20091109-200032.sv27281.89640@savannah.gnu.org>
	<20151213-191920.sv82809.51610@savannah.gnu.org>
	<20160113-235124.sv82809.66256@savannah.gnu.org>
	<20160114-195258.sv82809.11501@savannah.gnu.org>
	<20160114-224051.sv82809.2473@savannah.gnu.org>
	<20160114-230113.sv82809.55977@savannah.gnu.org>
In-Reply-To: <20160114-230113.sv82809.55977@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #27981] fscommand:quit ineffective if in first
	frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jan 2016 09:49:00 -0000

Follow-up Comment #7, bug #27981 (project gnash):

Regarding window-related assertion warnings, I have tested around and found
that they were caused by two
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gtk/gtk.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n913>
part
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gtk/gtk.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n870>
of screen refreshing code
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gui.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n689>
which took place
after frame's initial ActionScript interpretation
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gui.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n942>
in frame-advancing
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gui.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n934>.

Warnings appeared as screen refreshing code is run without knowing that
the window was already destroyed by `GtkGui::quitUI()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gtk/gtk.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n592>.

For the reason that `secondframeexit.swf` produced no assertion warnings even
`GtkGui::quitUI()` ran before window refreshing, is that there was no
graphics
change between first and second frame, thus refreshing was skipped
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gui.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n768>.

I have created a variant of `secondframeexit.swf` which has graphics drawn
on second frame. When run with Gnash, you'd see that the window assertion
warnings are now appeared:

`gnash -vv secondframeexit-repaint.swf`:

83 DEBUG: gnash::GtkAggGlue::GtkAggGlue() enter
83 DEBUG: gnash::GtkAggGlue::GtkAggGlue() returning
83 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) enter
83 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) returning
107 DEBUG: gnash_canvas_size_allocate 257 1
107 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*) enter
107 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*)
returning
107 DEBUG: virtual gnash::Renderer* gnash::GtkAggGlue::createRenderHandler()
enter
108 DEBUG: Framebuffer pixel format is BGRA32 (little-endian host)
108 DEBUG: virtual gnash::Renderer* gnash::GtkAggGlue::createRenderHandler()
returning
108 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
enter
108 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
returning
109 DEBUG: /home/window/Desktop/secondframeexit-repaint/ appended to local
sandboxes
109 DEBUG:
/home/window/Desktop/secondframeexit-repaint/secondframeexit-repaint.swf
appended to local sandboxes
109 SECURITY: Checking security of URL
'file:///home/window/Desktop/secondframeexit-repaint/secondframeexit-repaint.swf'
109 SECURITY: Load of file
/home/window/Desktop/secondframeexit-repaint/secondframeexit-repaint.swf
granted (under local sandbox /home/window/Desktop/secondframeexit-repaint/)
109 DEBUG: Movie
file:///home/window/Desktop/secondframeexit-repaint/secondframeexit-repaint.swf
(SWF7) added to library
135 SECURITY: Extensions disabled
136 DEBUG: Advance interval timer set to 10 ms (~ 100 FPS)
136 DEBUG: Loading native class MovieClip
136 TRACE: This is first frame.
136 DEBUG: void gnash::Gui::resize_view(int, int) enter
136 DEBUG: void gnash::Gui::resize_view(int, int) returning
143 DEBUG: gnash_canvas_size_allocate 320 240
143 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
enter
159 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
returning
159 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
enter
159 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int, int)
returning
159 DEBUG: void gnash::Gui::resize_view(int, int) enter
161 DEBUG: void gnash::Gui::resize_view(int, int) returning
222 TRACE: This is second frame start.
223 TRACE: This is second frame end.

(gtk-gnash:10008): Gdk-CRITICAL **: gdk_window_invalidate_rect_full: assertion
`GDK_IS_WINDOW (window)' failed

(gtk-gnash:10008): Gdk-CRITICAL **: IA__gdk_window_process_updates: assertion
`GDK_IS_WINDOW (window)' failed
225 DEBUG: Main loop ended, cleaning up
225 DEBUG: ~Player - _movieDef refcount: 2 (1 will be dropped now)
225 DEBUG: ~Gui - _movieDef refcount: 1


Test files and source code are attached as `secondframeexit-repaint.zip`.

Gnash: 0.8.11dev (git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

Note: `secondframeexit-repaint.swf` is hand-crafted using SWFML Simple,
as SWFTools's SWFC did not recognize the built-in `getURL()` function,
and Gnash did not recognize "fscommand:" scheme in `MovieClip.getURL()`.


(file #36046)
    _______________________________________________________

Additional Item Attachment:

File name: secondframeexit-repaint.zip    Size:4 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27981>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 15 05:03:49 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aK1ET-0007Xf-1n
	for mharc-gnash-commit@gnu.org; Fri, 15 Jan 2016 05:03:49 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1EM-0007XG-9c
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:03:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1EJ-0006vV-0i
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:03:42 -0500
Received: from [2001:4830:134:6::a] (port=55812 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1EI-0006vR-TG
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:03:38 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aK1EI-0005DP-KU; Fri, 15 Jan 2016 10:03:38 +0000
Date: Fri, 15 Jan 2016 10:03:38 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46308
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.164.100 (Savane authenticated user nachanon)
Message-Id: <20160115-170338.sv82809.54787@savannah.gnu.org>
References: <20151028-184753.sv82809.50454@savannah.gnu.org>
	<20151028-191604.sv82809.63152@savannah.gnu.org>
	<20151213-192853.sv82809.85975@savannah.gnu.org>
	<20160114-215421.sv82809.63359@savannah.gnu.org>
	<20160114-233700.sv82809.91489@savannah.gnu.org>
In-Reply-To: <20160114-233700.sv82809.91489@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46308] `gtk-gnash --once` freezes when used on
	single-frame SWF
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jan 2016 10:03:48 -0000

Follow-up Comment #5, bug #46308 (project gnash):

After applied the first patch of patch #8858, you'd see that running
`gtk-gnash --once singleframe.swf` now terminates gracefully by itself:


$ gtk-gnash -vv --once singleframe.swf
18204:1] 73 DEBUG: gnash::GtkAggGlue::GtkAggGlue() enter
18204:1] 73 DEBUG: gnash::GtkAggGlue::GtkAggGlue() returning
18204:1] 73 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***) enter
18204:1] 74 DEBUG: virtual bool gnash::GtkAggGlue::init(int, char***)
returning
18204:1] 98 DEBUG: gnash_canvas_size_allocate 257 1
18204:1] 98 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*)
enter
18204:1] 98 DEBUG: virtual void gnash::GtkAggGlue::prepDrawingArea(GtkWidget*)
returning
18204:1] 98 DEBUG: virtual gnash::Renderer*
gnash::GtkAggGlue::createRenderHandler() enter
18204:1] 99 DEBUG: Framebuffer pixel format is BGRA32 (little-endian host)
18204:1] 99 DEBUG: virtual gnash::Renderer*
gnash::GtkAggGlue::createRenderHandler() returning
18204:1] 99 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int,
int) enter
18204:1] 99 DEBUG: virtual void gnash::GtkAggGlue::setRenderHandlerSize(int,
int) returning
18204:1] 99 DEBUG: /home/window/Desktop/singleframe/ appended to local
sandboxes
18204:1] 99 DEBUG: /home/window/Desktop/singleframe/singleframe.swf appended
to local sandboxes
18204:1] 99 SECURITY: Checking security of URL
'file:///home/window/Desktop/singleframe/singleframe.swf'
18204:1] 99 SECURITY: Load of file
/home/window/Desktop/singleframe/singleframe.swf granted (under local sandbox
/home/window/Desktop/singleframe/)
18204:1] 99 DEBUG: Movie
file:///home/window/Desktop/singleframe/singleframe.swf (SWF7) added to
library
18204:1] 120 SECURITY: Extensions disabled
18204:1] 120 DEBUG: Advance interval timer set to 10 ms (~ 100 FPS)
18204:1] 120 DEBUG: Loading native class MovieClip
18204:1] 120 DEBUG: void gnash::Gui::resize_view(int, int) enter
18204:1] 120 DEBUG: void gnash::Gui::resize_view(int, int) returning
18204:1] 123 DEBUG: Main loop ended, cleaning up
18204:1] 123 DEBUG: ~Player - _movieDef refcount: 2 (1 will be dropped now)
18204:1] 123 DEBUG: ~Gui - _movieDef refcount: 1
$ echo $?
0
$


Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46308>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 15 05:13:30 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aK1Nq-0005ou-PK
	for mharc-gnash-commit@gnu.org; Fri, 15 Jan 2016 05:13:30 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35952)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1Np-0005ok-3L
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:13:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1Nl-0001DX-S0
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:13:29 -0500
Received: from [2001:4830:134:6::a] (port=56444 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1Nl-0001DT-PD
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:13:25 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aK1Nl-0005QC-GX; Fri, 15 Jan 2016 10:13:25 +0000
Date: Fri, 15 Jan 2016 10:13:25 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8858
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.164.100 (Savane authenticated user nachanon)
Message-Id: <20160115-171325.sv82809.57345@savannah.gnu.org>
References: <20160114-225406.sv82809.63680@savannah.gnu.org>
In-Reply-To: <20160114-225406.sv82809.63680@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8858] Patch to avoid freeze when SWF caused
	gtk-gnash to exit on first frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jan 2016 10:13:30 -0000

Follow-up Comment #1, patch #8858 (project gnash):

Patch 2 of 2:
See the attached `0002_defer-cleanup-to-after-gtk-main.patch`.

Both window-related assertion warnings in this case are originated from
screen
redrawing code that is run after ActionScript executed, which at the time,
display window was already destroyed by `GtkGui::quitUI()`
<https://savannah.gnu.org/bugs/?27981#comment7> as a result of
`fscommand("quit")`.

This patch addressed this by deferring window cleanup to after `gtk_main()`
end
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gtk/gtk.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n258>,
which should ensure that there will be no drawing operation take place after
it.  

Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36047)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_defer-cleanup-to-after-gtk-main.patch Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8858>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 15 05:17:28 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aK1Rg-0006RL-Tv
	for mharc-gnash-commit@gnu.org; Fri, 15 Jan 2016 05:17:28 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37353)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1Rf-0006RC-83
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:17:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1Rb-00024h-Rd
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:17:27 -0500
Received: from [2001:4830:134:6::a] (port=56790 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aK1Rb-00024b-Nw
	for gnash-commit@gnu.org; Fri, 15 Jan 2016 05:17:23 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aK1Rb-0005Wk-5w; Fri, 15 Jan 2016 10:17:23 +0000
Date: Fri, 15 Jan 2016 10:17:23 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 27981
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.164.100 (Savane authenticated user nachanon)
Message-Id: <20160115-171723.sv82809.83410@savannah.gnu.org>
References: <20091109-183522.sv27281.26941@savannah.gnu.org>
	<20091109-200032.sv27281.89640@savannah.gnu.org>
	<20151213-191920.sv82809.51610@savannah.gnu.org>
	<20160113-235124.sv82809.66256@savannah.gnu.org>
	<20160114-195258.sv82809.11501@savannah.gnu.org>
	<20160114-224051.sv82809.2473@savannah.gnu.org>
	<20160114-230113.sv82809.55977@savannah.gnu.org>
	<20160115-164852.sv82809.69938@savannah.gnu.org>
In-Reply-To: <20160115-164852.sv82809.69938@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #27981] fscommand:quit ineffective if in first
	frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jan 2016 10:17:28 -0000

Follow-up Comment #8, bug #27981 (project gnash):

I think moving window cleanup code from `Gtk::quitUI()` to `GtkGui::run()`
just after `gtk_main()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gtk/gtk.cpp?id=e8b111c3ca89eb23624d5c994fc4dff9b787d161#n258>
should help, as it ensure that the cleanup code
only run at the end, after all the drawing operations were already dealt
with.

Patch included, see patch #8858 comment 1
<https://savannah.gnu.org/patch/?8858#comment1>.

Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27981>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 16 06:05:30 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aKOfi-0004ZR-8j
	for mharc-gnash-commit@gnu.org; Sat, 16 Jan 2016 06:05:30 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aKOfg-0004ZH-2A
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:05:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aKOfe-0007Di-Sk
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:05:27 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:46093)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aKOfe-0007De-Oq
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:05:26 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1aKOfe-000288-1G
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 11:05:26 +0000
Date: Sat, 16 Jan 2016 11:05:26 +0000
Message-Id: <E1aKOfe-000288-1G@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: e8b111c3ca89eb23624d5c994fc4dff9b787d161
X-Git-Newrev: 62cfdfe81d6d9a17c722558dc6046b6596342e98
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2250-g62cfdfe
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jan 2016 11:05:29 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  62cfdfe81d6d9a17c722558dc6046b6596342e98 (commit)
       via  17a8452d9691d87ca4dda9f4e7edc872ff29c9ea (commit)
      from  e8b111c3ca89eb23624d5c994fc4dff9b787d161 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=62cfdfe81d6d9a17c722558dc6046b6596342e98


commit 62cfdfe81d6d9a17c722558dc6046b6596342e98
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Sat Jan 16 12:00:32 2016 +0100

    Defer gtk-gnash's window cleanup to the end of gtk_main().
    
    This fixes window-related assertion warnings in bug #27981.

diff --git a/gui/gtk/gtk.cpp b/gui/gtk/gtk.cpp
index 82e88f3..7fc22c8 100644
--- a/gui/gtk/gtk.cpp
+++ b/gui/gtk/gtk.cpp
@@ -260,6 +260,7 @@ GtkGui::run()
     {
         gtk_main();
     }
+    gtk_widget_destroy(_window);
     return true;
 }
 
@@ -593,7 +594,6 @@ GtkGui::quitUI()
     // Unregister the callback registered by setTimeout, if any. This also
     // removes other callbacks, but we're about to go away anyway.
     while (g_source_remove_by_user_data(this)) {}
-    gtk_widget_destroy(_window);
 
     _exiting = true;
     if (gtk_main_level() > 0)

http://git.savannah.gnu.org/cgit//commit/?id=17a8452d9691d87ca4dda9f4e7edc872ff29c9ea


commit 17a8452d9691d87ca4dda9f4e7edc872ff29c9ea
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Sat Jan 16 11:58:02 2016 +0100

    Make gtk-gnash avoid entering gtk_main() if SWF exited in first frame.
    
    This fixes the freeze in bug #27981 and bug #46308.

diff --git a/gui/gtk/gtk.cpp b/gui/gtk/gtk.cpp
index 6f6d828..82e88f3 100644
--- a/gui/gtk/gtk.cpp
+++ b/gui/gtk/gtk.cpp
@@ -144,6 +144,7 @@ GtkGui::GtkGui(unsigned long xid, float scale, bool loop, RunResources& r)
     ,_popup_menu_alt(0)
     ,_menubar(0)
     ,_vbox(0)
+    ,_exiting(false)
     ,_advanceSourceTimer(0)
 {
 }
@@ -255,7 +256,10 @@ GtkGui::run()
     // Kick-start before setting the interval timeout
     advance_movie(this);
 
-    gtk_main();
+    if (!_exiting)
+    {
+        gtk_main();
+    }
     return true;
 }
 
@@ -590,7 +594,12 @@ GtkGui::quitUI()
     // removes other callbacks, but we're about to go away anyway.
     while (g_source_remove_by_user_data(this)) {}
     gtk_widget_destroy(_window);
-    gtk_main_quit();
+
+    _exiting = true;
+    if (gtk_main_level() > 0)
+    {
+        gtk_main_quit();
+    }
 }
 
 /*private*/
diff --git a/gui/gtk/gtksup.h b/gui/gtk/gtksup.h
index 1cefe35..7250a00 100644
--- a/gui/gtk/gtksup.h
+++ b/gui/gtk/gtksup.h
@@ -144,6 +144,9 @@ private:
     GtkWidget* _menubar;
     GtkWidget* _vbox;
 
+    /// Exit flag, set by quitUI() to prevent entering gtk_main() if Gnash
+    /// terminated in first frame.
+    bool _exiting;
 
     /// Add key press events to the toplevel window.
     //

-----------------------------------------------------------------------

Summary of changes:
 gui/gtk/gtk.cpp  |   15 ++++++++++++---
 gui/gtk/gtksup.h |    3 +++
 2 files changed, 15 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Sat Jan 16 06:06:00 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aKOgC-0004c6-OT
	for mharc-gnash-commit@gnu.org; Sat, 16 Jan 2016 06:06:00 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOgA-0004bW-9A
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:05:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOg6-0007Iq-9j
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:05:58 -0500
Received: from [2001:4830:134:6::a] (port=43097 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOg6-0007Il-5l
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:05:54 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aKOg3-0003aa-P2; Sat, 16 Jan 2016 11:05:51 +0000
Date: Sat, 16 Jan 2016 11:05:51 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8858
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160116-120551.sv27281.8737@savannah.gnu.org>
References: <20160114-225406.sv82809.63680@savannah.gnu.org>
	<20160115-171325.sv82809.57345@savannah.gnu.org>
In-Reply-To: <20160115-171325.sv82809.57345@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8858] Patch to avoid freeze when SWF caused
	gtk-gnash to exit on first frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jan 2016 11:05:59 -0000

Update of patch #8858 (project gnash):

                  Status:                    None => Done                   
             Assigned to:                    None => strk                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #2:

commit 17a8452d9691d87ca4dda9f4e7edc872ff29c9ea
commit 62cfdfe81d6d9a17c722558dc6046b6596342e98


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8858>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 16 06:11:03 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aKOl4-0004tW-QC
	for mharc-gnash-commit@gnu.org; Sat, 16 Jan 2016 06:11:02 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59274)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOl2-0004tA-Dg
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:11:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOkz-0000RX-3D
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:11:00 -0500
Received: from [2001:4830:134:6::a] (port=43439 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOkz-0000RS-0B
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:10:57 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aKOkx-0003hI-TO; Sat, 16 Jan 2016 11:10:55 +0000
Date: Sat, 16 Jan 2016 11:10:55 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 27981
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160116-121055.sv27281.46397@savannah.gnu.org>
References: <20091109-183522.sv27281.26941@savannah.gnu.org>
	<20091109-200032.sv27281.89640@savannah.gnu.org>
	<20151213-191920.sv82809.51610@savannah.gnu.org>
	<20160113-235124.sv82809.66256@savannah.gnu.org>
	<20160114-195258.sv82809.11501@savannah.gnu.org>
	<20160114-224051.sv82809.2473@savannah.gnu.org>
	<20160114-230113.sv82809.55977@savannah.gnu.org>
	<20160115-164852.sv82809.69938@savannah.gnu.org>
	<20160115-171723.sv82809.83410@savannah.gnu.org>
In-Reply-To: <20160115-171723.sv82809.83410@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #27981] fscommand:quit ineffective if in first
	frame
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jan 2016 11:11:01 -0000

Update of bug #27981 (project gnash):

                  Status:                    None => Fixed                  
             Assigned to:                    None => strk                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #9:

This if fixed by patch #8858, thanks !
(tested with GUI gtk,qt4,sdl,dump)

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?27981>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 16 06:13:08 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aKOn6-00053G-Gu
	for mharc-gnash-commit@gnu.org; Sat, 16 Jan 2016 06:13:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOn4-00052l-79
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:13:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOn0-0000ll-W8
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:13:06 -0500
Received: from [2001:4830:134:6::a] (port=43564 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aKOn0-0000lh-Sl
	for gnash-commit@gnu.org; Sat, 16 Jan 2016 06:13:02 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aKOn0-0003hZ-50; Sat, 16 Jan 2016 11:13:02 +0000
Date: Sat, 16 Jan 2016 11:13:02 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46308
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160116-121301.sv27281.29745@savannah.gnu.org>
References: <20151028-184753.sv82809.50454@savannah.gnu.org>
	<20151028-191604.sv82809.63152@savannah.gnu.org>
	<20151213-192853.sv82809.85975@savannah.gnu.org>
	<20160114-215421.sv82809.63359@savannah.gnu.org>
	<20160114-233700.sv82809.91489@savannah.gnu.org>
	<20160115-170338.sv82809.54787@savannah.gnu.org>
In-Reply-To: <20160115-170338.sv82809.54787@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46308] `gtk-gnash --once` freezes when used on
	single-frame SWF
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jan 2016 11:13:07 -0000

Update of bug #46308 (project gnash):

                  Status:                    None => Ready For Test         
             Assigned to:                    None => strk                   

    _______________________________________________________

Follow-up Comment #6:

Fixed by patch #8858. I tested with gtk,qt4 and sdl guis.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46308>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 18 04:11:39 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aL5qc-0002S2-Uh
	for mharc-gnash-commit@gnu.org; Mon, 18 Jan 2016 04:11:38 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aL5qa-0002PE-D1
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 04:11:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aL5qW-0001NA-CV
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 04:11:36 -0500
Received: from [2001:4830:134:6::a] (port=54391 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aL5qW-0001N6-8S
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 04:11:32 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aL5qT-0003x2-T2; Mon, 18 Jan 2016 09:11:29 +0000
Date: Mon, 18 Jan 2016 09:11:29 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46308
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.166.127 (Savane authenticated user nachanon)
Message-Id: <20160118-161129.sv82809.75883@savannah.gnu.org>
References: <20151028-184753.sv82809.50454@savannah.gnu.org>
	<20151028-191604.sv82809.63152@savannah.gnu.org>
	<20151213-192853.sv82809.85975@savannah.gnu.org>
	<20160114-215421.sv82809.63359@savannah.gnu.org>
	<20160114-233700.sv82809.91489@savannah.gnu.org>
	<20160115-170338.sv82809.54787@savannah.gnu.org>
	<20160116-121301.sv27281.29745@savannah.gnu.org>
In-Reply-To: <20160116-121301.sv27281.29745@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46308] `gtk-gnash --once` freezes when used on
	single-frame SWF
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2016 09:11:37 -0000

Follow-up Comment #7, bug #46308 (project gnash):

Current git version of Gnash is now playing and terminating properly with
single-frame test SWF in oneshot mode. (Checked with GTK, Qt4, SDL, and Dump
UI)

So, this bug could now be marked as fixed.

GTK GUI:

$ gtk-gnash -v --once singleframe.swf
29940:1] 104 SECURITY: Checking security of URL
'file:///mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/singleframe.swf'
29940:1] 104 SECURITY: Load of file
/mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/singleframe.swf
granted (under local sandbox
/mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/)
29940:1] 120 SECURITY: Extensions disabled
$ echo $?
0
$ 


Qt4 GUI:

$ qt4-gnash -v --once singleframe.swf
29944:1] 678 SECURITY: Checking security of URL
'file:///mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/singleframe.swf'
29944:1] 678 SECURITY: Load of file
/mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/singleframe.swf
granted (under local sandbox
/mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/)
29944:1] 880 ERROR: Can't update stage matrix till VM is initialized
29944:1] 882 SECURITY: Extensions disabled
$ echo $?
0
$ 


SDL GUI:

$ sdl-gnash -v --once singleframe.swf
29952:1] 65 SECURITY: Checking security of URL
'file:///mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/singleframe.swf'
29952:1] 65 SECURITY: Load of file
/mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/singleframe.swf
granted (under local sandbox
/mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/)
29952:1] 77 SECURITY: Extensions disabled
$ echo $?
0
$ 


Dump GUI:

$ dump-gnash -v --once singleframe.swf
No video dump requested.
29961:1] 2 SECURITY: Checking security of URL
'file:///mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/singleframe.swf'
29961:1] 2 SECURITY: Load of file
/mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/singleframe.swf
granted (under local sandbox
/mnt/flash/temp_file/gnash-debug.tmp/singleframeonce/singleframeonce/)
WIDTH=320
HEIGHT=240
29961:1] 3 SECURITY: Extensions disabled
INTERVAL=10
TIME=10
FPS_ACTUAL=100
FRAMECOUNT=0
$ echo $?
0
$ 


Note: Gnash's framebuffer UI is not tested as there is an unrelated issue
which caused it to leave the console screen unusable after it exited.

Gnash: 0.8.11 (git 62cfdfe 16-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46308>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 18 04:26:04 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aL64a-0001ip-F5
	for mharc-gnash-commit@gnu.org; Mon, 18 Jan 2016 04:26:04 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44486)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <richard.wilbur@gmail.com>) id 1aL64X-0001eC-JT
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 04:26:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <richard.wilbur@gmail.com>) id 1aL64W-00057y-6f
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 04:26:01 -0500
Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:34658)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <richard.wilbur@gmail.com>) id 1aL64V-00057u-VP
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 04:26:00 -0500
Received: by mail-lb0-x230.google.com with SMTP id cl12so125920229lbc.1
	for <gnash-commit@gnu.org>; Mon, 18 Jan 2016 01:25:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=F2FuJDd+vcKJfNZj+zasf4179IFl9jENya0S48TxHHA=;
	b=pNDi5H+jiIOUJ1QjbvNY0RMY9NJGvICLgZQu6BYhtMwBGlF8cUc0fRY3AlnsLaJyuC
	rMgYS/FQQOWzTzSmiSya4pEZBG2gR0Guj21XYv0G1wPU9HdOmnOzfxONk2LeB3eZKm8z
	RwGsh5GnlYH8Z5sWXfZXP7KASKE2mprzucwRpBbR9AcAfsEIfga41rE7nv7PYwqKeJ9f
	OtgOuio+gvjKVohM+GINicoOOL7KqtetoRJDgzvoY0IrTLiMD09N6hJZBQuEqZqocbCc
	OWqcCONTnwuzmLDG7bV554AtErMXb0028p7YsuhFuu0al10THPnyD+B4v3CPBz0hWmkI
	Nv1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type;
	bh=F2FuJDd+vcKJfNZj+zasf4179IFl9jENya0S48TxHHA=;
	b=B8BFKNrBqjdqSR5tofZGx2c2hwHt/JASWFgNWRUZFLboyKXMX4vV6MYNlpRroD1tdM
	Hqkq9UBFm3MDzxIEF+IGy/WBOUcpBF/IQM4ykNYSLfXti9izuuTK4rJN/+ZdDHKTueMn
	NCJ4hnJ+gaF2VOheyszdSYNd7Eg57+g6B+Eu+XovyD8d65L/olIdF5Bg3iInFwpkA1h4
	aCiRgU+mdA2jcnYqq4O9DzvwD3KlWqMcQWHnggSC6j5C5F/WP3wLw2Gvb75bg7lfWD+a
	VmquoLYnCWe+K425huuzJeYLDiVUxsrHmsYAaU+ZsTndGwSv0Lm2UFmejAMOmIKgKrG4
	KBOw==
X-Gm-Message-State: ALoCoQln1xR7kU2FU/qg8S/6mEHiVfqKGHYJwHrUetj6eY48k0zaU8LXq1mlG8YGhDyByzXNcw/VtFSVVLT39FBT1QsFlpNCCw==
MIME-Version: 1.0
X-Received: by 10.112.180.138 with SMTP id do10mr8024886lbc.127.1453109158671; 
	Mon, 18 Jan 2016 01:25:58 -0800 (PST)
Received: by 10.114.109.98 with HTTP; Mon, 18 Jan 2016 01:25:58 -0800 (PST)
In-Reply-To: <E1aIyWr-00060e-TN@vcs.savannah.gnu.org>
References: <E1aIyWr-00060e-TN@vcs.savannah.gnu.org>
Date: Mon, 18 Jan 2016 02:25:58 -0700
Message-ID: <CAC4=CAGPXynWSsv_Z+EC7AW=oQqzcRN_LhW2=OiS6f8Vkob-ig@mail.gmail.com>
From: Richard Wilbur <richard.wilbur@gmail.com>
To: Sandro Santilli <strk@keybit.net>
Content-Type: text/plain; charset=UTF-8
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:4010:c04::230
Cc: Commit mailing list <gnash-commit@gnu.org>
Subject: Re: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2247-g6671ff0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2016 09:26:02 -0000

On Tue, Jan 12, 2016 at 5:58 AM, Sandro Santilli <strk@keybit.net> wrote:
[...]
> diff --git a/libcore/movie_root.cpp b/libcore/movie_root.cpp
> index 3c643e9..c9ce412 100644
> --- a/libcore/movie_root.cpp
> +++ b/libcore/movie_root.cpp
> @@ -1602,7 +1602,7 @@ movie_root::processInvoke(ExternalInterface::invoke_t *invoke)
>              // If the variable exists, GetVariable returns a string
>              // representation of its value. Variable with undefined
>              // or null value counts as exist too.
> -            ss << ExternalInterface::toXML(val.to_string());
> +            ss << ExternalInterface::toXML(val.to_string(_vm.getSWFVersion()));
>              ss << std::endl;
>          } else {
>              // If the variable does not exist, GetVariable sends null value

So I see the change of the invocation of val.to_string() to include
the SWF version but where is the change in the to_string() method to
accept the SWF version and return empty string for 'undefined' val
when version < 7, otherwise for 'undefined' val return 'undefined'?


From MAILER-DAEMON Mon Jan 18 06:47:27 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aL8HP-0004Jp-BU
	for mharc-gnash-commit@gnu.org; Mon, 18 Jan 2016 06:47:27 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47026)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aL8HJ-0004Ij-9h
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 06:47:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aL8HG-0005fI-4x
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 06:47:21 -0500
Received: from [2001:4830:134:6::a] (port=40455 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aL8HG-0005f3-1B
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 06:47:18 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aL8HE-0007WB-Kk; Mon, 18 Jan 2016 11:47:16 +0000
Date: Mon, 18 Jan 2016 11:47:16 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46308
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160118-124716.sv27281.83638@savannah.gnu.org>
References: <20151028-184753.sv82809.50454@savannah.gnu.org>
	<20151028-191604.sv82809.63152@savannah.gnu.org>
	<20151213-192853.sv82809.85975@savannah.gnu.org>
	<20160114-215421.sv82809.63359@savannah.gnu.org>
	<20160114-233700.sv82809.91489@savannah.gnu.org>
	<20160115-170338.sv82809.54787@savannah.gnu.org>
	<20160116-121301.sv27281.29745@savannah.gnu.org>
	<20160118-161129.sv82809.75883@savannah.gnu.org>
In-Reply-To: <20160118-161129.sv82809.75883@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46308] `gtk-gnash --once` freezes when used on
	single-frame SWF
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2016 11:47:25 -0000

Update of bug #46308 (project gnash):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                 


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46308>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 18 06:48:16 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aL8IC-0004Xb-8J
	for mharc-gnash-commit@gnu.org; Mon, 18 Jan 2016 06:48:16 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47203)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sandro.santilli@gmail.com>) id 1aL8IA-0004Uw-9Y
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 06:48:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sandro.santilli@gmail.com>) id 1aL8I7-0005ug-3q
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 06:48:14 -0500
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:36932)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sandro.santilli@gmail.com>) id 1aL8I6-0005uQ-SN
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 06:48:11 -0500
Received: by mail-wm0-x22c.google.com with SMTP id n5so59731183wmn.0
	for <gnash-commit@gnu.org>; Mon, 18 Jan 2016 03:48:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=sender:date:from:to:cc:subject:message-id:mail-followup-to
	:references:mime-version:content-type:content-disposition
	:in-reply-to:user-agent;
	bh=k5+DwaOebPSB+sAFJZ0sMnLu9+Q5GZi+AMQ5R68Ggrc=;
	b=C9QaPiRuo/A+468PC2QxYENZ1CjAwrLJdWn8ylwq5HU84XGyRpVCFOH2z0cJz/8ZoS
	HqMFFfVHXlLtrduO4tSIXQ3lU/8ovbGLj6ye4Qycd2f5uglSmgbNUz1A8vKMS/J2iDWr
	e9vJbptGyh7sPsrjFB7Mx/yxjeLh7ufaMesdS9xxKD+lPOjp7SUg5vpSX73DXmPPAD2i
	pK2rE6v2QA0Q4DPj8CxLiaUZLNPZo7S1mGDJ8jSEHDTzlyo2WV0S+dExdzjNa7apsT3r
	8CZG409Q9TKkb/veJyZ8wSDuxcVVnBF589M89zAWG51BFI39MiVMGYUl1uBiiF7CtW5F
	PPpw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:sender:date:from:to:cc:subject:message-id
	:mail-followup-to:references:mime-version:content-type
	:content-disposition:in-reply-to:user-agent;
	bh=k5+DwaOebPSB+sAFJZ0sMnLu9+Q5GZi+AMQ5R68Ggrc=;
	b=iJfsFgvzFC9ZsfWYtWtOa+4qQpP3Q5Xclqs8OTUf9Ok/vur/Hr6CZXmx+cb2WuexBE
	d3EOkh2KhIlKzO57sLtLX7ySFTdP5kH3b9DMXmk5hnYR7r7NrByFoM0pB3wQkb8VDrQK
	RpnO8tr3DCCP4oyC00lAJD24rg9TI4ub1rt+MMUk2HOwBR0lzvq0FwuS7Gahe/tcE86u
	RRESJJiWUZZMpUa86/a/lKghSycUXiM0Hs4Hu+9wSoHukrA0dng4uIyIyVxpEiwuA8OY
	UOqMm9B+COBJwWR257FMSVwrKBuHLZXysSgXcBCOcgVZ3BrhWRGMXjgYV9Sxp57PTOO2
	50YA==
X-Gm-Message-State: ALoCoQny8JHP3uJwjizNbybZHSZtM1GNXSmMzy6WTUr3tTjaY3pEfqv1O7/Ic0nGe6p7XXatUEDtTSJS1jhMM8TJNjVJkw5L0w==
X-Received: by 10.194.19.100 with SMTP id d4mr23948328wje.18.1453117689967;
	Mon, 18 Jan 2016 03:48:09 -0800 (PST)
Received: from localhost (ip-46-232-148-34.static.adsl.cheapnet.it.
	[46.232.148.34]) by smtp.gmail.com with ESMTPSA id
	z127sm15404923wme.2.2016.01.18.03.48.08
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 18 Jan 2016 03:48:08 -0800 (PST)
Sender: Sandro Santilli <sandro.santilli@gmail.com>
Date: Mon, 18 Jan 2016 12:48:06 +0100
From: Sandro Santilli <strk@keybit.net>
To: Richard Wilbur <richard.wilbur@gmail.com>
Message-ID: <20160118114806.GA9971@localhost>
Mail-Followup-To: Richard Wilbur <richard.wilbur@gmail.com>,
	Commit mailing list <gnash-commit@gnu.org>
References: <E1aIyWr-00060e-TN@vcs.savannah.gnu.org>
	<CAC4=CAGPXynWSsv_Z+EC7AW=oQqzcRN_LhW2=OiS6f8Vkob-ig@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAC4=CAGPXynWSsv_Z+EC7AW=oQqzcRN_LhW2=OiS6f8Vkob-ig@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:400c:c09::22c
Cc: Commit mailing list <gnash-commit@gnu.org>
Subject: Re: [Gnash-commit] [SCM] Gnash branch, master,
 updated. release_0_8_9_final-2247-g6671ff0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2016 11:48:15 -0000

On Mon, Jan 18, 2016 at 02:25:58AM -0700, Richard Wilbur wrote:
> On Tue, Jan 12, 2016 at 5:58 AM, Sandro Santilli <strk@keybit.net> wrote:
> [...]
> > diff --git a/libcore/movie_root.cpp b/libcore/movie_root.cpp
> > index 3c643e9..c9ce412 100644
> > --- a/libcore/movie_root.cpp
> > +++ b/libcore/movie_root.cpp
> > @@ -1602,7 +1602,7 @@ movie_root::processInvoke(ExternalInterface::invoke_t *invoke)
> >              // If the variable exists, GetVariable returns a string
> >              // representation of its value. Variable with undefined
> >              // or null value counts as exist too.
> > -            ss << ExternalInterface::toXML(val.to_string());
> > +            ss << ExternalInterface::toXML(val.to_string(_vm.getSWFVersion()));
> >              ss << std::endl;
> >          } else {
> >              // If the variable does not exist, GetVariable sends null value
> 
> So I see the change of the invocation of val.to_string() to include
> the SWF version but where is the change in the to_string() method to
> accept the SWF version and return empty string for 'undefined' val
> when version < 7, otherwise for 'undefined' val return 'undefined'?

It was already supported, since a long time.

--strk;


From MAILER-DAEMON Mon Jan 18 11:07:21 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aLCKv-0001Cb-Hc
	for mharc-gnash-commit@gnu.org; Mon, 18 Jan 2016 11:07:21 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34682)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <richard.wilbur@gmail.com>) id 1aLCKp-00019e-Lm
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 11:07:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <richard.wilbur@gmail.com>) id 1aLCKm-0006Yy-8w
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 11:07:15 -0500
Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:33622)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <richard.wilbur@gmail.com>) id 1aLCKm-0006Yt-18
	for gnash-commit@gnu.org; Mon, 18 Jan 2016 11:07:12 -0500
Received: by mail-lf0-x236.google.com with SMTP id m198so174858334lfm.0
	for <gnash-commit@gnu.org>; Mon, 18 Jan 2016 08:07:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type; bh=WcqDt/kM44vh8iXP+a4jimxKVT2Ld15SW/c2YYRgSKk=;
	b=ZWxMovM67aYbPfAemddAEsm+viBeQaRob7HsTyjrEx6YmrzxM9EI1sOVM1XxF9JPp0
	jOHHxR0hOw7oTEq12ecGxYmnuEJjRHrkMSV2nuheDSXFCXuGKh5B4uF6mNifrUVZaXmj
	6E5NKzFVmm6ZLBS1GPp2T4GtDq77sBvANDAztga859p8OxN4W8WRW/Yol6IEyM5GZjEB
	VWpm4oFtoBqno2uk/ns/nKEif3d0AKZAqnLzsGyRISiQd7GABJyoRmmbi7oE2cE6I3k4
	twY3u/CGy2RIaw+26kZKc+UFYAn8Chd79LbsRp4/K8LcXVYV1bk8d2k4BhcSg+eXhO3U
	WY3Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:content-type;
	bh=WcqDt/kM44vh8iXP+a4jimxKVT2Ld15SW/c2YYRgSKk=;
	b=NzviazuDV92qHSbriUkVvZz9wKYu8sT+DtNXIAXHxYZPMXE9SBkjO3fQLAoTLxYryu
	N7Q+AYR3hM0BIhBp6yfIi6tgeWUFkY7YJ6r1GT0TwTESW6+vvj7fY6EQo0Uvt996rp2Q
	cKS/Vvs/h+knxv6YU5ym6g13Ys+48PntJCAxFAFCmV1XUqMNkmca3Sgqvkl7ooDcjdQk
	loH6Vx4EPJ357duj5qfwjbEf2Ic00MJo4/ftHzytjAOUVAjcBiQw0aD/5EhWjahiJepa
	9Gs65cPTumo2aPKEFX4epUUY5wX159qSUi97NJCQ6d49MQrui/OKikDiUrJRfwkfqwLd
	+F0Q==
X-Gm-Message-State: ALoCoQnxa8G46aIbAze9rLJQCCvYRYQ37TDRi0cyl2rFgS9E5yh9vB/oYBVS1Dy10EB3oNg+HLAA3OC+DpKE1hInNGFjEbmUvA==
MIME-Version: 1.0
X-Received: by 10.25.148.141 with SMTP id w135mr7086431lfd.137.1453133231379; 
	Mon, 18 Jan 2016 08:07:11 -0800 (PST)
Received: by 10.114.109.98 with HTTP; Mon, 18 Jan 2016 08:07:11 -0800 (PST)
In-Reply-To: <20160118114806.GA9971@localhost>
References: <E1aIyWr-00060e-TN@vcs.savannah.gnu.org>
	<CAC4=CAGPXynWSsv_Z+EC7AW=oQqzcRN_LhW2=OiS6f8Vkob-ig@mail.gmail.com>
	<20160118114806.GA9971@localhost>
Date: Mon, 18 Jan 2016 09:07:11 -0700
Message-ID: <CAC4=CAGqmJ6quG6i89Uwe3hp0xKcRMVqAvnugSkVr+GFeekg9g@mail.gmail.com>
From: Richard Wilbur <richard.wilbur@gmail.com>
To: Richard Wilbur <richard.wilbur@gmail.com>,
	Commit mailing list <gnash-commit@gnu.org>
Content-Type: text/plain; charset=UTF-8
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2a00:1450:4010:c07::236
Subject: Re: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2247-g6671ff0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jan 2016 16:07:19 -0000

That makes for a wonderfully simple, elegant fix!


From MAILER-DAEMON Wed Jan 20 01:36:16 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aLmNM-0003JH-42
	for mharc-gnash-commit@gnu.org; Wed, 20 Jan 2016 01:36:16 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmNJ-0003IZ-Dq
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:36:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmNG-0000fp-7q
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:36:13 -0500
Received: from [2001:4830:134:6::a] (port=60553 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmNG-0000fl-4L
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:36:10 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aLmNF-0004ee-Vr; Wed, 20 Jan 2016 06:36:10 +0000
Date: Wed, 20 Jan 2016 06:36:09 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46935
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.114 (Savane authenticated user nachanon)
Message-Id: <20160120-133609.sv82809.49924@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46935] Scoreboard in I Love Traffic did not
	display on Gnash
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jan 2016 06:36:14 -0000

URL:
  <http://savannah.gnu.org/bugs/?46935>

                 Summary: Scoreboard in I Love Traffic did not display on
Gnash
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Wed 20 Jan 2016 01:36:09 PM ICT
                Category: core
                Severity: 3 - Normal
                 Release: 0.8.9
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I have used current git version of Gnash to play I Love Traffic game (Flash 10
with AVM1):

http://www.silvergames.com/i-love-traffic
(http://f3.silvergames.com/i-love-traffic.swf)

Depite the game was playing fine with a bit of volume control problem
(bug #35984), I found that the scoreboard on bottom-right of the screen
didn't show up correctly; it should show number of cars left on the stage,
with countdown timer, but it shown up blank on current Gnash.

However, with old Gnash 0.8.4 release, number on the scoreboard was visible.


Gnash: 0.8.4-3~lenny1 (debian)
System: Debian GNU/Linux 5.0 Lenny i386

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386

P.S. This problem somehow didn't surface in a newer re-issue of this game.
(If you are running the newer version, you'll see mobile application link on
its main menu; original version didn't have it)




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 20 01:46:00 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aLmWm-0004jO-8r
	for mharc-gnash-commit@gnu.org; Wed, 20 Jan 2016 01:46:00 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41235)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmWk-0004jE-4b
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:45:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmWg-0003O6-Uy
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:45:58 -0500
Received: from [2001:4830:134:6::a] (port=33121 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmWg-0003O1-Rh
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:45:54 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aLmWg-0004sQ-I1; Wed, 20 Jan 2016 06:45:54 +0000
Date: Wed, 20 Jan 2016 06:45:54 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46935
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.114 (Savane authenticated user nachanon)
Message-Id: <20160120-134554.sv82809.48094@savannah.gnu.org>
References: <20160120-133609.sv82809.49924@savannah.gnu.org>
In-Reply-To: <20160120-133609.sv82809.49924@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46935] Scoreboard in I Love Traffic did not
	display on Gnash
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jan 2016 06:45:59 -0000

Follow-up Comment #1, bug #46935 (project gnash):

This is an image result from Adobe Flash Player:
http://i.imgur.com/bFWbdov.png

This is an image result from Gnash 0.8.4:
http://i.imgur.com/YaN9hPf.png

You'd see that in both result, number of cars and countdown time are
displayed
on scoreboard at bottom-right of the screen.


This is an image result from Gnash 0.8.9:
http://i.imgur.com/tmZ0AwI.png

This is an image result from Gnash 0.8.10:
http://i.imgur.com/QTqR5h7.png

This is an image result from current Gnash 0.8.11dev git:
http://i.imgur.com/pXb91kG.png

You'd see that from Gnash 0.8.9 onward, scoreboard at bottom-right
of the screen was blank.


All screenshots are attached as `ilovetraffic_roundup1.zip`.

Gnash: 0.8.4-3~lenny1 (debian), 0.8.9-1~lenny (getgnash.org APT repository),
0.8.10-1~lenny (getgnash.org APT repository)
System: Debian GNU/Linux 5.0 Lenny i386

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36096)
    _______________________________________________________

Additional Item Attachment:

File name: ilovetraffic_roundup1.zip      Size:1744 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 20 01:50:17 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aLmav-0005DP-Rz
	for mharc-gnash-commit@gnu.org; Wed, 20 Jan 2016 01:50:17 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41957)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmat-0005Bu-HW
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:50:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmaq-000418-C9
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:50:15 -0500
Received: from [2001:4830:134:6::a] (port=33416 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmaq-000414-8O
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:50:12 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aLmap-0004yh-V3; Wed, 20 Jan 2016 06:50:12 +0000
Date: Wed, 20 Jan 2016 06:50:11 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46935
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.114 (Savane authenticated user nachanon)
Message-Id: <20160120-135011.sv82809.55504@savannah.gnu.org>
References: <20160120-133609.sv82809.49924@savannah.gnu.org>
	<20160120-134554.sv82809.48094@savannah.gnu.org>
In-Reply-To: <20160120-134554.sv82809.48094@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46935] Scoreboard in I Love Traffic did not
	display on Gnash
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jan 2016 06:50:16 -0000

Follow-up Comment #2, bug #46935 (project gnash):

Oldest tag in Gnash's git repository only dated back to somewhere _after_
0.8.4 release (tag release_0_8_5_start
<http://git.savannah.gnu.org/cgit/gnash.git/tag/?id=release_0_8_5_start>); the
0.8.4 release itself was
not listed. I think Gnash was on Bazaar repository at that time.

Nearest commit I could find is 239c395
<http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=239c39595e3ac784fb1b0789d74272a400975a9d>
which is the fourth-last change
of the 0.8.4 release according to changelog
<http://git.savannah.gnu.org/cgit/gnash.git/tree/doc/changelogs/ChangeLog-0.8.4?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n16>.
I couldn't find the next three
<http://git.savannah.gnu.org/cgit/gnash.git/tree/doc/changelogs/ChangeLog-0.8.4?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n1>
commit though.

Maybe it's a good idea to tag corresponding commit of every Gnash releases,
for the ease of future regression testing.

Note (for the record): 0.8.4 was released on 13-Oct-2008, according to
timestamp on Savannah's download area <https://ftp.gnu.org/gnu/gnash/0.8.4/>
and the last item on its changelog
<http://git.savannah.gnu.org/cgit/gnash.git/tree/doc/changelogs/ChangeLog-0.8.4?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n1>.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Jan 20 01:52:29 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aLmd3-0006zX-Pn
	for mharc-gnash-commit@gnu.org; Wed, 20 Jan 2016 01:52:29 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42601)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmd1-0006sl-20
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:52:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmcx-0004kK-SV
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:52:26 -0500
Received: from [2001:4830:134:6::a] (port=33567 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aLmcx-0004kG-Pi
	for gnash-commit@gnu.org; Wed, 20 Jan 2016 01:52:23 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aLmcx-0004z1-Ef; Wed, 20 Jan 2016 06:52:23 +0000
Date: Wed, 20 Jan 2016 06:52:23 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46935
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.114 (Savane authenticated user nachanon)
Message-Id: <20160120-135223.sv82809.32449@savannah.gnu.org>
References: <20160120-133609.sv82809.49924@savannah.gnu.org>
	<20160120-134554.sv82809.48094@savannah.gnu.org>
	<20160120-135011.sv82809.55504@savannah.gnu.org>
In-Reply-To: <20160120-135011.sv82809.55504@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46935] Scoreboard in I Love Traffic did not
	display on Gnash
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jan 2016 06:52:28 -0000

Follow-up Comment #3, bug #46935 (project gnash):

Git bisect test (239c395 good -> "release_0_8_9_final" bad) revealed that:

2e7f2ad96345d9596856436ad5efec5ee567ec37 is first bad commit
commit 2e7f2ad96345d9596856436ad5efec5ee567ec37
Author: Benjamin Wolsey <bwy@benjaminwolsey.de>
Date:   Sat Nov 8 18:30:07 2008 +0100

	Move DefineFont and DefineFont2 parsing into
libcore/swf/DefineFontTag.{h,cpp}.
	A font can now be constructed only as an embedded font (with a
DefineFontTag)
	or a device font (with name, bold, italic).

:040000 040000 3bfbf12d758596983dec27daee7d20fe0cbbc632
c50b8bee99b53a095f43d3db4df95668569b339f M	libcore


System: Debian GNU/Linux 5.0 Lenny i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 21 03:41:53 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMAoT-0000AK-SN
	for mharc-gnash-commit@gnu.org; Thu, 21 Jan 2016 03:41:53 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42551)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMAoQ-0000AA-V8
	for gnash-commit@gnu.org; Thu, 21 Jan 2016 03:41:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMAoN-0006g3-MR
	for gnash-commit@gnu.org; Thu, 21 Jan 2016 03:41:50 -0500
Received: from [2001:4830:134:6::a] (port=56752 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMAoN-0006fz-Ib
	for gnash-commit@gnu.org; Thu, 21 Jan 2016 03:41:47 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMAoN-00053L-5D; Thu, 21 Jan 2016 08:41:47 +0000
Date: Thu, 21 Jan 2016 08:41:47 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46944
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.161.119 (Savane authenticated user nachanon)
Message-Id: <20160121-154145.sv82809.32342@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46944] Gnash does not recognize "fscommand:"
	URI scheme in `MovieClip.getURL()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jan 2016 08:41:52 -0000

URL:
  <http://savannah.gnu.org/bugs/?46944>

                 Summary: Gnash does not recognize "fscommand:" URI scheme in
`MovieClip.getURL()`
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Thu 21 Jan 2016 03:41:45 PM ICT
                Category: core
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

While I was testing repainting condition in bug #27981 using SWFC, I ran
into a problem with Gnash's `MovieClip.getURL()` implementation regarding
FSCommand:

It turned out that while "fscommand:" URI scheme works fine on Gnash via the
built-in `getURL()` function powered by `GETURL2` AVM1 instruction,
it is _not recognized in Gnash's `MovieClip.getURL()` method_.

On Adobe Flash Player, "fscommand:" URI issued using `MovieClip.getURL()`
*works the same as built-in `getURL()`*.

I have created test Flash files (Flash 7) using SWFTools's SWFC, libming's
makeswf, and MTASC which tries to issue "fullscreen" FSCommand with "true"
parameter using `MovieClip.getURL("fscommand:fullscreen","true")`, and
run them with `set IgnoreFSCommand false` in `~/.gnashrc` configuration.

This is an image result of `mcgeturl-fscommand.swf` under Adobe Flash Player:
http://i.imgur.com/Ss60C58.png

You'd see that Flash Player recognized the issued FSCommand, and switched to
fullscreen mode.

This is an image result of `mcgeturl-fscommand.swf` under Gnash:
http://i.imgur.com/WNWHHU4.png

Gnash's console output shown:

107 SECURITY: Checking security of URL
'file:///mnt/flash/temp_file/gnash-debug.tmp/mcgeturl-fscommand/mcgeturl-fscommand/mcgeturl-fscommand.swf'
107 SECURITY: Load of file
/mnt/flash/temp_file/gnash-debug.tmp/mcgeturl-fscommand/mcgeturl-fscommand/mcgeturl-fscommand.swf
granted (under local sandbox
/mnt/flash/temp_file/gnash-debug.tmp/mcgeturl-fscommand/mcgeturl-fscommand/)
121 SECURITY: Extensions disabled
121 TRACE: This is first frame start.
121 NETWORK: getURL: HOSTFD is -1
gvfs-open: fscommand:///fullscreen: error opening location: The specified
location is not supported
137 TRACE: This is first frame end.


You'd see that Gnash did not recogize the issued FSCommand, and remains in
windowed display. From console output, you'd see that Gnash tried to open
the FSCommand URI via `xdg-open` as if it was a normal URL.

Test SWFs, source code, build script, screenshots, and logs (verbosity 2
+ action error log) are attached as `mcgeturl-fscommand.zip`.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386

Note: This is particularly important for SWF generated using SWFC, as SWFC's
ActionScript compiler seems to recognize neither the built-in `getURL()`
instruction nor the `fscommand()` macro; only way for SWFC-based script
to issue FSCommand is doing it via `MovieClip.getURL()`.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 21 Jan 2016 03:41:45 PM ICT  Name: mcgeturl-fscommand.zip  Size:
25kB   By: nachanon
Test Flash files, source code, build script, screenshots, and logs
<http://savannah.gnu.org/bugs/download.php?file_id=36108>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46944>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 22 00:39:15 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMURH-0005Ih-Ie
	for mharc-gnash-commit@gnu.org; Fri, 22 Jan 2016 00:39:15 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMURF-0005IU-Mf
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 00:39:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMURB-00049Q-1r
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 00:39:13 -0500
Received: from [2001:4830:134:6::a] (port=36917 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMURA-00049M-UZ
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 00:39:08 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMUQU-000761-Iu; Fri, 22 Jan 2016 05:38:26 +0000
Date: Fri, 22 Jan 2016 05:38:26 +0000
To: -Deleted Account- <idontexist@nowhere.net>, Hapi <c_hapi@hotmail.com>,
	Hapi2 <phcamille@hotmail.com>, Julie <julie.wonder14@gmail.com>,
	Sandro Santilli <strk@keybit.net>,
	Maximiliano =?UTF-8?B?Q2FzdGHDscOzbg==?= Araneda <maximi89@gmail.com>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Bjorn Nostvold <bjorn.nostvold@gmail.com>,
	Bella <belladoxie@live.com>, maikl <belichenko_@ukr.net>,
	Bernie Innocenti <bernie@codewiz.org>,
	OPlucgk <ckw85348@piloq.com>, Marco <info@altamiraweb.es>,
	Nadav Kavalerchik <nadavkav@gmail.com>,
	Rodrigo Carvalho <rcsilva83@gmail.com>,
	Samuel =?UTF-8?B?TGlkw6lu?= Borell <samuel@kodafritt.se>,
	gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: anonymous <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:80 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 23435
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 5.49.204.222
Message-Id: <20160122-053826.sv0.34408@savannah.gnu.org>
References: <20080530-052120.sv67576.63840@savannah.gnu.org>
	<20080601-030947.sv48477.56832@savannah.gnu.org>
	<20081010-112113.sv60230.36937@savannah.gnu.org>
	<20091209-212849.sv76464.42086@savannah.gnu.org>
	<20100920-093940.sv80137.6254@savannah.gnu.org>
	<20100924-173759.sv0.44627@savannah.gnu.org>
	<20101210-075423.sv60230.89429@savannah.gnu.org>
	<20101211-015541.sv43424.9979@savannah.gnu.org>
	<20101214-010135.sv43424.59275@savannah.gnu.org>
	<20110527-164309.sv9396.48077@savannah.gnu.org>
	<20110527-165022.sv9396.70570@savannah.gnu.org>
	<20110802-093645.sv27281.99084@savannah.gnu.org>
	<20110930-141601.sv85203.45504@savannah.gnu.org>
	<20111015-205448.sv0.19968@savannah.gnu.org>
	<20111015-205733.sv0.11828@savannah.gnu.org>
	<20111015-205823.sv0.15327@savannah.gnu.org>
	<20111015-205903.sv0.98852@savannah.gnu.org>
	<20111015-210021.sv0.88277@savannah.gnu.org>
	<20111015-210045.sv0.6915@savannah.gnu.org>
	<20111015-211855.sv0.44857@savannah.gnu.org>
	<20111015-211932.sv0.96743@savannah.gnu.org>
	<20111015-211945.sv0.3058@savannah.gnu.org>
	<20111015-212020.sv0.11466@savannah.gnu.org>
	<20111015-212032.sv0.37673@savannah.gnu.org>
	<20111015-212041.sv0.36781@savannah.gnu.org>
	<20111015-212054.sv0.56603@savannah.gnu.org>
	<20111015-212116.sv0.82630@savannah.gnu.org>
	<20111015-212128.sv0.5535@savannah.gnu.org>
	<20111015-212134.sv0.55135@savannah.gnu.org>
	<20111015-212139.sv0.21120@savannah.gnu.org>
	<20111015-212144.sv0.95581@savannah.gnu.org>
	<20111015-212204.sv0.95483@savannah.gnu.org>
	<20111015-212208.sv0.55917@savannah.gnu.org>
	<20111015-212213.sv0.83052@savannah.gnu.org>
	<20111015-212233.sv0.17909@savannah.gnu.org>
	<20111215-032001.sv86502.52580@savannah.gnu.org>
	<20120128-122636.sv86913.30138@savannah.gnu.org>
	<20130519-135802.sv90703.54900@savannah.gnu.org>
	<20130731-204517.sv92054.99015@savannah.gnu.org>
	<20131126-231824.sv93117.29607@savannah.gnu.org>
	<20150714-055243.sv100337.82085@savannah.gnu.org>
	<20150727-201122.sv100516.51572@savannah.gnu.org>
	<20150811-060338.sv100700.16246@savannah.gnu.org>
	<20150901-162252.sv100492.64065@savannah.gnu.org>
	<20150927-172817.sv101208.14240@savannah.gnu.org>
	<20150927-172952.sv101208.35076@savannah.gnu.org>
	<20150927-174325.sv101208.54147@savannah.gnu.org>
	<20150927-174804.sv101208.68924@savannah.gnu.org>
	<20150927-180604.sv101208.40469@savannah.gnu.org>
	<20150928-052013.sv101208.14222@savannah.gnu.org>
	<20150930-062616.sv101232.5956@savannah.gnu.org>
	<20151130-133030.sv97829.39785@savannah.gnu.org>
	<20160110-161003.sv102292.38827@savannah.gnu.org>
In-Reply-To: <20160110-161003.sv102292.38827@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #23435] Flash content rendered above menus in
	Firefox
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 05:39:14 -0000

Follow-up Comment #51, bug #23435 (project gnash):

Same here [url=http://www.weboliste.fr/] [/url] 

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?23435>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 22 02:52:11 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMWVv-00013M-1U
	for mharc-gnash-commit@gnu.org; Fri, 22 Jan 2016 02:52:11 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMWVs-00013E-QV
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 02:52:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMWVn-00016F-Ot
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 02:52:08 -0500
Received: from [2001:4830:134:6::a] (port=46264 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMWVn-00016B-LV
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 02:52:03 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMWVn-0001bg-At; Fri, 22 Jan 2016 07:52:03 +0000
Date: Fri, 22 Jan 2016 07:52:03 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 158.108.131.212 (Savane authenticated user nachanon)
Message-Id: <20160122-145202.sv82809.37865@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 07:52:10 -0000

URL:
  <http://savannah.gnu.org/bugs/?46949>

                 Summary: fb-gnash left console in unusable state after
exiting
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Fri 22 Jan 2016 02:52:02 PM ICT
                Category: gui-fb
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a follow-up to bug #46308 comment 7
<https://savannah.gnu.org/bugs/?46308#comment7>.

While I was testing Gnash's FrameBuffer UI in bug #46308, I found that
when `fb-gnash` is run on FrameBuffer console, as it finished running,
the screen would not go back to command line display; instead, it just
continue showing the last SWF frame, and switching back to X11 or other
console
using Alt+Fn key doesn't work.

Currently, one must blindly type commands to switch to root user and run
`shutdown -r now`, `init 6`, pressing Ctrl+Alt+Del, or issue magic SysRq
on keyboard to reboot the machine in order to get the display back to usable
state.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
X11: xorg 1:7.7+3~deb7u1 with xserver-xorg-video-intel 2:2.19.0-6 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Note: `textmode` command from `svgalib-bin` package and `reset` command
from `ncurses-bin` package didn't seem to help in this case.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 22 02:55:27 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMWZ5-0001WA-JZ
	for mharc-gnash-commit@gnu.org; Fri, 22 Jan 2016 02:55:27 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMWZ4-0001W4-5g
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 02:55:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMWYz-0001cx-6C
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 02:55:26 -0500
Received: from [2001:4830:134:6::a] (port=46474 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMWYz-0001co-38
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 02:55:21 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMWYy-0001hp-9t; Fri, 22 Jan 2016 07:55:20 +0000
Date: Fri, 22 Jan 2016 07:55:20 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46308
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 158.108.131.212 (Savane authenticated user nachanon)
Message-Id: <20160122-145520.sv82809.71289@savannah.gnu.org>
References: <20151028-184753.sv82809.50454@savannah.gnu.org>
	<20151028-191604.sv82809.63152@savannah.gnu.org>
	<20151213-192853.sv82809.85975@savannah.gnu.org>
	<20160114-215421.sv82809.63359@savannah.gnu.org>
	<20160114-233700.sv82809.91489@savannah.gnu.org>
	<20160115-170338.sv82809.54787@savannah.gnu.org>
	<20160116-121301.sv27281.29745@savannah.gnu.org>
	<20160118-161129.sv82809.75883@savannah.gnu.org>
	<20160118-124716.sv27281.83638@savannah.gnu.org>
In-Reply-To: <20160118-124716.sv27281.83638@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46308] `gtk-gnash --once` freezes when used on
	single-frame SWF
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 07:55:27 -0000

Follow-up Comment #8, bug #46308 (project gnash):

For the framebuffer UI issue mentioned in comment 7
<https://savannah.gnu.org/bugs/?46308#comment7>, it is now separately reported
as bug #46949.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46308>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 22 05:00:37 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMYWD-0008Nw-JJ
	for mharc-gnash-commit@gnu.org; Fri, 22 Jan 2016 05:00:37 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYW6-0008N3-MG
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:00:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYW1-0007os-Iv
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:00:30 -0500
Received: from [2001:4830:134:6::a] (port=55358 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYW1-0007oh-FU
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:00:25 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMYW0-0004M3-Tc; Fri, 22 Jan 2016 10:00:24 +0000
Date: Fri, 22 Jan 2016 10:00:24 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 158.108.131.212 (Savane authenticated user nachanon)
Message-Id: <20160122-170024.sv82809.7063@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
In-Reply-To: <20160122-145202.sv82809.37865@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 10:00:36 -0000

Follow-up Comment #1, bug #46949 (project gnash):

I have made a dummy 12-frames 1.0-sec SWF file `12frames.swf`
(with SWFTools' SWFC) to demonstrate this; see the attached `12frames.zip`.

Exact steps to reproduce:
0 Switch the machine to text console (using Ctrl+Alt+F1 on keyboard).
0 Login, and go to the directory which `12frames.swf` resides.
0 Run `fb-gnash --once 12frames.swf`.
0 You'll see that after 1 sec, the screen still show five orange boxes instead
of switching back to command line.

Note: after the last step, the command line is still usable (even it is not
visible),
you can type commands to restart the machine (or just use Ctrl+Alt+Del).

Screenshot is attached as `12frames_gnash0.8.11dev-62cfdfe.png`,
debug log (verbosity 2 + action error log) is attached as
`12frames_gnash0.8.11dev-62cfdfe.log`.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36126)
    _______________________________________________________

Additional Item Attachment:

File name: 12frames.zip                   Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 22 05:03:57 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMYZR-00020F-9I
	for mharc-gnash-commit@gnu.org; Fri, 22 Jan 2016 05:03:57 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYZO-0001yI-DX
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:03:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYZL-0000BF-7V
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:03:54 -0500
Received: from [2001:4830:134:6::a] (port=55604 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYZL-0000BB-3u
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:03:51 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMYZK-0004My-SQ; Fri, 22 Jan 2016 10:03:50 +0000
Date: Fri, 22 Jan 2016 10:03:50 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 158.108.131.212 (Savane authenticated user nachanon)
Message-Id: <20160122-170350.sv82809.76338@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
	<20160122-170024.sv82809.7063@savannah.gnu.org>
In-Reply-To: <20160122-170024.sv82809.7063@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 10:03:55 -0000

Additional Item Attachment, bug #46949 (project gnash):

File name: 12frames_gnash0.8.11dev-62cfdfe.png Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 22 05:06:27 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMYbr-0004GS-Cf
	for mharc-gnash-commit@gnu.org; Fri, 22 Jan 2016 05:06:27 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52536)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYbl-00047n-88
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:06:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYbf-0001Gv-QX
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:06:21 -0500
Received: from [2001:4830:134:6::a] (port=55782 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYbf-0001Go-Mw
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:06:15 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMYbf-0004Sv-IF; Fri, 22 Jan 2016 10:06:15 +0000
Date: Fri, 22 Jan 2016 10:06:15 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 158.108.131.212 (Savane authenticated user nachanon)
Message-Id: <20160122-170615.sv82809.92509@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
	<20160122-170024.sv82809.7063@savannah.gnu.org>
	<20160122-170350.sv82809.76338@savannah.gnu.org>
In-Reply-To: <20160122-170350.sv82809.76338@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 10:06:26 -0000

Additional Item Attachment, bug #46949 (project gnash):

File name: 12frames_gnash0.8.11dev-62cfdfe.log Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 22 05:12:30 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMYhi-0008HS-Av
	for mharc-gnash-commit@gnu.org; Fri, 22 Jan 2016 05:12:30 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54045)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYhb-0008GI-HD
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:12:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYhW-0002f7-GM
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:12:23 -0500
Received: from [2001:4830:134:6::a] (port=56249 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMYhW-0002f3-Cl
	for gnash-commit@gnu.org; Fri, 22 Jan 2016 05:12:18 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMYhW-0004Zm-4i; Fri, 22 Jan 2016 10:12:18 +0000
Date: Fri, 22 Jan 2016 10:12:18 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 158.108.131.212 (Savane authenticated user nachanon)
Message-Id: <20160122-171217.sv82809.24993@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
	<20160122-170024.sv82809.7063@savannah.gnu.org>
	<20160122-170350.sv82809.76338@savannah.gnu.org>
	<20160122-170615.sv82809.92509@savannah.gnu.org>
In-Reply-To: <20160122-170615.sv82809.92509@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 10:12:29 -0000

Follow-up Comment #2, bug #46949 (project gnash):

I have written a small C program that issues `KDSETMODE` ioctl on
current console, restoring it back to text mode. In case anyone tried
to test this issue and stuck in graphics mode, he or she could run
this program to restore the console instead of rebooting.

See the attached `fbtotext.c`.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36129)
    _______________________________________________________

Additional Item Attachment:

File name: fbtotext.c                     Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 23 00:52:37 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMr7l-0001b4-0U
	for mharc-gnash-commit@gnu.org; Sat, 23 Jan 2016 00:52:37 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49818)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMr7i-0001ZM-5n
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 00:52:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMr7d-0006lg-6E
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 00:52:34 -0500
Received: from [2001:4830:134:6::a] (port=54070 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMr7d-0006lc-2X
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 00:52:29 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMr7c-0004Af-Ox; Sat, 23 Jan 2016 05:52:28 +0000
Date: Sat, 23 Jan 2016 05:52:28 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.155 (Savane authenticated user nachanon)
Message-Id: <20160123-125228.sv82809.12482@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
	<20160122-170024.sv82809.7063@savannah.gnu.org>
	<20160122-170350.sv82809.76338@savannah.gnu.org>
	<20160122-170615.sv82809.92509@savannah.gnu.org>
	<20160122-171217.sv82809.24993@savannah.gnu.org>
In-Reply-To: <20160122-171217.sv82809.24993@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2016 05:52:35 -0000

Follow-up Comment #3, bug #46949 (project gnash):

There seems to be another issue too: if `--once` option was not used, and
user quitted Framebuffer Gnash with SIGINT (pressed Ctrl+C on keyboard),
it will terminate _with Segmentation Fault_ in addition to unusable console.

Exact steps to reproduce:
0 Switch the machine to text console (using Ctrl+Alt+F1 on keyboard).
0 Login, and go to the directory which `12frames.swf` resides.
0 Run `ulimit -c unlimited` to enable memory dump on segmentation fault.
0 Run `fb-gnash 12frames.swf`, wait until five yellow boxes appear on the
screen.
0 Wait around 3 seconds.
0 Press Ctrl+C on keyboard; Gnash would terminate (but the screen would not
change).
0 Blindly type commands to restart the machine, or press Ctrl+Alt+Del, or run
`fbtotext` <https://savannah.gnu.org/bugs/?46949#comment2> to restore the
display.
0 You'll see that there is a file named `core` in the same directory as
`12frames.swf`. If you run `fbtotext` instead of restarting, you might also
see the "Segmentation fault (core dumped)" message on the console and/or
"segfault" log entry in `dmesg` output too.

Debug log (verbosity 2 + action error) of this case is attached as
`12frames_gnash0.8.11dev-62cfdfe_normal.log`, and full GDB backtrace is
attached as `12frames_gnash0.8.11dev-62cfdfe_normal.gdb.log`.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36138, file #36139)
    _______________________________________________________

Additional Item Attachment:

File name: 12frames_gnash0.8.11dev-62cfdfe_normal.log Size:3 KB
File name: 12frames_gnash0.8.11dev-62cfdfe_normal.gdb.log Size:14 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 23 06:12:48 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMw7c-0006Lq-Tk
	for mharc-gnash-commit@gnu.org; Sat, 23 Jan 2016 06:12:48 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58125)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMw7a-0006LP-E4
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 06:12:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMw7X-0008T5-5t
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 06:12:46 -0500
Received: from [2001:4830:134:6::a] (port=46926 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMw7X-0008T1-2b
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 06:12:43 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMw7W-0002cH-SF; Sat, 23 Jan 2016 11:12:42 +0000
Date: Sat, 23 Jan 2016 11:12:42 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.155 (Savane authenticated user nachanon)
Message-Id: <20160123-181242.sv82809.30132@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
	<20160122-170024.sv82809.7063@savannah.gnu.org>
	<20160122-170350.sv82809.76338@savannah.gnu.org>
	<20160122-170615.sv82809.92509@savannah.gnu.org>
	<20160122-171217.sv82809.24993@savannah.gnu.org>
	<20160123-125228.sv82809.12482@savannah.gnu.org>
In-Reply-To: <20160123-125228.sv82809.12482@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2016 11:12:47 -0000

Follow-up Comment #4, bug #46949 (project gnash):

After testing around, I found three problems in fb-gnash's code which prevent
framebuffer from properly returning to text mode:

1. fb-gnash's self termination (due to `fb-gnash --once` or
`fscommand("quit")`) does not trigger a proper cleanup, as `Gui::quitUI()`
is not overridde; it simply call `std::exit()` straight away
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gui.h?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n465>,
so console is left
in unusable state as the cleanup code is not run.

On the other hand, if Gnash is terminating by signal (SIGINT or SIGTERM
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n169>),
it will try to trigger exit cleanup
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n149>;
though this does not successfully
return console to usable state, due to...

2. FBGui's destructor calls wrong function
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n178>,
the right one should be
`FBGui::enable_terminal()` which restores console to text mode. And...

3. fb-gnash's `FBGui::_fd` integer which is used for deciding
whether to enter console cleanup
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n177>,
is not properly initialized. According to current
`FBGui::disable_terminal()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n555>
and `FBGui::enable_terminal()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n687>
code, it doesn't
seems to be used anymore. Both function just open current TTY, set video
mode,
and closed it, without really doing anything meaningful with class's
`_fd` variable.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 23 08:23:40 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMyAG-00064G-Pz
	for mharc-gnash-commit@gnu.org; Sat, 23 Jan 2016 08:23:40 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60375)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyAE-000647-Sd
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:23:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyA9-0006aB-Sc
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:23:38 -0500
Received: from [2001:4830:134:6::a] (port=55247 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyA9-0006a7-Oi
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:23:33 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMyA9-0005NY-Fw; Sat, 23 Jan 2016 13:23:33 +0000
Date: Sat, 23 Jan 2016 13:23:33 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8887
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.155 (Savane authenticated user nachanon)
Message-Id: <20160123-202332.sv82809.13389@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8887] Patch to correct text console
	restoration in `fb-gnash`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2016 13:23:40 -0000

URL:
  <http://savannah.gnu.org/patch/?8887>

                 Summary: Patch to correct text console restoration in
`fb-gnash`
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sat 23 Jan 2016 08:23:31 PM ICT
                Category: gui-fb
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Patch 1 of 3:
See the attached `0001_use-normal-exit-in-fb-gnash.patch`.

Current Gnash's `FBGui` class does not override `Gui::quitUI()` function,
and caused fb-gnash to exit abruptly via `std::exit()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/gui.h?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n465>
when it finished
running SWF on `fscommand("quit")` or via usage of `--once` switch;
left the framebuffer console in graphics mode, which is unusable
until a special utility is run
<https://savannah.gnu.org/bugs/?46949#comment2>, or the machine is restarted;
bug #46949.

The patch implements `FBGui::quitUI()` function, which sets
`FBGui::terminate_request` flag
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n139>
to `true`, signalling main loop to terminate
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n402>.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 23 Jan 2016 08:23:32 PM ICT  Name:
0001_use-normal-exit-in-fb-gnash.patch  Size: 927B   By: nachanon
Patch to make fb-gnash's self-termination use normal exit path instead of
`std::exit()`
<http://savannah.gnu.org/patch/download.php?file_id=36145>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 23 08:28:52 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMyFI-0007AF-BJ
	for mharc-gnash-commit@gnu.org; Sat, 23 Jan 2016 08:28:52 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33020)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyFF-00076T-Kv
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:28:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyFC-0007sb-Ee
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:28:49 -0500
Received: from [2001:4830:134:6::a] (port=55597 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyFC-0007sX-BV
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:28:46 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMyFC-0005UC-4q; Sat, 23 Jan 2016 13:28:46 +0000
Date: Sat, 23 Jan 2016 13:28:46 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8887
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.155 (Savane authenticated user nachanon)
Message-Id: <20160123-202846.sv82809.5694@savannah.gnu.org>
References: <20160123-202332.sv82809.13389@savannah.gnu.org>
In-Reply-To: <20160123-202332.sv82809.13389@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8887] Patch to correct text console
	restoration in `fb-gnash`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2016 13:28:50 -0000

Follow-up Comment #1, patch #8887 (project gnash):

The previous post said `terminate_request` is a part of `FBGui` class,
it was mistyped, sorry. It is actually a global variable in `gnash::gui`
namespace.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 23 08:31:55 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMyIF-0007sd-Ax
	for mharc-gnash-commit@gnu.org; Sat, 23 Jan 2016 08:31:55 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33591)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyIC-0007r8-Rx
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:31:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyI9-0000Zx-N2
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:31:52 -0500
Received: from [2001:4830:134:6::a] (port=55821 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyI9-0000Zs-JF
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:31:49 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMyI9-0005aY-CB; Sat, 23 Jan 2016 13:31:49 +0000
Date: Sat, 23 Jan 2016 13:31:49 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8887
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.155 (Savane authenticated user nachanon)
Message-Id: <20160123-203149.sv82809.12783@savannah.gnu.org>
References: <20160123-202332.sv82809.13389@savannah.gnu.org>
	<20160123-202846.sv82809.5694@savannah.gnu.org>
In-Reply-To: <20160123-202846.sv82809.5694@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8887] Patch to correct text console
	restoration in `fb-gnash`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2016 13:31:53 -0000

Follow-up Comment #2, patch #8887 (project gnash):

Patch 2 of 3:
See the attached `0002_call-correct-cleanup-function-in-fb-gnash.patch`.

Current Gnash's `FBGui` class's destructor which run as a part of normal exit
procedure, calls a wrong console cleanup function
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n178>;
it should call
`FBBui::enable_terminal()` which re-enable text console.

This patch corrects the function call.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386

(file #36146)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_call-correct-cleanup-function-in-fb-gnash.patch Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 23 08:35:54 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMyM6-0000xe-Mp
	for mharc-gnash-commit@gnu.org; Sat, 23 Jan 2016 08:35:54 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34525)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyM5-0000x6-25
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:35:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyM1-0001V0-QI
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:35:52 -0500
Received: from [2001:4830:134:6::a] (port=56191 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyM1-0001Ur-N9
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:35:49 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMyM1-0005hz-CB; Sat, 23 Jan 2016 13:35:49 +0000
Date: Sat, 23 Jan 2016 13:35:49 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8887
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.155 (Savane authenticated user nachanon)
Message-Id: <20160123-203549.sv82809.27599@savannah.gnu.org>
References: <20160123-202332.sv82809.13389@savannah.gnu.org>
	<20160123-202846.sv82809.5694@savannah.gnu.org>
	<20160123-203149.sv82809.12783@savannah.gnu.org>
In-Reply-To: <20160123-203149.sv82809.12783@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8887] Patch to correct text console
	restoration in `fb-gnash`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2016 13:35:54 -0000

Follow-up Comment #3, patch #8887 (project gnash):

Patch 3 of 3:
See the attached `0003_remove-fd-variable-check-in-fb-gnash.patch`.

Current Gnash's `FBGui` class's destructor decides whether if would try to
call terminal cleanup code by looking at `FBGui::_fd` variable's validity
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n177>.

But in current code, function `disable_terminal()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n555>,
and `enable_terminal()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n687>
or any other function in `FBGui` didn't really do anything meaningful with
the
variable. Therefore, it was left it in `-1` value, preventing the call to
console cleanup code.

This patch removes the fd check in destructor, making the console cleanup
code always run at exit; and also removes the variable entirely, as it is
not used anymore, correcting wrong code of `disable_terminal()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n615>
in the process;
completing the fix of main issue in bug #46949.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36147)
    _______________________________________________________

Additional Item Attachment:

File name: 0003_remove-fd-variable-check-in-fb-gnash.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 23 08:38:35 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMyOh-0002Wr-9a
	for mharc-gnash-commit@gnu.org; Sat, 23 Jan 2016 08:38:35 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyOe-0002TZ-Fk
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:38:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyOb-0001yl-95
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:38:32 -0500
Received: from [2001:4830:134:6::a] (port=56356 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyOb-0001yh-5g
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:38:29 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMyOa-0005iO-Uv; Sat, 23 Jan 2016 13:38:28 +0000
Date: Sat, 23 Jan 2016 13:38:28 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8887
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.155 (Savane authenticated user nachanon)
Message-Id: <20160123-203828.sv82809.88211@savannah.gnu.org>
References: <20160123-202332.sv82809.13389@savannah.gnu.org>
	<20160123-202846.sv82809.5694@savannah.gnu.org>
	<20160123-203149.sv82809.12783@savannah.gnu.org>
	<20160123-203549.sv82809.27599@savannah.gnu.org>
In-Reply-To: <20160123-203549.sv82809.27599@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8887] Patch to correct text console
	restoration in `fb-gnash`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2016 13:38:33 -0000

Follow-up Comment #4, patch #8887 (project gnash):

Note: This series of patch does not address the supposedly-unrelated
segmentation fault <https://savannah.gnu.org/bugs/?46949#comment3> traced to
fb-gnash's exit cleanup code
(predating these patches), which is remaining to be investigated.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 23 08:46:40 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aMyWW-0004CJ-Co
	for mharc-gnash-commit@gnu.org; Sat, 23 Jan 2016 08:46:40 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36306)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyWT-0004Bu-Q5
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:46:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyWQ-0003hN-KV
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:46:37 -0500
Received: from [2001:4830:134:6::a] (port=56843 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aMyWQ-0003hJ-H4
	for gnash-commit@gnu.org; Sat, 23 Jan 2016 08:46:34 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aMyWQ-0005v7-B6; Sat, 23 Jan 2016 13:46:34 +0000
Date: Sat, 23 Jan 2016 13:46:34 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.155 (Savane authenticated user nachanon)
Message-Id: <20160123-204634.sv82809.51923@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
	<20160122-170024.sv82809.7063@savannah.gnu.org>
	<20160122-170350.sv82809.76338@savannah.gnu.org>
	<20160122-170615.sv82809.92509@savannah.gnu.org>
	<20160122-171217.sv82809.24993@savannah.gnu.org>
	<20160123-125228.sv82809.12482@savannah.gnu.org>
	<20160123-181242.sv82809.30132@savannah.gnu.org>
In-Reply-To: <20160123-181242.sv82809.30132@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2016 13:46:38 -0000

Follow-up Comment #5, bug #46949 (project gnash):

Patch included, see patch #8887.

After applied the patches, you'll see that either running
`fb-gnash --once 12frames.swf` and wait for it to terminate,
or running `fb-gnash 12frames.swf` and press Ctrl+C
bring console back to text mode properly.

Note: The patches does not fix the segmentation fault error
<https://savannah.gnu.org/bugs/?46949#comment3> in fb-gnash's
normal exit procedure. The reason that segmentation fault appears now is
that the patches make Gnash terminate in the normal exit path, which is
the same as one already used in termination by signal handler
<https://savannah.gnu.org/bugs/?46949#comment3>.

This segmentation fault issue is still remaining to be investigated.

Gnash: 0.8.11dev (patched git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 24 04:59:31 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aNHSF-0003E9-BH
	for mharc-gnash-commit@gnu.org; Sun, 24 Jan 2016 04:59:31 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNHSC-0003Cp-U1
	for gnash-commit@gnu.org; Sun, 24 Jan 2016 04:59:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNHS9-0005BF-Nf
	for gnash-commit@gnu.org; Sun, 24 Jan 2016 04:59:28 -0500
Received: from [2001:4830:134:6::a] (port=53280 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNHS9-0005BB-Kj
	for gnash-commit@gnu.org; Sun, 24 Jan 2016 04:59:25 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aNHS8-0005zn-2v; Sun, 24 Jan 2016 09:59:24 +0000
Date: Sun, 24 Jan 2016 09:59:24 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8853
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.166.234 (Savane authenticated user nachanon)
Message-Id: <20160124-165923.sv82809.89768@savannah.gnu.org>
References: <20160112-233805.sv82809.71845@savannah.gnu.org>
	<20160113-165125.sv27281.17247@savannah.gnu.org>
	<20160113-165326.sv27281.77644@savannah.gnu.org>
In-Reply-To: <20160113-165326.sv27281.77644@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8853] Patch to allow calling zero-argument
	JavaScript function via `ExternalInterface.call()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jan 2016 09:59:30 -0000

Follow-up Comment #3, patch #8853 (project gnash):

Patch 2 of 2:
See the attached
`0002_add-single-argument-externalinterface-call-test.patch`.

This patch adds a simple Flash-calls-JavaScript ExternalInterface test,
featuring a zero-argument string-returning JavaScript function call,
which ActionScript invokes `ExternalInterface.call()` using single argument.

The test is added as a part of `extcommtests-runner`.

*Note:*
The 1-sec pause between writing return value from container-side
`js_simple()` and writing invoke command to player-side `script_call()`,
is put there to avoid the condition that these two written data block got
read by Gnash as a single-block return value from `js_simple()`; discarding
the `script_call()` invoke, failing the test. This was due to Gnash (player)
used read block boundary to delimit the data
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/ExternalInterface.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n361>
rather than the XML tag.

Without a pause, test failures are very likely to appear, especially
under nested `make check-DEJAGNU`, but not when `extcommtests-runner` is run
directly.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36154)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_add-single-argument-externalinterface-call-test.patch Size:3
KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8853>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 24 05:03:08 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aNHVk-0003ZC-Kg
	for mharc-gnash-commit@gnu.org; Sun, 24 Jan 2016 05:03:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41486)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNHVi-0003Us-JZ
	for gnash-commit@gnu.org; Sun, 24 Jan 2016 05:03:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNHVf-0006JD-Dw
	for gnash-commit@gnu.org; Sun, 24 Jan 2016 05:03:06 -0500
Received: from [2001:4830:134:6::a] (port=53535 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNHVf-0006J8-B4
	for gnash-commit@gnu.org; Sun, 24 Jan 2016 05:03:03 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aNHVf-00066z-4u; Sun, 24 Jan 2016 10:03:03 +0000
Date: Sun, 24 Jan 2016 10:03:03 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46878
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.166.234 (Savane authenticated user nachanon)
Message-Id: <20160124-170302.sv82809.64138@savannah.gnu.org>
References: <20160112-192339.sv82809.34407@savannah.gnu.org>
	<20160112-193316.sv82809.67150@savannah.gnu.org>
	<20160112-233046.sv82809.7263@savannah.gnu.org>
	<20160112-234254.sv82809.60405@savannah.gnu.org>
In-Reply-To: <20160112-234254.sv82809.60405@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46878] Gnash refused to call zero-parameter
	JavaScript function via ExternalInterface.call()
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jan 2016 10:03:07 -0000

Follow-up Comment #4, bug #46878 (project gnash):

Automated test for this issue is now included.
See patch #8853 comment 3 <https://savannah.gnu.org/patch/?8853#comment3>.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46878>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 25 08:23:48 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aNh7U-0007su-MB
	for mharc-gnash-commit@gnu.org; Mon, 25 Jan 2016 08:23:48 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55054)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNh7T-0007qo-8y
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 08:23:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNh7Q-0006TO-2w
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 08:23:47 -0500
Received: from [2001:4830:134:6::a] (port=54638 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNh7P-0006TI-Vh
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 08:23:44 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aNh7B-0006rx-7Y; Mon, 25 Jan 2016 13:23:29 +0000
Date: Mon, 25 Jan 2016 13:23:29 +0000
To: Rob Savoye <rob@welcomehome.org>, Sandro Santilli <strk@keybit.net>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 32411
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.140 (Savane authenticated user nachanon)
Message-Id: <20160125-202329.sv82809.45439@savannah.gnu.org>
References: <20110210-101655.sv27281.26203@savannah.gnu.org>
	<20110305-163550.sv48477.58410@savannah.gnu.org>
	<20110305-083806.sv178.96135@savannah.gnu.org>
	<20110305-173739.sv48477.39395@savannah.gnu.org>
	<20110305-094138.sv178.98630@savannah.gnu.org>
	<20110305-174352.sv60230.66725@savannah.gnu.org>
	<20110305-095311.sv178.37635@savannah.gnu.org>
	<20110305-180604.sv48477.39870@savannah.gnu.org>
	<20110305-101517.sv178.56093@savannah.gnu.org>
	<20110305-183009.sv48477.87700@savannah.gnu.org>
	<20110305-103540.sv178.87326@savannah.gnu.org>
	<20110305-213931.sv27281.8825@savannah.gnu.org>
	<20160107-002427.sv82809.28725@savannah.gnu.org>
	<20160107-002941.sv82809.31437@savannah.gnu.org>
	<20160107-003238.sv82809.48271@savannah.gnu.org>
In-Reply-To: <20160107-003238.sv82809.48271@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #32411] ExternalInterface XML parser fails with
	nested tags
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jan 2016 13:23:48 -0000

Follow-up Comment #15, bug #32411 (project gnash):

YouTube's player used object (array) return type in ExternalInterface
callback
causing nested value tag to be sent to plugin; now crashing libgnashplugin
as bug #37223 is fixed.

See Debian bug report: https://bugs.debian.org/811106

Communication log between plugin and player
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811106#15> are also
included
in Debian bug report.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016) NPAPI
Iceweasel: 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32411>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 25 10:13:40 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aNipo-00067a-3x
	for mharc-gnash-commit@gnu.org; Mon, 25 Jan 2016 10:13:40 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55681)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNipl-00067T-NX
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 10:13:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNipi-0005O6-FK
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 10:13:37 -0500
Received: from [2001:4830:134:6::a] (port=33791 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNipi-0005O2-Br
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 10:13:34 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aNipg-0000jd-RY; Mon, 25 Jan 2016 15:13:32 +0000
Date: Mon, 25 Jan 2016 15:13:32 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8721
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.163.140 (Savane authenticated user nachanon)
Message-Id: <20160125-221332.sv82809.86377@savannah.gnu.org>
References: <20150821-222038.sv82809.84749@savannah.gnu.org>
	<20150824-123932.sv27281.97127@savannah.gnu.org>
	<20150824-124957.sv27281.79853@savannah.gnu.org>
	<20150825-192340.sv27281.22653@savannah.gnu.org>
	<20150828-195057.sv82809.29889@savannah.gnu.org>
	<20150828-201604.sv82809.41033@savannah.gnu.org>
	<20150828-204931.sv27281.66378@savannah.gnu.org>
	<20150828-205838.sv27281.52431@savannah.gnu.org>
	<20151203-123401.sv27281.75279@savannah.gnu.org>
	<20151207-224209.sv82809.60804@savannah.gnu.org>
	<20151207-224506.sv82809.79209@savannah.gnu.org>
	<20151207-165650.sv27281.73161@savannah.gnu.org>
	<20151207-170558.sv27281.62146@savannah.gnu.org>
	<20151207-170859.sv27281.7726@savannah.gnu.org>
	<20151207-183404.sv27281.15816@savannah.gnu.org>
In-Reply-To: <20151207-183404.sv27281.15816@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8721] Patch to make `GetVariable()` return
	String regardless of original variable type
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jan 2016 15:13:38 -0000

Follow-up Comment #15, patch #8721 (project gnash):

For the automated test case of this fix, see patch #8835 (committed as 48e75c1
<http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=48e75c155221141df7f2cf4a24944c005e7e89b0>).

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8721>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Jan 25 11:34:57 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aNk6T-0003zI-Br
	for mharc-gnash-commit@gnu.org; Mon, 25 Jan 2016 11:34:57 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57433)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNk6Q-0003yx-Ot
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 11:34:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNk6N-00020P-Ij
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 11:34:54 -0500
Received: from [2001:4830:134:6::a] (port=40080 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aNk6N-00020L-Em
	for gnash-commit@gnu.org; Mon, 25 Jan 2016 11:34:51 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aNk6M-0002RA-96; Mon, 25 Jan 2016 16:34:50 +0000
Date: Mon, 25 Jan 2016 16:34:50 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8721
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160125-173450.sv27281.45867@savannah.gnu.org>
References: <20150821-222038.sv82809.84749@savannah.gnu.org>
	<20150824-123932.sv27281.97127@savannah.gnu.org>
	<20150824-124957.sv27281.79853@savannah.gnu.org>
	<20150825-192340.sv27281.22653@savannah.gnu.org>
	<20150828-195057.sv82809.29889@savannah.gnu.org>
	<20150828-201604.sv82809.41033@savannah.gnu.org>
	<20150828-204931.sv27281.66378@savannah.gnu.org>
	<20150828-205838.sv27281.52431@savannah.gnu.org>
	<20151203-123401.sv27281.75279@savannah.gnu.org>
	<20151207-224209.sv82809.60804@savannah.gnu.org>
	<20151207-224506.sv82809.79209@savannah.gnu.org>
	<20151207-165650.sv27281.73161@savannah.gnu.org>
	<20151207-170558.sv27281.62146@savannah.gnu.org>
	<20151207-170859.sv27281.7726@savannah.gnu.org>
	<20151207-183404.sv27281.15816@savannah.gnu.org>
	<20160125-221332.sv82809.86377@savannah.gnu.org>
In-Reply-To: <20160125-221332.sv82809.86377@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8721] Patch to make `GetVariable()` return
	String regardless of original variable type
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jan 2016 16:34:55 -0000

Update of patch #8721 (project gnash):

                  Status:          Ready For Test => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #16:

So I'm closing this. Thanks.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8721>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 28 07:34:50 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aOlmk-0004EV-5x
	for mharc-gnash-commit@gnu.org; Thu, 28 Jan 2016 07:34:50 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aOlmh-0004B0-HV
	for gnash-commit@gnu.org; Thu, 28 Jan 2016 07:34:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aOlme-0005jI-1d
	for gnash-commit@gnu.org; Thu, 28 Jan 2016 07:34:47 -0500
Received: from [2001:4830:134:6::a] (port=34117 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aOlmd-0005j7-Uf
	for gnash-commit@gnu.org; Thu, 28 Jan 2016 07:34:43 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aOlmP-0006VJ-JX; Thu, 28 Jan 2016 12:34:29 +0000
Date: Thu, 28 Jan 2016 12:34:29 +0000
To: Rob Savoye <rob@welcomehome.org>, Sandro Santilli <strk@keybit.net>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 32411
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.162.171 (Savane authenticated user nachanon)
Message-Id: <20160128-193429.sv82809.89701@savannah.gnu.org>
References: <20110210-101655.sv27281.26203@savannah.gnu.org>
	<20110305-163550.sv48477.58410@savannah.gnu.org>
	<20110305-083806.sv178.96135@savannah.gnu.org>
	<20110305-173739.sv48477.39395@savannah.gnu.org>
	<20110305-094138.sv178.98630@savannah.gnu.org>
	<20110305-174352.sv60230.66725@savannah.gnu.org>
	<20110305-095311.sv178.37635@savannah.gnu.org>
	<20110305-180604.sv48477.39870@savannah.gnu.org>
	<20110305-101517.sv178.56093@savannah.gnu.org>
	<20110305-183009.sv48477.87700@savannah.gnu.org>
	<20110305-103540.sv178.87326@savannah.gnu.org>
	<20110305-213931.sv27281.8825@savannah.gnu.org>
	<20160107-002427.sv82809.28725@savannah.gnu.org>
	<20160107-002941.sv82809.31437@savannah.gnu.org>
	<20160107-003238.sv82809.48271@savannah.gnu.org>
	<20160125-202329.sv82809.45439@savannah.gnu.org>
In-Reply-To: <20160125-202329.sv82809.45439@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #32411] ExternalInterface XML parser fails with
	nested tags
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2016 12:34:48 -0000

Follow-up Comment #16, bug #32411 (project gnash):

I also made a test Flash file for checking current ExternalInterface's
support for Array-typed callback argument and return type too (in JavaScript
calls Flash direction); attached as `js2flash-arr.zip`.

Screenshot, logs (verbosity 2 + action error), and relevant GDB backtrace
are also included in the same ZIP file.

*Array-Typed Function Argument Case*

This is an image result from `js2flash-arrarg.html` under browser with Flash
Player:
http://i.imgur.com/1BcnPEL.png

Flash Player's trace output from the run:

Warning: Reference to undeclared variable, 'JS2FlashArrayArg'
callee: starting
callee: adding ExternalInterface callback
callee: finished initializing
callee: entering ExternalInterface callback
callee: ExternalInterface callback succeeded, expected array with 2 elements
[Hello, World], got array with 2 elements [Hello, World]
callee: ExternalInterface callback finished


You'll see that Flash Player passed an ExternalInterface callback's Array
argument, length, and its elements correctly.

This is an image result from `js2flash-arrarg.html` under browser with Gnash:
http://i.imgur.com/7YY6GdA.png

Gnash's console output shows:

SECURITY: Extensions disabled
ACTIONSCRIPT ERROR: reference to non-existent variable 'JS2FlashArrayArg'
TRACE: callee: starting
TRACE: callee: adding ExternalInterface callback
TRACE: callee: finished initializing
TRACE: callee: entering ExternalInterface callback
ACTIONSCRIPT ERROR: getMember called against a value that does not cast to an
as_object: [undefined]
ACTIONSCRIPT ERROR: getMember called against a value that does not cast to an
as_object: [undefined]
ACTIONSCRIPT ERROR: getMember called against a value that does not cast to an
as_object: [undefined]
TRACE: callee: ExternalInterface called incorrectly, expected array with 2
elements [Hello, World] got undefined with undefined elements [undefined,
undefined]
TRACE: callee: ExternalInterface callback finished


You'll see from console output that Gnash passed an Array-typed
ExternalInterface callback argument as `undefined`.

According to Gnash's container-player communication log, the problem also
started from libgnashplugin sending an empty `<object>` tag to player,
which is incorrect since this array is supposed to have two elements.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016) NPAPI
Flash Player: 11.2.202.491 NPAPI binary
Iceweasel: 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

(file #36190)
    _______________________________________________________

Additional Item Attachment:

File name: js2flash-arr.zip               Size:24 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32411>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Jan 28 07:39:22 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aOlr8-0006Dw-PR
	for mharc-gnash-commit@gnu.org; Thu, 28 Jan 2016 07:39:22 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aOlr5-0006Cz-IA
	for gnash-commit@gnu.org; Thu, 28 Jan 2016 07:39:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aOlr2-00073G-Nq
	for gnash-commit@gnu.org; Thu, 28 Jan 2016 07:39:19 -0500
Received: from [2001:4830:134:6::a] (port=34686 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aOlr2-00073B-KY
	for gnash-commit@gnu.org; Thu, 28 Jan 2016 07:39:16 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aOlql-0006dq-36; Thu, 28 Jan 2016 12:38:59 +0000
Date: Thu, 28 Jan 2016 12:38:59 +0000
To: Rob Savoye <rob@welcomehome.org>, Sandro Santilli <strk@keybit.net>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 32411
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.162.171 (Savane authenticated user nachanon)
Message-Id: <20160128-193858.sv82809.92335@savannah.gnu.org>
References: <20110210-101655.sv27281.26203@savannah.gnu.org>
	<20110305-163550.sv48477.58410@savannah.gnu.org>
	<20110305-083806.sv178.96135@savannah.gnu.org>
	<20110305-173739.sv48477.39395@savannah.gnu.org>
	<20110305-094138.sv178.98630@savannah.gnu.org>
	<20110305-174352.sv60230.66725@savannah.gnu.org>
	<20110305-095311.sv178.37635@savannah.gnu.org>
	<20110305-180604.sv48477.39870@savannah.gnu.org>
	<20110305-101517.sv178.56093@savannah.gnu.org>
	<20110305-183009.sv48477.87700@savannah.gnu.org>
	<20110305-103540.sv178.87326@savannah.gnu.org>
	<20110305-213931.sv27281.8825@savannah.gnu.org>
	<20160107-002427.sv82809.28725@savannah.gnu.org>
	<20160107-002941.sv82809.31437@savannah.gnu.org>
	<20160107-003238.sv82809.48271@savannah.gnu.org>
	<20160125-202329.sv82809.45439@savannah.gnu.org>
	<20160128-193429.sv82809.89701@savannah.gnu.org>
In-Reply-To: <20160128-193429.sv82809.89701@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #32411] ExternalInterface XML parser fails with
	nested tags
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2016 12:39:21 -0000

Follow-up Comment #17, bug #32411 (project gnash):

*Array-Typed Function Return Value Case*

This is an image result from `js2flash-arrret.html` under browser with Flash
Player:
http://i.imgur.com/fltGcMx.png

Flash Player's trace output from the run:

Warning: Reference to undeclared variable, 'JS2FlashArrayRet'
callee: starting
callee: adding ExternalInterface callback
callee: finished initializing
callee: entering ExternalInterface callback
callee: ExternalInterface callback succeeded
callee: ExternalInterface callback returning


You'll see that Flash Player passed ExternalInterface callback's Array return
value, length and its sub-elements correctly.

This is an image result from `js2flash-arrjret.html` under browser with
Gnash:
http://i.imgur.com/D83Zlmr.png

Gnash's console output shows:

SECURITY: Extensions disabled
ACTIONSCRIPT ERROR: reference to non-existent variable 'JS2FlashArrayRet'
TRACE: callee: starting
TRACE: callee: adding ExternalInterface callback
TRACE: callee: finished initializing
TRACE: callee: entering ExternalInterface callback
TRACE: callee: ExternalInterface callback succeeded
TRACE: callee: ExternalInterface callback returning


You'll see from screenshot that Gnash did not pass Array-typed return value 
from ExternalInterface callback correctly, and XULRunner crashed afterward.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016) NPAPI
Flash Player: 11.2.202.491 NPAPI binary
Iceweasel: 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32411>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 29 02:02:26 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aP34c-00074j-Fl
	for mharc-gnash-commit@gnu.org; Fri, 29 Jan 2016 02:02:26 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP34a-00074Y-RI
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:02:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP34W-0005ct-Ri
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:02:24 -0500
Received: from [2001:4830:134:6::a] (port=39107 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP34W-0005cp-OF
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:02:20 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aP34V-0007QZ-EG; Fri, 29 Jan 2016 07:02:19 +0000
Date: Fri, 29 Jan 2016 07:02:19 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8887
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160129-080219.sv27281.37574@savannah.gnu.org>
References: <20160123-202332.sv82809.13389@savannah.gnu.org>
	<20160123-202846.sv82809.5694@savannah.gnu.org>
	<20160123-203149.sv82809.12783@savannah.gnu.org>
	<20160123-203549.sv82809.27599@savannah.gnu.org>
	<20160123-203828.sv82809.88211@savannah.gnu.org>
In-Reply-To: <20160123-203828.sv82809.88211@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8887] Patch to correct text console
	restoration in `fb-gnash`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 07:02:25 -0000

Update of patch #8887 (project gnash):

                  Status:                    None => In Progress            
             Assigned to:                    None => strk                   


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 29 02:10:33 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aP3CT-00013R-1w
	for mharc-gnash-commit@gnu.org; Fri, 29 Jan 2016 02:10:33 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36176)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aP3CQ-00013L-Q3
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:10:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aP3CP-00085V-Df
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:10:30 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:39838)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aP3CP-00085L-9d
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:10:29 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1aP3CN-0001yn-6d
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 07:10:29 +0000
Date: Fri, 29 Jan 2016 07:10:27 +0000
Message-Id: <E1aP3CN-0001yn-6d@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 62cfdfe81d6d9a17c722558dc6046b6596342e98
X-Git-Newrev: b6666a67ff2ab161f73fadd9c17b75573751e41c
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2253-gb6666a6
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 07:10:32 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  b6666a67ff2ab161f73fadd9c17b75573751e41c (commit)
       via  a60f7ea77232573bb010ea29a14b41f901045fc4 (commit)
       via  bb76853664ebdcc7f1555201d38b8de6c1615184 (commit)
      from  62cfdfe81d6d9a17c722558dc6046b6596342e98 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=b6666a67ff2ab161f73fadd9c17b75573751e41c


commit b6666a67ff2ab161f73fadd9c17b75573751e41c
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Fri Jan 29 08:01:02 2016 +0100

    Remove the incorrect _fd variable check in FBGui destructor.

diff --git a/gui/fb/fb.cpp b/gui/fb/fb.cpp
index 0370c56..37948c7 100644
--- a/gui/fb/fb.cpp
+++ b/gui/fb/fb.cpp
@@ -153,7 +153,6 @@ terminate_signal(int /*signo*/) {
 
 FBGui::FBGui(unsigned long xid, float scale, bool loop, RunResources& r)
     : Gui(xid, scale, loop, r),
-      _fd(-1),
       _original_vt(-1),
       _original_kd(-1),
       _own_vt(-1),
@@ -174,11 +173,7 @@ FBGui::~FBGui()
 {  
     // GNASH_REPORT_FUNCTION;
     
-    if (_fd > 0) {
-        enable_terminal();
-        // log_debug("Closing framebuffer device");
-        close(_fd);
-    }
+    enable_terminal();
 }
 
 bool
@@ -588,8 +583,6 @@ FBGui::disable_terminal()
     struct vt_stat vts;
     if (ioctl(fd, VT_GETSTATE, &vts) == -1) {
         log_error(_("Could not get current VT state"));
-        close(_fd);
-        _fd = -1;
         close(fd);
         return false;
     }
@@ -618,7 +611,7 @@ FBGui::disable_terminal()
         return false;
     }
   
-    _fd = open(tty, O_RDWR);
+    fd = open(tty, O_RDWR);
     if (fd < 0) {
         log_error(_("Could not open %s"), tty);
         return false;
@@ -714,8 +707,6 @@ FBGui::enable_terminal()
 
     if (ioctl(fd, VT_ACTIVATE, _original_vt)) {
         log_error(_("Could not activate VT number %d"), _original_vt);
-        close(_fd);
-        _fd = -1;
         close(fd);
         return false;
     }
diff --git a/gui/fb/fbsup.h b/gui/fb/fbsup.h
index 35b850f..063b0b5 100644
--- a/gui/fb/fbsup.h
+++ b/gui/fb/fbsup.h
@@ -187,7 +187,6 @@ private:
     /// reverts disable_terminal() changes
     bool enable_terminal();
     
-    int         _fd;
     int         _original_vt;   // virtual terminal that was active at startup
     int         _original_kd;   // keyboard mode at startup
     int         _own_vt;        // virtual terminal we are running in   

http://git.savannah.gnu.org/cgit//commit/?id=a60f7ea77232573bb010ea29a14b41f901045fc4


commit a60f7ea77232573bb010ea29a14b41f901045fc4
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Fri Jan 29 08:00:46 2016 +0100

    Call a correct console cleanup function in FBGui destructor.

diff --git a/gui/fb/fb.cpp b/gui/fb/fb.cpp
index 07d0687..0370c56 100644
--- a/gui/fb/fb.cpp
+++ b/gui/fb/fb.cpp
@@ -175,7 +175,7 @@ FBGui::~FBGui()
     // GNASH_REPORT_FUNCTION;
     
     if (_fd > 0) {
-        disable_terminal();
+        enable_terminal();
         // log_debug("Closing framebuffer device");
         close(_fd);
     }

http://git.savannah.gnu.org/cgit//commit/?id=bb76853664ebdcc7f1555201d38b8de6c1615184


commit bb76853664ebdcc7f1555201d38b8de6c1615184
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Fri Jan 29 08:00:20 2016 +0100

    Use normal exit procedure instead of std::exit() when fb-gnash finished running SWF.

diff --git a/gui/fb/fb.cpp b/gui/fb/fb.cpp
index 5e9a155..07d0687 100644
--- a/gui/fb/fb.cpp
+++ b/gui/fb/fb.cpp
@@ -517,6 +517,12 @@ FBGui::setInvalidatedRegions(const InvalidatedRanges& ranges)
      _glue->setInvalidatedRegions(ranges);
 }
 
+void
+FBGui::quitUI()
+{
+    terminate_request = true;
+}
+
 char *
 FBGui::find_accessible_tty(int no)
 {
diff --git a/gui/fb/fbsup.h b/gui/fb/fbsup.h
index 23f409b..35b850f 100644
--- a/gui/fb/fbsup.h
+++ b/gui/fb/fbsup.h
@@ -119,6 +119,9 @@ public:
     /// Start main rendering loop.
     bool run();
 
+    /// Stop main rendering loop.
+    void quitUI();
+
     // Resize the viewing area within the total framebuffer display
     bool resize_view(int width, int height);
     

-----------------------------------------------------------------------

Summary of changes:
 gui/fb/fb.cpp  |   19 ++++++++-----------
 gui/fb/fbsup.h |    4 +++-
 2 files changed, 11 insertions(+), 12 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Fri Jan 29 02:10:44 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aP3Ce-000155-7B
	for mharc-gnash-commit@gnu.org; Fri, 29 Jan 2016 02:10:44 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3Cb-00014w-SF
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:10:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3CY-00086P-Kq
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:10:41 -0500
Received: from [2001:4830:134:6::a] (port=39585 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3CY-00086L-HU
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:10:38 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aP3CX-0007dZ-GR; Fri, 29 Jan 2016 07:10:37 +0000
Date: Fri, 29 Jan 2016 07:10:37 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8887
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160129-081037.sv27281.57839@savannah.gnu.org>
References: <20160123-202332.sv82809.13389@savannah.gnu.org>
	<20160123-202846.sv82809.5694@savannah.gnu.org>
	<20160123-203149.sv82809.12783@savannah.gnu.org>
	<20160123-203549.sv82809.27599@savannah.gnu.org>
	<20160123-203828.sv82809.88211@savannah.gnu.org>
	<20160129-080219.sv27281.37574@savannah.gnu.org>
In-Reply-To: <20160129-080219.sv27281.37574@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8887] Patch to correct text console
	restoration in `fb-gnash`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 07:10:42 -0000

Update of patch #8887 (project gnash):

                  Status:             In Progress => Done                   
             Open/Closed:                    Open => Closed                 


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 29 02:11:18 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aP3DC-00017f-QZ
	for mharc-gnash-commit@gnu.org; Fri, 29 Jan 2016 02:11:18 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36375)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3DA-00017Z-JK
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:11:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3D7-0008Ao-Bv
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:11:16 -0500
Received: from [2001:4830:134:6::a] (port=39618 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3D7-0008Ak-8E
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:11:13 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aP3D5-0007dh-Jw; Fri, 29 Jan 2016 07:11:11 +0000
Date: Fri, 29 Jan 2016 07:11:11 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160129-081111.sv27281.18979@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
	<20160122-170024.sv82809.7063@savannah.gnu.org>
	<20160122-170350.sv82809.76338@savannah.gnu.org>
	<20160122-170615.sv82809.92509@savannah.gnu.org>
	<20160122-171217.sv82809.24993@savannah.gnu.org>
	<20160123-125228.sv82809.12482@savannah.gnu.org>
	<20160123-181242.sv82809.30132@savannah.gnu.org>
	<20160123-204634.sv82809.51923@savannah.gnu.org>
In-Reply-To: <20160123-204634.sv82809.51923@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 07:11:17 -0000

Update of bug #46949 (project gnash):

                  Status:                    None => Ready For Test         

    _______________________________________________________

Follow-up Comment #6:

The 3 patches in patch #8887 have been pushed, this is ready for test.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 29 02:27:10 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aP3SY-0000CL-1v
	for mharc-gnash-commit@gnu.org; Fri, 29 Jan 2016 02:27:10 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3SW-0000CC-3S
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:27:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3SR-0001Vq-0H
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:27:08 -0500
Received: from [2001:4830:134:6::a] (port=41060 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP3SQ-0001Vm-Sf
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:27:02 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aP3SP-0007yD-Lu; Fri, 29 Jan 2016 07:27:01 +0000
Date: Fri, 29 Jan 2016 07:27:01 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8853
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:43.0) Gecko/20100101 Firefox/43.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160129-082701.sv27281.4690@savannah.gnu.org>
References: <20160112-233805.sv82809.71845@savannah.gnu.org>
	<20160113-165125.sv27281.17247@savannah.gnu.org>
	<20160113-165326.sv27281.77644@savannah.gnu.org>
	<20160124-165923.sv82809.89768@savannah.gnu.org>
In-Reply-To: <20160124-165923.sv82809.89768@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8853] Patch to allow calling zero-argument
	JavaScript function via `ExternalInterface.call()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 07:27:09 -0000

Update of patch #8853 (project gnash):

                  Status:          Ready For Test => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #4:

Second patch pushed as commit e705394a72888a8791497d94a7cf4c78b2e23f02

Thanks!


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8853>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Fri Jan 29 02:27:40 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aP3T2-0000We-7f
	for mharc-gnash-commit@gnu.org; Fri, 29 Jan 2016 02:27:40 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aP3Sz-0000Sg-8y
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:27:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aP3Sx-0001bb-Vi
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:27:37 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:39969)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aP3Sx-0001bW-Rp
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 02:27:35 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1aP3SR-0004If-NX
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 07:27:19 +0000
Date: Fri, 29 Jan 2016 07:27:06 +0000
Message-Id: <E1aP3SR-0004If-NX@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: b6666a67ff2ab161f73fadd9c17b75573751e41c
X-Git-Newrev: e705394a72888a8791497d94a7cf4c78b2e23f02
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2254-ge705394
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 07:27:38 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  e705394a72888a8791497d94a7cf4c78b2e23f02 (commit)
      from  b6666a67ff2ab161f73fadd9c17b75573751e41c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=e705394a72888a8791497d94a7cf4c78b2e23f02


commit e705394a72888a8791497d94a7cf4c78b2e23f02
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Fri Jan 29 08:25:58 2016 +0100

    Add automated test for single-argument ExternalInterface.call() usage.

diff --git a/testsuite/misc-mtasc.all/extcomm.as b/testsuite/misc-mtasc.all/extcomm.as
index 4f455cd..cb8eaf3 100644
--- a/testsuite/misc-mtasc.all/extcomm.as
+++ b/testsuite/misc-mtasc.all/extcomm.as
@@ -1,6 +1,6 @@
 // extcomm.as - Host container communication (ExternalInterface) tests
 //
-//   Copyright (C) 2015 Free Software Foundation, Inc.
+//   Copyright (C) 2015, 2016 Free Software Foundation, Inc.
 //
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
@@ -136,5 +136,9 @@ class ExternalCommTest
 				}
 			)
 		);
+
+		// Calling JavaScript function without any argument should give
+		// a correct return value
+		check_equals(ExternalInterface.call("js_simple"), "Correct");
 	}
 }
diff --git a/testsuite/misc-mtasc.all/extcommtests-runner.sh b/testsuite/misc-mtasc.all/extcommtests-runner.sh
index c71cd6d..6f0d875 100644
--- a/testsuite/misc-mtasc.all/extcommtests-runner.sh
+++ b/testsuite/misc-mtasc.all/extcommtests-runner.sh
@@ -4,7 +4,7 @@
 # extcommtests-runner.sh: container-emulated, automated
 #     ExternalInterface test generator
 # 
-# Copyright (C) 2015 Free Software Foundation, Inc.
+# Copyright (C) 2015, 2016 Free Software Foundation, Inc.
 # 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -26,6 +26,8 @@
 # The generated test runner checks Gnash for:
 #  * ExternalInterface.addCallback() issues (bug #37223)
 #        <https://savannah.gnu.org/bugs/?37223>
+#  * Single-argument ExternalInterface.call() issue (bug #46878)
+#        <https://savannah.gnu.org/bugs/?46878>
 # 
 # Usage:
 #     ./extcommtests-runner.sh <builddir> <srcdir> <swf>
@@ -183,6 +185,20 @@ check_equals \
 	'<invoke name="addMethod" returntype="xml"><arguments><string>script_longarglist</string></arguments></invoke>' \
 	"Gnash should properly register script_longarglist ExternalInterface callback"
 
+# Read for js_simple JavaScript function invocation statement
+read_timeout LINE \$READTIMEOUT <&3
+check_equals \
+	"\$LINE" \
+	'<invoke name="js_simple" returntype="xml"><arguments><string>js_simple</string></arguments></invoke>' \
+	"Gnash should call JavaScript's js_simple function correctly"
+
+# Return string value from js_simple function
+echo '<string>Correct</string>' >&4
+
+# Pause a bit, so the next script_call invoke doesn't get mixed up with
+# the previous return value data
+sleep 1
+
 # Call the script_call callback
 echo '<invoke name="script_call" returntype="xml"><arguments><string>Hello</string><string>World</string></arguments></invoke>' >&4
 
@@ -244,7 +260,7 @@ XFAILED=\`expr "\$XFAILED" + "\$PLAYERXFAILED"\`
 TESTED=\`expr "\$TESTED" + "\$PLAYERPASSED" + "\$PLAYERXPASSED" + "\$PLAYERFAILED" + "\$PLAYERXFAILED"\`
 
 # Check for total number of test run
-check_totals "45" "There should be 45 tests run"
+check_totals "47" "There should be 47 tests run"
 
 # Remove temporary files
 rm "\$LOGFILE"

-----------------------------------------------------------------------

Summary of changes:
 testsuite/misc-mtasc.all/extcomm.as             |    6 +++++-
 testsuite/misc-mtasc.all/extcommtests-runner.sh |   20 ++++++++++++++++++--
 2 files changed, 23 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Fri Jan 29 03:05:38 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aP43m-0006nJ-GD
	for mharc-gnash-commit@gnu.org; Fri, 29 Jan 2016 03:05:38 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46016)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP43h-0006ld-AG
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 03:05:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP43c-000499-AC
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 03:05:33 -0500
Received: from [2001:4830:134:6::a] (port=43818 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aP43c-000490-6Z
	for gnash-commit@gnu.org; Fri, 29 Jan 2016 03:05:28 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aP43b-0000Sp-S6; Fri, 29 Jan 2016 08:05:27 +0000
Date: Fri, 29 Jan 2016 08:05:27 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47004
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.165.102 (Savane authenticated user nachanon)
Message-Id: <20160129-150526.sv82809.19313@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47004] Gnash didn't pass string return value
	"Error" and "SecurityError" from ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2016 08:05:38 -0000

URL:
  <http://savannah.gnu.org/bugs/?47004>

                 Summary: Gnash didn't pass string return value "Error" and
"SecurityError" from ExternalInterface callback
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Fri 29 Jan 2016 03:05:26 PM ICT
                Category: plugin
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a spin-off from bug #37223 (ExternalInterface registration issue),
and bug #32411 (ExternalInterface Object data issue).

There is a weird problem in libgnashplugin's ExternalInterface callback
return value handling. I found that if a string "Error", or "SecurityError"
is returned from Flash-side callback, JavaScript would get `null` value
instead of the returned string. Other string values are passed correctly.

I have created simple SWF file (Flash 8) using libming's makeswf, which
registers a callback named `error_call` and `securityerror_call` and
`hello_call` which return string "Error", "SecurityError", and "Hello!"
to demonstrate this problem.

Text output from running `js2flash-errorstring.html` under browser with Flash
Player:

Flash's error_call() returned type string, value: Error
Flash's securityerror_call() returned type string, value: SecurityError
Flash's hello_call() returned type string, value: Hello!


You'd see that string "Error", "SecurityError", and "Hello!" are passed back
to JavaScript correctly.

Text output from running `js2flash-errorstring.html` under browser Gnash:

Flash's error_call() returned type object, value: null
Flash's securityerror_call() returned type object, value: null
Flash's hello_call() returned type string, value: Hello!


You'd see that "Error", and "SecurityError" string are passed back to
JavaScript as `null`, which is incorrect.

According to container-player communication dump, each "<string>" value
are correctly sent from Gnash's player side. So this is most likely to be
libgnashplugin's fault.

SWF file, source code, build script, HTML container, screenshots, text output
debug logs, and container-player communication dumps are attached as
`js2flash-errorstring.html`.

Gnash: 0.8.11dev (git 62cfdfe 16-Jan-2016) NPAPI
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 29 Jan 2016 03:05:26 PM ICT  Name: js2flash-errorstring.zip  Size:
9kB   By: nachanon
Test Flash file, HTML container, source code, screenshots and logs
<http://savannah.gnu.org/bugs/download.php?file_id=36194>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47004>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Jan 30 21:49:44 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aPi5A-0004lD-HU
	for mharc-gnash-commit@gnu.org; Sat, 30 Jan 2016 21:49:44 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39640)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPi57-0004kj-Mz
	for gnash-commit@gnu.org; Sat, 30 Jan 2016 21:49:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPi54-00013W-Hf
	for gnash-commit@gnu.org; Sat, 30 Jan 2016 21:49:41 -0500
Received: from [2001:4830:134:6::a] (port=47782 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPi54-00013R-EW
	for gnash-commit@gnu.org; Sat, 30 Jan 2016 21:49:38 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aPi54-00055d-2X; Sun, 31 Jan 2016 02:49:38 +0000
Date: Sun, 31 Jan 2016 02:49:38 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47004
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.166.184 (Savane authenticated user nachanon)
Message-Id: <20160131-094937.sv82809.50502@savannah.gnu.org>
References: <20160129-150526.sv82809.19313@savannah.gnu.org>
In-Reply-To: <20160129-150526.sv82809.19313@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47004] Gnash didn't pass string return value
	"Error" and "SecurityError" from ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Jan 2016 02:49:42 -0000

Follow-up Comment #1, bug #47004 (project gnash):

This problem could be narrowed down to `plugin/npapi/callbacks.cpp`, inside
function `remoteCallback()` around line 707
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/callbacks.cpp?id=e705394a72888a8791497d94a7cf4c78b2e23f02#n702>:

    std::string answer;
    GnashNPVariant parsed = plugin::ExternalInterface::parseXML(data);
    if (!NPVARIANT_IS_NULL(parsed.get())) {
        answer = NPStringToString(NPVARIANT_TO_STRING(parsed.get()));
    }
    if (answer == "Error") {
        NULL_TO_NPVARIANT(*result);
    } else if (answer == "SecurityError") {
        NULL_TO_NPVARIANT(*result);
    } else {
        parsed.copy(*result);
    }


This check doesn't seem appropriate, as:
* It fails when ActionScript's callback legitimately returned a string "Error"
or "SecurityError"; demonstrated by test file.
* Bad things could happen if the return value is both not `null` and is not a
String. (e.g. `NPObject`)

Second one is actually the reason I found this issue in the first place;
this string conversion code crashes when I tried to make
`ExternalInterface::parseXML()` return a full-blown `NPObject` derived
from JavaScript `Object` (a part of bug #32411's fix).

Gnash: Gnash 0.8.11dev (git e705394 29-Jan-2016) NPAPI
Browser: Iceweasel 10.0.12 
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47004>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 31 05:31:58 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aPpIT-0003v4-VN
	for mharc-gnash-commit@gnu.org; Sun, 31 Jan 2016 05:31:57 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPpIR-0003rM-QH
	for gnash-commit@gnu.org; Sun, 31 Jan 2016 05:31:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPpIO-000877-Jz
	for gnash-commit@gnu.org; Sun, 31 Jan 2016 05:31:55 -0500
Received: from [2001:4830:134:6::a] (port=50024 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPpIO-000873-Gy
	for gnash-commit@gnu.org; Sun, 31 Jan 2016 05:31:52 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aPpIO-0006XK-5Z; Sun, 31 Jan 2016 10:31:52 +0000
Date: Sun, 31 Jan 2016 10:31:52 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47029
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.166.184 (Savane authenticated user nachanon)
Message-Id: <20160131-173151.sv82809.82302@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47029] fb-gnash produces segmentation fault on
	exit
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Jan 2016 10:31:57 -0000

URL:
  <http://savannah.gnu.org/bugs/?47029>

                 Summary: fb-gnash produces segmentation fault on exit
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sun 31 Jan 2016 05:31:51 PM ICT
                Category: gui-fb
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a spin-off from bug #46949 (framebuffer console restoration issue)
comment 3 <https://savannah.gnu.org/bugs/?46949#comment3>.

Current FrameBuffer Gnash seems to always produce a segmentation fault on
its exit procedure, with backtrace more or less similar to:

#0  0x00000109 in ?? ()
#1  0xb7701096 in std::_Sp_counted_ptr<gnash::Renderer*,
(__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0xb90d5108) at
/usr/include/c++/4.7/bits/shared_ptr_base.h:293
#2  0xb76d5a08 in
std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
(this=0xb90d5108) at /usr/include/c++/4.7/bits/shared_ptr_base.h:147
#3  0xb76f730e in ~__shared_count (this=0xb90cb844, __in_chrg=<optimized out>)
at /usr/include/c++/4.7/bits/shared_ptr_base.h:558
#4  ~__shared_ptr (this=0xb90cb840, __in_chrg=<optimized out>) at
/usr/include/c++/4.7/bits/shared_ptr_base.h:813
#5  ~shared_ptr (this=0xb90cb840, __in_chrg=<optimized out>) at
/usr/include/c++/4.7/bits/shared_ptr.h:93
#6  gnash::RunResources::~RunResources (this=0xb90cb828, __in_chrg=<optimized
out>) at ../libcore/RunResources.h:53
#7  0xb76f73c9 in std::_Sp_counted_ptr<gnash::RunResources*,
(__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0xb90c9750) at
/usr/include/c++/4.7/bits/shared_ptr_base.h:293
#8  0xb76d5a08 in
std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
(this=0xb90c9750) at /usr/include/c++/4.7/bits/shared_ptr_base.h:147
#9  0xb76f39f7 in ~__shared_count (this=0xbff41f14, __in_chrg=<optimized out>)
at /usr/include/c++/4.7/bits/shared_ptr_base.h:558
#10 ~__shared_ptr (this=0xbff41f10, __in_chrg=<optimized out>) at
/usr/include/c++/4.7/bits/shared_ptr_base.h:813
#11 ~shared_ptr (this=0xbff41f10, __in_chrg=<optimized out>) at
/usr/include/c++/4.7/bits/shared_ptr.h:93
#12 gnash::Player::~Player (this=0xbff41eb0, __in_chrg=<optimized out>) at
Player.cpp:866
#13 0xb76cf328 in playFile (player=..., argc=4, argv=0xbff427c4, filename=...)
at gnash.cpp:92
#14 0xb76d5005 in __call<void, std::basic_string<char, std::char_traits<char>,
std::allocator<char> >&, 0u, 1u, 2u, 3u> (__args=..., this=0xbff422d8) at
/usr/include/c++/4.7/functional:1156
#15 operator()<std::basic_string<char, std::char_traits<char>,
std::allocator<char> >&, void> (this=0xbff422d8) at
/usr/include/c++/4.7/functional:1215
#16 std::for_each<__gnu_cxx::__normal_iterator<std::string*,
std::vector<std::string, std::allocator<std::string> > >, std::_Bind<void
(*(std::reference_wrapper<gnash::Player>, int, char**,
std::_Placeholder<1>))(gnash::Player&, int, char**, std::string const&)>
>(__gnu_cxx::__normal_iterator<std::string*, std::vector<std::string,
std::allocator<std::string> > >, __gnu_cxx::__normal_iterator<std::string*,
std::vector<std::string, std::allocator<std::string> > >, std::_Bind<void
(*(std::reference_wrapper<gnash::Player>, int, char**,
std::_Placeholder<1>))(gnash::Player&, int, char**, std::string const&)>)
(__first=..., __last=..., __f=...) at
/usr/include/c++/4.7/bits/stl_algo.h:4442
#17 0xb76cdbaf in main (argc=4, argv=0xbff427c4) at gnash.cpp:176


The way Gnash exit doesn't seems to significantly change the backtrace. Tested
with:
* `fscommand("quit")` ActionScript code when `set ignoreFSCommand` in
`~/.gnashrc` is `false`
* `--once` command line option
* SIGINT (via Ctrl+C)
* and SIGTERM (via `killall`)

Log output and detailed GDB backtrace from running `singleframe.swf` (from
file #35320 in bug #46308) using `fb-gnash -vv --once singleframe.swf`
are also attached.

This issue is specific to Gnash's FrameBuffer UI.
GTK, Qt4, SDL, and Dump UI are not affected.

Gnash: 0.8.11dev (git e705394 29-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 31 Jan 2016 05:31:51 PM ICT  Name:
singleframe_gnash0.8.11dev-e705394.log  Size: 3kB   By: nachanon
Log output and detailed GDB backtrace from running `fb-gnash -vv --once
singleframe.swf`
<http://savannah.gnu.org/bugs/download.php?file_id=36215>
-------------------------------------------------------
Date: Sun 31 Jan 2016 05:31:51 PM ICT  Name:
singleframe_gnash0.8.11dev-e705394.gdb.log  Size: 15kB   By: nachanon
Log output and detailed GDB backtrace from running `fb-gnash -vv --once
singleframe.swf`
<http://savannah.gnu.org/bugs/download.php?file_id=36216>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47029>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Jan 31 06:10:09 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aPptR-0002HC-9Y
	for mharc-gnash-commit@gnu.org; Sun, 31 Jan 2016 06:10:09 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51382)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPptP-0002Gw-Ik
	for gnash-commit@gnu.org; Sun, 31 Jan 2016 06:10:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPptM-0007hC-Cu
	for gnash-commit@gnu.org; Sun, 31 Jan 2016 06:10:07 -0500
Received: from [2001:4830:134:6::a] (port=52976 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aPptM-0007h5-9s
	for gnash-commit@gnu.org; Sun, 31 Jan 2016 06:10:04 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aPptL-0007UW-5F; Sun, 31 Jan 2016 11:10:03 +0000
Date: Sun, 31 Jan 2016 11:10:03 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 46949
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0
X-Apparently-From: 110.77.166.184 (Savane authenticated user nachanon)
Message-Id: <20160131-181002.sv82809.45233@savannah.gnu.org>
References: <20160122-145202.sv82809.37865@savannah.gnu.org>
	<20160122-170024.sv82809.7063@savannah.gnu.org>
	<20160122-170350.sv82809.76338@savannah.gnu.org>
	<20160122-170615.sv82809.92509@savannah.gnu.org>
	<20160122-171217.sv82809.24993@savannah.gnu.org>
	<20160123-125228.sv82809.12482@savannah.gnu.org>
	<20160123-181242.sv82809.30132@savannah.gnu.org>
	<20160123-204634.sv82809.51923@savannah.gnu.org>
	<20160129-081111.sv27281.18979@savannah.gnu.org>
In-Reply-To: <20160129-081111.sv27281.18979@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #46949] fb-gnash left console in unusable state
	after exiting
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Jan 2016 11:10:08 -0000

Follow-up Comment #7, bug #46949 (project gnash):

Current git version of Framebuffer Gnash now turn console back to text mode
properly when stopped by `fscommand("quit")` ActionScript, `--once`
command line switch, SIGINT (Ctrl+C), and SIGTERM (`killall fb-gnash`).

Screenshot after running `fb-gnash -v secondframeexit12-repaint.swf`:
(Test SWF from file #36046, bug #27981; with `set ignoreFSCommand false` in
`~/.gnashrc`)
http://i.imgur.com/c1vyBWi.png

Screenshot after running `fb-gnash -v --once 12frames.swf`:
http://i.imgur.com/q0vAF8S.png

Screenshot after running `fb-gnash -v 12frames.swf` and pressed Ctrl+C:
http://i.imgur.com/MynEvRE.png

Screenshot after running `fb-gnash -v 12frames.swf` and used `killall
fb-gnash`:
http://i.imgur.com/eyYM83G.png

You'd see that in every case, the console came back to text mode when Gnash
terminated. You'd also see that there's a "Segmentation fault" error shown
at the end of each run too.

Screenshots are attached in `fb-gnash_postrun-roundup.e705394.zip` as a
reference.

This bug could be now marked as fixed.
The segmentation fault problem is filed separately as bug #47029.

Gnash: 0.8.11dev (git e705394 29-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36217)
    _______________________________________________________

Additional Item Attachment:

File name: fb-gnash_postrun-roundup.e705394.zip Size:17 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46949>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



