From MAILER-DAEMON Tue Mar 01 09:20:58 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aalAY-0003UT-Av
	for mharc-gnash-commit@gnu.org; Tue, 01 Mar 2016 09:20:58 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aalAV-0003Ss-Cn
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 09:20:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aalAR-0001W8-Lx
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 09:20:55 -0500
Received: from [2001:4830:134:6::a] (port=59388 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aalAR-0001Vj-G8
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 09:20:51 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aalAR-0008DN-9S; Tue, 01 Mar 2016 14:20:51 +0000
Date: Tue, 01 Mar 2016 14:20:51 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47280
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.162.222 (Savane authenticated user nachanon)
Message-Id: <20160301-212051.sv82809.59059@savannah.gnu.org>
References: <20160227-171328.sv82809.96025@savannah.gnu.org>
	<20160227-172107.sv82809.32015@savannah.gnu.org>
	<20160227-231236.sv82809.80423@savannah.gnu.org>
In-Reply-To: <20160227-231236.sv82809.80423@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47280] Gnash's ExternalInterface does not
	return Number value correctly
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2016 14:20:56 -0000

Follow-up Comment #3, bug #47280 (project gnash):

The problem on JavaScript-calls-Flash return value boils down to how
libgnashplugin parses `<number>` data from player side
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/external.cpp?id=c12c3cf104a095cff9791cdb3cee8bbf4853d5e0#n292>:

        } else if (tag == "<number>") {
            start = end;
            end = xml.find("</number>");
            std::string str = xml.substr(start, end-start);
            if (str.find(".") != std::string::npos) {
                double num = strtod(str.c_str(), nullptr);
                DOUBLE_TO_NPVARIANT(num, value);
            } else {
                int num = strtol(str.c_str(), nullptr, 0);
                INT32_TO_NPVARIANT(num, value);
            }


There are few problem with this:
* It fails when `Infinity`, `-Infinity`, or `NaN` is encountered, as the
plugin would parse it as an integer (and results in zero value).
* It fails when the number is a whole number but is not in `int32_t` range,
e.g. 4294967295.

As I understand, plugin's `ExternalInterface::parseXML()` is used only for
parsing player's answer from JavaScript call (both ExternalInterface
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/callbacks.cpp?id=c12c3cf104a095cff9791cdb3cee8bbf4853d5e0#n702>
and
built-in
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/callbacks.cpp?id=c12c3cf104a095cff9791cdb3cee8bbf4853d5e0#n233>
plugin
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/callbacks.cpp?id=c12c3cf104a095cff9791cdb3cee8bbf4853d5e0#n377>
functions
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/callbacks.cpp?id=c12c3cf104a095cff9791cdb3cee8bbf4853d5e0#n631>),
unconditionally parsing the number as `double`
shouldn't cause any problem, as it is same type as JavaScript's `Number`.

Gnash: 0.8.11dev (git c12c3cf 22-Feb-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47280>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 01 09:27:49 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aalHB-0006Wg-EN
	for mharc-gnash-commit@gnu.org; Tue, 01 Mar 2016 09:27:49 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46218)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aalH9-0006WI-Ut
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 09:27:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aalH6-0004dt-MO
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 09:27:47 -0500
Received: from [2001:4830:134:6::a] (port=60324 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aalH6-0004dp-Iz
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 09:27:44 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aalH6-0008KT-F2; Tue, 01 Mar 2016 14:27:44 +0000
Date: Tue, 01 Mar 2016 14:27:44 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47280
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.162.222 (Savane authenticated user nachanon)
Message-Id: <20160301-212744.sv82809.83712@savannah.gnu.org>
References: <20160227-171328.sv82809.96025@savannah.gnu.org>
	<20160227-172107.sv82809.32015@savannah.gnu.org>
	<20160227-231236.sv82809.80423@savannah.gnu.org>
	<20160301-212051.sv82809.59059@savannah.gnu.org>
In-Reply-To: <20160301-212051.sv82809.59059@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47280] Gnash's ExternalInterface does not
	return Number value correctly
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2016 14:27:49 -0000

Follow-up Comment #4, bug #47280 (project gnash):

The precision problem on Flash-calls-JavaScript return value boils down to
how
libgnashplugin marshall floating point number data
<http://git.savannah.gnu.org/cgit/gnash.git/tree/plugin/npapi/external.cpp?id=c12c3cf104a095cff9791cdb3cee8bbf4853d5e0#n361>:

    if (NPVARIANT_IS_DOUBLE(*value)) {
        double num = NPVARIANT_TO_DOUBLE(*value);
        ss << "<number>" << num << "</number>";
    } else if (NPVARIANT_IS_STRING(*value)) {


This causes precision loss as iostream used only few decimal digits when
printing `double` type to the stream. (To losslessly represent the number,
17 decimal significands were required)

Gnash: 0.8.11dev (git c12c3cf 22-Feb-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47280>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 01 14:36:12 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aaq5c-00034o-Bt
	for mharc-gnash-commit@gnu.org; Tue, 01 Mar 2016 14:36:12 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36144)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aaq5a-00034X-HF
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 14:36:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aaq5X-0001ST-Q7
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 14:36:10 -0500
Received: from [2001:4830:134:6::a] (port=33763 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aaq5X-0001SC-Mz
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 14:36:07 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aaq5X-0006cd-IY; Tue, 01 Mar 2016 19:36:07 +0000
Date: Tue, 01 Mar 2016 19:36:07 +0000
To: Abdel-Rahman <abodyxplay1@gmail.com>, Real Name <zl29ah@gmail.com>,
	gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Abdel-Rahman <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47301
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 197.38.100.51 (Savane authenticated user abogical)
Message-Id: <20160301-193607.sv102846.21585@savannah.gnu.org>
References: <20160228-203548.sv0.65852@savannah.gnu.org>
In-Reply-To: <20160228-203548.sv0.65852@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47301] cannot build against ffmpeg-3.0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2016 19:36:11 -0000

Additional Item Attachment, bug #47301 (project gnash):

File name: pixelformat_gnash.patch        Size:7 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 01 14:37:16 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aaq6e-0003DV-Kf
	for mharc-gnash-commit@gnu.org; Tue, 01 Mar 2016 14:37:16 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36388)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aaq6b-0003Cq-Vy
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 14:37:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aaq6X-0002d4-VL
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 14:37:13 -0500
Received: from [2001:4830:134:6::a] (port=33823 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aaq6X-0002d0-Ry
	for gnash-commit@gnu.org; Tue, 01 Mar 2016 14:37:09 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aaq6X-0006cy-Ko; Tue, 01 Mar 2016 19:37:09 +0000
Date: Tue, 01 Mar 2016 19:37:09 +0000
To: Abdel-Rahman <abodyxplay1@gmail.com>, Real Name <zl29ah@gmail.com>,
	gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Abdel-Rahman <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47301
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 197.38.100.51 (Savane authenticated user abogical)
Message-Id: <20160301-193709.sv102846.47746@savannah.gnu.org>
References: <20160228-203548.sv0.65852@savannah.gnu.org>
	<20160301-193607.sv102846.21585@savannah.gnu.org>
In-Reply-To: <20160301-193607.sv102846.21585@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47301] cannot build against ffmpeg-3.0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2016 19:37:15 -0000

Follow-up Comment #1, bug #47301 (project gnash):

he class and enum names that gnash has used in ffmpeg has been changed since
version 3.0, I attached a patch that would rename those classes and fix them.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Mar 02 02:14:35 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ab0zT-0007Uf-EP
	for mharc-gnash-commit@gnu.org; Wed, 02 Mar 2016 02:14:35 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60869)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ab0zQ-0007TV-Mt
	for gnash-commit@gnu.org; Wed, 02 Mar 2016 02:14:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ab0zL-00087B-Ok
	for gnash-commit@gnu.org; Wed, 02 Mar 2016 02:14:32 -0500
Received: from [2001:4830:134:6::a] (port=54159 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ab0zL-000877-LP
	for gnash-commit@gnu.org; Wed, 02 Mar 2016 02:14:27 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1ab0zK-0004dG-Gx; Wed, 02 Mar 2016 07:14:26 +0000
Date: Wed, 02 Mar 2016 07:14:26 +0000
To: Sandro Santilli <strk@keybit.net>, Abdel-Rahman <abodyxplay1@gmail.com>,
	Real Name <zl29ah@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47301
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160302-081426.sv27281.99387@savannah.gnu.org>
References: <20160228-203548.sv0.65852@savannah.gnu.org>
	<20160301-193607.sv102846.21585@savannah.gnu.org>
	<20160301-193709.sv102846.47746@savannah.gnu.org>
In-Reply-To: <20160301-193709.sv102846.47746@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47301] cannot build against ffmpeg-3.0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Mar 2016 07:14:33 -0000

Update of bug #47301 (project gnash):

             Assigned to:                    None => strk                   

    _______________________________________________________

Follow-up Comment #2:

We need an approach that retains backward compatibility.
One idea would be that, based on ffmpeg version, macros withouth the AV prefix
are mapped to the AV prefixed ones. Ideally in the
libmedia/ffmpeg/ffmpegHeaders.h file, where you'll find more similar mappings.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Mar 02 10:15:34 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ab8Uw-0001wY-7n
	for mharc-gnash-commit@gnu.org; Wed, 02 Mar 2016 10:15:34 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ab8Ut-0001vw-HQ
	for gnash-commit@gnu.org; Wed, 02 Mar 2016 10:15:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ab8Uq-0000jo-BM
	for gnash-commit@gnu.org; Wed, 02 Mar 2016 10:15:31 -0500
Received: from [2001:4830:134:6::a] (port=34859 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ab8Uq-0000jk-8R
	for gnash-commit@gnu.org; Wed, 02 Mar 2016 10:15:28 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1ab8Uo-0006wQ-Ma; Wed, 02 Mar 2016 15:15:26 +0000
Date: Wed, 02 Mar 2016 15:15:26 +0000
To: Sandro Santilli <strk@keybit.net>, Abdel-Rahman <abodyxplay1@gmail.com>,
	Real Name <zl29ah@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Abdel-Rahman <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47301
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 197.38.126.9 (Savane authenticated user abogical)
Message-Id: <20160302-151526.sv102846.12559@savannah.gnu.org>
References: <20160228-203548.sv0.65852@savannah.gnu.org>
	<20160301-193607.sv102846.21585@savannah.gnu.org>
	<20160301-193709.sv102846.47746@savannah.gnu.org>
	<20160302-081426.sv27281.99387@savannah.gnu.org>
In-Reply-To: <20160302-081426.sv27281.99387@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47301] cannot build against ffmpeg-3.0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Mar 2016 15:15:32 -0000

Follow-up Comment #3, bug #47301 (project gnash):

That is a nice idea, I've Implenented what you've said in a new patch I've
attached. The enums will still be renamed for newer version of ffmpeg, but if
it's an old version of ffmpeg, We would define macros that would replace the
new names with older ones.

However, I haven't tested this out yet on older ffmpeg libraries.

(file #36528)
    _______________________________________________________

Additional Item Attachment:

File name: pixfmt_gnash.patch             Size:8 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 03 03:44:56 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abOsS-0006jK-7Q
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 03:44:56 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35072)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abOsP-0006fP-6L
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 03:44:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abOsJ-0007o5-UU
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 03:44:53 -0500
Received: from [2001:4830:134:6::a] (port=60544 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abOsJ-0007nz-S0
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 03:44:47 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1abOsI-0003tW-RS; Thu, 03 Mar 2016 08:44:46 +0000
Date: Thu, 03 Mar 2016 08:44:46 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8916
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160303-094446.sv27281.44067@savannah.gnu.org>
References: <20160222-205720.sv82809.23994@savannah.gnu.org>
	<20160223-092421.sv27281.88326@savannah.gnu.org>
	<20160223-092459.sv27281.15636@savannah.gnu.org>
In-Reply-To: <20160223-092459.sv27281.15636@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8916] Patch to make libgnashplugin return
	real JavaScript object from ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 08:44:54 -0000

Update of patch #8916 (project gnash):

                  Status:                    None => In Progress            
             Assigned to:                 rsavoye => strk                   

    _______________________________________________________

Follow-up Comment #3:

I guess we can just commit this and try it on the field...

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8916>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 03 04:33:23 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abPdL-00056y-7l
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 04:33:23 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44082)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPdJ-00056p-Kt
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:33:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPdG-0003Bm-GH
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:33:21 -0500
Received: from [2001:4830:134:6::a] (port=36460 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPdG-0003Bb-DB
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:33:18 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1abPdF-0004xH-81; Thu, 03 Mar 2016 09:33:17 +0000
Date: Thu, 03 Mar 2016 09:33:17 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8916
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160303-103317.sv27281.18804@savannah.gnu.org>
References: <20160222-205720.sv82809.23994@savannah.gnu.org>
	<20160223-092421.sv27281.88326@savannah.gnu.org>
	<20160223-092459.sv27281.15636@savannah.gnu.org>
	<20160303-094446.sv27281.44067@savannah.gnu.org>
In-Reply-To: <20160303-094446.sv27281.44067@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8916] Patch to make libgnashplugin return
	real JavaScript object from ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 09:33:22 -0000

Update of patch #8916 (project gnash):

                  Status:             In Progress => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #4:

Pushed as commit 765adb072dc4b8407f1936a60c3f2af4aeff2046


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8916>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 03 04:33:25 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abPdN-00058T-BX
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 04:33:25 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44081)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1abPdJ-00056o-KR
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:33:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1abPdD-0003BT-TO
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:33:21 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:54666)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1abPdD-0003BP-Oz
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:33:15 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1abPcx-0002Sa-1Q
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 09:33:05 +0000
Date: Thu, 03 Mar 2016 09:33:03 +0000
Message-Id: <E1abPcx-0002Sa-1Q@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: c12c3cf104a095cff9791cdb3cee8bbf4853d5e0
X-Git-Newrev: 765adb072dc4b8407f1936a60c3f2af4aeff2046
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2268-g765adb0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 09:33:24 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  765adb072dc4b8407f1936a60c3f2af4aeff2046 (commit)
      from  c12c3cf104a095cff9791cdb3cee8bbf4853d5e0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=765adb072dc4b8407f1936a60c3f2af4aeff2046


commit 765adb072dc4b8407f1936a60c3f2af4aeff2046
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Tue Feb 23 09:21:15 2016 +0100

    Unmarshall ActionScript object in plugin's ExternalInterface as a real JavaScript Object.
    
    This fixes plugin's crash in bug #32411.
    See <https://savannah.gnu.org/bugs/?32411>

diff --git a/plugin/npapi/callbacks.cpp b/plugin/npapi/callbacks.cpp
index 9865018..b2c61af 100644
--- a/plugin/npapi/callbacks.cpp
+++ b/plugin/npapi/callbacks.cpp
@@ -230,7 +230,7 @@ IsPlaying (NPObject *npobj, NPIdentifier /* name */, const NPVariant */*args */,
             return false;
         }
 
-        GnashNPVariant value = plugin::ExternalInterface::parseXML(data);
+        GnashNPVariant value = plugin::ExternalInterface::parseXML((GnashPluginScriptObject*)npobj, data);
         if (NPVARIANT_TO_BOOLEAN(value.get()) == true) {
             BOOLEAN_TO_NPVARIANT(true, *result);
         } else {
@@ -374,7 +374,7 @@ PercentLoaded (NPObject *npobj, NPIdentifier /* name */, const NPVariant */*args
             return false;
         }
         
-        GnashNPVariant value = plugin::ExternalInterface::parseXML(data);
+        GnashNPVariant value = plugin::ExternalInterface::parseXML((GnashPluginScriptObject*)npobj, data);
         if (NPVARIANT_IS_INT32(value.get())) {
             INT32_TO_NPVARIANT(NPVARIANT_TO_INT32(value.get()), *result);
         } else {
@@ -628,7 +628,7 @@ TotalFrames (NPObject *npobj, NPIdentifier /* name */, const NPVariant */*args *
             return false;
         }
 
-        GnashNPVariant value = plugin::ExternalInterface::parseXML(data);
+        GnashNPVariant value = plugin::ExternalInterface::parseXML((GnashPluginScriptObject*)npobj, data);
         if (NPVARIANT_IS_INT32(value.get())) {
             value.copy(*result);
         } else {
@@ -699,7 +699,7 @@ remoteCallback (NPObject *npobj, NPIdentifier name, const NPVariant *args,
         return false;
     }
 
-    GnashNPVariant parsed = plugin::ExternalInterface::parseXML(data);
+    GnashNPVariant parsed = plugin::ExternalInterface::parseXML((GnashPluginScriptObject*)npobj, data);
     parsed.copy(*result);
 
     // printNPVariant(&parsed.get());
diff --git a/plugin/npapi/external.cpp b/plugin/npapi/external.cpp
index a1c199e..1183fba 100644
--- a/plugin/npapi/external.cpp
+++ b/plugin/npapi/external.cpp
@@ -1,5 +1,5 @@
 // 
-//   Copyright (C) 2010, 2011, 2012 Free Software Foundation, Inc
+//   Copyright (C) 2010, 2011, 2012, 2014, 2016 Free Software Foundation, Inc
 // 
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
@@ -200,7 +200,7 @@ ExternalInterface::makeObject (std::map<std::string, std::string> &args)
 //      </arguments>
 // </invoke>
 std::shared_ptr<ExternalInterface::invoke_t>
-ExternalInterface::parseInvoke(const std::string &xml)
+ExternalInterface::parseInvoke(GnashPluginScriptObject *scriptobj, const std::string &xml)
 {
     std::shared_ptr<ExternalInterface::invoke_t> invoke;
     if (xml.empty()) {
@@ -254,7 +254,7 @@ ExternalInterface::parseInvoke(const std::string &xml)
             end   = xml.find("</invoke");
             if (start != std::string::npos && end != std::string::npos) {
                     tag   = xml.substr(start, end-start);
-                    invoke->args = parseArguments(tag);
+                    invoke->args = parseArguments(scriptobj, tag);
                 }
         }
     }
@@ -263,7 +263,7 @@ ExternalInterface::parseInvoke(const std::string &xml)
 }
 
 GnashNPVariant 
-ExternalInterface::parseXML(const std::string &xml)
+ExternalInterface::parseXML(GnashPluginScriptObject *scriptobj, const std::string &xml)
 {
     NPVariant value;
     NULL_TO_NPVARIANT(value);
@@ -318,7 +318,7 @@ ExternalInterface::parseXML(const std::string &xml)
             end = xml.find("</array");
             if ( end != std::string::npos )  {
               std::string str = xml.substr(start, end-start);
-              std::map<std::string, GnashNPVariant> props = parseProperties(str);
+              std::map<std::string, GnashNPVariant> props = parseProperties(scriptobj, str);
               std::map<std::string, GnashNPVariant>::iterator it;
               for (it=props.begin(); it != props.end(); ++it) {
                   NPIdentifier id = NPN_GetStringIdentifier(it->first.c_str());
@@ -328,20 +328,39 @@ ExternalInterface::parseXML(const std::string &xml)
               OBJECT_TO_NPVARIANT(obj, value);
             }
         } else if (tag == "<object>") {
+            NPObject *jswindow;
+            NPObject *obj;
+            NPVariant objvar;
+
             start = end;
             end = xml.find("</object");
-            if ( end != std::string::npos )  {
-              NPObject *obj =  (NPObject *)NPN_MemAlloc(sizeof(NPObject));
-              obj->referenceCount = 1;
+            while ( end != std::string::npos )  {
+              // To create a new JavaScript Object, we call JavaScript's
+              // window.Object() method and use the returned NPObject.
+              // Then we assign members according to the received XML data.
+              if (NPN_GetValue(scriptobj->nppinstance, NPNVWindowNPObject,
+                               &jswindow) != NPERR_NO_ERROR) {
+                  break;
+              }
+              if (!NPN_Invoke(scriptobj->nppinstance, jswindow,
+                              NPN_GetStringIdentifier("Object"),
+                              NULL, 0, &objvar)) {
+                  NPN_ReleaseObject(jswindow);
+                  break;
+              }
+              obj = NPVARIANT_TO_OBJECT(objvar);
+
               std::string str = xml.substr(start, end-start);
-              std::map<std::string, GnashNPVariant> props = parseProperties(str);
+              std::map<std::string, GnashNPVariant> props = parseProperties(scriptobj, str);
               std::map<std::string, GnashNPVariant>::iterator it;
               for (it=props.begin(); it != props.end(); ++it) {
                   NPIdentifier id = NPN_GetStringIdentifier(it->first.c_str());
                   GnashNPVariant& value = it->second;
-                  NPN_SetProperty(nullptr, obj, id, &value.get());
+                  NPN_SetProperty(scriptobj->nppinstance, obj, id, &value.get());
               }
+              NPN_ReleaseObject(jswindow);
               OBJECT_TO_NPVARIANT(obj, value);
+              break;
             }
         }
     }
@@ -384,7 +403,7 @@ ExternalInterface::convertNPVariant (const NPVariant *value)
 }
 
 std::map<std::string, GnashNPVariant>
-ExternalInterface::parseProperties(const std::string &xml)
+ExternalInterface::parseProperties(GnashPluginScriptObject *scriptobj, const std::string &xml)
 {
     std::map<std::string, GnashNPVariant> props;
 
@@ -404,7 +423,7 @@ ExternalInterface::parseProperties(const std::string &xml)
         start = end + 2;
         end = xml.find("</property>", start) ;
         std::string data = xml.substr(start, end-start);
-        props[id] = parseXML(data);
+        props[id] = parseXML(scriptobj, data);
         start = xml.find(" id=", end);
     }
 
@@ -412,7 +431,7 @@ ExternalInterface::parseProperties(const std::string &xml)
 }
 
 std::vector<GnashNPVariant>
-ExternalInterface::parseArguments(const std::string &xml)
+ExternalInterface::parseArguments(GnashPluginScriptObject *scriptobj, const std::string &xml)
 {
     std::vector<GnashNPVariant> args;
 
@@ -437,7 +456,7 @@ ExternalInterface::parseArguments(const std::string &xml)
         if (data == "</arguments>") {
             break;
         }
-        args.push_back(parseXML(sub));
+        args.push_back(parseXML(scriptobj, sub));
         data.erase(0, end);
     }
 
diff --git a/plugin/npapi/external.h b/plugin/npapi/external.h
index 7a0aa67..6031bda 100644
--- a/plugin/npapi/external.h
+++ b/plugin/npapi/external.h
@@ -1,5 +1,5 @@
 // 
-//   Copyright (C) 2010, 2011, 2012 Free Software Foundation, Inc
+//   Copyright (C) 2010, 2011, 2012, 2014, 2016 Free Software Foundation, Inc
 // 
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
@@ -31,7 +31,7 @@
 #include "npapi.h"
 #include "npruntime.h"
 
-#include "GnashNPVariant.h"
+#include "pluginScriptObject.h"
 
 namespace gnash {
 
@@ -61,11 +61,11 @@ struct ExternalInterface
     static std::string makeArray (std::vector<std::string> &args);
     static std::string makeObject (std::map<std::string, std::string> &args);
     
-    static GnashNPVariant parseXML(const std::string &xml);
-    static std::shared_ptr<invoke_t> parseInvoke(const std::string &xml);
+    static GnashNPVariant parseXML(GnashPluginScriptObject *scriptobj, const std::string &xml);
+    static std::shared_ptr<invoke_t> parseInvoke(GnashPluginScriptObject *scriptobj, const std::string &xml);
     
-    static std::map<std::string, GnashNPVariant> parseProperties(const std::string &xml);
-    static std::vector<GnashNPVariant> parseArguments(const std::string &xml);
+    static std::map<std::string, GnashNPVariant> parseProperties(GnashPluginScriptObject *scriptobj, const std::string &xml);
+    static std::vector<GnashNPVariant> parseArguments(GnashPluginScriptObject *scriptobj, const std::string &xml);
     static std::string convertNPVariant (const NPVariant *npv);
 };
 
diff --git a/plugin/npapi/plugin.cpp b/plugin/npapi/plugin.cpp
index c0d5b2b..96585e6 100644
--- a/plugin/npapi/plugin.cpp
+++ b/plugin/npapi/plugin.cpp
@@ -821,7 +821,7 @@ nsPluginInstance::processPlayerRequest()
         // Extract a message from the packet
         std::string msg = packet.substr(0, pos + term.size());
         std::shared_ptr<plugin::ExternalInterface::invoke_t> invoke =
-            plugin::ExternalInterface::parseInvoke(msg);
+            plugin::ExternalInterface::parseInvoke(_scriptObject, msg);
 
         // drop the parsed message from the packet
         packet.erase(0, msg.size());
diff --git a/plugin/npapi/pluginScriptObject.cpp b/plugin/npapi/pluginScriptObject.cpp
index 3b599c8..59e8a06 100644
--- a/plugin/npapi/pluginScriptObject.cpp
+++ b/plugin/npapi/pluginScriptObject.cpp
@@ -1,5 +1,5 @@
 // 
-//   Copyright (C) 2010, 2011, 2012 Free Software Foundation, Inc
+//   Copyright (C) 2010, 2011, 2012, 2014, 2016 Free Software Foundation, Inc
 // 
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
@@ -125,7 +125,7 @@ GnashPluginScriptObject::initializeIdentifiers()
 {
     // log_debug("initializeIdentifiers");
 
-//    NPN_Status(_nppinstance, __FUNCTION__);
+//    NPN_Status(nppinstance, __FUNCTION__);
     
 //    http://www.adobe.com/support/flash/publishexport/scriptingwithflash/scriptingwithflash_04.html
     
@@ -247,7 +247,7 @@ GnashPluginScriptObject::initializeIdentifiers()
 
 // Constructor
 GnashPluginScriptObject::GnashPluginScriptObject()
-    : _nppinstance (nullptr),
+    : nppinstance (nullptr),
       _controlfd(-1),
       _hostfd(-1)
 {
@@ -259,7 +259,7 @@ GnashPluginScriptObject::GnashPluginScriptObject()
 
 // Constructor
 GnashPluginScriptObject::GnashPluginScriptObject(NPP npp)
-    : _nppinstance (npp),
+    : nppinstance (npp),
       _controlfd(-1),
       _hostfd(-1)
 {
@@ -519,7 +519,7 @@ GnashPluginScriptObject::Invoke(NPObject */* npobj */, NPIdentifier name,
 
     return false;
     
-//    return NPN_Invoke(_nppinstance, this, name, args, argCount, result);
+//    return NPN_Invoke(nppinstance, this, name, args, argCount, result);
 }
 
 bool
@@ -621,7 +621,7 @@ GnashPluginScriptObject::GetVariable(const std::string &name)
         return GnashNPVariant();
     }
 
-    GnashNPVariant parsed = plugin::ExternalInterface::parseXML(data);
+    GnashNPVariant parsed = plugin::ExternalInterface::parseXML(this, data);
 
     printNPVariant(&parsed.get());
     
diff --git a/plugin/npapi/pluginScriptObject.h b/plugin/npapi/pluginScriptObject.h
index 2a8b7aa..7c45091 100644
--- a/plugin/npapi/pluginScriptObject.h
+++ b/plugin/npapi/pluginScriptObject.h
@@ -1,5 +1,5 @@
 // 
-//   Copyright (C) 2010, 2011, 2012 Free Software Foundation, Inc
+//   Copyright (C) 2010, 2011, 2012, 2016 Free Software Foundation, Inc
 // 
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
@@ -138,6 +138,10 @@ public:
     void AddProperty(const std::string &name, double num);
     void AddProperty(const std::string &name, int num);
 
+    /// Plugin instance object
+    // nppinstance->pdata should be the nsPluginInstance once NPP_New() is finished.
+    NPP nppinstance;
+
 protected:
     // Internal functions for the API
     void Deallocate();
@@ -155,10 +159,7 @@ protected:
 
 private:
     void initializeIdentifiers();
-    void setInstance(NPP inst) { _nppinstance = inst; };
-    
-    // _nppinstance->pdata should be the nsPluginInstance once NPP_New() is finished.
-    NPP _nppinstance;
+    void setInstance(NPP inst) { nppinstance = inst; };
     
     std::map<NPIdentifier, GnashNPVariant> _properties;
     std::map<NPIdentifier, NPInvokeFunctionPtr> _methods;
diff --git a/plugin/npapi/test.cpp b/plugin/npapi/test.cpp
index 1eb2367..21d4ce5 100644
--- a/plugin/npapi/test.cpp
+++ b/plugin/npapi/test.cpp
@@ -1,5 +1,5 @@
 // 
-//   Copyright (C) 2010, 2011, 2012 Free Software Foundation, Inc
+//   Copyright (C) 2010, 2011, 2012, 2014, 2016 Free Software Foundation, Inc
 // 
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
@@ -166,7 +166,7 @@ main(int , char **)
     // Parsing tests
     //
     xml = "<string>Hello World!</string>";
-    GnashNPVariant np = plugin::ExternalInterface::parseXML(xml);
+    GnashNPVariant np = plugin::ExternalInterface::parseXML(nullptr, xml);
     std::string data = NPStringToString(NPVARIANT_TO_STRING(np.get()));
     if (NPVARIANT_IS_STRING(np.get()) &&
         (data == "Hello World!")) {
@@ -176,7 +176,7 @@ main(int , char **)
     }
 
     xml = "<number>123.456</number>";
-    np = plugin::ExternalInterface::parseXML(xml);
+    np = plugin::ExternalInterface::parseXML(nullptr, xml);
     double num = NPVARIANT_TO_DOUBLE(np.get());
     if (NPVARIANT_IS_DOUBLE(np.get()) &&
         (num == 123.456)) {
@@ -186,7 +186,7 @@ main(int , char **)
     }
 
     xml = "<number>78</number>";
-    np = plugin::ExternalInterface::parseXML(xml);
+    np = plugin::ExternalInterface::parseXML(nullptr, xml);
     int inum = NPVARIANT_TO_INT32(np.get());
     if (NPVARIANT_IS_INT32(np.get()) &&
         (inum == 78)) {
@@ -196,7 +196,7 @@ main(int , char **)
     }
 
     xml = "<true/>";
-    np = plugin::ExternalInterface::parseXML(xml);
+    np = plugin::ExternalInterface::parseXML(nullptr, xml);
     bool flag = NPVARIANT_TO_BOOLEAN(np.get());
     if (NPVARIANT_IS_BOOLEAN(np.get()) &&
         (flag == true)) {
@@ -206,7 +206,7 @@ main(int , char **)
     }
 
     xml = "<false/>";
-    np = plugin::ExternalInterface::parseXML(xml);
+    np = plugin::ExternalInterface::parseXML(nullptr, xml);
     flag = NPVARIANT_TO_BOOLEAN(np.get());
     if (NPVARIANT_IS_BOOLEAN(np.get()) &&
         (flag == false)) {
@@ -216,7 +216,7 @@ main(int , char **)
     }
 
     xml = "<null/>";
-    np = plugin::ExternalInterface::parseXML(xml);
+    np = plugin::ExternalInterface::parseXML(nullptr, xml);
     if (NPVARIANT_IS_NULL(np.get())) {
         runtest.pass("plugin::ExternalInterface::parseXML(null)");
     } else {
@@ -224,7 +224,7 @@ main(int , char **)
     }
 
     xml = "<void/>";
-    np = plugin::ExternalInterface::parseXML(xml);
+    np = plugin::ExternalInterface::parseXML(nullptr, xml);
     if (NPVARIANT_IS_VOID(np.get())) {
         runtest.pass("plugin::ExternalInterface::parseXML(void)");
     } else {
@@ -232,7 +232,7 @@ main(int , char **)
     }
 
     xml = "<property id=\"0\"><string>foobar</string></property><property id=\"1\"><number>12.34</number></property><property id=\"2\"><number>56</number></property>";
-    std::map<std::string, GnashNPVariant> props = plugin::ExternalInterface::parseProperties(xml);
+    std::map<std::string, GnashNPVariant> props = plugin::ExternalInterface::parseProperties(nullptr, xml);
     np = props["0"];
     data = NPStringToString(NPVARIANT_TO_STRING(np.get()));
     if ((props.size() == 3) && (data == "foobar")) {
@@ -241,13 +241,15 @@ main(int , char **)
         runtest.fail("plugin::ExternalInterface::parseProperties()");
     }
     
+#if 0
     xml = "<object><property id=\"test1\"><string>foobar</string></property><property id=\"test2\"><number>12.34</number></property><property id=\"test3\"><number>56</number></property></object>";
-    np = plugin::ExternalInterface::parseXML(xml);
+    np = plugin::ExternalInterface::parseXML(nullptr, xml);
     if (NPVARIANT_IS_OBJECT(np.get())) {
         runtest.pass("plugin::ExternalInterface::parseXML(object)");
     } else {
         runtest.fail("plugin::ExternalInterface::parseXML(object)");
     }
+#endif
     
     std::vector<std::string> iargs;
     str = plugin::ExternalInterface::makeString("barfoo");
@@ -267,7 +269,7 @@ main(int , char **)
     }
     
     xml = "<arguments><string>barfoo</string><number>135.78</number><number>89</number></arguments>";
-    std::vector<GnashNPVariant> arguments = plugin::ExternalInterface::parseArguments(xml);
+    std::vector<GnashNPVariant> arguments = plugin::ExternalInterface::parseArguments(nullptr, xml);
     np = arguments[0];
     str = NPStringToString(NPVARIANT_TO_STRING(np.get()));
     double dub = NPVARIANT_TO_DOUBLE(arguments[1].get());
@@ -281,7 +283,7 @@ main(int , char **)
 
     // Parse an invoke message
     xml = "<invoke name=\"barbyfoo\" returntype=\"xml\"><arguments><string>barfoo</string><number>135.78</number></arguments></invoke>";
-    std::shared_ptr<plugin::ExternalInterface::invoke_t> invoke ( plugin::ExternalInterface::parseInvoke(xml) );
+    std::shared_ptr<plugin::ExternalInterface::invoke_t> invoke ( plugin::ExternalInterface::parseInvoke(nullptr, xml) );
     str = NPStringToString(NPVARIANT_TO_STRING(invoke->args[0].get()));
     if ((invoke->name == "barbyfoo") && (invoke->type == "xml")
         && (NPVARIANT_IS_STRING(invoke->args[0].get()))
@@ -296,7 +298,7 @@ main(int , char **)
 
     // Test for bug #31766
     xml = "<invoke name=\"reportFlashTiming\" returntype=\"xml\"><arguments><string>reportFlashTiming</string><object><property id=\"5\"><number>1297286708921</number></property><property id=\"4\"><string>vr</string></p";
-    invoke = plugin::ExternalInterface::parseInvoke(xml);
+    invoke = plugin::ExternalInterface::parseInvoke(nullptr, xml);
     if ((invoke->name == "reportFlashTiming") && (invoke->type == "xml")
         && invoke->args.empty())
     {
@@ -307,7 +309,7 @@ main(int , char **)
 
 
     xml = "<invoke name=\"reportFlashTiming\" returntype=\"xml\"><arguments><string>reportFlashTiming</string><object><property id=\"5\"><number>1297326407594</number></property><property id=\"4\"><string>vr</string></property><property id=\"3\"><number>1297326407147</number></property><property id=\"2\"><string>gv</string></property><property id=\"1\"><number>1297326406281</number></property><property id=\"0\"><string>fs</string></property></object><string>34</string><number>2</number><string>AASb6VeOkQtvnu_8</string><string>0</string><string>LNX%2010%2C1%2C999%2C0</string><string>Gnash%20GNU%2FLinux</string></arguments></invoke>";
-    invoke = plugin::ExternalInterface::parseInvoke(xml);
+    invoke = plugin::ExternalInterface::parseInvoke(nullptr, xml);
     check_equals (invoke->name, "reportFlashTiming");
     check_equals (invoke->type, "xml");
     xcheck_equals (invoke->args.size(), 8);
@@ -345,7 +347,7 @@ main(int , char **)
 
     {
       xml = "<object><property id=\"5\">";
-      GnashNPVariant v = plugin::ExternalInterface::parseXML(xml);
+      GnashNPVariant v = plugin::ExternalInterface::parseXML(nullptr, xml);
       check(NPVARIANT_IS_NULL(v.get()));
     }
 
@@ -454,6 +456,19 @@ NPN_HasProperty(NPP , NPObject* , NPIdentifier name)
     return false;
 }
 
+NPError
+NPN_GetValue(NPP, NPNVariable, void*)
+{
+    return NPERR_GENERIC_ERROR;
+}
+
+bool
+NPN_Invoke(NPP, NPObject*, NPIdentifier, const NPVariant*, uint32_t,
+           NPVariant*)
+{
+    return false;
+}
+
 void
 NPN_ReleaseVariantValue(NPVariant *variant)
 {

-----------------------------------------------------------------------

Summary of changes:
 plugin/npapi/callbacks.cpp          |    8 +++---
 plugin/npapi/external.cpp           |   47 ++++++++++++++++++++++++----------
 plugin/npapi/external.h             |   12 ++++----
 plugin/npapi/plugin.cpp             |    2 +-
 plugin/npapi/pluginScriptObject.cpp |   12 ++++----
 plugin/npapi/pluginScriptObject.h   |   11 ++++---
 plugin/npapi/test.cpp               |   45 ++++++++++++++++++++++-----------
 7 files changed, 86 insertions(+), 51 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Thu Mar 03 04:34:12 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abPe8-0005bA-Kl
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 04:34:12 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44260)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPe1-0005Xc-3y
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:34:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPdx-0003IX-Tv
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:34:05 -0500
Received: from [2001:4830:134:6::a] (port=36515 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPdx-0003IT-Qm
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:34:01 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1abPdo-0004xY-3t; Thu, 03 Mar 2016 09:33:52 +0000
Date: Thu, 03 Mar 2016 09:33:52 +0000
To: Sandro Santilli <strk@keybit.net>, Rob Savoye <rob@welcomehome.org>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 32411
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160303-103351.sv27281.85886@savannah.gnu.org>
References: <20110210-101655.sv27281.26203@savannah.gnu.org>
	<20110305-163550.sv48477.58410@savannah.gnu.org>
	<20110305-083806.sv178.96135@savannah.gnu.org>
	<20110305-173739.sv48477.39395@savannah.gnu.org>
	<20110305-094138.sv178.98630@savannah.gnu.org>
	<20110305-174352.sv60230.66725@savannah.gnu.org>
	<20110305-095311.sv178.37635@savannah.gnu.org>
	<20110305-180604.sv48477.39870@savannah.gnu.org>
	<20110305-101517.sv178.56093@savannah.gnu.org>
	<20110305-183009.sv48477.87700@savannah.gnu.org>
	<20110305-103540.sv178.87326@savannah.gnu.org>
	<20110305-213931.sv27281.8825@savannah.gnu.org>
	<20160107-002427.sv82809.28725@savannah.gnu.org>
	<20160107-002941.sv82809.31437@savannah.gnu.org>
	<20160107-003238.sv82809.48271@savannah.gnu.org>
	<20160125-202329.sv82809.45439@savannah.gnu.org>
	<20160128-193429.sv82809.89701@savannah.gnu.org>
	<20160128-193858.sv82809.92335@savannah.gnu.org>
	<20160202-125234.sv82809.30410@savannah.gnu.org>
	<20160202-133959.sv82809.81821@savannah.gnu.org>
	<20160202-212605.sv82809.8411@savannah.gnu.org>
	<20160202-220515.sv82809.3824@savannah.gnu.org>
	<20160202-220846.sv82809.24247@savannah.gnu.org>
	<20160215-113832.sv27281.1014@savannah.gnu.org>
	<20160222-210416.sv82809.32819@savannah.gnu.org>
	<20160222-211116.sv82809.61887@savannah.gnu.org>
	<20160222-211307.sv82809.88299@savannah.gnu.org>
	<20160222-212721.sv82809.36416@savannah.gnu.org>
	<20160223-091846.sv27281.96331@savannah.gnu.org>
	<20160223-102823.sv27281.52200@savannah.gnu.org>
In-Reply-To: <20160223-102823.sv27281.52200@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #32411] ExternalInterface XML parser fails with
	nested tags
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 09:34:11 -0000

Update of bug #32411 (project gnash):

                  Status:               Postponed => Ready For Test         
             Assigned to:                    None => strk                   

    _______________________________________________________

Follow-up Comment #27:

patch #8916 committed, looking forward for tests

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?32411>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 03 04:47:56 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abPrQ-0000de-O2
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 04:47:56 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48952)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1abPrM-0000X2-Uf
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:47:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1abPrL-0007AZ-9r
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:47:52 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:54915)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1abPrL-0007AV-5n
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:47:51 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1abPqj-0004f5-Fq
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 09:47:44 +0000
Date: Thu, 03 Mar 2016 09:47:13 +0000
Message-Id: <E1abPqj-0004f5-Fq@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 765adb072dc4b8407f1936a60c3f2af4aeff2046
X-Git-Newrev: 9229f6fa59061eb930179c6f6a616be541d1139f
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2269-g9229f6f
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 09:47:54 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  9229f6fa59061eb930179c6f6a616be541d1139f (commit)
      from  765adb072dc4b8407f1936a60c3f2af4aeff2046 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=9229f6fa59061eb930179c6f6a616be541d1139f


commit 9229f6fa59061eb930179c6f6a616be541d1139f
Author: Sandro Santilli <strk@keybit.net>
Date:   Thu Mar 3 10:44:48 2016 +0100

    Add support for building against ffmpeg-3.0
    
    Patch by Abdel-Rahman, see https://savannah.gnu.org/bugs/?47301
    
    Tested against libavcodec/libavformat 53

diff --git a/libmedia/ffmpeg/VideoConverterFfmpeg.cpp b/libmedia/ffmpeg/VideoConverterFfmpeg.cpp
index 74aa55f..da11e5d 100644
--- a/libmedia/ffmpeg/VideoConverterFfmpeg.cpp
+++ b/libmedia/ffmpeg/VideoConverterFfmpeg.cpp
@@ -57,7 +57,7 @@ private:
 
 // The lookup table in this function is adapted from chroma.c from the VLC
 // codebase; its license permits distribution under GPLv3 and later.
-PixelFormat
+AVPixelFormat
 fourcc_to_ffmpeg(ImgBuf::Type4CC code)
 {
 
@@ -68,40 +68,40 @@ fourcc_to_ffmpeg(ImgBuf::Type4CC code)
     static const struct
     {
         ImgBuf::Type4CC  fourcc;
-        PixelFormat ffmpegcode;
+        AVPixelFormat ffmpegcode;
     } pixfmt_table[] =
     {
         // Planar YUV formats
-        {GNASH_FOURCC('I','4','4','4'), PIX_FMT_YUV444P},
-        {GNASH_FOURCC('J','4','4','4'), PIX_FMT_YUVJ444P},
+        {GNASH_FOURCC('I','4','4','4'), AV_PIX_FMT_YUV444P},
+        {GNASH_FOURCC('J','4','4','4'), AV_PIX_FMT_YUVJ444P},
 
 #if LIBAVUTIL_VERSION_INT >= ((49<<16)+(5<<8)+0)
-        {GNASH_FOURCC('I','4','4','0'), PIX_FMT_YUV440P},
-        {GNASH_FOURCC('J','4','4','0'), PIX_FMT_YUVJ440P},
+        {GNASH_FOURCC('I','4','4','0'), AV_PIX_FMT_YUV440P},
+        {GNASH_FOURCC('J','4','4','0'), AV_PIX_FMT_YUVJ440P},
 #endif
 
-        {GNASH_FOURCC('I','4','2','2'), PIX_FMT_YUV422P},
-        {GNASH_FOURCC('J','4','2','2'), PIX_FMT_YUVJ422P},
+        {GNASH_FOURCC('I','4','2','2'), AV_PIX_FMT_YUV422P},
+        {GNASH_FOURCC('J','4','2','2'), AV_PIX_FMT_YUVJ422P},
 
-        {GNASH_FOURCC('I','4','2','0'), PIX_FMT_YUV420P},
-        {GNASH_FOURCC('Y','V','1','2'), PIX_FMT_YUV420P},
-        {GNASH_FOURCC('I','Y','U','V'), PIX_FMT_YUV420P},
-        {GNASH_FOURCC('J','4','2','0'), PIX_FMT_YUVJ420P},
-        {GNASH_FOURCC('I','4','1','1'), PIX_FMT_YUV411P},
-        {GNASH_FOURCC('I','4','1','0'), PIX_FMT_YUV410P},
-        {GNASH_FOURCC('Y','V','U','9'), PIX_FMT_YUV410P},
+        {GNASH_FOURCC('I','4','2','0'), AV_PIX_FMT_YUV420P},
+        {GNASH_FOURCC('Y','V','1','2'), AV_PIX_FMT_YUV420P},
+        {GNASH_FOURCC('I','Y','U','V'), AV_PIX_FMT_YUV420P},
+        {GNASH_FOURCC('J','4','2','0'), AV_PIX_FMT_YUVJ420P},
+        {GNASH_FOURCC('I','4','1','1'), AV_PIX_FMT_YUV411P},
+        {GNASH_FOURCC('I','4','1','0'), AV_PIX_FMT_YUV410P},
+        {GNASH_FOURCC('Y','V','U','9'), AV_PIX_FMT_YUV410P},
 
 #if LIBAVUTIL_VERSION_INT >= ((49<<16)+(0<<8)+1)
-        {GNASH_FOURCC('N','V','1','2'), PIX_FMT_NV12},
-        {GNASH_FOURCC('N','V','2','1'), PIX_FMT_NV21},
+        {GNASH_FOURCC('N','V','1','2'), AV_PIX_FMT_NV12},
+        {GNASH_FOURCC('N','V','2','1'), AV_PIX_FMT_NV21},
 #endif
 
-        {GNASH_FOURCC('Y','U','Y','2'), PIX_FMT_YUYV422},
-        {GNASH_FOURCC('Y','U','Y','V'), PIX_FMT_YUYV422},
-        {GNASH_FOURCC('U','Y','V','Y'), PIX_FMT_UYVY422},
-        {GNASH_FOURCC('Y','4','1','1'), PIX_FMT_UYYVYY411},
+        {GNASH_FOURCC('Y','U','Y','2'), AV_PIX_FMT_YUYV422},
+        {GNASH_FOURCC('Y','U','Y','V'), AV_PIX_FMT_YUYV422},
+        {GNASH_FOURCC('U','Y','V','Y'), AV_PIX_FMT_UYVY422},
+        {GNASH_FOURCC('Y','4','1','1'), AV_PIX_FMT_UYYVYY411},
 
-        { 0, PIX_FMT_NONE}
+        { 0, AV_PIX_FMT_NONE}
     };
 #undef GNASH_FOURCC
 
@@ -112,13 +112,13 @@ fourcc_to_ffmpeg(ImgBuf::Type4CC code)
         }
     }
    
-    return PIX_FMT_NONE;
+    return AV_PIX_FMT_NONE;
 }
 
 VideoConverterFfmpeg::VideoConverterFfmpeg(ImgBuf::Type4CC srcFormat, ImgBuf::Type4CC dstFormat)
     : VideoConverter(srcFormat, dstFormat)
 {
-     if(fourcc_to_ffmpeg(_dst_fmt) == PIX_FMT_NONE) {
+     if(fourcc_to_ffmpeg(_dst_fmt) == AV_PIX_FMT_NONE) {
          throw MediaException(_("VideoConverterFfmpeg cannot convert to the "
                               "requested format"));
      }
@@ -138,9 +138,9 @@ VideoConverterFfmpeg::convert(const ImgBuf& src)
     const int width = src.width;
     const int height = src.height;
 
-    PixelFormat dst_pixFmt = fourcc_to_ffmpeg(_dst_fmt);
-    assert(dst_pixFmt != PIX_FMT_NONE);
-    PixelFormat src_pixFmt = PIX_FMT_RGB24;
+    AVPixelFormat dst_pixFmt = fourcc_to_ffmpeg(_dst_fmt);
+    assert(dst_pixFmt != AV_PIX_FMT_NONE);
+    AVPixelFormat src_pixFmt = AV_PIX_FMT_RGB24;
     
 #ifdef HAVE_SWSCALE_H
 
diff --git a/libmedia/ffmpeg/VideoDecoderFfmpeg.cpp b/libmedia/ffmpeg/VideoDecoderFfmpeg.cpp
index 20d49b9..caa0377 100644
--- a/libmedia/ffmpeg/VideoDecoderFfmpeg.cpp
+++ b/libmedia/ffmpeg/VideoDecoderFfmpeg.cpp
@@ -51,7 +51,7 @@ namespace {
     void set_vaapi_context(AVCodecContext* avctx, VaapiContextFfmpeg* vactx);
     void clear_vaapi_context(AVCodecContext* avctx);
     void reset_context(AVCodecContext* avctx, VaapiContextFfmpeg* vactx = nullptr);
-    PixelFormat get_format(AVCodecContext* avctx, const PixelFormat* fmt);
+    AVPixelFormat get_format(AVCodecContext* avctx, const AVPixelFormat* fmt);
 #if LIBAVCODEC_VERSION_MAJOR >= 55
     int get_buffer(AVCodecContext* avctx, AVFrame* pic, int flags);
 #else
@@ -251,16 +251,16 @@ VideoDecoderFfmpeg::frameToImage(AVCodecContext* srcCtx,
                                  const AVFrame& srcFrameRef)
 {
     const AVFrame *srcFrame = &srcFrameRef;
-    PixelFormat srcPixFmt = srcCtx->pix_fmt;
+    AVPixelFormat srcPixFmt = srcCtx->pix_fmt;
 
     const int width = srcCtx->width;
     const int height = srcCtx->height;
 
 #ifdef FFMPEG_VP6A
-    PixelFormat pixFmt = (srcCtx->codec->id == AV_CODEC_ID_VP6A) ?
-        PIX_FMT_RGBA : PIX_FMT_RGB24;
+    AVPixelFormat pixFmt = (srcCtx->codec->id == AV_CODEC_ID_VP6A) ?
+        AV_PIX_FMT_RGBA : AV_PIX_FMT_RGB24;
 #else 
-    PixelFormat pixFmt = PIX_FMT_RGB24;
+    AVPixelFormat pixFmt = AV_PIX_FMT_RGB24;
 #endif 
 
     std::unique_ptr<image::GnashImage> im;
@@ -306,10 +306,10 @@ VideoDecoderFfmpeg::frameToImage(AVCodecContext* srcCtx,
 
     switch (pixFmt)
     {
-        case PIX_FMT_RGBA:
+        case AV_PIX_FMT_RGBA:
             im.reset(new image::ImageRGBA(width, height));
             break;
-        case PIX_FMT_RGB24:
+        case AV_PIX_FMT_RGB24:
             im.reset(new image::ImageRGB(width, height));
             break;
         default:
@@ -325,7 +325,7 @@ VideoDecoderFfmpeg::frameToImage(AVCodecContext* srcCtx,
     avpicture_fill(&picture, im->begin(), pixFmt, width, height);
 
 #ifndef HAVE_SWSCALE_H
-    img_convert(&picture, PIX_FMT_RGB24, (AVPicture*)srcFrame,
+    img_convert(&picture, AV_PIX_FMT_RGB24, (AVPicture*)srcFrame,
             srcPixFmt, width, height);
 #else
 
@@ -499,15 +499,15 @@ reset_context(AVCodecContext* avctx, VaapiContextFfmpeg* vactx)
 }
 
 /// AVCodecContext.get_format() implementation
-PixelFormat
-get_format(AVCodecContext* avctx, const PixelFormat* fmt)
+AVPixelFormat
+get_format(AVCodecContext* avctx, const AVPixelFormat* fmt)
 {
 #ifdef HAVE_VA_VA_H
     VaapiContextFfmpeg* const vactx = get_vaapi_context(avctx);
 
     if (vactx) {
-        for (int i = 0; fmt[i] != PIX_FMT_NONE; i++) {
-            if (fmt[i] != PIX_FMT_VAAPI_VLD) continue;
+        for (int i = 0; fmt[i] != AV_PIX_FMT_NONE; i++) {
+            if (fmt[i] != AV_PIX_FMT_VAAPI_VLD) continue;
 
             if (vactx->initDecoder(avctx->width, avctx->height)) {
                 return fmt[i];
diff --git a/libmedia/ffmpeg/ffmpegHeaders.h b/libmedia/ffmpeg/ffmpegHeaders.h
index 2e4944e..d8f9b26 100644
--- a/libmedia/ffmpeg/ffmpegHeaders.h
+++ b/libmedia/ffmpeg/ffmpegHeaders.h
@@ -185,4 +185,27 @@ extern "C" {
 }
 #endif
 
+#if LIBAVUTIL_VERSION_MAJOR < 55
+#define AVPixelFormat        PixelFormat
+#define AV_PIX_FMT_YUV444P   PIX_FMT_YUV444P
+#define AV_PIX_FMT_YUVJ444P  PIX_FMT_YUVJ444P
+#define AV_PIX_FMT_YUV440P   PIX_FMT_YUV440P
+#define AV_PIX_FMT_YUVJ440P  PIX_FMT_YUVJ440P
+#define AV_PIX_FMT_YUV422P   PIX_FMT_YUV422P
+#define AV_PIX_FMT_YUVJ422P  PIX_FMT_YUVJ422P
+#define AV_PIX_FMT_YUV420P   PIX_FMT_YUV420P
+#define AV_PIX_FMT_YUVJ420P  PIX_FMT_YUVJ420P
+#define AV_PIX_FMT_YUV411P   PIX_FMT_YUV411P
+#define AV_PIX_FMT_YUV410P   PIX_FMT_YUV410P
+#define AV_PIX_FMT_NV12      PIX_FMT_NV12
+#define AV_PIX_FMT_NV21      PIX_FMT_NV21
+#define AV_PIX_FMT_YUYV422   PIX_FMT_YUYV422
+#define AV_PIX_FMT_UYVY422   PIX_FMT_UYVY422
+#define AV_PIX_FMT_UYYVYY411 PIX_FMT_UYYVYY411
+#define AV_PIX_FMT_NONE      PIX_FMT_NONE
+#define AV_PIX_FMT_RGB24     PIX_FMT_RGB24
+#define AV_PIX_FMT_RGBA      PIX_FMT_RGBA
+#define AV_PIX_FMT_VAAPI_VLD PIX_FMT_VAAPI_VLD
+#endif
+
 #endif // GNASH_MEDIA_FFMPEG_HEADERS_H

-----------------------------------------------------------------------

Summary of changes:
 libmedia/ffmpeg/VideoConverterFfmpeg.cpp |   54 +++++++++++++++---------------
 libmedia/ffmpeg/VideoDecoderFfmpeg.cpp   |   24 +++++++-------
 libmedia/ffmpeg/ffmpegHeaders.h          |   23 +++++++++++++
 3 files changed, 62 insertions(+), 39 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Thu Mar 03 04:48:07 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abPra-0000ws-St
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 04:48:07 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49002)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPrV-0000mC-9a
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:48:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPrS-0007Dr-3m
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:48:01 -0500
Received: from [2001:4830:134:6::a] (port=37628 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abPrS-0007Dh-0U
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 04:47:58 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1abPrQ-0005Hf-QB; Thu, 03 Mar 2016 09:47:56 +0000
Date: Thu, 03 Mar 2016 09:47:56 +0000
To: Sandro Santilli <strk@keybit.net>, Abdel-Rahman <abodyxplay1@gmail.com>,
	Real Name <zl29ah@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47301
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160303-104756.sv27281.91672@savannah.gnu.org>
References: <20160228-203548.sv0.65852@savannah.gnu.org>
	<20160301-193607.sv102846.21585@savannah.gnu.org>
	<20160301-193709.sv102846.47746@savannah.gnu.org>
	<20160302-081426.sv27281.99387@savannah.gnu.org>
	<20160302-151526.sv102846.12559@savannah.gnu.org>
In-Reply-To: <20160302-151526.sv102846.12559@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47301] cannot build against ffmpeg-3.0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 09:48:05 -0000

Update of bug #47301 (project gnash):

                  Status:                    None => Ready For Test         

    _______________________________________________________

Follow-up Comment #4:

Sounds good, pushed as commit 9229f6fa59061eb930179c6f6a616be541d1139f

Thanks.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 03 08:20:47 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abTBP-00035j-95
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 08:20:47 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abTBH-00030r-LF
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 08:20:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abTBE-0007xx-9b
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 08:20:39 -0500
Received: from [2001:4830:134:6::a] (port=54706 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abTBD-0007xk-RL
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 08:20:36 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1abTBC-0001ZL-OU; Thu, 03 Mar 2016 13:20:34 +0000
Date: Thu, 03 Mar 2016 13:20:34 +0000
To: Sandro Santilli <strk@keybit.net>, Abdel-Rahman <abodyxplay1@gmail.com>,
	Real Name <zl29ah@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Abdel-Rahman <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47301
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 197.38.126.9 (Savane authenticated user abogical)
Message-Id: <20160303-132034.sv102846.11000@savannah.gnu.org>
References: <20160228-203548.sv0.65852@savannah.gnu.org>
	<20160301-193607.sv102846.21585@savannah.gnu.org>
	<20160301-193709.sv102846.47746@savannah.gnu.org>
	<20160302-081426.sv27281.99387@savannah.gnu.org>
	<20160302-151526.sv102846.12559@savannah.gnu.org>
	<20160303-104756.sv27281.91672@savannah.gnu.org>
In-Reply-To: <20160303-104756.sv27281.91672@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47301] cannot build against ffmpeg-3.0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 13:20:45 -0000

Follow-up Comment #5, bug #47301 (project gnash):

Your welcome :)

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 03 08:26:53 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abTHJ-0006MV-1j
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 08:26:53 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52750)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abTHH-0006Kz-FJ
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 08:26:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abTHC-00011y-Ci
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 08:26:51 -0500
Received: from [2001:4830:134:6::a] (port=55248 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abTHC-00011u-8e
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 08:26:46 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1abTH8-0001fl-TT; Thu, 03 Mar 2016 13:26:42 +0000
Date: Thu, 03 Mar 2016 13:26:42 +0000
To: Sandro Santilli <strk@keybit.net>, Abdel-Rahman <abodyxplay1@gmail.com>,
	Real Name <zl29ah@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Real Name <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47301
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 109.188.124.19 (Savane authenticated user l29ah)
Message-Id: <20160303-132642.sv93866.73778@savannah.gnu.org>
References: <20160228-203548.sv0.65852@savannah.gnu.org>
	<20160301-193607.sv102846.21585@savannah.gnu.org>
	<20160301-193709.sv102846.47746@savannah.gnu.org>
	<20160302-081426.sv27281.99387@savannah.gnu.org>
	<20160302-151526.sv102846.12559@savannah.gnu.org>
	<20160303-104756.sv27281.91672@savannah.gnu.org>
	<20160303-132034.sv102846.11000@savannah.gnu.org>
In-Reply-To: <20160303-132034.sv102846.11000@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47301] cannot build against ffmpeg-3.0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 13:26:52 -0000

Follow-up Comment #6, bug #47301 (project gnash):

master builds and works now, thank you

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 03 10:21:13 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1abV3x-0003JP-9D
	for mharc-gnash-commit@gnu.org; Thu, 03 Mar 2016 10:21:13 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50232)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abV3u-0003Ip-El
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 10:21:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abV3r-00058q-8T
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 10:21:10 -0500
Received: from [2001:4830:134:6::a] (port=35895 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1abV3r-00058i-4Z
	for gnash-commit@gnu.org; Thu, 03 Mar 2016 10:21:07 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1abV3p-00046e-Nu; Thu, 03 Mar 2016 15:21:05 +0000
Date: Thu, 03 Mar 2016 15:21:05 +0000
To: Sandro Santilli <strk@keybit.net>, Abdel-Rahman <abodyxplay1@gmail.com>,
	Real Name <zl29ah@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47301
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160303-162105.sv27281.4124@savannah.gnu.org>
References: <20160228-203548.sv0.65852@savannah.gnu.org>
	<20160301-193607.sv102846.21585@savannah.gnu.org>
	<20160301-193709.sv102846.47746@savannah.gnu.org>
	<20160302-081426.sv27281.99387@savannah.gnu.org>
	<20160302-151526.sv102846.12559@savannah.gnu.org>
	<20160303-104756.sv27281.91672@savannah.gnu.org>
	<20160303-132034.sv102846.11000@savannah.gnu.org>
	<20160303-132642.sv93866.73778@savannah.gnu.org>
In-Reply-To: <20160303-132642.sv93866.73778@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47301] cannot build against ffmpeg-3.0
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2016 15:21:11 -0000

Update of bug #47301 (project gnash):

                  Status:          Ready For Test => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #7:

Thanks for testing.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47301>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Mar 05 12:16:39 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acFol-0006iM-0P
	for mharc-gnash-commit@gnu.org; Sat, 05 Mar 2016 12:16:39 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34446)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acFoi-0006hV-Bg
	for gnash-commit@gnu.org; Sat, 05 Mar 2016 12:16:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acFof-0007U3-0S
	for gnash-commit@gnu.org; Sat, 05 Mar 2016 12:16:36 -0500
Received: from [2001:4830:134:6::a] (port=45678 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acFoe-0007Ti-SY
	for gnash-commit@gnu.org; Sat, 05 Mar 2016 12:16:32 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acFod-00012L-HC; Sat, 05 Mar 2016 17:16:31 +0000
Date: Sat, 05 Mar 2016 17:16:31 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 37223
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.164.71 (Savane authenticated user nachanon)
Message-Id: <20160306-001631.sv82809.61603@savannah.gnu.org>
References: <20120830-160926.sv82809.43366@savannah.gnu.org>
	<20130319-174516.sv82809.31460@savannah.gnu.org>
	<20150804-180816.sv82809.45053@savannah.gnu.org>
	<20150804-133501.sv27281.31496@savannah.gnu.org>
	<20150810-171105.sv82809.45138@savannah.gnu.org>
	<20150813-233055.sv82809.86441@savannah.gnu.org>
	<20150816-102000.sv82809.47449@savannah.gnu.org>
	<20150816-120237.sv82809.2053@savannah.gnu.org>
	<20150816-094548.sv27281.33358@savannah.gnu.org>
	<20150816-105723.sv27281.58495@savannah.gnu.org>
	<20150819-162448.sv82809.18043@savannah.gnu.org>
	<20150819-123244.sv27281.95835@savannah.gnu.org>
	<20150819-173717.sv82809.59361@savannah.gnu.org>
	<20150819-174628.sv82809.47467@savannah.gnu.org>
	<20150819-125122.sv27281.47972@savannah.gnu.org>
	<20150928-101318.sv82809.44998@savannah.gnu.org>
	<20151004-002132.sv82809.49504@savannah.gnu.org>
	<20151005-140602.sv82809.12407@savannah.gnu.org>
	<20151005-161606.sv82809.95118@savannah.gnu.org>
	<20151006-182634.sv27281.21560@savannah.gnu.org>
	<20151013-164645.sv82809.2971@savannah.gnu.org>
	<20151226-195314.sv82809.60040@savannah.gnu.org>
	<20151226-154819.sv27281.70015@savannah.gnu.org>
In-Reply-To: <20151226-154819.sv27281.70015@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #37223] JavaScript call didn't reach the
	ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Mar 2016 17:16:37 -0000

Follow-up Comment #23, bug #37223 (project gnash):

>From more testing and a hint from Gnash's `Function.call()` implementation
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/Function_as.cpp?id=9229f6fa59061eb930179c6f6a616be541d1139f#n159>,
I found that the correct `this` object inside ExternalInterface
callback registered with `undefined` or `null` instance is, in fact,
ActionScript's *`_global` object*.

I have made a semi-automated test SWF/HTML for verifying this aspect of
ExternalInterface, attached as `js2flash-nothis.zip`.

This is text output from `js2flash-nothis.html` on browser with Flash Player:


PASSED: Flash should properly register nullthis_call ExternalInterface
callback
PASSED: Flash should properly register undefinedthis_call ExternalInterface
callback
PASSED: ExternalInterface should be available
PASSED: nullthis_call ExternalInterface callback registration should not fail
PASSED: undefinedthis_call ExternalInterface callback registration should not
fail
PASSED: nullthis_call ExternalInterface callback should be called
PASSED: this pointer inside nullthis_call should be equal to undefined value
PASSED: this pointer inside nullthis_call should be equal to null value
PASSED: this pointer inside nullthis_call should not strictly equal to
undefined value
PASSED: this pointer inside nullthis_call should not strictly equal to null
value
PASSED: Appending this pointer inside nullthis_call to empty string should
give "undefined" string
PASSED: this pointer inside nullthis_call should be strictly equal to _global
object
PASSED: undefinedthis_call ExternalInterface callback should be called
PASSED: this pointer inside undefinedthis_call should be equal to undefined
value
PASSED: this pointer inside undefinedthis_call should be equal to null value
PASSED: this pointer inside undefinedthis_call should not strictly equal to
undefined value
PASSED: this pointer inside undefinedthis_call should not strictly equal to
null value
PASSED: Appending this pointer inside undefinedthis_call to empty string
should give "undefined" string
PASSED: this pointer inside undefinedthis_call should be strictly equal to
_global object
PASSED: There should be 19 tests run


You'd see that all checks were passed.

This is text output from `js2flash-nothis.html` on browser with Gnash:

PASSED: Flash should properly register nullthis_call ExternalInterface
callback
PASSED: Flash should properly register undefinedthis_call ExternalInterface
callback
PASSED: ExternalInterface should be available
PASSED: nullthis_call ExternalInterface callback registration should not fail
PASSED: undefinedthis_call ExternalInterface callback registration should not
fail
PASSED: nullthis_call ExternalInterface callback should be called
PASSED: this pointer inside nullthis_call should be equal to undefined value
PASSED: this pointer inside nullthis_call should be equal to null value
PASSED: this pointer inside nullthis_call should not strictly equal to
undefined value
FAILED: this pointer inside nullthis_call should not strictly equal to null
value
FAILED: Appending this pointer inside nullthis_call to empty string should
give "undefined" string ("null" != "undefined")
FAILED: this pointer inside nullthis_call should be strictly equal to _global
object
PASSED: undefinedthis_call ExternalInterface callback should be called
PASSED: this pointer inside undefinedthis_call should be equal to undefined
value
PASSED: this pointer inside undefinedthis_call should be equal to null value
PASSED: this pointer inside undefinedthis_call should not strictly equal to
undefined value
FAILED: this pointer inside undefinedthis_call should not strictly equal to
null value
FAILED: Appending this pointer inside undefinedthis_call to empty string
should give "undefined" string ("null" != "undefined")
FAILED: this pointer inside undefinedthis_call should be strictly equal to
_global object
PASSED: There should be 19 tests run


You'd see that checks were failed in the same way as current XFAILs
<https://savannah.gnu.org/patch/?8840#comment0> in
extcomm test of Gnash testsuite.

Gnash: 0.8.11dev (git 9229f6f 3-Mar-2016) NPAPI
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36557)
    _______________________________________________________

Additional Item Attachment:

File name: js2flash-nothis.zip            Size:25 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?37223>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Mar 06 12:43:45 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acciX-0001Av-Ds
	for mharc-gnash-commit@gnu.org; Sun, 06 Mar 2016 12:43:45 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acciU-00019c-GQ
	for gnash-commit@gnu.org; Sun, 06 Mar 2016 12:43:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acciR-0008If-7k
	for gnash-commit@gnu.org; Sun, 06 Mar 2016 12:43:42 -0500
Received: from [2001:4830:134:6::a] (port=41985 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acciR-0008Ib-41
	for gnash-commit@gnu.org; Sun, 06 Mar 2016 12:43:39 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acciQ-0007KT-OM; Sun, 06 Mar 2016 17:43:38 +0000
Date: Sun, 06 Mar 2016 17:43:38 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8933
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.166.226 (Savane authenticated user nachanon)
Message-Id: <20160307-004337.sv82809.71717@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8933] Patch to use `_global` as a fallback
	`this` object in ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Mar 2016 17:43:43 -0000

URL:
  <http://savannah.gnu.org/patch/?8933>

                 Summary: Patch to use `_global` as a fallback `this` object
in ExternalInterface callback
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Mon 07 Mar 2016 12:43:37 AM ICT
                Category: core
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a follow-up to patch #8840.

On current version of Gnash, when ExternalInterface callback which
registered with `undefined` or `null` as `instance` object get called,
`this` pointer inside the callback will be set to `null`.

On Flash Player, `this` instance inside the callback in this case would be
the same as one seen in a function invoked using `Function.call(null)` or
`Function.call(undefined)` <https://savannah.gnu.org/patch/?8840#comment0>,
which is the `_global` object
<https://savannah.gnu.org/bugs/?37223#comment23>.

Patch 1 of 2:
See the attached
`0007_supply-global-instance-for-externalinterface-callback.patch`.

This patch adds a provision to provide `_global` object as `this` instance
in the same manner as `Function.call(null)` and `Function.call(undefined)`
when the callback is registered without one; fixing this aspect of bug
#37223.

Note: Implementation provided by this patch is not exactly the same as
current Gnash's `Function.call()`, as Gnash's `Function.call()`
implementation
has a bug. Automated test of this particular case will follows.

Gnash: 0.8.11dev (patched against git 9229f6f 3-Mar-2016)
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 07 Mar 2016 12:43:37 AM ICT  Name:
0007_supply-global-instance-for-externalinterface-callback.patch  Size: 3kB  
By: nachanon
Patch to use `_global` as ExternalInterface callback context to the ones
lacking it
<http://savannah.gnu.org/patch/download.php?file_id=36559>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8933>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Mar 07 01:00:56 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acoDw-00059E-IZ
	for mharc-gnash-commit@gnu.org; Mon, 07 Mar 2016 01:00:56 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45514)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acoDu-000591-I3
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 01:00:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acoDr-0006eq-8v
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 01:00:54 -0500
Received: from [2001:4830:134:6::a] (port=43204 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acoDr-0006el-5A
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 01:00:51 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acoDp-00069q-SI; Mon, 07 Mar 2016 06:00:49 +0000
Date: Mon, 07 Mar 2016 06:00:49 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 37223
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.167.138 (Savane authenticated user nachanon)
Message-Id: <20160307-130049.sv82809.87949@savannah.gnu.org>
References: <20120830-160926.sv82809.43366@savannah.gnu.org>
	<20130319-174516.sv82809.31460@savannah.gnu.org>
	<20150804-180816.sv82809.45053@savannah.gnu.org>
	<20150804-133501.sv27281.31496@savannah.gnu.org>
	<20150810-171105.sv82809.45138@savannah.gnu.org>
	<20150813-233055.sv82809.86441@savannah.gnu.org>
	<20150816-102000.sv82809.47449@savannah.gnu.org>
	<20150816-120237.sv82809.2053@savannah.gnu.org>
	<20150816-094548.sv27281.33358@savannah.gnu.org>
	<20150816-105723.sv27281.58495@savannah.gnu.org>
	<20150819-162448.sv82809.18043@savannah.gnu.org>
	<20150819-123244.sv27281.95835@savannah.gnu.org>
	<20150819-173717.sv82809.59361@savannah.gnu.org>
	<20150819-174628.sv82809.47467@savannah.gnu.org>
	<20150819-125122.sv27281.47972@savannah.gnu.org>
	<20150928-101318.sv82809.44998@savannah.gnu.org>
	<20151004-002132.sv82809.49504@savannah.gnu.org>
	<20151005-140602.sv82809.12407@savannah.gnu.org>
	<20151005-161606.sv82809.95118@savannah.gnu.org>
	<20151006-182634.sv27281.21560@savannah.gnu.org>
	<20151013-164645.sv82809.2971@savannah.gnu.org>
	<20151226-195314.sv82809.60040@savannah.gnu.org>
	<20151226-154819.sv27281.70015@savannah.gnu.org>
	<20160306-001631.sv82809.61603@savannah.gnu.org>
In-Reply-To: <20160306-001631.sv82809.61603@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #37223] JavaScript call didn't reach the
	ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 06:00:55 -0000

Follow-up Comment #24, bug #37223 (project gnash):

I have made a revised version of `js2flash-nothis.zip` test, which include
additional checks on relationship between `this` object inside callback
without context and the `_global` object, by trying to set some property
to `this` inside the callback, and check for them in `_global` outside
the callback.

The test is attached as `js2flash-nothis-v2.zip`.

Gnash: 0.8.11dev (git 9229f6f 3-Mar-2016) NPAPI
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36563)
    _______________________________________________________

Additional Item Attachment:

File name: js2flash-nothis-v2.zip         Size:29 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?37223>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Mar 07 01:21:35 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acoXv-0007fa-KW
	for mharc-gnash-commit@gnu.org; Mon, 07 Mar 2016 01:21:35 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acoXt-0007fO-MJ
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 01:21:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acoXq-0002kW-Bq
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 01:21:33 -0500
Received: from [2001:4830:134:6::a] (port=44794 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acoXq-0002kS-8D
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 01:21:30 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acoXp-0006a1-2O; Mon, 07 Mar 2016 06:21:29 +0000
Date: Mon, 07 Mar 2016 06:21:29 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 37223
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.167.138 (Savane authenticated user nachanon)
Message-Id: <20160307-132128.sv82809.91313@savannah.gnu.org>
References: <20120830-160926.sv82809.43366@savannah.gnu.org>
	<20130319-174516.sv82809.31460@savannah.gnu.org>
	<20150804-180816.sv82809.45053@savannah.gnu.org>
	<20150804-133501.sv27281.31496@savannah.gnu.org>
	<20150810-171105.sv82809.45138@savannah.gnu.org>
	<20150813-233055.sv82809.86441@savannah.gnu.org>
	<20150816-102000.sv82809.47449@savannah.gnu.org>
	<20150816-120237.sv82809.2053@savannah.gnu.org>
	<20150816-094548.sv27281.33358@savannah.gnu.org>
	<20150816-105723.sv27281.58495@savannah.gnu.org>
	<20150819-162448.sv82809.18043@savannah.gnu.org>
	<20150819-123244.sv27281.95835@savannah.gnu.org>
	<20150819-173717.sv82809.59361@savannah.gnu.org>
	<20150819-174628.sv82809.47467@savannah.gnu.org>
	<20150819-125122.sv27281.47972@savannah.gnu.org>
	<20150928-101318.sv82809.44998@savannah.gnu.org>
	<20151004-002132.sv82809.49504@savannah.gnu.org>
	<20151005-140602.sv82809.12407@savannah.gnu.org>
	<20151005-161606.sv82809.95118@savannah.gnu.org>
	<20151006-182634.sv27281.21560@savannah.gnu.org>
	<20151013-164645.sv82809.2971@savannah.gnu.org>
	<20151226-195314.sv82809.60040@savannah.gnu.org>
	<20151226-154819.sv27281.70015@savannah.gnu.org>
	<20160306-001631.sv82809.61603@savannah.gnu.org>
	<20160307-130049.sv82809.87949@savannah.gnu.org>
In-Reply-To: <20160307-130049.sv82809.87949@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #37223] JavaScript call didn't reach the
	ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 06:21:35 -0000

Follow-up Comment #25, bug #37223 (project gnash):

Patch included for fixing `instance=null` and `instance=undefined` case.
See patch #8933.

This is text output from `js2flash-nothis-v2.html` on browser with patched
Gnash:

PASSED: Flash should properly register nullthis_call ExternalInterface
callback
PASSED: Flash should properly register undefinedthis_call ExternalInterface
callback
PASSED: Flash should properly register globalcheck_call ExternalInterface
callback
PASSED: ExternalInterface should be available
PASSED: nullthis_call ExternalInterface callback registration should not fail
PASSED: undefinedthis_call ExternalInterface callback registration should not
fail
PASSED: globalcheck_call ExternalInterface callback registration should not
fail
PASSED: nullthis_call ExternalInterface callback should be called
PASSED: this pointer inside nullthis_call should be equal to undefined value
PASSED: this pointer inside nullthis_call should be equal to null value
PASSED: this pointer inside nullthis_call should not strictly equal to
undefined value
PASSED: this pointer inside nullthis_call should not strictly equal to null
value
PASSED: Appending this pointer inside nullthis_call to empty string should
give "undefined" string
PASSED: this pointer inside nullthis_call should be strictly equal to _global
object
PASSED: undefinedthis_call ExternalInterface callback should be called
PASSED: this pointer inside undefinedthis_call should be equal to undefined
value
PASSED: this pointer inside undefinedthis_call should be equal to null value
PASSED: this pointer inside undefinedthis_call should not strictly equal to
undefined value
PASSED: this pointer inside undefinedthis_call should not strictly equal to
null value
PASSED: Appending this pointer inside undefinedthis_call to empty string
should give "undefined" string
PASSED: this pointer inside undefinedthis_call should be strictly equal to
_global object
PASSED: globalcheck_call ExternalInterface callback should be called
PASSED: _global.nullthis_value should be set to the correct value
PASSED: _global.undefinedthis_value should be set to the correct value
PASSED: There should be 25 tests run


You'd see that all tests are now showing PASSED result.

Note: The `Function.call()` issue
<https://savannah.gnu.org/patch/?8933#comment0> mentioned in the patch entry
will be
reported separately after additional testing are done.

Gnash: 0.8.11dev (patched against git 9229f6f 3-Mar-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?37223>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Mar 07 05:05:32 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acs2e-0005OW-PB
	for mharc-gnash-commit@gnu.org; Mon, 07 Mar 2016 05:05:32 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37507)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1acs2c-0005ON-Ip
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 05:05:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1acs2b-0002Dd-CW
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 05:05:30 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:47659)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1acs2b-0002DZ-8z
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 05:05:29 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1acs2a-0000IR-OX
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 10:05:29 +0000
Date: Mon, 07 Mar 2016 10:05:28 +0000
Message-Id: <E1acs2a-0000IR-OX@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 9229f6fa59061eb930179c6f6a616be541d1139f
X-Git-Newrev: 8b336929d19917a4d85629e8a9cd8483ad7f1c60
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2270-g8b33692
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 10:05:31 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  8b336929d19917a4d85629e8a9cd8483ad7f1c60 (commit)
      from  9229f6fa59061eb930179c6f6a616be541d1139f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60


commit 8b336929d19917a4d85629e8a9cd8483ad7f1c60
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Mon Mar 7 11:04:53 2016 +0100

    Use _global as "this" for ExternalInterface callback that lacks it.
    
    This fixes special cases of bug #37223 where instance object of
    the callback is set to null or undefined at registration time.
    See <https://savannah.gnu.org/bugs/?37223>

diff --git a/libcore/movie_root.cpp b/libcore/movie_root.cpp
index 55e45c5..cb63f7d 100644
--- a/libcore/movie_root.cpp
+++ b/libcore/movie_root.cpp
@@ -1942,6 +1942,12 @@ movie_root::callExternalCallback(const std::string &name,
         }
         else instance = instance_iterator->second;
 
+        // Use _global object as "this" instance if the callback is originally
+        // registered with null or undefined one.
+        if (instance == NULL) {
+            instance = &getGlobal(*method);
+        }
+
         // Populate function call arguments
         for (std::vector<as_value>::const_iterator args_iterator
                  = fnargs.begin();
diff --git a/testsuite/misc-mtasc.all/extcomm.as b/testsuite/misc-mtasc.all/extcomm.as
index dcf7862..df80226 100644
--- a/testsuite/misc-mtasc.all/extcomm.as
+++ b/testsuite/misc-mtasc.all/extcomm.as
@@ -89,12 +89,13 @@ class ExternalCommTest
 				{
 					// `this` should be an "undefined" object like one in
 					// a function called via `function.call(null)`
-					xcheck_equals(typeof(this), "object");
+					check_equals(typeof(this), "object");
 					check(this == undefined);
 					check(this == null);
 					check(this !== undefined);
-					xcheck(this !== null);
-					xcheck_equals("" + this, "undefined");
+					check(this !== null);
+					check_equals("" + this, "undefined");
+					check(this === _global);
 				}
 			)
 		);
@@ -104,12 +105,13 @@ class ExternalCommTest
 				{
 					// `this` should be an "undefined" object like one in
 					// a function called via `function.call(undefined)`
-					xcheck_equals(typeof(this), "object");
+					check_equals(typeof(this), "object");
 					check(this == undefined);
 					check(this == null);
 					check(this !== undefined);
-					xcheck(this !== null);
-					xcheck_equals("" + this, "undefined");
+					check(this !== null);
+					check_equals("" + this, "undefined");
+					check(this === _global);
 				}
 			)
 		);
diff --git a/testsuite/misc-mtasc.all/extcommtests-runner.sh b/testsuite/misc-mtasc.all/extcommtests-runner.sh
index 80cd550..2ac31a4 100644
--- a/testsuite/misc-mtasc.all/extcommtests-runner.sh
+++ b/testsuite/misc-mtasc.all/extcommtests-runner.sh
@@ -281,7 +281,7 @@ XFAILED=\`expr "\$XFAILED" + "\$PLAYERXFAILED"\`
 TESTED=\`expr "\$TESTED" + "\$PLAYERPASSED" + "\$PLAYERXPASSED" + "\$PLAYERFAILED" + "\$PLAYERXFAILED"\`
 
 # Check for total number of test run
-check_totals "87" "There should be 87 tests run"
+check_totals "89" "There should be 89 tests run"
 
 # Remove temporary files
 rm "\$LOGFILE"

-----------------------------------------------------------------------

Summary of changes:
 libcore/movie_root.cpp                          |    6 ++++++
 testsuite/misc-mtasc.all/extcomm.as             |   14 ++++++++------
 testsuite/misc-mtasc.all/extcommtests-runner.sh |    2 +-
 3 files changed, 15 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Mon Mar 07 05:07:28 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acs4W-0005XU-TE
	for mharc-gnash-commit@gnu.org; Mon, 07 Mar 2016 05:07:28 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37801)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acs4P-0005Wk-Ak
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 05:07:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acs4M-00034W-Kz
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 05:07:21 -0500
Received: from [2001:4830:134:6::a] (port=34466 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acs4M-00034S-HR
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 05:07:18 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acs4L-000318-Lb; Mon, 07 Mar 2016 10:07:17 +0000
Date: Mon, 07 Mar 2016 10:07:17 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8933
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:38.0) Gecko/20100101 Firefox/38.0 Iceweasel/38.5.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160307-110717.sv27281.7946@savannah.gnu.org>
References: <20160307-004337.sv82809.71717@savannah.gnu.org>
In-Reply-To: <20160307-004337.sv82809.71717@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8933] Patch to use `_global` as a fallback
	`this` object in ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 10:07:27 -0000

Update of patch #8933 (project gnash):

                  Status:                    None => In Progress            
             Assigned to:                    None => strk                   

    _______________________________________________________

Follow-up Comment #1:

Patch 1 aka 0007_supply-global-instance-for-externalinterface-callback.patch
pushed as 
commit 8b336929d19917a4d85629e8a9cd8483ad7f1c60


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8933>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Mar 07 07:21:44 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acuAS-0001is-M6
	for mharc-gnash-commit@gnu.org; Mon, 07 Mar 2016 07:21:44 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuAP-0001ii-6y
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:21:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuAK-0001bs-5U
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:21:41 -0500
Received: from [2001:4830:134:6::a] (port=48294 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuAK-0001bi-1s
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:21:36 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acuAJ-0006Rs-Rq; Mon, 07 Mar 2016 12:21:35 +0000
Date: Mon, 07 Mar 2016 12:21:35 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47354
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.167.138 (Savane authenticated user nachanon)
Message-Id: <20160307-192134.sv82809.29796@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47354] `Function.call(null)` and
	`Function.call(undefined)` provided an incorrect `this` instance
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 12:21:43 -0000

URL:
  <http://savannah.gnu.org/bugs/?47354>

                 Summary: `Function.call(null)` and `Function.call(undefined)`
provided an incorrect `this` instance
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Mon 07 Mar 2016 07:21:34 PM ICT
                Category: ActionScript
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a spin-off from bug #37223 (ExternalInterface issue).

While I was testing on Gnash's ExternalInterface callback behavior when SWF
registered a callback with accompanied `this` object set to `null`
or `undefined`, I found that `this` object inside the callback is supposed
to be the same as one inside function called with `Function.call(null)` or
`Function.call(undefined)`.

On Flash Player, `this` object is actually the ActionScript's `_global`
object.
On Gnash, a plain object with no prototype was returned instead, which is
incorrect.

I have made test SWF files (using libming's makeswf) which checks following
properties of `this` inside a function called via `Function.call(null)`
and `Function.call(undefined)`:
* `typeof(this)` should return "object".
* `this` should be equal to `null` and `undefined`.
* `this` should _not be_ strictly equal to `null` and `undefined`.
* When appending `this` to an empty string, it must give "undefined" (Flash
7+) or empty string (Flash 6).
* *`this` should be _strictly equal_ to `_global`.*
* *Properties set to `this` must be retrievable later via `_global` object,
outside the function.*

(The test is similar to `js2flash-nothis-v2.zip`
<https://savannah.gnu.org/bugs/?37223#comment24> provided in bug #37223)

This is a trace output of `fncall-nothis-v7.swf` under Flash Player:

PASSED: _global object should be an object type
Warning: valueOf is not a function
PASSED: _global object should be equal to undefined value
Warning: valueOf is not a function
PASSED: _global object should be equal to null value
Warning: valueOf is not a function
PASSED: Appending _global object to empty string should give "undefined"
string
PASSED: _global object should not be strictly equal to undefined value
PASSED: _global object should not be strictly equal to null value
PASSED: this pointer inside fn_nullthis should be an object type
Warning: valueOf is not a function
PASSED: this pointer inside fn_nullthis should be equal to undefined value
Warning: valueOf is not a function
PASSED: this pointer inside fn_nullthis should be equal to null value
Warning: valueOf is not a function
PASSED: Appending this pointer inside fn_nullthis to empty string should give
"undefined" string
PASSED: this pointer inside fn_nullthis should not be strictly equal to
undefined value
PASSED: this pointer inside fn_nullthis should not be strictly equal to null
value
PASSED: this pointer inside fn_nullthis should be strictly equal to _global
object
PASSED: this pointer inside fn_undefinedthis should be an object type
Warning: valueOf is not a function
PASSED: this pointer inside fn_undefinedthis should be equal to undefined
value
Warning: valueOf is not a function
PASSED: this pointer inside fn_undefinedthis should be equal to null value
Warning: valueOf is not a function
PASSED: Appending this pointer inside fn_undefinedthis to empty string should
give "undefined" string
PASSED: this pointer inside fn_undefinedthis should not be strictly equal to
undefined value
PASSED: this pointer inside fn_undefinedthis should not be strictly equal to
null value
PASSED: this pointer inside fn_undefinedthis should be strictly equal to
_global object
PASSED: _global.nullthis_value should be set to the correct value
PASSED: _global.undefinedthis_value should be set to the correct value
PASSED: There should be 22 tests run


You'd see that all tests were passed.

This is a debug output (verbosity 1) of `fncall-nothis-v7.swf` under Gnash:

105 SECURITY: Checking security of URL
'file:///mnt/gnashdev/fncall-nothis/fncall-nothis/fncall-nothis-v7.swf'
105 SECURITY: Load of file
/mnt/gnashdev/fncall-nothis/fncall-nothis/fncall-nothis-v7.swf granted (under
local sandbox /mnt/gnashdev/fncall-nothis/fncall-nothis/)
136 SECURITY: Extensions disabled
138 TRACE: PASSED: _global object should be an object type
138 TRACE: PASSED: _global object should be equal to undefined value
138 TRACE: PASSED: _global object should be equal to null value
138 TRACE: PASSED: Appending _global object to empty string should give
"undefined" string
138 TRACE: PASSED: _global object should not be strictly equal to undefined
value
138 TRACE: PASSED: _global object should not be strictly equal to null value
138 TRACE: PASSED: this pointer inside fn_nullthis should be an object type
138 TRACE: PASSED: this pointer inside fn_nullthis should be equal to
undefined value
139 TRACE: PASSED: this pointer inside fn_nullthis should be equal to null
value
139 TRACE: PASSED: Appending this pointer inside fn_nullthis to empty string
should give "undefined" string
139 TRACE: PASSED: this pointer inside fn_nullthis should not be strictly
equal to undefined value
139 TRACE: PASSED: this pointer inside fn_nullthis should not be strictly
equal to null value
139 TRACE: FAILED: this pointer inside fn_nullthis should be strictly equal to
_global object
139 TRACE: PASSED: this pointer inside fn_undefinedthis should be an object
type
139 TRACE: PASSED: this pointer inside fn_undefinedthis should be equal to
undefined value
139 TRACE: PASSED: this pointer inside fn_undefinedthis should be equal to
null value
139 TRACE: PASSED: Appending this pointer inside fn_undefinedthis to empty
string should give "undefined" string
139 TRACE: PASSED: this pointer inside fn_undefinedthis should not be strictly
equal to undefined value
139 TRACE: PASSED: this pointer inside fn_undefinedthis should not be strictly
equal to null value
140 TRACE: FAILED: this pointer inside fn_undefinedthis should be strictly
equal to _global object
140 ACTIONSCRIPT ERROR: Reference to undefined member [string:nullthis_value]
of object [object(gnash::Global_as):0xb8a24278]
140 TRACE: FAILED: _global.nullthis_value should be set to the correct value
("undefined" != "fn_nullthis")
140 ACTIONSCRIPT ERROR: Reference to undefined member
[string:undefinedthis_value] of object [object(gnash::Global_as):0xb8a24278]
140 TRACE: FAILED: _global.undefinedthis_value should be set to the correct
value ("undefined" != "fn_undefinedthis")
140 TRACE: PASSED: There should be 22 tests run


You'd see that tests of properties highlighted above in bold were failed.

Test SWF files (Flash 6-8), full debug logs, and source code are attached
as `fncall-nothis.zip`.

Gnash: 0.8.11dev (git 8b33692 7-Mar-2016)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386

P.S. Gnash's testsute
<http://git.savannah.gnu.org/cgit/gnash.git/tree/testsuite/actionscript.all/Function.as?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60#n131>
doesn't seem to have automated test on this issue.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 07 Mar 2016 07:21:34 PM ICT  Name: fncall-nothis.zip  Size: 11kB  
By: nachanon
`Function.call()` test SWF files, source code, and debug logs
<http://savannah.gnu.org/bugs/download.php?file_id=36565>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47354>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Mar 07 07:28:43 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acuHD-0004jn-4J
	for mharc-gnash-commit@gnu.org; Mon, 07 Mar 2016 07:28:43 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuHA-0004in-Qb
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:28:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuH5-0003Ff-PL
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:28:40 -0500
Received: from [2001:4830:134:6::a] (port=49017 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuH5-0003Fb-Lc
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:28:35 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acuH4-0006Ye-JD; Mon, 07 Mar 2016 12:28:34 +0000
Date: Mon, 07 Mar 2016 12:28:34 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8933
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.167.138 (Savane authenticated user nachanon)
Message-Id: <20160307-192834.sv82809.87483@savannah.gnu.org>
References: <20160307-004337.sv82809.71717@savannah.gnu.org>
	<20160307-110717.sv27281.7946@savannah.gnu.org>
In-Reply-To: <20160307-110717.sv27281.7946@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8933] Patch to use `_global` as a fallback
	`this` object in ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 12:28:41 -0000

Follow-up Comment #2, patch #8933 (project gnash):

The forementioned bug in Gnash's `Function.call()` is now filed as bug #47354.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8933>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Mar 07 07:31:57 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acuKL-0005KH-GV
	for mharc-gnash-commit@gnu.org; Mon, 07 Mar 2016 07:31:57 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53068)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuKJ-0005K8-CB
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:31:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuKF-0004J2-Av
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:31:55 -0500
Received: from [2001:4830:134:6::a] (port=49258 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acuKF-0004Iy-7o
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 07:31:51 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acuKE-0006ey-M1; Mon, 07 Mar 2016 12:31:50 +0000
Date: Mon, 07 Mar 2016 12:31:50 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 37223
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.167.138 (Savane authenticated user nachanon)
Message-Id: <20160307-193150.sv82809.27016@savannah.gnu.org>
References: <20120830-160926.sv82809.43366@savannah.gnu.org>
	<20130319-174516.sv82809.31460@savannah.gnu.org>
	<20150804-180816.sv82809.45053@savannah.gnu.org>
	<20150804-133501.sv27281.31496@savannah.gnu.org>
	<20150810-171105.sv82809.45138@savannah.gnu.org>
	<20150813-233055.sv82809.86441@savannah.gnu.org>
	<20150816-102000.sv82809.47449@savannah.gnu.org>
	<20150816-120237.sv82809.2053@savannah.gnu.org>
	<20150816-094548.sv27281.33358@savannah.gnu.org>
	<20150816-105723.sv27281.58495@savannah.gnu.org>
	<20150819-162448.sv82809.18043@savannah.gnu.org>
	<20150819-123244.sv27281.95835@savannah.gnu.org>
	<20150819-173717.sv82809.59361@savannah.gnu.org>
	<20150819-174628.sv82809.47467@savannah.gnu.org>
	<20150819-125122.sv27281.47972@savannah.gnu.org>
	<20150928-101318.sv82809.44998@savannah.gnu.org>
	<20151004-002132.sv82809.49504@savannah.gnu.org>
	<20151005-140602.sv82809.12407@savannah.gnu.org>
	<20151005-161606.sv82809.95118@savannah.gnu.org>
	<20151006-182634.sv27281.21560@savannah.gnu.org>
	<20151013-164645.sv82809.2971@savannah.gnu.org>
	<20151226-195314.sv82809.60040@savannah.gnu.org>
	<20151226-154819.sv27281.70015@savannah.gnu.org>
	<20160306-001631.sv82809.61603@savannah.gnu.org>
	<20160307-130049.sv82809.87949@savannah.gnu.org>
	<20160307-132128.sv82809.91313@savannah.gnu.org>
In-Reply-To: <20160307-132128.sv82809.91313@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #37223] JavaScript call didn't reach the
	ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 12:31:56 -0000

Follow-up Comment #26, bug #37223 (project gnash):

The issue of `thisObject=null` and `thisObject=undefined` in Gnash's
`Function.call()` <https://savannah.gnu.org/patch/?8933#comment0> is now
reported separately as bug #47354.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?37223>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Mon Mar 07 09:16:44 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1acvxk-0007xM-7U
	for mharc-gnash-commit@gnu.org; Mon, 07 Mar 2016 09:16:44 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acvxh-0007wR-Ft
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 09:16:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acvxd-0004Yz-FU
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 09:16:41 -0500
Received: from [2001:4830:134:6::a] (port=58985 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1acvxd-0004YQ-CI
	for gnash-commit@gnu.org; Mon, 07 Mar 2016 09:16:37 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1acvxd-0000V4-19; Mon, 07 Mar 2016 14:16:37 +0000
Date: Mon, 07 Mar 2016 14:16:37 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47354
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.167.138 (Savane authenticated user nachanon)
Message-Id: <20160307-211636.sv82809.46259@savannah.gnu.org>
References: <20160307-192134.sv82809.29796@savannah.gnu.org>
In-Reply-To: <20160307-192134.sv82809.29796@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47354] `Function.call(null)` and
	`Function.call(undefined)` provided an incorrect `this` instance
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2016 14:16:43 -0000

Follow-up Comment #1, bug #47354 (project gnash):

Gnash's implementation of `Function.apply()` is also affected by the
same problem. I have made a variant of `fncall-nothis.zip` test which uses
`Function.apply()` instead of `Function.call()`; attached as
`fnapply-nothis.zip`.

This is a trace output of `fnapply-nothis-v7.swf` under Flash Player: 

PASSED: _global object should be an object type
Warning: valueOf is not a function
PASSED: _global object should be equal to undefined value
Warning: valueOf is not a function
PASSED: _global object should be equal to null value
Warning: valueOf is not a function
PASSED: Appending _global object to empty string should give "undefined"
string
PASSED: _global object should not be strictly equal to undefined value
PASSED: _global object should not be strictly equal to null value
PASSED: this pointer inside fn_nullthis should be an object type
Warning: valueOf is not a function
PASSED: this pointer inside fn_nullthis should be equal to undefined value
Warning: valueOf is not a function
PASSED: this pointer inside fn_nullthis should be equal to null value
Warning: valueOf is not a function
PASSED: Appending this pointer inside fn_nullthis to empty string should give
"undefined" string
PASSED: this pointer inside fn_nullthis should not be strictly equal to
undefined value
PASSED: this pointer inside fn_nullthis should not be strictly equal to null
value
PASSED: this pointer inside fn_nullthis should be strictly equal to _global
object
PASSED: this pointer inside fn_undefinedthis should be an object type
Warning: valueOf is not a function
PASSED: this pointer inside fn_undefinedthis should be equal to undefined
value
Warning: valueOf is not a function
PASSED: this pointer inside fn_undefinedthis should be equal to null value
Warning: valueOf is not a function
PASSED: Appending this pointer inside fn_undefinedthis to empty string should
give "undefined" string
PASSED: this pointer inside fn_undefinedthis should not be strictly equal to
undefined value
PASSED: this pointer inside fn_undefinedthis should not be strictly equal to
null value
PASSED: this pointer inside fn_undefinedthis should be strictly equal to
_global object
PASSED: _global.nullthis_value should be set to the correct value
PASSED: _global.undefinedthis_value should be set to the correct value
PASSED: There should be 22 tests run


You'd see that all tests were passed.

This is a debug output (verbosity 1) of `fnapply-nothis-v7.swf` under Gnash:

102 SECURITY: Checking security of URL
'file:///mnt/gnashdev/fncall-nothis/fnapply-nothis/fnapply-nothis-v7.swf'
102 SECURITY: Load of file
/mnt/gnashdev/fncall-nothis/fnapply-nothis/fnapply-nothis-v7.swf granted
(under local sandbox /mnt/gnashdev/fncall-nothis/fnapply-nothis/)
131 SECURITY: Extensions disabled
132 TRACE: PASSED: _global object should be an object type
132 TRACE: PASSED: _global object should be equal to undefined value
132 TRACE: PASSED: _global object should be equal to null value
132 TRACE: PASSED: Appending _global object to empty string should give
"undefined" string
132 TRACE: PASSED: _global object should not be strictly equal to undefined
value
132 TRACE: PASSED: _global object should not be strictly equal to null value
133 TRACE: PASSED: this pointer inside fn_nullthis should be an object type
133 TRACE: PASSED: this pointer inside fn_nullthis should be equal to
undefined value
133 TRACE: PASSED: this pointer inside fn_nullthis should be equal to null
value
133 TRACE: PASSED: Appending this pointer inside fn_nullthis to empty string
should give "undefined" string
133 TRACE: PASSED: this pointer inside fn_nullthis should not be strictly
equal to undefined value
133 TRACE: PASSED: this pointer inside fn_nullthis should not be strictly
equal to null value
133 TRACE: FAILED: this pointer inside fn_nullthis should be strictly equal to
_global object
133 TRACE: PASSED: this pointer inside fn_undefinedthis should be an object
type
133 TRACE: PASSED: this pointer inside fn_undefinedthis should be equal to
undefined value
133 TRACE: PASSED: this pointer inside fn_undefinedthis should be equal to
null value
133 TRACE: PASSED: Appending this pointer inside fn_undefinedthis to empty
string should give "undefined" string
133 TRACE: PASSED: this pointer inside fn_undefinedthis should not be strictly
equal to undefined value
133 TRACE: PASSED: this pointer inside fn_undefinedthis should not be strictly
equal to null value
133 TRACE: FAILED: this pointer inside fn_undefinedthis should be strictly
equal to _global object
134 ACTIONSCRIPT ERROR: Reference to undefined member [string:nullthis_value]
of object [object(gnash::Global_as):0xb8af5290]
134 TRACE: FAILED: _global.nullthis_value should be set to the correct value
("undefined" != "fn_nullthis")
134 ACTIONSCRIPT ERROR: Reference to undefined member
[string:undefinedthis_value] of object [object(gnash::Global_as):0xb8af5290]
134 TRACE: FAILED: _global.undefinedthis_value should be set to the correct
value ("undefined" != "fn_undefinedthis")
134 TRACE: PASSED: There should be 22 tests run


You'd see that tests were failed in the same way as `Function.call()`.

Gnash: 0.8.11dev (git 8b33692 7-Mar-2016)
Flash Player: 11.2 r202 (11.2.202.491) Standalone
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36566)
    _______________________________________________________

Additional Item Attachment:

File name: fnapply-nothis.zip             Size:11 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47354>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 08 07:47:12 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adH2e-00058R-2q
	for mharc-gnash-commit@gnu.org; Tue, 08 Mar 2016 07:47:12 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40180)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adH2b-00057Q-RE
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 07:47:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adH2Y-00051k-G6
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 07:47:09 -0500
Received: from [2001:4830:134:6::a] (port=55985 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adH2Y-00051a-CQ
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 07:47:06 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adH2Y-0004wH-3e; Tue, 08 Mar 2016 12:47:06 +0000
Date: Tue, 08 Mar 2016 12:47:06 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47354
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.162.247 (Savane authenticated user nachanon)
Message-Id: <20160308-194705.sv82809.75958@savannah.gnu.org>
References: <20160307-192134.sv82809.29796@savannah.gnu.org>
	<20160307-211636.sv82809.46259@savannah.gnu.org>
In-Reply-To: <20160307-211636.sv82809.46259@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47354] `Function.call(null)` and
	`Function.call(undefined)` provided an incorrect `this` instance
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 12:47:10 -0000

Follow-up Comment #2, bug #47354 (project gnash):

This issue could be narrowed down directly to how `Function.call()` and
`Function.apply()` are currently implemented in Gnash.

`Function.apply()` at `libcore/asobj/Function_as.cpp` around line 107
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/Function_as.cpp?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60#n107>:

	if (!fn.nargs) {
        IF_VERBOSE_ASCODING_ERRORS(
            log_aserror(_("Function.apply() called with no args"));
        );
        new_fn_call.this_ptr = new as_object(getGlobal(fn));
	}
	else {
		// Get the object to use as 'this' reference
		as_object* obj = toObject(fn.arg(0), getVM(fn));

        if (!obj) obj = new as_object(getGlobal(fn)); 

        new_fn_call.this_ptr = obj;


`Function.call()` at `libcore/asobj/Function_as.cpp` around line 159
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/asobj/Function_as.cpp?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60#n159>:

    if (!fn.nargs || fn.arg(0).is_undefined() || fn.arg(0).is_null()) {
        tp = new as_object(getGlobal(fn));
    }


In both methods, `this` inside the called function would be set to an empty
object
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/as_object.h?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60#n166>
if `thisObject` argument was not specified, or specified as `null` or
`undefined`.

Gnash: 0.8.11dev (git 8b33692 7-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47354>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 08 10:12:18 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adJJ4-0007Nn-LX
	for mharc-gnash-commit@gnu.org; Tue, 08 Mar 2016 10:12:18 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJIy-0007Fu-Ri
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:12:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJIt-0002Ns-4V
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:12:12 -0500
Received: from [2001:4830:134:6::a] (port=40282 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJIt-0002Nn-1k
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:12:07 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adJIs-000854-Rv; Tue, 08 Mar 2016 15:12:06 +0000
Date: Tue, 08 Mar 2016 15:12:06 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47354
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.162.247 (Savane authenticated user nachanon)
Message-Id: <20160308-221206.sv82809.86430@savannah.gnu.org>
References: <20160307-192134.sv82809.29796@savannah.gnu.org>
	<20160307-211636.sv82809.46259@savannah.gnu.org>
	<20160308-194705.sv82809.75958@savannah.gnu.org>
In-Reply-To: <20160308-194705.sv82809.75958@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47354] `Function.call(null)` and
	`Function.call(undefined)` provided an incorrect `this` instance
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 15:12:17 -0000

Follow-up Comment #3, bug #47354 (project gnash):

I have written an updated version of `fncall-nothis.zip` and
`fnapply-nothis.zip` which include the case where SWF tries to call
`Function.call()` and `Function.apply()` with no argument;
attached as `fncall-nothis-rev2.zip` and `fnapply-nothis-rev2.zip`.


(file #36568, file #36569)
    _______________________________________________________

Additional Item Attachment:

File name: fncall-nothis-rev2.zip         Size:12 KB
File name: fnapply-nothis-rev2.zip        Size:12 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47354>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 08 10:16:50 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adJNR-0001D7-VH
	for mharc-gnash-commit@gnu.org; Tue, 08 Mar 2016 10:16:49 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51228)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJNK-00014Y-82
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:16:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJNG-0003q1-Of
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:16:42 -0500
Received: from [2001:4830:134:6::a] (port=40778 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJNG-0003px-L7
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:16:38 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adJNG-0008BO-HY; Tue, 08 Mar 2016 15:16:38 +0000
Date: Tue, 08 Mar 2016 15:16:38 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8935
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.162.247 (Savane authenticated user nachanon)
Message-Id: <20160308-221637.sv82809.48987@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8935] Patch for providing `_global` as a
	fallback instance in `Function.call()` and `Function.apply()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 15:16:48 -0000

URL:
  <http://savannah.gnu.org/patch/?8935>

                 Summary: Patch for providing `_global` as a fallback instance
in `Function.call()` and `Function.apply()`
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Tue 08 Mar 2016 10:16:37 PM ICT
                Category: ActionScript
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Current Gnash's implementation of `Function.call()` and `Function.apply()`
have an incorrect behavior when user specified `thisObject` argument as
`null` or `undefined`, which it caused the function to be called with `this`
instance set to an empty object
<https://savannah.gnu.org/bugs/?47354#comment2> rather than the `_global`
object.

Patch 1 of 2:
See the attached
`0001_supply-global-instance-fallback-for-function-call-apply.patch`.

This patch makes `Function.call()` and `Function.apply()` supply a reference
to `Global_as` (a.k.a. ActionScript `_global`) as the context of function
call
if the `thisObject` argument of the method is specified as `null`
or `undefined`; fixing bug #47354.

Gnash: 0.8.11dev (patched against git 8b33692 7-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 08 Mar 2016 10:16:37 PM ICT  Name:
0001_supply-global-instance-fallback-for-function-call-apply.patch  Size: 1kB 
 By: nachanon
Patch to use `_global` as function context if called via
`Function.call()`/`Function.apply()` with null/undefined instance
<http://savannah.gnu.org/patch/download.php?file_id=36570>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 08 10:20:55 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adJRP-0003az-SG
	for mharc-gnash-commit@gnu.org; Tue, 08 Mar 2016 10:20:55 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52256)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJRK-0003SN-Af
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:20:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJRH-0004ey-Km
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:20:50 -0500
Received: from [2001:4830:134:6::a] (port=41417 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adJRH-0004dy-9l
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 10:20:47 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adJRA-0008Hm-Aa; Tue, 08 Mar 2016 15:20:40 +0000
Date: Tue, 08 Mar 2016 15:20:40 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47354
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.162.247 (Savane authenticated user nachanon)
Message-Id: <20160308-222040.sv82809.79036@savannah.gnu.org>
References: <20160307-192134.sv82809.29796@savannah.gnu.org>
	<20160307-211636.sv82809.46259@savannah.gnu.org>
	<20160308-194705.sv82809.75958@savannah.gnu.org>
	<20160308-221206.sv82809.86430@savannah.gnu.org>
In-Reply-To: <20160308-221206.sv82809.86430@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47354] `Function.call(null)` and
	`Function.call(undefined)` provided an incorrect `this` instance
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 15:20:55 -0000

Follow-up Comment #4, bug #47354 (project gnash):

Patch included, see patch #8935.

This is debug output (verbosity 1) of `fncall-nothis-rev2-v7.swf` with patched
Gnash:

115 SECURITY: Checking security of URL
'file:///mnt/gnashdev/fncall-nothis/fncall-nothis-rev2/fncall-nothis-rev2-v7.swf'
115 SECURITY: Load of file
/mnt/gnashdev/fncall-nothis/fncall-nothis-rev2/fncall-nothis-rev2-v7.swf
granted (under local sandbox /mnt/gnashdev/fncall-nothis/fncall-nothis-rev2/)
151 SECURITY: Extensions disabled
151 TRACE: PASSED: _global object should be an object type
151 TRACE: PASSED: _global object should be equal to undefined value
152 TRACE: PASSED: _global object should be equal to null value
152 TRACE: PASSED: Appending _global object to empty string should give
"undefined" string
152 TRACE: PASSED: _global object should not be strictly equal to undefined
value
152 TRACE: PASSED: _global object should not be strictly equal to null value
152 TRACE: PASSED: this pointer inside fn_nothis should be an object type
152 TRACE: PASSED: this pointer inside fn_nothis should be equal to undefined
value
152 TRACE: PASSED: this pointer inside fn_nothis should be equal to null
value
152 TRACE: PASSED: Appending this pointer inside fn_nothis to empty string
should give "undefined" string
152 TRACE: PASSED: this pointer inside fn_nothis should not be strictly equal
to undefined value
152 TRACE: PASSED: this pointer inside fn_nothis should not be strictly equal
to null value
152 TRACE: PASSED: this pointer inside fn_nothis should be strictly equal to
_global object
153 TRACE: PASSED: this pointer inside fn_nullthis should be an object type
153 TRACE: PASSED: this pointer inside fn_nullthis should be equal to
undefined value
153 TRACE: PASSED: this pointer inside fn_nullthis should be equal to null
value
153 TRACE: PASSED: Appending this pointer inside fn_nullthis to empty string
should give "undefined" string
153 TRACE: PASSED: this pointer inside fn_nullthis should not be strictly
equal to undefined value
153 TRACE: PASSED: this pointer inside fn_nullthis should not be strictly
equal to null value
153 TRACE: PASSED: this pointer inside fn_nullthis should be strictly equal to
_global object
153 TRACE: PASSED: this pointer inside fn_undefinedthis should be an object
type
153 TRACE: PASSED: this pointer inside fn_undefinedthis should be equal to
undefined value
153 TRACE: PASSED: this pointer inside fn_undefinedthis should be equal to
null value
153 TRACE: PASSED: Appending this pointer inside fn_undefinedthis to empty
string should give "undefined" string
153 TRACE: PASSED: this pointer inside fn_undefinedthis should not be strictly
equal to undefined value
153 TRACE: PASSED: this pointer inside fn_undefinedthis should not be strictly
equal to null value
154 TRACE: PASSED: this pointer inside fn_undefinedthis should be strictly
equal to _global object
154 TRACE: PASSED: _global.nothis_value should be set to the correct value
154 TRACE: PASSED: _global.nullthis_value should be set to the correct value
154 TRACE: PASSED: _global.undefinedthis_value should be set to the correct
value
154 TRACE: PASSED: There should be 30 tests run


This is debug output (verbosity 1) of `fnapply-nothis-rev2-v7.swf` with
patched Gnash:

116 SECURITY: Checking security of URL
'file:///mnt/gnashdev/fncall-nothis/fnapply-nothis-rev2/fnapply-nothis-rev2-v7.swf'
116 SECURITY: Load of file
/mnt/gnashdev/fncall-nothis/fnapply-nothis-rev2/fnapply-nothis-rev2-v7.swf
granted (under local sandbox
/mnt/gnashdev/fncall-nothis/fnapply-nothis-rev2/)
160 SECURITY: Extensions disabled
161 TRACE: PASSED: _global object should be an object type
161 TRACE: PASSED: _global object should be equal to undefined value
161 TRACE: PASSED: _global object should be equal to null value
162 TRACE: PASSED: Appending _global object to empty string should give
"undefined" string
162 TRACE: PASSED: _global object should not be strictly equal to undefined
value
162 TRACE: PASSED: _global object should not be strictly equal to null value
162 ACTIONSCRIPT ERROR: Function.apply() called with no args
162 TRACE: PASSED: this pointer inside fn_nothis should be an object type
163 TRACE: PASSED: this pointer inside fn_nothis should be equal to undefined
value
163 TRACE: PASSED: this pointer inside fn_nothis should be equal to null
value
163 TRACE: PASSED: Appending this pointer inside fn_nothis to empty string
should give "undefined" string
163 TRACE: PASSED: this pointer inside fn_nothis should not be strictly equal
to undefined value
163 TRACE: PASSED: this pointer inside fn_nothis should not be strictly equal
to null value
163 TRACE: PASSED: this pointer inside fn_nothis should be strictly equal to
_global object
164 TRACE: PASSED: this pointer inside fn_nullthis should be an object type
164 TRACE: PASSED: this pointer inside fn_nullthis should be equal to
undefined value
164 TRACE: PASSED: this pointer inside fn_nullthis should be equal to null
value
164 TRACE: PASSED: Appending this pointer inside fn_nullthis to empty string
should give "undefined" string
164 TRACE: PASSED: this pointer inside fn_nullthis should not be strictly
equal to undefined value
165 TRACE: PASSED: this pointer inside fn_nullthis should not be strictly
equal to null value
165 TRACE: PASSED: this pointer inside fn_nullthis should be strictly equal to
_global object
165 TRACE: PASSED: this pointer inside fn_undefinedthis should be an object
type
165 TRACE: PASSED: this pointer inside fn_undefinedthis should be equal to
undefined value
165 TRACE: PASSED: this pointer inside fn_undefinedthis should be equal to
null value
165 TRACE: PASSED: Appending this pointer inside fn_undefinedthis to empty
string should give "undefined" string
166 TRACE: PASSED: this pointer inside fn_undefinedthis should not be strictly
equal to undefined value
166 TRACE: PASSED: this pointer inside fn_undefinedthis should not be strictly
equal to null value
166 TRACE: PASSED: this pointer inside fn_undefinedthis should be strictly
equal to _global object
166 TRACE: PASSED: _global.nothis_value should be set to the correct value
166 TRACE: PASSED: _global.nullthis_value should be set to the correct value
167 TRACE: PASSED: _global.undefinedthis_value should be set to the correct
value
167 TRACE: PASSED: There should be 30 tests run


You'd see that tests are now giving all-PASSED result. (Other version of test
SWFs in both test case are also giving all PASSED result too)

Gnash: 0.8.11dev (patched against git 8b33692 7-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47354>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 08 13:17:44 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adMCW-0008Ks-RP
	for mharc-gnash-commit@gnu.org; Tue, 08 Mar 2016 13:17:44 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49922)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adMCT-0008Iu-Us
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 13:17:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adMCP-0007If-SK
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 13:17:41 -0500
Received: from [2001:4830:134:6::a] (port=55076 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adMCP-0007Ia-PX
	for gnash-commit@gnu.org; Tue, 08 Mar 2016 13:17:37 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adMCN-0003XX-OT; Tue, 08 Mar 2016 18:17:35 +0000
Date: Tue, 08 Mar 2016 18:17:35 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8935
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160308-191735.sv27281.54649@savannah.gnu.org>
References: <20160308-221637.sv82809.48987@savannah.gnu.org>
In-Reply-To: <20160308-221637.sv82809.48987@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8935] Patch for providing `_global` as a
	fallback instance in `Function.call()` and `Function.apply()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2016 18:17:43 -0000

Update of patch #8935 (project gnash):

             Assigned to:                    None => strk                   

    _______________________________________________________

Follow-up Comment #1:

Is patch 2 going to contain the test ?
I'd like this to come with tests, and hopefully Function.as in
actionscript.all is a good place to add them.

We have support for XCHECK for the specific reason of allowing tests to be
submitted even _before_  fixes :)

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Mar 09 01:09:54 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adXJi-0001pz-RE
	for mharc-gnash-commit@gnu.org; Wed, 09 Mar 2016 01:09:54 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60733)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adXJf-0001oy-Tx
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 01:09:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adXJa-000635-UH
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 01:09:51 -0500
Received: from [2001:4830:134:6::a] (port=53293 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adXJa-00062i-R4
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 01:09:46 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adXJY-0001kN-Jo; Wed, 09 Mar 2016 06:09:44 +0000
Date: Wed, 09 Mar 2016 06:09:44 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8933
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.164.167 (Savane authenticated user nachanon)
Message-Id: <20160309-130944.sv82809.20986@savannah.gnu.org>
References: <20160307-004337.sv82809.71717@savannah.gnu.org>
	<20160307-110717.sv27281.7946@savannah.gnu.org>
	<20160307-192834.sv82809.87483@savannah.gnu.org>
In-Reply-To: <20160307-192834.sv82809.87483@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8933] Patch to use `_global` as a fallback
	`this` object in ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 06:09:52 -0000

Follow-up Comment #3, patch #8933 (project gnash):

Patch 2 of 2:
See the attached
`0008_add-external-interface-global-instance-fallback-prop-assignment-test.patch`.

This patch adds few more checks on relationship of `this` pointer inside
ExternalInterface callback registered with `null`/`undefined` context
and the `_global` object; by trying to assign a string member to it.
If the member could be accessed later via `_global` object: PASS, otherwise:
FAIL.

(It is the same check as ones provided in `js2flash-nothis-v2.html` test
<https://savannah.gnu.org/bugs/?37223#comment24>)

Might need a review, since I'm not sure if this kind of property assignment
checks are redundant or not, as the previously-added strict equality test
should already check that `this` and `_global` are the same object instance
(provided that the operator works correctly on Gnash).


(file #36574)
    _______________________________________________________

Additional Item Attachment:

File name:
0008_add-external-interface-global-instance-fallback-prop-assignment-test.patch
Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8933>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Mar 09 05:42:59 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adbZz-0001iH-Nf
	for mharc-gnash-commit@gnu.org; Wed, 09 Mar 2016 05:42:59 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41831)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adbZx-0001Yr-JE
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 05:42:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adbZp-0000xc-2Y
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 05:42:53 -0500
Received: from [2001:4830:134:6::a] (port=43497 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adbZo-0000xY-W3
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 05:42:49 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adbZo-0007bZ-Mn; Wed, 09 Mar 2016 10:42:48 +0000
Date: Wed, 09 Mar 2016 10:42:48 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8938
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 203.209.83.139 (Savane authenticated user nachanon)
Message-Id: <20160309-174247.sv82809.18732@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8938] Patch to add a missing bracket in
	front of debug log messages
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 10:42:58 -0000

URL:
  <http://savannah.gnu.org/patch/?8938>

                 Summary: Patch to add a missing bracket in front of debug log
messages
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Wed 09 Mar 2016 05:42:47 PM ICT
                Category: None
                Priority: 4
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is kind of a cosmetic issue, and is trivial to fix.

When I looked at current Gnash's debug output, e.g.:

20044:1] 678 TRACE: Hello World!


It bugs me a lot that what exactly first two number, colon, and
a _dangling bracket_ printed in front of log message are for [1].
It first glance, I thought it was some kind of broken ANSI escape code.

After I digged around Gnash's libbase code, I found that the numbers are
actually process ID and thread ID, which makes sense; but the open bracket
was
conspicuously missing
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libbase/log.cpp?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60#n105>.

So I wrote a patch to fix the missing bracket, see the attached
`0001_add-missing-bracket-to-debug-log.patch`.

After applied the patch, you'll see that Gnash's debug output now look like:

[3916:1] 131 TRACE: Hello World!


Gnash: 0.8.11dev (patched against git 8b33692 7-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

[1] Side note: I have searched around current Gnash user manual and developer
reference, and found nothing that mention process/thread ID part of the log
message. (For the timestamp, developer reference only briefly mentioned it as
a part of `LogFile::setStamp()` description
<http://git.savannah.gnu.org/cgit/gnash.git/tree/doc/C/refmanual/logging.xml?id=8b336929d19917a4d85629e8a9cd8483ad7f1c60#n233>)




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 09 Mar 2016 05:42:47 PM ICT  Name:
0001_add-missing-bracket-to-debug-log.patch  Size: 532B   By: nachanon
Patch for adding the missing open bracket to log messages
<http://savannah.gnu.org/patch/download.php?file_id=36577>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8938>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Mar 09 07:34:38 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1addK2-0002ML-9X
	for mharc-gnash-commit@gnu.org; Wed, 09 Mar 2016 07:34:38 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35282)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1addJz-0002Hx-Aw
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 07:34:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1addJy-0004ni-Bi
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 07:34:35 -0500
Received: from vcs.savannah.gnu.org ([208.118.235.72]:44566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1addJy-0004nd-9H
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 07:34:34 -0500
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1addJx-0003fk-Bp
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 12:34:33 +0000
Date: Wed, 09 Mar 2016 12:34:33 +0000
Message-Id: <E1addJx-0003fk-Bp@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 8b336929d19917a4d85629e8a9cd8483ad7f1c60
X-Git-Newrev: a72afa572ede07393cead17211a0ab61210394e4
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2271-ga72afa5
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 12:34:36 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  a72afa572ede07393cead17211a0ab61210394e4 (commit)
      from  8b336929d19917a4d85629e8a9cd8483ad7f1c60 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=a72afa572ede07393cead17211a0ab61210394e4


commit a72afa572ede07393cead17211a0ab61210394e4
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Wed Mar 9 13:34:19 2016 +0100

    Add the missing open bracket in front of debug messages.

diff --git a/libbase/log.cpp b/libbase/log.cpp
index c74cd5c..1037de2 100644
--- a/libbase/log.cpp
+++ b/libbase/log.cpp
@@ -102,7 +102,7 @@ namespace {
 
         std::uint64_t diff = clocktime::getTicks() - t.startTicks;
         // should we split in seconds/ms ?
-        o << getpid() << ":" << htid << "] " << diff;
+        o << "[" << getpid() << ":" << htid << "] " << diff;
 
         return o;
 

-----------------------------------------------------------------------

Summary of changes:
 libbase/log.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Wed Mar 09 07:35:53 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1addLF-0002vo-Lh
	for mharc-gnash-commit@gnu.org; Wed, 09 Mar 2016 07:35:53 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1addLD-0002sw-C0
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 07:35:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1addL8-00053N-BU
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 07:35:51 -0500
Received: from [2001:4830:134:6::a] (port=51528 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1addL8-00053H-67
	for gnash-commit@gnu.org; Wed, 09 Mar 2016 07:35:46 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1addL7-0001zo-4a; Wed, 09 Mar 2016 12:35:45 +0000
Date: Wed, 09 Mar 2016 12:35:45 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8938
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:44.0) Gecko/20100101 Firefox/44.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160309-133545.sv27281.88055@savannah.gnu.org>
References: <20160309-174247.sv82809.18732@savannah.gnu.org>
In-Reply-To: <20160309-174247.sv82809.18732@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8938] Patch to add a missing bracket in
	front of debug log messages
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2016 12:35:52 -0000

Update of patch #8938 (project gnash):

                  Status:                    None => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #1:

I think it was intentional, anyway, pushed :)
commit a72afa572ede07393cead17211a0ab61210394e4


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8938>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 10 06:03:56 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adyNo-00083j-5w
	for mharc-gnash-commit@gnu.org; Thu, 10 Mar 2016 06:03:56 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49068)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adyNl-00082c-4M
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:03:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adyNf-0001oo-5h
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:03:53 -0500
Received: from [2001:4830:134:6::a] (port=41544 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adyNf-0001oj-2P
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:03:47 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adyNd-0005bZ-VN; Thu, 10 Mar 2016 11:03:46 +0000
Date: Thu, 10 Mar 2016 11:03:45 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8935
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.166.242 (Savane authenticated user nachanon)
Message-Id: <20160310-180345.sv82809.5151@savannah.gnu.org>
References: <20160308-221637.sv82809.48987@savannah.gnu.org>
	<20160308-191735.sv27281.54649@savannah.gnu.org>
In-Reply-To: <20160308-191735.sv27281.54649@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8935] Patch for providing `_global` as a
	fallback instance in `Function.call()` and `Function.apply()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 11:03:54 -0000

Follow-up Comment #2, patch #8935 (project gnash):

Patch 2 of 2:
See the attached
`0002_add-function-call-global-fallback-instance-tests.patch`.

This patch adds following automated checks on `Function.call()` and
`Function.apply()` to ActionScript section of Gnash testsuite:

* Function.apply() tests:
** `this` inside function called with `Function.apply()` should be strictly
equal to `_global`.
** Property set to `this` inside function called with `Function.apply()`
should end up in `_global` object.
** `this` inside function called with `Function.apply(undefined)` should be
strictly equal to `_global`.
** Property set to `this` inside function called with
`Function.apply(undefined)` should end up in `_global` object.
** `this` inside function called with `Function.apply(null)` should be
strictly equal to `_global`.
** Property set to `this` inside function called with `Function.apply(null)`
should end up in `_global` object.
* Function.call() tests:
** `this` inside function called with `Function.call()` should be strictly
equal to `_global`.
** Property set to `this` inside function called with `Function.call()` should
end up in `_global` object.
** `this` inside function called with `Function.call(undefined)` should be
strictly equal to `_global`.
** Property set to `this` inside function called with
`Function.call(undefined)` should end up in `_global` object.
** `this` inside function called with `Function.call(null)` should be strictly
equal to `_global`.
** Property set to `this` inside function called with `Function.call(null)`
should end up in `_global` object.

Might need a review, for the same reason as second half
<https://savannah.gnu.org/patch/?8933#comment3> of patch #8933.

Gnash: 0.8.11dev (patched against git a72afa5 9-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36594)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_add-function-call-global-fallback-instance-tests.patch Size:4
KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 10 06:08:58 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adySg-0000Bf-Jl
	for mharc-gnash-commit@gnu.org; Thu, 10 Mar 2016 06:08:58 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50230)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adySe-0000BW-AB
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:08:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adySb-0003Wz-44
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:08:56 -0500
Received: from [2001:4830:134:6::a] (port=42761 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adySb-0003Wv-0d
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:08:53 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adySa-0005i9-45; Thu, 10 Mar 2016 11:08:52 +0000
Date: Thu, 10 Mar 2016 11:08:52 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8935
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.166.242 (Savane authenticated user nachanon)
Message-Id: <20160310-180851.sv82809.27244@savannah.gnu.org>
References: <20160308-221637.sv82809.48987@savannah.gnu.org>
	<20160308-191735.sv27281.54649@savannah.gnu.org>
	<20160310-180345.sv82809.5151@savannah.gnu.org>
In-Reply-To: <20160310-180345.sv82809.5151@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8935] Patch for providing `_global` as a
	fallback instance in `Function.call()` and `Function.apply()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 11:08:57 -0000

Follow-up Comment #3, patch #8935 (project gnash):

As a reference, after applying the second patch, running
`testsuite/actionscript.all/Function-v*.swf` under Flash Player
gives following text output:

Function-v5.swf:

 - xtrace enabled -
SWF5 - WIN 11,3,300,271

[Function.as master-22362-650a19f]


#passed: 150
#failed: 0
#total tests run: 150


Function-v6.swf:

 - xtrace enabled -
SWF6 - WIN 11,3,300,271

[Function.as master-22362-650a19f]
custom text rep
[type Function]
#passed: 263
#failed: 0
#total tests run: 263


Function-v7.swf:

 - xtrace enabled -
SWF7 - WIN 11,3,300,271

[Function.as master-22362-650a19f]
custom text rep
[type Function]
#passed: 264
#failed: 0
#total tests run: 264


Function-v8.swf:

 - xtrace enabled -
SWF8 - WIN 11,3,300,271

[Function.as master-22362-650a19f]
custom text rep
[type Function]
#passed: 264
#failed: 0
#total tests run: 264


Gnash testsuite: 0.8.11dev (patched against git a72afa5 9-Mar-2016)
Flash Player: 11.3 r300 (11.3.300.271) NPAPI binary
Browser: Opera 11.51
System: Microsoft Windows XP SP3

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 10 06:11:59 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1adyVa-0000iN-Ut
	for mharc-gnash-commit@gnu.org; Thu, 10 Mar 2016 06:11:58 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50557)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adyVZ-0000i9-22
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:11:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adyVV-0004G9-Oe
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:11:56 -0500
Received: from [2001:4830:134:6::a] (port=43089 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1adyVV-0004G5-LS
	for gnash-commit@gnu.org; Thu, 10 Mar 2016 06:11:53 -0500
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1adyVU-0005ob-VX; Thu, 10 Mar 2016 11:11:53 +0000
Date: Thu, 10 Mar 2016 11:11:52 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8935
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.166.242 (Savane authenticated user nachanon)
Message-Id: <20160310-181152.sv82809.8177@savannah.gnu.org>
References: <20160308-221637.sv82809.48987@savannah.gnu.org>
	<20160308-191735.sv27281.54649@savannah.gnu.org>
	<20160310-180345.sv82809.5151@savannah.gnu.org>
	<20160310-180851.sv82809.27244@savannah.gnu.org>
In-Reply-To: <20160310-180851.sv82809.27244@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8935] Patch for providing `_global` as a
	fallback instance in `Function.call()` and `Function.apply()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2016 11:11:58 -0000

Follow-up Comment #4, patch #8935 (project gnash):

Side note: The reason that my integrated automated tests are usually
submitted last, is that integrated tests are more difficult to write;
extra care must be taken regarding the convention and avoid interfering
with other tests.

So I mostly rely on isolated (non-integrated) tests
<https://savannah.gnu.org/bugs/?47354#comment3> to identify the
correct behavior, and to confirm the fix
<https://savannah.gnu.org/bugs/?47354#comment4>. Then, work on the integrated
version
after the fix is accepted.

Hope you'd understand.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Mar 13 08:57:40 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1af5aW-0006Xf-Jt
	for mharc-gnash-commit@gnu.org; Sun, 13 Mar 2016 08:57:40 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5aU-0006XH-UO
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 08:57:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5aR-0003Qm-Nw
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 08:57:38 -0400
Received: from [2001:4830:134:6::a] (port=40888 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5aR-0003Qi-KN
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 08:57:35 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1af5aR-0007py-7S; Sun, 13 Mar 2016 12:57:35 +0000
Date: Sun, 13 Mar 2016 12:57:35 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8942
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.168.176 (Savane authenticated user nachanon)
Message-Id: <20160313-195734.sv82809.42746@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8942] Patches to improve number value
	handling in ExternalInterface
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2016 12:57:39 -0000

URL:
  <http://savannah.gnu.org/patch/?8942>

                 Summary: Patches to improve number value handling in
ExternalInterface
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sun 13 Mar 2016 07:57:34 PM ICT
                Category: plugin
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Current libgnashplugin's ExternalInterface data parser has
a problem unmarshalling `Number` value sent from Gnash (player) when
the number is a very large whole number, or is a special float value like
`Infinity`, `-Infinity`, and `NaN`. This is due to the parser selectively
parse number string without dot as integer
<https://savannah.gnu.org/bugs/?47280#comment3> (range `int32_t`).

Patch 1 of 2:
See the attached
`0001_always-parse-externalinterface-number-as-double.patch`.

This patch makes libgnashplugin always unmarshall `<number>` value sent
from Gnash player as `double`, which supports special value like infinity
and non-number value. This also make a large whole number correctly passed
as wider significand range is provided (53-bit instead of 32-bit).

This partially fixes bug #47280.

The change in type shouldn't cause problem, as
`ExternalInterface::parseXML()`
is only used for parsing return value for JavaScript-access call
(ExternalInterface and built-in Flash plugin functions).

Gnash: 0.8.11dev (patched against git a72afa5 9-Mar-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sun 13 Mar 2016 07:57:34 PM ICT  Name:
0001_always-parse-externalinterface-number-as-double.patch  Size: 1kB   By:
nachanon
Patch to make libgnashplugin always parse `&lt;number&gt;` as `double`
<http://savannah.gnu.org/patch/download.php?file_id=36618>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8942>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Mar 13 09:00:05 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1af5cr-0006ln-Oy
	for mharc-gnash-commit@gnu.org; Sun, 13 Mar 2016 09:00:05 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50412)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5co-0006kx-QB
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 09:00:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5cl-0003jQ-Kn
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 09:00:02 -0400
Received: from [2001:4830:134:6::a] (port=41068 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5cl-0003jM-HD
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 08:59:59 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1af5cl-0007qJ-7I; Sun, 13 Mar 2016 12:59:59 +0000
Date: Sun, 13 Mar 2016 12:59:59 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8942
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.168.176 (Savane authenticated user nachanon)
Message-Id: <20160313-195959.sv82809.41145@savannah.gnu.org>
References: <20160313-195734.sv82809.42746@savannah.gnu.org>
In-Reply-To: <20160313-195734.sv82809.42746@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8942] Patches to improve number value
	handling in ExternalInterface
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2016 13:00:04 -0000

Follow-up Comment #1, patch #8942 (project gnash):

Current libgnashplugin marshall `double` value sent from NPRuntime
to `<number>` data using default iostream with no specific precision
<https://savannah.gnu.org/bugs/?47280#comment4>
specified. This causes precision loss as not enough decimal digits
were used to represent the value.

Patch 2 of 2:
See the attached
`0002_plugin-externalinterface-number-marshall-enough-digits.patch`.

This patch explicitly specifies iostream floating point precision to
`std::numeric_limits<double>::max_digits10` (C++ 11) which is
enough significands to accurately reproduce the original `double` value
(provided that receiver end's parser library implements the correct
rounding).

This partially fixes bug #47280.

Gnash: 0.8.11dev (patched against git a72afa5 9-Mar-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36619)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_plugin-externalinterface-number-marshall-enough-digits.patch
Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8942>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Mar 13 09:05:20 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1af5hw-0007Hy-9Z
	for mharc-gnash-commit@gnu.org; Sun, 13 Mar 2016 09:05:20 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51501)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5ht-0007HC-Ur
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 09:05:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5hq-0005HB-OI
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 09:05:17 -0400
Received: from [2001:4830:134:6::a] (port=41394 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5hq-0005H7-LA
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 09:05:14 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1af5hq-00082b-Di; Sun, 13 Mar 2016 13:05:14 +0000
Date: Sun, 13 Mar 2016 13:05:14 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47280
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.168.176 (Savane authenticated user nachanon)
Message-Id: <20160313-200514.sv82809.2929@savannah.gnu.org>
References: <20160227-171328.sv82809.96025@savannah.gnu.org>
	<20160227-172107.sv82809.32015@savannah.gnu.org>
	<20160227-231236.sv82809.80423@savannah.gnu.org>
	<20160301-212051.sv82809.59059@savannah.gnu.org>
	<20160301-212744.sv82809.83712@savannah.gnu.org>
In-Reply-To: <20160301-212744.sv82809.83712@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47280] Gnash's ExternalInterface does not
	return Number value correctly
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2016 13:05:19 -0000

Follow-up Comment #5, bug #47280 (project gnash):

Patch included for fixing `Infinity`/`-Infinity`/`NaN` parsing of
ActionScript
callback return value, and precision loss of JavaScript function return
value.
See patch #8942.

Relevant text output from `js2flash-rtypes.html` with patched Gnash:

PASSED: Flash callback integer_call should return a correct type
PASSED: Flash callback integer_call should return a correct value
PASSED: Flash callback float_call should return a correct type
PASSED: Flash callback float_call should return a correct value
PASSED: Flash callback infinite_call should return a correct type
PASSED: Flash callback infinite_call should return a correct value
PASSED: Flash callback neginfinite_call should return a correct type
PASSED: Flash callback neginfinite_call should return a correct value
PASSED: Flash callback nan_call should return a correct type
PASSED: Flash callback nan_call should return a correct value


You'd see that `Infinity` return value from `infinite_call(), `-Infinity`
from
`neginfinite_call()`, and `NaN` from `nan_call()` are now passed correctly
from ActionScript callback to JavaScript.

Relevant trace output from `flash2js-rtypes.html` with patched Gnash:

82 TRACE: PASSED: JavaScript function integer_call should return a correct
type
82 TRACE: PASSED: JavaScript function integer_call should return a correct
value
82 TRACE: PASSED: JavaScript function float_call should return a correct type
82 TRACE: PASSED: JavaScript function float_call should return a correct
value
83 TRACE: PASSED: JavaScript function infinite_call should return a correct
type
83 TRACE: FAILED: JavaScript function infinite_call should return NaN
83 TRACE: PASSED: JavaScript function neginfinite_call should return a correct
type
83 TRACE: FAILED: JavaScript function neginfinite_call should return NaN
83 TRACE: PASSED: JavaScript function nan_call should return a correct type
83 TRACE: PASSED: JavaScript function nan_call should return a correct value


You'd see that return value from `float_call()` JavaScript function is now
passed back to ActionScript correctly.

Gnash: 0.8.11dev (patched against git a72afa5 9-Mar-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47280>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Mar 13 09:07:10 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1af5ji-0007Xq-5W
	for mharc-gnash-commit@gnu.org; Sun, 13 Mar 2016 09:07:10 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51767)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5jf-0007Xd-Vm
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 09:07:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5jc-0006I5-QP
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 09:07:07 -0400
Received: from [2001:4830:134:6::a] (port=41513 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1af5jc-0006I1-NV
	for gnash-commit@gnu.org; Sun, 13 Mar 2016 09:07:04 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1af5jc-00082r-LC; Sun, 13 Mar 2016 13:07:04 +0000
Date: Sun, 13 Mar 2016 13:07:04 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47280
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.168.176 (Savane authenticated user nachanon)
Message-Id: <20160313-200704.sv82809.12222@savannah.gnu.org>
References: <20160227-171328.sv82809.96025@savannah.gnu.org>
	<20160227-172107.sv82809.32015@savannah.gnu.org>
	<20160227-231236.sv82809.80423@savannah.gnu.org>
	<20160301-212051.sv82809.59059@savannah.gnu.org>
	<20160301-212744.sv82809.83712@savannah.gnu.org>
	<20160313-200514.sv82809.2929@savannah.gnu.org>
In-Reply-To: <20160313-200514.sv82809.2929@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47280] Gnash's ExternalInterface does not
	return Number value correctly
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2016 13:07:08 -0000

Follow-up Comment #6, bug #47280 (project gnash):

Note: Some tests are still failing as _Flash Player_ has some quirks/bugs
regarding number value. Some of them are not very easy to investigate:

* `Infinity` and `-Infinity` return value from JavaScript function are passed
as `NaN`.
* Not all significands in return value of ActionScript callback are passed
correctly.

These quirks would need additional testing and discussion before including
them in Gnash.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47280>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Thu Mar 17 01:48:38 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1agQnW-0001Qr-ST
	for mharc-gnash-commit@gnu.org; Thu, 17 Mar 2016 01:48:38 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58677)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1agQnT-0001Ob-FV
	for gnash-commit@gnu.org; Thu, 17 Mar 2016 01:48:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1agQnQ-0003qS-8E
	for gnash-commit@gnu.org; Thu, 17 Mar 2016 01:48:35 -0400
Received: from [2001:4830:134:6::a] (port=46700 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1agQnQ-0003qO-4h
	for gnash-commit@gnu.org; Thu, 17 Mar 2016 01:48:32 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1agQnP-0003wJ-O2; Thu, 17 Mar 2016 05:48:31 +0000
Date: Thu, 17 Mar 2016 05:48:31 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47054
User-Agent: Opera/9.80 (Windows NT 5.1; U; en) Presto/2.9.168 Version/11.51
X-Apparently-From: 110.77.166.104 (Savane authenticated user nachanon)
Message-Id: <20160317-124831.sv82809.33301@savannah.gnu.org>
References: <20160203-195917.sv82809.39952@savannah.gnu.org>
	<20160203-200157.sv82809.3254@savannah.gnu.org>
	<20160203-200601.sv82809.69252@savannah.gnu.org>
	<20160203-213338.sv82809.26065@savannah.gnu.org>
In-Reply-To: <20160203-213338.sv82809.26065@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47054] `getvariable.as` test produces
	different result on different Flash Player version
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Mar 2016 05:48:36 -0000

Follow-up Comment #4, bug #47054 (project gnash):

When tried on native version of Flash Player each SWF is supposed to run:

Text output of `getvariable-v6.swf` under Flash Player 6.0 r79 NPAPI:

 - xtrace enabled -
SWF6 - WIN 6,0,79,0

[getvariable.as master-22343-e705394]
#passed: 58
#failed: 0
#total tests run: 58


Text output of `getvariable-v7.swf` under Flash Player 7.0 r73 NPAPI:

 - xtrace enabled -
SWF7 - WIN 7,0,73,0

[getvariable.as master-22343-e705394]
#passed: 58
#failed: 0
#total tests run: 58


Text output of `getvariable-v8.swf` under Flash Player 8.0 r42 NPAPI:

 - xtrace enabled -
SWF8 - WIN 8,0,42,0

[getvariable.as master-22343-e705394]
#passed: 58
#failed: 0
#total tests run: 58


Although Flash 5 is not tested yet (there're some problems on how
DejaGNU functions used TextField), according to the results so far,
this issue is actually *Adobe Flash Player's own regression*,
which is introduced somewhere between version 9.x and version 11.x.

In order to pinpoint the exact version (for documentation),
a regression test would need to be performed.

Gnash testsuite: 0.8.11dev (git e705394 29-Jan-2016)
Browser: Mozilla Firefox 11.0
System: Microsoft Windows XP Professional SP3


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47054>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Mar 23 22:08:28 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aiuhI-0006Nh-Do
	for mharc-gnash-commit@gnu.org; Wed, 23 Mar 2016 22:08:28 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59833)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aiuhC-0006M8-5K
	for gnash-commit@gnu.org; Wed, 23 Mar 2016 22:08:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aiuh9-0006TM-0I
	for gnash-commit@gnu.org; Wed, 23 Mar 2016 22:08:22 -0400
Received: from [2001:4830:134:6::a] (port=37007 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aiuh8-0006TE-SW
	for gnash-commit@gnu.org; Wed, 23 Mar 2016 22:08:18 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aiugN-0006d3-Na; Thu, 24 Mar 2016 02:07:31 +0000
Date: Thu, 24 Mar 2016 02:07:31 +0000
To: -Deleted Account- <idontexist@nowhere.net>, Hapi <c_hapi@hotmail.com>,
	Julie <julie.wonder14@gmail.com>,
	raheem labon <info@superproductivite.com>,
	Sandro Santilli <strk@keybit.net>,
	Maximiliano =?UTF-8?B?Q2FzdGHDscOzbg==?= Araneda <maximi89@gmail.com>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Bjorn Nostvold <bjorn.nostvold@gmail.com>,
	Bella <belladoxie@live.com>, maikl <belichenko_@ukr.net>,
	Bernie Innocenti <bernie@codewiz.org>, Marco <info@altamiraweb.es>,
	Nadav Kavalerchik <nadavkav@gmail.com>,
	Rodrigo Carvalho <rcsilva83@gmail.com>,
	Samuel =?UTF-8?B?TGlkw6lu?= Borell <samuel@kodafritt.se>,
	gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: raheem labon <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 23435
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64;
	rv:45.0) Gecko/20100101 Firefox/45.0
X-Apparently-From: 41.204.117.237 (Savane authenticated user raheem)
Message-Id: <20160324-020731.sv103100.3273@savannah.gnu.org>
References: <20080530-052120.sv67576.63840@savannah.gnu.org>
	<20080601-030947.sv48477.56832@savannah.gnu.org>
	<20081010-112113.sv60230.36937@savannah.gnu.org>
	<20091209-212849.sv76464.42086@savannah.gnu.org>
	<20100920-093940.sv80137.6254@savannah.gnu.org>
	<20100924-173759.sv0.44627@savannah.gnu.org>
	<20101210-075423.sv60230.89429@savannah.gnu.org>
	<20101211-015541.sv43424.9979@savannah.gnu.org>
	<20101214-010135.sv43424.59275@savannah.gnu.org>
	<20110527-164309.sv9396.48077@savannah.gnu.org>
	<20110527-165022.sv9396.70570@savannah.gnu.org>
	<20110802-093645.sv27281.99084@savannah.gnu.org>
	<20110930-141601.sv85203.45504@savannah.gnu.org>
	<20111015-205448.sv0.19968@savannah.gnu.org>
	<20111015-205733.sv0.11828@savannah.gnu.org>
	<20111015-205823.sv0.15327@savannah.gnu.org>
	<20111015-205903.sv0.98852@savannah.gnu.org>
	<20111015-210021.sv0.88277@savannah.gnu.org>
	<20111015-210045.sv0.6915@savannah.gnu.org>
	<20111015-211855.sv0.44857@savannah.gnu.org>
	<20111015-211932.sv0.96743@savannah.gnu.org>
	<20111015-211945.sv0.3058@savannah.gnu.org>
	<20111015-212020.sv0.11466@savannah.gnu.org>
	<20111015-212032.sv0.37673@savannah.gnu.org>
	<20111015-212041.sv0.36781@savannah.gnu.org>
	<20111015-212054.sv0.56603@savannah.gnu.org>
	<20111015-212116.sv0.82630@savannah.gnu.org>
	<20111015-212128.sv0.5535@savannah.gnu.org>
	<20111015-212134.sv0.55135@savannah.gnu.org>
	<20111015-212139.sv0.21120@savannah.gnu.org>
	<20111015-212144.sv0.95581@savannah.gnu.org>
	<20111015-212204.sv0.95483@savannah.gnu.org>
	<20111015-212208.sv0.55917@savannah.gnu.org>
	<20111015-212213.sv0.83052@savannah.gnu.org>
	<20111015-212233.sv0.17909@savannah.gnu.org>
	<20111215-032001.sv86502.52580@savannah.gnu.org>
	<20120128-122636.sv86913.30138@savannah.gnu.org>
	<20130519-135802.sv90703.54900@savannah.gnu.org>
	<20130731-204517.sv92054.99015@savannah.gnu.org>
	<20131126-231824.sv93117.29607@savannah.gnu.org>
	<20150714-055243.sv100337.82085@savannah.gnu.org>
	<20150727-201122.sv100516.51572@savannah.gnu.org>
	<20150811-060338.sv100700.16246@savannah.gnu.org>
	<20150901-162252.sv100492.64065@savannah.gnu.org>
	<20150927-172817.sv101208.14240@savannah.gnu.org>
	<20150927-172952.sv101208.35076@savannah.gnu.org>
	<20150927-174325.sv101208.54147@savannah.gnu.org>
	<20150927-174804.sv101208.68924@savannah.gnu.org>
	<20150927-180604.sv101208.40469@savannah.gnu.org>
	<20150928-052013.sv101208.14222@savannah.gnu.org>
	<20150930-062616.sv101232.5956@savannah.gnu.org>
	<20151130-133030.sv97829.39785@savannah.gnu.org>
	<20160110-161003.sv102292.38827@savannah.gnu.org>
	<20160122-053826.sv0.34408@savannah.gnu.org>
In-Reply-To: <20160122-053826.sv0.34408@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #23435] Flash content rendered above menus in
	Firefox
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2016 02:08:26 -0000

Follow-up Comment #52, bug #23435 (project gnash):

Some of the sites are working great with the menus over the flash,
but on some site, the pull-down menus appear in front of the flash movie like
stated before, but the login form appears behind it...
I'm seeing the same behaviour on this site
[url=http://www.dentalespace.com/patient/forum/message-119220-0.htm/] [/url]





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?23435>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Wed Mar 23 22:19:33 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aius1-00016i-GM
	for mharc-gnash-commit@gnu.org; Wed, 23 Mar 2016 22:19:33 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aiury-00012S-2g
	for gnash-commit@gnu.org; Wed, 23 Mar 2016 22:19:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aiuru-0008EV-Js
	for gnash-commit@gnu.org; Wed, 23 Mar 2016 22:19:30 -0400
Received: from [2001:4830:134:6::a] (port=37848 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aiuru-0008EF-Gy
	for gnash-commit@gnu.org; Wed, 23 Mar 2016 22:19:26 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aiur8-0006rI-Vm; Thu, 24 Mar 2016 02:18:39 +0000
Date: Thu, 24 Mar 2016 02:18:38 +0000
To: -Deleted Account- <idontexist@nowhere.net>, Hapi <c_hapi@hotmail.com>,
	Julie <julie.wonder14@gmail.com>,
	raheem labon <info@superproductivite.com>,
	Sandro Santilli <strk@keybit.net>,
	Maximiliano =?UTF-8?B?Q2FzdGHDscOzbg==?= Araneda <maximi89@gmail.com>,
	Bastiaan Jacques <bastiaan@bjacques.org>,
	Benjamin Wolsey <bwy@benjaminwolsey.de>,
	Bjorn Nostvold <bjorn.nostvold@gmail.com>,
	Bella <belladoxie@live.com>, maikl <belichenko_@ukr.net>,
	Bernie Innocenti <bernie@codewiz.org>, Marco <info@altamiraweb.es>,
	Nadav Kavalerchik <nadavkav@gmail.com>,
	Rodrigo Carvalho <rcsilva83@gmail.com>,
	Samuel =?UTF-8?B?TGlkw6lu?= Borell <samuel@kodafritt.se>,
	gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: raheem labon <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 23435
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64;
	rv:45.0) Gecko/20100101 Firefox/45.0
X-Apparently-From: 41.204.117.237 (Savane authenticated user raheem)
Message-Id: <20160324-021838.sv103100.90218@savannah.gnu.org>
References: <20080530-052120.sv67576.63840@savannah.gnu.org>
	<20080601-030947.sv48477.56832@savannah.gnu.org>
	<20081010-112113.sv60230.36937@savannah.gnu.org>
	<20091209-212849.sv76464.42086@savannah.gnu.org>
	<20100920-093940.sv80137.6254@savannah.gnu.org>
	<20100924-173759.sv0.44627@savannah.gnu.org>
	<20101210-075423.sv60230.89429@savannah.gnu.org>
	<20101211-015541.sv43424.9979@savannah.gnu.org>
	<20101214-010135.sv43424.59275@savannah.gnu.org>
	<20110527-164309.sv9396.48077@savannah.gnu.org>
	<20110527-165022.sv9396.70570@savannah.gnu.org>
	<20110802-093645.sv27281.99084@savannah.gnu.org>
	<20110930-141601.sv85203.45504@savannah.gnu.org>
	<20111015-205448.sv0.19968@savannah.gnu.org>
	<20111015-205733.sv0.11828@savannah.gnu.org>
	<20111015-205823.sv0.15327@savannah.gnu.org>
	<20111015-205903.sv0.98852@savannah.gnu.org>
	<20111015-210021.sv0.88277@savannah.gnu.org>
	<20111015-210045.sv0.6915@savannah.gnu.org>
	<20111015-211855.sv0.44857@savannah.gnu.org>
	<20111015-211932.sv0.96743@savannah.gnu.org>
	<20111015-211945.sv0.3058@savannah.gnu.org>
	<20111015-212020.sv0.11466@savannah.gnu.org>
	<20111015-212032.sv0.37673@savannah.gnu.org>
	<20111015-212041.sv0.36781@savannah.gnu.org>
	<20111015-212054.sv0.56603@savannah.gnu.org>
	<20111015-212116.sv0.82630@savannah.gnu.org>
	<20111015-212128.sv0.5535@savannah.gnu.org>
	<20111015-212134.sv0.55135@savannah.gnu.org>
	<20111015-212139.sv0.21120@savannah.gnu.org>
	<20111015-212144.sv0.95581@savannah.gnu.org>
	<20111015-212204.sv0.95483@savannah.gnu.org>
	<20111015-212208.sv0.55917@savannah.gnu.org>
	<20111015-212213.sv0.83052@savannah.gnu.org>
	<20111015-212233.sv0.17909@savannah.gnu.org>
	<20111215-032001.sv86502.52580@savannah.gnu.org>
	<20120128-122636.sv86913.30138@savannah.gnu.org>
	<20130519-135802.sv90703.54900@savannah.gnu.org>
	<20130731-204517.sv92054.99015@savannah.gnu.org>
	<20131126-231824.sv93117.29607@savannah.gnu.org>
	<20150714-055243.sv100337.82085@savannah.gnu.org>
	<20150727-201122.sv100516.51572@savannah.gnu.org>
	<20150811-060338.sv100700.16246@savannah.gnu.org>
	<20150901-162252.sv100492.64065@savannah.gnu.org>
	<20150927-172817.sv101208.14240@savannah.gnu.org>
	<20150927-172952.sv101208.35076@savannah.gnu.org>
	<20150927-174325.sv101208.54147@savannah.gnu.org>
	<20150927-174804.sv101208.68924@savannah.gnu.org>
	<20150927-180604.sv101208.40469@savannah.gnu.org>
	<20150928-052013.sv101208.14222@savannah.gnu.org>
	<20150930-062616.sv101232.5956@savannah.gnu.org>
	<20151130-133030.sv97829.39785@savannah.gnu.org>
	<20160110-161003.sv102292.38827@savannah.gnu.org>
	<20160122-053826.sv0.34408@savannah.gnu.org>
	<20160324-020731.sv103100.3273@savannah.gnu.org>
In-Reply-To: <20160324-020731.sv103100.3273@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #23435] Flash content rendered above menus in
	Firefox
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2016 02:19:31 -0000

Follow-up Comment #53, bug #23435 (project gnash):

Some of the sites are working great with the menus over the flash,
but on some site, the pull-down menus appear in front of the flash movie like
stated before, but the login form appears behind it...
I'm seeing the same behaviour on this site
[url=http://www.dentalespace.com/patient/forum/message-119220-0.htm] [/url] 

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?23435>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Mar 26 04:19:18 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ajjRG-0001LW-Io
	for mharc-gnash-commit@gnu.org; Sat, 26 Mar 2016 04:19:18 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ajjRE-0001LO-0i
	for gnash-commit@gnu.org; Sat, 26 Mar 2016 04:19:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ajjRA-00049u-RD
	for gnash-commit@gnu.org; Sat, 26 Mar 2016 04:19:15 -0400
Received: from [2001:4830:134:6::a] (port=33484 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ajjRA-00049p-Nq
	for gnash-commit@gnu.org; Sat, 26 Mar 2016 04:19:12 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1ajjRA-0000Xh-Dh; Sat, 26 Mar 2016 08:19:12 +0000
Date: Sat, 26 Mar 2016 08:19:12 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47540
User-Agent: Opera/9.80 (Windows NT 5.1; U; en) Presto/2.10.229 Version/11.64
X-Apparently-From: 110.77.165.199 (Savane authenticated user nachanon)
Message-Id: <20160326-151911.sv82809.25550@savannah.gnu.org>
References: 
In-Reply-To: 
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47540] Gnash should support rendering SWF
	without background color
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Mar 2016 08:19:17 -0000

URL:
  <http://savannah.gnu.org/bugs/?47540>

                 Summary: Gnash should support rendering SWF without
background color
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Sat 26 Mar 2016 03:19:11 PM ICT
                Category: renderer
                Severity: 3 - Normal
                 Release: master
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This entry is not a bug, but rather a feature request.

Follow up from a mailing list discussion:
https://lists.gnu.org/archive/html/gnash/2015-07/msg00000.html
https://lists.gnu.org/archive/html/gnash/2015-07/msg00001.html

I have been wondering about possibility to use Gnash as a general-purpose
animation renderer for a long time. But as SWF has an opaque color-filled
background, the rendered animation frames couldn't be easily overlaid on
other pieces of film or video. To accomodate these uses, Gnash would need
to support rendering/screenshotting/video-dumping SWF without filling
background color.

In order to make this work, Gnash (at least with AGG-based renderer)
would have to do following things:

* Gnash would need to support 32-bit RGB+alpha PNG screenshot output.
* Gnash would need to support 32-bit RGB+alpha video output.
* Renderer would need to render with alpha channel support, on
alpha-supporting canvas.
* Gnash would need to be able to turn off rendering of SWF background color
(or render it as transparent) on request.
* Gnash would need to provide a command line switch to turn off SWF
background.

Gnash: 0.8.11dev (git a72afa5 9-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47540>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sat Mar 26 04:22:24 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ajjUG-0001iA-L9
	for mharc-gnash-commit@gnu.org; Sat, 26 Mar 2016 04:22:24 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ajjUF-0001hB-5C
	for gnash-commit@gnu.org; Sat, 26 Mar 2016 04:22:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ajjUB-0004ga-Tt
	for gnash-commit@gnu.org; Sat, 26 Mar 2016 04:22:23 -0400
Received: from [2001:4830:134:6::a] (port=33698 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1ajjUB-0004gQ-QZ
	for gnash-commit@gnu.org; Sat, 26 Mar 2016 04:22:19 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1ajjUB-0000eO-Nd; Sat, 26 Mar 2016 08:22:19 +0000
Date: Sat, 26 Mar 2016 08:22:19 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47540
User-Agent: Opera/9.80 (Windows NT 5.1; U; en) Presto/2.10.229 Version/11.64
X-Apparently-From: 110.77.165.199 (Savane authenticated user nachanon)
Message-Id: <20160326-152219.sv82809.40219@savannah.gnu.org>
References: <20160326-151911.sv82809.25550@savannah.gnu.org>
In-Reply-To: <20160326-151911.sv82809.25550@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47540] Gnash should support rendering SWF
	without background color
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Mar 2016 08:22:24 -0000

Follow-up Comment #1, bug #47540 (project gnash):

Note (as a clarification): This feature request is related to Gnash's
video dumping and screenshotting mechanism. For the different issue
related to transparent windowing mode of Gnash plugin, see bug #23091.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47540>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Mar 27 10:31:43 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1akBjD-00044C-Ha
	for mharc-gnash-commit@gnu.org; Sun, 27 Mar 2016 10:31:43 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52796)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akBjB-00042t-36
	for gnash-commit@gnu.org; Sun, 27 Mar 2016 10:31:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akBj7-0005qD-2c
	for gnash-commit@gnu.org; Sun, 27 Mar 2016 10:31:41 -0400
Received: from [2001:4830:134:6::a] (port=42987 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akBj6-0005q9-VS
	for gnash-commit@gnu.org; Sun, 27 Mar 2016 10:31:36 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1akBj6-00062s-PH; Sun, 27 Mar 2016 14:31:36 +0000
Date: Sun, 27 Mar 2016 14:31:36 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47540
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.165.7 (Savane authenticated user nachanon)
Message-Id: <20160327-213136.sv82809.80916@savannah.gnu.org>
References: <20160326-151911.sv82809.25550@savannah.gnu.org>
	<20160326-152219.sv82809.40219@savannah.gnu.org>
In-Reply-To: <20160326-152219.sv82809.40219@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47540] Gnash should support rendering SWF
	without background color
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Mar 2016 14:31:42 -0000

Follow-up Comment #2, bug #47540 (project gnash):

I have done additional research on Gnash's screenshotting mechanism
and some bits on Gnash's _AGG-based_ rendering; I found that Gnash is,
in fact:

* ...already using 32-bit RGBA pixel format when rendered in `dump-gnash`.
* ...apparently using some form* of truecolor+alpha pixel format when rendered
in `gtk-gnash`.
* ...already using 32-bit PNG screenshot output (if requested to save
screenshot in PNG format).
* ...already using 32-bit RGBA raw video format when dumping video.

Things that need to be done are just adding capability to turn SWF background
rendering off, and providing switch (`--transparent` or something similar)
to enable it.

Gnash: 0.8.11dev (git a72afa5 9-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

*Note: AGG pixel format on `gtk-gnash` is set to the format queried from GDK.
I'm still not sure how different display configuration could affect this.
(e.g. When user is using 16bpp display mode)


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47540>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Sun Mar 27 10:49:48 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1akC0i-00054a-1k
	for mharc-gnash-commit@gnu.org; Sun, 27 Mar 2016 10:49:48 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54048)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akC0g-00053Q-I8
	for gnash-commit@gnu.org; Sun, 27 Mar 2016 10:49:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akC0d-00009C-9Y
	for gnash-commit@gnu.org; Sun, 27 Mar 2016 10:49:46 -0400
Received: from [2001:4830:134:6::a] (port=44220 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akC0d-000098-6S
	for gnash-commit@gnu.org; Sun, 27 Mar 2016 10:49:43 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1akC0c-0006NW-Q9; Sun, 27 Mar 2016 14:49:42 +0000
Date: Sun, 27 Mar 2016 14:49:42 +0000
To: Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Nutchanon Wetchasit <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47540
User-Agent: Mozilla/5.0 (X11; Linux i686;
	rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1
X-Apparently-From: 110.77.165.7 (Savane authenticated user nachanon)
Message-Id: <20160327-214942.sv82809.59449@savannah.gnu.org>
References: <20160326-151911.sv82809.25550@savannah.gnu.org>
	<20160326-152219.sv82809.40219@savannah.gnu.org>
	<20160327-213136.sv82809.80916@savannah.gnu.org>
In-Reply-To: <20160327-213136.sv82809.80916@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47540] Gnash should support rendering SWF
	without background color
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Mar 2016 14:49:47 -0000

Follow-up Comment #3, bug #47540 (project gnash):

The attached `force-agg-transparent-background.patch` is an
_experimental_ patch which forces Gnash AGG renderer's background color
to RGBA #FFFFFF00 (a.k.a. transparent).

Once the patch is applied, PNG files generated via `gnash --screenshot` and
raw video generated via `dump-gnash -D` would now have transparent
background.

Note:

* It is intended for people who want to try transparent background _right
now_. It is not meant to be included in the mainline.
* It supports only AGG (default) renderer.
* It has a side effect causing SWF to be displayed with black background in
normal player/plugin. (I haven't looked closely into this yet)
* It provides *no means to turn transparency off*.

Gnash: 0.8.11dev (patched against git a72afa5 9-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36780)
    _______________________________________________________

Additional Item Attachment:

File name: force-agg-transparent-background.patch Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47540>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 29 05:45:23 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1akqDD-0000XM-9x
	for mharc-gnash-commit@gnu.org; Tue, 29 Mar 2016 05:45:23 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqDB-0000XA-Kj
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 05:45:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqD6-0004GU-Lq
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 05:45:21 -0400
Received: from [2001:4830:134:6::a] (port=43474 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqD6-0004GQ-IO
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 05:45:16 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1akqD4-0002J4-SE; Tue, 29 Mar 2016 09:45:14 +0000
Date: Tue, 29 Mar 2016 09:45:14 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8942
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:45.0) Gecko/20100101 Firefox/45.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160329-114514.sv27281.46794@savannah.gnu.org>
References: <20160313-195734.sv82809.42746@savannah.gnu.org>
	<20160313-195959.sv82809.41145@savannah.gnu.org>
In-Reply-To: <20160313-195959.sv82809.41145@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8942] Patches to improve number value
	handling in ExternalInterface
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 09:45:22 -0000

Follow-up Comment #2, patch #8942 (project gnash):

No automated tests for these patches ?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8942>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 29 05:50:50 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1akqIU-0001qw-Hq
	for mharc-gnash-commit@gnu.org; Tue, 29 Mar 2016 05:50:50 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqIS-0001pz-Ii
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 05:50:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqIO-0005Zg-57
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 05:50:48 -0400
Received: from [2001:4830:134:6::a] (port=43934 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqIO-0005Za-1q
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 05:50:44 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1akqIL-0002PK-Gg; Tue, 29 Mar 2016 09:50:41 +0000
Date: Tue, 29 Mar 2016 09:50:41 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: bugs
X-Savane-Item-ID: 47280
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:45.0) Gecko/20100101 Firefox/45.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160329-115041.sv27281.34471@savannah.gnu.org>
References: <20160227-171328.sv82809.96025@savannah.gnu.org>
	<20160227-172107.sv82809.32015@savannah.gnu.org>
	<20160227-231236.sv82809.80423@savannah.gnu.org>
	<20160301-212051.sv82809.59059@savannah.gnu.org>
	<20160301-212744.sv82809.83712@savannah.gnu.org>
	<20160313-200514.sv82809.2929@savannah.gnu.org>
	<20160313-200704.sv82809.12222@savannah.gnu.org>
In-Reply-To: <20160313-200704.sv82809.12222@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [bug #47280] Gnash's ExternalInterface does not
	return Number value correctly
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 09:50:49 -0000

Follow-up Comment #7, bug #47280 (project gnash):

We usually try to track as closely as possible the proprietary player as most
SWF authors code using the proprietary player as a reference. Sometimes
different versions of the proprietary player (PP for short) behave differently
and that's why we setup an online repository of our actionscript.all tests to
make it easier for different people on the net to report eventual weird
behavior (failures) with their version of the player.

Unfortunately the online versions are not available at the moment, but you
could produce them with "make online-tests" from under
testsuite/actioncsript.all. I guess we'll want to publish them somewhere else
and call users for testing.

When the _platform_ makes a difference, we pick the Windows version as the
reference one. As for the version, the most stable version should be
considered.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47280>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 29 06:27:32 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1akqs0-0001vP-5g
	for mharc-gnash-commit@gnu.org; Tue, 29 Mar 2016 06:27:32 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34498)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1akqrx-0001t6-6h
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:27:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1akqrt-0008Db-37
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:27:29 -0400
Received: from vcs.savannah.gnu.org ([208.118.235.72]:41103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1akqrs-0008DV-Vp
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:27:25 -0400
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1akqrs-0001sX-E2
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 10:27:24 +0000
Date: Tue, 29 Mar 2016 10:27:24 +0000
Message-Id: <E1akqrs-0001sX-E2@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: a72afa572ede07393cead17211a0ab61210394e4
X-Git-Newrev: c98c271596356118b074a4023c7816623a5514ab
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2273-gc98c271
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 10:27:30 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  c98c271596356118b074a4023c7816623a5514ab (commit)
       via  2f264a33249e4cfe03ff728ba2f54c6ee2b96d74 (commit)
      from  a72afa572ede07393cead17211a0ab61210394e4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=c98c271596356118b074a4023c7816623a5514ab


commit c98c271596356118b074a4023c7816623a5514ab
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Tue Mar 29 11:44:03 2016 +0200

    Use enough digits to represent double in plugin's ExternalInterface.
    
    See bug #47280 <https://savannah.gnu.org/bugs/?47280>

diff --git a/plugin/npapi/external.cpp b/plugin/npapi/external.cpp
index a49d0c5..4ebce1d 100644
--- a/plugin/npapi/external.cpp
+++ b/plugin/npapi/external.cpp
@@ -372,6 +372,7 @@ ExternalInterface::convertNPVariant (const NPVariant *value)
     
     if (NPVARIANT_IS_DOUBLE(*value)) {
         double num = NPVARIANT_TO_DOUBLE(*value);
+        ss.precision(std::numeric_limits<double>::max_digits10);
         ss << "<number>" << num << "</number>";
     } else if (NPVARIANT_IS_STRING(*value)) {
         std::string str = NPStringToString(NPVARIANT_TO_STRING(*value));

http://git.savannah.gnu.org/cgit//commit/?id=2f264a33249e4cfe03ff728ba2f54c6ee2b96d74


commit 2f264a33249e4cfe03ff728ba2f54c6ee2b96d74
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Tue Mar 29 11:43:51 2016 +0200

    Always parse "<number>" in plugin's ExternalInterface as double.
    
    See bug #47280 <https://savannah.gnu.org/bugs/?47280>

diff --git a/plugin/npapi/external.cpp b/plugin/npapi/external.cpp
index 1183fba..a49d0c5 100644
--- a/plugin/npapi/external.cpp
+++ b/plugin/npapi/external.cpp
@@ -293,13 +293,8 @@ ExternalInterface::parseXML(GnashPluginScriptObject *scriptobj, const std::strin
             start = end;
             end = xml.find("</number>");
             std::string str = xml.substr(start, end-start);
-            if (str.find(".") != std::string::npos) {
-                double num = strtod(str.c_str(), nullptr);
-                DOUBLE_TO_NPVARIANT(num, value);
-            } else {
-                int num = strtol(str.c_str(), nullptr, 0);
-                INT32_TO_NPVARIANT(num, value);
-            }
+            double num = strtod(str.c_str(), nullptr);
+            DOUBLE_TO_NPVARIANT(num, value);
         } else if (tag == "<string>") {
             start = end;
             end = xml.find("</string>");

-----------------------------------------------------------------------

Summary of changes:
 plugin/npapi/external.cpp |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Tue Mar 29 06:28:03 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1akqsV-0001yF-0u
	for mharc-gnash-commit@gnu.org; Tue, 29 Mar 2016 06:28:03 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34620)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqsP-0001xz-R7
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:28:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqsK-0008Hl-PA
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:27:57 -0400
Received: from [2001:4830:134:6::a] (port=47540 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akqsK-0008Hf-M0
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:27:52 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1akqsJ-00039E-O4; Tue, 29 Mar 2016 10:27:51 +0000
Date: Tue, 29 Mar 2016 10:27:51 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8942
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:45.0) Gecko/20100101 Firefox/45.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160329-122751.sv27281.58352@savannah.gnu.org>
References: <20160313-195734.sv82809.42746@savannah.gnu.org>
	<20160313-195959.sv82809.41145@savannah.gnu.org>
	<20160329-114514.sv27281.46794@savannah.gnu.org>
In-Reply-To: <20160329-114514.sv27281.46794@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8942] Patches to improve number value
	handling in ExternalInterface
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 10:28:01 -0000

Update of patch #8942 (project gnash):

                  Status:                    None => Ready For Test         
             Assigned to:                    None => strk                   

    _______________________________________________________

Follow-up Comment #3:

Patch1 pushed as 2f264a33249e4cfe03ff728ba2f54c6ee2b96d74
Patch2 pushed as c98c271596356118b074a4023c7816623a5514ab

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8942>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 29 06:29:39 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1akqu3-00027V-Lt
	for mharc-gnash-commit@gnu.org; Tue, 29 Mar 2016 06:29:39 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1akqu0-00026e-GE
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:29:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1akqtz-00005o-55
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:29:36 -0400
Received: from vcs.savannah.gnu.org ([208.118.235.72]:41140)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1akqtz-00005k-1Y
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:29:35 -0400
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1akqty-0001y4-RF
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 10:29:34 +0000
Date: Tue, 29 Mar 2016 10:29:34 +0000
Message-Id: <E1akqty-0001y4-RF@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: c98c271596356118b074a4023c7816623a5514ab
X-Git-Newrev: 29199b445b4a9315a1ae1006695f93a562592311
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2274-g29199b4
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 10:29:38 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  29199b445b4a9315a1ae1006695f93a562592311 (commit)
      from  c98c271596356118b074a4023c7816623a5514ab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=29199b445b4a9315a1ae1006695f93a562592311


commit 29199b445b4a9315a1ae1006695f93a562592311
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Tue Mar 29 12:28:19 2016 +0200

    Add automated property-assignment tests on fallback ExternalInterface callback context.
    
    See bug #37223 <https://savannah.gnu.org/bugs/?37223>

diff --git a/testsuite/misc-mtasc.all/extcomm.as b/testsuite/misc-mtasc.all/extcomm.as
index df80226..0f76c15 100644
--- a/testsuite/misc-mtasc.all/extcomm.as
+++ b/testsuite/misc-mtasc.all/extcomm.as
@@ -96,6 +96,7 @@ class ExternalCommTest
 					check(this !== null);
 					check_equals("" + this, "undefined");
 					check(this === _global);
+					this.nothis1_value = "script_nothis1";
 				}
 			)
 		);
@@ -112,6 +113,18 @@ class ExternalCommTest
 					check(this !== null);
 					check_equals("" + this, "undefined");
 					check(this === _global);
+					this.nothis2_value = "script_nothis2";
+				}
+			)
+		);
+
+		// Registering callback for checking _global properties shouldn't fail
+		check(
+			ExternalInterface.addCallback("script_globalcheck", mc,
+				function():Void
+				{
+					check_equals(_global.nothis1_value, "script_nothis1");
+					check_equals(_global.nothis2_value, "script_nothis2");
 				}
 			)
 		);
diff --git a/testsuite/misc-mtasc.all/extcommtests-runner.sh b/testsuite/misc-mtasc.all/extcommtests-runner.sh
index 2ac31a4..b165630 100644
--- a/testsuite/misc-mtasc.all/extcommtests-runner.sh
+++ b/testsuite/misc-mtasc.all/extcommtests-runner.sh
@@ -180,6 +180,13 @@ check_equals \
 	'<invoke name="addMethod" returntype="xml"><arguments><string>script_nothis2</string></arguments></invoke>' \
 	"Gnash should properly register script_nothis2 ExternalInterface callback"
 
+# Read for script_globalcheck callback registration statement
+read_timeout LINE \$READTIMEOUT <&3
+check_equals \
+	"\$LINE" \
+	'<invoke name="addMethod" returntype="xml"><arguments><string>script_globalcheck</string></arguments></invoke>' \
+	"Gnash should properly register script_globalcheck ExternalInterface callback"
+
 # Read for script_longarglist callback registration statement
 read_timeout LINE \$READTIMEOUT <&3
 check_equals \
@@ -241,6 +248,13 @@ echo '<invoke name="script_nothis2" returntype="xml"><arguments></arguments></in
 read_timeout LINE \$READTIMEOUT <&3
 check_equals "\$LINE" '<void/>' "Gnash should return a correct value from script_nothis2 ExternalInterface callback"
 
+# Call the script_globalcheck callback
+echo '<invoke name="script_globalcheck" returntype="xml"><arguments></arguments></invoke>' >&4
+
+# Read for callback return value statement
+read_timeout LINE \$READTIMEOUT <&3
+check_equals "\$LINE" '<void/>' "Gnash should return a correct value from script_globalcheck ExternalInterface callback"
+
 # Call the script_longarglist callback
 echo '<invoke name="script_longarglist" returntype="xml"><arguments><string>The</string><string>quick</string><string>brown</string><string>fox</string><string>jumps</string><string>over</string><string>the</string><string>lazy</string><string>dog</string></arguments></invoke>' >&4
 
@@ -281,7 +295,7 @@ XFAILED=\`expr "\$XFAILED" + "\$PLAYERXFAILED"\`
 TESTED=\`expr "\$TESTED" + "\$PLAYERPASSED" + "\$PLAYERXPASSED" + "\$PLAYERFAILED" + "\$PLAYERXFAILED"\`
 
 # Check for total number of test run
-check_totals "89" "There should be 89 tests run"
+check_totals "94" "There should be 94 tests run"
 
 # Remove temporary files
 rm "\$LOGFILE"

-----------------------------------------------------------------------

Summary of changes:
 testsuite/misc-mtasc.all/extcomm.as             |   13 +++++++++++++
 testsuite/misc-mtasc.all/extcommtests-runner.sh |   16 +++++++++++++++-
 2 files changed, 28 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Tue Mar 29 06:30:09 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1akquX-0002Fh-IZ
	for mharc-gnash-commit@gnu.org; Tue, 29 Mar 2016 06:30:09 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35111)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akquT-0002CB-Ph
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:30:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akquO-00009q-Ow
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:30:05 -0400
Received: from [2001:4830:134:6::a] (port=47684 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1akquO-00009k-LP
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 06:30:00 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1akquN-00039g-P6; Tue, 29 Mar 2016 10:29:59 +0000
Date: Tue, 29 Mar 2016 10:29:59 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8933
User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64;
	rv:45.0) Gecko/20100101 Firefox/45.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160329-122959.sv27281.32702@savannah.gnu.org>
References: <20160307-004337.sv82809.71717@savannah.gnu.org>
	<20160307-110717.sv27281.7946@savannah.gnu.org>
	<20160307-192834.sv82809.87483@savannah.gnu.org>
	<20160309-130944.sv82809.20986@savannah.gnu.org>
In-Reply-To: <20160309-130944.sv82809.20986@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8933] Patch to use `_global` as a fallback
	`this` object in ExternalInterface callback
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 10:30:07 -0000

Update of patch #8933 (project gnash):

                  Status:             In Progress => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #4:

Redundancy is not a problem when applied to tests.
Patch 2 of 2 pushed as 29199b445b4a9315a1ae1006695f93a562592311
Thanks!

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8933>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



From MAILER-DAEMON Tue Mar 29 14:06:10 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aky1q-0002d2-QM
	for mharc-gnash-commit@gnu.org; Tue, 29 Mar 2016 14:06:10 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49186)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aky1n-0002a6-UB
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 14:06:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aky1h-0005ET-Ng
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 14:06:07 -0400
Received: from vcs.savannah.gnu.org ([208.118.235.72]:45965)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <strk@keybit.net>) id 1aky1h-0005EK-JG
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 14:06:01 -0400
Received: from strk by vcs.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <strk@keybit.net>) id 1aky1h-0005ip-3e
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 18:06:01 +0000
Date: Tue, 29 Mar 2016 18:06:01 +0000
Message-Id: <E1aky1h-0005ip-3e@vcs.savannah.gnu.org>
To: gnash-commit@gnu.org
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: 29199b445b4a9315a1ae1006695f93a562592311
X-Git-Newrev: 484ca4cd2fecb73c3308fd451004f6cc2e976fbe
From: Sandro Santilli <strk@keybit.net>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 208.118.235.72
Subject: [Gnash-commit] [SCM] Gnash branch, master,
	updated. release_0_8_9_final-2276-g484ca4c
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 18:06:09 -0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  484ca4cd2fecb73c3308fd451004f6cc2e976fbe (commit)
       via  a794319ac28c02365eddffd571a37c3ec4fb1eea (commit)
      from  29199b445b4a9315a1ae1006695f93a562592311 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=484ca4cd2fecb73c3308fd451004f6cc2e976fbe


commit 484ca4cd2fecb73c3308fd451004f6cc2e976fbe
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Tue Mar 29 19:19:50 2016 +0200

    Add automated tests on no-context function call via Function.call() and Function.apply().
    
    See bug #47354 <https://savannah.gnu.org/bugs/?47354>

diff --git a/testsuite/actionscript.all/Function.as b/testsuite/actionscript.all/Function.as
index b8b693f..e844403 100644
--- a/testsuite/actionscript.all/Function.as
+++ b/testsuite/actionscript.all/Function.as
@@ -1,5 +1,5 @@
 // 
-//   Copyright (C) 2005, 2006, 2007, 2009, 2010 Free Software
+//   Copyright (C) 2005, 2006, 2007, 2009, 2010, 2011, 2016 Free Software
 //   Foundation, Inc
 //
 // This program is free software; you can redistribute it and/or modify
@@ -35,6 +35,14 @@ check( ! Function.hasOwnProperty('__constructor__') );
 // Define a function returning 'this'.name and the given args
 function getThisName(a,b,c) { return this.name+a+b+c; }
 
+#if OUTPUT_VERSION >= 6
+// Define a function for checking 'this' against '_global' object
+function isThisGlobal() { return this===_global; }
+#endif
+
+// Define a function which set a property named 'instanceCheck' to 'this'
+function setThisMember(value) { this.instanceCheck=value; }
+
 // Every newly created function's super class is Object
 check_equals(getThisName.prototype.__proto__, Object.prototype);
 
@@ -121,6 +129,21 @@ var ret=getThisName.apply(undefined, "7");
   check_equals ( ret , 0 );
 #endif
 
+// Test Function.apply() with 'thisObject' being unspecified, 'undefined',
+// or 'null'
+
+function setThisMember_apply_noarg() { this.instanceCheck = "apply_no_this"; }
+check ( isThisGlobal.apply() );
+check ( isThisGlobal.apply(undefined) );
+check ( isThisGlobal.apply(null) );
+setThisMember_apply_noarg.apply();
+check_equals ( _global.instanceCheck, "apply_no_this" );
+setThisMember.apply(undefined, ["apply_undefined_this"]);
+check_equals ( _global.instanceCheck, "apply_undefined_this" );
+setThisMember.apply(null, ["apply_null_this"]);
+check_equals ( _global.instanceCheck, "apply_null_this" );
+check ( delete _global.instanceCheck );
+
 #else // OUTPUT_VERSION < 6
 
 // No Function.apply... for SWF up to 5
@@ -162,6 +185,33 @@ check_equals(typeof(ret), 'object');
 check_equals(ret, undefined); // an object type which returns 'undefined' as primitive value ?
 check( ! (ret === undefined) ); // an object type which returns 'undefined' as primitive value ?
 check( ! (ret === null) ); // an object type which returns 'undefined' as primitive value ?
+check( ret === _global ); // an object is actually the '_global' ?
+ret = getThis.call(undefined);
+check_equals(c, 3);
+check_equals(typeof(ret), 'object');
+check_equals(ret, undefined); // an object type which returns 'undefined' as primitive value ?
+check( ! (ret === undefined) ); // an object type which returns 'undefined' as primitive value ?
+check( ! (ret === null) ); // an object type which returns 'undefined' as primitive value ?
+check( ret === _global ); // an object is actually the '_global' ?
+ret = getThis.call();
+check_equals(c, 4);
+check_equals(typeof(ret), 'object');
+check_equals(ret, undefined); // an object type which returns 'undefined' as primitive value ?
+check( ! (ret === undefined) ); // an object type which returns 'undefined' as primitive value ?
+check( ! (ret === null) ); // an object type which returns 'undefined' as primitive value ?
+check( ret === _global ); // an object is actually the '_global' ?
+
+// Test Function.call() with 'thisObject' being unspecified, 'undefined',
+// or 'null'
+
+function setThisMember_call_noarg() { this.instanceCheck = "call_no_this"; }
+setThisMember_call_noarg.call();
+check_equals(_global.instanceCheck, "call_no_this");
+setThisMember.call(undefined, "call_undefined_this");
+check_equals(_global.instanceCheck, "call_undefined_this");
+setThisMember.call(null, "call_null_this");
+check_equals(_global.instanceCheck, "call_null_this");
+check(delete _global.instanceCheck);
 
 retCaller = 'custom'; 
 myCaller = function()
@@ -1077,8 +1127,8 @@ check_equals(called, 0);
  check_totals(150); // SWF5
 #endif
 #if OUTPUT_VERSION == 6
- check_totals(239); // SWF6
+ check_totals(263); // SWF6
 #endif
 #if OUTPUT_VERSION >= 7
- check_totals(240); // SWF7,SWF8
+ check_totals(264); // SWF7,SWF8
 #endif

http://git.savannah.gnu.org/cgit//commit/?id=a794319ac28c02365eddffd571a37c3ec4fb1eea


commit a794319ac28c02365eddffd571a37c3ec4fb1eea
Author: Nutchanon Wetchasit <Nutchanon.Wetchasit@gmail.com>
Date:   Tue Mar 29 19:19:24 2016 +0200

    Use _global as a fallback "this" object in Function.call() and Function.apply().
    
    See bug #47354 <https://savannah.gnu.org/bugs/?47354>

diff --git a/libcore/asobj/Function_as.cpp b/libcore/asobj/Function_as.cpp
index f276109..879c927 100644
--- a/libcore/asobj/Function_as.cpp
+++ b/libcore/asobj/Function_as.cpp
@@ -104,13 +104,13 @@ function_apply(const fn_call& fn)
         IF_VERBOSE_ASCODING_ERRORS(
             log_aserror(_("Function.apply() called with no args"));
         );
-        new_fn_call.this_ptr = new as_object(getGlobal(fn));
+        new_fn_call.this_ptr = &getGlobal(fn);
 	}
 	else {
 		// Get the object to use as 'this' reference
 		as_object* obj = toObject(fn.arg(0), getVM(fn));
 
-        if (!obj) obj = new as_object(getGlobal(fn)); 
+        if (!obj) obj = &getGlobal(fn);
 
         new_fn_call.this_ptr = obj;
 
@@ -156,7 +156,7 @@ function_call(const fn_call& fn)
     as_object* tp;
 
     if (!fn.nargs || fn.arg(0).is_undefined() || fn.arg(0).is_null()) {
-        tp = new as_object(getGlobal(fn));
+        tp = &getGlobal(fn);
     }
     else tp = toObject(fn.arg(0), getVM(fn));
 

-----------------------------------------------------------------------

Summary of changes:
 libcore/asobj/Function_as.cpp          |    6 ++--
 testsuite/actionscript.all/Function.as |   56 ++++++++++++++++++++++++++++++--
 2 files changed, 56 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Gnash


From MAILER-DAEMON Tue Mar 29 14:06:24 2016
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1aky24-0002eZ-4g
	for mharc-gnash-commit@gnu.org; Tue, 29 Mar 2016 14:06:24 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49250)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aky1y-0002dm-O7
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 14:06:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aky1s-0005GM-TF
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 14:06:18 -0400
Received: from [2001:4830:134:6::a] (port=60719 helo=frontend.savannah.gnu.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <www-data@savannah.gnu.org>) id 1aky1s-0005GH-QV
	for gnash-commit@gnu.org; Tue, 29 Mar 2016 14:06:12 -0400
Received: from www-data by frontend.savannah.gnu.org with local (Exim 4.72)
	(envelope-from <www-data@savannah.gnu.org>)
	id 1aky1q-0004hi-8V; Tue, 29 Mar 2016 18:06:10 +0000
Date: Tue, 29 Mar 2016 18:06:10 +0000
To: Sandro Santilli <strk@keybit.net>,
	Nutchanon Wetchasit <Nachanon.Vetjasit@gmail.com>, gnash-commit@gnu.org
X-PHP-Originating-Script: 0:sendmail.php
From: Sandro Santilli <INVALID.NOREPLY@gnu.org>
X-Savane-Server: savannah.gnu.org:443 [208.118.235.70]
MIME-Version: 1.0
Content-Type: text/plain;charset=UTF-8
X-Savane-Project: gnash
X-Savane-Tracker: patch
X-Savane-Item-ID: 8935
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:29.0) Gecko/20100101 Firefox/29.0
X-Apparently-From: 46.232.148.34 (Savane authenticated user strk)
Message-Id: <20160329-200610.sv27281.48146@savannah.gnu.org>
References: <20160308-221637.sv82809.48987@savannah.gnu.org>
	<20160308-191735.sv27281.54649@savannah.gnu.org>
	<20160310-180345.sv82809.5151@savannah.gnu.org>
	<20160310-180851.sv82809.27244@savannah.gnu.org>
	<20160310-181152.sv82809.8177@savannah.gnu.org>
In-Reply-To: <20160310-181152.sv82809.8177@savannah.gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:6::a
Subject: [Gnash-commit] [patch #8935] Patch for providing `_global` as a
	fallback instance in `Function.call()` and `Function.apply()`
X-BeenThere: gnash-commit@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Gnash CVS commit messages <gnash-commit.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/gnash-commit>
List-Post: <mailto:gnash-commit@gnu.org>
List-Help: <mailto:gnash-commit-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/gnash-commit>,
	<mailto:gnash-commit-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 18:06:22 -0000

Update of patch #8935 (project gnash):

                  Status:                    None => Done                   
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #5:

Patch1: a794319ac28c02365eddffd571a37c3ec4fb1eea
Patch2: 484ca4cd2fecb73c3308fd451004f6cc2e976fbe

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/



