From MAILER-DAEMON Tue Jul 18 18:03:55 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dXaaw-0000JM-SO
	for mharc-gpsd-dev@gnu.org; Tue, 18 Jul 2017 18:03:54 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52745)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dXaav-0000Hl-7T
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:03:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dXaaq-000377-BF
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:03:53 -0400
Received: from d.mail.sonic.net ([64.142.111.50]:34248)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dXaaq-00035m-1C
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:03:48 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v6IM3cH8030258
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
	Tue, 18 Jul 2017 15:03:38 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v6IM3ccY015222;
	Tue, 18 Jul 2017 15:03:38 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v6IM3bQ4015219; 
	Tue, 18 Jul 2017 15:03:37 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Tue, 18 Jul 2017 15:03:37 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: GPSD Developers List <gpsd-dev@nongnu.org>
cc: "Robin H. Johnson" <robbat2@gentoo.org>
In-Reply-To: <20170528205131.31057-1-robbat2@gentoo.org>
Message-ID: <Pine.LNX.4.58L1X.1707181455390.12398@bolt.sonic.net>
References: <20170528205131.31057-1-robbat2@gentoo.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVYQyzPmlQR0jB5ohnoIHeJNMzxnxlHsQ0KOIGAK7t7pGYFodkpKjMEAmxpLyzDYNEeG3fV6ZVqkaFqlI7BbUafG
X-Sonic-ID: C;luaZ8wRs5xGgzfsKk0eh0A== M;pC6y8wRs5xGgzfsKk0eh0A==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.50
Subject: Re: [gpsd-dev] [PATCH 1/2] gpsprof: fix replot
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jul 2017 22:03:54 -0000


On Sun, 28 May 2017, Robin H. Johnson wrote:

> gpsprof's replot functionality feeds JSON back to a session, but relies
> on the oldstyle keydict to read fields out for analysis.
>
> Refactor gps.gps.read() to have common code for handling JSON input &
> using the shim-setter, then wire gpsprof to feed JSON into the new
> function.
[...]

This change breaks xgps (and perhaps other things):
========================================================================
MacPro:gpsd fw$ xgps -r95 time
Traceback (most recent call last):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/gi/overrides/GLib.py", line 735, in <lambda>
    func_fdtransform = lambda _, cond, *data: callback(channel, cond, *data)
  File "/usr/local/bin/xgps", line 867, in handle_response
    if self.daemon.read() == -1:
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/gps/gps.py", line 264, in read
    self.interpret_json(self.response)
AttributeError: 'gps' object has no attribute 'interpret_json'
========================================================================

Also, when testing gpsprof, I noticed some questionable lines with "nan"
in the output.

Fred Wright


From MAILER-DAEMON Tue Jul 18 18:05:05 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dXac5-0001II-CS
	for mharc-gpsd-dev@gnu.org; Tue, 18 Jul 2017 18:05:05 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53039)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dXac2-0001GE-Qz
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:05:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dXabx-0004DH-Tg
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:05:02 -0400
Received: from c.mail.sonic.net ([64.142.111.80]:46982)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dXabx-0004CS-K6
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:04:57 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by c.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v6IM4qLr028214
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
	Tue, 18 Jul 2017 15:04:53 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v6IM4qHr015489;
	Tue, 18 Jul 2017 15:04:52 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v6IM4qTt015486; 
	Tue, 18 Jul 2017 15:04:52 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Tue, 18 Jul 2017 15:04:52 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: GPSD Developers List <gpsd-dev@nongnu.org>
cc: "Robin H. Johnson" <robbat2@gentoo.org>
In-Reply-To: <20170528205131.31057-2-robbat2@gentoo.org>
Message-ID: <Pine.LNX.4.58L1X.1707181503550.12398@bolt.sonic.net>
References: <20170528205131.31057-1-robbat2@gentoo.org>
	<20170528205131.31057-2-robbat2@gentoo.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVYXixbViDWaZkaFfkNZyPV6QDbBHLXBQysUxgB03kBhJTN52YPOj1xprca1qwzo44zAGW2lAyTHFcnQPhYzz/Nz
X-Sonic-ID: C;Qt0uIAVs5xGOZ8GbEi49jA== M;siVYIAVs5xGOZ8GbEi49jA==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.80
Subject: Re: [gpsd-dev] [PATCH 2/2] gpsprof: accept valid samples only.
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jul 2017 22:05:03 -0000


On Sun, 28 May 2017, Robin H. Johnson wrote:

> Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
[...]

Merged (without PATCH 1/2).

Fred Wright


From MAILER-DAEMON Tue Jul 18 18:10:28 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dXahI-0006mr-Cz
	for mharc-gpsd-dev@gnu.org; Tue, 18 Jul 2017 18:10:28 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dXahG-0006ks-2z
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:10:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dXahB-00079T-52
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:10:26 -0400
Received: from d.mail.sonic.net ([64.142.111.50]:42942)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dXahA-000790-Ri
	for gpsd-dev@nongnu.org; Tue, 18 Jul 2017 18:10:21 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v6IMAHpc005487
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
	Tue, 18 Jul 2017 15:10:17 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v6IMAH4o017138;
	Tue, 18 Jul 2017 15:10:17 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v6IMAHAm017135; 
	Tue, 18 Jul 2017 15:10:17 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Tue, 18 Jul 2017 15:10:17 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: GPSD Developers List <gpsd-dev@nongnu.org>
In-Reply-To: <CACmBxyt36gwr1qaqygnyVR1PZO-Y3sE3yht06Y4vjhyQbbvbwA@mail.gmail.com>
Message-ID: <Pine.LNX.4.58L1X.1707181505440.12398@bolt.sonic.net>
References: <CACmBxyt36gwr1qaqygnyVR1PZO-Y3sE3yht06Y4vjhyQbbvbwA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVaiBwAD6W9a6KqK7+RHX6EmCYuvqztHmrefN0Du0q13e4y36F8o8EXyZ3ppM+5YC9ptz+2ODGL+1CUwutmpTn1Q
X-Sonic-ID: C;UlqZ4QVs5xG4mfsKk0eh0A== M;Bjav4QVs5xG4mfsKk0eh0A==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.50
Subject: Re: [gpsd-dev] Patch: Fix ref-leak of PyObject_Call
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jul 2017 22:10:27 -0000


On Tue, 30 May 2017, Kurt Schwehr wrote:

> Tested with scons check.
>
> This is my first use of git format-patch, so hopefully I haven't bungled
> anything.

The format-patch was fine.  It's usually preferable to send as a direct
email (e.g., via "git send-email"), unless the patch has email
compatibility issues such as long lines or funny characters.

Merged.

Fred Wright


From MAILER-DAEMON Wed Jul 19 09:11:54 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dXold-0004Il-Uu
	for mharc-gpsd-dev@gnu.org; Wed, 19 Jul 2017 09:11:53 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53504)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Clark.Li@cohdawireless.com>) id 1dXns1-0002tU-DE
	for gpsd-dev@nongnu.org; Wed, 19 Jul 2017 08:14:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Clark.Li@cohdawireless.com>) id 1dXnry-0005g2-1L
	for gpsd-dev@nongnu.org; Wed, 19 Jul 2017 08:14:25 -0400
Received: from mail1.bemta12.messagelabs.com ([216.82.251.17]:37402)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <Clark.Li@cohdawireless.com>)
	id 1dXnrx-0005dw-Nk
	for gpsd-dev@nongnu.org; Wed, 19 Jul 2017 08:14:21 -0400
Received: from [216.82.249.212] by server-17.bemta-12.messagelabs.com id
	56/2F-01736-B1D4F695; Wed, 19 Jul 2017 12:14:19 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRWlGSWpSXmKPExsVScuVmmq6Ub36
	kwY4dNhZrnt9hdWD0eHJtM1MAYxRrZl5SfkUCa0brx5nsBZN8K1pPnGJtYFxl3cXIxSEk0M8o
	0dfVw9zFyMnBJqAtcWjSUzBbREBfYuKEW2wgtrCAisTkt7tYIeKaEqeOv2GEsI0kDj35zNTFy
	MHBIqAqcfmEOUiYV8BPYs/5nUwgtpCAncSZ3bPZQWxOAXuJC4/ng8UZBWQlJk09DGYzC4hL3H
	oCEZcQEJBYsuc8M4QtKvHy8T9WCFtRYvnfjawQ9ToSC3Z/YoOwtSWWLXzNDLFXUOLkzCcsExi
	FZiEZOwtJyywkLbOQtCxgZFnFqFGcWlSWWqRrbKaXVJSZnlGSm5iZo2toaKSXm1pcnJiempOY
	VKyXnJ+7iREY5PUMDIw7GM8ujD7EKMnBpCTKO4c3P1KILyk/pTIjsTgjvqg0J7X4EKMMB4eSB
	C+nD1BOsCg1PbUiLTMHGG8waQkOHiURXg2QNG9xQWJucWY6ROoUo6KUOO85b6CEAEgiozQPrg
	0W45cYZaWEeRkZGBiEeApSi3IzS1DlXzGKczAqCfO6g4znycwrgZv+CmgxE9BiYd8ckMUliQg
	pqQZG3kkiE3X/3ZssJ5ZQJfp9n1YG39xg1hbOYwYZBxxrrZWSPtfpRMVtTt+zzlqTIeCp0569
	13avOnzvw9KXBveaXj3qN36cNNdpOfcJsfPvtrb6Z4YsWNZVy1HweLOidJrx8d/5X3j0lG/U/
	UtmO5zT08ifbTVr8bPgg7Y8xnOeJSlt33ClaeU/JZbijERDLeai4kQAsP/WzewCAAA=
X-Env-Sender: Clark.Li@cohdawireless.com
X-Msg-Ref: server-8.tower-219.messagelabs.com!1500466456!175435641!1
X-Originating-IP: [116.212.217.102]
X-StarScan-Received: 
X-StarScan-Version: 9.4.25; banners=cohdawireless.com,-,-
X-VirusChecked: Checked
Received: (qmail 7655 invoked from network); 19 Jul 2017 12:14:18 -0000
Received: from unknown (HELO webmail.cohdawireless.com) (116.212.217.102)
	by server-8.tower-219.messagelabs.com with DHE-RSA-AES256-SHA encrypted
	SMTP; 19 Jul 2017 12:14:18 -0000
Received: from CW-SVR13.cohda.wireless ([::1]) by cw-svr13.cohda.wireless
	([::1]) with mapi id 14.03.0319.002; Wed, 19 Jul 2017 21:43:45 +0930
From: Clark Li <Clark.Li@cohdawireless.com>
To: "gpsd-dev@nongnu.org" <gpsd-dev@nongnu.org>
Thread-Topic: [PATCH] Support UBX NAV-PVT
Thread-Index: AQHTAIg6LMFyO5ecyEyXU9/Cd+OjcqJbD4Ig
Date: Wed, 19 Jul 2017 12:13:44 +0000
Message-ID: <4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
References: <20170719121131.5169-1-clark.li@cohdawireless.com>
In-Reply-To: <20170719121131.5169-1-clark.li@cohdawireless.com>
Accept-Language: en-US, en-AU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [115.70.26.209]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]
X-Received-From: 216.82.251.17
X-Mailman-Approved-At: Wed, 19 Jul 2017 09:11:53 -0400
Subject: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jul 2017 12:14:27 -0000

NAV-SOL has only been retained for backwards compatibility; users are reco=
mmended to use the UBX-NAV-PVT message in preference.

Check valid flags of iTOW and fTOW and process fTOW whose range is
+-500us
---
 driver_ubx.c                     | 172 +++++++++++++++++++++++++++++++++-=
-----
 driver_ubx.h                     |  11 +++
 test/daemon/ublox-aek-4t.log.chk |   2 +-
 3 files changed, 161 insertions(+), 24 deletions(-)

diff --git a/driver_ubx.c b/driver_ubx.c index 88be6c07..358d0a61 100644
--- a/driver_ubx.c
+++ b/driver_ubx.c
@@ -130,19 +130,129 @@ static gps_mask_t  ubx_msg_nav_pvt(struct gps_devic=
e_t *session, unsigned char *buf,
 =09=09size_t data_len)
 {
-    unsigned int flags;
+    uint8_t valid;
+    uint8_t flags;
+    uint8_t navmode;
+    struct tm unpacked_date;
+    double subseconds;
+    double hacc, vacc, sacc;
+    int *status =3D &session->gpsdata.status;
+    int *mode =3D &session->newdata.mode;
     gps_mask_t mask =3D 0;
=20
     if (data_len !=3D 92)
-=09return 0;
+        return 0;
=20
+    valid =3D (unsigned int)getub(buf, 11);
+    navmode =3D (unsigned char)getub(buf, 20);
     flags =3D (unsigned int)getub(buf, 21);
=20
-    /* TODO: finish decoding UBX_MON_PVT
-     * no need until depreacaed UBX_MON_SOL is dead
-     */
+    switch (navmode)
+    {
+    case UBX_MODE_TMONLY:
+    {
+        if (*mode !=3D MODE_NO_FIX) {
+            *mode =3D MODE_NO_FIX;
+            mask |=3D MODE_SET;
+        }
+        if (*status !=3D STATUS_NO_FIX) {
+            *status =3D STATUS_NO_FIX;
+            mask |=3D STATUS_SET;
+        }
+        break;
+    }
+    case UBX_MODE_3D:
+    case UBX_MODE_GPSDR:
+    {
+        if (*mode !=3D MODE_3D) {
+            *mode =3D MODE_3D;
+            mask |=3D MODE_SET;
+        }
+        if ((flags & UBX_NAV_PVT_FLAG_DGPS) =3D=3D UBX_NAV_PVT_FLAG_DGPS)=
 {
+            if (*status !=3D STATUS_DGPS_FIX) {
+                *status =3D STATUS_DGPS_FIX;
+                mask |=3D STATUS_SET;
+            }
+        } else {
+            if (*status !=3D STATUS_FIX) {
+                *status =3D STATUS_FIX;
+                mask |=3D STATUS_SET;
+            }
+        }
+        mask |=3D   LATLON_SET | ALTITUDE_SET | SPEED_SET | TRACK_SET | C=
LEAR_IS
+                | REPORT_IS;
+        break;
+    }
+    case UBX_MODE_2D:
+    case UBX_MODE_DR:        /* consider this too as 2D */
+    {
+        if (*mode !=3D MODE_2D) {
+            *mode =3D MODE_2D;
+            mask |=3D MODE_SET;
+        };
+        if (*status !=3D STATUS_FIX) {
+            *status =3D STATUS_FIX;
+            mask |=3D STATUS_SET;
+        }
+        mask |=3D LATLON_SET | SPEED_SET;
+        break;
+    }
+    default:
+    {
+        if (*mode !=3D MODE_NO_FIX) {
+            *mode =3D MODE_NO_FIX;
+            mask |=3D MODE_SET;
+        };
+        if (*status !=3D STATUS_NO_FIX) {
+            *status =3D STATUS_NO_FIX;
+            mask |=3D STATUS_SET;
+        }
+        break;
+    }
+    }
+
+    if ((valid & UBX_NAV_PVT_VALID_DATE_TIME) =3D=3D UBX_NAV_PVT_VALID_DA=
TE_TIME) {
+        unpacked_date.tm_year =3D (uint16_t)getleu16(buf, 4) - 1900;
+     =20  unpacked_date.tm_mon =3D (uint8_t)getub(buf, 6) - 1;
+        unpacked_date.tm_mday =3D (uint8_t)getub(buf, 7);
+        unpacked_date.tm_hour =3D (uint8_t)getub(buf, 8);
+        unpacked_date.tm_min =3D (uint8_t)getub(buf, 9);
+        unpacked_date.tm_sec =3D (uint8_t)getub(buf, 10);
+        unpacked_date.tm_isdst =3D 0;
+        unpacked_date.tm_wday =3D 0;
+        unpacked_date.tm_yday =3D 0;
+        subseconds =3D 1e-9 * (int32_t)getles32(buf, 16);
+        session->newdata.time =3D \
+            (timestamp_t)mkgmtime(&unpacked_date) + subseconds;
+        mask |=3D TIME_SET | NTPTIME_IS;
+    }
+
+    session->newdata.longitude =3D 1e-7 * (int32_t)getles32(buf, 24);
+    session->newdata.latitude =3D 1e-7 * (int32_t)getles32(buf, 28);
+    session->newdata.altitude =3D 1e-3 * (int32_t)getles32(buf, 32);
+    session->newdata.speed =3D 1e-3 * (int32_t)getles32(buf, 60);
+    session->newdata.track =3D 1e-5 * (int32_t)getles32(buf, 64);
+    hacc =3D (double)(getles32(buf, 40) / 1000.0);
+    vacc =3D (double)(getles32(buf, 44) / 1000.0);
+    sacc =3D (double)(getles32(buf, 48) / 1000.0);
+    // epx ^ 2 + epy ^ 2 =3D hacc ^ 2
+    session->newdata.epx =3D session->newdata.epy =3D 0.707 * hacc;
+    session->newdata.epv =3D vacc;
+    session->newdata.eps =3D sacc;
+    mask |=3D HERR_SET | VERR_SET | SPEEDERR_SET;
     gpsd_log(&session->context->errout, LOG_DATA,
-=09     "NAV-PVT: flags:%02x\n", flags);
+         "NAV_PVT: flags=3D%02x time=3D%.2f lat=3D%.2f lon=3D%.2f alt=3D%=
.2f track=3D%.2f speed=3D%.2f climb=3D%.2f mode=3D%d status=3D%d used=3D%d=
\n",
+         flags,
+         session->newdata.time,
+         session->newdata.latitude,
+         session->newdata.longitude,
+         session->newdata.altitude,
+         session->newdata.track,
+         session->newdata.speed,
+         session->newdata.climb,
+         session->newdata.mode,
+         session->gpsdata.status,
+         session->gpsdata.satellites_used);
     return mask;
 }
=20
@@ -166,10 +276,12 @@ ubx_msg_nav_sol(struct gps_device_t *session, unsign=
ed char *buf,
 #define DATE_VALID=09(UBX_SOL_VALID_WEEK | UBX_SOL_VALID_TIME)
     if ((flags & DATE_VALID) =3D=3D DATE_VALID) {
 =09unsigned short gw;
-=09unsigned int tow;
-=09tow =3D (unsigned int)getleu32(buf, 0);
+=09unsigned int iTOW;
+=09int fTOW;
+=09iTOW =3D (unsigned int)getleu32(buf, 0);
+=09fTOW =3D (int)getles32(buf, 4);
 =09gw =3D (unsigned short)getles16(buf, 8);
-=09session->newdata.time =3D gpsd_gpstime_resolve(session, gw, tow / 1000=
.0);
+=09session->newdata.time =3D gpsd_gpstime_resolve(session, gw, (iTOW *=20=

+1e-3) + (fTOW * 1e-9));
 =09mask |=3D TIME_SET | NTPTIME_IS;
     }
 #undef DATE_VALID
@@ -292,24 +404,38 @@ static gps_mask_t
 ubx_msg_nav_timegps(struct gps_device_t *session, unsigned char *buf,
 =09=09    size_t data_len)
 {
-    unsigned int gw, tow, flags;
+    unsigned int gw, iTOW, flags;
+    int fTOW;
+    gps_mask_t mask =3D 0;
=20
     if (data_len !=3D 16)
-=09return 0;
+        return 0;
=20
-    tow =3D (unsigned int)getleu32(buf, 0);
-    gw =3D (unsigned int)getles16(buf, 8);
     flags =3D (unsigned int)getub(buf, 11);
-    if ((flags & 0x7) !=3D 0)
-=09session->context->leap_seconds =3D (int)getub(buf, 10);
-    session->newdata.time =3D gpsd_gpstime_resolve(session,
-=09=09=09=09=09      (unsigned short int)gw,
-=09=09=09=09=09      (double)tow / 1000.0);
+
+    // Valid leap seconds
+    if ((flags & UBX_TIMEGPS_VALID_LEAP_SECOND) =3D=3D UBX_TIMEGPS_VALID_=
LEAP_SECOND)
+        session->context->leap_seconds =3D (int)getub(buf, 10);
+
+    // Valid GPS time of week and week number #define VALID_TIME=20
+(UBX_TIMEGPS_VALID_TIME | UBX_TIMEGPS_VALID_WEEK)
+    if ((flags & VALID_TIME) =3D=3D VALID_TIME) #undef VALID_TIME
+    {
+        iTOW =3D (unsigned int)getleu32(buf, 0);
+        fTOW =3D (int)getles32(buf, 4);
+        gw =3D (unsigned int)getles16(buf, 8);
+        session->newdata.time =3D
+          gpsd_gpstime_resolve(session,
+                               (unsigned short int)gw,
+                               ((double)iTOW * 1e-3) + ((double)fTOW * 1e=
-9));
+        mask |=3D (TIME_SET | NTPTIME_IS);
+    }
=20
     gpsd_log(&session->context->errout, LOG_DATA,
-=09     "TIMEGPS: time=3D%.2f leap=3D%d, mask=3D{TIME}\n",
-=09  =20  session->newdata.time, session->context->leap_seconds);
-    return TIME_SET | NTPTIME_IS;
+             "TIMEGPS: time=3D%.2f mask=3D{TIME}\n",
+             session->newdata.time);
+    return mask;
 }
=20
 /**
@@ -486,8 +612,8 @@ gps_mask_t ubx_parse(struct gps_device_t * session, un=
signed char *buf,
 =09break;
     case UBX_NAV_PVT:
 =09gpsd_log(&session->context->errout, LOG_PROG, "UBX_NAV_PVT\n");
-=09mask =3D ubx_msg_nav_pvt(session, &buf[UBX_PREFIX_LEN], data_len);
-        break;
+=09mask =3D ubx_msg_nav_pvt(session, &buf[UBX_PREFIX_LEN], data_len)
+             | (CLEAR_IS | REPORT_IS);
     case UBX_NAV_POSUTM:
 =09gpsd_log(&session->context->errout, LOG_DATA, "UBX_NAV_POSUTM\n");
 =09break;
diff --git a/driver_ubx.h b/driver_ubx.h index c23efdf7..99ef9b98 100644
--- a/driver_ubx.h
+++ b/driver_ubx.h
@@ -102,6 +102,10 @@ typedef enum {
 #define UBX_SOL_VALID_WEEK 0x04
 #define UBX_SOL_VALID_TIME 0x08
=20
+#define UBX_TIMEGPS_VALID_TIME        0x01
+#define UBX_TIMEGPS_VALID_WEEK        0x02
+#define UBX_TIMEGPS_VALID_LEAP_SECOND 0x04
+
 /* from UBX_NAV_SVINFO */
 #define UBX_SAT_USED 0x01
 #define UBX_SAT_DGPS 0x02
@@ -118,4 +122,11 @@ typedef enum {
 #define UBX_SIG_CDCRLK2 6
 #define UBX_SIG_NAVMSG 7
=20
+#define UBX_NAV_PVT_VALID_DATE      0x01
+#define UBX_NAV_PVT_VALID_TIME      0x02
+#define UBX_NAV_PVT_VALID_DATE_TIME (UBX_NAV_PVT_VALID_DATE |=20
+UBX_NAV_PVT_VALID_TIME)
+
+#define UBX_NAV_PVT_FLAG_GPS_FIX_OK 0x01
+#define UBX_NAV_PVT_FLAG_DGPS       0x02
+
 #endif /* _GPSD_UBX_H_ */
diff --git a/test/daemon/ublox-aek-4t.log.chk b/test/daemon/ublox-aek-4t.l=
og.chk
index 45680ea6..31acd979 100644
--- a/test/daemon/ublox-aek-4t.log.chk
+++ b/test/daemon/ublox-aek-4t.log.chk
@@ -26,4 +26,4 @@ $GPZDA,231127.00,23,12,2007,00,00*65
 $GPGGA,231126,2037.7569,N,08704.0845,W,2,07,1.67,75.75,M,-13.865,M,,*4C
 $GPRMC,231126,A,2037.7569,N,08704.0845,W,0.0000,0.000,231207,,*36
 $GPGSA,A,3,15,2,30,5,12,18,135,,,,,,2.6,1.7,2.0*0F
-{"class":"TPV","status":2,"mode":3,"time":"2007-12-23T23:11:26.999Z","ept=
":0.005,"lat":20.629281718,"lon":-87.068075424,"alt":75.754,"epx":2.973,"e=
py":6.138,"epv":11.443,"track":0.0000,"speed":0.000,"climb":0.000,"eps":0.=
17,"epc":22.89}
+{"class":"TPV","status":2,"mode":3,"time":"2007-12-23T23:11:26.999Z","e
+pt":0.005,"lat":20.629281718,"lon":-87.068075424,"alt":75.754,"epx":2.9
+73,"epy":6.138,"epv":11.443,"track":0.0000,"speed":0.000,"climb":0.000,
+"eps":0.17,"epc":22.88}
--
2.13.0

This communication may contain confidential or copyright information. If y=
ou are not an intended recipient, you must not keep, forward, copy, use, s=
ave or rely on this communication, and any such action is unauthorized and=
 prohibited. If you have received this communication in error, please repl=
y to this email to notify the sender of its incorrect delivery and then de=
lete both the original message and your reply.


From MAILER-DAEMON Thu Jul 20 00:59:28 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dY3Ye-00088g-C6
	for mharc-gpsd-dev@gnu.org; Thu, 20 Jul 2017 00:59:28 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51084)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dY3Yb-000888-D2
	for gpsd-dev@nongnu.org; Thu, 20 Jul 2017 00:59:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dY3YY-0000La-CN
	for gpsd-dev@nongnu.org; Thu, 20 Jul 2017 00:59:25 -0400
Received: from d.mail.sonic.net ([64.142.111.50]:38174)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dY3YY-0000Jq-1g
	for gpsd-dev@nongnu.org; Thu, 20 Jul 2017 00:59:22 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v6K4xF7X031406
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
	for <gpsd-dev@nongnu.org>; Wed, 19 Jul 2017 21:59:15 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v6K4xFl5003388
	for <gpsd-dev@nongnu.org>; Wed, 19 Jul 2017 21:59:15 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v6K4xFqL003385
	for <gpsd-dev@nongnu.org>; Wed, 19 Jul 2017 21:59:15 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Wed, 19 Jul 2017 21:59:15 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: "gpsd-dev@nongnu.org" <gpsd-dev@nongnu.org>
In-Reply-To: <4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
Message-ID: <Pine.LNX.4.58L1X.1707192157040.1086@bolt.sonic.net>
References: <20170719121131.5169-1-clark.li@cohdawireless.com>
	<4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVatRBlcX2saB3QRCixlIkxvQTMQCHmRKVDqodYLBwCeEdnEnkIi2eWz0DY6CfgAbsdKMJBIyqTNEwM8fJNi7/6e
X-Sonic-ID: C;krUDLght5xGYtvsKk0eh0A== M;9igiLght5xGYtvsKk0eh0A==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.50
Subject: Re: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jul 2017 04:59:26 -0000


On Wed, 19 Jul 2017, Clark Li wrote:

> NAV-SOL has only been retained for backwards compatibility; users are recommended to use the UBX-NAV-PVT message in preference.
[...]

Since you presumably have a relevant receiver and a setup to use the new
message, it would be a good idea to include a test case for it.

Your existing patch to one of the expected test results seems to be solely
to expect the addition of some inappropriate line breaks.

Fred Wright


From MAILER-DAEMON Thu Jul 20 05:15:31 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dY7YR-0007Q0-Cn
	for mharc-gpsd-dev@gnu.org; Thu, 20 Jul 2017 05:15:31 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Clark.Li@cohdawireless.com>) id 1dY7YN-0007Pb-4T
	for gpsd-dev@nongnu.org; Thu, 20 Jul 2017 05:15:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Clark.Li@cohdawireless.com>) id 1dY7YJ-0001sV-QD
	for gpsd-dev@nongnu.org; Thu, 20 Jul 2017 05:15:27 -0400
Received: from mail1.bemta8.messagelabs.com ([216.82.243.200]:48867)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <Clark.Li@cohdawireless.com>)
	id 1dY7YJ-0001sE-Iv
	for gpsd-dev@nongnu.org; Thu, 20 Jul 2017 05:15:23 -0400
Received: from [216.82.242.36] by server-8.bemta-8.messagelabs.com id
	1F/7B-02182-AA470795; Thu, 20 Jul 2017 09:15:22 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRWlGSWpSXmKPExsVScuVmmu7KkoJ
	Ig1efJC3WPL/D6sDo8eTaZqYAxijWzLyk/IoE1oypG7kK/u1lrJh9vKqB8cJKxi5GLg4hgX5G
	iZOvO9i6GDk52AS0JQ5NesoMYosI6EtMnHALLC4soCIx+e0uVoi4psSp428YIWwjiWftW8FqW
	ARUJbZ+aWcCsXkF/CQaN94As4UEbCWOdfaA2ZwCdhJfLveygNiMArISk6YeBoszC4hL3HoyH8
	yWEBCQWLLnPDOELSrx8vE/VghbUWL5342sEPU6Egt2f2KDsLUlli18zQyxV1Di5MwnLBMYhWY
	hGTsLScssJC2zkLQsYGRZxahRnFpUllqka2Sql1SUmZ5RkpuYmaNraGChl5taXJyYnpqTmFSs
	l5yfu4kRGOb1DAyMOxiffvA9xCjJwaQkyssSWBApxJeUn1KZkVicEV9UmpNafIhRhoNDSYI3v
	BgoJ1iUmp5akZaZA4w4mLQEB4+SCG8ZSJq3uCAxtzgzHSJ1itGYY8Pq9V+YOO683fWFSYglLz
	8vVUqc1xqkVACkNKM0D24QLBFcYpSVEuZlZGBgEOIpSC3KzSxBlX/FKM7BqCTMWwcyhSczrwR
	u3yugU5iATnnkBnZKSSJCSqqBUXiKmHdYx+cvEffKLs+Mfrroj9r7ylOaF/g/Fvj2vs3l+vFB
	zfDru3cMp2Y5PlnHmq/+dEfNX2dhbfNPPGsPnl//65bld+kyfm51JbbOxLruBB7uBYc2C3vcs
	zEVzbqxPM77ur7z+bg3j6Xur/8lYXRWUvBDReZf7+d2rhHbPfi9NXWblBmWKLEUZyQaajEXFS
	cCADEA6L//AgAA
X-Env-Sender: Clark.Li@cohdawireless.com
X-Msg-Ref: server-16.tower-94.messagelabs.com!1500542118!177907424!1
X-Originating-IP: [116.212.217.102]
X-StarScan-Received: 
X-StarScan-Version: 9.4.25; banners=cohdawireless.com,-,-
X-VirusChecked: Checked
Received: (qmail 16916 invoked from network); 20 Jul 2017 09:15:20 -0000
Received: from unknown (HELO webmail.cohdawireless.com) (116.212.217.102)
	by server-16.tower-94.messagelabs.com with DHE-RSA-AES256-SHA encrypted
	SMTP; 20 Jul 2017 09:15:20 -0000
Received: from CW-SVR13.cohda.wireless ([::1]) by cw-svr13.cohda.wireless
	([::1]) with mapi id 14.03.0319.002; Thu, 20 Jul 2017 18:45:17 +0930
From: Clark Li <Clark.Li@cohdawireless.com>
To: "gpsd-dev@nongnu.org" <gpsd-dev@nongnu.org>
Thread-Topic: [PATCH] Support UBX NAV-PVT
Thread-Index: AQHTATiNZNQnBS88oU+t5MDeBx84FqJcbs4g
Date: Thu, 20 Jul 2017 09:15:16 +0000
Message-ID: <4EE4C24172624C4D8128D445E37EF8AB17857955@cw-svr13.cohda.wireless>
References: <20170720085826.438-1-clark.li@cohdawireless.com>
In-Reply-To: <20170720085826.438-1-clark.li@cohdawireless.com>
Accept-Language: en-US, en-AU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [115.70.26.209]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]
X-Received-From: 216.82.243.200
Subject: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Jul 2017 09:15:30 -0000

NAV-SOL has only been retained for backwards compatibility; users are reco=
mmended to use the UBX-NAV-PVT message in preference.

A regression test case using ublox-neo-m8n is also added.

Also fix the checking on valid flags of iTOW and fTOW and process fTOW who=
se range is +-500us. Update test/dae/ublox-aek-4t.log.chk accordingly.
---
 driver_ubx.c                      | 170 ++++++++++++++++++++++++++++++++-=
-----
 driver_ubx.h                      |  11 +++
 test/daemon/ublox-aek-4t.log.chk  |   2 +-
 test/daemon/ublox-neo-m8n.log     | Bin 0 -> 5054 bytes
 test/daemon/ublox-neo-m8n.log.chk | 120 +++++++++++++++++++++++++++
 5 files changed, 279 insertions(+), 24 deletions(-)  create mode 100644 t=
est/daemon/ublox-neo-m8n.log  create mode 100644 test/daemon/ublox-neo-m8n=
.log.chk

diff --git a/driver_ubx.c b/driver_ubx.c index 88be6c07..6236c25d 100644
--- a/driver_ubx.c
+++ b/driver_ubx.c
@@ -130,19 +130,129 @@ static gps_mask_t  ubx_msg_nav_pvt(struct gps_devic=
e_t *session, unsigned char *buf,
 =09=09size_t data_len)
 {
-    unsigned int flags;
+    uint8_t valid;
+    uint8_t flags;
+    uint8_t navmode;
+    struct tm unpacked_date;
+    double subseconds;
+    double hacc, vacc, sacc;
+    int *status =3D &session->gpsdata.status;
+    int *mode =3D &session->newdata.mode;
     gps_mask_t mask =3D 0;
=20
     if (data_len !=3D 92)
-=09return 0;
+        return 0;
=20
+    valid =3D (unsigned int)getub(buf, 11);
+    navmode =3D (unsigned char)getub(buf, 20);
     flags =3D (unsigned int)getub(buf, 21);
=20
-    /* TODO: finish decoding UBX_MON_PVT
-     * no need until depreacaed UBX_MON_SOL is dead
-     */
+    switch (navmode)
+    {
+    case UBX_MODE_TMONLY:
+    {
+        if (*mode !=3D MODE_NO_FIX) {
+            *mode =3D MODE_NO_FIX;
+            mask |=3D MODE_SET;
+        }
+        if (*status !=3D STATUS_NO_FIX) {
+            *status =3D STATUS_NO_FIX;
+            mask |=3D STATUS_SET;
+        }
+        break;
+    }
+    case UBX_MODE_3D:
+    case UBX_MODE_GPSDR:
+    {
+        if (*mode !=3D MODE_3D) {
+            *mode =3D MODE_3D;
+            mask |=3D MODE_SET;
+        }
+        if ((flags & UBX_NAV_PVT_FLAG_DGPS) =3D=3D UBX_NAV_PVT_FLAG_DGPS)=
 {
+            if (*status !=3D STATUS_DGPS_FIX) {
+                *status =3D STATUS_DGPS_FIX;
+                mask |=3D STATUS_SET;
+            }
+        } else {
+            if (*status !=3D STATUS_FIX) {
+                *status =3D STATUS_FIX;
+                mask |=3D STATUS_SET;
+            }
+        }
+        mask |=3D   LATLON_SET | ALTITUDE_SET | SPEED_SET | TRACK_SET | C=
LEAR_IS
+                | REPORT_IS;
+        break;
+    }
+    case UBX_MODE_2D:
+    case UBX_MODE_DR:        /* consider this too as 2D */
+    {
+        if (*mode !=3D MODE_2D) {
+            *mode =3D MODE_2D;
+            mask |=3D MODE_SET;
+        };
+        if (*status !=3D STATUS_FIX) {
+            *status =3D STATUS_FIX;
+            mask |=3D STATUS_SET;
+        }
+        mask |=3D LATLON_SET | SPEED_SET;
+        break;
+    }
+    default:
+    {
+        if (*mode !=3D MODE_NO_FIX) {
+            *mode =3D MODE_NO_FIX;
+            mask |=3D MODE_SET;
+        };
+        if (*status !=3D STATUS_NO_FIX) {
+            *status =3D STATUS_NO_FIX;
+            mask |=3D STATUS_SET;
+        }
+        break;
+    }
+    }
+
+    if ((valid & UBX_NAV_PVT_VALID_DATE_TIME) =3D=3D UBX_NAV_PVT_VALID_DA=
TE_TIME) {
+        unpacked_date.tm_year =3D (uint16_t)getleu16(buf, 4) - 1900;
+        unpacked_date.tm_mon =3D (uint8_t)getub(buf, 6) - 1;
+        unpacked_date.tm_mday =3D (uint8_t)getub(buf, 7);
+        unpacked_date.tm_hour =3D (uint8_t)getub(buf, 8);
+        unpacked_date.tm_min =3D (uint8_t)getub(buf, 9);
+        unpacked_date.tm_sec =3D (uint8_t)getub(buf, 10);
+        unpacked_date.tm_isdst =3D 0;
+        unpacked_date.tm_wday =3D 0;
+        unpacked_date.tm_yday =3D 0;
+        subseconds =3D 1e-9 * (int32_t)getles32(buf, 16);
+        session->newdata.time =3D \
+            (timestamp_t)mkgmtime(&unpacked_date) + subseconds;
+        mask |=3D TIME_SET | NTPTIME_IS;
+    }
+
+    session->newdata.longitude =3D 1e-7 * (int32_t)getles32(buf, 24);
+    session->newdata.latitude =3D 1e-7 * (int32_t)getles32(buf, 28);
+    session->newdata.altitude =3D 1e-3 * (int32_t)getles32(buf, 32);
+    session->newdata.speed =3D 1e-3 * (int32_t)getles32(buf, 60);
+    session->newdata.track =3D 1e-5 * (int32_t)getles32(buf, 64);
+    hacc =3D (double)(getles32(buf, 40) / 1000.0);
+    vacc =3D (double)(getles32(buf, 44) / 1000.0);
+    sacc =3D (double)(getles32(buf, 48) / 1000.0);
+    // epx ^ 2 + epy ^ 2 =3D hacc ^ 2
+    session->newdata.epx =3D session->newdata.epy =3D 0.707 * hacc;
+    session->newdata.epv =3D vacc;
+    session->newdata.eps =3D sacc;
+    mask |=3D HERR_SET | VERR_SET | SPEEDERR_SET;
     gpsd_log(&session->context->errout, LOG_DATA,
-=09     "NAV-PVT: flags:%02x\n", flags);
+         "NAV_PVT: flags=3D%02x time=3D%.2f lat=3D%.2f lon=3D%.2f alt=3D%=
.2f track=3D%.2f speed=3D%.2f climb=3D%.2f mode=3D%d status=3D%d used=3D%d=
\n",
+         flags,
+         session->newdata.time,
+         session->newdata.latitude,
+         session->newdata.longitude,
+         session->newdata.altitude,
+=20        session->newdata.track,
+         session->newdata.speed,
+         session->newdata.climb,
+         session->newdata.mode,
+         session->gpsdata.status,
+         session->gpsdata.satellites_used);
     return mask;
 }
=20
@@ -166,10 +276,12 @@ ubx_msg_nav_sol(struct gps_device_t *session, unsign=
ed char *buf,
 #define DATE_VALID=09(UBX_SOL_VALID_WEEK | UBX_SOL_VALID_TIME)
     if ((flags & DATE_VALID) =3D=3D DATE_VALID) {
 =09unsigned short gw;
-=09unsigned int tow;
-=09tow =3D (unsigned int)getleu32(buf, 0);
+=09unsigned int iTOW;
+=09int fTOW;
+=09iTOW =3D (unsigned int)getleu32(buf, 0);
+=09fTOW =3D (int)getles32(buf, 4);
 =09gw =3D (unsigned short)getles16(buf, 8);
-=09session->newdata.time =3D gpsd_gpstime_resolve(session, gw, tow / 1000=
.0);
+=09session->newdata.time =3D gpsd_gpstime_resolve(session, gw, (iTOW *=20=

+1e-3) + (fTOW * 1e-9));
 =09mask |=3D TIME_SET | NTPTIME_IS;
     }
 #undef DATE_VALID
@@ -292,24 +404,36 @@ static gps_mask_t
 ubx_msg_nav_timegps(struct gps_device_t *session, unsigned char *buf,
 =09=09    size_t data_len)
 {
-    unsigned int gw, tow, flags;
+    unsigned int gw, iTOW, flags;
+    int fTOW;
+    gps_mask_t mask =3D 0;
=20
     if (data_len !=3D 16)
-=09return 0;
+        return 0;
=20
-    tow =3D (unsigned int)getleu32(buf, 0);
-    gw =3D (unsigned int)getles16(buf, 8);
     flags =3D (unsigned int)getub(buf, 11);
-    if ((flags & 0x7) !=3D 0)
-=09session->context->leap_seconds =3D (int)getub(buf, 10);
-    session->newdata.time =3D gpsd_gpstime_resolve(session,
-=09=09=09=09=09      (unsigned short int)gw,
-=09=09=09=09=09      (double)tow / 1000.0);
+    // Valid leap seconds
+    if ((flags & UBX_TIMEGPS_VALID_LEAP_SECOND) =3D=3D UBX_TIMEGPS_VALID_=
LEAP_SECOND)
+        session->context->leap_seconds =3D (int)getub(buf, 10);
+    // Valid GPS time of week and week number #define VALID_TIME=20
+(UBX_TIMEGPS_VALID_TIME | UBX_TIMEGPS_VALID_WEEK)
+    if ((flags & VALID_TIME) =3D=3D VALID_TIME) #undef VALID_TIME
+    {
+        iTOW =3D (unsigned int)getleu32(buf, 0);
+        fTOW =3D (int)getles32(buf, 4);
+        gw =3D (unsigned int)getles16(buf, 8);
+        session->newdata.time =3D
+          gpsd_gpstime_resolve(session,
+                               (unsigned short int)gw,
+                               ((double)iTOW * 1e-3) + ((double)fTOW * 1e=
-9));
+        mask |=3D (TIME_SET | NTPTIME_IS);
+    }
=20
     gpsd_log(&session->context->errout, LOG_DATA,
-=09     "TIMEGPS: time=3D%.2f leap=3D%d, mask=3D{TIME}\n",
-=09     session->newdata.time, session->context->leap_seconds);
-    return TIME_SET | NTPTIME_IS;
+             "TIMEGPS: time=3D%.2f mask=3D{TIME}\n",
+             session->newdata.time);
+    return mask;
 }
=20
 /**
@@ -486,8 +610,8 @@ gps_mask_t ubx_parse(struct gps_device_t * session, un=
signed char *buf,
 =09break;
     case UBX_NAV_PVT:
 =09gpsd_log(&session->context->errout, LOG_PROG, "UBX_NAV_PVT\n");
-=09mask =3D ubx_msg_nav_pvt(session, &buf[UBX_PREFIX_LEN], data_len);
-        break;
+=09mask =3D ubx_msg_nav_pvt(session, &buf[UBX_PREFIX_LEN], data_len)
+             | (CLEAR_IS | REPORT_IS);
     case UBX_NAV_POSUTM:
 =09gpsd_log(&session->context->errout, LOG_DATA, "UBX_NAV_POSUTM\n");
 =09break;
diff --git a/driver_ubx.h b/driver_ubx.h index c23efdf7..99ef9b98 100644
--- a/driver_ubx.h
+++ b/driver_ubx.h
@@ -102,6 +102,10 @@ typedef enum {
 #define UBX_SOL_VALID_WEEK 0x04
 #define UBX_SOL_VALID_TIME 0x08
=20
+#define UBX_TIMEGPS_VALID_TIME        0x01
+#define UBX_TIMEGPS_VALID_WEEK        0x02
+#define UBX_TIMEGPS_VALID_LEAP_SECOND 0x04
+
 /* from UBX_NAV_SVINFO */
 #define UBX_SAT_USED 0x01
 #define UBX_SAT_DGPS 0x02
@@ -118,4 +122,11 @@ typedef enum {
 #define UBX_SIG_CDCRLK2 6
 #define UBX_SIG_NAVMSG 7
=20
+#define UBX_NAV_PVT_VALID_DATE      0x01
+#define UBX_NAV_PVT_VALID_TIME      0x02
+#define UBX_NAV_PVT_VALID_DATE_TIME (UBX_NAV_PVT_VALID_DATE |=20
+UBX_NAV_PVT_VALID_TIME)
+
+#define UBX_NAV_PVT_FLAG_GPS_FIX_OK 0x01
+#define UBX_NAV_PVT_FLAG_DGPS       0x02
+
 #endif /* _GPSD_UBX_H_ */
diff --git a/test/daemon/ublox-aek-4t.log.chk b/test/daemon/ublox-aek-4t.l=
og.chk
index 45680ea6..31acd979 100644
--- a/test/daemon/ublox-aek-4t.log.chk
+++ b/test/daemon/ublox-aek-4t.log.chk
@@ -26,4 +26,4 @@ $GPZDA,231127.00,23,12,2007,00,00*65
 $GPGGA,231126,2037.7569,N,08704.0845,W,2,07,1.67,75.75,M,-13.865,M,,*4C
 $GPRMC,231126,A,2037.7569,N,08704.0845,W,0.0000,0.000,231207,,*36
 $GPGSA,A,3,15,2,30,5,12,18,135,,,,,,2.6,1.7,2.0*0F
-{"class":"TPV","status":2,"mode":3,"time":"2007-12-23T23:11:26.999Z","ept=
":0.005,"lat":20.629281718,"lon":-87.068075424,"alt":75.754,"epx":2.973,"e=
py":6.138,"epv":11.443,"track":0.0000,"speed":0.000,"climb":0.000,"eps":0.=
17,"epc":22.89}
+{"class":"TPV","status":2,"mode":3,"time":"2007-12-23T23:11:26.999Z","e
+pt":0.005,"lat":20.629281718,"lon":-87.068075424,"alt":75.754,"epx":2.9
+73,"epy":6.138,"epv":11.443,"track":0.0000,"speed":0.000,"climb":0.000,
+"eps":0.17,"epc":22.88}
diff --git a/test/daemon/ublox-neo-m8n.log b/test/daemon/ublox-neo-m8n.log=
 new file mode 100644 index 0000000000000000000000000000000000000000..28f7=
c1210cefc87390aced8960eaff133213e9f4
GIT binary patch
literal 5054
zcmb7|4^ULs6^HKvyNe4Vh=3D3xJ$3j?)f(uqbVj2;R#v+nnt!b^WENfU;T)HgfkFkl9
z7;9#dX{V$S#i(gTp;}B6n}5!vrfG)MaoSGCG+L+FRFbGkTdXFURJXtL&U@@#eKSU!
z%f0O0_rAUF-0z;VW-FDhW>0Bbex1+Xp;Rtjk-xm8Qfc<rxA{D_Y^A)x+tTU@mMYo=3D
zeFomDZmVnd27{hJsZ#E91)7u!uQK0FqXM6If!p6u?`ro3JU&lrYk}L}{7qc4$QAUI
zDn-u1;(TXue&Ia4RN;5Kf?ognQl+fk<8yiIJu{W+vYAR*TWc`j@_Ah|mD%4Ym{(LX
zr&=3DkTT~aXD=3D`3Ds%f^)}8@#Q`I<L>8pfC5gbOyW+Hw2YD_jDpSmAXzP*x*r?R8=3Doh
zS_1w?k2{E~7UC~_=3DH^z#)zaeYELB=3DP9(A62r}7n558Yq6MDeayU#s`xLwM`j=3DmRPN
zzdxv~^9PiAPtfJ{wHDZHXT;$;lXZ=3D7Zd;x7534mfwn!953n3hj9h?;%ZA&<KVdsNe
z-zdCL<rZSNMF?Mv5DP6rd>#sg&Z6aFZYJ7**(pZQH`I(5KNaH4feJf*<DU?Z4SgF7
zB~fMMc3cnjStnYF@y-=3DyUm0VYRCXuk5PJ~pC&9LZ{UX@SV3&iPh-?1`b{u*d6Z-)A
zP6PJlH<(R~c8NW_h}pmE(bvuFcT3O5>FmeBK2;}#7wiDo%fS8;+>2<}(R6kn*iRX-
z_wQsjF@_}e)m_Z~@%Atqw-@QxPNWh0H(2*3um`}N2lfx~W);{em_v<z^k@De#=3DQpY
z-V`wAtTqwDlz~Ym5mk*YaUy=3Djh`snNvgnsNH#x)9Eo!D<Y;|O<6}wG$&^R_d{%MgP
zQpe-$@zcb?kUA&Mk>n9)`StNRjt|8}9#2R$pT=3Dd$bpNCrC04x0^OKbc9#b)oCn>R`
zA|%r2{uz$t?}>l&wVBiJ-6HIQSf))%A;mS7##_T<vndPrS*6Y~M~6SZSz3$5BJAZR
z;PDwO)@d_B!mHlj5-Z~WLLZA>A2)f{NsK4a*e0wNeSTu<^ruBnC<9zeQk<<vB$y`A
zc;aMxljw*^rg8Gr^n8&M%Eb7&Z5&&AzEe7RPg4w2#&K+`c0|Uu>CL0r6x){&+l`2A
zBVv2iFK}lesuA0NVLx5g8pW9Q^Z@!_8^m_o2(yXdmDmNVnLW8Tl6_<oyG-mZu$^GP
zDY32K5PJk|yvDwO{v8AMg9@{W@w&ub`VzCxjIpDN>3Jk{vCA)m-46Ds3kL$&op^I4
z)@{d}Bs5~@qNjC#jQ;NiZ2vRNCPp0YOXmnN>TJy3zf)g#lzNV=3DozE^G20IA$A+Q&K
z-HwYM0Gk|+!u2Q7(|JVfVf2>`*zT*$CdL|#P1kI2F}vmYNcP}$cA3~e0J{V1Sg`do
zjADER+`powYV0r2C)D12ety*s23#h_tzF(Ox!f(e>|obam-{7`hxv8Y<<EG0lgq~?
zmuE{ZUy@wDz}KoS=3DNh=3D2HRd(Dyz(|&&Vb83s&|ntr%5iSs4mm_V^Lk+p}8Cnmt!QC
zaYl`~>`?ES*2S@<=3DX+3!?XyQXwk5kFV=3DIob%da4|&4}%M#P-;FAzHAnmSSI#OSCUP
zLm#ijb_l)QAhz=3D=3Dm`#l95_>R>*<yE?P4|4@adw&5jbMjrg?I++NATuDVAD~572JQK
zO~aV>^eFnf4cHUUGn*JIHiUgTwu#w8W9(?v<rgrA&al_OUI+H8U@rx`3+z>3(|VJ^
zqCQ<?529agz;0c|Y+~$|*k_M3`zL$!bw{f%U%ZE1CUzaz?O<EL)^lS5IP~1Fp<xTC
z>wX1&tpWR#o7uz|)!5|nwH#)zej$=3DwF5Xx3^6OyNfIYodh}W9ACb%E#j>Wa)@_*1M
zchNJa^RvT%eK*xSaG4mlcKLb9<t>uSvox2pk(UP~m;WZYd|q=3Do?S{O3OmaD2a@lMO
z=3DjBf{muDa^-}N<IUUHi*ziQxes^oI2<Z=3Dq~^0QK2{!(yWPD5TUHicczRPR}`fn!V0
zci|)9T66MK99!iVk+JQ5i(RJJeh;x7twDZ5Y-_Nm3lQ5&i0M~a({p1VV!PEKwzEED
zHZguCv5P2QqsIQ^2KLAk>@w}??||J0_FS-+ft?68<p|o(<dj|$P@TKOfc^7sW)tJA
z#Qs(xvk(1JUw4e^Q}IT2`L|$KgMA;^Cw!>w!HxnO*buFqa-@ES^@9B?1NOl0nN5s2
zxUXK{uX~Q!9eX3$Tkd6-sUE2W`|?^LHiKOR_NQiniZT?U?-%q#wE_9mkN$`O`wz>Q
zO^nSF`_Ye>y`V3W{eg*HJ_PnMu=3DjxN1UnP#KY>kWC)N10Zkxv5hyJ($`;Sdvz-3~{
zE>oQuSz|j;WAD;j&O?pernx*7HMU)HS+21^&|JO~HMZvCgej8CccR7~(p<KqHrDfU
z7HaHaEidPx#+F^4p}A}y%f+Ux;j!67_bFwUqrOg!O?lbK<rK+fIWLpTdnK3k8haXC
z&edw{bkx|Kmn}y*w)A}8mtxyf#<7jv7a7~Ux7p<bi0xv;_PdDfxh8zAL2L&RTgpjP
z@0~+z_5Ab^{vI)i?TR916T|VN@Sc8oAG7~_1H1D{cDWzy1z?B1kGu@_B_x(^uup?&
z0&6B(4jS$0Ptjj9VAtNoY+`gs?BoAs_O|`{y3MM~$1sQT@?Nm-0ec_VbHN?~dn4H7
zkbaKo=3Dg48amgu^<*6ezV*~EBPVt-u8?ArcF_S7<Vc@NknU{`>Bx>1NzVEe$vQ6lL4
zq@MC5t$REAI}F(MhnY=3D`DUXJqxoJPM^9CZ>P0{S~POxW#eR2){{{ie1V7tNo0^CtF
z{HZ<zVjsY`(13j(?KQYej9a_BM{@aL$>ph<%Q?u)hqSz$hwsZLC6~|fSaX@ahl(U}
z`EAMNIa*#Omyb#=3DkMOmbl$Q%Mm&0}S%`VTqO_zHO^0MsmBsDLq-<=3Da>mu;xAty+zp
b4ww6*)f}BnE<4qGIzH#v((`SUVr%<9x0&gV

literal 0
HcmV?d00001

diff --git a/test/daemon/ublox-neo-m8n.log.chk b/test/daemon/ublox-neo-m8n=
.log.chk
new file mode 100644
index 00000000..b229a3aa
--- /dev/null
+++ b/test/daemon/ublox-neo-m8n.log.chk
@@ -0,0 +1,120 @@
+$GPZDA,085000.80,19,07,2017,00,00*68
+$GPGGA,085000,3454.3736,S,13836.4872,E,2,00,,25.42,M,,,*00
+$GPRMC,085000,A,3454.3736,S,13836.4872,E,0.0583,31.472,190717,,*08
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:00.800Z","e
+pt":0.005,"lat":-34.906226300,"lon":138.608119700,"alt":25.424,"epx":0.
+800,"epy":0.800,"epv":1.602,"track":31.4718,"speed":0.030,"eps":-0.01}
+$GPZDA,085001.00,19,07,2017,00,00*61
+$GPGGA,085000,3454.3736,S,13836.4872,E,2,00,,25.38,M,,,*0D
+$GPRMC,085000,A,3454.3736,S,13836.4872,E,0.0311,31.472,190717,,*05
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:00.000Z","e
+pt":0.005,"lat":-34.906226600,"lon":138.608119900,"alt":25.378,"epx":0.
+801,"epy":0.801,"epv":1.603,"track":31.4718,"speed":0.016,"climb":-0.23
+0,"eps":0.02,"epc":16.02}
+$GPZDA,085001.20,19,07,2017,00,00*63
+$GPGGA,085001,3454.3736,S,13836.4872,E,2,00,,25.31,M,,,*05
+$GPRMC,085001,A,3454.3736,S,13836.4872,E,0.0311,31.472,190717,,*04
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:01.200Z","e
+pt":0.005,"lat":-34.906226900,"lon":138.608119900,"alt":25.306,"epx":0.
+805,"epy":0.805,"epv":1.610,"track":31.4718,"speed":0.016,"climb":-0.36
+0,"eps":-0.01,"epc":16.06}
+$GPZDA,085001.40,19,07,2017,00,00*65
+$GPGGA,085001,3454.3736,S,13836.4872,E,2,00,,25.26,M,,,*03
+$GPRMC,085001,A,3454.3736,S,13836.4872,E,0.0583,31.472,190717,,*09
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:01.400Z","e
+pt":0.005,"lat":-34.906227100,"lon":138.608120200,"alt":25.258,"epx":0.
+807,"epy":0.807,"epv":1.616,"track":31.4718,"speed":0.030,"climb":-0.24
+0,"eps":0.02,"epc":16.13}
+$GPZDA,085001.60,19,07,2017,00,00*67
+$GPGGA,085001,3454.3736,S,13836.4872,E,2,00,,25.19,M,,,*0F
+$GPRMC,085001,A,3454.3736,S,13836.4872,E,0.0408,31.472,190717,,*0B
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:01.600Z","e
+pt":0.005,"lat":-34.906227500,"lon":138.608120300,"alt":25.194,"epx":0.
+809,"epy":0.809,"epv":1.619,"track":31.4718,"speed":0.021,"climb":-0.32
+0,"eps":-0.02,"epc":16.17}
+$GPZDA,085001.80,19,07,2017,00,00*69
+$GPGGA,085001,3454.3737,S,13836.4872,E,2,00,,25.14,M,,,*03
+$GPRMC,085001,A,3454.3737,S,13836.4872,E,0.0253,31.472,190717,,*02
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:01.800Z","e
+pt":0.005,"lat":-34.906227800,"lon":138.608120300,"alt":25.136,"epx":0.
+809,"epy":0.809,"epv":1.619,"track":31.4718,"speed":0.013,"climb":-0.29
+0,"eps":0.01,"epc":16.19}
+$GPZDA,085002.00,19,07,2017,00,00*62
+$GPGGA,085001,3454.3737,S,13836.4872,E,2,00,,25.07,M,,,*01
+$GPRMC,085001,A,3454.3737,S,13836.4872,E,0.0739,31.472,190717,,*0B
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:01.000Z","e
+pt":0.005,"lat":-34.906228100,"lon":138.608120400,"alt":25.073,"epx":0.
+810,"epy":0.810,"epv":1.620,"track":31.4718,"speed":0.038,"climb":-0.31
+5,"eps":0.03,"epc":16.19}
+$GPZDA,085002.20,19,07,2017,00,00*60
+$GPGGA,085002,3454.3737,S,13836.4872,E,2,00,,25.01,M,,,*04
+$GPRMC,085002,A,3454.3737,S,13836.4872,E,0.0058,31.472,190717,,*08
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:02.200Z","e
+pt":0.005,"lat":-34.906228400,"lon":138.608120500,"alt":25.008,"epx":0.
+808,"epy":0.808,"epv":1.617,"track":31.4718,"speed":0.003,"climb":-0.32
+5,"eps":-0.00,"epc":16.18}
+$GPZDA,085002.40,19,07,2017,00,00*66
+$GPGGA,085002,3454.3737,S,13836.4872,E,2,00,,24.95,M,,,*08
+$GPRMC,085002,A,3454.3737,S,13836.4872,E,0.0428,31.472,190717,,*0B
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:02.400Z","e
+pt":0.005,"lat":-34.906228700,"lon":138.608120500,"alt":24.952,"epx":0.
+801,"epy":0.801,"epv":1.603,"track":31.4718,"speed":0.022,"climb":-0.28
+0,"eps":0.02,"epc":16.10}
+$GPZDA,085002.60,19,07,2017,00,00*64
+$GPGGA,085002,3454.3737,S,13836.4872,E,2,00,,24.89,M,,,*05
+$GPRMC,085002,A,3454.3737,S,13836.4872,E,0.0233,31.472,190717,,*07
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:02.600Z","e
+pt":0.005,"lat":-34.906229100,"lon":138.608120700,"alt":24.892,"epx":0.
+803,"epy":0.803,"epv":1.608,"track":31.4718,"speed":0.012,"climb":-0.30
+0,"eps":-0.01,"epc":16.05}
+$GPZDA,085002.80,19,07,2017,00,00*6A
+$GPGGA,085002,3454.3738,S,13836.4872,E,2,00,,24.83,M,,,*00
+$GPRMC,085002,A,3454.3738,S,13836.4872,E,0.0564,31.472,190717,,*0D
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:02.800Z","e
+pt":0.005,"lat":-34.906229400,"lon":138.608120700,"alt":24.831,"epx":0.
+812,"epy":0.812,"epv":1.625,"track":31.4718,"speed":0.029,"climb":-0.30
+5,"eps":0.03,"epc":16.16}
+$GPZDA,085003.00,19,07,2017,00,00*63
+$GPGGA,085002,3454.3738,S,13836.4873,E,2,00,,24.76,M,,,*0B
+$GPRMC,085002,A,3454.3738,S,13836.4873,E,0.0505,31.472,190717,,*0B
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:02.000Z","e
+pt":0.005,"lat":-34.906229800,"lon":138.608120900,"alt":24.760,"epx":0.
+810,"epy":0.810,"epv":1.622,"track":31.4718,"speed":0.026,"climb":-0.35
+5,"eps":-0.02,"epc":16.23}
+$GPZDA,085003.20,19,07,2017,00,00*61
+$GPGGA,085003,3454.3738,S,13836.4873,E,2,00,,24.70,M,,,*0C
+$GPRMC,085003,A,3454.3738,S,13836.4873,E,0.0350,31.472,190717,,*0C
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:03.200Z","e
+pt":0.005,"lat":-34.906230200,"lon":138.608120900,"alt":24.695,"epx":0.
+807,"epy":0.807,"epv":1.616,"track":31.4718,"speed":0.018,"climb":-0.32
+5,"eps":0.01,"epc":16.19}
+$GPZDA,085003.40,19,07,2017,00,00*67
+$GPGGA,085003,3454.3738,S,13836.4873,E,2,00,,24.62,M,,,*0F
+$GPRMC,085003,A,3454.3738,S,13836.4873,E,0.0214,31.472,190717,,*0D
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:03.400Z","e
+pt":0.005,"lat":-34.906230500,"lon":138.608121000,"alt":24.617,"epx":0.
+805,"epy":0.805,"epv":1.609,"track":31.4718,"speed":0.011,"climb":-0.39
+0,"eps":0.01,"epc":16.12}
+$GPZDA,085003.60,19,07,2017,00,00*65
+$GPGGA,085003,3454.3739,S,13836.4873,E,2,00,,24.56,M,,,*09
+$GPRMC,085003,A,3454.3739,S,13836.4873,E,0.0253,31.472,190717,,*0F
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:03.600Z","e
+pt":0.005,"lat":-34.906230900,"lon":138.608121000,"alt":24.561,"epx":0.
+791,"epy":0.791,"epv":1.582,"track":31.4718,"speed":0.013,"climb":-0.28
+0,"eps":-0.01,"epc":15.95}
+$GPZDA,085003.80,19,07,2017,00,00*6B
+$GPGGA,085003,3454.3739,S,13836.4873,E,2,00,,24.49,M,,,*07
+$GPRMC,085003,A,3454.3739,S,13836.4873,E,0.0408,31.472,190717,,*07
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:03.800Z","e
+pt":0.005,"lat":-34.906231300,"lon":138.608120900,"alt":24.486,"epx":0.
+776,"epy":0.776,"epv":1.552,"track":31.4718,"speed":0.021,"climb":-0.37
+5,"eps":0.02,"epc":15.67}
+$GPZDA,085004.00,19,07,2017,00,00*64
+$GPGGA,085003,3454.3739,S,13836.4872,E,2,00,,24.39,M,,,*01
+$GPRMC,085003,A,3454.3739,S,13836.4872,E,0.0233,31.472,190717,,*08
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:03.000Z","e
+pt":0.005,"lat":-34.906231700,"lon":138.608120600,"alt":24.390,"epx":0.
+771,"epy":0.771,"epv":1.538,"track":31.4718,"speed":0.012,"climb":-0.48
+0,"eps":-0.00,"epc":15.45}
+$GPZDA,085004.20,19,07,2017,00,00*66
+$GPGGA,085004,3454.3739,S,13836.4872,E,2,00,,24.31,M,,,*0E
+$GPRMC,085004,A,3454.3739,S,13836.4872,E,0.0330,31.472,190717,,*0D
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:04.200Z","e
+pt":0.005,"lat":-34.906232200,"lon":138.608120300,"alt":24.309,"epx":0.
+759,"epy":0.759,"epv":1.516,"track":31.4718,"speed":0.017,"climb":-0.40
+5,"eps":-0.01,"epc":15.27}
+$GPZDA,085004.40,19,07,2017,00,00*60
+$GPGGA,085004,3454.3740,S,13836.4872,E,2,00,,24.23,M,,,*03
+$GPRMC,085004,A,3454.3740,S,13836.4872,E,0.0194,31.472,190717,,*0F
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:04.400Z","e
+pt":0.005,"lat":-34.906232600,"lon":138.608120000,"alt":24.225,"epx":0.
+745,"epy":0.745,"epv":1.487,"track":31.4718,"speed":0.010,"climb":-0.42
+0,"eps":-0.01,"epc":15.01}
+$GPZDA,085004.60,19,07,2017,00,00*62
+$GPGGA,085004,3454.3740,S,13836.4872,E,2,00,,24.15,M,,,*06
+$GPRMC,085004,A,3454.3740,S,13836.4872,E,0.0505,31.472,190717,,*03
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:04.600Z","e
+pt":0.005,"lat":-34.906233100,"lon":138.608119600,"alt":24.154,"epx":0.
+729,"epy":0.729,"epv":1.455,"track":31.4718,"speed":0.026,"climb":-0.35
+5,"eps":0.03,"epc":14.71}
+$GPZDA,085004.80,19,07,2017,00,00*6C
+$GPGGA,085004,3454.3740,S,13836.4872,E,2,00,,24.06,M,,,*04
+$GPRMC,085004,A,3454.3740,S,13836.4872,E,0.0700,31.472,190717,,*04
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:04.800Z","e
+pt":0.005,"lat":-34.906233600,"lon":138.608119300,"alt":24.063,"epx":0.
+715,"epy":0.715,"epv":1.428,"track":31.4718,"speed":0.036,"climb":-0.45
+5,"eps":-0.04,"epc":14.41}
+$GPZDA,085005.00,19,07,2017,00,00*65
+$GPGGA,085004,3454.3740,S,13836.4871,E,2,00,,23.98,M,,,*07
+$GPRMC,085004,A,3454.3740,S,13836.4871,E,0.0408,31.472,190717,,*0C
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:04.000Z","e
+pt":0.005,"lat":-34.906233900,"lon":138.608118900,"alt":23.975,"epx":0.
+705,"epy":0.705,"epv":1.405,"track":31.4718,"speed":0.021,"climb":-0.44
+0,"eps":0.02,"epc":14.16}
+$GPZDA,085005.20,19,07,2017,00,00*67
+$GPGGA,085005,3454.3741,S,13836.4871,E,2,00,,23.88,M,,,*06
+$GPRMC,085005,A,3454.3741,S,13836.4871,E,0.0156,31.472,190717,,*02
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:05.200Z","e
+pt":0.005,"lat":-34.906234400,"lon":138.608118500,"alt":23.884,"epx":0.
+697,"epy":0.697,"epv":1.388,"track":31.4718,"speed":0.008,"climb":-0.45
+5,"eps":0.01,"epc":13.96}
+$GPZDA,085005.40,19,07,2017,00,00*61
+$GPGGA,085005,3454.3741,S,13836.4871,E,2,00,,23.77,M,,,*06
+$GPRMC,085005,A,3454.3741,S,13836.4871,E,0.0330,31.472,190717,,*00
+$GPGSA,A,3,,,,,,,,,,,,,,,*1C
+{"class":"TPV","status":2,"mode":3,"time":"2017-07-19T08:50:05.400Z","e
+pt":0.005,"lat":-34.906234900,"lon":138.608118100,"alt":23.769,"epx":0.
+694,"epy":0.694,"epv":1.379,"track":31.4718,"speed":0.017,"climb":-0.57
+5,"eps":-0.01,"epc":13.83}
--
2.13.0

This communication may contain confidential or copyright information. If y=
ou are not an intended recipient, you must not keep, forward, copy, use, s=
ave or rely on this communication, and any such action is unauthorized and=
 prohibited. If you have received this communication in error, please repl=
y to this email to notify the sender of its incorrect delivery and then de=
lete both the original message and your reply.


From MAILER-DAEMON Fri Jul 21 19:11:18 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dYh4o-0003ZT-RA
	for mharc-gpsd-dev@gnu.org; Fri, 21 Jul 2017 19:11:18 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dYh4m-0003ZF-0z
	for gpsd-dev@nongnu.org; Fri, 21 Jul 2017 19:11:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dYh4h-0003Pl-1L
	for gpsd-dev@nongnu.org; Fri, 21 Jul 2017 19:11:16 -0400
Received: from d.mail.sonic.net ([64.142.111.50]:53930)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dYh4g-0003Mz-NV
	for gpsd-dev@nongnu.org; Fri, 21 Jul 2017 19:11:10 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v6LNB1SD008148
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
	Fri, 21 Jul 2017 16:11:01 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v6LNB1ta022746;
	Fri, 21 Jul 2017 16:11:01 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v6LNB1Uw022740; 
	Fri, 21 Jul 2017 16:11:01 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Fri, 21 Jul 2017 16:11:01 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: GPSD Developers List <gpsd-dev@nongnu.org>
In-Reply-To: <4EE4C24172624C4D8128D445E37EF8AB17857965@cw-svr13.cohda.wireless>
Message-ID: <Pine.LNX.4.58L1X.1707211535210.10401@bolt.sonic.net>
References: <20170719121131.5169-1-clark.li@cohdawireless.com>
	<4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707192157040.1086@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857965@cw-svr13.cohda.wireless>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVZRfiQDeRLtqgUv/RxZEIMC5NhlYR+WGtOG1HIrgpdYNnvU6KPvYBiM2Kzm3qI6JYgNmP+vS3Z7RYHV6as+Tl40
X-Sonic-ID: C;1Hbu3Glu5xGIY/sKk0eh0A== M;5KwR3Wlu5xGIY/sKk0eh0A==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.50
Subject: Re: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jul 2017 23:11:17 -0000


(Back on-list since some issues might be of wider interest)

On Thu, 20 Jul 2017, Clark Li wrote:

> Thanks Fred. I've sent out another one with log/check for NAV-PVT from ublox-neo-m8n.

Previously, I hadn't bothered to try to apply your patch after seeing the
issue I reported, but I've now tried it and it (either version) fails to
apply.  There seems to be some inconsistency between the state of
driver_ubx.c and what the patch expects.  Ordinarily this might be due to
the patch's being based on a different revision of the file, but in this
case the blob ID in the patch matches the state of the file, so I'm
puzzled.  Did you have uncommitted changes to the file at the time you ran
git format-patch?  I don't know what the effect of that is, but it's my
best guess as to why the patch is bad.

> Changes for ublox-aek-4t.log.chk is actually for the processing fTOW in driver_ubx.c

Except that if you look closely at the diff, you'll see that the only
actual change to that file is the introduction of some spurious line
breaks.  It makes sense that the output is effectively unchanged, but it
doesn't make sense that some spurious newlines appeared.  Did you perhaps
obtain the "updated" version via copy-n-paste rather than from
"regress-driver -b"?

It's also odd that only that one case was affected by whatever you did.
Did you only run the one test case, rather than all of them (typically via
"scons check")?

With regard to the new test data, did you do some form of sanity check on
it?  All the regression tests can do is verify that the code continues to
produce the same results as before; they have no built-in concept of
"correct" results.  I don't know the specific details, but since it looks
like you're adding support for a new message type that duplicates the
functionality of an older message type, a possible approach would be to
configure the receiver to output both and then verify that both the old
and new versions of the code come up with the same (or possibly better)
TPV decodes.  Though if supporting both results in duplicate TPV outputs,
some tweaking would be needed to be able to compare them.

Incidentally, when updating regression-test data, a fairly convenient
approach (if one is working in a git repo) is just to run "scons
gps-makeregress" and then let git tell you what actually changed (and see
if it's plausible).  That lets you view the diffs much more flexibly than
looking at the test output from gps-regress.

Fred Wright


From MAILER-DAEMON Tue Jul 25 09:40:03 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1da04A-0008Oz-VW
	for mharc-gpsd-dev@gnu.org; Tue, 25 Jul 2017 09:40:03 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Clark.Li@cohdawireless.com>) id 1da048-0008Mu-Ia
	for gpsd-dev@nongnu.org; Tue, 25 Jul 2017 09:40:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Clark.Li@cohdawireless.com>) id 1da045-0006p2-AQ
	for gpsd-dev@nongnu.org; Tue, 25 Jul 2017 09:40:00 -0400
Received: from mail1.bemta12.messagelabs.com ([216.82.251.2]:10358)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <Clark.Li@cohdawireless.com>)
	id 1da044-0006nv-Rr
	for gpsd-dev@nongnu.org; Tue, 25 Jul 2017 09:39:57 -0400
Received: from [216.82.249.212] by server-2.bemta-12.messagelabs.com id
	C9/A1-01994-82A47795; Tue, 25 Jul 2017 13:39:52 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIKsWRWlGSWpSXmKPExsVScuVmmq6GV3m
	kwZHl4haP18ZZrHl+h9WByWP3jtvsHk+ubWYKYIpizcxLyq9IYM2YeWgle8GKLUwVe8/dZ2tg
	bF3B1MXIxSEk0M8ocfbVPyCHk4NNQFvi0KSnzCC2iICexKL+W4wgNrOAgkTTjn5WEFtYwFhiw
	ed+FogaE4nDu0+xQth+Eo9+ngabwyKgKnHu6GawObxA8bvfrjJDLNvMJHFoxX4gh4ODU8BJou
	1/CUgNo4CsxKSph5kgdolL3HoyH8yWEBCReHjxNBuELSrx8vE/VghbUWL5342sEPUZEjunnGS
	F2CUocXLmE5YJjEKzkIyahaRsFpIyiLiOxILdn9ggbG2JZQtfM0PYfhLnPjxihLCNJf49+wlk
	cwHZuxglFv++C5VQlJjS/ZB9ASPnKkb14tSistQiXVO9pKLM9IyS3MTMHF1DQyO93NTi4sT01
	JzEpGK95PzcTYzAqKtnYGDcwbjsn88hRkkOJiVR3m+65ZFCfEn5KZUZicUZ8UWlOanFhxhlOD
	iUJHhvewDlBItS01Mr0jJzgPEPk5bg4FES4WXwBErzFhck5hZnpkOkTjEqSonz7gXpEwBJZJT
	mwbXBUs4lRlkpYV5GBgYGIZ6C1KLczBJU+VeM4hyMSsK8jiDjeTLzSuCmvwJazAS0eM6MUpDF
	JYkIKakGxm16wrekxT88Mru0af2PawdWunM+Eg1SmMyilH77ikXXpMt9Pe9O7q6U9rqrUO2dr
	Km9dnnuq/nTbzycwiTJ9WHFx0mlnM1Z/dES5VXrdxXqyOyTeL1dqffclzlFf9/mv2itLdTeZ7
	BGVTq1tntC855W995NB2es26fL952TwdJrv8Tcw08/5yuxFGckGmoxFxUnAgAtOx2rNAMAAA=
	=
X-Env-Sender: Clark.Li@cohdawireless.com
X-Msg-Ref: server-12.tower-219.messagelabs.com!1500989989!172718505!1
X-Originating-IP: [116.212.217.102]
X-StarScan-Received: 
X-StarScan-Version: 9.4.25; banners=cohdawireless.com,-,-
X-VirusChecked: Checked
Received: (qmail 17194 invoked from network); 25 Jul 2017 13:39:51 -0000
Received: from unknown (HELO webmail.cohdawireless.com) (116.212.217.102)
	by server-12.tower-219.messagelabs.com with DHE-RSA-AES256-SHA
	encrypted SMTP; 25 Jul 2017 13:39:51 -0000
Received: from CW-SVR13.cohda.wireless ([::1]) by cw-svr13.cohda.wireless
	([::1]) with mapi id 14.03.0319.002; Tue, 25 Jul 2017 23:09:18 +0930
From: Clark Li <Clark.Li@cohdawireless.com>
To: GPSD Developers List <gpsd-dev@nongnu.org>
Thread-Topic: [gpsd-dev] [PATCH] Support UBX NAV-PVT
Thread-Index: AQHTAIg6LMFyO5ecyEyXU9/Cd+OjcqJbD4IggAB6CoCAAObLYIAB3JOAgAL8nNA=
Date: Tue, 25 Jul 2017 13:39:18 +0000
Message-ID: <4EE4C24172624C4D8128D445E37EF8AB17857FAD@cw-svr13.cohda.wireless>
References: <20170719121131.5169-1-clark.li@cohdawireless.com>
	<4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707192157040.1086@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857965@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707211535210.10401@bolt.sonic.net>
In-Reply-To: <Pine.LNX.4.58L1X.1707211535210.10401@bolt.sonic.net>
Accept-Language: en-US, en-AU
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator: 
x-originating-ip: [115.70.26.209]
Content-Type: multipart/mixed;
	boundary="_002_4EE4C24172624C4D8128D445E37EF8AB17857FADcwsvr13cohdawir_"
MIME-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]
X-Received-From: 216.82.251.2
Subject: Re: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jul 2017 13:40:02 -0000

--_002_4EE4C24172624C4D8128D445E37EF8AB17857FADcwsvr13cohdawir_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

>Previously, I hadn't bothered to try to apply your patch after seeing the=
 issue I reported, but I've now tried it and it (either version) fails to =
apply.  There seems to be some inconsistency between the state of driver_u=
bx.c and what the patch expects.  Ordinarily this might be due to the patc=
h's being based on a different revision of the file, but in this case the =
blob ID in the patch matches the state of the file, so I'm puzzled.  Did y=
ou have uncommitted changes to the file at the time you ran git format-pat=
ch?  I don't know what the effect of that is, but it's my best guess as to=
 why the patch is bad.
That last patch was not based on the very latest in master branch. But I g=
uess forwarding the output of git-send-email from gmail to outlook should =
also be blamed... I am attaching the original git-format-patch output this=
 time, hopefully this one can be applied without conflicts.

>Except that if you look closely at the diff, you'll see that the only act=
ual change to that file is the introduction of some spurious line breaks. =
 It makes sense that the output is effectively unchanged, but it doesn't m=
ake sense that some spurious newlines appeared.  Did you perhaps obtain th=
e "updated" version via copy-n-paste rather than from "regress-driver -b"?=

The chk file was updated using "regress-driver -b" but again this might be=
 due to the email forwarding...

>It's also odd that only that one case was affected by whatever you did.=20=

>Did you only run the one test case, rather than all of them (typically vi=
a "scons check")?
scons check was run to check all the regression tests. ublox-aek-4t.log mi=
ght be the only regression that contains NAV-NAV-SOL.

>With regard to the new test data, did you do some form of sanity check on=
 it?  All the regression tests can do is verify that the code continues to=
 produce the same results as before; they have no built-in concept of "cor=
rect" results.
Yes sanity check has been done on for positon/speed/time when the log was =
recorded.

>I don't know the specific details, but since it looks like you're adding =
support for a new message type that duplicates the functionality of an old=
er message type, a possible approach would be to configure the receiver to=
 output both and then verify that both the old and new versions of the cod=
e come up with the same (or possibly better) TPV decodes.  Though if suppo=
rting both results in duplicate TPV outputs, some tweaking would be needed=
 to be able to compare them.
TPV for NAV-PVT provides extra 'epx', 'epy' and 'epv' fields while NAV-SOL=
 does not. I assume you meant 'more fields' by 'better TPV decodes', as po=
sitional accuracy depends on the actual GPS configuration and its internal=
 calculation.

>Incidentally, when updating regression-test data, a fairly convenient app=
roach (if one is working in a git repo) is just to run "scons gps-makeregr=
ess" and then let git tell you what actually changed (and see if it's plau=
sible).  That lets you view the diffs much more flexibly than looking at t=
he test output from gps-regress.
Thanks for the extra tips!

-----Original Message-----
From: Fred Wright [mailto:fw@fwright.net]=20
Sent: Saturday, July 22, 2017 8:41 AM
To: GPSD Developers List
Cc: Clark Li
Subject: RE: [gpsd-dev] [PATCH] Support UBX NAV-PVT


(Back on-list since some issues might be of wider interest)

On Thu, 20 Jul 2017, Clark Li wrote:

> Thanks Fred. I've sent out another one with log/check for NAV-PVT from u=
blox-neo-m8n.

Previously, I hadn't bothered to try to apply your patch after seeing the =
issue I reported, but I've now tried it and it (either version) fails to a=
pply.  There seems to be some inconsistency between the state of driver_ub=
x.c and what the patch expects.  Ordinarily this might be due to the patch=
's being based on a different revision of the file, but in this case the b=
lob ID in the patch matches the state of the file, so I'm puzzled.  Did yo=
u have uncommitted changes to the file at the time you ran git format-patc=
h?  I don't know what the effect of that is, but it's my best guess as to =
why the patch is bad.

> Changes for ublox-aek-4t.log.chk is actually for the processing fTOW=20
> in driver_ubx.c

Except that if you look closely at the diff, you'll see that the only actu=
al change to that file is the introduction of some spurious line breaks.  =
It makes sense that the output is effectively unchanged, but it doesn't ma=
ke sense that some spurious newlines appeared.  Did you perhaps obtain the=
 "updated" version via copy-n-paste rather than from "regress-driver -b"?

It's also odd that only that one case was affected by whatever you did.
Did you only run the one test case, rather than all of them (typically via=
 "scons check")?

With regard to the new test data, did you do some form of sanity check on =
it?  All the regression tests can do is verify that the code continues to =
produce the same results as before; they have no built-in concept of "corr=
ect" results.  I don't know the specific details, but since it looks like =
you're adding support for a new message type that duplicates the functiona=
lity of an older message type, a possible approach would be to configure t=
he receiver to output both and then verify that both the old and new versi=
ons of the code come up with the same (or possibly better) TPV decodes.  T=
hough if supporting both results in duplicate TPV outputs, some tweaking w=
ould be needed to be able to compare them.

Incidentally, when updating regression-test data, a fairly convenient appr=
oach (if one is working in a git repo) is just to run "scons gps-makeregre=
ss" and then let git tell you what actually changed (and see if it's plaus=
ible).  That lets you view the diffs much more flexibly than looking at th=
e test output from gps-regress.

Fred Wright

______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com ___________=
___________________________________________________________

This communication may contain confidential or copyright information. If y=
ou are not an intended recipient, you must=20not keep, forward, copy, use,=
 save or rely on this communication, and any such action is unauthorized a=
nd prohibited. If you have received this communication in error, please re=
ply to this email to notify the sender of its incorrect delivery and then =
delete both the original message and your reply.
--_002_4EE4C24172624C4D8128D445E37EF8AB17857FADcwsvr13cohdawir_
Content-Type: application/octet-stream;
	name="0001-Support-UBX-NAV-PVT.patch"
Content-Description: 0001-Support-UBX-NAV-PVT.patch
Content-Disposition: attachment; filename="0001-Support-UBX-NAV-PVT.patch";
	size=24185; creation-date="Tue, 25 Jul 2017 13:08:42 GMT";
	modification-date="Tue, 25 Jul 2017 13:08:07 GMT"
Content-Transfer-Encoding: base64

RnJvbSBjYmJhYzcxZDkyYWY1NGE2MTkzNmJkZDIxMWIyOGMyNGMxZDgzYzVkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDbGFyayBMaSA8Y2xhcmsubGlAY29oZGF3aXJlbGVzcy5jb20+
CkRhdGU6IFRodSwgMjAgSnVsIDIwMTcgMDk6MTQ6MjEgKzAxMDAKU3ViamVjdDogW1BBVENIXSBT
dXBwb3J0IFVCWCBOQVYtUFZUCgpOQVYtU09MIGhhcyBvbmx5IGJlZW4gcmV0YWluZWQgZm9yIGJh
Y2t3YXJkcyBjb21wYXRpYmlsaXR5OyB1c2VycyBhcmUKcmVjb21tZW5kZWQgdG8gdXNlIHRoZSBV
QlgtTkFWLVBWVCBtZXNzYWdlIGluIHByZWZlcmVuY2UuCgpBIHJlZ3Jlc3Npb24gdGVzdCBjYXNl
IHVzaW5nIHVibG94LW5lby1tOG4gaXMgYWxzbyBhZGRlZC4KCkFsc28gZml4IHRoZSBjaGVja2lu
ZyBvbiB2YWxpZCBmbGFncyBvZiBpVE9XIGFuZCBmVE9XIGFuZCBwcm9jZXNzIGZUT1cgd2hvc2UK
cmFuZ2UgaXMgKy01MDB1cy4gVXBkYXRlIHRlc3QvZGFlL3VibG94LWFlay00dC5sb2cuY2hrIGFj
Y29yZGluZ2x5LgoKU2lnbmVkLW9mZi1ieTogQ2xhcmsgTGkgPGNsYXJrLmxpQGNvaGRhd2lyZWxl
c3MuY29tPgotLS0KIGRyaXZlcl91YnguYyAgICAgICAgICAgICAgICAgICAgICB8IDE3MCArKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQogZHJpdmVyX3VieC5oICAgICAgICAg
ICAgICAgICAgICAgIHwgIDExICsrKwogdGVzdC9kYWVtb24vdWJsb3gtYWVrLTR0LmxvZy5jaGsg
IHwgICAyICstCiB0ZXN0L2RhZW1vbi91YmxveC1uZW8tbThuLmxvZyAgICAgfCBCaW4gMCAtPiA1
MDU0IGJ5dGVzCiB0ZXN0L2RhZW1vbi91YmxveC1uZW8tbThuLmxvZy5jaGsgfCAxMjAgKysrKysr
KysrKysrKysrKysrKysrKysrKysrCiA1IGZpbGVzIGNoYW5nZWQsIDI3OSBpbnNlcnRpb25zKCsp
LCAyNCBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCB0ZXN0L2RhZW1vbi91YmxveC1u
ZW8tbThuLmxvZwogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3QvZGFlbW9uL3VibG94LW5lby1tOG4u
bG9nLmNoawoKZGlmZiAtLWdpdCBhL2RyaXZlcl91YnguYyBiL2RyaXZlcl91YnguYwppbmRleCA4
OGJlNmMwNy4uNjIzNmMyNWQgMTAwNjQ0Ci0tLSBhL2RyaXZlcl91YnguYworKysgYi9kcml2ZXJf
dWJ4LmMKQEAgLTEzMCwxOSArMTMwLDEyOSBAQCBzdGF0aWMgZ3BzX21hc2tfdAogdWJ4X21zZ19u
YXZfcHZ0KHN0cnVjdCBncHNfZGV2aWNlX3QgKnNlc3Npb24sIHVuc2lnbmVkIGNoYXIgKmJ1ZiwK
IAkJc2l6ZV90IGRhdGFfbGVuKQogewotICAgIHVuc2lnbmVkIGludCBmbGFnczsKKyAgICB1aW50
OF90IHZhbGlkOworICAgIHVpbnQ4X3QgZmxhZ3M7CisgICAgdWludDhfdCBuYXZtb2RlOworICAg
IHN0cnVjdCB0bSB1bnBhY2tlZF9kYXRlOworICAgIGRvdWJsZSBzdWJzZWNvbmRzOworICAgIGRv
dWJsZSBoYWNjLCB2YWNjLCBzYWNjOworICAgIGludCAqc3RhdHVzID0gJnNlc3Npb24tPmdwc2Rh
dGEuc3RhdHVzOworICAgIGludCAqbW9kZSA9ICZzZXNzaW9uLT5uZXdkYXRhLm1vZGU7CiAgICAg
Z3BzX21hc2tfdCBtYXNrID0gMDsKIAogICAgIGlmIChkYXRhX2xlbiAhPSA5MikKLQlyZXR1cm4g
MDsKKyAgICAgICAgcmV0dXJuIDA7CiAKKyAgICB2YWxpZCA9ICh1bnNpZ25lZCBpbnQpZ2V0dWIo
YnVmLCAxMSk7CisgICAgbmF2bW9kZSA9ICh1bnNpZ25lZCBjaGFyKWdldHViKGJ1ZiwgMjApOwog
ICAgIGZsYWdzID0gKHVuc2lnbmVkIGludClnZXR1YihidWYsIDIxKTsKIAotICAgIC8qIFRPRE86
IGZpbmlzaCBkZWNvZGluZyBVQlhfTU9OX1BWVAotICAgICAqIG5vIG5lZWQgdW50aWwgZGVwcmVh
Y2FlZCBVQlhfTU9OX1NPTCBpcyBkZWFkCi0gICAgICovCisgICAgc3dpdGNoIChuYXZtb2RlKQor
ICAgIHsKKyAgICBjYXNlIFVCWF9NT0RFX1RNT05MWToKKyAgICB7CisgICAgICAgIGlmICgqbW9k
ZSAhPSBNT0RFX05PX0ZJWCkgeworICAgICAgICAgICAgKm1vZGUgPSBNT0RFX05PX0ZJWDsKKyAg
ICAgICAgICAgIG1hc2sgfD0gTU9ERV9TRVQ7CisgICAgICAgIH0KKyAgICAgICAgaWYgKCpzdGF0
dXMgIT0gU1RBVFVTX05PX0ZJWCkgeworICAgICAgICAgICAgKnN0YXR1cyA9IFNUQVRVU19OT19G
SVg7CisgICAgICAgICAgICBtYXNrIHw9IFNUQVRVU19TRVQ7CisgICAgICAgIH0KKyAgICAgICAg
YnJlYWs7CisgICAgfQorICAgIGNhc2UgVUJYX01PREVfM0Q6CisgICAgY2FzZSBVQlhfTU9ERV9H
UFNEUjoKKyAgICB7CisgICAgICAgIGlmICgqbW9kZSAhPSBNT0RFXzNEKSB7CisgICAgICAgICAg
ICAqbW9kZSA9IE1PREVfM0Q7CisgICAgICAgICAgICBtYXNrIHw9IE1PREVfU0VUOworICAgICAg
ICB9CisgICAgICAgIGlmICgoZmxhZ3MgJiBVQlhfTkFWX1BWVF9GTEFHX0RHUFMpID09IFVCWF9O
QVZfUFZUX0ZMQUdfREdQUykgeworICAgICAgICAgICAgaWYgKCpzdGF0dXMgIT0gU1RBVFVTX0RH
UFNfRklYKSB7CisgICAgICAgICAgICAgICAgKnN0YXR1cyA9IFNUQVRVU19ER1BTX0ZJWDsKKyAg
ICAgICAgICAgICAgICBtYXNrIHw9IFNUQVRVU19TRVQ7CisgICAgICAgICAgICB9CisgICAgICAg
IH0gZWxzZSB7CisgICAgICAgICAgICBpZiAoKnN0YXR1cyAhPSBTVEFUVVNfRklYKSB7CisgICAg
ICAgICAgICAgICAgKnN0YXR1cyA9IFNUQVRVU19GSVg7CisgICAgICAgICAgICAgICAgbWFzayB8
PSBTVEFUVVNfU0VUOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgICAgIG1hc2sgfD0g
ICBMQVRMT05fU0VUIHwgQUxUSVRVREVfU0VUIHwgU1BFRURfU0VUIHwgVFJBQ0tfU0VUIHwgQ0xF
QVJfSVMKKyAgICAgICAgICAgICAgICB8IFJFUE9SVF9JUzsKKyAgICAgICAgYnJlYWs7CisgICAg
fQorICAgIGNhc2UgVUJYX01PREVfMkQ6CisgICAgY2FzZSBVQlhfTU9ERV9EUjogICAgICAgIC8q
IGNvbnNpZGVyIHRoaXMgdG9vIGFzIDJEICovCisgICAgeworICAgICAgICBpZiAoKm1vZGUgIT0g
TU9ERV8yRCkgeworICAgICAgICAgICAgKm1vZGUgPSBNT0RFXzJEOworICAgICAgICAgICAgbWFz
ayB8PSBNT0RFX1NFVDsKKyAgICAgICAgfTsKKyAgICAgICAgaWYgKCpzdGF0dXMgIT0gU1RBVFVT
X0ZJWCkgeworICAgICAgICAgICAgKnN0YXR1cyA9IFNUQVRVU19GSVg7CisgICAgICAgICAgICBt
YXNrIHw9IFNUQVRVU19TRVQ7CisgICAgICAgIH0KKyAgICAgICAgbWFzayB8PSBMQVRMT05fU0VU
IHwgU1BFRURfU0VUOworICAgICAgICBicmVhazsKKyAgICB9CisgICAgZGVmYXVsdDoKKyAgICB7
CisgICAgICAgIGlmICgqbW9kZSAhPSBNT0RFX05PX0ZJWCkgeworICAgICAgICAgICAgKm1vZGUg
PSBNT0RFX05PX0ZJWDsKKyAgICAgICAgICAgIG1hc2sgfD0gTU9ERV9TRVQ7CisgICAgICAgIH07
CisgICAgICAgIGlmICgqc3RhdHVzICE9IFNUQVRVU19OT19GSVgpIHsKKyAgICAgICAgICAgICpz
dGF0dXMgPSBTVEFUVVNfTk9fRklYOworICAgICAgICAgICAgbWFzayB8PSBTVEFUVVNfU0VUOwor
ICAgICAgICB9CisgICAgICAgIGJyZWFrOworICAgIH0KKyAgICB9CisKKyAgICBpZiAoKHZhbGlk
ICYgVUJYX05BVl9QVlRfVkFMSURfREFURV9USU1FKSA9PSBVQlhfTkFWX1BWVF9WQUxJRF9EQVRF
X1RJTUUpIHsKKyAgICAgICAgdW5wYWNrZWRfZGF0ZS50bV95ZWFyID0gKHVpbnQxNl90KWdldGxl
dTE2KGJ1ZiwgNCkgLSAxOTAwOworICAgICAgICB1bnBhY2tlZF9kYXRlLnRtX21vbiA9ICh1aW50
OF90KWdldHViKGJ1ZiwgNikgLSAxOworICAgICAgICB1bnBhY2tlZF9kYXRlLnRtX21kYXkgPSAo
dWludDhfdClnZXR1YihidWYsIDcpOworICAgICAgICB1bnBhY2tlZF9kYXRlLnRtX2hvdXIgPSAo
dWludDhfdClnZXR1YihidWYsIDgpOworICAgICAgICB1bnBhY2tlZF9kYXRlLnRtX21pbiA9ICh1
aW50OF90KWdldHViKGJ1ZiwgOSk7CisgICAgICAgIHVucGFja2VkX2RhdGUudG1fc2VjID0gKHVp
bnQ4X3QpZ2V0dWIoYnVmLCAxMCk7CisgICAgICAgIHVucGFja2VkX2RhdGUudG1faXNkc3QgPSAw
OworICAgICAgICB1bnBhY2tlZF9kYXRlLnRtX3dkYXkgPSAwOworICAgICAgICB1bnBhY2tlZF9k
YXRlLnRtX3lkYXkgPSAwOworICAgICAgICBzdWJzZWNvbmRzID0gMWUtOSAqIChpbnQzMl90KWdl
dGxlczMyKGJ1ZiwgMTYpOworICAgICAgICBzZXNzaW9uLT5uZXdkYXRhLnRpbWUgPSBcCisgICAg
ICAgICAgICAodGltZXN0YW1wX3QpbWtnbXRpbWUoJnVucGFja2VkX2RhdGUpICsgc3Vic2Vjb25k
czsKKyAgICAgICAgbWFzayB8PSBUSU1FX1NFVCB8IE5UUFRJTUVfSVM7CisgICAgfQorCisgICAg
c2Vzc2lvbi0+bmV3ZGF0YS5sb25naXR1ZGUgPSAxZS03ICogKGludDMyX3QpZ2V0bGVzMzIoYnVm
LCAyNCk7CisgICAgc2Vzc2lvbi0+bmV3ZGF0YS5sYXRpdHVkZSA9IDFlLTcgKiAoaW50MzJfdCln
ZXRsZXMzMihidWYsIDI4KTsKKyAgICBzZXNzaW9uLT5uZXdkYXRhLmFsdGl0dWRlID0gMWUtMyAq
IChpbnQzMl90KWdldGxlczMyKGJ1ZiwgMzIpOworICAgIHNlc3Npb24tPm5ld2RhdGEuc3BlZWQg
PSAxZS0zICogKGludDMyX3QpZ2V0bGVzMzIoYnVmLCA2MCk7CisgICAgc2Vzc2lvbi0+bmV3ZGF0
YS50cmFjayA9IDFlLTUgKiAoaW50MzJfdClnZXRsZXMzMihidWYsIDY0KTsKKyAgICBoYWNjID0g
KGRvdWJsZSkoZ2V0bGVzMzIoYnVmLCA0MCkgLyAxMDAwLjApOworICAgIHZhY2MgPSAoZG91Ymxl
KShnZXRsZXMzMihidWYsIDQ0KSAvIDEwMDAuMCk7CisgICAgc2FjYyA9IChkb3VibGUpKGdldGxl
czMyKGJ1ZiwgNDgpIC8gMTAwMC4wKTsKKyAgICAvLyBlcHggXiAyICsgZXB5IF4gMiA9IGhhY2Mg
XiAyCisgICAgc2Vzc2lvbi0+bmV3ZGF0YS5lcHggPSBzZXNzaW9uLT5uZXdkYXRhLmVweSA9IDAu
NzA3ICogaGFjYzsKKyAgICBzZXNzaW9uLT5uZXdkYXRhLmVwdiA9IHZhY2M7CisgICAgc2Vzc2lv
bi0+bmV3ZGF0YS5lcHMgPSBzYWNjOworICAgIG1hc2sgfD0gSEVSUl9TRVQgfCBWRVJSX1NFVCB8
IFNQRUVERVJSX1NFVDsKICAgICBncHNkX2xvZygmc2Vzc2lvbi0+Y29udGV4dC0+ZXJyb3V0LCBM
T0dfREFUQSwKLQkgICAgICJOQVYtUFZUOiBmbGFnczolMDJ4XG4iLCBmbGFncyk7CisgICAgICAg
ICAiTkFWX1BWVDogZmxhZ3M9JTAyeCB0aW1lPSUuMmYgbGF0PSUuMmYgbG9uPSUuMmYgYWx0PSUu
MmYgdHJhY2s9JS4yZiBzcGVlZD0lLjJmIGNsaW1iPSUuMmYgbW9kZT0lZCBzdGF0dXM9JWQgdXNl
ZD0lZFxuIiwKKyAgICAgICAgIGZsYWdzLAorICAgICAgICAgc2Vzc2lvbi0+bmV3ZGF0YS50aW1l
LAorICAgICAgICAgc2Vzc2lvbi0+bmV3ZGF0YS5sYXRpdHVkZSwKKyAgICAgICAgIHNlc3Npb24t
Pm5ld2RhdGEubG9uZ2l0dWRlLAorICAgICAgICAgc2Vzc2lvbi0+bmV3ZGF0YS5hbHRpdHVkZSwK
KyAgICAgICAgIHNlc3Npb24tPm5ld2RhdGEudHJhY2ssCisgICAgICAgICBzZXNzaW9uLT5uZXdk
YXRhLnNwZWVkLAorICAgICAgICAgc2Vzc2lvbi0+bmV3ZGF0YS5jbGltYiwKKyAgICAgICAgIHNl
c3Npb24tPm5ld2RhdGEubW9kZSwKKyAgICAgICAgIHNlc3Npb24tPmdwc2RhdGEuc3RhdHVzLAor
ICAgICAgICAgc2Vzc2lvbi0+Z3BzZGF0YS5zYXRlbGxpdGVzX3VzZWQpOwogICAgIHJldHVybiBt
YXNrOwogfQogCkBAIC0xNjYsMTAgKzI3NiwxMiBAQCB1YnhfbXNnX25hdl9zb2woc3RydWN0IGdw
c19kZXZpY2VfdCAqc2Vzc2lvbiwgdW5zaWduZWQgY2hhciAqYnVmLAogI2RlZmluZSBEQVRFX1ZB
TElECShVQlhfU09MX1ZBTElEX1dFRUsgfCBVQlhfU09MX1ZBTElEX1RJTUUpCiAgICAgaWYgKChm
bGFncyAmIERBVEVfVkFMSUQpID09IERBVEVfVkFMSUQpIHsKIAl1bnNpZ25lZCBzaG9ydCBndzsK
LQl1bnNpZ25lZCBpbnQgdG93OwotCXRvdyA9ICh1bnNpZ25lZCBpbnQpZ2V0bGV1MzIoYnVmLCAw
KTsKKwl1bnNpZ25lZCBpbnQgaVRPVzsKKwlpbnQgZlRPVzsKKwlpVE9XID0gKHVuc2lnbmVkIGlu
dClnZXRsZXUzMihidWYsIDApOworCWZUT1cgPSAoaW50KWdldGxlczMyKGJ1ZiwgNCk7CiAJZ3cg
PSAodW5zaWduZWQgc2hvcnQpZ2V0bGVzMTYoYnVmLCA4KTsKLQlzZXNzaW9uLT5uZXdkYXRhLnRp
bWUgPSBncHNkX2dwc3RpbWVfcmVzb2x2ZShzZXNzaW9uLCBndywgdG93IC8gMTAwMC4wKTsKKwlz
ZXNzaW9uLT5uZXdkYXRhLnRpbWUgPSBncHNkX2dwc3RpbWVfcmVzb2x2ZShzZXNzaW9uLCBndywg
KGlUT1cgKiAxZS0zKSArIChmVE9XICogMWUtOSkpOwogCW1hc2sgfD0gVElNRV9TRVQgfCBOVFBU
SU1FX0lTOwogICAgIH0KICN1bmRlZiBEQVRFX1ZBTElECkBAIC0yOTIsMjQgKzQwNCwzNiBAQCBz
dGF0aWMgZ3BzX21hc2tfdAogdWJ4X21zZ19uYXZfdGltZWdwcyhzdHJ1Y3QgZ3BzX2RldmljZV90
ICpzZXNzaW9uLCB1bnNpZ25lZCBjaGFyICpidWYsCiAJCSAgICBzaXplX3QgZGF0YV9sZW4pCiB7
Ci0gICAgdW5zaWduZWQgaW50IGd3LCB0b3csIGZsYWdzOworICAgIHVuc2lnbmVkIGludCBndywg
aVRPVywgZmxhZ3M7CisgICAgaW50IGZUT1c7CisgICAgZ3BzX21hc2tfdCBtYXNrID0gMDsKIAog
ICAgIGlmIChkYXRhX2xlbiAhPSAxNikKLQlyZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIDA7CiAK
LSAgICB0b3cgPSAodW5zaWduZWQgaW50KWdldGxldTMyKGJ1ZiwgMCk7Ci0gICAgZ3cgPSAodW5z
aWduZWQgaW50KWdldGxlczE2KGJ1ZiwgOCk7CiAgICAgZmxhZ3MgPSAodW5zaWduZWQgaW50KWdl
dHViKGJ1ZiwgMTEpOwotICAgIGlmICgoZmxhZ3MgJiAweDcpICE9IDApCi0Jc2Vzc2lvbi0+Y29u
dGV4dC0+bGVhcF9zZWNvbmRzID0gKGludClnZXR1YihidWYsIDEwKTsKLSAgICBzZXNzaW9uLT5u
ZXdkYXRhLnRpbWUgPSBncHNkX2dwc3RpbWVfcmVzb2x2ZShzZXNzaW9uLAotCQkJCQkgICAgICAo
dW5zaWduZWQgc2hvcnQgaW50KWd3LAotCQkJCQkgICAgICAoZG91YmxlKXRvdyAvIDEwMDAuMCk7
CisgICAgLy8gVmFsaWQgbGVhcCBzZWNvbmRzCisgICAgaWYgKChmbGFncyAmIFVCWF9USU1FR1BT
X1ZBTElEX0xFQVBfU0VDT05EKSA9PSBVQlhfVElNRUdQU19WQUxJRF9MRUFQX1NFQ09ORCkKKyAg
ICAgICAgc2Vzc2lvbi0+Y29udGV4dC0+bGVhcF9zZWNvbmRzID0gKGludClnZXR1YihidWYsIDEw
KTsKKyAgICAvLyBWYWxpZCBHUFMgdGltZSBvZiB3ZWVrIGFuZCB3ZWVrIG51bWJlcgorI2RlZmlu
ZSBWQUxJRF9USU1FIChVQlhfVElNRUdQU19WQUxJRF9USU1FIHwgVUJYX1RJTUVHUFNfVkFMSURf
V0VFSykKKyAgICBpZiAoKGZsYWdzICYgVkFMSURfVElNRSkgPT0gVkFMSURfVElNRSkKKyN1bmRl
ZiBWQUxJRF9USU1FCisgICAgeworICAgICAgICBpVE9XID0gKHVuc2lnbmVkIGludClnZXRsZXUz
MihidWYsIDApOworICAgICAgICBmVE9XID0gKGludClnZXRsZXMzMihidWYsIDQpOworICAgICAg
ICBndyA9ICh1bnNpZ25lZCBpbnQpZ2V0bGVzMTYoYnVmLCA4KTsKKyAgICAgICAgc2Vzc2lvbi0+
bmV3ZGF0YS50aW1lID0KKyAgICAgICAgICBncHNkX2dwc3RpbWVfcmVzb2x2ZShzZXNzaW9uLAor
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh1bnNpZ25lZCBzaG9ydCBpbnQpZ3csCisg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChkb3VibGUpaVRPVyAqIDFlLTMpICsgKChk
b3VibGUpZlRPVyAqIDFlLTkpKTsKKyAgICAgICAgbWFzayB8PSAoVElNRV9TRVQgfCBOVFBUSU1F
X0lTKTsKKyAgICB9CiAKICAgICBncHNkX2xvZygmc2Vzc2lvbi0+Y29udGV4dC0+ZXJyb3V0LCBM
T0dfREFUQSwKLQkgICAgICJUSU1FR1BTOiB0aW1lPSUuMmYgbGVhcD0lZCwgbWFzaz17VElNRX1c
biIsCi0JICAgICBzZXNzaW9uLT5uZXdkYXRhLnRpbWUsIHNlc3Npb24tPmNvbnRleHQtPmxlYXBf
c2Vjb25kcyk7Ci0gICAgcmV0dXJuIFRJTUVfU0VUIHwgTlRQVElNRV9JUzsKKyAgICAgICAgICAg
ICAiVElNRUdQUzogdGltZT0lLjJmIG1hc2s9e1RJTUV9XG4iLAorICAgICAgICAgICAgIHNlc3Np
b24tPm5ld2RhdGEudGltZSk7CisgICAgcmV0dXJuIG1hc2s7CiB9CiAKIC8qKgpAQCAtNDg2LDgg
KzYxMCw4IEBAIGdwc19tYXNrX3QgdWJ4X3BhcnNlKHN0cnVjdCBncHNfZGV2aWNlX3QgKiBzZXNz
aW9uLCB1bnNpZ25lZCBjaGFyICpidWYsCiAJYnJlYWs7CiAgICAgY2FzZSBVQlhfTkFWX1BWVDoK
IAlncHNkX2xvZygmc2Vzc2lvbi0+Y29udGV4dC0+ZXJyb3V0LCBMT0dfUFJPRywgIlVCWF9OQVZf
UFZUXG4iKTsKLQltYXNrID0gdWJ4X21zZ19uYXZfcHZ0KHNlc3Npb24sICZidWZbVUJYX1BSRUZJ
WF9MRU5dLCBkYXRhX2xlbik7Ci0gICAgICAgIGJyZWFrOworCW1hc2sgPSB1YnhfbXNnX25hdl9w
dnQoc2Vzc2lvbiwgJmJ1ZltVQlhfUFJFRklYX0xFTl0sIGRhdGFfbGVuKQorICAgICAgICAgICAg
IHwgKENMRUFSX0lTIHwgUkVQT1JUX0lTKTsKICAgICBjYXNlIFVCWF9OQVZfUE9TVVRNOgogCWdw
c2RfbG9nKCZzZXNzaW9uLT5jb250ZXh0LT5lcnJvdXQsIExPR19EQVRBLCAiVUJYX05BVl9QT1NV
VE1cbiIpOwogCWJyZWFrOwpkaWZmIC0tZ2l0IGEvZHJpdmVyX3VieC5oIGIvZHJpdmVyX3VieC5o
CmluZGV4IGMyM2VmZGY3Li45OWVmOWI5OCAxMDA2NDQKLS0tIGEvZHJpdmVyX3VieC5oCisrKyBi
L2RyaXZlcl91YnguaApAQCAtMTAyLDYgKzEwMiwxMCBAQCB0eXBlZGVmIGVudW0gewogI2RlZmlu
ZSBVQlhfU09MX1ZBTElEX1dFRUsgMHgwNAogI2RlZmluZSBVQlhfU09MX1ZBTElEX1RJTUUgMHgw
OAogCisjZGVmaW5lIFVCWF9USU1FR1BTX1ZBTElEX1RJTUUgICAgICAgIDB4MDEKKyNkZWZpbmUg
VUJYX1RJTUVHUFNfVkFMSURfV0VFSyAgICAgICAgMHgwMgorI2RlZmluZSBVQlhfVElNRUdQU19W
QUxJRF9MRUFQX1NFQ09ORCAweDA0CisKIC8qIGZyb20gVUJYX05BVl9TVklORk8gKi8KICNkZWZp
bmUgVUJYX1NBVF9VU0VEIDB4MDEKICNkZWZpbmUgVUJYX1NBVF9ER1BTIDB4MDIKQEAgLTExOCw0
ICsxMjIsMTEgQEAgdHlwZWRlZiBlbnVtIHsKICNkZWZpbmUgVUJYX1NJR19DRENSTEsyIDYKICNk
ZWZpbmUgVUJYX1NJR19OQVZNU0cgNwogCisjZGVmaW5lIFVCWF9OQVZfUFZUX1ZBTElEX0RBVEUg
ICAgICAweDAxCisjZGVmaW5lIFVCWF9OQVZfUFZUX1ZBTElEX1RJTUUgICAgICAweDAyCisjZGVm
aW5lIFVCWF9OQVZfUFZUX1ZBTElEX0RBVEVfVElNRSAoVUJYX05BVl9QVlRfVkFMSURfREFURSB8
IFVCWF9OQVZfUFZUX1ZBTElEX1RJTUUpCisKKyNkZWZpbmUgVUJYX05BVl9QVlRfRkxBR19HUFNf
RklYX09LIDB4MDEKKyNkZWZpbmUgVUJYX05BVl9QVlRfRkxBR19ER1BTICAgICAgIDB4MDIKKwog
I2VuZGlmIC8qIF9HUFNEX1VCWF9IXyAqLwpkaWZmIC0tZ2l0IGEvdGVzdC9kYWVtb24vdWJsb3gt
YWVrLTR0LmxvZy5jaGsgYi90ZXN0L2RhZW1vbi91YmxveC1hZWstNHQubG9nLmNoawppbmRleCA0
NTY4MGVhNi4uMzFhY2Q5NzkgMTAwNjQ0Ci0tLSBhL3Rlc3QvZGFlbW9uL3VibG94LWFlay00dC5s
b2cuY2hrCisrKyBiL3Rlc3QvZGFlbW9uL3VibG94LWFlay00dC5sb2cuY2hrCkBAIC0yNiw0ICsy
Niw0IEBAICRHUFpEQSwyMzExMjcuMDAsMjMsMTIsMjAwNywwMCwwMCo2NQogJEdQR0dBLDIzMTEy
NiwyMDM3Ljc1NjksTiwwODcwNC4wODQ1LFcsMiwwNywxLjY3LDc1Ljc1LE0sLTEzLjg2NSxNLCwq
NEMNCiAkR1BSTUMsMjMxMTI2LEEsMjAzNy43NTY5LE4sMDg3MDQuMDg0NSxXLDAuMDAwMCwwLjAw
MCwyMzEyMDcsLCozNg0KICRHUEdTQSxBLDMsMTUsMiwzMCw1LDEyLDE4LDEzNSwsLCwsLDIuNiwx
LjcsMi4wKjBGDQoteyJjbGFzcyI6IlRQViIsInN0YXR1cyI6MiwibW9kZSI6MywidGltZSI6IjIw
MDctMTItMjNUMjM6MTE6MjYuOTk5WiIsImVwdCI6MC4wMDUsImxhdCI6MjAuNjI5MjgxNzE4LCJs
b24iOi04Ny4wNjgwNzU0MjQsImFsdCI6NzUuNzU0LCJlcHgiOjIuOTczLCJlcHkiOjYuMTM4LCJl
cHYiOjExLjQ0MywidHJhY2siOjAuMDAwMCwic3BlZWQiOjAuMDAwLCJjbGltYiI6MC4wMDAsImVw
cyI6MC4xNywiZXBjIjoyMi44OX0NCit7ImNsYXNzIjoiVFBWIiwic3RhdHVzIjoyLCJtb2RlIjoz
LCJ0aW1lIjoiMjAwNy0xMi0yM1QyMzoxMToyNi45OTlaIiwiZXB0IjowLjAwNSwibGF0IjoyMC42
MjkyODE3MTgsImxvbiI6LTg3LjA2ODA3NTQyNCwiYWx0Ijo3NS43NTQsImVweCI6Mi45NzMsImVw
eSI6Ni4xMzgsImVwdiI6MTEuNDQzLCJ0cmFjayI6MC4wMDAwLCJzcGVlZCI6MC4wMDAsImNsaW1i
IjowLjAwMCwiZXBzIjowLjE3LCJlcGMiOjIyLjg4fQ0KZGlmZiAtLWdpdCBhL3Rlc3QvZGFlbW9u
L3VibG94LW5lby1tOG4ubG9nIGIvdGVzdC9kYWVtb24vdWJsb3gtbmVvLW04bi5sb2cKbmV3IGZp
bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMC4uMjhmN2MxMjEwY2VmYzg3MzkwYWNlZDg5NjBlYWZmMTMzMjEzZTlmNApHSVQgYmluYXJ5
IHBhdGNoCmxpdGVyYWwgNTA1NAp6Y21iN3w0XlVMczZeSEt2eU5lNFZoPTN4SiQzaj8pZih1cWJW
ajI7UiN2K25udCFiXldFTmZVO1QpSGdma0ZrbDkKejc7OSNkWHtWJFMjaShnVHA7fUI2bn01IXZy
ZkcpTWFvU0dDRytMK0ZSRmJHa1RkWEZVUkpYdEwmVUBAI2VLU1UhCnolZjBPMF9yQVVGLTB6O1ZX
LUZEaFc+MEJiZXgxK1hwO1J0amsteG04UWZjPHJ4QXtEX1leQSl4K3RUVUBtTVlvPQp6ZUZvbURa
bVZuZDI3e2hKc1ojRTkxKTd1IXVRSzBGcVhNNklmIXA2dT9gcm8zSlUmbHJZa31MfXs3cWM0JFFB
VUkKekRuLXUxOyhUWHVlJklhNFJOOzVLZj9vZ25RbCtmazw4eWlJSnV7Vyt2WUFSKlRXY2BqQF9B
aHxtRCU0WW17KExYCnpyJj1rVFR+YVhEPWAzRHMlZl4pfThAI1FgSTxMPjhwZkM1Z2JPeVcrSHcy
WURfakRwU21BWHpQKngqcj9SOD1vaAp6U18xdz9rMntFfjdVQ35fPUheeiMpemFlWUVMQj1QOShB
NjJyfTduNTU4WXE2TURlYXlVI3NgeEx3TWBqPW1SUE4KenpkeHZ+XjlQaUFQdGZKe3dIRFpIWFQ7
JDtsWFo9N1pkO3g3NTM0bWZ3biE5NTNuM2hqOWg/OyVaQSY8S1Zkc05lCnotemRDTDxyWlNOTUY/
TXY1RFA2cmQ+I3NnJlo2YUZaWUo3KioocFpRSGBJKDVLTmFINGZlSmYqPERVP1o0U2dGNwp6Qn5m
TU1jM2NualN0bllGQHktPXlVbTBWWVJDWHVrNVBKfnBDJjlMWntVWEBTVjMmaVBoLT8xYGJ7dSpk
NlotKUEKelA2UEpsSDwoUn5jOE5XX2h9cG1FKGJ2dUZjVDNPNT5GbWVCSzI7fSM3d2lEbyVmUzg7
Kz4yPH0oUjZrbippUlgtCnpfd1FzakZAX31lKW1fWn5AJUF0cXctQFF4UE5XaDBIKDIqM3VtYH1O
MmxmeH5XKTt7ZW1fdjx6XmtARGUjPVFwWQp6LVZgd0F0VHF3RGx6flltNW1rKllhVXk9amhgc25O
dmduc05II3gpOUVvIUQ8WTt8Tzw2fXdHJCZeUl9keyVNZ1AKelFwZS0kQHpjYj9rVUEmTWs+bjkp
YFN0TlJqdHw4fTkjMlIkcFQ9ZCRicE5DckMwNHgwXk9LYmM5I2Ipb0NuPlJgCnpBfCVyMnt1eiR0
P30+bCZ3VkJpSi02SElRU2YpKSVBO21TNyMjX1Q8dm5kUHJTKjZZfk1+NlNaU3ozJDVCSkFaUgp6
O1BEd08pQGRfQiFtSGxqNS1afldMTFpBPkEyKWZ7TnNLNGEqZTB3TmVTVHU8XnJ1Qm5DPDl6ZVFr
PDx2QiR5YEEKemM7YU14bGp3Kl5yZzhHcl5uOCZNJUViNyZaNSYmQXpFZTdSUGc0dzIjJksrYGMw
fFV1PkNMMHI2eCl7JitsYDJBCnpCVnYyaUZLfWxlc3VBME5WTHg1ZzhwVzlRXlpAIV84Xm1fbzIo
eVhkbURtTlZuTFc4VGw2XzxveUctbVp1JF5HUAp6RFkzMks1UEprfHl2RHdPe3Y4QU1nOUB7V0B3
JnViYFZ6Q3hqSXBETj4zSmt7dkNBKW0tNDZEczNrTCQmb3BeSTQKeilAe2R9QnM1fkBxTmpDI2pR
O05pWjJ2Uk5DUHAwWU9YbW5OPlRKeTN6ZilnI2x6TlY9b3pFXkcyMElBJEErUSZLCnotSHdZTTBH
a3wrIXUyUTcofEpWZlZmMj5gKnpUKiRDZEx8I1Axa0kyRn12bVlOY1B9JGNBM35lMEp7VjFTZ2Bk
bwp6akFERVIrYHBvd1lWMHIyQylEMTJldHkqczIzI2hfdHpGKE94IWYoZT58b2JhbS17N2BoeHY4
WTw8RUcwbGdxfj8Kem11RXtaVXlAd0R6fUtvUz1OaD0ySFJkKER5eih8JiZWYjgzcyZ8bnRyJTVp
U3M0bW1fVl5MaytwfThDbm10IVFDCnphWWxgfj5gP0VTKjJTQDw9WCszIT9YeVFYd2s1a0ZWPUlv
YiVkYTR8JjR9JU0jUC07RkF6SEFubVNTSSNPU0NVUAp6TG0jaWpiX2wpUUFoej09bWAjbDk1Xz5S
Pio8eUU/UDR8NEBhZHcmNWpiTWpyZz9JKytOQVR1RFZBRH41NzJKUUsKek9+YVY+XmVGbmY0Y0hV
VUduKkpJSGlVZ1R3dSN3OFc5KD92PHJnckEmYWxfT1VJK0g4VUByeGAzK3o+Myh8VkpeCnpxQ1E8
PzUyOWFnejswY3xZK34kfCprX00zYHpMJCFid3tmJVUlWkUxQ1V6YXo/TzxFTClebFM1SVB+MUZw
PHhUQwp6PndYMSZ0cFdSI283dXp8KSE1fG53SCMpemVqJD13RjVYeDNeNk95TmZJWW9kaH1XOUFD
YiVFI2o+V2EpQF8qMU0KemNoTkphXlJ2VCVlSyp4U2FHNG1sY0tMYjk8dD51U3ZveDJwayhVUH5t
O1daWWR8cT1vP1N7TzNPbWFEMmFAbE1PCno9akJme211RGFeLX1OPElVVUhpKnppUXhlc15vSTI8
Wj1xfl4wUUsyeyEoeVdQRDVUVUhpY2N6UlBSfWBmbiFWMAp6Y2l8KTlUNjZNSzk5IWlWaytKUTVp
KFJKSmVoO3g3dHdEWjVZLV9ObTNsUTUmaTBNfmEoe3AxVlYhUEVLd3pFRUQKekhaZ3VDdjVQMlFx
c0lRXjJLTEFrPkB3fT8/fHxKMF9GUy0rZnQ/Njg8cHxvKDxkanwkUEBUS09mY143c1cpdEpBCnoj
UXMoeHZrKDFKVXc0ZV5RfUlUMmBMfCRLZ01BO15DdyE+dyFIeG5PKmJ1RnFhLUBFU15AOUI/MU5P
bDBuTjVzMgp6eFVYS3t1WH5RITllWDMkVGtkNi1zVUUyV2B8P15MSGlLT1JfTlFpbmlaVD9VPy0l
cSN3RV85bWtOJGBPYHd6PlEKek9eblNGYF9ZZT55YFYzV3tlZypISl9Qbk11PWp4TjFVblAjS1k+
a1dDKU4xMFpreHY1aHlKKCRgO1NkdnotM357CnpFPm9RdVN6fGo7V0FEO2omTz9wZXJueCo3SE1V
KUhTKzIxXiZ8Sk9+SE1adkNnZWo4Q2NjUjd+KHA8S3FIckRmVQp6N0hhSGFFaWRQeCMrRl40cH1B
fXklZitVeDtqITY3X2JGd1Vxck9nIU8/bGJLPHJLK2ZJV0xwVGRuSzNrOGhhWEMKeiZlZHd7Ymt4
fEttbn15KncpQX04bXR4eWYjPDdqdjdhN35VeDdwPGJpMHh2O19QZERmeGg4ekFMMkwmUlRncGpQ
CnpAMH4rel81QWJee3ZJKWk/VFI5MTZUfFZOQFNjOG9BRzd+XzFIMUR7Y0RXenkxej9CMWtHdUBf
Ql94KF51dXA/Jgp6MCY2Qig0alMkMFB0amo5VkF0Tm9ZK2Bncz9Cb0FzX098YHt5M01NfiQxc1FU
QD9ObS0wZWNfVmJITj9+ZG40SDcKemtiYUtvPWc0OGFtZ3VePCo2ZXpWKn5FQlBWdC11OD9BcmNG
X1M3PFZjQE5rblV7YD5CeD4xTnpWRWUkdlE2bEw0CnpxQE1DNXQkUkVBSX1GKE1oblk9YERVWEpx
eG9KUE1eOUNaPlAwe1N+UE94VyNlUjIpe3t7aWUxVjd0Tm8wXkN0Rgp6e0haPHpWanNZYCgxM2oo
P0tRWWVqOWFfQk17QGFMJD5waDwlUT91KWhxU3okaHdzWkxDNn58ZlNhWEBhaGwoVX0KemBFQU1O
SWEqI09teWIjPWtNT21ibCRRJU1tJjB9UyVgVlRxT196SE9eME1zbUJzRExxLTw9YT5tdTt4QXR5
K3pwCmI0d3c2KilmfUJuRTw0cUdJekgjdigoYFNVVnIlPDl4MCZnVgoKbGl0ZXJhbCAwCkhjbVY/
ZDAwMDAxCgpkaWZmIC0tZ2l0IGEvdGVzdC9kYWVtb24vdWJsb3gtbmVvLW04bi5sb2cuY2hrIGIv
dGVzdC9kYWVtb24vdWJsb3gtbmVvLW04bi5sb2cuY2hrCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu
ZGV4IDAwMDAwMDAwLi5iMjI5YTNhYQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3QvZGFlbW9uL3Vi
bG94LW5lby1tOG4ubG9nLmNoawpAQCAtMCwwICsxLDEyMCBAQAorJEdQWkRBLDA4NTAwMC44MCwx
OSwwNywyMDE3LDAwLDAwKjY4DQorJEdQR0dBLDA4NTAwMCwzNDU0LjM3MzYsUywxMzgzNi40ODcy
LEUsMiwwMCwsMjUuNDIsTSwsLCowMA0KKyRHUFJNQywwODUwMDAsQSwzNDU0LjM3MzYsUywxMzgz
Ni40ODcyLEUsMC4wNTgzLDMxLjQ3MiwxOTA3MTcsLCowOA0KKyRHUEdTQSxBLDMsLCwsLCwsLCws
LCwsLCwqMUMNCit7ImNsYXNzIjoiVFBWIiwic3RhdHVzIjoyLCJtb2RlIjozLCJ0aW1lIjoiMjAx
Ny0wNy0xOVQwODo1MDowMC44MDBaIiwiZXB0IjowLjAwNSwibGF0IjotMzQuOTA2MjI2MzAwLCJs
b24iOjEzOC42MDgxMTk3MDAsImFsdCI6MjUuNDI0LCJlcHgiOjAuODAwLCJlcHkiOjAuODAwLCJl
cHYiOjEuNjAyLCJ0cmFjayI6MzEuNDcxOCwic3BlZWQiOjAuMDMwLCJlcHMiOi0wLjAxfQ0KKyRH
UFpEQSwwODUwMDEuMDAsMTksMDcsMjAxNywwMCwwMCo2MQ0KKyRHUEdHQSwwODUwMDAsMzQ1NC4z
NzM2LFMsMTM4MzYuNDg3MixFLDIsMDAsLDI1LjM4LE0sLCwqMEQNCiskR1BSTUMsMDg1MDAwLEEs
MzQ1NC4zNzM2LFMsMTM4MzYuNDg3MixFLDAuMDMxMSwzMS40NzIsMTkwNzE3LCwqMDUNCiskR1BH
U0EsQSwzLCwsLCwsLCwsLCwsLCwsKjFDDQoreyJjbGFzcyI6IlRQViIsInN0YXR1cyI6MiwibW9k
ZSI6MywidGltZSI6IjIwMTctMDctMTlUMDg6NTA6MDAuMDAwWiIsImVwdCI6MC4wMDUsImxhdCI6
LTM0LjkwNjIyNjYwMCwibG9uIjoxMzguNjA4MTE5OTAwLCJhbHQiOjI1LjM3OCwiZXB4IjowLjgw
MSwiZXB5IjowLjgwMSwiZXB2IjoxLjYwMywidHJhY2siOjMxLjQ3MTgsInNwZWVkIjowLjAxNiwi
Y2xpbWIiOi0wLjIzMCwiZXBzIjowLjAyLCJlcGMiOjE2LjAyfQ0KKyRHUFpEQSwwODUwMDEuMjAs
MTksMDcsMjAxNywwMCwwMCo2Mw0KKyRHUEdHQSwwODUwMDEsMzQ1NC4zNzM2LFMsMTM4MzYuNDg3
MixFLDIsMDAsLDI1LjMxLE0sLCwqMDUNCiskR1BSTUMsMDg1MDAxLEEsMzQ1NC4zNzM2LFMsMTM4
MzYuNDg3MixFLDAuMDMxMSwzMS40NzIsMTkwNzE3LCwqMDQNCiskR1BHU0EsQSwzLCwsLCwsLCws
LCwsLCwsKjFDDQoreyJjbGFzcyI6IlRQViIsInN0YXR1cyI6MiwibW9kZSI6MywidGltZSI6IjIw
MTctMDctMTlUMDg6NTA6MDEuMjAwWiIsImVwdCI6MC4wMDUsImxhdCI6LTM0LjkwNjIyNjkwMCwi
bG9uIjoxMzguNjA4MTE5OTAwLCJhbHQiOjI1LjMwNiwiZXB4IjowLjgwNSwiZXB5IjowLjgwNSwi
ZXB2IjoxLjYxMCwidHJhY2siOjMxLjQ3MTgsInNwZWVkIjowLjAxNiwiY2xpbWIiOi0wLjM2MCwi
ZXBzIjotMC4wMSwiZXBjIjoxNi4wNn0NCiskR1BaREEsMDg1MDAxLjQwLDE5LDA3LDIwMTcsMDAs
MDAqNjUNCiskR1BHR0EsMDg1MDAxLDM0NTQuMzczNixTLDEzODM2LjQ4NzIsRSwyLDAwLCwyNS4y
NixNLCwsKjAzDQorJEdQUk1DLDA4NTAwMSxBLDM0NTQuMzczNixTLDEzODM2LjQ4NzIsRSwwLjA1
ODMsMzEuNDcyLDE5MDcxNywsKjA5DQorJEdQR1NBLEEsMywsLCwsLCwsLCwsLCwsLCoxQw0KK3si
Y2xhc3MiOiJUUFYiLCJzdGF0dXMiOjIsIm1vZGUiOjMsInRpbWUiOiIyMDE3LTA3LTE5VDA4OjUw
OjAxLjQwMFoiLCJlcHQiOjAuMDA1LCJsYXQiOi0zNC45MDYyMjcxMDAsImxvbiI6MTM4LjYwODEy
MDIwMCwiYWx0IjoyNS4yNTgsImVweCI6MC44MDcsImVweSI6MC44MDcsImVwdiI6MS42MTYsInRy
YWNrIjozMS40NzE4LCJzcGVlZCI6MC4wMzAsImNsaW1iIjotMC4yNDAsImVwcyI6MC4wMiwiZXBj
IjoxNi4xM30NCiskR1BaREEsMDg1MDAxLjYwLDE5LDA3LDIwMTcsMDAsMDAqNjcNCiskR1BHR0Es
MDg1MDAxLDM0NTQuMzczNixTLDEzODM2LjQ4NzIsRSwyLDAwLCwyNS4xOSxNLCwsKjBGDQorJEdQ
Uk1DLDA4NTAwMSxBLDM0NTQuMzczNixTLDEzODM2LjQ4NzIsRSwwLjA0MDgsMzEuNDcyLDE5MDcx
NywsKjBCDQorJEdQR1NBLEEsMywsLCwsLCwsLCwsLCwsLCoxQw0KK3siY2xhc3MiOiJUUFYiLCJz
dGF0dXMiOjIsIm1vZGUiOjMsInRpbWUiOiIyMDE3LTA3LTE5VDA4OjUwOjAxLjYwMFoiLCJlcHQi
OjAuMDA1LCJsYXQiOi0zNC45MDYyMjc1MDAsImxvbiI6MTM4LjYwODEyMDMwMCwiYWx0IjoyNS4x
OTQsImVweCI6MC44MDksImVweSI6MC44MDksImVwdiI6MS42MTksInRyYWNrIjozMS40NzE4LCJz
cGVlZCI6MC4wMjEsImNsaW1iIjotMC4zMjAsImVwcyI6LTAuMDIsImVwYyI6MTYuMTd9DQorJEdQ
WkRBLDA4NTAwMS44MCwxOSwwNywyMDE3LDAwLDAwKjY5DQorJEdQR0dBLDA4NTAwMSwzNDU0LjM3
MzcsUywxMzgzNi40ODcyLEUsMiwwMCwsMjUuMTQsTSwsLCowMw0KKyRHUFJNQywwODUwMDEsQSwz
NDU0LjM3MzcsUywxMzgzNi40ODcyLEUsMC4wMjUzLDMxLjQ3MiwxOTA3MTcsLCowMg0KKyRHUEdT
QSxBLDMsLCwsLCwsLCwsLCwsLCwqMUMNCit7ImNsYXNzIjoiVFBWIiwic3RhdHVzIjoyLCJtb2Rl
IjozLCJ0aW1lIjoiMjAxNy0wNy0xOVQwODo1MDowMS44MDBaIiwiZXB0IjowLjAwNSwibGF0Ijot
MzQuOTA2MjI3ODAwLCJsb24iOjEzOC42MDgxMjAzMDAsImFsdCI6MjUuMTM2LCJlcHgiOjAuODA5
LCJlcHkiOjAuODA5LCJlcHYiOjEuNjE5LCJ0cmFjayI6MzEuNDcxOCwic3BlZWQiOjAuMDEzLCJj
bGltYiI6LTAuMjkwLCJlcHMiOjAuMDEsImVwYyI6MTYuMTl9DQorJEdQWkRBLDA4NTAwMi4wMCwx
OSwwNywyMDE3LDAwLDAwKjYyDQorJEdQR0dBLDA4NTAwMSwzNDU0LjM3MzcsUywxMzgzNi40ODcy
LEUsMiwwMCwsMjUuMDcsTSwsLCowMQ0KKyRHUFJNQywwODUwMDEsQSwzNDU0LjM3MzcsUywxMzgz
Ni40ODcyLEUsMC4wNzM5LDMxLjQ3MiwxOTA3MTcsLCowQg0KKyRHUEdTQSxBLDMsLCwsLCwsLCws
LCwsLCwqMUMNCit7ImNsYXNzIjoiVFBWIiwic3RhdHVzIjoyLCJtb2RlIjozLCJ0aW1lIjoiMjAx
Ny0wNy0xOVQwODo1MDowMS4wMDBaIiwiZXB0IjowLjAwNSwibGF0IjotMzQuOTA2MjI4MTAwLCJs
b24iOjEzOC42MDgxMjA0MDAsImFsdCI6MjUuMDczLCJlcHgiOjAuODEwLCJlcHkiOjAuODEwLCJl
cHYiOjEuNjIwLCJ0cmFjayI6MzEuNDcxOCwic3BlZWQiOjAuMDM4LCJjbGltYiI6LTAuMzE1LCJl
cHMiOjAuMDMsImVwYyI6MTYuMTl9DQorJEdQWkRBLDA4NTAwMi4yMCwxOSwwNywyMDE3LDAwLDAw
KjYwDQorJEdQR0dBLDA4NTAwMiwzNDU0LjM3MzcsUywxMzgzNi40ODcyLEUsMiwwMCwsMjUuMDEs
TSwsLCowNA0KKyRHUFJNQywwODUwMDIsQSwzNDU0LjM3MzcsUywxMzgzNi40ODcyLEUsMC4wMDU4
LDMxLjQ3MiwxOTA3MTcsLCowOA0KKyRHUEdTQSxBLDMsLCwsLCwsLCwsLCwsLCwqMUMNCit7ImNs
YXNzIjoiVFBWIiwic3RhdHVzIjoyLCJtb2RlIjozLCJ0aW1lIjoiMjAxNy0wNy0xOVQwODo1MDow
Mi4yMDBaIiwiZXB0IjowLjAwNSwibGF0IjotMzQuOTA2MjI4NDAwLCJsb24iOjEzOC42MDgxMjA1
MDAsImFsdCI6MjUuMDA4LCJlcHgiOjAuODA4LCJlcHkiOjAuODA4LCJlcHYiOjEuNjE3LCJ0cmFj
ayI6MzEuNDcxOCwic3BlZWQiOjAuMDAzLCJjbGltYiI6LTAuMzI1LCJlcHMiOi0wLjAwLCJlcGMi
OjE2LjE4fQ0KKyRHUFpEQSwwODUwMDIuNDAsMTksMDcsMjAxNywwMCwwMCo2Ng0KKyRHUEdHQSww
ODUwMDIsMzQ1NC4zNzM3LFMsMTM4MzYuNDg3MixFLDIsMDAsLDI0Ljk1LE0sLCwqMDgNCiskR1BS
TUMsMDg1MDAyLEEsMzQ1NC4zNzM3LFMsMTM4MzYuNDg3MixFLDAuMDQyOCwzMS40NzIsMTkwNzE3
LCwqMEINCiskR1BHU0EsQSwzLCwsLCwsLCwsLCwsLCwsKjFDDQoreyJjbGFzcyI6IlRQViIsInN0
YXR1cyI6MiwibW9kZSI6MywidGltZSI6IjIwMTctMDctMTlUMDg6NTA6MDIuNDAwWiIsImVwdCI6
MC4wMDUsImxhdCI6LTM0LjkwNjIyODcwMCwibG9uIjoxMzguNjA4MTIwNTAwLCJhbHQiOjI0Ljk1
MiwiZXB4IjowLjgwMSwiZXB5IjowLjgwMSwiZXB2IjoxLjYwMywidHJhY2siOjMxLjQ3MTgsInNw
ZWVkIjowLjAyMiwiY2xpbWIiOi0wLjI4MCwiZXBzIjowLjAyLCJlcGMiOjE2LjEwfQ0KKyRHUFpE
QSwwODUwMDIuNjAsMTksMDcsMjAxNywwMCwwMCo2NA0KKyRHUEdHQSwwODUwMDIsMzQ1NC4zNzM3
LFMsMTM4MzYuNDg3MixFLDIsMDAsLDI0Ljg5LE0sLCwqMDUNCiskR1BSTUMsMDg1MDAyLEEsMzQ1
NC4zNzM3LFMsMTM4MzYuNDg3MixFLDAuMDIzMywzMS40NzIsMTkwNzE3LCwqMDcNCiskR1BHU0Es
QSwzLCwsLCwsLCwsLCwsLCwsKjFDDQoreyJjbGFzcyI6IlRQViIsInN0YXR1cyI6MiwibW9kZSI6
MywidGltZSI6IjIwMTctMDctMTlUMDg6NTA6MDIuNjAwWiIsImVwdCI6MC4wMDUsImxhdCI6LTM0
LjkwNjIyOTEwMCwibG9uIjoxMzguNjA4MTIwNzAwLCJhbHQiOjI0Ljg5MiwiZXB4IjowLjgwMywi
ZXB5IjowLjgwMywiZXB2IjoxLjYwOCwidHJhY2siOjMxLjQ3MTgsInNwZWVkIjowLjAxMiwiY2xp
bWIiOi0wLjMwMCwiZXBzIjotMC4wMSwiZXBjIjoxNi4wNX0NCiskR1BaREEsMDg1MDAyLjgwLDE5
LDA3LDIwMTcsMDAsMDAqNkENCiskR1BHR0EsMDg1MDAyLDM0NTQuMzczOCxTLDEzODM2LjQ4NzIs
RSwyLDAwLCwyNC44MyxNLCwsKjAwDQorJEdQUk1DLDA4NTAwMixBLDM0NTQuMzczOCxTLDEzODM2
LjQ4NzIsRSwwLjA1NjQsMzEuNDcyLDE5MDcxNywsKjBEDQorJEdQR1NBLEEsMywsLCwsLCwsLCws
LCwsLCoxQw0KK3siY2xhc3MiOiJUUFYiLCJzdGF0dXMiOjIsIm1vZGUiOjMsInRpbWUiOiIyMDE3
LTA3LTE5VDA4OjUwOjAyLjgwMFoiLCJlcHQiOjAuMDA1LCJsYXQiOi0zNC45MDYyMjk0MDAsImxv
biI6MTM4LjYwODEyMDcwMCwiYWx0IjoyNC44MzEsImVweCI6MC44MTIsImVweSI6MC44MTIsImVw
diI6MS42MjUsInRyYWNrIjozMS40NzE4LCJzcGVlZCI6MC4wMjksImNsaW1iIjotMC4zMDUsImVw
cyI6MC4wMywiZXBjIjoxNi4xNn0NCiskR1BaREEsMDg1MDAzLjAwLDE5LDA3LDIwMTcsMDAsMDAq
NjMNCiskR1BHR0EsMDg1MDAyLDM0NTQuMzczOCxTLDEzODM2LjQ4NzMsRSwyLDAwLCwyNC43NixN
LCwsKjBCDQorJEdQUk1DLDA4NTAwMixBLDM0NTQuMzczOCxTLDEzODM2LjQ4NzMsRSwwLjA1MDUs
MzEuNDcyLDE5MDcxNywsKjBCDQorJEdQR1NBLEEsMywsLCwsLCwsLCwsLCwsLCoxQw0KK3siY2xh
c3MiOiJUUFYiLCJzdGF0dXMiOjIsIm1vZGUiOjMsInRpbWUiOiIyMDE3LTA3LTE5VDA4OjUwOjAy
LjAwMFoiLCJlcHQiOjAuMDA1LCJsYXQiOi0zNC45MDYyMjk4MDAsImxvbiI6MTM4LjYwODEyMDkw
MCwiYWx0IjoyNC43NjAsImVweCI6MC44MTAsImVweSI6MC44MTAsImVwdiI6MS42MjIsInRyYWNr
IjozMS40NzE4LCJzcGVlZCI6MC4wMjYsImNsaW1iIjotMC4zNTUsImVwcyI6LTAuMDIsImVwYyI6
MTYuMjN9DQorJEdQWkRBLDA4NTAwMy4yMCwxOSwwNywyMDE3LDAwLDAwKjYxDQorJEdQR0dBLDA4
NTAwMywzNDU0LjM3MzgsUywxMzgzNi40ODczLEUsMiwwMCwsMjQuNzAsTSwsLCowQw0KKyRHUFJN
QywwODUwMDMsQSwzNDU0LjM3MzgsUywxMzgzNi40ODczLEUsMC4wMzUwLDMxLjQ3MiwxOTA3MTcs
LCowQw0KKyRHUEdTQSxBLDMsLCwsLCwsLCwsLCwsLCwqMUMNCit7ImNsYXNzIjoiVFBWIiwic3Rh
dHVzIjoyLCJtb2RlIjozLCJ0aW1lIjoiMjAxNy0wNy0xOVQwODo1MDowMy4yMDBaIiwiZXB0Ijow
LjAwNSwibGF0IjotMzQuOTA2MjMwMjAwLCJsb24iOjEzOC42MDgxMjA5MDAsImFsdCI6MjQuNjk1
LCJlcHgiOjAuODA3LCJlcHkiOjAuODA3LCJlcHYiOjEuNjE2LCJ0cmFjayI6MzEuNDcxOCwic3Bl
ZWQiOjAuMDE4LCJjbGltYiI6LTAuMzI1LCJlcHMiOjAuMDEsImVwYyI6MTYuMTl9DQorJEdQWkRB
LDA4NTAwMy40MCwxOSwwNywyMDE3LDAwLDAwKjY3DQorJEdQR0dBLDA4NTAwMywzNDU0LjM3Mzgs
UywxMzgzNi40ODczLEUsMiwwMCwsMjQuNjIsTSwsLCowRg0KKyRHUFJNQywwODUwMDMsQSwzNDU0
LjM3MzgsUywxMzgzNi40ODczLEUsMC4wMjE0LDMxLjQ3MiwxOTA3MTcsLCowRA0KKyRHUEdTQSxB
LDMsLCwsLCwsLCwsLCwsLCwqMUMNCit7ImNsYXNzIjoiVFBWIiwic3RhdHVzIjoyLCJtb2RlIjoz
LCJ0aW1lIjoiMjAxNy0wNy0xOVQwODo1MDowMy40MDBaIiwiZXB0IjowLjAwNSwibGF0IjotMzQu
OTA2MjMwNTAwLCJsb24iOjEzOC42MDgxMjEwMDAsImFsdCI6MjQuNjE3LCJlcHgiOjAuODA1LCJl
cHkiOjAuODA1LCJlcHYiOjEuNjA5LCJ0cmFjayI6MzEuNDcxOCwic3BlZWQiOjAuMDExLCJjbGlt
YiI6LTAuMzkwLCJlcHMiOjAuMDEsImVwYyI6MTYuMTJ9DQorJEdQWkRBLDA4NTAwMy42MCwxOSww
NywyMDE3LDAwLDAwKjY1DQorJEdQR0dBLDA4NTAwMywzNDU0LjM3MzksUywxMzgzNi40ODczLEUs
MiwwMCwsMjQuNTYsTSwsLCowOQ0KKyRHUFJNQywwODUwMDMsQSwzNDU0LjM3MzksUywxMzgzNi40
ODczLEUsMC4wMjUzLDMxLjQ3MiwxOTA3MTcsLCowRg0KKyRHUEdTQSxBLDMsLCwsLCwsLCwsLCws
LCwqMUMNCit7ImNsYXNzIjoiVFBWIiwic3RhdHVzIjoyLCJtb2RlIjozLCJ0aW1lIjoiMjAxNy0w
Ny0xOVQwODo1MDowMy42MDBaIiwiZXB0IjowLjAwNSwibGF0IjotMzQuOTA2MjMwOTAwLCJsb24i
OjEzOC42MDgxMjEwMDAsImFsdCI6MjQuNTYxLCJlcHgiOjAuNzkxLCJlcHkiOjAuNzkxLCJlcHYi
OjEuNTgyLCJ0cmFjayI6MzEuNDcxOCwic3BlZWQiOjAuMDEzLCJjbGltYiI6LTAuMjgwLCJlcHMi
Oi0wLjAxLCJlcGMiOjE1Ljk1fQ0KKyRHUFpEQSwwODUwMDMuODAsMTksMDcsMjAxNywwMCwwMCo2
Qg0KKyRHUEdHQSwwODUwMDMsMzQ1NC4zNzM5LFMsMTM4MzYuNDg3MyxFLDIsMDAsLDI0LjQ5LE0s
LCwqMDcNCiskR1BSTUMsMDg1MDAzLEEsMzQ1NC4zNzM5LFMsMTM4MzYuNDg3MyxFLDAuMDQwOCwz
MS40NzIsMTkwNzE3LCwqMDcNCiskR1BHU0EsQSwzLCwsLCwsLCwsLCwsLCwsKjFDDQoreyJjbGFz
cyI6IlRQViIsInN0YXR1cyI6MiwibW9kZSI6MywidGltZSI6IjIwMTctMDctMTlUMDg6NTA6MDMu
ODAwWiIsImVwdCI6MC4wMDUsImxhdCI6LTM0LjkwNjIzMTMwMCwibG9uIjoxMzguNjA4MTIwOTAw
LCJhbHQiOjI0LjQ4NiwiZXB4IjowLjc3NiwiZXB5IjowLjc3NiwiZXB2IjoxLjU1MiwidHJhY2si
OjMxLjQ3MTgsInNwZWVkIjowLjAyMSwiY2xpbWIiOi0wLjM3NSwiZXBzIjowLjAyLCJlcGMiOjE1
LjY3fQ0KKyRHUFpEQSwwODUwMDQuMDAsMTksMDcsMjAxNywwMCwwMCo2NA0KKyRHUEdHQSwwODUw
MDMsMzQ1NC4zNzM5LFMsMTM4MzYuNDg3MixFLDIsMDAsLDI0LjM5LE0sLCwqMDENCiskR1BSTUMs
MDg1MDAzLEEsMzQ1NC4zNzM5LFMsMTM4MzYuNDg3MixFLDAuMDIzMywzMS40NzIsMTkwNzE3LCwq
MDgNCiskR1BHU0EsQSwzLCwsLCwsLCwsLCwsLCwsKjFDDQoreyJjbGFzcyI6IlRQViIsInN0YXR1
cyI6MiwibW9kZSI6MywidGltZSI6IjIwMTctMDctMTlUMDg6NTA6MDMuMDAwWiIsImVwdCI6MC4w
MDUsImxhdCI6LTM0LjkwNjIzMTcwMCwibG9uIjoxMzguNjA4MTIwNjAwLCJhbHQiOjI0LjM5MCwi
ZXB4IjowLjc3MSwiZXB5IjowLjc3MSwiZXB2IjoxLjUzOCwidHJhY2siOjMxLjQ3MTgsInNwZWVk
IjowLjAxMiwiY2xpbWIiOi0wLjQ4MCwiZXBzIjotMC4wMCwiZXBjIjoxNS40NX0NCiskR1BaREEs
MDg1MDA0LjIwLDE5LDA3LDIwMTcsMDAsMDAqNjYNCiskR1BHR0EsMDg1MDA0LDM0NTQuMzczOSxT
LDEzODM2LjQ4NzIsRSwyLDAwLCwyNC4zMSxNLCwsKjBFDQorJEdQUk1DLDA4NTAwNCxBLDM0NTQu
MzczOSxTLDEzODM2LjQ4NzIsRSwwLjAzMzAsMzEuNDcyLDE5MDcxNywsKjBEDQorJEdQR1NBLEEs
MywsLCwsLCwsLCwsLCwsLCoxQw0KK3siY2xhc3MiOiJUUFYiLCJzdGF0dXMiOjIsIm1vZGUiOjMs
InRpbWUiOiIyMDE3LTA3LTE5VDA4OjUwOjA0LjIwMFoiLCJlcHQiOjAuMDA1LCJsYXQiOi0zNC45
MDYyMzIyMDAsImxvbiI6MTM4LjYwODEyMDMwMCwiYWx0IjoyNC4zMDksImVweCI6MC43NTksImVw
eSI6MC43NTksImVwdiI6MS41MTYsInRyYWNrIjozMS40NzE4LCJzcGVlZCI6MC4wMTcsImNsaW1i
IjotMC40MDUsImVwcyI6LTAuMDEsImVwYyI6MTUuMjd9DQorJEdQWkRBLDA4NTAwNC40MCwxOSww
NywyMDE3LDAwLDAwKjYwDQorJEdQR0dBLDA4NTAwNCwzNDU0LjM3NDAsUywxMzgzNi40ODcyLEUs
MiwwMCwsMjQuMjMsTSwsLCowMw0KKyRHUFJNQywwODUwMDQsQSwzNDU0LjM3NDAsUywxMzgzNi40
ODcyLEUsMC4wMTk0LDMxLjQ3MiwxOTA3MTcsLCowRg0KKyRHUEdTQSxBLDMsLCwsLCwsLCwsLCws
LCwqMUMNCit7ImNsYXNzIjoiVFBWIiwic3RhdHVzIjoyLCJtb2RlIjozLCJ0aW1lIjoiMjAxNy0w
Ny0xOVQwODo1MDowNC40MDBaIiwiZXB0IjowLjAwNSwibGF0IjotMzQuOTA2MjMyNjAwLCJsb24i
OjEzOC42MDgxMjAwMDAsImFsdCI6MjQuMjI1LCJlcHgiOjAuNzQ1LCJlcHkiOjAuNzQ1LCJlcHYi
OjEuNDg3LCJ0cmFjayI6MzEuNDcxOCwic3BlZWQiOjAuMDEwLCJjbGltYiI6LTAuNDIwLCJlcHMi
Oi0wLjAxLCJlcGMiOjE1LjAxfQ0KKyRHUFpEQSwwODUwMDQuNjAsMTksMDcsMjAxNywwMCwwMCo2
Mg0KKyRHUEdHQSwwODUwMDQsMzQ1NC4zNzQwLFMsMTM4MzYuNDg3MixFLDIsMDAsLDI0LjE1LE0s
LCwqMDYNCiskR1BSTUMsMDg1MDA0LEEsMzQ1NC4zNzQwLFMsMTM4MzYuNDg3MixFLDAuMDUwNSwz
MS40NzIsMTkwNzE3LCwqMDMNCiskR1BHU0EsQSwzLCwsLCwsLCwsLCwsLCwsKjFDDQoreyJjbGFz
cyI6IlRQViIsInN0YXR1cyI6MiwibW9kZSI6MywidGltZSI6IjIwMTctMDctMTlUMDg6NTA6MDQu
NjAwWiIsImVwdCI6MC4wMDUsImxhdCI6LTM0LjkwNjIzMzEwMCwibG9uIjoxMzguNjA4MTE5NjAw
LCJhbHQiOjI0LjE1NCwiZXB4IjowLjcyOSwiZXB5IjowLjcyOSwiZXB2IjoxLjQ1NSwidHJhY2si
OjMxLjQ3MTgsInNwZWVkIjowLjAyNiwiY2xpbWIiOi0wLjM1NSwiZXBzIjowLjAzLCJlcGMiOjE0
LjcxfQ0KKyRHUFpEQSwwODUwMDQuODAsMTksMDcsMjAxNywwMCwwMCo2Qw0KKyRHUEdHQSwwODUw
MDQsMzQ1NC4zNzQwLFMsMTM4MzYuNDg3MixFLDIsMDAsLDI0LjA2LE0sLCwqMDQNCiskR1BSTUMs
MDg1MDA0LEEsMzQ1NC4zNzQwLFMsMTM4MzYuNDg3MixFLDAuMDcwMCwzMS40NzIsMTkwNzE3LCwq
MDQNCiskR1BHU0EsQSwzLCwsLCwsLCwsLCwsLCwsKjFDDQoreyJjbGFzcyI6IlRQViIsInN0YXR1
cyI6MiwibW9kZSI6MywidGltZSI6IjIwMTctMDctMTlUMDg6NTA6MDQuODAwWiIsImVwdCI6MC4w
MDUsImxhdCI6LTM0LjkwNjIzMzYwMCwibG9uIjoxMzguNjA4MTE5MzAwLCJhbHQiOjI0LjA2Mywi
ZXB4IjowLjcxNSwiZXB5IjowLjcxNSwiZXB2IjoxLjQyOCwidHJhY2siOjMxLjQ3MTgsInNwZWVk
IjowLjAzNiwiY2xpbWIiOi0wLjQ1NSwiZXBzIjotMC4wNCwiZXBjIjoxNC40MX0NCiskR1BaREEs
MDg1MDA1LjAwLDE5LDA3LDIwMTcsMDAsMDAqNjUNCiskR1BHR0EsMDg1MDA0LDM0NTQuMzc0MCxT
LDEzODM2LjQ4NzEsRSwyLDAwLCwyMy45OCxNLCwsKjA3DQorJEdQUk1DLDA4NTAwNCxBLDM0NTQu
Mzc0MCxTLDEzODM2LjQ4NzEsRSwwLjA0MDgsMzEuNDcyLDE5MDcxNywsKjBDDQorJEdQR1NBLEEs
MywsLCwsLCwsLCwsLCwsLCoxQw0KK3siY2xhc3MiOiJUUFYiLCJzdGF0dXMiOjIsIm1vZGUiOjMs
InRpbWUiOiIyMDE3LTA3LTE5VDA4OjUwOjA0LjAwMFoiLCJlcHQiOjAuMDA1LCJsYXQiOi0zNC45
MDYyMzM5MDAsImxvbiI6MTM4LjYwODExODkwMCwiYWx0IjoyMy45NzUsImVweCI6MC43MDUsImVw
eSI6MC43MDUsImVwdiI6MS40MDUsInRyYWNrIjozMS40NzE4LCJzcGVlZCI6MC4wMjEsImNsaW1i
IjotMC40NDAsImVwcyI6MC4wMiwiZXBjIjoxNC4xNn0NCiskR1BaREEsMDg1MDA1LjIwLDE5LDA3
LDIwMTcsMDAsMDAqNjcNCiskR1BHR0EsMDg1MDA1LDM0NTQuMzc0MSxTLDEzODM2LjQ4NzEsRSwy
LDAwLCwyMy44OCxNLCwsKjA2DQorJEdQUk1DLDA4NTAwNSxBLDM0NTQuMzc0MSxTLDEzODM2LjQ4
NzEsRSwwLjAxNTYsMzEuNDcyLDE5MDcxNywsKjAyDQorJEdQR1NBLEEsMywsLCwsLCwsLCwsLCws
LCoxQw0KK3siY2xhc3MiOiJUUFYiLCJzdGF0dXMiOjIsIm1vZGUiOjMsInRpbWUiOiIyMDE3LTA3
LTE5VDA4OjUwOjA1LjIwMFoiLCJlcHQiOjAuMDA1LCJsYXQiOi0zNC45MDYyMzQ0MDAsImxvbiI6
MTM4LjYwODExODUwMCwiYWx0IjoyMy44ODQsImVweCI6MC42OTcsImVweSI6MC42OTcsImVwdiI6
MS4zODgsInRyYWNrIjozMS40NzE4LCJzcGVlZCI6MC4wMDgsImNsaW1iIjotMC40NTUsImVwcyI6
MC4wMSwiZXBjIjoxMy45Nn0NCiskR1BaREEsMDg1MDA1LjQwLDE5LDA3LDIwMTcsMDAsMDAqNjEN
CiskR1BHR0EsMDg1MDA1LDM0NTQuMzc0MSxTLDEzODM2LjQ4NzEsRSwyLDAwLCwyMy43NyxNLCws
KjA2DQorJEdQUk1DLDA4NTAwNSxBLDM0NTQuMzc0MSxTLDEzODM2LjQ4NzEsRSwwLjAzMzAsMzEu
NDcyLDE5MDcxNywsKjAwDQorJEdQR1NBLEEsMywsLCwsLCwsLCwsLCwsLCoxQw0KK3siY2xhc3Mi
OiJUUFYiLCJzdGF0dXMiOjIsIm1vZGUiOjMsInRpbWUiOiIyMDE3LTA3LTE5VDA4OjUwOjA1LjQw
MFoiLCJlcHQiOjAuMDA1LCJsYXQiOi0zNC45MDYyMzQ5MDAsImxvbiI6MTM4LjYwODExODEwMCwi
YWx0IjoyMy43NjksImVweCI6MC42OTQsImVweSI6MC42OTQsImVwdiI6MS4zNzksInRyYWNrIjoz
MS40NzE4LCJzcGVlZCI6MC4wMTcsImNsaW1iIjotMC41NzUsImVwcyI6LTAuMDEsImVwYyI6MTMu
ODN9DQotLSAKMi4xMy4wCgo=

--_002_4EE4C24172624C4D8128D445E37EF8AB17857FADcwsvr13cohdawir_--


From MAILER-DAEMON Wed Jul 26 12:41:27 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1daPNG-0003mq-T5
	for mharc-gpsd-dev@gnu.org; Wed, 26 Jul 2017 12:41:26 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52386)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <reinhard.arlt@t-online.de>) id 1daPNE-0003mg-Tt
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 12:41:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <reinhard.arlt@t-online.de>) id 1daPNB-0005XH-OW
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 12:41:24 -0400
Received: from mailout03.t-online.de ([194.25.134.81]:50931)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <reinhard.arlt@t-online.de>)
	id 1daPNB-0005W0-Ga
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 12:41:21 -0400
Received: from fwd23.aul.t-online.de (fwd23.aul.t-online.de [172.20.26.128])
	by mailout03.t-online.de (Postfix) with SMTP id C3D67423E331
	for <gpsd-dev@nongnu.org>; Wed, 26 Jul 2017 18:41:17 +0200 (CEST)
Received: from [192.168.2.120]
	(XRfN3OZCYh2baaRIZN2rsnbyYypzYso1FLdhXEp2U0T93s581zkhxIr1x6ZCo36gC3@[87.147.29.247])
	by fwd23.t-online.de
	with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted)
	esmtp id 1daPN2-1EzPyy0; Wed, 26 Jul 2017 18:41:12 +0200
To: gpsd-dev <gpsd-dev@nongnu.org>
From: Reinhard Arlt <reinhard.arlt@t-online.de>
Message-ID: <3c383a85-827f-aee4-dc89-5fc6a9704b55@t-online.de>
Date: Wed, 26 Jul 2017 18:41:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
	Thunderbird/52.2.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-ID: XRfN3OZCYh2baaRIZN2rsnbyYypzYso1FLdhXEp2U0T93s581zkhxIr1x6ZCo36gC3
X-TOI-MSGID: 208923fb-06f3-4a26-922d-f953650ee1e6
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
	[fuzzy]
X-Received-From: 194.25.134.81
Subject: [gpsd-dev] "scons audit" fails on an ubuntu 16.04 system...
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jul 2017 16:41:26 -0000

Hello,

running "scons audit" fails with

pylint --rcfile=/dev/null --dummy-variables-rgx='^_' 
--msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}" 
--reports=n 
--disable=F0001,C0103,C0111,C1001,C0301,C0302,C0322,C0324,C0323,C0321,C0330,R0201,R0801,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,W0110,W0201,W0121,W0123,W0231,W0232,W0234,W0401,W0403,W0141,W0142,W0603,W0614,W0640,W0621,W1504,E0602,E0611,E1101,E1102,E1103,F0401,I0011 
gps/*.py *.py gpscat gpsfake gpsprof gegps xgps xgpsspeed
Traceback (most recent call last):
   File "/usr/bin/pylint", line 3, in <module>
     run_pylint()
   File "/usr/lib/python2.7/dist-packages/pylint/__init__.py", line 21, 
in run_pylint
     Run(sys.argv[1:])
   File "/usr/lib/python2.7/dist-packages/pylint/lint.py", line 1019, in 
__init__
     args = linter.load_command_line_configuration(args)
   File 
"/usr/lib/python2.7/dist-packages/logilab/common/configuration.py", line 
685, in load_command_line_configuration
     (options, args) = self.cmdline_parser.parse_args(args=args)
   File "/usr/lib/python2.7/optparse.py", line 1400, in parse_args
     stop = self._process_args(largs, rargs, values)
   File "/usr/lib/python2.7/optparse.py", line 1440, in _process_args
     self._process_long_opt(rargs, values)
   File "/usr/lib/python2.7/optparse.py", line 1515, in _process_long_opt
     option.process(opt, value, values, self)
   File "/usr/lib/python2.7/dist-packages/logilab/common/optik_ext.py", 
line 237, in process
     self.action, self.dest, opt, value, values, parser)
   File "/usr/lib/python2.7/optparse.py", line 809, in take_action
     self.callback(self, opt, value, parser, *args, **kwargs)
   File 
"/usr/lib/python2.7/dist-packages/logilab/common/configuration.py", line 
540, in cb_set_provider_option
     self.global_set_option(opt, value)
   File 
"/usr/lib/python2.7/dist-packages/logilab/common/configuration.py", line 
544, in global_set_option
     self._all_options[opt].set_option(opt, value)
   File "/usr/lib/python2.7/dist-packages/pylint/lint.py", line 392, in 
set_option
     meth(_id)
   File "/usr/lib/python2.7/dist-packages/pylint/utils.py", line 276, in 
disable
     msg = self.check_message_id(msgid)
   File "/usr/lib/python2.7/dist-packages/pylint/utils.py", line 341, in 
check_message_id
     raise UnknownMessage('No such message id %s' % msgid)
pylint.utils.UnknownMessage: No such message id C0330
scons: *** [pylint] Error 1
scons: building terminated because of errors.

Is there a quick fix?

Thank you

Reinhard



From MAILER-DAEMON Wed Jul 26 13:49:15 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1daQQt-0004lS-6L
	for mharc-gpsd-dev@gnu.org; Wed, 26 Jul 2017 13:49:15 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60632)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1daQQq-0004gS-IE
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 13:49:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1daQQm-0006uI-Jw
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 13:49:12 -0400
Received: from c.mail.sonic.net ([64.142.111.80]:57124)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1daQQm-0006oK-9y
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 13:49:08 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by c.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v6QHn2Xn008169
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
	for <gpsd-dev@nongnu.org>; Wed, 26 Jul 2017 10:49:02 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v6QHn1SB031621
	for <gpsd-dev@nongnu.org>; Wed, 26 Jul 2017 10:49:02 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v6QHn1jJ031596
	for <gpsd-dev@nongnu.org>; Wed, 26 Jul 2017 10:49:01 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Wed, 26 Jul 2017 10:49:01 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: gpsd-dev <gpsd-dev@nongnu.org>
In-Reply-To: <3c383a85-827f-aee4-dc89-5fc6a9704b55@t-online.de>
Message-ID: <Pine.LNX.4.58L1X.1707261043290.21159@bolt.sonic.net>
References: <3c383a85-827f-aee4-dc89-5fc6a9704b55@t-online.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVZCyxk//oAHGMORKbAJi7BfhDcf+dRhh/0fKuyoRDglw9KwH17TgsxiBDWyEbp4N6zVTdp5rp9CjwcuhxaD8sdy
X-Sonic-ID: C;lCiytSpy5xGcOMGbEi49jA== M;xOXOtSpy5xGcOMGbEi49jA==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.80
Subject: Re: [gpsd-dev] "scons audit" fails on an ubuntu 16.04 system...
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jul 2017 17:49:13 -0000


On Wed, 26 Jul 2017, Reinhard Arlt wrote:

> running "scons audit" fails with
>
> pylint --rcfile=/dev/null --dummy-variables-rgx='^_'
> --msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}"
> --reports=n
> --disable=F0001,C0103,C0111,C1001,C0301,C0302,C0322,C0324,C0323,C0321,C0330,R0201,R0801,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,W0110,W0201,W0121,W0123,W0231,W0232,W0234,W0401,W0403,W0141,W0142,W0603,W0614,W0640,W0621,W1504,E0602,E0611,E1101,E1102,E1103,F0401,I0011
> gps/*.py *.py gpscat gpsfake gpsprof gegps xgps xgpsspeed
> Traceback (most recent call last):
[...]
>    File "/usr/lib/python2.7/dist-packages/pylint/utils.py", line 341, in
> check_message_id
>      raise UnknownMessage('No such message id %s' % msgid)
> pylint.utils.UnknownMessage: No such message id C0330
> scons: *** [pylint] Error 1
> scons: building terminated because of errors.

That's a legitimate message ID AFAIK.  Does this relate to your pylint
version?

It appears that the C0330 test is broken, anyway, making it justifiable to
disable it. :-)

	https://github.com/PyCQA/pylint/issues/741

Fred Wright


From MAILER-DAEMON Wed Jul 26 14:23:14 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1daQxm-0006gR-1K
	for mharc-gpsd-dev@gnu.org; Wed, 26 Jul 2017 14:23:14 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51131)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gem@rellim.com>) id 1daQxk-0006gL-8p
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 14:23:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gem@rellim.com>) id 1daQxj-00037o-7P
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 14:23:12 -0400
Received: from rellim.com ([2001:470:e815::19]:46083 helo=spidey.rellim.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <gem@rellim.com>) id 1daQxi-00031r-Vw
	for gpsd-dev@nongnu.org; Wed, 26 Jul 2017 14:23:11 -0400
Received: from spidey.rellim.com (dave.rellim.com
	[IPv6:2001:470:e815:0:0:0:0:19] (may be forged))
	(authenticated bits=0)
	by spidey.rellim.com (8.15.2/8.15.2) with ESMTPSA id v6QIMqoK022032
	(version=TLSv1.2 cipher=DHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); 
	Wed, 26 Jul 2017 11:22:57 -0700
DKIM-Filter: OpenDKIM Filter v2.10.3 spidey.rellim.com v6QIMqoK022032
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=rellim.com; s=kong;
	t=1501093377; bh=Mzhdase3JX7UiyNRzCnAvcCWgg6rRB829oSw5TjZ7Jo=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=nNnOfF2Ejug+jYaiLqGAVnnfzNNFZQ/nP5oSGcEpbXORQZqnIQ6m9/oKEKMSDxtwV
	IQiWvKd9K/0ruDdII/PiJ8J3MqLpYxNiM+IJ5y18x9/lzxensddHGoYYp73DPtAO6a
	IKsRL9MWrRCRCGSnoqqtUipmkKSmMihnvbXy9bAE=
Date: Wed, 26 Jul 2017 11:22:51 -0700
From: "Gary E. Miller" <gem@rellim.com>
To: Reinhard Arlt <reinhard.arlt@t-online.de>
Cc: gpsd-dev <gpsd-dev@nongnu.org>
Message-ID: <20170726112251.5bfb6e34@spidey.rellim.com>
In-Reply-To: <3c383a85-827f-aee4-dc89-5fc6a9704b55@t-online.de>
References: <3c383a85-827f-aee4-dc89-5fc6a9704b55@t-online.de>
Organization: Rellim
X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	boundary="Sig_/jiLQWatT33JFtrCWZ_3m_Ej";
	protocol="application/pgp-signature"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2
	(spidey.rellim.com [IPv6:2001:470:e815:0:0:0:0:19]);
	Wed, 26 Jul 2017 11:22:57 -0700 (PDT)
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 2001:470:e815::19
Subject: Re: [gpsd-dev] "scons audit" fails on an ubuntu 16.04 system...
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jul 2017 18:23:13 -0000

--Sig_/jiLQWatT33JFtrCWZ_3m_Ej
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Yo Reinhard!

On Wed, 26 Jul 2017 18:41:50 +0200
Reinhard Arlt <reinhard.arlt@t-online.de> wrote:

> running "scons audit" fails with

What are you rinning it on?  Mostly works for me, Gentoo Stable and Unstabl=
e:

Gentoo Untable:

# pylint --version
No config file found, using default configuration
pylint 1.7.2,=20
astroid 1.5.3
Python 2.7.13 (default, Feb 19 2017, 13:53:18)=20
[GCC 5.4.0]

Gentoo Stable:

 # pylint --version
No config file found, using default configuration
pylint 1.6.5,=20
astroid 1.4.8
Python 2.7.12 (default, May 31 2017, 01:53:50)=20
[GCC 6.3.0]
S
t does your "pylint --version" say?

>    File "/usr/lib/python2.7/dist-packages/pylint/utils.py", line 341,
> in check_message_id
>      raise UnknownMessage('No such message id %s' % msgid)
> pylint.utils.UnknownMessage: No such message id C0330

That sure looks like a problem with your pylint.

> Is there a quick fix?

Dunno yet.

On my gentoo Unstable I got many warnings, and this result:

    Your code has been rated at 9.90/10

So I have some patching to do, people let bad python code slip into the
git repo...

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	gem@rellim.com  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can=E2=80=99t measure it, you can=E2=80=99t improve it." - Lord=
 Kelvin

--Sig_/jiLQWatT33JFtrCWZ_3m_Ej
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENqCjEoytAEAuFCk8DQ7ZSUHRedgFAll43fsACgkQDQ7ZSUHR
edjyEggAo0ebGxBXzM8JOHot9DxaXNOgYolQCPnkz4jFWvQaQtqN2COcPaNLVdfM
8MILn/r388CMJmd7mrbbdH7Cs/rhObqHSilXFoKkQcFcZYWUXwWalzJwR/gqDr0K
sj5Aw/8tbr+y6FEB5k4mtwhkfipW8sndJr5T1kSFAphegVZzr7FjJBlUL+EDXzAE
A1v3g4QAEquDJc8G+Xt1O0XxNd3ZJYIwSK+fBlu8IqYq79XcOGH7tJChSQS7l2kr
J8FJhb9uL+DoRH3sjHzWtKdu3K5jFHN7PTe0Zkj1ivIxlVYcSfWJ9rKMbP/J1/dM
WBnB/pm8YdN/NkV5wRKnX8uoJE9rfg==
=uCDt
-----END PGP SIGNATURE-----

--Sig_/jiLQWatT33JFtrCWZ_3m_Ej--


