From MAILER-DAEMON Wed Aug 02 02:01:00 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dcmiK-00076g-1U
	for mharc-gpsd-dev@gnu.org; Wed, 02 Aug 2017 02:01:00 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34508)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dcmiG-00076W-VZ
	for gpsd-dev@nongnu.org; Wed, 02 Aug 2017 02:00:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dcmiD-0006ER-Sl
	for gpsd-dev@nongnu.org; Wed, 02 Aug 2017 02:00:57 -0400
Received: from c.mail.sonic.net ([64.142.111.80]:45646)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dcmiD-00066b-J4
	for gpsd-dev@nongnu.org; Wed, 02 Aug 2017 02:00:53 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by c.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v7260hZj027917
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
	for <gpsd-dev@nongnu.org>; Tue, 1 Aug 2017 23:00:43 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v7260hfG023086
	for <gpsd-dev@nongnu.org>; Tue, 1 Aug 2017 23:00:43 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v7260gVk023083
	for <gpsd-dev@nongnu.org>; Tue, 1 Aug 2017 23:00:43 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Tue, 1 Aug 2017 23:00:42 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: GPSD Developers List <gpsd-dev@nongnu.org>
In-Reply-To: <4EE4C24172624C4D8128D445E37EF8AB17857FAD@cw-svr13.cohda.wireless>
Message-ID: <Pine.LNX.4.58L1X.1708012218350.10832@bolt.sonic.net>
References: <20170719121131.5169-1-clark.li@cohdawireless.com>
	<4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707192157040.1086@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857965@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707211535210.10401@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857FAD@cw-svr13.cohda.wireless>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVbtPUqjrGsU8NHycpOPr83/AwKwyUbNAJp2i9ue4AhUP/QfdMGZaxunHW9SBlYAaav4Q33aKvdhtDMgIyqGq4cn
X-Sonic-ID: C;XHVZ60d35xGbQcGbEi49jA== M;pNt460d35xGbQcGbEi49jA==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.80
Subject: Re: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Aug 2017 06:00:58 -0000


On Tue, 25 Jul 2017, Clark Li wrote:

> >Previously, I hadn't bothered to try to apply your patch after seeing
> >the issue I reported, but I've now tried it and it (either version)
> >fails to apply.  There seems to be some inconsistency between the state
> >of driver_ubx.c and what the patch expects.  Ordinarily this might be
> >due to the patch's being based on a different revision of the file, but
> >in this case the blob ID in the patch matches the state of the file, so
> >I'm puzzled.  Did you have uncommitted changes to the file at the time
> >you ran git format-patch?  I don't know what the effect of that is, but
> >it's my best guess as to why the patch is bad.
> That last patch was not based on the very latest in master branch. But I
> guess forwarding the output of git-send-email from gmail to outlook
> should also be blamed... I am attaching the original git-format-patch
> output this time, hopefully this one can be applied without conflicts.

It's not essential (though it's desirable) to base the patch on a
reasonably recent master, and that wasn't the problem in this case.  In
fact, as I mentioned, the blob IDs in the diff matched, meaning that the
files you were actually modifying matched, even though changes had been
made elsewhere.

I managed to figure out the main problem, which is that "git am" doesn't
seem to like patches sent as attachments, but screws up in very confusing
ways if you try.  Basically, it seems to go through the right motions, but
gets confused about line numbering.  The solution was to use "git apply"
rather than "git am", but that has the problem that it doesn't create the
commit message automatically, and I had to do that by hand.

What usually works well for emailed patches is to send the patch to the
list directly with "git send-email".  This results in exactly what "git
am" expects.  If you want to email the patch to yourself to test it,
that's fine, but to send it for real, resend it with "git send-email"
rather than forwarding a received version that may have been mangled by an
email client.

The one case I know of where this has trouble is where there are very
long lines, which sometimes happens in regression-test data.  In
principle, binary data could cause trouble as well, but it looks like "git
format-patch" is smart enough to make a binary diff in that case.

> >Except that if you look closely at the diff, you'll see that the only
> >actual change to that file is the introduction of some spurious line
> >breaks.  It makes sense that the output is effectively unchanged, but
> >it doesn't make sense that some spurious newlines appeared.  Did you
> >perhaps obtain the "updated" version via copy-n-paste rather than from
> >"regress-driver -b"?
> The chk file was updated using "regress-driver -b" but again this might be due to the email forwarding...

I suspected something else due to the extra line breaks being in just the
"after" data and not the "before", suggesting that data was getting
garbled on the way *into* the diff rather than in the email.  But whatever
that problem was seems to have gone away now.

> >It's also odd that only that one case was affected by whatever you did.
> >Did you only run the one test case, rather than all of them (typically via "scons check")?
> scons check was run to check all the regression tests. ublox-aek-4t.log might be the only regression that contains NAV-NAV-SOL.

The reason I suspected that is because only that one case had the
differences, which seemd not email-related as noted above.  But I now see
that there was a real, albeit subtle, difference masked by the newline
issue, namely a one-digit change in one number.  Presumably that's an
expected change.

I want to look at this some more before pushing it, but at least I have a
valid commit now.

Fred Wright


From MAILER-DAEMON Thu Aug 03 16:45:29 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1ddMzp-00076d-DV
	for mharc-gpsd-dev@gnu.org; Thu, 03 Aug 2017 16:45:29 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39102)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1ddMzn-00075I-51
	for gpsd-dev@nongnu.org; Thu, 03 Aug 2017 16:45:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1ddMzk-000208-95
	for gpsd-dev@nongnu.org; Thu, 03 Aug 2017 16:45:27 -0400
Received: from d.mail.sonic.net ([64.142.111.50]:46428)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1ddMzj-0001mq-Uc
	for gpsd-dev@nongnu.org; Thu, 03 Aug 2017 16:45:24 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v73KjFd9007532
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
	for <gpsd-dev@nongnu.org>; Thu, 3 Aug 2017 13:45:15 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v73KjFNC032527
	for <gpsd-dev@nongnu.org>; Thu, 3 Aug 2017 13:45:15 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v73KjFp9032524
	for <gpsd-dev@nongnu.org>; Thu, 3 Aug 2017 13:45:15 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Thu, 3 Aug 2017 13:45:15 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: GPSD Developers List <gpsd-dev@nongnu.org>
In-Reply-To: <Pine.LNX.4.58L1X.1708012218350.10832@bolt.sonic.net>
Message-ID: <Pine.LNX.4.58L1X.1708031326070.26673@bolt.sonic.net>
References: <20170719121131.5169-1-clark.li@cohdawireless.com>
	<4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707192157040.1086@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857965@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707211535210.10401@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857FAD@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1708012218350.10832@bolt.sonic.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVZliF8wENY6VB4ciB2wh1bxfnj+UGaAzOqiXg6+qVqy8z8C2ckQkYMfcshQ2h3APxGLNOEYwnhZ9OGO4JxbQfgf
X-Sonic-ID: C;QvRqp4x45xGInvsKk0eh0A== M;FNCKp4x45xGInvsKk0eh0A==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.50
Subject: Re: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2017 20:45:28 -0000


On Tue, 1 Aug 2017, Fred Wright wrote:

> I want to look at this some more before pushing it, but at least I have a
> valid commit now.

Ok, I've looked at it now, and have two substantive corrections plus a
bunch of whitespace corrections.

1) The change to the big case statement accidentally deleted the "break"
line at line 615, casuing UBX_NAV_PVT to fall through to UBX_NAV_POSUTM.
Since the latter does nothing but emit a log message, it didn't affect the
test results, but would have been nticeable with logging turned on.

2) I don't agree with the Pythagorean scale factor in mapping hacc to epx
and epy (line 239).  The correct mapping depends upon circumstances, and
in particular, for a circular error zone, one would have epx = epy = hacc.
Although epx and/or epy may *sometimes* be smaller than hacc, there's not
enough information to determine this, so the conservative thing to do is
assume the circular case.  Also, some forum posts suggest that hacc tends
to be overoptimistic, so scaling it down is underconservative.  In
addition, if I *were* using a scale factor, I'd define it as a parameter
rather than burying a magic constant in the body of the code, and wouldn't
be so stingy with the precision.

Whitespace-wise, the general issue is that this file uses tabs as much as
possible, while your additions used all spaces.  The overarching rule on
style is consistency.  There were also two preexisting lines gratuitously
changed to spaces without any real edits.

I've pushed a set of three commits to a "clarkli" branch on my GitHub,
whose diffs you can see here:

	https://github.com/fhgwright/gpsd/compare/master...clarkli

The first commit is yours as is.  The second makes two substantive changes
as noted above (including updating the test results to reflect the epx/epy
change).  The third is whitespace-only changes, including breaking up one
long line.

If you agree, I'll squash this into one corrected commit and push it.

Fred Wright


From MAILER-DAEMON Sun Aug 06 19:54:09 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1deVN3-0007a3-Nl
	for mharc-gpsd-dev@gnu.org; Sun, 06 Aug 2017 19:54:09 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54775)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Clark.Li@cohdawireless.com>) id 1deVN1-0007Zr-Bo
	for gpsd-dev@nongnu.org; Sun, 06 Aug 2017 19:54:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Clark.Li@cohdawireless.com>) id 1deVMy-0001S8-9K
	for gpsd-dev@nongnu.org; Sun, 06 Aug 2017 19:54:07 -0400
Received: from mail1.bemta8.messagelabs.com ([216.82.243.195]:26832)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <Clark.Li@cohdawireless.com>)
	id 1deVMy-0001Ql-4F
	for gpsd-dev@nongnu.org; Sun, 06 Aug 2017 19:54:04 -0400
Received: from [216.82.242.36] by server-3.bemta-8.messagelabs.com id
	14/75-02004-81CA7895; Sun, 06 Aug 2017 23:54:00 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIIsWRWlGSWpSXmKPExsVScuVmmq7EmvZ
	Ig75OLYvHa+Ms1jy/w+rA5LF7x212jyfXNjMFMEWxZuYl5VcksGbcu3SIreCwSMXv2z/ZGhgn
	CXYxcnEICfQxSnycvJSxi5GTg01AW+LQpKfMILaIgI9EY+8UVhBbWMBYYsHnfhaIuInE4d2nW
	CHsJIn2DTOB6jk4WARUJC689gExeQX8JO5fzYcY/5RZ4ubc+2CtnAJOEkuntTOB2IwCshKTph
	4Gs5kFxCVuPZkPZksICEgs2XOeGcIWlXj5+B8rhK0kcbr5ISNEvY7Egt2f2CBsbYllC1+D1fM
	KCEqcnPmEZQKj0CwkY2chaZmFpGUWkpYFjCyrGNWLU4vKUot0TfSSijLTM0pyEzNzdA0NLPRy
	U4uLE9NTcxKTivWS83M3MQKDngEIdjDe6XM+xCjJwaQkyhu/oi1SiC8pP6UyI7E4I76oNCe1+
	BCjDAeHkgSv9+r2SCHBotT01Iq0zBxg/MGkJTh4lER4M0HSvMUFibnFmekQqVOMilLivM4gCQ
	GQREZpHlwbLOYvMcpKCfMyAh0ixFOQWpSbWYIq/4pRnINRSZj31CqgKTyZeSVw018BLWYCWvw
	msRVkcUkiQkqqgTEwJkPObfoey5QfvWaLJ95eY+heqGgqkLJX5kDiBuWj7yOtE5j7Nzns33ln
	oZo3v05cZlL7/C+23k8uvhc/fUX7+W+b9/Mfrs+oYDwzO+jB1KqtCzj3FmpvmHBzqqHfW4MZU
	+pXPFs669XjjzFVJrX+D10ufg3fp3ldi1enjufXkaUzf2d/uZKrxFKckWioxVxUnAgAT1QUS/
	QCAAA=
X-Env-Sender: Clark.Li@cohdawireless.com
X-Msg-Ref: server-3.tower-94.messagelabs.com!1502063637!182580095!1
X-Originating-IP: [116.212.217.102]
X-StarScan-Received: 
X-StarScan-Version: 9.4.45; banners=cohdawireless.com,-,-
X-VirusChecked: Checked
Received: (qmail 85249 invoked from network); 6 Aug 2017 23:54:00 -0000
Received: from unknown (HELO webmail.cohdawireless.com) (116.212.217.102)
	by server-3.tower-94.messagelabs.com with DHE-RSA-AES256-SHA encrypted
	SMTP; 6 Aug 2017 23:54:00 -0000
Received: from CW-SVR13.cohda.wireless ([::1]) by cw-svr13.cohda.wireless
	([::1]) with mapi id 14.03.0319.002; Mon, 7 Aug 2017 09:23:26 +0930
From: Clark Li <Clark.Li@cohdawireless.com>
To: Fred Wright <fw@fwright.net>, GPSD Developers List <gpsd-dev@nongnu.org>
Thread-Topic: [gpsd-dev] [PATCH] Support UBX NAV-PVT
Thread-Index: AQHTAIg6LMFyO5ecyEyXU9/Cd+OjcqJbD4IggAB6CoCAAObLYIAB3JOAgAL8nNCADr+AAIACiXmAgAWKUvA=
Date: Sun, 6 Aug 2017 23:53:25 +0000
Message-ID: <4EE4C24172624C4D8128D445E37EF8AB17862967@cw-svr13.cohda.wireless>
References: <20170719121131.5169-1-clark.li@cohdawireless.com>
	<4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707192157040.1086@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857965@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707211535210.10401@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857FAD@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1708012218350.10832@bolt.sonic.net>
	<Pine.LNX.4.58L1X.1708031326070.26673@bolt.sonic.net>
In-Reply-To: <Pine.LNX.4.58L1X.1708031326070.26673@bolt.sonic.net>
Accept-Language: en-US, en-AU
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [192.168.52.132]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]
X-Received-From: 216.82.243.195
Subject: Re: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Aug 2017 23:54:08 -0000

Hi Fred,

I agree with the changes. Thanks for looking into this!

Cheers,
Clark
-----Original Message-----
From: gpsd-dev [mailto:gpsd-dev-bounces+clark.li=3Dcohdawireless.com@nongn=
u.org] On Behalf Of Fred Wright
Sent: Friday, August 04, 2017 6:15 AM
To: GPSD Developers List
Subject: Re: [gpsd-dev] [PATCH] Support UBX NAV-PVT


On Tue, 1 Aug 2017, Fred Wright wrote:

> I want to look at this some more before pushing it, but at least I=20
> have a valid commit now.

Ok, I've looked at it now, and have two substantive corrections plus a bun=
ch of whitespace corrections.

1) The change to the big case statement accidentally deleted the "break"
line at line 615, casuing UBX_NAV_PVT to fall through to UBX_NAV_POSUTM.
Since the latter does nothing but emit a log message, it didn't affect the=
 test results, but would have been nticeable with logging turned on.

2) I don't agree with the Pythagorean scale factor in mapping hacc to epx =
and epy (line 239).  The correct mapping depends upon circumstances, and i=
n particular, for a circular error zone, one would have epx =3D epy =3D ha=
cc.
Although epx and/or epy may *sometimes* be smaller than hacc, there's not =
enough information to determine this, so the conservative thing to do is a=
ssume the circular case.  Also, some forum posts suggest that hacc tends t=
o be overoptimistic, so scaling it down is underconservative.  In addition=
, if I *were* using a scale factor, I'd define it as a parameter rather th=
an burying a magic constant in the body of the code, and wouldn't be so st=
ingy with the precision.

Whitespace-wise, the general issue is that this file uses tabs as much as =
possible, while your additions used all spaces.  The overarching rule on s=
tyle is consistency.  There were also two preexisting lines gratuitously c=
hanged to spaces without any real edits.

I've pushed a set of three commits to a "clarkli" branch on my GitHub, who=
se diffs you can see here:

=09https://github.com/fhgwright/gpsd/compare/master...clarkli

The first commit is yours as is.  The second makes two substantive changes=
 as noted above (including updating the test results to reflect the epx/ep=
y change).  The third is whitespace-only changes, including breaking up on=
e long line.

If you agree, I'll squash this into one corrected commit and push it.

Fred Wright


______________________________________________________________________
This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com ___________=
___________________________________________________________

This communication may contain confidential or copyright information. If y=
ou are not an intended recipient, you must not keep, forward, copy, use, s=
ave or rely on this communication, and any such action is unauthorized and=
 prohibited. If you have received this communication in error, please repl=
y to this email to notify the sender of its incorrect delivery and then de=
lete both the original message and your reply.


From MAILER-DAEMON Mon Aug 14 21:15:33 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dhQSC-00082M-UF
	for mharc-gpsd-dev@gnu.org; Mon, 14 Aug 2017 21:15:32 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56455)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dhQSA-0007zn-GF
	for gpsd-dev@nongnu.org; Mon, 14 Aug 2017 21:15:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dhQS7-0008Tx-Bu
	for gpsd-dev@nongnu.org; Mon, 14 Aug 2017 21:15:30 -0400
Received: from d.mail.sonic.net ([64.142.111.50]:43264)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dhQS7-0008Sh-2e
	for gpsd-dev@nongnu.org; Mon, 14 Aug 2017 21:15:27 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v7F1FMnJ006251
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
	for <gpsd-dev@nongnu.org>; Mon, 14 Aug 2017 18:15:22 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v7F1FMx2013337
	for <gpsd-dev@nongnu.org>; Mon, 14 Aug 2017 18:15:22 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v7F1FMFm013315
	for <gpsd-dev@nongnu.org>; Mon, 14 Aug 2017 18:15:22 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Mon, 14 Aug 2017 18:15:22 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: GPSD Developers List <gpsd-dev@nongnu.org>
In-Reply-To: <4EE4C24172624C4D8128D445E37EF8AB17862967@cw-svr13.cohda.wireless>
Message-ID: <Pine.LNX.4.58L1X.1708141813100.10777@bolt.sonic.net>
References: <20170719121131.5169-1-clark.li@cohdawireless.com>
	<4EE4C24172624C4D8128D445E37EF8AB17857798@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707192157040.1086@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857965@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1707211535210.10401@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17857FAD@cw-svr13.cohda.wireless>
	<Pine.LNX.4.58L1X.1708012218350.10832@bolt.sonic.net>
	<Pine.LNX.4.58L1X.1708031326070.26673@bolt.sonic.net>
	<4EE4C24172624C4D8128D445E37EF8AB17862967@cw-svr13.cohda.wireless>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVYPJoVxcpwDt+pxoGI/mQxy/Upcr1Sncxoyk3aJgS8btj3To/MDG0to7JuoXkllm0BK3ESsG0DQUUjNT2ywf9vg
X-Sonic-ID: C;OhHbNVeB5xG3XvsKk0eh0A== M;yH0INleB5xG3XvsKk0eh0A==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.50
Subject: Re: [gpsd-dev] [PATCH] Support UBX NAV-PVT
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Aug 2017 01:15:31 -0000


On Sun, 6 Aug 2017, Clark Li wrote:

> I agree with the changes. Thanks for looking into this!

Sorry for the delay in posting, but I merged this about a week ago.  The
Travis build failed in one of the three test cases, but this appears to be
a Travis issue, not a GPSD issue.

Fred Wright


From MAILER-DAEMON Tue Aug 29 02:49:14 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dmaKn-0005iH-R1
	for mharc-gpsd-dev@gnu.org; Tue, 29 Aug 2017 02:49:13 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43159)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zach@zbnet.org>) id 1dmV60-0002ai-VS
	for gpsd-dev@nongnu.org; Mon, 28 Aug 2017 21:13:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zach@zbnet.org>) id 1dmV5x-0005Sr-Oa
	for gpsd-dev@nongnu.org; Mon, 28 Aug 2017 21:13:36 -0400
Received: from zbnet.org ([75.147.178.13]:14441 helo=zbn-ex-01.hq.zbnet.org)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <zach@zbnet.org>) id 1dmV5x-0005Rz-Ih
	for gpsd-dev@nongnu.org; Mon, 28 Aug 2017 21:13:33 -0400
Received: from ZBN-EX-01.hq.zbnet.org (192.168.12.4) by ZBN-EX-01.hq.zbnet.org
	(192.168.12.4) with Microsoft SMTP Server (TLS) id 15.0.1130.7;
	Mon, 28 Aug 2017 17:52:43 -0700
Received: from ZBN-EX-01.hq.zbnet.org ([fe80::3143:6638:9b0a:f900]) by
	ZBN-EX-01.hq.zbnet.org ([fe80::3143:6638:9b0a:f900%5]) with mapi id
	15.00.1130.005; Mon, 28 Aug 2017 17:52:43 -0700
From: Zachary Bourdeau <zach@zbnet.org>
To: "gpsd-dev@nongnu.org" <gpsd-dev@nongnu.org>
Thread-Topic: 'internal error - too many satellites'
Thread-Index: AQHTIGEf4VJ2T/x/TEalQp0+QsZ7uQ==
Date: Tue, 29 Aug 2017 00:52:43 +0000
Message-ID: <1503967963278.74794@zbnet.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [192.168.13.51]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy]
X-Received-From: 75.147.178.13
X-Mailman-Approved-At: Tue, 29 Aug 2017 02:49:12 -0400
Subject: [gpsd-dev] 'internal error - too many satellites'
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Aug 2017 01:13:38 -0000

GPSD Devs,

Is there reason why GPSD cannot accept more than 10 satellites at a time th=
rough the GPGSV sentence? It looks like that is whats happening. I am not s=
ure if this is a bug or by design. I can turn off the GPGSV sentence if tha=
t would help, but i'm curious to see what feedback you folks have on this i=
ssue before I do.
?

(92) $GPGSV,3,1,11,10,76.6,281.3,30.9,15,20.4,46.4,30.9,18,66.8,63.3,24.4,2=
1,43.6,122.3,34.3*70\x0d\x0a
(89) $GPGSV,3,2,11,24,17.6,87.2,31.8,27,50.6,255.9,30.4,32,30.9,189.8,26.3,=
08,33.8,302.3,*5B\x0d\x0a
gpsmon:ERROR: internal error - too many satellites [72]!
(52) $GPGSV,3,3,11,14,13.4,192.7,,16,,,,20,1.4,74.5,*71\x0d\x0a

-Zach



From MAILER-DAEMON Tue Aug 29 04:01:30 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dmbSk-0006c2-O7
	for mharc-gpsd-dev@gnu.org; Tue, 29 Aug 2017 04:01:30 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59467)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dmbSe-0006ZC-7w
	for gpsd-dev@nongnu.org; Tue, 29 Aug 2017 04:01:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dmbSa-0002EG-En
	for gpsd-dev@nongnu.org; Tue, 29 Aug 2017 04:01:24 -0400
Received: from d.mail.sonic.net ([64.142.111.50]:55950)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dmbSa-0002D2-6a
	for gpsd-dev@nongnu.org; Tue, 29 Aug 2017 04:01:20 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v7T819xg016125
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
	for <gpsd-dev@nongnu.org>; Tue, 29 Aug 2017 01:01:09 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v7T819nL021146
	for <gpsd-dev@nongnu.org>; Tue, 29 Aug 2017 01:01:09 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v7T8190h021136
	for <gpsd-dev@nongnu.org>; Tue, 29 Aug 2017 01:01:09 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Tue, 29 Aug 2017 01:01:09 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: "gpsd-dev@nongnu.org" <gpsd-dev@nongnu.org>
In-Reply-To: <1503967963278.74794@zbnet.org>
Message-ID: <Pine.LNX.4.58L1X.1708290051130.18289@bolt.sonic.net>
References: <1503967963278.74794@zbnet.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVai9y9PlLORML7jPrcFnJC8YWs0q6M7rMOIuKnFbznia040j1PAxG0RugCVZMSgQ5tYm/QVA7EQHp93GECaxpT9
X-Sonic-ID: C;fpCkN5CM5xGVIvsKk0eh0A== M;YEvLN5CM5xGVIvsKk0eh0A==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.50
Subject: Re: [gpsd-dev] 'internal error - too many satellites'
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Aug 2017 08:01:30 -0000


On Tue, 29 Aug 2017, Zachary Bourdeau wrote:

> Is there reason why GPSD cannot accept more than 10 satellites at a time
> through the GPGSV sentence? It looks like that is whats happening. I am
> not sure if this is a bug or by design. I can turn off the GPGSV
> sentence if that would help, but i'm curious to see what feedback you
> folks have on this issue before I do. ?
>
> (92) $GPGSV,3,1,11,10,76.6,281.3,30.9,15,20.4,46.4,30.9,18,66.8,63.3,24.4,21,43.6,122.3,34.3*70\x0d\x0a
> (89) $GPGSV,3,2,11,24,17.6,87.2,31.8,27,50.6,255.9,30.4,32,30.9,189.8,26.3,08,33.8,302.3,*5B\x0d\x0a
> gpsmon:ERROR: internal error - too many satellites [72]!
> (52) $GPGSV,3,3,11,14,13.4,192.7,,16,,,,20,1.4,74.5,*71\x0d\x0a

There's certainly no 10-satellite limit.  I believe the "72" in the error
message is the real limit.  Also, I just ran gpsmon against a multi-system
GNSS receiver here with up to 20 satellites in view, 12 GPS (GPGSV) and 8
GLONASS (GLGSV), without any issues beyond the 12-satellite limit of the
view pane (which simply truncates the list).

First of all, are you using the latest source code?  There's no point in
trying to chase a bug that was already fixed.

Secondly, can you capture some data with gpscat that reproduces the
problem?

The "\x0d\x0a" in the above is fishy, since gpsmon doesn't normally report
the CR-LF that way.  Is the data being run through something that's
"decoding" the CR-LF into printable characters?  Even if it is, the
internal error isn't appropriate, but it might prevent correct results.

Fred Wright


From MAILER-DAEMON Thu Aug 31 23:14:14 2017
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1dncPN-0008KG-B5
	for mharc-gpsd-dev@gnu.org; Thu, 31 Aug 2017 23:14:14 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53208)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dncPK-0008Ji-UJ
	for gpsd-dev@nongnu.org; Thu, 31 Aug 2017 23:14:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fw@fwright.net>) id 1dncPH-0005eI-Qh
	for gpsd-dev@nongnu.org; Thu, 31 Aug 2017 23:14:10 -0400
Received: from d.mail.sonic.net ([64.142.111.50]:39538)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <fw@fwright.net>) id 1dncPH-0005bo-HV
	for gpsd-dev@nongnu.org; Thu, 31 Aug 2017 23:14:07 -0400
Received: from newshell.sonic.net (bolt.sonic.net [208.201.242.19])
	by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPS id v813Dwlh025552
	(version=TLSv1 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT)
	for <gpsd-dev@nongnu.org>; Thu, 31 Aug 2017 20:13:58 -0700
Received: from bolt.sonic.net (localhost.localdomain [127.0.0.1])
	by newshell.sonic.net (8.13.6/8.12.1) with ESMTP id v813Dw87020816
	for <gpsd-dev@nongnu.org>; Thu, 31 Aug 2017 20:13:58 -0700
Received: from localhost (fw@localhost)
	by bolt.sonic.net (8.13.6/8.12.1/Submit) with ESMTP id v813Dw7Q020813
	for <gpsd-dev@nongnu.org>; Thu, 31 Aug 2017 20:13:58 -0700
X-Authentication-Warning: bolt.sonic.net: fw owned process doing -bs
Date: Thu, 31 Aug 2017 20:13:58 -0700 (PDT)
From: Fred Wright <fw@fwright.net>
X-X-Sender: fw@bolt.sonic.net
To: GPSD Developers List <gpsd-dev@nongnu.org>
Message-ID: <Pine.LNX.4.58L1X.1708312008390.18284@bolt.sonic.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Sonic-CAuth: UmFuZG9tSVZuPDx38B9z/kWU33ZWuHRMLB1Xq7iOOgc2EcKFwMi0aRfC7bA0TBrKt63HzjAFWCppLqLjPD1i1ZzCmjzX6reJ
X-Sonic-ID: C;OFFNmMOO5xGpmvsKk0eh0A== M;6OpimMOO5xGpmvsKk0eh0A==
X-Sonic-Spam-Details: -1.5/5.0 by cerberusd
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-Received-From: 64.142.111.50
Subject: [gpsd-dev] GPS 'sees' the Great American Eclipse
X-BeenThere: gpsd-dev@nongnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <gpsd-dev.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/gpsd-dev/>
List-Post: <mailto:gpsd-dev@nongnu.org>
List-Help: <mailto:gpsd-dev-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/gpsd-dev>,
	<mailto:gpsd-dev-request@nongnu.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Sep 2017 03:14:11 -0000


Some folks here might find this interesting:

http://gpsworld.com/gps-sees-the-great-american-eclipse/

Fred Wright


