Re: [PATCH] fix coreutils-5.0.91 rejecting "[ toto -eq tata ]" like form
From:
Jim Meyering
Subject:
Re: [PATCH] fix coreutils-5.0.91 rejecting "[ toto -eq tata ]" like forms
Date:
Wed, 07 Jan 2004 23:43:52 +0100
Thierry Vignaud <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> Since I am unable to reproduce those failures,
>> I suspect that some of the implied `-4mdk' changes
>> introduced the problem.
>
> it seems sg break it but i failled to see any hunk that can affect [:
[ and test both use test.c. `[' is built from lbracket.c.
Did you try reverting this change?
...
> diff -rubBd /home/tv/rpm/BUILD/coreutils-5.0.91/src/test.c ../src/test.c
> --- /home/tv/rpm/BUILD/coreutils-5.0.91/src/test.c 2004-01-07
> 22:24:02.000000000 +0100
> +++ ../src/test.c 2003-07-26 14:19:55.000000000 +0200
> @@ -1091,7 +1091,7 @@
>
> argv = margv;
>
> - if (margv[0][strlen(margv[0])-1] == '[')
> + if (LBRACKET)
> {
> /* Recognize --help or --version, but only when invoked in the
> "[" form, and when the last argument is not "]". POSIX
...