|
| From: | Pádraig Brady |
| Subject: | Re: [PATCH] maint: use a wildcard to include all syntax check exceptions in dist |
| Date: | Mon, 8 Jun 2009 13:11:29 +0100 |
| User-agent: | Thunderbird 2.0.0.6 (X11/20071008) |
Jim Meyering wrote:
> Pádraig Brady wrote:
>
> ...
>> + test "$$(($(VC_LIST) | sed -n '/^.x-sc_/p'; \
>> + sed -n "/^$$sce =[ ]*\\\\$$/,/[^\]$$/p" \
>> + $(srcdir)/Makefile.am \
>> + | sed "s/^ *//;/^$$sce =/d" \
>> + | tr -s '\012\\' ' ' | fmt -1 \
>> + ) | sort | uniq -u)" \
>> + && { echo "Makefile.am: $$sce mismatch" >&2; exit 1; } \
>> + || :;
>
> Quoting infelicity.
> Notice how the second sed expression is not quoted at all.
Well it wouldn't work if it wasn't quoted. I did test :)
echo "$(echo "two spaces")" seems to be fine.
But you're right in that it could be confusing.
> How about this instead?
Sure I'll use a `make` variable instead.
I'll also change the first '$((' to '$( (' so
that readers aren't confused with arithmetic expansion.
I'll also add a comment on this make target.
thanks,
Pádraig.
| [Prev in Thread] | Current Thread | [Next in Thread] |