|
| From: | Pádraig Brady |
| Subject: | Re: [PATCH] chcon, chmod, chgrp, chown, du: do not ignore fts_close failure |
| Date: | Tue, 1 Sep 2009 11:25:10 +0100 |
| User-agent: | Thunderbird 2.0.0.6 (X11/20071008) |
Jim Meyering wrote:
> The following patch will be required when coreutils
> next updates from gnulib, with gnulib's just-added warn_unused_result
> attribute on fts_close.
>
> It eliminates a slight risk that fts_close would fail and these
> applications would ignore that failure and exit successfully.
Do we want to fail silently though (however unlikely)?
I.E. do these need: error (0, errno, _("fts_close failed"));
cheers,
Pádraig.
| [Prev in Thread] | Current Thread | [Next in Thread] |