Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to PƔdraig Brady on 9/25/2009 4:11 AM:
>
> You need to chmod a+x ln/hard-to-sym
Oops. Yeah. Serves me right for testing on cygwin 1.5 (cygwin 1.7 fixed
that bug, so that a script now has to be executable to run it).
> Also " path " in your -P description in coreutils.texi
> is causing doc/Makefile.am::check-texinfo to fail
s/path/file name/ fixed that.
>
> Also your stdbuf cleanup needs the following.
> (I was wary about passing NULL into access())
I should have used xreadlink, not areadlink, for ENOMEM. But
file_name_concat guarantees non-NULL results (it calls xalloc-die on
ENOMEM, and there are no other failure paths), so there was no risk of
calling access(NULL). Hmm, should we be using euidaccess instead of access?
Also, Jim, should we add a maintainer check that ensures we always use
[ax]readlink rather than raw readlink?
I've folded in your suggestions. I pushed ln and copy.c changes to
master, but left stdbuf changes only on my own repo.
git pull git://repo.or.cz/coreutils/ericb.git master
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkq8wz0ACgkQ84KuGfSFAYC8mQCgvvTDvYEyo9a+wS3Y9zE9Z+ZE
R7cAniLaXbQl92mCCw8K6Z2o3D36QUm+
=a82d
-----END PGP SIGNATURE-----