Re: [PATCH] tests: don't silently skip the sort-version tests
From:
Jim Meyering
Subject:
Re: [PATCH] tests: don't silently skip the sort-version tests
Date:
Wed, 13 Jan 2010 15:46:54 +0100
Eric Blake wrote:
> According to Jim Meyering on 1/13/2010 2:26 AM:
>> The behavior of bash via /bin/sh (same for zsh and dash, though without
>> the warning) is probably POSIX-conforming, but this example illustrates
>> why it would be better to emulate openBSD's /bin/sh.
>>
>> * tests/misc/sort-version: Don't use <<- and indented here-doc contents.
>> s/<<-/<</ and unindent the here-document contents. Otherwise,
>> bash would ignore the indented delimiter and use EOF, thus silently
>> skipping this test.
>
> Actually, this was a regression caused by your conversion from space to
> tab indentation. POSIX states: "If the redirection symbol is "<<-" , all
s/space to tab/tab to space/
> leading <tab> characters shall be stripped from input lines and the line
> containing the trailing delimiter."
Ha! Thanks for pointing that out.
This is the first snag I've encountered with that conversion.
I'm glad I'm the one who fixed it.