[PATCH v2] who --mesg now checks the group of TTY devices
From:
Kamil Dudka
Subject:
[PATCH v2] who --mesg now checks the group of TTY devices
Date:
Fri, 22 Jan 2010 15:33:41 +0100
User-agent:
KMail/1.9.10
Hi Jim,
attached is the second version of the patch.
On Thursday 21 of January 2010 13:04:27 Jim Meyering wrote:
> >> It would be helpful to say how to determine the appropriate group name.
> >> Something like "ls -lg /dev/tty" or
> >> $ stat --format %G /dev/tty
> >> tty
> >
> > Do you mean directly in the help string or somewhere else?
>
> I was thinking of a comment in the .m4 file,
> but now that you mention the help string, perhaps that's better.
> You choose.
Well, let it be a shell comment then.
> You're right that we go to extremes to avoid in-functions #ifdefs.
> In-function #ifdefs are evil, but so is code duplication.
> It's a trade-off. Since this function is so small,
> and the fraction of duplicated code would have been so high,
> the in-function #ifdef is clearly the lesser evil.
It makes sense to me.
Kamil