On 05/12/2010 07:53 AM, Eric Blake wrote:
> On 05/11/2010 05:39 PM, PƔdraig Brady wrote:
>> The attached patch gives warnings about questionable
>> option combinations. For example:
>>
>> $ sort --debug -rb -k1,1n /dev/null
>> ! options `-b' are ignored
>> ! option `-r' only applies to last-resort comparison
>
> That looks awkward, both when compared to the GCS convention of listing
> the program name rather than !, and in respect to plurality:
>
> sort: option `-b' is ignored
> sort: option `-r' only applies to last-resort comparison
Or, to put it more concretely,
> + fprintf (stderr, _("! options `-%s' are ignored\n"), opts);
> + free (opts);
> + ugkey.reverse = ugkey_reverse;
> + }
> + if (!stable && ugkey.reverse)
> + fprintf (stderr,
> + _("! option `-r' only applies to last-resort comparison\n"));
Why are we using fprintf(stderr) instead of error()?
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc Description: OpenPGP digital signature