bug#12350: Composites identified as primes in factor.c (when HAVE_GMP)
From:
Torbjorn Granlund
Subject:
bug#12350: Composites identified as primes in factor.c (when HAVE_GMP)
Date:
Tue, 04 Sep 2012 19:58:20 +0200
User-agent:
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (berkeley-unix)
Jim Meyering <address@hidden> writes:
Jim Meyering wrote:
> Torbjorn Granlund wrote:
>> The very old factoring code cut from an now obsolete version GMP does
>> not pass proper arguments to the mpz_probab_prime_p function. It ask
>> for 3 Miller-Rabin tests only, which is not sufficient.
>
> Hi Torbjorn
>
> Thank you for the patch and explanation.
> I've converted that into the commit below in your name.
> Please proofread it and let me know if you'd like to change anything.
> I tweaked the patch to change MR_REPS from a #define to an enum
> and to add the comment just preceding.
>
> I'll add NEWS and tests separately.
...
> From: Torbjorn Granlund <address@hidden>
> Date: Tue, 4 Sep 2012 16:22:47 +0200
> Subject: [PATCH] factor: don't ever declare composites to be prime
Torbjƶrn, I've just noticed that I misspelled your name above.
Did you? Well, you misspell recognise too, but then again, most people
on the other side of the pond misspell lots of English words. :-)
--
Torbjƶrn