bug#18062: [PATCH] chroot: always change to / if not changing credential
From:
Bernhard Voelker
Subject:
bug#18062: [PATCH] chroot: always change to / if not changing credentials
Date:
Sun, 20 Jul 2014 17:30:08 +0200
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
On 07/20/2014 04:46 PM, Andreas Schwab wrote:
> Bernhard Voelker <address@hidden> writes:
>> This effectively reverts the idea behind v8.22-94-g99960ee:
>
> This should be ripped out completely, chroot is not su.
Well, --userspec is a GNU extension - a very useful one IMO.
And why should "chroot /" invoke chroot(2) when it's a noop,
or even worse, on some systems depends on using an
administrative account?
>> Why do you think the change is needed?
>
>https://build.opensuse.org/package/live_build_log/home:AndreasSchwab/hdf/13.1/x86_64
Your local patch [1] looks different - it also moves the chdir(1)
down to after the if-body.
[1]
https://build.opensuse.org/package/view_file/home:AndreasSchwab/coreutils/coreutils-chroot.patch?expand=1
Why's that?
Have a nice day,
Berny