bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified
From:
Pádraig Brady
Subject:
bug#19681: [PATCH] sync: use syncfs(2) if any argument is specified
Date:
Tue, 27 Jan 2015 14:58:44 +0000
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
On 27/01/15 10:48, Giuseppe Scrivano wrote:
> Pádraig Brady <address@hidden> writes:
>
>> thanks!
>> Pádraig.
>
> Thanks for the review, I've amended the changes you suggested:
There were a few problems:
- Compile failure without HAVE_SYNCFS (defined)
- Various errors() used errno where undefined
- A file that failed to sync was not identified
- File descriptors were leaked on failure to sync
- The command would block if presented with a fifo
- Write only files ere not supported
- Various references to "paths" rather than "files"
- The info docs for --file-system were a bit terse
- No tests
I've fixed up those issues in the attached,
which I'll push soon.
thanks,
Pádraig.