bug#21760: timeout: Feature Request: --verbose ==> output if timeout
From:
Pádraig Brady
Subject:
bug#21760: timeout: Feature Request: --verbose ==> output if timeout
Date:
Thu, 23 Nov 2017 17:48:18 -0800
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
On 23/11/17 15:38, Jim Meyering wrote:
> On Thu, Nov 23, 2017 at 2:35 PM, Pádraig Brady <address@hidden> wrote:
> ...
>>> So I'm leaning towards supporting --verbose which would output something
>>> like:
>>>
>>> timeout: aborting command 'blah' with signal SIGTERM
>>> timeout: aborting command 'blah' with signal SIGKILL
>
> + error (0, 0, _("aborting command %s with signal %s"),
> + quote (command), signame);
>
> I like it, though maybe print "sending signal %s to command %s" ?
> Sometimes (as above), the first attempt doesn't affect the process,
> much less send SIGABRT, which one might infer from the use of "abort".
>
> Also wording related, "the signal sent upon timeout" appears both in
> code and in doc. I'd s/the/any/, since there can be more than one.
>
Pushed with those improvements.
thanks for the review,
Pádraig