[ 
https://issues.apache.org/jira/browse/GROOVY-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18144694#comment-18144694
 ] 

ASF GitHub Bot commented on GROOVY-8113:
----------------------------------------

daniellansun commented on PR #3109:
URL: https://github.com/apache/groovy/pull/3109#issuecomment-6870962921

   Thanks, Jochen. I have followed both of your suggestions in f123a672245.
   
   The generated-name flag is now set on the `GroovyCodeSource` when that 
source is created, for the anonymous evaluate and parse paths. After 
compilation, `doParseClass` records the name on the `InnerLoader` only when the 
flag is set and the compiled main class's simple name matches the name derived 
from the source. The ThreadLocal is gone, and so are `noteGeneratedScriptName` 
and `clearGeneratedScriptName` on `GroovyShell` and `GroovyClassLoader`. What 
remains public is `GroovyCodeSource.setNameGenerated` and `isNameGenerated`.
   
   The `parallelLockMap` tests, together with the forked JVM and `--add-opens` 
setup they needed, have been replaced by a parent loader that records 
`loadClass` calls, in the same style as GROOVY-9236. For a generated script the 
parent is not asked for that class, or for its MetaClass, BeanInfo, or 
Customizer companions.
   
   I also corrected `GroovySocketServer.getCodeSource` so that a Windows drive 
path is opened as a file rather than parsed as a URI. A missing path of that 
form now fails with `Unable to get script from:`, not `Unable to get script 
from URI:`.
   
   If you would like any of this taken further, I would be glad to follow up.
   




> Groovy script/template engine produce memory leak 
> --------------------------------------------------
>
>                 Key: GROOVY-8113
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8113
>             Project: Groovy
>          Issue Type: Bug
>          Components: groovy-templates, GroovyScriptEngine
>    Affects Versions: 2.4.8
>         Environment: Groovy 2.4.8, Oracle Java JDK 8u121
>            Reporter: Artyom Kravchenko
>            Priority: Critical
>         Attachments: merged_path.png, object_explorer.png
>
>
> There is a simple way to produce OutOfMemoryException if  run infinite 
> numbers of groovy scripts or evaluate groovy templates.
> Simple test to reproduce a memory leak(run groovy script and make template 
> inside the script):
> set max heap size: -Xmx7m 
> {code:java}
> import javax.script.*;
> import java.util.HashMap;
> import java.util.Map;
> public class OutOfMemoryTest {
>     private static String TEMPLATE = "Dear ${fullName} please go away at 
> ${time}";
>     private static String SCRIPT = "def run(args) {\n" +
>             "def bindings = ['fullName' : 'Ali Baba', 'time' : new Date()]\n" 
> +
>             "println 
> args.templateEngine.createTemplate(args.template).make(bindings).toString()\n"
>  +
>             "}";
>     public static void main(String... args) {
> //        
> GroovySystem.getMetaClassRegistry().getMetaClassCreationHandler().setDisableCustomMetaClassLookup(true);
>         while(true) {
>             ScriptEngineManager engineManager = new ScriptEngineManager();
>             ScriptEngine engine = engineManager.getEngineByName("groovy");
>             try {
>                 engine.eval(SCRIPT);
>             } catch (ScriptException e) {
>                 throw new RuntimeException(e);
>             }
>             groovy.text.SimpleTemplateEngine templateEngine = new 
> groovy.text.SimpleTemplateEngine();
>             Invocable inv = (Invocable) engine;
>             Map<String, Object> params = new HashMap<>();
>             params.put("template", TEMPLATE);
>             params.put("templateEngine", templateEngine);
>             Object[] runArgs = { params };
>             try {
>                 inv.invokeFunction("run", runArgs);
>             } catch (ScriptException | NoSuchMethodException e) {
>                 e.printStackTrace();
>             }
>         }
>     }
> }
> {code}
> The main cause of issue is Java class loader. Two instances: 
> sun.misc.Launcher.AppClassLoader and  sun.misc.Launcher.ExtClassLoader 
> (parent for first one), each of them has a strong reference: 
> {code:java}
> ConcurrentHashMap<String, Object> parallelLockMap
> {code}
> It collects all loaded classes (and never releases their) for application 
> including newly created script/template classes.
> The main reason of introduction of this reference described here:  
> https://blogs.oracle.com/dholmes/entry/parallel_classloading_revisited_fully_concurrent
> For each iteration of my test I see that  parallelLockMap grows with 6 new 
> entries:
> {code:java}
> groovy.runtime.metaclass.Script94MetaClass
> Script94BeanInfo
> Script94Customizer
> groovy.runtime.metaclass.SimpleTemplateScript94MetaClass
> SimpleTemplateScript94BeanInfo
> SimpleTemplateScript94Customizer
> {code}
> See memory snapshots(attached): objects_explorer, merged_path.
> I have found a partial solution of the issue, if I add this code  line to my 
> test:
> {code:java}
>   
> GroovySystem.getMetaClassRegistry().getMetaClassCreationHandler().setDisableCustomMetaClassLookup(true);
> {code}
> I see that classes like:
> {code:java}
> groovy.runtime.metaclass.Script94MetaClass
> groovy.runtime.metaclass.SimpleTemplateScript94MetaClass
> {code}
> goes away (groovy engine don't ask ClassLoader to find this classes on class 
> path therefore such classes are not collected by  ClassLoader) but classes 
> like   
> {code:java}
> Script94BeanInfo
> Script94Customizer
> SimpleTemplateScript94BeanInfo
> SimpleTemplateScript94Customizer
> {code}
> still has affect on memory.
> Dear developers, could you please point me any advice/workarounds for this 
> issue. It will be fine to get rig this issue in future releases. 



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to