[
https://issues.apache.org/jira/browse/GROOVY-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18145262#comment-18145262
] ASF GitHub Bot commented on GROOVY-11492: ----------------------------------------- codecov-commenter commented on PR #3054: URL: https://github.com/apache/groovy/pull/3054#issuecomment-6897648819 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/3054?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `94.33962%` with `3 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.5036%. Comparing base ([`a8e491b`](https://app.codecov.io/gh/apache/groovy/commit/a8e491b6f87281be7614493559e80bf524234b22?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`add5261`](https://app.codecov.io/gh/apache/groovy/commit/add52613f067d8d5b64e1637f3d04419aac5dcfc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3054?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/3054?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | 94.3396% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/3054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/3054?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #3054 +/- ## ================================================== + Coverage 74.4991% 74.5036% +0.0045% - Complexity 44952 44961 +9 ================================================== Files 1703 1703 Lines 152332 152359 +27 Branches 29187 29194 +7 ================================================== + Hits 113486 113513 +27 + Misses 28416 28413 -3 - Partials 10430 10433 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/3054?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/3054?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `87.2421% <94.3396%> (+0.0154%)` | :arrow_up: | ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/3054/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Java compatibility: array initializers without "new Type[]" > ----------------------------------------------------------- > > Key: GROOVY-11492 > URL: https://issues.apache.org/jira/browse/GROOVY-11492 > Project: Groovy > Issue Type: Improvement > Components: parser-antlr4 > Reporter: Eric Milles > Assignee: Eric Milles > Priority: Major > Labels: arrays > > There are a few cases where bare array initializers are not yet supported: > # {{int[][] array = \{ \{1,2\}, \{3,4\} \};}} > # {{@Target(\{ ElementType.FIELD, ElementType.METHOD \})}} > # {code:groovy}@interface A { > String[] strings() default {} > } > {code} > These were implemented as part of [1] but the PR was closed. It may be worth > looking back over what was done and re-implementing one or more of these > cases. It was noted that {{Closure[] array = \{\};}} is one of the edge > cases that leads to ambiguity. > [1] https://github.com/apache/groovy/pull/691 -- This message was sent by Atlassian Jira (v10.3.26#10030026)
