[
https://issues.apache.org/jira/browse/GROOVY-12552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18145914#comment-18145914
]
ASF GitHub Bot commented on GROOVY-12552:
-----------------------------------------
jdaugherty commented on PR #3081:
URL: https://github.com/apache/groovy/pull/3081#issuecomment-6929726971
Thanks Paul, and for the bisect. I reproduced both tables: with 4.0.33
compiled together, `base.name = 'x'` calls `Impl.setName` but
`setName`/`getName` call `Named`; with this PR, `h(i.getName())` picks
`h(String)` and, for a `Holder<Number>` with an `Integer value` property,
`n(hi.getValue())` picks `n(Integer)`.
78abaf5c76 adds:
- A Groovy 7 entry in `COMPATIBILITY.md` with the three points: the
assignment form calling the class's setter again (a regression since 5.0.0 from
GROOVY-11381), the explicit calls preferring the class's accessor, and the
narrower inferred type and overload where the interface declares a wider type.
- `testAccessorOfPropertyNarrowerThanInterfaceMethod` in `Groovy12552`,
asserting the overloads chosen for `i.getName()` and `i.name`, and for the
`Holder<Number>` case, and that `i.getName().toUpperCase()` type checks.
Without the fix it fails to compile.
I've corrected the PR description and GROOVY-12552, and added 4.0.33 and
6.0.0 to its affected versions.
6.0.x only sounds right, so I've dropped the 5.1.x request from the
description. Thanks for opening GROOVY-12760.
> STC: property access calls an interface's accessor instead of the property's
> own when the property's class is in the same compilation unit
> ------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-12552
> URL: https://issues.apache.org/jira/browse/GROOVY-12552
> Project: Groovy
> Issue Type: Bug
> Components: Static Type Checker
> Affects Versions: 4.0.33, 5.1.3, 6.0.0
> Reporter: James Daugherty
> Priority: Major
>
> When an interface declares the setter and getter of a property that a class
> implements as a Groovy property, static compilation calls the interface's
> methods with {{invokeinterface}} when the class is compiled together with the
> caller, and the class's own accessors with {{invokevirtual}} when the class
> is already compiled. The behaviour at run time is the same, but the same
> source compiles to a different class file depending on what else is compiled.
> Groovy 4.0.33 calls the class's setter for {{base.name = 'x'}} in both cases,
> but, compiled together, the interface's methods for the explicit {{setName}}
> and {{getName}} calls; the assignment form changed in 5.0.0 with GROOVY-11381.
> {code:groovy}
> interface Named {
> void setName(String name)
> String getName()
> }
> abstract class Base implements Named {
> String name
> }
> class Impl extends Base {}
> @groovy.transform.CompileStatic
> class Svc {
> String rename() {
> Base base = new Impl()
> base.name = 'x' // invokeinterface Named.setName when Base is in
> the unit, invokevirtual Impl.setName when it is compiled
> base.setName('y')
> base.getName()
> }
> }
> {code}
> Reproduced with 5.1.3 and master. A reproducer with a groovyc script and an
> incremental Gradle build:
> https://github.com/jdaugherty/groovy-property-accessor-interface-method
> *Cause*
> A property of a class in the compilation unit does not have its accessors yet
> when static type checking runs. {{StaticTypeCheckingVisitor.findMethod}} adds
> a synthetic accessor for the property when every method found is abstract
> (GROOVY-10922), but after the interface's method.
> {{StaticTypeCheckingSupport.removeCovariantsAndInterfaceEquivalents}} only
> drops an interface method that comes after the method of a class implementing
> it, so both stay. The receiver-distance tie-break in {{chooseBestMethods}}
> then ranks an interface implemented by the superclass at 1 and the superclass
> itself at 4, so the interface method is chosen whenever the receiver's
> inferred type is a subclass of the property's class ({{Impl}} here); with the
> receiver exactly {{Base}} the accessor is chosen already. A compiled class
> lists its real accessor first, and the interface method is dropped.
> *Proposed fix*
> Add the synthetic accessor first, where a compiled class has its accessor, so
> that it is preferred over the interface method the same way.
> Found while making incremental builds of a Grails application produce the
> same classes as a full build; see also GROOVY-12550 and GROOVY-12544.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)