[ 
https://issues.apache.org/jira/browse/GROOVY-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18147085#comment-18147085
 ] 

ASF GitHub Bot commented on GROOVY-12519:
-----------------------------------------

codeconsole commented on PR #3045:
URL: https://github.com/apache/groovy/pull/3045#issuecomment-7000830709

   Thanks for the re-review. The GROOVY-12519 entry is back in COMPATIBILITY.md 
in 003a967bcc, after merging master in (984527e94e) so it sits on the current 
end of the file. It follows the GROOVY-12521 layout, with a "Who is affected" 
paragraph. While writing it I found that the `@CompileStatic` closure and 
lambda fix covers any static method of the superclass called through `super`, 
not only a hidden one: `super.sm()` from a closure failed with 
`IncompatibleClassChangeError` even when the class doesn't declare `sm()`. The 
entry says so, and f9c39c9005 adds `testSuperDotStaticMethodInClosure` for it, 
which fails under `@CompileStatic` without the change. I checked the "another 
overload with `null`" wording against the code without the fix: `super.sm()` 
there called `Base.sm(String)` with `null`.




> super.sm() and super.sp fail for static members of the superclass (dynamic 
> Groovy, and in a closure under SC)
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: GROOVY-12519
>                 URL: https://issues.apache.org/jira/browse/GROOVY-12519
>             Project: Groovy
>          Issue Type: Bug
>          Components: groovy-runtime, Static compilation
>    Affects Versions: 6.0.0
>            Reporter: Scott Murphy Heiberg
>            Priority: Major
>
> A static method or static property of the superclass reached through 
> {{super}} fails in dynamic Groovy:
> {code:groovy}
> class Base {
>     static String sm() { 'sm:base' }
>     static String sp = 'sp:base'
> }
> class Dyn extends Base {
>     static String sm() { 'sm:dyn' }
>     static String sp = 'sp:dyn'
>     String m() { super.sm() }
>     String p() { super.sp }
> }
> new Dyn().m() // MissingMethodException: No signature of method: sm for 
> class: Base
> new Dyn().p() // MissingPropertyException: No such property: sp for class: Dyn
> {code}
> The same happens inside a closure. javac accepts the equivalent Java and 
> returns {{sm:base}} and {{sp:base}}. Under {{@CompileStatic}} both work in 
> the class body and {{super.sp}} works in a closure, but {{super.sm()}} in a 
> closure fails with {{IncompatibleClassChangeError: Expecting non-static 
> method 'java.lang.String Base.sm()'}}, because the {{super$}} helper method 
> calls the static method with {{invokespecial}}.
> In dynamic Groovy the super call is resolved through the {{super$}} helper 
> methods of the class, which are not generated for static methods. Seen in 
> 4.0.33, 5.0.8 and master.
> Expected: {{super.sm()}} and {{super.sp}} call the superclass's static method 
> and read its static property, in every mode, in the class body and in 
> closures and lambdas.
> PR: https://github.com/apache/groovy/pull/3045



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to