daniellansun commented on PR #3259: URL: https://github.com/apache/groovy/pull/3259#issuecomment-7054942250
Hi Jochen, Thank you for taking another look, and thanks again for the earlier approval. I understand the concern about the size, and I wanted to explain what changed after that approval. There were only two follow-ups. First, I squashed the related commits into three thematic ones, one for each pull request: #3155, #3167, and this one. That rewrite does not add new feature work; it only tidies the history of the same changes. Second, I added unit tests to raise the execution coverage of the new code. The pull request still looks large because it remains stacked on #3155 and #3167; the unique work for this change is in the last commit. I would be very glad to hear any further suggestions you may have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
