Repository navigation
Return early on invalid_client OAuth exception. - #2721
Merged
Merged
Conversation
cory-miller
approved these changes
Jul 27, 2023
ashb
pushed a commit
to ashb/runner
that referenced
this pull request
Jul 28, 2023
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are getting
invalid_clienterror on OAuth token exchange, we can safely assume the registration has been deleted.In this case, we can exit instead of try to test the token exchange one more time.
I left the old code still there just in case I miss some edge case that actually do need an extra test.