Repository navigation
GROOVY-12709: stop following field initializers that refer back to ea… - #3239
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3239 +/- ##
==================================================
+ Coverage 74.1763% 74.1795% +0.0032%
- Complexity 43806 43809 +3
==================================================
Files 1692 1692
Lines 149758 149761 +3
Branches 28417 28418 +1
==================================================
+ Hits 111085 111092 +7
- Misses 28465 28466 +1
+ Partials 10208 10203 -5
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
paulk-asert
force-pushed
the
groovy12709
branch
from
November 6, 2026 03:47
470468b to
b789dbd
Compare
…ch other CheckingVisitor.findConstExp followed field initializers with no record of the fields already visited, so fields whose initializers formed a cycle (static String A = B; static String B = A) made RegexChecker and FormatStringChecker overflow the stack. Track the variables followed during a lookup and treat a repeat as having no constant value.
paulk-asert
force-pushed
the
groovy12709
branch
from
November 6, 2026 04:12
b789dbd to
2f11baf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ch other
CheckingVisitor.findConstExp followed field initializers with no record of the fields already visited, so fields whose initializers formed a cycle (static String A = B; static String B = A) made RegexChecker and FormatStringChecker overflow the stack. Track the variables followed during a lookup and treat a repeat as having no constant value.