"Save configuration" is changed to "Abort" after switching language #3330

Activity

1. correctmost commented on Apr 3, 2025

   

   correctmost

   on Apr 3, 2025

   Contributor

   More actions

   There's a mix-up because the menu items all have the same __config__ key:
   

   archinstall/archinstall/lib/global_menu.py

   Lines 194 to 207 in f0159e1

   	MenuItem(
   	text=str(_('Save configuration')),
   	action=lambda x: self._safe_config(),
   	key='__config__'
   	),
   	MenuItem(
   	text=str(_('Install')),
   	preview_action=self._prev_install_invalid_config,
   	key='__config__'
   	),
   	MenuItem(
   	text=str(_('Abort')),
   	action=lambda x: exit(1),
   	key='__config__'

   The keys are assumed to be unique here:
   

   archinstall/archinstall/lib/global_menu.py

   Lines 265 to 274 in f0159e1

   	def _upate_lang_text(self) -> None:
   	"""
   	The options for the global menu are generated with a static text;
   	each entry of the menu needs to be updated with the new translation
   	"""
   	new_options = self._get_menu_options()
   	for o in new_options:
   	if o.key is not None:
   	self._item_group.find_by_key(o.key).text = o.text
2. svartkanin

   added a commit that references this issue on Apr 7, 2025

   Fix archlinux#3330

   This issue will close once commit 96ceda2 is merged into the 'master' branch.

   96ceda2
3. Torxed

   closed this as completedin #3360on Apr 8, 2025
4. Torxed

   closed this as completedin bae0e29on Apr 8, 2025
5. pull

   added a commit that references this issue on Apr 8, 2025

   Fix archlinux#3330 (archlinux#3360)

   ...

   This issue will close once commit bae0e29 is merged into the 'master' branch.

   bae0e29