Remove Snapshots subvolume from default BTRFS layout so it's compatible with both Snapper and Timeshift #3363

describe the request

Not quite a bug report, nor quite a feature request, but just a suggestion to eliminate two lines in the script that would make the default subvolume arrangement in BTRFS compatible with both Snapper and Timeshift.

Just delete these two lines:

• archinstall/archinstall/lib/interactions/disk_conf.py

  Line 431 in da29b31

  SubvolumeModification(Path('@.snapshots'), Path('/.snapshots'))

• archinstall/examples/disk_layouts-sample.json

  Line 19 in da29b31

  "@.snapshots": "/.snapshots",

The logic is as follows:

Both Snapper and Timeshift create their own location for BTRFS snapshots, and while Timeshift just ignores any existing snapshots subvolume, snapper forces you to delete the existing subvolume (which while not complicated is confusing if you are not used to it and can potentially break your boot).

By eliminating the pre-existing snapshots subvolume you fix the Snapper issue without affecting Timeshift and those that wish to make their own custom Snapshots layout can still do it with perhaps one less step too.

Thank you!