Skip to content

replace GTK theme package for Budgie build with an active one - #3327

Merged
Torxed merged 2 commits into
archlinux:masterfrom
EK-92:fix-budgie-build
Apr 2, 2025
Merged

Torxed merged 2 commits into
archlinux:masterfrom
EK-92:fix-budgie-build

Conversation

@EK-92

@EK-92 EK-92 commented Apr 2, 2025 •

Copy link
Copy Markdown
Contributor
  • This fix issue:

error: target not found: arc-gtk-theme

image

PR Description:

Ran into an issue with a fresh ISO trying to get Arch Budgie on my machine. A quick search let to a conclusion that the theme package seized to exist, and is only now maintained as a fork on AUR. Materia is but one option of many available, can be a different one as default, just something within extra repository, adding a list of currently available below the diff.

@override
	def packages(self) -> list[str]:
		return [
			"arc-gtk-theme", => "materia-gtk-theme",
			"budgie",
			"mate-terminal",
			"nemo",
extra/deepin-gtk-theme 2020.06.10-2 (300.6 KiB 3.5 MiB) [deepin] 
    Deepin GTK Theme
extra/adw-gtk-theme 5.6-1 (101.8 KiB 1.8 MiB) 
    Unofficial GTK 3 port of the libadwaita theme
extra/lxde-icon-theme 0.5.2-1 (4.4 MiB 4.4 MiB) [lxde lxde-gtk3] 
    LXDE default icon theme based on nuoveXT2
extra/adapta-gtk-theme 3.95.0.11-3 (696.4 KiB 17.2 MiB) 
    An adaptive Gtk+ theme based on Material Design Guidelines
extra/materia-gtk-theme 20210322-3 (339.0 KiB 6.0 MiB) 
    A Material Design theme for GNOME/GTK+ based desktop environments
extra/orchis-theme 2024_11_03-4 (330.2 KiB 9.5 MiB) 
    A Material Design theme for GNOME/GTK based desktop environments
extra/pop-gtk-theme 5.5.1.r7.25ea85d9-1 (551.1 KiB 3.3 MiB) 
    System76 Pop GTK+ Theme
extra/breeze-gtk 6.3.3-1 (192.4 KiB 1.2 MiB) [plasma]
    Breeze widget theme for GTK 2 and 3
extra/gtk-theme-elementary 8.2.0-1 (83.2 KiB 10.8 MiB) [pantheon] 
    elementary GTK theme

Tests and Checks

  • I have tested the code!

@EK-92
EK-92 requested a review from Torxed as a code owner April 2, 2025 01:38
@EK-92 EK-92 changed the title replace GTK theme package with an active one replace GTK theme package for Budgie build with an active one Apr 2, 2025

@Torxed Torxed left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, we should add this to the PKGBUILD as a dependencie as well. Mind updating the PR? :)

@EK-92
EK-92 requested a review from grazzolini as a code owner April 2, 2025 06:13
@EK-92

EK-92 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor Author

Added to PKGBUILD as requested, in optdepends.
But now I'm doubtful whether there's a need for it at all since budgie-desktop pulls gnome-themes-standard as a dependency so it's more like a good-to-have rather than an actual requirement (unless I'm wrong of course).
An alternative fix would be just not using any theme that isn't explicitly requested by user in custom packages, and relying on gnome themes, unless it doesn't work well with Budgie?

@Torxed

Torxed commented Apr 2, 2025

Copy link
Copy Markdown
Member

The reason I want it in the PKGBUILD is to create a hard link for packages. So that if someone changes meta or group packages, then we can be notified. Currently all this doesn't work as I would hope, but it's something and allowes us to not rely on group or meta packages.

@Torxed
Torxed merged commit ed0e9bd into archlinux:master Apr 2, 2025
@codefiles

Copy link
Copy Markdown
Contributor

The package materia-gtk-theme is not a dependency or optional dependency of archinstall and does not belong in the PKGBUILD. @Torxed, the change here was not related to meta or group packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants