Repository navigation
Actually prevent installing if the config is invalid - #3335
Merged
svartkanin merged 1 commit intoApr 3, 2025
Merged
Conversation
Mintsuki
force-pushed
the
prevent-installing-invalid-config
branch
9 times, most recently
from
April 3, 2025 02:55
7d34e73 to
7ffec95
Compare
correctmost
reviewed
Apr 3, 2025
Mintsuki
force-pushed
the
prevent-installing-invalid-config
branch
from
April 3, 2025 04:53
7ffec95 to
595fd50
Compare
Contributor
Author
|
@correctmost thanks for the suggestion, this is much, much more elegant code than whatever I had before! |
Mintsuki
force-pushed
the
prevent-installing-invalid-config
branch
from
April 3, 2025 04:55
595fd50 to
cfbe69d
Compare
This also makes use of the previously unused _is_config_valid() method.
Mintsuki
force-pushed
the
prevent-installing-invalid-config
branch
from
April 3, 2025 04:59
cfbe69d to
0147a13
Compare
svartkanin
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also makes use of the previously unused _is_config_valid() method.