Skip to content

Fix 3362 - #3377

Merged
Torxed merged 1 commit into
archlinux:masterfrom
svartkanin:fix-3362
Apr 11, 2025
Merged

Torxed merged 1 commit into
archlinux:masterfrom
svartkanin:fix-3362

Conversation

@svartkanin

Copy link
Copy Markdown
Collaborator

No description provided.

@svartkanin
svartkanin marked this pull request as ready for review April 11, 2025 00:58
@svartkanin
svartkanin requested a review from Torxed as a code owner April 11, 2025 00:58
@Torxed
Torxed merged commit a842fb4 into archlinux:master Apr 11, 2025
@svartkanin

Copy link
Copy Markdown
Collaborator Author

@Torxed did it fix the problem?

@Torxed

Torxed commented Apr 12, 2025

Copy link
Copy Markdown
Member

I believe my error is elsewhere:

Traceback (most recent call last):
  File "/usr/bin/archinstall", line 5, in <module>
    from archinstall import run_as_a_module
  File "/usr/lib/python3.13/site-packages/archinstall/__init__.py", line 10, in <module>
    from archinstall.lib.args import arch_config_handler
  File "/usr/lib/python3.13/site-packages/archinstall/lib/args.py", line 421, in <module>
    arch_config_handler: ArchConfigHandler = ArchConfigHandler()
                                             ~~~~~~~~~~~~~~~~~^^
  File "/usr/lib/python3.13/site-packages/archinstall/lib/args.py", line 210, in __init__
    self._config = ArchConfig.from_config(config)
                   ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/usr/lib/python3.13/site-packages/archinstall/lib/args.py", line 137, in from_config
    arch_config.profile_config = ProfileConfiguration.parse_arg(profile_config)
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.13/site-packages/archinstall/lib/models/profile_model.py", line 36, in parse_arg
    from ..profile.profiles_handler import profile_handler
  File "/usr/lib/python3.13/site-packages/archinstall/lib/profile/__init__.py", line 1, in <module>
    from .profile_menu import ProfileMenu, select_greeter, select_profile
  File "/usr/lib/python3.13/site-packages/archinstall/lib/profile/profile_menu.py", line 11, in <module>
    from ..interactions.system_conf import select_driver
  File "/usr/lib/python3.13/site-packages/archinstall/lib/interactions/__init__.py", line 1, in <module>
    from .disk_conf import (
    ...<6 lines>...
    )
  File "/usr/lib/python3.13/site-packages/archinstall/lib/interactions/disk_conf.py", line 4, in <module>
    from archinstall.lib.args import arch_config_handler
ImportError: cannot import name 'arch_config_handler' from partially initialized module 'archinstall.lib.args' (most likely due to a circular import) (/usr/lib/python3.13/site-packages/archinstall/lib/args.py)

I haven't dug into this yet, but I suspect it has something to do with --config and --silent loading the config early during import, causing archinstall.lib.args to end up in a circular import.
As it only happens with --config (or in my case --config-url) and --silent.

@Val

Val commented Apr 26, 2025 •

Copy link
Copy Markdown

This works for me using root@archiso ~ # archinstall --verbose --config /tmp/config.json --silent

--- /usr/lib/python3.13/site-packages/archinstall/lib/interactions/disk_conf.py.orig	2025-04-26 15:20:43.821921757 +0000
+++ /usr/lib/python3.13/site-packages/archinstall/lib/interactions/disk_conf.py	2025-04-26 15:21:10.413966831 +0000
@@ -1,7 +1,6 @@
 from pathlib import Path
 from typing import TYPE_CHECKING
 
-from archinstall.lib.args import arch_config_handler
 from archinstall.lib.disk.device_handler import device_handler
 from archinstall.lib.disk.partitioning_menu import manual_partitioning
 from archinstall.lib.menu.menu_helper import MenuHelper

@Torxed

Torxed commented May 15, 2025

Copy link
Copy Markdown
Member

@Torxed did it fix the problem?

It did :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants