Skip to content

Split out Result and ResultType to break import cycle - #3387

Merged
svartkanin merged 1 commit into
archlinux:masterfrom
correctmost:cm/break-result-cycle
Apr 13, 2025
Merged

Split out Result and ResultType to break import cycle#3387
svartkanin merged 1 commit into
archlinux:masterfrom
correctmost:cm/break-result-cycle

Conversation

@correctmost

@correctmost correctmost commented Apr 12, 2025

Copy link
Copy Markdown
Contributor

PR Description:

Previously, there was an import cycle between tui.menu_item and tui.types:

archinstall/tui/menu_item.py: error: Cycle detected in import chain
  archinstall/tui/menu_item.py
  archinstall/tui/types.py (reportImportCycles)

@correctmost
Split out Result and ResultType to break import cycle
67e600e 
Previously, there was an import cycle between tui.menu_item and
tui.types.
@correctmost
correctmost requested a review from Torxed as a code owner April 12, 2025 08:45
correctmost
correctmost commented Apr 12, 2025
View reviewed changes
Comment thread archinstall/tui/types.py


@dataclass
class MenuCell:

@correctmost correctmost Apr 12, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MenuCell was unused

@svartkanin
svartkanin merged commit e281c2f into archlinux:master Apr 13, 2025
@correctmost
correctmost deleted the cm/break-result-cycle branch April 13, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svartkanin svartkanin svartkanin approved these changes
@Torxed Torxed Awaiting requested review from Torxed Torxed is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@correctmost @svartkanin