Repository navigation
Split out unicode_ljust and unicode_rjust to break import cycle - #3388
Merged
Merged
Conversation
svartkanin
approved these changes
Apr 13, 2025
svartkanin
reviewed
Apr 13, 2025
| @@ -0,0 +1,40 @@ | |||
| import unicodedata | |||
Collaborator
There was a problem hiding this comment.
@correctmost would it make sense to put this into the utils.py rather to avoid too many modules with utility functions?
Contributor
Author
There was a problem hiding this comment.
Adding the code to lib/utils/util.py will introduce a different cycle:
archinstall/lib/utils/util.py: error: Cycle detected in import chain
archinstall/lib/utils/util.py
archinstall/tui/curses_menu.py
archinstall/tui/result.py
archinstall/tui/menu_item.py (reportImportCycles)
Should I move lib/unicode.py to lib/utils/unicode.py to avoid some clutter at the top level?
Collaborator
There was a problem hiding this comment.
yeah lets move it in there that will do
Previously, there was an import cycle between tui.menu_item and lib.output.
correctmost
force-pushed
the
cm/break-unicode-cycle
branch
from
April 13, 2025 05:37
435f074 to
2c9126f
Compare
svartkanin
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
Previously, there was an import cycle between
tui.menu_itemandlib.output: