Repository navigation
.AUP importer - #11205
.AUP importer#11205
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA new Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Client
participant Au3Importer
participant LegacyAupImporter
participant TrackeditProject
Client->>Au3Importer: import(filePath)
Au3Importer->>Au3Importer: detect legacy .aup
Au3Importer->>LegacyAupImporter: resolve(filePath)
LegacyAupImporter-->>Au3Importer: Result(tracks, labelTracks)
Au3Importer->>TrackeditProject: add wave tracks, clips, and labels
Au3Importer-->>Client: success or failure
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Warning Review ran into problems🔥 ProblemsLinked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM. I'm sure there are people who would want more conversion features, but I think this should cover the vast majority. We can extend it later if there's enough demand for it. PRs welcome, of course! |
6e80eb3 to
affad1a
Compare
|
It works really well, with the only exception of being a bit too slow when opening large projects, and even more so when closing them. Don't mind this being merged as is, though. |
A basic importer for .AUP which bypasses legacy architecture by letting libsndfile do stuff instead. It only gets you the wavedata and labels right now, not envelopes or any of the other stuff (though it appears that was brittle previously, too, #1643) – and I'm not sure I care too much about those advanced features, anyway.
Recommended:
QA: