You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After migrating To PMD 7.1.0, it caught new violations in our Codebase (#14856 (comment)). We should investigate this list and fix all violations if they are valid. if a violation is a false positive it should be reported to PMD
@romani the PR fixes few violations from the issue there are other violations that are left to be investigated either they will be remained suppressed after proper investigation of weather they are false positive or will be resolved .
Please reopen the issue
Investigating which are the violations that should remain suppressed will update the comment to mention why they will remain suppressed and will resolve all in the next PR, working on it.
Activity
romani commentedon May 9, 2024
Please inline violations in text format, not xml. It much easier to read for humans.
Issue checkstyle#14870: Fix PMD violations UnnecessaryVarargsArrayCreβ¦
Issue #14870: Fix PMD violations UnnecessaryVarargsArrayCreation, Conβ¦
romani commentedon Feb 16, 2026
Fix is merged
vivek-0509 commentedon Feb 16, 2026
@romani the PR fixes few violations from the issue there are other violations that are left to be investigated either they will be remained suppressed after proper investigation of weather they are false positive or will be resolved .
Please reopen the issue
Youssefalaa7 commentedon Feb 16, 2026
https://github.com/Youssefalaa7/checkstyle/blob/4fffb488d1d2bac55a5928d89765e36ee7190f2b/config/pmd-test.xml#L100C1-L104C75
There are still many comments referencing this closed issue causing
Check no closed issue references / check_issues (pull_request) to fail
so i think it is not finished yet and need to be reopened
vivek-0509 commentedon Feb 16, 2026
Investigating which are the violations that should remain suppressed will update the comment to mention why they will remain suppressed and will resolve all in the next PR, working on it.
romani commentedon Feb 16, 2026
Issue is reopened, as there more to fix, remove all references to this issue from code
Issue checkstyle#14870: Fix PMD suppressions in pmd.xml
Issue checkstyle#14870: Fix PMD suppressions in pmd.xml
9 remaining items
Issue checkstyle#14870: Fix PMD violations CommitValidationTest
Issue #14870: pmd false postive cleanup
Issue checkstyle#14870: pmd false postive cleanup
romani commentedon May 11, 2026
there ate still 3 places where suppression still present https://github.com/checkstyle/checkstyle/blob/master/config/pmd-test.xml
Issue checkstyle#14870: Fix PMD 7.1.0 Violations
Issue checkstyle#14870: Fix PMD 7.1.0 Violations
Issue checkstyle#14870: Fix PMD 7.1.0 Violations
Issue checkstyle#14870: Fix PMD 7.1.0 Violations
Issue #14870: Fix PMD 7.1.0 Violations
romani commentedon Sep 8, 2026
Fix is merged