Skip to content

Fix PMD 7.1.0 ViolationsΒ #14870

Closed
Closed

Description

@mahfouz72

After migrating To PMD 7.1.0, it caught new violations in our Codebase (#14856 (comment)). We should investigate this list and fix all violations if they are valid. if a violation is a false positive it should be reported to PMD

the suppressions were added in 5a1f41e
List of violations: https://gist.github.com/mahfouz72/d199fca33ce2c9e8d84be3882403093c

we should split down the list to make the fix easier so a few PRs are fine


Investigate #14870 (comment) about package private scope of visibility

Activity

  1. romani commented on May 9, 2024

    @romani
    Member

    Please inline violations in text format, not xml. It much easier to read for humans.

  2. added a commit that references this issue on Feb 16, 2026
  3. added a commit that references this issue on Feb 16, 2026
  4. romani commented on Feb 16, 2026

    @romani
    Member

    Fix is merged

  5. added this to the 13.3.0 milestone on Feb 16, 2026
  6. vivek-0509 commented on Feb 16, 2026

    @vivek-0509
    Member

    @romani the PR fixes few violations from the issue there are other violations that are left to be investigated either they will be remained suppressed after proper investigation of weather they are false positive or will be resolved .
    Please reopen the issue

  7. Youssefalaa7 commented on Feb 16, 2026

    @Youssefalaa7
    Contributor

    https://github.com/Youssefalaa7/checkstyle/blob/4fffb488d1d2bac55a5928d89765e36ee7190f2b/config/pmd-test.xml#L100C1-L104C75
    There are still many comments referencing this closed issue causing
    Check no closed issue references / check_issues (pull_request) to fail
    so i think it is not finished yet and need to be reopened

  8. vivek-0509 commented on Feb 16, 2026

    @vivek-0509
    Member

    Investigating which are the violations that should remain suppressed will update the comment to mention why they will remain suppressed and will resolve all in the next PR, working on it.

  9. reopened this on Feb 16, 2026
  10. romani commented on Feb 16, 2026

    @romani
    Member

    Issue is reopened, as there more to fix, remove all references to this issue from code

  11. added 2 commits that reference this issue on Feb 21, 2026
  12. 9 remaining items

  13. added a commit that references this issue on Apr 8, 2026
  14. added a commit that references this issue on Apr 11, 2026
  15. modified the milestones: 13.3.0, 13.4.1 on Apr 11, 2026
  16. added a commit that references this issue on Apr 20, 2026
  17. romani commented on May 11, 2026

    @romani
    Member

    there ate still 3 places where suppression still present https://github.com/checkstyle/checkstyle/blob/master/config/pmd-test.xml

  18. added 4 commits that reference this issue on Sep 6, 2026
  19. added a commit that references this issue on Sep 8, 2026
  20. modified the milestones: 13.4.1, 14.1.1 on Sep 8, 2026
  21. romani commented on Sep 8, 2026

    @romani
    Member

    Fix is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions