Repository navigation
docker: load the supplied daemon configuration on Windows - #1408
Merged
Merged
Conversation
Windows dockerd resolves its default configuration path relative to the configured data root. The setup script wrote daemon.json under ProgramData while using a different data root, so the supplied settings were ignored. Write the configuration in the runtime directory and pass its quoted path explicitly through --config-file. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-windows-daemon-config
branch
from
November 4, 2026 14:49
5b1f6af to
483424a
Compare
vvoland
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows Docker installations silently ignoring the supplied daemon configuration. The setup script writes
daemon.jsonunder%ProgramData%\Docker\config, but starts dockerd with a custom--data-root. On Windows, dockerd resolves its default configuration path relative to that data root. This change writes the configuration in the runtime directory and passes its path explicitly through--config-file.This surfaced while adding Windows e2e coverage in docker/buildx#4187, which uses
setup-docker-actionto exercise the embedded containerd and BuildKit configuration used by Docker Desktop.