Repository navigation
ol-button: href links, ghost variant, icon/circle shapes, floating elevation - #13347
Merged
Merged
Conversation
…g elevation - href renders an <a> with identical styling (target/rel/download pass through); disabled/loading drop the href and set aria-disabled. Selectors move from `> button` to `> :is(button, a)`, and the link form out-ranks the global a:link/a:visited underline. - variant="ghost": no fill, border, or lift at rest; neutral hover fill. - shape="icon" | "circle": square on the size's control height (via a new --ol-button-height custom property), no horizontal padding. - elevation="floating": heavier drop shadow via a new --box-shadow-floating token, for controls that sit over content. - Design page examples for each, plus jest coverage of the rendering contract. Claude-Session: https://claude.ai/code/session_0181hgjqkv2tyxa8XJi3v78y
lokesh
marked this pull request as ready for review
August 17, 2026 17:34
RayBB
approved these changes
Aug 17, 2026
RayBB
left a comment
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
A small but mighty improvement. Working very well and looks great. Ship it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature — extends
<ol-button>with what the in-progress book actions popover work (#13346) needs, so those surfaces stop hand-rolling button features.All four are standard button-component conventions (link buttons, ghost, icon-only, elevation) rather than anything novel to OL, so nothing here should be contentious.
hrefrenders an<a>with identical styling (target/rel/downloadpass through). For button-shaped navigation like Read / Borrow.variant="ghost"— no fill, border, or lift at rest; neutral hover fill.shape="icon"/shape="circle"— icon-only, square on the size's control height.elevation="floating"— heavier drop shadow (new--box-shadow-floatingtoken) for controls sitting over content, e.g. a save button on cover art.Note
Low risk: nothing in the codebase uses these yet — this only adds attributes and CSS rules to the existing component.
Screenshots
See above.
Also, here is a scenario where these features can be utilized:
add-popover.mp4
Testing
/developers/design/components#buttonhas examples for each addition.npx jest tests/unit/js/OLButton.test.jscovers the button ↔ link rendering contract.Stakeholders
@cdrini @mekarpeles