Repository navigation
Document the button-order convention - #13750
Merged
lokesh merged 1 commit intoOct 5, 2026
Merged
Conversation
Dialogs put the primary action on the right; page forms put it on the left, aligned with the inputs. Both are deliberate, but the rule was not written down anywhere, so the difference read as a bug in internetarchive#13728. Wording from @lokesh in that thread.
Collaborator
|
Thanks for the PR, @MohitSAGAR11! A reviewer must first be assigned. There are currently 109 open PRs of equal or higher priority ahead of yours. PR triage checklist (maintainers / Pierre)
Note This comment was automatically generated by Pierre, Open Library's PR first-touch assistant, on behalf of @mekarpeles. This is NOT a code review or sign-off. |
Collaborator
|
Thanks @MohitSAGAR11 π |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #13728 β the documentation half. The merge-dialog work @lokesh
described in that thread follows separately.
@lokesh explained in #13728 that dialogs and page forms use different button
orders on purpose, and that the rule was not written down. This writes it into
docs/ai/design.mdso the difference stops reading as a bug.Technical
Wording is @lokesh's from the issue thread, with the
olConfirm()and/developers/designreferences added as concrete anchors.Testing
Docs only β no code paths touched.
Stakeholders
@lokesh