Skip to content

Document the button-order convention - #13750

Merged
lokesh merged 1 commit into
internetarchive:masterfrom
MohitSAGAR11:13728/docs/button-order
Oct 5, 2026
Merged

lokesh merged 1 commit into
internetarchive:masterfrom
MohitSAGAR11:13728/docs/button-order

Conversation

@MohitSAGAR11

@MohitSAGAR11 MohitSAGAR11 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Part of #13728 β€” the documentation half. The merge-dialog work @lokesh
described in that thread follows separately.

@lokesh explained in #13728 that dialogs and page forms use different button
orders on purpose, and that the rule was not written down. This writes it into
docs/ai/design.md so the difference stops reading as a bug.

Technical

Wording is @lokesh's from the issue thread, with the olConfirm() and
/developers/design references added as concrete anchors.

Testing

Docs only β€” no code paths touched.

Stakeholders

@lokesh

Dialogs put the primary action on the right; page forms put it on the left, aligned with the inputs. Both are deliberate, but the rule was not written down anywhere, so the difference read as a bug in internetarchive#13728.

Wording from @lokesh in that thread.
@openlibrary-bot

Copy link
Copy Markdown
Collaborator

Thanks for the PR, @MohitSAGAR11!

A reviewer must first be assigned. There are currently 109 open PRs of equal or higher priority ahead of yours.

PR triage checklist (maintainers / Pierre)
  • PR description β€” not empty; explains what the change does and how to verify it
  • References an issue β€” PR body contains a #NNN reference
    • Linked issue is triaged β€” has a Priority: * label (not just Needs: Triage)
    • Linked issue is assigned β€” has at least one assignee
  • Commit history clean β€” no WIP/fixup/conflict noise; commit messages are meaningful
  • CI passing β€” no failing check-runs
  • Test cases present β€” if the change touches substantive logic, test coverage exists or is explained
  • Proof of testing β€” PR body includes a description of what was tested, a screenshot, or a video

Note

This comment was automatically generated by Pierre, Open Library's PR first-touch assistant, on behalf of @mekarpeles. This is NOT a code review or sign-off.

@lokesh
lokesh merged commit eba9c4f into internetarchive:master Oct 5, 2026
5 checks passed
@lokesh

lokesh commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks @MohitSAGAR11 πŸ™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants