Repository navigation
nginx snippets: make GET public, keep writes archive.org-only - #13949
Merged
Merged
Conversation
GET /api/snippets was 403'd for openlibrary.org (same-origin GET sends no Origin, so the blanket origin gate rejected it). Gate only writes now: - GET/OPTIONS: unrestricted (BookReader, openlibrary.org, etc.) - POST/PUT: archive.org origin required ($snippets_deny_write) - DELETE: 405 (unchanged) CORS Allow-Origin echoed for archive.org + openlibrary.org. Verified with nginx + iannotate across origins/methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nginx snippets: make GET public, keep writes archive.org-only
GET /api/snippetscurrently 403s when called from openlibrary.org: a same-origin GET sends noOriginheader, so the blanketif ($snippets_bad_origin) return 403rejects it. (BookReader works only because it's cross-origin and sendsOrigin: archive.org.)This gates writes only, leaving reads public:
archive.orgorigin ($snippets_deny_write=POST/PUT× non-archive.org).405(unchanged).Access-Control-Allow-Originechoed for*.archive.organd*.openlibrary.orgso cross-origin browser reads from both work.iannotate already serves GET to anyone — this is purely the nginx gate, no app change.
Tested (nginx + iannotate, sqlite, across origins/methods)
GET archive.org/openlibrary.org/no-origin →
200(+ matching CORS header); GET from an unlisted origin →200read but no CORS header; POST/PUT archive.org →200; POST/PUT openlibrary.org or no-origin →403; DELETE →405.nginx -tpasses.