[ovatonne]

Fixes #6221.

[Copilot]

Pull request overview

This PR performs a small cleanup in the std::expected test suite to better label the coverage for LWG-4026 (“Assignment operators of std::expected should propagate triviality”) by moving the explanatory comment to the helper function that encapsulates those checks.

Changes:

• Remove an inline “per LWG-4026 …” comment near the TrivialityTester machinery.
• Add a dedicated LWG-4026 header comment immediately above test_triviality_of_assignment_all().
• Remove the call-site trailing comment for test_triviality_of_assignment_all() to reduce noise in test_all().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[A. Jiang (frederick-vs-ja)]

Thanks!

…opagate triviality (#6221)

You can and should use Fixes #6221 or something like to associate this PR with the issue to be fixed. See GitHub's close/fix/resolve syntax.

Also, please fix the PR title. GitHub automatically truncates the first line of the commit message if it's too long when using it as the defaulted PR title. In this case of this PR, IMO you should fix the title, but should also drop the issue number.

[ovatonne]

Thank you for your time on this!

You can and should use Fixes #6221

I though I correctly copied what I saw on the repo, but I absolutely didn't.

Also, please fix the PR title.

I hope it is ok now, even though it still is a long title for little changes ^^

[Stephan T. Lavavej (StephanTLavavej)]

Thanks! Title is great now.

We merge PRs to our GitHub and MSVC-internal repos simultaneously in a semi-manual process, batched up to save time. Your PR will be part of the next batch. I'll post comments as I prepare your PR for merging; no action is required from you.

[Stephan T. Lavavej (StephanTLavavej)]

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

[Stephan T. Lavavej (StephanTLavavej)]

Thanks for cleaning this up and congratulations on your first microsoft/STL commit! 😻

FYI, your commit showed up as "co-authored-by", which I believe indicates that you haven't configured your GitHub profile to be linked to the email address that you're marking your commits with. (For example, my GitHub profile is set up with my personal email as primary, and my work emails as secondary addresses.)