Repository navigation
<xcharconv_ryu.h>: Remove VSO-1918426 workaround for missing <intrin0.h> parts - #6282
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoMay 15, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an architecture-specific workaround in the Ryu-based <charconv> implementation and standardizes the intrinsics include to consistently use _STL_INTRIN_HEADER (as defined in yvals_core.h).
Changes:
- Removed the ARM64/ARM64EC/_M_HYBRID_X86_ARM64 special-case
#include <intrin.h>workaround. - Always includes
_STL_INTRIN_HEADERwhen_HAS_CHARCONV_INTRINSICSis enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 14, 2026
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
Stephan T. Lavavej (StephanTLavavej)
moved this from Ready To Merge
to Merging
in STL Code Reviews
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
changed the title
<xcharconv_ryu.h>: Remove VSO-1918426 workaround for missing <intrin0.h> parts<xcharconv_ryu.h>: Remove VSO-1918426 workaround for missing <intrin0.h> parts
Stephan T. Lavavej (StephanTLavavej)
merged commit May 15, 2026
684ff48
into
microsoft:main
52 of 53 checks passed
Member
🧹 😻 🪄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6281 (comment)