Repository navigation
Further cleanup of vectorized minmax_element - #6459
Merged
Stephan T. Lavavej (StephanTLavavej) merged 9 commits intoOct 1, 2026
Merged
Stephan T. Lavavej (StephanTLavavej) merged 9 commits into
Stephan T. Lavavej (StephanTLavavej) merged 9 commits into
Conversation
Alex Guteniev (AlexGuteniev)
requested a review
from a team
as a code owner
September 21, 2026 17:17
Contributor
Author
|
I'd like to have one more cleanup here to get rid of this STL/stl/src/vector_algorithms.cpp Lines 3259 to 3260 in 85f13f3 I think that would go to a separate PR. |
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
added
the
enhancement
…aits::_Unsigned_t` is `void` for floating-point.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 23, 2026
Stephan T. Lavavej (StephanTLavavej)
moved this from Initial Review
to Ready To Merge
in STL Code Reviews
It will go without sign correction. Very minor perf change of an unimportant case, but I want the traits to be honest
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 25, 2026
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Oct 1, 2026
b0459ef
into
microsoft:main
48 checks passed
Member
🪄 🧹 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6450
Reduce oddness of
minmax_element:_Has_unsigned_cmp. Which may become true for x64 & x86 too, if we make use of AVX-512numeric_limitsinstead of having initialization values from traitsis_floating_point_vinstead of propagating this information via traits