Repository navigation
fix(fetch): preserve abort propagation after garbage collection - #6070
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6070 +/- ##
==========================================
+ Coverage 91.58% 91.63% +0.04%
==========================================
Files 113 113
Lines 44001 43973 -28
==========================================
- Hits 40298 40294 -4
+ Misses 3703 3679 -24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Copied and cloned requests can lose cancellation after garbage collection because their signals do not keep forwarding controllers alive. Native AbortSignal composition can retain finalization records while a long-lived source survives on supported Node.js versions. For 5,000 constructor copies of one retained parent, Node 24.20.0 / V8 13.6.233.17-node.53 improves from 35.37 us to 0.83 us per copy. Two fresh processes use 50,000 warm-up operations and seven trials, discarding the fastest and slowest. Fixes: #4068 Refs: nodejs/node#62363 Signed-off-by: Ruben Bridgewater <ruben.bridgewater@datadoghq.com>
BridgeAR
force-pushed
the
BridgeAR/2026-10-21-abort-signal-gc
branch
from
October 22, 2026 08:15
ab719df to
1b5ff84
Compare
BridgeAR
marked this pull request as ready for review
October 22, 2026 11:08
metcoder95
approved these changes
Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied and cloned requests can lose cancellation after garbage collection because their signals do not keep the controllers that forward aborts alive.
Fixes: #4068