Repository navigation
fix(h2): preserve accepted streams with deferred ids - #6090
Merged
Merged
Conversation
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6090 +/- ##
==========================================
- Coverage 91.61% 91.60% -0.01%
==========================================
Files 113 113
Lines 44044 44043 -1
==========================================
- Hits 40351 40346 -5
- Misses 3693 3697 +4 β View full report in Codecov by Harness. π New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #6089
Rationale
bindRequestToStream()cachesstream.idbefore a pending stream has necessarily received an ID. When GOAWAY later includes that stream's assigned ID, the cachedundefinedmakes Undici reject an accepted response.Read the live stream ID when GOAWAY arrives. This follows the existing
Http2Stream.idcontract without adding runtime-specific behavior.Changes
Bug Fixes
Features
N/A
Breaking Changes and Deprecations
None.
Validation
046bb4c6withUND_ERR_INFOand pass with this change.npm run test:h2: 147 core tests and 14 Fetch tests pass on Node v24.22.1.npm run lintpasses.The full repository test suite and other operating systems were not run.
Status