Repository navigation
perf: Remove repeated keys from by's - #30095
Merged
Merged
Conversation
orlp
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
ritchie46
as code owners
October 20, 2026 12:24
Collaborator
|
issue (non-blocking): seems like there are some missed optimization opportunities because we run the new rule after sort-collapsing. Here are these cases, as detected by AI |
dancsi
approved these changes
Oct 22, 2026
dsprenkels
approved these changes
Oct 22, 2026
dsprenkels
left a comment
Collaborator
There was a problem hiding this comment.
nit: I'd make expand_flags() move-based instead of mutably updating the sort_options in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies
.sort(["a", "a"])to just.sort("a").Also fixes #30081.
Also fixes #30209.
Also includes a simplification pass - we now require the
MultipleSortOptionsare expanded in the planner.Generated mostly with AI, verified by me.