You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
when building the extensions, stdout is lost when stdout is redirectedΒ #59796
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee=Noneclosed_at=<Date2012-09-06.23:20:46.325>created_at=<Date2012-08-08.10:52:57.205>labels= ['type-bug', 'build']
title='when building the extensions, stdout is lost when stdout is redirected'updated_at=<Date2012-09-07.00:27:24.428>user='https://github.com/doko42'
I see this on all Debian and Ubuntu releases, when stdout is redirected. I expect to see the compiler and linker invocations for the sharedmods target, but I only see stderr (compiler and linker warnings).
e.g. make 2>&1 | tee log
or script -c 'make' log
can this be reproduced on Debian/Ubuntu, or is this seen on other Linux distributions as well?
bah, this happens when you do a parallel build. --jobserver-fds is passed in MAKEFLAGS, and the test for sharedmods turns on the quiet mode, because it matches just *s* in MAKEFLAGS :-/
The patch tries to parse MAKEFLAGS using getopt, and if getopt is not available, falls back to MAKEFLAGS, and then tries to match -s.
The only downside is that you won't get a quiet build, if you don't have getopt, and pass MAKEFLAGS options as a combined option (e.g. -fs).
python-dev commented on Aug 28, 2012
python-devmannequin
Mannequin
More actions
New changeset 1a1d097b17e2 by Matthias Klose in branch '2.7':
even if you pass other options to make, and -s not as the first flag? and does this work for other makes different than GNU make too? But maybe we already require GNU make.
The lines under each of my examples are the content of $MAKEFLAGS. It works when I pass the option in a different order and even with alternative spellings for -s like --quiet. It's always the "s" flag:
$ make -s --jobs=4
"s --jobserver-fds=3,4 -j"
$ make --jobs=4 --silent
"s --jobserver-fds=3,4 -j"
$ make --jobs=4 --quiet
"s --jobserver-fds=3,4 -j"
$ make --jobs=4 --quiet -n
echo'"sn --jobserver-fds=3,4 -j"'
With just the -j flag $MAKEFLAGS starts with a space so the first word is empty:
$ make -j4
" --jobserver-fds=3,4 -j"
I don't know if other make implementations work similar but I think we require GNU Make, too.
Activity
doko42 commentedon Aug 8, 2012
I see this on all Debian and Ubuntu releases, when stdout is redirected. I expect to see the compiler and linker invocations for the sharedmods target, but I only see stderr (compiler and linker warnings).
e.g. make 2>&1 | tee log
or script -c 'make' log
can this be reproduced on Debian/Ubuntu, or is this seen on other Linux distributions as well?
doko42 commentedon Aug 28, 2012
bah, this happens when you do a parallel build. --jobserver-fds is passed in MAKEFLAGS, and the test for sharedmods turns on the quiet mode, because it matches just *s* in MAKEFLAGS :-/
The patch tries to parse MAKEFLAGS using getopt, and if getopt is not available, falls back to MAKEFLAGS, and then tries to match -s.
The only downside is that you won't get a quiet build, if you don't have getopt, and pass MAKEFLAGS options as a combined option (e.g. -fs).
python-dev commentedon Aug 28, 2012
New changeset 1a1d097b17e2 by Matthias Klose in branch '2.7':
http://hg.python.org/cpython/rev/1a1d097b17e2
New changeset 763d188a96bb by Matthias Klose in branch '3.2':
http://hg.python.org/cpython/rev/763d188a96bb
New changeset 3a3fd48a6ef7 by Matthias Klose in branch 'default':
http://hg.python.org/cpython/rev/3a3fd48a6ef7
doko42 commentedon Aug 28, 2012
fixed.
benjaminp commentedon Aug 28, 2012
This seems to have broken parallel building of modules.
tiran commentedon Sep 6, 2012
The fix doesn't work for me. With "make -s" I still see the output to stdout. Also there are much simpler ways to test for MAKEFLAGS:
ifneq (,$(findstring s,$(MAKEFLAGS)))
QUIET="-q"
else
QUIET=""
endif
then use $(QUIET) in the call to setup.py
doko42 commentedon Sep 6, 2012
@benjamin: no, the extensions were never built in parallel
@christian: no, that again would match the `s' when you have something like --jobserver in MAKEFLAGS.
tiran commentedon Sep 6, 2012
Ah, got it. GNU sorts the arguments in MAKEFLAGS. The "s" flag is always in the first word.
This make code works well for me:
ifeq (s,$(findstring s,$(word 1,$(MAKEFLAGS))))
QUIET=-q
else
QUIET=
endif
I've attached a patch that also fixes the quiet option for ctypes configure script.
doko42 commentedon Sep 6, 2012
even if you pass other options to make, and -s not as the first flag? and does this work for other makes different than GNU make too? But maybe we already require GNU make.
tiran commentedon Sep 6, 2012
The lines under each of my examples are the content of $MAKEFLAGS. It works when I pass the option in a different order and even with alternative spellings for -s like --quiet. It's always the "s" flag:
With just the -j flag $MAKEFLAGS starts with a space so the first word is empty:
$ make -j4 " --jobserver-fds=3,4 -j"I don't know if other make implementations work similar but I think we require GNU Make, too.
python-dev commentedon Sep 6, 2012
New changeset 048e13546a7c by Christian Heimes in branch '3.2':
Issue bpo-15591: run ctypes' configure in quiet mode when setup.py runs silently
http://hg.python.org/cpython/rev/048e13546a7c
New changeset e5569b03a287 by Christian Heimes in branch 'default':
Issue bpo-15591: run ctypes' configure in quiet mode when setup.py runs silently
http://hg.python.org/cpython/rev/e5569b03a287
New changeset 962e8b2a39f3 by Christian Heimes in branch '2.7':
Issue bpo-15591: run ctypes' configure in quiet mode when setup.py runs silently
http://hg.python.org/cpython/rev/962e8b2a39f3
python-dev commentedon Sep 6, 2012
New changeset b9261dd34289 by Christian Heimes in branch '3.2':
Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
http://hg.python.org/cpython/rev/b9261dd34289
New changeset fcc629208842 by Christian Heimes in branch 'default':
Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
http://hg.python.org/cpython/rev/fcc629208842
New changeset 2587aeb616b6 by Christian Heimes in branch '2.7':
Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
http://hg.python.org/cpython/rev/2587aeb616b6
New changeset 4807ed8a627e by Christian Heimes in branch 'default':
Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
http://hg.python.org/cpython/rev/4807ed8a627e
python-dev commentedon Sep 7, 2012
New changeset 8cd6acffbcb9 by Christian Heimes in branch '2.7':
Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
http://hg.python.org/cpython/rev/8cd6acffbcb9