Skip to content

when building the extensions, stdout is lost when stdout is redirectedΒ #59796

Closed

Description

@doko42
BPO 15591
Nosy @warsaw, @brettcannon, @doko42, @tiran, @benjaminp
Files
  • makeflags.diff
  • quiet.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2012-09-06.23:20:46.325>
    created_at = <Date 2012-08-08.10:52:57.205>
    labels = ['type-bug', 'build']
    title = 'when building the extensions, stdout is lost when stdout is redirected'
    updated_at = <Date 2012-09-07.00:27:24.428>
    user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2012-09-07.00:27:24.428>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2012-09-06.23:20:46.325>
    closer = 'christian.heimes'
    components = ['Build']
    creation = <Date 2012-08-08.10:52:57.205>
    creator = 'doko'
    dependencies = []
    files = ['27034', '27136']
    hgrepos = []
    issue_num = 15591
    keywords = ['patch']
    message_count = 13.0
    messages = ['167684', '169287', '169288', '169289', '169306', '169917', '169919', '169920', '169921', '169922', '169927', '169953', '169960']
    nosy_count = 7.0
    nosy_names = ['barry', 'brett.cannon', 'doko', 'christian.heimes', 'benjamin.peterson', 'Arfrever', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue15591'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

    Activity

    1. doko42 commented on Aug 8, 2012

      @doko42
      MemberAuthor

      I see this on all Debian and Ubuntu releases, when stdout is redirected. I expect to see the compiler and linker invocations for the sharedmods target, but I only see stderr (compiler and linker warnings).

      e.g. make 2>&1 | tee log
      or script -c 'make' log

      can this be reproduced on Debian/Ubuntu, or is this seen on other Linux distributions as well?

    2. added
      buildThe build process and cross-build
      type-bugAn unexpected behavior, bug, or error
      on Aug 8, 2012
    3. doko42 commented on Aug 28, 2012

      @doko42
      MemberAuthor

      bah, this happens when you do a parallel build. --jobserver-fds is passed in MAKEFLAGS, and the test for sharedmods turns on the quiet mode, because it matches just *s* in MAKEFLAGS :-/

      The patch tries to parse MAKEFLAGS using getopt, and if getopt is not available, falls back to MAKEFLAGS, and then tries to match -s.

      The only downside is that you won't get a quiet build, if you don't have getopt, and pass MAKEFLAGS options as a combined option (e.g. -fs).

    4. python-dev commented on Aug 28, 2012

      python-devmannequin
      Mannequin

      New changeset 1a1d097b17e2 by Matthias Klose in branch '2.7':

      New changeset 763d188a96bb by Matthias Klose in branch '3.2':

      New changeset 3a3fd48a6ef7 by Matthias Klose in branch 'default':

    5. doko42 commented on Aug 28, 2012

      @doko42
      MemberAuthor

      fixed.

    6. benjaminp commented on Aug 28, 2012

      @benjaminp
      Contributor

      This seems to have broken parallel building of modules.

    7. tiran commented on Sep 6, 2012

      @tiran
      Member

      The fix doesn't work for me. With "make -s" I still see the output to stdout. Also there are much simpler ways to test for MAKEFLAGS:

      ifneq (,$(findstring s,$(MAKEFLAGS)))
      QUIET="-q"
      else
      QUIET=""
      endif

      then use $(QUIET) in the call to setup.py

    8. reopened this on Sep 6, 2012
    9. doko42 commented on Sep 6, 2012

      @doko42
      MemberAuthor

      @benjamin: no, the extensions were never built in parallel

      @christian: no, that again would match the `s' when you have something like --jobserver in MAKEFLAGS.

    10. tiran commented on Sep 6, 2012

      @tiran
      Member

      Ah, got it. GNU sorts the arguments in MAKEFLAGS. The "s" flag is always in the first word.

      $ make -j4 -s
      "s --jobserver-fds=3,4 -j"
      
      $ make --quiet -j4
      "s --jobserver-fds=3,4 -j"

      This make code works well for me:

      ifeq (s,$(findstring s,$(word 1,$(MAKEFLAGS))))
      QUIET=-q
      else
      QUIET=
      endif

      I've attached a patch that also fixes the quiet option for ctypes configure script.

    11. doko42 commented on Sep 6, 2012

      @doko42
      MemberAuthor

      even if you pass other options to make, and -s not as the first flag? and does this work for other makes different than GNU make too? But maybe we already require GNU make.

    12. tiran commented on Sep 6, 2012

      @tiran
      Member

      The lines under each of my examples are the content of $MAKEFLAGS. It works when I pass the option in a different order and even with alternative spellings for -s like --quiet. It's always the "s" flag:

      $ make -s --jobs=4
      "s --jobserver-fds=3,4 -j"
      
      $ make  --jobs=4 --silent
      "s --jobserver-fds=3,4 -j"
      
      $ make  --jobs=4 --quiet
      "s --jobserver-fds=3,4 -j"
      
      $ make  --jobs=4 --quiet -n
      echo '"sn --jobserver-fds=3,4 -j"'

      With just the -j flag $MAKEFLAGS starts with a space so the first word is empty:

      $ make -j4
      " --jobserver-fds=3,4 -j"

      I don't know if other make implementations work similar but I think we require GNU Make, too.

    13. python-dev commented on Sep 6, 2012

      python-devmannequin
      Mannequin

      New changeset 048e13546a7c by Christian Heimes in branch '3.2':
      Issue bpo-15591: run ctypes' configure in quiet mode when setup.py runs silently
      http://hg.python.org/cpython/rev/048e13546a7c

      New changeset e5569b03a287 by Christian Heimes in branch 'default':
      Issue bpo-15591: run ctypes' configure in quiet mode when setup.py runs silently
      http://hg.python.org/cpython/rev/e5569b03a287

      New changeset 962e8b2a39f3 by Christian Heimes in branch '2.7':
      Issue bpo-15591: run ctypes' configure in quiet mode when setup.py runs silently
      http://hg.python.org/cpython/rev/962e8b2a39f3

    14. python-dev commented on Sep 6, 2012

      python-devmannequin
      Mannequin

      New changeset b9261dd34289 by Christian Heimes in branch '3.2':
      Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
      http://hg.python.org/cpython/rev/b9261dd34289

      New changeset fcc629208842 by Christian Heimes in branch 'default':
      Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
      http://hg.python.org/cpython/rev/fcc629208842

      New changeset 2587aeb616b6 by Christian Heimes in branch '2.7':
      Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
      http://hg.python.org/cpython/rev/2587aeb616b6

      New changeset 4807ed8a627e by Christian Heimes in branch 'default':
      Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
      http://hg.python.org/cpython/rev/4807ed8a627e

    15. python-dev commented on Sep 7, 2012

      python-devmannequin
      Mannequin

      New changeset 8cd6acffbcb9 by Christian Heimes in branch '2.7':
      Issue bpo-15591 and Issue bpo-11715: silence output of setup.py when make is run with -s option.
      http://hg.python.org/cpython/rev/8cd6acffbcb9

    16. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions