Repository navigation
OTP29 support - #242
Merged
Merged
OTP29 support#242
Conversation
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
mkuratczyk
marked this pull request as draft
October 12, 2026 15:28
'catch Expr' is deprecated, and record() is now a built-in type.
Dialyzer can see it now that read_header0/1 is no longer wrapped in catch.
Funs defined in the suite can't be called on a peer running a different OTP version (badfun), which prevented running the whole suite in mixed OTP mode.
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently address mixed-OTP execution and compatibility without identified unresolved defects.
0 open findings
What changed in this PR
Adds OTP 29 and mixed-version cluster support while preventing cross-node anonymous-fun failures.
Changes:
- Updates CI and test dependencies for OTP 27–29.
- Adds mixed-OTP testing and remote writer-sequence coverage.
- Refines OTP 29 compatibility warnings and exception handling.
| File | Description |
|---|---|
.github/​workflows/​erlang.yml |
Tests OTP 27–29. |
.github/​workflows/​mixed-otp.yml |
Adds mixed-OTP CI matrix. |
Makefile |
Updates test dependencies. |
src/​osiris.erl |
Safely queries remote writer sequences. |
src/​osiris.hrl |
Modernizes logger exception handling. |
src/​osiris_log.erl |
Resolves type and catch warnings. |
src/​osiris_util.erl |
Simplifies base64 URI validation. |
src/​osiris_writer.erl |
Narrows batch exception handling. |
test/​osiris_SUITE.erl |
Adds remote coverage and MFA peer helpers. |
🧠Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kjnilsson
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetch_writer_seq