Repository navigation
Avoid race condition when sending snapshot. - #619
Merged
Merged
Conversation
When the snapshot is deleted midway through it may end up with an empty live indexes accidentally which it treats as a valid value and snapshot send completes without sending any live indexes. Logging tweaks
kjnilsson
force-pushed
the
send-snapshot-race-cond
branch
from
April 15, 2026 10:40
f897870 to
5a63636
Compare
mkuratczyk
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the snapshot is deleted midway through it may end up with
an empty live indexes accidentally which it treats as a valid
value and snapshot send completes without sending any live
indexes.
Logging tweaks