Repository navigation
Fix file handle leak in ra_flru:evict_all - #623
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes ra_flru:evict_all/1 so it returns a properly preserved cache state (including max_size and handler) after evicting all items, preventing downstream callers from unintentionally resetting the handler/max size and leaking resources.
Changes:
- Update
evict_all/1to return an updated copy of the original state rather than constructing a fresh record with onlyitems = []. - Extend the existing EUnit test to assert
evict_all/1preservesmax_sizeandhandler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kjnilsson
marked this pull request as ready for review
April 21, 2026 13:43
mkuratczyk
approved these changes
Apr 21, 2026
mkuratczyk
left a comment
mkuratczyk
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Looks like that's the one indeed - previously I saw FDs leaking within 10-15 minutes of starting the workload, now it's been 40 minutes and no unexpected FDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.